WebKit-https.git
13 years agoWebKitTools:
beidson@apple.com [Wed, 13 Feb 2008 18:47:14 +0000 (18:47 +0000)]
WebKitTools:

        Reviewed by Darin Adler

        Add some much needed Database support to DRT

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (dumpDatabaseCallbacksCallback): Flag to control if the UIDelegate methods related to
          databases are called
        (clearAllDatabasesCallback): Allow a test to delete all databases
        (setDatabaseQuotaCallback): Allow a test to set the quota new origins will get
        (LayoutTestController::staticFunctions):

        * DumpRenderTree/LayoutTestController.h:
        (LayoutTestController::dumpDatabaseCallbacks):
        (LayoutTestController::setDumpDatabaseCallbacks):

        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::clearAllDatabases):
        (LayoutTestController::setDatabaseQuota):

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::clearAllDatabases): Stubbed out
        (LayoutTestController::setDatabaseQuota): Ditto
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::clearAllDatabases): Stubbed out with error message
        (LayoutTestController::setDatabaseQuota): Ditto

        * DumpRenderTree/mac/UIDelegate.mm:
        (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Print a
          message with details about the event then return a 5mb quota like before

LayoutTests:

        Reviewed by Darin Adler

        Added layout tests to cover
        http://trac.webkit.org/projects/webkit/changeset/29983
        and
        http://trac.webkit.org/projects/webkit/changeset/30184

        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
        * storage/quota-tracking-expected.txt: Added.
        * storage/quota-tracking.html: Added.
        * storage/success-callback-expected.txt: Added.
        * storage/success-callback.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix issues with the paint origin when using wxGCDC, with computing the font platform...
kevino@webkit.org [Wed, 13 Feb 2008 17:49:28 +0000 (17:49 +0000)]
Fix issues with the paint origin when using wxGCDC, with computing the font platform data hash, and Win and wxPython bindings compilation.
http://bugs.webkit.org/show_bug.cgi?id=17321

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-13 Rodney Dawes <dobey@wayofthemonkey.com>
aroben@apple.com [Wed, 13 Feb 2008 17:28:37 +0000 (17:28 +0000)]
2008-02-13  Rodney Dawes  <dobey@wayofthemonkey.com>

Fix Bug 17220: Illogical dependency between PluginView and PluginDatabase

WebCore:

        Fix Bug 17220: Illogical dependency between PluginView and
        PluginDatabase

        <http://bugs.webkit.org/show_bug.cgi?id=17220>

        Reviewed by Adam and Darin.

        Rename PluginDatabase::createPluginView to PluginView::create, to make
        the illogical dependency between the two, logical
        Make PluginDatabase::findPlugin a public method
        Update the includes in PluginView and PluginDatabase for the change

        * plugins/PluginDatabase.h:
        * plugins/PluginView.h:
        * plugins/win/PluginDatabaseWin.cpp:
        * plugins/win/PluginViewWin.cpp:

WebKit/win:

        Fix Bug 17220: Illogical dependency between PluginView and
        PluginDatabase

        <http://bugs.webkit.org/show_bug.cgi?id=17220>

        Reviewed by Adam and Darin.

        Update for the rename of PluginDatabase::createPluginView
        to PluginView::create

        * WebFrame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWindows build fixes
aroben@apple.com [Wed, 13 Feb 2008 17:20:47 +0000 (17:20 +0000)]
Windows build fixes

WebCore:

        Build fix

        * platform/graphics/cg/GraphicsContextCG.cpp: Added missing #include.

WebKit/win:

        Windows build fix

        * Interfaces/WebKit.idl: Create the typelib version symbol ourselves.

WebKitLibraries:

        * win/tools/scripts/auto-version.sh: Removed a redundant symbol.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-13 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 13 Feb 2008 16:29:00 +0000 (16:29 +0000)]
2008-02-13  Alp Toker  <alp@atoker.com>

        Reviewed by Adam Roben.

        Fix very small, upside down, inside out text on GTK+/DirectFB.

        Based on an initial patch by Sriram Neelakandan <sriram.neelakandan@gmail.com>

        Test the result of gdk_screen_get_resolution() and use a default
        fallback in case of failure.

        Also remove an unhelpful runtime warning.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * platform/mac/svg/hixie/perf/001-expected.txt: Removed.
darin@apple.com [Wed, 13 Feb 2008 15:56:30 +0000 (15:56 +0000)]
    * platform/mac/svg/hixie/perf/001-expected.txt: Removed.
        * platform/mac/svg/hixie/perf/002-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Not reviewed, build fix.
pewtermoose@webkit.org [Wed, 13 Feb 2008 15:29:11 +0000 (15:29 +0000)]
    Not reviewed, build fix.

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::paintBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - try to fix Wx build
darin@apple.com [Wed, 13 Feb 2008 14:25:29 +0000 (14:25 +0000)]
    - try to fix Wx build

        * platform/graphics/wx/GraphicsContextWx.cpp:
        (WebCore::GraphicsContext::paintBuffer): Added.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::paintBuffer): Added missing paintingDisabled() check.
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::paintBuffer): Ditto.
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::paintBuffer): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - try to fix Wx build
darin@apple.com [Wed, 13 Feb 2008 13:33:44 +0000 (13:33 +0000)]
    - try to fix Wx build

        * platform/wx/LocalizedStringsWx.cpp: Add missing include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Wed, 13 Feb 2008 13:26:40 +0000 (13:26 +0000)]
WebCore:

        - roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders
          incorrectly due to visibility fix

        Removed the Xcode-specific quirk at the request of some folks on the Xcode team.

        * WebCore.base.exp: Rolled out change.
        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::setProperty): Ditto.
        * page/Settings.cpp:
        (WebCore::Settings::Settings): Ditto. But keep the initialization of
        m_fontRenderingMode.
        (WebCore::Settings::setNeedsXcodeVisibilityQuirk): Removed.
        * page/Settings.h:
        (WebCore::Settings::needsXcodeVisibilityQuirk): Removed.

WebKit/mac:

        - roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders
          incorrectly due to visibility fix

        Removed the Xcode-specific quirk at the request of some folks on the Xcode team.

        * Misc/WebKitVersionChecks.h: Removed the constant.

        * WebView/WebView.mm:
        (-[WebView _needsXcodeVisibilityQuirk]): Removed.
        (-[WebView _preferencesChangedNotification:]): Removed call to
        setNeedsXcodeVisibilityQuirk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap@webkit.org [Wed, 13 Feb 2008 12:51:41 +0000 (12:51 +0000)]
    Reviewed by Darin.

        <rdar://problem/5740042> Database termination issues

        Test: storage/close-during-stress-test.html

        * dom/Document.cpp:
        (WebCore::Document::databaseThread):
        * dom/Document.h:
        Don't re-create the database thread if it has been already terminated.

        * storage/Database.h: (WebCore::Database::document): Changed m_database to a RefPtr to avoid
        having a hanging reference.

        * storage/DatabaseThread.cpp:
        (WebCore::DatabaseThread::requestTermination):

        * storage/SQLTransaction.cpp: (WebCore::SQLTransaction::~SQLTransaction): Removed logging.
        Transactions are deleted during GC, so it's usually not importatnt to know when it happens.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - check in results for these tests
darin@apple.com [Wed, 13 Feb 2008 12:33:24 +0000 (12:33 +0000)]
    - check in results for these tests

        No idea if these are right or not; just what was generated on my computer.
        If someone has a better version, feel free to replace these results with correct ones.

        * platform/mac/svg/hixie/perf/001-expected.txt: Added.
        * platform/mac/svg/hixie/perf/002-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
darin@apple.com [Wed, 13 Feb 2008 12:27:46 +0000 (12:27 +0000)]
    Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17340
          WebCore/platform/Timer.cpp fails to build with gcc 4.3

        * platform/Timer.cpp: Add include of <limits.h> since this file uses UINT_MAX.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
darin@apple.com [Wed, 13 Feb 2008 12:10:00 +0000 (12:10 +0000)]
    Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=17339
          JavaScriptCore does not build with gcc 4.3

        * kjs/interpreter.cpp: Add include of <unistd.h>, since that's where
        getpid() comes from.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/5737003> REGRESSION (r27747): can't browse pictures on fastcupid.com
oliver@apple.com [Wed, 13 Feb 2008 09:51:59 +0000 (09:51 +0000)]
<rdar://problem/5737003> REGRESSION (r27747): can't browse pictures on fastcupid.com

Reviewed by Alexey P.

When converting numeric values to booleans we need to account for NaN

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoComment out the ASSERT to make the layout tests pass. Filed <rdar://problem/5739818...
timothy@apple.com [Wed, 13 Feb 2008 06:32:27 +0000 (06:32 +0000)]
Comment out the ASSERT to make the layout tests pass. Filed <rdar://problem/5739818> to track the issue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady Eidson.
timothy@apple.com [Wed, 13 Feb 2008 06:04:19 +0000 (06:04 +0000)]
    Reviewed by Brady Eidson.

        <rdar://problem/5652560> Can't delete database if the website that
        uses it has been opened in this session

        Close the Database on the database thread before deleting the file.
        Tested and works on Windows and Mac.

        * platform/sql/SQLiteDatabase.cpp:
        (WebCore::SQLiteDatabase::close): Assert we are on the opening thread.
        * storage/Database.cpp:
        (WebCore::Database::markAsDeletedAndClose): Unschedule any pending
        Database tasks, and start and imediate DatabaseCloseTask.
        (WebCore::Database::close): Close the SQLDatabase.
        * storage/Database.h: Renamed markAsDeleted to markAsDeletedAndClose.
        * storage/DatabaseTask.cpp:
        (WebCore::DatabaseCloseTask::DatabaseCloseTask): New task.
        (WebCore::DatabaseCloseTask::doPerformTask): Call close on the Database.
        (WebCore::DatabaseCloseTask::debugTaskName): Return "DatabaseCloseTask".
        * storage/DatabaseTask.h: Add DatabaseCloseTask.
        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::deleteDatabaseFile): Call the renamed
          markAsDeletedAndClose.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoEndeavour to fix qt and gtk builds
oliver@apple.com [Wed, 13 Feb 2008 04:22:25 +0000 (04:22 +0000)]
Endeavour to fix qt and gtk builds

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Clean up auto-version.sh a bit
aroben@apple.com [Wed, 13 Feb 2008 03:07:15 +0000 (03:07 +0000)]
     Clean up auto-version.sh a bit

         It now does quite a bit less file I/O and many fewer fork/exec pairs.
         It's also quite a bit easier to read.

         Reviewed by Steve.

         * win/tools/scripts/auto-version.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Use a precompiled header to build WebKit.
sfalken@apple.com [Wed, 13 Feb 2008 02:53:48 +0000 (02:53 +0000)]
    Use a precompiled header to build WebKit.

        Reviewed by Adam.

        * WebKit.vcproj/WebKit.vcproj:
        * WebKitPrefix.cpp: Added.
        * WebKitPrefix.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBug 17269: Deobfuscate CanvasRenderingContext2D.cpp
oliver@apple.com [Wed, 13 Feb 2008 02:11:55 +0000 (02:11 +0000)]
Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp
Remove ifdef's from canvas paint code

Reviewed by Eric S.

By making GraphicsContext aware of the crossplatform ImageBuffer
type we can migrate the ifdef-ified paint code in HTMLCanvasElement
into platform implementations of GraphicsContext.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler
beidson@apple.com [Wed, 13 Feb 2008 01:10:42 +0000 (01:10 +0000)]
    Reviewed by Darin Adler

        Fix for <rdar://problem/5737692> - Database API needs to support SuccessCallback

        Layout tests will come shortly with a mess of DRT changes

        * platform/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::SecurityOrigin): Standardize on "empty string" instead of null string
          as different paths of constructing a SecurityOrigin were causing different hashes for the "same"
          SecurityOrigin

        * storage/Database.cpp:
        (WebCore::Database::changeVersion): Pass in the successCallback
        (WebCore::Database::transaction): Ditto

        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::SQLTransaction):
        (WebCore::SQLTransaction::debugStepName):
        (WebCore::SQLTransaction::performNextStep): Update ASSERTs for the new valid steps
        (WebCore::SQLTransaction::performPendingCallback): Ditto
        (WebCore::SQLTransaction::postflightAndCommit): Schedule the success callback if it exists - otherwise
          skip straight to cleanupAfterSuccessCallback()
        (WebCore::SQLTransaction::deliverSuccessCallback): Deliver success callback on the main thread, then
          schedule cleanupAfterSuccessCallback()
        (WebCore::SQLTransaction::cleanupAfterSuccessCallback): Cleanup and end the transaction
        (WebCore::SQLTransaction::handleTransactionError):
        (WebCore::SQLTransaction::deliverTransactionErrorCallback):
        (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
        * storage/SQLTransaction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Versioning script change.
sfalken@apple.com [Wed, 13 Feb 2008 00:18:33 +0000 (00:18 +0000)]
    Versioning script change.

        * win/tools/scripts/auto-version.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Changes to support merged MIDL output.
sfalken@apple.com [Wed, 13 Feb 2008 00:16:39 +0000 (00:16 +0000)]
    Changes to support merged MIDL output.

        All COM interfaces are now generated to WebKit.h.

        Reviewed by Sam, Ada.

        * bindings/scripts/CodeGeneratorCOM.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Changes to support merged MIDL output.
sfalken@apple.com [Wed, 13 Feb 2008 00:16:27 +0000 (00:16 +0000)]
    Changes to support merged MIDL output.

        All COM interfaces are now generated to WebKit.h.

        Reviewed by Sam, Ada.

        * Drosera/win/BaseDelegate.h:
        * Drosera/win/DebuggerClient.cpp:
        * Drosera/win/DebuggerDocumentPlatform.cpp:
        * Drosera/win/Drosera.cpp:
        * Drosera/win/ServerConnection.cpp:
        * Drosera/win/ServerConnection.h:
        * DumpRenderTree/win/DumpRenderTree.cpp:
        * DumpRenderTree/win/EditingDelegate.h:
        * DumpRenderTree/win/EventSender.cpp:
        * DumpRenderTree/win/FrameLoadDelegate.cpp:
        * DumpRenderTree/win/FrameLoadDelegate.h:
        * DumpRenderTree/win/GCControllerWin.cpp:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        * DumpRenderTree/win/PolicyDelegate.h:
        * DumpRenderTree/win/ResourceLoadDelegate.h:
        * DumpRenderTree/win/UIDelegate.cpp:
        * DumpRenderTree/win/UIDelegate.h:
        * DumpRenderTree/win/WorkQueueItemWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Changes to support merged MIDL output.
sfalken@apple.com [Wed, 13 Feb 2008 00:16:05 +0000 (00:16 +0000)]
    Changes to support merged MIDL output.

        All COM interfaces are now generated to WebKit.h.

        Reviewed by Sam, Ada.

        * DOMCSSClasses.h:
        * DOMCoreClasses.h:
        * DOMEventsClasses.h:
        * DOMHTMLClasses.h:
        * DefaultDownloadDelegate.h:
        * DefaultPolicyDelegate.cpp:
        * DefaultPolicyDelegate.h:
        * GEN_DOMObject.h:
        * Interfaces/DOMCSS.idl:
        * Interfaces/DOMCore.idl:
        * Interfaces/DOMEvents.idl:
        * Interfaces/DOMExtensions.idl:
        * Interfaces/DOMHTML.idl:
        * Interfaces/DOMPrivate.idl:
        * Interfaces/DOMRange.idl:
        * Interfaces/DOMWindow.idl:
        * Interfaces/IGEN_DOMObject.idl:
        * Interfaces/IWebArchive.idl:
        * Interfaces/IWebBackForwardList.idl:
        * Interfaces/IWebBackForwardListPrivate.idl:
        * Interfaces/IWebCache.idl:
        * Interfaces/IWebDataSource.idl:
        * Interfaces/IWebDatabaseManager.idl:
        * Interfaces/IWebDocument.idl:
        * Interfaces/IWebDownload.idl:
        * Interfaces/IWebEditingDelegate.idl:
        * Interfaces/IWebError.idl:
        * Interfaces/IWebErrorPrivate.idl:
        * Interfaces/IWebFormDelegate.idl:
        * Interfaces/IWebFrame.idl:
        * Interfaces/IWebFrameLoadDelegate.idl:
        * Interfaces/IWebFrameLoadDelegatePrivate.idl:
        * Interfaces/IWebFramePrivate.idl:
        * Interfaces/IWebFrameView.idl:
        * Interfaces/IWebHTMLRepresentation.idl:
        * Interfaces/IWebHTTPURLResponse.idl:
        * Interfaces/IWebHistory.idl:
        * Interfaces/IWebHistoryItem.idl:
        * Interfaces/IWebHistoryItemPrivate.idl:
        * Interfaces/IWebIconDatabase.idl:
        * Interfaces/IWebInspector.idl:
        * Interfaces/IWebJavaScriptCollector.idl:
        * Interfaces/IWebKitStatistics.idl:
        * Interfaces/IWebMutableURLRequest.idl:
        * Interfaces/IWebMutableURLRequestPrivate.idl:
        * Interfaces/IWebNotification.idl:
        * Interfaces/IWebNotificationCenter.idl:
        * Interfaces/IWebNotificationObserver.idl:
        * Interfaces/IWebPolicyDelegate.idl:
        * Interfaces/IWebPreferences.idl:
        * Interfaces/IWebPreferencesPrivate.idl:
        * Interfaces/IWebResource.idl:
        * Interfaces/IWebResourceLoadDelegate.idl:
        * Interfaces/IWebResourceLoadDelegatePrivate.idl:
        * Interfaces/IWebScriptCallFrame.idl:
        * Interfaces/IWebScriptDebugListener.idl:
        * Interfaces/IWebScriptDebugServer.idl:
        * Interfaces/IWebScriptObject.idl:
        * Interfaces/IWebScriptScope.idl:
        * Interfaces/IWebScrollBarDelegatePrivate.idl:
        * Interfaces/IWebScrollBarPrivate.idl:
        * Interfaces/IWebSecurityOrigin.idl:
        * Interfaces/IWebTextRenderer.idl:
        * Interfaces/IWebUIDelegate.idl:
        * Interfaces/IWebUIDelegatePrivate.idl:
        * Interfaces/IWebURLAuthenticationChallenge.idl:
        * Interfaces/IWebURLRequest.idl:
        * Interfaces/IWebURLResponse.idl:
        * Interfaces/IWebURLResponsePrivate.idl:
        * Interfaces/IWebUndoManager.idl:
        * Interfaces/IWebUndoTarget.idl:
        * Interfaces/IWebView.idl:
        * Interfaces/IWebViewPrivate.idl:
        * Interfaces/WebKit.idl:
        * WebActionPropertyBag.cpp:
        * WebBackForwardList.h:
        * WebCache.h:
        * WebDataSource.cpp:
        * WebDataSource.h:
        * WebDatabaseManager.h:
        * WebDownload.h:
        * WebEditorClient.cpp:
        * WebEditorClient.h:
        * WebError.h:
        * WebFrame.cpp:
        * WebFrame.h:
        * WebFramePolicyListener.h:
        * WebHTMLRepresentation.cpp:
        * WebHTMLRepresentation.h:
        * WebHistory.cpp:
        * WebHistory.h:
        * WebHistoryItem.h:
        * WebIconDatabase.h:
        * WebInspector.h:
        * WebJavaScriptCollector.h:
        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/WebKitGUID.vcproj:
        * WebKitDLL.cpp:
        * WebKitStatistics.h:
        * WebMutableURLRequest.cpp:
        * WebMutableURLRequest.h:
        * WebNotification.h:
        * WebNotificationCenter.h:
        * WebPreferences.h:
        * WebResource.h:
        * WebScriptCallFrame.h:
        * WebScriptDebugServer.cpp:
        * WebScriptDebugServer.h:
        * WebScriptDebugger.cpp:
        * WebScriptDebugger.h:
        * WebScriptObject.h:
        * WebScrollBar.h:
        * WebSecurityOrigin.h:
        * WebTextRenderer.h:
        * WebURLAuthenticationChallenge.h:
        * WebURLAuthenticationChallengeSender.h:
        * WebURLCredential.h:
        * WebURLProtectionSpace.h:
        * WebURLResponse.h:
        * WebView.cpp:
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
mitz@apple.com [Tue, 12 Feb 2008 23:54:39 +0000 (23:54 +0000)]
    Reviewed by Adam Roben.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17041
          <rdar://problem/5709660> Eastern Asian fonts do not display without specific box in Control Panel

        Revised the system fallback font lookup logic to use MLang font linking
        again. To avoid reintroducing bug 16548 and <rdar://problem/5280188>,
        for CJK characters, try linking based on a single code page at a time,
        starting with the user's default code page (if it is one of the CJK
        code pages) followed by the other CJK code pages in a prescribed order
        that matches what Firefox does.

        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::getCJKCodePageMasks): Added. Returns the search order for CJK
        code pages, with the user's default code page first.
        (WebCore::currentFontContainsCharacter): Factored out of
        getFontDataForCharacters().
        (WebCore::createMLangFont): Ditto.
        (WebCore::FontCache::getFontDataForCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
andersca@apple.com [Tue, 12 Feb 2008 23:34:04 +0000 (23:34 +0000)]
    Reviewed by Adam.

        Implement imageTitle.

        * WebCoreLocalizedStrings.cpp:
        (WebCore::imageTitle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady Eidson.
weinig@apple.com [Tue, 12 Feb 2008 21:29:51 +0000 (21:29 +0000)]
    Reviewed by Brady Eidson.

        <rdar://problem/5659216> REGRESSION: PLT 0.3% slower due to r28868 (caching ClassNodeList and NamedNodeList)

        - Tweak the statements in isASCIISpace to account for the statistical distribution of
          usage in the PLT.

        .4% speedup on my machine.  Stephanie's machine shows this as .3% speedup.

        * wtf/ASCIICType.h:
        (WTF::isASCIISpace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Adam Roben.
mitz@apple.com [Tue, 12 Feb 2008 21:17:47 +0000 (21:17 +0000)]
    Rubber-stamped by Adam Roben.

        - make fast/css/css3-nth-child pass

        * fast/css/css3-nth-child.html: Removed spaces that were making the
        :nth-child selector fail to parse because of <rdar://problem/5733761>.
        * platform/mac-leopard/fast/css/css3-nth-child-expected.checksum: Added.
        * platform/mac-leopard/fast/css/css3-nth-child-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-12 Rodney Dawes <dobey@wayofthemonkey.com>
alp@webkit.org [Tue, 12 Feb 2008 21:04:50 +0000 (21:04 +0000)]
2008-02-12  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Alp Toker.

        Add -DMAEMO_CHANGES when the hildon CONFIG option is specified
        Add hildon-1 to PKGCONFIG when hildon CONFIG option is specified

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Timothy Hatcher.
mitz@apple.com [Tue, 12 Feb 2008 20:13:46 +0000 (20:13 +0000)]
    Reviewed by Timothy Hatcher.

        - <rdar://problem/5738175> Remove workaround for <rdar://problem/5539388> from post-Tiger builds

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::setShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Release build fix
beidson@apple.com [Tue, 12 Feb 2008 20:11:55 +0000 (20:11 +0000)]
    Release build fix

        * storage/DatabaseTask.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
ap@webkit.org [Tue, 12 Feb 2008 19:37:03 +0000 (19:37 +0000)]
    Reviewed by Brady.

        http://bugs.webkit.org/show_bug.cgi?id=17177
        <rdar://problem/5729619> Storage tasks are getting lost

        <rdar://problem/5729445> REGRESSION: Cannot schedule more than one transaction at a time

        <rdar://problem/5729446> Major thread safety issue in Database code

        * platform/MessageQueue.h: Added a thread-safe queue abstraction.

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        Added MessageQueue.h.

        * dom/Document.cpp:
        (WebCore::Document::~Document): Fixed a race condition resulting in a hanging reference.

        * storage/Database.idl: Fixed parameter declarations to actually match implementation
        (which is custom, so it got out of sync).

        * storage/DatabaseTask.h:
        (WebCore::DatabaseTask::database):
        (WebCore::DatabaseTransactionTask::transaction):
        Changed tasks to hold more information internally. Added helpers for better debug logging.

        * storage/DatabaseTask.cpp:
        (WebCore::DatabaseTask::DatabaseTask):
        (WebCore::DatabaseTask::performTask):
        (WebCore::DatabaseOpenTask::DatabaseOpenTask):
        (WebCore::DatabaseOpenTask::doPerformTask):
        (WebCore::DatabaseOpenTask::debugTaskName):
        (WebCore::DatabaseTransactionTask::DatabaseTransactionTask):
        (WebCore::DatabaseTransactionTask::~DatabaseTransactionTask):
        (WebCore::DatabaseTransactionTask::doPerformTask):
        (WebCore::DatabaseTransactionTask::debugTaskName):
        (WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask):
        (WebCore::DatabaseTableNamesTask::doPerformTask):
        (WebCore::DatabaseTableNamesTask::debugTaskName):
        Implementation for the above.

        (WebCore::DatabaseTask::lockForSynchronousScheduling):
        (WebCore::DatabaseTask::waitForSynchronousCompletion):
        Fixed a potential race condition: if the task completed before we entered a wait, we'd never
        wake up. There was an assertion guarding against this, but no actual guarantee that I could see.

        * storage/DatabaseThread.cpp:
        (WebCore::DatabaseThread::DatabaseThread):
        (WebCore::DatabaseThread::requestTermination):
        (WebCore::DatabaseThread::databaseThread):
        (WebCore::DatabaseThread::scheduleTask):
        (WebCore::DatabaseThread::scheduleImmediateTask):
        (WebCore::DatabaseThread::unscheduleDatabaseTasks):
        * storage/DatabaseThread.h:
        Changed to use MessageQueue.

        * storage/Database.cpp:
        (WebCore::guidMutex):
        (WebCore::guidToVersionMap):
        (WebCore::guidToDatabaseMap):
        (WebCore::Database::openDatabase):
        (WebCore::Database::Database):
        (WebCore::Database::~Database):
        (WebCore::Database::openAndVerifyVersion):
        (WebCore::guidForOriginAndName):
        (WebCore::Database::changeVersion):
        (WebCore::Database::transaction):
        (WebCore::Database::scheduleTransaction):
        (WebCore::Database::scheduleTransactionStep):
        (WebCore::Database::scheduleTransactionCallback):
        (WebCore::Database::version):
        (WebCore::Database::deliverPendingCallback):
        (WebCore::Database::tableNames):
        * storage/Database.h:
        Changed m_transactionQueue to a MessageQueue.
        Got rid of callback tracking - these can take care of themselves.
        Got rid of a DatabaseThread member, as the Document can be asked for it.
        Moved private static members and helpers out of the header.
        Lost CurrentThreadSetter debug helper on the way. We may need to re-add something like that later.

        * storage/SQLTransaction.h:
        * storage/SQLTransaction.cpp: Added a lot of debug logging.
        (WebCore::SQLTransaction::scheduleToRunStatements): Removed "m_currentStatement = 0" assignment,
        as it created a race condition. Everything seems to work better without it, although a real fix
        would be to get rid of this variable - it's evil shared data that isn't even protected in any way.

        * manual-tests/database-threading-stress-test-2.html: Added.
        * manual-tests/database-threading-stress-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Bug 17328: REGRESSION (r30147): Inspector is unstyled on Windows
aroben@apple.com [Tue, 12 Feb 2008 19:29:52 +0000 (19:29 +0000)]
 Fix Bug 17328: REGRESSION (r30147): Inspector is unstyled on Windows

 WebCore:

         Fix Bug 17328: REGRESSION (r30147): Inspector is unstyled on Windows

         <http://bugs.webkit.org/show_bug.cgi?id=17328>
         <rdar://5737946>

         Reviewed by Mitz.

         Test: fast/loader/local-css-allowed-in-strict-mode.html

         * platform/network/cf/ResourceResponseCFNet.cpp:
         (WebCore::ResourceResponse::doUpdateResourceResponse): Add a case for
         .css files.

 LayoutTests:

         Add a test for Bug 17328: REGRESSION (r30147): Inspector is unstyled
         on Windows

         <http://bugs.webkit.org/show_bug.cgi?id=17328>
         <rdar://5737946>

         Reviewed by Mitz.

         * fast/loader/local-css-allowed-in-strict-mode-expected.txt: Added.
         * fast/loader/local-css-allowed-in-strict-mode.html: Added.
         * fast/loader/resources/stylesheet.css: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
andersca@apple.com [Tue, 12 Feb 2008 19:17:24 +0000 (19:17 +0000)]
    Build fix.

        * loader/ImageDocument.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix tyop.
andersca@apple.com [Tue, 12 Feb 2008 18:53:03 +0000 (18:53 +0000)]
Fix tyop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
andersca@apple.com [Tue, 12 Feb 2008 18:51:16 +0000 (18:51 +0000)]
WebCore:

        Reviewed by Mitz.

        Make the code that sets the image title cross platform.

        * WebCore.xcodeproj/project.pbxproj:
        Remove ImageDocumentMac.

        * loader/ImageDocument.cpp:
        (WebCore::ImageTokenizer::finish):

        * loader/mac/ImageDocumentMac.h: Removed.
        * loader/mac/ImageDocumentMac.mm: Removed.

        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreViewFactory.h:
        Move imageTitleForFilename:size from the bridge to
        the view factory.

        * platform/LocalizedStrings.h:
        Add imageTitle.

        * platform/mac/LocalizedStringsMac.mm:
        (WebCore::imageTitle):
        Have imageTitle call the view factory.

        * platform/qt/Localizations.cpp:
        (WebCore::imageTitle):
        * platform/wx/LocalizedStringsWx.cpp:
        (WebCore::imageTitle):
        * platform/gtk/LocalizedStringsGtk.cpp:
        (WebCore::imageTitle):
        Add stubs.

WebKit/mac:

        Reviewed by Mitz.

        * WebCoreSupport/WebFrameBridge.mm:
        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory imageTitleForFilename:size:]):
        Move implementatino from WebFrameBridge to WebViewFactory.

WebKit/win:

        Reviewed by Mitz.

        * WebCoreLocalizedStrings.cpp:
        (WebCore::imageTitle):
        Add stub.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoNot reviewed, adding missing layout test results (that have been r+ already, but...
zimmermann@webkit.org [Tue, 12 Feb 2008 13:23:04 +0000 (13:23 +0000)]
Not reviewed, adding missing layout test results (that have been r+ already, but not commited)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agomore Qt fixes
oliver@apple.com [Tue, 12 Feb 2008 09:40:04 +0000 (09:40 +0000)]
more Qt fixes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoYet another attempt to fix Qt
oliver@apple.com [Tue, 12 Feb 2008 09:30:30 +0000 (09:30 +0000)]
Yet another attempt to fix Qt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAttempt to fix qt build
oliver@apple.com [Tue, 12 Feb 2008 09:21:02 +0000 (09:21 +0000)]
Attempt to fix qt build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMake canvas use an ImageBuffer for its backing store
oliver@apple.com [Tue, 12 Feb 2008 09:14:25 +0000 (09:14 +0000)]
Make canvas use an ImageBuffer for its backing store

Reviewed by Alp Toker.

In order to make the canvas implementation less platform dependent
(and thus reduce the current quagmire of ifdefs) we now use an
ImageBuffer to provide the backing buffer, an immediate consequence
of this is to remove multiple ifdefs in the construction of the
buffer.  This patch allows us to further reduce the platform
dependencies in later patches.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Tue, 12 Feb 2008 06:02:57 +0000 (06:02 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17320
          <rdar://problem/5736953> :last-child does not set the "uses sibling rules" flag

        Test: fast/css/last-child-style-sharing.html

        * css/CSSGrammar.y: Changed to call setUsesSiblingRules(true) for all
        CSS3 selectors that require it.

LayoutTests:

        Reviewed by Dave Hyatt.

        - test for http://bugs.webkit.org/show_bug.cgi?id=17320
          <rdar://problem/5736953> :last-child does not set the "uses sibling rules" flag

        * fast/css/last-child-style-sharing.html: Added.
        * platform/mac/fast/css/last-child-style-sharing-expected.checksum: Added.
        * platform/mac/fast/css/last-child-style-sharing-expected.png: Added.
        * platform/mac/fast/css/last-child-style-sharing-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders Carlsson.
weinig@apple.com [Tue, 12 Feb 2008 01:24:02 +0000 (01:24 +0000)]
    Reviewed by Anders Carlsson.

        Fixes for:
        <rdar://problem/5735497> Match Firefox's cross-domain model more accurately by return the built-in version of functions even if they have been overridden
        <rdar://problem/5735443> Crash when setting the Window objects prototype to a custom Object and then calling a method on it

        - Expose the native Object.prototype.toString implementation so that it can be used for cross-domain
          toString calling.

        * JavaScriptCore.exp:
        * kjs/object_object.cpp:
        * kjs/object_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Tue, 12 Feb 2008 00:26:21 +0000 (00:26 +0000)]
WebCore:

        Reviewed by Darin Adler.

        Make the cross-domain security model more closely match Firefox by always returning the
        native built-in functions when accessing functions cross-domain.

        Fixes for:
        <rdar://problem/5735497> Match Firefox's cross-domain model more accurately by return the built-in version of functions even if they have been overridden
        <rdar://problem/5735443> Crash when setting the Window objects prototype to a custom Object and then calling a method on it

        Tests: fast/dom/Window/window-custom-prototype-crash.html
               fast/dom/Window/window-function-frame-getter-precedence.html
               http/tests/security/cross-frame-access-get-override.html
               http/tests/security/cross-frame-access-location-get-override.html
               http/tests/security/cross-frame-access-location-get.html
               http/tests/security/cross-frame-access-location-put.html

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::customGetOwnPropertySlot):
        - Return the native-built in version of an cross-domain allowed function (eg. window.focus) whether or
          not it has been overridden, instead of undefined.
        - When doing findEntry lookup, use the the tables directly (JSDOMWindowPrototype::info.propHashTable)
          instead of calling the virtual classInfo() method to avoid the unnecessary overhead.
        - Allow access to the native toString function cross-domain.  It always returns "[object Window]".
        - Use the new nonCachingStaticFunctionGetter when return allowed functions cross-frame so that
          the function an overridden function is not inadvertantly returned from the PropertyMap.\

        * bindings/js/JSHistoryCustom.cpp:
        (WebCore::JSHistory::customGetOwnPropertySlot):
        - Implement the same model as described above for the History object, always returning the
          native built-in function cross-domain.
        - Allow access to the native toString function cross-domain.
        - Clean up the code to make it clear that the custom functionality is only there for cross-domain
          access.

        * bindings/js/JSLocation.cpp:
        (WebCore::JSLocation::getOwnPropertySlot):
        - Match the generated classes by moving all the custom logic into a separate customGetOwnPropertySlot
          function.  This will help moving to a generated class in the future.
        (WebCore::JSLocation::customGetOwnPropertySlot):
        - Implement the same model as described above for the Location object, always returning the
          native built-in function cross-domain.
        - Clean up the code to make it clear that the custom functionality is only there for cross-domain
          access.
        (WebCore::JSLocation::put):
        (WebCore::JSLocation::deleteProperty):
        (WebCore::JSLocation::getPropertyNames):
        * bindings/js/JSLocation.h:
        - Clean up to match the rest of the file a little better.

        * bindings/js/kjs_binding.cpp:
        (WebCore::allowsAccessFromFrame):
        (WebCore::printErrorMessageForFrame):
        (WebCore::nonCachingStaticFunctionGetter):
        (WebCore::objectToStringFunctionGetter):
        * bindings/js/kjs_binding.h:
        - Put common functionality related to cross-domain access here to serve as a central shared point.
          This includes moving and augmenting the allowsAccessFromFrame method that was in both JSHistoryCustom.cpp
          and JSLocation.cpp.

        * bindings/js/kjs_dom.cpp:
        (WebCore::checkNodeSecurity):
        - Use the new allowsAccessFromFrame method.

        * bindings/js/kjs_window.cpp:
        (KJS::Window::childFrameGetter): Cleanup.
        (KJS::Window::namedItemGetter): Cleanup.
        (KJS::Window::getOwnPropertySlot):
        - Do the prototype lookup early to match Firefox in having function lookup have a higher precedence
          than the index or shortcut name getters.
        - Cleanup function to make it more understandable and slightly more efficient.
        (KJS::Window::allowsAccessFrom):
        - Add a new variant of this method that takes a reference to a String, which, on failure, will
          contain the error message to print out.  The caller can then pass this to printErrorMessage.
          This allows for code to check allowsAccessFrom and act on the result without printing out the
          error message. For convenience, a version with out the String parameter has been left which
          prints out the message automatically.
        (KJS::Window::printErrorMessage):
        * bindings/js/kjs_window.h:

LayoutTests:

        Reviewed by Darin Adler.

        Tests for:
        <rdar://problem/5735497> Match Firefox's cross-domain model more accurately by return the built-in version of functions even if they have been overridden
        <rdar://problem/5735443> Crash when setting the Window objects prototype to a custom Object and then calling a method on it

        * fast/dom/Window/resources/WindowProperties.js: Added.
        * fast/dom/Window/window-custom-prototype-crash-expected.txt: Added.
        * fast/dom/Window/window-custom-prototype-crash.html: Added.
        * fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Added.
        * fast/dom/Window/window-function-frame-getter-precedence.html: Added.
        * fast/dom/Window/window-function-name-getter-precedence-expected.txt:
        * fast/dom/Window/window-function-name-getter-precedence.html:
        * http/tests/security/cross-frame-access-custom-expected.txt:
        * http/tests/security/cross-frame-access-custom.html:
        * http/tests/security/cross-frame-access-get-override-expected.txt: Added.
        * http/tests/security/cross-frame-access-get-override.html: Added.
        * http/tests/security/cross-frame-access-history-get-override-expected.txt:
        * http/tests/security/cross-frame-access-history-get-override.html:
        * http/tests/security/cross-frame-access-history-put-expected.txt:
        * http/tests/security/cross-frame-access-history-put.html:
        * http/tests/security/cross-frame-access-location-expected.txt: Removed.
        * http/tests/security/cross-frame-access-location-get-expected.txt: Added.
        * http/tests/security/cross-frame-access-location-get-override-expected.txt: Added.
        * http/tests/security/cross-frame-access-location-get-override.html: Added.
        * http/tests/security/cross-frame-access-location-get.html: Copied from http/tests/security/cross-frame-access-location.html.
        * http/tests/security/cross-frame-access-location-put-expected.txt: Added.
        * http/tests/security/cross-frame-access-location-put.html: Added.
        * http/tests/security/cross-frame-access-location.html: Removed.
        * http/tests/security/resources/cross-frame-iframe-for-get-override-test.html: Added.
        * http/tests/security/resources/cross-frame-iframe-for-get-test.html:
        * http/tests/security/resources/cross-frame-iframe-for-history-put-test.html:
        * http/tests/security/resources/cross-frame-iframe-for-location-get-override-test.html: Added.
        * http/tests/security/resources/cross-frame-iframe-for-location-get-test.html: Added.
        * http/tests/security/resources/cross-frame-iframe-for-location-put-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Tue, 12 Feb 2008 00:16:44 +0000 (00:16 +0000)]
WebCore:

        Reviewed by Mitz.

        - fix <rdar://problem/5726016> REGRESSION: Xcode News window renders
          incorrectly due to visibility fix

        Added an Xcode-specific quirk.

        * WebCore.base.exp: Added export for new Settings function.
        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::setProperty): Here's the crazy quirk.
        If you try to change the visibilty on a node with the class name tab_content,
        instead it will use display:none.
        * page/Settings.cpp:
        (WebCore::Settings::Settings): Initialize m_needsXcodeVisibilityQuirk. Also
        initialize m_fontRenderingMode! This seems like it was a bug before, but we
        probably were getting lucky and always getting 0 on Windows, which is the
        only place the setting matters.
        (WebCore::Settings::setNeedsXcodeVisibilityQuirk): Added.
        * page/Settings.h:
        (WebCore::Settings::needsXcodeVisibilityQuirk): Added.

WebKit/mac:

        Reviewed by Mitz.

        - fix <rdar://problem/5726016> REGRESSION: Xcode News window renders
          incorrectly due to visibility fix

        Added an Xcode-specific quirk.

        * Misc/WebKitVersionChecks.h: Added a constant for the "linked on or after"
        part of the check.

        * WebView/WebView.mm:
        (-[WebView _needsXcodeVisibilityQuirk]): Added.
        (-[WebView _preferencesChangedNotification:]): Added a call to
        setNeedsXcodeVisibilityQuirk based on _needsXcodeVisibilityQuirk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-11 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>
alp@webkit.org [Mon, 11 Feb 2008 23:38:37 +0000 (23:38 +0000)]
2008-02-11  Pierre-Luc Beaudoin  <pierre-luc.beaudoin@collabora.co.uk>

        Reviewed by Alp Toker.

        Add my blog's WebKit category, English only posts.

        * config.ini:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady Eidson.
timothy@apple.com [Mon, 11 Feb 2008 22:54:53 +0000 (22:54 +0000)]
    Reviewed by Brady Eidson.

        <rdar://problem/5733069> Many m_quotaMap uses do not hold the m_quotaMapGuard

        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::hasEntryForOrigin): Hold m_quotaMapGuard when using m_quotaMap.
        (WebCore::DatabaseTracker::origins): Ditto.
        (WebCore::DatabaseTracker::setQuota): Ditto.
        (WebCore::DatabaseTracker::deleteAllDatabases): Call origins() and itterate over the
        origins to call deleteOrigin().
        (WebCore::DatabaseTracker::deleteOrigin): Hold m_quotaMapGuard when using m_quotaMap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bug 17286, crash accessing a null RenderStyle. Add a simple null...
hyatt@apple.com [Mon, 11 Feb 2008 21:19:01 +0000 (21:19 +0000)]
    Fix for bug 17286, crash accessing a null RenderStyle.  Add a simple null check.

        Reviewed by aroben

        Added fast/css/empty-generated-content.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::checkOneSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by David Kilzer.
rwlbuis@webkit.org [Mon, 11 Feb 2008 21:04:20 +0000 (21:04 +0000)]
    Reviewed by David Kilzer.

        http://bugs.webkit.org/show_bug.cgi?id=17201
        Bug 17201: Use RefPtr in CSSParser::parseFont() to get rid of goto silliness

        Gets rid of goto usage in parseFont.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBack out accidental checkin to HTMLMediaElement.cpp.
hyatt@apple.com [Mon, 11 Feb 2008 20:26:40 +0000 (20:26 +0000)]
Back out accidental checkin to HTMLMediaElement.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd layout test for bug 16798.
hyatt@apple.com [Mon, 11 Feb 2008 20:22:08 +0000 (20:22 +0000)]
Add layout test for bug 16798.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd layout test for bug 16798.
hyatt@apple.com [Mon, 11 Feb 2008 20:21:50 +0000 (20:21 +0000)]
Add layout test for bug 16798.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@30148 268f45cc-cd09-0410...
hyatt@apple.com [Mon, 11 Feb 2008 20:18:12 +0000 (20:18 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bug 17298, Acid3 text should be black and not red. Make sure stylesh...
hyatt@apple.com [Mon, 11 Feb 2008 20:17:36 +0000 (20:17 +0000)]
    Fix for bug 17298, Acid3 text should be black and not red.  Make sure stylesheets with the wrong MIME type
        are not accepted in strict mode.

        Reviewed by darin

        Added http/tests/misc/css-reject-in-strict-mode.html

        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::setCSSStyleSheet):
        * css/CSSImportRule.h:
        * dom/Document.cpp:
        (WebCore::Document::setCSSStyleSheet):
        * dom/Document.h:
        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::setCSSStyleSheet):
        * dom/ProcessingInstruction.h:
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::setCSSStyleSheet):
        * html/HTMLLinkElement.h:
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::pickMedia):
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::ref):
        (WebCore::CachedCSSStyleSheet::checkNotify):
        (WebCore::CachedCSSStyleSheet::canUseSheet):
        * loader/CachedCSSStyleSheet.h:
        (WebCore::CachedCSSStyleSheet::sheetText):
        * loader/CachedResourceClient.h:
        (WebCore::CachedResourceClient::setCSSStyleSheet):
        * loader/mac/UserStyleSheetLoader.cpp:
        (UserStyleSheetLoader::setCSSStyleSheet):
        * loader/mac/UserStyleSheetLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Bug 14316: Inspector's Console truncates long strings
aroben@apple.com [Mon, 11 Feb 2008 19:58:18 +0000 (19:58 +0000)]
    Fix Bug 14316: Inspector's Console truncates long strings

        <http://bugs.webkit.org/show_bug.cgi?id=14316>
        <rdar://5357695>

        We no longer call Object.describe to format all the output of commands
        enetered into the Console. The ConsolePanel object now has a set of
        formatting functions that append a formatted representation of the
        passed-in object to the passed-in container node.

        Reviewed by Sam.

        * page/inspector/ConsolePanel.js:
        (WebInspector.ConsolePanel._onEnterPressed): Updated for rename of
        _outputToNode to _format.
        (WebInspector.ConsolePanel._format): Renamed from _outputToNode. Use
        Object.type to get the type of the object, then call the appropriate
        formatting function.
        (WebInspector.ConsolePanel._formatvalue): Added.
        (WebInspector.ConsolePanel._formatstring): Added. This function
        contains the actual fix for the bug, since it doesn't truncate the
        string no matter how long it is.
        (WebInspector.ConsolePanel._formatregexp): Added.
        (WebInspector.ConsolePanel._formatarray): Added. This is a bit more
        functional than Object.describe for arrays, since it recursively
        formats each item in the array. One advantage of this is that Nodes in
        arrays will be linkified instead of just turning into "[Object
        HTMLBodyElement]" or similar.
        (WebInspector.ConsolePanel._formatnode): Added.
        (WebInspector.ConsolePanel._formatobject): Added.
        (WebInspector.ConsolePanel.
        * page/inspector/utilities.js:
        (Object.type): Added. Code was pulled out of Object.describe and
        reorganized slightly.
        (Object.describe): Call Object.type. There should be no change in
        behavior of this function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-11 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 11 Feb 2008 18:09:59 +0000 (18:09 +0000)]
2008-02-11  Alp Toker  <alp@atoker.com>

        Wx build fix for breakage introduced in r30142. Spotted by Darin.

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::parseDataUrl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add Brent Fulgham's blog
aroben@apple.com [Mon, 11 Feb 2008 17:44:34 +0000 (17:44 +0000)]
    Add Brent Fulgham's blog

        Rubberstamped by Alp.

        * config.ini:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed and tweaked by Darin
darin@apple.com [Mon, 11 Feb 2008 17:38:10 +0000 (17:38 +0000)]
    Reviewed and tweaked by Darin

        - http://bugs.webkit.org/show_bug.cgi?id=17299
          a couple compilation fixes for Cairo/Win32 configuration

        * platform/graphics/cairo/ImageSourceCairo.cpp:
        (WebCore::createDecoder): Turn off XBMImageDecoder for PLATFORM(WIN) configuration.
        * rendering/RenderThemeWin.cpp:
        (WebCore::prepareForDrawing): Added IntRect parameter.
        (WebCore::doneDrawing): Ditto.
        (WebCore::RenderThemeWin::paintButton): Ditto.
        (WebCore::RenderThemeWin::paintTextField): Ditto.
        (WebCore::RenderThemeWin::paintMenuListButton): Ditto.
        (WebCore::RenderThemeWin::systemFont): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-11 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 11 Feb 2008 16:56:25 +0000 (16:56 +0000)]
2008-02-11  Alp Toker  <alp@atoker.com>

        Reviewed by Alexey.

        Acid3 data URL parsing fix for the GTK+ port.

        Avoid WebCore's base64Decode() when possible since it's not a
        general-purpose Base64 decoder and fails on newlines.

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::parseDataUrl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - another Qt build fix
darin@apple.com [Mon, 11 Feb 2008 15:33:07 +0000 (15:33 +0000)]
    - another Qt build fix

        * platform/qt/PopupMenuQt.cpp:
        (WebCore::PopupMenu::PopupMenu): Added explicit RefCounted constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber stamped by Eric.
darin@apple.com [Mon, 11 Feb 2008 07:40:49 +0000 (07:40 +0000)]
    Rubber stamped by Eric.

        * kjs/ExecState.h:
        (KJS::ExecState::takeException): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - another Qt build fix (wish the Qt bot wouldn't stop on the first error)
darin@apple.com [Mon, 11 Feb 2008 07:38:36 +0000 (07:38 +0000)]
    - another Qt build fix (wish the Qt bot wouldn't stop on the first error)

        * platform/qt/FileChooserQt.cpp:
        (WebCore::FileChooser::FileChooser): Added explicit RefCounted constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - another Qt fix
darin@apple.com [Mon, 11 Feb 2008 07:03:29 +0000 (07:03 +0000)]
    - another Qt fix

        * platform/graphics/qt/IconQt.cpp:
        (WebCore::Icon::Icon): Added explicit RefCounted constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-10 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 11 Feb 2008 06:09:20 +0000 (06:09 +0000)]
2008-02-10  Alp Toker  <alp@atoker.com>

        Another Win build fix for r30133 breakage.

        * plugins/win/PluginPackageWin.cpp:
        (WebCore::PluginPackage::PluginPackage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-10 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 11 Feb 2008 05:50:45 +0000 (05:50 +0000)]
2008-02-10  Alp Toker  <alp@atoker.com>

        Build fix GTK+ and prospective build fix for Win breakage introduced
        in r30133.

        * platform/Cursor.h:
        (WebCore::SharedCursor::SharedCursor):
        * platform/graphics/gtk/IconGtk.cpp:
        (WebCore::Icon::Icon):
        * platform/gtk/FileChooserGtk.cpp:
        (WebCore::FileChooser::FileChooser):
        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenu::PopupMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - try to fix Win, Qt, GTK, and WX builds
darin@apple.com [Mon, 11 Feb 2008 04:17:24 +0000 (04:17 +0000)]
    - try to fix Win, Qt, GTK, and WX builds

        * platform/Cursor.h:
        (WebCore::SharedCursor::SharedCursor): Added explicit RefCounted constructor.
        * platform/graphics/win/IconWin.cpp:
        (WebCore::Icon::Icon): Ditto.
        * platform/win/FileChooserWin.cpp:
        (WebCore::FileChooser::FileChooser): Ditto.
        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::PopupMenu): Ditto.
        * platform/wx/TemporaryLinkStubs.cpp:
        (FileChooser::FileChooser): Ditto.
        (PopupMenu::PopupMenu): Ditto.
        (Icon::Icon): Ditto.
        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::PluginStream): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam Weinig and Anders Carlsson.
mitz@apple.com [Mon, 11 Feb 2008 03:41:36 +0000 (03:41 +0000)]
    Reviewed by Sam Weinig and Anders Carlsson.

        - change a test to simply use 'font-family' instead of unnecessary
          @font-face hackery

        * fast/text/atsui-spacing-features.html:
        * platform/mac/fast/text/atsui-spacing-features-expected.checksum:
        * platform/mac/fast/text/atsui-spacing-features-expected.png:
        * platform/mac/fast/text/atsui-spacing-features-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
darin@apple.com [Mon, 11 Feb 2008 02:03:31 +0000 (02:03 +0000)]
JavaScriptCore:

        Reviewed by Eric.

        - http://bugs.webkit.org/show_bug.cgi?id=17256
          eliminate default ref. count of 0 in RefCounted class

        * wtf/RefCounted.h:
        (WTF::RefCounted::RefCounted): Remove default of 0.

WebKit/wx:

        Reviewed by Eric.

        - http://bugs.webkit.org/show_bug.cgi?id=17256
          eliminate default ref. count of 0 in RefCounted class

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::FrameLoaderClientWx):
        Set the count to 0 explicitly (one stray client I missed in my last pass).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver Hunt.
mitz@apple.com [Sun, 10 Feb 2008 23:17:02 +0000 (23:17 +0000)]
    Reviewed by Oliver Hunt.

        - fix a memory leak

        * DumpRenderTree/cg/ImageDiffCG.cpp:
        (getDifferenceBitmap): Use a static CFMutableData instead of allocating
        and leaking the buffer each time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate test results for iframe fix.
hyatt@apple.com [Sun, 10 Feb 2008 23:08:26 +0000 (23:08 +0000)]
Update test results for iframe fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bug 17082, cssRules should be live.
hyatt@apple.com [Sun, 10 Feb 2008 22:33:00 +0000 (22:33 +0000)]
    Fix for bug 17082, cssRules should be live.

        Reviewed by olliej

        Added fast/css/live-cssrules.html

        * css/CSSRuleList.cpp:
        (WebCore::CSSRuleList::CSSRuleList):
        (WebCore::CSSRuleList::length):
        (WebCore::CSSRuleList::item):
        (WebCore::CSSRuleList::deleteRule):
        (WebCore::CSSRuleList::insertRule):
        * css/CSSRuleList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd layout test for bug 17082.
hyatt@apple.com [Sun, 10 Feb 2008 22:31:50 +0000 (22:31 +0000)]
Add layout test for bug 17082.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd layout test for bug 17082.
hyatt@apple.com [Sun, 10 Feb 2008 22:31:32 +0000 (22:31 +0000)]
Add layout test for bug 17082.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bug 17253. <iframe> contents need to be reflected into the DOM as...
hyatt@apple.com [Sun, 10 Feb 2008 22:30:04 +0000 (22:30 +0000)]
    Fix for bug 17253.  <iframe> contents need to be reflected into the DOM as a single text node.

        Reviewed by olliej

        fast/frames/iframe-text-contents.html

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::getNode):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseSpecial):
        (WebCore::HTMLTokenizer::parseComment):
        (WebCore::HTMLTokenizer::parseTag):
        * html/HTMLTokenizer.h:
        (WebCore::HTMLTokenizer::State::inIFrame):
        (WebCore::HTMLTokenizer::State::setInIFrame):
        (WebCore::HTMLTokenizer::State::inAnySpecial):
        (WebCore::HTMLTokenizer::State::needsSpecialWriteHandling):
        (WebCore::HTMLTokenizer::State::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd layout tests for 17253.
hyatt@apple.com [Sun, 10 Feb 2008 22:29:27 +0000 (22:29 +0000)]
Add layout tests for 17253.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd layout tests for 17253.
hyatt@apple.com [Sun, 10 Feb 2008 22:29:18 +0000 (22:29 +0000)]
Add layout tests for 17253.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - fix a couple of directories that were using our JavaScript template/wrapper
darin@apple.com [Sun, 10 Feb 2008 21:28:08 +0000 (21:28 +0000)]
    - fix a couple of directories that were using our JavaScript template/wrapper
          system incorrectly

        * fast/dom/SelectorAPI/resources/TEMPLATE.html: Fixed relative paths.
        * fast/events/event-instanceof.html: Regenerating this file revealed that the path
        to the stylesheet was wrong. Fixed by running the make-js-test-wrappers script.
        Didn't affect the text-only results, but the test looked wrong in the browser.
        * fast/events/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
        * traversal/resources/TEMPLATE.html: Fixed relative paths.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Sun, 10 Feb 2008 20:13:51 +0000 (20:13 +0000)]
WebCore:

        Reviewed and tweaked by Darin.

        DOMRange.surroundContents throws wrong exception (Acid3 bug)
        http://bugs.webkit.org/show_bug.cgi?id=16749

        Throw BAD_BOUNDARYPOINTS_ERR if attempting to split a non-text node that
        has offsets in characters.

        * dom/Range.cpp:
        (WebCore::Range::surroundContents):

LayoutTests:

        Reviewed and tweaked a bit by Darin.

        DOMRange.surroundContents throws wrong exception (Acid3 bug)
        http://bugs.webkit.org/show_bug.cgi?id=16749

        Throw BAD_BOUNDARYPOINTS_ERR if attempting to split a non-text node that
        has offsets in characters

        * fast/dom/Range/range-exceptions-expected.txt: Added.
        * fast/dom/Range/resources/range-exceptions.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
darin@apple.com [Sun, 10 Feb 2008 19:27:12 +0000 (19:27 +0000)]
JavaScriptCore:

        Reviewed by Eric.

        - http://bugs.webkit.org/show_bug.cgi?id=17256
          Make clients of RefCounted explicitly set the count to 0.

        * API/JSClassRef.cpp:
        (OpaqueJSClass::OpaqueJSClass):
        * bindings/runtime_root.cpp:
        (KJS::Bindings::RootObject::RootObject):

WebCore:

        Reviewed by Eric.

        - http://bugs.webkit.org/show_bug.cgi?id=17256
          Make clients of RefCounted explicitly set the count to 0.

        * bindings/js/JSSVGPODTypeWrapper.h:
        (WebCore::JSSVGPODTypeWrapper::JSSVGPODTypeWrapper):
        * css/CSSFontFace.h:
        (WebCore::CSSFontFace::CSSFontFace):
        * css/CSSRuleList.cpp:
        (WebCore::CSSRuleList::CSSRuleList):
        * css/CSSSegmentedFontFace.cpp:
        (WebCore::CSSSegmentedFontFace::CSSSegmentedFontFace):
        * css/Counter.h:
        (WebCore::Counter::Counter):
        * css/Pair.h:
        (WebCore::Pair::Pair):
        * css/Rect.h:
        (WebCore::Rect::Rect):
        * css/StyleBase.h:
        (WebCore::StyleBase::StyleBase):
        * css/StyleSheetList.cpp:
        (WebCore::StyleSheetList::StyleSheetList):
        * dom/Attr.cpp:
        (WebCore::Attr::Attr):
        * dom/Attr.h:
        * dom/Attribute.h:
        (WebCore::Attribute::Attribute):
        * dom/Clipboard.cpp:
        (WebCore::Clipboard::Clipboard):
        * dom/DOMImplementation.h:
        (WebCore::DOMImplementation::DOMImplementation):
        * dom/Event.cpp:
        (WebCore::Event::Event):
        * dom/EventListener.h:
        (WebCore::EventListener::EventListener):
        * dom/ExceptionBase.cpp:
        (WebCore::ExceptionBase::ExceptionBase):
        * dom/NamedAttrMap.h:
        (WebCore::NamedAttrMap::insertAttribute):
        * dom/NamedNodeMap.h:
        (WebCore::NamedNodeMap::NamedNodeMap):
        * dom/NodeFilter.h:
        (WebCore::NodeFilter::NodeFilter):
        * dom/NodeFilterCondition.h:
        (WebCore::NodeFilterCondition::NodeFilterCondition):
        * dom/NodeList.h:
        (WebCore::NodeList::NodeList):
        * dom/QualifiedName.h:
        (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl):
        (WebCore::QualifiedName::ref):
        * dom/Range.cpp:
        (WebCore::Range::Range):
        * dom/RegisteredEventListener.cpp:
        (WebCore::RegisteredEventListener::RegisteredEventListener):
        * dom/StyledElement.h:
        * dom/Traversal.cpp:
        (WebCore::Traversal::Traversal):
        * editing/EditCommand.cpp:
        (WebCore::EditCommand::EditCommand):
        * history/BackForwardList.cpp:
        (WebCore::BackForwardList::BackForwardList):
        * history/CachedPage.cpp:
        (WebCore::CachedPage::CachedPage):
        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::HistoryItem):
        * html/CanvasGradient.cpp:
        (WebCore::CanvasGradient::CanvasGradient):
        * html/CanvasPattern.cpp:
        (WebCore::CanvasPattern::CanvasPattern):
        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
        * html/CanvasStyle.cpp:
        (WebCore::CanvasStyle::CanvasStyle):
        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::HTMLCollection):
        * html/MediaError.h:
        (WebCore::MediaError::MediaError):
        * html/TimeRanges.cpp:
        (TimeRanges::TimeRanges):
        * html/TimeRanges.h:
        (WebCore::TimeRanges::TimeRanges):
        * html/VoidCallback.h:
        (WebCore::VoidCallback::VoidCallback):
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::DocumentLoader):
        * loader/FormState.cpp:
        (WebCore::FormState::FormState):
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::ResourceLoader):
        * loader/TextResourceDecoder.cpp:
        (WebCore::TextResourceDecoder::TextResourceDecoder):
        * loader/icon/IconRecord.cpp:
        (WebCore::IconRecord::IconRecord):
        * page/BarInfo.cpp:
        (WebCore::BarInfo::BarInfo):
        * page/Console.cpp:
        (WebCore::Console::Console):
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::DOMSelection):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::DOMWindow):
        * page/Frame.cpp:
        (WebCore::Frame::Frame):
        * page/History.cpp:
        (WebCore::History::History):
        * page/InspectorController.cpp:
        (WebCore::InspectorResource::InspectorResource):
        (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
        * page/Plugin.h:
        (WebCore::Plugin::Plugin):
        * page/Screen.cpp:
        (WebCore::Screen::Screen):
        * platform/ArrayImpl.cpp:
        (WebCore::ArrayImpl::ArrayPrivate::ArrayPrivate):
        * platform/DeprecatedValueListImpl.cpp:
        (WebCore::DeprecatedValueListImpl::Private::Private):
        * platform/ScrollBar.cpp:
        (WebCore::Scrollbar::Scrollbar):
        * platform/SharedBuffer.cpp:
        (WebCore::SharedBuffer::SharedBuffer):
        * platform/graphics/FontFallbackList.cpp:
        (WebCore::FontFallbackList::FontFallbackList):
        * platform/graphics/FontFamily.cpp:
        (WebCore::FontFamily::FontFamily):
        * platform/graphics/FontFamily.h:
        (WebCore::FontFamily::FontFamily):
        * platform/graphics/FontSelector.h:
        (WebCore::FontSelector::FontSelector):
        (WebCore::FontSelector::~FontSelector):
        * platform/graphics/GlyphPageTreeNode.h:
        (WebCore::GlyphPage::GlyphPage):
        * platform/graphics/mac/IconMac.mm:
        (WebCore::Icon::Icon):
        * platform/mac/FileChooserMac.mm:
        (WebCore::FileChooser::FileChooser):
        * platform/mac/PopupMenuMac.mm:
        (WebCore::PopupMenu::PopupMenu):
        * platform/mac/SharedBufferMac.mm:
        (WebCore::SharedBuffer::SharedBuffer):
        * platform/network/FormData.cpp:
        (WebCore::FormData::FormData):
        * platform/network/FormData.h:
        (WebCore::FormData::FormData):
        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::ResourceHandle):
        * platform/text/CString.h:
        (WebCore::CStringBuffer::CStringBuffer):
        * platform/text/RegularExpression.cpp:
        (WebCore::RegularExpression::Private::Private):
        * rendering/RenderStyle.cpp:
        (WebCore::StyleSurroundData::StyleSurroundData):
        (WebCore::StyleBoxData::StyleBoxData):
        (WebCore::StyleVisualData::StyleVisualData):
        (WebCore::StyleBackgroundData::StyleBackgroundData):
        (WebCore::StyleMarqueeData::StyleMarqueeData):
        (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
        (WebCore::StyleMultiColData::StyleMultiColData):
        (WebCore::StyleTransformData::StyleTransformData):
        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
        (WebCore::StyleRareInheritedData::StyleRareInheritedData):
        (WebCore::StyleInheritedData::StyleInheritedData):
        * rendering/RenderStyle.h:
        (WebCore::TransformOperation::TransformOperation):
        (WebCore::CursorList::CursorList):
        * rendering/SVGCharacterLayoutInfo.h:
        (WebCore::SVGCharOnPath::SVGCharOnPath):
        * rendering/SVGRenderStyle.cpp:
        (WebCore::SVGRenderStyle::SVGRenderStyle):
        * rendering/SVGRenderStyle.h:
        (WebCore::SVGRenderStyle::SVGRenderStyle):
        * rendering/SVGRenderStyleDefs.cpp:
        (StyleFillData::StyleFillData):
        (StyleStrokeData::StyleStrokeData):
        (StyleStopData::StyleStopData):
        (StyleTextData::StyleTextData):
        (StyleClipData::StyleClipData):
        (StyleMaskData::StyleMaskData):
        (StyleMarkerData::StyleMarkerData):
        (StyleMiscData::StyleMiscData):
        * storage/SQLResultSetRowList.h:
        (WebCore::SQLResultSetRowList::SQLResultSetRowList):
        * svg/SVGAngle.cpp:
        (WebCore::SVGAngle::SVGAngle):
        * svg/SVGAnimatedTemplate.h:
        (WebCore::SVGAnimatedTemplate::SVGAnimatedTemplate):
        * svg/SVGElementInstanceList.cpp:
        (WebCore::SVGElementInstanceList::SVGElementInstanceList):
        * svg/SVGList.h:
        (WebCore::SVGList::SVGList):
        (WebCore::SVGPODListItem::SVGPODListItem):
        * svg/SVGPathSeg.h:
        (WebCore::SVGPathSeg::SVGPathSeg):
        * svg/SVGPreserveAspectRatio.cpp:
        (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
        * svg/SVGRenderingIntent.h:
        (WebCore::SVGRenderingIntent::SVGRenderingIntent):
        * svg/SVGUnitTypes.h:
        (WebCore::SVGUnitTypes::SVGUnitTypes):
        * svg/graphics/SVGPaintServerGradient.h:
        (WebCore::SVGPaintServerGradient::SharedStopCache::SharedStopCache):
        * svg/graphics/SVGResource.cpp:
        (WebCore::SVGResource::SVGResource):
        * xml/DOMParser.h:
        (WebCore::DOMParser::DOMParser):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::XMLHttpRequest):
        * xml/XMLSerializer.h:
        (WebCore::XMLSerializer::XMLSerializer):
        * xml/XPathEvaluator.h:
        (WebCore::XPathEvaluator::XPathEvaluator):
        * xml/XPathExpression.h:
        (WebCore::XPathExpression::XPathExpression):
        * xml/XPathNSResolver.h:
        (WebCore::XPathNSResolver::XPathNSResolver):
        * xml/XPathResult.cpp:
        (WebCore::XPathResult::XPathResult):
        * xml/XPathValue.h:
        (WebCore::XPath::ValueData::ValueData):
        * xml/XSLTProcessor.h:
        (WebCore::XSLTProcessor::XSLTProcessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDon't call select() for CURL when there are no valid file descriptors.
kevino@webkit.org [Sun, 10 Feb 2008 19:02:43 +0000 (19:02 +0000)]
Don't call select() for CURL when there are no valid file descriptors.
http://bugs.webkit.org/show_bug.cgi?id=17178

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - fix http://bugs.webkit.org/show_bug.cgi?id=17274
darin@apple.com [Sun, 10 Feb 2008 18:57:31 +0000 (18:57 +0000)]
    - fix bugs.webkit.org/show_bug.cgi?id=17274
          REGRESSION: User Agent string broken in r30119

        * WebView/WebView.mm:
        (-[WebView _userAgentWithApplicationName:andWebKitVersion:]):
        Fix wrong variable name. Doh!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher.
darin@apple.com [Sun, 10 Feb 2008 07:00:06 +0000 (07:00 +0000)]
    Reviewed by Tim Hatcher.

        - fix <rdar://problem/5725996> crash every time you open the Xcode documentation window

        * WebView/WebView.mm:
        (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Work around a bug in the
        garbage collector's Objective C++ support by not initializing a static to an object
        that needs to be marked when running under GC.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-09 Alp Toker <alp@atoker.com>
alp@webkit.org [Sun, 10 Feb 2008 04:52:46 +0000 (04:52 +0000)]
2008-02-09  Alp Toker  <alp@atoker.com>

        Only syndicate Jan's WebKit posts, not his entire blog.

        * config.ini:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam Weinig.
mitz@apple.com [Sun, 10 Feb 2008 00:16:39 +0000 (00:16 +0000)]
    Reviewed by Sam Weinig.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17259
          Element::recalcStyle() needlessly null-checks the result of styleForElement()

        * dom/Element.cpp:
        (WebCore::Element::recalcStyle): Removed unneeded null checks.
        styleForElement() can never return null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
hyatt@apple.com [Sat, 9 Feb 2008 23:47:37 +0000 (23:47 +0000)]
WebCore:

        Fix for bug 17254, nth-* selectors do not work with negative coefficients.

        Reviewed by Mitz.

        fast/css/negative-nth-child.html

        * css/CSSStyleSelector.cpp:
        (WebCore::parseNth):

LayoutTests:

        Added test for bug 17254.

        Reviewed by Mitz.

        * fast/css/negative-nth-child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoThe comedy continues. Bungled the rename from Eric's review when doing the backout...
hyatt@apple.com [Sat, 9 Feb 2008 22:56:37 +0000 (22:56 +0000)]
The comedy continues. Bungled the rename from Eric's review when doing the backout of CSSStyleSelector's accidental fix for 17254.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFollowup to 17203. Missed a directory.
hyatt@apple.com [Sat, 9 Feb 2008 22:54:10 +0000 (22:54 +0000)]
Followup to 17203. Missed a directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBack out accidental change to CSSStyleSelector.cpp.
hyatt@apple.com [Sat, 9 Feb 2008 22:51:34 +0000 (22:51 +0000)]
Back out accidental change to CSSStyleSelector.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bug 17203, high CPU usage loading HTML5 spec. This patch significant...
hyatt@apple.com [Sat, 9 Feb 2008 22:49:13 +0000 (22:49 +0000)]
    Fix for bug 17203, high CPU usage loading HTML5 spec.  This patch significantly improves the performance
        of CSS3 selectors.

        (1) Split the notion of being affected by positional rules into "forward" and "backward."  The "forward"
        selectors do not need to re-resolve during parsing, since children are appended on the end.  Only the
        "backward" selectors like last-child or nth-last-child have to re-resolve when a close tag is encountered.

        (2) Extend childrenChanged to specify whether the children were changed by the parser or not.  This allows
        Element::childrenChanged to know when the parser is adding children so that it can ignore those adds when
        possible.

        (3) Make sure all Elements now know whether or not their children are currently parsing.  Backwards selectors
        like last-child will always return false when children are still being parsed.  When an Element finishes
        parsing its children, finishParsingChildren() gets called and will make sure the children re-resolve properly.

        (4) Added a beginParsingChildren method and renamed finishParsing to finishedParsingChildren.

        (5) Eliminated one-off hacks that did the same thing in HTMLObjectElement and HTMLAppletElement.

        (6) Patched many incorrect implementations of finishedParsingChildren that did not properly call into their
        base class (mostly new SVG elements that got added for SVG fonts around the time this became a requirement).

        Reviewed by Eric

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::checkSelector):
        (WebCore::CSSStyleSelector::checkOneSelector):
        * dom/Attr.cpp:
        (WebCore::Attr::childrenChanged):
        * dom/Attr.h:
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::addChild):
        * dom/Document.cpp:
        (WebCore::Document::childrenChanged):
        * dom/Document.h:
        * dom/Element.cpp:
        (WebCore::Element::Element):
        (WebCore::Element::recalcStyle):
        (WebCore::checkFirstChildRules):
        (WebCore::checkLastChildRules):
        (WebCore::checkEmptyRules):
        (WebCore::checkStyleRules):
        (WebCore::Element::childrenChanged):
        (WebCore::Element::finishParsingChildren):
        * dom/Element.h:
        (WebCore::Element::finishedParsingChildren):
        (WebCore::Element::beginParsingChildren):
        * dom/Node.cpp:
        * dom/Node.h:
        (WebCore::Node::finishParsingChildren):
        (WebCore::Node::beginParsingChildren):
        (WebCore::Node::childrenChanged):
        * dom/StyledElement.cpp:
        (WebCore::StyledElement::StyledElement):
        * dom/StyledElement.h:
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::startElementNs):
        (WebCore::XMLTokenizer::endElementNs):
        (WebCore::):
        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::HTMLAppletElement):
        (WebCore::HTMLAppletElement::finishParsingChildren):
        * html/HTMLAppletElement.h:
        * html/HTMLElementFactory.cpp:
        (WebCore::objectConstructor):
        * html/HTMLGenericFormElement.cpp:
        (WebCore::HTMLFormControlElementWithState::finishParsingChildren):
        * html/HTMLGenericFormElement.h:
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::HTMLObjectElement):
        (WebCore::HTMLObjectElement::finishParsingChildren):
        (WebCore::HTMLObjectElement::childrenChanged):
        * html/HTMLObjectElement.h:
        * html/HTMLOptGroupElement.cpp:
        (WebCore::HTMLOptGroupElement::childrenChanged):
        * html/HTMLOptGroupElement.h:
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::childrenChanged):
        * html/HTMLOptionElement.h:
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::insertNode):
        (WebCore::HTMLParser::pushBlock):
        (WebCore::HTMLParser::popOneBlockCommon):
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::childrenChanged):
        (WebCore::HTMLScriptElement::finishParsingChildren):
        * html/HTMLScriptElement.h:
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::childrenChanged):
        * html/HTMLSelectElement.h:
        * html/HTMLStyleElement.cpp:
        (WebCore::HTMLStyleElement::finishParsingChildren):
        (WebCore::HTMLStyleElement::childrenChanged):
        * html/HTMLStyleElement.h:
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::childrenChanged):
        * html/HTMLTextAreaElement.h:
        * html/HTMLTitleElement.cpp:
        (WebCore::HTMLTitleElement::childrenChanged):
        * html/HTMLTitleElement.h:
         * rendering/RenderApplet.cpp:
        (WebCore::RenderApplet::createWidgetIfNecessary):
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget):
        * rendering/RenderStyle.cpp:
        (WebCore::RenderStyle::RenderStyle):
        * rendering/RenderStyle.h:
        (WebCore::RenderStyle::childrenAffectedByForwardPositionalRules):
        (WebCore::RenderStyle::setChildrenAffectedByForwardPositionalRules):
        (WebCore::RenderStyle::childrenAffectedByBackwardPositionalRules):
        (WebCore::RenderStyle::setChildrenAffectedByBackwardPositionalRules):
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::finishParsingChildren):
        * svg/SVGAnimationElement.h:
        * svg/SVGClipPathElement.cpp:
        (WebCore::SVGClipPathElement::childrenChanged):
        * svg/SVGClipPathElement.h:
        * svg/SVGDefinitionSrcElement.cpp:
        (WebCore::SVGDefinitionSrcElement::childrenChanged):
        * svg/SVGDefinitionSrcElement.h:
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::finishParsingChildren):
        * svg/SVGElement.h:
        * svg/SVGFontFaceElement.cpp:
        (WebCore::SVGFontFaceElement::childrenChanged):
        * svg/SVGFontFaceElement.h:
        * svg/SVGFontFaceFormatElement.cpp:
        (WebCore::SVGFontFaceFormatElement::childrenChanged):
        * svg/SVGFontFaceFormatElement.h:
        * svg/SVGFontFaceSrcElement.cpp:
        (WebCore::SVGFontFaceSrcElement::childrenChanged):
        * svg/SVGFontFaceSrcElement.h:
        * svg/SVGFontFaceUriElement.cpp:
        (WebCore::SVGFontFaceUriElement::childrenChanged):
        * svg/SVGFontFaceUriElement.h:
        * svg/SVGGElement.cpp:
        (WebCore::SVGGElement::childrenChanged):
        * svg/SVGGElement.h:
        * svg/SVGGradientElement.cpp:
        (WebCore::SVGGradientElement::childrenChanged):
        * svg/SVGGradientElement.h:
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::childrenChanged):
        * svg/SVGMarkerElement.h:
        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::childrenChanged):
        * svg/SVGMaskElement.h:
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::childrenChanged):
        * svg/SVGPatternElement.h:
        * svg/SVGStyleElement.cpp:
        (WebCore::SVGStyleElement::finishParsingChildren):
        (WebCore::SVGStyleElement::childrenChanged):
        * svg/SVGStyleElement.h:
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::childrenChanged):
        * svg/SVGStyledElement.h:
        * svg/SVGTitleElement.cpp:
        (WebCore::SVGTitleElement::childrenChanged):
        * svg/SVGTitleElement.h:
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::childrenChanged):
        * svg/SVGUseElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-09 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
zecke@webkit.org [Sat, 9 Feb 2008 22:38:42 +0000 (22:38 +0000)]
2008-02-09  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>

        Unreviewed build fix

        Somehow the removal of adjustSliderThumbSize(RenderObject*) sneaked
        into the patch.

        * platform/qt/RenderThemeQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-09 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
zecke@webkit.org [Sat, 9 Feb 2008 22:16:53 +0000 (22:16 +0000)]
2008-02-09  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>

        Reviewed by Adele.

        paintResizeControl is dead, remove the code. This painting
        is done by the RenderLayer.

        * platform/qt/RenderThemeQt.cpp:
        * platform/qt/RenderThemeQt.h:
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
darin@apple.com [Sat, 9 Feb 2008 18:09:42 +0000 (18:09 +0000)]
    Reviewed by Mitz.

        - http://bugs.webkit.org/show_bug.cgi?id=17256
          Change RegExp to start its ref count at 1, not 0

        We'll want to do this to every RefCounted class, one at a time.

        * kjs/nodes.h:
        (KJS::RegExpNode::RegExpNode): Use RegExp::create instead of new RegExp.
        * kjs/regexp.cpp:
        (KJS::RegExp::RegExp): Marked inline, set initial ref count to 1.
        (KJS::RegExp::create): Added. Calls new RegExp then adopts the initial ref.
        * kjs/regexp.h: Reformatted. Made the constructors private. Added static
        create functions that return objects already wrapped in PassRefPtr.
        * kjs/regexp_object.cpp:
        (KJS::regExpProtoFuncCompile): Use RegExp::create instead of new RegExp.
        (KJS::RegExpObjectImp::construct): Ditto.
        * kjs/string_object.cpp:
        (KJS::stringProtoFuncMatch): Ditto.
        (KJS::stringProtoFuncSearch): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMSVC7 fixes.
kevino@webkit.org [Sat, 9 Feb 2008 08:13:39 +0000 (08:13 +0000)]
MSVC7 fixes.
http://bugs.webkit.org/show_bug.cgi?id=17211

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-08 Brent Fulgham <bfulgham@gmail.com>
mrowe@apple.com [Sat, 9 Feb 2008 06:47:58 +0000 (06:47 +0000)]
2008-02-08  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Adam Roben.

        Bug 17226: Fix Windows (Cairo) build of image-decoders
        http://bugs.webkit.org/show_bug.cgi?id=17226

        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        * platform/image-decoders/png/PNGImageDecoder.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-08 Alp Toker <alp@atoker.com>
alp@webkit.org [Sat, 9 Feb 2008 05:44:24 +0000 (05:44 +0000)]
2008-02-08  Alp Toker  <alp@atoker.com>

        Rubber-stamped by Maciej.

        Bump autoconf CAIRO_REQUIRED_VERSION up to 1.4.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/5731773> REGRESSION (r28973): Extraneous parentheses in function...
oliver@apple.com [Sat, 9 Feb 2008 05:17:06 +0000 (05:17 +0000)]
<rdar://problem/5731773> REGRESSION (r28973): Extraneous parentheses in function.toString()
https://bugs.webkit.org/show_bug.cgi?id=17214

Reviewed by Maciej

Make a subclass of CommaNode to provide the correct precedence for each expression in
a variable declaration list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady Eidson.
timothy@apple.com [Sat, 9 Feb 2008 04:15:27 +0000 (04:15 +0000)]
    Reviewed by Brady Eidson.

        <rdar://problem/5640896> Removing database then trying
        to recreate it causes trouble

        Added open Database support to DatabaseTracker. So any Database that
        is deleted will be marked as deleted and will fail to open any transaction
        or execute any new SQL queries.

        * storage/Database.cpp:
        (WebCore::Database::Database): Call DatabaseTracker::addOpenDatabase.
        (WebCore::Database::~Database): Call DatabaseTracker::removeOpenDatabase.
        (WebCore::Database::markAsDeleted): Set the m_deleted flag.
        (WebCore::Database::version): Return a null String if m_deleted is true.
        * storage/Database.h:
        (WebCore::Database::deleted): Return m_deleted.
        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::addOpenDatabase): Add the Database to a map of origins and names.
        (WebCore::DatabaseTracker::removeOpenDatabase): Remove the Database from the map.
        (WebCore::DatabaseTracker::deleteDatabaseFile): Call markAsDeleted on all the open Databases
          matching the origin/name.
        * storage/DatabaseTracker.h:
        * storage/SQLStatement.cpp:
        (WebCore::SQLStatement::setDatabaseDeletedError): Set the error about the user deleting the database.
        * storage/SQLStatement.h:
        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::executeSQL): If the Database is deleted, call setDatabaseDeletedError.
        (WebCore::SQLTransaction::openTransactionAndPreflight): Set the error about the user deleting the database
          if the Database was marked as deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
darin@apple.com [Sat, 9 Feb 2008 01:13:46 +0000 (01:13 +0000)]
JavaScriptCore:

        Reviewed by Oliver.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17247
          Labelled continue/break can fail in some cases

        Test: fast/js/continue-break-multiple-labels.html

        * kjs/nodes.h:
        (KJS::StatementNode::pushLabel): Made this virtual.
        (KJS::LabelNode::pushLabel): Forward pushLabel calls to the statement inside.

LayoutTests:

        - test for http://bugs.webkit.org/show_bug.cgi?id=17247
          Labelled continue/break can fail in some cases

        * fast/js/continue-break-multiple-labels-expected.txt: Added.
        * fast/js/continue-break-multiple-labels.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30103 268f45cc-cd09-0410-ab3c-d52691b4dbfc