WebKit-https.git
9 years ago2011-02-02 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Wed, 2 Feb 2011 18:55:35 +0000 (18:55 +0000)]
2011-02-02  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Landing detailed heap snapshots, part 2.

        https://bugs.webkit.org/show_bug.cgi?id=53606

        Display progress while taking a snapshot, and hints while loading
        and parsing. This is needed because taking detailed heap snapshots
        takes time.

        * English.lproj/localizedStrings.js:
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._reset):
        (WebInspector.ProfilesPanel.prototype._addProfileHeader):
        (WebInspector.ProfilesPanel.prototype.getProfiles):
        (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
        * inspector/front-end/SidebarTreeElement.js:
        (WebInspector.SidebarTreeElement.prototype.refreshTitles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Sam Weinig.
ap@apple.com [Wed, 2 Feb 2011 18:51:57 +0000 (18:51 +0000)]
    Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=53561
        <rdar://problem/8900228> Stepping through print previews in WebKit2 mode steps in and out of
        printing mode a lot

        Disable NSView autodisplay, so that -[WKView drawRect:] isn't called (other than when
        resizing the window), so that we don't have to switch modes all the time.

        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::setAutodisplay):
        * UIProcess/PageClient.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::setAutodisplay):
        * UIProcess/WebPageProxy.h:
        Pipe the call from WKPrintingView down to WKView.

        * UIProcess/API/mac/WKPrintingView.mm:
        (-[WKPrintingView beginDocument]): Added. We don't want to autodisplay WKView while printing,
        because layout is changed to print at the time, and drawing to screen requires relayout.

        (-[WKPrintingView endDocument]): When not printing, turn autodisplay back on. Also, call
        -[super endDocument] for unknown but definitive good (oops!).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore conversion from right()/bottom() to maxX()/maxY().
hyatt@apple.com [Wed, 2 Feb 2011 18:35:41 +0000 (18:35 +0000)]
More conversion from right()/bottom() to maxX()/maxY().

Reviewed by Darin Adler.

* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoval of right()/bottom(). Replace with maxX() and maxY(). Still converting....
hyatt@apple.com [Wed, 2 Feb 2011 18:32:56 +0000 (18:32 +0000)]
Removal of right()/bottom().  Replace with maxX() and maxY().  Still converting.  Haven't removed yet.

Reviewed by Darin Adler.

* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::layout):
* platform/graphics/FloatRect.h:
* platform/graphics/IntRect.h:
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::GLES2Canvas::drawTexturedRect):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::verticalScrollbarRect):
(WebCore::LayerRendererChromium::horizontalScrollbarRect):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::setDrawViewportRect):
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::contentRectToTileIndices):
(WebCore::LayerTilerChromium::growLayerToContain):
* platform/graphics/gpu/TilingData.cpp:
(WebCore::TilingData::tileBoundsWithBorder):
(WebCore::TilingData::overlappedTileIndices):
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
* platform/graphics/skia/FloatRectSkia.cpp:
(WebCore::FloatRect::operator SkRect):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
* platform/graphics/skia/IntRectSkia.cpp:
(WebCore::IntRect::operator SkIRect):
(WebCore::IntRect::operator SkRect):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::beginLayerClippedToImage):
* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContextPlatformPrivate::clip):
* platform/graphics/win/IntRectWin.cpp:
(WebCore::IntRect::operator RECT):
* platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::shapeAndPlaceItem):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::roundRect):
(WebCore::mapRect):
(WebCore::TransparentLayerDC::TransparentLayerDC):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::strokeRect):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::initFrameBuffer):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::invalidateRect):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintMenuListButton):
(WebCore::RenderThemeSafari::paintSliderTrack):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::paintInnerSpinButton):
(WebCore::RenderThemeWin::paintMenuListButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 2 Feb 2011 18:30:59 +0000 (18:30 +0000)]
2011-02-01  Darin Fisher  <darin@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Avoid #ifdefs in code that constructs a GraphicsContext by
        adding a helper class.
        https://bugs.webkit.org/show_bug.cgi?id=53575

        * WebKit.gyp:
        * src/WebFontImpl.cpp:
        (WebKit::WebFontImpl::drawText):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::printPage):
        (WebKit::WebFrameImpl::paint):
        * src/WebPopupMenuImpl.cpp:
        (WebKit::WebPopupMenuImpl::paint):
        * src/WebScrollbarImpl.cpp:
        (WebKit::WebScrollbarImpl::paint):
        * src/painting: Added.
        * src/painting/GraphicsContextBuilder.h: Added.
        (WebKit::GraphicsContextBuilder::GraphicsContextBuilder):
        (WebKit::GraphicsContextBuilder::context):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoval of right()/bottom(), converting to maxX()/maxY().
hyatt@apple.com [Wed, 2 Feb 2011 18:30:27 +0000 (18:30 +0000)]
Removal of right()/bottom(), converting to maxX()/maxY().

Reviewed by Darin Adler.

../WebKit/gtk:

* webkit/webkitwebview.cpp:
(webkit_web_view_popup_menu_handler):

../WebKit/win:

* DOMHTMLClasses.cpp:
(DOMHTMLInputElement::rectOnScreen):
* WebCoreSupport/EmbeddedWidget.cpp:
(EmbeddedWidget::frameRectsChanged):
* WebFrame.cpp:
(WebFrame::computePageRects):
* WebScrollBar.cpp:
(WebScrollBar::frameRect):
* WebView.cpp:
(WebView::addToDirtyRegion):
(WebView::visibleContentRect):
(WebView::prepareCandidateWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConversion of right()/bottom() to maxX()/maxY() as part of the removal of those acces...
hyatt@apple.com [Wed, 2 Feb 2011 18:29:28 +0000 (18:29 +0000)]
Conversion of right()/bottom() to maxX()/maxY() as part of the removal of those accessors.

Reviewed by Darin Adler.

* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::calculatePositionAndSize):
* UIProcess/win/WebView.cpp:
(WebKit::WebView::prepareCandidateWindow):
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::platformGeometryDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 2 Feb 2011 18:06:27 +0000 (18:06 +0000)]
2011-02-02  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] po files path update after the code moved to Source
        https://bugs.webkit.org/show_bug.cgi?id=53599

        * POTFILES: Add Source to the path of the files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 2 Feb 2011 18:05:28 +0000 (18:05 +0000)]
2011-02-01  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add test for OPTIONS requests caused by CORS preflight checking to appear in Network panel
        https://bugs.webkit.org/show_bug.cgi?id=53501

        * http/tests/inspector/network-preflight-options-expected.txt: Added.
        * http/tests/inspector/network-preflight-options.html: Added.
        * http/tests/inspector/resources/cors-target.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 2 Feb 2011 17:59:24 +0000 (17:59 +0000)]
2011-02-01  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        Overflow in WebKit2 argument decoder buffer checking
        https://bugs.webkit.org/show_bug.cgi?id=53536

        * Platform/CoreIPC/ArgumentDecoder.cpp:
        (CoreIPC::roundUpToAlignment): Tweak code a bit for clarity and to replace
        C casts with C++ casts.
        (CoreIPC::ArgumentDecoder::alignBufferPosition): Rearrange buffer calculation
        so we don't do any math with the passed-in size, because that could overflow.
        (CoreIPC::ArgumentDecoder::bufferIsLargeEnoughToContain): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 2 Feb 2011 17:00:06 +0000 (17:00 +0000)]
2011-02-02  Martin Robinson  <mrobinson@igalia.com>

        Skip another test that uses modal dialogs.

        * platform/gtk/Skipped: Skip modal dialog test and update bug in the skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse Vector instead of a linked list for rules in CSSStyleSelector
antti@apple.com [Wed, 2 Feb 2011 15:00:55 +0000 (15:00 +0000)]
Use Vector instead of a linked list for rules in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=53581

Reviewed by Maciej Stachowiak.

- eliminate CSSRuleDataList, replace with Vector<RuleData>
- rename CSSRuleData -> RuleData and CSSRuleSet -> RuleSet
  (these are selector internal classes, CSS prefix is better reserved for public ones).
- constify a bit
- shrink the vectors to fit after collecting the rules

* css/CSSStyleSelector.cpp:
(WebCore::RuleData::RuleData):
(WebCore::RuleData::position):
(WebCore::RuleData::rule):
(WebCore::RuleData::selector):
(WebCore::RuleSet::disableAutoShrinkToFit):
(WebCore::RuleSet::getIDRules):
(WebCore::RuleSet::getClassRules):
(WebCore::RuleSet::getTagRules):
(WebCore::RuleSet::getPseudoRules):
(WebCore::RuleSet::getUniversalRules):
(WebCore::RuleSet::getPageRules):
(WebCore::collectSiblingRulesInDefaultStyle):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::loadFullDefaultStyle):
(WebCore::loadSimpleDefaultStyle):
(WebCore::loadViewSourceStyle):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::operator >):
(WebCore::operator <=):
(WebCore::CSSStyleSelector::sortMatchedRules):
(WebCore::CSSStyleSelector::matchUARules):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::~RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addPageRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::RuleSet::addStyleRule):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::RuleSet::collectIdsAndSiblingRules):
(WebCore::shrinkMapVectorsToFit):
(WebCore::RuleSet::shrinkToFit):
(WebCore::CSSStyleSelector::matchPageRules):
(WebCore::CSSStyleSelector::matchPageRulesForList):
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::addMatchedRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Wed, 2 Feb 2011 14:08:21 +0000 (14:08 +0000)]
2011-02-02  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Use DIVs instead of TABLE in TextViewer
        https://bugs.webkit.org/show_bug.cgi?id=53299

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._createTextViewer):
        (WebInspector.SourceFrame.prototype._mouseDown):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer):
        (WebInspector.TextViewer.prototype.set mimeType):
        (WebInspector.TextViewer.prototype.revealLine):
        (WebInspector.TextViewer.prototype.addDecoration):
        (WebInspector.TextViewer.prototype.removeDecoration):
        (WebInspector.TextViewer.prototype.markAndRevealRange):
        (WebInspector.TextViewer.prototype.highlightLine):
        (WebInspector.TextViewer.prototype.clearLineHighlight):
        (WebInspector.TextViewer.prototype.freeCachedElements):
        (WebInspector.TextViewer.prototype._handleKeyDown):
        (WebInspector.TextViewer.prototype.editLine.finishEditing):
        (WebInspector.TextViewer.prototype.editLine):
        (WebInspector.TextViewer.prototype.beginUpdates):
        (WebInspector.TextViewer.prototype.endUpdates):
        (WebInspector.TextViewer.prototype.resize):
        (WebInspector.TextViewer.prototype._textChanged):
        (WebInspector.TextViewer.prototype._updatePanelOffsets):
        (WebInspector.TextViewer.prototype._syncScroll):
        (WebInspector.TextViewer.prototype._syncDecorationsForLine):
        (WebInspector.TextEditorChunkedPanel):
        (WebInspector.TextEditorChunkedPanel.prototype.set syncScrollListener):
        (WebInspector.TextEditorChunkedPanel.prototype.get textModel):
        (WebInspector.TextEditorChunkedPanel.prototype.addDecoration):
        (WebInspector.TextEditorChunkedPanel.prototype.removeDecoration):
        (WebInspector.TextEditorChunkedPanel.prototype.revealLine):
        (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
        (WebInspector.TextEditorChunkedPanel.prototype.textChanged):
        (WebInspector.TextEditorChunkedPanel.prototype.beginUpdates):
        (WebInspector.TextEditorChunkedPanel.prototype.endUpdates):
        (WebInspector.TextEditorChunkedPanel.prototype.resize):
        (WebInspector.TextEditorChunkedPanel.prototype._scroll):
        (WebInspector.TextEditorChunkedPanel.prototype._scheduleRepaintAll):
        (WebInspector.TextEditorChunkedPanel.prototype._buildChunks):
        (WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
        (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
        (WebInspector.TextEditorChunkedPanel.prototype._chunkForLine):
        (WebInspector.TextEditorGutterPanel):
        (WebInspector.TextEditorGutterPanel.prototype.freeCachedElements):
        (WebInspector.TextEditorGutterPanel.prototype._createNewChunk):
        (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
        (WebInspector.TextEditorGutterChunk):
        (WebInspector.TextEditorGutterChunk.prototype.get expanded):
        (WebInspector.TextEditorGutterChunk.prototype.set expanded):
        (WebInspector.TextEditorGutterChunk.prototype.get height):
        (WebInspector.TextEditorGutterChunk.prototype._createRow):
        (WebInspector.TextEditorMainPanel):
        (WebInspector.TextEditorMainPanel.prototype.set syncDecorationsForLine):
        (WebInspector.TextEditorMainPanel.prototype.set mimeType):
        (WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
        (WebInspector.TextEditorMainPanel.prototype.highlightLine):
        (WebInspector.TextEditorMainPanel.prototype.clearLineHighlight):
        (WebInspector.TextEditorMainPanel.prototype.freeCachedElements):
        (WebInspector.TextEditorMainPanel.prototype._buildChunks):
        (WebInspector.TextEditorMainPanel.prototype._createNewChunk):
        (WebInspector.TextEditorMainPanel.prototype._expandChunks):
        (WebInspector.TextEditorMainPanel.prototype._highlightDataReady):
        (WebInspector.TextEditorMainPanel.prototype._paintLines):
        (WebInspector.TextEditorMainPanel.prototype._paintLine):
        (WebInspector.TextEditorMainPanel.prototype._releaseLinesHighlight):
        (WebInspector.TextEditorMainPanel.prototype._getSelection):
        (WebInspector.TextEditorMainPanel.prototype._restoreSelection):
        (WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
        (WebInspector.TextEditorMainPanel.prototype._positionToSelection):
        (WebInspector.TextEditorMainPanel.prototype._appendTextNode):
        (WebInspector.TextEditorMainPanel.prototype._handleDomUpdates):
        (WebInspector.TextEditorMainChunk):
        (WebInspector.TextEditorMainChunk.prototype.addDecoration):
        (WebInspector.TextEditorMainChunk.prototype.set expanded):
        (WebInspector.TextEditorMainChunk.prototype.get height):
        (WebInspector.TextEditorMainChunk.prototype.getExpandedLineRow):
        (WebInspector.TextEditorMainChunk.prototype._createRow):
        (WebInspector):
        * inspector/front-end/textViewer.css:
        (.text-editor-lines):
        (.text-editor-contents):
        (.text-editor-editable):
        (.webkit-line-decorations):
        (.webkit-line-number):
        (.webkit-execution-line.webkit-line-content):
        (.diff-container .webkit-added-line.webkit-line-content):
        (.diff-container .webkit-removed-line.webkit-line-content):
        (.diff-container .webkit-changed-line.webkit-line-content):
        (.webkit-highlighted-line.webkit-line-content):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 2 Feb 2011 13:55:01 +0000 (13:55 +0000)]
2011-02-02  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Removed some custom Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Wed, 2 Feb 2011 10:10:54 +0000 (10:10 +0000)]
2011-02-02  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Implement support for cursor updates
        https://bugs.webkit.org/show_bug.cgi?id=53421

        Layout test for cursor updates.

        * storage/indexeddb/cursor-update-expected.txt: Added.
        * storage/indexeddb/cursor-update.html: Added.
2011-02-02  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Implement support for cursor updates
        https://bugs.webkit.org/show_bug.cgi?id=53421

        Implement support for cursor updates using the same pattern as cursor
        deletes: forward the calls to the IDBObjectStoreBackend::put().
        The put() function's signature needs to be changed to allow for a
        "cursor update mode". This makes the signature more clear anyway,
        since it replaces the boolean parameter.

        Test: storage/indexeddb/cursor-update.html

        * storage/IDBCursor.idl:
        * storage/IDBCursorBackendImpl.cpp:
        (WebCore::IDBCursorBackendImpl::key):
        (WebCore::IDBCursorBackendImpl::update):
        * storage/IDBCursorBackendImpl.h:
        * storage/IDBObjectStore.cpp:
        (WebCore::IDBObjectStore::add):
        (WebCore::IDBObjectStore::put):
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::put):
        (WebCore::IDBObjectStoreBackendImpl::putInternal):
        * storage/IDBObjectStoreBackendImpl.h:
        * storage/IDBObjectStoreBackendInterface.h:
2011-02-02  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Implement support for cursor updates
        https://bugs.webkit.org/show_bug.cgi?id=53421

        Mirror the update to the IDBObjectStoreInterface::put() signature in
        the WebKit layer wrappers.

        * public/WebIDBObjectStore.h:
        (WebKit::WebIDBObjectStore::put):
        * src/IDBObjectStoreProxy.cpp:
        (WebCore::IDBObjectStoreProxy::put):
        * src/IDBObjectStoreProxy.h:
        * src/WebIDBObjectStoreImpl.cpp:
        (WebKit::WebIDBObjectStoreImpl::put):
        * src/WebIDBObjectStoreImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Naoki Takano <takano.naoki@gmail.com>
commit-queue@webkit.org [Wed, 2 Feb 2011 08:50:41 +0000 (08:50 +0000)]
2011-02-02  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Kent Tamura.

        Fix popup menu RTL bug introduced by Changeset 75982.
        https://bugs.webkit.org/show_bug.cgi?id=53567

        PopupMenuChromium::layout() calculates X position according to RTL or not. So Change the X position calculation in layoutAndCalculateWidgetRect().

        No new tests. However we can check manually with select_dropdown_box_alignment.html, autofill_alignment.html, select_alignment.html, select_dropdown_box_alignment.html, autofill-popup-width-and-item-direction.html

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Fix calculation of x position, because layout() considers RTL. And change the parameter from both X and Y positions to only Y position.
        (WebCore::PopupContainer::showPopup): Change the passing parameter.
        (WebCore::PopupContainer::refresh): Change the passing parameter.
        * platform/chromium/PopupMenuChromium.h: Change the parameter declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 2 Feb 2011 08:49:32 +0000 (08:49 +0000)]
2011-02-02  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fix dist compilation
        https://bugs.webkit.org/show_bug.cgi?id=53579

        * GNUmakefile.am: Added WriteBarrier.h to the sources, it was
        added in r77151

2011-02-02  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fix dist compilation
        https://bugs.webkit.org/show_bug.cgi?id=53579

        * GNUmakefile.am: Added FontWidthVariant.h to the sources, it was
        added in r77153.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Dai Mikurube <dmikurube@google.com>
commit-queue@webkit.org [Wed, 2 Feb 2011 08:24:08 +0000 (08:24 +0000)]
2011-02-02  Dai Mikurube  <dmikurube@google.com>

        Reviewed by David Levin.

        Make mime type lookup in File::create(path) thread-safe
        https://bugs.webkit.org/show_bug.cgi?id=47700

        This patch introduces a new function MIMETypeRegistry::getMIMETypeForExtensionThreadSafe().
        The function is to be called as a thread-safe version of getMIMETypeForExtension() when
        both FILE_SYSTEM and WORKERS are enabled.

        No tests for this patch. This patch itself doesn't change the behaviors.
        For Chromium, it runs in the same way with getMIMETypeForExtensionThreadSafe().
        For the other platforms, it causes compilation error in case of enabled FILE_SYSTEM and WORKERS.
        The compilation error would be a signal to implement getMIMETypeForExtensionThreadSafe() in these
        platforms. Currently it doesn't happen since FILE_SYSTEM is not available in the other platforms.

        * platform/MIMETypeRegistry.cpp: Defined generic getMIMETypeForExtension() calling getMIMETypeForExtensionThreadSafe() for enabled FILE_SYSTEM and WORKERS.
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        * platform/MIMETypeRegistry.h: Declared getMIMETypeForExtensionThreadSafe() which should be implemented for each platform.
        * platform/android/TemporaryLinkStubs.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        * platform/brew/MIMETypeRegistryBrew.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        * platform/chromium/MIMETypeRegistryChromium.cpp: Defined getMIMETypeForExtensionThreadSafe() for the case when FILE_SYSTEM and WORKERS are enabled.
        (WebCore::MIMETypeRegistry::getMIMETypeForExtensionThreadSafe):
        * platform/efl/MIMETypeRegistryEfl.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        * platform/gtk/MIMETypeRegistryGtk.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        * platform/haiku/MIMETypeRegistryHaiku.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        * platform/mac/MIMETypeRegistryMac.mm:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        * platform/qt/MIMETypeRegistryQt.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        * platform/win/MIMETypeRegistryWin.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        * platform/wince/MIMETypeRegistryWinCE.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        * platform/wx/MimeTypeRegistryWx.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-02 Chris Evans <cevans@chromium.org>
commit-queue@webkit.org [Wed, 2 Feb 2011 08:13:41 +0000 (08:13 +0000)]
2011-02-02  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        [Chromium] Propagate the accurate gesture status when calling into FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=53571

        * src/WebPluginContainerImpl.cpp:
        (WebKit::WebPluginContainerImpl::loadFrameRequest): FrameLoader might decide the target is a new window, so make such the UserGestureIndicator is fully accurate before calling into it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 2 Feb 2011 08:00:19 +0000 (08:00 +0000)]
2011-02-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Improve readability of updateWidget by converting bool parameter to an enum
        https://bugs.webkit.org/show_bug.cgi?id=53576

        As requested on webkit-dev.

        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::updateWidget):
        * html/HTMLEmbedElement.h:
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::updateWidget):
        * html/HTMLMediaElement.h:
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::updateWidget):
        * html/HTMLObjectElement.h:
        * html/HTMLPlugInImageElement.cpp:
        (WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):
        * html/HTMLPlugInImageElement.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::updateWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Wed, 2 Feb 2011 07:06:51 +0000 (07:06 +0000)]
Unreviewed.

Fix Qt build after r77339.

* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::enterAcceleratedCompositingMode):
(QWKPagePrivate::exitAcceleratedCompositingMode):
* UIProcess/API/qt/qwkpage_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 James Robinson <jamesr@chromium.org>
commit-queue@webkit.org [Wed, 2 Feb 2011 07:02:52 +0000 (07:02 +0000)]
2011-02-01  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        [v8] Increase V8 native->js recursion limit to match document.write() recursion limit
        https://bugs.webkit.org/show_bug.cgi?id=53566

        Unskip test that we now pass.

        * platform/chromium/test_expectations.txt:
2011-02-01  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        [v8] Increase V8 native->js recursion limit to match document.write() recursion limit
        https://bugs.webkit.org/show_bug.cgi?id=53566

        A recursion limit of 22 is necessary to pass fast/dom/Document/document-write-recursion.html.
        Other than being large enough for this one test case, this limit is arbitrary.

        * bindings/v8/V8Proxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 2 Feb 2011 06:00:17 +0000 (06:00 +0000)]
2011-02-01  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        make draft comments focusable
        https://bugs.webkit.org/show_bug.cgi?id=53554

        Makes frozen draft comments focusable. The ones that are currently being edited are not.
        I'm on the fence whether they should be, but this seems good enough for now.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 2 Feb 2011 05:17:38 +0000 (05:17 +0000)]
2011-02-01  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        avoid jitter when loading the comments to a patch
        https://bugs.webkit.org/show_bug.cgi?id=53570

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 2 Feb 2011 05:13:39 +0000 (05:13 +0000)]
2011-02-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Andreas Kling.

        Remove useless comment
        https://bugs.webkit.org/show_bug.cgi?id=53549

        The reason for this parameter is captured in
        plugins/netscape-plugin-setwindow-size.html, which is a better place to
        capture it than in this comment (which otherwise just re-iterates the
        name of the parameter).

        * html/HTMLPlugInImageElement.cpp:
        (WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
ggaren@apple.com [Wed, 2 Feb 2011 05:05:55 +0000 (05:05 +0000)]
2011-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r77297.
        http://trac.webkit.org/changeset/77297
        https://bugs.webkit.org/show_bug.cgi?id=53538

        caused leopard crashes (Requested by paroga on #webkit).

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * wtf/text/AtomicString.cpp:
        (WTF::AtomicString::fromUTF8):
        * wtf/unicode/UTF8.cpp:
        (WTF::Unicode::calculateStringHashFromUTF8):
        * wtf/unicode/UTF8.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 2 Feb 2011 03:02:04 +0000 (03:02 +0000)]
2011-02-01  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        fast/css/box-shadow.html was removed in r77101 but there was
        still a reference to it in the expectations file.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Wed, 2 Feb 2011 02:57:35 +0000 (02:57 +0000)]
2011-02-01  James Simonsen  <simonjam@chromium.org>

        Reviewed by Tony Gentilcore.

        [WebTiming] Remove asserts that verify timestamp order
        https://bugs.webkit.org/show_bug.cgi?id=53548

        Covered by existing tests.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stopLoading): Remove assert.
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchTimedEvent): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 2 Feb 2011 02:50:21 +0000 (02:50 +0000)]
2011-02-01  Dimitri Glazkov  <dglazkov@chromium.org>

        Add the 'default_targets' enclosure to the flags.

        * WebCore.gyp/WebCore.gyp: Did it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 2 Feb 2011 02:39:31 +0000 (02:39 +0000)]
2011-02-01  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by James Robinson.

        Async event handlers should not fire within a modal dialog
        https://bugs.webkit.org/show_bug.cgi?id=53202

        Add tests for a scroll event triggered right before a modal dialog is
        shown.

        * fast/events/scroll-event-during-modal-dialog-expected.txt: Added.
        * fast/events/scroll-event-during-modal-dialog.html: Added.
2011-02-01  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by James Robinson.

        Async event handlers should not fire within a modal dialog
        https://bugs.webkit.org/show_bug.cgi?id=53202

        Asychronous events that use EventQueue would currently fire while a
        modal dialog (e.g. window.alert()) was up. Change EventQueue to use a
        SuspendableTimer (which automatically gets suspended while dialogs are
        up and in other cases where JS execution is not allowed).

        Test: fast/events/scroll-event-during-modal-dialog.html

        * dom/Document.cpp:
        (WebCore::Document::Document):
        * dom/EventQueue.cpp:
        (WebCore::EventQueueTimer::EventQueueTimer):
        (WebCore::EventQueueTimer::fired):
        (WebCore::EventQueue::EventQueue):
        (WebCore::EventQueue::enqueueEvent):
        (WebCore::EventQueue::pendingEventTimerFired):
        * dom/EventQueue.h:
        (WebCore::EventQueue::create):
        * page/SuspendableTimer.cpp:
        (WebCore::SuspendableTimer::SuspendableTimer):
        (WebCore::SuspendableTimer::suspend):
        (WebCore::SuspendableTimer::resume):
        * page/SuspendableTimer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 2 Feb 2011 02:32:22 +0000 (02:32 +0000)]
2011-02-01  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        new-run-webkit-tests: stop skipping so many tests

        r77163 introduced a regression where we weren't resetting test
        expectations properly and were skipping too many tests as a
        result. This patch fixes that and adds a test for it.

        https://bugs.webkit.org/show_bug.cgi?id=53551

        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 2 Feb 2011 02:18:20 +0000 (02:18 +0000)]
2011-02-01  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        Change wrong PLATFORM(WIN) to USE(WININET)
        https://bugs.webkit.org/show_bug.cgi?id=53547

        * platform/network/ResourceHandle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago32-bit build fix.
bdakin@apple.com [Wed, 2 Feb 2011 02:05:59 +0000 (02:05 +0000)]
32-bit build fix.

* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 2 Feb 2011 01:53:27 +0000 (01:53 +0000)]
2011-02-01  Kent Tamura  <tkent@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Roll Chromium revision for the WebKitWeightWatcher change
        https://bugs.webkit.org/show_bug.cgi?id=53563

        * platform/chromium/test_expectations.txt:
          fast/css/font-weight-1.html is expected to fail.
2011-02-01  Kent Tamura  <tkent@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Roll Chromium revision for the WebKitWeightWatcher change
        https://bugs.webkit.org/show_bug.cgi?id=53563

        * DEPS: Roll to crrev.com/73378 to have the WebKitWeightWatcher change of webkit_support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 2 Feb 2011 01:49:59 +0000 (01:49 +0000)]
2011-02-01  Dimitri Glazkov  <dglazkov@chromium.org>

        Marking test, added in r77333 as skipped, because it is
        reaching V8 recursion limits faster than those on Document.

        * platform/chromium/test_expectations.txt: See above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 2 Feb 2011 01:45:48 +0000 (01:45 +0000)]
2011-02-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Attach the layer tree in the UI process
        https://bugs.webkit.org/show_bug.cgi?id=53560

        * UIProcess/API/mac/WKView.mm:
        (-[WKView _enterAcceleratedCompositingMode:]):
        Make a render layer and add it as a sublayer of our root layer.

        * WebProcess/WebPage/mac/LayerTreeHostMac.h:
        Make LayerTreeHostMac a GraphicsLayerClient.

        * WebProcess/WebPage/mac/LayerTreeHostMac.mm:
        (WebKit::LayerTreeHostMac::LayerTreeHostMac):
        Create a root layer, add the layer subtree as a child of the root layer.

        (WebKit::LayerTreeHostMac::~LayerTreeHostMac):
        Assert that m_rootLayer is null.

        (WebKit::LayerTreeHostMac::invalidate):
        Null out m_rootLayer.

        (WebKit::LayerTreeHostMac::notifyAnimationStarted):
        (WebKit::LayerTreeHostMac::notifySyncRequired):
        (WebKit::LayerTreeHostMac::paintContents):
        Add stubs.

        (WebKit::LayerTreeHostMac::showDebugBorders):
        (WebKit::LayerTreeHostMac::showRepaintCounter):
        Return the correct settings.

        (WebKit::LayerTreeHostMac::flushPendingLayerChanges):
        Flush the root layer changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-25 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 2 Feb 2011 01:31:28 +0000 (01:31 +0000)]
2011-01-25  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Two tests crash after r76555
        https://bugs.webkit.org/show_bug.cgi?id=53057

        * platform/gtk/Skipped: Unskip tests which are no longer crashing.
2011-01-25  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Two tests crash after r76555
        https://bugs.webkit.org/show_bug.cgi?id=53057

        Instead of creating synchronous ResourceHandles manually, use the ::create factory.
        This ensures that ::start() is not called when there is a scheduled failure and also
        reduces code duplication.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::loadResourceSynchronously): Use the ::create factory method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 2 Feb 2011 01:16:29 +0000 (01:16 +0000)]
2011-02-01  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: add first stub of test_runner2. This
        will add support for the 'inline', 'threads', and 'processes'
        flags to --worker-model, but for now the implementatios just
        fall back on the old ones.

        https://bugs.webkit.org/show_bug.cgi?id=53157

        * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 2 Feb 2011 01:12:45 +0000 (01:12 +0000)]
2011-02-01  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Mihai Parparita.

        [codereviewtool] extra space at the beginning of lines in side-by-side view
        https://bugs.webkit.org/show_bug.cgi?id=53550

        The newline between the spans turns into user-visible space in side-by-side mode.

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Windows build.
andersca@apple.com [Wed, 2 Feb 2011 01:11:14 +0000 (01:11 +0000)]
Fix Windows build.

* UIProcess/win/WebView.cpp:
(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
* UIProcess/win/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 2 Feb 2011 01:09:34 +0000 (01:09 +0000)]
2011-02-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Add a layer backed NSView for accelerated content
        https://bugs.webkit.org/show_bug.cgi?id=53555

        Rename the current _layerHostingView to _oldLayerHostingView and
        add a new _layerHostingView to be used with the new drawing area.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView hitTest:]):
        (-[WKView _startAcceleratedCompositing:]):
        (-[WKView _stopAcceleratedCompositing]):
        (-[WKView _enterAcceleratedCompositingMode:]):
        (-[WKView _exitAcceleratedCompositingMode]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 2 Feb 2011 01:04:53 +0000 (01:04 +0000)]
2011-02-01  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] GObject DOM bindings do no support the CallWith attribute
        https://bugs.webkit.org/show_bug.cgi?id=53331

        Disable building GObject DOM bindings for IndexedDB because we do not support
        the CallWith attribute at this time.

        * bindings/gobject/GNUmakefile.am: Disable building bindings for the IndexedDB API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 2 Feb 2011 01:01:05 +0000 (01:01 +0000)]
2011-02-01  Darin Adler  <darin@apple.com>

        Reviewed by Brady Eidson.

        Fix a couple loose ends from the back/forward tree encode/decode work
        https://bugs.webkit.org/show_bug.cgi?id=53537

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::encodeBackForwardTreeNode): Remove extra copy of
        original URL string; no need to encode it twice.
        (WebCore::HistoryItem::decodeBackForwardTree): Ditto.
        * history/HistoryItem.h: Removed declaration for function that is no
        longer defined nor used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 2 Feb 2011 00:55:40 +0000 (00:55 +0000)]
2011-02-01  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] disable arm uninitialized variable warnings
        https://bugs.webkit.org/show_bug.cgi?id=53553

        We just got another error:
        third_party/WebKit/Source/WebCore/css/CSSPrimitiveValue.cpp:123:error:
        'colorTransparent.unstatic.4879' may be used uninitialized in this
        function

        * WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 2 Feb 2011 00:48:26 +0000 (00:48 +0000)]
2011-02-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Pass enter/exit accelerated compositing mode to the WKView
        https://bugs.webkit.org/show_bug.cgi?id=53552

        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::enterAcceleratedCompositingMode):
        (WebKit::PageClientImpl::exitAcceleratedCompositingMode):
        * UIProcess/API/mac/WKView.mm:
        (-[WKView _enterAcceleratedCompositingMode:]):
        (-[WKView _exitAcceleratedCompositingMode]):
        * UIProcess/API/mac/WKViewInternal.h:
        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
        (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
        * UIProcess/PageClient.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::enterAcceleratedCompositingMode):
        (WebKit::WebPageProxy::exitAcceleratedCompositingMode):
        * UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 chris reiss <christopher.reiss@nokia.com>
commit-queue@webkit.org [Wed, 2 Feb 2011 00:22:52 +0000 (00:22 +0000)]
2011-02-01  chris reiss  <christopher.reiss@nokia.com>

        Reviewed by Adam Barth.

        Self-replicating code makes Safari hang and eventually crash
        https://bugs.webkit.org/show_bug.cgi?id=15123

        * fast/dom/Document/document-close-iframe-load-expected.txt: Added.
        * fast/dom/Document/document-close-iframe-load.html: Added.
        * fast/dom/Document/document-close-nested-iframe-load-expected.txt: Added.
        * fast/dom/Document/document-close-nested-iframe-load.html: Added.
        * fast/dom/Document/document-write-recursion-expected.txt: Added.
        * fast/dom/Document/document-write-recursion.html: Added.
2011-02-01  chris reiss  <christopher.reiss@nokia.com>

        Reviewed by Adam Barth.

        Self-replicating code makes Safari hang and eventually crash
        https://bugs.webkit.org/show_bug.cgi?id=15123

        Here we are replicating the Firefox safeguard against
        recursive document.write( ) 's.

        See  https://bug197052.bugzilla.mozilla.org/attachment.cgi?id=293907 in bug
        https://bugzilla.mozilla.org/show_bug.cgi?id=197052 .   Firefox does two things -
            a) imposes a recursion limit of 20 on document.write( ) and
            b) once that limit is passed, panics all the way the call stack (rather than just returning one level.)
        To see why this is necessary, consider the script :

        <script>
           var t = document.body.innerHTML;
           document.write(t);
        </script>

        This will create a tree both broad and deep as the script keeps appending itself to the text.   If
        we just return one level after the recursion limit is reached, we still allow millions of copies to
        duplicate (and execute).

        The recursion is fortunately depth-first, so as soon as we cross this limit, we panic up the callstack
        to prevent this situation.    (IE apparently does the same thing, with a lower recursion limit.)

        Test: fast/dom/Document/document-write-recursion.html
        Test: fast/dom/Document/document-close-iframe-load.html
        Test: fast/dom/Document/document-close-nested-iframe-load.html

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::write):
        * dom/Document.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 2 Feb 2011 00:12:04 +0000 (00:12 +0000)]
2011-02-01  Dimitri Glazkov  <dglazkov@chromium.org>

        Updated text expectations to avoid conflict.

        * platform/chromium/test_expectations.txt: Tweaked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 2 Feb 2011 00:05:19 +0000 (00:05 +0000)]
2011-02-01  Ojan Vafai  <ojan@chromium.org>

        Increment version number to cache-bust code-review.js.

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-31 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 2 Feb 2011 00:00:36 +0000 (00:00 +0000)]
2011-01-31  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        Store draft comments in localStorage
        https://bugs.webkit.org/show_bug.cgi?id=52866

        * code-review.js:
        * code-review-test.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Johnny Ding <jnd@chromium.org>
jnd@chromium.org [Tue, 1 Feb 2011 23:52:27 +0000 (23:52 +0000)]
2011-02-01  Johnny Ding  <jnd@chromium.org>

        Reviewed by Darin Adler.

        Don't set user gesture in HTMLAnchorElement's click handler because the click handler can be triggered by untrusted event.
        https://bugs.webkit.org/show_bug.cgi?id=53424

        * fast/events/popup-blocked-from-untrusted-click-event-on-anchor-expected.txt: Added.
        * fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html: Added.
2011-02-01  Johnny Ding  <jnd@chromium.org>

        Reviewed by Darin Adler.

        Don't set user gesture in HTMLAnchorElement's click handler because the click handler can be triggered by untrusted event.
        https://bugs.webkit.org/show_bug.cgi?id=53424

        Test: fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html

        * html/HTMLAnchorElement.cpp:
        (WebCore::handleLinkClick):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Qt buildfix after r77286.
ossy@webkit.org [Tue, 1 Feb 2011 23:50:58 +0000 (23:50 +0000)]
Unreviewed Qt buildfix after r77286.

https://bugs.webkit.org/show_bug.cgi?id=53520
Remove the physical terminology from IntRect and FloatRect.

Source/WebCore:

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::createTiles):

Source/WebKit/qt:

* WebCoreSupport/PopupMenuQt.cpp:
(WebCore::PopupMenuQt::show):

Source/WebKit2:

* UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 1 Feb 2011 23:46:41 +0000 (23:46 +0000)]
2011-02-01  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
paroga@webkit.org [Tue, 1 Feb 2011 23:32:46 +0000 (23:32 +0000)]
2011-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r77297.
        http://trac.webkit.org/changeset/77297
        https://bugs.webkit.org/show_bug.cgi?id=53538

        caused leopard crashes (Requested by paroga on #webkit).

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * wtf/text/AtomicString.cpp:
        (WTF::AtomicString::fromUTF8):
        * wtf/unicode/UTF8.cpp:
        (WTF::Unicode::calculateStringHashFromUTF8):
        * wtf/unicode/UTF8.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 1 Feb 2011 23:26:15 +0000 (23:26 +0000)]
2011-02-01  Dimitri Glazkov  <dglazkov@chromium.org>

        Updated baselines after switching input-derived parts of HTMLMediaElement
        to use shadow DOM.
        https://bugs.webkit.org/show_bug.cgi?id=53314

        * platform/chromium-linux/media/video-zoom-controls-expected.checksum: Updated.
        * platform/chromium-linux/media/video-zoom-controls-expected.png: Updated.
        * platform/chromium-mac/media/video-zoom-controls-expected.checksum: Updated.
        * platform/chromium-mac/media/video-zoom-controls-expected.png: Updated.
        * platform/chromium-mac/media/video-zoom-controls-expected.txt: Updated.
        * platform/chromium-win/media/video-zoom-controls-expected.checksum: Updated.
        * platform/chromium-win/media/video-zoom-controls-expected.png: Updated.
        * platform/chromium-win/media/video-zoom-controls-expected.txt: Updated.
        * platform/chromium/test_expectations.txt: Expectation of failure removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Mac production builds.
weinig@apple.com [Tue, 1 Feb 2011 23:20:09 +0000 (23:20 +0000)]
Fix Mac production builds.

../JavaScriptCore:

* JavaScriptCore.xcodeproj/project.pbxproj:

../WebCore:

* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollbarThemeMac.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Tue, 1 Feb 2011 23:05:34 +0000 (23:05 +0000)]
2011-02-01  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Test not crashing on chromium, was crashing earlier because of
        some build issues. Also, rebaselining chromium mac since it matches
        rest of chromium and is not same as mac leopard.
        https://bugs.webkit.org/show_bug.cgi?id=53516

        * platform/chromium-mac/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 1 Feb 2011 23:04:18 +0000 (23:04 +0000)]
2011-02-01  Darin Fisher  <darin@chromium.org>

        Reviewed by David Levin.

        [chromium] Remove unnecessary WebCore:: prefixing in a few places and fix-up some indentation.
        https://bugs.webkit.org/show_bug.cgi?id=53523

        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::attach):
        (WebKit::WebDevToolsAgentImpl::inspectNode):
        (WebKit::WebDevToolsAgentImpl::inspectorController):
        (WebKit::WebDevToolsAgentImpl::mainFrame):
        (WebKit::WebDevToolsAgentImpl::identifierForInitialRequest):
        (WebKit::WebDevToolsAgentImpl::sendMessageToFrontend):
        (WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie):
        (WebKit::WebDevToolsAgent::interruptAndDispatch):
        (WebKit::WebDevToolsAgent::processPendingMessages):
        * src/WebPopupMenuImpl.cpp:
        (WebKit::WebPopupMenuImpl::resize):
        * src/WebScrollbarImpl.cpp:
        (WebKit::WebScrollbarImpl::setLocation):
        (WebKit::WebScrollbarImpl::setValue):
        (WebKit::WebScrollbarImpl::onMouseWheel):
        (WebKit::WebScrollbarImpl::onKeyDown):
        (WebKit::WebScrollbarImpl::scrollPosition):
        (WebKit::WebScrollbarImpl::setScrollOffset):
        (WebKit::WebScrollbarImpl::invalidateScrollbarRect):
        (WebKit::WebScrollbarImpl::getTickmarks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Qt bustage.
hyatt@apple.com [Tue, 1 Feb 2011 22:56:36 +0000 (22:56 +0000)]
Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Qt bustage.
hyatt@apple.com [Tue, 1 Feb 2011 22:52:02 +0000 (22:52 +0000)]
Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 1 Feb 2011 22:51:45 +0000 (22:51 +0000)]
2011-02-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Send messages when entering/exiting accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=53534

        * Shared/LayerTreeContext.h: Added.
        * Shared/mac/LayerTreeContextMac.mm: Added.
        Add new LayerTreeContext which holds all information needed to enter
        accelerated compositing mode.

        * UIProcess/DrawingAreaProxy.h:
        (WebKit::DrawingAreaProxy::enterAcceleratedCompositingMode):
        (WebKit::DrawingAreaProxy::exitAcceleratedCompositingMode):
        Add empty stubs.

        * UIProcess/DrawingAreaProxy.messages.in:
        Add new messgaes.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
        (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
        * UIProcess/DrawingAreaProxyImpl.h:
        Add empty stubs.

        * WebKit2.xcodeproj/project.pbxproj:
        Add new files.

        * WebProcess/WebPage/mac/LayerTreeHostMac.h:
        * WebProcess/WebPage/mac/LayerTreeHostMac.mm:
        (WebKit::LayerTreeHostMac::LayerTreeHostMac):
        (WebKit::LayerTreeHostMac::invalidate):
        Send messages.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 1 Feb 2011 22:49:01 +0000 (22:49 +0000)]
2011-02-01  Darin Adler  <darin@apple.com>

        Reviewed by Chris Fleizach.

        REGRESSION: Removing focus from area element causes unwanted scrolling
        https://bugs.webkit.org/show_bug.cgi?id=50169

        Test: fast/images/imagemap-scroll.html

        * html/HTMLAreaElement.cpp:
        (WebCore::HTMLAreaElement::setFocus): Added override. Calls the new
        RenderImage::areaElementFocusChanged function.
        (WebCore::HTMLAreaElement::updateFocusAppearance): Removed the code
        here that calls setNeedsLayout on the image's renderer. This was an
        attempt to cause repaint of the renderer, but this function does not
        need to do that. Also changed this to use the imageElement function
        to avoid repeating code.

        * html/HTMLAreaElement.h: Updated for above changes.

        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paint): Updated for name change.
        (WebCore::RenderImage::paintAreaElementFocusRing): Renamed this from
        paintFocusRing, because it only paints area focus rings, and should
        not be confused with paintFocusRing functions in other classes. Also
        removed the unused style argument. Removed the code that used an
        HTMLCollection to see if the focused area element is for this image
        and instead just call imageElement on the area element.
        (WebCore::RenderImage::areaElementFocusChanged): Added. Calls repaint.

        * rendering/RenderImage.h: Added a public areaElementFocusChanged
        function for HTMLAreaElement to call. Made the paintFocusRing function
        private, renamed it to paintAreaElementFocusRing, and removed its
        unused style argument.
2011-02-01  Darin Adler  <darin@apple.com>

        Reviewed by Chris Fleizach.

        REGRESSION: Removing focus from area element causes unwanted scrolling
        https://bugs.webkit.org/show_bug.cgi?id=50169

        * fast/images/imagemap-scroll-expected.txt: Added.
        * fast/images/imagemap-scroll.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Qt bustage.
hyatt@apple.com [Tue, 1 Feb 2011 22:48:39 +0000 (22:48 +0000)]
Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 1 Feb 2011 22:42:47 +0000 (22:42 +0000)]
2011-02-01  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        getUniform should support SAMPLER_2D or SAMPLER_CUBE
        https://bugs.webkit.org/show_bug.cgi?id=52190

        * fast/canvas/webgl/gl-object-get-calls-expected.txt:
        * fast/canvas/webgl/gl-object-get-calls.html: Test getUniform with sampler2D and samplerCube uniforms.
        * fast/canvas/webgl/resources/noopUniformShader.vert: Added.
        * fast/canvas/webgl/resources/samplerUniformShader.frag: Added.
2011-02-01  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r77286.

        * platform/graphics/wince/GraphicsContextWinCE.cpp:
        (WebCore::TransparentLayerDC::TransparentLayerDC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 1 Feb 2011 22:39:30 +0000 (22:39 +0000)]
2011-02-01  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r77286.

        * platform/graphics/wince/GraphicsContextWinCE.cpp:
        (WebCore::TransparentLayerDC::TransparentLayerDC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAX: AXPosition of AXScrollArea is wrong
cfleizach@apple.com [Tue, 1 Feb 2011 22:37:29 +0000 (22:37 +0000)]
AX: AXPosition of AXScrollArea is wrong
https://bugs.webkit.org/show_bug.cgi?id=53511

Reviewed by Darin Adler.

Source/WebCore:

AccessibilityScrollView needed to return a valid documentFrameView() object.
At the same time, the code from document() should be consolidated in
AccessibilityObject, so all objects can use it.

Test: platform/mac/accessibility/webkit-scrollarea-position.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::document):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::accessibilityHitTest):
(WebCore::AccessibilityScrollView::documentFrameView):
* accessibility/AccessibilityScrollView.h:

LayoutTests:

* platform/mac/accessibility/webkit-scrollarea-position-expected.txt: Added.
* platform/mac/accessibility/webkit-scrollarea-position.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Dan Bernstein and Darin Adler.
ap@apple.com [Tue, 1 Feb 2011 22:30:11 +0000 (22:30 +0000)]
    Reviewed by Dan Bernstein and Darin Adler.

        <rdar://problem/8830594> Printed page is sometimes shifted down, making footer invisible

        * UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView locationOfPrintRect:]): Instead of
        letting AppKit compute content position on page, make the view provide it. We can do this
        because WK(Printing)Views are always printed on their own, not as part of other views.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 1 Feb 2011 22:29:33 +0000 (22:29 +0000)]
2011-02-01  Zhenyao Mo  <zmo@google.com>

        Reviewed by Darin Adler.

        Fix the incorrect usage of RetainPtr cases in GraphicsContext3DCG.cpp
        https://bugs.webkit.org/show_bug.cgi?id=53531

        With this fix, running WebGL conformance tests should no longer crash randomly.

        * platform/graphics/cg/GraphicsContext3DCG.cpp:
        (WebCore::GraphicsContext3D::getImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 1 Feb 2011 22:14:53 +0000 (22:14 +0000)]
2011-02-01  Dimitri Glazkov  <dglazkov@chromium.org>

        One more Chromium build fix after r77286.

        * platform/chromium/ScrollbarThemeChromiumMac.mm:
        (WebCore::ScrollbarThemeChromiumMac::paint): Changed to not use topLeft().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the windows build.
weinig@apple.com [Tue, 1 Feb 2011 22:12:10 +0000 (22:12 +0000)]
Try to fix the windows build.

* DerivedSources.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Qt bustage.
hyatt@apple.com [Tue, 1 Feb 2011 22:11:30 +0000 (22:11 +0000)]
Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the build for Beth.
weinig@apple.com [Tue, 1 Feb 2011 22:04:11 +0000 (22:04 +0000)]
Fix the build for Beth.

* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 1 Feb 2011 22:03:04 +0000 (22:03 +0000)]
2011-02-01  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Avoid strlen() in AtomicString::fromUTF8
        https://bugs.webkit.org/show_bug.cgi?id=50516

        Add an overload to calculateStringHashFromUTF8 to get
        strlen() of the input data with only one call.

        This change shows about 3% performance win on the xml-parser benchmark.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * wtf/text/AtomicString.cpp:
        (WTF::AtomicString::fromUTF8):
        * wtf/unicode/UTF8.cpp:
        (WTF::Unicode::calculateStringHashAndLengthFromUTF8Internal):
        (WTF::Unicode::calculateStringHashFromUTF8):
        (WTF::Unicode::calculateStringHashAndLengthFromUTF8):
        * wtf/unicode/UTF8.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 1 Feb 2011 21:57:49 +0000 (21:57 +0000)]
2011-02-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Make LayerTreeHost ref counted
        https://bugs.webkit.org/show_bug.cgi?id=53530

        LayerTreeHostMac will soon be able to trigger layout, which could cause
        the page to leave accelerated compositing mode and free the LayerTreeHostMac object.

        Making LayerTreeHost ref counted will let LayerTreeHostMac protect itself while triggering layout.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::setRootCompositingLayer):
        * WebProcess/WebPage/DrawingAreaImpl.h:
        * WebProcess/WebPage/LayerTreeHost.cpp:
        (WebKit::LayerTreeHost::create):
        * WebProcess/WebPage/LayerTreeHost.h:
        * WebProcess/WebPage/mac/LayerTreeHostMac.h:
        * WebProcess/WebPage/mac/LayerTreeHostMac.mm:
        (WebKit::LayerTreeHostMac::create):
        (WebKit::LayerTreeHostMac::LayerTreeHostMac):
        (WebKit::LayerTreeHostMac::~LayerTreeHostMac):
        (WebKit::LayerTreeHostMac::invalidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix chromium bustage.
hyatt@apple.com [Tue, 1 Feb 2011 21:56:15 +0000 (21:56 +0000)]
Fix chromium bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Qt build bustage.
hyatt@apple.com [Tue, 1 Feb 2011 21:51:16 +0000 (21:51 +0000)]
Fix Qt build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 1 Feb 2011 21:47:57 +0000 (21:47 +0000)]
2011-02-01  Dimitri Glazkov  <dglazkov@chromium.org>

        Added yet another expectations of flakiness.
        https://bugs.webkit.org/show_bug.cgi?id=53527

        * platform/chromium/test_expectations.txt: Flakiness abound.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPart 2 for <rdar://problem/8492788>
weinig@apple.com [Tue, 1 Feb 2011 21:45:38 +0000 (21:45 +0000)]
Part 2 for <rdar://problem/8492788>
Adopt WKScrollbarPainterController

Reviewed by Beth Dakin.

Use header detection to define scrollbar painting controller #define.

Source/JavaScriptCore:

* DerivedSources.make:
* JavaScriptCore.xcodeproj/project.pbxproj:

Source/WebCore:

* WebCore.exp.in:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKit2:

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=53520
hyatt@apple.com [Tue, 1 Feb 2011 21:39:47 +0000 (21:39 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=53520

Reviewed by Oliver Hunt.

Remove the physical terminology from IntRect and FloatRect.

Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
we need to update our terminology to be more accurate.

I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
renaming right() and bottom() to maxX() and maxY().  These terms remain accurate
even for flipped rectangles.

../WebCore:

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper position]):
* dom/ClientRect.h:
(WebCore::ClientRect::right):
(WebCore::ClientRect::bottom):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::convertLogicalToDevice):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::normalizeRect):
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::drawElementTitle):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::adjustWindowRect):
* page/DragController.cpp:
(WebCore::dragLocForSelectionDrag):
* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEventForKey):
* page/PrintContext.cpp:
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
(WebCore::PrintContext::pageNumberForElement):
* page/SpatialNavigation.cpp:
(WebCore::end):
(WebCore::areRectsFullyAligned):
(WebCore::areRectsMoreThanFullScreenApart):
(WebCore::below):
(WebCore::rightOf):
(WebCore::isRectInDirection):
(WebCore::entryAndExitPointsForDirection):
(WebCore::virtualRectForDirection):
* page/WindowFeatures.cpp:
(WebCore::WindowFeatures::WindowFeatures):
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::setFrameRect):
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::splitTrack):
* platform/chromium/ScrollbarThemeChromium.cpp:
(WebCore::ScrollbarThemeChromium::paintTickmarks):
* platform/graphics/FloatQuad.h:
(WebCore::FloatQuad::FloatQuad):
* platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::intersects):
(WebCore::FloatRect::contains):
(WebCore::FloatRect::intersect):
(WebCore::FloatRect::unite):
(WebCore::enclosingIntRect):
* platform/graphics/FloatRect.h:
(WebCore::FloatRect::maxX):
(WebCore::FloatRect::maxY):
(WebCore::FloatRect::contains):
* platform/graphics/IntRect.cpp:
(WebCore::IntRect::intersects):
(WebCore::IntRect::contains):
(WebCore::IntRect::intersect):
(WebCore::IntRect::unite):
* platform/graphics/IntRect.h:
(WebCore::IntRect::maxX):
(WebCore::IntRect::maxY):
(WebCore::IntRect::shiftXEdgeTo):
(WebCore::IntRect::shiftMaxXEdgeTo):
(WebCore::IntRect::shiftYEdgeTo):
(WebCore::IntRect::shiftMaxYEdgeTo):
(WebCore::IntRect::contains):
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::draw):
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::copyImageBytes):
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformBoundsForGlyph):
* platform/graphics/transforms/AffineTransform.cpp:
(WebCore::AffineTransform::mapRect):
* platform/graphics/win/FontCGWin.cpp:
(WebCore::drawGDIGlyphs):
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
(WebCore::MediaPlayerPrivate::paint):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::centerRectVerticallyInParentInputElement):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::paint):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::positionForOffset):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::paintEllipsisBoxes):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::flipForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustForColumns):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObject::right):
(WebCore::RenderBlock::FloatingObject::bottom):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::reflectedRect):
(WebCore::RenderBox::localCaretRect):
(WebCore::RenderBox::addShadowOverflow):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::visualOverflowRectForPropagation):
(WebCore::RenderBox::layoutOverflowRectForPropagation):
(WebCore::RenderBox::flipForWritingMode):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutlineForLine):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::getRectToExpose):
(WebCore::cornerRect):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::overflowBottom):
(WebCore::RenderLayer::overflowRight):
(WebCore::RenderLayer::paintResizer):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::rangeIntersectsRect):
(WebCore::RenderLineBoxList::paint):
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
* rendering/RenderOverflow.h:
(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::addLayoutOverflow):
(WebCore::RenderOverflow::addVisualOverflow):
(WebCore::RenderOverflow::setLayoutOverflow):
(WebCore::RenderOverflow::setVisualOverflow):
(WebCore::RenderOverflow::resetLayoutOverflow):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint):
* rendering/RenderScrollbarTheme.cpp:
(WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paint):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paint):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintObject):
* rendering/RenderText.cpp:
(WebCore::RenderText::absoluteQuads):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::forwardEvent):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintMenuListButton):
(WebCore::RenderThemeMac::paintSliderTrack):
* rendering/RenderView.cpp:
(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::docBottom):
(WebCore::RenderView::docRight):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::paddedLayoutOverflowRect):
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::localCaretRect):

../WebKit/mac:

* WebView/WebHTMLView.mm:
(setNeedsDisplayInRect):

../WebKit2:

* Platform/Region.cpp:
(WebKit::Region::Shape::Shape):
* UIProcess/API/mac/WKPrintingView.mm:
(pageDidComputePageRects):
* UIProcess/FindIndicator.cpp:
(WebKit::FindIndicator::draw):
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::invalidate):
(WebKit::TiledDrawingAreaProxy::paint):
(WebKit::TiledDrawingAreaProxy::createTiles):
* UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:
(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::callSetWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Tue, 1 Feb 2011 21:38:41 +0000 (21:38 +0000)]
2011-02-01  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Rebaseline my test for QT, Leopard from r77262 due
        to minor comment error differences.

        * platform/mac-leopard/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
        * platform/qt/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 1 Feb 2011 21:34:41 +0000 (21:34 +0000)]
2011-02-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Move flushPendingLayerChanges to LayerTreeHostMac
        https://bugs.webkit.org/show_bug.cgi?id=53525

        In preparation for adding more Mac specific code to flushPendingLayerChanges.

        * WebProcess/WebPage/LayerTreeHost.cpp:
        * WebProcess/WebPage/LayerTreeHost.h:
        * WebProcess/WebPage/mac/LayerTreeHostMac.h:
        * WebProcess/WebPage/mac/LayerTreeHostMac.mm:
        (WebKit::LayerTreeHostMac::flushPendingLayerChanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Tue, 1 Feb 2011 21:28:36 +0000 (21:28 +0000)]
2011-02-01  Xiaomei Ji  <xji@chromium.org>

        Unreviewed.

        Rebaseline after r77267.

        * platform/chromium-linux/fast/dom/34176-expected.checksum: Added.
        * platform/chromium-linux/fast/dom/34176-expected.png: Added.
        * platform/chromium-mac/fast/dom/34176-expected.checksum: Added.
        * platform/chromium-mac/fast/dom/34176-expected.png: Added.
        * platform/chromium-win/fast/dom/34176-expected.checksum: Added.
        * platform/chromium-win/fast/dom/34176-expected.png: Added.
        * platform/chromium-win/fast/dom/34176-expected.txt: Added.
        * platform/win/fast/dom/34176-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 1 Feb 2011 21:15:11 +0000 (21:15 +0000)]
2011-02-01  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by James Robinson.

        [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
        https://bugs.webkit.org/show_bug.cgi?id=53522

        * Scripts/run-chromium-webkit-unit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Tue, 1 Feb 2011 20:50:27 +0000 (20:50 +0000)]
2011-02-01  Xiaomei Ji  <xji@chromium.org>

        Unreviewed.

        * fast/dom/34176.html: Removed properties svn:executable and svn:mime-type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 1 Feb 2011 20:44:22 +0000 (20:44 +0000)]
2011-02-01  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        REGRESSION(77082): GC-related crashes seen: on WebKit2 bot; on GTK 32bit
        bot; loading trac pages; typing in search field
        https://bugs.webkit.org/show_bug.cgi?id=53519

        The crashes were all caused by failure to run an object's destructor.

        * runtime/CollectorHeapIterator.h:
        (JSC::ObjectIterator::ObjectIterator): Don't skip forward upon
        construction. The iterator class used to do that when it was designed
        for prior-to-beginning initialization. I forgot to remove this line
        of code when I changed the iterator to normal initialization.

        Skipping forward upon construction was causing the heap to skip running
        the destructor for the very first object in a block when destroying the
        block. This usually did not crash, since block destruction is rare and
        most objects have pretty trivial destructors. However, in the rare case
        when the heap would destroy a block whose first object was a global
        object or a DOM node, BOOM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 1 Feb 2011 20:39:37 +0000 (20:39 +0000)]
2011-02-01  Dimitri Glazkov  <dglazkov@chromium.org>

        Remove expectations of failure for passing tests.

        * platform/chromium/test_expectations.txt: Fewer fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 1 Feb 2011 20:35:41 +0000 (20:35 +0000)]
2011-02-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Mihai Parparita.

        Using Control-C to cancel webkit-patch or other python tools causes
        unpleasant traceback console spew
        https://bugs.webkit.org/show_bug.cgi?id=53462

        Catch the exception and don't print the stack trace.

        * Scripts/webkit-patch:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for <rdar://problem/8492788> Adopt WKScrollbarPainterController
bdakin@apple.com [Tue, 1 Feb 2011 20:35:25 +0000 (20:35 +0000)]
Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController

Reviewed by Sam Weinig.

Source/WebCore:

Lots of new WebCoreSystemInterface functions to export.
* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Let the scrollAnimator know when the mouse has
moved anywhere inside the page, and when the mouse
has moved in or out of the window.
* page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::updateMouseEventTargetNode):

Let the scrollAnimator know when the window has become
active or inactive.
* page/FocusController.cpp:
(WebCore::FocusController::setActive):

Let the scrollAnimator know when all of these things
are happening.
* page/FrameView.cpp:
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
(WebCore::FrameView::currentMousePosition):
(WebCore::FrameView::contentsResized):

New functions called through WebKit2 that allow the
scrollAnimator to know when a live resize starts and ends.
(WebCore::FrameView::willStartLiveResize):
(WebCore::FrameView::willEndLiveResize):
* page/FrameView.h:

New functions on ScrollAnimator that pass information
to the WKPainterController when we're using one.
* platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::scrollableArea):
(WebCore::ScrollAnimator::contentAreaWillPaint):
(WebCore::ScrollAnimator::mouseEnteredContentArea):
(WebCore::ScrollAnimator::mouseExitedContentArea):
(WebCore::ScrollAnimator::mouseMovedInContentArea):
(WebCore::ScrollAnimator::willStartLiveResize):
(WebCore::ScrollAnimator::contentsResized):
(WebCore::ScrollAnimator::willEndLiveResize):
(WebCore::ScrollAnimator::contentAreaDidShow):
(WebCore::ScrollAnimator::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scrollbarPainterDelegate):
(WebCore::ScrollAnimatorMac::setPainterForPainterController):
(WebCore::ScrollAnimatorMac::removePainterFromPainterController):
(WebCore::ScrollAnimatorMac::notityPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):

Let the scrollAnimator know when this is happening.
* platform/ScrollView.cpp:
(WebCore::ScrollView::paint):

New function lets the scrollAnimator get the current
mouse position.
* platform/ScrollView.h:
(WebCore::ScrollView::currentMousePosition):

New function that returns the scrollAnimator when needed.
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollAnimator):

Keep track of if we're in a live resize using a new memeber
variable.
* platform/mac/ScrollAnimatorMac.h:
(WebCore::ScrollAnimatorMac::inLiveResize):
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::view):

New delegates for the WKPainter and WKPainterController
(-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(-[ScrollKnobAnimation initWithScrollbarPainter:forScrollAnimator:WebCore::animateKnobAlphaTo:duration:]):
(-[ScrollKnobAnimation setCurrentProgress:]):
(-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollbarPainterDelegate convertRectToBacking:]):
(-[ScrollbarPainterDelegate convertRectFromBacking:]):
(-[ScrollbarPainterDelegate layer]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):

Get the WKScrollbarPainterRefs to synch up with the
WKScrollbarPainterControllerRefs when appropriate
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::setNewPainterForScrollbar):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):

Implement ScrollableArea's virtual function contentsSize() for access
through the scrollAnimator.
* rendering/RenderLayer.h:
(WebCore::RenderLayer::contentsSize):

Source/WebKit/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKit2:

Implement NSView's viewWillStartLiveResize and
viewDidEndLiveResize and propagate the messages down
to WebCore.
* UIProcess/API/mac/WKView.mm:
(-[WKView viewWillStartLiveResize]):
(-[WKView viewDidEndLiveResize]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewWillStartLiveResize):
(WebKit::WebPageProxy::viewWillEndLiveResize):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewWillStartLiveResize):
(WebKit::WebPage::viewWillEndLiveResize):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

A bunch of new WebKitSystemInterface functions.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Carol Szabo <carol.szabo@nokia.com>
carol.szabo@nokia.com [Tue, 1 Feb 2011 20:28:08 +0000 (20:28 +0000)]
2011-02-01  Carol Szabo  <carol.szabo@nokia.com>

        Reviewed by David Hyatt.

        layoutTestController.counterValueForElementById does not return the correct value
        https://bugs.webkit.org/show_bug.cgi?id=53037

        * fast/css/counters/deep-before-expected.txt: Added.
        * fast/css/counters/deep-before.html: Added.
        This tests whether DumpRenderTree properly retrieves counters and
        whether counters are properly set when the before pseudo element's
        renderer is not a direct child of the generating element's renderer.
2011-02-01  Carol Szabo  <carol.szabo@nokia.com>

        Reviewed by David Hyatt.

        layoutTestController.counterValueForElementById does not return the correct value
        https://bugs.webkit.org/show_bug.cgi?id=53037

        Test: fast/css/counters/deep-before.html

        * rendering/RenderTreeAsText.cpp:
        (WebCore::counterValueForElement):
        Modified to use the newly available RenderObject::beforePseudoElement()
        and RenderObject::afterPseudoElement() instead of the old imperfect
        algorithm to find the before and after pseudo elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Tue, 1 Feb 2011 20:27:01 +0000 (20:27 +0000)]
2011-02-01  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        Allow access for security origin same as this.
        https://bugs.webkit.org/show_bug.cgi?id=53440

        Hard to test as newly added path currently is never hit.

        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::canAccess): allow access if this == other

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 1 Feb 2011 20:25:05 +0000 (20:25 +0000)]
2011-02-01  Dimitri Glazkov  <dglazkov@chromium.org>

        Added more flakiness expectations from bots.

        * platform/chromium/test_expectations.txt: Another one bites or doesn't bite the dust.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-31 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 1 Feb 2011 20:17:21 +0000 (20:17 +0000)]
2011-01-31  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Update JSObject storage for new marking API
        https://bugs.webkit.org/show_bug.cgi?id=53467

        JSObject no longer uses EncodedJSValue for its property storage.
        This produces a stream of mechanical changes to PropertySlot and
        anonymous storage APIs.

        * JavaScriptCore.exp:
        * runtime/ArrayPrototype.cpp:
        (JSC::ArrayPrototype::ArrayPrototype):
        * runtime/BooleanConstructor.cpp:
        (JSC::constructBoolean):
        (JSC::constructBooleanFromImmediateBoolean):
        * runtime/BooleanObject.cpp:
        (JSC::BooleanObject::BooleanObject):
        * runtime/BooleanObject.h:
        * runtime/BooleanPrototype.cpp:
        (JSC::BooleanPrototype::BooleanPrototype):
        * runtime/DateInstance.cpp:
        (JSC::DateInstance::DateInstance):
        * runtime/DatePrototype.cpp:
        (JSC::DatePrototype::DatePrototype):
        * runtime/JSActivation.cpp:
        (JSC::JSActivation::getOwnPropertySlot):
        * runtime/JSArray.cpp:
        (JSC::JSArray::getOwnPropertySlot):
        * runtime/JSFunction.cpp:
        (JSC::JSFunction::getOwnPropertySlot):
        * runtime/JSGlobalObject.h:
        (JSC::JSGlobalObject::JSGlobalObject):
        * runtime/JSObject.cpp:
        (JSC::JSObject::fillGetterPropertySlot):
        * runtime/JSObject.h:
        (JSC::JSObject::getDirectLocation):
        (JSC::JSObject::offsetForLocation):
        (JSC::JSObject::putAnonymousValue):
        (JSC::JSObject::clearAnonymousValue):
        (JSC::JSObject::getAnonymousValue):
        (JSC::JSObject::putThisToAnonymousValue):
        (JSC::JSObject::locationForOffset):
        (JSC::JSObject::inlineGetOwnPropertySlot):
        * runtime/JSObjectWithGlobalObject.cpp:
        (JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
        * runtime/JSWrapperObject.h:
        (JSC::JSWrapperObject::JSWrapperObject):
        (JSC::JSWrapperObject::setInternalValue):
        * runtime/Lookup.cpp:
        (JSC::setUpStaticFunctionSlot):
        * runtime/NumberConstructor.cpp:
        (JSC::constructWithNumberConstructor):
        * runtime/NumberObject.cpp:
        (JSC::NumberObject::NumberObject):
        (JSC::constructNumber):
        * runtime/NumberObject.h:
        * runtime/NumberPrototype.cpp:
        (JSC::NumberPrototype::NumberPrototype):
        * runtime/PropertySlot.h:
        (JSC::PropertySlot::getValue):
        (JSC::PropertySlot::setValue):
        (JSC::PropertySlot::setRegisterSlot):
        * runtime/StringObject.cpp:
        (JSC::StringObject::StringObject):
        * runtime/StringPrototype.cpp:
        (JSC::StringPrototype::StringPrototype):
        * runtime/WriteBarrier.h:
        (JSC::WriteBarrierBase::setWithoutWriteBarrier):
2011-01-31  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Update JSObject storage for new marking API
        https://bugs.webkit.org/show_bug.cgi?id=53467

        Update WebCore to handle new anonymous slot behaviour.

        * bindings/js/JSDOMWindowShell.cpp:
        (WebCore::JSDOMWindowShell::setWindow):
        * bindings/js/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::initScript):
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 1 Feb 2011 20:05:07 +0000 (20:05 +0000)]
2011-02-01  Dimitri Glazkov  <dglazkov@chromium.org>

        https://bugs.webkit.org/show_bug.cgi?id=53516
        Test introduced in r77262 is crashing.

        * platform/chromium/test_expectations.txt: Added expectation to crash
            while the fix is worked on.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Tue, 1 Feb 2011 20:02:06 +0000 (20:02 +0000)]
2011-02-01  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Hyatt.

        Fix a text rendering problem when enclosing block is RTL and text runs
        are in different directionality.
        https://bugs.webkit.org/show_bug.cgi?id=34176

        The problem happens in the following example scenario (ABC represents
        Hebrew characters):
        <div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>

        The line consists of 3 text runs -- TextRun1 TextRun2 TextRun3. In which
        TextRun1 and TextRun2's bidi level are 2, and TextRun3's bidi level is 1.
        TextRun2 and TextRun3's least common ancestor is not a sibling of TextRun1.

        The visual bidi run order of the text runs is TextRun3 TextRun1 TextRun2.

        Inside RenderBlock::constructLine(), when RenderBlock::createLineBoxes()
        creates InlineFlowBox for TextRun2, it should check an InlineFlowBox for
        the run's render object's ancestor (not only its parent) has already
        been constructed or has something following it on the line, in which
        case, create a new box for TextRun2 instead of sharing the same box with
        TextRun3.

        In other words, the following 2 div should render the same results
        (ABC represents Hebrew characters).
        <div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>
        <div dir=rtl>this is a <span>Test <span>ABC</span></span></div>

        Test: fast/dom/34176.html

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::parentIsConstructedOrHaveNext):
        (WebCore::RenderBlock::createLineBoxes):
2011-02-01  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Hyatt.

        Fix a text rendering problem when enclosing block is RTL and text runs
        are in different directionality.
        https://bugs.webkit.org/show_bug.cgi?id=34176

        The problem happens in the following example scenario (ABC represents
        Hebrew characters):
        <div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>

        The line consists of 3 text runs -- TextRun1 TextRun2 TextRun3. In which
        TextRun1 and TextRun2's bidi level are 2, and TextRun3's bidi level is 1.
        TextRun2 and TextRun3's least common ancestor is not a sibling of TextRun1.

        The visual bidi run order of the text runs is TextRun3 TextRun1 TextRun2.

        Inside RenderBlock::constructLine(), when RenderBlock::createLineBoxes()
        creates InlineFlowBox for TextRun2, it should check an InlineFlowBox for
        the run's render object's ancestor (not only its parent) has already
        been constructed or has something following it on the line, in which
        case, create a new box for TextRun2 instead of sharing the same box with
        TextRun3.

        In other words, the following 2 div should render the same results
        (ABC represents Hebrew characters).
        <div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>
        <div dir=rtl>this is a <span>Test <span>ABC</span></span></div>

        * fast/dom/34176.html: Added.
        * platform/mac/fast/dom/34176-expected.checksum: Added.
        * platform/mac/fast/dom/34176-expected.png: Added.
        * platform/mac/fast/dom/34176-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate printing layout test for the ceiling->floor change.
hyatt@apple.com [Tue, 1 Feb 2011 19:39:52 +0000 (19:39 +0000)]
Update printing layout test for the ceiling->floor change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Scott Cameron <sccameron@rim.com>
dbates@webkit.org [Tue, 1 Feb 2011 19:22:06 +0000 (19:22 +0000)]
2011-02-01  Scott Cameron  <sccameron@rim.com>

        Reviewed by Daniel Bates.

        Use Windows format for MinGW HTTPD path.
        https://bugs.webkit.org/show_bug.cgi?id=53503

        * Scripts/webkitperl/httpd.pm:
          - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
            so that we don't have to escape the space characters in the path. Also,
            changed path to Windows-style path and removed FIXME comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 1 Feb 2011 19:21:16 +0000 (19:21 +0000)]
2011-02-01  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed. Include actual values in fast/canvas/webgl/gl-teximage.html
        (removed by r77129) in the case of failure.

        * fast/canvas/webgl/gl-teximage.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-31 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Tue, 1 Feb 2011 19:16:35 +0000 (19:16 +0000)]
2011-01-31  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dan Bernstein.

        Tests that a removed svg style element is not accessed again in document's
        style recalc code and does not result in crash.
        https://bugs.webkit.org/show_bug.cgi?id=53441

        * fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
        * fast/css/stylesheet-candidate-nodes-crash.xhtml: Added.
2011-02-01  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dan Bernstein.

        Do not add a node in the document's stylesheet candidate node list if the
        node is already removed from document.
        https://bugs.webkit.org/show_bug.cgi?id=53441

        Test: fast/css/stylesheet-candidate-nodes-crash.xhtml

        * dom/Document.cpp:
        (WebCore::Document::addStyleSheetCandidateNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 1 Feb 2011 19:09:00 +0000 (19:09 +0000)]
2011-02-01  Dimitri Glazkov  <dglazkov@chromium.org>

        More flakiness updates.

        * platform/chromium/test_expectations.txt: Moar flakiness recorded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 1 Feb 2011 18:50:17 +0000 (18:50 +0000)]
2011-02-01  Daniel Bates  <dbates@rim.com>

        Reviewed by Antonio Gomes.

        Modify RandomNumberSeed.h to use USE(MERSENNE_TWISTER_19937)
        https://bugs.webkit.org/show_bug.cgi?id=53506

        Currently, use of the Mersenne Twister pseudorandom number generator
        is hardcoded to the Windows CE port. With the passing of bug #53253,
        we can generalize support for this PRNG to all ports that use srand(3)
        and rand(3), including Windows CE.

        * wtf/RandomNumberSeed.h:
        (WTF::initializeRandomNumberGenerator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLand Webpage.cpp for previous patch. Change was lost after conflict resolution from...
hyatt@apple.com [Tue, 1 Feb 2011 18:49:59 +0000 (18:49 +0000)]
Land Webpage.cpp for previous patch.  Change was lost after conflict resolution from a merge.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77259 268f45cc-cd09-0410-ab3c-d52691b4dbfc