WebKit-https.git
6 years agoBuild fix after r139357. It was missing a comma.
rniwa@webkit.org [Fri, 11 Jan 2013 05:33:05 +0000 (05:33 +0000)]
Build fix after r139357. It was missing a comma.

* QueueStatusServer/model/queues.py:
(Queue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoElements must be reattached when inserted/removed from top layer
falken@chromium.org [Fri, 11 Jan 2013 04:46:21 +0000 (04:46 +0000)]
Elements must be reattached when inserted/removed from top layer
https://bugs.webkit.org/show_bug.cgi?id=105489

Reviewed by Julien Chaffraix.

Source/WebCore:

Ensure a reattach occurs when an element is inserted/removed from top layer, so its renderer can be inserted correctly:
as a child of RenderView in top layer sibling order if it's in the top layer, and in the usual place otherwise.

We previously relied on style recalc to catch when an element is inserted/removed from the top layer, because it
only happens on dialog.show/close which toggle display: none. But that is incorrect because, for example, close()
followed immediately by show() results in no style change.

Tests: fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html
       fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html

* dom/Element.cpp:
(WebCore::Element::removedFrom): Call Document::removeFromTopLayer to let the element be removed from the top layer vector.
removeFromTopLayer calls Element::setIsInTopLayer(false) itself if needed.
(WebCore::Element::setIsInTopLayer): Ensure a reattach occurs if the element is already attached.

LayoutTests:

* fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer-expected.html: Added.
* fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html: Added.
This tests that a top layer element removed from the document does not reappear in the top layer if readded.
This test actually would pass before this patch, but just by good fortune (see bug).
* fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd-expected.html: Added.
* fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html: Added.
This tests that top layer ordering is correct after removing and readding an element to the top layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWhen a selected node in nested ShadowDOM is deleted, selection have wrong range.
shinyak@chromium.org [Fri, 11 Jan 2013 04:44:20 +0000 (04:44 +0000)]
When a selected node in nested ShadowDOM is deleted, selection have wrong range.
https://bugs.webkit.org/show_bug.cgi?id=106526

Reviewed by Ryosuke Niwa.

Source/WebCore:

Since FrameSelection and htmlediting did not consider nested Shadow DOM, the FrameSelection still selects
removed elements if selected nodes in nested Shadow DOM are removed.

We have to use containsIncludingShadowDOM to handle with nested Shadow DOM correctly.

Test: fast/dom/shadow/selection-in-nested-shadow.html

* editing/FrameSelection.cpp:
(WebCore::removingNodeRemovesPosition):
* editing/htmlediting.cpp:
(WebCore::updatePositionForNodeRemoval):

LayoutTests:

* fast/dom/shadow/selection-in-nested-shadow-expected.txt: Added.
* fast/dom/shadow/selection-in-nested-shadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Shadow DOM] Refactoring: InsertionPoint could simplify its subclass hooks
morrita@google.com [Fri, 11 Jan 2013 04:00:13 +0000 (04:00 +0000)]
[Shadow DOM] Refactoring: InsertionPoint could simplify its subclass hooks
https://bugs.webkit.org/show_bug.cgi?id=106614

Reviewed by Dimitri Glazkov.

This change simplifies InsertionPoint overrides and give some flexibility to it.

The change

- Removes InsertionPoint::isSelectValid(). now ContentSelectorQuery parses given selector anyway.
  Invalid select attribute is handled by newly introduced matchTypeFor() method.
- Introduces InsertionPoint::matchTypeFor() to give a chance each InsertionPoint to decide whether it
  accepts the given node as its distribution. Then it lets DetailsSummaryElement adopt it.
- Pulls some HTMLShadowElement overrides up to InsertionPoint so that other upcoming InsertionPoint
  subclasses don't need to override them.

No new tests. Refactoring.

* html/HTMLDetailsElement.cpp:
(WebCore::DetailsSummaryElement::DetailsSummaryElement):
- Implemented matchTypeFor() to get rid of HTMLContentElement machinery which is compiled out in the upcoming change.
(DetailsSummaryElement):
* html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorQuery::ContentSelectorQuery):
(WebCore::ContentSelectorQuery::matches):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::matchTypeFor): Added.
(WebCore):
* html/shadow/HTMLContentElement.h:
(HTMLContentElement):
(WebCore::isHTMLContentElement):
* html/shadow/HTMLShadowElement.cpp:
* html/shadow/HTMLShadowElement.h:
(HTMLShadowElement):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::emptySelectorList): Moved from HTMLShadowElement.
(WebCore):
* html/shadow/InsertionPoint.h:
(WebCore::InsertionPoint::matchTypeFor): Added.
(WebCore::InsertionPoint::selectorList): Moved from HTMLShadowElement.
(InsertionPoint):
* testing/Internals.cpp:
(WebCore::Internals::isValidContentSelect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFixing AuthenticationError when running test-webkitpy as a non-committer.
commit-queue@webkit.org [Fri, 11 Jan 2013 03:18:36 +0000 (03:18 +0000)]
Fixing AuthenticationError when running test-webkitpy as a non-committer.
https://bugs.webkit.org/show_bug.cgi?id=106420

Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-10
Reviewed by Eric Seidel.

* Scripts/webkitpy/common/checkout/scm/git.py:
(Git.push_local_commits_to_server):
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVNRepository):
(SVNRepository.has_authorization_for_realm):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPlugin snapshot label should take device resolution and inset into account
dino@apple.com [Fri, 11 Jan 2013 02:01:02 +0000 (02:01 +0000)]
Plugin snapshot label should take device resolution and inset into account
https://bugs.webkit.org/show_bug.cgi?id=106619

Reviewed by Simon Fraser.

* rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::paintLabel): Take into account the inset in the label image.
(WebCore::RenderSnapshottedPlugIn::tryToFitStartLabel): Look at the page's device scale, and adjust the label image accordingly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Store scrollable layer's contents size for coordinated scrollable layers
jamesr@google.com [Fri, 11 Jan 2013 00:07:22 +0000 (00:07 +0000)]
[chromium] Store scrollable layer's contents size for coordinated scrollable layers
https://bugs.webkit.org/show_bug.cgi?id=106518

Reviewed by Adrienne Walker.

Source/WebCore:

This stores a scrollable layer's contentsSize in the scroll layer's bounds, which is otherwise not useful. This
value is currently calculated based on fragile knowledge of the tree structure immediately beneath a scrollable
layer.

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorChromium::frameViewLayoutUpdated):

LayoutTests:

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIndexedDB: Update expected results for IndexedDB layout tests
commit-queue@webkit.org [Fri, 11 Jan 2013 00:01:42 +0000 (00:01 +0000)]
IndexedDB: Update expected results for IndexedDB layout tests
https://bugs.webkit.org/show_bug.cgi?id=106411

Patch by Michael Pruett <michael@68k.org> on 2013-01-10
Reviewed by Tony Chang.

For IndexedDB layout tests whose output differs between V8 and
JSC, move V8 test output to platform/chromium and set expected
results to JSC test output.

* platform/chromium/storage/indexeddb/exception-in-event-aborts-expected.txt: Copied from LayoutTests/storage/indexeddb/exception-in-event-aborts-expected.txt.
* platform/chromium/storage/indexeddb/transaction-error-expected.txt: Copied from LayoutTests/storage/indexeddb/transaction-error-expected.txt.
* platform/chromium/storage/indexeddb/version-change-abort-expected.txt: Copied from LayoutTests/storage/indexeddb/version-change-abort-expected.txt.
* storage/indexeddb/exception-in-event-aborts-expected.txt:
* storage/indexeddb/transaction-error-expected.txt:
* storage/indexeddb/version-change-abort-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoLayout Test fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html is flaky.
dglazkov@chromium.org [Thu, 10 Jan 2013 23:43:09 +0000 (23:43 +0000)]
Layout Test fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=106612

* platform/chromium/TestExpectations: Marked as flake.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][EFL] Rename from xxxContentsScale() to xxxScale() in PageViewportController.
commit-queue@webkit.org [Thu, 10 Jan 2013 23:35:54 +0000 (23:35 +0000)]
[Qt][EFL] Rename from xxxContentsScale() to xxxScale() in PageViewportController.
https://bugs.webkit.org/show_bug.cgi?id=106537

Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-10
Reviewed by Kenneth Rohde Christiansen.

Rename 3 methods to match the terms of ViewportAttributes.

* UIProcess/API/qt/qwebkittest.cpp:
(QWebKitTest::viewport):
(QWebKitTest::contentsScale):
* UIProcess/PageViewportController.h:
(WebKit::PageViewportController::minimumScale):
(WebKit::PageViewportController::maximumScale):
(WebKit::PageViewportController::currentScale):
* UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Layout Test animations/fill-mode-iteration-count-non-integer.html is failing.
dglazkov@chromium.org [Thu, 10 Jan 2013 23:14:33 +0000 (23:14 +0000)]
[Chromium] Layout Test animations/fill-mode-iteration-count-non-integer.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=106609

* platform/chromium/TestExpectations: Marked as failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdjust ref-test expectation to actual work.
dglazkov@chromium.org [Thu, 10 Jan 2013 23:11:10 +0000 (23:11 +0000)]
Adjust ref-test expectation to actual work.

* platform/chromium/TestExpectations: Adjusted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed rebaseline. Apple Windows port.
roger_fong@apple.com [Thu, 10 Jan 2013 22:45:16 +0000 (22:45 +0000)]
Unreviewed rebaseline. Apple Windows port.

* platform/win/fast/ruby/base-shorter-than-text-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Layout Test fast/canvas/webgl/context-release-upon-reload.html is a flaky...
dglazkov@chromium.org [Thu, 10 Jan 2013 22:42:09 +0000 (22:42 +0000)]
[Chromium] Layout Test fast/canvas/webgl/context-release-upon-reload.html is a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=106606

* platform/chromium/TestExpectations: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement AutocompleteErrorEvent#reason
commit-queue@webkit.org [Thu, 10 Jan 2013 22:40:15 +0000 (22:40 +0000)]
Implement AutocompleteErrorEvent#reason
https://bugs.webkit.org/show_bug.cgi?id=105568

Source/WebCore:

Patch by Dan Beam <dbeam@chromium.org> on 2013-01-10
Reviewed by Adam Barth.

Test: fast/events/constructors/autocomplete-error-event-constructor.html

* WebCore.gypi: Added AutocompleteErrorEvent.idl and AutocompleteErrorEvent.h for chromium port's build.
* dom/AutocompleteErrorEvent.h: Added.
(WebCore): Added new type of error named AutocompleteErrorEvent.
(AutocompleteErrorEventInit): Added init params for AutocompleteErrorEvents (so initEvent() can be used).
(AutocompleteErrorEvent): Added a new error event that inherits from Event but also has a reason for failure.
(WebCore::AutocompleteErrorEvent::create): Factory function to create AutocompleteErrorEvents.
(WebCore::AutocompleteErrorEvent::reason): The reason why a requestAutocomplete() invocation failed. Can be
                                           "disabled", "cancel", or "invalid".
(WebCore::AutocompleteErrorEvent::interfaceName): The name of the event's interface (for event.toString()).
(WebCore::AutocompleteErrorEvent::AutocompleteErrorEvent): Various ways of constructing the error event.
* dom/AutocompleteErrorEvent.idl: Added.
* dom/EventNames.in: Added AutocompleteError to this list, based on REQUEST_AUTOCOMPLETE conditional.
* html/HTMLFormElement.cpp: Updated form elements to dispatch AutocompleteErrorEvents on errors and to give
                            more details (event.reason) when the request fails.
(WebCore::HTMLFormElement::requestAutocomplete): Changed to newly added failure type "disabled".
(WebCore::HTMLFormElement::finishRequestAutocomplete): Changed
* html/HTMLFormElement.h: Added new results (ErrorDisabled, ErrorCancel, ErrorInvalid).
* page/DOMWindow.idl: Added global event constructor for new AutocompleteErrorEvent() style event creation.

Source/WebKit/chromium:

Patch by Dan Beam <dbeam@chromium.org> on 2013-01-10
Reviewed by Adam Barth.

* public/WebFormElement.h: Added matching enum values for public chromium WebKit API.
* src/AssertMatchingEnums.cpp: Updated compile assert that WebKit and WebCore enums match.

LayoutTests:

Added tests to verify event creation and global event constructor existence of AutocompleteErrorEvent
and updated the existing tests to make sure errors received are of the right type and have the right reason.

Patch by Dan Beam <dbeam@chromium.org> on 2013-01-10
Reviewed by Adam Barth.

* fast/events/constructors/autocomplete-error-event-constructor-expected.txt: Added.
* fast/events/constructors/autocomplete-error-event-constructor.html: Added.
* fast/events/event-creation.html: Added new AutocompleteErrorEvent() test case.
* fast/forms/form-request-autocomplete.html: Updated 'autocompleteerror' listeners to check event.reason.
* fast/js/constructor-length.html: Added AutocompleteErrorEvent to list.
* fast/js/script-tests/global-constructors.js: Added AutocompleteErrorEvent to list.
* platform/blackberry/fast/js/constructor-length-expected.txt: Added expected ReferenceError.
* platform/chromium/fast/events/constructors/autocomplete-error-event-constructor-expected.txt: Added.
* platform/chromium/fast/forms/form-request-autocomplete-expected.txt: Updated passing expectations.
* platform/chromium/fast/js/constructor-length-expected.txt: Added expected 0 length result.
* platform/gtk/fast/js/constructor-length-expected.txt: Added expected ReferenceError.
* platform/mac/fast/js/constructor-length-expected.txt: Added expected ReferenceError.
* platform/qt/fast/js/constructor-length-expected.txt: Added expected ReferenceError.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHTMLMediaElement::resume() should schedule a load rather than load immediately
yoli@rim.com [Thu, 10 Jan 2013 22:31:48 +0000 (22:31 +0000)]
HTMLMediaElement::resume() should schedule a load rather than load immediately
https://bugs.webkit.org/show_bug.cgi?id=106587

Reviewed by Eric Carlson.

It is not always safe to start the jobs at the time resume() is called. That is why the jobs are
suspended. It can also be suspended again right after being resumed.

No new tests as there is no visible functional change, also it is a theoretically good-to-have change
that doesn't fix any known cross-platform issue.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::resume): Replace load() with scheduleLoad().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed rebaselines. Apple Windows port.
roger_fong@apple.com [Thu, 10 Jan 2013 22:31:22 +0000 (22:31 +0000)]
Unreviewed rebaselines. Apple Windows port.

* platform/win/TestExpectations:
* platform/win/fast/dom/window-load-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r139226.
commit-queue@webkit.org [Thu, 10 Jan 2013 22:25:40 +0000 (22:25 +0000)]
Unreviewed, rolling out r139226.
http://trac.webkit.org/changeset/139226
https://bugs.webkit.org/show_bug.cgi?id=106602

re
baselines were premature (Requested by rfong on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-10

* platform/win/accessibility/canvas-fallback-content-2-expected.txt:
* platform/win/platform/win/accessibility/option-element-selection-and-focus-events-expected.txt: Removed.
* platform/win/platform/win/accessibility/select-element-valuechange-event-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate WebkitSystemInterface lib for Windows port.
roger_fong@apple.com [Thu, 10 Jan 2013 22:09:24 +0000 (22:09 +0000)]
Update WebkitSystemInterface lib for Windows port.
This hasn't been done in a while and the current one is out of date.
In addition I believe it will fix:
<rdar://problem/12990844>

Rubberstamped by Timothy Horton.

* win/lib/WebKitSystemInterface.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd an ENABLE macro and a WebCore::Setting for the threaded parser
abarth@webkit.org [Thu, 10 Jan 2013 22:06:20 +0000 (22:06 +0000)]
Add an ENABLE macro and a WebCore::Setting for the threaded parser
https://bugs.webkit.org/show_bug.cgi?id=106595

Reviewed by Benjamin Poulain.

Source/WebCore:

This patch adds both a WebCore::Setting and an ENABLE macro for the
threaded parser. We plan to keep the ENABLE macro off by default for a
while. The runtime setting will let us more easily conduct A/B
experiments when the time arises.

* page/Settings.in:

Source/WebKit/chromium:

Explicitly disable THREADED_HTML_PARSER for Chromium so that we can
more easily enable it locally.

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Layout Test svg/dom/SVGScriptElement/script-onerror-bubbling.svg is a...
dglazkov@chromium.org [Thu, 10 Jan 2013 21:58:39 +0000 (21:58 +0000)]
[Chromium] Layout Test svg/dom/SVGScriptElement/script-onerror-bubbling.svg is a flaky timeout on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=106598

* platform/chromium/TestExpectations: Expectatized.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRegression(r129944): Heap-use-after-free in WebCore::computeNonFastScrollableRegion
wangxianzhu@chromium.org [Thu, 10 Jan 2013 21:52:40 +0000 (21:52 +0000)]
Regression(r129944): Heap-use-after-free in WebCore::computeNonFastScrollableRegion
https://bugs.webkit.org/show_bug.cgi?id=99515

Reviewed by Simon Fraser.

The object used-after-freed is a destructed FrameView that is still in the m_scrollableAreas set of the parent FrameView. Actually it has been removed from m_scrollableAreas when setParent(0), but then is added back in updateScrollableAreaSet() because its frameViewParent() is still not 0 (though parent() is already 0).

No new tests. The heap-use-after-free doesn't always cause crash so it can't be stably tested with a test case. Memory analysis tools like asan discovered the heap-use-after-free and verified that the patch can fix the issue.

* page/FrameView.cpp:
(WebCore::FrameView::parentFrameView): Checks if the FrameView has been removed from the parent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2] Set IndexedDB database path in WK2
commit-queue@webkit.org [Thu, 10 Jan 2013 21:49:28 +0000 (21:49 +0000)]
[WK2] Set IndexedDB database path in WK2
https://bugs.webkit.org/show_bug.cgi?id=106257

Patch by Michael Pruett <michael@68k.org> on 2013-01-10
Reviewed by Benjamin Poulain.

* WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:
(WebKit::WebKeyValueStorageManager::initialize):
* WebProcess/KeyValueStorage/WebKeyValueStorageManager.h:
(WebKeyValueStorageManager):
(WebKit::WebKeyValueStorageManager::indexedDBDatabaseDirectory):
* WebProcess/WebPage/WebPageGroupProxy.cpp:
(WebKit::WebPageGroupProxy::WebPageGroupProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 10 Jan 2013 21:44:20 +0000 (21:44 +0000)]
Unreviewed GTK gardening.

Expanding the timeout expectation for fast/css/user-drag-none.html, the test
times out on both debug and release builds.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][jhbuild] Use tarballs for gstreamer instead of git
christophe.dumez@intel.com [Thu, 10 Jan 2013 21:43:44 +0000 (21:43 +0000)]
[EFL][jhbuild] Use tarballs for gstreamer instead of git
https://bugs.webkit.org/show_bug.cgi?id=106552

Reviewed by Laszlo Gombos.

Use tarballs for gstreamer instead of git in EFL's jhbuild
to work around intermittent network issues on our build
bots. Tarballs are fully cached and require no network
operation if their checksum matches.

* efl/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd Mac WK2 EWS bots
rniwa@webkit.org [Thu, 10 Jan 2013 21:27:54 +0000 (21:27 +0000)]
Add Mac WK2 EWS bots
https://bugs.webkit.org/show_bug.cgi?id=106590

Reviewed by Adam Barth.

Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
Also add a deprecated MacWK2Port class.

* QueueStatusServer/model/queues.py:
(Queue):
* Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port):
(MacWK2Port):
(MacWK2Port.run_webkit_tests_command):
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(MacEWS):
(MacWK2EWS):
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(_test_ewses):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix scale of screen.width, window.outerWidth and @media device-width when page scale...
commit-queue@webkit.org [Thu, 10 Jan 2013 21:10:00 +0000 (21:10 +0000)]
Fix scale of screen.width, window.outerWidth and @media device-width when page scale not applied in compositor.
https://bugs.webkit.org/show_bug.cgi?id=106460

Patch by John Mellor <johnme@chromium.org> on 2013-01-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

screen.width, window.outerWidth and @media device-width should be in
density independent (UI) pixels, not physical screen pixels.

This already works on most ports (including iOS). However Chrome for
Android currently internally sizes its windows in physical screen pixels
instead of density independent pixels, and this leaks through in the
sizes provided to WebCore.

This patch scales these sizes appropriately before they reach JavaScript,
on platforms where the applyPageScaleFactorInCompositor setting is false
(i.e. just Chrome for Android). Once Chrome for Android switches over to
the same coordinate space, the applyPageScaleFactorInCompositor setting
will be removed, along with any code (such as this) that depends on it.

The effect of this patch on Chrome for Android when viewing a page with
a width=device-width viewport on a Galaxy Nexus (720x1280 @ dPR 2) is:
    @media device-width      changes from 720 to 360
    screen.width             changes from 720 to 360
    screen.availWidth        changes from 720 to 360
    window.outerWidth        changes from 720 to 360
    window.innerWidth                    remains 360 (at overview zoom)
    @media width                         remains 360
    document.documentElement.clientWidth remains 360
    document.documentElement.offsetWidth remains 360
    document.documentElement.scrollWidth remains 360
    document.body.clientWidth            remains 360
    document.body.offsetWidth            remains 360
    document.body.scrollWidth            remains 360
And similarly for heights (though they are slightly less than 640, since
toolbars etc. get subtracted from the available height).

No new tests, as applyDeviceScaleFactorInCompositor appears to always be
true in DumpRenderTree, so this situation cannot occur there.

* page/Settings.in:
    Added applyDeviceScaleFactorInCompositor setting, which allows
    detecting whether we need to normalize the scale.
* platform/chromium/PlatformScreenChromium.cpp:
(WebCore::toUserSpace):
    Static function for normalizing screen rect scale.
(WebCore::screenRect):
    Uses toUserSpace.
(WebCore::screenAvailableRect):
    Uses toUserSpace.
* rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processSubtree):
    Use applyDeviceScaleFactorInCompositor instead of
    applyPageScaleFactorInCompositor, to scale the window rect correctly
    on platforms other than Chrome for Android.

Source/WebKit/chromium:

1. Exposes the existing applyDeviceScaleFactorInCompositor from
WebSettings on Settings (and stores the value there instead), so it can
be accessed from WebCore.

2. Changes ChromeClientImpl::windowRect to return values in density
independent (UI) pixels pixels instead of physical screen pixels (see
explanation in Source/WebCore/ChangeLog).

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::windowRect):
    Normalizes window rect scale.
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setApplyDeviceScaleFactorInCompositor):
(WebKit::WebSettingsImpl::applyDeviceScaleFactorInCompositor):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] move webpermissionclient related methods to TestRunner library
commit-queue@webkit.org [Thu, 10 Jan 2013 21:02:53 +0000 (21:02 +0000)]
[chromium] move webpermissionclient related methods to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=106548

Patch by Dan Carney <dcarney@google.com> on 2013-01-10
Reviewed by Jochen Eisinger.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebKit):
(WebTestRunner::WebTestRunner::webPermissions):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::setDelegate):
(WebTestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::webPermissions):
(WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
(WebTestRunner::TestRunner::setImagesAllowed):
(WebTestRunner::TestRunner::setScriptsAllowed):
(WebTestRunner::TestRunner::setStorageAllowed):
(WebTestRunner::TestRunner::setPluginsAllowed):
(WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
(WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner):
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
(WebTestRunner):
(WebTestRunner::WebPermissions::WebPermissions):
(WebTestRunner::WebPermissions::~WebPermissions):
(WebTestRunner::WebPermissions::allowImage):
(WebTestRunner::WebPermissions::allowScriptFromSource):
(WebTestRunner::WebPermissions::allowStorage):
(WebTestRunner::WebPermissions::allowPlugins):
(WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
(WebTestRunner::WebPermissions::allowRunningInsecureContent):
(WebTestRunner::WebPermissions::setImagesAllowed):
(WebTestRunner::WebPermissions::setScriptsAllowed):
(WebTestRunner::WebPermissions::setStorageAllowed):
(WebTestRunner::WebPermissions::setPluginsAllowed):
(WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
(WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
(WebTestRunner::WebPermissions::setDelegate):
(WebTestRunner::WebPermissions::setDumpCallbacks):
(WebTestRunner::WebPermissions::reset):
* DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
(WebTestRunner):
(WebPermissions):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::resetTestController):
(TestShell::createNewWindow):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::normalizeLayoutTestURL):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSplit EWS tool cold-boot.sh into modular components
commit-queue@webkit.org [Thu, 10 Jan 2013 21:01:22 +0000 (21:01 +0000)]
Split EWS tool cold-boot.sh into modular components
https://bugs.webkit.org/show_bug.cgi?id=106527

Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-10
Reviewed by Adam Barth.

Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
Updated GCE bot build scripts to match.
Unable to test scripts directly as they depend on being in the repository to work!

* EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
* EWSTools/GoogleComputeEngine/build-commit-queue.sh:
* EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
* EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
* EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRename GraphicsContext::addRoundedRectClip
fmalita@chromium.org [Thu, 10 Jan 2013 20:51:41 +0000 (20:51 +0000)]
Rename GraphicsContext::addRoundedRectClip
https://bugs.webkit.org/show_bug.cgi?id=106581

Reviewed by Simon Fraser.

This patch renames GraphicsContext::addRoundedRectClip to clipRoundedRect for consistency
with the other GC clipping methods.

No new tests: no functional changes.

* WebCore.order:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::clipRoundedRect):
* platform/graphics/GraphicsContext.h:
(GraphicsContext):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::clipRoundedRect):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::pushContentsClip):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::clipRoundedInnerRect):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clipToRect):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
* rendering/RenderThemeMacShared.mm:
(WebCore::RenderThemeMacShared::paintMenuListButtonGradients):
(WebCore::RenderThemeMacShared::paintSliderTrack):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintSliderTrack):
* rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMediaStream API: Adding the new id attribute to MediaStream and MediaStreamTrack
tommyw@google.com [Thu, 10 Jan 2013 20:44:15 +0000 (20:44 +0000)]
MediaStream API: Adding the new id attribute to MediaStream and MediaStreamTrack
https://bugs.webkit.org/show_bug.cgi?id=106564

Reviewed by Adam Barth.

Specification: http://dev.w3.org/2011/webrtc/editor/getusermedia.html
MediaStream looses its label attribute and instead gets an id attribute.
MediaStreamTrack gets an id attribute.

Source/Platform:

* chromium/public/WebMediaStreamComponent.h:
(WebMediaStreamComponent):
* chromium/public/WebMediaStreamDescriptor.h:
(WebMediaStreamDescriptor):

Source/WebCore:

Not testable yet, will add tests in a followup patch.

* Modules/mediastream/MediaStream.h:
(WebCore::MediaStream::label):
(MediaStream):
(WebCore::MediaStream::id):
* Modules/mediastream/MediaStream.idl:
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::id):
(WebCore):
* Modules/mediastream/MediaStreamTrack.h:
* Modules/mediastream/MediaStreamTrack.idl:
* platform/chromium/support/WebMediaStreamComponent.cpp:
(WebKit::WebMediaStreamComponent::initialize):
(WebKit):
(WebKit::WebMediaStreamComponent::isEnabled):
(WebKit::WebMediaStreamComponent::id):
(WebKit::WebMediaStreamComponent::source):
* platform/chromium/support/WebMediaStreamDescriptor.cpp:
(WebKit::WebMediaStreamDescriptor::label):
(WebKit):
(WebKit::WebMediaStreamDescriptor::id):
* platform/mediastream/MediaStreamComponent.h:
(WebCore::MediaStreamComponent::id):
(WebCore::MediaStreamComponent::MediaStreamComponent):
(MediaStreamComponent):
* platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptor::create):
(WebCore::MediaStreamDescriptor::id):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
(MediaStreamDescriptor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFlexboxes incorrectly add the scrollbar width to the intrinsic width of fixed-width...
ojan@chromium.org [Thu, 10 Jan 2013 20:32:24 +0000 (20:32 +0000)]
Flexboxes incorrectly add the scrollbar width to the intrinsic width of fixed-width items
https://bugs.webkit.org/show_bug.cgi?id=106591

Reviewed by Levi Weintraub.

Source/WebCore:

The scrollbar width should only be added if the width of the flex item
is not fixed.

Test: fast/css/fixed-width-intrinsic-width-excludes-scrollbars.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computePreferredLogicalWidths):
Use shared helper method. This also happens to fix the vertical
writing-mode case.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::instrinsicScrollbarLogicalWidth):
(WebCore):
* rendering/RenderBox.h:
(RenderBox):
Add a method for determining the scrollbar's contribution to the boxes
intrinsic width.

* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
Use shared code for determining the scrollbar width and only add the
width when computing the intrinsic widths.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computePreferredLogicalWidths):\
Just adding a FIXME to account for scrollbar width.

LayoutTests:

* fast/css/fixed-width-intrinsic-width-excludes-scrollbars-expected.txt: Added.
* fast/css/fixed-width-intrinsic-width-excludes-scrollbars.html: Added.
* fast/css/positioned-overflow-scroll.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReplace unnecessary null-checks with an assert in MainResourceLoader::continueAfterNa...
japhet@chromium.org [Thu, 10 Jan 2013 20:21:35 +0000 (20:21 +0000)]
Replace unnecessary null-checks with an assert in MainResourceLoader::continueAfterNavigationPolicy.
https://bugs.webkit.org/show_bug.cgi?id=106476

Reviewed by Alexey Proskuryakov.

* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::continueAfterNavigationPolicy): Null-checks for resourceLoader were
    added in an abundance of caution in r139150. Given that we know the load hasn't been cancelled,
    resourceLoader can only be null if continueAfterNavigationPolicy() has already been called
    before when m_substituteData is valid. continueAfterNavigationPolicy() is only called for redirects,
    and SubstituteData doesn't support redirects, so it is correct to assert that resourceLoader is non-null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 10 Jan 2013 20:14:07 +0000 (20:14 +0000)]
Unreviewed GTK gardening.

Removing a few crash expectations for tests that haven't crashed
for a long time. Hopefully the crash causes have been fixed.
Adding a flaky failure expectation for a CSS Regions reftest.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDashboard Cleanup: Do not generate the page if we are about to reload.
jparent@chromium.org [Thu, 10 Jan 2013 19:52:33 +0000 (19:52 +0000)]
Dashboard Cleanup: Do not generate the page if we are about to reload.
https://bugs.webkit.org/show_bug.cgi?id=106584

Reviewed by Dirk Pranke.

Move the logic to determine if we should generate the page into
parseParameters() since that is where we have the knowledge to
determine it, and return that value to handleLocationChange,
rather than passing the changed parameters back to handleLocationChange
and having it make the decision.

This is logically equivalent, save one case: when we are about to do
a reload, we know that there is no reason to generate the page.  Old
code was causing an extra page generation in this case.

* TestResultServer/static-dashboards/dashboard_base.js:
(parseParameters):
(handleLocationChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Thu, 10 Jan 2013 19:47:23 +0000 (19:47 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-10

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoScrollingCoordinator touch event hit rects aren't converted to proper coordinates...
leviw@chromium.org [Thu, 10 Jan 2013 19:33:20 +0000 (19:33 +0000)]
ScrollingCoordinator touch event hit rects aren't converted to proper coordinates when in nested views
https://bugs.webkit.org/show_bug.cgi?id=106383

Reviewed by James Robinson.

Source/WebCore:

ScrollingCoordinator uses clippedOverflowRectForRepaint(0) to generate the bounds for a renderer's hit
testing rect. The rect this returns is in the coordinates of its document. This change converts the
rect to the outermost view's coordinate system using convertToContainingView.

Tests: platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::accumulateRendererTouchEventTargetRects):

LayoutTests:

* platform/chromium/fast/events/touch/resources: Added.
* platform/chromium/fast/events/touch/resources/frame-with-touch-handler.html: Added.
* platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt: Added.
* platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRegression(r137939): Heap-use-after-free in WebCore::accumulateDocumentEventTargetRects
leviw@chromium.org [Thu, 10 Jan 2013 19:29:37 +0000 (19:29 +0000)]
Regression(r137939): Heap-use-after-free in WebCore::accumulateDocumentEventTargetRects
https://bugs.webkit.org/show_bug.cgi?id=106454

Reviewed by James Robinson.

Source/WebCore:

Correctly removing child Documents from their parent's tracked touch handler maps when detaching and
when their last touch event handler is removed.

Test: fast/events/touch/nested-document-with-touch-handler-detached-crash.html

* dom/Document.cpp:
(WebCore::Document::detach):
(WebCore::Document::didRemoveEventTargetNode):

LayoutTests:

* fast/events/touch/nested-document-with-touch-handler-detached-crash.html: Added.
* fast/events/touch/nested-document-with-touch-handler-detached-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoConvert fast/css/positioned-overflow-scroll.html to a check-layout.js test
ojan@chromium.org [Thu, 10 Jan 2013 19:22:49 +0000 (19:22 +0000)]
Convert fast/css/positioned-overflow-scroll.html to a check-layout.js test
https://bugs.webkit.org/show_bug.cgi?id=106585

Reviewed by Tony Chang.

This is in preparation for adding more cases to this test.

* fast/css/positioned-overflow-scroll-expected.txt: Added.
* fast/css/positioned-overflow-scroll.html:
* platform/chromium-android/fast/css/positioned-overflow-scroll-expected.png: Removed.
* platform/chromium-android/fast/css/positioned-overflow-scroll-expected.txt: Removed.
* platform/chromium-linux/fast/css/positioned-overflow-scroll-expected.png: Removed.
* platform/chromium-mac-lion/fast/css/positioned-overflow-scroll-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/css/positioned-overflow-scroll-expected.png: Removed.
* platform/chromium-mac/fast/css/positioned-overflow-scroll-expected.png: Removed.
* platform/chromium-win/fast/css/positioned-overflow-scroll-expected.png: Removed.
* platform/chromium/fast/css/positioned-overflow-scroll-expected.txt: Removed.
* platform/efl/fast/css/positioned-overflow-scroll-expected.png: Removed.
* platform/efl/fast/css/positioned-overflow-scroll-expected.txt: Removed.
* platform/gtk/fast/css/positioned-overflow-scroll-expected.png: Removed.
* platform/gtk/fast/css/positioned-overflow-scroll-expected.txt: Removed.
* platform/mac/fast/css/positioned-overflow-scroll-expected.png: Removed.
* platform/mac/fast/css/positioned-overflow-scroll-expected.txt: Removed.
* platform/qt/fast/css/positioned-overflow-scroll-expected.png: Removed.
* platform/qt/fast/css/positioned-overflow-scroll-expected.txt: Removed.
* resources/check-layout.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r138222): WebDocumentLoaderMac-related leaks seen on Leaks bot
japhet@chromium.org [Thu, 10 Jan 2013 19:22:11 +0000 (19:22 +0000)]
REGRESSION(r138222): WebDocumentLoaderMac-related leaks seen on Leaks bot
https://bugs.webkit.org/show_bug.cgi?id=106137

Reviewed by Brady Eidson.

Tested manually by comparing before and after leaks output for WK1-mac.

* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::receivedError): Call dispatchDidFailLoading() if
    a SubstituteData load fails or is cancelled. Without this call, load counts
    are not balanced on WebDocumentLoaderMac and it is retained forever.
(WebCore::MainResourceLoader::didFinishLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[jhbuild] Use the "configure" script to build glib
commit-queue@webkit.org [Thu, 10 Jan 2013 19:11:51 +0000 (19:11 +0000)]
[jhbuild] Use the "configure" script to build glib
https://bugs.webkit.org/show_bug.cgi?id=106569

Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2013-01-10
Reviewed by Martin Robinson.

So far both EFL and GTK have been using autogen.sh to build glib.
While that does work most of the time, it's not really needed since
we are downloading and building stable releases from tarballs.
Additionally, autogen.sh fails to work with automake 1.13 due to the
usage of some macros that have been removed (this has already been
fixed in glib master).

* efl/jhbuild.modules:
* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEnsure that WebPageProxy's notion of pageScaleFactor is reset on didCommitLoad
timothy_horton@apple.com [Thu, 10 Jan 2013 18:44:48 +0000 (18:44 +0000)]
Ensure that WebPageProxy's notion of pageScaleFactor is reset on didCommitLoad
https://bugs.webkit.org/show_bug.cgi?id=103290
<rdar://problem/12752467>

Reviewed by Darin Adler.

When a standard main frame load is committed, we reset the WebPage's
pageScaleFactor, if it's not the default. However, if the previous
page had a full-main-frame plugin that was handling page scaling itself,
WebPageProxy can have a cached pageScaleFactor != 1, while WebPage
now (since the plugin that was overriding (set)pageScaleFactor is gone)
has a pageScaleFactor of 1, causing us to skip the call to reset the
WebPage's pageScaleFactor.

Therefore, when WebPageProxy is notified that a standard main-frame load
is committed, reset its cached notion of the pageScaleFactor.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame): Add a parameter which corresponds to FrameLoadType, so we can
determine whether a frame load is of FrameLoadTypeStandard (which matches the check to reset page scale in
WebFrameLoaderClient::didCommitLoad), so we can reset m_pageScaleFactor.
* UIProcess/WebPageProxy.h:
(WebPageProxy): Add frameLoadType parameter to didCommitLoadForFrame.
* UIProcess/WebPageProxy.messages.in: Add frameLoadType parameter to didCommitLoadForFrame.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad): Pass frameLoadType parameter to didCommitLoadForFrame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPDFPlugin: Cmd-/+ should affect PDF page scale
timothy_horton@apple.com [Thu, 10 Jan 2013 18:42:07 +0000 (18:42 +0000)]
PDFPlugin: Cmd-/+ should affect PDF page scale
https://bugs.webkit.org/show_bug.cgi?id=103285
<rdar://problem/12710469>

Reviewed by Darin Adler.

Plugins which support handling page scale themselves should also handle
page zoom, as it is a very similar concept.

This patch disables text zoom in the case of a main-frame plugin which supports
page scale factor changes, as it is not needed in the PDFPlugin case
(we can't do text-only scale for PDF), but it could be added later if needed.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::pageZoomFactorDidChange):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in:
Add WebPageProxy::pageZoomFactorDidChange, to notify WebPageProxy of
out-of-band page zoom factor changes (in this case, from PluginView).

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::setPageScaleFactor):
Update WebPageProxy's notion of the current page zoom whenever PluginView
is notified of a page scale factor change.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setTextZoomFactor): We don't support text zoom in plugins, but
we also don't want it to silently act on the Frame if we have a plugin that
purports to handle page scale itself. Return early if this is the case.
(WebKit::WebPage::pageZoomFactor): For plugins that support page scale factor,
we equate page scale and page zoom. Return the PluginView's page scale factor
in place of the Frame's page zoom factor.
(WebKit::WebPage::setPageZoomFactor): Make page zoom changes in the aforementioned
case affect the PluginView's page scale.
(WebKit::WebPage::setPageAndTextZoomFactors): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoManually revert http://trac.webkit.org/changeset/136012
rjkroege@chromium.org [Thu, 10 Jan 2013 18:41:04 +0000 (18:41 +0000)]
Manually revert trac.webkit.org/changeset/136012
https://bugs.webkit.org/show_bug.cgi?id=106580

Reviewed by Dimitri Glazkov.

Source/WebCore:

136012 broke touch-scrolling of an overflow div in an iframe. Revert manually
to work around conflicts.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):

LayoutTests:

* fast/events/touch/gesture/touch-gesture-scroll-remove-node-expected.txt: Removed.
* fast/events/touch/gesture/touch-gesture-scroll-remove-node.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChanging tests to be consistent and use self.scm rather then recreating the scm object.
commit-queue@webkit.org [Thu, 10 Jan 2013 18:41:02 +0000 (18:41 +0000)]
Changing tests to be consistent and use self.scm rather then recreating the scm object.
(Missed a couple)
https://bugs.webkit.org/show_bug.cgi?id=106536

Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-10
Reviewed by Eric Seidel.

* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r136967): margin-top + overflow:hidden causes incorrect layout for interna...
robert@webkit.org [Thu, 10 Jan 2013 18:39:17 +0000 (18:39 +0000)]
REGRESSION(r136967): margin-top + overflow:hidden causes incorrect layout for internal floated elements
https://bugs.webkit.org/show_bug.cgi?id=106374

Reviewed by David Hyatt.

Source/WebCore:

r136397 treated any self-collapsing block that had a clearance delta as though it was clearing a float, but
blocks that avoid floats can get a clearance delta too. So just ensure there is clearance on the block when deciding
whether we need to add the margin back in before placing the float.

Test: fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden-and-float-child.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):

LayoutTests:

* fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden-and-float-child-expected.txt: Added.
* fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden-and-float-child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPDFPlugin: Header cleanup
timothy_horton@apple.com [Thu, 10 Jan 2013 18:39:13 +0000 (18:39 +0000)]
PDFPlugin: Header cleanup
https://bugs.webkit.org/show_bug.cgi?id=106540

Reviewed by Andreas Kling.

* WebProcess/Plugins/PDF/PDFPlugin.mm: Remove some unneeded headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Update expectations for fast/regions/selecting-text-through-different...
dglazkov@chromium.org [Thu, 10 Jan 2013 18:28:53 +0000 (18:28 +0000)]
[Chromium] Update expectations for fast/regions/selecting-text-through-different-region-flows.html.

* platform/chromium-mac-lion/fast/regions/selecting-text-through-different-region-flows-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Color picker in Styles pane shows wrong initial color
apavlov@chromium.org [Thu, 10 Jan 2013 18:27:51 +0000 (18:27 +0000)]
Web Inspector: Color picker in Styles pane shows wrong initial color
https://bugs.webkit.org/show_bug.cgi?id=106567

Reviewed by Pavel Feldman.

The RGB's G value for "crimson" was wrong.

* inspector/front-end/Color.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Mark more inspector/geolocation* tests as flaky on Win.
dglazkov@chromium.org [Thu, 10 Jan 2013 18:27:22 +0000 (18:27 +0000)]
[Chromium] Mark more inspector/geolocation* tests as flaky on Win.
https://bugs.webkit.org/show_bug.cgi?id=106426

* platform/chromium/TestExpectations: Marked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Refactor InspectorTest to create output interface
commit-queue@webkit.org [Thu, 10 Jan 2013 18:25:39 +0000 (18:25 +0000)]
Web Inspector: Refactor InspectorTest to create output interface
https://bugs.webkit.org/show_bug.cgi?id=106231

Patch by John J. Barton <johnjbarton@chromium.org> on 2013-01-10
Reviewed by Pavel Feldman.

Refactor InspectorTest to extract InspectorTest.Output, the API
used between InspectorTest and the test output reciever (the
test-script page by default).

* http/tests/inspector/inspector-test.js:
(initialize_InspectorTest.InspectorTest.Output.testComplete):
(initialize_InspectorTest.InspectorTest.Output.addResult):
(initialize_InspectorTest.InspectorTest.Output.clearResults):
(initialize_InspectorTest.InspectorTest.completeTest):
(initialize_InspectorTest.InspectorTest.addResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSpeed up supplemental dependency computation
tony@chromium.org [Thu, 10 Jan 2013 18:25:07 +0000 (18:25 +0000)]
Speed up supplemental dependency computation
https://bugs.webkit.org/show_bug.cgi?id=106503

Reviewed by Adam Barth.

.:

* Source/cmake/WebKitMacros.cmake: Add --idlAttributesFile to the binding generation step in cmake.

Source/WebCore:

On my machine, generating supplemental IDL dependencies was taking about 18s
because it has to run the C preprocessor on each IDL file. Avoid this by using
a regular expression to find the Supplemental= value in each IDL file rather than
doing a full parse. Now generating supplemental IDL dependencies is less than a
second.

preprocess-idls.pl used to also check IDL attributes against IDLAttributes.txt.
Move this code to run in generate-bindings.pl. This change revealed that
TestRunner.idl uses PassContext so add that to IDLAttributes.txt.

No new tests, this is a build refactor. EWS bots should be green.

* DerivedSources.make: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
* DerivedSources.pri: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
* GNUmakefile.am: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
* UseJSC.cmake: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
* UseV8.cmake: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
* WebCore.gyp/WebCore.gyp: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
* bindings/scripts/IDLAttributes.txt: Add PassContext needed by TestRunner.idl.
* bindings/scripts/generate-bindings.pl:
(loadIDLAttributes): Moved from preprocess-idls.pl.
(checkIDLAttributes): Moved from preprocess-idls.pl.
(checkIfIDLAttributesExists): Moved from preprocess-idls.pl.
* bindings/scripts/preprocess-idls.pl:
(getSupplementalFromIDLFile): Helper method to get Supplemental=* quickly.

Tools:

Pass the IDL attributes file for generating the bindings in WebKitTestRunner.

* WebKitTestRunner/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Filters] RenderLayerCompositor::addToOverlapMap should take into account the...
mvujovic@adobe.com [Thu, 10 Jan 2013 18:16:00 +0000 (18:16 +0000)]
[CSS Filters] RenderLayerCompositor::addToOverlapMap should take into account the filters outsets (ie. blur and drop-shadow)
https://bugs.webkit.org/show_bug.cgi?id=94022

Reviewed by Simon Fraser.

Source/WebCore:

When a layer has a filter that moves pixels, we need to add its entire bounds, including its
outsets and children, to the overlap map. The filter can move the children's pixels
anywhere in the layer, so we can't rely on the children's bounds.

Eventually, we should avoid adding children to the overlap map if the parent's bounds used
for overlap testing already include the children. I've added a FIXME for this optimization.

Tests: compositing/filters/sw-layer-overlaps-hw-shadow.html
       compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow.html
       compositing/filters/sw-shadow-overlaps-hw-layer.html
       compositing/filters/sw-shadow-overlaps-hw-shadow.html

* rendering/RenderLayer.h:
(WebCore::RenderLayer::overlapBounds):
    If necessary, return the calculated layer bounds, including the children. Otherwise,
    return the localBoundingBox.
(RenderLayer):
(WebCore::RenderLayer::overlapBoundsIncludeChildren):
    If the layer has a filter that moves pixels, return true.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMap):
    Add the overlapBounds instead of the localBoundingBox to the overlap map.
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
    Use the overlapBounds instead of the localBoundingBox for overlap testing.

LayoutTests:

Add tests to check several combinations of software layer and composited layer overlap when
filter outsets are involved.

* compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Added.
* compositing/filters/sw-layer-overlaps-hw-shadow.html: Added.
* compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Added.
* compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow.html: Added.
* compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Added.
* compositing/filters/sw-shadow-overlaps-hw-layer.html: Added.
* compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Added.
* compositing/filters/sw-shadow-overlaps-hw-shadow.html: Added.
* platform/chromium/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Added.
* platform/chromium/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agointrinsic min-widths don't override width for file upload controls
ojan@chromium.org [Thu, 10 Jan 2013 18:08:36 +0000 (18:08 +0000)]
intrinsic min-widths don't override width for file upload controls
https://bugs.webkit.org/show_bug.cgi?id=106517

Reviewed by Tony Chang.

Source/WebCore:

Separate out computing intrinsic width from perferred width so that
we can use the intrinsic width correctly when applying min-width/max-width.
The preferred width is the width used in its container's computation
of its intrinsic width.

This is the first in a series of patches making this work across
the render tree.

Test: fast/forms/file/intrinsic-min-width-overrides-width.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::minIntrinsicLogicalWidth):
(WebCore):
(WebCore::RenderBox::maxIntrinsicLogicalWidth):
(WebCore::RenderBox::computeIntrinsicLogicalWidths):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidths):
(WebCore):
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
* rendering/RenderFileUploadControl.h:
(RenderFileUploadControl):

LayoutTests:

* fast/forms/file/intrinsic-min-width-overrides-width-expected.html: Added.
* fast/forms/file/intrinsic-min-width-overrides-width.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Unreviewed gardening.
fmalita@chromium.org [Thu, 10 Jan 2013 17:56:12 +0000 (17:56 +0000)]
[Chromium] Unreviewed gardening.

Rebaselining results after http://trac.webkit.org/changeset/138250.

* platform/chromium-linux-x86/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
* platform/chromium-mac-lion/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
* platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
* platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-mac-lion/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
* platform/chromium-mac-lion/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
* platform/chromium-mac-lion/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
* platform/chromium-mac-lion/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
* platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
* platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
* platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/chromium-mac/svg/custom/feDisplacementMap-01-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-mac/svg/filters/feImage-animated-transform-on-target-rect-expected.png:
* platform/chromium-mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
* platform/chromium-mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
* platform/chromium-mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
* platform/chromium-mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
* platform/chromium-mac/svg/filters/feImage-late-indirect-update-expected.png:
* platform/chromium-mac/svg/filters/feImage-multiple-targets-id-change-expected.png:
* platform/chromium-mac/svg/filters/feImage-position-expected.png:
* platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
* platform/chromium-mac/svg/filters/feImage-reference-invalidation-expected.png:
* platform/chromium-mac/svg/filters/feImage-subregions-expected.png:
* platform/chromium-mac/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
* platform/chromium-mac/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
* platform/chromium-mac/svg/filters/feImage-target-add-to-document-expected.png:
* platform/chromium-mac/svg/filters/feImage-target-attribute-change-expected.png:
* platform/chromium-mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png:
* platform/chromium-mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png:
* platform/chromium-mac/svg/filters/feImage-target-changes-id-expected.png:
* platform/chromium-mac/svg/filters/feImage-target-id-change-expected.png:
* platform/chromium-mac/svg/filters/feImage-target-inline-style-change-expected.png:
* platform/chromium-mac/svg/filters/feImage-target-property-change-expected.png:
* platform/chromium-mac/svg/filters/feImage-target-reappend-to-document-expected.png:
* platform/chromium-mac/svg/filters/feImage-target-remove-from-document-expected.png:
* platform/chromium-mac/svg/filters/feImage-target-style-change-expected.png:
* platform/chromium-win-xp/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
* platform/chromium-win-xp/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
* platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
* platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
* platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
* platform/chromium-win/svg/filters/feImage-late-indirect-update-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Autotools] Add the AM_WEBKIT_FEATURE_CONDITIONAL macro
zandobersek@gmail.com [Thu, 10 Jan 2013 17:51:57 +0000 (17:51 +0000)]
[Autotools] Add the AM_WEBKIT_FEATURE_CONDITIONAL macro
https://bugs.webkit.org/show_bug.cgi?id=106576

Reviewed by Martin Robinson.

Replace the AC_CHECK_WEBKIT_FEATURE_ENABLED with the new macro.
The former was executing actions based on the passed-in feature being
enabled in the (possibly overridden) GNUmakefile.features.am, the actions
usually affecting the Automake conditional value that was set up afterwards.
The new macro does this directly, setting up an Automake conditional of the
same name as the feature that was checked.

* Source/autotools/webkitfeature.m4:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agomedia/video-controls-captions.html fails after fixing https://bugs.webkit.org/show_bu...
victor@rosedu.org [Thu, 10 Jan 2013 17:45:41 +0000 (17:45 +0000)]
media/video-controls-captions.html fails after fixing https://bugs.webkit.org/show_bug.cgi?id=105536
https://bugs.webkit.org/show_bug.cgi?id=106230

Reviewed by Eric Carlson.

Source/WebCore:

Until Chromium has proper controls for lists of text tracks, the caption button
needs to preserve its functionality.

Updated TestExpectations to reactivate test.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Added explicit call to updateTextTrackDisplay.
This enables hiding the tracks immediately.
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Added extra check before rendering
that captions should actually be displayed.

LayoutTests:

* platform/chromium/TestExpectations: Reactivated test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoComposedShadowTreeWalker shouldn't be exposed to non-ShadowDOM classes
morrita@google.com [Thu, 10 Jan 2013 17:44:05 +0000 (17:44 +0000)]
ComposedShadowTreeWalker shouldn't be exposed to non-ShadowDOM classes
https://bugs.webkit.org/show_bug.cgi?id=106505

Reviewed by Dimitri Glazkov.

This change hides ComposedShadowTreeWalker from non-ShadowDOM classes by

- introducing thin wrapper functions on NodeRenderingTraversal and relacing
  CSTW callsites with it,
- replacing ComposedShadowTreeWalker usage with AncestorChainWalker if possible and
- moving AncestorChainWalker to its own file and including it on files
  which needs only AncestorChainWalker. This eliminates ComposedShadowTreeWalker.h inclusions.

No new tests. No behavior change.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/AncestorChainWalker.cpp: Added. Extracted from ComposedShadowTreeWalker.cpp
(WebCore):
(WebCore::AncestorChainWalker::AncestorChainWalker):
(WebCore::AncestorChainWalker::parent):
* dom/AncestorChainWalker.h: Added. Extracted from ComposedShadowTreeWalker.h
(WebCore):
(AncestorChainWalker):
(WebCore::AncestorChainWalker::get):
(WebCore::AncestorChainWalker::crossingInsertionPoint):
* dom/ComposedShadowTreeWalker.cpp:
* dom/ComposedShadowTreeWalker.h:
* dom/DOMAllInOne.cpp:
* dom/ElementShadow.h:
(WebCore::shadowOfParent):
(WebCore):
* dom/EventDispatcher.cpp:
* dom/Node.cpp:
* dom/NodeRenderingTraversal.cpp:
(WebCore::NodeRenderingTraversal::nextInScope):
(NodeRenderingTraversal):
(WebCore::NodeRenderingTraversal::previousInScope): Added.
(WebCore::NodeRenderingTraversal::parentInScope): Added.
(WebCore::NodeRenderingTraversal::lastChildInScope): Added.
* dom/NodeRenderingTraversal.h:
(NodeRenderingTraversal):
* dom/TreeScope.cpp:
* html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::attach):
* page/EventHandler.cpp:
* page/FocusController.cpp: Replacing CSTW with NRT
(WebCore):
(WebCore::FocusNavigationScope::focusNavigationScopeOf):
(WebCore::FocusController::findNodeWithExactTabIndex):
(WebCore::nextNodeWithGreaterTabIndex):
(WebCore::previousNodeWithLowerTabIndex):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the ENABLE_ANIMATION_API feature define occurences
zandobersek@gmail.com [Thu, 10 Jan 2013 17:29:45 +0000 (17:29 +0000)]
Remove the ENABLE_ANIMATION_API feature define occurences
https://bugs.webkit.org/show_bug.cgi?id=106544

Reviewed by Simon Fraser.

The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
feature define handling still lingers in various build systems and configurations
but is of no use, so it should be removed.

.:

* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests - no new functionality.

* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.features.am.in:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r139227.
dglazkov@chromium.org [Thu, 10 Jan 2013 17:27:29 +0000 (17:27 +0000)]
Unreviewed, rolling out r139227.
http://trac.webkit.org/changeset/139227
https://bugs.webkit.org/show_bug.cgi?id=106227

Broke Win component build.

* public/WebAccessibilityObject.h:
* public/WebAccessibilityRole.h:
* public/WebActiveWheelFlingParameters.h:
* public/WebAnimationController.h:
* public/WebApplicationCacheHost.h:
* public/WebApplicationCacheHostClient.h:
* public/WebArrayBuffer.h:
* public/WebAudioSourceProvider.h:
* public/WebBatteryStatus.h:
* public/WebBindings.h:
* public/WebBlob.h:
* public/WebCache.h:
* public/WebCachedURLRequest.h:
* public/WebColorChooser.h:
* public/WebColorChooserClient.h:
* public/WebColorName.h:
* public/WebCommonWorkerClient.h:
* public/WebCompositionUnderline.h:
* public/WebCompositorInputHandler.h:
* public/WebConsoleMessage.h:
* public/WebContentDetectionResult.h:
* public/WebContextMenuData.h:
* public/WebCrossOriginPreflightResultCache.h:
* public/WebCursorInfo.h:
* public/WebDOMEvent.h:
* public/WebDOMEventListener.h:
* public/WebDOMStringList.h:
* public/WebDataSource.h:
* public/WebDatabase.h:
* public/WebDateTimeChooserCompletion.h:
* public/WebDateTimeChooserParams.h:
* public/WebDeliveredIntentClient.h:
* public/WebDevToolsAgent.h:
* public/WebDevToolsAgentClient.h:
* public/WebDevToolsFrontend.h:
* public/WebDeviceOrientationClient.h:
* public/WebDeviceOrientationClientMock.h:
* public/WebDeviceOrientationController.h:
* public/WebDocument.h:
* public/WebDraggableRegion.h:
* public/WebExternalPopupMenuClient.h:
* public/WebFileChooserCompletion.h:
* public/WebFileChooserParams.h:
* public/WebFileSystemCallbacks.h:
* public/WebFileSystemEntry.h:
* public/WebFileWriter.h:
* public/WebFileWriterClient.h:
* public/WebFindOptions.h:
* public/WebFont.h:
* public/WebFontCache.h:
* public/WebFontDescription.h:
* public/WebFormControlElement.h:
* public/WebFormElement.h:
* public/WebFrame.h:
* public/WebFrameClient.h:
* public/WebGeolocationClientMock.h:
* public/WebGeolocationController.h:
* public/WebGeolocationError.h:
* public/WebGeolocationPermissionRequest.h:
* public/WebGeolocationPermissionRequestManager.h:
* public/WebGeolocationPosition.h:
* public/WebGlyphCache.h:
* public/WebHelperPlugin.h:
* public/WebHistoryItem.h:
* public/WebHitTestResult.h:
* public/WebIDBCallbacks.h:
* public/WebIDBCursor.h:
* public/WebIDBDatabase.h:
* public/WebIDBDatabaseCallbacks.h:
* public/WebIDBDatabaseError.h:
* public/WebIDBFactory.h:
* public/WebIDBIndex.h:
* public/WebIDBKey.h:
* public/WebIDBKeyPath.h:
* public/WebIDBKeyRange.h:
* public/WebIDBMetadata.h:
* public/WebIDBObjectStore.h:
* public/WebIDBTransaction.h:
* public/WebIDBTransactionCallbacks.h:
* public/WebIconURL.h:
* public/WebImageDecoder.h:
* public/WebInputEvent.h:
* public/WebIntent.h:
* public/WebIntentRequest.h:
* public/WebIntentServiceInfo.h:
* public/WebMediaPlayer.h:
* public/WebMediaStreamRegistry.h:
* public/WebMenuItemInfo.h:
* public/WebNetworkStateNotifier.h:
* public/WebNode.h:
* public/WebNodeCollection.h:
* public/WebNodeList.h:
* public/WebNotification.h:
* public/WebNotificationPresenter.h:
* public/WebOptionElement.h:
* public/WebPageOverlay.h:
* public/WebPagePopup.h:
* public/WebPageSerializer.h:
* public/WebPasswordFormData.h:
* public/WebPerformance.h:
* public/WebPlugin.h:
* public/WebPluginContainer.h:
* public/WebPluginParams.h:
* public/WebPopupMenu.h:
* public/WebPopupMenuInfo.h:
* public/WebPrerendererClient.h:
* public/WebPrintParams.h:
* public/WebRange.h:
* public/WebRegularExpression.h:
* public/WebRuntimeFeatures.h:
* public/WebScopedMicrotaskSuppression.h:
* public/WebScopedUserGesture.h:
* public/WebScriptController.h:
* public/WebScriptSource.h:
* public/WebSearchableFormData.h:
* public/WebSecurityOrigin.h:
* public/WebSecurityPolicy.h:
* public/WebSelectElement.h:
* public/WebSettings.h:
* public/WebSharedWorker.h:
* public/WebSharedWorkerRepository.h:
* public/WebSpeechGrammar.h:
* public/WebSpeechInputController.h:
* public/WebSpeechInputResult.h:
* public/WebSpeechRecognitionHandle.h:
* public/WebSpeechRecognitionParams.h:
* public/WebSpeechRecognitionResult.h:
* public/WebSpeechRecognizer.h:
* public/WebSpeechRecognizerClient.h:
* public/WebSpellCheckClient.h:
* public/WebStorageEventDispatcher.h:
* public/WebSurroundingText.h:
* public/WebTestingSupport.h:
* public/WebTextCheckingCompletion.h:
* public/WebTextCheckingResult.h:
* public/WebTextFieldDecoratorClient.h:
* public/WebTextInputInfo.h:
* public/WebTextRun.h:
* public/WebTimeRange.h:
* public/WebTouchPoint.h:
* public/WebUserMediaRequest.h:
* public/WebView.h:
* public/WebViewBenchmarkSupport.h:
* public/WebViewClient.h:
* public/WebWidget.h:
* public/WebWidgetClient.h:
* public/WebWindowFeatures.h:
* public/WebWorkerInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSerialization of Gradients fails when PlatformContextSkia is not bitmap backed
commit-queue@webkit.org [Thu, 10 Jan 2013 16:48:39 +0000 (16:48 +0000)]
Serialization of Gradients fails when PlatformContextSkia is not bitmap backed
https://bugs.webkit.org/show_bug.cgi?id=106559

Patch by Robert Phillips <robertphillips@chromium.org> on 2013-01-10
Reviewed by Stephen White.

This patch switches over from having platform/Skia improperly
crack open the device to find the bitmap configuration to just
specifying it directly.

No new tests. This bug is Chromium specific and only occurs in a
debugging tool (when serializing to a Skia-specific file format).

* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::createCompatibleDevice):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoThe "outline-offset" property is not found in the computed style property list
apavlov@chromium.org [Thu, 10 Jan 2013 16:27:04 +0000 (16:27 +0000)]
The "outline-offset" property is not found in the computed style property list
https://bugs.webkit.org/show_bug.cgi?id=106561

Reviewed by Alexis Menard.

Source/WebCore:

Listed CSSPropertyOutlineOffset in the CSSComputedStyleDeclaration's computedProperties[].

Test: fast/css/getComputedStyle/getComputedStyle-outline-offset.html

* css/CSSComputedStyleDeclaration.cpp:

LayoutTests:

* fast/css/getComputedStyle/getComputedStyle-outline-offset-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-outline-offset.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPluginPackage::freeLibraryTimerFired asserts if plugin got loaded again meanwhile
commit-queue@webkit.org [Thu, 10 Jan 2013 15:31:13 +0000 (15:31 +0000)]
PluginPackage::freeLibraryTimerFired asserts if plugin got loaded again meanwhile
https://bugs.webkit.org/show_bug.cgi?id=106463

Patch by David Faure <faure@kde.org> on 2013-01-10
Reviewed by Simon Hausmann.

No new tests, this code path will be tested by bug 106140.

* plugins/PluginPackage.cpp:
(WebCore::PluginPackage::freeLibraryTimerFired): skip unloading if loaded again meanwhile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCSSParser does not allow the absence of whitespace between "and" and "expression"
dominik.rottsches@intel.com [Thu, 10 Jan 2013 15:13:18 +0000 (15:13 +0000)]
CSSParser does not allow the absence of whitespace between "and" and "expression"
https://bugs.webkit.org/show_bug.cgi?id=106458

Patch by Alexander Pavlov <apavlov@chromium.org> on 2013-01-10
Reviewed by Antti Koivisto.

* fast/css/media-rule-no-whitespace-expected.txt: Added.
* fast/css/media-rule-no-whitespace.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCSSParser does not allow the absence of whitespace between "and" and "expression"
apavlov@chromium.org [Thu, 10 Jan 2013 14:40:53 +0000 (14:40 +0000)]
CSSParser does not allow the absence of whitespace between "and" and "expression"
https://bugs.webkit.org/show_bug.cgi?id=106458

Reviewed by Antti Koivisto.

Source/WebCore:

The issue was that a construct similar to "and(max-width: 480px)" looks like a function call (token type FUNCTION), even though
it is actually a MEDIA_AND followed by a parenthesized expression.

Test: fast/css/media-rule-no-whitespace.html

* css/CSSParser.cpp:
(WebCore::CSSParser::detectFunctionTypeToken): Return if the detection has been successful.
(WebCore::CSSParser::realLex): Test for media query tokens if function type detection has failed.
* css/CSSParser.h:

LayoutTests:

* fast/css/media-rule-no-whitespace-expected.txt: Added.
* fast/css/media-rule-no-whitespace.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Unreviewed gardening.
fmalita@chromium.org [Thu, 10 Jan 2013 14:23:58 +0000 (14:23 +0000)]
[Chromium] Unreviewed gardening.

Rebaselining results after http://trac.webkit.org/changeset/139191.

* platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
* platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac-lion/compositing/video/video-controls-layer-creation-expected.png:
* platform/chromium-mac-lion/fast/backgrounds/background-leakage-transforms-expected.png:
* platform/chromium-mac-lion/fast/borders/border-radius-split-inline-expected.png:
* platform/chromium-mac-lion/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
* platform/chromium-mac-lion/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-mac-lion/fast/css/shadow-multiple-expected.png:
* platform/chromium-mac-lion/fast/css/text-input-with-webkit-border-radius-expected.png:
* platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac-lion/fast/hidpi/video-controls-in-hidpi-expected.png:
* platform/chromium-mac-lion/fast/layers/video-layer-expected.png:
* platform/chromium-mac-lion/fast/regions/full-screen-video-from-region-expected.png:
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-mac-lion/fast/transforms/shadows-expected.png:
* platform/chromium-mac-lion/fullscreen/full-screen-stacking-context-expected.png:
* platform/chromium-mac-lion/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png:
* platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
* platform/chromium-mac-lion/media/audio-controls-rendering-expected.png:
* platform/chromium-mac-lion/media/audio-repaint-expected.png:
* platform/chromium-mac-lion/media/controls-after-reload-expected.png:
* platform/chromium-mac-lion/media/controls-layout-direction-expected.png:
* platform/chromium-mac-lion/media/controls-strict-expected.png:
* platform/chromium-mac-lion/media/controls-styling-expected.png:
* platform/chromium-mac-lion/media/controls-styling-strict-expected.png:
* platform/chromium-mac-lion/media/controls-without-preload-expected.png:
* platform/chromium-mac-lion/media/media-controls-clone-expected.png:
* platform/chromium-mac-lion/media/media-document-audio-repaint-expected.png:
* platform/chromium-mac-lion/media/video-controls-rendering-expected.png:
* platform/chromium-mac-lion/media/video-display-toggle-expected.png:
* platform/chromium-mac-lion/media/video-empty-source-expected.png:
* platform/chromium-mac-lion/media/video-no-audio-expected.png:
* platform/chromium-mac-lion/media/video-playing-and-pause-expected.png:
* platform/chromium-mac-lion/media/video-zoom-controls-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac-snowleopard/compositing/video/video-controls-layer-creation-expected.png:
* platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png:
* platform/chromium-mac-snowleopard/fast/borders/border-radius-split-inline-expected.png:
* platform/chromium-mac-snowleopard/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
* platform/chromium-mac-snowleopard/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac-snowleopard/fast/layers/video-layer-expected.png:
* platform/chromium-mac-snowleopard/fast/regions/full-screen-video-from-region-expected.png:
* platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
* platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png:
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
* platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
* platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
* platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
* platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png:
* platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
* platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
* platform/chromium-mac-snowleopard/media/controls-styling-strict-expected.png:
* platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
* platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png:
* platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
* platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
* platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
* platform/chromium-mac-snowleopard/media/video-empty-source-expected.png:
* platform/chromium-mac-snowleopard/media/video-no-audio-expected.png:
* platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac/compositing/video/video-controls-layer-creation-expected.png:
* platform/chromium-mac/fast/backgrounds/background-leakage-expected.png:
* platform/chromium-mac/fast/backgrounds/background-leakage-transforms-expected.png:
* platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png:
* platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png:
* platform/chromium-mac/fast/box-shadow/spread-expected.png:
* platform/chromium-mac/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-mac/fast/css/shadow-multiple-expected.png:
* platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.png:
* platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.png:
* platform/chromium-mac/fast/layers/video-layer-expected.png:
* platform/chromium-mac/fast/regions/full-screen-video-from-region-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-mac/fast/transforms/shadows-expected.png:
* platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
* platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png:
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
* platform/chromium-mac/media/audio-controls-rendering-expected.png:
* platform/chromium-mac/media/audio-repaint-expected.png:
* platform/chromium-mac/media/controls-after-reload-expected.png:
* platform/chromium-mac/media/controls-layout-direction-expected.png:
* platform/chromium-mac/media/controls-strict-expected.png:
* platform/chromium-mac/media/controls-styling-expected.png:
* platform/chromium-mac/media/controls-styling-strict-expected.png:
* platform/chromium-mac/media/controls-without-preload-expected.png:
* platform/chromium-mac/media/media-controls-clone-expected.png:
* platform/chromium-mac/media/media-document-audio-repaint-expected.png:
* platform/chromium-mac/media/video-controls-rendering-expected.png:
* platform/chromium-mac/media/video-display-toggle-expected.png:
* platform/chromium-mac/media/video-empty-source-expected.png:
* platform/chromium-mac/media/video-no-audio-expected.png:
* platform/chromium-mac/media/video-playing-and-pause-expected.png:
* platform/chromium-mac/media/video-zoom-controls-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-win/compositing/video/video-controls-layer-creation-expected.png:
* platform/chromium-win/fast/backgrounds/background-leakage-expected.png:
* platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.png:
* platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
* platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
* platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
* platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
* platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
* platform/chromium-win/fast/box-shadow/spread-expected.png:
* platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
* platform/chromium-win/fast/css/shadow-multiple-expected.png:
* platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.png:
* platform/chromium-win/fast/layers/video-layer-expected.png:
* platform/chromium-win/fast/regions/full-screen-video-from-region-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-win/fast/transforms/shadows-expected.png:
* platform/chromium-win/fullscreen/full-screen-stacking-context-expected.png:
* platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png:
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
* platform/chromium-win/media/audio-controls-rendering-expected.png:
* platform/chromium-win/media/audio-repaint-expected.png:
* platform/chromium-win/media/controls-after-reload-expected.png:
* platform/chromium-win/media/controls-layout-direction-expected.png:
* platform/chromium-win/media/controls-strict-expected.png:
* platform/chromium-win/media/controls-styling-expected.png:
* platform/chromium-win/media/controls-styling-strict-expected.png:
* platform/chromium-win/media/controls-without-preload-expected.png:
* platform/chromium-win/media/media-controls-clone-expected.png:
* platform/chromium-win/media/media-document-audio-repaint-expected.png:
* platform/chromium-win/media/video-controls-rendering-expected.png:
* platform/chromium-win/media/video-display-toggle-expected.png:
* platform/chromium-win/media/video-empty-source-expected.png:
* platform/chromium-win/media/video-no-audio-expected.png:
* platform/chromium-win/media/video-playing-and-pause-expected.png:
* platform/chromium-win/media/video-zoom-controls-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium/TestExpectations:
* platform/efl-wk2/media/video-zoom-controls-expected.png: Renamed from LayoutTests/platform/efl/media/video-zoom-controls-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoASSERT_NOT_REACHED in StylePropertySet::fontValue when accessing font style property...
alexis@webkit.org [Thu, 10 Jan 2013 13:46:39 +0000 (13:46 +0000)]
ASSERT_NOT_REACHED in StylePropertySet::fontValue when accessing font style property through JS after setting style font size.
https://bugs.webkit.org/show_bug.cgi?id=88866

Reviewed by Alexander Pavlov.

Source/WebCore:

StylePropertySet::fontValue always assumed that it was called using
style.font after a subsequent call which set the shorthand font. The
ASSERT_NOT_REACHED assumed that all longhands of the font shorthand not
set by the shorthand itself were set to initial. While it's true when
we set the font shorthand (i.e all longhands are set to implicit initial)
it is not true when you set the longhands individually. For example setting
font-size will not set other font properties to initial. It is the behavior of all
other shorthands in WebKit. When reconstructing the shorthand other
properties tests whether the value of each longhands is initial or not
(if not then we omit the value, as we should always construct the
shortest shorthand possible) or if the value is set or not (if set then
we include it in the shorthand if not then we omit it). The comment
removed was also talking about invalid font property potentially built
by fontValue(). So far appendFontLonghandValueIfExplicit will always
construct a valid value as it takes care of adding ' ' or '/' when
needed, so the return value is parsable and correct.

Test: fast/css/font-shorthand-from-longhands.html

* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::appendFontLonghandValueIfExplicit):
(WebCore::StylePropertySet::fontValue):
* css/StylePropertySet.h:

LayoutTests:

Add tests to cover the bug.

* fast/css/font-shorthand-from-longhands-expected.txt: Added.
* fast/css/font-shorthand-from-longhands.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Contents gets blurry when page is scrolled down
mikhail.pozdnyakov@intel.com [Thu, 10 Jan 2013 13:37:27 +0000 (13:37 +0000)]
[EFL][WK2] Contents gets blurry when page is scrolled down
https://bugs.webkit.org/show_bug.cgi?id=106545

Reviewed by Kenneth Rohde Christiansen.

The bound values for scrolling also should be pixel aligned, otherwise
it leads to page contents blurriness when the page is scrolled down.

* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::pageDidRequestScroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Thu, 10 Jan 2013 12:28:45 +0000 (12:28 +0000)]
[EFL] Unreviewed gardening.

Marking one more flaky crasher due to gstreamer.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r139306.
loislo@chromium.org [Thu, 10 Jan 2013 12:28:11 +0000 (12:28 +0000)]
Unreviewed, rolling out r139306.
http://trac.webkit.org/changeset/139306
https://bugs.webkit.org/show_bug.cgi?id=106550

it broke inspector-protocol/nmi-webaudio-leak-test.html
(Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-10

* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::reportMemoryUsage):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::reportMemoryUsage):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::reportMemoryUsage):
* css/MediaList.cpp:
(WebCore::MediaList::reportMemoryUsage):
* css/RuleSet.cpp:
(WebCore::RuleData::reportMemoryUsage):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::reportMemoryUsage):
* dom/TreeScope.cpp:
(WebCore::TreeScope::reportMemoryUsage):
* inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::reportMemoryUsage):
* inspector/InspectorMemoryAgent.cpp:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::reportMemoryUsage):
* inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportMemoryUsage):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::reportMemoryUsage):
* loader/Prerenderer.cpp:
(WebCore::Prerenderer::reportMemoryUsage):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::reportMemoryUsage):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::reportMemoryUsage):
* page/Page.cpp:
(WebCore::Page::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Thu, 10 Jan 2013 12:25:44 +0000 (12:25 +0000)]
[EFL] Unreviewed gardening.

Marking three media tests as flaky crashers.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening, paint the bots green.
ossy@webkit.org [Thu, 10 Jan 2013 12:07:36 +0000 (12:07 +0000)]
Unreviewed gardening, paint the bots green.

* platform/qt/TestExpectations: Skip http/tests/security/isolatedWorld/* tests instead of marking them as failures. (r138817)
* platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.png: Added after r139197.
* platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.txt: Added after r139197.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Fix ietestcenter/css3/bordersbackgrounds/border-radius-clip-002.htm expect...
noel.gordon@gmail.com [Thu, 10 Jan 2013 11:49:05 +0000 (11:49 +0000)]
[chromium] Fix ietestcenter/css3/bordersbackgrounds/border-radius-clip-002.htm expectation lines

Unreviewed gardening.

* platform/chromium/TestExpectations: Two bugs and expectation lines refer to this test, and one
expectation line overrides the other: assign to the earlier bug and ditch the redundant line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Native Memory Instrumentation: fix instrumentation for already instrum...
loislo@chromium.org [Thu, 10 Jan 2013 11:31:09 +0000 (11:31 +0000)]
Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 2/N
https://bugs.webkit.org/show_bug.cgi?id=106546

Reviewed by Vsevolod Vlasov.

Many nontrivial class members were instrumented in reportMemoryUsage methods.

* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::reportMemoryUsage):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::reportMemoryUsage):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::reportMemoryUsage):
* css/MediaList.cpp:
(WebCore::MediaList::reportMemoryUsage):
* css/RuleSet.cpp:
(WebCore::RuleData::reportMemoryUsage):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::reportMemoryUsage):
* dom/TreeScope.cpp:
(WebCore::TreeScope::reportMemoryUsage):
* inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::reportMemoryUsage):
* inspector/InspectorMemoryAgent.cpp:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::reportMemoryUsage):
* inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportMemoryUsage):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::reportMemoryUsage):
* loader/Prerenderer.cpp:
(WebCore::Prerenderer::reportMemoryUsage):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::reportMemoryUsage):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::reportMemoryUsage):
* page/Page.cpp:
(WebCore::Page::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Add support for loading web process extensions
commit-queue@webkit.org [Thu, 10 Jan 2013 11:27:49 +0000 (11:27 +0000)]
[GTK] Add support for loading web process extensions
https://bugs.webkit.org/show_bug.cgi?id=105631

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-01-10
Reviewed by Gustavo Noronha Silva.

.:

* GNUmakefile.am: Add webkit2_web_extension_h_api.
* Source/autotools/symbols.filter: Export WebGtkExtensionManager
symbols required by the injected bundle lib.

Source/WebKit2:

* GNUmakefile.am: Link to libWebCoreDOM.la and build injected
bundle lib.
* GNUmakefile.list.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitWebContext.cpp:
(injectedBundleDirectory): Helper funtion to get the injected
bundle directory.
(injectedBundleFilename): Helper funtion to get the injected undle
library full path.
(createDefaultWebContext): Create the WebContext with an injected
bundle path.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_get_page_id): Return the identifier of the web
page associated to the web view.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new chapter for
web extensions.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/docs/webkit2gtk.types: Add new types.
* UIProcess/API/gtk/tests/GNUmakefile.am: Add new files to compilation.
* UIProcess/API/gtk/tests/TestMain.cpp:
(main):
* UIProcess/API/gtk/tests/TestWebExtensions.cpp: Added.
(testWebExtension):
(beforeAll):
(afterAll):
* UIProcess/API/gtk/tests/WebExtensionTest.cpp: Added.
(methodCallCallback):
(webkit_web_extension_initialize):
* UIProcess/API/gtk/tests/WebKitTestBus.cpp: Added.
(WebKitTestBus::WebKitTestBus):
(WebKitTestBus::run):
(WebKitTestBus::~WebKitTestBus):
(WebKitTestBus::connection):
(onNameAppeared):
(WebKitTestBus::createProxy):
* UIProcess/API/gtk/tests/WebKitTestBus.h: Added.
(WebKitTestBus):
* WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp: Added.
(_WebKitWebExtensionPrivate):
(webkitWebExtensionPageCreated): Create a WebKitWebPage for the
newly crated page and emit WebKitWebExtension::page-created
signals.
(webkitWebExtensionPageDestroy): Remove the page from the map.
(didCreatePage): Call webkitWebExtensionPageCreated().
(willDestroyPage): Call webkitWebExtensionPageDestroy().
(webkitWebExtensionCreate): Create a new WebKitWebExtension and
initialize the injected bundle client.
(webkit_web_extension_get_page): Return the WebKitWebPage for the
given page identifier.
* WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.h: Added.
(_WebKitWebExtension):
(_WebKitWebExtensionClass):
* WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionDefines.h: Added.
* WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionPrivate.h: Added.
* WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp: Added.
(_WebKitWebPagePrivate):
(webkit_web_page_class_init):
(webkitWebPageCreate): Create a new WebKitWebPage.
(webkit_web_page_get_dom_document): Return the WebKitDOMDocument
loaded in the WebKitWebPage.
* WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h: Added.
(_WebKitWebPage):
(_WebKitWebPageClass):
* WebProcess/InjectedBundle/API/gtk/WebKitWebPagePrivate.h: Added.
* WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h: Added.
* WebProcess/gtk/WebGtkExtensionManager.cpp: Added.
(WebKit::WebGtkExtensionManager::shared): Return the global shared
instance.
(WebKit::WebGtkExtensionManager::WebGtkExtensionManager):
(WebKit::WebGtkExtensionManager::appendModuleDirectories): Add
directories to scan for modules.
(WebKit::WebGtkExtensionManager::scanModules): Scan for modules.
(WebKit::WebGtkExtensionManager::initialize): Load and initialize
the modules found.
* WebProcess/gtk/WebGtkExtensionManager.h: Added.
* WebProcess/gtk/WebGtkInjectedBundleMain.cpp: Added.
(WKBundleInitialize): Initialize WebGtkExtensionManager.

Tools:

* MiniBrowser/gtk/GNUmakefile.am:
* MiniBrowser/gtk/main.c:
(main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
bundle lib from build dir.
* Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
located in WebProcess/InjectedBundle/API/gtk.
* gtk/generate-gtkdoc:
(get_webkit2_options): Scan also files in
WebProcess/InjectedBundle/API/gtk to generate API docs.
(get_webkit2_options.injected_bundle_src_path): Helper function to
build paths in WebProcess/InjectedBundle/API/gtk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Remove lost-compositor-context layout tests
noel.gordon@gmail.com [Thu, 10 Jan 2013 11:14:32 +0000 (11:14 +0000)]
[chromium] Remove lost-compositor-context layout tests
https://bugs.webkit.org/show_bug.cgi?id=106089

Unreviewed gardening.

* platform/chromium/TestExpectations: Remove all references to the
lost-compositor-context test expectations after r138814.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Writing immediately to created windows (open) fails
mikhail.pozdnyakov@intel.com [Thu, 10 Jan 2013 11:04:06 +0000 (11:04 +0000)]
[EFL][WK2] Writing immediately to created windows (open) fails
https://bugs.webkit.org/show_bug.cgi?id=105276

Reviewed by Kenneth Rohde Christiansen.

Do not reset 'about:blank' url for the new pages in mini browser.

* MiniBrowser/efl/main.c:
(window_create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Optimize expectations for fast/forms/button-inner-block-reuse.html
noel.gordon@gmail.com [Thu, 10 Jan 2013 10:52:11 +0000 (10:52 +0000)]
[chromium] Optimize expectations for fast/forms/button-inner-block-reuse.html

Unreviewed gardening.

* platform/chromium-win-xp/fast/forms/button-inner-block-reuse-expected.png: Removed.
* platform/chromium-win/fast/forms/button-inner-block-reuse-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Optimize expectaions for fast/forms/button-generated-content.html
noel.gordon@gmail.com [Thu, 10 Jan 2013 10:42:35 +0000 (10:42 +0000)]
[chromium] Optimize expectaions for fast/forms/button-generated-content.html

Unreviewed gardening.

* platform/chromium-win-xp/fast/forms/button-generated-content-expected.png: Removed.
* platform/chromium-win/fast/forms/button-generated-content-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r139189): pixel alignment must be performed in device units.
commit-queue@webkit.org [Thu, 10 Jan 2013 09:59:46 +0000 (09:59 +0000)]
REGRESSION(r139189): pixel alignment must be performed in device units.
https://bugs.webkit.org/show_bug.cgi?id=106504

Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-10
Reviewed by Kenneth Rohde Christiansen.

After r139189, pixel alignment is performed in UI units. If deviceScaleFactor is
fractional number, adjusted scroll position can blur non-composited layer.

* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::pixelAlignedFloatPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChanging tests to be consistent and use self.scm rather then recreating the scm object.
commit-queue@webkit.org [Thu, 10 Jan 2013 09:58:20 +0000 (09:58 +0000)]
Changing tests to be consistent and use self.scm rather then recreating the scm object.
https://bugs.webkit.org/show_bug.cgi?id=106536

Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-10
Reviewed by Eric Seidel.

* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Thu, 10 Jan 2013 09:35:17 +0000 (09:35 +0000)]
[EFL] Unreviewed gardening.

Marking a missing expectation for fast/repaint/caret-with-transformation.html

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 10 Jan 2013 09:21:37 +0000 (09:21 +0000)]
Unreviewed GTK gardening.

Removing a few failure expectations that are no longer needed.
The tests the expectations were covering now pass.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 10 Jan 2013 09:17:14 +0000 (09:17 +0000)]
Unreviewed GTK gardening.

Adding a platform-specific baseline for a CSS Regions test.
Adding a missing expectation for the fast/repaint/caret-with-transformation.html layout test.

* platform/gtk/TestExpectations:
* platform/gtk/fast/regions/selecting-text-through-different-region-flows-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Handle the case that start/end position is out of unclipped selection...
commit-queue@webkit.org [Thu, 10 Jan 2013 09:15:08 +0000 (09:15 +0000)]
[BlackBerry] Handle the case that start/end position is out of unclipped selection region
https://bugs.webkit.org/show_bug.cgi?id=106486

Patch by Yongxin Dai <yodai@rim.com> on 2013-01-10
Reviewed by Rob Buis.

PR #270624
Unclipped selection region should cover start/end position of the selection.
Since we exclude hidden text when calculating unclipped selection region, the
start/end position can be out of unclipped selection region if it is for hidden
text. If that is the case, start/end handle will be invisible. To avoid invisible
handle, we take unclipped selection region as reference rectangle in the case.

Internally reviewed by Genevieve Mak, Mike Fenton

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::referencePoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoConverting to unittest2 so we can use assertItemsEqual, making tests
commit-queue@webkit.org [Thu, 10 Jan 2013 09:06:27 +0000 (09:06 +0000)]
Converting to unittest2 so we can use assertItemsEqual, making tests
not dependent on order of items.
https://bugs.webkit.org/show_bug.cgi?id=106532

Before:
Ran 1733 tests in 38.385s
FAILED (failures=1, errors=22)

After:
Ran 1733 tests in 32.298s
FAILED (failures=0, errors=22)

Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-10
Reviewed by Eric Seidel.

* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook._install_unittest2):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2] [Gtk] web inspector is not visible.
commit-queue@webkit.org [Thu, 10 Jan 2013 08:59:01 +0000 (08:59 +0000)]
[WK2] [Gtk] web inspector is not visible.
https://bugs.webkit.org/show_bug.cgi?id=106050

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-01-10
Reviewed by Carlos Garcia Campos.

Use webkitWebViewBaseAddWebInspector when adding web inspector to
webview in order to make webview aware of its existence.

Use gtk_container_add when adding web inspector wiew to its own window
because m_inspectorWindow is not a WebKitWebViewBase.

* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformAttach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
christophe.dumez@intel.com [Thu, 10 Jan 2013 08:45:39 +0000 (08:45 +0000)]
Unreviewed EFL gardening.

Add platform expectation for new test added in r139197.

* platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.png: Added.
* platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Add gstreamer 1.0.5 to jhbuild
christophe.dumez@intel.com [Thu, 10 Jan 2013 08:42:41 +0000 (08:42 +0000)]
[EFL] Add gstreamer 1.0.5 to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=106178

Reviewed by Laszlo Gombos.

.:

Update EFL CMake configuration to require gstreamer
1.0.5.

* Source/cmake/FindGStreamer.cmake:
* Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Remove GSTREAMER_INTERFACES_LIBRARIES from EFL
CMake configuration.

No new tests, no behavior change for layout tests.

* PlatformEfl.cmake:

Source/WebKit:

Remove GSTREAMER_INTERFACES_LIBRARIES from EFL
CMake configuration.

* PlatformEfl.cmake:

Source/WebKit/efl:

Fix compilation error when using gstreamer 1.0.

* WebCoreSupport/FullscreenVideoControllerEfl.cpp:
* WebCoreSupport/FullscreenVideoControllerEfl.h:

Tools:

Add gstreamer 1.0.5 to EFL's jhbuild configuration.

* efl/jhbuild.modules:

LayoutTests:

Skip several media tests that are crashing with gstreamer 1.0.

* platform/efl/TestExpectations:
* platform/efl/media/sources-fallback-codecs-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix after r139266.
christophe.dumez@intel.com [Thu, 10 Jan 2013 07:44:22 +0000 (07:44 +0000)]
Unreviewed build fix after r139266.

r139266 broke the debug build of the gstreamer backend due
to a missing header include.

No new tests, no behavior change.

* platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIndexedDB: Allow createIndex/createObjectStore to be asynchronous
alecflett@chromium.org [Thu, 10 Jan 2013 07:33:14 +0000 (07:33 +0000)]
IndexedDB: Allow createIndex/createObjectStore to be asynchronous
https://bugs.webkit.org/show_bug.cgi?id=106377

Reviewed by Tony Chang.

Source/WebCore:

Migrate implementations of createIndex/deleteIndex,
createObjectStore/deleteObjectStore over to IDBDatabaseBackendImpl,
so that they can be asynchronous in multi-process ports.

Has the side effect of removing the last consumers of
IDBIndexBackendImpl and IDBObjectStoreBackendImpl. The former
is removed complete and the latter becomes a temporary namespace
pending a further more mechanical code shuffle.

A key refactoring effect is that the IDBDatabaseBackendImpl
now contains the authoritative IDBDatabaseMetadata hierarchy,
and updates to it are consolidated in one place rather than
scattered across a parallel object tree.

No new tests as this is just refactoring.

* Modules/indexeddb/IDBBackingStore.cpp: Simplify objectstore/index loading and propagate errors.
(WebCore::IDBBackingStore::getObjectStores):
(WebCore::IDBBackingStore::getIndexes):
* Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
* Modules/indexeddb/IDBCursorBackendImpl.cpp: Dependency cleanup.
* Modules/indexeddb/IDBCursorBackendImpl.h: Dependency cleanup.
(WebCore):
* Modules/indexeddb/IDBDatabase.cpp: Frontend IDBObjectStores no longer hold onto backend objects.
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Add all create/deleteIndex operations from IDBIndexBackendImpl.
(WebCore::CreateObjectStoreOperation::create):
(WebCore::CreateObjectStoreOperation::CreateObjectStoreOperation):
(CreateObjectStoreOperation):
(WebCore::DeleteObjectStoreOperation::create):
(WebCore::DeleteObjectStoreOperation::DeleteObjectStoreOperation):
(DeleteObjectStoreOperation):
(WebCore::CreateObjectStoreAbortOperation::create):
(WebCore::CreateObjectStoreAbortOperation::CreateObjectStoreAbortOperation):
(CreateObjectStoreAbortOperation):
(WebCore::DeleteObjectStoreAbortOperation::create):
(WebCore::DeleteObjectStoreAbortOperation::DeleteObjectStoreAbortOperation):
(DeleteObjectStoreAbortOperation):
(CreateIndexOperation):
(WebCore::CreateIndexOperation::create):
(WebCore::CreateIndexOperation::CreateIndexOperation):
(WebCore):
(DeleteIndexOperation):
(WebCore::DeleteIndexOperation::create):
(WebCore::DeleteIndexOperation::DeleteIndexOperation):
(CreateIndexAbortOperation):
(WebCore::CreateIndexAbortOperation::create):
(WebCore::CreateIndexAbortOperation::CreateIndexAbortOperation):
(DeleteIndexAbortOperation):
(WebCore::DeleteIndexAbortOperation::create):
(WebCore::DeleteIndexAbortOperation::DeleteIndexAbortOperation):
(WebCore::GetOperation::GetOperation):
(WebCore::IDBDatabaseBackendImpl::addObjectStore):
(WebCore::IDBDatabaseBackendImpl::removeObjectStore):
(WebCore::IDBDatabaseBackendImpl::addIndex):
(WebCore::IDBDatabaseBackendImpl::removeIndex):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::metadata):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::CreateObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::createIndex):
(WebCore::CreateIndexOperation::perform):
(WebCore::CreateIndexAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteIndex):
(WebCore::DeleteIndexOperation::perform):
(WebCore::DeleteIndexAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::get):
(WebCore::IDBDatabaseBackendImpl::put):
(WebCore::IDBDatabaseBackendImpl::setIndexKeys):
(WebCore::IDBDatabaseBackendImpl::count):
(WebCore::DeleteRangeOperation::perform):
(WebCore::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteDatabaseFinal):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores): Load directly into metadata from backing store.
(WebCore::CreateObjectStoreAbortOperation::perform):
(WebCore::DeleteObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::perform):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(WebCore):
(IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
* Modules/indexeddb/IDBIndexBackendImpl.cpp: Removed.
* Modules/indexeddb/IDBIndexBackendImpl.h: Removed.
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::IDBObjectStore): Frontend IDBIndex objects no longer hold onto backend.
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::deleteIndex):
* Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::create):
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(WebCore):
(IDBObjectStoreBackendImpl):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::objectStore):
* Modules/indexeddb/IDBTransaction.h:
* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
* Modules/indexeddb/IDBTransactionBackendImpl.h:
(WebCore::IDBTransactionBackendImpl::objectStore):
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Remove this test as it makes no sense once the objectstore/index
hierarchy is gone.

* tests/IDBDatabaseBackendTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNew chromium-mac pixel baseline for gradient-background-leakage-hidpi.html
noel.gordon@gmail.com [Thu, 10 Jan 2013 07:26:44 +0000 (07:26 +0000)]
New chromium-mac pixel baseline for gradient-background-leakage-hidpi.html
https://bugs.webkit.org/show_bug.cgi?id=106373

Unreviewed gardening.

* platform/chromium-mac/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2][EFL] Add guard around NativeWebTouchEvent
commit-queue@webkit.org [Thu, 10 Jan 2013 07:07:18 +0000 (07:07 +0000)]
[WK2][EFL] Add guard around NativeWebTouchEvent
https://bugs.webkit.org/show_bug.cgi?id=105846

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-01-09
Reviewed by Benjamin Poulain.

Fix EFL build without TOUCH_EVENTS.

* Shared/efl/NativeWebTouchEventEfl.cpp: Add TOUCH_EVENTS guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate expectations for fast/forms/button-generated-content.html
noel.gordon@gmail.com [Thu, 10 Jan 2013 07:05:48 +0000 (07:05 +0000)]
Update expectations for fast/forms/button-generated-content.html

Unreviewed gardening.

* fast/forms/button-generated-content-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/forms/button-generated-content-expected.txt.
* platform/chromium-win-xp/fast/forms/button-generated-content-expected.png: Added.
* platform/mac/fast/forms/button-generated-content-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Don't throw exceptions when we don't have a callstack
commit-queue@webkit.org [Thu, 10 Jan 2013 07:05:40 +0000 (07:05 +0000)]
Web Inspector: Don't throw exceptions when we don't have a callstack
https://bugs.webkit.org/show_bug.cgi?id=104849

Patch by John J. Barton <johnjbarton@chromium.org> on 2013-01-09
Reviewed by Pavel Feldman.

Check array details.callFrames.length before accessing array;

No new tests, but this fix may help us find the cause of 'other' reasons.

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerPaused):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate expectations for fast/forms/button-inner-block-reuse.html
noel.gordon@gmail.com [Thu, 10 Jan 2013 06:52:29 +0000 (06:52 +0000)]
Update expectations for fast/forms/button-inner-block-reuse.html

Unreviewed gardening.

* fast/forms/button-inner-block-reuse-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/button-inner-block-reuse-expected.txt.
* platform/chromium-win-xp/fast/forms/button-inner-block-reuse-expected.png: Added.
* platform/mac/fast/forms/button-inner-block-reuse-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [Network] Data grid header and content cells are misaligned.
commit-queue@webkit.org [Thu, 10 Jan 2013 06:28:45 +0000 (06:28 +0000)]
Web Inspector: [Network] Data grid header and content cells are misaligned.
https://bugs.webkit.org/show_bug.cgi?id=105795

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-09
Reviewed by Pavel Feldman.

Header and content tables have different width -> same percent values
turn to different cell widths.

* inspector/front-end/DataGrid.js: Add "corner" cell to all rows.
* inspector/front-end/dataGrid.css: Apply "corner" rules to "td" nodes.
(.data-grid .data-container): Remove artificial padding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake caret repainting container-aware
commit-queue@webkit.org [Thu, 10 Jan 2013 06:23:32 +0000 (06:23 +0000)]
Make caret repainting container-aware
https://bugs.webkit.org/show_bug.cgi?id=103955

Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-01-09
Reviewed by Simon Fraser.

Source/WebCore:

Only invalidate local rects on the caret's repaint container,
instead of invalidating an absolute rect on the whole view.

Test: fast/repaint/caret-with-transformation.html

* editing/FrameSelection.cpp:
(WebCore::caretRendersInsideNode):
(WebCore::caretRenderer):
(WebCore::FrameSelection::caretRenderer):
(WebCore::DragCaretController::caretRenderer):
(WebCore::repaintCaretForLocalRect):
(WebCore::FrameSelection::recomputeCaretRect):
(WebCore::CaretBase::invalidateCaretRect):
(WebCore::FrameSelection::focusedOrActiveStateChanged):
* editing/FrameSelection.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::repaintSelection):
* rendering/RenderView.h:

LayoutTests:

The caret repaint padding has been removed. Needs rebaseline.
Added test that carets should be repainted correctly on a transformed element.

* fast/repaint/caret-with-transformation.html: Added.
* platform/chromium/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Add win mac expectations for r139256
noel.gordon@gmail.com [Thu, 10 Jan 2013 05:57:35 +0000 (05:57 +0000)]
[Chromium] Add win mac expectations for r139256
https://bugs.webkit.org/show_bug.cgi?id=106404

Unreviewed gardening.

* platform/chromium-mac/fast/borders/border-radius-with-box-shadow-expected.png: Added.
* platform/chromium-win/fast/borders/border-radius-with-box-shadow-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRebaseline the binding test after r139278.
rniwa@webkit.org [Thu, 10 Jan 2013 05:53:40 +0000 (05:53 +0000)]
Rebaseline the binding test after r139278.

* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTarget::getOwnPropertySlot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139280 268f45cc-cd09-0410-ab3c-d52691b4dbfc