WebKit-https.git
13 years ago Reviewed by Darin.
thatcher [Wed, 10 Jan 2007 00:11:09 +0000 (00:11 +0000)]
    Reviewed by Darin.

        Rename the now ObjC++ files to be .mm and remove the explicit file types.

        * DOM/WebDOMOperations.m: Removed.
        * DefaultDelegates/WebDefaultContextMenuDelegate.m: Removed.
        * English.lproj/StringsNotToBeLocalized.txt:
        * Misc/WebCoreStatistics.m: Removed.
        * Misc/WebElementDictionary.m: Removed.
        * Misc/WebIconDatabase.m: Removed.
        * Misc/WebNSAttributedStringExtras.m: Removed.
        * Misc/WebNSPasteboardExtras.m: Removed.
        * Plugins/WebNetscapePluginEmbeddedView.m: Removed.
        * Plugins/WebNullPluginView.m: Removed.
        * Plugins/WebPluginContainerCheck.m: Removed.
        * WebCoreSupport/WebViewFactory.m: Removed.
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebArchiver.m: Removed.
        * WebView/WebHTMLRepresentation.m: Removed.
        * WebView/WebHTMLView.m: Removed.
        * WebView/WebRenderNode.m: Removed.
        * WebView/WebResource.m: Removed.
        * WebView/WebScriptDebugDelegate.m: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
darin [Wed, 10 Jan 2007 00:08:18 +0000 (00:08 +0000)]
JavaScriptCore:

        - update 2007 Apple copyright for the new company name

        * kjs/DateMath.cpp:

WebCore:

        - update all 2007 Apple copyrights for the new company name

        * css/cssstyleselector.cpp:
        * html/HTMLLIElement.cpp:
        * platform/CharacterNames.h:
        * platform/TextBreakIterator.h:
        * platform/TextBreakIteratorICU.cpp:
        * platform/graphics/ImageBuffer.h:
        * rendering/CounterNode.cpp:
        * rendering/CounterNode.h:
        * rendering/RenderBox.h:
        * rendering/RenderContainer.cpp:
        * rendering/RenderCounter.cpp:
        * rendering/RenderCounter.h:
        * rendering/RenderImage.h:
        * rendering/RenderListItem.h:
        * rendering/RenderListMarker.h:
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:
        * rendering/RenderTable.cpp:
        * rendering/RenderTableCell.cpp:
        * rendering/RenderTableCell.h:
        * rendering/RenderText.cpp:
        * rendering/RenderText.h:
        * rendering/RenderTreeAsText.cpp:
        * rendering/SVGRenderTreeAsText.cpp:
        * rendering/break_lines.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Tue, 9 Jan 2007 22:49:45 +0000 (22:49 +0000)]
LayoutTests:

        Reviewed by john

        * editing/inserting/4840662-expected.checksum: Added.
        * editing/inserting/4840662-expected.png: Added.
        * editing/inserting/4840662-expected.txt: Added.
        * editing/inserting/4840662.html: Added.
        * editing/pasteboard/4840662-expected.checksum: Added.
        * editing/pasteboard/4840662-expected.png: Added.
        * editing/pasteboard/4840662-expected.txt: Added.
        * editing/pasteboard/4840662.html: Added.

WebCore:

        Reviewed by john

        <rdar://problem/4840662>
        REGRESSION: Mail crash when dragging text into a link

        moveParagraphs fails to move content into a display:block
        anchor because of code in positionAvoidingSpecialElementBoundary,
        and so it infinitely recurs.

        * editing/htmlediting.cpp:
        (WebCore::positionAvoidingSpecialElementBoundary): Don't avoid anchors
        that have display:block so that content is inserted in the expected
        paragraph.  This fixes the bug and weird behavior when typing before/after
        anchors with display:block.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
rwlbuis [Tue, 9 Jan 2007 22:29:49 +0000 (22:29 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=12145
        Color parsing is too relaxed in strict mode
        http://bugs.webkit.org/show_bug.cgi?id=12166
        REGRESSION (r18480): "336633" is not parsed as a color

        Fix a regression by using String::format return value.
        Also make strict mode more strict for cases where hexcolors
        lack a #.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
darin [Tue, 9 Jan 2007 21:48:17 +0000 (21:48 +0000)]
    Reviewed by Maciej.

        - fixed regression where redirects did not have user-agent any more

        Showed up as a failure in one of the http tests, so no new test needed.

        * loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest):
        Don't use a copy of the ResourceRequest; pass the original so it can be modified.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - fix build
darin [Tue, 9 Jan 2007 21:19:29 +0000 (21:19 +0000)]
    - fix build

        * kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
        Actually compile it this time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - fix build
darin [Tue, 9 Jan 2007 21:13:39 +0000 (21:13 +0000)]
    - fix build

        * kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
        Change types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - fix build on platforms where Unicode::UChar is != uint16_t
darin [Tue, 9 Jan 2007 21:11:27 +0000 (21:11 +0000)]
    - fix build on platforms where Unicode::UChar is != uint16_t

        * kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
        Change types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-01-09 Mitz Pettel <mitz@webkit.org>
ap [Tue, 9 Jan 2007 17:38:46 +0000 (17:38 +0000)]
2007-01-09  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - changes for http://bugs.webkit.org/show_bug.cgi?id=11078
          Forms Don't Submit (ASP Pages)

JavaScriptCore:
        * JavaScriptCore.exp:
        * kjs/value.cpp:
        (KJS::JSValue::toInt32): Folded toInt32Inline into this method, which was its
        only caller.
        (KJS::JSValue::toUInt32): Added a variant that reports if the conversion has
        succeeded.
        * kjs/value.h:

WebCore:
        * bindings/js/kjs_html.cpp:
        (KJS::JSHTMLCollectionProtoFunc::callAsFunction): Changed item() to fall back
        to namedItem() if its argument does not convert to a number.

LayoutTests:
        * fast/dom/collection-namedItem-via-item-expected.txt: Added.
        * fast/dom/collection-namedItem-via-item.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
darin [Tue, 9 Jan 2007 14:54:26 +0000 (14:54 +0000)]
JavaScriptCore:

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12174
          improve Unicode use (less WTF::Unicode:: prefix, centralized character names)

        * wtf/unicode/icu/UnicodeIcu.h: Change parameter and return types
        to UChar32 and UChar. Removed unneeded type casts and added some
        const to functions that lacked it. Removed WTF::Unicode::memcmp.
        (WTF::Unicode::umemcasecmp): Renamed from strcasecmp since this
        doesn't work on 0-terminated strings as the str functions do.
        * wtf/unicode/qt4/UnicodeQt4.h: Ditto.

        - got rid of namespace prefixes from most uses of WTF::Unicode

        * kjs/function.cpp:
        (KJS::isStrWhiteSpace):
        (KJS::escapeStringForPrettyPrinting):
        * kjs/lexer.cpp:
        (KJS::Lexer::isWhiteSpace):
        (KJS::Lexer::isIdentStart):
        (KJS::Lexer::isIdentPart):
        * kjs/string_object.cpp:
        (KJS::StringProtoFunc::callAsFunction):

WebCore:

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12174
          improve Unicode use (less WTF::Unicode:: prefix, centralized character names)

        - got rid of namespace prefixes from most uses of WTF::Unicode

        - updated for removal of WTF::Unicode::memcmp
        - updated for renaming of WTF::Unicode::strcasecmp to umemcasecmp.

        - unified constants for special Unicode characters in a new
          CharacterNames.h header

        * WebCore.xcodeproj/project.pbxproj:
        * css/cssparser.cpp:
        (WebCore::ParseString::lower):
        * dom/Document.cpp:
        (WebCore::isValidNameStart):
        (WebCore::isValidNamePart):
        * dom/Position.cpp:
        (WebCore::Position::leadingWhitespacePosition):
        (WebCore::Position::trailingWhitespacePosition):
        * editing/CompositeEditCommand.cpp:
        (WebCore::isWhitespace):
        * editing/HTMLInterchange.cpp:
        * editing/TextIterator.cpp:
        (WebCore::CircularSearchBuffer::CircularSearchBuffer):
        (WebCore::CircularSearchBuffer::append):
        * editing/htmlediting.cpp:
        (WebCore::stringWithRebalancedWhitespace):
        (WebCore::nonBreakingSpaceString):
        * editing/htmlediting.h:
        * html/HTMLFontElement.cpp:
        (WebCore::parseFontSizeNumber):
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleError):
        * html/HTMLSelectElement.cpp:
        (WebCore::stripLeadingWhiteSpace):
        * platform/Font.cpp:
        (WebCore::WidthIterator::advance):
        (WebCore::WidthIterator::normalizeVoicingMarks):
        * platform/GlyphMap.cpp:
        (WebCore::GlyphMap::locatePage):
        * platform/MimeTypeRegistry.h:
        * platform/StringHash.h:
        * platform/StringImpl.cpp:
        (WebCore::isSpace):
        (WebCore::StringImpl::append):
        (WebCore::StringImpl::insert):
        (WebCore::StringImpl::truncate):
        (WebCore::StringImpl::remove):
        (WebCore::parseLength):
        (WebCore::StringImpl::isLower):
        (WebCore::StringImpl::lower):
        (WebCore::StringImpl::upper):
        (WebCore::StringImpl::secure):
        (WebCore::StringImpl::foldCase):
        (WebCore::StringImpl::capitalize):t
        (WebCore::StringImpl::toInt):
        (WebCore::equalIgnoringCase):
        (WebCore::StringImpl::find):
        * platform/TextBoundaries.h:
        * platform/TextCodec.h:
        * platform/TextCodecLatin1.cpp:
        * platform/TextEncoding.h:
        * platform/TextEncodingRegistry.h:
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeSelection):
        * platform/mac/TextCodecMac.cpp:
        (WebCore::TextCodecMac::decode):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateFirstLetter):
        * rendering/RenderListMarker.cpp:
        (WebCore::listMarkerText):
        (WebCore::RenderListMarker::paint):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::widthFromCache):
        (WebCore::isSpaceAccordingToStyle):
        (WebCore::RenderText::setInternalString):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::quoteAndEscapeNonPrintables):
        (WebCore::operator<<):
        * rendering/bidi.cpp:
        (WebCore::BidiState::BidiState):
        (WebCore::BidiContext::BidiContext):
        (WebCore::bidiNext):
        (WebCore::bidiFirst):
        (WebCore::BidiIterator::direction):
        (WebCore::appendRun):
        (WebCore::embed):
        (WebCore::RenderBlock::bidiReorderLine):
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::skipNonBreakingSpace):
        (WebCore::RenderBlock::findNextLineBreak):
        * rendering/break_lines.cpp:
        (WebCore::nextBreakablePosition):
        * rendering/break_lines.h:
        * xml/XPathParser.cpp:
        (WebCore::XPath::charCat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAnother change log tweak.
darin [Tue, 9 Jan 2007 14:43:40 +0000 (14:43 +0000)]
Another change log tweak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd the bug number.
darin [Tue, 9 Jan 2007 14:42:16 +0000 (14:42 +0000)]
Add the bug number.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
darin [Tue, 9 Jan 2007 14:36:16 +0000 (14:36 +0000)]
    Reviewed by Darin.

        * rendering/RenderText.h:
        (WebCore::RenderText::selectionState):
        Change the m_selectionState enum-bitfield to an unsigned-bitfield,
        because enums on Windows are signed, which caused it to become
        negative (whereas the valid values are all positive).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt.
darin [Tue, 9 Jan 2007 14:28:47 +0000 (14:28 +0000)]
    Reviewed by Hyatt.

        - http://bugs.webkit.org/show_bug.cgi?id=12175
          port break_lines.cpp to be platform independent

        * platform/TextBreakIterator.h: Added lineBreakIterator.
        Removed ICU-specific stuff from the header.

        * platform/TextBreakIteratorICU.cpp:
        (WebCore::setUpIterator): Added helper to be shared by the three different
        creation functions.
        (WebCore::characterBreakIterator): Changed to use setUpIterator.
        (WebCore::wordBreakIterator): Ditto.
        (WebCore::lineBreakIterator): Added.

        * platform/qt/TextBreakIteratorQt.cpp:
        (WebCore::lineBreakIterator): Added a stub.

        * rendering/break_lines.cpp:
        (WebCore::isBreakableSpace): Added.
        (WebCore::shouldBreakAfter): Added.
        (WebCore::needsAdvancedBreakAnalysis): Added.
        (WebCore::nextBreakablePosition): Changed to use TextBreakIterator on platforms
        other than Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
darin [Tue, 9 Jan 2007 14:19:01 +0000 (14:19 +0000)]
    Reviewed by Mitz.

        - added a Thai line breaking test

        * fast/text/international/thai-line-breaks-expected.checksum: Added.
        * fast/text/international/thai-line-breaks-expected.png: Added.
        * fast/text/international/thai-line-breaks-expected.txt: Added.
        * fast/text/international/thai-line-breaks.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
mjs [Tue, 9 Jan 2007 14:15:23 +0000 (14:15 +0000)]
    Reviewed by Darin.

        - move WebDataProtocol load handling from ResourceLoader to MainResourceLoader

        (it's only ever used for main resources)

        * loader/ResourceLoader.h:
        (WebCore::ResourceLoader::setRequest):
        * loader/mac/MainResourceLoaderMac.mm:
        (WebCore::MainResourceLoader::willSendRequest):
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        * loader/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::willSendRequest):
        (WebCore::ResourceLoader::didReceiveResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
rwlbuis [Tue, 9 Jan 2007 13:56:31 +0000 (13:56 +0000)]
    Reviewed by Eric.

        http://bugs.webkit.org/show_bug.cgi?id=12129
        repaint issue after setting viewBox attribute with ECMAScript

        Make sure RenderSVGContainer updates after setting viewBox from js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
mjs [Tue, 9 Jan 2007 13:50:25 +0000 (13:50 +0000)]
    Reviewed by Darin.

        - remove window display throttling code; no longer used

        * Misc/WebNSWindowExtras.h:
        * Misc/WebNSWindowExtras.m:
        * WebView/WebFrameView.mm:
        (-[WebFrameView initWithFrame:]):
        * WebView/WebPreferenceKeysPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMake the Qt build compile... again!
lars [Tue, 9 Jan 2007 08:20:00 +0000 (08:20 +0000)]
Make the Qt build compile... again!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for background: inherit bug where background-color wasn't getting properl...
hyatt [Tue, 9 Jan 2007 08:15:42 +0000 (08:15 +0000)]
    Fix for background: inherit bug where background-color wasn't getting properly overridden.  This was a
        regression from Safari 1.3 to 2.0.

        Reviewed by bdash

        fast/backgrounds/background-color-inherit-bug.html

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd new layout test for background inherit color bug.
hyatt [Tue, 9 Jan 2007 08:14:23 +0000 (08:14 +0000)]
Add new layout test for background inherit color bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brian Dash
beidson [Tue, 9 Jan 2007 07:55:42 +0000 (07:55 +0000)]
    Reviewed by Brian Dash

        <rdar://problem/4895178>
        WebCore::BackForwardList vector should be backed by a HashSet to remove
        the potential expense in frequently calling BackForwardList::containsItem()

        * history/BackForwardList.cpp:
        (WebCore::BackForwardList::addItem): Maintain HashSet as well as Vector
        (WebCore::BackForwardList::setCapacity): Ditto
        (WebCore::BackForwardList::close): Ditto
        (WebCore::BackForwardList::removeItem): Ditto
        (WebCore::BackForwardList::containsItem): Make a hash lookup instead of iterate
        through the Vector
        * history/BackForwardList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix a regression where layout is triggering on all recalcStyles, due to a...
hyatt [Tue, 9 Jan 2007 05:53:41 +0000 (05:53 +0000)]
    Fix a regression where layout is triggering on all recalcStyles, due to a bad comparison
        in the multicol assignment operator.

        * rendering/RenderStyle.cpp:
        (WebCore::StyleMultiColData::operator==):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAnd forgot change log.
darin [Tue, 9 Jan 2007 05:25:55 +0000 (05:25 +0000)]
And forgot change log.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoOops, forgot one file.
darin [Tue, 9 Jan 2007 05:25:33 +0000 (05:25 +0000)]
Oops, forgot one file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - rolled out Beth's RenderFlow::destroy change, which broke 5 editing tests
darin [Tue, 9 Jan 2007 05:18:01 +0000 (05:18 +0000)]
    - rolled out Beth's RenderFlow::destroy change, which broke 5 editing tests

        * rendering/RenderFlow.cpp: (WebCore::RenderFlow::destroy):
        Used svn merge to roll the change out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-01-09 Mark Rowe <mrowe@apple.com>
bdash [Tue, 9 Jan 2007 03:52:30 +0000 (03:52 +0000)]
2007-01-09  Mark Rowe  <mrowe@apple.com>

        Reviewed by Tim H.

        Build fix for 64-bit platforms.

        * platform/graphics/svg/SVGPaintServerGradient.h:
        * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
        (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
andersca [Tue, 9 Jan 2007 02:54:37 +0000 (02:54 +0000)]
WebCore:

        Reviewed by Brady.

        Move some history related functions off the bridge and into FrameLoader directly.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::canGoBackOrForward):
        (WebCore::FrameLoader::getHistoryLength):
        (WebCore::FrameLoader::historyURL):
        * loader/mac/FrameLoaderMac.mm:
        * page/mac/WebCoreFrameBridge.h:

WebKit:

        Reviewed by Brady.

        Remove bridge functions that are implemented directly in FrameLoader now.

        * WebCoreSupport/WebFrameBridge.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Tue, 9 Jan 2007 02:48:28 +0000 (02:48 +0000)]
LayoutTests:

        Reviewed by Mark.

        Update results to include outline-color.

        * fast/css/computed-style-expected.txt:
        * fast/css/computed-style.html:

WebCore:

        Reviewed by Mark.

        Adds outline-color to list of computable styles.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):

WebKit:

        Reviewed by Mark.

        Adds default value for outline-color and fixes default
        values of the recently fixed *-color properties.

        * WebInspector/webInspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt.
bdakin [Tue, 9 Jan 2007 01:03:00 +0000 (01:03 +0000)]
    Reviewed by Hyatt.

        Fix for a bug that Adam, Hyatt, and I noticed when debugging
        another problem.

        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::root): Added assertion. If we are casting to a
        root, we should make sure we are root.
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::destroy): It is not enough to remove the
        child boxes for anonymous blocks. We need to be more thorough when
        cleaning these up. Adam's test case illustrates the problem well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand updated computed style results.
hyatt [Tue, 9 Jan 2007 00:54:42 +0000 (00:54 +0000)]
Land updated computed style results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand updated stroke results.
hyatt [Tue, 9 Jan 2007 00:51:55 +0000 (00:51 +0000)]
Land updated stroke results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoOnly dump stroke/fill if it's different from color
hyatt [Tue, 9 Jan 2007 00:12:13 +0000 (00:12 +0000)]
Only dump stroke/fill if it's different from color

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix typo.
ddkilzer [Mon, 8 Jan 2007 23:28:10 +0000 (23:28 +0000)]
Fix typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fixed text of previous comment.
sullivan [Mon, 8 Jan 2007 23:14:04 +0000 (23:14 +0000)]
    Fixed text of previous comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Tweak to previous checkin
sullivan [Mon, 8 Jan 2007 23:11:48 +0000 (23:11 +0000)]
    Tweak to previous checkin

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
        Adam suggested I should nil-check page->frame()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady and Beth
sullivan [Mon, 8 Jan 2007 23:05:56 +0000 (23:05 +0000)]
    Reviewed by Brady and Beth

        - fixed <rdar://problem/4912541> GMAIL: With selected text in a rich text message, choosing
        "Search in Google" displays search results in the message body field

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
        Visit google URL in main frame rather than in current frame

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix computed style errors for color properties that had invalid colors.
hyatt [Mon, 8 Jan 2007 23:01:46 +0000 (23:01 +0000)]
    Fix computed style errors for color properties that had invalid colors.
        They should return the value of the 'color' property when their colors
        are not valid.

        Fixed the computed style value for border-top-color (a typo was causing it to
        use border-left-color instead).

        Implement outline-color computed style.

        Reviewed by harrison

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::currentColorOrValidColor):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Mon, 8 Jan 2007 22:51:24 +0000 (22:51 +0000)]
LayoutTests:

        Reviewed by Darin and Eric.

        Fixes: http://bugs.webkit.org/show_bug.cgi?id=12150
        Corrected results for W3C's pservers-grad-16-b.
        Add a test for stop calues corner cases.

        * svg/W3C-SVG-1.1/pservers-grad-16-b-expected.checksum:
        * svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
        * svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt:
        * svg/custom/gradient-stop-corner-cases-expected.checksum: Added.
        * svg/custom/gradient-stop-corner-cases-expected.png: Added.
        * svg/custom/gradient-stop-corner-cases-expected.txt: Added.
        * svg/custom/gradient-stop-corner-cases.svg: Added.

WebCore:

        Reviewed by Darin and Eric.

        Fixes: http://bugs.webkit.org/show_bug.cgi?id=12150
        Handle correctly cases where no stops are defined, cases where a
        stop offset value is less than previous stops offset value, and cases
        where a stop offset value is greater than 1.0.

        * platform/graphics/svg/SVGPaintServerGradient.cpp:
        (WebCore::SVGPaintServerGradient::setGradientStops): Don't sort stops
        * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
        (WebCore::cgGradientCallback): When there are no stops, use a transparent
        fill
        (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
        a stop offset must always be considered at greater or equal to all
        preceding stop offsets, but no more than 1.0

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
thatcher [Mon, 8 Jan 2007 22:15:00 +0000 (22:15 +0000)]
    Reviewed by Geoff.

        <rdar://problem/4865325> please re-add auto font activation support in WebKit

        * platform/mac/WebFontCache.mm:
        (+[WebFontCache fontWithFamily:traits:size:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - turn off the Armenian part of this test for now,
darin [Mon, 8 Jan 2007 21:36:22 +0000 (21:36 +0000)]
    - turn off the Armenian part of this test for now,
          since it gives different results with different fonts

        * fast/lists/w3-list-styles-expected.checksum:
        * fast/lists/w3-list-styles-expected.png:
        * fast/lists/w3-list-styles-expected.txt:
        * fast/lists/w3-list-styles.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
bdakin [Mon, 8 Jan 2007 21:32:01 +0000 (21:32 +0000)]
    Reviewed by Adam.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=12161 REGRESSION:
        Crash when control-clicking on an image for contextual menu

        * WebView/WebHTMLView.m:
        (-[WebHTMLView menuForEvent:]): We need to nil-check coreMenu since
        it will be nil if the DOM popped up a menu instead. I cleaned up
        the function to make all the nil checks early returns instead of
        nesting all of the content. Also moved the autorelease to be with
        the creation of the menu instead of at the return.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
weinig [Mon, 8 Jan 2007 20:55:21 +0000 (20:55 +0000)]
    Reviewed by Adam.

        - http://bugs.webkit.org/show_bug.cgi?id=12143
          remove Widget code unneeded now that form elements do not use Widget

        * bindings/objc/DOMHTML.mm: (-[DOMHTMLSelectElement _activateItemAtIndex:]):
        Removed useless implementation that would only work with NSView-based
        <select> elements, and added a FIXME about the fact that this function
        doesn't do anything any more. I think it's used by Safari forms auto-fill.

        * bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject rendererForView:]):
        Removed code that depends on elementForView:, since that always returns
        nil now.

        * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::~HTMLFormElement):
        Use a formDestroyed() function rather than clearing m_form directly so that
        this class doesn't have to be a friend of HTMLGenericFormElement.

        * html/HTMLGenericFormElement.h: Removed now-unneeded friend declaration
        for HTMLFormElement. Moved definition of supportsFocus into the .cpp file.
        Added a public formDestroyed function for use by HTMLFormElement.
        * html/HTMLGenericFormElement.cpp:
        (WebCore::HTMLGenericFormElement::attach): Removed widget-specific code.
        (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
        (WebCore::HTMLGenericFormElement::isMouseFocusable): Ditto.
        (WebCore::HTMLGenericFormElement::supportsFocus): Added this here; it was
        in the header file before, for no good reason.

        * page/EventHandler.h: Removed unused Mac-specific
        currentEventIsMouseDownInWidget.
        * page/mac/EventHandlerMac.mm: Ditto.

        * page/Frame.cpp: (WebCore::Frame::frameForWidget): Changed to use
        RenderWidget to find the frame rather than the WigetClient element()
        function.

        * page/mac/FrameMac.h: Removed unused bridgeForWidget.
        * page/mac/FrameMac.mm: Ditto.

        * page/mac/WebCoreFrameBridge.h: Removed elementForView.
        * page/mac/WebCoreFrameBridge.mm: Ditto. While the scroll bar still did
        implement WebCoreWidgetHolder, it does not correspond to a DOM element,
        so this method was always returning nil.

        * platform/Widget.h: Moved unused types and functions that are still
        in the platform-specific implementations into a "to be deleted" section:
        FocusPolicy, NoFocus, TabFocus, ClickFocus, StrongFocus, WheelFocus,
        lockDrawingFocus, font, focusPolicy, hasFocus, clearFocus, setFont,
        disableFlushDrawing, enableFlushDrawing, unlockDrawingFocus.
        Removed unused functions that are not in platform-specific implementations:
        sizeHint, baselinePosition, checksDescendantsForFocus.
        * platform/Widget.cpp: Removed functions.

        * platform/WidgetClient.h: Emptied out the class. Soon we can delete it.

        * platform/mac/PlatformScrollBarMac.mm: (-[WebCoreScrollBar mouseDown:]):
        Got rid of unneeded includes, removed use of the WebCoreWidgetHolder
        protocol and the one method in it, and changed the calls to beforeMouseDown
        and afterMouseDown to pass the widget pointer in.

        * platform/mac/WebCoreWidgetHolder.h: Emptied out the file -- to be deleted
        later.

        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::~Widget): Removed code to manage deferredFirstResponder.
        (WebCore::Widget::hasFocus): Removed body of function and replaced with
        an assertion that it's never called. Later we'll remove it.
        (WebCore::Widget::setFocus): Tweaked a bit to work given changes to the
        FrameMac class. Also added a FIXME. Given how this works, it does not
        belong in the platform layer.
        (WebCore::Widget::clearFocus): Removed body of function and replaced with
        an assertion that it's never called. Later we'll remove it.
        (WebCore::Widget::focusPolicy): Ditto.
        (WebCore::Widget::font): Ditto.
        (WebCore::Widget::setFont): Ditto.
        (WebCore::Widget::lockDrawingFocus): Ditto.
        (WebCore::Widget::unlockDrawingFocus): Ditto.
        (WebCore::Widget::disableFlushDrawing): Ditto.
        (WebCore::Widget::enableFlushDrawing): Ditto.
        (WebCore::Widget::paint): Removed obsolete comment.
        (WebCore::Widget::sendConsumedMouseUp): Removed body of function and replaced with
        an assertion that it's never called. Later we'll remove it.
        (WebCore::Widget::setIsSelected): Tweaked a bit to work given changes to the
        FrameMac class. Also added a FIXME. Given how this works, it does not
        belong in the platform layer.
        (WebCore::Widget::beforeMouseDown): Changed to take an explicit Widget parameter.
        (WebCore::Widget::afterMouseDown): Ditto.

        * rendering/RenderApplet.cpp:
        (WebCore::RenderApplet::intrinsicWidth): Changed to not call sizeHint() any more.
        I didn't change the values returned by the function, but they make no sense and
        this should probably be fixed later.
        (WebCore::RenderApplet::intrinsicHeight): Ditto.

        * rendering/RenderWidget.h: Removed unneeded WidgetClient.h include. Changed
        RenderWidget to no longer inherit from WidgetClient. Added a find function to find
        a RenderWidget given a Widget. Removed all the virtual functions that override
        WidgetClient hooks.
        * rendering/RenderWidget.cpp: Removed all the WidgetClient functions.
        (WebCore::widgetRendererMap): Added. Map that gives the RenderWidget for each
        Widget that is owned by a RenderWidget.
        (WebCore::RenderWidget::destroy): Removed the setClient call and added a call to
        remove the widget from the widgetRendererMap.
        (WebCore::RenderWidget::setWidget): Ditto.
        (WebCore::RenderWidget::setStyle): Removed the call to Widget::setFont.
        (WebCore::RenderWidget::find): Added. Returns the RenderWidget for a Widget, if any.

        - other changes

        * dom/Node.cpp:
        (WebCore::Node::dump): Removed unnecessary use of DeprecatedString.
        (WebCore::appendAttributeDesc): Ditto.
        (WebCore::Node::showNode): Ditto.
        (WebCore::Node::formatForDebugger): Ditto.

        * loader/CachedImage.cpp: (WebCore::CachedImage::createImage): Cleaned up
        conditional compilation so adding more MIME types here doesn't make the
        function more and more difficult to read.

        * page/Frame.h: Removed unneeded includes and declarations.
        Tweaked formatting.
        * page/Page.h: Removed unneeded declarations.
        * platform/ScrollView.h: Removed unneeded includes.

        * rendering/RenderBlock.cpp: (WebCore::RenderBlock::renderName): Tweaked formatting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
weinig [Mon, 8 Jan 2007 19:55:56 +0000 (19:55 +0000)]
    Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12162
          The inheritableProperties array is duplicated

        No test possible (no change to functionality).

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::removeComputedInheritablePropertiesFrom): Added.
        Removes the inheritable properties that CSSComputedStyleDeclaration knows how to compute
        from the given mutable declaration.
        * css/CSSComputedStyleDeclaration.h:
        * css/CSSMutableStyleDeclaration.cpp: Removed one copy of the inheritableProperties array.
        * css/CSSMutableStyleDeclaration.h:
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Changed to call
        CSSComputedStyleDeclaration::removeComputedInheritablePropertiesFrom.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap [Mon, 8 Jan 2007 19:48:59 +0000 (19:48 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=12099
        XMLHttpRequest shouldn't honor a charset specified via setRequestHeader

        Test: http/tests/xmlhttprequest/request-encoding.html

        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::send): Don't try to get the charset from Content-Type. Keep checking
        for unknown charsets, because that will be needed again when we start using document.xmlEncoding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap [Mon, 8 Jan 2007 19:42:33 +0000 (19:42 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=7640
        Menu items are displayed as "undefined"

WebCore:
        * bindings/js/kjs_dom.cpp:
        (KJS::DOMNodeProtoFunc::callAsFunction):
        * bindings/js/kjs_domnode.h:
        (KJS::DOMNode::):
        Removed Node::item. No idea why it was there in the first place.

        * bindings/js/kjs_html.cpp:
        (KJS::HTMLElementFunction::callAsFunction):
        * bindings/js/kjs_html.h:
        (KJS::JSHTMLElement::):
        Added HTMLSelectElement::item. It is not in DOM2 IDL, but the spec seems to mentions it anyway:
        "The contained options can be directly accessed through the select element as a collection."

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::namedItem):
        (WebCore::HTMLSelectElement::item):
        * html/HTMLSelectElement.h:
        * html/HTMLSelectElement.idl:
        Added this method to DOM and IDL, too. Made namedItem() non-virtual.

LayoutTests:
        * fast/dom/Window/window-properties-expected.txt: Updated the results.

        * fast/dom/node-item-expected.txt: Added.
        * fast/dom/node-item.html: Added.
        Check that there is no Node:item or HTMLElement:item.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
bdakin [Mon, 8 Jan 2007 19:31:42 +0000 (19:31 +0000)]
    Reviewed by Maciej.

        Fix for <rdar://problem/4912254> REGRESSION: After copying text to
        the clipboard, the paste contextual remains dimmed when it should
        be active

        No layout test for context menu problems.

        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::checkOrEnableIfNeeded): Remove check to see
        if the content is richly editable; it only has to be regular
        editable and the call to canPaste() takes care of that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
weinig [Mon, 8 Jan 2007 19:17:52 +0000 (19:17 +0000)]
    Reviewed by Mitz.

        Attempt to fix build for buildbots.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::columnGap):
        (WebCore::RenderBlock::calcColumnWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
darin [Mon, 8 Jan 2007 19:15:43 +0000 (19:15 +0000)]
LayoutTests:

        - added a W3C list style test that was cited in a bug

        * fast/lists/w3-list-styles-expected.checksum: Added.
        * fast/lists/w3-list-styles-expected.png: Added.
        * fast/lists/w3-list-styles-expected.txt: Added.
        * fast/lists/w3-list-styles.html: Added.

WebCore:

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=3232
          CSS2: Web Kit does not support all list style types

        Test case showed problems in cjk-ideographic and hebrew
        Test: fast/lists/w3-list-styles.html

        * rendering/RenderListMarker.cpp:
        (WebCore::toCJKIdeographic): Fix the algorithm so it doesn't include leading zeroes.
        I had misread the part that says you start with the decimal form of the number.
        Fix an assertion that was too stringent. Fix the code to collapse consecutive zeroes
        so that it doesn't get confused by intervening "noChar" characters.
        (WebCore::RenderListMarker::paint): Reverse the text before painting if the first character's
        direction is right to left.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
darin [Mon, 8 Jan 2007 18:59:56 +0000 (18:59 +0000)]
LayoutTests:

        Reviewed by Beth.

        - http://bugs.webkit.org/show_bug.cgi?id=12142
          render tree dump for test results should include the value of list markers

        * css1/basic/class_as_selector-expected.txt:
        * css1/basic/containment-expected.txt:
        * css1/basic/contextual_selectors-expected.txt:
        * css1/basic/id_as_selector-expected.txt:
        * css1/box_properties/border_bottom-expected.txt:
        * css1/box_properties/border_left-expected.txt:
        * css1/box_properties/border_right_inline-expected.txt:
        * css1/box_properties/border_top-expected.txt:
        * css1/box_properties/clear_float-expected.txt:
        * css1/box_properties/margin-expected.txt:
        * css1/box_properties/margin_bottom-expected.txt:
        * css1/box_properties/margin_left-expected.txt:
        * css1/box_properties/margin_right-expected.txt:
        * css1/box_properties/margin_top-expected.txt:
        * css1/box_properties/padding_left-expected.txt:
        * css1/box_properties/padding_right-expected.txt:
        * css1/cascade/cascade_order-expected.txt:
        * css1/classification/display-expected.txt:
        * css1/classification/list_style-expected.txt:
        * css1/classification/list_style_image-expected.txt:
        * css1/classification/list_style_position-expected.txt:
        * css1/classification/list_style_type-expected.txt:
        * css1/conformance/forward_compatible_parsing-expected.txt:
        * css1/pseudo/anchor-expected.txt:
        * css2.1/t0402-c71-fwd-parsing-02-f-expected.txt:
        * css2.1/t0505-c16-descendant-01-e-expected.txt:
        * css2.1/t050803-c14-classes-00-e-expected.txt:
        * css2.1/t0509-c15-ids-01-e-expected.txt:
        * css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
        * css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
        * css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
        * css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
        * css2.1/t1205-c561-list-displ-00-b-expected.txt:
        * css2.1/t1205-c563-list-type-00-b-expected.txt:
        * css2.1/t1205-c563-list-type-01-b-expected.txt:
        * css2.1/t1205-c564-list-img-00-b-g-expected.txt:
        * css2.1/t1205-c565-list-pos-00-b-expected.txt:
        * css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
        * editing/deleting/4866671-expected.txt:
        * editing/deleting/delete-first-list-item-expected.txt:
        * editing/deleting/delete-link-1-expected.txt:
        * editing/deleting/delete-listitem-002-expected.txt:
        * editing/deleting/list-item-1-expected.txt:
        * editing/deleting/merge-into-empty-block-2-expected.txt:
        * editing/execCommand/4641880-1-expected.txt:
        * editing/execCommand/create-list-from-range-selection-expected.txt:
        * editing/execCommand/create-list-with-hr-expected.txt:
        * editing/execCommand/indent-list-item-expected.txt:
        * editing/execCommand/indent-selection-expected.txt:
        * editing/execCommand/insert-list-and-stitch-expected.txt:
        * editing/execCommand/remove-list-from-range-selection-expected.txt:
        * editing/execCommand/remove-list-item-1-expected.txt:
        * editing/execCommand/remove-list-items-expected.txt:
        * editing/execCommand/switch-list-type-expected.txt:
        * editing/inserting/insert-div-022-expected.txt:
        * editing/inserting/insert-div-023-expected.txt:
        * editing/inserting/insert-div-024-expected.txt:
        * editing/pasteboard/4861080-expected.txt:
        * editing/pasteboard/drop-link-expected.txt:
        * editing/pasteboard/innerText-inline-table-expected.txt:
        * editing/pasteboard/input-field-1-expected.txt:
        * editing/pasteboard/merge-end-list-expected.txt:
        * editing/pasteboard/merge-start-list-expected.txt:
        * editing/pasteboard/paste-4039777-fix-expected.txt:
        * editing/pasteboard/paste-list-001-expected.txt:
        * editing/pasteboard/select-element-1-expected.txt:
        * editing/selection/drag-to-contenteditable-iframe-expected.txt:
        * editing/selection/extend-by-word-002-expected.txt:
        * editing/selection/move-by-line-002-expected.txt:
        * editing/selection/select-all-iframe-expected.txt:
        * editing/selection/selectNode-expected.txt:
        * editing/selection/selectNodeContents-expected.txt:
        * editing/unsupported-content/list-delete-001-expected.txt:
        * editing/unsupported-content/list-type-after-expected.txt:
        * editing/unsupported-content/list-type-before-expected.txt:
        * fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt:
        * fast/block/float/014-expected.txt:
        * fast/css-generated-content/009-expected.txt:
        * fast/css/001-expected.txt:
        * fast/css/continuationCrash-expected.txt:
        * fast/css/css2-system-fonts-expected.txt:
        * fast/css/css3-modsel-22-expected.txt:
        * fast/css/list-outline-expected.txt:
        * fast/doctypes/001-expected.txt:
        * fast/doctypes/002-expected.txt:
        * fast/doctypes/003-expected.txt:
        * fast/doctypes/004-expected.txt:
        * fast/dom/Window/window-onFocus-expected.txt:
        * fast/forms/form-hides-table-expected.txt:
        * fast/forms/plaintext-mode-2-expected.txt:
        * fast/lists/001-expected.txt:
        * fast/lists/002-expected.txt:
        * fast/lists/003-expected.txt:
        * fast/lists/004-expected.txt:
        * fast/lists/005-expected.txt:
        * fast/lists/006-expected.txt:
        * fast/lists/007-expected.txt:
        * fast/lists/008-expected.txt:
        * fast/lists/alpha-list-wrap-expected.txt:
        * fast/lists/decimal-leading-zero-expected.txt:
        * fast/lists/drag-into-marker-expected.txt:
        * fast/lists/dynamic-marker-crash-expected.txt:
        * fast/lists/inlineBoxWrapperNullCheck-expected.txt:
        * fast/lists/li-br-expected.txt:
        * fast/lists/li-style-alpha-huge-value-crash-expected.txt:
        * fast/lists/li-values-expected.txt:
        * fast/lists/markers-in-selection-expected.txt:
        * fast/lists/numeric-markers-outside-list-expected.txt:
        * fast/lists/ol-display-types-expected.txt:
        * fast/lists/olstart-expected.txt:
        * fast/lists/ordered-list-with-no-ol-tag-expected.txt:
        * fast/lists/scrolled-marker-paint-expected.txt:
        * fast/overflow/overflow-rtl-expected.txt:
        * fast/selectors/001-expected.txt:
        * fast/selectors/013-expected.txt:
        * fast/selectors/015-expected.txt:
        * fast/selectors/166-expected.txt:
        * fast/table/018-expected.txt:
        * fast/table/form-with-table-style-expected.txt:
        * fast/text/whitespace/tab-character-basics-expected.txt:
        * fast/tokenizer/004-expected.txt:
        * tables/mozilla/bugs/bug23235-expected.txt:
        * tables/mozilla/bugs/bug30692-expected.txt:
        * tables/mozilla/bugs/bug3191-expected.txt:
        * tables/mozilla/bugs/bug32205-2-expected.txt:
        * tables/mozilla/marvin/backgr_index-expected.txt:
        * tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
        * tables/mozilla/marvin/x_table-expected.txt:
        * tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
        * tables/mozilla/other/wa_table_tr_align-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
        * tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
        * tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
        * traversal/stay-within-root-expected.txt:

WebCore:

        Reviewed by Beth.

        - http://bugs.webkit.org/show_bug.cgi?id=12142
          render tree dump for test results should include the value of list markers

        * rendering/RenderTreeAsText.cpp:
        (WebCore::getTagName): Changed to use String instead of DeprecatedString.
        (WebCore::quoteAndEscapeNonPrintables): Ditto. Also moved up so it can be used
        in the operator below.
        (WebCore::operator<<): Added clause for RenderListMarker that dumps the value
        of the list marker's text.
        (WebCore::nodePosition): Changed to use String instead of DeprecatedString.
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::TextStreamSeparator::TextStreamSeparator): Changed to use String
        instead of DeprecatedString.
        (WebCore::getTagName): Ditto.
        (WebCore::write): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by ap and the rubber stamp of Maciej.
weinig [Mon, 8 Jan 2007 17:50:01 +0000 (17:50 +0000)]
    Reviewed by ap and the rubber stamp of Maciej.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=12164
        Cleanup Tokenizers

        - Moves Tokenizer class into its own file.
        - Move XMLTokenizer declaration from XMLTokenizer.cpp to XMLTokenizer.h
        - Fixup #includes.

        * WebCore.xcodeproj/project.pbxproj:
        * dom/Document.cpp:
        (WebCore::Document::createTokenizer):
        * dom/Tokenizer.h: Added.
        (WebCore::Tokenizer::Tokenizer):
        (WebCore::Tokenizer::~Tokenizer):
        (WebCore::Tokenizer::stopParsing):
        (WebCore::Tokenizer::processingData):
        (WebCore::Tokenizer::executingScript):
        (WebCore::Tokenizer::wantsRawData):
        (WebCore::Tokenizer::writeRawData):
        (WebCore::Tokenizer::inViewSourceMode):
        (WebCore::Tokenizer::setInViewSourceMode):
        (WebCore::Tokenizer::wellFormed):
        (WebCore::Tokenizer::lineNumber):
        (WebCore::Tokenizer::columnNumber):
        * dom/XMLTokenizer.cpp:
        * dom/XMLTokenizer.h:
        (WebCore::XMLTokenizer::):
        (WebCore::XMLTokenizer::setIsXHTMLDocument):
        (WebCore::XMLTokenizer::isXHTMLDocument):
        (WebCore::XMLTokenizer::wellFormed):
        * html/HTMLElement.cpp:
        * html/HTMLTokenizer.h:
        (WebCore::Token::reset):
        (WebCore::HTMLTokenizer::checkBuffer):
        (WebCore::HTMLTokenizer::checkScriptBuffer):
        (WebCore::HTMLTokenizer::State::State):
        (WebCore::HTMLTokenizer::State::setBit):
        * xml/XSLTProcessor.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Mon, 8 Jan 2007 15:42:33 +0000 (15:42 +0000)]
LayoutTests:

        Reviewed by Tim H.

        Update results to include -webkit-box-shadow.

        * fast/css/computed-style-expected.txt:

WebCore:

        Reviewed by Tim H.

        Adds -webkit-box-shadow to list of computable styles.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):

WebKit:

        Reviewed by Tim H.

        Adds default value for -webkit-box-shadow and fixes default
        value of -webkit-column-count to be "auto".  Also sorts the
        list of defaults.

        * WebInspector/webInspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by bdash.
rwlbuis [Mon, 8 Jan 2007 13:43:10 +0000 (13:43 +0000)]
    Reviewed by bdash.

        Initialize the member vars, fixes testcases
        pointer-events-path.svg and pointer-events-text.svg
        on the PPC build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-01-08 Andrew Wellington <proton@wiretapped.net>
bdash [Mon, 8 Jan 2007 12:36:08 +0000 (12:36 +0000)]
2007-01-08  Andrew Wellington  <proton@wiretapped.net>

        Reviewed by Mark.

        * WebInspector/webInspector/inspector.js: Hide default values of
        -webkit-column styles in WebInspector.
2007-01-08  Andrew Wellington  <proton@wiretapped.net>

        Reviewed by Mark.

        * fast/css/computed-style-expected.txt: Update results to include
        -webkit-column styles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago This patch computes the correct column width and column count. It ensures...
hyatt [Mon, 8 Jan 2007 11:57:36 +0000 (11:57 +0000)]
    This patch computes the correct column width and column count.  It ensures that content lays out constrained
        to the column width in one long strip.  It does not yet balance the long strip into multiple columns.

        Reviewed by Mark

        * rendering/RenderBlock.cpp:
        (WebCore:::RenderFlow):
        (WebCore::RenderBlock::layoutBlock):
        (WebCore::RenderBlock::rightOffset):
        (WebCore::RenderBlock::availableWidth):
        (WebCore::RenderBlock::columnGap):
        (WebCore::RenderBlock::calcColumnWidth):
        * rendering/RenderBlock.h:
        * rendering/RenderStyle.h:
        (WebCore::RenderStyle::setColumnWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix column-count so that it supports auto just like column-width does.
hyatt [Mon, 8 Jan 2007 10:30:22 +0000 (10:30 +0000)]
    Fix column-count so that it supports auto just like column-width does.

        Add a new function, availableWidth(), that will be used to return the width available to content placed inside
        a block.  For now it still returns contentWidth(), so no behavioral change has occurred yet.

        Subclass calcWidth() in RenderBlock, but don't change anything yet.  This is where RenderBlock will calc the
        correct column width.

        Reviewed by mark

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::leftRelOffset):
        (WebCore::RenderBlock::rightRelOffset):
        (WebCore::RenderBlock::getClearDelta):
        (WebCore::RenderBlock::availableWidth):
        (WebCore::RenderBlock::calcWidth):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::containingBlockWidth):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::containingBlockWidth):
        (WebCore::RenderObject::paddingTop):
        (WebCore::RenderObject::paddingBottom):
        (WebCore::RenderObject::paddingLeft):
        (WebCore::RenderObject::paddingRight):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::availableWidth):
        * rendering/RenderStyle.cpp:
        (WebCore::StyleMultiColData::StyleMultiColData):
        (WebCore::StyleMultiColData::operator==):
        * rendering/RenderStyle.h:
        (WebCore::RenderStyle::hasAutoColumnCount):
        (WebCore::RenderStyle::setColumnCount):
        (WebCore::RenderStyle::setHasAutoColumnCount):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::calcWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
hyatt [Mon, 8 Jan 2007 08:45:32 +0000 (08:45 +0000)]
LayoutTests:

        Add layout test for inheritance of auto z-index.

        Reviewed by eric

        * fast/layers/zindex-inherit-expected.checksum: Added.
        * fast/layers/zindex-inherit-expected.png: Added.
        * fast/layers/zindex-inherit-expected.txt: Added.
        * fast/layers/zindex-inherit.html: Added.

WebCore:

        Fix z-index:inherit so that it works properly when inheriting from z-index:auto.

        Reviewed by eric

        fast/layers/zindex-inherit.html

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add support for all of the CSS3 multi-column properties in preparation for...
hyatt [Mon, 8 Jan 2007 08:41:23 +0000 (08:41 +0000)]
    Add support for all of the CSS3 multi-column properties in preparation for implementing the
        feature.

        Reviewed by eric

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::):
        * css/CSSPropertyNames.in:
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * rendering/RenderStyle.cpp:
        (WebCore::StyleMultiColData::StyleMultiColData):
        (WebCore::StyleMultiColData::operator==):
        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
        (WebCore::StyleRareNonInheritedData::operator==):
        (WebCore::RenderStyle::RenderStyle):
        (WebCore::RenderStyle::diff):
        * rendering/RenderStyle.h:
        (WebCore::StyleMultiColData::operator!=):
        (WebCore::StyleMultiColData::ruleWidth):
        (WebCore::RenderStyle::columnWidth):
        (WebCore::RenderStyle::hasAutoColumnWidth):
        (WebCore::RenderStyle::columnCount):
        (WebCore::RenderStyle::columnGap):
        (WebCore::RenderStyle::hasAutoColumnGap):
        (WebCore::RenderStyle::columnRuleColor):
        (WebCore::RenderStyle::columnRuleStyle):
        (WebCore::RenderStyle::columnRuleWidth):
        (WebCore::RenderStyle::columnBreakBefore):
        (WebCore::RenderStyle::columnBreakInside):
        (WebCore::RenderStyle::columnBreakAfter):
        (WebCore::RenderStyle::setColumnWidth):
        (WebCore::RenderStyle::setHasAutoColumnWidth):
        (WebCore::RenderStyle::setColumnCount):
        (WebCore::RenderStyle::setColumnGap):
        (WebCore::RenderStyle::setHasAutoColumnGap):
        (WebCore::RenderStyle::setColumnRuleColor):
        (WebCore::RenderStyle::setColumnRuleStyle):
        (WebCore::RenderStyle::setColumnRuleWidth):
        (WebCore::RenderStyle::resetColumnRule):
        (WebCore::RenderStyle::setColumnBreakBefore):
        (WebCore::RenderStyle::setColumnBreakInside):
        (WebCore::RenderStyle::setColumnBreakAfter):
        (WebCore::RenderStyle::initialColumnCount):
        (WebCore::RenderStyle::initialColumnWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
rwlbuis [Mon, 8 Jan 2007 06:45:10 +0000 (06:45 +0000)]
    Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10587
        pointer-events is not implemented for RenderSVGImage or RenderSVGText
        Implement pointer-events for raster images and svg text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ddkilzer [Mon, 8 Jan 2007 05:17:06 +0000 (05:17 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11917
          setlocale() can return null

        * kjs/date_object.cpp:
        (KJS::DateProtoFunc::callAsFunction): Removed dead code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ddkilzer [Mon, 8 Jan 2007 05:11:18 +0000 (05:11 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12100
          JNI bindings should be available to non-Mac platforms that have JNI

        Change JNI so that it is not wrapped in the PLATFORM(MAC) ifdef, enabling
        other platforms who have JNI to use it.

        * bindings/jni/jni_instance.h:
          Removed unnecessary include of <CoreFoundation/CoreFoundation.h>
        * bindings/jni/jni_utility.cpp:
        (KJS::Bindings::setJavaVM):
        * bindings/jni/jni_utility.h:
          Added new method for clients to set the JavaVM
        * bindings/runtime.cpp:
        (KJS::Bindings::Instance::createBindingForLanguageInstance):
          Changed code to utilize new #if HAVE(JNI)
        * kjs/config.h:
          Added new #define for JNI, ie HAVE_JNI

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ddkilzer [Mon, 8 Jan 2007 05:08:17 +0000 (05:08 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        Fix http://bugs.webkit.org/show_bug.cgi?id=11431
        ARM platform has some byte alignment issues

        Fix for NaN being 4 bytes and it must start on a byte boundary
        for ARM architectures.

        * kjs/fpconst.cpp:
        (KJS::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix a regression where border-radius was not clipping the background when...
hyatt [Mon, 8 Jan 2007 01:16:55 +0000 (01:16 +0000)]
    Fix a regression where border-radius was not clipping the background when border was set to none.
        Fix multi-line inline flow painting to properly apply border-radius to the background only at the
        beginning of the first line and end of the last line.

        Reviewed by eric

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintBackground):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintBackground):
        (WebCore::RenderBox::paintBackgroundExtended):
        * rendering/RenderBox.h:
        * rendering/RenderObject.h:
        (WebCore::RenderObject::paintBackgroundExtended):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
hyatt [Sun, 7 Jan 2007 23:31:07 +0000 (23:31 +0000)]
LayoutTests:

        Add support for the CSS3 box-shadow property.

        Reviewed by olliej

        * fast/box-shadow/basic-shadows-expected.checksum: Added.
        * fast/box-shadow/basic-shadows-expected.png: Added.
        * fast/box-shadow/basic-shadows-expected.txt: Added.
        * fast/box-shadow/basic-shadows.html: Added.

WebCore:

        Add support for the CSS3 box-shadow property.

        Reviewed by olliej

        fast/box-shadow/ contains the tests for this feature.

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::clipOutRoundedRect):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::clipOut):
        (WebCore::GraphicsContext::clipOutEllipseInRect):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::clipOut):
        (WebCore::GraphicsContext::clipOutEllipseInRect):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paint):
        (WebCore::InlineFlowBox::paintBoxShadow):
        (WebCore::InlineFlowBox::paintBoxDecorations):
        (WebCore::shouldDrawTextDecoration):
        (WebCore::InlineFlowBox::paintTextDecorations):
        * rendering/InlineFlowBox.h:
        * rendering/InlineRunBox.h:
        (WebCore::InlineRunBox::paintBoxDecorations):
        (WebCore::InlineRunBox::paintTextDecorations):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintObject):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::setStyle):
        (WebCore::RenderBox::paintBoxDecorations):
        (WebCore::RenderBox::paintBackgroundExtended):
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::paintBoxDecorations):
        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::paint):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paint):
        * rendering/RenderImage.h:
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
        (WebCore::RenderObject::paintBoxShadow):
        (WebCore::RenderObject::dump):
        (WebCore::RenderObject::setStyle):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::hasBoxDecorations):
        (WebCore::RenderObject::setHasBoxDecorations):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paint):
        (WebCore::RenderTable::paintBoxDecorations):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::RenderTableCell):
        (WebCore::RenderTableCell::setStyle):
        (WebCore::RenderTableCell::paintBoxDecorations):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by weinig.
rwlbuis [Sun, 7 Jan 2007 18:15:39 +0000 (18:15 +0000)]
    Reviewed by weinig.

        Correct results from previous patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by weinig.
rwlbuis [Sun, 7 Jan 2007 16:47:24 +0000 (16:47 +0000)]
    Reviewed by weinig.

        http://bugs.webkit.org/show_bug.cgi?id=10362
        SVG needs to support SVGError events and some form of "error state"
        Report SVG warnings and errors on (JS) console.
        Expose line and column number getters in Tokenizer in
        order to display them with the error message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Sam.
zimmermann [Sun, 7 Jan 2007 14:00:06 +0000 (14:00 +0000)]
Reviewed by Sam.
Cleanup code & fix InlineBox positioning when text-anchor is used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMake it compile and link again. (Qt) Includes implementation of a few stubs
staikos [Sun, 7 Jan 2007 12:47:42 +0000 (12:47 +0000)]
Make it compile and link again. (Qt)  Includes implementation of a few stubs
which should be moved to other locations, as well as a non-Qt-specific change
to make it compile (nil->ResourceResponse()).  Qt port continues to function as
well as before.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Updated pixel results that weren't landed with r17141.
ap [Sun, 7 Jan 2007 12:01:26 +0000 (12:01 +0000)]
    Updated pixel results that weren't landed with r17141.

        * http/tests/incremental/slow-utf8-css-expected.checksum:
        * http/tests/incremental/slow-utf8-css-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-01-07 Mitz Pettel <mitz@webkit.org>
ap [Sun, 7 Jan 2007 11:47:34 +0000 (11:47 +0000)]
2007-01-07  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Mark Rowe.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11133

        Test: fast/forms/listbox-clip.html

        * platform/mac/PlatformScrollBarMac.mm:
        (-[WebCoreScrollBar initWithPlatformScrollbar:]): Get the correct scrollbar
        width/height based on control size.
        * rendering/RenderListBox.cpp:
        Renamed optionsSpacingLeft to optionsSpacingHorizontal since it is applied
        on both sides.
        (WebCore::RenderListBox::calcMinMaxWidth): Account for optionsSpacingHorizontal.
        Not including the spacing before went unnoticed since the scrollbar was lying
        about its width by exactly the same amount.
        (WebCore::RenderListBox::paintObject): Clip out the scrollbar.
        (WebCore::RenderListBox::paintItemForeground): Changed for the rename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-01-07 Mitz Pettel <mitz@webkit.org>
ap [Sun, 7 Jan 2007 11:35:05 +0000 (11:35 +0000)]
2007-01-07  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11935
          REGRESSION: Changing the overflow style dynamically does not force repaint

        Test: fast/repaint/erase-overflow.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::setStyle): Added a repaint before changing hasOverflowClip
        to true, to ensure that the current overflow is erased.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
rwlbuis [Sun, 7 Jan 2007 11:26:48 +0000 (11:26 +0000)]
    Reviewed by Darin.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=12106
        Changed URL from WebResourceLoadDelegate's webView:resource:willSendRequest:... is ignored

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Re-apply r17618, which got reverted with CSS suite update.
ap [Sun, 7 Jan 2007 11:26:35 +0000 (11:26 +0000)]
    Re-apply r17618, which got reverted with CSS suite update.

        Reviewed by Sam Weinig.

        Fix a layout test failure that happened with additional fonts installed - replace a fancy
        Unicode character with a plain asterisk.

        * css2.1/t0905-c414-flt-00-d-expected.checksum:
        * css2.1/t0905-c414-flt-00-d-expected.png:
        * css2.1/t0905-c414-flt-00-d-expected.txt:
        * css2.1/t0905-c414-flt-00-d.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap [Sun, 7 Jan 2007 11:14:41 +0000 (11:14 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=10313
        xsl:import doesn't work in stylesheets loaded via XMLHttpRequest

        This is a partial fix that makes a couple more steps towards fixing the problem.

        Test: fast/xsl/transform-xhr-doc.xhtml

        * xml/XSLTProcessor.cpp:
        (WebCore::xsltStylesheetPointer): Pass an URL for the stylesheet. I'm not sure why this constructor even needs it,
        given that it has a Node, but this is a small modifications that makes XSLImportRule try to load from a correct URL.
        (WebCore::XSLTProcessor::transformToString): Fix the crash for real this time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
rwlbuis [Sun, 7 Jan 2007 08:37:24 +0000 (08:37 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=12125
        overflow attribute of the symbol element not respected

        Copy the attribute map to the cloned node so the overflow on
        the symbol is respected.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Suggested by Mitz.
darin [Sun, 7 Jan 2007 04:29:48 +0000 (04:29 +0000)]
    Suggested by Mitz.

        - disabled 3 tests with results that are too font-dependent to be used as
          part of the test suite; two are tests of Armenian numbering and one is
          a test of some SVG font features which we do not support

        * css2.1/t1202-counter-10-b-expected.checksum: Removed.
        * css2.1/t1202-counter-10-b-expected.png: Removed.
        * css2.1/t1202-counter-10-b-expected.txt: Removed.
        * css2.1/t1202-counter-10-b.html: Removed.
        * css2.1/t1202-counters-10-b-expected.checksum: Removed.
        * css2.1/t1202-counters-10-b-expected.png: Removed.
        * css2.1/t1202-counters-10-b-expected.txt: Removed.
        * css2.1/t1202-counters-10-b.html: Removed.
        * svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Removed.
        * svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Removed.
        * svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Removed.
        * svg/W3C-SVG-1.1/text-fonts-03-t.svg: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed and significantly tweaked by Darin.
darin [Sun, 7 Jan 2007 04:11:10 +0000 (04:11 +0000)]
    Reviewed and significantly tweaked by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12103
          LEAK: Fix the leaking ImageBuffer buffers on TOT

        * ksvg2/svg/SVGMaskElement.h:
        * ksvg2/svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::drawMaskerContent):
        Changed to return auto_ptr since it returns a newly-created ImageBuffer.

        * ksvg2/svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::buildPattern):
        Changed to use auto_ptr since ImageBuffer::create now returns one.

        * platform/graphics/GraphicsContext.h: Removed the include of ImageBuffer.h,
        which was never needed, and the declaration of createImageBuffer, which is
        now a class member function of ImageBuffer.

        * platform/graphics/ImageBuffer.h: Replaced the constructor with a create
        function. Added a comment about the need to move renderSubtreeToImage
        elsewhere. Added an m_data member to store the data so it can be deleted
        when the object is done, made the m_size member non-platform-specific.
        Added a private constructor for use to create the CG version.

        * platform/graphics/cg/GraphicsContextCG.cpp: Removed
        GraphicsContext::createImageBuffer.

        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::create): Added. Replaces the old
        GraphicsContext::createImageBuffer function.
        (WebCore::ImageBuffer::ImageBuffer): Added m_data and m_context.
        (WebCore::ImageBuffer::~ImageBuffer): Added a fastFree of the data and got
        rid of the unneeded null check before calling CGImageRelease.

        * platform/graphics/svg/SVGPaintServerGradient.h: Removed the include of
        ImageBuffer.h and declared the ImageBuffer class instead.

        * platform/graphics/svg/SVGPaintServerPattern.h: Removed the include of
        ImageBuffer.h and declared the ImageBuffer class instead, and changed setTile
        to take an auto_ptr since it takes ownership of the ImageBuffer.
        * platform/graphics/svg/SVGPaintServerPattern.cpp:
        (WebCore::SVGPaintServerPattern::setTile): Ditto.

        * platform/graphics/svg/SVGResourceMasker.h: Removed the include of
        ImageBuffer.h and declared the ImageBuffer class instead, and changed setMask
        to take an auto_ptr since it takes ownership of the ImageBuffer.
        * platform/graphics/svg/SVGResourceMasker.cpp:
        (WebCore::SVGResourceMasker::setMask): Ditto.

        * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
        (WebCore::SVGPaintServerGradient::setup): Updated to use auto_ptr.

        * platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp: Updated includes.

        * platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
        (WebCore::SVGResourceMasker::applyMask): Updated to use auto_ptr.

        - other changes

        * ksvg2/svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::handleStartCondition):
        Remove unused variables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoThis is still X11-specific.
staikos [Sat, 6 Jan 2007 17:15:58 +0000 (17:15 +0000)]
This is still X11-specific.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
ddkilzer [Sat, 6 Jan 2007 12:06:30 +0000 (12:06 +0000)]
WebCore:

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12136
          REGRESSION: Counters-related leaks

        * rendering/RenderCounter.cpp:
        (WebCore::destroyCounterNodeChildren): Delete the child counter nodes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Release build fix.
adele [Sat, 6 Jan 2007 06:24:08 +0000 (06:24 +0000)]
    Release build fix.

        * rendering/RenderListItem.cpp: (WebCore::RenderListItem::explicitValueChanged): Initialize listRenderer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
darin [Sat, 6 Jan 2007 01:36:24 +0000 (01:36 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - added a new version of the CSS 2.1 test from the W3C site
        - added counters, list, and other CSS tests for my counter-related check-in

        * css2.1: Updated to the 2006-10-11 version of the test suite.
        I downloaded it from http://www.w3.org/Style/CSS/Test/CSS2.1/20061011/
        added UTF-8 BOMs to the beginning of all the files, and generated expected
        results.

        * fast/css-generated-content/reset-content-to-initial-expected.txt: Updated
        to reflect a bug fix in CSS content property support.

        * fast/css/counters/*: Removed all the existing tests since they are now part
        of the CSS 2.1 test suite.

        * fast/css/counters/counter-text-security-expected.checksum:  Added. New test.
        * fast/css/counters/counter-text-security-expected.png: Ditto.
        * fast/css/counters/counter-text-security-expected.txt: Ditto.
        * fast/css/counters/counter-text-security.html: Ditto.

        * fast/css/counters/counter-text-transform-expected.checksum: Added. New test.
        * fast/css/counters/counter-text-transform-expected.png: Ditto.
        * fast/css/counters/counter-text-transform-expected.txt: Ditto.
        * fast/css/counters/counter-text-transform.html: Ditto.

        * fast/lists/decimal-leading-zero-expected.checksum: Added. New test.
        * fast/lists/decimal-leading-zero-expected.png: Ditto.
        * fast/lists/decimal-leading-zero-expected.txt: Ditto.
        * fast/lists/decimal-leading-zero.html: Ditto.

        * fast/css/text-security-expected.checksum:  Added. New test.
        * fast/css/text-security-expected.png: Ditto.
        * fast/css/text-security-expected.txt: Ditto.
        * fast/css/text-security.html: Ditto.

        * fast/lists/decimal-leading-zero-expected.checksum: Added. New test.
        * fast/lists/decimal-leading-zero-expected.png: Ditto.
        * fast/lists/decimal-leading-zero-expected.txt: Ditto.
        * fast/lists/decimal-leading-zero.html: Ditto.

        * fast/lists/li-values-expected.checksum: Added. New test.
        * fast/lists/li-values-expected.png: Ditto.
        * fast/lists/li-values-expected.txt: Ditto.
        * fast/lists/li-values.html: Ditto.

        * fast/css/import-rule-regression-11590-expected.checksum: Added. Missing
        pixel-test results.
        * fast/css/import-rule-regression-11590-expected.png: Ditto.
        * fast/dom/css-insert-import-rule-expected.checksum: Ditto.
        * fast/dom/css-insert-import-rule-expected.png: Ditto.
        * fast/forms/encoding-test-expected.checksum: Ditto.
        * fast/forms/encoding-test-expected.png: Ditto.
        * fast/frames/frame-src-attribute-expected.checksum: Ditto.
        * fast/frames/frame-src-attribute-expected.png: Ditto.
        * fast/frames/onlyCommentInIFrame-expected.png: Ditto.
        * fast/frames/viewsource-attribute-expected.checksum: Ditto.
        * fast/frames/viewsource-attribute-expected.png: Ditto.
        * fast/loader/start-load-in-unload-expected.checksum: Ditto.
        * fast/loader/start-load-in-unload-expected.png: Ditto.

WebCore:

        Reviewed by Hyatt.

        - eliminated use of DeprecatedString for list item markers
        - eliminated use of DeprecatedValueList for border style collapsing
        - made many members private instead of protected or public

        - reworked counter implementation to fix most of the CSS 2.1 counter tests;
            made CounterNode be a simple non-polymorphic class, moved most counter-
            specific code out of RenderObject into RenderCounter, changed the data
            structure in RenderStyle to be more speed-efficient but less space-
            efficient for nodes with counter styles
        - fixed http://bugs.webkit.org/show_bug.cgi?id=11557

        Tests: css2.1

        - fixed a bug where counter text did not have text transform or text security
          applied to it

        Test: fast/css/counters/counter-text-security.html
        Test: fast/css/counters/counter-text-transform.html

        - improved handling of CSS content property values with data of the wrong
          type; this probably needs a bit more refinement

        Test: fast/css-generated-content/reset-content-to-initial-expected.txt

        - fixed a bug where removing the value attribute from an HTMLLIElement would
          set the list item's value to 0 instead of restoring it to normal

        Test: fast/lists/li-values.html

        - fixed a bug where changing the text security style from one style to another
          would not change the displayed text

        Test: fast/css/text-security.html

        - fixed some problems handling long sequences of counter-related styles;
          still needs more work and some super-large test cases to check if
          recursive algorithms for these that will overflow stack remain

        - added support for list styles decimal-leading-zero, hiragana, hirigana-iroha,
          katakana, katakana-iroha, cjk-ideographic, armenian, and georgian

        Test: fast/lists/decimal-leading-zero.html

        - minor tweaks and bug fixes for other list styles, including range checking

        * WebCore.exp: Updated for RenderListItem change.

        * bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]): Updated to use
        String instead of DeprecatedString.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Removed
        implementation for counter styles for now. We should probably restore it
        later, but we need to make sure the returned list is separate from the
        original list in the DOM -- modifying the list should not change the element
        it was computed from.

        * css/Counter.h: Removed unneeded empty constructor and destructor.

        * css/cssstyleselector.cpp:
        (WebCore::applyCounterList): Added. Stores counter directives in hash tables
        that should allow us to efficiently implement dynamic counter changes. Full
        support will have to wait for a future check-in.
        (WebCore::CSSStyleSelector::applyProperty): Changed counter properties to
        call applyCounterList. Reformatted the code to parse the content property for
        changes to RenderStyle and to handle the case where some the items in the
        content list don't generate any content.

        * editing/visible_units.cpp:
        * rendering/RenderBox.cpp:
        * rendering/RenderFlexibleBox.cpp:
        * rendering/RenderFlow.cpp:
        * rendering/RenderSlider.cpp:
        Added includes needed because of header changes.

        * html/HTMLLIElement.H: Removed unneeded m_isValued.
        * html/HTMLLIElement.cpp:
        (WebCore::HTMLLIElement::parseMappedAttribute): To match test results seen
        in WinIE, ignore values that are 0 or negative, and use new functions in
        RenderListItem to communicate the lack of a valid value.
        (WebCore::HTMLLIElement::attach): More of the same.

        * rendering/CounterNode.h: Made CounterNode be a non-polymorphic class,
        removing all the subclasses. Merged in CounterResetNode. Removed
        m_total from CounterResetNode, because it isn't needed for any of
        the styles (decimal-leading-zero always uses two digits). Removed
        m_hasSeparator and m_willNeedLayout since they aren't needed any more.
        Renamed m_count to m_countInParent for clarify, and named the list
        links the same as their associated functions. Removed many functions
        as well.
        * rendering/CounterNode.cpp:
        (WebCore::CounterNode::CounterNode): Added new fields.
        (WebCore::CounterNode::computeCountInParent): Added. Used by recount.
        (WebCore::CounterNode::recount): Simplified by removing unused parameter and the
        "get next" idiom. Changed to be iterative instead of recursive so we can handle
        arbitrarily long lists.
        (WebCore::CounterNode::insertAfter): Moved here from CounterResetNode. Updated
        for field name changes. Corrected rule for when to recount.
        (WebCore::CounterNode::removeChild): Moved here from CounterResetNode. Changed
        to only work on nodes without children. Corrected rule for when to recount.
        (WebCore::nextInPreOrderAfterChildren): Added. For debugging only.
        (WebCore::nextInPreOrder): Ditto.
        (WebCore::showTreeAndMark): Ditto.
        (showTree): Ditto.

        * rendering/CounterListItem.h:
        * rendering/CounterResetNode.h:
        * rendering/CounterResetNode.cpp:
        Marked ready to remove. I'll do the remove in a separate patch, since I have
        to update a lot of different make files when I do.

        * rendering/ListMarkerBox.cpp: (WebCore::ListMarkerBox::isText): Changed for the
        change to RenderListMarker.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::addChildToFlow): Changed to use functions instead of
        direct field access so the fields can be private and we don't need to be friends.
        (WebCore::RenderBlock::getBaselineOfFirstLineBox): Ditto.
        (WebCore::RenderBlock::getBaselineOfLastLineBox): Ditto.
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::initMaxMarginValues): Ditto.
        (WebCore::RenderBlock::firstRootBox): Ditto.
        (WebCore::RenderBlock::lastRootBox): Ditto.
        * rendering/RenderBox.h:
        (WebCore::RenderBox::setWidth): Ditto.
        (WebCore::RenderBox::setHeight): Ditto.
        * rendering/RenderButton.cpp:
        (WebCore::RenderButton::addChild): Ditto.
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::determineStartPosition): Ditto.

        * rendering/RenderContainer.h: Renamed m_first and m_last to m_firstChild
        and m_lastChild. Made them private instead of proected. Removed the
        setFirstChild and setLastChild functions.
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::RenderContainer): Updated for field name change.
        Changed all calls to get at fields directly instead of using functions.
        (WebCore::RenderContainer::destroyLeftoverChildren): Ditto.
        (WebCore::updateListMarkerNumbers): Updated for RenderListItem change.
        (WebCore::RenderContainer::addChild): Changed to get at fields directly
        instead of using functions. Also used release() since RenderText::setText
        now takes PassRefPtr.
        (WebCore::RenderContainer::removeChildNode): Changed to get at fields directly
        instead of using functions.
        (WebCore::RenderContainer::updatePseudoChildForObject): Create the anonymous
        box only if at least one of of the items in the content list actually
        generates content. Since a RenderCounter is a RenderText, don't bother making
        a new style for it -- it just shares the style with its parent. Changed code
        to use RenderImage::setCachedImage() instead of of setContentObject().
        Added a call to setIsAnonymousImage() here, which was the only special thing
        that setContentObject() used to do. Pass a reference to the counter to the
        RenderCounter rather than a pointer. Pass document() as the node instead of
        passing the element to RenderCounter, which makes it anonymous automatically,
        and removed the setIsAnonymous call.
        (WebCore::RenderContainer::appendChildNode): Chagned to get at fields directly
        instead of using functions.
        (WebCore::RenderContainer::insertChildNode): Ditto.
        (WebCore::RenderContainer::layout): Ditto.
        (WebCore::RenderContainer::removeLeftoverAnonymousBoxes): Ditto.
        (WebCore::RenderContainer::positionForCoordinates): Ditto.
        (WebCore::RenderContainer::addLineBoxRects): Ditto.

        * rendering/RenderCounter.h: Removed unneeded layout override, never called on a
        text node. Added override of originalString. Replaced CounterData* with a copy of
        the CounterContent -- it's two atomic strings and an integer so it's efficient
        enough to store all three in the render object, and this eliminates the lifetime
        problems we could have if we used a pointer.
        * rendering/RenderCounter.cpp: Removed duplicate copy of list marker code.
        (WebCore::counterMaps): Moved these maps here from RenderObject.
        (WebCore::previousSiblingOrParent): Added.
        (WebCore::lastDescendant): Added.
        (WebCore::previousInPreOrder): Added.
        (WebCore::planCounter): Added.
        (WebCore::findPlaceForCounter): Added.
        (WebCore::counter): New name of function that was named RenderObject::findCounter.
        Also uses a new algorithm that passes all the CSS 2.1 tests.
        (WebCore::RenderCounter::RenderCounter): Changed to take a Document* instead of a
        Node*, since at the moment counters are always anonymous.
        (WebCore::RenderCounter::originalString): Added. This overrides the originalString
        in the RenderText base class so that any text transforms will use the counter's
        value. This code was previously in calcMinMaxWidth.
        (WebCore::RenderCounter::calcMinMaxWidth): Changed to call setInternalString and
        pass originalString -- this uses the counter's value from the counter tree.
        (WebCore::destroyCounterNodeChildren): Added.
        (WebCore::RenderCounter::destroyCounterNodes): Added. Called as needed from
        RenderObject::destroy for objects that have counter nodes.

        * rendering/RenderFlow.h: Made m_continuation private instead of protected.

        * rendering/RenderImage.h: Removed unneeded includes, and unnecessary element()
        function that casts to HTMLElement*. Made image() protected, and made the two
        calcAspectRatio functions private. Removed setContentObject(). Renamed the
        errorOccured() function to isErrorImage() and made it private.
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::RenderImage): Removed initialization of removed
        m_selectionState field.
        (WebCore::RenderImage::setCachedImage): Rearrange code so it won't try to
        call isErrorImage() on a null image.
        (WebCore::RenderImage::paint): Updated for name change.

        * rendering/RenderListBox.h: Removed unneeded forward declarations.

        * rendering/RenderListItem.h:
        Renamed markerStringValue() to markerText() and made it return a String instead of
        a DeprecatedString. Renamed m_prededfVal to m_explicitValue. Added booleans named
        m_hasExplicitValue and m_isValueUpToDate and marked m_value mutable so it can be
        computed in const member functions.
        (WebCore::RenderListItem::value): Changed to update value on demand at the time
        you ask for it.
        (WebCore::RenderListItem::hasExplicitValue): Added. Use instead of magic -1 value
        to indicate that the item does or does not have an explicit value.
        (WebCore::RenderListItem::explicitValue): Added.
        (WebCore::RenderListItem::setExplicitValue): Added.
        (WebCore::RenderListItem::clearExplicitValue): Added.
        * rendering/RenderListItem.cpp:
        (WebCore::RenderListItem::RenderListItem): Updated to not use magic -1 values.
        (WebCore::RenderListItem::setStyle): Removed call to RenderListMarker::setListItem
        since it's not needed any more, and instead pass the list item to the constructor.
        (WebCore::previousListItem): Made parameter const.
        (WebCore::RenderListItem::calcValue): Restructed the function a bit.
        (WebCore::RenderListItem::updateValueNow): Added. Calls calcValue.
        (WebCore::RenderListItem::updateValue): Added. New name for resetValue(). Unlike
        the old version, this no longer calculates the value until it's asked-for later.
        (WebCore::RenderListItem::markerText): Changed to return String rather than a
        DeprecatedString and to return a null string rather than empty string when there
        is no marker.

        * rendering/RenderListMarker.h: Added listMarkerText function -- common code shared
        with anyone who needs to convert a value into text given a list style.
        Changed constructor to take a RenderListItem and figure out the document from that.
        Added isImage() and isText() functions and removed listImage() function. Changed the
        type of the text() function from DeprecatedString to String. Removed the listItem()
        and seListeItem() functions. Made the getRelativeMarkerRect() function private.
        Renamed m_item to m_text and chagned it from DeprecatedString to String. Renamed
        m_listImage to m_image.
        * rendering/RenderListMarker.cpp:
        (WebCore::toRoman): Added range checking to fix buffer overrun for large or negative
        numbers. Rewrote to use a local UChar array and String rather than prepending to a
        DeprecatedString.
        (WebCore::toAlphabetic): Replaces toLetterString, and is more flexible since it takes
        an alphabet array. Changed to match CSS 3 specification by using decimal numbering for
        0 and negative numbers. Rewrote to use a local UChar array and String rather than
        prepending to a DeprecatedString.
        (WebCore::toHebrewUnder1000): Added. Helper function for Hebrew numbers so we can
        handle numbers up to a million.
        (WebCore::toHebrew): Changed to use toHebrewUnder1000, added a special case for
        zero, negative, and too-large numbers.
        (WebCore::toArmenianUnder10000): Added. Used by toArmenian.
        (WebCore::toArmenian): Added.
        (WebCore::toGeorgian): Added.
        (WebCore::toCJKIdeographic): Added.
        (WebCore::listMarkerText): Added. Moved the code here from calcMinMaxWidth, but added
        support for text for the styles disc, circle, square, decimal-leading-zero, hiragana,
        hirigana-iroha, katakana, katakana-iroha, cjk-ideographic, armenian, and georgian.
        Also changed some of the styles to share the new toAlphabetic function.
        (WebCore::RenderListMarker::RenderListMarker): Updated for name changes and list
        item parameter.
        (WebCore::RenderListMarker::~RenderListMarker): Updated for name changes.
        (WebCore::RenderListMarker::setStyle): Updated for name changes.
        (WebCore::RenderListMarker::isImage): Added. Useful helper that unifies the check
        for no image and the error image.
        (WebCore::RenderListMarker::paint): Updated for name changes to to use isImage()
        and rearranged the code a bit.
        (WebCore::RenderListMarker::imageChanged): Updated for name change
        (WebCore::RenderListMarker::calcMinMaxWidth): Updated for name change, fixed a bug
        where we'd leave the old text around if we were using an image-based marker. Also
        changed the code to use isImage() instead of checking m_listImage.
        (WebCore::RenderListMarker::calcWidth): Changed to use isImage().
        (WebCore::RenderListMarker::lineHeight): Changed to use isImage().
        (WebCore::RenderListMarker::baselinePosition): Changed to use isImage().
        (WebCore::RenderListMarker::getRelativeMarkerRect): Changed to use isImage(),
        restructured the code a little.

        * rendering/RenderObject.h: Removed now-uneeded includes. Removed collectBorders()
        and isFormElement(). Made remove() function and m_hasCounterNodeMap public so
        we could remove friend declarations for RenderListItem and RenderView.
        Moved findCounter() to become a private function inside RenderCounter.cpp.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createObject): Fix bug where a contentData() with
        CONTENT_NONE is treated as image content -- only look at the content property
        if it has exactly one entry which is a CONTENT_OBJECT.
        (WebCore::RenderObject::selectionStartEnd): Add const.
        (WebCore::RenderObject::destroy): Moved counter-specific code to
        RenderCounter::destroyCounterNodes.
        (WebCore::RenderObject::recalcMinMaxWidths): Changed code to set m_recalcMinMax
        near the top of the function -- the old code would potentially reset it after it
        was set by the calcMinMaxWidths functions, and possibly skip a future needed
        recalc. That came up in counter test cases. Removed unneeded boolean check right
        after an assertion.

        * rendering/RenderPart.h: Marked two virtual functions virtual for clarity.

        * rendering/RenderReplaced.h: Made shouldPaint be protected, and made
        m_intrinsicWidth, m_intrinsicHeight, and m_selectionState be private.
        Also marked isSelected() const.
        * rendering/RenderReplaced.cpp: Added newly-needed include.
        (WebCore::RenderReplaced::RenderReplaced): Use constructor syntax.
        (WebCore::RenderReplaced::isSelected): Made const and changed to call the
        selectionStartEnd function in the straightforward way.

        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::absoluteRects): Use functions instead of direct field
        access so the fields can be private.
        (WebCore::RenderSVGText::relativeBBox): Ditto.

        * rendering/RenderStyle.h: Tweaked formatting. Changed names of CSS3 holders
        to say "rare" instead, since it's not all CSS 3. Renamed CounterData to
        CounterContent, since it's used inside ContentData. Changed names of fields in
        ContentData to have m prefix. Moved content and counter fields into the rare
        non-inherited data object. Removed unneeded assignment operator from a class
        that already inherits from Shared which makes it start out noncopyable.
        * rendering/RenderStyle.cpp: Name changes, plus:
        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
        Updated for added fields (content, counter-reset, counter-increment).
        (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): Ditto.
        (WebCore::StyleRareNonInheritedData::operator==): Reformatted and sorted so it's
        easy to see if any fields are missing.
        (WebCore::operator!=): Added. Compares two CounterContent objects.
        (WebCore::RenderStyle::arenaDelete): Removed code to handle content, which is
        now in the rareNonInheritedData structure.
        (WebCore::RenderStyle::RenderStyle): Ditto.
        (WebCore::RenderStyle::inheritFrom): Ditto.
        (WebCore::RenderStyle::operator==): Ditto.
        (WebCore::RenderStyle::inheritedNotEqual):
        (WebCore::RenderStyle::diff):
        (WebCore::RenderStyle::contentDataEquivalent): Added case for counter,
        which previously would be ignored when determining if content is equivalent.
        (WebCore::RenderStyle::clearContent): Added.
        (WebCore::RenderStyle::setContent): Updated for change in content location.
        (WebCore::ContentData::clear): Changed algorithm so that it's not recursive
        and thus can handle a very long list of ContentData.
        (WebCore::operator==): Added. Compares two CounterDirective objects.
        (WebCore::RenderStyle::counterDirectives): Added.
        (WebCore::RenderStyle::accessCounterDirectives): Added.

        * rendering/RenderTable.h: Made m_currentBorder const to better reflect the
        paint algorithm.
        * rendering/RenderTable.cpp: (WebCore::RenderTable::paint): Changed to use
        Vector instead of DeprecatedValueList for the border styles, and to sort
        rather than inserting in sorted order as we go. Put the code to loop through
        the nodes and collect border styles here instead of in a RenderObject virtual
        function. Also set m_currentBorder to 0 after the loop for greater clarity.

        * rendering/RenderTableCell.h: Added a typedef for a vector of border values.
        Removed the virtual collectBorders and replaced with the non-virtual named
        collectBorderStyles. Also added a static member function named sortBorderStyles.
        * rendering/RenderTableCell.cpp:
        (WebCore::CollapsedBorders::CollapsedBorders): Removed unneeded constructor
        parameter.
        (WebCore::addBorderStyle): Changed to use a vector instead of a
        DeprecatedValueList. Wrote out a loop since Vector doesn't have a contains
        member function. Removed the code to insert the border at a sorted location;
        instead we have a separate call to sort the border styles
        (WebCore::RenderTableCell::collectBorderStyles): Renamed, and changed the
        parameter type.
        (WebCore::compareBorderStylesForQSort): Added.
        (WebCore::RenderTableCell::sortBorderStyles): Added.

        * rendering/RenderText.h: Changed StringImpl parameters in setText functions
        to be PassRefPtr; added a new setInternalString function. Made a bunch of the
        member functions private and made all the data members private instead of
        protected.
        * rendering/RenderText.cpp:
        (WebCore::RenderText::setStyle): Restructure a bit for clarity. Fix case where
        the old style has a different security than the new style. Use release() since
        RenderText::setText now takes PassRefPtr. Always call cacheWidths here.
        (WebCore::RenderText::setTextWithOffset): Changed to take the string as a
        PassRefPtr instead of a raw pointer.
        (WebCore::isInlineFlowOrEmptyText): Added.
        (WebCore::RenderText::setInternalString): Refactored core of setText into a
        separate protected member function that can be used RenderCounter. Changed
        the text security square character to match what's used in list markers.
        Changed the text transform switch statement so that gcc will warn us if we add
        a new value and don't add a case for it.
        (WebCore::RenderText::setText): Refactored most of the function into
        setInternalString. Removed the call to cacheWidths -- that's now done in the
        setStyle function only.

        * rendering/RenderView.h:
        * rendering/RenderView.cpp: (WebCore::RenderView::selectionStartEnd): Now const.

        * rendering/RenderWidget.cpp: Added newly-needed include.
        (WebCore::RenderWidget::setSelectionState): Don't bother setting m_selectionState
        here since RenderReplaced::setSelectionState already does that.

WebKit:

        Reviewed by Hyatt.

        * Misc/WebNSAttributedStringExtras.m:
        (+[NSAttributedString _web_attributedStringFromRange:]):
        Updated to use new list marker text API that is String rather than
        DeprecatedString. Also removed code to do text form of non-text list
        markers since the list marker class now deals with that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
andersca [Sat, 6 Jan 2007 01:13:35 +0000 (01:13 +0000)]
    Reviewed by Darin.

        Fix build.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchCreatePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber stamped by Adam.
andersca [Sat, 6 Jan 2007 00:55:49 +0000 (00:55 +0000)]
    Rubber stamped by Adam.

        Move even more code to .cpp files.

        * WebCore.xcodeproj/project.pbxproj:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::createWindow):
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::canLoad):
        (WebCore::FrameLoader::initialRequest):
        (WebCore::FrameLoader::receivedData):
        (WebCore::FrameLoader::setRequest):
        (WebCore::FrameLoader::setResponse):
        (WebCore::FrameLoader::willUseArchive):
        (WebCore::FrameLoader::handleUnimplementablePolicy):
        (WebCore::FrameLoader::cannotShowMIMEType):
        (WebCore::FrameLoader::interruptionForPolicyChangeError):
        (WebCore::FrameLoader::checkNavigationPolicy):
        (WebCore::FrameLoader::checkContentPolicy):
        (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
        (WebCore::FrameLoader::reloadAllowingStaleData):
        (WebCore::FrameLoader::reload):
        (WebCore::FrameLoader::finishedLoading):
        (WebCore::FrameLoader::continueAfterWillSubmitForm):
        (WebCore::FrameLoader::submitForm):
        (WebCore::FrameLoader::post):
        (WebCore::FrameLoader::isReloading):
        (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
        (WebCore::FrameLoader::loadResourceSynchronously):
        (WebCore::FrameLoader::startLoadingMainResource):
        (WebCore::FrameLoader::startLoading):
        (WebCore::FrameLoader::cancelMainResourceLoad):
        (WebCore::FrameLoader::identifierForInitialRequest):
        (WebCore::FrameLoader::willSendRequest):
        (WebCore::FrameLoader::didReceiveResponse):
        (WebCore::FrameLoader::didReceiveData):
        (WebCore::FrameLoader::didFailToLoad):
        (WebCore::FrameLoader::originalRequest):
        (WebCore::FrameLoader::receivedMainResourceError):
        (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
        (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
        (WebCore::FrameLoader::opened):
        (WebCore::FrameLoader::dataURLBaseFromRequest):
        (WebCore::FrameLoader::checkNewWindowPolicy):
        (WebCore::FrameLoader::continueAfterNewWindowPolicy):
        (WebCore::FrameLoader::continueAfterNavigationPolicy):
        (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
        (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
        (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
        (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
        (WebCore::FrameLoader::sendRemainingDelegateMessages):
        (WebCore::FrameLoader::requestFromDelegate):
        (WebCore::FrameLoader::loadedResourceFromMemoryCache):
        (WebCore::FrameLoader::applyUserAgent):
        (WebCore::PolicyCheck::PolicyCheck):
        (WebCore::PolicyCheck::clear):
        (WebCore::PolicyCheck::set):
        (WebCore::PolicyCheck::call):
        (WebCore::PolicyCheck::clearRequest):
        * loader/FrameLoader.h:
        * loader/FrameLoaderClient.h:
        * loader/MainResourceLoader.h:
        * loader/ResourceLoader.h:
        (WebCore::ResourceLoader::setIdentifier):
        (WebCore::ResourceLoader::identifier):
        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
        (WebCore::FrameLoader::referrer):
        (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
        (WebCore::FrameLoader::didCancelAuthenticationChallenge):
        (WebCore::FrameLoader::didChangeTitle):
        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyFrameLoaderClient::dispatchCreatePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Fri, 5 Jan 2007 23:03:50 +0000 (23:03 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - repaint tests and updated results for
          http://bugs.webkit.org/show_bug.cgi?id=12079
          Nested tables don't repaint properly when a certain row is added

        * fast/repaint/table-section-overflow-expected.checksum: Added.
        * fast/repaint/table-section-overflow-expected.png: Added.
        * fast/repaint/table-section-overflow-expected.txt: Added.
        * fast/repaint/table-section-overflow.html: Added.
        * fast/repaint/table-section-repaint-expected.checksum: Added.
        * fast/repaint/table-section-repaint-expected.png: Added.
        * fast/repaint/table-section-repaint-expected.txt: Added.
        * fast/repaint/table-section-repaint.html: Added.
        * tables/mozilla/core/misc-expected.txt:
        * tables/mozilla/core/misc-expected.png:
        * tables/mozilla/core/misc-expected.checksum:

WebCore:

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12079
          Nested tables don't repaint properly when a certain row is added

        Tests: fast/repaint/table-section-repaint.html
               fast/repaint/table-section-overflow.html

        Fixed repainting when table sections move during layout.

        Made table cells' overflows propagate to table sections and gave tables
        overflows.

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::layout): Added computation of horizontal and vertical overflows
        based on the caption's and the table sections' overflows.
        Added checks for table sections that change position during layout. When that happens,
        we assume all sections below the first section that moved also moved, and repaint
        everything downwards from there.
        Added calls to repaintDuringLayoutIfMoved() for the caption.
        Changed the way table sections are iterated over and added a FIXME to change it again
        once bug 12124 is fixed.
        (WebCore::RenderTable::paint): Changed to paint overflow.
        (WebCore::RenderTable::outerBorderBottom):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::RenderTableSection):
        (WebCore::RenderTableSection::layoutRows): Added code to compute the section's overflow
        and a flag saying whether any cells in this section overflow.
        (WebCore::RenderTableSection::paint): Changed to paint overflow. If any cell
        in the section has overflow, then all cells are given a chance to paint. This is needed
        because there can be internal overflow, and external overflow can be coming from any
        cell inside.
        * rendering/RenderTableSection.h:
        (WebCore::RenderTableSection::overflowWidth):
        (WebCore::RenderTableSection::overflowLeft):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
bdakin [Fri, 5 Jan 2007 22:48:47 +0000 (22:48 +0000)]
    Reviewed by Adam.

        Fix for <rdar://problem/4863434> Wrong contextual menu appears for
        textarea and input elements at http://www.apple.com/feedback/
        ical.html

        No test cases added since context menus are not in DRT.

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::handleContextMenuEvent): Call
        EventHandler's hitTestResultAtPoint() instead of just hit testing
        the layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoindependEnt
andersca [Fri, 5 Jan 2007 22:27:53 +0000 (22:27 +0000)]
independEnt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Adam.
andersca [Fri, 5 Jan 2007 22:26:32 +0000 (22:26 +0000)]
    Rubber-stamped by Adam.

        Move a bunch of platform independant code over to DocumentLoader.cpp

        * WebCore.xcodeproj/project.pbxproj:
        * loader/DocumentLoader.cpp:
        (WebCore::canonicalizedTitle):
        (WebCore::DocumentLoader::DocumentLoader):
        (WebCore::DocumentLoader::frameLoader):
        (WebCore::DocumentLoader::~DocumentLoader):
        (WebCore::DocumentLoader::setMainResourceData):
        (WebCore::DocumentLoader::mainResourceData):
        (WebCore::DocumentLoader::originalRequest):
        (WebCore::DocumentLoader::originalRequestCopy):
        (WebCore::DocumentLoader::request):
        (WebCore::DocumentLoader::initialRequest):
        (WebCore::DocumentLoader::actualRequest):
        (WebCore::DocumentLoader::URL):
        (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
        (WebCore::DocumentLoader::setRequest):
        (WebCore::DocumentLoader::setMainDocumentError):
        (WebCore::DocumentLoader::clearErrors):
        (WebCore::DocumentLoader::mainReceivedError):
        (WebCore::DocumentLoader::stopLoading):
        (WebCore::DocumentLoader::setupForReplace):
        (WebCore::DocumentLoader::commitIfReady):
        (WebCore::DocumentLoader::finishedLoading):
        (WebCore::DocumentLoader::setCommitted):
        (WebCore::DocumentLoader::isCommitted):
        (WebCore::DocumentLoader::setLoading):
        (WebCore::DocumentLoader::isLoading):
        (WebCore::DocumentLoader::commitLoad):
        (WebCore::DocumentLoader::doesProgressiveLoad):
        (WebCore::DocumentLoader::receivedData):
        (WebCore::DocumentLoader::setupForReplaceByMIMEType):
        (WebCore::DocumentLoader::updateLoading):
        (WebCore::DocumentLoader::setFrame):
        (WebCore::DocumentLoader::attachToFrame):
        (WebCore::DocumentLoader::detachFromFrame):
        (WebCore::DocumentLoader::prepareForLoadStart):
        (WebCore::DocumentLoader::setIsClientRedirect):
        (WebCore::DocumentLoader::isClientRedirect):
        (WebCore::DocumentLoader::setPrimaryLoadComplete):
        (WebCore::DocumentLoader::isLoadingInAPISense):
        (WebCore::DocumentLoader::addResponse):
        (WebCore::DocumentLoader::stopRecordingResponses):
        (WebCore::DocumentLoader::title):
        (WebCore::DocumentLoader::setLastCheckedRequest):
        (WebCore::DocumentLoader::lastCheckedRequest):
        (WebCore::DocumentLoader::triggeringAction):
        (WebCore::DocumentLoader::setTriggeringAction):
        (WebCore::DocumentLoader::responses):
        (WebCore::DocumentLoader::setOverrideEncoding):
        (WebCore::DocumentLoader::overrideEncoding):
        (WebCore::DocumentLoader::setTitle):
        (WebCore::DocumentLoader::urlForHistory):
        * loader/DocumentLoader.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::committedLoad):
        (WebCore::FrameLoader::setMainDocumentError):
        (WebCore::FrameLoader::mainReceivedCompleteError):
        (WebCore::FrameLoader::mainReceivedError):
        (WebCore::FrameLoader::cancelledError):
        (WebCore::FrameLoader::fileDoesNotExistError):
        (WebCore::FrameLoader::mainResourceData):
        * loader/FrameLoader.h:
        * loader/FrameLoaderClient.h:
        * loader/mac/DocumentLoaderMac.mm:
        (WebCore::DocumentLoader::unreachableURL):
        * loader/mac/FrameLoaderMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixed Eric's name
beidson [Fri, 5 Jan 2007 21:18:08 +0000 (21:18 +0000)]
Fixed Eric's name

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric Siedel
beidson [Fri, 5 Jan 2007 21:14:52 +0000 (21:14 +0000)]
    Reviewed by Eric Siedel

        http://bugs.webkit.org/show_bug.cgi?id=12117
        Fixes null deref when opening links from a gmail account

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::updateHistoryForStandardLoad): Null check m_currentHistoryItem
        (WebCore::FrameLoader::updateHistoryForClientRedirect): Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move some now cross platform functions over to ResourceLoader.cpp in an attem...
andersca [Fri, 5 Jan 2007 21:00:47 +0000 (21:00 +0000)]
    Move some now cross platform functions over to ResourceLoader.cpp in an attempt to fix the non Mac builds.

        * loader/CachedResource.h:
        (WebCore::CachedResource::setAllData):
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::resourceData):
        * loader/ResourceLoader.h:
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::didFinishLoading):
        * loader/mac/LoaderFunctionsMac.mm:
        * loader/mac/ResourceLoaderMac.mm:
        * platform/SharedBuffer.cpp:
        (WebCore::SharedBuffer::platformDataSize):
        * platform/network/ResourceHandle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand updated results for float tests.
hyatt [Fri, 5 Jan 2007 20:57:54 +0000 (20:57 +0000)]
Land updated results for float tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Back out fix for 12114. I missed rule #5 in the float positioning part of...
hyatt [Fri, 5 Jan 2007 20:56:58 +0000 (20:56 +0000)]
    Back out fix for 12114.  I missed rule #5 in the float positioning part of the CSS2.1 spec.  Keep all
        the code cleanup though.

        Reviewed by mitz

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::positionNewFloats):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
andersca [Fri, 5 Jan 2007 19:33:24 +0000 (19:33 +0000)]
WebCore:

        Reviewed by Maciej.

        Add a shared buffer class which is backed by either a vector or an NSData object. This object can also
        be held in a custom NSData subclass. Use this in the loader wherever NSData was used.

        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * loader/CachedResource.h:
        (WebCore::CachedResource::allData):
        * loader/DocumentLoader.h:
        * loader/FrameLoader.h:
        * loader/ResourceLoader.h:
        * loader/SubresourceLoaderClient.h:
        (WebCore::SubresourceLoaderClient::didFail):
        * loader/loader.cpp:
        (WebCore::Loader::didFinishLoading):
        * loader/loader.h:
        * loader/mac/DocumentLoaderMac.mm:
        (WebCore::DocumentLoader::setMainResourceData):
        (WebCore::DocumentLoader::mainResourceData):
        (WebCore::DocumentLoader::setupForReplaceByMIMEType):
        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::mainResourceData):
        * loader/mac/ImageDocumentMac.mm:
        (WebCore::finishImageLoad):
        * loader/mac/LoaderFunctionsMac.mm:
        (WebCore::CheckCacheObjectStatus):
        (WebCore::CachedResource::setAllData):
        * loader/mac/NetscapePlugInStreamLoaderMac.mm:
        (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
        * loader/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::addData):
        (WebCore::ResourceLoader::resourceData):
        (WebCore::ResourceLoader::clearResourceData):
        (WebCore::ResourceLoader::didReceiveData):
        (WebCore::ResourceLoader::willStopBufferingData):
        * loader/mac/SubresourceLoaderMac.mm:
        (WebCore::SubresourceLoader::didReceiveResponse):
        (WebCore::SubresourceLoader::didFinishLoading):
        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge getData:andResponse:forURL:]):
        (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
        * platform/KURL.h:
        * platform/SharedBuffer.cpp: Added.
        (WebCore::SharedBuffer::SharedBuffer):
        (WebCore::SharedBuffer::size):
        (WebCore::SharedBuffer::data):
        (WebCore::SharedBuffer::append):
        (WebCore::SharedBuffer::clear):
        (WebCore::SharedBuffer::clearPlatformData):
        (WebCore::SharedBuffer::maybeTransferPlatformData):
        (WebCore::SharedBuffer::hasPlatformData):
        (WebCore::SharedBuffer::platformData):
        * platform/SharedBuffer.h: Added.
        * platform/mac/SharedBufferMac.mm: Added.
        (-[SharedBufferData dealloc]):
        (-[SharedBufferData finalize]):
        (-[SharedBufferData initWithSharedBuffer:WebCore::]):
        (-[SharedBufferData length]):
        (-[SharedBufferData bytes]):
        (WebCore::SharedBuffer::wrapNSData):
        (WebCore::SharedBuffer::SharedBuffer):
        (WebCore::SharedBuffer::createNSData):
        (WebCore::SharedBuffer::hasPlatformData):
        (WebCore::SharedBuffer::platformData):
        (WebCore::SharedBuffer::platformDataSize):
        (WebCore::SharedBuffer::maybeTransferPlatformData):
        (WebCore::SharedBuffer::clearPlatformData):
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleClient.h:
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::bufferedData):

WebKit:

        Reviewed by Maciej.

        The data returned is now a SharedBuffer so wrap it in an NSData object.

        * WebView/WebDataSource.mm:
        (-[WebDataSource data]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap [Fri, 5 Jan 2007 19:26:50 +0000 (19:26 +0000)]
    Reviewed by Darin.

        Test for http://bugs.webkit.org/show_bug.cgi?id=3420
        XMLHttpRequest does not handle set-cookie headers

        * http/tests/xmlhttprequest/resources/get-set-cookie.cgi:
        Set the cookies unconditionally (previously, the test failed if there
        were other cookies for 127.0.0.1:8000.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
andersca [Fri, 5 Jan 2007 19:02:22 +0000 (19:02 +0000)]
    Reviewed by Adam.

        http://bugs.webkit.org/show_bug.cgi?id=12120
        REGRESSION(r18605): Safari snippet editor no longer works

        * loader/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::willSendRequest):
        Put back the code change in r18607.

        * platform/mac/KURLMac.mm:
        (WebCore::KURL::KURL):
        Convert nil NSURLs to null KURLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
ap [Fri, 5 Jan 2007 16:15:22 +0000 (16:15 +0000)]
    Reviewed by Geoff.

        http://bugs.webkit.org/show_bug.cgi?id=7296
        Disable JavaScript exceptions when dynamically changing CSS properties.

        * bindings/js/kjs_css.cpp:
        (KJS::DOMCSSStyleDeclaration::put): Removed the Dashboard quirk logic.

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::setProperty): Don't raise an exception if parsing fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agobe smarter when detecting the display (hopefully fixes
zack [Fri, 5 Jan 2007 13:24:46 +0000 (13:24 +0000)]
be smarter when detecting the display (hopefully fixes
running the layout tests with the buildbot)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
antti [Fri, 5 Jan 2007 09:00:33 +0000 (09:00 +0000)]
LayoutTests:

        Reviewed by hyatt.

        Test for http://bugs.webkit.org/show_bug.cgi?id=12109
        layer visibility incorrect in some cases

        * fast/layers/layer-visibility-sublayer-expected.checksum: Added.
        * fast/layers/layer-visibility-sublayer-expected.png: Added.
        * fast/layers/layer-visibility-sublayer-expected.txt: Added.
        * fast/layers/layer-visibility-sublayer.html: Added.

WebCore:

        Reviewed by hyatt.

        http://bugs.webkit.org/show_bug.cgi?id=12109

        Fix layer visibility in some cases with nested layers.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateVisibilityStatus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agothe daily checkin to get the Qt build compiling again :)
lars [Fri, 5 Jan 2007 08:43:49 +0000 (08:43 +0000)]
the daily checkin to get the Qt build compiling again :)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
aroben [Fri, 5 Jan 2007 07:44:46 +0000 (07:44 +0000)]
WebCore:

        Reviewed by Geoff, cheered by others.

        Dead code elimination.

        All layout tests pass.

        * page/EventHandler.h:
        * page/mac/EventHandlerMac.mm:
        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreFrameBridge.mm:

WebKit:

        Reviewed by Geoff, cheered by others.

        Dead code elimination.

        * WebView/WebHTMLView.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18614 268f45cc-cd09-0410-ab3c-d52691b4dbfc