WebKit-https.git
6 years agoReport run id's in api/runs.php for the new dashboard UI
rniwa@webkit.org [Mon, 11 Aug 2014 21:16:27 +0000 (21:16 +0000)]
Report run id's in api/runs.php for the new dashboard UI
https://bugs.webkit.org/show_bug.cgi?id=135813

Reviewed by Andreas Kling.

Include run_id in the generated JSON.

* public/api/runs.php:
(fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
(format_run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMerging platforms mixes baselines and targets into reported data
rniwa@webkit.org [Mon, 11 Aug 2014 20:48:32 +0000 (20:48 +0000)]
Merging platforms mixes baselines and targets into reported data
https://bugs.webkit.org/show_bug.cgi?id=135260

Reviewed by Andreas Kling.

When merging two platforms, move test configurations of a different type (baseline, target)
as well as of different metric (Time, Runs).

Also avoid fetching the entire table of runs just to see if there are no remaining runs.
It's sufficient to detect one such test_runs object.

* public/admin/platforms.php:
(merge_platforms):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPass inherited style only when resolving tree style
antti@apple.com [Mon, 11 Aug 2014 20:42:16 +0000 (20:42 +0000)]
Pass inherited style only when resolving tree style
https://bugs.webkit.org/show_bug.cgi?id=135799

Reviewed by Andreas Kling.

No need to pass around the style parent element.

* dom/ContainerNode.h:
(WebCore::ContainerNode::childShouldCreateRenderer): Deleted.
* dom/Element.cpp:
(WebCore::Element::childShouldCreateRenderer):
* dom/Element.h:
* style/StyleResolveTree.cpp:
(WebCore::Style::RenderTreePosition::parent):
(WebCore::Style::nextSiblingRenderer):
(WebCore::Style::RenderTreePosition::RenderTreePosition):
(WebCore::Style::RenderTreePosition::computeNextSibling):
(WebCore::Style::shouldCreateRenderer):
(WebCore::Style::styleForElement):
(WebCore::Style::createRendererIfNeeded):
(WebCore::Style::textRendererIsNeeded):
(WebCore::Style::createTextRendererIfNeeded):
(WebCore::Style::attachTextRenderer):
(WebCore::Style::updateTextRendererAfterContentChange):
(WebCore::Style::attachChildren):
(WebCore::Style::attachDistributedChildren):
(WebCore::Style::attachShadowRoot):
(WebCore::Style::attachBeforeOrAfterPseudoElementIfNeeded):
(WebCore::Style::attachRenderTree):
(WebCore::Style::resolveLocal):
(WebCore::Style::resolveTextNode):
(WebCore::Style::resolveShadowTree):
(WebCore::Style::updateBeforeOrAfterPseudoElement):
(WebCore::Style::resolveTree):
* svg/SVGDocument.cpp:
(WebCore::SVGDocument::childShouldCreateRenderer): Deleted.

    Implement this in SVGSVGElement::rendererIsNeeded instead.

* svg/SVGDocument.h:
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::rendererIsNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCSS JIT: support :scope
utatane.tea@gmail.com [Mon, 11 Aug 2014 20:24:19 +0000 (20:24 +0000)]
CSS JIT: support :scope
https://bugs.webkit.org/show_bug.cgi?id=135733

Reviewed by Benjamin Poulain.

Implement :scope for CSS JIT. It introduces scope field to CheckingContext
and it makes CheckingContext more similar to SelectorChecker::SelectorCheckingContext.
And since :scope requires CheckingContext, QueryingRules can accept SelectorCheckerWithCheckingContext.

Source/WebCore:

Tests: fast/selectors/querySelector-scope-filtered-root.html
       fast/selectors/scope-works-as-root.html

* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::shouldUseRenderStyleFromCheckingContext):
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagsToElementStyleFromContext):
(WebCore::SelectorCompiler::SelectorCodeGenerator::loadCheckingContext):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsActive):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsFirstChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsHovered):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsLastChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsOnlyChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasPseudoElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateRequestedPseudoElementEqualsToSelectorPseudoElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsScopeRoot):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateMarkPseudoStyleForPseudoElement):
* cssjit/SelectorCompiler.h:
(WebCore::SelectorCompiler::CheckingContext::CheckingContext):
* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::executeCompiledSimpleSelectorChecker):
(WebCore::SelectorDataList::executeCompiledSelectorCheckerWithCheckingContext):
(WebCore::SelectorDataList::execute):
* dom/SelectorQuery.h:

LayoutTests:

* fast/selectors/querySelector-scope-filtered-root-expected.txt: Added.
* fast/selectors/querySelector-scope-filtered-root.html: Added.
Searching root node of querySelectorAll is filtered to id node, but :scope root node should not be changed.
* fast/selectors/scope-works-as-root-expected.html: Added.
* fast/selectors/scope-works-as-root.html: Added.
:scope in stylesheet works as :root.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd Private WKPreferences API for developer extras (show inspector)
commit-queue@webkit.org [Mon, 11 Aug 2014 20:07:51 +0000 (20:07 +0000)]
Add Private WKPreferences API for developer extras (show inspector)
https://bugs.webkit.org/show_bug.cgi?id=135811

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-08-11
Reviewed by Timothy Hatcher.

* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _developerExtrasEnabled]):
(-[WKPreferences _setDeveloperExtrasEnabled:]):
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r172401.
commit-queue@webkit.org [Mon, 11 Aug 2014 20:00:58 +0000 (20:00 +0000)]
Unreviewed, rolling out r172401.
https://bugs.webkit.org/show_bug.cgi?id=135812

Failing stress/for-in-tests.js
http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/7945/steps
/jscore-test/logs/stdio (Requested by mlam on #webkit).

Reverted changeset:

"for-in optimization should also make sure the base matches
the object being iterated"
https://bugs.webkit.org/show_bug.cgi?id=135782
http://trac.webkit.org/changeset/172401

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: console.profile shouldn't stop auto-recorded profiles
timothy@apple.com [Mon, 11 Aug 2014 19:50:52 +0000 (19:50 +0000)]
Web Inspector: console.profile shouldn't stop auto-recorded profiles
https://bugs.webkit.org/show_bug.cgi?id=135810

Reviewed by Joseph Pecoraro.

* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::start): Added. Call internalStart. Set m_enabledFromFrontend.
(WebCore::InspectorTimelineAgent::stop): Added. Calls internalStop. Clear m_enabledFromFrontend.
(WebCore::InspectorTimelineAgent::internalStart): Renamed from start.
(WebCore::InspectorTimelineAgent::internalStop): Renamed from stop.
(WebCore::InspectorTimelineAgent::startFromConsole): Use internalStart.
(WebCore::InspectorTimelineAgent::stopFromConsole): Use internalStop. Only stop if !m_enabledFromFrontend.
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent): Initialize m_enabledFromFrontend.
* inspector/InspectorTimelineAgent.h: Added m_enabledFromFrontend.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Update folder icons
timothy@apple.com [Mon, 11 Aug 2014 19:22:15 +0000 (19:22 +0000)]
Web Inspector: Update folder icons
https://bugs.webkit.org/show_bug.cgi?id=135808

Reviewed by Joseph Pecoraro.

* UserInterface/Images/FolderGeneric.png: Updated.
* UserInterface/Images/FolderGeneric@2x.png: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: use type builders to construct high fidelity type information payloads
burg@cs.washington.edu [Mon, 11 Aug 2014 19:19:47 +0000 (19:19 +0000)]
Web Inspector: use type builders to construct high fidelity type information payloads
https://bugs.webkit.org/show_bug.cgi?id=135803

Reviewed by Timothy Hatcher.

Due to some typos in the protocol file, the code had worked with raw objects
rather than with type builders. Convert to using builders.

* inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
* inspector/agents/InspectorRuntimeAgent.h:
* inspector/protocol/Runtime.json: Fix 'item' for 'items'; true for 'true'.
* runtime/HighFidelityTypeProfiler.cpp:
(JSC::HighFidelityTypeProfiler::getTypesForVariableAtOffsetForInspector):
* runtime/HighFidelityTypeProfiler.h:
* runtime/TypeSet.cpp:
(JSC::TypeSet::allStructureRepresentations):
(JSC::StructureShape::stringRepresentation):
(JSC::StructureShape::inspectorRepresentation):
* runtime/TypeSet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agofor-in optimization should also make sure the base matches the object being iterated
mhahnenberg@apple.com [Mon, 11 Aug 2014 18:59:44 +0000 (18:59 +0000)]
for-in optimization should also make sure the base matches the object being iterated
https://bugs.webkit.org/show_bug.cgi?id=135782

Reviewed by Geoffrey Garen.

If we access a different base object with the same index, we shouldn't try to randomly
load from that object's backing store.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::pushIndexedForInScope):
(JSC::BytecodeGenerator::pushStructureForInScope):
* bytecompiler/BytecodeGenerator.h:
(JSC::ForInContext::ForInContext):
(JSC::ForInContext::base):
(JSC::StructureForInContext::StructureForInContext):
(JSC::IndexedForInContext::IndexedForInContext):
* bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitMultiLoopBytecode):
* tests/stress/for-in-tests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] Unreviewed gardening.
bfulgham@apple.com [Mon, 11 Aug 2014 18:47:34 +0000 (18:47 +0000)]
[Win] Unreviewed gardening.

* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Display files in
proper folder categories..

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: DataGrid and its clients are a cluster-cuss of styles
timothy@apple.com [Mon, 11 Aug 2014 18:43:11 +0000 (18:43 +0000)]
Web Inspector: DataGrid and its clients are a cluster-cuss of styles
https://bugs.webkit.org/show_bug.cgi?id=135788

Clean up DataGrid and its subclasses and client styles.

Reviewed by Joseph Pecoraro.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/ApplicationCacheFrameContentView.css:
(.content-view.application-cache-frame > .data-grid):
* UserInterface/Views/CookieStorageContentView.css:
(.content-view.cookie-storage > .data-grid):
* UserInterface/Views/DOMStorageContentView.css:
(.content-view.dom-storage > .data-grid):
* UserInterface/Views/DOMTreeDataGrid.css:
(.dom-tree-data-grid .data-grid):
(.dom-tree-data-grid .name-column .icon):
* UserInterface/Views/DOMTreeDataGrid.js:
(WebInspector.DOMTreeDataGrid):
* UserInterface/Views/DataGrid.css:
(.data-grid):
(.data-grid table):
(.data-grid .data-container):
(.data-grid.inline):
(.data-grid th):
(.data-grid :-webkit-any(th, td):not(:last-child)):
(.data-grid th.sortable:active):
(.data-grid th:-webkit-any(.sort-ascending, .sort-descending)):
(.data-grid table.data):
(.data-grid td):
(.data-grid:focus tr.selected td:not(:last-child)):
(body.mac-platform.legacy .data-grid:focus tr.selected td:not(:last-child)):
(.data-grid :-webkit-any(th, td) > div):
(.data-grid th:-webkit-any(.sort-ascending, .sort-descending) > div:first-child):
(.data-grid th.sort-ascending > div:first-child::after):
(.data-grid th.sort-descending > div:first-child::after):
(.data-grid td .subtitle):
(.data-grid td .subtitle::before):
(.data-grid:focus tr.selected td .subtitle):
(.data-grid td.error):
(.data-grid tr.selected td.error):
(.data-grid td .icon):
(.data-grid td .go-to-arrow):
(.data-grid tr:-webkit-any(.selected, :hover) .go-to-arrow):
* UserInterface/Views/DatabaseContentView.css:
(.storage-view):
* UserInterface/Views/DatabaseTableContentView.css:
(.content-view.database-table > .data-grid):
* UserInterface/Views/DetailsSection.css:
(.details-section > .content .data-grid):
* UserInterface/Views/IndexedDatabaseObjectStoreContentView.css:
(.content-view.indexed-database-object-store > .data-grid):
* UserInterface/Views/LayerTreeDataGridNode.js:
(WebInspector.LayerTreeDataGridNode.prototype._makeNameCell):
(WebInspector.LayerTreeDataGridNode.prototype._updateNameCellData):
* UserInterface/Views/LayerTreeSidebarPanel.css:
(.layer-tree.panel .data-grid):
(.layer-tree.panel .name-column .icon):
(.layer-tree.panel tr.reflection .name-column .icon):
(.layer-tree.panel tr.pseudo-element .name-column .icon):
(.layer-tree.panel .name-column .reflection):
(.layer-tree.panel tr.selected .name-column .reflection):
(.layer-tree.panel .bottom-bar):
(body.mac-platform.legacy .layer-tree.panel .bottom-bar):
(.layer-tree.panel .bottom-bar > div):
(body.mac-platform.legacy .layer-tree.panel .bottom-bar > div):
(body.mac-platform.legacy .layer-tree-popover):
* UserInterface/Views/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel):
(WebInspector.LayerTreeSidebarPanel.prototype._buildLayerInfoSection):
(WebInspector.LayerTreeSidebarPanel.prototype._buildDataGridSection):
(WebInspector.LayerTreeSidebarPanel.prototype._buildBottomBar):
(WebInspector.LayerTreeSidebarPanel.prototype._updateMetrics):
* UserInterface/Views/LegacyJavaScriptProfileView.css:
(.content-view.profile-view > .data-grid):
* UserInterface/Views/LegacyProfileView.css:
* UserInterface/Views/LogContentView.css:
(.console-message .bubble):
* UserInterface/Views/NetworkTimelineView.css:
(.timeline-view.network > .data-grid):
* UserInterface/Views/OverviewTimelineView.css:
(.timeline-view.overview > .timeline-ruler > .header):
(.timeline-view.overview > .data-grid):
* UserInterface/Views/OverviewTimelineView.js:
* UserInterface/Views/ProbeDetailsSidebarPanel.css:
(.details-section.probe-set .options > .probe-add):
(.popover .probe-popover):
* UserInterface/Views/ProbeSetDataGrid.css:
(.details-section.probe-set .data-grid tr.past-value td):
(.details-section.probe-set .data-grid > td.unknown-value):
(.details-section.probe-set .data-grid tr.revealed.highlighted):
(.details-section.probe-set .data-grid tr.separator):
(.details-section.probe-set .data-grid > tr.data-updated):
(.details-section.probe-set .data-grid .selected .section *):
(.details-section.probe-set .data-grid .selected td.unknown-value):
(.details-section.probe-set .data-grid .section):
* UserInterface/Views/QuickConsole.css:
(.quick-console):
* UserInterface/Views/TimelineDataGrid.css:
(.data-grid.timeline th):
(.data-grid.timeline > .navigation-bar-container > .navigation-bar):
* UserInterface/Views/TimelineRuler.css:
(.timeline-ruler > .header):
(.timeline-ruler > .header > .divider):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoJIT should use full 64-bit stores for jsBoolean and jsNull
mhahnenberg@apple.com [Mon, 11 Aug 2014 18:39:52 +0000 (18:39 +0000)]
JIT should use full 64-bit stores for jsBoolean and jsNull
https://bugs.webkit.org/show_bug.cgi?id=135784

Reviewed by Michael Saboff.

This guarantees that we set the high bits of the register with the correct tag.

* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_has_structure_property):
(JSC::JIT::emit_op_next_enumerator_pname):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] Adjust build script for Windows production build.
bfulgham@apple.com [Mon, 11 Aug 2014 18:23:29 +0000 (18:23 +0000)]
[Win] Adjust build script for Windows production build.
https://bugs.webkit.org/show_bug.cgi?id=135806
<rdar://problem/17978299>

Reviewed by Timothy Hatcher.

../JavaScriptCore:

* JavaScriptCore.vcxproj/copy-files.cmd: Copy file for later use
in WebInspectorUI build.

../WebCore:

* WebCore.vcxproj/copyForwardingHeaders.cmd: Copy file needed
for WebInspectorUI build.

../WebInspectorUI:

* WebInspectorUI.vcxproj/WebInspectorUI.make: Make sure target for
xcopy operation exists.
* WebInspectorUI.vcxproj/WebInspectorUI.proj: Don't create directories
we don't need, make sure the target location exists before we build.
* WebInspectorUI.vcxproj/build-webinspectorui.pl: Make sure that
production builds get the intermediary command files from the
right place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Add a helper to avoid leaking single-fire event listeners in Promise...
burg@cs.washington.edu [Mon, 11 Aug 2014 18:10:25 +0000 (18:10 +0000)]
Web Inspector: Add a helper to avoid leaking single-fire event listeners in Promise chains
https://bugs.webkit.org/show_bug.cgi?id=135772

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

A common pattern when working with promise chains is to convert an event
handler into a promise by using a single-fire event listener with the
resolve continuation as the callback. This is fine if the event fires;
if it doesn't fire, then the event emitter permanently keeps a reference to the
this-object and the callback.

This patch adds EventListener, a proxy object for events that can be manipulated
from multiple promise callback functions. If a promise is rejected, the catch
block can disconnect any event listeners set up earlier in the promise chain.

This patch also reimplements EventListenerSet to use multiple EventListeners,
since they share the same logic to uniformly handle Inspector and DOM events.

Test: inspector/event-listener.html
Test: inspector/event-listener-set.html

* UserInterface/Base/EventListener.js: Added.
(WebInspector.EventListener):
(WebInspector.EventListener.prototype.this._callback):
(WebInspector.EventListener.prototype.connect):
(WebInspector.EventListener.prototype.disconnect):
* UserInterface/Base/EventListenerSet.js: Update license block.
(WebInspector.EventListenerSet.prototype.register):
(WebInspector.EventListenerSet.prototype.install):
(WebInspector.EventListenerSet.prototype.uninstall):
* UserInterface/Main.html: Include EventListener.
* UserInterface/Test.html: Include EventListener and EventListenerSet.

LayoutTests:

* inspector/event-listener-expected.txt: Added.
* inspector/event-listener-set-expected.txt: Added.
* inspector/event-listener-set.html: Added.
* inspector/event-listener.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Services with UI] Action menu arrow hit testing is sometimes wrong.
enrica@apple.com [Mon, 11 Aug 2014 17:52:15 +0000 (17:52 +0000)]
[Services with UI] Action menu arrow hit testing is sometimes wrong.
https://bugs.webkit.org/show_bug.cgi?id=135776
<rdar://problem/17837670>

Reviewed by Brady Eidson.

There was a problem in the algorithm that stitches together the selection rectangles
to be given to Data Detectors API.
This change adds a new function that stiches together all the rects contributing to the
first line, all the rects contributing to the last line and all the ones in the middle.
This way we can have a maximum of 3 non overlapping rectangles.

* WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::stitchRects):
(WebKit::compactRectsWithGapRects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r172393.
commit-queue@webkit.org [Mon, 11 Aug 2014 10:40:00 +0000 (10:40 +0000)]
Unreviewed, rolling out r172393.
https://bugs.webkit.org/show_bug.cgi?id=135796

discussion needed about GnuTLS version bump on the bots
(Requested by philn on #webkit).

Reverted changeset:

https://bugs.webkit.org/show_bug.cgi?id=133317
http://trac.webkit.org/changeset/172393

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Adds dependency on GnuTLS 3.0+ for the implementation of subtle crypto algorithms
commit-queue@webkit.org [Mon, 11 Aug 2014 10:23:48 +0000 (10:23 +0000)]
[GTK] Adds dependency on GnuTLS 3.0+ for the implementation of subtle crypto algorithms
https://bugs.webkit.org/show_bug.cgi?id=133317

.:

GnuTLS is already an indirect dependency through libsoup -> glib-networking.

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2014-08-11
Reviewed by Philippe Normand.

No new tests since no new functionality has been added.

* Source/cmake/OptionsGTK.cmake: Adds search for required GnuTLS package

Source/WebCore:

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2014-08-11
Reviewed by Philippe Normand.

No new tests since no new functionality has been added.

* PlatformGTK.cmake: Adds GnuTLS libs and included dirs to WebCore targets

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, EFL build fix since r172385.
gyuyoung.kim@samsung.com [Mon, 11 Aug 2014 10:07:59 +0000 (10:07 +0000)]
Unreviewed, EFL build fix since r172385.

* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Fix debug build after r172389.
philn@webkit.org [Mon, 11 Aug 2014 10:04:32 +0000 (10:04 +0000)]
[GTK] Fix debug build after r172389.

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2014-08-11
Rubber-stamped by Philippe Normand.

* crypto/gtk/CryptoKeyRSAGtk.cpp:
(WebCore::CryptoKeyRSA::exportData): Remove spurious ASSERT from
stub. It will be added back along with the real implementation of
the method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed fix after r172348.
zandobersek@gmail.com [Mon, 11 Aug 2014 09:48:06 +0000 (09:48 +0000)]
Unreviewed fix after r172348.

* platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::BitmapImage): Initialize m_minimumSubsamplingLevel to 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Adds stubs for all subtle crypto algorithm implemntations
commit-queue@webkit.org [Mon, 11 Aug 2014 08:59:15 +0000 (08:59 +0000)]
[GTK] Adds stubs for all subtle crypto algorithm implemntations
https://bugs.webkit.org/show_bug.cgi?id=133316

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2014-08-11
Reviewed by Philippe Normand.

.:

* Source/cmake/OptionsGTK.cmake: Add ENABLE_SUBTLE_CRYPTO option
* Source/cmake/WebKitFeatures.cmake: Add ENABLE_SUBTLE_CRYPTO option
* Source/cmakeconfig.h.cmake: Define ENABLE_SUBTLE_CRYPTO

Source/WebCore:

No new tests since no new functionality has been added.

* CMakeLists.txt: Add subtle crypto 'algorithms' and 'parameters' dirs to WebCore incuded dirs
* PlatformGTK.cmake:  Add subtle crypto sources to WebCore target
* crypto/gtk/CryptoAlgorithmAES_CBCGtk.cpp: Added.
(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):
* crypto/gtk/CryptoAlgorithmAES_KWGtk.cpp: Added.
(WebCore::CryptoAlgorithmAES_KW::platformEncrypt):
(WebCore::CryptoAlgorithmAES_KW::platformDecrypt):
* crypto/gtk/CryptoAlgorithmHMACGtk.cpp: Added.
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):
* crypto/gtk/CryptoAlgorithmRSAES_PKCS1_v1_5Gtk.cpp: Added.
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):
* crypto/gtk/CryptoAlgorithmRSASSA_PKCS1_v1_5Gtk.cpp: Added.
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):
* crypto/gtk/CryptoAlgorithmRSA_OAEPGtk.cpp: Added.
(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):
* crypto/gtk/CryptoAlgorithmRegistryGtk.cpp: Added.
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
* crypto/gtk/CryptoDigestGtk.cpp: Added.
(WebCore::CryptoDigest::CryptoDigest):
(WebCore::CryptoDigest::~CryptoDigest):
(WebCore::CryptoDigest::create):
(WebCore::CryptoDigest::addBytes):
(WebCore::CryptoDigest::computeHash):
* crypto/gtk/CryptoKeyRSAGtk.cpp: Added.
(WebCore::CryptoKeyRSA::CryptoKeyRSA):
(WebCore::CryptoKeyRSA::create):
(WebCore::CryptoKeyRSA::~CryptoKeyRSA):
(WebCore::CryptoKeyRSA::restrictToHash):
(WebCore::CryptoKeyRSA::isRestrictedToHash):
(WebCore::CryptoKeyRSA::keySizeInBits):
(WebCore::CryptoKeyRSA::buildAlgorithmDescription):
(WebCore::CryptoKeyRSA::exportData):
(WebCore::CryptoKeyRSA::generatePair):
* crypto/gtk/SerializedCryptoKeyWrapGtk.cpp: Added.
(WebCore::getDefaultWebCryptoMasterKey):
(WebCore::wrapSerializedCryptoKey):
(WebCore::unwrapSerializedCryptoKey):
* crypto/keys/CryptoKeyRSA.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Update OptionsGTK.cmake and NEWS for 2.5.2 release.
carlosgc@webkit.org [Mon, 11 Aug 2014 08:05:15 +0000 (08:05 +0000)]
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.5.2 release.

.:

* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

* gtk/NEWS: Add release notes for 2.5.2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Fix GTK+ make distcheck.
carlosgc@webkit.org [Mon, 11 Aug 2014 07:29:34 +0000 (07:29 +0000)]
Unreviewed. Fix GTK+ make distcheck.

* gtk/manifest.txt: Remove Source/WebCore/Resources/inputSpeech.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] No IPC messages are sent when building WebKitGTK+ with VERSION_SCRIPT
carlosgc@webkit.org [Mon, 11 Aug 2014 06:34:39 +0000 (06:34 +0000)]
[GTK] No IPC messages are sent when building WebKitGTK+ with VERSION_SCRIPT
https://bugs.webkit.org/show_bug.cgi?id=135760

Reviewed by Philippe Normand.

The problem is that the threading initialization is failing
because there are two copies of WTF, one in libjavascriptcoregtk
and the other in libwebkit2gtk. When WebKit2 is initialized in the
UI process, JSC::initializeThreading() is called first and then
WTF::initializeMainThread(). The former is calling
ThreadIdentifierData::initializeOnce() initializing the
ThreadIdentifierData::m_key symbol in libjavascriptcoregtk, while
the latter is using the ThreadIdentifierData API from libwebkit2gtk
that hasn't been initialized.

* CMakeLists.txt: Do not add WTF to the list of WebKit2 libraries,
WebKit2 already depends on JavaScriptCore that already links to WTF.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove inputSpeech.png
commit-queue@webkit.org [Mon, 11 Aug 2014 04:22:11 +0000 (04:22 +0000)]
Remove inputSpeech.png
https://bugs.webkit.org/show_bug.cgi?id=135771

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-08-10
Reviewed by Andreas Kling.

* Resources/inputSpeech.png: Removed.
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoYelp phone number highlights often disappear
timothy_horton@apple.com [Mon, 11 Aug 2014 01:26:14 +0000 (01:26 +0000)]
Yelp phone number highlights often disappear
https://bugs.webkit.org/show_bug.cgi?id=135789
<rdar://problem/17971057>

Reviewed by Brady Eidson.

Since selectedTelephoneNumberRangesChanged doesn't provide an associated
Frame, an incoming selectedTelephoneNumberRangesChanged from a subframe
would overwrite ServicesOverlayController's cached (and potentially active)
telephone number highlights.

This happens a lot on Yelp, because they have many subframes which are
doing layout on a regular basis.

* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::selectedTelephoneNumberRangesChanged):
* WebProcess/WebCoreSupport/WebEditorClient.h:
Adjust to the new (lack of) arguments.

* WebProcess/WebPage/ServicesOverlayController.h:
* WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::selectedTelephoneNumberRangesChanged):
Adjust logging; we can revisit it later.

(WebKit::ServicesOverlayController::buildPhoneNumberHighlights):
When building phone number highlights, walk the Frame tree and retrieve
them from all of the Editors.

(WebKit::ServicesOverlayController::didRebuildPotentialHighlights):
(WebKit::ServicesOverlayController::telephoneNumberRangesForFocusedFrame):
(WebKit::ServicesOverlayController::determineActiveHighlight):
(WebKit::ServicesOverlayController::handleClick):
Retrieve the detected telephone number ranges from the focused frame
when combining telephone numbers with selection services.
This ensures that we don't show combined phone number highlights from other frames.

* editing/Editor.cpp:
(WebCore::Editor::scanSelectionForTelephoneNumbers):
(WebCore::Editor::clearDataDetectedTelephoneNumbers): Deleted.
* editing/Editor.h:
(WebCore::Editor::detectedTelephoneNumberRanges):
* page/EditorClient.h:
(WebCore::EditorClient::selectedTelephoneNumberRangesChanged):
Cache and expose detected telephone number ranges on Editor.
Change selectedTelephoneNumberRangesChanged to take no arguments; it's
just a notification now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRefactor ServiceOverlayController in preparation for fading between highlights
timothy_horton@apple.com [Mon, 11 Aug 2014 01:23:36 +0000 (01:23 +0000)]
Refactor ServiceOverlayController in preparation for fading between highlights
https://bugs.webkit.org/show_bug.cgi?id=135787
<rdar://problem/17935736>

Reviewed by Brady Eidson.

Rework ServicesOverlayController so that we always keep a set of generic
"potential highlights", which are refcounted Highlight objects and
wrap a DDHighlightRef, as well as a type (Selection or TelephoneNumber),
Range (only used in the case of TelephoneNumber), and potentially more
things in the future (like, say, fade state!).

We eagerly update the list of potential highlights when the selection or set
of detected telephone numbers changes, and use this information to install
or uninstall the page overlay as needed.

When we need to recompute the "active" highlight from this set (for example,
we need to handle a mouse event or paint the highlight), we look through
the set of potential highlights and decide. This moves the "active" highlight
decision logic into one small and confined place.

* WebProcess/WebPage/ServicesOverlayController.h:
(WebKit::ServicesOverlayController::Highlight):
Add the new aforementioned refcounted Highlight class.
Rename m_lastHoveredHighlightChangeTime to m_lastActiveHighlightChangeTime.
Make m_webPage a reference.
The rest is just added/removed/adjusted functions for the refactoring.

(WebKit::TelephoneNumberData::TelephoneNumberData): Deleted.
* WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::Highlight::createForSelection):
(WebKit::ServicesOverlayController::Highlight::createForTelephoneNumber):
Create Highlights for the two different highlight types.

(WebKit::ServicesOverlayController::ServicesOverlayController):
(WebKit::ServicesOverlayController::willMoveToWebPage):
Our WebPage pointer is always valid because it owns us; don't clear it.
We need to keep it around so that we can uninstall the overlay and
install it again later, anyway.

(WebKit::ServicesOverlayController::selectionRectsDidChange):
(WebKit::ServicesOverlayController::selectedTelephoneNumberRangesChanged):
When selection rects or detected telephone numbers change, rebuild potential highlights.
This will have the side-effect of installing the overlay if needed.

(WebKit::ServicesOverlayController::mouseIsOverHighlight):
Make this function take a Highlight instead of a DDHighlightRef.

(WebKit::ServicesOverlayController::remainingTimeUntilHighlightShouldBeShown):
Make this function take a Highlight instead of a DDHighlightRef.

(WebKit::ServicesOverlayController::drawHighlight):
Make this function take a Highlight instead of a DDHighlightRef.
There's no reason to do the translation separately from the layer blit,
also allowing us to avoid the StateSaver.

(WebKit::ServicesOverlayController::drawRect):
drawRect now always paints the active highlight, instead of duplicating
logic about which highlight should be active.
Also, it will update the active highlight before painting.
We no longer need to re-determine whether the active highlight's phone
number range is still a valid phone number range, because we rebuild
the potential highlights whenever the set of phone number ranges changes.

(WebKit::ServicesOverlayController::clearActiveHighlight):
Mostly an adoption of new names.

(WebKit::ServicesOverlayController::removeAllPotentialHighlightsOfType):
Run through the list of potential highlights and remove any of the given type.
The two highlight building functions use this helper to clear the old ones before building.

(WebKit::ServicesOverlayController::buildPhoneNumberHighlights):
(WebKit::ServicesOverlayController::buildSelectionHighlight):
Rebuild the list of potential highlights, replacing all highlights of
the given type with new ones.

(WebKit::ServicesOverlayController::hasRelevantSelectionServices):
Factor out the code that decides whether our current selection is
viable for servicing based on whether we have plain-text and/or rich-text services.

(WebKit::ServicesOverlayController::didRebuildPotentialHighlights):
When rebuilding potential highlights, if we have no potential highlights at all,
uninstall the page overlay; we don't need mouse tracking and don't need to
paint anything. This improves memory use and compositing performance significantly,
where previously we were leaving the overlay up forever after creating it.

If we have either detected telephone numbers or relevant selection services,
create and install the overlay if it doesn't already exist.

(WebKit::ServicesOverlayController::createOverlayIfNeeded):
This just moved from elsehwere, except that it now uses FadeMode::DoNotFade.
It doesn't make sense to fade on install/uninstall (which happens even before hover)
but not on changing the active highlight; fading will be re-addressed in the next patch.

(WebKit::ServicesOverlayController::highlightsAreEquivalent):
Determine whether two highlights are equivalent. While we may have
created a new Highlight at rebuild time, if two telephone number
highlights have equivalent ranges, there's no need to 'transition' to the new one.

(WebKit::ServicesOverlayController::determineActiveHighlight):
Run through the list of services, and try to find one that is hovered.
We prefer telephone number highlights to selection highlights, and
we will never make a selection highlight active if it is both
not serviceable and there are no telephone numbers to show in the combined menu.
This is the centralized location for determination of which highlight
should be considered active. If the active highlight changed, update
the time since last change and cancel the mouse-down tracking.

(WebKit::ServicesOverlayController::mouseEvent):
Adjust some comments to be more explanatory.
A bunch of code moved out of here and into determineActiveHighlight.

(WebKit::ServicesOverlayController::handleClick):
Adjust to take a reference and use Highlight instead of DDHighlightRef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDestructuring assignment in a var declaration list incorrectly consumes subsequent...
oliver@apple.com [Sun, 10 Aug 2014 20:12:01 +0000 (20:12 +0000)]
Destructuring assignment in a var declaration list incorrectly consumes subsequent variable initialisers
https://bugs.webkit.org/show_bug.cgi?id=135773

Reviewed by Michael Saboff.

Source/JavaScriptCore:

We should be using parseAssignment expression in order to get the correct
precedence.

* parser/Parser.cpp:
(JSC::Parser<LexerType>::parseVarDeclarationList):

LayoutTests:

Add new tests.

* js/destructuring-assignment-expected.txt:
* js/script-tests/destructuring-assignment.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoJSC Lexer is allowing octals 08 and 09 in strict mode functions
commit-queue@webkit.org [Sun, 10 Aug 2014 20:07:34 +0000 (20:07 +0000)]
JSC Lexer is allowing octals 08 and 09 in strict mode functions
https://bugs.webkit.org/show_bug.cgi?id=135704

Patch by Diego Pino Garcia <dpino@igalia.com> on 2014-08-10
Reviewed by Oliver Hunt.

Return syntax error ("Decimal integer literals with a leading zero are
forbidden in strict mode") if a number starts with 0 and is followed
by a digit.

* parser/Lexer.cpp:
(JSC::Lexer<T>::lex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: new glyphs are visible on OS X 10.9 builds
timothy@apple.com [Sun, 10 Aug 2014 10:25:27 +0000 (10:25 +0000)]
Web Inspector: new glyphs are visible on OS X 10.9 builds
https://bugs.webkit.org/show_bug.cgi?id=135743

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

* UserInterface/Images/Legacy/UserInputPrompt.svg: Removed.
* UserInterface/Images/Legacy/UserInputPromptPrevious.svg: Removed.
* UserInterface/Images/Legacy/UserInputResult.svg: Removed.
Removed images that were not used.

* UserInterface/Views/DashboardContainerView.css:
(body.mac-platform.legacy .dashboard-container .advance-arrow):
* UserInterface/Views/DebuggerDashboardView.js:
(WebInspector.DebuggerDashboardView):
* UserInterface/Views/FolderIcon.css:
(body.mac-platform.legacy .folder-icon .icon):
* UserInterface/Views/HierarchicalPathComponent.css:
(body.mac-platform.legacy .hierarchical-path-component > .selector-arrows):
* UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView):
Use legacy images.

* UserInterface/Views/NavigationSidebarPanel.css:
(.navigation-sidebar-panel-content-tree-outline:focus .item.selected .subtitle):
Fix color for selected subtitle.

* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel):
Use legacy images.

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController window]): Use 10100 instead of 1090 for the version.

Source/WebKit2:

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::createInspectorWindow): Use 10100 instead of 1090 for the version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate HashTable's operator= after r172167 per review comments
benjamin@webkit.org [Sun, 10 Aug 2014 08:45:13 +0000 (08:45 +0000)]
Update HashTable's operator= after r172167 per review comments

* wtf/HashTable.h:
Update the type as suggested by Darin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] REGRESSION(r166239): The ld version script is not being used
carlosgc@webkit.org [Sun, 10 Aug 2014 07:30:26 +0000 (07:30 +0000)]
[GTK] REGRESSION(r166239): The ld version script is not being used
https://bugs.webkit.org/show_bug.cgi?id=135694

Reviewed by Martin Robinson.

.:

Move the symbols filter file from Tools/gtk to Source/cmake and rename
it as gtksymbols.filter. Also updated it, since some of the symbols
exported were renamed.

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/gtksymbols.filter: Renamed from Tools/gtk/symbols.filter.

Source/WebKit2:

* CMakeLists.txt: Add VERSION_SCRIPT to WebKit2 link flags if present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Child processes should be installed in a versioned directory
carlosgc@webkit.org [Sun, 10 Aug 2014 07:09:47 +0000 (07:09 +0000)]
[GTK] Child processes should be installed in a versioned directory
https://bugs.webkit.org/show_bug.cgi?id=135754

Reviewed by Gustavo Noronha Silva.

Define LIBEXEC_INSTALL_DIR as
${CMAKE_INSTALL_FULL_LIBEXECDIR}/webkitgtk-${WEBKITGTK_API_VERSION}
so that the child processes are installed in $libexec/webkitgtk-4.0.
This makes it possible to install 2.6 in parallel to older versions.

* Source/cmake/OptionsGTK.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: TimelineManager should reuse empty recordings
burg@cs.washington.edu [Sun, 10 Aug 2014 04:34:34 +0000 (04:34 +0000)]
Web Inspector: TimelineManager should reuse empty recordings
https://bugs.webkit.org/show_bug.cgi?id=135749

Reviewed by Timothy Hatcher.

Check whether the recording is empty before creating a new one.

* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype._loadNewRecording):
* UserInterface/Models/TimelineRecording.js:
(WebInspector.TimelineRecording.prototype.isEmpty):
(WebInspector.TimelineRecording.prototype.unloaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r172301): Combined phone number highlight doesn't appear if rich content...
timothy_horton@apple.com [Sun, 10 Aug 2014 01:04:23 +0000 (01:04 +0000)]
REGRESSION (r172301): Combined phone number highlight doesn't appear if rich content is selected and we have no rich content services
https://bugs.webkit.org/show_bug.cgi?id=135785
<rdar://problem/17969843>

Reviewed by Brady Eidson.

* WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::drawSelectionHighlight):
We can't early return in the rich-content-but-no-rich-services case
if we have telephone numbers in the selection, because we want to offer
them up in the combined menu.

* UIProcess/mac/WebContextMenuProxyMac.mm:
If we end up with no menu, because there were no services available,
make a fresh one that we can fill with combined telephone number items.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSubpixel rendering: Transforms on non-compositing layers leave bits behind when the...
zalan@apple.com [Sun, 10 Aug 2014 00:48:59 +0000 (00:48 +0000)]
Subpixel rendering: Transforms on non-compositing layers leave bits behind when the box boundaries changes.
https://bugs.webkit.org/show_bug.cgi?id=135786

Reviewed by Simon Fraser.

Since we don't control the transformed context painting's snapping strategy, our best bet to fully
include the transformed box when requesting for repaint is to use enclosing.
Pixelsnapping doesn't work here for all cases. For example, a scaled box at 0.8px can be anti-aliased painted
both at 0.5px and 1px, while with pixelsnapping we'd expect it to be painted starting from 1px;

Source/WebCore:

Test: fast/repaint/hidpi-transform-on-subpixel-repaintrect.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint): enclose the result of the transform.

LayoutTests:

* fast/repaint/hidpi-transform-on-subpixel-repaintrect-expected.txt: Added.
* fast/repaint/hidpi-transform-on-subpixel-repaintrect.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION: Inspector crashes when debugger is paused and injected scripts access...
mark.lam@apple.com [Sat, 9 Aug 2014 06:50:19 +0000 (06:50 +0000)]
REGRESSION: Inspector crashes when debugger is paused and injected scripts access window.screen().
<https://webkit.org/b/135656>

Not reviewed.

Rolling out r170680 which was merged to ToT in r172129.

Source/JavaScriptCore:

* debugger/Debugger.h:
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::scope):
(JSC::DebuggerCallFrame::evaluate):
(JSC::DebuggerCallFrame::invalidate):
* debugger/DebuggerCallFrame.h:
* debugger/DebuggerScope.cpp:
(JSC::DebuggerScope::DebuggerScope):
(JSC::DebuggerScope::finishCreation):
(JSC::DebuggerScope::visitChildren):
(JSC::DebuggerScope::className):
(JSC::DebuggerScope::getOwnPropertySlot):
(JSC::DebuggerScope::put):
(JSC::DebuggerScope::deleteProperty):
(JSC::DebuggerScope::getOwnPropertyNames):
(JSC::DebuggerScope::defineOwnProperty):
(JSC::DebuggerScope::next): Deleted.
(JSC::DebuggerScope::invalidateChain): Deleted.
(JSC::DebuggerScope::isWithScope): Deleted.
(JSC::DebuggerScope::isGlobalScope): Deleted.
(JSC::DebuggerScope::isFunctionScope): Deleted.
* debugger/DebuggerScope.h:
(JSC::DebuggerScope::create):
(JSC::DebuggerScope::Iterator::Iterator): Deleted.
(JSC::DebuggerScope::Iterator::get): Deleted.
(JSC::DebuggerScope::Iterator::operator++): Deleted.
(JSC::DebuggerScope::Iterator::operator==): Deleted.
(JSC::DebuggerScope::Iterator::operator!=): Deleted.
(JSC::DebuggerScope::isValid): Deleted.
(JSC::DebuggerScope::jsScope): Deleted.
(JSC::DebuggerScope::begin): Deleted.
(JSC::DebuggerScope::end): Deleted.
* inspector/JSJavaScriptCallFrame.cpp:
(Inspector::JSJavaScriptCallFrame::scopeType):
(Inspector::JSJavaScriptCallFrame::scopeChain):
* inspector/JavaScriptCallFrame.h:
(Inspector::JavaScriptCallFrame::scopeChain):
* inspector/ScriptDebugServer.cpp:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::debuggerScopeStructure): Deleted.
* runtime/JSObject.h:
(JSC::JSObject::isWithScope): Deleted.
* runtime/JSScope.h:
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:

Source/WebCore:

* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::attachDebugger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Do not initialize g_type in WebProcessMain::platformInitialize()
g.czajkowski@samsung.com [Sat, 9 Aug 2014 02:37:31 +0000 (02:37 +0000)]
[EFL] Do not initialize g_type in WebProcessMain::platformInitialize()
https://bugs.webkit.org/show_bug.cgi?id=135700

Reviewed by Gyuyoung Kim.

Inspired by r171788.
Glib since 2.36 itself initializes g_type_init.

* WebProcess/efl/WebProcessMainEfl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnbreak webkitpy unit tests by checking for the existence of the image diff template
simon.fraser@apple.com [Sat, 9 Aug 2014 01:14:52 +0000 (01:14 +0000)]
Unbreak webkitpy unit tests by checking for the existence of the image diff template
file before trying to open it (as the tests do for results.html).

* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.write_image_diff_files):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix for 32-bit.
timothy_horton@apple.com [Sat, 9 Aug 2014 01:12:28 +0000 (01:12 +0000)]
Build fix for 32-bit.

* UIProcess/mac/ServicesController.mm:
(WebKit::ServicesController::ServicesController):
Don't dynamically refresh services in 32-bit apps. It's not possible
to write a 32-bit app with the Modern API, so this doesn't matter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoLoad the layout test result image diff HTML from a file, rather than having it inline...
simon.fraser@apple.com [Sat, 9 Aug 2014 00:23:38 +0000 (00:23 +0000)]
Load the layout test result image diff HTML from a file, rather than having it inline in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=135780

Reviewed by Dan Bates.

Tools:

Pull the HTML for the image diff file into a separate file, for easier hackability.

* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.write_image_diff_files):

LayoutTests:

Add image-diff-template.html and expected result (crazy, but this is what we do
for results.html too).

* fast/harness/image-diff-template-expected.txt: Added.
* fast/harness/image-diff-template.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement long mouse press over links. Part of 135257 - Add long mouse press gesture.
commit-queue@webkit.org [Sat, 9 Aug 2014 00:00:04 +0000 (00:00 +0000)]
Implement long mouse press over links. Part of 135257 - Add long mouse press gesture.
https://bugs.webkit.org/show_bug.cgi?id=135476

Patch by Peyton Randolph <prandolph@apple.com> on 2014-08-08
Reviewed by Tim Horton.

* page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear): Clear long press state.
(WebCore::EventHandler::handleMousePressEvent): Start the long-press if the mouse press is a left
mouse press over a link.
(WebCore::EventHandler::eventMayStartDrag): We cannot start a drag if we've recognized a long press.
(WebCore::EventHandler::handleMouseReleaseEvent):
If we didn't recognize a long press, cancel the long press.
(WebCore::EventHandler::beginTrackingPotentialLongMousePress):
Begin the long mouse press by kicking off a timer. If the timer fires before the long press is
cancelled, the long press is recognized.
(WebCore::EventHandler::recognizeLongMousePress): Added. Trigger the long-press and disable other
actions like dragging.
(WebCore::EventHandler::cancelTrackingPotentialLongMousePress): Added. Cancel the long press by
clearing related state.
(WebCore::EventHandler::clearLongMousePressState): Added. Clear long press state.
(WebCore::EventHandler::handleLongMousePressMouseMovedEvent): Added. Cancel the long press if
the mouse moves outside a specified hysteresis interval.
(WebCore::EventHandler::handleMouseMoveEvent): Ask handleLongMousePressMouseMovedEvent whether to
return early and not update hovers, cursors, drags, etc.
(WebCore::EventHandler::dragHysteresisExceeded): Factor out the hysteresis bounds check into
mouseHysteresisExceeded().
(WebCore::EventHandler::handleDrag): Cancel long press upon starting drag.
(WebCore::EventHandler::mouseHysteresisExceeded): Added. General hysteresis function that takes an
arbitrary mouse movement threshold. Factored out from dragHysteresisExceeded.
* page/EventHandler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[mac] Dynamically update serviceability when the set of services changes
timothy_horton@apple.com [Fri, 8 Aug 2014 23:27:25 +0000 (23:27 +0000)]
[mac] Dynamically update serviceability when the set of services changes
https://bugs.webkit.org/show_bug.cgi?id=135738
<rdar://problem/17533459>

Reviewed by Brady Eidson.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
Adopt the new universal refreshExistingServices.

(WebKit::WebContext::refreshExistingServices): Deleted.
* UIProcess/WebContext.h:
Remove WebContext::refreshExistingServices; there's no need for it.

* UIProcess/mac/ServicesController.h:
* UIProcess/mac/ServicesController.mm:
Fix the build with only public headers by including NSSharingService.h itself.
Place the NSSharingServicePicker (Details) category outside the #ifdef.
Forward-declare and possibly import NSExtension SPI.

(WebKit::ServicesController::ServicesController):
Register a callback to be notified whenever the set of services changes.
When this occurs, call refreshExistingServices. We let refreshExistingServices
coalesce updates because these notifications can come in small batches.

(WebKit::ServicesController::refreshExistingServices):
Dispatch changes in service availability to all processes in all contexts.

* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
Adjust the referenced rdar:// and call ServicesController::refreshExistingServices
instead of the now-removed WebContext:: variant. We can't remove this
yet because our services state can still be stale because NSServiceSharingPicker
can still sometimes lie about the current service state immediately after a change occurs;
once that is fixed, we should get rid of this as well as the refresh in Web Process creation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2] Scrolling does not work inside nested frames
simon.fraser@apple.com [Fri, 8 Aug 2014 23:24:02 +0000 (23:24 +0000)]
[WK2] Scrolling does not work inside nested frames
https://bugs.webkit.org/show_bug.cgi?id=135775
<rdar://problem/17959896>

Reviewed by Tim Horton.

Source/WebCore:

r169733 added an "isMainFrame" check in AsyncScrollingCoordinator::frameViewNonFastScrollableRegionChanged.
However we have to rebuild the non-fast-scrollable region when any subframe changes,
even a deeply nested one. So always rebuild it, starting from the root frame.

Fixes scrolling on nested framesets like http://www.opengl.org/sdk/docs/man3/.

Test: platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-nested-frame-scrollability.html

* page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::frameViewNonFastScrollableRegionChanged):

LayoutTests:

Nested frameset test that dumps the scrolling tree.

* platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-nested-frame-scrollability-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-nested-frame-scrollability.html: Added.
* platform/mac-wk2/tiled-drawing/scrolling/frames/resources/frameset-frame.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClients that request the selection services menu after WebKit2 will get one with...
timothy_horton@apple.com [Fri, 8 Aug 2014 23:15:55 +0000 (23:15 +0000)]
Clients that request the selection services menu after WebKit2 will get one with different metrics than otherwise
https://bugs.webkit.org/show_bug.cgi?id=135765
<rdar://problem/17962180>

Reviewed by Brady Eidson.

* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
The menu is cached between clients, but we make adjustments to it.
We should copy it before adjusting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Refactor getExcludedIntervals since only one LineSegment is ever returned
bjonesbe@adobe.com [Fri, 8 Aug 2014 21:12:06 +0000 (21:12 +0000)]
[CSS Shapes] Refactor getExcludedIntervals since only one LineSegment is ever returned
https://bugs.webkit.org/show_bug.cgi?id=135757

Reviewed by Zoltan Horvath.

The interface for getExcludedIntervals was designed when shape-inside
was still a thing, and it was possible for a line in a shape to have
multiple segments. shape-outside can only have one segment per line,
so this refactors the code to simplify and reflect that reality.

No new test, no behavior change.

* rendering/shapes/BoxShape.cpp:
(WebCore::BoxShape::getExcludedInterval):
(WebCore::BoxShape::getExcludedIntervals): Deleted.
* rendering/shapes/BoxShape.h:
* rendering/shapes/PolygonShape.cpp:
(WebCore::PolygonShape::getExcludedInterval):
(WebCore::PolygonShape::getExcludedIntervals): Deleted.
* rendering/shapes/PolygonShape.h:
* rendering/shapes/RasterShape.cpp:
(WebCore::RasterShape::getExcludedInterval):
(WebCore::RasterShape::getExcludedIntervals): Deleted.
* rendering/shapes/RasterShape.h:
* rendering/shapes/RectangleShape.cpp:
(WebCore::RectangleShape::getExcludedInterval):
(WebCore::RectangleShape::getExcludedIntervals): Deleted.
* rendering/shapes/RectangleShape.h:
* rendering/shapes/Shape.h:
(WebCore::LineSegment::LineSegment):
* rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::logicalLeftOffset):
(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):
(WebCore::ShapeOutsideInfo::computeSegmentsForLine): Deleted.
* rendering/shapes/ShapeOutsideInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: add debugging flag to InspectorTest for unbuffered logging to stderr
burg@cs.washington.edu [Fri, 8 Aug 2014 20:21:59 +0000 (20:21 +0000)]
Web Inspector: add debugging flag to InspectorTest for unbuffered logging to stderr
https://bugs.webkit.org/show_bug.cgi?id=135726

Reviewed by Timothy Hatcher.

Source/WebCore:

Add a bridge so that InspectorTest can synchronously log to the console.

* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::unbufferedLog): Added.
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:

Source/WebInspectorUI:

Added a flag for debugging inspector tests which will synchronously log messages.
This avoids failure modes that prevent logging from being added to the test page.

* UserInterface/Base/Test.js:
(InspectorTest.debugLog):
(InspectorTest.addResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGardening: fix Windows build after r172259.
mark.lam@apple.com [Fri, 8 Aug 2014 20:04:19 +0000 (20:04 +0000)]
Gardening: fix Windows build after r172259.

Not reviewed.

* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::addMockSpeechInputResult): Deleted.
(TestRunner::setMockSpeechInputDumpRect): Deleted.
(TestRunner::startSpeechInput): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: When Switching Recordings, the UI datagrids do not update to match...
commit-queue@webkit.org [Fri, 8 Aug 2014 20:00:39 +0000 (20:00 +0000)]
Web Inspector: When Switching Recordings, the UI datagrids do not update to match selection
https://bugs.webkit.org/show_bug.cgi?id=135764

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-08-08
Reviewed by Timothy Hatcher.

* UserInterface/Views/TimelineSidebarPanel.js:
When changing the activeContentView trigger an update of the datagrids by
re-applying the filter, which will be different now that the view is different.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdjustments to CueBox CSS Width calculations.
roger_fong@apple.com [Fri, 8 Aug 2014 19:53:52 +0000 (19:53 +0000)]
Adjustments to CueBox CSS Width calculations.
https://bugs.webkit.org/show_bug.cgi?id=135759
<rdar://problem/17954473>.

Reviewed by Eric Carlson.

This is a followup patch that addresses some of the test failures caused by r172224.
These tests were skipped in r172253.
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateActiveCuesFontSize):
Tell the cue boxes that they need to be updated when the font size specified in the user prefs changes.

Cap width to 100%, calculate max-width in percentages instead of pixels.
* html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):
* html/track/VTTCue.cpp:
(WebCore::VTTCueBox::applyCSSProperties):

(WebCore::VTTCue::setFontSize):
Remove some unnecessary code that doesn't actually work.
Make sure to tell cuebox that it needs to be updated.

* TestExpectations:
Unskip tests media/track/track-cue-rendering-horizontal.html and media/track/track-cue-rendering-rtl.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Uncaught Exception opening Web Inspector - TypeError: undefined is...
commit-queue@webkit.org [Fri, 8 Aug 2014 19:33:46 +0000 (19:33 +0000)]
Web Inspector: Uncaught Exception opening Web Inspector - TypeError: undefined is not a function - candidateObjectCookie.every
https://bugs.webkit.org/show_bug.cgi?id=135762

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-08-08
Reviewed by Timothy Hatcher.

* UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.treeElementMatchesCookie):
Fix a typo, the wrong object was being used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agomake clean does not work in OpenSource, fails in WebKitLibraries
commit-queue@webkit.org [Fri, 8 Aug 2014 19:20:19 +0000 (19:20 +0000)]
make clean does not work in OpenSource, fails in WebKitLibraries
https://bugs.webkit.org/show_bug.cgi?id=135734

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-08-08
Reviewed by David Kilzer.

Tools:

* Scripts/copy-webkitlibraries-to-product-directory:
Add a --clean switch that removes possible WebKitSystemInterface
and LLVM libraries and headers that may have been copied to the
product directory.

WebKitLibraries:

* Makefile:
Add a "clean" target that runs copy-webkitlibraries-to-product-dir
with the new --clean switch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClean up image subsampling code, make it less iOS-specific
simon.fraser@apple.com [Fri, 8 Aug 2014 18:55:51 +0000 (18:55 +0000)]
Clean up image subsampling code, make it less iOS-specific
https://bugs.webkit.org/show_bug.cgi?id=134916

Reviewed by Dean Jackson.

Compile the image subsampling code on both Mac and iOS, and make it more platform
neutral in general. Add a setting to allow it to be enabled on Mac for testing.

The most significant changes are in ImageSourceCG and BitmapImageCG. CG's ImageSource
is no longer stateful with respect to subsampling; its functions take a SubsamplingLevel
when appropriate. CG's BitmapImage now determines which level of subsampling to use
for a given frame, storing the subsampling level in the frame data. It can replace
an aggressively subsampled frame with a less subsampled frame if necessary.

To reduce the chances of subsampling affecting rendering, BitmapImage::size() now
always returns the non-subsampled size; subsampling is strictly internal to BitmapImage.
BitmapImage::draw() takes care of scaling the srcRect for subsampled images.

iOS had a code path that enabled caching of frame metadata in BitmapImage without
actually decoding the frame; make this cross-platform.

Fix a couple of issues in the original pathc: remove a log, and ImageSource::allowSubsamplingOfFrameAtIndex()
return false.

* WebCore.exp.in: Changed signature for GraphicsContext::drawNativeImage().
* WebCore.xcodeproj/project.pbxproj: Added ImageSource.cpp, which is not built
for Cocoa but useful for reference.
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageSizeForRenderer): Remove iOS-specific subsampling code.
(WebCore::CachedImage::createImage): Call setAllowSubsampling() on the image if we
can get to Settings (m_loader is null for image documents).
(WebCore::CachedImage::currentFrameKnownToBeOpaque): This forced decode always
caused creation of the non-subsampled image, so remove it. There's no reason to
eagerly decode the frame here.
* loader/cache/CachedImage.h: Fix comment.
* page/Settings.cpp: Add defaultImageSubsamplingEnabled, true for iOS and false for Mac.
* page/Settings.in: Added imageSubsamplingEnabled.
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage): Init some more things. Default m_allowSubsampling to
true for iOS to catch images created in code paths where we can't get to Settings.
(WebCore::BitmapImage::haveFrameAtIndex): Handy helper.
(WebCore::BitmapImage::cacheFrame): Now takes the subsampling level and whether to cache
just metadata, or also the frame.
(WebCore::BitmapImage::didDecodeProperties): No need to store originalSize.
(WebCore::BitmapImage::updateSize): When we get the size for the first time, call
determineMinimumSubsamplingLevel() to choose a reasonable subsampling level which takes
platform-specific limits into account.
(WebCore::BitmapImage::dataChanged): Comment.
(WebCore::BitmapImage::ensureFrameIsCached): Take ImageFrameCaching into account.
(WebCore::BitmapImage::frameAtIndex): Choose a subsampling level given the scale,
then determine if we can use the currently cached frame, or whether we should resample.
(WebCore::BitmapImage::frameIsCompleteAtIndex): Caching m_isComplete is now done when caching
frame metadata.
(WebCore::BitmapImage::frameDurationAtIndex):
(WebCore::BitmapImage::frameHasAlphaAtIndex): The 'true' return is the safe return value.
(WebCore::BitmapImage::frameOrientationAtIndex): Caching m_orientation is now done when caching
frame metadata.
(WebCore::BitmapImage::cacheFrameInfo): Deleted.
(WebCore::BitmapImage::originalSize): Deleted.
(WebCore::BitmapImage::originalSizeRespectingOrientation): Deleted.
(WebCore::BitmapImage::currentFrameSize): Deleted.
(WebCore::BitmapImage::ensureFrameInfoIsCached): Deleted.
* platform/graphics/BitmapImage.h:
(WebCore::FrameData::FrameData):
* platform/graphics/GraphicsContext.h: No need to pass a scale param now.
* platform/graphics/ImageSource.cpp: Non-Cocoa changes.
(WebCore::ImageSource::subsamplingLevelForScale):
(WebCore::ImageSource::allowSubsamplingOfFrameAtIndex):
(WebCore::ImageSource::size):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameBytesAtIndex):
* platform/graphics/ImageSource.h: No longer stores subsampling state.
(WebCore::ImageSource::isSubsampled): Deleted.
* platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::determineMinimumSubsamplingLevel):
* platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::FrameData::clear):
(WebCore::BitmapImage::BitmapImage): Init more members.
(WebCore::BitmapImage::determineMinimumSubsamplingLevel): Choose a minimum subsampling
level for the platform (subsample until the image area falls under a threshold).
(WebCore::BitmapImage::checkForSolidColor): Don't bother decoding frames if the image
is not 1x1. Also take care not to decode a non-subsampled image.
(WebCore::BitmapImage::draw): The actual bug fix is here; remove logic that
computed srcRectForCurrentFrame from m_size and m_originalSize; for some callers
srcRect was computed using the pre-subsampled size, and for others it was the subsampled size.
Instead, scale srcRect by mapping between the non-subsampled size, and the size of the CGImageRef
which is affected by subsampling.
(WebCore::BitmapImage::copyUnscaledFrameAtIndex):
* platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage): Remove #ifdeffed code.
(WebCore::GraphicsContext3D::paintToCanvas):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage): No more weird scaling!
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::draw):
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::ImageSource):
(WebCore::createImageSourceOptions): Helper that always returns a new CFDictionaryRef.
(WebCore::imageSourceOptions): If not subsampling, return the cached CFDictionaryRef, otherwise
make a new options dict and return it.
(WebCore::ImageSource::subsamplingLevelForScale): Helper that returns a subsampling level
between 0 and 3 given a scale.
(WebCore::ImageSource::isSizeAvailable): SkipMetadata is a default value for the param now.
(WebCore::ImageSource::allowSubsamplingOfFrameAtIndex): We turn off subsampling for progressive
JPEGs because of a bug, so need this to know if a frame should be subsampled.
(WebCore::ImageSource::frameSizeAtIndex): The looping to find a subsampling level is now in BitmapImageCG.
(WebCore::ImageSource::orientationAtIndex):
(WebCore::ImageSource::size): Always use a subsampling level of 0 for size().
(WebCore::ImageSource::getHotSpot):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::createFrameAtIndex): The caller mapped a scale to a level.
(WebCore::ImageSource::frameDurationAtIndex):
(WebCore::ImageSource::frameBytesAtIndex):
(WebCore::ImageSource::imageSourceOptions): Deleted.
(WebCore::ImageSource::originalSize): Deleted.
* platform/graphics/mac/ImageMac.mm:
(WebCore::BitmapImage::invalidatePlatformData): 0 -> nullptr
* platform/graphics/wince/ImageWinCE.cpp:
(WebCore::BitmapImage::determineMinimumSubsamplingLevel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoProgress towards using CMake on Mac.
achristensen@apple.com [Fri, 8 Aug 2014 18:13:54 +0000 (18:13 +0000)]
Progress towards using CMake on Mac.
https://bugs.webkit.org/show_bug.cgi?id=135662

Reviewed by Laszlo Gombos.

* CMakeLists.txt:
.:

Mavericks has a flex version of "flex 2.5.35 Apple(flex-31)" which CMake doesn't like on Mac.
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:
Added features that are needed by the Mac port.
* Source/cmake/OptionsMac.cmake:
Enable CSS_IMAGE_SET based on FeatureDefines.h.
Disable the FTL with CMake for now.
* Source/cmake/OptionsEFL.cmake:
* Source/cmake/OptionsGTK.cmake:
Enable subpixel layout to not conflict with FeatureDefines.h

Source/WebCore:

Added necessary include directories and idls.
* PlatformEfl.cmake:
* PlatformGTK.cmake:
Moved ImageSource.cpp and image-decoders to platform CMake files because they are not used on mac.
* PlatformMac.cmake:
Corrected some sources.
* config.h:
Added workaround for not using prefix headers with CMake.
* platform/graphics/ANGLEWebKitBridge.h:
Compile fix to find ANGLE headers while using CMake.
* platform/graphics/FormatConverter.h:
* platform/mac/NSScrollerImpDetails.h:
Removed unnecessary config.h includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUndo some erroneous changes to the Xcode scheme files from r172259.
simon.fraser@apple.com [Fri, 8 Aug 2014 17:41:24 +0000 (17:41 +0000)]
Undo some erroneous changes to the Xcode scheme files from r172259.

* WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme:
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoServices overlay dropdown is often in the wrong place with zoomed pages or horizontal...
timothy_horton@apple.com [Fri, 8 Aug 2014 16:19:37 +0000 (16:19 +0000)]
Services overlay dropdown is often in the wrong place with zoomed pages or horizontal scrolling
https://bugs.webkit.org/show_bug.cgi?id=135755
<rdar://problem/17907752>

Reviewed by Brady Eidson.

* WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::establishHoveredTelephoneHighlight):
(WebKit::ServicesOverlayController::maybeCreateSelectionHighlight):
DDHighlightCreateWithRectsInVisibleRectWithStyleAndDirection adjusts the
location of the button based on the visible rect, trying to keep the button visible.

We're handing it the wrong visible rect, though, not taking scrolling into account.

This leads to pages that scroll horizontally showing the button on the left
even if there's space for it on the right, or sometimes not showing it at all.

Instead, provide the actual main FrameView visible rect; the same coordinate
space that the highlight rects are provided in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdditional items added to selection services menus are misaligned
timothy_horton@apple.com [Fri, 8 Aug 2014 16:18:46 +0000 (16:18 +0000)]
Additional items added to selection services menus are misaligned
https://bugs.webkit.org/show_bug.cgi?id=135747
<rdar://problem/17933167>

Reviewed by Brady Eidson.

* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
Use NSSharingServicePickerStyleRollover for the rollover image services menu;
use NSSharingServicePickerStyleTextSelection for the selection services menu.

Set NSMenu's showsStateColumn to YES for selection services menus, so that
other items added to the menu line up correctly.

Remove an unncessary .get()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Remove unnecessary ewk_private.h includes
g.czajkowski@samsung.com [Fri, 8 Aug 2014 12:57:19 +0000 (12:57 +0000)]
[EFL] Remove unnecessary ewk_private.h includes
https://bugs.webkit.org/show_bug.cgi?id=135753

Reviewed by Gyuyoung Kim.

Neither the below file uses the functionality from ewk_private.h.

* UIProcess/API/efl/ewk_context.cpp:
* UIProcess/API/efl/ewk_context_menu_item.cpp:
* UIProcess/API/efl/ewk_cookie_manager.cpp:
* UIProcess/API/efl/ewk_navigation_policy_decision.cpp:
* UIProcess/API/efl/ewk_popup_menu_item.cpp:
* UIProcess/API/efl/ewk_view.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Do not use GtkWindow:resize-grip-visible with recent GTK+ versions
carlosgc@webkit.org [Fri, 8 Aug 2014 09:31:41 +0000 (09:31 +0000)]
[GTK] Do not use GtkWindow:resize-grip-visible with recent GTK+ versions
https://bugs.webkit.org/show_bug.cgi?id=135699

Reviewed by Philippe Normand.

Resize grips support have been removed from GTK+ since 3.13.4, the
API has been deprecated and does nothing.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseSetToplevelOnScreenWindow):
(resizeWebKitWebViewBaseFromAllocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CMake] Drop the required version of CMake down to 2.8.8
zandobersek@gmail.com [Fri, 8 Aug 2014 08:17:01 +0000 (08:17 +0000)]
[CMake] Drop the required version of CMake down to 2.8.8
https://bugs.webkit.org/show_bug.cgi?id=135713

Reviewed by Alex Christensen.

.:

* CMakeLists.txt: Require CMake 2.8.8.

Source/WebCore:

* CMakeLists.txt: Use set_property() to set INCLUDE_DIRECTORIES for
the ANGLESupport library. This avoids using target_include_directories()
which requires CMake 2.8.11.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agocommit-log-message has extra blank line at the top of pre-populated message
commit-queue@webkit.org [Fri, 8 Aug 2014 08:09:08 +0000 (08:09 +0000)]
commit-log-message has extra blank line at the top of pre-populated message
https://bugs.webkit.org/show_bug.cgi?id=135744

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-08-08
Reviewed by Csaba Osztrogon√°c.

Do not add a blank leading line in single ChangeLog commit messages.

* Scripts/commit-log-editor:
(createCommitMessage):
* Scripts/webkitpy/common/checkout/checkout_unittest.py:
(test_commit_message_for_one_reviewed_changelog):
(test_commit_message_for_one_rollout_changelog):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GStreamer][1.4] Caps negotiation failure in playback pipeline
philn@webkit.org [Fri, 8 Aug 2014 07:46:15 +0000 (07:46 +0000)]
[GStreamer][1.4] Caps negotiation failure in playback pipeline
https://bugs.webkit.org/show_bug.cgi?id=135607

Reviewed by Carlos Garcia Campos.

Ensure the capsfilters used in front of interleave negotiate their
caps correctly with audioconvert which requires audio buffers with
interleaved layout.

No new tests, existing webaudio tests will cover this change once
we bump our JHBuild moduleset to GStreamer 1.4.

* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(getGStreamerMonoAudioCaps):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r172094): timeline views are blank after reloading in some situations
burg@cs.washington.edu [Fri, 8 Aug 2014 07:05:47 +0000 (07:05 +0000)]
REGRESSION(r172094): timeline views are blank after reloading in some situations
https://bugs.webkit.org/show_bug.cgi?id=135742

Reviewed by Timothy Hatcher.

Address various bugs that cause the wrong timeline content views to appear when
starting a recording by reloading the inspected page. Fix other small oversights
that were encountered in the sidebar-based view state restoration code.

* UserInterface/Models/TimelineRecording.js:
(WebInspector.TimelineRecording.prototype.saveIdentityToCookie): Add a dummy implementation.

* UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.treeElementMatchesCookie):
This code erroneously matches any tree element whose represented object's
saveIdentityToCookie function produces an empty cookie.

* UserInterface/Views/TimelineContentView.js:
(WebInspector.TimelineContentView.prototype._showTimelineView): Add an assertion
that will find mismatches between represented objects of the TimelineContentView
and TimelineViews.

* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype.restoreStateFromCookie): Don't call
the superclass's implementation, since we do not want to perform a relaxed match
against any of our tree elements. The only thing that can be restored across reopen
is a selected timeline tree element, which is already handled by this override.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Fix accidental always true comparison
commit-queue@webkit.org [Fri, 8 Aug 2014 06:57:32 +0000 (06:57 +0000)]
Web Inspector: Fix accidental always true comparison
https://bugs.webkit.org/show_bug.cgi?id=135741

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-08-07
Reviewed by Timothy Hatcher.

Remove accidental "!" that would always cause this comparison to succeed.

* UserInterface/Views/OverviewTimelineView.js:
(WebInspector.OverviewTimelineView.prototype.updateLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Timeline Filter Bars are not appearing at all
commit-queue@webkit.org [Fri, 8 Aug 2014 06:56:24 +0000 (06:56 +0000)]
Web Inspector: Timeline Filter Bars are not appearing at all
https://bugs.webkit.org/show_bug.cgi?id=135740

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-08-07
Reviewed by Timothy Hatcher.

* UserInterface/Views/TimelineDataGrid.css:
(.data-grid.timeline.has-non-default-filter > .navigation-bar-container):
(.data-grid.timeline > .navigation-bar-container > .navigation-bar):
(body.mac-platform.legacy .data-grid.timeline > .navigation-bar-container > .navigation-bar):
Update the positioning and height for non-legacy because the console is now taller.

* UserInterface/Views/ScopeBar.js:
(WebInspector.ScopeBar.prototype.hasNonDefaultItemSelected):
Helper to know if there is a non-default filter.

* UserInterface/Views/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid.prototype.treeElementMatchesActiveScopeFilters):
(WebInspector.TimelineDataGrid.prototype._scopeBarSelectedItemsDidChange):
Update scope bar visibility. If non-default we want to always show it.

(WebInspector.TimelineDataGrid.prototype._updateScopeBarForcedVisibility):
If there is a non-default filter, force showing the bar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: breakpoints enabled state is not persisted across re-opening the inspector
commit-queue@webkit.org [Fri, 8 Aug 2014 06:53:22 +0000 (06:53 +0000)]
Web Inspector: breakpoints enabled state is not persisted across re-opening the inspector
https://bugs.webkit.org/show_bug.cgi?id=135745

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-08-07
Reviewed by Timothy Hatcher.

When restoring breakpoints when the inspector is initializing, do not
let setting these breakpoints automatically enable breakpoints. We should
respect the setting in this case.

* UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager.restoreBreakpointsSoon):
(WebInspector.DebuggerManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r172291.
commit-queue@webkit.org [Fri, 8 Aug 2014 06:50:29 +0000 (06:50 +0000)]
Unreviewed, rolling out r172291.
https://bugs.webkit.org/show_bug.cgi?id=135748

broke background-attachment-fixed with backround-size-contain
(e.g. iCloud.com) (Requested by thorton on #webkit).

Reverted changeset:

"Fixed backgrounds don't paint in blurred inset areas"
https://bugs.webkit.org/show_bug.cgi?id=135712
http://trac.webkit.org/changeset/172291

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Combine and minify Esprima
timothy@apple.com [Fri, 8 Aug 2014 06:48:52 +0000 (06:48 +0000)]
Web Inspector: Combine and minify Esprima
https://bugs.webkit.org/show_bug.cgi?id=135728

Reviewed by Joseph Pecoraro.

* Scripts/combine-resources.pl:
* Scripts/copy-user-interface-resources.pl:
* UserInterface/External/Esprima/LICENSE: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSubpixel rendering: Border thickness and length flooring can result empty borders
zalan@apple.com [Fri, 8 Aug 2014 03:51:44 +0000 (03:51 +0000)]
Subpixel rendering: Border thickness and length flooring can result empty borders
due to losing precision during multiple float <-> LayoutUnit conversions.
https://bugs.webkit.org/show_bug.cgi?id=135686

Reviewed by Simon Fraser.

The combination of losing precision and flooring the border thickness/length to avoid
empty border rect drawing can lead to false positives of missing borders.
This patch moves empty border checking right before painting where we can safely use round
instead of floor.

Source/WebCore:

Tests: fast/borders/hidpi-border-width-flooring.html

* rendering/RenderObject.cpp:
(WebCore::drawBorderLineRect):
(WebCore::drawBorderLine):
(WebCore::RenderObject::drawLineForBoxSide):

LayoutTests:

* fast/borders/hidpi-border-width-flooring-expected.html: Added.
* fast/borders/hidpi-border-width-flooring.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Build break with mpegts since r167025
ryuan.choi@samsung.com [Fri, 8 Aug 2014 02:40:07 +0000 (02:40 +0000)]
[EFL] Build break with mpegts since r167025
https://bugs.webkit.org/show_bug.cgi?id=135737

Reviewed by Gyuyoung Kim.

* PlatformEfl.cmake: Added includes and libraries about MPEG-TS

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCreate a more generic way for VMEntryScope to notify those interested that it will...
commit-queue@webkit.org [Fri, 8 Aug 2014 02:29:22 +0000 (02:29 +0000)]
Create a more generic way for VMEntryScope to notify those interested that it will be destroyed
https://bugs.webkit.org/show_bug.cgi?id=135358

Patch by Saam Barati <sbarati@apple.com> on 2014-08-07
Reviewed by Geoffrey Garen.

When VMEntryScope is destroyed, and it has a flag set indicating that the
Debugger needs to recompile all functions, it calls Debugger::recompileAllJSFunctions.
This flag is only used by Debugger to have VMEntryScope notify it when the
Debugger is safe to recompile all functions. This patch will substitute this
Debugger-specific recompilation flag with a list of callbacks that are notified
when the outermost VMEntryScope dies. This creates a general purpose interface
for being notified when the VM stops executing code via the event of the outermost
VMEntryScope dying.

* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* runtime/VMEntryScope.cpp:
(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::setEntryScopeDidPopListener):
(JSC::VMEntryScope::~VMEntryScope):
* runtime/VMEntryScope.h:
(JSC::VMEntryScope::setRecompilationNeeded): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Services with UI] Action menu does not appear if selection includes both text and...
timothy_horton@apple.com [Fri, 8 Aug 2014 01:17:52 +0000 (01:17 +0000)]
[Services with UI] Action menu does not appear if selection includes both text and an image
https://bugs.webkit.org/show_bug.cgi?id=135731
<rdar://problem/17837491>

Reviewed by Dean Jackson.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
Initialize hasRichContentServices with the cached value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of SCRIPTED_SPEECH
bfulgham@apple.com [Fri, 8 Aug 2014 00:38:01 +0000 (00:38 +0000)]
Get rid of SCRIPTED_SPEECH
https://bugs.webkit.org/show_bug.cgi?id=135729

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-08-07
Reviewed by Brent Fulgham.

* fast/events/constructors/speech-recognition-error-constructor-expected.txt: Removed.
* fast/events/constructors/speech-recognition-error-constructor.html: Removed.
* fast/events/constructors/speech-recognition-event-constructor-expected.txt: Removed.
* fast/events/constructors/speech-recognition-event-constructor.html: Removed.
* fast/speech/scripted/basics-expected.txt: Removed.
* fast/speech/scripted/basics.html: Removed.
* fast/speech/scripted/navigate-away-expected.txt: Removed.
* fast/speech/scripted/navigate-away-iframe-expected.txt: Removed.
* fast/speech/scripted/navigate-away-iframe.html: Removed.
* fast/speech/scripted/navigate-away.html: Removed.
* fast/speech/scripted/speechgrammar-basics-expected.txt: Removed.
* fast/speech/scripted/speechgrammar-basics.html: Removed.
* fast/speech/scripted/speechrecognition-basics-expected.txt: Removed.
* fast/speech/scripted/speechrecognition-basics.html: Removed.
* fast/speech/scripted/speechrecognition-errors-expected.txt: Removed.
* fast/speech/scripted/speechrecognition-errors.html: Removed.
* fast/speech/scripted/speechrecognitionerror-basics-expected.txt: Removed.
* fast/speech/scripted/speechrecognitionerror-basics.html: Removed.
* fast/speech/scripted/start-exception-expected.txt: Removed.
* fast/speech/scripted/start-exception.html: Removed.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/gtk/fast/speech/speech-bidi-rendering-expected.txt: Removed.
* platform/mac/TestExpectations:
* platform/mac/fast/speech/speech-bidi-rendering-expected.png: Removed.
* platform/mac/fast/speech/speech-bidi-rendering-expected.txt: Removed.
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHTML <sub> and <sup> elements do not work in some 64-bit builds
simon.fraser@apple.com [Fri, 8 Aug 2014 00:35:33 +0000 (00:35 +0000)]
HTML <sub> and <sup> elements do not work in some 64-bit builds
https://bugs.webkit.org/show_bug.cgi?id=135736

Reviewed by Tim Horton.

RootInlineBox::verticalPositionForBox() had some implicit conversions between
LayoutUnit and int that caused overflow, and resulted in different comparison
behavior with an int constant in different architectures, since overflow behavior
is undefined.

Specifically, VerticalPositionCache was written in terms of ints with a special
0x80000000 "not found" value. However, 0x80000000 was being assigned to
a LayoutUnit, which multiplies by 64 causing overflow. The result was then
compared again with 0x80000000 which could pass or fail depending on overflow
behavior.

Fix by converting VerticalPositionCache to use LayoutUnits, and to have a bool
return value with a result out param, instead of a special return value.

Not easily testable, since the difference does not show in DRT output,
and a ref test would be flakey.

* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::ascentAndDescentForBox):
* rendering/VerticalPositionCache.h:
(WebCore::VerticalPositionCache::get):
(WebCore::VerticalPositionCache::set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of SCRIPTED_SPEECH
bfulgham@apple.com [Fri, 8 Aug 2014 00:32:36 +0000 (00:32 +0000)]
Get rid of SCRIPTED_SPEECH
https://bugs.webkit.org/show_bug.cgi?id=135729

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-08-07
Reviewed by Brent Fulgham.

../JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

../WebCore:

* Configurations/FeatureDefines.xcconfig:
* Modules/speech/SpeechGrammar.cpp: Removed.
* Modules/speech/SpeechGrammar.h: Removed.
* Modules/speech/SpeechGrammar.idl: Removed.
* Modules/speech/SpeechGrammarList.cpp: Removed.
* Modules/speech/SpeechGrammarList.h: Removed.
* Modules/speech/SpeechGrammarList.idl: Removed.
* Modules/speech/SpeechRecognition.cpp: Removed.
* Modules/speech/SpeechRecognition.h: Removed.
* Modules/speech/SpeechRecognition.idl: Removed.
* Modules/speech/SpeechRecognitionAlternative.cpp: Removed.
* Modules/speech/SpeechRecognitionAlternative.h: Removed.
* Modules/speech/SpeechRecognitionAlternative.idl: Removed.
* Modules/speech/SpeechRecognitionClient.h: Removed.
* Modules/speech/SpeechRecognitionController.cpp: Removed.
* Modules/speech/SpeechRecognitionController.h: Removed.
* Modules/speech/SpeechRecognitionError.cpp: Removed.
* Modules/speech/SpeechRecognitionError.h: Removed.
* Modules/speech/SpeechRecognitionError.idl: Removed.
* Modules/speech/SpeechRecognitionEvent.cpp: Removed.
* Modules/speech/SpeechRecognitionEvent.h: Removed.
* Modules/speech/SpeechRecognitionEvent.idl: Removed.
* Modules/speech/SpeechRecognitionResult.cpp: Removed.
* Modules/speech/SpeechRecognitionResult.h: Removed.
* Modules/speech/SpeechRecognitionResult.idl: Removed.
* Modules/speech/SpeechRecognitionResultList.cpp: Removed.
* Modules/speech/SpeechRecognitionResultList.h: Removed.
* Modules/speech/SpeechRecognitionResultList.idl: Removed.
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setScriptedSpeechEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::scriptedSpeechEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionErrorEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEventEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarListEnabled): Deleted.
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): Deleted.
* bindings/js/JSDictionary.h:
* dom/EventNames.in:
* dom/EventTargetFactory.in:

../WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

../WebKit2:

* Configurations/FeatureDefines.xcconfig:

../WTF:

* wtf/FeatureDefines.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix regression where tree outline keyboard navigation is broken.
timothy@apple.com [Fri, 8 Aug 2014 00:15:52 +0000 (00:15 +0000)]
Fix regression where tree outline keyboard navigation is broken.

https://bugs.webkit.org/show_bug.cgi?id=135718

Reviewed by Joseph Pecoraro.

* UserInterface/Views/TreeOutline.js:
(TreeElement.prototype.revealed): Fix the check for currentAncestor.hidden.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Filter bar text and icon are positioned too low and tight
timothy@apple.com [Fri, 8 Aug 2014 00:08:17 +0000 (00:08 +0000)]
Web Inspector: Filter bar text and icon are positioned too low and tight
https://bugs.webkit.org/show_bug.cgi?id=135723

Reviewed by Joseph Pecoraro.

* UserInterface/Views/FilterBar.css:
(.filter-bar > input[type="search"]):
(.filter-bar > input[type="search"]::-webkit-search-decoration):
* UserInterface/Views/SearchBar.css:
(.search-bar > input[type="search"]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] Unreviewed gardening.
bfulgham@apple.com [Thu, 7 Aug 2014 23:43:08 +0000 (23:43 +0000)]
[Win] Unreviewed gardening.

Have 'Assemble Build Logs' step work properly for DebugSuffix target
(both 32-bit and 64-bit).

* win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] Unreviewed gardening.
bfulgham@apple.com [Thu, 7 Aug 2014 23:35:33 +0000 (23:35 +0000)]
[Win] Unreviewed gardening.

Don't build the JSFileException and JSFileReaderSync files in 64-bit; they are already part
of DerivedObjects.cpp.

* WebCore.vcxproj/WebCore.vcxproj: Exclude JSFileException and JSFileReaderSync to avoid
multiple definitions of symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agosetCustomSwipeViews inside didChangeBackForwardList client callback is ignored
timothy_horton@apple.com [Thu, 7 Aug 2014 23:29:31 +0000 (23:29 +0000)]
setCustomSwipeViews inside didChangeBackForwardList client callback is ignored
https://bugs.webkit.org/show_bug.cgi?id=135633
<rdar://problem/17926507>

Reviewed by Sam Weinig.

* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeBackForwardList):
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::clearCustomSwipeViews): Deleted.
* UIProcess/mac/PageClientImpl.h:
* UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::clearCustomSwipeViews): Deleted.
WebKit clears the set of custom swipe views at the end of WebPageProxy::didChangeBackForwardList,
*after* calling into the client. This means that if the client wants to setCustomSwipeViews in
didChangeBackForwardList, it won't be respected.

Since there's only one client of this SPI, let's just stop clearing the list of custom swipe
views in WebKit and leave that totally up to the client.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Services with UI] Action menu does not appear if selection includes both text and...
enrica@apple.com [Thu, 7 Aug 2014 23:08:38 +0000 (23:08 +0000)]
[Services with UI] Action menu does not appear if selection includes both text and an image.
https://bugs.webkit.org/show_bug.cgi?id=135731
<rdar://problem/17837491>

Reviewed by Brady Eidson.

Source/WebCore:

When collecting selection rects via SelectionRectGatherer we should also note if the selection
contains non text elements. This way the Notifier class can send that information to ServicesOverlayController
to properly handle the highlight for the service.

* editing/SelectionRectGatherer.cpp:
(WebCore::SelectionRectGatherer::SelectionRectGatherer):
(WebCore::SelectionRectGatherer::Notifier::~Notifier):
(WebCore::SelectionRectGatherer::clearAndCreateNotifier):
* editing/SelectionRectGatherer.h:
(WebCore::SelectionRectGatherer::setTextOnly):
(WebCore::SelectionRectGatherer::isTextOnly):
* page/EditorClient.h:
(WebCore::EditorClient::selectionRectsDidChange):
* rendering/RenderView.cpp:
(WebCore::RenderView::applySubtreeSelection):

Source/WebKit2:

Adding a new setting to ServicesController to communicate to the WebProcess if
there are services installed that can handle a combination of text and images.
This way ServicesOverlayController can decide if it appropriate to show the hightlight
based on the type of selection (text only or non text only). This information is retrieved
when the selection rects are collected by SelectionGatherer and used by
SelectionGatherer::Notifier to communicate the selection change.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
* Shared/WebProcessCreationParameters.h:
* UIProcess/mac/ServicesController.h:
(WebKit::ServicesController::hasRichContentServices):
* UIProcess/mac/ServicesController.mm:
(WebKit::ServicesController::ServicesController):
(WebKit::ServicesController::refreshExistingServices):
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::selectionRectsDidChange):
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebPage/ServicesOverlayController.h:
* WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::ServicesOverlayController):
(WebKit::ServicesOverlayController::selectionRectsDidChange):
(WebKit::ServicesOverlayController::drawSelectionHighlight):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::setEnabledServices):
* WebProcess/WebProcess.h:
(WebKit::WebProcess::hasRichContentServices):
* WebProcess/WebProcess.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] Unreviewed gardening.
bfulgham@apple.com [Thu, 7 Aug 2014 23:02:08 +0000 (23:02 +0000)]
[Win] Unreviewed gardening.

* WebKit.vcxproj/WebKit/WebKitCommon.props: Add $(DebugSuffix) to libraries so
that the DebugSuffix target works properly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] Unreviewed gardening.
bfulgham@apple.com [Thu, 7 Aug 2014 22:47:33 +0000 (22:47 +0000)]
[Win] Unreviewed gardening.

DebugSuffix targets should use our debugsuffix property sheet, and
will therefore build to the proper output location with the proper
suffix tags.

Also, we must use the WebKit_Libraries environment variable, not a set
of relative paths to the property sheets.

* ANGLE.vcxproj/libEGL.vcxproj: Use 'debugsuffix.props' sheet.
* ANGLE.vcxproj/libGLESv2.vcxproj: Ditto.
* ANGLE.vcxproj/preprocessor.vcxproj: Ditto.
* ANGLE.vcxproj/translator_common.vcxproj: Ditto.
* ANGLE.vcxproj/translator_glsl.vcxproj: Ditto.
* ANGLE.vcxproj/translator_hlsl.vcxproj: Ditto.
* ANGLE.vcxproj/libEGLCommon.props: Use $(DebugSuffix) endings.
* ANGLE.vcxproj/libGLESv2Common.props: Ditto.
* ANGLE.vcxproj/translatorCommon.props: Output to 'lib' folder,
not 'bin' folder. These are libraries!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Parental Controls content filter is mistakenly enabled for HTTP responses
aestes@apple.com [Thu, 7 Aug 2014 22:27:18 +0000 (22:27 +0000)]
[Mac] Parental Controls content filter is mistakenly enabled for HTTP responses
https://bugs.webkit.org/show_bug.cgi?id=135730

Reviewed by Brady Eidson.

On the Mac, the WebFilterEvaluator (Parental Controls) content filter should only be enabled for HTTPS
responses. During iOS upstreaming we mistakenly enabled it for HTTP responses as well, and this causes HTTP
responses to be filtered twice -- once by the Parental Controls HTTP proxy and once by WebCore. Revert to the
pre-upstreaming behavior and only enable the content filter for HTTPS responses.

No new tests. Content filtering is not testable from WebKit.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived): Passed the response to ContentFilter::canHandleResponse().
* platform/ContentFilter.h:
* platform/mac/ContentFilterMac.mm:
(WebCore::ContentFilter::canHandleResponse): Renamed from isEnabled(). Checks the response's scheme on Mac to
determine whether WebFilterEvaluator should be used.
(WebCore::ContentFilter::isEnabled): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFixed backgrounds don't paint in blurred inset areas
bdakin@apple.com [Thu, 7 Aug 2014 22:25:11 +0000 (22:25 +0000)]
Fixed backgrounds don't paint in blurred inset areas
https://bugs.webkit.org/show_bug.cgi?id=135712

Reviewed by Simon Fraser.

Source/WebCore:

Background geometry calculations for fixed background need to use the larger
visible rect.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

LayoutTests:

Unfortunately for this test to be valid in WK2, it needs to be run from the
platform/mac-wk2/tiled-drawing directory so that tiled drawing is enabled. So
there are two copies of the test so that we can get coverage for WK1 and WK2.
* platform/mac-wk1/TestExpectations:
* platform/mac-wk1/fast: Added.
* platform/mac-wk1/fast/backgrounds: Added.
* platform/mac-wk1/fast/backgrounds/resources: Added.
* platform/mac-wk1/fast/backgrounds/resources/green.png: Added.
* platform/mac-wk1/fast/backgrounds/top-content-inset-fixed-attachment-expected.html: Added.
* platform/mac-wk1/fast/backgrounds/top-content-inset-fixed-attachment.html: Added.
* platform/mac-wk2/tiled-drawing/resources/green.png: Added.
* platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-expected.html: Added.
* platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment.html: Added.
* platform/mac/fast/backgrounds/resources: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Dashboard error and warning icons should be filled when enabled
timothy@apple.com [Thu, 7 Aug 2014 22:21:25 +0000 (22:21 +0000)]
Web Inspector: Dashboard error and warning icons should be filled when enabled
https://bugs.webkit.org/show_bug.cgi?id=135725

Reviewed by Joseph Pecoraro.

* UserInterface/Images/ErrorsEnabled.svg:
* UserInterface/Images/IssuesEnabled.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EME][Mac] Error codes returned by AVSampleBufferDisplayLayer are negative; clip...
jer.noble@apple.com [Thu, 7 Aug 2014 22:17:50 +0000 (22:17 +0000)]
[EME][Mac] Error codes returned by AVSampleBufferDisplayLayer are negative; clip when passed to JavaScript as doubles.
https://bugs.webkit.org/show_bug.cgi?id=135710

Reviewed by Brent Fulgham.

Return the absolute value of the error codes returned by AVSampleBufferDisplayLayer, so that the conversion from
unsigned -> double does not clip due to the (converted) value being greater than 2^53.

* platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::layerDidReceiveError):
(WebCore::CDMSessionMediaSourceAVFObjC::rendererDidReceiveError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Dashboard contents shift when window changes active state
commit-queue@webkit.org [Thu, 7 Aug 2014 22:14:44 +0000 (22:14 +0000)]
Web Inspector: Dashboard contents shift when window changes active state
https://bugs.webkit.org/show_bug.cgi?id=135724

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-08-07
Reviewed by Timothy Hatcher.

The container was getting a 1px border when inactive and none when active.
Give it a transparent border when active so contents don't change size.

* UserInterface/Views/DashboardContainerView.css:
(.toolbar .dashboard-container):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Fix several warnings of doxygen
ryuan.choi@samsung.com [Thu, 7 Aug 2014 22:11:50 +0000 (22:11 +0000)]
[EFL] Fix several warnings of doxygen
https://bugs.webkit.org/show_bug.cgi?id=135643

Reviewed by Gyuyoung Kim.

* UIProcess/API/efl/ewk_context_menu_item.h: Removed /info which is not doxygen keyword and unnecessary to the user.
* UIProcess/API/efl/ewk_cookie_manager.h: Fixed parameter name.
* UIProcess/API/efl/ewk_form_submission_request.h: Removed # from Eina_List because doxygen may not know the EFL structures.
* UIProcess/API/efl/ewk_page_group.h: Fixed to match with parameter name.
* UIProcess/API/efl/ewk_settings.h: Fixed wrong keyword and parameter name.
* UIProcess/API/efl/ewk_text_checker.h: Ditto.
* UIProcess/API/efl/ewk_view.h:
- Used escape string for the tag.
- Used @code, @endcode for media query example.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSpeculateInt32Operand is sometimes used in a 64-bit context, which has undefined...
mhahnenberg@apple.com [Thu, 7 Aug 2014 22:08:19 +0000 (22:08 +0000)]
SpeculateInt32Operand is sometimes used in a 64-bit context, which has undefined behavior
https://bugs.webkit.org/show_bug.cgi?id=135722

Reviewed by Filip Pizlo.

We should be using SpeculateStrictInt32Operand instead.

* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSometimes Gmail cannot load messages, particularly on refresh ("...the application...
dbates@webkit.org [Thu, 7 Aug 2014 21:39:19 +0000 (21:39 +0000)]
Sometimes Gmail cannot load messages, particularly on refresh ("...the application ran into an unexpected error...")
https://bugs.webkit.org/show_bug.cgi?id=135688
<rdar://problem/17886686>

Reviewed by Alexey Proskuryakov.

Fixes an issue where gmail.com may fail to load the list of messages. In particular, a SQLTransactionCallback
function may not be executed and hence Gmail will not display the list of messages and
will subsequently display an error message.

When a WebKit client defers loading of a page (e.g. -[WebView setDefersCallbacks:YES]), WebCore
may still load the main resource, say if substitute data is available for it, and defer executing
tasks, such as a SQLTransactionCallback function, by appending such tasks to the end of the list
of pending tasks for the associated Document. This list of pending tasks is never processed when
a client subsequently allows loading (e.g. -[WebView setDefersCallbacks:NO])). Therefore, we never
execute a SQLTransactionCallback function that was deferred.

Ideally WebCore would defer loading of substitute data when a WebKit client requests that loading
be deferred and hence a SQLTransactionCallback function would be deferred as a consequence of the
lack of JavaScript script execution (since substitute data wasn't loaded and hence any JavaScript
script contained in the substitute data that initiates a SQL transaction isn't executed). For now,
it's sufficient to only defer executing tasks when either there are existing pending tasks or the
page defers loading and active DOM objects in the document are suspended (e.g. Document::suspendActiveDOMObjects() was called).

* dom/Document.cpp:
(WebCore::Document::postTask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agohttp/tests/security/cross-frame-access-enumeration.html fails after FTLOPT merge.
mark.lam@apple.com [Thu, 7 Aug 2014 21:18:16 +0000 (21:18 +0000)]
http/tests/security/cross-frame-access-enumeration.html fails after FTLOPT merge.
<https://webkit.org/b/135708>

Reviewed by Mark Hahnenberg.

* TestExpectations:
* http/tests/security/cross-frame-access-enumeration-expected.txt:
- re-baselined the test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix reference to missing CloseTimeline.svg image.
timothy@apple.com [Thu, 7 Aug 2014 21:10:22 +0000 (21:10 +0000)]
Fix reference to missing CloseTimeline.svg image.

Rubber-stamped by Joseph Pecoraro.

* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.createTimelineTreeElement): Use CloseLarge.svg instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] Unreviewed build fix.
bfulgham@apple.com [Thu, 7 Aug 2014 21:09:51 +0000 (21:09 +0000)]
[Win] Unreviewed build fix.

Add a WebInspectorUI.proj file for use with MSBuild utility.

* WebInspectorUI.vcxproj/WebInspectorUI.proj: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of INPUT_SPEECH
benjamin@webkit.org [Thu, 7 Aug 2014 21:04:11 +0000 (21:04 +0000)]
Get rid of INPUT_SPEECH
https://bugs.webkit.org/show_bug.cgi?id=135672

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-08-07
Reviewed by Andreas Kling.

.:

* Source/cmake/OptionsMac.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* Modules/speech/SpeechSynthesis.cpp:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setSpeechInputEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::speechInputEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitSpeechEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitGrammarEnabled): Deleted.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* css/html.css:
(input::-webkit-input-speech-button): Deleted.
* dom/Element.h:
(WebCore::Element::isInputFieldSpeechButtonElement): Deleted.
* dom/EventNames.in:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::speechButtonElement): Deleted.
(WebCore::HTMLInputElement::isSpeechEnabled): Deleted.
* html/HTMLInputElement.h:
* html/HTMLInputElement.idl:
* html/InputType.cpp:
(WebCore::InputType::shouldRespectListAttribute):
(WebCore::InputType::shouldRespectSpeechAttribute): Deleted.
* html/InputType.h:
(WebCore::InputType::speechButtonElement): Deleted.
* html/NumberInputType.cpp:
(WebCore::NumberInputType::shouldRespectSpeechAttribute): Deleted.
* html/NumberInputType.h:
* html/PasswordInputType.cpp:
(WebCore::PasswordInputType::shouldRespectSpeechAttribute): Deleted.
* html/PasswordInputType.h:
* html/SearchInputType.cpp:
(WebCore::SearchInputType::shouldRespectSpeechAttribute): Deleted.
* html/SearchInputType.h:
* html/TelephoneInputType.cpp:
(WebCore::TelephoneInputType::shouldRespectSpeechAttribute): Deleted.
* html/TelephoneInputType.h:
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::needsContainer):
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::destroyShadowSubtree):
(WebCore::TextFieldInputType::speechButtonElement): Deleted.
* html/TextFieldInputType.h:
* html/TextInputType.cpp:
(WebCore::TextInputType::shouldRespectSpeechAttribute): Deleted.
* html/TextInputType.h:
* html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): Deleted.
(WebCore::InputFieldSpeechButtonElement::~InputFieldSpeechButtonElement): Deleted.
(WebCore::InputFieldSpeechButtonElement::create): Deleted.
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler): Deleted.
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents): Deleted.
(WebCore::InputFieldSpeechButtonElement::setState): Deleted.
(WebCore::InputFieldSpeechButtonElement::speechInput): Deleted.
(WebCore::InputFieldSpeechButtonElement::didCompleteRecording): Deleted.
(WebCore::InputFieldSpeechButtonElement::didCompleteRecognition): Deleted.
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult): Deleted.
(WebCore::InputFieldSpeechButtonElement::willAttachRenderers): Deleted.
(WebCore::InputFieldSpeechButtonElement::willDetachRenderers): Deleted.
(WebCore::InputFieldSpeechButtonElement::startSpeechInput): Deleted.
(WebCore::InputFieldSpeechButtonElement::stopSpeechInput): Deleted.
* html/shadow/TextControlInnerElements.h:
(WebCore::toInputFieldSpeechButtonElement): Deleted.
* page/SpeechInput.cpp: Removed.
* page/SpeechInput.h: Removed.
* page/SpeechInputClient.h: Removed.
* page/SpeechInputEvent.cpp: Removed.
* page/SpeechInputEvent.h: Removed.
* page/SpeechInputEvent.idl: Removed.
* page/SpeechInputListener.h: Removed.
* page/SpeechInputResult.cpp: Removed.
* page/SpeechInputResult.h: Removed.
* page/SpeechInputResult.idl: Removed.
* page/SpeechInputResultList.cpp: Removed.
* page/SpeechInputResultList.h: Removed.
* page/SpeechInputResultList.idl: Removed.
* platform/ThemeTypes.h:
* rendering/RenderInputSpeech.cpp: Removed.
* rendering/RenderInputSpeech.h: Removed.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore::RenderTheme::adjustInputFieldSpeechButtonStyle): Deleted.
(WebCore::RenderTheme::paintInputFieldSpeechButton): Deleted.
* rendering/RenderTheme.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):

Source/WebInspectorUI:

* UserInterface/Models/CSSKeywordCompletions.js:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:
* PlatformGTK.cmake:

Source/WTF:

* wtf/FeatureDefines.h:

Tools:

* DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
(addMockSpeechInputResultCallback): Deleted.
(setMockSpeechInputDumpRectCallback): Deleted.
* DumpRenderTree/TestRunner.h:
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::addMockSpeechInputResult): Deleted.
(TestRunner::setMockSpeechInputDumpRect): Deleted.
(TestRunner::startSpeechInput): Deleted.

LayoutTests:

* fast/forms/input-user-modify.html:
* fast/speech/bubble-position-expected.txt: Removed.
* fast/speech/bubble-position-scrolled-expected.txt: Removed.
* fast/speech/bubble-position-scrolled.html: Removed.
* fast/speech/bubble-position.html: Removed.
* fast/speech/change-focus-expected.txt: Removed.
* fast/speech/change-focus.html: Removed.
* fast/speech/input-appearance-numberandspeech.html: Removed.
* fast/speech/input-appearance-searchandspeech.html: Removed.
* fast/speech/input-appearance-speechbutton.html: Removed.
* fast/speech/input-onspeechchange-event-expected.txt: Removed.
* fast/speech/input-onspeechchange-event.html: Removed.
* fast/speech/input-ontextinput-event-expected.txt: Removed.
* fast/speech/input-ontextinput-event.html: Removed.
* fast/speech/input-readonly-and-disabled-expected.txt: Removed.
* fast/speech/input-readonly-and-disabled.html: Removed.
* fast/speech/input-text-language-tag-expected.txt: Removed.
* fast/speech/input-text-language-tag.html: Removed.
* fast/speech/input-text-speechbutton-expected.txt: Removed.
* fast/speech/input-text-speechbutton.html: Removed.
* fast/speech/input-text-speechstart-expected.txt: Removed.
* fast/speech/input-text-speechstart.html: Removed.
* fast/speech/intrinsic-input-width-with-speech-border-padding-expected.txt: Removed.
* fast/speech/intrinsic-input-width-with-speech-border-padding.html: Removed.
* fast/speech/speech-bidi-rendering.html: Removed.
* fast/speech/speech-button-ignore-generated-events-expected.txt: Removed.
* fast/speech/speech-button-ignore-generated-events.html: Removed.
* fast/speech/speech-input-result-list-not-enough-arguments-expected.txt: Removed.
* fast/speech/speech-input-result-list-not-enough-arguments.html: Removed.
* fast/speech/speech-input-scripting-expected.txt: Removed.
* fast/speech/speech-input-scripting.html: Removed.
* fast/speech/speech-style-on-non-speech-elements-expected.txt: Removed.
* fast/speech/speech-style-on-non-speech-elements.html: Removed.
* platform/gtk/fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
* platform/gtk/fast/speech/input-appearance-speechbutton-expected.txt: Removed.
* platform/ios-sim/fast/speech/input-appearance-numberandspeech-expected.txt: Removed.
* platform/ios-sim/fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
* platform/ios-sim/fast/speech/input-appearance-speechbutton-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCreate UTF-8 string from in-band VTT cues
eric.carlson@apple.com [Thu, 7 Aug 2014 21:01:20 +0000 (21:01 +0000)]
Create UTF-8 string from in-band VTT cues
https://bugs.webkit.org/show_bug.cgi?id=135716

Reviewed by Brent Fulgham.

Tests will be added in https://bugs.webkit.org/show_bug.cgi?id=135717.

* platform/graphics/ISOVTTCue.cpp:
(WebCore::ISOBox::peekString): Call String::fromUTF8 because we know that VTT is always
    UTF-8.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGardening: Mark some tests as failing to green the bots.
mark.lam@apple.com [Thu, 7 Aug 2014 20:56:30 +0000 (20:56 +0000)]
Gardening: Mark some tests as failing to green the bots.
<https://webkit.org/b/135720>

Not reviewed.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Dragging selection window when mouse goes out of window bounds does...
joepeck@webkit.org [Thu, 7 Aug 2014 20:50:45 +0000 (20:50 +0000)]
Web Inspector: Dragging selection window when mouse goes out of window bounds does not behave as expected
https://bugs.webkit.org/show_bug.cgi?id=135372

Reviewed by Timothy Hatcher.

Constrain move selection window dragging to the ruler bounds
based on the mouse down position on the drag window.

* UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler.prototype._handleMouseDown):
(WebInspector.TimelineRuler.prototype._handleMouseMove):
(WebInspector.TimelineRuler.prototype._handleMouseUp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDisable implicit animations on video layer.
jeremyj-wk@apple.com [Thu, 7 Aug 2014 20:41:23 +0000 (20:41 +0000)]
Disable implicit animations on video layer.
https://bugs.webkit.org/show_bug.cgi?id=135679

Reviewed by Eric Carlson.

Disable implicit animations on AVPlayerLayer except when setting fullscreen frame.
This prevents unwanted animations.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer): disable implicit animations
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenFrame): allow implicit animations while changing fullscreen frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172244 268f45cc-cd09-0410-ab3c-d52691b4dbfc