WebKit-https.git
9 years ago2010-11-04 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 6 Nov 2010 21:19:59 +0000 (21:19 +0000)]
2010-11-04  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Bug 46335 - Add EditingStyle
        https://bugs.webkit.org/show_bug.cgi?id=46335

        Added EditingStyle to WebCore/editing.  This class is intended to encapsulate getPropertiesNotIn, removeNonEditingProperties,
        editingStyleAtPosition, and prepareEditingStyleToApplyAt in ApplyStyleCommand.cpp once deployed everywhere.
        Deployed it in typing styles.

        No new tests are added since this is a refactoring in progress.

        * CMakeLists.txt: Added EditingStyle.cpp
        * GNUmakefile.am: Added EditingStyle.cpp and EditingStyle.h
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphs): Calls editingStyleIncludingTypingStyle.
        (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Uses EditingStyle.
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::saveTypingStyleState): Ditto.
        (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Ditto.
        * editing/DeleteSelectionCommand.h:
        * editing/EditingStyle.cpp: Added.
        (WebCore::editingStyleFromComputedStyle): Added.
        (WebCore::EditingStyle::EditingStyle): Added.
        (WebCore::EditingStyle::init): Added; a clone of ApplyStyleCommand::editingStyleAtPosition.
        (WebCore::EditingStyle::removeTextFillAndStrokeColorsIfNeeded): Extracted from init.
        (WebCore::EditingStyle::replaceFontSizeByKeywordIfPossible): Extracted from init.
        (WebCore::EditingStyle::isEmpty): Added.
        (WebCore::EditingStyle::setStyle): Added.
        (WebCore::EditingStyle::clear): Added.
        (WebCore::EditingStyle::removeBlockProperties): Added.
        (WebCore::EditingStyle::prepareToApplyAt): Added.
        (WebCore::editingStyleIncludingTypingStyle): Added.
        * editing/EditingStyle.h: Added.
        (WebCore::EditingStyle::create): Added.
        (WebCore::EditingStyle::style): Added.
        * editing/RemoveFormatCommand.cpp:
        (WebCore::RemoveFormatCommand::doApply): Uses EditingStyle.
        * editing/SelectionController.h:
        (WebCore::SelectionController::typingStyle): Uses EditingStyle.
        (WebCore::SelectionController::clearTypingStyle): Uses EditingStyle.
        (WebCore::SelectionController::setTypingStyle): Uses EditingStyle.
        * rendering/style/RenderStyle.h: Added EditingStyle as a friend.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Update Qt specific expected files after r71467.
ossy@webkit.org [Sat, 6 Nov 2010 08:33:27 +0000 (08:33 +0000)]
Unreviewed. Update Qt specific expected files after r71467.

* platform/qt/fast/blockflow/background-horizontal-bt-expected.checksum:
* platform/qt/fast/blockflow/background-horizontal-bt-expected.png:
* platform/qt/fast/blockflow/background-horizontal-bt-expected.txt:
* platform/qt/fast/blockflow/background-vertical-lr-expected.checksum:
* platform/qt/fast/blockflow/background-vertical-lr-expected.png:
* platform/qt/fast/blockflow/background-vertical-lr-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Alexey Proskuryakov <ap@apple.com>
ap@apple.com [Sat, 6 Nov 2010 06:13:17 +0000 (06:13 +0000)]
2010-11-05  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=49100
        ASSERT([self window]) fails in -[WebBaseNetscapePluginView restartTimers]

        * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView restartTimers]):
        Removed the assertion. Multiple callers provide no guarantee that the plug-in is still alive
        (see bug comments), and there seems to be no harm in executing this function in that case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
commit-queue@webkit.org [Sat, 6 Nov 2010 05:52:23 +0000 (05:52 +0000)]
2010-11-05  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Link with target name set does not work correctly
        https://bugs.webkit.org/show_bug.cgi?id=48865

        When a new page is created with a name (target=myFrame), the new
        mainFrame could not be found because they where not stored in the
        same PageGroup. As PageGroup are not exposed externally so the
        simpliest solution is to use a global page group name. This also fixes
        issue with visited link coloration across pages. After this change the
        private function webkit_web_view_set_group_name() was no longer used
        so it was removed completly.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::closeWindowSoon):
        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=47237
hyatt@apple.com [Sat, 6 Nov 2010 05:49:57 +0000 (05:49 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=47237

Reviewed by Dan Bernstein and Simon Fraser.

Make selection work with vertical text.  This patch fixes a bug in the computation of lineTop.  For lines
with positive leading, lineTop was incorrectly including the top leading.  Since the flipping of lines
for "lr" and "bt" writing modes involved flipping using lineTop and lineBottom, an incorrect lineTop meant
that those modes were mis-rendering.  This is why the Japanese "lr" text examples have the first line smushed
too far against the border.

Fixing lineTop to no longer incorrectly include top leading has implications for editing.  I ended up
rewriting positionForPoint to exactly match selection, since that seemed to be the most intuitive
behavior.  I got rid of the verticalClickFudgeFactor and now just use selectionTop and selectionBottom
instead of lineTop and lineBottom.  I am pretty sure the code used selectionTop in a previous incarnation
anyway and that I moved away from it when I implemented lineTop and lineBottom.  The code then grew
more complicated from people trying to work with lineTop and lineBottom, but going back to selectionTop
and selectionBottom is the right behavior I think.  One editing test has been updated after this change
(editing/selection/after-line-break.html), and one DOM test has been changed to not hit test past the
bottom of a line (fast/dom/Document/CaretRangeFromPoint/basic.html).

I patched selection painting of InlineTextBoxes so that the leading going up to the next line box is used
for "lr" and "bt" modes instead of the previous box.  This makes sense for English text, but we may want
a different policy for Japanese text eventually (possibly just splitting the difference instead).  Leaving it
this way for now, and we can collect feedback on the design.

I rewrote all of the selection gap painting code to be writing-mode aware.  During the course of rewriting this
code I noticed a bug in the logicalLeftSelectionOffset and logicalRightSelectionOffset functions where there
was a coordinate space mismatch on a comparison.  Fixing this improves the repaint/selection-clear.html test.

Added new tests in fast/blockflow/.

WebCore:

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionBottom):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
* rendering/InlineTextBox.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::paintSelection):
(WebCore::clipOutPositionedObjects):
(WebCore::blockDirectionOffset):
(WebCore::inlineDirectionOffset):
(WebCore::RenderBlock::logicalRectToPhysicalRect):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::blockSelectionGaps):
(WebCore::RenderBlock::blockSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionOffset):
(WebCore::RenderBlock::logicalRightSelectionOffset):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::flipForWritingMode):
* rendering/RenderBox.h:
(WebCore::RenderBox::logicalBottom):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::lineSelectionGap):
(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::selectionBottom):
* rendering/RootInlineBox.h:

LayoutTests:

* editing/selection/after-line-break-expected.txt:
* fast/blockflow/japanese-lr-selection.html: Added.
* fast/blockflow/japanese-rl-selection.html: Added.
* fast/dom/Document/CaretRangeFromPoint/basic.html:
* platform/mac/fast/blockflow/background-horizontal-bt-expected.checksum:
* platform/mac/fast/blockflow/background-horizontal-bt-expected.png:
* platform/mac/fast/blockflow/background-horizontal-bt-expected.txt:
* platform/mac/fast/blockflow/background-vertical-lr-expected.checksum:
* platform/mac/fast/blockflow/background-vertical-lr-expected.png:
* platform/mac/fast/blockflow/background-vertical-lr-expected.txt:
* platform/mac/fast/blockflow/border-image-horizontal-bt-expected.checksum:
* platform/mac/fast/blockflow/border-image-horizontal-bt-expected.png:
* platform/mac/fast/blockflow/border-image-horizontal-bt-expected.txt:
* platform/mac/fast/blockflow/border-image-vertical-lr-expected.checksum:
* platform/mac/fast/blockflow/border-image-vertical-lr-expected.png:
* platform/mac/fast/blockflow/border-image-vertical-lr-expected.txt:
* platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum:
* platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
* platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
* platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
* platform/mac/fast/blockflow/border-vertical-lr-expected.png:
* platform/mac/fast/blockflow/border-vertical-lr-expected.txt:
* platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
* platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.png:
* platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.txt:
* platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
* platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.png:
* platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
* platform/mac/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
* platform/mac/fast/blockflow/japanese-lr-selection-expected.png: Added.
* platform/mac/fast/blockflow/japanese-lr-selection-expected.txt: Added.
* platform/mac/fast/blockflow/japanese-lr-text-expected.checksum:
* platform/mac/fast/blockflow/japanese-lr-text-expected.png:
* platform/mac/fast/blockflow/japanese-lr-text-expected.txt:
* platform/mac/fast/blockflow/japanese-rl-selection-expected.checksum: Added.
* platform/mac/fast/blockflow/japanese-rl-selection-expected.png: Added.
* platform/mac/fast/blockflow/japanese-rl-selection-expected.txt: Added.
* platform/mac/fast/repaint/selection-clear-expected.checksum:
* platform/mac/fast/repaint/selection-clear-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 6 Nov 2010 05:34:37 +0000 (05:34 +0000)]
2010-11-05  Simon Fraser  <simon.fraser@apple.com>

        Just put things back the way they were. Too many mysterious linker errors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 6 Nov 2010 05:23:23 +0000 (05:23 +0000)]
2010-11-05  Simon Fraser  <simon.fraser@apple.com>

        Undo most of the previous commit since the compiler seems to have trouble
        with an inlined operator++ in debug builds.

        * platform/DeprecatedPtrListImpl.cpp:
        (WebCore::DeprecatedPtrListImplIterator::operator++):
        * platform/DeprecatedPtrListImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 6 Nov 2010 04:55:43 +0000 (04:55 +0000)]
2010-11-05  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt.

        Inline some DeprecatedPtrListImplIterator methods for performance
        https://bugs.webkit.org/show_bug.cgi?id=49124

        This is a ~4% performance improvement on some Peacekeepr "Community" tests.

        * platform/DeprecatedPtrListImpl.cpp:
        * platform/DeprecatedPtrListImpl.h:
        (WebCore::DeprecatedListNode::DeprecatedListNode):
        (WebCore::DeprecatedPtrListImplIterator::current):
        (WebCore::DeprecatedPtrListImplIterator::operator++):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 6 Nov 2010 01:01:18 +0000 (01:01 +0000)]
2010-11-05  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Gray-scale PNGs with color profiles don't decode properly on Chromium Mac
        https://bugs.webkit.org/show_bug.cgi?id=49110

        Test that we decode gray-scale PNGs correctly.  Sadly, this is a pixel
        test.  For ports that run pixel tests, we'll have to grab the pixels
        off the bot.

        * fast/images/gray-scale-png-with-color-profile.html: Added.
        * fast/images/resources/mu.png: Added.
        * platform/mac/fast/images/gray-scale-png-with-color-profile-expected.txt: Added.
2010-11-05  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Gray-scale PNGs with color profiles don't decode properly on Chromium Mac
        https://bugs.webkit.org/show_bug.cgi?id=49110

        Applying the color profile from this PNG was causing the image to
        triple in width.  This seems to be because both the PNG decoder and
        CoreGraphics were trying to expand the gray-scale image to RGB.  To fix
        this issue, I've disabled color profile support for gray-scale PNGs.

        Test: fast/images/gray-scale-png-with-color-profile.html

        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::headerAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Jian Li <jianli@chromium.org>
jianli@chromium.org [Sat, 6 Nov 2010 00:42:21 +0000 (00:42 +0000)]
2010-11-05  Jian Li  <jianli@chromium.org>

        Reviewed by Dmitry Titov.

        Need to check if page is detached in Frame::transferChildFrameToNewDocument to avoid occasional crash
        https://bugs.webkit.org/show_bug.cgi?id=49116

        The fix is to add the check.

        * page/Frame.cpp:
        (WebCore::Frame::transferChildFrameToNewDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPasting large amounts of plain text in a text area is very slow
enrica@apple.com [Sat, 6 Nov 2010 00:14:52 +0000 (00:14 +0000)]
Pasting large amounts of plain text in a text area is very slow
https://bugs.webkit.org/show_bug.cgi?id=49040
<rdar://problem/7640912>

Reviewed by Adele Peterson.

The optimization consists in skipping the ApplyStyle command when
pasting into a text area or into an element that has -webkit-user-modify: read-write-plaintext-only.
The biggest performance hit comes from iterating through
a large number of paragraph when no style change is needed.
A further step will be to improve the paragraph iteration when it
can't be avoided.

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply): Check if the selection
is in a text form control or in an element that has -webkit-user-modify: read-write-plaintext-only
and force no style matching.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Sat, 6 Nov 2010 00:12:07 +0000 (00:12 +0000)]
2010-11-05  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        suspendAnimations/resumeAnimations not present in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=49109

        Got 4 tests out of the Skipped list that now pass

        * platform/mac-wk2/Skipped:
2010-11-05  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        suspendAnimations/resumeAnimations not present in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=49109

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::suspendAnimations):
        (WTR::LayoutTestController::resumeAnimations):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2010-11-05  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        suspendAnimations/resumeAnimations not present in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=49109

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        (WKBundleFrameSuspendAnimations):
        (WKBundleFrameResumeAnimations):
        * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
        * WebProcess/WebPage/WebFrame.cpp:
        (WebKit::WebFrame::suspendAnimations):
        (WebKit::WebFrame::resumeAnimations):
        * WebProcess/WebPage/WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, updating Chromium expectations.
dumi@chromium.org [Fri, 5 Nov 2010 23:01:22 +0000 (23:01 +0000)]
Unreviewed, updating Chromium expectations.

* platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-with-child-crash-expected.txt: Added.
* platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-with-child-crash-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebProcess won't kill itself if UIProcess goes away while WebProcess is spinning
andersca@apple.com [Fri, 5 Nov 2010 22:55:41 +0000 (22:55 +0000)]
WebProcess won't kill itself if UIProcess goes away while WebProcess is spinning
https://bugs.webkit.org/show_bug.cgi?id=49090
<rdar://problem/7834575>

Reviewed by Darin Adler.

* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::connectionDidClose):
Call Client::didCloseOnConnectionWorkQueue.

* Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::Client::didCloseOnConnectionWorkQueue):
Add new client function. Will be called on the connection work queue when the connection is closed.

* Platform/WorkItem.h:
(FunctionWorkItem0::FunctionWorkItem0):
(FunctionWorkItem0::execute):
(WorkItem::create):
Add a new WorkItem subclass that will invoke a C function.

* Platform/WorkQueue.h:
* Platform/mac/WorkQueueMac.cpp:
(WorkQueue::scheduleWorkAfterDelay):
New function which will schedule the given work item to be executed in at least 'delay' seconds.

* Platform/qt/WorkQueueQt.cpp:
(WorkQueue::scheduleWorkAfterDelay):
Add empty stub.

* Platform/win/WorkQueueWin.cpp:
(WorkQueue::scheduleWorkAfterDelay):
Ditto.

* PluginProcess/PluginProcess.h:
Derive from ChildProcess.

* Shared/ChildProcess.cpp: Added.
(WebKit::ChildProcess::ChildProcess):
(WebKit::ChildProcess::~ChildProcess):
(WebKit::watchdogCallback):
Call _exit.

(WebKit::ChildProcess::didCloseOnConnectionWorkQueue):
When the connection is closed, schedule a work item to be run in 10 seconds. If the process hasn't
exited normally by then, we'll exit.

* Shared/ChildProcess.h:
Add new ChildProcess class which is a common base class of WebProcess and PluginProcess and which contains
the watchdog timer logic.

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
Add new files.

* WebProcess/WebProcess.h:
Derive from ChildProcess.

* win/WebKit2.vcproj:
Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 5 Nov 2010 22:47:59 +0000 (22:47 +0000)]
2010-11-05  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by David Levin.

        JSCallbackData::invokeCallback triggers layout from a worker thread
        https://bugs.webkit.org/show_bug.cgi?id=49096

        Fixed the bug by only calling updateStyleForAllDocuments when the context is document in
        JSCallbackData::invokeCallback.

        No new tests are added since many of existing workers tests hit the added assertion in debug builds.

        * bindings/js/JSCallbackData.cpp:
        (WebCore::JSCallbackData::invokeCallback): No longer calls updateStyleForAllDocuments unconditionally.
        * dom/Document.cpp:
        (WebCore::Document::updateStyleIfNeeded): Added ASSERT(isMainThread()).
        (WebCore::Document::updateStyleForAllDocuments): Ditto.
        (WebCore::Document::updateLayout): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIncreased tolerance on test due to variability of timing on the bots
cmarrin@apple.com [Fri, 5 Nov 2010 22:47:56 +0000 (22:47 +0000)]
Increased tolerance on test due to variability of timing on the bots

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Fri, 5 Nov 2010 22:34:00 +0000 (22:34 +0000)]
Unreviewed.

[Qt] animations tests fails which uses suspend/resume
https://bugs.webkit.org/show_bug.cgi?id=43905

* platform/qt/Skipped:
 - animations/suspend-resume-animation-events.html added until fix.
 - animations/stop-animation-on-suspend.html added until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Ilya Sherman <isherman@chromium.org>
commit-queue@webkit.org [Fri, 5 Nov 2010 22:00:54 +0000 (22:00 +0000)]
2010-11-05  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Simon Fraser.

        Querying selection start and end should be const
        https://bugs.webkit.org/show_bug.cgi?id=48786

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::selectionStart):
        (WebCore::RenderTextControl::selectionEnd):
        (WebCore::RenderTextControl::visiblePositionForIndex):
        (WebCore::RenderTextControl::indexForVisiblePosition):
        * rendering/RenderTextControl.h:
2010-11-05  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Simon Fraser.

        Querying selection start and end should be const
        https://bugs.webkit.org/show_bug.cgi?id=48786

        * public/WebInputElement.h:
        * src/WebInputElement.cpp:
        (WebKit::WebInputElement::selectionStart):
        (WebKit::WebInputElement::selectionEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Fri, 5 Nov 2010 21:45:37 +0000 (21:45 +0000)]
2010-11-05  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Move resumeAnimations/suspendAnimations from Frame to AnimationController.
        https://bugs.webkit.org/show_bug.cgi?id=49073

        * src/WebAnimationControllerImpl.cpp:
        (WebKit::WebAnimationControllerImpl::suspendAnimations):
        (WebKit::WebAnimationControllerImpl::resumeAnimations):
2010-11-05  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Move resumeAnimations/suspendAnimations from Frame to AnimationController.
        https://bugs.webkit.org/show_bug.cgi?id=49073

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::suspendAnimations):
        (DumpRenderTreeSupportQt::resumeAnimations):
2010-11-05  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Move resumeAnimations/suspendAnimations from Frame to AnimationController.
        https://bugs.webkit.org/show_bug.cgi?id=49073

        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_suspend_animations):
        (webkit_web_frame_resume_animations):
2010-11-05  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Move resumeAnimations/suspendAnimations from Frame to AnimationController.
        https://bugs.webkit.org/show_bug.cgi?id=49073

        * WebFrame.cpp:
        (WebFrame::suspendAnimations):
        (WebFrame::resumeAnimations):
2010-11-05  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Move resumeAnimations/suspendAnimations from Frame to AnimationController.
        https://bugs.webkit.org/show_bug.cgi?id=49073

        * WebView/WebFrame.mm:
        (-[WebFrame _suspendAnimations]):
        (-[WebFrame _resumeAnimations]):
2010-11-05  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Move resumeAnimations/suspendAnimations from Frame to AnimationController.
        https://bugs.webkit.org/show_bug.cgi?id=49073

        Changed the name of suspendAnimations/resumeAnimations to
        suspendAnimationsInDocument/resumeAnimationsInDocument. These are no
        longer exported, but have the same functionality as before. I then
        added new suspendAnimations/resumeAnimations function which take
        no params and suspend/resume on the frame owning the animation
        controller and all its child frames. These are the functions that
        are now exported. I then changed all the platform specific WebKit
        code to use these functions.

        * WebCore.exp.in:
        * page/Frame.cpp:
        * page/Frame.h:
        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::suspendAnimations):
        (WebCore::AnimationControllerPrivate::resumeAnimations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 5 Nov 2010 21:41:24 +0000 (21:41 +0000)]
2010-11-05  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Ojan Vafai.

        [Chromium] fast/events/stopPropagation-submit.html fails
        https://bugs.webkit.org/show_bug.cgi?id=49078

        The test was failing because of a difference between KURL and GURL in
        how forms that have a data: URL action are handled*. Since the actual
        test was testing something else (that stopPropagation does not prevent
        form submissions), using a real page as the target makes the test
        pass everywhere.

        * FWIW, it looks like GURL is right, per step 15 of section 4.10.22.3
        (Form submission algorithm) of the HTML 5 spec, data URLs used with GET
        should not be mutated; filed bug 49091 about this.

        * fast/events/resources/stopPropagation-submit-target.html: Added.
        * fast/events/stopPropagation-submit.html:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-04 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 5 Nov 2010 20:28:49 +0000 (20:28 +0000)]
2010-11-04  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Need to simulate DEPTH_STENCIL in framebufferRenderbuffer / getFramebufferAttachmentParameter
        https://bugs.webkit.org/show_bug.cgi?id=49020

        * src/WebGraphicsContext3DDefaultImpl.cpp: Remove DEPTH_STENCIL_ATTACHMENT emulation at this level.
2010-11-04  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Need to simulate DEPTH_STENCIL in framebufferRenderbuffer / getFramebufferAttachmentParameter
        https://bugs.webkit.org/show_bug.cgi?id=49020

        * html/canvas/WebGLFramebuffer.cpp:
        (WebCore::WebGLFramebuffer::getAttachment): Return the attached renderbuffer/texture.
        (WebCore::WebGLFramebuffer::isIncomplete): Add an extra parameter deciding whether we should check internal format matching the attachment point or not.
        (WebCore::WebGLFramebuffer::onAccess): Pass extra parameter in isIncomplete.
        * html/canvas/WebGLFramebuffer.h:
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::checkFramebufferStatus): Pass extra parameter in isIncomplete.
        (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Emulate DEPTH_STENCIL_ATTACHMENT; re-attach previously conflicted buffers upon detachment.
        (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Throw an error when conflicted attachments exist.
        (WebCore::WebGLRenderingContext::renderbufferStorage): Map DEPTH_STENCIL to DEPTH24_STENCIL8.
        * platform/graphics/Extensions3D.h: Add DEPTH24_STENCIL8 enum and update the documentation.
        * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
        (WebCore::GraphicsContext3D::framebufferRenderbuffer): Remove emulation code at this level.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 5 Nov 2010 20:27:15 +0000 (20:27 +0000)]
2010-11-05  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed; test_expectations fix.

        Remove three tests that are no longer flaky. Update a comment about a
        test that fails due to V8 differences.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 5 Nov 2010 20:26:45 +0000 (20:26 +0000)]
2010-11-05  Darin Fisher  <darin@chromium.org>

        Pull chromium@65229 to fix the build.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 5 Nov 2010 20:08:50 +0000 (20:08 +0000)]
2010-11-05  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed expectation update for fast/events/context-no-deselect.html.

        Add missing chromium-linux expectations.

        * platform/chromium-linux/fast/events/context-no-deselect-expected.checksum: Added.
        * platform/chromium-linux/fast/events/context-no-deselect-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Chris Guillory <chris.guillory@google.com>
commit-queue@webkit.org [Fri, 5 Nov 2010 19:55:25 +0000 (19:55 +0000)]
2010-11-05  Chris Guillory  <chris.guillory@google.com>

        Reviewed by Chris Fleizach.

        Keep a reference to the scrollbar in accessibility scrollbar.
        https://bugs.webkit.org/show_bug.cgi?id=48896

        * accessibility/AccessibilityScrollbar.h:
        (WebCore::AccessibilityScrollbar::scrollbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 5 Nov 2010 19:42:32 +0000 (19:42 +0000)]
2010-11-05  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Website consistently crashing TOT in JIT::execute() on news.com.au
        https://bugs.webkit.org/show_bug.cgi?id=48954

        The problem here was the strict pass of this conversion was loading the
        this structure into one register but doing the flags check off a different
        register.  This is clearly wrong.  I have been unable to trigger the crash
        with a reduction, but I've added an assertion to the this conversion to
        attempt to make it more readily catchable in future.

        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_convert_this_strict):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::emit_op_convert_this_strict):
        * jit/JITStubs.cpp:
        (JSC::DEFINE_STUB_FUNCTION):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 5 Nov 2010 19:37:44 +0000 (19:37 +0000)]
2010-11-05  Tony Chang  <tony@chromium.org>

        Reviewed by David Levin.

        cleanup style in TestNetscapePlugIn/PluginObject.cpp
        https://bugs.webkit.org/show_bug.cgi?id=49044

        * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
        (getPluginClass):
        (pluginGetProperty):
        (pluginSetProperty):
        (variantToIdentifier):
        (testCallback):
        (getURL):
        (getURLNotify):
        (testInvokeDefault):
        (testGetProperty):
        (testDocumentOpen):
        (testWindowOpen):
        (pluginInvoke):
        (handleCallback):
        (notifyStream):
        * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Chang Shu <chang.shu@nokia.com>
chang.shu@nokia.com [Fri, 5 Nov 2010 19:22:11 +0000 (19:22 +0000)]
2010-11-05  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Antonio Gomes.

        Add support for <select> element in single selection mode. We use space to
        trigger arrow key handling for selection change or spatial navigation.
        https://bugs.webkit.org/show_bug.cgi?id=48937

        * fast/events/spatial-navigation/resources/spatial-navigation-utils.js:
        (doMove):
        * fast/events/spatial-navigation/snav-single-select-expected.txt:
        * fast/events/spatial-navigation/snav-single-select.html:
2010-11-05  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Antonio Gomes.

        Add support for <select> element in single selection mode. We use space to
        trigger arrow key handling for selection change or spatial navigation.
        https://bugs.webkit.org/show_bug.cgi?id=48937

        * dom/SelectElement.cpp:
        (WebCore::isSpatialNavigationEnabled):
        (WebCore::SelectElement::menuListDefaultEventHandler):
        (WebCore::SelectElement::listBoxDefaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 5 Nov 2010 19:02:30 +0000 (19:02 +0000)]
2010-11-05  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        Add QueueStatusServer/__init__.py so others can run the QueueStatusServer tests
        https://bugs.webkit.org/show_bug.cgi?id=49032

        I wrote this file as part of bug 47847, but I forgot to commit it.
        No one else noticed it missing because test-webkitpy knows how
        to recover in the case where it can't import QueueStatusServer
        (which generally occurs due to not having installed the AppEngine SDK).

        * QueueStatusServer/__init__.py: Added.
        * QueueStatusServer/model/workitems_unittest.py:
         - Remove a test which fails.  This was probably landed (by me)
           from my other machine, which since this __init__.py was missing
           I never noticed the failure and landed this invalid test.
           Sadly we can't really test remove_work_item as it depends
           on .key() working.  .key() will throw unless the object
           has already been saved it seems.
           This may be a mis-design in our remove_work_item implementation,
           but for now, just removing the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 5 Nov 2010 18:44:05 +0000 (18:44 +0000)]
2010-11-05  Darin Fisher  <darin@chromium.org>

        Reviewed by Nate Chapin.

        Replace deprecated TargetIsSub{Frame,Resource} with TargetIsSub{frame,resource}.
        https://bugs.webkit.org/show_bug.cgi?id=49074

        * public/WebURLRequest.h:
        * src/FrameLoaderClientImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 5 Nov 2010 18:32:24 +0000 (18:32 +0000)]
2010-11-05  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed expectations update for fast/events/click-count.html; it's no longer slow since r46779 sped it up.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 5 Nov 2010 18:25:55 +0000 (18:25 +0000)]
2010-11-05  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed expectations update for fast/events/option-tab.html; it no longer crashes.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Charlie Reis <creis@chromium.org>
commit-queue@webkit.org [Fri, 5 Nov 2010 18:24:27 +0000 (18:24 +0000)]
2010-11-05  Charlie Reis  <creis@chromium.org>

        Reviewed by Darin Fisher.

        Need to expose HistoryController::previousItem() for Chromium WebKit API.
        https://bugs.webkit.org/show_bug.cgi?id=48809

        * loader/HistoryController.h:
2010-11-05  Charlie Reis  <creis@chromium.org>

        Reviewed by Darin Fisher.

        WebFrame::previousHistoryItem() should return last committed item.
        https://bugs.webkit.org/show_bug.cgi?id=48809

        * src/WebFrameImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement PluginInfoStore::shouldUsePlugin on Windows
aroben@apple.com [Fri, 5 Nov 2010 18:15:26 +0000 (18:15 +0000)]
Implement PluginInfoStore::shouldUsePlugin on Windows

Fixes <http://webkit.org/b/43509> <rdar://problem/8273822> WebKit2
should refuse to load the same plugins that old-WebKit refuses to load

Reviewed by Anders Carlsson.

* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::fileVersion): Helper function to construct a 64-bit file
version from two 32-bit numbers.
(WebKit::PluginInfoStore::getPluginInfo): Ported code from
WebCore::PluginPackage::fetchInfo to get the plugin's version. We now
store it in Plugin::fileVersion.

(WebKit::isOldWindowsMediaPlayerPlugin):
(WebKit::isNewWindowsMediaPlayerPlugin):
Added these helpers. The code came from
WebCore::PluginDatabase::getPluginPathsInDirectories.

(WebKit::PluginInfoStore::shouldUsePlugin): Implemented. The code was
ported from WebCore::PluginDatabase::getPluginPathsInDirectories and
WebCore::PluginPackage::isPluginBlacklisted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOperate on m_plugins directly in PluginInfoStore::shouldUsePlugin
aroben@apple.com [Fri, 5 Nov 2010 18:14:54 +0000 (18:14 +0000)]
Operate on m_plugins directly in PluginInfoStore::shouldUsePlugin

We'll need to operate on m_plugins if we ever want to unload an
already-loaded plugin before loading the new one.

Fixes <http://webkit.org/b/49076> loadedPlugins parameter to
PluginInfoStore::shouldUsePlugin is redundant

Reviewed by Anders Carlsson.

* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::loadPlugin):
* UIProcess/Plugins/PluginInfoStore.h:
* UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
(WebKit::PluginInfoStore::shouldUsePlugin):
* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::shouldUsePlugin):
* UIProcess/Plugins/qt/PluginInfoStoreQt.cpp:
(WebKit::PluginInfoStore::shouldUsePlugin):
* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::PluginInfoStore::shouldUsePlugin):
Removed the loadedPlugins parameter from shouldUsePlugin. The single
implementation (Mac) now uses m_plugins directly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAssertion failure in PluginStream::~PluginStream when running userscripts/user-script...
bweinstein@apple.com [Fri, 5 Nov 2010 18:08:33 +0000 (18:08 +0000)]
Assertion failure in PluginStream::~PluginStream when running userscripts/user-script-plugin-document.html
https://bugs.webkit.org/show_bug.cgi?id=48751
<rdar://problem/8615536>

Reviewed by Anders Carlsson.

WebKit/win:

Always call committedLoad in WebFrameLoaderClient::finishedLoading, even if we have a manual loader. We were
running into a case where we were trying to load an empty plugin document, which uses a manual loader, and
PluginStream::didFinishLoading was never being called. The stream was never being stopped, making us fire
an assert in the PluginStream destructor.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::finishedLoading):

LayoutTests:

Unskip userscripts/user-script-plugin-document.html because it is passing now.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agouserscripts/user-script-*-document.html tests are flaky on Windows
bweinstein@apple.com [Fri, 5 Nov 2010 18:01:50 +0000 (18:01 +0000)]
userscripts/user-script-*-document.html tests are flaky on Windows
https://bugs.webkit.org/show_bug.cgi?id=45980

Reviewed by Eric Carlson.

We can't use counting.mp4 as our video file to create a video document, because on Windows counting.mp4
is opened in Windows Explorer or Quicktime instead of Safari. This bug is being tracked by
<https://bugs.webkit.org/show_bug.cgi?id=25220>.

This patch switches user-script-video-document.html to use silence-loop.mov instead of counting.mp4,
which creates a video document on both Mac and Windows.

* userscripts/resources/counting.mp4: Removed.
* userscripts/resources/silence-loop.mov: Added.
* userscripts/user-script-video-document-expected.txt:
* userscripts/user-script-video-document.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement pluginElementNPObject
andersca@apple.com [Fri, 5 Nov 2010 17:58:18 +0000 (17:58 +0000)]
Implement pluginElementNPObject
https://bugs.webkit.org/show_bug.cgi?id=49077

Reviewed by Adam Roben.

WebKit2:

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::pluginElementNPObject):
Send the GetPluginElementNPObject message.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::getPluginElementNPObject):
Get the plug-in element NPObject and expose it to the other side of the connection.

* WebProcess/Plugins/PluginProxy.messages.in:
Add GetPluginElementNPObject.

LayoutTests:

Remove now passing test.

* platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 5 Nov 2010 17:43:38 +0000 (17:43 +0000)]
2010-11-05  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Crash in ApplyStyleCommand::surroundNodeRangeWithElement
        https://bugs.webkit.org/show_bug.cgi?id=48581

        The crash was caused by a false assertion that we can always recover selection in
        ApplyStyleCommand::removeInlineStyle.  Fixed the crash by removing the assertion
        and adding an early exit to the call site.  Also converted raw pointers to RefPtr
        in surroundNodeRangeWithElement and addInlineStyleIfNeeded.

        Test (non-Mac platforms): editing/style/iframe-onload-crash.html

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyInlineStyle):
        (WebCore::ApplyStyleCommand::removeInlineStyle):
        (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
        (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
        * editing/ApplyStyleCommand.h:
2010-11-04  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Re-enabled editing/style/iframe-onload-crash.html on Chromium, Qt, and Windows platforms.

        * platform/chromium/test_expectations.txt:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement NP_RemoveProperty and NP_Enumerate
andersca@apple.com [Fri, 5 Nov 2010 17:38:40 +0000 (17:38 +0000)]
Implement NP_RemoveProperty and NP_Enumerate
https://bugs.webkit.org/show_bug.cgi?id=49046

Reviewed by Oliver Hunt.

WebKit2:

* Shared/Plugins/NPObjectMessageReceiver.cpp:
(WebKit::NPObjectMessageReceiver::removeProperty):
Call the removeProperty NPClass function.

(WebKit::NPObjectMessageReceiver::enumerate):
Call the enumerate NPClass function.

* Shared/Plugins/NPObjectMessageReceiver.messages.in:
Add RemoveProperty and Enumerate messages.

* Shared/Plugins/NPObjectProxy.cpp:
(WebKit::NPObjectProxy::removeProperty):
Send the RemoveProperty message.

(WebKit::NPObjectProxy::enumerate):
Send the Enumerate message.

(WebKit::NPObjectProxy::NP_RemoveProperty):
Call removeProperty.

(WebKit::NPObjectProxy::NP_Enumerate):
Call enumerate.

LayoutTests:

Remove now passing tests.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 5 Nov 2010 17:35:56 +0000 (17:35 +0000)]
2010-11-05  Zhenyao Mo  <zmo@google.com>

        Unreviewed, update webgl test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 5 Nov 2010 17:25:05 +0000 (17:25 +0000)]
2010-11-05  Zhenyao Mo  <zmo@google.com>

        Unreviewed, update webgl test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for GTK build broken by http://trac.webkit.org/changeset/71424
cmarrin@apple.com [Fri, 5 Nov 2010 17:05:12 +0000 (17:05 +0000)]
Fix for GTK build broken by trac.webkit.org/changeset/71424

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Darin Adler.
ap@apple.com [Fri, 5 Nov 2010 17:02:24 +0000 (17:02 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=49008
        <rdar://problem/7906226> Frequent crashes on mail.yahoo.co.jp

WebCore:
        Instance::m_runtimeObject used to be zeroed out by RuntimeObject destructor. But the
        destructor may not be called immediately - GC first marks an object as dead, and only
        destroys it when its cell is overwritten. So, m_runtimeObject would keep pointing to a dead
        object.

        Functions in JSPluginElementFunctions.cpp put the RuntimeObject on stack for later use,
        but if it's already dead, it can be overwritten before use.

        The solution is of course to use WeakGCPtr, which returns 0 for dead objects.

        * bridge/jsc/BridgeJSC.cpp:
        (JSC::Bindings::Instance::Instance):
        (JSC::Bindings::Instance::~Instance):
        (JSC::Bindings::Instance::createRuntimeObject):
        (JSC::Bindings::Instance::willDestroyRuntimeObject):
        (JSC::Bindings::Instance::willInvalidateRuntimeObject):
        * bridge/jsc/BridgeJSC.h:
        * bridge/runtime_object.cpp:
        (JSC::Bindings::RuntimeObject::~RuntimeObject):
        (JSC::Bindings::RuntimeObject::invalidate):

WebKit:
        Callers of NetscapePluginInstanceProxy::waitForReply() are not prepared to be deleted during
        the call, unless it returns 0. There are two reasons for NetscapePluginInstanceProxy to be
        deleted during wait:
        - plugin crashed;
        - plugin was stopped (e.g. due to a DOM modification performed by another reply that came in
        while waiting).

        We didn't recognize the latter.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::PluginDestroyDeferrer::~PluginDestroyDeferrer):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::waitForReply):
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::didCallPluginFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix failing python tests.
weinig@apple.com [Fri, 5 Nov 2010 16:55:18 +0000 (16:55 +0000)]
Fix failing python tests.

* Scripts/webkit2/messages.py:
* Scripts/webkit2/messages_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Fri, 5 Nov 2010 16:38:46 +0000 (16:38 +0000)]
2010-11-05  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
        https://bugs.webkit.org/show_bug.cgi?id=46945

        Add new funtions to suspend and resume animations. The go through all subframes and suspend or resume them
        recursively.

        Test: animations/stop-animation-on-suspend.html

        * WebCore.exp.in:
        * page/Frame.cpp:
        (WebCore::Frame::suspendAnimations):
        (WebCore::Frame::resumeAnimations):
        * page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGenerate the messages sent to the WebProcessProxy
weinig@apple.com [Fri, 5 Nov 2010 16:18:34 +0000 (16:18 +0000)]
Generate the messages sent to the WebProcessProxy
https://bugs.webkit.org/show_bug.cgi?id=49062

Reviewed by Adam Roben..

* Platform/CoreIPC/MessageID.h:
Temporarily add MessageClassWebProcessProxyLegacy while we still can't
support GetPluginProcessConnection (and deferred sync replies) in the
general mechanism.

* Scripts/webkit2/messages.py:
Add support for WebCore::PluginData and WebKit::WebNavigationDataStore.

* Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h:
Remove now unused kinds. Rename to MessageClassWebProcessProxyLegacy.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPluginPath):
(WebKit::WebProcessProxy::addBackForwardItem):
(WebKit::WebProcessProxy::didNavigateWithNavigationData):
(WebKit::WebProcessProxy::didPerformClientRedirect):
(WebKit::WebProcessProxy::didPerformServerRedirect):
(WebKit::WebProcessProxy::didUpdateHistoryTitle):
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
(WebKit::WebProcessProxy::didDestroyFrame):
* UIProcess/WebProcessProxy.h:
* UIProcess/WebProcessProxy.messages.in: Added.
Move implementations to their own functions.

* WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
Change to use WebProcessProxyLegacyMessage.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::updateGlobalHistory):
(WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
(WebKit::WebFrameLoaderClient::setTitle):
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::populatePluginCache):
* WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::updateBackForwardItem):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::addVisitedLink):
(WebKit::WebProcess::removeWebFrame):
Use generated messages.

* DerivedSources.make:
* DerivedSources.pro:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Fri, 5 Nov 2010 15:45:16 +0000 (15:45 +0000)]
2010-11-05  Stephen White  <senorblanco@chromium.org>

        Unreviewed; test_expectations fix.

        Cleaning up the chromium-gpu test expectations after the switch to DRT.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate expected results for two tests on Windows
aroben@apple.com [Fri, 5 Nov 2010 15:40:54 +0000 (15:40 +0000)]
Update expected results for two tests on Windows

* platform/win/fast/dom/HTMLMeterElement/meter-element-expected.png:
* platform/win/fast/dom/HTMLMeterElement/meter-element-expected.txt:
* platform/win/fast/dom/HTMLProgressElement/progress-element-with-child-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Fri, 5 Nov 2010 14:59:56 +0000 (14:59 +0000)]
Unreviewed.

[Qt] Add platform specific expected results for new passing tests introduced in r71382.
Compared to Mac png files and Mac expected files.

* platform/qt/fast/table/027-vertical-expected.checksum: Added.
* platform/qt/fast/table/027-vertical-expected.png: Added.
* platform/qt/fast/table/027-vertical-expected.txt: Added.
* platform/qt/fast/table/028-vertical-expected.checksum: Added.
* platform/qt/fast/table/028-vertical-expected.png: Added.
* platform/qt/fast/table/028-vertical-expected.txt: Added.
* platform/qt/fast/table/035-vertical-expected.checksum: Added.
* platform/qt/fast/table/035-vertical-expected.png: Added.
* platform/qt/fast/table/035-vertical-expected.txt: Added.
* platform/qt/fast/table/038-vertical-expected.checksum: Added.
* platform/qt/fast/table/038-vertical-expected.png: Added.
* platform/qt/fast/table/038-vertical-expected.txt: Added.
* platform/qt/fast/table/040-vertical-expected.checksum: Added.
* platform/qt/fast/table/040-vertical-expected.png: Added.
* platform/qt/fast/table/040-vertical-expected.txt: Added.
* platform/qt/fast/table/auto-with-percent-height-vertical-expected.checksum: Added.
* platform/qt/fast/table/auto-with-percent-height-vertical-expected.png: Added.
* platform/qt/fast/table/auto-with-percent-height-vertical-expected.txt: Added.
* platform/qt/fast/table/border-collapsing/001-vertical-expected.checksum: Added.
* platform/qt/fast/table/border-collapsing/001-vertical-expected.png: Added.
* platform/qt/fast/table/border-collapsing/001-vertical-expected.txt: Added.
* platform/qt/fast/table/border-collapsing/002-vertical-expected.checksum: Added.
* platform/qt/fast/table/border-collapsing/002-vertical-expected.png: Added.
* platform/qt/fast/table/border-collapsing/002-vertical-expected.txt: Added.
* platform/qt/fast/table/border-collapsing/003-vertical-expected.checksum: Added.
* platform/qt/fast/table/border-collapsing/003-vertical-expected.png: Added.
* platform/qt/fast/table/border-collapsing/003-vertical-expected.txt: Added.
* platform/qt/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
* platform/qt/fast/table/border-collapsing/004-vertical-expected.png: Added.
* platform/qt/fast/table/border-collapsing/004-vertical-expected.txt: Added.
* platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.checksum: Added.
* platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png: Added.
* platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt: Added.
* platform/qt/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum: Added.
* platform/qt/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Added.
* platform/qt/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt: Added.
* platform/qt/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.checksum: Added.
* platform/qt/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png: Added.
* platform/qt/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt: Added.
* platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.checksum: Added.
* platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.png: Added.
* platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Added.
* platform/qt/fast/table/growCellForImageQuirk-vertical-expected.checksum: Added.
* platform/qt/fast/table/growCellForImageQuirk-vertical-expected.png: Added.
* platform/qt/fast/table/growCellForImageQuirk-vertical-expected.txt: Added.
* platform/qt/fast/table/height-percent-test-vertical-expected.checksum: Added.
* platform/qt/fast/table/height-percent-test-vertical-expected.png: Added.
* platform/qt/fast/table/height-percent-test-vertical-expected.txt: Added.
* platform/qt/fast/table/percent-widths-stretch-vertical-expected.checksum: Added.
* platform/qt/fast/table/percent-widths-stretch-vertical-expected.png: Added.
* platform/qt/fast/table/percent-widths-stretch-vertical-expected.txt: Added.
* platform/qt/fast/table/rowspan-paint-order-vertical-expected.checksum: Added.
* platform/qt/fast/table/rowspan-paint-order-vertical-expected.png: Added.
* platform/qt/fast/table/rowspan-paint-order-vertical-expected.txt: Added.
* platform/qt/fast/table/table-display-types-vertical-expected.checksum: Added.
* platform/qt/fast/table/table-display-types-vertical-expected.png: Added.
* platform/qt/fast/table/table-display-types-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTeach check-webkit-style about TestNetscapePlugIn
aroben@apple.com [Fri, 5 Nov 2010 14:48:06 +0000 (14:48 +0000)]
Teach check-webkit-style about TestNetscapePlugIn

Fixes <http://webkit.org/b/49030> check-webkit-style is ignorant of
TestNetscapePlugIn's coding conventions

Reviewed by John Sullivan.

* Scripts/webkitpy/style/checker.py: Lump TestNetscapePlugIn in with
WebKitAPITest and TestWebKitAPI in having different include order and
naming conventions than WebCore. Added some comments about why the
exceptions exist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a test that shows that windowed plugins are able to paint
aroben@apple.com [Fri, 5 Nov 2010 14:47:37 +0000 (14:47 +0000)]
Add a test that shows that windowed plugins are able to paint

Somehow we never had a test for this before.

Fixes <http://webkit.org/b/49029> Should add a test that shows
windowed plugins can paint

Reviewed by Jon Honeycutt.

WebKitTools:

* DumpRenderTree/TestNetscapePlugIn/Tests/win/DrawsGradient.cpp: Added.
(DrawsGradient::DrawsGradient):
(DrawsGradient::wndProc): We handle the WM_PAINT and WM_PRINTCLIENT messages.

(DrawsGradient::onPaint):
(DrawsGradient::onPrintClient):
These both just call through to paint.

(DrawsGradient::paint): Fills our client area with some gradients.

* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Link
against Msimg32.lib for ::GradientFill and added DrawsGradient.

* DumpRenderTree/win/PixelDumpSupportWin.cpp:
(createBitmapContextFromWebView): Use WM_PRINT instead of
WM_PRINTCLIENT so that ::DefWindowProc will send
WM_PRINT/WM_PRINTCLIENT messages to the WebView's child windows.
Replaced kCGImageAlphaPremultipledFirst with kCGImageAlphaNoneSkipFirst
because GDI doesn't support alpha and kCGImageBitmapOrder32Little with
kCGImageBitmapOrder32Host because, who knows, maybe someday Windows
will run on a big-endian platform.

LayoutTests:

* platform/win/platform/win/plugins/draws-gradient-expected.checksum: Added.
* platform/win/platform/win/plugins/draws-gradient-expected.png: Added.
* platform/win/platform/win/plugins/draws-gradient-expected.txt: Added.
* platform/win/plugins/draws-gradient.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExtract much of NPNInvalidateRectInvalidatesWindow's code into a WindowedPluginTest...
aroben@apple.com [Fri, 5 Nov 2010 14:46:45 +0000 (14:46 +0000)]
Extract much of NPNInvalidateRectInvalidatesWindow's code into a WindowedPluginTest base class

The base class takes care of subclassing the plugin's window so that a
custom WNDPROC is called. This will make it easier to write tests that
need to handle window messages.

Fixes <http://webkit.org/b/49028> It's hard to write a PluginTest with
a custom WNDPROC

Reviewed by Jon Honeycutt.

* DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
(NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
(NPNInvalidateRectInvalidatesWindow::NPP_SetWindow):
(NPNInvalidateRectInvalidatesWindow::wndProc):
(NPNInvalidateRectInvalidatesWindow::testInvalidateRect):
Moved code from here to WindowedPluginTest. Changed to use window()
instead of m_window.

* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
Added WindowedPluginTest and added TestNetscapePlugIn/win to the
include path. Also reordered the include path to make a little more
sense and simplified the entry that added TestNetscapePlugIn itself to
the include path.

* DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp: Added.
(WindowedPluginTest::WindowedPluginTest):
(WindowedPluginTest::NPP_SetWindow):
(WindowedPluginTest::staticWndProc):
* DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h: Added.
(WindowedPluginTest::window):
Code came from NPNInvalidateRectInvalidatesWindow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse a window region to clip windowed plugins
aroben@apple.com [Fri, 5 Nov 2010 14:46:05 +0000 (14:46 +0000)]
Use a window region to clip windowed plugins

Fixes <http://webkit.org/b/49024> <rdar://problem/8487847> Windowed
plugins aren't clipped in WebKit2 on Windows

Reviewed by Jon Honeycutt.

WebKit2:

* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::registerPluginView): Removed the CS_PARENTDC style. This style
makes Windows ignore the window region and always clip to the parent
window. Also pass WebKit.dll's HINSTANCE as part of the WNDCLASSW
struct so that the window class will be specific to WebKit.dll rather
than to WebKit2WebProcess.exe. This is useful for testing, but also
more pedantically correct.
(WebKit::setWindowRegion): Helper function to set a window region and
deal with ownership of the HRGN correctly.
(WebKit::NetscapePlugin::platformGeometryDidChange): Make an HRGN that
corresponds to m_clipRect and set it on the plugin's window.

WebKitTools:

Add a plugin test to show that windowed plugins are clipped correctly

* DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp: Added.
(WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Initialize members.
(WindowRegionIsSetToClipRect::NPP_SetWindow): Check that our window
region matches the clip rect we know we should have based on
window-region-is-set-to-clip-rect.html, and check that our window class
doesn't have the CS_PARENTDC style.

* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
Added WindowRegionIsSetToClipRect.

LayoutTests:

Add a test to show that windowed plugins are clipped correctly

* platform/win/plugins/window-region-is-set-to-clip-rect-expected.txt: Added.
* platform/win/plugins/window-region-is-set-to-clip-rect.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 5 Nov 2010 14:29:57 +0000 (14:29 +0000)]
2010-11-05  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Crash in InspectorDOMAgent::innerParentNode.
        https://bugs.webkit.org/show_bug.cgi?id=49054

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::setOuterHTML):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Fri, 5 Nov 2010 14:25:59 +0000 (14:25 +0000)]
Unreviewed.

[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.

* platform/qt/fast/block/basic/truncation-rtl-expected.checksum: Added.
* platform/qt/fast/block/basic/truncation-rtl-expected.png: Added.
* platform/qt/fast/block/basic/truncation-rtl-expected.txt: Added.
* platform/qt/fast/blockflow/background-horizontal-bt-expected.checksum: Added.
* platform/qt/fast/blockflow/background-horizontal-bt-expected.png: Added.
* platform/qt/fast/blockflow/background-horizontal-bt-expected.txt: Added.
* platform/qt/fast/blockflow/background-vertical-lr-expected.checksum: Added.
* platform/qt/fast/blockflow/background-vertical-lr-expected.png: Added.
* platform/qt/fast/blockflow/background-vertical-lr-expected.txt: Added.
* platform/qt/fast/blockflow/background-vertical-rl-expected.checksum: Added.
* platform/qt/fast/blockflow/background-vertical-rl-expected.png: Added.
* platform/qt/fast/blockflow/background-vertical-rl-expected.txt: Added.
* platform/qt/fast/blockflow/basic-vertical-line-expected.checksum: Added.
* platform/qt/fast/blockflow/basic-vertical-line-expected.png: Added.
* platform/qt/fast/blockflow/basic-vertical-line-expected.txt: Added.
* platform/qt/fast/blockflow/body-direction-propagation-blocked-expected.checksum: Added.
* platform/qt/fast/blockflow/body-direction-propagation-blocked-expected.png: Added.
* platform/qt/fast/blockflow/body-direction-propagation-blocked-expected.txt: Added.
* platform/qt/fast/blockflow/body-direction-propagation-expected.checksum: Added.
* platform/qt/fast/blockflow/body-direction-propagation-expected.png: Added.
* platform/qt/fast/blockflow/body-direction-propagation-expected.txt: Added.
* platform/qt/fast/blockflow/body-writing-mode-propagation-blocked-expected.checksum: Added.
* platform/qt/fast/blockflow/body-writing-mode-propagation-blocked-expected.png: Added.
* platform/qt/fast/blockflow/body-writing-mode-propagation-blocked-expected.txt: Added.
* platform/qt/fast/blockflow/body-writing-mode-propagation-expected.checksum: Added.
* platform/qt/fast/blockflow/body-writing-mode-propagation-expected.png: Added.
* platform/qt/fast/blockflow/body-writing-mode-propagation-expected.txt: Added.
* platform/qt/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Added.
* platform/qt/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Added.
* platform/qt/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt: Added.
* platform/qt/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Added.
* platform/qt/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added.
* platform/qt/fast/blockflow/box-shadow-horizontal-bt-expected.txt: Added.
* platform/qt/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
* platform/qt/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
* platform/qt/fast/blockflow/box-shadow-vertical-lr-expected.txt: Added.
* platform/qt/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
* platform/qt/fast/blockflow/box-shadow-vertical-rl-expected.png: Added.
* platform/qt/fast/blockflow/box-shadow-vertical-rl-expected.txt: Added.
* platform/qt/fast/blockflow/english-bt-text-expected.checksum: Added.
* platform/qt/fast/blockflow/english-bt-text-expected.png: Added.
* platform/qt/fast/blockflow/english-bt-text-expected.txt: Added.
* platform/qt/fast/blockflow/english-lr-text-expected.checksum: Added.
* platform/qt/fast/blockflow/english-lr-text-expected.png: Added.
* platform/qt/fast/blockflow/english-lr-text-expected.txt: Added.
* platform/qt/fast/blockflow/english-rl-text-expected.checksum: Added.
* platform/qt/fast/blockflow/english-rl-text-expected.png: Added.
* platform/qt/fast/blockflow/english-rl-text-expected.txt: Added.
* platform/qt/fast/borders/border-radius-inline-flow-expected.checksum: Added.
* platform/qt/fast/borders/border-radius-inline-flow-expected.png: Added.
* platform/qt/fast/borders/border-radius-inline-flow-expected.txt: Added.
* platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
* platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
* platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt: Added.
* platform/qt/fast/dom/gc-10-expected.checksum: Added.
* platform/qt/fast/dom/gc-10-expected.png: Added.
* platform/qt/fast/dom/gc-10-expected.txt: Added.
* platform/qt/fast/transforms/rotated-transform-affects-scrolling-1-expected.checksum: Added.
* platform/qt/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Added.
* platform/qt/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Added.
* platform/qt/fast/transforms/rotated-transform-affects-scrolling-2-expected.checksum: Added.
* platform/qt/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: Added.
* platform/qt/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
* platform/qt/svg/animations: Added.
* platform/qt/svg/animations/repeatDur-zero-expected.checksum: Added.
* platform/qt/svg/animations/repeatDur-zero-expected.png: Added.
* platform/qt/svg/animations/repeatDur-zero-expected.txt: Added.
* platform/qt/svg/custom/use-invalid-pattern-expected.checksum: Added.
* platform/qt/svg/custom/use-invalid-pattern-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 5 Nov 2010 14:25:23 +0000 (14:25 +0000)]
2010-11-05  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: XHR logging in console should give complete view of resource.
        https://bugs.webkit.org/show_bug.cgi?id=48998

        Drive-by fixes: linkify line number to scripts panel, fall back to resources;
        enable multiline console entry on shift modifier as well.

        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel):
        (WebInspector.NetworkPanel.prototype._reset):
        (WebInspector.NetworkPanel.prototype.refreshResource):
        (WebInspector.NetworkPanel.prototype.canShowSourceLine):
        (WebInspector.NetworkPanel.prototype.showSourceLine):
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel.prototype.show):
        (WebInspector.StoragePanel.prototype.showSourceLine):
        * inspector/front-end/inspector.js:
        (WebInspector.showPanel):
        (WebInspector.linkifyStringAsFragment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-27 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Fri, 5 Nov 2010 14:01:34 +0000 (14:01 +0000)]
2010-10-27  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Clean up IDBTransactionBackend/Coordinator
        https://bugs.webkit.org/show_bug.cgi?id=48425

        Get rid of obsolete id and thus we don't need the factory method
        on IDBTransactionCoordinator that creates IDBTransactionBackends.

        Add an assert to IDBTransactionBackend to make sure we're not in
        the coordinator and then remove the coordinators ref counting link
        to the transaction.

        Have the transaction backend zero out refs to the database when its
        done using it.

        Existing tests provide coverage for this refactoring.

        * storage/IDBDatabaseBackendImpl.cpp:
        (WebCore::IDBDatabaseBackendImpl::setVersion):
        (WebCore::IDBDatabaseBackendImpl::transaction):
        * storage/IDBTransactionBackendImpl.cpp:
        (WebCore::IDBTransactionBackendImpl::create):
        (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
        (WebCore::IDBTransactionBackendImpl::~IDBTransactionBackendImpl):
        (WebCore::IDBTransactionBackendImpl::abort):
        (WebCore::IDBTransactionBackendImpl::commit):
        * storage/IDBTransactionBackendImpl.h:
        * storage/IDBTransactionBackendInterface.h:
        * storage/IDBTransactionCoordinator.cpp:
        (WebCore::IDBTransactionCoordinator::didStartTransaction):
        (WebCore::IDBTransactionCoordinator::didFinishTransaction):
        (WebCore::IDBTransactionCoordinator::isActive):
        (WebCore::IDBTransactionCoordinator::processStartedTransactions):
        * storage/IDBTransactionCoordinator.h:
2010-10-27  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Clean up IDBTransactionBackend/Coordinator
        https://bugs.webkit.org/show_bug.cgi?id=48425

        Remove obsolete ::id() method.

        * public/WebIDBTransaction.h:
        * src/IDBTransactionBackendProxy.cpp:
        * src/IDBTransactionBackendProxy.h:
        * src/WebIDBTransactionImpl.cpp:
        * src/WebIDBTransactionImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-27 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Fri, 5 Nov 2010 13:57:26 +0000 (13:57 +0000)]
2010-10-27  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        IDBFactoryBackend's reference to IDBDatabaseBackend should be weak
        https://bugs.webkit.org/show_bug.cgi?id=48416

        The factory's lifetime is that of the application, so without making
        this weak, IDBDatabaseBackend's will never be closed until the app
        terminates.

        * storage/IDBDatabaseBackendImpl.cpp:
        (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
        (WebCore::IDBDatabaseBackendImpl::~IDBDatabaseBackendImpl):
        * storage/IDBDatabaseBackendImpl.h:
        (WebCore::IDBDatabaseBackendImpl::create):
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::IDBFactoryBackendImpl::removeIDBDatabaseBackend):
        (WebCore::IDBFactoryBackendImpl::removeSQLiteDatabase):
        (WebCore::IDBFactoryBackendImpl::open):
        * storage/IDBFactoryBackendImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 5 Nov 2010 12:25:59 +0000 (12:25 +0000)]
2010-11-05  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, apparently some forms tests need different results in
        the bots after the removing the font hinting.

        * platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.txt:
        * platform/gtk/fast/forms/001-expected.txt:
        * platform/gtk/fast/forms/003-expected.txt:
        * platform/gtk/fast/forms/004-expected.txt:
        * platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt:
        * platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt:
        * platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt:
        * platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt:
        * platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
        * platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
        * platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
        * platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
        * platform/gtk/fast/forms/form-element-geometry-expected.txt:
        * platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
        * platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
        * platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
        * platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
        * platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
        * platform/gtk/fast/forms/menulist-style-color-expected.txt:
        * platform/gtk/fast/forms/menulist-width-change-expected.txt:
        * platform/gtk/fast/forms/option-script-expected.txt:
        * platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
        * platform/gtk/fast/forms/select-baseline-expected.txt:
        * platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
        * platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
        * platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
        * platform/gtk/fast/forms/select-initial-position-expected.txt:
        * platform/gtk/fast/forms/select-size-expected.txt:
        * platform/gtk/fast/forms/select-style-expected.txt:
        * platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
        * platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
        * platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
        * platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
        * platform/gtk/svg/custom/use-font-face-crash-expected.txt:
        * platform/gtk/svg/in-html/circle-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Left over files and shared memory segments
kbalazs@webkit.org [Fri, 5 Nov 2010 12:03:50 +0000 (12:03 +0000)]
[Qt][WK2] Left over files and shared memory segments
https://bugs.webkit.org/show_bug.cgi?id=48985

Reviewed by Andreas Kling.

* Platform/qt/SharedMemoryQt.cpp:
(WebKit::SharedMemory::create): Force deletion of the QSharedMemory
object on terminate by connecting QCoreApplication::aboutToQuit with
deleteLater. Add the object to the CrashHandler as well to release the
shared memory segment even on crash.
(WebKit::SharedMemory::~SharedMemory):
* Shared/qt/CrashHandler.cpp: Added.
CrashHandler has a container for QObjects that we want to
destroy on crash. When we got a signal that we interpret as
a crash then it destroys those objects.
(WebKit::CrashHandler::CrashHandler):
(WebKit::CrashHandler::signalHandler):
(WebKit::CrashHandler::deleteObjects):
* Shared/qt/CrashHandler.h: Added.
(WebKit::CrashHandler::instance):
(WebKit::CrashHandler::didDelete):
(WebKit::CrashHandler::markForDeletionOnCrash):
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncherHelper::ProcessLauncherHelper):
Add the object itself to the CrashHandler to close the QLocalServer
even on crash. Without that the QLocalServer leaves over socket files on the disk.
(WebKit::ProcessLauncherHelper::~ProcessLauncherHelper):
* WebKit2.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-27 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Fri, 5 Nov 2010 11:53:36 +0000 (11:53 +0000)]
2010-10-27  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        IDBObjectStoreBackend and IDBIndexBackend should not depend on IDBDatabaseBackend
        https://bugs.webkit.org/show_bug.cgi?id=48410

        Break dependency cyles between IDBDatabaseBackend and the other classes listed.
        This was causing memory leaks.

        * storage/IDBCursorBackendImpl.cpp:
        (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
        (WebCore::IDBCursorBackendImpl::updateInternal):
        (WebCore::IDBCursorBackendImpl::removeInternal):
        (WebCore::IDBCursorBackendImpl::database):
        * storage/IDBCursorBackendImpl.h:
        (WebCore::IDBCursorBackendImpl::create):
        * storage/IDBDatabaseBackendImpl.cpp:
        (WebCore::IDBDatabaseBackendImpl::createObjectStore):
        (WebCore::IDBDatabaseBackendImpl::loadObjectStores):
        * storage/IDBIndexBackendImpl.cpp:
        (WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
        (WebCore::IDBIndexBackendImpl::openCursorInternal):
        (WebCore::IDBIndexBackendImpl::sqliteDatabase):
        * storage/IDBIndexBackendImpl.h:
        (WebCore::IDBIndexBackendImpl::create):
        (WebCore::IDBIndexBackendImpl::storeName):
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
        (WebCore::IDBObjectStoreBackendImpl::createIndex):
        (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
        (WebCore::IDBObjectStoreBackendImpl::loadIndexes):
        (WebCore::IDBObjectStoreBackendImpl::sqliteDatabase):
        * storage/IDBObjectStoreBackendImpl.h:
        (WebCore::IDBObjectStoreBackendImpl::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Fri, 5 Nov 2010 11:44:23 +0000 (11:44 +0000)]
2010-11-05  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skipping crashing svg test.

        [GTK] svg/animations/animate-path-nested-transforms.html crashes
        https://bugs.webkit.org/show_bug.cgi?id=49065

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 5 Nov 2010 11:36:07 +0000 (11:36 +0000)]
2010-11-05  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Avoid font hinting in the DRT
        https://bugs.webkit.org/show_bug.cgi?id=48548

        Rebaseline the test results after removing the font hinting.

        * platform/gtk/http/tests/misc/slow-loading-mask-expected.txt:
        * platform/gtk/fast/multicol/float-multicol-expected.txt:
        * platform/gtk/fast/multicol/float-paginate-complex-expected.txt:
        * platform/gtk/fast/multicol/float-paginate-expected.txt:
        * platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
        * platform/gtk/fast/multicol/layers-split-across-columns-expected.txt:
        * platform/gtk/fast/multicol/margin-collapse-expected.txt:
        * platform/gtk/fast/multicol/max-height-columns-block-expected.txt:
        * platform/gtk/fast/multicol/nested-columns-expected.txt:
        * platform/gtk/fast/multicol/paginate-block-replaced-expected.txt:
        * platform/gtk/fast/multicol/positioned-split-expected.txt:
        * platform/gtk/fast/multicol/positioned-with-constrained-height-expected.txt:
        * platform/gtk/fast/multicol/shadow-breaking-expected.txt:
        * platform/gtk/fast/multicol/single-line-expected.txt:
        * platform/gtk/fast/multicol/span/anonymous-style-inheritance-expected.txt:
        * platform/gtk/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
        * platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
        * platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
        * platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
        * platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
        * platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
        * platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
        * platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt:
        * platform/gtk/fast/multicol/span/span-margin-collapsing-expected.txt:
        * platform/gtk/fast/multicol/table-margin-collapse-expected.txt:
        * platform/gtk/fast/multicol/table-vertical-align-expected.txt:
        * platform/gtk/fast/multicol/unsplittable-inline-block-expected.txt:
        * platform/gtk/fast/overflow/line-clamp-expected.txt:
        * platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
        * platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.txt:
        * platform/gtk/fast/repaint/block-no-inflow-children-expected.txt:
        * platform/gtk/fast/repaint/fixed-child-move-after-scroll-expected.txt:
        * platform/gtk/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
        * platform/gtk/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
        * platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
        * platform/gtk/fast/repaint/fixed-move-after-scroll-expected.txt:
        * platform/gtk/fast/repaint/layout-state-scrolloffset-expected.txt:
        * platform/gtk/fast/repaint/layout-state-scrolloffset2-expected.txt:
        * platform/gtk/fast/repaint/layout-state-scrolloffset3-expected.txt:
        * platform/gtk/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
        * platform/gtk/fast/repaint/stacked-diacritics-expected.txt:
        * platform/gtk/fast/table/early-table-layout-expected.txt:
        * platform/gtk/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt:
        * platform/gtk/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt:
        * platform/gtk/fast/table/fixed-table-with-percent-width-inside-div-expected.txt:
        * platform/gtk/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt:
        * platform/gtk/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt:
        * platform/gtk/fast/table/fixed-table-with-small-percent-width-expected.txt:
        * platform/gtk/fast/text/backslash-to-yen-sign-dynamic-expected.txt:
        * platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
        * platform/gtk/fast/text/backslash-to-yen-sign-expected.txt:
        * platform/gtk/fast/text/format-control-expected.txt:
        * platform/gtk/fast/text/international/bidi-mirror-he-ar-expected.txt:
        * platform/gtk/fast/text/international/bold-bengali-expected.txt:
        * platform/gtk/fast/text/international/plane2-expected.txt:
        * platform/gtk/fast/text/shadow-no-blur-expected.txt:
        * platform/gtk/fast/text/shadow-translucent-fill-expected.txt:
        * platform/gtk/fast/text/stroking-expected.txt:
        * platform/gtk/fonts/cursive-expected.txt:
        * platform/gtk/fonts/custom-font-missing-glyphs-expected.txt:
        * platform/gtk/fonts/default-expected.txt:
        * platform/gtk/fonts/fantasy-expected.txt:
        * platform/gtk/fonts/font-face-with-complex-text-expected.txt:
        * platform/gtk/fonts/fontconfig-aliasing-settings-expected.txt:
        * platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt:
        * platform/gtk/fonts/fontconfig-synthetic-oblique-expected.txt:
        * platform/gtk/fonts/monospace-expected.txt:
        * platform/gtk/fonts/sans-serif-expected.txt:
        * platform/gtk/fonts/serif-expected.txt:
        * platform/gtk/fonts/xsettings_antialias_settings-expected.txt:
        * platform/gtk/http/tests/misc/slow-loading-image-in-pattern-expected.txt:
        * platform/gtk/media/audio-controls-rendering-expected.txt:
        * platform/gtk/media/audio-no-installed-engines-expected.txt:
        * platform/gtk/media/controls-after-reload-expected.txt:
        * platform/gtk/media/controls-strict-expected.txt:
        * platform/gtk/media/video-display-toggle-expected.txt:
        * platform/gtk/media/video-empty-source-expected.txt:
        * platform/gtk/media/video-no-audio-expected.txt:
        * platform/gtk/media/video-replaces-poster-expected.txt:
        * platform/gtk/media/video-zoom-expected.txt:
        * platform/gtk/scrollbars/basic-scrollbar-expected.txt:
        * platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
        * platform/gtk/scrollbars/disabled-scrollbar-expected.txt:
        * platform/gtk/scrollbars/overflow-scrollbar-combinations-expected.txt:
        * platform/gtk/scrollbars/scrollbar-buttons-expected.txt:
        * platform/gtk/scrollbars/scrollbar-orientation-expected.txt:
        * platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
        * platform/gtk/svg/batik/text/textDecoration-expected.txt:
        * platform/gtk/svg/css/composite-shadow-text-expected.txt:
        * platform/gtk/svg/css/group-with-shadow-expected.txt:
        * platform/gtk/svg/css/text-shadow-multiple-expected.txt:
        * platform/gtk/svg/custom/broken-internal-references-expected.txt:
        * platform/gtk/svg/custom/bug45331-expected.txt:
        * platform/gtk/svg/custom/clone-element-with-animated-svg-properties-expected.txt:
        * platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
        * platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
        * platform/gtk/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
        * platform/gtk/svg/custom/js-update-stop-linked-gradient-expected.txt:
        * platform/gtk/svg/custom/mask-invalidation-expected.txt:
        * platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt:
        * platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
        * platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt:
        * platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
        * platform/gtk/svg/custom/pattern-incorrect-tiling-expected.txt:
        * platform/gtk/svg/custom/recursive-gradient-expected.txt:
        * platform/gtk/svg/custom/recursive-pattern-expected.txt:
        * platform/gtk/svg/custom/relative-sized-content-expected.txt:
        * platform/gtk/svg/custom/relative-sized-content-with-resources-expected.txt:
        * platform/gtk/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
        * platform/gtk/svg/custom/relative-sized-shadow-tree-content-expected.txt:
        * platform/gtk/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
        * platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
        * platform/gtk/svg/custom/text-rotated-gradient-expected.txt:
        * platform/gtk/svg/custom/text-rotation-expected.txt:
        * platform/gtk/svg/custom/text-x-dy-lists-expected.txt:
        * platform/gtk/svg/custom/text-xy-updates-SVGList-expected.txt:
        * platform/gtk/svg/custom/use-font-face-crash-expected.txt:
        * platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt:
        * platform/gtk/svg/filters/filter-on-tspan-expected.txt:
        * platform/gtk/svg/filters/filter-width-update-expected.txt:
        * platform/gtk/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt:
        * platform/gtk/svg/foreignObject/svg-document-as-direct-child-expected.txt:
        * platform/gtk/svg/foreignObject/svg-document-in-html-document-expected.txt:
        * platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
        * platform/gtk/svg/in-html/circle-expected.txt:
        * platform/gtk/svg/repaint/filter-repaint-expected.txt:
        * platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
        * platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
        * platform/gtk/svg/text/select-x-list-1-expected.txt:
        * platform/gtk/svg/text/select-x-list-2-expected.txt:
        * platform/gtk/svg/text/select-x-list-3-expected.txt:
        * platform/gtk/svg/text/select-x-list-4-expected.txt:
        * platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt:
        * platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt:
        * platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt:
        * platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt:
        * platform/gtk/svg/text/selection-background-color-expected.txt:
        * platform/gtk/svg/text/selection-doubleclick-expected.txt:
        * platform/gtk/svg/text/selection-styles-expected.txt:
        * platform/gtk/svg/text/selection-tripleclick-expected.txt:
        * platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
        * platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt:
        * platform/gtk/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
        * platform/gtk/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
        * platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
        * platform/gtk/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
        * platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
        * platform/gtk/svg/zoom/text/zoom-foreignObject-expected.txt:
        * platform/gtk/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
        * platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
        * platform/gtk/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
        * platform/gtk/tables/layering/paint-test-layering-1-expected.txt:
        * platform/gtk/tables/layering/paint-test-layering-2-expected.txt:
        * platform/gtk/transforms/2d/compound-transforms-vs-containers-expected.txt:
        * platform/gtk/transforms/2d/hindi-rotated-expected.txt:
        * platform/gtk/transforms/2d/transform-borderbox-expected.txt:
        * platform/gtk/transforms/2d/transform-fixed-container-expected.txt:
        * platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt:
        * platform/gtk/transforms/2d/zoom-menulist-expected.txt:
        * platform/gtk/transforms/no_transform_hit_testing-expected.txt:
        * platform/gtk/transforms/svg-vs-css-expected.txt:
        * platform/gtk/transitions/move-after-transition-expected.txt:
        * platform/gtk/transitions/svg-text-shadow-transition-expected.txt:
        * platform/gtk/transitions/transition-drt-api-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 5 Nov 2010 11:29:26 +0000 (11:29 +0000)]
2010-11-05  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Avoid font hinting in the DRT
        https://bugs.webkit.org/show_bug.cgi?id=48548

        Rebaseline the test results after removing the font hinting.

        * platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
        * platform/gtk/editing/pasteboard/paste-text-009-expected.txt:
        * platform/gtk/editing/pasteboard/paste-text-010-expected.txt:
        * platform/gtk/editing/pasteboard/paste-xml-expected.txt:
        * platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
        * platform/gtk/editing/selection/13804-expected.txt:
        * platform/gtk/editing/selection/4818145-expected.txt:
        * platform/gtk/editing/selection/4866671-expected.txt:
        * platform/gtk/editing/selection/4889598-expected.txt:
        * platform/gtk/editing/selection/4895428-2-expected.txt:
        * platform/gtk/editing/selection/4960116-expected.txt:
        * platform/gtk/editing/selection/4960137-expected.txt:
        * platform/gtk/editing/selection/4983858-expected.txt:
        * platform/gtk/editing/selection/5007143-2-expected.txt:
        * platform/gtk/editing/selection/5007143-expected.txt:
        * platform/gtk/editing/selection/5057506-2-expected.txt:
        * platform/gtk/editing/selection/5057506-expected.txt:
        * platform/gtk/editing/selection/5076323-1-expected.txt:
        * platform/gtk/editing/selection/5076323-2-expected.txt:
        * platform/gtk/editing/selection/5076323-3-expected.txt:
        * platform/gtk/editing/selection/5081257-1-expected.txt:
        * platform/gtk/editing/selection/5081257-2-expected.txt:
        * platform/gtk/editing/selection/5099303-expected.txt:
        * platform/gtk/editing/selection/5109817-expected.txt:
        * platform/gtk/editing/selection/5131716-1-expected.txt:
        * platform/gtk/editing/selection/5131716-2-expected.txt:
        * platform/gtk/editing/selection/5131716-3-expected.txt:
        * platform/gtk/editing/selection/5131716-4-expected.txt:
        * platform/gtk/editing/selection/5232159-expected.txt:
        * platform/gtk/editing/selection/5234383-1-expected.txt:
        * platform/gtk/editing/selection/5234383-2-expected.txt:
        * platform/gtk/editing/selection/addRange-expected.txt:
        * platform/gtk/editing/selection/drag-in-iframe-expected.txt:
        * platform/gtk/editing/selection/drag-select-1-expected.txt:
        * platform/gtk/editing/selection/drag-text-delay-expected.txt:
        * platform/gtk/editing/selection/drag-to-contenteditable-iframe-expected.txt:
        * platform/gtk/editing/selection/extend-by-character-002-expected.txt:
        * platform/gtk/editing/selection/extend-by-character-003-expected.txt:
        * platform/gtk/editing/selection/extend-by-character-004-expected.txt:
        * platform/gtk/editing/selection/extend-by-character-005-expected.txt:
        * platform/gtk/editing/selection/extend-selection-expected.txt:
        * platform/gtk/editing/selection/fake-drag-expected.txt:
        * platform/gtk/editing/selection/iframe-expected.txt:
        * platform/gtk/editing/selection/inline-table-expected.txt:
        * platform/gtk/editing/selection/mixed-editability-6-expected.txt:
        * platform/gtk/editing/selection/mixed-editability-7-expected.txt:
        * platform/gtk/editing/selection/move-backwords-by-word-001-expected.txt:
        * platform/gtk/editing/selection/move-between-blocks-no-001-expected.txt:
        * platform/gtk/editing/selection/move-between-blocks-yes-001-expected.txt:
        * platform/gtk/editing/selection/move-by-character-001-expected.txt:
        * platform/gtk/editing/selection/move-by-character-002-expected.txt:
        * platform/gtk/editing/selection/move-by-character-003-expected.txt:
        * platform/gtk/editing/selection/move-by-character-004-expected.txt:
        * platform/gtk/editing/selection/move-by-character-005-expected.txt:
        * platform/gtk/editing/selection/move-by-sentence-001-expected.txt:
        * platform/gtk/editing/selection/move-by-sentence-linebreak-expected.txt:
        * platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
        * platform/gtk/editing/selection/range-between-block-and-inline-expected.txt:
        * platform/gtk/editing/selection/select-box-expected.txt:
        * platform/gtk/editing/selection/select-text-overflow-ellipsis-expected.txt:
        * platform/gtk/editing/selection/selectNode-expected.txt:
        * platform/gtk/editing/selection/selectNodeContents-expected.txt:
        * platform/gtk/editing/selection/selection-actions-expected.txt:
        * platform/gtk/editing/selection/wrapped-line-caret-1-expected.txt:
        * platform/gtk/editing/selection/wrapped-line-caret-2-expected.txt:
        * platform/gtk/editing/spelling/spelling-expected.txt:
        * platform/gtk/editing/style/4916887-expected.txt:
        * platform/gtk/editing/style/5017613-1-expected.txt:
        * platform/gtk/editing/style/5017613-2-expected.txt:
        * platform/gtk/editing/style/5046875-1-expected.txt:
        * platform/gtk/editing/style/5046875-2-expected.txt:
        * platform/gtk/editing/style/5084241-expected.txt:
        * platform/gtk/editing/style/5228141-expected.txt:
        * platform/gtk/editing/style/5279521-expected.txt:
        * platform/gtk/editing/style/apply-through-end-of-document-expected.txt:
        * platform/gtk/editing/style/block-style-003-expected.txt:
        * platform/gtk/editing/style/highlight-expected.txt:
        * platform/gtk/editing/style/relative-font-size-change-001-expected.txt:
        * platform/gtk/editing/style/style-3681552-fix-001-expected.txt:
        * platform/gtk/editing/style/style-3681552-fix-002-expected.txt:
        * platform/gtk/editing/style/typing-style-001-expected.txt:
        * platform/gtk/editing/style/typing-style-002-expected.txt:
        * platform/gtk/editing/undo/4063751-expected.txt:
        * platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
        * platform/gtk/editing/undo/undo-combined-delete-expected.txt:
        * platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
        * platform/gtk/editing/undo/undo-delete-expected.txt:
        * platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
        * platform/gtk/editing/undo/undo-forward-delete-expected.txt:
        * platform/gtk/fast/backgrounds/001-expected.txt:
        * platform/gtk/fast/backgrounds/animated-gif-as-background-expected.txt:
        * platform/gtk/fast/backgrounds/background-inherit-color-bug-expected.txt:
        * platform/gtk/fast/backgrounds/background-origin-root-element-expected.txt:
        * platform/gtk/fast/backgrounds/background-position-1-expected.txt:
        * platform/gtk/fast/backgrounds/background-position-rounding-expected.txt:
        * platform/gtk/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
        * platform/gtk/fast/backgrounds/mask-composite-expected.txt:
        * platform/gtk/fast/backgrounds/opacity-on-document-element-expected.txt:
        * platform/gtk/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt:
        * platform/gtk/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
        * platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
        * platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
        * platform/gtk/fast/backgrounds/size/backgroundSize16-expected.txt:
        * platform/gtk/fast/backgrounds/size/zero-expected.txt:
        * platform/gtk/fast/backgrounds/solid-color-context-restore-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/002-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/003-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
        * platform/gtk/fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt:
        * platform/gtk/fast/blockflow/fieldsets-expected.txt:
        * platform/gtk/fast/borders/block-mask-overlay-image-expected.txt:
        * platform/gtk/fast/borders/border-color-inherit-expected.txt:
        * platform/gtk/fast/borders/border-fit-expected.txt:
        * platform/gtk/fast/borders/border-image-border-radius-expected.txt:
        * platform/gtk/fast/borders/border-radius-constraints-expected.txt:
        * platform/gtk/fast/borders/border-radius-huge-assert-expected.txt:
        * platform/gtk/fast/borders/border-radius-split-inline-expected.txt:
        * platform/gtk/fast/borders/borderRadiusAllStylesAllCorners-expected.txt:
        * platform/gtk/fast/borders/borderRadiusInvalidColor-expected.txt:
        * platform/gtk/fast/borders/different-color-borders-expected.txt:
        * platform/gtk/fast/borders/inline-mask-overlay-image-expected.txt:
        * platform/gtk/fast/borders/svg-as-border-image-2-expected.txt:
        * platform/gtk/fast/borders/svg-as-border-image-expected.txt:
        * platform/gtk/fast/box-shadow/basic-shadows-expected.txt:
        * platform/gtk/fast/box-shadow/border-radius-big-expected.txt:
        * platform/gtk/fast/box-shadow/inset-expected.txt:
        * platform/gtk/fast/box-shadow/transform-fringing-expected.txt:
        * platform/gtk/fast/canvas/setWidthResetAfterForcedRender-expected.txt:
        * platform/gtk/fast/canvas/shadow-offset-1-expected.txt:
        * platform/gtk/fast/canvas/shadow-offset-2-expected.txt:
        * platform/gtk/fast/canvas/shadow-offset-3-expected.txt:
        * platform/gtk/fast/canvas/shadow-offset-4-expected.txt:
        * platform/gtk/fast/canvas/shadow-offset-5-expected.txt:
        * platform/gtk/fast/canvas/shadow-offset-6-expected.txt:
        * platform/gtk/fast/canvas/shadow-offset-7-expected.txt:
        * platform/gtk/fast/canvas/toDataURL-alpha-expected.txt:
        * platform/gtk/fast/css-generated-content/after-duplicated-after-split-expected.txt:
        * platform/gtk/fast/css/compare-content-style-expected.txt:
        * platform/gtk/fast/css/css3-space-in-nth-and-lang-expected.txt:
        * platform/gtk/fast/css/first-letter-first-line-hover-expected.txt:
        * platform/gtk/fast/css/first-letter-punctuation-expected.txt:
        * platform/gtk/fast/css/font-face-opentype-expected.txt:
        * platform/gtk/fast/css/inline-element-line-break-expected.txt:
        * platform/gtk/fast/css/input-search-padding-expected.txt:
        * platform/gtk/fast/css/non-standard-checkbox-size-expected.txt:
        * platform/gtk/fast/css/percent-top-relative-container-height-unspecified-expected.txt:
        * platform/gtk/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt:
        * platform/gtk/fast/css/pseudo-element-line-break-expected.txt:
        * platform/gtk/fast/css/rtl-to-viewport-expected.txt:
        * platform/gtk/fast/css/shadow-multiple-expected.txt:
        * platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
        * platform/gtk/fast/css/transformed-mask-expected.txt:
        * platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
        * platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.txt:
        * platform/gtk/fast/dynamic/window-scrollbars-test-expected.txt:
        * platform/gtk/fast/events/event-sender-mouse-moved-expected.txt:
        * platform/gtk/fast/events/keydown-1-expected.txt:
        * platform/gtk/fast/events/mouseout-dead-node-expected.txt:
        * platform/gtk/fast/events/standalone-image-drag-to-editable-expected.txt:
        * platform/gtk/fast/forms/001-expected.txt:
        * platform/gtk/fast/forms/003-expected.txt:
        * platform/gtk/fast/forms/004-expected.txt:
        * platform/gtk/fast/forms/006-expected.txt:
        * platform/gtk/fast/forms/007-expected.txt:
        * platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt:
        * platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt:
        * platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt:
        * platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt:
        * platform/gtk/fast/forms/HTMLOptionElement_label05-expected.txt:
        * platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
        * platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
        * platform/gtk/fast/forms/basic-buttons-expected.txt:
        * platform/gtk/fast/forms/basic-inputs-expected.txt:
        * platform/gtk/fast/forms/basic-textareas-expected.txt:
        * platform/gtk/fast/forms/blankbuttons-expected.txt:
        * platform/gtk/fast/forms/box-shadow-override-expected.txt:
        * platform/gtk/fast/forms/button-align-expected.txt:
        * platform/gtk/fast/forms/button-cannot-be-nested-expected.txt:
        * platform/gtk/fast/forms/button-default-title-expected.txt:
        * platform/gtk/fast/forms/button-generated-content-expected.txt:
        * platform/gtk/fast/forms/button-inner-block-reuse-expected.txt:
        * platform/gtk/fast/forms/button-positioned-expected.txt:
        * platform/gtk/fast/forms/button-sizes-expected.txt:
        * platform/gtk/fast/forms/button-style-color-expected.txt:
        * platform/gtk/fast/forms/button-submit-expected.txt:
        * platform/gtk/fast/forms/button-table-styles-expected.txt:
        * platform/gtk/fast/forms/button-text-transform-expected.txt:
        * platform/gtk/fast/forms/button-white-space-expected.txt:
        * platform/gtk/fast/forms/caret-rtl-expected.txt:
        * platform/gtk/fast/forms/checkbox-radio-onchange-expected.txt:
        * platform/gtk/fast/forms/control-clip-expected.txt:
        * platform/gtk/fast/forms/control-clip-overflow-expected.txt:
        * platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
        * platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
        * platform/gtk/fast/forms/encoding-test-expected.txt:
        * platform/gtk/fast/forms/fieldset-align-expected.txt:
        * platform/gtk/fast/forms/fieldset-with-float-expected.txt:
        * platform/gtk/fast/forms/file-input-direction-expected.txt:
        * platform/gtk/fast/forms/file-input-disabled-expected.txt:
        * platform/gtk/fast/forms/float-before-fieldset-expected.txt:
        * platform/gtk/fast/forms/floating-textfield-relayout-expected.txt:
        * platform/gtk/fast/forms/form-added-to-table-expected.txt:
        * platform/gtk/fast/forms/form-element-geometry-expected.txt:
        * platform/gtk/fast/forms/form-hides-table-expected.txt:
        * platform/gtk/fast/forms/form-in-malformed-markup-expected.txt:
        * platform/gtk/fast/forms/formmove-expected.txt:
        * platform/gtk/fast/forms/formmove2-expected.txt:
        * platform/gtk/fast/forms/formmove3-expected.txt:
        * platform/gtk/fast/forms/hidden-input-file-expected.txt:
        * platform/gtk/fast/forms/hidden-listbox-expected.txt:
        * platform/gtk/fast/forms/image-border-expected.txt:
        * platform/gtk/fast/forms/indeterminate-expected.txt:
        * platform/gtk/fast/forms/input-align-expected.txt:
        * platform/gtk/fast/forms/input-align-image-expected.txt:
        * platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt:
        * platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.txt:
        * platform/gtk/fast/forms/input-appearance-disabled-expected.txt:
        * platform/gtk/fast/forms/input-appearance-focus-expected.txt:
        * platform/gtk/fast/forms/input-appearance-height-expected.txt:
        * platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
        * platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
        * platform/gtk/fast/forms/input-appearance-selection-expected.txt:
        * platform/gtk/fast/forms/input-appearance-visibility-expected.txt:
        * platform/gtk/fast/forms/input-appearance-width-expected.txt:
        * platform/gtk/fast/forms/input-baseline-expected.txt:
        * platform/gtk/fast/forms/input-button-sizes-expected.txt:
        * platform/gtk/fast/forms/input-disabled-color-expected.txt:
        * platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
        * platform/gtk/fast/forms/input-field-text-truncated-expected.txt:
        * platform/gtk/fast/forms/input-first-letter-expected.txt:
        * platform/gtk/fast/forms/input-no-renderer-expected.txt:
        * platform/gtk/fast/forms/input-paste-undo-expected.txt:
        * platform/gtk/fast/forms/input-placeholder-focus-twice-expected.txt:
        * platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
        * platform/gtk/fast/forms/input-readonly-dimmed-expected.txt:
        * platform/gtk/fast/forms/input-readonly-empty-expected.txt:
        * platform/gtk/fast/forms/input-spaces-expected.txt:
        * platform/gtk/fast/forms/input-table-expected.txt:
        * platform/gtk/fast/forms/input-text-click-inside-expected.txt:
        * platform/gtk/fast/forms/input-text-click-outside-expected.txt:
        * platform/gtk/fast/forms/input-text-double-click-expected.txt:
        * platform/gtk/fast/forms/input-text-drag-down-expected.txt:
        * platform/gtk/fast/forms/input-text-option-delete-expected.txt:
        * platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
        * platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
        * platform/gtk/fast/forms/input-text-word-wrap-expected.txt:
        * platform/gtk/fast/forms/input-type-change-expected.txt:
        * platform/gtk/fast/forms/input-type-change2-expected.txt:
        * platform/gtk/fast/forms/input-type-text-min-width-expected.txt:
        * platform/gtk/fast/forms/input-value-expected.txt:
        * platform/gtk/fast/forms/isindex-placeholder-expected.txt:
        * platform/gtk/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
        * platform/gtk/fast/forms/listbox-scrollbar-incremental-load-expected.txt:
        * platform/gtk/fast/forms/listbox-width-change-expected.txt:
        * platform/gtk/fast/forms/menulist-clip-expected.txt:
        * platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
        * platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
        * platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
        * platform/gtk/fast/forms/menulist-option-wrap-expected.txt:
        * platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
        * platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
        * platform/gtk/fast/forms/menulist-style-color-expected.txt:
        * platform/gtk/fast/forms/menulist-width-change-expected.txt:
        * platform/gtk/fast/forms/minWidthPercent-expected.txt:
        * platform/gtk/fast/forms/negativeLineHeight-expected.txt:
        * platform/gtk/fast/forms/option-index-expected.txt:
        * platform/gtk/fast/forms/option-script-expected.txt:
        * platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
        * platform/gtk/fast/forms/option-text-clip-expected.txt:
        * platform/gtk/fast/forms/password-placeholder-text-security-expected.txt:
        * platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
        * platform/gtk/fast/forms/placeholder-set-attribute-expected.txt:
        * platform/gtk/fast/forms/placeholder-set-value-expected.txt:
        * platform/gtk/fast/forms/placeholder-stripped-expected.txt:
        * platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
        * platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt:
        * platform/gtk/fast/forms/radio-attr-order-expected.txt:
        * platform/gtk/fast/forms/radio-nested-labels-expected.txt:
        * platform/gtk/fast/forms/radio_checked-expected.txt:
        * platform/gtk/fast/forms/radio_checked_dynamic-expected.txt:
        * platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt:
        * platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
        * platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
        * platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
        * platform/gtk/fast/forms/search-rtl-expected.txt:
        * platform/gtk/fast/forms/search-transformed-expected.txt:
        * platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
        * platform/gtk/fast/forms/search-zoomed-expected.txt:
        * platform/gtk/fast/forms/searchfield-heights-expected.txt:
        * platform/gtk/fast/forms/select-align-expected.txt:
        * platform/gtk/fast/forms/select-baseline-expected.txt:
        * platform/gtk/fast/forms/select-block-background-expected.txt:
        * platform/gtk/fast/forms/select-change-listbox-size-expected.txt:
        * platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
        * platform/gtk/fast/forms/select-change-popup-to-listbox-expected.txt:
        * platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
        * platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
        * platform/gtk/fast/forms/select-display-none-style-resolve-expected.txt:
        * platform/gtk/fast/forms/select-empty-option-height-expected.txt:
        * platform/gtk/fast/forms/select-initial-position-expected.txt:
        * platform/gtk/fast/forms/select-item-background-clip-expected.txt:
        * platform/gtk/fast/forms/select-list-box-with-height-expected.txt:
        * platform/gtk/fast/forms/select-selected-expected.txt:
        * platform/gtk/fast/forms/select-size-expected.txt:
        * platform/gtk/fast/forms/select-style-expected.txt:
        * platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
        * platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
        * platform/gtk/fast/forms/slider-padding-expected.txt:
        * platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt:
        * platform/gtk/fast/forms/slider-thumb-stylability-expected.txt:
        * platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
        * platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
        * platform/gtk/fast/forms/targeted-frame-submission-expected.txt:
        * platform/gtk/fast/forms/text-style-color-expected.txt:
        * platform/gtk/fast/forms/textAreaLineHeight-expected.txt:
        * platform/gtk/fast/forms/textarea-align-expected.txt:
        * platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
        * platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt:
        * platform/gtk/fast/forms/textarea-placeholder-set-value-expected.txt:
        * platform/gtk/fast/forms/textarea-scroll-height-expected.txt:
        * platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
        * platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
        * platform/gtk/fast/forms/textarea-setinnerhtml-expected.txt:
        * platform/gtk/fast/forms/textarea-width-expected.txt:
        * platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
        * platform/gtk/fast/forms/textfield-outline-expected.txt:
        * platform/gtk/fast/forms/thumbslider-crash-expected.txt:
        * platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt:
        * platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
        * platform/gtk/fast/frames/001-expected.txt:
        * platform/gtk/fast/frames/contentWindow_Frame-expected.txt:
        * platform/gtk/fast/frames/contentWindow_iFrame-expected.txt:
        * platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
        * platform/gtk/fast/frames/flattening/frameset-flattening-grid-expected.txt:
        * platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.txt:
        * platform/gtk/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
        * platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
        * platform/gtk/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
        * platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
        * platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
        * platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
        * platform/gtk/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
        * platform/gtk/fast/frames/flattening/iframe-flattening-simple-expected.txt:
        * platform/gtk/fast/frames/frame-navigation-expected.txt:
        * platform/gtk/fast/frames/frame-scrolling-attribute-expected.txt:
        * platform/gtk/fast/frames/frameElement-frame-expected.txt:
        * platform/gtk/fast/frames/frameElement-iframe-expected.txt:
        * platform/gtk/fast/frames/frameset-style-recalc-expected.txt:
        * platform/gtk/fast/frames/iframe-option-crash-expected.txt:
        * platform/gtk/fast/frames/iframe-scrolling-attribute-expected.txt:
        * platform/gtk/fast/frames/iframe-with-frameborder-expected.txt:
        * platform/gtk/fast/frames/inline-object-inside-frameset-expected.txt:
        * platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
        * platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
        * platform/gtk/fast/frames/viewsource-attribute-expected.txt:
        * platform/gtk/fast/frames/viewsource-on-image-file-expected.txt:
        * platform/gtk/fast/gradients/radial-centered-expected.txt:
        * platform/gtk/fast/images/imagemap-focus-ring-expected.txt:
        * platform/gtk/fast/images/svg-background-partial-redraw-expected.txt:
        * platform/gtk/fast/inline/continuation-outlines-with-layers-2-expected.txt:
        * platform/gtk/fast/inline/inline-focus-ring-expected.txt:
        * platform/gtk/fast/layers/remove-only-this-layer-update-expected.txt:
        * platform/gtk/fast/lists/drag-into-marker-expected.txt:
        * platform/gtk/fast/multicol/border-padding-pagination-expected.txt:
        * platform/gtk/fast/multicol/client-rects-expected.txt:
        * platform/gtk/fast/multicol/column-break-with-balancing-expected.txt:
        * platform/gtk/fast/multicol/column-count-with-rules-expected.txt:
        * platform/gtk/fast/multicol/column-rules-expected.txt:
        * platform/gtk/fast/multicol/column-rules-stacking-expected.txt:
        * platform/gtk/fast/multicol/columns-shorthand-parsing-expected.txt:
        * platform/gtk/fast/multicol/float-avoidance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 5 Nov 2010 11:18:01 +0000 (11:18 +0000)]
2010-11-05  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Avoid font hinting in the DRT
        https://bugs.webkit.org/show_bug.cgi?id=48548

        Rebaseline the test results after removing the font hinting.

        * platform/gtk/animations/animation-drt-api-expected.txt:
        * platform/gtk/animations/animation-drt-api-multiple-keyframes-expected.txt:
        * platform/gtk/animations/missing-values-first-keyframe-expected.txt:
        * platform/gtk/animations/missing-values-last-keyframe-expected.txt:
        * platform/gtk/animations/state-at-end-event-expected.txt:
        * platform/gtk/css1/basic/class_as_selector-expected.txt:
        * platform/gtk/css1/basic/comments-expected.txt:
        * platform/gtk/css1/basic/containment-expected.txt:
        * platform/gtk/css1/basic/contextual_selectors-expected.txt:
        * platform/gtk/css1/basic/grouping-expected.txt:
        * platform/gtk/css1/basic/id_as_selector-expected.txt:
        * platform/gtk/css1/basic/inheritance-expected.txt:
        * platform/gtk/css1/box_properties/border-expected.txt:
        * platform/gtk/css1/box_properties/border_bottom-expected.txt:
        * platform/gtk/css1/box_properties/border_bottom_inline-expected.txt:
        * platform/gtk/css1/box_properties/border_bottom_width-expected.txt:
        * platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt:
        * platform/gtk/css1/box_properties/border_color-expected.txt:
        * platform/gtk/css1/box_properties/border_color_inline-expected.txt:
        * platform/gtk/css1/box_properties/border_inline-expected.txt:
        * platform/gtk/css1/box_properties/border_left-expected.txt:
        * platform/gtk/css1/box_properties/border_left_inline-expected.txt:
        * platform/gtk/css1/box_properties/border_left_width-expected.txt:
        * platform/gtk/css1/box_properties/border_left_width_inline-expected.txt:
        * platform/gtk/css1/box_properties/border_right-expected.txt:
        * platform/gtk/css1/box_properties/border_right_inline-expected.txt:
        * platform/gtk/css1/box_properties/border_right_width-expected.txt:
        * platform/gtk/css1/box_properties/border_right_width_inline-expected.txt:
        * platform/gtk/css1/box_properties/border_style-expected.txt:
        * platform/gtk/css1/box_properties/border_style_inline-expected.txt:
        * platform/gtk/css1/box_properties/border_top-expected.txt:
        * platform/gtk/css1/box_properties/border_top_inline-expected.txt:
        * platform/gtk/css1/box_properties/border_top_width-expected.txt:
        * platform/gtk/css1/box_properties/border_top_width_inline-expected.txt:
        * platform/gtk/css1/box_properties/border_width-expected.txt:
        * platform/gtk/css1/box_properties/border_width_inline-expected.txt:
        * platform/gtk/css1/box_properties/clear-expected.txt:
        * platform/gtk/css1/box_properties/clear_float-expected.txt:
        * platform/gtk/css1/box_properties/float-expected.txt:
        * platform/gtk/css1/box_properties/float_elements_in_series-expected.txt:
        * platform/gtk/css1/box_properties/float_margin-expected.txt:
        * platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
        * platform/gtk/css1/box_properties/height-expected.txt:
        * platform/gtk/css1/box_properties/margin-expected.txt:
        * platform/gtk/css1/box_properties/margin_bottom-expected.txt:
        * platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt:
        * platform/gtk/css1/box_properties/margin_inline-expected.txt:
        * platform/gtk/css1/box_properties/margin_left-expected.txt:
        * platform/gtk/css1/box_properties/margin_left_inline-expected.txt:
        * platform/gtk/css1/box_properties/margin_right-expected.txt:
        * platform/gtk/css1/box_properties/margin_right_inline-expected.txt:
        * platform/gtk/css1/box_properties/margin_top-expected.txt:
        * platform/gtk/css1/box_properties/margin_top_inline-expected.txt:
        * platform/gtk/css1/box_properties/padding-expected.txt:
        * platform/gtk/css1/box_properties/padding_bottom-expected.txt:
        * platform/gtk/css1/box_properties/padding_bottom_inline-expected.txt:
        * platform/gtk/css1/box_properties/padding_inline-expected.txt:
        * platform/gtk/css1/box_properties/padding_left-expected.txt:
        * platform/gtk/css1/box_properties/padding_left_inline-expected.txt:
        * platform/gtk/css1/box_properties/padding_right-expected.txt:
        * platform/gtk/css1/box_properties/padding_right_inline-expected.txt:
        * platform/gtk/css1/box_properties/padding_top-expected.txt:
        * platform/gtk/css1/box_properties/padding_top_inline-expected.txt:
        * platform/gtk/css1/box_properties/width-expected.txt:
        * platform/gtk/css1/cascade/cascade_order-expected.txt:
        * platform/gtk/css1/cascade/important-expected.txt:
        * platform/gtk/css1/classification/display-expected.txt:
        * platform/gtk/css1/classification/list_style-expected.txt:
        * platform/gtk/css1/classification/list_style_image-expected.txt:
        * platform/gtk/css1/classification/list_style_position-expected.txt:
        * platform/gtk/css1/classification/list_style_type-expected.txt:
        * platform/gtk/css1/classification/white_space-expected.txt:
        * platform/gtk/css1/color_and_background/background-expected.txt:
        * platform/gtk/css1/color_and_background/background_attachment-expected.txt:
        * platform/gtk/css1/color_and_background/background_color-expected.txt:
        * platform/gtk/css1/color_and_background/background_image-expected.txt:
        * platform/gtk/css1/color_and_background/background_position-expected.txt:
        * platform/gtk/css1/color_and_background/background_repeat-expected.txt:
        * platform/gtk/css1/color_and_background/color-expected.txt:
        * platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt:
        * platform/gtk/css1/font_properties/font-expected.txt:
        * platform/gtk/css1/font_properties/font_family-expected.txt:
        * platform/gtk/css1/font_properties/font_size-expected.txt:
        * platform/gtk/css1/font_properties/font_style-expected.txt:
        * platform/gtk/css1/font_properties/font_variant-expected.txt:
        * platform/gtk/css1/font_properties/font_weight-expected.txt:
        * platform/gtk/css1/formatting_model/canvas-expected.txt:
        * platform/gtk/css1/formatting_model/floating_elements-expected.txt:
        * platform/gtk/css1/formatting_model/height_of_lines-expected.txt:
        * platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt:
        * platform/gtk/css1/formatting_model/inline_elements-expected.txt:
        * platform/gtk/css1/formatting_model/replaced_elements-expected.txt:
        * platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
        * platform/gtk/css1/pseudo/anchor-expected.txt:
        * platform/gtk/css1/pseudo/firstletter-expected.txt:
        * platform/gtk/css1/pseudo/firstline-expected.txt:
        * platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
        * platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
        * platform/gtk/css1/text_properties/letter_spacing-expected.txt:
        * platform/gtk/css1/text_properties/line_height-expected.txt:
        * platform/gtk/css1/text_properties/text_align-expected.txt:
        * platform/gtk/css1/text_properties/text_decoration-expected.txt:
        * platform/gtk/css1/text_properties/text_indent-expected.txt:
        * platform/gtk/css1/text_properties/text_transform-expected.txt:
        * platform/gtk/css1/text_properties/vertical_align-expected.txt:
        * platform/gtk/css1/text_properties/word_spacing-expected.txt:
        * platform/gtk/css1/units/color_units-expected.txt:
        * platform/gtk/css1/units/length_units-expected.txt:
        * platform/gtk/css1/units/percentage_units-expected.txt:
        * platform/gtk/css1/units/urls-expected.txt:
        * platform/gtk/css3/css3-modsel-33-expected.txt:
        * platform/gtk/css3/css3-modsel-35-expected.txt:
        * platform/gtk/css3/css3-modsel-36-expected.txt:
        * platform/gtk/css3/css3-modsel-37-expected.txt:
        * platform/gtk/editing/deleting/4922367-expected.txt:
        * platform/gtk/editing/deleting/5026848-1-expected.txt:
        * platform/gtk/editing/deleting/5026848-2-expected.txt:
        * platform/gtk/editing/deleting/5026848-3-expected.txt:
        * platform/gtk/editing/deleting/5032066-expected.txt:
        * platform/gtk/editing/deleting/5091898-expected.txt:
        * platform/gtk/editing/deleting/5099303-expected.txt:
        * platform/gtk/editing/deleting/5115601-expected.txt:
        * platform/gtk/editing/deleting/5126166-expected.txt:
        * platform/gtk/editing/deleting/5156801-2-expected.txt:
        * platform/gtk/editing/deleting/5206311-1-expected.txt:
        * platform/gtk/editing/deleting/5206311-2-expected.txt:
        * platform/gtk/editing/deleting/5272440-expected.txt:
        * platform/gtk/editing/deleting/5300379-expected.txt:
        * platform/gtk/editing/deleting/5369009-expected.txt:
        * platform/gtk/editing/deleting/5390681-2-expected.txt:
        * platform/gtk/editing/deleting/5433862-2-expected.txt:
        * platform/gtk/editing/deleting/5483370-expected.txt:
        * platform/gtk/editing/deleting/delete-3608430-fix-expected.txt:
        * platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
        * platform/gtk/editing/deleting/delete-3959464-fix-expected.txt:
        * platform/gtk/editing/deleting/delete-and-undo-expected.txt:
        * platform/gtk/editing/deleting/delete-block-contents-003-expected.txt:
        * platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt:
        * platform/gtk/editing/deleting/delete-block-merge-contents-012-expected.txt:
        * platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt:
        * platform/gtk/editing/deleting/delete-block-merge-contents-014-expected.txt:
        * platform/gtk/editing/deleting/delete-block-merge-contents-015-expected.txt:
        * platform/gtk/editing/deleting/delete-block-merge-contents-016-expected.txt:
        * platform/gtk/editing/deleting/delete-block-merge-contents-017-expected.txt:
        * platform/gtk/editing/deleting/delete-br-001-expected.txt:
        * platform/gtk/editing/deleting/delete-br-002-expected.txt:
        * platform/gtk/editing/deleting/delete-br-003-expected.txt:
        * platform/gtk/editing/deleting/delete-br-004-expected.txt:
        * platform/gtk/editing/deleting/delete-br-005-expected.txt:
        * platform/gtk/editing/deleting/delete-br-006-expected.txt:
        * platform/gtk/editing/deleting/delete-br-007-expected.txt:
        * platform/gtk/editing/deleting/delete-br-010-expected.txt:
        * platform/gtk/editing/deleting/delete-br-013-expected.txt:
        * platform/gtk/editing/deleting/delete-by-word-001-expected.txt:
        * platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt:
        * platform/gtk/editing/deleting/delete-line-001-expected.txt:
        * platform/gtk/editing/deleting/delete-line-002-expected.txt:
        * platform/gtk/editing/deleting/delete-line-005-expected.txt:
        * platform/gtk/editing/deleting/delete-line-006-expected.txt:
        * platform/gtk/editing/deleting/delete-line-007-expected.txt:
        * platform/gtk/editing/deleting/delete-line-008-expected.txt:
        * platform/gtk/editing/deleting/delete-line-009-expected.txt:
        * platform/gtk/editing/deleting/delete-line-010-expected.txt:
        * platform/gtk/editing/deleting/delete-line-011-expected.txt:
        * platform/gtk/editing/deleting/delete-line-012-expected.txt:
        * platform/gtk/editing/deleting/delete-line-013-expected.txt:
        * platform/gtk/editing/deleting/delete-line-014-expected.txt:
        * platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
        * platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
        * platform/gtk/editing/deleting/delete-listitem-001-expected.txt:
        * platform/gtk/editing/deleting/delete-listitem-002-expected.txt:
        * platform/gtk/editing/deleting/delete-to-end-of-paragraph-expected.txt:
        * platform/gtk/editing/deleting/delete-to-select-table-expected.txt:
        * platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt:
        * platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt:
        * platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt:
        * platform/gtk/editing/deleting/forward-delete-expected.txt:
        * platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt:
        * platform/gtk/editing/deleting/move-nodes-001-expected.txt:
        * platform/gtk/editing/deleting/smart-delete-003-expected.txt:
        * platform/gtk/editing/deleting/smart-delete-004-expected.txt:
        * platform/gtk/editing/deleting/type-delete-after-quote-expected.txt:
        * platform/gtk/editing/execCommand/4580583-1-expected.txt:
        * platform/gtk/editing/execCommand/4580583-2-expected.txt:
        * platform/gtk/editing/execCommand/4747450-expected.txt:
        * platform/gtk/editing/execCommand/4916402-expected.txt:
        * platform/gtk/editing/execCommand/4916541-expected.txt:
        * platform/gtk/editing/execCommand/4924441-expected.txt:
        * platform/gtk/editing/execCommand/5080333-1-expected.txt:
        * platform/gtk/editing/execCommand/5080333-2-expected.txt:
        * platform/gtk/editing/execCommand/5136770-expected.txt:
        * platform/gtk/editing/execCommand/5138441-expected.txt:
        * platform/gtk/editing/execCommand/5142012-1-expected.txt:
        * platform/gtk/editing/execCommand/5142012-2-expected.txt:
        * platform/gtk/editing/execCommand/5190926-expected.txt:
        * platform/gtk/editing/execCommand/5481523-expected.txt:
        * platform/gtk/editing/execCommand/5482023-expected.txt:
        * platform/gtk/editing/execCommand/5569741-expected.txt:
        * platform/gtk/editing/inserting/12882-expected.txt:
        * platform/gtk/editing/inserting/4840662-expected.txt:
        * platform/gtk/editing/inserting/4875189-1-expected.txt:
        * platform/gtk/editing/inserting/4875189-2-expected.txt:
        * platform/gtk/editing/inserting/4959067-expected.txt:
        * platform/gtk/editing/inserting/4960120-2-expected.txt:
        * platform/gtk/editing/inserting/5002441-expected.txt:
        * platform/gtk/editing/inserting/5058163-1-expected.txt:
        * platform/gtk/editing/inserting/5058163-2-expected.txt:
        * platform/gtk/editing/inserting/5156401-2-expected.txt:
        * platform/gtk/editing/inserting/5418891-expected.txt:
        * platform/gtk/editing/inserting/5510537-expected.txt:
        * platform/gtk/editing/inserting/5549929-2-expected.txt:
        * platform/gtk/editing/inserting/5549929-3-expected.txt:
        * platform/gtk/editing/inserting/6703873-expected.txt:
        * platform/gtk/editing/inserting/editable-inline-element-expected.txt:
        * platform/gtk/editing/inserting/edited-whitespace-1-expected.txt:
        * platform/gtk/editing/inserting/insert-3800346-fix-expected.txt:
        * platform/gtk/editing/inserting/insert-3851164-fix-expected.txt:
        * platform/gtk/editing/inserting/insert-3907422-fix-expected.txt:
        * platform/gtk/editing/inserting/insert-div-009-expected.txt:
        * platform/gtk/editing/inserting/insert-div-024-expected.txt:
        * platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt:
        * platform/gtk/editing/inserting/redo-expected.txt:
        * platform/gtk/editing/inserting/typing-002-expected.txt:
        * platform/gtk/editing/pasteboard/4076267-2-expected.txt:
        * platform/gtk/editing/pasteboard/4076267-3-expected.txt:
        * platform/gtk/editing/pasteboard/4076267-expected.txt:
        * platform/gtk/editing/pasteboard/5032095-expected.txt:
        * platform/gtk/editing/pasteboard/5071074-2-expected.txt:
        * platform/gtk/editing/pasteboard/5075944-3-expected.txt:
        * platform/gtk/editing/pasteboard/5089327-expected.txt:
        * platform/gtk/editing/pasteboard/5134759-expected.txt:
        * platform/gtk/editing/pasteboard/5156401-1-expected.txt:
        * platform/gtk/editing/pasteboard/5387578-expected.txt:
        * platform/gtk/editing/pasteboard/5483567-expected.txt:
        * platform/gtk/editing/pasteboard/7955-expected.txt:
        * platform/gtk/editing/pasteboard/cut-text-001-expected.txt:
        * platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt:
        * platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
        * platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
        * platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
        * platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
        * platform/gtk/editing/pasteboard/innerText-inline-table-expected.txt:
        * platform/gtk/editing/pasteboard/paste-blockquote-1-expected.txt:
        * platform/gtk/editing/pasteboard/paste-blockquote-2-expected.txt:
        * platform/gtk/editing/pasteboard/paste-blockquote-3-expected.txt:
        * platform/gtk/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
        * platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt:
        * platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt:
        * platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
        * platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt:
        * platform/gtk/editing/pasteboard/paste-text-001-expected.txt:
        * platform/gtk/editing/pasteboard/paste-text-002-expected.txt:
        * platform/gtk/editing/pasteboard/paste-text-003-expected.txt:
        * platform/gtk/editing/pasteboard/paste-text-004-expected.txt:
        * platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
        * platform/gtk/editing/pasteboard/paste-text-006-expected.txt:
        * platform/gtk/editing/pasteboard/paste-text-007-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 5 Nov 2010 11:10:15 +0000 (11:10 +0000)]
2010-11-05  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Avoid font hinting in the DRT
        https://bugs.webkit.org/show_bug.cgi?id=48548

        Change the settings to avoid font hinting, it was causing
        different results depending on the distribution.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (initializeGtkFontSettings):
        * DumpRenderTree/gtk/fonts/fonts.conf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 5 Nov 2010 10:30:28 +0000 (10:30 +0000)]
2010-11-05  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: inspector lags on large resources with numerous <script> tags.
        https://bugs.webkit.org/show_bug.cgi?id=49060

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 5 Nov 2010 10:15:23 +0000 (10:15 +0000)]
2010-11-05  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by David Kilzer.

        Replace ARRAYSIZE with WTF_ARRAY_LENGTH
        https://bugs.webkit.org/show_bug.cgi?id=48903

        * platform/UUID.cpp:
        (WebCore::createCanonicalUUIDString):
        * platform/graphics/chromium/FontCacheChromiumWin.cpp:
        (WebCore::FontCache::getFontDataForCharacters):
        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::FontCache::getLastResortFallbackFont):
        * platform/graphics/win/IconWin.cpp:
        (WebCore::Icon::createIconForFiles):
        * platform/win/ClipboardUtilitiesWin.cpp:
        (WebCore::getWebLocData):
        * platform/win/ClipboardWin.cpp:
        (WebCore::createGlobalHDropContent):
        (WebCore::createGlobalImageFileDescriptor):
        (WebCore::ClipboardWin::files):
        (WebCore::ClipboardWin::writeURL):
        * platform/win/DragDataWin.cpp:
        (WebCore::DragData::asFilenames):
        * platform/win/FileSystemWin.cpp:
        (WebCore::safeCreateFile):
2010-11-05  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by David Kilzer.

        Replace ARRAYSIZE with WTF_ARRAY_LENGTH
        https://bugs.webkit.org/show_bug.cgi?id=48903

        * WebCoreSupport/EditorClientEfl.cpp:
        (WebCore::EditorClientEfl::interpretKeyEvent):
2010-11-05  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by David Kilzer.

        Replace ARRAYSIZE with WTF_ARRAY_LENGTH
        https://bugs.webkit.org/show_bug.cgi?id=48903

        * WebCoreSupport/WebChromeClient.cpp:
        (WebChromeClient::exceededDatabaseQuota):
        * WebKitDLL.cpp:
        (DllGetClassObject):
        * WebView.cpp:
        (WebView::mouseWheel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ukai@chromium.org [Fri, 5 Nov 2010 09:47:31 +0000 (09:47 +0000)]
Unreviewed.

Fix wrong test_expectation format.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Fri, 5 Nov 2010 09:42:42 +0000 (09:42 +0000)]
2010-11-05  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Dirk Schulze.

        Bug 48979 - [Chromium] SVGListPropertyTearOff.h: function commitChange ASSERTs on Win & Mac
        https://bugs.webkit.org/show_bug.cgi?id=48979

        Remove Chromium expectation entry.

        * platform/chromium/test_expectations.txt:
2010-11-05  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Dirk Schulze.

        Bug 48979 - [Chromium] SVGListPropertyTearOff.h: function commitChange ASSERTs on Win & Mac
        https://bugs.webkit.org/show_bug.cgi?id=48979

        Function removeItemValuesAndWrappers(): Move code out of 'if' statement so that
        'wrappers' and 'values' stay synced.

        test: svg/dom/baseVal-animVal-crash.html doesn't ASSERT

        * svg/properties/SVGListProperty.h:
        (WebCore::SVGListProperty::removeItemValuesAndWrappers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 5 Nov 2010 09:14:12 +0000 (09:14 +0000)]
2010-11-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode
        https://bugs.webkit.org/show_bug.cgi?id=49051

        This is a speculative fix.  The unit tests cover these methods, however
        I don't know if this will fully stop the system.log spam.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, updating Chromium expectations.
ukai@chromium.org [Fri, 5 Nov 2010 09:08:41 +0000 (09:08 +0000)]
Unreviewed, updating Chromium expectations.

Add failure for crbug 62025 and 62026

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 John Reck <jreck@google.com>
commit-queue@webkit.org [Fri, 5 Nov 2010 08:29:28 +0000 (08:29 +0000)]
2010-11-05  John Reck  <jreck@google.com>

        Reviewed by Nikolas Zimmermann.

        The change to SVGPropertyTearOff by CodeGeneratorV8.pm caused two build failures
        for Android. One was a missing SVGPropertyTearOff.h include, the other was a
        missing forward declaration of FloatRect. Seems to be the result of:
        https://bugs.webkit.org/show_bug.cgi?id=48204

        Bug: https://bugs.webkit.org/show_bug.cgi?id=49025

        No tests needed, fixes build issue.

        * bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Rob Buis <rwlbuis@gmail.com>
rwlbuis@webkit.org [Fri, 5 Nov 2010 08:04:51 +0000 (08:04 +0000)]
2010-11-05  Rob Buis  <rwlbuis@gmail.com>

        Reviewed by David Hyatt.

        CSSRule#parentRule always null
        https://bugs.webkit.org/show_bug.cgi?id=46228

        Ensure MediaList child rules have the MediaList set as parent
        in order to correct their parentRule correctness.

        Test: fast/dom/css-mediarule-parentRule.html

        * css/CSSMediaRule.cpp:
        (WebCore::CSSMediaRule::CSSMediaRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-05 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 5 Nov 2010 07:58:02 +0000 (07:58 +0000)]
2010-11-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add basic support for showing bot id on /queue-status/ pages
        https://bugs.webkit.org/show_bug.cgi?id=49037

        This support is really simple.  Eventually we'll want to
        show the bot id in the lock table too, but we don't have
        that information stored in the server yet.

        * QueueStatusServer/handlers/queuestatus.py:
        * QueueStatusServer/handlers/queuestatus_unittest.py: Added.
        * QueueStatusServer/templates/includes/singlequeuestatus.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-03 Antonio Gomes <tonikitoo@webkit.org>, Andre Pedralho <andre.pedralho...
tonikitoo@webkit.org [Fri, 5 Nov 2010 05:08:02 +0000 (05:08 +0000)]
2010-11-03  Antonio Gomes  <tonikitoo@webkit.org>, Andre Pedralho  <andre.pedralho@gmail.com>

        Reviewed by Kenneth Rohde Christiansen and Antti Koivisto.

        [Qt] Making effective use of nodesFromRect.
        https://bugs.webkit.org/show_bug.cgi?id=44089

        Patch adds a helper class (named TouchAdjuster) to improve tap actions
        on mobile touch devices. TouchAdjuster makes use of the newly added rect
        based hit test extension through the Document::nodesFromRect method.
        Given a rectangle as input, nodesFromRect returns a z-index ordered list
        of nodes whose boundaries intersect the rectangle.

        Basically the TouchAdjuster class intercepts the QGraphicsSceneMouseEvent
        passed to both QWebPagePrivate::mouse{Press,Release}Event methods before
        they are passed down to WebCore. The goal is to infer the target click position.
        For that, a rectangle is built up using the event position as a center point and
        expanding it based on the values and directions set in the Platform Plugin
        QWebTouchModifier::hitTestPadding.

        TouchAdjuster iterates over the list of nodes returned by nodesFromRect and
        picks the clickable one that has the largest intersection area with the hit
        test rectangle. The target position is then the center point of this intersection
        area.

        In case of no clickable node intersects the hit test area, the click position
        is not altered.

        TouchAdjuster is *only* working for QGraphicsWebView based views.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::mousePressEvent):
        (QWebPagePrivate::mouseReleaseEvent):
        (QWebPagePrivate::adjustPointForClicking):
        (QWebPagePrivate::TouchAdjuster::TouchAdjuster):
        (QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
        (isClickableElement):
        (hasMouseListener):
        (isValidFrameOwner):
        (nodeToElement):
        * Api/qwebpage_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-04 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 5 Nov 2010 04:58:51 +0000 (04:58 +0000)]
2010-11-04  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        Expectation of /editing/spelling/spelling-textarea.html is confusing
        https://bugs.webkit.org/show_bug.cgi?id=48818

        - Turned spelling-contenteditable.html and spelling-textarea.html into
          single script-test named spelling-hasspellingmarker.html,
          which uses shouldBe() family for the assertion. The original tests
          misused testPassed() for printing.
        - Added a test for <input>, which possibly goes different path from
          editing <textarea> and @contentEditable.
        - Added a "false" case test to catch the error that results true for anything.

        * editing/spelling/script-tests/spelling-hasspellingmarker.js: Added.
        * editing/spelling/spelling-contenteditable-expected.txt: Removed.
        * editing/spelling/spelling-contenteditable.html: Removed.
        * editing/spelling/spelling-hasspellingmarker-expected.txt: Added.
        * editing/spelling/spelling-hasspellingmarker.html: Added.
        * editing/spelling/spelling-textarea-expected.txt: Removed.
        * editing/spelling/spelling-textarea.html: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-04 usaini <usaini08@gmail.com>
commit-queue@webkit.org [Fri, 5 Nov 2010 04:47:44 +0000 (04:47 +0000)]
2010-11-04  usaini  <usaini08@gmail.com>

        Reviewed by Antonio Gomes.

        WebWindowFeatures has a faulty constructor for WebCore::WindowFeatures
        https://bugs.webkit.org/show_bug.cgi?id=48035

        * public/WebWindowFeatures.h:
        (WebKit::WebWindowFeatures::WebWindowFeatures): updated the constructor
        that takes in a WebCore::WindowFeature and had it copy all the variables
        over properly so that after calling the constructor WebWindowFeatures is
        always in a valid state. Before, the x,y,width,height booleans may be true, but
        the corresponding int values would not be updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-04 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Fri, 5 Nov 2010 04:41:42 +0000 (04:41 +0000)]
2010-11-04  Antonio Gomes  <agomes@rim.com>

        Rubber-stamped by Martin Robinson.

        [Gtk] fast/events/spatial-navigation/snav-iframe-flattening-simple.html fails
        https://bugs.webkit.org/show_bug.cgi?id=47587

        Frame flattening support was added to GTK+ by r69919 in bug 38650. Tests passes now.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-04 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 5 Nov 2010 04:33:53 +0000 (04:33 +0000)]
2010-11-04  Xan Lopez  <xlopez@igalia.com>

        Fix the GTK+ build.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-20 Chang Shu <chang.shu@nokia.com>, Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Fri, 5 Nov 2010 04:31:22 +0000 (04:31 +0000)]
2010-10-20  Chang Shu  <chang.shu@nokia.com>, Antonio Gomes <tonikitoo@webkit.org>

        Reviewed by Simon Fraser.

        Spatial Navigation: add support to <input type=text> and <textarea>
        https://bugs.webkit.org/show_bug.cgi?id=37153

        Before this patch, the focus cannot move away from input box once it is in. This patch allows focus
        move to neighbor nodes when the caret reaches the edge of the texts. This patch does not support yet
        cases where the focused <input> has a JS handler for the arrow keys.

        WebCore:

        Tests: fast/events/spatial-navigation/snav-input.html
        fast/events/spatial-navigation/snav-textarea.html

        * editing/EditorCommand.cpp:
        (WebCore::executeMoveDown):
        (WebCore::executeMoveLeft):
        (WebCore::executeMoveRight):
        (WebCore::executeMoveUp):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modify):

        WebKit/qt:

        * WebCoreSupport/EditorClientQt.cpp:
        WebCore::EditorClientQt::handleKeyboardEvent):

        LayoutTests:

        * fast/events/spatial-navigation/snav-input-expected.txt: Added.
        * fast/events/spatial-navigation/snav-input.html: Added.
        * fast/events/spatial-navigation/snav-textarea-expected.txt: Added.
        * fast/events/spatial-navigation/snav-textarea.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-04 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 5 Nov 2010 04:07:14 +0000 (04:07 +0000)]
2010-11-04  Martin Robinson  <mrobinson@igalia.com>

        Skip two new tests. One of which is only failing on the
        bots and the other which uses the meter element, which is
        currently unsupported on GTK+.

        * platform/gtk/Skipped: Skip two more tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
mitz@apple.com [Fri, 5 Nov 2010 03:58:41 +0000 (03:58 +0000)]
Build fix.

* editing/Editor.cpp:
(WebCore::Editor::dismissCorrectionPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoreversion bubble in WebViews
mitz@apple.com [Fri, 5 Nov 2010 03:48:05 +0000 (03:48 +0000)]
reversion bubble in WebViews
https://bugs.webkit.org/show_bug.cgi?id=47630
<rdar://problem/8530960>

Patch by Jia Pu <jpu@apple.com> on 2010-11-04
Reviewed by Dan Bernstein.

WebCore:

Added manual test:
manual-tests/autocorrection/continue-typing-to-dismiss-reversion.html
manual-tests/autocorrection/delete-to-dismiss-reversion.html
manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html
manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html
manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html

We can only manully test this feature for two reasons:
1. On Mac OS X, the result of spell checking is partly determined by past user usage. We can't
   realiably generating test cases until we can disable user custom data during spell checking.
2. To exerciese this feature, we need a minimum of 0.3 second delay using WebCore timer.

This patch is to add reversion to correction panel. It consists of following major code changes:
1. Collected all autocorrection related member variables in Editor into a CorrectionPanelInfo
   class to improve readability.
2. Changed signature of Editor::startCorrectionPanelTimer() to allow caller to specify the
   type of correction panel--regular correction or reversion.
3. Made necessary changes to adopt reversion API in AppKit.
4. Use SUPPORT_CORRECTION_PANEL macro to improve readability.

* GNUmakefile.am: Added CorrectionPanelInfo.h.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj:
* editing/CorrectionPanelInfo.h: Added.
* editing/Editor.cpp:
(WebCore::Editor::respondToChangedSelection): Start correction panel timer for reversion when
  the new selection is a caret selection at end of a previously corrected word.
(WebCore::Editor::appliedEditing): Stop timer at the beginning of the method instead of at the end.
(WebCore::Editor::~Editor): Adopted new method dismissCorrectionPanel().
(WebCore::Editor::markMisspellingsAfterTypingToPosition): Adopted new method applyCorrectionPanelInfo().
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Code change for new m_correctionPanelInfo
  member variable.
(WebCore::Editor::correctionPanelTimerFired): Change to handle reversion panel type.
(WebCore::Editor::handleRejectedCorrection): Ditto.
(WebCore::Editor::startCorrectionPanelTimer): Changed signature to allow passing in panel type.
(WebCore::Editor::stopCorrectionPanelTimer): Adopted macro SUPPORT_CORRECTION_PANEL.
(WebCore::Editor::handleCancelOperation): Ditto.
(WebCore::Editor::isShowingCorrectionPanel): Ditto.
(WebCore::Editor::dismissCorrectionPanel): Update m_correctionPanelInfo when correction panel
  is dismissed.
(WebCore::Editor::applyCorrectionPanelInfo): Factored out code that applies autocorrection.
(WebCore::Editor::changeSelectionAfterCommand): Adopt macro SUPPORT_CORRECTION_PANEL.
* editing/Editor.h: Adopted CorrectionPanelInfo and add new member methods.
* editing/EditorCommand.cpp: Adopted macro SUPPORT_CORRECTION_PANEL
(WebCore::createCommandMap):
* editing/TypingCommand.cpp: Adopted macro SUPPORT_CORRECTION_PANEL and new signature of
  startCorrectionPanelTimer().
(WebCore::TypingCommand::markMisspellingsAfterTyping):
* loader/EmptyClients.h:
(WebCore::EmptyEditorClient::showCorrectionPanel): Adopted new signature of base class method.
(WebCore::EmptyEditorClient::dismissCorrectionPanel):  Ditto.
* manual-tests/autocorrection/continue-typing-to-dismiss-reversion.html: Added.
* manual-tests/autocorrection/delete-to-dismiss-reversion.html: Added.
* manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html: Added.
* manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html: Added.
* manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html: Added.
* page/EditorClient.h: Changed signature of showCorrectionPanel() and dismissCorrectionPanel().
* platform/graphics/mac/GraphicsContextMac.mm: Added comment to improve readability.
(WebCore::GraphicsContext::drawLineForTextChecking):

WebKit/mac:

This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail.

* WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method.
* WebCoreSupport/WebEditorClient.mm: Adopted new signature of base class method. And code
  change to use new reversion API in AppKit.
(WebEditorClient::WebEditorClient):
(WebEditorClient::~WebEditorClient):
(WebEditorClient::respondToChangedSelection):
(WebEditorClient::showCorrectionPanel):
(WebEditorClient::dismissCorrectionPanel):
(WebEditorClient::isShowingCorrectionPanel):

WebKit2:

This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail.

* WebProcess/WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method.
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: Ditto.
(WebKit::WebEditorClient::showCorrectionPanel):
(WebKit::WebEditorClient::dismissCorrectionPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated test result from previous commit, as I removed tabs from the test before...
mitz@apple.com [Fri, 5 Nov 2010 03:39:14 +0000 (03:39 +0000)]
Updated test result from previous commit, as I removed tabs from the test before committing
but forgot to update the result.

* platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-04 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 5 Nov 2010 02:51:58 +0000 (02:51 +0000)]
2010-11-04  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        Create a filesystem wrapper that we can use to enforce
        particular conventions and use for mocking and dependency
        injection down the line.

        https://bugs.webkit.org/show_bug.cgi?id=48144

        * Scripts/webkitpy/common/system/filesystem.py: Added.
        * Scripts/webkitpy/common/system/filesystem_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore: Made table layout and painting work with all writing modes. Hit-testing...
mitz@apple.com [Fri, 5 Nov 2010 02:43:17 +0000 (02:43 +0000)]
WebCore: Made table layout and painting work with all writing modes. Hit-testing, repainting, tables
where some elements have their own layers, and cells whose writing mode differs from the
table’s are not supported yet.

Reviewed by Dave Hyatt.

Make tables work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46417

Tests: fast/table/027-vertical.html
       fast/table/028-vertical.html
       fast/table/035-vertical.html
       fast/table/038-vertical.html
       fast/table/040-vertical.html
       fast/table/auto-with-percent-height-vertical.html
       fast/table/border-collapsing/001-vertical.html
       fast/table/border-collapsing/002-vertical.html
       fast/table/border-collapsing/003-vertical.html
       fast/table/border-collapsing/004-vertical.html
       fast/table/border-collapsing/border-collapsing-head-foot-vertical.html
       fast/table/border-collapsing/equal-precedence-resolution-vertical.html
       fast/table/border-collapsing/rtl-border-collapsing-vertical.html
       fast/table/colspanMinWidth-vertical.html
       fast/table/fixed-with-auto-with-colspan-vertical.html
       fast/table/growCellForImageQuirk-vertical.html
       fast/table/height-percent-test-vertical.html
       fast/table/percent-widths-stretch-vertical.html
       fast/table/rowspan-paint-order-vertical.html
       fast/table/table-display-types-vertical.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle): Changed to allow all writing modes for tables,
make row groups, rows, column groups and columns inherit the table’s writing mode. For now,
make cells do this too.
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::parseMappedAttribute): Map align=center using logical properties.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable): Initialize m_borderStart and m_borderEnd.
(WebCore::RenderTable::styleDidChange): Changed the rule for when to use auto layout to look
at the logical width instead of the width.
(WebCore::RenderTable::computeLogicalWidth): Uses logical widths and works with perpendicular
containing blocks.
(WebCore::RenderTable::layout): Use logical lengths.
(WebCore::RenderTable::setCellLogicalWidths): Renamed setCellWidths() to this and updated for
the renaming of RenderTableSection::setCellWidths().
(WebCore::RenderTable::paintObject): Account for flipped modes.
(WebCore::RenderTable::subtractCaptionRect): Added this helper method the considers writing modes.
(WebCore::RenderTable::paintBoxDecorations): Adopted subtractCaptionRect().
(WebCore::RenderTable::paintMask): Ditto.
(WebCore::RenderTable::computePreferredLogicalWidths): Updated for the renaming of
recalcHorizontalBorders().
(WebCore::RenderTable::calcBorderStart): Renamed calcBorderLeft() to this and changed it to use
borderStart(). Splits odd number of pixels based on the physical side.
(WebCore::RenderTable::calcBorderEnd): Similar.
(WebCore::RenderTable::recalcBordersInRowDirection): Renamed recalcHorizontalBorders() to this
and updated for other renames.
(WebCore::RenderTable::borderBefore): Replaced borderTop() with this.
(WebCore::RenderTable::borderAfter): Similar.
(WebCore::RenderTable::outerBorderBefore): Similar.
(WebCore::RenderTable::outerBorderAfter): Similar.
(WebCore::RenderTable::outerBorderStart): Similar.
(WebCore::RenderTable::outerBorderEnd): Similar.
(WebCore::RenderTable::firstLineBoxBaseline): Changed to use logical heights.
(WebCore::RenderTable::overflowClipRect): Account for writing modes.
* rendering/RenderTable.h:
(WebCore::RenderTable::borderStart):
(WebCore::RenderTable::borderEnd):
(WebCore::RenderTable::borderLeft):
(WebCore::RenderTable::borderRight):
(WebCore::RenderTable::borderTop):
(WebCore::RenderTable::borderBottom):
(WebCore::RenderTable::outerBorderLeft):
(WebCore::RenderTable::outerBorderRight):
(WebCore::RenderTable::outerBorderTop):
(WebCore::RenderTable::outerBorderBottom):
(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection): Changed to match its name.
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleWillChange): Changed to detect changes to logical height.
* rendering/RenderTableSection.cpp:
(WebCore::setRowLogicalHeightToRowStyleLogicalHeightIfNotRelative): Renamed and changed to use
logical heights.
(WebCore::RenderTableSection::RenderTableSection): Updated initializers for new member variables.
(WebCore::RenderTableSection::addChild): Updated for rename.
(WebCore::RenderTableSection::ensureRows): Ditto.
(WebCore::RenderTableSection::addCell): Ditto. Also use logical heights.
(WebCore::RenderTableSection::setCellLogicalWidths): Renamed setCellWidths() to this, changed
to use logical widths.
(WebCore::RenderTableSection::calcRowLogicalHeight): Added “logical” to the name. Updated with
logical heights.
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::recalcOuterBorder):
(WebCore::RenderTableSection::firstLineBoxBaseline):
(WebCore::RenderTableSection::paintCell):
(WebCore::RenderTableSection::recalcCells):
* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::outerBorderBefore):
(WebCore::RenderTableSection::outerBorderAfter):
(WebCore::RenderTableSection::outerBorderStart):
(WebCore::RenderTableSection::outerBorderEnd):

LayoutTests: Make tables work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46417

Reviewed by Dave Hyatt.

* fast/table/027-vertical.html: Copied from LayoutTests/fast/table/027.html.
* fast/table/028-vertical.html: Copied from LayoutTests/fast/table/028.html.
* fast/table/035-vertical.html: Copied from LayoutTests/fast/table/035.html.
* fast/table/038-vertical.html: Copied from LayoutTests/fast/table/038.html.
* fast/table/040-vertical.html: Copied from LayoutTests/fast/table/040.html.
* fast/table/auto-with-percent-height-vertical.html: Copied from LayoutTests/fast/table/auto-with-percent-height.html.
* fast/table/border-collapsing/001-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/001.html.
* fast/table/border-collapsing/002-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/002.html.
* fast/table/border-collapsing/003-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/003.html.
* fast/table/border-collapsing/004-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/004.html.
* fast/table/border-collapsing/border-collapsing-head-foot-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/border-collapsing-head-foot.html.
* fast/table/border-collapsing/equal-precedence-resolution-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/equal-precedence-resolution.html.
* fast/table/border-collapsing/rtl-border-collapsing-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/rtl-border-collapsing.html.
* fast/table/colspanMinWidth-vertical.html: Copied from LayoutTests/fast/table/colspanMinWidth.html.
* fast/table/fixed-with-auto-with-colspan-vertical.html: Copied from LayoutTests/fast/table/fixed-with-auto-with-colspan.html.
* fast/table/growCellForImageQuirk-vertical.html: Copied from LayoutTests/fast/table/growCellForImageQuirk.html.
* fast/table/height-percent-test-vertical.html: Copied from LayoutTests/fast/table/height-percent-test.html.
* fast/table/percent-widths-stretch-vertical.html: Copied from LayoutTests/fast/table/percent-widths-stretch.html.
* fast/table/rowspan-paint-order-vertical.html: Copied from LayoutTests/fast/table/rowspan-paint-order.html.
* fast/table/table-display-types-vertical.html: Copied from LayoutTests/fast/table/table-display-types.html.
* platform/mac/fast/table/027-vertical-expected.checksum: Added.
* platform/mac/fast/table/027-vertical-expected.png: Added.
* platform/mac/fast/table/027-vertical-expected.txt: Added.
* platform/mac/fast/table/028-vertical-expected.checksum: Added.
* platform/mac/fast/table/028-vertical-expected.png: Added.
* platform/mac/fast/table/028-vertical-expected.txt: Added.
* platform/mac/fast/table/035-vertical-expected.checksum: Added.
* platform/mac/fast/table/035-vertical-expected.png: Added.
* platform/mac/fast/table/035-vertical-expected.txt: Added.
* platform/mac/fast/table/038-vertical-expected.checksum: Added.
* platform/mac/fast/table/038-vertical-expected.png: Added.
* platform/mac/fast/table/038-vertical-expected.txt: Added.
* platform/mac/fast/table/040-vertical-expected.checksum: Added.
* platform/mac/fast/table/040-vertical-expected.png: Added.
* platform/mac/fast/table/040-vertical-expected.txt: Added.
* platform/mac/fast/table/auto-with-percent-height-vertical-expected.checksum: Added.
* platform/mac/fast/table/auto-with-percent-height-vertical-expected.png: Added.
* platform/mac/fast/table/auto-with-percent-height-vertical-expected.txt: Added.
* platform/mac/fast/table/border-collapsing/001-vertical-expected.checksum: Added.
* platform/mac/fast/table/border-collapsing/001-vertical-expected.png: Added.
* platform/mac/fast/table/border-collapsing/001-vertical-expected.txt: Added.
* platform/mac/fast/table/border-collapsing/002-vertical-expected.checksum: Added.
* platform/mac/fast/table/border-collapsing/002-vertical-expected.png: Added.
* platform/mac/fast/table/border-collapsing/002-vertical-expected.txt: Added.
* platform/mac/fast/table/border-collapsing/003-vertical-expected.checksum: Added.
* platform/mac/fast/table/border-collapsing/003-vertical-expected.png: Added.
* platform/mac/fast/table/border-collapsing/003-vertical-expected.txt: Added.
* platform/mac/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
* platform/mac/fast/table/border-collapsing/004-vertical-expected.png: Added.
* platform/mac/fast/table/border-collapsing/004-vertical-expected.txt: Added.
* platform/mac/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.checksum: Added.
* platform/mac/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png: Added.
* platform/mac/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt: Added.
* platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum: Added.
* platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Added.
* platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt: Added.
* platform/mac/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.checksum: Added.
* platform/mac/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png: Added.
* platform/mac/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt: Added.
* platform/mac/fast/table/colspanMinWidth-vertical-expected.checksum: Added.
* platform/mac/fast/table/colspanMinWidth-vertical-expected.png: Added.
* platform/mac/fast/table/colspanMinWidth-vertical-expected.txt: Added.
* platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.checksum: Added.
* platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.png: Added.
* platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Added.
* platform/mac/fast/table/growCellForImageQuirk-vertical-expected.checksum: Added.
* platform/mac/fast/table/growCellForImageQuirk-vertical-expected.png: Added.
* platform/mac/fast/table/growCellForImageQuirk-vertical-expected.txt: Added.
* platform/mac/fast/table/height-percent-test-vertical-expected.checksum: Added.
* platform/mac/fast/table/height-percent-test-vertical-expected.png: Added.
* platform/mac/fast/table/height-percent-test-vertical-expected.txt: Added.
* platform/mac/fast/table/percent-widths-stretch-vertical-expected.checksum: Added.
* platform/mac/fast/table/percent-widths-stretch-vertical-expected.png: Added.
* platform/mac/fast/table/percent-widths-stretch-vertical-expected.txt: Added.
* platform/mac/fast/table/rowspan-paint-order-vertical-expected.checksum: Added.
* platform/mac/fast/table/rowspan-paint-order-vertical-expected.png: Added.
* platform/mac/fast/table/rowspan-paint-order-vertical-expected.txt: Added.
* platform/mac/fast/table/table-display-types-vertical-expected.checksum: Added.
* platform/mac/fast/table/table-display-types-vertical-expected.png: Added.
* platform/mac/fast/table/table-display-types-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-04 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 5 Nov 2010 02:10:37 +0000 (02:10 +0000)]
2010-11-04  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        run_webkit_tests_unittest fails under Python 2.5
        https://bugs.webkit.org/show_bug.cgi?id=49043

        Switch from itertools.chain.from_iterable (which was added in 2.6)
        to using itertools.chain directly.

        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-04 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 5 Nov 2010 01:57:40 +0000 (01:57 +0000)]
2010-11-04  Kent Tamura  <tkent@chromium.org>

        Unreviewed, trivial test fix.

        Fix GTK build for http://trac.webkit.org/changeset/71373 .

        * GNUmakefile.am: Add HTMLOutputElement.{cpp,h}

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-04 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 5 Nov 2010 01:26:16 +0000 (01:26 +0000)]
2010-11-04  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed fix to webkit-patch rebaseline-server so that it runs under
        Python 2.5 (it needs an import to use the with statement).

        * Scripts/webkitpy/tool/commands/rebaselineserver.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-04 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 5 Nov 2010 01:23:54 +0000 (01:23 +0000)]
2010-11-04  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        Stale reference to RenderObject held as FrameView layoutRoot
        https://bugs.webkit.org/show_bug.cgi?id=48019

        * fast/dom/HTMLMeterElement/meter-element-with-child-crash-expected.txt: Added.
        * fast/dom/HTMLMeterElement/meter-element-with-child-crash.html: Added.
        * fast/dom/HTMLProgressElement/progress-element-with-child-crash-expected.txt: Added.
        * fast/dom/HTMLProgressElement/progress-element-with-child-crash.html: Added.
        * platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
2010-11-04  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        Stale reference to RenderObject held as FrameView layoutRoot
        https://bugs.webkit.org/show_bug.cgi?id=48019

        <progress> and <meter> shouldn't have children of its RenderObject,
        which caused unexpected result.
        This change suppresses child creation to prevent it.

        Tests: fast/dom/HTMLMeterElement/meter-element-with-child-crash.html
               fast/dom/HTMLProgressElement/progress-element-with-child-crash.html

        * rendering/RenderIndicator.h:
        (WebCore::RenderIndicator::canHaveChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-04 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 5 Nov 2010 01:18:37 +0000 (01:18 +0000)]
2010-11-04  Martin Robinson  <mrobinson@igalia.com>

        Unskip some passing tests and update some baselines.

        * platform/gtk/Skipped: Update skipped list.
        * platform/gtk/http/tests/misc/slow-loading-mask-expected.txt: Added.
        * platform/gtk/transforms/2d/transform-borderbox-expected.txt:
        * platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-04 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 5 Nov 2010 01:16:27 +0000 (01:16 +0000)]
2010-11-04  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Adam Barth.

        Use leakRef instead of releaseRef
        https://bugs.webkit.org/show_bug.cgi?id=48974

        Use leakRef instead of the deprecated releaseRef. This was renamed
        some time ago because 'releaseRef' is too close to 'release',
        which does something completely different.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-04 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 5 Nov 2010 01:05:35 +0000 (01:05 +0000)]
2010-11-04  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        new-run-webkit-tests: split out webkit-specific configuration stuff into a new module

        The current NRWT code has webkit-specific configuration code (like
        _script_path, default configuration, etc.) mixed in with
        layout-test-specific stuff in port/base. The configuration code
        should be split out into a separate module for easier mocking,
        testing, and isolation.

        https://bugs.webkit.org/show_bug.cgi?id=48264

        * Scripts/webkitpy/layout_tests/port/config.py: Added.
        * Scripts/webkitpy/layout_tests/port/config_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-04 Kenichi Ishibashi <bashi@google.com>
commit-queue@webkit.org [Fri, 5 Nov 2010 00:57:50 +0000 (00:57 +0000)]
2010-11-04  Kenichi Ishibashi  <bashi@google.com>

        Reviewed by Kent Tamura.

        [HTML5][Forms] Support for <output> element
        https://bugs.webkit.org/show_bug.cgi?id=29363

        Adds tests for the DOMSettableTokenList and the output element.

        * fast/dom/HTMLOutputElement/dom-settable-token-list-expected.txt: Added.
        * fast/dom/HTMLOutputElement/dom-settable-token-list.html: Added.
        * fast/dom/HTMLOutputElement/htmloutputelement-expected.txt: Added.
        * fast/dom/HTMLOutputElement/htmloutputelement-reset-event-expected.txt: Added.
        * fast/dom/HTMLOutputElement/htmloutputelement-reset-event.html: Added.
        * fast/dom/HTMLOutputElement/htmloutputelement-validity-expected.txt: Added.
        * fast/dom/HTMLOutputElement/htmloutputelement-validity.html: Added.
        * fast/dom/HTMLOutputElement/htmloutputelement-value-expected.txt: Added.
        * fast/dom/HTMLOutputElement/htmloutputelement-value.html: Added.
        * fast/dom/HTMLOutputElement/htmloutputelement.html: Added.
        * fast/dom/HTMLOutputElement/script-tests/dom-settable-token-list.js: Added.
        (createElement):
        * fast/dom/HTMLOutputElement/script-tests/htmloutputelement-reset-event.js: Added.
        * fast/dom/HTMLOutputElement/script-tests/htmloutputelement-validity.js: Added.
        * fast/dom/HTMLOutputElement/script-tests/htmloutputelement-value.js: Added.
        * fast/dom/Window/window-properties-expected.txt: Updated expectation.
        * fast/dom/Window/window-property-descriptors-expected.txt: Updated expectation.
        * fast/dom/prototype-inheritance-2-expected.txt: Updated expectation.
        * fast/dom/prototype-inheritance-expected.txt: Updated expectation.
        * fast/js/global-constructors-expected.txt: Updated expectation.
        * platform/chromium/fast/dom/prototype-inheritance-expected.txt: Updated expectation.
        * platform/gtk/fast/dom/Window/window-properties-expected.txt: Updated expectation.
        * platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Updated expectation.
        * platform/gtk/fast/dom/prototype-inheritance-expected.txt: Updated expectation.
        * platform/gtk/fast/js/global-constructors-expected.txt: Updated expectation.
        * platform/qt/fast/dom/Window/window-properties-expected.txt: Updated expectation.
        * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated expectation.
        * platform/qt/fast/dom/prototype-inheritance-expected.txt: Updated expectation.
        * platform/qt/fast/js/global-constructors-expected.txt: Updated expectation.
        * platform/win/fast/dom/Window/window-property-descriptors-expected.txt: Updated expectation.
        * platform/win/fast/dom/prototype-inheritance-2-expected.txt: Updated expectation.
        * platform/win/fast/dom/prototype-inheritance-expected.txt: Updated expectation.
        * platform/win/fast/js/global-constructors-expected.txt: Updated expectation.
2010-11-04  Kenichi Ishibashi  <bashi@google.com>

        Reviewed by Kent Tamura.

        [HTML5][Forms] Support for <output> element
        https://bugs.webkit.org/show_bug.cgi?id=29363

        Support for <output> element.

        Tests: fast/dom/HTMLOutputElement/dom-settable-token-list.html
               fast/dom/HTMLOutputElement/htmloutputelement-reset-event.html
               fast/dom/HTMLOutputElement/htmloutputelement-validity.html
               fast/dom/HTMLOutputElement/htmloutputelement-value.html
               fast/dom/HTMLOutputElement/htmloutputelement.html

        * Android.derived.jscbindings.mk: Added JSHTMLOutputElement.h.
        * Android.derived.v8bindings.mk: Added V8HTMLOutputElement.h.
        * Android.jscbindings.mk: Added JSHTMLOutputElementCustom.cpp.
        * Android.mk: Added HTMLOutputElement.cpp.
        * Android.v8bindings.mk: Added V8HTMLOutputElementCustom.cpp.
        * CMakeLists.txt: Added HTMLOutputElement.{idl,cpp} and JSHTMLOutputElementCustom.cpp.
        * DerivedSources.cpp: Added JSHTMLOutputElement.cpp.
        * DerivedSources.make: Added HTMLOutputElement entry.
        * GNUmakefile.am: Added JSHTMLOutputElement.{cpp,h}
        * WebCore.gypi: Added HTMLOutputElement.{idl,cpp,h}, JSHTMLOutputElementCustom.cpp and V8HTMLOutputElementCustom.cpp
        * WebCore.pri: Added HTMLOutputElement.idl.
        * WebCore.pro: Added V8HTMLOutputElementCustom.cpp, JSHTMLOutputElementCustom.cpp and HTMLOutputElement.cpp.
        * WebCore.vcproj/WebCore.vcproj: Added entries for JSHTMLOutputElement.{cpp,h} and JSHTMLOutputElementCustom.cpp.
        * WebCore.xcodeproj/project.pbxproj: Added entries for JSHTMLOutputElementCustom.cpp, HTMLOutputElement.{cpp,h,idl}, JSHTMLOutputElement.{cpp,h}
        * bindings/js/JSBindingsAllInOne.cpp: Added JSHTMLOutputElementCustom.cpp.
        * bindings/js/JSHTMLOutputElementCustom.cpp: Added.
        (WebCore::JSHTMLOutputElement::htmlFor):
        (WebCore::JSHTMLOutputElement::setHtmlFor):
        * bindings/v8/custom/V8DOMSettableTokenListCustom.cpp: Modified.
        (WebCore::V8DOMSettableTokenList::indexedPropertyGetter): Returns null if the index is out of range.
        * bindings/v8/custom/V8HTMLOutputElementCustom.cpp: Added.
        (WebCore::V8HTMLOutputElement::htmlForAccessorGetter):
        (WebCore::V8HTMLOutputElement::htmlForAccessorSetter):
        * css/html.css: Added a default style of output element.
        (output):
        * html/DOMSettableTokenList.cpp: Fix bugs.
        (WebCore::DOMSettableTokenList::item): Returns null string if the index is out of range.
        (WebCore::DOMSettableTokenList::addInternal): Added check m_tokens.isNull().
        (WebCore::DOMSettableTokenList::setValue): Set the value case sensitive.
        * html/HTMLOutputElement.cpp: Added.
        (WebCore::HTMLOutputElement::HTMLOutputElement):
        (WebCore::HTMLOutputElement::create):
        (WebCore::HTMLOutputElement::formControlType):
        (WebCore::HTMLOutputElement::parseMappedAttribute):
        (WebCore::HTMLOutputElement::htmlFor):
        (WebCore::HTMLOutputElement::setFor):
        (WebCore::HTMLOutputElement::setForm):
        (WebCore::HTMLOutputElement::childrenChanged):
        (WebCore::HTMLOutputElement::reset):
        (WebCore::HTMLOutputElement::value):
        (WebCore::HTMLOutputElement::setValue):
        (WebCore::HTMLOutputElement::defaultValue):
        (WebCore::HTMLOutputElement::setDefaultValue):
        (WebCore::HTMLOutputElement::setTextContentInternal):
        * html/HTMLOutputElement.h: Added.
        (WebCore::HTMLOutputElement::isEnumeratable):
        (WebCore::HTMLOutputElement::willValidate):
        * html/HTMLOutputElement.idl: Added.
        * html/HTMLTagNames.in: Added "output".
        * page/DOMWindow.idl: Added an attribute for HTMLOutputElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-04 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 5 Nov 2010 00:55:00 +0000 (00:55 +0000)]
2010-11-04  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Remove IMPLEMENTATION_COLOR_READ_FORMAT and TYPE
        https://bugs.webkit.org/show_bug.cgi?id=48938

        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv):
2010-11-04  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Remove IMPLEMENTATION_COLOR_READ_FORMAT and TYPE
        https://bugs.webkit.org/show_bug.cgi?id=48938

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::initializeNewContext):
        (WebCore::WebGLRenderingContext::getParameter):
        (WebCore::WebGLRenderingContext::readPixels):
        * html/canvas/WebGLRenderingContext.h:
        * html/canvas/WebGLRenderingContext.idl:
        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
        (WebCore::GraphicsContext3D::getIntegerv):
2010-11-04  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Remove IMPLEMENTATION_COLOR_READ_FORMAT and TYPE
        https://bugs.webkit.org/show_bug.cgi?id=48938

        * fast/canvas/webgl/read-pixels-pack-alignment-expected.txt:
        * fast/canvas/webgl/read-pixels-pack-alignment.html:
        * fast/canvas/webgl/webgl-specific-expected.txt:
        * fast/canvas/webgl/webgl-specific.html: Test two enums are undefined in WebGL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-04 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 5 Nov 2010 00:52:47 +0000 (00:52 +0000)]
2010-11-04  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        TypedArray should throw exception if length not a multiple of element size
        https://bugs.webkit.org/show_bug.cgi?id=45487

        * bindings/js/JSArrayBufferViewHelper.h:
        (WebCore::constructArrayBufferView):
        * bindings/v8/custom/V8ArrayBufferViewCustom.h:
        (WebCore::constructWebGLArray):
2010-11-04  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        TypedArray should throw exception if length not a multiple of element size
        https://bugs.webkit.org/show_bug.cgi?id=45487

        * fast/canvas/webgl/array-unit-tests-expected.txt:
        * fast/canvas/webgl/array-unit-tests.html: Test against the non-multiplication exception behavior.
        * fast/canvas/webgl/gl-enum-tests-expected.txt:
        * fast/canvas/webgl/gl-enum-tests.html: Fix the ArrayBuffer size so it won't throw an error with this patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-04 Kenneth Russell <kbr@google.com>
kbr@google.com [Fri, 5 Nov 2010 00:33:18 +0000 (00:33 +0000)]
2010-11-04  Kenneth Russell  <kbr@google.com>

        Reviewed by Adam Barth.

        [chromium] Mac: WebGL: all textured content is blue
        https://bugs.webkit.org/show_bug.cgi?id=49021

        Added support for 8-bit, little-endian CGImages. The previous
        image decode path used the default byte order, which is apparently
        big-endian.

        Tested with various WebGL content and layout tests in Chromium.
        Ran layout tests in WebKit and tested various WebGL content in
        Safari. Was not able to run layout tests with Chromium port of
        DumpRenderTree due to build failures currently in the tree.

        * platform/graphics/GraphicsContext3D.cpp:
        (WebCore::doPacking):
        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/cg/GraphicsContext3DCG.cpp:
        (WebCore::getSourceDataFormat):
        (WebCore::GraphicsContext3D::getImageData):
2010-11-04  Kenneth Russell  <kbr@google.com>

        Reviewed by Adam Barth.

        [chromium] Mac: WebGL: all textured content is blue
        https://bugs.webkit.org/show_bug.cgi?id=49021

        Updated expectations for WebGL layout tests which were affected by
        the image decoder change
        https://bugs.webkit.org/show_bug.cgi?id=47974 .

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-02 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 5 Nov 2010 00:28:27 +0000 (00:28 +0000)]
2010-11-02  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        Rebaseline server: initial framework
        https://bugs.webkit.org/show_bug.cgi?id=48892

        Adds the basic framework for the rebaseline server (details at
        http://webkit.org/b/47761). Includes the rebaseline-server webkit-patch
        command, which starts an HTTP server that can serve static files or
        invoke handler methods on a class.

        * Scripts/webkitpy/tool/commands/__init__.py:
        * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: Added.
        * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: Added.
        * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: Added.
        * Scripts/webkitpy/tool/commands/rebaselineserver.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71369 268f45cc-cd09-0410-ab3c-d52691b4dbfc