rniwa@webkit.org [Thu, 7 Nov 2013 03:49:35 +0000 (03:49 +0000)]
New flakiness dashboard should generate JSON in the background process
https://bugs.webkit.org/show_bug.cgi?id=123797
Reviewed by Alexey Proskuryakov.
* config.json: Add defaultBuildWaitInterval used by process-builds.php.
* init-database.sql: Add is_process column to builds table so that we can track of "unprocessed" builds.
* public/admin/process-builds.php: Added.
(process_latest_five_builds): Update flakiness states and generate JSONs for the latest five builds.
We go backwards in the time so that we don't end up infinite looping over a single build that fails.
(main): Call processed_builds with an exponential back off.
* public/api/report.php:
(store_results): No need to return build or builder ids.
(main): Don't update flakiness states or generate JSONs.
* public/include/test-results.php:
(add_build): Take the slave name; it doesn't make any sense to create a build without it and later
updating it in store_test_results.
(store_test_results): Once new test results are added, explicitly mark this build as unprocessed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Thu, 7 Nov 2013 03:39:52 +0000 (03:39 +0000)]
Optimize baselines: svg/W3C-I18N
Unreviewed; run "webkit-patch optimize-baselines svg/W3C-I18N"
* platform/efl/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Removed.
* platform/gtk/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed.
* svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt.
* svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt.
* svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt.
* svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt.
* svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt.
* svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt.
* svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt.
* svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt.
* svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt.
* svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt.
* svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt.
* svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt.
* svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt.
* svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt.
* svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt.
* svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt.
* svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt.
* svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt.
* svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt.
* svg/W3C-I18N/text-anchor-no-markup-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.txt.
* svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt.
* svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt.
* svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt.
* svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt.
* svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt.
* svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt.
* svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt.
* svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt.
* svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt.
* svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt.
* svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt.
* svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt.
* svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt.
* svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt.
* svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt.
* svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt.
* svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt.
* svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt.
* svg/W3C-I18N/tspan-direction-ltr-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-direction-ltr-expected.txt.
* svg/W3C-I18N/tspan-direction-rtl-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Thu, 7 Nov 2013 03:32:48 +0000 (03:32 +0000)]
InlineBox: Make paint() and nodeAtPoint() pure virtuals.
<https://webkit.org/b/123937>
...and move the current implementations to InlineElementBox.
All subclasses were already overriding these functions so the move
is completely natural.
Reviewed by Anders Carlsson.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Thu, 7 Nov 2013 03:30:11 +0000 (03:30 +0000)]
Nothing should return std::unique_ptr<InlineBox>.
<https://webkit.org/b/123936>
Made RenderBox, RenderLineBreak and RenderListMarker return tightly
typed InlineElementBoxes instead.
Reviewed by Anders Carlsson.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Thu, 7 Nov 2013 03:26:18 +0000 (03:26 +0000)]
Optimize baselines: accessibility
Unreviewed; run "webkit-patch optimize-baselines accessibility"
* accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt.
* accessibility/aria-combobox-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-combobox-expected.txt.
* accessibility/aria-fallback-roles-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-fallback-roles-expected.txt.
* accessibility/aria-labelledby-overrides-aria-label-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-labelledby-overrides-aria-label-expected.txt.
* accessibility/aria-menubar-menuitems-expected.txt:
* accessibility/aria-option-role-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-option-role-expected.txt.
* accessibility/aria-roles-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-roles-expected.txt.
* accessibility/aria-tab-role-on-buttons-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-tab-role-on-buttons-expected.txt.
* accessibility/aria-tables-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-tables-expected.txt.
* accessibility/aria-toggle-button-with-title-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-toggle-button-with-title-expected.txt.
* accessibility/canvas-description-and-role-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/canvas-description-and-role-expected.txt.
* accessibility/canvas-fallback-content-expected.txt:
* accessibility/deleting-iframe-destroys-axcache-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt.
* accessibility/div-within-anchors-causes-crash-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/div-within-anchors-causes-crash-expected.txt.
* accessibility/file-upload-button-stringvalue-expected.txt: Renamed from LayoutTests/platform/efl-wk1/accessibility/file-upload-button-stringvalue-expected.txt.
* accessibility/img-alt-tag-only-whitespace-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/img-alt-tag-only-whitespace-expected.txt.
* accessibility/notification-listeners-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/notification-listeners-expected.txt.
* accessibility/paragraph-with-linebreaks-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/paragraph-with-linebreaks-expected.txt.
* accessibility/svg-image-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/svg-image-expected.txt.
* accessibility/svg-remote-element-expected.txt:
* platform/efl-wk1/accessibility/table-attributes-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-attributes-expected.txt.
* platform/efl-wk1/accessibility/table-detection-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-detection-expected.txt.
* platform/efl-wk1/accessibility/table-one-cell-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-one-cell-expected.txt.
* platform/efl-wk1/accessibility/table-sections-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-sections-expected.txt.
* platform/efl-wk1/accessibility/table-with-rules-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-with-rules-expected.txt.
* platform/efl/accessibility/aria-menubar-menuitems-expected.txt: Removed.
* platform/efl/accessibility/canvas-fallback-content-expected.txt: Removed.
* platform/efl/accessibility/svg-remote-element-expected.txt: Removed.
* platform/gtk-wk1/accessibility/table-attributes-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-attributes-expected.txt.
* platform/gtk-wk1/accessibility/table-sections-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-sections-expected.txt.
* platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Removed.
* platform/gtk/accessibility/aria-combobox-expected.txt: Removed.
* platform/gtk/accessibility/aria-fallback-roles-expected.txt: Removed.
* platform/gtk/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Removed.
* platform/gtk/accessibility/aria-menubar-menuitems-expected.txt: Removed.
* platform/gtk/accessibility/aria-option-role-expected.txt: Removed.
* platform/gtk/accessibility/aria-roles-expected.txt: Removed.
* platform/gtk/accessibility/aria-tab-role-on-buttons-expected.txt: Removed.
* platform/gtk/accessibility/aria-tables-expected.txt: Removed.
* platform/gtk/accessibility/aria-toggle-button-with-title-expected.txt: Removed.
* platform/gtk/accessibility/canvas-description-and-role-expected.txt: Removed.
* platform/gtk/accessibility/canvas-fallback-content-expected.txt: Removed.
* platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Removed.
* platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt: Removed.
* platform/gtk/accessibility/file-upload-button-stringvalue-expected.txt: Removed.
* platform/gtk/accessibility/img-alt-tag-only-whitespace-expected.txt: Removed.
* platform/gtk/accessibility/notification-listeners-expected.txt: Removed.
* platform/gtk/accessibility/paragraph-with-linebreaks-expected.txt: Removed.
* platform/gtk/accessibility/svg-image-expected.txt: Removed.
* platform/gtk/accessibility/svg-remote-element-expected.txt: Removed.
* platform/mac/accessibility/aria-fallback-roles-expected.txt: Removed.
* platform/mac/accessibility/aria-menubar-menuitems-expected.txt: Copied from LayoutTests/accessibility/aria-menubar-menuitems-expected.txt.
* platform/mac/accessibility/aria-roles-expected.txt: Removed.
* platform/mac/accessibility/aria-tables-expected.txt: Removed.
* platform/mac/accessibility/canvas-fallback-content-expected.txt: Copied from LayoutTests/accessibility/canvas-fallback-content-expected.txt.
* platform/mac/accessibility/img-alt-tag-only-whitespace-expected.txt: Removed.
* platform/mac/accessibility/svg-image-expected.txt: Removed.
* platform/win-future/accessibility/svg-remote-element-expected.txt: Copied from LayoutTests/accessibility/svg-remote-element-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Thu, 7 Nov 2013 02:47:48 +0000 (02:47 +0000)]
Optimize baselines: media
Unreviewed; run "webkit-patch optimize-baselines media"
* media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt:
* media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt:
* media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt:
* media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt:
* media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt:
* media/media-can-play-webm-expected.txt: Renamed from LayoutTests/platform/efl/media/media-can-play-webm-expected.txt.
* media/video-controls-visible-audio-only-expected.txt: Renamed from LayoutTests/platform/efl/media/video-controls-visible-audio-only-expected.txt.
* platform/efl-wk2/media/video-layer-crash-expected.png: Renamed from LayoutTests/platform/efl/media/video-layer-crash-expected.png.
* platform/efl-wk2/media/video-transformed-expected.png: Renamed from LayoutTests/platform/efl/media/video-transformed-expected.png.
* platform/efl-wk2/media/video-zoom-expected.png: Renamed from LayoutTests/platform/efl/media/video-zoom-expected.png.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Removed.
* platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Removed.
* platform/gtk/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Removed.
* platform/gtk/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Removed.
* platform/gtk/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Removed.
* platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Removed.
* platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Removed.
* platform/gtk/media/media-can-play-webm-expected.txt: Removed.
* platform/gtk/media/video-controls-visible-audio-only-expected.txt: Removed.
* platform/mac/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Copied from LayoutTests/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt.
* platform/mac/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Copied from LayoutTests/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt.
* platform/mac/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Copied from LayoutTests/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt.
* platform/mac/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Copied from LayoutTests/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt.
* platform/mac/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Copied from LayoutTests/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt.
* platform/mac/media/video-controls-visible-audio-only-expected.txt: Removed.
* platform/win-7sp0/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Renamed from LayoutTests/platform/efl/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt.
* platform/win-7sp0/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Renamed from LayoutTests/platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt.
* platform/win-7sp0/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Renamed from LayoutTests/platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt.
* platform/win/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Removed.
* platform/win/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Removed.
* platform/win/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Removed.
* platform/win/media/media-can-play-ogg-expected.txt: Removed.
* platform/win/media/video-colorspace-yuv420-expected.txt: Removed.
* platform/win/media/video-colorspace-yuv422-expected.txt: Removed.
* platform/win/media/video-size-intrinsic-scale-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Thu, 7 Nov 2013 02:02:14 +0000 (02:02 +0000)]
Remote Layer Tree: RemoteLayerTreeDrawingArea doesn't make layers for fixedpos elements
https://bugs.webkit.org/show_bug.cgi?id=123943
Reviewed by Simon Fraser.
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::updatePreferences):
Make fixed position elements create compositing layers and stacking contexts
in the RemoteLayerTreeDrawingArea just like they do in TiledCoreAnimationDrawingArea.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
Fix the comment, since we have long since achieved this goal.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Thu, 7 Nov 2013 01:41:27 +0000 (01:41 +0000)]
kTraceBufferLen is unused in default builds
https://bugs.webkit.org/show_bug.cgi?id=123941
<rdar://problem/
15409804>
Reviewed by Tim Horton.
kTraceBufferLen is not used in debug.cpp if TRACE_ENABLED is
not defined. This causes a warning in newer builds of clang.
For now, skip warnings on unused variables until we
update from ANGLE.
* src/compiler/debug.cpp: Add unused-variable ignore pragma.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 7 Nov 2013 01:20:14 +0000 (01:20 +0000)]
Implement enough functionality so that NSURLRequest objects can be decoded
https://bugs.webkit.org/show_bug.cgi?id=123942
Reviewed by Andreas Kling.
* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(-[WKRemoteObjectEncoder requiresSecureCoding]):
Add new method. Return YES.
(-[WKRemoteObjectDecoder decodeValueOfObjCType:at:]):
Add new method. This currently only handles 'i', but we'll add more variants as needed.
(-[WKRemoteObjectDecoder decodeBoolForKey:]):
Get a WebBoolean from the dictionary and return its value.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 7 Nov 2013 01:12:29 +0000 (01:12 +0000)]
Encoded object stream should be sequential
https://bugs.webkit.org/show_bug.cgi?id=123939
Reviewed by Andreas Kling.
Reserve space in the object stream for objects that are to be encoded, otherwise
the object stream will not be sequential.
* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(encodeToObjectStream):
* Shared/ImmutableArray.h:
(WebKit::ImmutableArray::entries):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 7 Nov 2013 00:48:56 +0000 (00:48 +0000)]
Allow property list classes to exist in containers
https://bugs.webkit.org/show_bug.cgi?id=123938
Reviewed by Andreas Kling.
* Shared/API/Cocoa/WKRemoteObjectInterface.mm:
(isContainerClass):
Return whether a given class is a container class.
(propertyListClasses):
Return the set of property list classes.
(allowedArgumentClassesForMethod):
Allow all property list classes for container type arguments.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 7 Nov 2013 00:39:11 +0000 (00:39 +0000)]
[iOS] Upstream Letterpress effect
https://bugs.webkit.org/show_bug.cgi?id=123932
Reviewed by Sam Weinig.
Source/JavaScriptCore:
Add feature define ENABLE_LETTERPRESS disabled by default. We only enable
letterpress on iOS.
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Test: platform/iphone-simulator/iphone/getComputedStyle-text-decoration-letterpress.html
* Configurations/FeatureDefines.xcconfig: Add feature define ENABLE_LETTERPRESS disabled
by default. We only enable letterpress on iOS.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderTextDecorationFlagsToCSSValue): Add support for CSS value -webkit-letterpress.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseTextDecoration): Ditto.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator TextDecoration): Ditto.
* css/CSSValueKeywords.in: Added CSS value -webkit-letterpress.
* platform/graphics/GraphicsContext.h:
* platform/graphics/mac/FontMac.mm:
(WebCore::fillVectorWithHorizontalGlyphPositions): Added.
(WebCore::shouldUseLetterpressEffect): Added.
(WebCore::showLetterpressedGlyphsWithAdvances): Added.
(WebCore::showGlyphsWithAdvances): Modified to call showLetterpressedGlyphsWithAdvances()
to show a letterpressed glyph. I also included additional iOS-specific changes.
(WebCore::Font::drawGlyphs):
* rendering/TextPaintStyle.cpp:
(WebCore::TextPaintStyle::TextPaintStyle):
(WebCore::computeTextPaintStyle): Modified to compute letterpress effect style.
(WebCore::updateGraphicsContext): Modified to apply/unapply letterpress effect drawing mode.
* rendering/TextPaintStyle.h:
* rendering/style/RenderStyleConstants.h:
Source/WebKit/mac:
Add feature define ENABLE_LETTERPRESS disabled by default. We only enable
letterpress on iOS.
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Add feature define ENABLE_LETTERPRESS disabled by default. We only enable
letterpress on iOS.
* Configurations/FeatureDefines.xcconfig:
Source/WTF:
Add feature define ENABLE_LETTERPRESS disabled by default. We only enable
letterpress on iOS.
* wtf/FeatureDefines.h:
LayoutTests:
* platform/iphone-simulator/iphone/getComputedStyle-text-decoration-letterpress-expected.txt: Added.
* platform/iphone-simulator/iphone/getComputedStyle-text-decoration-letterpress.html: Added.
* platform/iphone-simulator/iphone/resources/getComputedStyle-text-decoration-letterpress.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 7 Nov 2013 00:20:03 +0000 (00:20 +0000)]
Crash in SliderThumbElement::dragFrom
https://bugs.webkit.org/show_bug.cgi?id=123873
Reviewed by Sam Weinig.
Moved Ref.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::dragFrom):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Thu, 7 Nov 2013 00:04:52 +0000 (00:04 +0000)]
LayoutTests/media/track/track-forced-subtitles-in-band.html always times out
https://bugs.webkit.org/show_bug.cgi?id=123412
Reviewed by Jer Noble.
* media/content/CC+Subtitles.mov: Added.
* media/track/track-forced-subtitles-in-band.html: Fail loudly if the caption track menu is
not found by the helper function. Wait for both 'seeked' and 'cuechange' events before
checking activeCues.
* media/trackmenu-test.js:
(getTrackListElement): Correct the caption menu pseudo-id.
(trackMenuList): Complain when the track menu is not found.
* platform/mac/TestExpectations: Remove track-forced-subtitles-in-band.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 7 Nov 2013 00:00:14 +0000 (00:00 +0000)]
Cleanup FontMac.mm
https://bugs.webkit.org/show_bug.cgi?id=123928
Reviewed by Andy Estes.
* platform/graphics/mac/FontMac.mm:
(WebCore::showGlyphsWithAdvances): Inline the value of variable isVertical as we
reference it exactly once and its value is sufficiently clear.
(WebCore::Font::drawGlyphs): Remove default case in switch block so that the compiler
checks that all cases are covered. Move definition of platformData to the top of the
function and use it whenever we want to access the platform font data
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 6 Nov 2013 23:53:02 +0000 (23:53 +0000)]
Fixed multiple API test failures after r158764.
Reviewed by Sam Weinig.
* UIProcess/API/mac/WKBrowsingContextController.mm:
(setUpPagePolicyClient): If the delegate isn’t set or doesn’t respond to a selector, respond
with WKFramePolicyListenerUse().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@apple.com [Wed, 6 Nov 2013 23:08:56 +0000 (23:08 +0000)]
[WebGL] We should not allow generateMipMap on compressed textures
https://bugs.webkit.org/show_bug.cgi?id=123915
<rdar://problem/
15201274>
Reviewed by Dean Jackson.
Found by existing conformance/extensions/webgl-compressed-texture-s3tc.html
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::compressedTexImage2D): Set compressed flag.
(WebCore::WebGLRenderingContext::compressedTexSubImage2D): Ditto.
(WebCore::WebGLRenderingContext::generateMipmap): For Apple builds, check state
of compressed flag and generate appropriate WebGL error if necessary.
* html/canvas/WebGLTexture.cpp:
(WebCore::WebGLTexture::WebGLTexture): Set compressed flag to false by default
(WebCore::WebGLTexture::isCompressed): Added
(WebCore::WebGLTexture::setCompressed): Added
* html/canvas/WebGLTexture.h:
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::generateMipmap): Switch implementation to use proper
glGenerateMipmaps, rather than the glGenerateMipmapsEXT method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 6 Nov 2013 23:04:39 +0000 (23:04 +0000)]
Move allowed classes handling to decodeObject
https://bugs.webkit.org/show_bug.cgi?id=123930
Reviewed by Andreas Kling.
* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(decodeObjectFromObjectStream):
Pass allowed classes through to decodeObject.
(decodeObject):
Update to take an NSSet of allowed classes. If the set is nil, use the current set.
(-[WKRemoteObjectDecoder decodeObjectOfClasses:forKey:]):
Pass classes to decodeObject.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Nov 2013 22:44:23 +0000 (22:44 +0000)]
Web Inspector: Changes to CodeGeneratorInspectorStrings.py should rebuild inspector generated files
https://bugs.webkit.org/show_bug.cgi?id=123925
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-11-06
Reviewed by Timothy Hatcher.
* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 6 Nov 2013 22:37:46 +0000 (22:37 +0000)]
Support iteration of the Arguments object
https://bugs.webkit.org/show_bug.cgi?id=123835
Reviewed by Mark Lam.
Source/JavaScriptCore:
Add an ArgumentsIterator object, and associated classes so that we can support
iteration of the arguments object.
This is a largely mechanical patch. The only gnarliness is in the
logic to avoid reifying the Arguments object in for(... of arguments)
scenarios.
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitEnumeration):
* runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlot):
(JSC::argumentsFuncIterator):
* runtime/Arguments.h:
* runtime/ArgumentsIteratorConstructor.cpp: Added.
(JSC::ArgumentsIteratorConstructor::finishCreation):
* runtime/ArgumentsIteratorConstructor.h: Added.
(JSC::ArgumentsIteratorConstructor::create):
(JSC::ArgumentsIteratorConstructor::createStructure):
(JSC::ArgumentsIteratorConstructor::ArgumentsIteratorConstructor):
* runtime/ArgumentsIteratorPrototype.cpp: Added.
(JSC::ArgumentsIteratorPrototype::finishCreation):
(JSC::argumentsIteratorPrototypeFuncIterator):
(JSC::argumentsIteratorPrototypeFuncNext):
* runtime/ArgumentsIteratorPrototype.h: Added.
(JSC::ArgumentsIteratorPrototype::create):
(JSC::ArgumentsIteratorPrototype::createStructure):
(JSC::ArgumentsIteratorPrototype::ArgumentsIteratorPrototype):
* runtime/CommonIdentifiers.h:
* runtime/JSArgumentsIterator.cpp: Added.
(JSC::JSArgumentsIterator::finishCreation):
* runtime/JSArgumentsIterator.h: Added.
(JSC::JSArgumentsIterator::createStructure):
(JSC::JSArgumentsIterator::create):
(JSC::JSArgumentsIterator::next):
(JSC::JSArgumentsIterator::JSArgumentsIterator):
* runtime/JSArrayIterator.cpp:
(JSC::createIteratorResult):
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h:
LayoutTests:
Add test cases
* js/arguments-iterator-expected.txt: Added.
* js/arguments-iterator.html: Added.
* js/script-tests/arguments-iterator.js: Added.
(shouldThrow.test):
(testAlias):
(testStrict):
(testReifiedArguments):
(testOverwrittenArguments):
(testNullArguments):
(testNonArrayLikeArguments):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Nov 2013 22:37:34 +0000 (22:37 +0000)]
Fix EFL build after r158753
https://bugs.webkit.org/show_bug.cgi?id=123923
r158753 renamed WKNavigationData.h as WKNavigationDataRef.h, so
update it in UIProcess/API/efl/ewk_navigation_data_private.h.
Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-11-06
Reviewed by Csaba Osztrogonác.
* UIProcess/API/efl/ewk_navigation_data_private.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Wed, 6 Nov 2013 22:29:17 +0000 (22:29 +0000)]
Fix the display of query parameters when the value is missing.
https://bugs.webkit.org/show_bug.cgi?id=123920
Reviewed by Joseph Pecoraro.
* UserInterface/ResourceDetailsSidebarPanel.js:
(WebInspector.ResourceDetailsSidebarPanel.prototype._createNameValueDataGrid):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
achicu@adobe.com [Wed, 6 Nov 2013 22:08:46 +0000 (22:08 +0000)]
Web Inspector: CSS Regions: When a flow is clicked the content of flow needs to be displayed
https://bugs.webkit.org/show_bug.cgi?id=122927
Reviewed by Joseph Pecoraro.
ContentFlowTreeContentView is now used to display the content nodes of a ContentFlow. It is
very similar to the DOMTreeContentView class, but can handle multiple root nodes.
* UserInterface/ContentFlowTreeContentView.js: Added.
(WebInspector.ContentFlowTreeContentView):
(WebInspector.ContentFlowTreeContentView.prototype.get selectionPathComponents):
(WebInspector.ContentFlowTreeContentView.prototype.updateLayout):
(WebInspector.ContentFlowTreeContentView.prototype.shown):
(WebInspector.ContentFlowTreeContentView.prototype.hidden):
(WebInspector.ContentFlowTreeContentView.prototype.closed):
(WebInspector.ContentFlowTreeContentView.prototype._selectedNodeDidChange):
(WebInspector.ContentFlowTreeContentView.prototype._pathComponentSelected):
(WebInspector.ContentFlowTreeContentView.prototype._createContentNodeTree):
(WebInspector.ContentFlowTreeContentView.prototype._createContentTrees):
(WebInspector.ContentFlowTreeContentView.prototype._contentNodeWasAdded):
(WebInspector.ContentFlowTreeContentView.prototype._contentNodeWasRemoved):
* UserInterface/ContentView.js:
(WebInspector.ContentView):
(WebInspector.ContentView.isViewable):
* UserInterface/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype.ondeselect): We need to remove the selected "dom node"
so that the element is not going to stay selected after the we move to a different DOM tree.
* UserInterface/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline.prototype.selectDOMNode):
* UserInterface/Main.html:
* UserInterface/Main.js:
(WebInspector.sidebarPanelForRepresentedObject):
* UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 6 Nov 2013 21:57:22 +0000 (21:57 +0000)]
Fix test case
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 6 Nov 2013 21:54:52 +0000 (21:54 +0000)]
Remove the flaky test expectation after r158720 now that the test is not flaky.
* platform/mac/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 6 Nov 2013 21:52:54 +0000 (21:52 +0000)]
Implement more decoding methods
https://bugs.webkit.org/show_bug.cgi?id=123922
Reviewed by Dan Bernstein.
* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(-[WKRemoteObjectDecoder decodeObjectForKey:]):
Call decodeObjectOfClasses:forKey: passing nil as the classes set.
(-[WKRemoteObjectDecoder decodeInt64ForKey:]):
Try to get a WebUInt64 and return its value.
(-[WKRemoteObjectDecoder decodeDoubleForKey:]):
Try to get a WebDouble and return its value.
(-[WKRemoteObjectDecoder decodeBytesForKey:returnedLength:]):
Move this method next to the other decoding methods.
(-[WKRemoteObjectDecoder requiresSecureCoding]):
Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Nov 2013 21:39:17 +0000 (21:39 +0000)]
Disable "unused local typedefs" warning for GCC 4.7
https://bugs.webkit.org/show_bug.cgi?id=123913
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-06
Reviewed by Martin Robinson.
That warning was actually introduced in gcc 4.7.0.
See: http://gcc.gnu.org/gcc-4.7/changes.html
* wtf/Compiler.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Nov 2013 21:31:52 +0000 (21:31 +0000)]
[Gtk][EFL] Fix build after r158759
https://bugs.webkit.org/show_bug.cgi?id=123910
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-06
Reviewed by Gustavo Noronha Silva.
* UIProcess/API/gtk/PageClientImpl.cpp: Remove flashBackingStoreUpdates().
* UIProcess/API/gtk/PageClientImpl.h: Same.
* UIProcess/CoordinatedGraphics/WebView.cpp: Same.
* UIProcess/CoordinatedGraphics/WebView.h: Same.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::incorporateUpdate): Don't call flashBackingStoreUpdates().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 6 Nov 2013 21:21:17 +0000 (21:21 +0000)]
Unreviewed Mac build fix; include ResourceResponse.
* Shared/WebNavigationDataStore.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 6 Nov 2013 21:17:47 +0000 (21:17 +0000)]
Decode invocation arguments
https://bugs.webkit.org/show_bug.cgi?id=123917
Reviewed by Sam Weinig.
* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(-[WKRemoteObjectDecoder initWithInterface:rootObjectDictionary:WebKit::]):
Initialize the object stream.
(decodeObjectFromObjectStream):
Check that we're not reading past the end of the stream, then decode the object.
(decodeInvocationArguments):
Decode arguments from the object stream.
(decodeInvocation):
Call decodeInvocationArguments and set up the selector argument.
* Shared/ImmutableArray.h:
(WebKit::ImmutableArray::at):
(WebKit::ImmutableArray::size):
(WebKit::ImmutableArray::entries):
Constify.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 6 Nov 2013 20:56:52 +0000 (20:56 +0000)]
[Cocoa] Add -[WKNavigationData response]
https://bugs.webkit.org/show_bug.cgi?id=123918
Reviewed by Sam Weinig.
* Shared/WebNavigationDataStore.h: Added a ResourceResponse data member.
(WebKit::WebNavigationDataStore::encode): Encode the response.
(WebKit::WebNavigationDataStore::decode): Decode the response.
* UIProcess/Cocoa/WKNavigationData.h: Declared new property.
* UIProcess/Cocoa/WKNavigationData.mm:
(-[WKNavigationData response]): Added.
* UIProcess/WebNavigationData.h:
(WebKit::WebNavigationData::response): Added.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::updateGlobalHistory): Set the response in the data store.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bjonesbe@adobe.com [Wed, 6 Nov 2013 20:49:38 +0000 (20:49 +0000)]
Rename region line offset methods
https://bugs.webkit.org/show_bug.cgi?id=123897
Reviewed by Sam Weinig.
Because of the large number of overloads on the line offset methods,
it is very hard to read code using them, which also makes it harder to
move them out of RenderBlock. This patch renames the methods that take
a region as an argument to make it clearer when looking at the code
how the differ from the ones that don't.
No new tests, no behavior change.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::availableLogicalWidthForLineInRegion):
(WebCore::RenderBlock::logicalRightOffsetForLineInRegion):
(WebCore::RenderBlock::logicalLeftOffsetForLineInRegion):
(WebCore::RenderBlock::startOffsetForLineInRegion):
(WebCore::RenderBlock::endOffsetForLineInRegion):
(WebCore::RenderBlock::availableLogicalWidthForLine):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 6 Nov 2013 20:49:19 +0000 (20:49 +0000)]
Fix the 32-bit build.
* UIProcess/API/mac/WKBrowsingContextController.h:
* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController _initWithPageRef:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 6 Nov 2013 20:48:59 +0000 (20:48 +0000)]
[Cocoa] Add -[WKBrowsingContextController unreachableURL]
https://bugs.webkit.org/show_bug.cgi?id=123909
Reviewed by Anders Carlsson.
* UIProcess/API/mac/WKBrowsingContextController.h: Declared unreachableURL property.
* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController unreachableURL]): Added.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::unreachableURL): Added.
* UIProcess/WebPageProxy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 6 Nov 2013 20:38:37 +0000 (20:38 +0000)]
HTMLCollection should use CollectionIndexCache
https://bugs.webkit.org/show_bug.cgi?id=123906
Reviewed by Ryosuke Niwa.
More code sharing.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
* dom/ChildNodeList.h:
* dom/CollectionIndexCache.h:
(WebCore::::nodeBeforeCached):
(WebCore::::nodeAfterCached):
(WebCore::::nodeAt):
Add a mechanism for disabling use of backward traversal.
* dom/LiveNodeList.h:
(WebCore::LiveNodeList::collectionCanTraverseBackward):
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::isMatchingElement):
(WebCore::HTMLCollection::iterateForPreviousElement):
(WebCore::firstMatchingElement):
(WebCore::nextMatchingElement):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::nameShouldBeVisibleInDocumentAll):
(WebCore::firstMatchingChildElement):
(WebCore::nextMatchingSiblingElement):
(WebCore::HTMLCollection::firstElement):
(WebCore::HTMLCollection::traverseForward):
(WebCore::HTMLCollection::collectionFirst):
(WebCore::HTMLCollection::collectionLast):
(WebCore::HTMLCollection::collectionTraverseForward):
(WebCore::HTMLCollection::collectionTraverseBackward):
(WebCore::HTMLCollection::invalidateCache):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
* html/HTMLCollection.h:
(WebCore::HTMLCollection::collectionCanTraverseBackward):
Disable use of backward traversal for collections that use custom traversal.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 6 Nov 2013 20:32:19 +0000 (20:32 +0000)]
DFG CheckArray(NonArray) should prove that the child isn't an array
https://bugs.webkit.org/show_bug.cgi?id=123911
<rdar://problem/
15202803>
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::isArrayType):
LayoutTests:
* js/dfg-check-array-non-array-expected.txt: Added.
* js/dfg-check-array-non-array.html: Added.
* js/script-tests/dfg-check-array-non-array.js: Added.
(foo):
(bar):
(baz):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 6 Nov 2013 20:31:40 +0000 (20:31 +0000)]
Encode parameters as objects
https://bugs.webkit.org/show_bug.cgi?id=123912
Reviewed by Beth Dakin.
We want to ensure that the objects have the right types when decoded, so just encode them as objects.
* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(encodeInvocation):
(-[WKRemoteObjectEncoder encodeValueOfObjCType:at:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 6 Nov 2013 20:16:55 +0000 (20:16 +0000)]
Unreviewed webkitpy unit test fix; update baselines after r158765
* Scripts/webkitpy/port/win_unittest.py:
(WinPortTest.test_baseline_search_path):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 6 Nov 2013 19:53:42 +0000 (19:53 +0000)]
[Win] run-webkit-tests on the win platform should fall back to mac-mountainlion, not mac-lion.
https://bugs.webkit.org/show_bug.cgi?id=123905
Reviewed by Brent Fulgham.
Now that the mac-lion results have been removed, the win port should fall back to
the mac-mountainlion results.
* Scripts/webkitpy/port/win.py:
(WinPort.default_baseline_search_path):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 6 Nov 2013 19:42:09 +0000 (19:42 +0000)]
Add WKBrowsingContextPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=123904
Reviewed by Anders Carlsson.
* UIProcess/API/mac/WKBrowsingContextController.h:
* UIProcess/API/mac/WKBrowsingContextController.mm:
Implement a WKPagePolicyClient in terms of the new WKBrowsingContextPolicyDelegate protocol.
* UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:
Added.
* UIProcess/API/mac/WebKit2.h:
Add new #include of WKBrowsingContextPolicyDelegate.h
* WebKit2.xcodeproj/project.pbxproj:
Add new file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 6 Nov 2013 19:23:20 +0000 (19:23 +0000)]
WKRemoteObjectInterface should keep track of allowed decodable classes
https://bugs.webkit.org/show_bug.cgi?id=123903
Reviewed by Sam Weinig.
* Shared/API/Cocoa/WKRemoteObjectInterface.mm:
(allowedArgumentClassesForMethod):
Helper function that returns a vector of sets of allowed classes for each method argument.
(initializeAllowedArgumentClasses):
Iterate over the methods in the protocol, get the extended method type encoding and create an
NSMethodSignature from it. Finally, pass the signature to allowedArgumentClassesForMethod.
(initializeAllowedArgumentClasses):
Call the other initializeAllowedArgumentClasses twice, once for required methods,
and once for optional methods.
(-[WKRemoteObjectInterface initWithProtocol:identifier:]):
Call initializeAllowedArgumentClasses.
(-[WKRemoteObjectInterface _allowedArgumentClassesForSelector:]):
Add new getter.
* Shared/API/Cocoa/WKRemoteObjectInterfaceInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Wed, 6 Nov 2013 19:21:47 +0000 (19:21 +0000)]
JSExport doesn't support constructors
https://bugs.webkit.org/show_bug.cgi?id=123380
Reviewed by Geoffrey Garen.
Needed another linked-on-or-after check for when we're deciding whether
we should copy over init family methods.
Factored out the link time checks into a separate function so that they can be cached.
Factored out the check for init-family method selectors into helper function and changed it to
match the description in the clang docs, namely that there can be underscores at the beginning
and the first letter after 'init' part of the selector (if there is one) must be a capital letter.
Updated tests to make sure we don't treat "initialize" as an init-family method and that we do
treat "_init" as an init-family method.
* API/JSWrapperMap.h:
* API/JSWrapperMap.mm:
(isInitFamilyMethod):
(shouldSkipMethodWithName):
(copyMethodsToObject):
(allocateConstructorForCustomClass):
(supportsInitMethodConstructors):
* API/tests/testapi.mm:
(-[ClassA initialize]):
(-[ClassD initialize]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 6 Nov 2013 19:01:30 +0000 (19:01 +0000)]
Fix a Mountain Lion test failure.
NSURLRequest doesn't conform to NSSecureCoding on Mountain Lion, so don't try to test encoding it.
* TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
(TestWebKitAPI::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Nov 2013 18:53:17 +0000 (18:53 +0000)]
Add "id" attribute to TextTrack
https://bugs.webkit.org/show_bug.cgi?id=123825
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-06
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/track-id.html
* html/HTMLMediaElement.cpp:
(HTMLMediaElement::addTextTrack): Add emptyString() for track id.
* html/track/AudioTrack.cpp:
(WebCore::AudioTrack::AudioTrack): Pass trackPrivate->id() to TrackBase.
(WebCore::AudioTrack::idChanged): Added, set id.
* html/track/AudioTrack.h: Move m_id to TrackBase.
* html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::InbandTextTrack): Pass trackPrivate->id() to TrackBase.
(WebCore::InbandTextTrack::idChanged): Added, set id.
* html/track/InbandTextTrack.h: Add idChanged().
* html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::LoadableTextTrack): Add emptyString() for track id.
(WebCore::LoadableTextTrack::id): Override to return the track element's id.
* html/track/TextTrack.cpp:
(WebCore::TextTrack::captionMenuOffItem): Add empty string for track id.
(WebCore::TextTrack::captionMenuAutomaticItem): Add empty string for track id.
(WebCore::TextTrack::TextTrack): Pass id to TrackBase.
* html/track/TextTrack.h:
(WebCore::TextTrack::create): Add id parameter.
* html/track/TextTrack.idl: Add id attribute.
* html/track/TrackBase.cpp:
(WebCore::TrackBase::TrackBase): Add m_id.
* html/track/TrackBase.h: Add id attribute / m_id.
* html/track/VideoTrack.cpp:
(WebCore::VideoTrack::VideoTrack): Pass trackPrivate->id() to TrackBase.
(WebCore::VideoTrack::idChanged): Added, set id.
* html/track/VideoTrack.h: Move m_id to TrackBase.
* platform/graphics/TrackPrivateBase.h: Add idChanged() callback.
LayoutTests:
* media/track/track-id-expected.txt: Added.
* media/track/track-id.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 6 Nov 2013 18:51:58 +0000 (18:51 +0000)]
Remove dead code
https://bugs.webkit.org/show_bug.cgi?id=123902
Reviewed by Tim Horton.
Remove the PageClient::containingWindowGraphicsContext() as well as the
WKPageSetDebugPaintFlags and WKPageGetDebugPaintFlags API functions.
* UIProcess/API/C/WKPage.cpp:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::searchTheWeb):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 6 Nov 2013 18:18:48 +0000 (18:18 +0000)]
Move array position caching out from HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=123895
Reviewed by Darin Adler.
This caching complicates the logic but is used by a single subclass
(HTMLFormControlsCollection) only. The subclass can do the caching itself.
* html/HTMLAllCollection.cpp:
(WebCore::HTMLAllCollection::HTMLAllCollection):
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::elementBeforeOrAfterCachedElement):
(WebCore::HTMLCollection::firstElement):
Renamed from traverseFirstElement.
(WebCore::HTMLCollection::traverseForwardToOffset):
(WebCore::HTMLCollection::invalidateCache):
Make cache invalidation virtual so we can clear HTMLTableRowsCollection index cache.
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
Use traverseForwardToOffset instead traverseNextElement. This allows removal of traverseNextElement.
* html/HTMLCollection.h:
(WebCore::HTMLCollection::usesCustomForwardOnlyTraversal):
Renamed the enum and the accessor to be more informative.
(WebCore::HTMLCollection::setCachedElement):
(WebCore::HTMLCollection::customElementAfter):
Renamed from virtualItemAfter.
* html/HTMLFormControlsCollection.cpp:
(WebCore::HTMLFormControlsCollection::HTMLFormControlsCollection):
(WebCore::findFormAssociatedElement):
(WebCore::HTMLFormControlsCollection::customElementAfter):
Move the array position caching logic here.
(WebCore::HTMLFormControlsCollection::invalidateCache):
* html/HTMLFormControlsCollection.h:
* html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::HTMLNameCollection):
* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::HTMLOptionsCollection):
* html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
(WebCore::HTMLTableRowsCollection::customElementAfter):
* html/HTMLTableRowsCollection.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
m.pakula@samsung.com [Wed, 6 Nov 2013 18:17:03 +0000 (18:17 +0000)]
[ATK] accessibility/title-ui-element-correctness.html fails
https://bugs.webkit.org/show_bug.cgi?id=99825
Reviewed by Mario Sanchez Prada.
Source/WebCore:
When calling setAtkRelationSetFromCoreObject a new ATK_LABELLED_BY_RELATION
is added, adding proper label element as a relation. When the document structure
has been changed and a different label should be linked as a relation, current ATK
implementation adds it as a next target on relation's target list, while
WTR/DumpRenderTree implementation takes only first one into account.
This patch adds a new function removing current relations before adding new ones.
Covered by existing tests.
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(removeAtkRelationFromRelationSetByType):
(setAtkRelationSetFromCoreObject):
LayoutTests:
Remove failure test expectation for the test fixed by this patch.
* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/gtk/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 6 Nov 2013 18:12:48 +0000 (18:12 +0000)]
Promoted WKBrowsingContextHistoryDelegate.h to private.
Rubber-stamped by Sam Weinig.
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Wed, 6 Nov 2013 17:43:33 +0000 (17:43 +0000)]
Unreviewed GTK gardening. Media elements wrongly exposed after r158743.
* platform/gtk/TestExpectations: Added failure expectations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Nov 2013 17:39:01 +0000 (17:39 +0000)]
[ATK] Providing new table related accessibility expectations after r158742
https://bugs.webkit.org/show_bug.cgi?id=123893
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-06
Reviewed by Chris Fleizach.
New baselines after added missing implementation in r158742.
* platform/efl-wk1/TestExpectations: Tests are no longer failing.
* platform/efl-wk2/TestExpectations: Tests are no longer failing.
* platform/efl-wk2/accessibility/table-attributes-expected.txt: Added.
* platform/efl-wk2/accessibility/table-sections-expected.txt: Added.
* platform/efl/accessibility/table-attributes-expected.txt: Added.
* platform/efl/accessibility/table-sections-expected.txt: Added.
* platform/gtk-wk2/accessibility/table-attributes-expected.txt: Added.
* platform/gtk-wk2/accessibility/table-sections-expected.txt: Added.
* platform/gtk/TestExpectations: Tests are no longer failing.
* platform/gtk/accessibility/table-attributes-expected.txt: Added.
* platform/gtk/accessibility/table-sections-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 6 Nov 2013 17:36:26 +0000 (17:36 +0000)]
[Cocoa] History delegate
https://bugs.webkit.org/show_bug.cgi?id=123837
Reviewed by Sam Weinig.
* Shared/Cocoa/APIObject.mm:
(WebKit::APIObject::newObject): Allocate a WKNavigationData if the object is a
WebNavigationData.
* Shared/Cocoa/WKNSString.h:
(WebKit::wrapper): Added. Returns a WebString’s wrapper as an NSString.
* Shared/Cocoa/WKNSURL.h:
(WebKit::wrapper): Added. Returns a WebURL’s wrapper as an NSURL.
* UIProcess/API/C/WKNavigationData.cpp: Renamed.
* UIProcess/API/C/WKNavigationData.h: Renamed.
* UIProcess/API/C/WKNavigationDataRef.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKNavigationData.cpp.
* UIProcess/API/C/WKNavigationDataRef.h: Copied from Source/WebKit2/UIProcess/API/C/WKNavigationData.h.
* UIProcess/API/mac/WKBrowsingContextController.h: Declared historyDelegate property.
* UIProcess/API/mac/WKProcessGroup.mm:
(didNavigateWithNavigationData): Added history client callback that calls the browsing
context’s history delegate.
(didPerformClientRedirect): Ditto.
(didPerformServerRedirect): Ditto.
(didUpdateHistoryTitle): Ditto.
(setUpHistoryClient): Added.
(-[WKProcessGroup initWithInjectedBundleURL:]): Added call to setUpHistoryClient.
(-[WKProcessGroup dealloc]): Clear the history client.
* UIProcess/Cocoa/WKBrowsingContextHistoryDelegate.h: Added.
* UIProcess/Cocoa/WKNavigationData.h: Added.
* UIProcess/Cocoa/WKNavigationData.mm: Added.
(-[WKNavigationData dealloc]): Calls the WebNavigationData destructor.
(-[WKNavigationData title]): Added.
(-[WKNavigationData originalRequest]): Added.
(-[WKNavigationData destinationURL]): Added.
(-[WKNavigationData _apiObject]): Returns the wrapped WebNavigationData.
* UIProcess/Cocoa/WKNavigationDataInternal.h: Added.
(WebKit::wrapper): Added. Returns a WebNavigationData’s wrapper as a WKNavigationData.
* WebKit2.xcodeproj/project.pbxproj: Updated for renames and additions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 6 Nov 2013 17:31:44 +0000 (17:31 +0000)]
Unreviewed gardening; Fix expected results for video-seek-with-negative-playback.html,
and modify the test to conform to media test style.
* media/video-seek-with-negative-playback-expected.txt:
* media/video-seek-with-negative-playback.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Wed, 6 Nov 2013 17:29:12 +0000 (17:29 +0000)]
Change ctiTrampoline into a thunk
https://bugs.webkit.org/show_bug.cgi?id=123844
Reviewed by Filip Pizlo.
Converted ctiTrampoline and ctiOpThrowNotCaught into thunks named callToJavaScript
and returnFromJavaScript. Cleaned up and in some cases removed JITStubsXXX.h files
after removing ctiTrampoline and ctiOpThrowNotCaught. Added callJavaScriptJITFunction
to VM that is a function pointer to the callToJavaScript thunk.
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGDriver.cpp:
(JSC::DFG::compileImpl):
* jit/JITCode.cpp:
(JSC::JITCode::execute):
* jit/JITExceptions.cpp:
(JSC::genericUnwind):
* jit/JITStubs.cpp:
* jit/JITStubs.h:
* jit/JITStubsARM.h:
* jit/JITStubsARM64.h: Removed.
* jit/JITStubsARMv7.h:
* jit/JITStubsMIPS.h: Removed.
* jit/JITStubsMSVC64.asm:
* jit/JITStubsSH4.h: Removed.
* jit/JITStubsX86.h:
* jit/JITStubsX86_64.h:
* jit/JSInterfaceJIT.h:
* jit/ThunkGenerators.cpp:
(JSC::returnFromJavaScript):
(JSC::callToJavaScript):
* jit/ThunkGenerators.h:
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Wed, 6 Nov 2013 16:48:17 +0000 (16:48 +0000)]
Add ENABLE(TEXT_SELECTION)
https://bugs.webkit.org/show_bug.cgi?id=123827
Reviewed by Ryosuke Niwa.
Source/WebCore:
Add compile-time guard, ENABLE(TEXT_SELECTION), to enable or
disable selection painting in WebCore (enabled by default).
On iOS we disable WebCore selection painting and have UIKit
paint the selection.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintSelection): Only paint selection when
TEXT_SELECTION is enabled.
* rendering/LogicalSelectionOffsetCaches.h:
(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
For now, add a ENABLE(TEXT_SELECTION)-guard around an assertion. Added
a FIXME comment to investigate the callers and either move the assertion
to the appropriate callers or structure the code such that we can remove
the assertion.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintSelection): Only paint selection when
TEXT_SELECTION is enabled.
* rendering/TextPaintStyle.cpp:
(WebCore::computeTextSelectionPaintStyle): Only compute the selection
paint style when TEXT_SELECTION is enabled. Otherwise, return a paint
style identical to the text paint style. Also, substitute nullptr for 0.
Source/WTF:
Enable selection painting by default on all ports except iOS.
* wtf/FeatureDefines.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 6 Nov 2013 16:45:28 +0000 (16:45 +0000)]
Unrevewied Windows build fix after r158736; add InlineElementBox.cpp to the RenderingAllInOne.cpp file.
* rendering/RenderingAllInOne.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 6 Nov 2013 16:38:45 +0000 (16:38 +0000)]
FTL should support StringCharCodeAt
https://bugs.webkit.org/show_bug.cgi?id=123854
Reviewed by Sam Weinig.
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileStringCharCodeAt):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
svillar@igalia.com [Wed, 6 Nov 2013 16:36:46 +0000 (16:36 +0000)]
Unreviewed build fix, style() return type is now a reference.
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::resolveGridPositionFromStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 6 Nov 2013 16:26:06 +0000 (16:26 +0000)]
Unreviewed 32-bit Mac build fix; use an explicit FloatSize -> IntSize conversion function.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 6 Nov 2013 16:15:16 +0000 (16:15 +0000)]
Playing many sounds with HTML5 Audio makes WebKit unresponsive
https://bugs.webkit.org/show_bug.cgi?id=116145
Reviewed by Eric Carlson.
Cache as much information as possible from AVPlayerItem to eliminate unneccesary
calls into AVFoundation.
Add WillChange/DidChange functions to handle the results of KVO notifications
from AVPlayerItem and AVPlayer:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPlay):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPause):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateRate):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatusDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackLikelyToKeepUpWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackLikelyToKeepUpDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackBufferEmptyWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackBufferEmptyDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackBufferFullWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackBufferFullDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::loadedTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasEnabledAudioDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::presentationSizeDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::durationDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::rateDidChange):
(WebCore::itemKVOProperties):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
Instruct the HTMLMediaElement to cache the currentTime value for 5 seconds:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
(WebCore::MediaPlayerPrivateAVFoundationObjC::maximumDurationToCacheMediaTime):
Add and initialize member variables to hold these cached values:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
Add a new Notification type which can take (and call) a Function object:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::Notification::Notification):
(WebCore::MediaPlayerPrivateAVFoundation::Notification::function):
Implement queries in terms of the cached values of AVPlayerItem and AVPlayer
properties:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):
(WebCore::MediaPlayerPrivateAVFoundationObjC::rate):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformBufferedTimeRanges):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMinTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeLoaded):
(WebCore::MediaPlayerPrivateAVFoundationObjC::totalBytes):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks):
Invalidate the cached currentTime before calling scheduleTimeUpdate so that the
correct movieTime is saved in m_clockTimeAtLastUpdateEvent:
* html/HTMLMediaElement.cpp:
(HTMLMediaElement::setReadyState):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
svillar@igalia.com [Wed, 6 Nov 2013 15:54:08 +0000 (15:54 +0000)]
[CSS Grid Layout] Add support for named grid areas
https://bugs.webkit.org/show_bug.cgi?id=120045
Reviewed by Andreas Kling.
From Blink r155555, r155850 and r155889 by <jchaffraix@chromium.org>
Source/WebCore:
Added support for named grid areas. Basically a named grid area is
now a valid grid position. The shorthand parsing of grid-area was
split from the grid-{row|column} as the rules for expanding are
slightly different.
Unknown grid area names are treated as 'auto' as per the
specification. This means that for those cases we need to trigger
the auto-placement algorithm.
Tests: fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html
fast/css-grid-layout/grid-item-named-grid-area-resolution.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForGridPosition):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridPosition):
(WebCore::gridMissingGridPositionValue):
(WebCore::CSSParser::parseGridItemPositionShorthand):
(WebCore::CSSParser::parseGridAreaShorthand):
(WebCore::CSSParser::parseSingleGridAreaLonghand):
* css/CSSParser.h:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::adjustGridItemPosition):
(WebCore::createGridPosition):
* css/StyleResolver.h:
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::resolveGridPositionFromStyle):
* rendering/style/GridPosition.h:
(WebCore::GridPosition::isNamedGridArea):
(WebCore::GridPosition::setNamedGridArea):
(WebCore::GridPosition::namedGridLine):
LayoutTests:
Added a couple of new tests to check that both known and unknown
named grid areas are properly handled.
Also extended some of the existing tests to use named grid areas
as any other possible grid position.
* fast/css-grid-layout/grid-item-area-get-set-expected.txt:
* fast/css-grid-layout/grid-item-area-get-set.html:
* fast/css-grid-layout/grid-item-bad-named-area-auto-placement-expected.txt: Added.
* fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html: Added.
* fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
* fast/css-grid-layout/grid-item-column-row-get-set.html:
* fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
* fast/css-grid-layout/grid-item-end-after-get-set.html:
* fast/css-grid-layout/grid-item-named-grid-area-resolution-expected.txt: Added.
* fast/css-grid-layout/grid-item-named-grid-area-resolution.html: Added.
* fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
* fast/css-grid-layout/grid-item-start-before-get-set.html:
* fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Wed, 6 Nov 2013 14:15:42 +0000 (14:15 +0000)]
AX: Audio and Video attachments are not output to VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=123479
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Video and audio elements don't appear as distinct objects in the AX hierarchy,
nor are they treated as replaceable objects when emitting the text. We should
treat these characters like attachments, for one. On the Mac platform, we should
also identify them with special subroles.
Tests: platform/mac/accessibility/media-emits-object-replacement.html
platform/mac/accessibility/media-role-descriptions.html
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isGenericFocusableElement):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
* editing/TextIterator.cpp:
(WebCore::isRendererReplacedElement):
LayoutTests:
Making media elements int replaced elements has the unfortunate side-effect
of causing a new line to be inserted into any test using a <video> or <audio> tag.
* compositing/video/video-poster-expected.txt:
* compositing/video/video-reflection-expected.txt:
* compositing/visibility/visibility-simple-video-layer-expected.txt:
* fast/css/first-letter-block-form-controls-crash-expected.txt:
* fast/css/relative-position-replaced-in-table-display-crash-expected.txt:
* fast/forms/access-key-for-all-elements-expected.txt:
* fast/forms/form-associated-element-crash3-expected.txt:
* fast/multicol/renderer-positioned-assert-crash-expected.txt:
* fast/regions/full-screen-video-from-region-expected.txt:
* fast/runin/nonblock-runin-expected.txt:
* fast/spatial-navigation/snav-media-elements-expected.txt:
* fullscreen/full-screen-crash-offsetLeft-expected.txt:
* fullscreen/full-screen-no-style-sharing-expected.txt:
* fullscreen/full-screen-stacking-context-expected.txt:
* fullscreen/video-controls-drag-expected.txt:
* fullscreen/video-controls-timeline-expected.txt:
* fullscreen/video-cursor-auto-hide-expected.txt:
* fullscreen/video-specified-size-expected.txt:
* http/tests/appcache/video-expected.txt:
* http/tests/media/pdf-served-as-pdf-expected.txt:
* http/tests/media/reload-after-dialog-expected.txt:
* http/tests/media/text-served-as-text-expected.txt:
* http/tests/media/video-accept-encoding-expected.txt:
* http/tests/media/video-buffered-range-contains-currentTime-expected.txt:
* http/tests/media/video-cross-site-expected.txt:
* http/tests/media/video-error-abort-expected.txt:
* http/tests/media/video-load-suspend-expected.txt:
* http/tests/media/video-play-progress-expected.txt:
* http/tests/media/video-play-stall-before-meta-data-expected.txt:
* http/tests/media/video-preload-expected.txt:
* http/tests/media/video-redirect-expected.txt:
* http/tests/media/video-referer-expected.txt:
* http/tests/media/video-served-as-text-expected.txt:
* http/tests/media/video-throttled-load-metadata-expected.txt:
* http/tests/misc/empty-urls-expected.txt:
* http/tests/security/contentSecurityPolicy/media-src-allowed-expected.txt:
* http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
* http/tests/security/local-video-poster-from-remote-expected.txt:
* http/tests/security/local-video-source-from-remote-expected.txt:
* http/tests/security/local-video-src-from-remote-expected.txt:
* http/tests/security/text-track-crossorigin-expected.txt:
* media/W3C/audio/events/event_canplay-expected.txt:
* media/W3C/audio/events/event_canplay_manual-expected.txt:
* media/W3C/audio/events/event_canplaythrough-expected.txt:
* media/W3C/audio/events/event_canplaythrough_manual-expected.txt:
* media/W3C/audio/events/event_loadeddata-expected.txt:
* media/W3C/audio/events/event_loadeddata_manual-expected.txt:
* media/W3C/audio/events/event_loadedmetadata-expected.txt:
* media/W3C/audio/events/event_loadedmetadata_manual-expected.txt:
* media/W3C/audio/events/event_loadstart-expected.txt:
* media/W3C/audio/events/event_loadstart_manual-expected.txt:
* media/W3C/audio/events/event_order_canplay_canplaythrough-expected.txt:
* media/W3C/audio/events/event_order_canplay_playing-expected.txt:
* media/W3C/audio/events/event_order_loadedmetadata_loadeddata-expected.txt:
* media/W3C/audio/events/event_order_loadstart_progress-expected.txt:
* media/W3C/audio/events/event_pause_manual-expected.txt:
* media/W3C/audio/events/event_play-expected.txt:
* media/W3C/audio/events/event_play_manual-expected.txt:
* media/W3C/audio/events/event_playing-expected.txt:
* media/W3C/audio/events/event_playing_manual-expected.txt:
* media/W3C/audio/events/event_progress-expected.txt:
* media/W3C/audio/events/event_progress_manual-expected.txt:
* media/W3C/audio/events/event_timeupdate-expected.txt:
* media/W3C/audio/events/event_timeupdate_manual-expected.txt:
* media/W3C/audio/networkState/networkState_during_loadstart-expected.txt:
* media/W3C/audio/paused/paused_false_during_play-expected.txt:
* media/W3C/audio/paused/paused_true_during_pause-expected.txt:
* media/W3C/audio/readyState/readyState_during_canplay-expected.txt:
* media/W3C/audio/readyState/readyState_during_canplaythrough-expected.txt:
* media/W3C/audio/readyState/readyState_during_loadeddata-expected.txt:
* media/W3C/audio/readyState/readyState_during_loadedmetadata-expected.txt:
* media/W3C/audio/readyState/readyState_during_playing-expected.txt:
* media/W3C/video/canPlayType/canPlayType_application_octet_stream-expected.txt:
* media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_1-expected.txt:
* media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_2-expected.txt:
* media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_3-expected.txt:
* media/W3C/video/canPlayType/canPlayType_bogus_type-expected.txt:
* media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt:
* media/W3C/video/canPlayType/canPlayType_method_exists-expected.txt:
* media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt:
* media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt:
* media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt:
* media/W3C/video/currentSrc/currentSrc_empty_if_no_src-expected.txt:
* media/W3C/video/currentSrc/currentSrc_property_exists-expected.txt:
* media/W3C/video/error/error_null-expected.txt:
* media/W3C/video/error/error_onerror_called_on_bogus_source-expected.txt:
* media/W3C/video/error/error_property_exists-expected.txt:
* media/W3C/video/events/event_canplay-expected.txt:
* media/W3C/video/events/event_canplay_manual-expected.txt:
* media/W3C/video/events/event_canplaythrough-expected.txt:
* media/W3C/video/events/event_canplaythrough_manual-expected.txt:
* media/W3C/video/events/event_loadeddata-expected.txt:
* media/W3C/video/events/event_loadeddata_manual-expected.txt:
* media/W3C/video/events/event_loadedmetadata-expected.txt:
* media/W3C/video/events/event_loadedmetadata_manual-expected.txt:
* media/W3C/video/events/event_loadstart-expected.txt:
* media/W3C/video/events/event_loadstart_manual-expected.txt:
* media/W3C/video/events/event_order_canplay_canplaythrough-expected.txt:
* media/W3C/video/events/event_order_canplay_playing-expected.txt:
* media/W3C/video/events/event_order_loadedmetadata_loadeddata-expected.txt:
* media/W3C/video/events/event_order_loadstart_progress-expected.txt:
* media/W3C/video/events/event_pause_manual-expected.txt:
* media/W3C/video/events/event_play-expected.txt:
* media/W3C/video/events/event_play_manual-expected.txt:
* media/W3C/video/events/event_playing-expected.txt:
* media/W3C/video/events/event_playing_manual-expected.txt:
* media/W3C/video/events/event_progress-expected.txt:
* media/W3C/video/events/event_progress_manual-expected.txt:
* media/W3C/video/events/event_timeupdate-expected.txt:
* media/W3C/video/events/event_timeupdate_manual-expected.txt:
* media/W3C/video/networkState/networkState_during_loadstart-expected.txt:
* media/W3C/video/networkState/networkState_during_progress-expected.txt:
* media/W3C/video/networkState/networkState_initial-expected.txt:
* media/W3C/video/networkState/networkState_property_exists-expected.txt:
* media/W3C/video/paused/paused_false_during_play-expected.txt:
* media/W3C/video/paused/paused_true_during_pause-expected.txt:
* media/W3C/video/preload/preload_property_exists-expected.txt:
* media/W3C/video/preload/preload_reflects_auto_value-expected.txt:
* media/W3C/video/preload/preload_reflects_bogus_value-expected.txt:
* media/W3C/video/preload/preload_reflects_empty-expected.txt:
* media/W3C/video/preload/preload_reflects_metadata-expected.txt:
* media/W3C/video/preload/preload_reflects_no_value-expected.txt:
* media/W3C/video/preload/preload_reflects_none-expected.txt:
* media/W3C/video/preload/preload_reflects_none_autoplay-expected.txt:
* media/W3C/video/readyState/readyState_during_canplay-expected.txt:
* media/W3C/video/readyState/readyState_during_canplaythrough-expected.txt:
* media/W3C/video/readyState/readyState_during_loadeddata-expected.txt:
* media/W3C/video/readyState/readyState_during_loadedmetadata-expected.txt:
* media/W3C/video/readyState/readyState_during_playing-expected.txt:
* media/W3C/video/readyState/readyState_initial-expected.txt:
* media/W3C/video/readyState/readyState_property_exists-expected.txt:
* media/W3C/video/src/src_reflects_attribute_not_source_elements-expected.txt:
* media/W3C/video/src/src_reflects_no_value-expected.txt:
* media/W3C/video/src/src_removal_does_not_trigger_loadstart-expected.txt:
* media/audio-mpeg-supported-expected.txt:
* media/audio-mpeg4-supported-expected.txt:
* media/audio-only-video-intrinsic-size-expected.txt:
* media/auto-play-in-sandbox-with-allow-scripts-expected.txt:
* media/before-load-member-access-expected.txt:
* media/broken-video-expected.txt:
* media/constructors-expected.txt:
* media/controls-css-overload-expected.txt:
* media/controls-drag-timebar-expected.txt:
* media/controls-layout-direction-expected.txt:
* media/controls-right-click-on-timebar-expected.txt:
* media/csp-blocks-video-expected.txt:
* media/event-attributes-expected.txt:
* media/media-blocked-by-beforeload-expected.txt:
* media/media-blocked-by-willsendrequest-expected.txt:
* media/media-can-play-mpeg-audio-expected.txt:
* media/media-can-play-mpeg4-video-expected.txt:
* media/media-can-play-octet-stream-expected.txt:
* media/media-can-play-type-expected.txt:
* media/media-can-play-wav-audio-expected.txt:
* media/media-captions-expected.txt:
* media/media-captions-no-controls-expected.txt:
* media/media-controller-expected.txt:
* media/media-controller-playback-expected.txt:
* media/media-controller-playbackrate-expected.txt:
* media/media-controller-time-clamp-expected.txt:
* media/media-controller-time-constant-expected.txt:
* media/media-controller-time-expected.txt:
* media/media-controller-timeupdate-expected.txt:
* media/media-controller-unpause-expected.txt:
* media/media-controls-invalid-url-expected.txt:
* media/media-ended-expected.txt:
* media/media-extension-with-fragment-expected.txt:
* media/media-fragments/TC0001-expected.txt:
* media/media-fragments/TC0002-expected.txt:
* media/media-fragments/TC0003-expected.txt:
* media/media-fragments/TC0004-expected.txt:
* media/media-fragments/TC0005-expected.txt:
* media/media-fragments/TC0006-expected.txt:
* media/media-fragments/TC0009-expected.txt:
* media/media-fragments/TC0011-expected.txt:
* media/media-fragments/TC0012-expected.txt:
* media/media-fragments/TC0014-expected.txt:
* media/media-fragments/TC0015-expected.txt:
* media/media-fragments/TC0017-expected.txt:
* media/media-fragments/TC0024-expected.txt:
* media/media-fragments/TC0027-expected.txt:
* media/media-fragments/TC0028-expected.txt:
* media/media-fragments/TC0029-expected.txt:
* media/media-fragments/TC0030-expected.txt:
* media/media-fragments/TC0031-expected.txt:
* media/media-fragments/TC0032-expected.txt:
* media/media-fragments/TC0033-expected.txt:
* media/media-fragments/TC0034-expected.txt:
* media/media-fragments/TC0035-expected.txt:
* media/media-fragments/TC0036-expected.txt:
* media/media-fragments/TC0037-expected.txt:
* media/media-fragments/TC0038-expected.txt:
* media/media-fragments/TC0039-expected.txt:
* media/media-fragments/TC0044-expected.txt:
* media/media-fragments/TC0051-expected.txt:
* media/media-fragments/TC0052-expected.txt:
* media/media-fragments/TC0053-expected.txt:
* media/media-fragments/TC0054-expected.txt:
* media/media-fragments/TC0055-expected.txt:
* media/media-fragments/TC0058-expected.txt:
* media/media-fragments/TC0059-expected.txt:
* media/media-fragments/TC0061-expected.txt:
* media/media-fragments/TC0062-expected.txt:
* media/media-fragments/TC0063-expected.txt:
* media/media-fragments/TC0064-expected.txt:
* media/media-fragments/TC0065-expected.txt:
* media/media-fragments/TC0066-expected.txt:
* media/media-fragments/TC0067-expected.txt:
* media/media-fragments/TC0068-expected.txt:
* media/media-fragments/TC0069-expected.txt:
* media/media-fragments/TC0070-expected.txt:
* media/media-fragments/TC0071-expected.txt:
* media/media-fragments/TC0072-expected.txt:
* media/media-fragments/TC0073-expected.txt:
* media/media-fragments/TC0074-expected.txt:
* media/media-fragments/TC0075-expected.txt:
* media/media-fragments/TC0076-expected.txt:
* media/media-fragments/TC0077-expected.txt:
* media/media-fragments/TC0078-expected.txt:
* media/media-fragments/TC0079-expected.txt:
* media/media-fragments/TC0080-expected.txt:
* media/media-fragments/TC0081-expected.txt:
* media/media-fragments/TC0082-expected.txt:
* media/media-fragments/TC0083-expected.txt:
* media/media-fragments/TC0084-expected.txt:
* media/media-fragments/TC0085-expected.txt:
* media/media-fragments/TC0086-expected.txt:
* media/media-fragments/TC0087-expected.txt:
* media/media-fragments/TC0088-expected.txt:
* media/media-fragments/TC0089-expected.txt:
* media/media-fragments/TC0090-expected.txt:
* media/media-fragments/TC0091-expected.txt:
* media/media-fragments/TC0092-expected.txt:
* media/media-fragments/TC0093-expected.txt:
* media/media-fragments/TC0094-expected.txt:
* media/media-fullscreen-inline-expected.txt:
* media/media-preload-no-delay-loadevent-expected.txt:
* media/no-autoplay-with-user-gesture-requirement-expected.txt:
* media/nodesFromRect-shadowContent-expected.txt:
* media/restore-from-page-cache-expected.txt:
* media/sources-fallback-codecs-expected.txt:
* media/track/add-and-remove-track-expected.txt:
* media/track/audio-track-expected.txt:
* media/track/opera/interfaces/TextTrack/addCue-expected.txt:
* media/track/opera/interfaces/TextTrack/removeCue-expected.txt:
* media/track/opera/interfaces/TextTrackCue/align-expected.txt:
* media/track/opera/interfaces/TextTrackCue/endTime-expected.txt:
* media/track/opera/interfaces/TextTrackCue/id-expected.txt:
* media/track/opera/interfaces/TextTrackCue/pauseOnExit-expected.txt:
* media/track/opera/interfaces/TextTrackCue/startTime-expected.txt:
* media/track/opera/interfaces/TextTrackCue/track-expected.txt:
* media/track/opera/interfaces/TextTrackCueList/getCueById-expected.txt:
* media/track/opera/interfaces/TextTrackCueList/length-expected.txt:
* media/track/text-track-cue-is-reachable-expected.txt:
* media/track/text-track-is-reachable-expected.txt:
* media/track/track-active-cues-expected.txt:
* media/track/track-add-remove-cue-expected.txt:
* media/track/track-add-track-expected.txt:
* media/track/track-addtrack-kind-expected.txt:
* media/track/track-automatic-subtitles-expected.txt:
* media/track/track-css-all-cues-expected.txt:
* media/track/track-css-cue-lifetime-expected.txt:
* media/track/track-css-matching-default-expected.txt:
* media/track/track-css-matching-expected.txt:
* media/track/track-css-matching-lang-expected.txt:
* media/track/track-css-matching-timestamps-expected.txt:
* media/track/track-css-property-whitelist-expected.txt:
* media/track/track-css-user-override-expected.txt:
* media/track/track-cue-container-rendering-position-expected.txt:
* media/track/track-cue-empty-text-crash-expected.txt:
* media/track/track-cue-inline-assertion-crash-expected.txt:
* media/track/track-cue-mutable-expected.txt:
* media/track/track-cue-mutable-fragment-expected.txt:
* media/track/track-cue-negative-timestamp-expected.txt:
* media/track/track-cue-nothing-to-render-expected.txt:
* media/track/track-cue-overlap-snap-to-lines-not-set-expected.txt:
* media/track/track-cue-rendering-empty-cue-crash-expected.txt:
* media/track/track-cue-rendering-expected.txt:
* media/track/track-cue-rendering-on-resize-expected.txt:
* media/track/track-cue-rendering-rtl-expected.txt:
* media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt:
* media/track/track-cue-rendering-tree-is-removed-properly-expected.txt:
* media/track/track-cue-rendering-with-padding-expected.txt:
* media/track/track-cues-cuechange-expected.txt:
* media/track/track-cues-enter-exit-expected.txt:
* media/track/track-cues-missed-expected.txt:
* media/track/track-cues-pause-on-exit-expected.txt:
* media/track/track-cues-seeking-expected.txt:
* media/track/track-cues-sorted-before-dispatch-expected.txt:
* media/track/track-default-attribute-expected.txt:
* media/track/track-disabled-addcue-expected.txt:
* media/track/track-disabled-expected.txt:
* media/track/track-element-load-event-expected.txt:
* media/track/track-in-band-cues-added-once-expected.txt:
* media/track/track-in-band-duplicate-tracks-when-source-changes-expected.txt:
* media/track/track-in-band-expected.txt:
* media/track/track-in-band-legacy-api-expected.txt:
* media/track/track-in-band-style-expected.txt:
* media/track/track-kind-expected.txt:
* media/track/track-large-timestamp-expected.txt:
* media/track/track-legacyapi-with-automatic-mode-expected.txt:
* media/track/track-load-from-element-readyState-expected.txt:
* media/track/track-load-from-src-readyState-expected.txt:
* media/track/track-long-captions-file-expected.txt:
* media/track/track-mode-disabled-crash-expected.txt:
* media/track/track-mode-expected.txt:
* media/track/track-mode-not-changed-by-new-track-expected.txt:
* media/track/track-mode-triggers-loading-expected.txt:
* media/track/track-remove-active-cue-crash-expected.txt:
* media/track/track-remove-by-setting-innerHTML-expected.txt:
* media/track/track-remove-quickly-expected.txt:
* media/track/track-text-track-cue-list-expected.txt:
* media/track/track-texttracks-expected.txt:
* media/track/track-webvtt-tc000-empty-expected.txt:
* media/track/track-webvtt-tc001-utf8-expected.txt:
* media/track/track-webvtt-tc002-bom-expected.txt:
* media/track/track-webvtt-tc003-newlines-expected.txt:
* media/track/track-webvtt-tc004-magic-header-expected.txt:
* media/track/track-webvtt-tc005-header-comment-expected.txt:
* media/track/track-webvtt-tc006-cue-identifiers-expected.txt:
* media/track/track-webvtt-tc007-cue-no-id-expected.txt:
* media/track/track-webvtt-tc008-timings-no-hours-expected.txt:
* media/track/track-webvtt-tc009-timings-hour-expected.txt:
* media/track/track-webvtt-tc010-no-timings-expected.txt:
* media/track/track-webvtt-tc011-blank-lines-expected.txt:
* media/track/track-webvtt-tc013-settings-expected.txt:
* media/track/track-webvtt-tc014-alignment-expected.txt:
* media/track/track-webvtt-tc015-positioning-expected.txt:
* media/track/track-webvtt-tc016-align-positioning-expected.txt:
* media/track/track-webvtt-tc017-line-position-expected.txt:
* media/track/track-webvtt-tc018-align-text-line-position-expected.txt:
* media/track/track-webvtt-tc019-cue-size-expected.txt:
* media/track/track-webvtt-tc020-cue-size-align-expected.txt:
* media/track/track-webvtt-tc021-valign-expected.txt:
* media/track/track-webvtt-tc022-entities-expected.txt:
* media/track/track-webvtt-tc023-markup-expected.txt:
* media/track/track-webvtt-tc024-timestamp-expected.txt:
* media/track/track-webvtt-tc025-class-markup-expected.txt:
* media/track/track-webvtt-tc026-voice-expected.txt:
* media/track/track-webvtt-tc027-empty-cue-expected.txt:
* media/track/track-webvtt-tc028-unsupported-markup-expected.txt:
* media/track/track-word-breaking-expected.txt:
* media/track/tracklist-is-reachable-expected.txt:
* media/track/video-track-expected.txt:
* media/unsupported-rtsp-expected.txt:
* media/unsupported-tracks-expected.txt:
* media/video-append-source-expected.txt:
* media/video-autoplay-expected.txt:
* media/video-beforeload-remove-source-expected.txt:
* media/video-buffered-expected.txt:
* media/video-canvas-drawing-expected.txt:
* media/video-canvas-drawing-output-expected.txt:
* media/video-controls-captions-trackmenu-hide-on-click-outside-expected.txt:
* media/video-controls-captions-trackmenu-includes-enabled-track-expected.txt:
* media/video-controls-expected.txt:
* media/video-controls-transformed-expected.txt:
* media/video-controls-with-mutation-event-handler-expected.txt:
* media/video-controls-zoomed-expected.txt:
* media/video-currentTime-delay-expected.txt:
* media/video-currentTime-expected.txt:
* media/video-currentTime-set-expected.txt:
* media/video-currentTime-set2-expected.txt:
* media/video-delay-load-event-expected.txt:
* media/video-display-aspect-ratio-expected.txt:
* media/video-dom-autoplay-expected.txt:
* media/video-dom-preload-expected.txt:
* media/video-dom-src-expected.txt:
* media/video-duration-known-after-eos-expected.txt:
* media/video-error-does-not-exist-expected.txt:
* media/video-load-networkState-expected.txt:
* media/video-load-preload-metadata-expected.txt:
* media/video-load-preload-none-expected.txt:
* media/video-load-readyState-expected.txt:
* media/video-load-require-user-gesture-expected.txt:
* media/video-loop-expected.txt:
* media/video-mouse-focus-expected.txt:
* media/video-muted-expected.txt:
* media/video-no-autoplay-expected.txt:
* media/video-pause-empty-events-expected.txt:
* media/video-pause-immediately-expected.txt:
* media/video-play-empty-events-expected.txt:
* media/video-play-pause-events-expected.txt:
* media/video-play-pause-exception-expected.txt:
* media/video-play-require-user-gesture-expected.txt:
* media/video-playbackrate-expected.txt:
* media/video-played-collapse-expected.txt:
* media/video-played-ranges-1-expected.txt:
* media/video-played-reset-expected.txt:
* media/video-plays-past-end-of-test-expected.txt:
* media/video-poster-blocked-by-willsendrequest-expected.txt:
* media/video-poster-delayed-expected.txt:
* media/video-poster-expected.txt:
* media/video-poster-scale-expected.txt:
* media/video-preload-expected.txt:
* media/video-replaces-poster-expected.txt:
* media/video-reverse-play-duration-expected.txt:
* media/video-seek-after-end-expected.txt:
* media/video-seek-by-small-increment-expected.txt:
* media/video-seek-multiple-expected.txt:
* media/video-seek-no-src-exception-expected.txt:
* media/video-seek-past-end-playing-expected.txt:
* media/video-seekable-expected.txt:
* media/video-seeking-expected.txt:
* media/video-set-rate-from-pause-expected.txt:
* media/video-single-valid-source-expected.txt:
* media/video-size-expected.txt:
* media/video-source-error-expected.txt:
* media/video-source-error-no-candidate-expected.txt:
* media/video-source-expected.txt:
* media/video-source-inserted-expected.txt:
* media/video-source-load-expected.txt:
* media/video-source-none-supported-expected.txt:
* media/video-source-type-expected.txt:
* media/video-src-blob-expected.txt:
* media/video-src-change-expected.txt:
* media/video-src-empty-expected.txt:
* media/video-src-expected.txt:
* media/video-src-invalid-poster-expected.txt:
* media/video-src-invalid-remove-expected.txt:
* media/video-src-none-expected.txt:
* media/video-src-plus-source-expected.txt:
* media/video-src-remove-expected.txt:
* media/video-src-set-expected.txt:
* media/video-src-source-expected.txt:
* media/video-timeupdate-during-playback-expected.txt:
* media/video-timeupdate-reverse-play-expected.txt:
* media/video-volume-expected.txt:
* media/video-width-height-expected.txt:
* platform/mac/accessibility/media-element-expected.txt:
* platform/mac/accessibility/media-emits-object-replacement-expected.txt: Added.
* platform/mac/accessibility/media-emits-object-replacement.html: Added.
* platform/mac/accessibility/media-role-descriptions-expected.txt: Added.
* platform/mac/accessibility/media-role-descriptions.html: Added.
* platform/mac/compositing/video/video-object-fit-expected.txt:
* platform/mac/fullscreen/video-controls-override-expected.txt:
* platform/mac/media/media-can-play-wav-audio-expected.txt:
* platform/mac/media/media-can-play-webm-expected.txt:
* platform/mac/media/video-seek-past-end-paused-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Nov 2013 13:55:36 +0000 (13:55 +0000)]
[ATK] Implement tables-related attributesOf*() functions for AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=118969
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-06
Reviewed by Mario Sanchez Prada.
Added missing implementation of attributesOfColumnHeaders, attributesOfRowHeaders, attributesOfVisibleCells.
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::attributesOfChildren):
(AccessibilityUIElement::attributesOfColumnHeaders):
(AccessibilityUIElement::attributesOfRowHeaders):
(AccessibilityUIElement::attributesOfVisibleCells):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Nov 2013 11:31:12 +0000 (11:31 +0000)]
[ATK] accessibility/tabindex-elements-are-accessible.html is failing
https://bugs.webkit.org/show_bug.cgi?id=123884
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-06
Reviewed by Mario Sanchez Prada.
Added new accessibility expectation file. ATK represents paragraph's role as a ATK_ROLE_PARAGRAPH.
* platform/efl/TestExpectations: Test is no longer failing.
* platform/efl/accessibility/tabindex-elements-are-accessible-expected.txt: Added.
* platform/gtk/accessibility/tabindex-elements-are-accessible-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Wed, 6 Nov 2013 11:17:45 +0000 (11:17 +0000)]
Unreviewed GTK gardening. Tests failing after r158195
* platform/gtk/TestExpectations: Added failure expectations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 6 Nov 2013 11:11:07 +0000 (11:11 +0000)]
Notify nodes removal to Range/Selection after dispatching blur and mutation event
https://bugs.webkit.org/show_bug.cgi?id=123880
Reviewed by Andreas Kling.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/
b60576a0560d14f8757e58d55d37b7cefa48a6ac
In willRemoveChildren in ContainerNode.cpp, call Document::nodeChildrenWillBeRemoved after instead of
before dispatching mutation events because we need to update ranges created by those mutation event
listeners. willRemoveChild was fixed in r115686.
Tests: editing/selection/selection-change-in-blur-event-by-remove-children.html
editing/selection/selection-change-in-mutation-event-by-remove-children.html
fast/dom/Range/range-created-during-remove-children.html
* dom/ContainerNode.cpp:
(WebCore::willRemoveChildren):
LayoutTests:
* editing/selection/selection-change-in-blur-event-by-remove-children-expected.txt: Added.
* editing/selection/selection-change-in-blur-event-by-remove-children.html: Added.
* editing/selection/selection-change-in-mutation-event-by-remove-children-expected.txt: Added.
* editing/selection/selection-change-in-mutation-event-by-remove-children.html: Added.
* fast/dom/Range/range-created-during-remove-children-expected.txt: Added.
* fast/dom/Range/range-created-during-remove-children.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 6 Nov 2013 10:55:08 +0000 (10:55 +0000)]
Fix out-of-date offset in selection range code in range.surroundContents
https://bugs.webkit.org/show_bug.cgi?id=123871
Source/WebCore:
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/
c89b413ff0fc4aafa0c71d180b0b1e131bb37707
The code in Range::insertNode assumeed that the start offset of the selection range within its container
doesn't change across a call to insertBefore on the container but this is wrong. This patch recomputes
the start offset when it is used after the insertBefore call.
Test: editing/selection/range-surroundContents-with-preceding-node.html
* dom/Range.cpp:
(WebCore::Range::insertNode):
LayoutTests:
Reviewed by Andreas Kling.
* editing/selection/range-surroundContents-with-preceding-node-expected.txt: Added.
* editing/selection/range-surroundContents-with-preceding-node.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Nov 2013 10:33:02 +0000 (10:33 +0000)]
[GTK] accessibility/svg-group-element-with-title.html is failing
https://bugs.webkit.org/show_bug.cgi?id=114251
Unreviewed GTK gardening.
Removed failure expectation as the test is passing since r158664.
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-11-06
* platform/gtk/TestExpectations: The test is no longer failing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Wed, 6 Nov 2013 10:26:56 +0000 (10:26 +0000)]
Add InlineElementBox and stop instantiating InlineBox directly.
<https://webkit.org/b/123882>
Make the InlineBox constructors protected and add a new class
called InlineElementBox on top. This is somewhat analogous to the
split between RenderText and RenderElement, and allows us to make
renderer() return a far tighter RenderBoxModelObject& instead
of a RenderObject&.
Moved over attachLine(), deleteLine() and extractLine() to start
things off. More things will follow.
Reviewed by Antti Koivisto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Nov 2013 10:21:26 +0000 (10:21 +0000)]
[EFL] Change required version of ATK to 2.10.0
https://bugs.webkit.org/show_bug.cgi?id=123883
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-06
Reviewed by Mario Sanchez Prada.
Changing a required version of ATK to 2.10.0
* Source/cmake/OptionsEfl.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Nov 2013 09:32:26 +0000 (09:32 +0000)]
Source/WebCore: Seek for video doesn't work when playback rate is negative
https://bugs.webkit.org/show_bug.cgi?id=123791
In MediaPlayerPrivateGStreamer::seek negative playback rate was not taken to account.
Patch by Piotr Grad <p.grad@samsung.com> on 2013-11-06
Reviewed by Philippe Normand.
Test: media/video-seek-with-negative-playback.html
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::seek):
LayoutTests: Test for seek not working properly with negative playback rate.
https://bugs.webkit.org/show_bug.cgi?id=123791
Seek method should work properly with negative playback rate.
Patch by Piotr Grad <p.grad@samsung.com> on 2013-11-06
Reviewed by Philippe Normand.
* media/video-seek-with-negative-playback.html: Added.
* media/video-seek-with-negative-playback-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Wed, 6 Nov 2013 08:19:38 +0000 (08:19 +0000)]
Reinstate an annoying assertion that I accidentally commented out.
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousIconForPageURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Nov 2013 08:14:46 +0000 (08:14 +0000)]
[GStreamer] Override label() and language() in Audio and VideoTrackPrivateGStreamer
https://bugs.webkit.org/show_bug.cgi?id=123836
The tests are currently flakey because we only get the label and language if we get
tags after the track client is set.
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-06
Reviewed by Philippe Normand.
No new tests because the tests already exist (this fixes flakeyness).
* platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h: Override label() and language() to use m_label and m_language.
* platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h: Same.
* platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: Make m_label and m_language protected so they can be used in the functions above.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 6 Nov 2013 08:13:33 +0000 (08:13 +0000)]
Add a test for queries whose leftmost selector matches the root node
https://bugs.webkit.org/show_bug.cgi?id=123877
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/
22981c70bf93e8a07ee7b4d68a4522aee21b26ce
so that we won't introduce the regression they had.
* fast/selectors/querySelector-leftmost-selector-matches-rootNode-expected.txt: Added.
* fast/selectors/querySelector-leftmost-selector-matches-rootNode.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Wed, 6 Nov 2013 08:09:44 +0000 (08:09 +0000)]
RenderBlockFlow should only expose its line boxes as RootInlineBox.
<https://webkit.org/b/123878>
The line boxes attached directly to a RenderBlockFlow are always
RootInlineBox objects, so call sites should always use the tightly
typed firstRootBox() and lastRootBox().
This allows the compiler to devirtualize calls to member functions
of RootInlineBox that are marked FINAL.
Reviewed by Antti Koivisto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 6 Nov 2013 08:05:09 +0000 (08:05 +0000)]
Assertion failure end < m_runCount in WebCore::BidiRunList<WebCore::BidiRun>::reverseRuns
https://bugs.webkit.org/show_bug.cgi?id=123863
Reviewed by Andreas Kling.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/
cbaa92c763a37d89eeabd01658e522219299290c
Test: fast/text/bidi-reverse-runs-crash.html
* platform/text/BidiResolver.h:
(WebCore::BidiResolver<Iterator, Run>::createBidiRunsForLine): Don't reverse the runs if there's
nothing to be reversed.
LayoutTests:
* fast/text/bidi-reverse-runs-crash-expected.txt: Added.
* fast/text/bidi-reverse-runs-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 6 Nov 2013 08:02:18 +0000 (08:02 +0000)]
Address the review comment after r158724.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zalan@apple.com [Wed, 6 Nov 2013 07:31:52 +0000 (07:31 +0000)]
Widget's position change should not initiate layout, only when its size changes.
https://bugs.webkit.org/show_bug.cgi?id=123860
Reviewed by Andreas Kling.
RenderWidgets initiate unnecessary layouts while scrolling when they are embedded to
overflow:scroll containers. Scroll position change doesn't dirty the render tree
so it should not trigger layout either.
.:
* ManualTests/layouts-on-renderwidgets-while-scrolling.html: Added.
Source/WebCore:
Manual test added. Unfortunately we can't test against the number of layouts yet.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::updateWidgetGeometry):
(WebCore::RenderWidget::updateWidgetPosition):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 6 Nov 2013 07:30:55 +0000 (07:30 +0000)]
Add more tests for formaction, formenctype, formmethod, formnovalidate, and formtarget attributes
https://bugs.webkit.org/show_bug.cgi?id=123876
Reviewed by Andreas Kling.
Merge tests from https://chromium.googlesource.com/chromium/blink/+/
5f4ccd416fec39a6878af66e87bda191cc59ea7e
so that we won't introduce regressions they had.
* fast/forms/formaction-attribute-expected.txt:
* fast/forms/formaction-attribute.html:
* fast/forms/formmethod-attribute-input-2-expected.txt: Added.
* fast/forms/formmethod-attribute-input-2.html: Added.
* fast/forms/formtarget-attribute-input-2-expected.txt: Added.
* fast/forms/formtarget-attribute-input-2.html: Added.
* fast/forms/interactive-validation-formnovalidate-2-expected.txt: Added.
* fast/forms/interactive-validation-formnovalidate-2.html: Added.
* fast/forms/mailto/formenctype-attribute-input-2-expected.txt: Added.
* fast/forms/mailto/formenctype-attribute-input-2.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 6 Nov 2013 07:20:02 +0000 (07:20 +0000)]
Mac Mavericks rebaseline after r158714.
* platform/mac/fast/forms/textAreaLineHeight-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 6 Nov 2013 07:11:31 +0000 (07:11 +0000)]
Use-after-free in SliderThumbElement::dragFrom
https://bugs.webkit.org/show_bug.cgi?id=123873
Reviewed by Andreas Kling.
Source/WebCore:
Ref the SliderThumbElement since it could go away inside dragFrom.
Test: fast/forms/range/range-type-change-onchange-2.html
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
LayoutTests:
Merge https://chromium.googlesource.com/chromium/blink/+/
04a23bfca2d04101a1828d36ff36c29f3a24f34b
* fast/forms/range/range-type-change-onchange-2-expected.txt: Added.
* fast/forms/range/range-type-change-onchange-2.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 6 Nov 2013 06:14:47 +0000 (06:14 +0000)]
Change the order of conditions to avoid computing rendererIsEditable()
https://bugs.webkit.org/show_bug.cgi?id=123868
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/
c89b413ff0fc4aafa0c71d180b0b1e131bb37707
When we need both Node::renderer() and Node::rendererIsEditable() conditions to be true to perform
some operation, it is more effective to check for renderer() first, so that if this condition fails
we can avoid unnecessary computation of rendererIsEditable().
* dom/Position.cpp:
(WebCore::nextRenderedEditable):
(WebCore::previousRenderedEditable):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 6 Nov 2013 06:02:35 +0000 (06:02 +0000)]
simpleUserAgentStyleSheet doesn't have focus ring on anchor element
https://bugs.webkit.org/show_bug.cgi?id=123867
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/
08ecc23c4d80be9969918c4baf0ac83dc6cb6cbd
* css/CSSDefaultStyleSheets.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 6 Nov 2013 06:00:46 +0000 (06:00 +0000)]
valueForBorderRadiusShorthand returns wrong values in some case
https://bugs.webkit.org/show_bug.cgi?id=123866
Reviewed by Andreas Kling.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/
0933728126f2db06ab8e945efc98bffa2d42af1c
Because valueForBorderRadiusShorthand misses the followings:
- showHorizontalBottomRight depends on showHorizontalBottomLeft.
- showHorizontalTopRight depends on showHorizontalBottomRight (including showHorizontalBottomLeft).
See also http://dev.w3.org/csswg/css-backgrounds/#the-border-radius
Test: fast/css/getComputedStyle/getComputedStyle-borderRadius-2.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::getBorderRadiusShorthandValue):
LayoutTests:
* fast/css/getComputedStyle/getComputedStyle-borderRadius-2-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-borderRadius-2.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 6 Nov 2013 05:50:35 +0000 (05:50 +0000)]
Flaky Test: transitions/cancel-transition.html
https://bugs.webkit.org/show_bug.cgi?id=114193
Reviewed by Simon Fraser.
Merge https://chromium.googlesource.com/chromium/blink/+/
983dbbff6c46b6365540bf1451f25b31d72ce893
* transitions/cancel-transition.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 6 Nov 2013 05:21:42 +0000 (05:21 +0000)]
Protect DOM nodes in IndentOutdentCommand::tryIndentingAsListItem()
https://bugs.webkit.org/show_bug.cgi?id=123861
Reviewed by Benjamin Poulain.
Merge https://chromium.googlesource.com/chromium/blink/+/
297442eb539a2b764fdad323de79099a70179186 partially.
* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::tryIndentingAsListItem): Make selectedListItem, previousList, and nextList
RefPtr since they're are used after calling insertNodeBefore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Wed, 6 Nov 2013 04:47:12 +0000 (04:47 +0000)]
Apply more unique_ptr to line box management.
<https://webkit.org/b/123857>
Make all of the functions that return newly-created line boxes
return them packed up in std::unique_ptrs.
There is one exception in RenderBlockLineLayout where the function
createInlineBoxForRenderer() is inconsistent about the ownership of
the returned object. This will be addressed by a subsequent patch.
We now "release" the line boxes into their various home structures,
so the pointer smartness doesn't go end-to-end just yet.
Reviewed by Anders Carlsson.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 6 Nov 2013 04:40:02 +0000 (04:40 +0000)]
FTL should support NewObject
https://bugs.webkit.org/show_bug.cgi?id=123849
Reviewed by Oliver Hunt.
* ftl/FTLAbstractHeapRepository.cpp:
(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):
* ftl/FTLAbstractHeapRepository.h:
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLIntrinsicRepository.h:
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNewObject):
(JSC::FTL::LowerDFGToLLVM::allocate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 6 Nov 2013 04:38:23 +0000 (04:38 +0000)]
FTL should support StringCharAt
https://bugs.webkit.org/show_bug.cgi?id=123855
Reviewed by Oliver Hunt.
This is just like GetByVal for String, so we reuse that code.
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compileStringCharAt):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 6 Nov 2013 03:59:43 +0000 (03:59 +0000)]
Windows build fix attempt after r158704.
* FullscreenVideoController.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 6 Nov 2013 03:55:02 +0000 (03:55 +0000)]
getComputedStyle(x).lineHeight is affected by zooming
https://bugs.webkit.org/show_bug.cgi?id=123847
Reviewed by Benjamin Poulain.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/
7957097afbab2899ababd0d9c8acbf6e3eddb870
Test: fast/css/line-height-zoom-get-computed-style.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::lineHeightFromStyle): Don't round line-height values.
* css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyLineHeight::applyValue): Use the computed value instead of the used value.
LayoutTests:
Cleaned up the test.
* fast/css/line-height-zoom-get-computed-style-expected.txt: Added.
* fast/css/line-height-zoom-get-computed-style.html: Added.
* platform/mac-mountainlion/fast/forms/textAreaLineHeight-expected.txt: Rebaselined.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Nov 2013 03:50:51 +0000 (03:50 +0000)]
AX: media controls accessibility needs more work
https://bugs.webkit.org/show_bug.cgi?id=123749
Patch by James Craig <jcraig@apple.com> on 2013-11-05
Reviewed by Jer Noble.
Updated some of the control labels/roles to improve accessibility.
- Volume slider is now keyboard/screenreader accessible.
- muteButton was a checkbox toggling checked state, now a button that toggles label "mute/unmute"
- fullscreenButton was a checkbox toggling checked state, now a button that toggles label "display/exit full screen"
- captionButton was a checkbox, now a popup button that launches the newly accessible menu.
Subtitles menu is now keyboard/screenreader accessible (uses roaming tabindex).
Render dump expectations changed because volume slider is now hidden via...
...opacity/size (to make accessible without hover) instead of display:none.
Updated existing test coverage.
Source/WebCore:
* Modules/mediacontrols/mediaControlsApple.css:
(audio::-webkit-media-controls-panel .volume-box):
(audio::-webkit-media-controls-panel .volume-box:active):
(audio::-webkit-media-controls-toggle-closed-captions-button):
(audio::-webkit-media-controls-closed-captions-container .list):
(audio::-webkit-media-controls-closed-captions-container li:focus):
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.createControls):
(Controller.prototype.handleFullscreenChange):
(Controller.prototype.handleMuteButtonClicked):
(Controller.prototype.handleMinButtonClicked):
(Controller.prototype.handleMaxButtonClicked):
(Controller.prototype.handleVolumeSliderChange):
(Controller.prototype.buildCaptionMenu):
(Controller.prototype.focusSiblingCaptionItem):
(Controller.prototype.handleCaptionItemKeyUp):
LayoutTests:
* platform/mac/accessibility/media-element-expected.txt:
* platform/mac/media/audio-controls-rendering-expected.txt:
* platform/mac/media/controls-after-reload-expected.txt:
* platform/mac/media/controls-strict-expected.txt:
* platform/mac/media/controls-styling-strict-expected.txt:
* platform/mac/media/controls-without-preload-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Wed, 6 Nov 2013 03:36:32 +0000 (03:36 +0000)]
Move some plugin-specific code from RenderWidget to RenderEmbeddedObject.
<https://webkit.org/b/123845>
All RenderWidgets representing plugins will be RenderEmbeddedObjects.
Move some of the plugin-specific logic to RenderEmbeddedObject since it
doesn't make sense for all RenderWidgets (frames, embedded documents)
to care about this.
Reviewed by Anders Carlsson.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 6 Nov 2013 02:48:49 +0000 (02:48 +0000)]
Add a test to obtain offsetWidth of expanded table cell
https://bugs.webkit.org/show_bug.cgi?id=123843
Reviewed by Tim Horton.
Merge the test fix in https://chromium.googlesource.com/chromium/blink/+/
b249d552497c0939d8277360b99dd3c56b0c9659.
* fast/table/table-cell-offset-width-expected.txt:
* fast/table/table-cell-offset-width.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 6 Nov 2013 02:40:07 +0000 (02:40 +0000)]
Add a test to obtain offsetWidth of expanded table cell
https://bugs.webkit.org/show_bug.cgi?id=123843
Reviewed by Tim Horton.
Merge the test from https://chromium.googlesource.com/chromium/blink/+/
58a5fac292a5b3f79b00cdc71074fbf8be2ebc2b
so that we'll never introduce the regression they had.
* fast/table/table-cell-offset-width-expected.txt: Added.
* fast/table/table-cell-offset-width.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Wed, 6 Nov 2013 02:39:39 +0000 (02:39 +0000)]
Fix the 32-bit build.
* WebCore.exp.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
achicu@adobe.com [Wed, 6 Nov 2013 02:15:50 +0000 (02:15 +0000)]
Web Inspector: Moving an element while in the DOMNodeRemoved handler will hide it in the inspector
https://bugs.webkit.org/show_bug.cgi?id=123516
Reviewed by Timothy Hatcher.
Source/WebCore:
InspectorInstrumentation::willRemoveDOMNode was actually calling both willRemoveDOMNodeImpl and
didRemoveDOMNodeImpl, making the DOMAgent unbind the element even if it was still part of the DOM.
Because of that the DOMAgent was sending two events:
1. When the element was about to be removed, just before JS "DOMNodeRemoved" was triggered.
2. When the element was actually removed.
Note that inspector's event #2 will not know about the node, as it just removed it from the
internal hashmap, so it will just use a nodeID == 0 for it.
This patch adds a separate call to InspectorInstrumentation::didRemoveDOMNode, just before the
element is about to be removed. The InspectorInstrumentation::willRemoveDOMNode call is now only used
by the DOMDebugger to trigger the DOM breakpoints in the Web Inspector. That feature is not exposed
in the new Inspector UI, but can be used/tested using the protocol directly.
Tests: inspector-protocol/dom-debugger/node-removed.html
inspector-protocol/dom/dom-remove-events.html
inspector-protocol/dom/remove-multiple-nodes.html
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeBetween):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willRemoveDOMNode):
(WebCore::InspectorInstrumentation::didRemoveDOMNode):
LayoutTests:
Added tests to check that the DOM.childNodeRemoved inspector-protocol message is dispatched
correctly when DOM nodes are moved while inside the "DOMNodeRemoved" event handler.
* inspector-protocol/dom-debugger/node-removed-expected.txt: Added.
* inspector-protocol/dom-debugger/node-removed.html: Added. Checking that the DOMDebugger agent
is still sending the node-removed events.
* inspector-protocol/dom/dom-remove-events-expected.txt: Added.
* inspector-protocol/dom/dom-remove-events.html: Added. Test with a single DOM remove event.
* inspector-protocol/dom/remove-multiple-nodes-expected.txt: Added.
* inspector-protocol/dom/remove-multiple-nodes.html: Added. Test case when multiple children
are removed at once with parentNode.textContent = "String".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 6 Nov 2013 02:09:45 +0000 (02:09 +0000)]
Remove old unused code for hypothetical LLVM intrinsics
https://bugs.webkit.org/show_bug.cgi?id=123824
Reviewed by Oliver Hunt.
* ftl/FTLIntrinsicRepository.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 6 Nov 2013 02:07:43 +0000 (02:07 +0000)]
FTL should support String character access operations
https://bugs.webkit.org/show_bug.cgi?id=123783
Reviewed by Oliver Hunt.
Implements:
- string.length
- string[index]
* ftl/FTLAbstractHeapRepository.h:
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLIntrinsicRepository.h:
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetIndexedPropertyStorage):
(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryuan.choi@samsung.com [Wed, 6 Nov 2013 02:03:16 +0000 (02:03 +0000)]
Unreviewed build fix on CMake based ports with GLES.
* CMakeLists.txt:
Added OPENGLES2_LIBRARIES and OPENGLES2_INCLUDE_DIR into the includes and
libraries list.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Wed, 6 Nov 2013 01:44:50 +0000 (01:44 +0000)]
platformCALayerDeviceScaleFactor should be const
https://bugs.webkit.org/show_bug.cgi?id=123842
Reviewed by Simon Fraser.
* WebCore.exp.in:
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::LayerClient::platformCALayerDeviceScaleFactor):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::platformCALayerDeviceScaleFactor):
* platform/graphics/ca/GraphicsLayerCA.h:
* platform/graphics/ca/PlatformCALayerClient.h:
* platform/graphics/ca/mac/TileController.h:
* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::platformCALayerDeviceScaleFactor):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerDeviceScaleFactor):
Constify PlatformCALayerClient::platformCALayerDeviceScaleFactor.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc