WebKit-https.git
6 years agoAdopt is/toHTMLImageElement for code cleanup
kangil.han@samsung.com [Sat, 29 Jun 2013 02:41:54 +0000 (02:41 +0000)]
Adopt is/toHTMLImageElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118182

Reviewed by Andreas Kling.

To enhance readability, this patch adopts is/toHTMLImageElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isNativeImage):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::url):
* bindings/js/JSNodeCustom.cpp:
(WebCore::isReachableFromDOM):
* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::assignToHTMLImageElement):
(JSC::Bindings::QtPixmapRuntime::toQt):
* dom/Clipboard.cpp:
(WebCore::Clipboard::setDragImage):
* dom/Node.cpp:
(WebCore::Node::enclosingLinkEventParentOrSelf):
* editing/Editor.cpp:
(WebCore::imageElementFromImageDocument):
* html/HTMLAnchorElement.cpp:
(WebCore::appendServerMapMousePosition):
* html/HTMLImageElement.h:
(WebCore::isHTMLImageElement):
(WebCore::toHTMLImageElement):
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
* html/HTMLNameCollection.cpp:
(WebCore::WindowNameCollection::nodeMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatchesIfIdAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatches):
* page/DragController.cpp:
(WebCore::DragController::draggableElement):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::getURLForImageNode):
* platform/mac/HTMLConverter.mm:
(+[WebHTMLConverter editingAttributedStringFromRange:]):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::imageMap):
(WebCore::RenderImage::updateAltText):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldRespectImageOrientation):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
(BlackBerry::WebKit::WebPage::blockZoom):
* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPageThrottler::shouldThrottleTimers is wrong.
barraclough@apple.com [Sat, 29 Jun 2013 01:45:04 +0000 (01:45 +0000)]
PageThrottler::shouldThrottleTimers is wrong.
https://bugs.webkit.org/show_bug.cgi?id=118210

Reviewed by Anders Carlson.

m_throttleState == PageNotThrottledState
    -> page NOT throttled, so should NOT throttle timers
m_throttleState != PageNotThrottledState
    -> page NOT NOT throttled, so should throttle timers

This needs cleaning up, but for now, 1 character fix.

* page/PageThrottler.h:
(WebCore::PageThrottler::shouldThrottleTimers):
    == -> !=

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove String::deprecatedCharactersWithNullTermination() and related code
andersca@apple.com [Sat, 29 Jun 2013 01:39:28 +0000 (01:39 +0000)]
Remove String::deprecatedCharactersWithNullTermination() and related code
https://bugs.webkit.org/show_bug.cgi?id=118211

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

* API/JSStringRef.cpp:
(JSStringCreateWithCharactersNoCopy):
Update call to StringImpl::createWithoutCopying.

Source/WTF:

Remove String::deprecatedCharactersWithNullTermination, StringImpl::createWithTerminatingNullCharacter
and the s_hashFlagHasTerminatingNullCharacter flag. We no longer care about whether strings have a
terminating null character.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::createFromLiteral):
(WTF::StringImpl::createWithoutCopying):
(WTF::StringImpl::getData16SlowCase):
(WTF::StringImpl::sizeInBytes):
* wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl):
(WTF::StringImpl::createFromLiteral):
(WTF::StringImpl::isolatedCopy):
* wtf/text/WTFString.cpp:
* wtf/text/WTFString.h:

Tools:

Remove all hasTerminatingNullCharacter() checks.

* TestWebKitAPI/Tests/WTF/AtomicString.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/WTFString.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate Apple System fonts in auto-complete
dino@apple.com [Sat, 29 Jun 2013 01:39:20 +0000 (01:39 +0000)]
Update Apple System fonts in auto-complete
https://bugs.webkit.org/show_bug.cgi?id=118205
<rdar://problem/14308488>

Reviewed by Joseph Pecoraro.

Update for the new Apple System font names, and remove some invalid entries.

* UserInterface/CSSKeywordCompletions.js: General cleanup. Note that
"apple-system-short-caption2" looks like it was accidentally omitted. It wasn't :)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: AX: VoiceOver speaks all inspector search fields as 'required'
commit-queue@webkit.org [Sat, 29 Jun 2013 01:25:43 +0000 (01:25 +0000)]
Web Inspector: AX: VoiceOver speaks all inspector search fields as 'required'
https://bugs.webkit.org/show_bug.cgi?id=118122

Patch by James Craig <james@cookiecrook.com> on 2013-06-28
Reviewed by Timothy Hatcher.

Removed bogus "required" state, and switched :valid selector to use :not(:placeholder-shown)
so that screen readers will not indicate a bogus :required/:invalid state to the user.
Minor cosmetic difference blocked by http://webkit.org/b/118162

* UserInterface/FilterBar.css:
(.filter-bar > input[type="search"]:focus):
(.filter-bar > input[type="search"]:not(:placeholder-shown)):
* UserInterface/FilterBar.js:
(WebInspector.FilterBar):
* UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel):
* UserInterface/SearchBar.css:
(.search-bar > input[type="search"]:focus):
(.search-bar > input[type="search"]:not(:placeholder-shown)):
* UserInterface/SearchBar.js:
(WebInspector.SearchBar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAn element with -webkit-user-select: all should be selected on single click
rniwa@webkit.org [Sat, 29 Jun 2013 00:09:09 +0000 (00:09 +0000)]
An element with -webkit-user-select: all should be selected on single click
https://bugs.webkit.org/show_bug.cgi?id=117864

Reviewed by Darin Adler.

Source/WebCore:

Set m_mouseDownMayStartSelect true even when the node cannot start selection
if the node was inside an element with -webkit-user-select: all.

Test: editing/selection/user-select-all-with-single-click.html

* page/EventHandler.cpp:
(WebCore::canMouseDownStartSelect):

LayoutTests:

Add tests for single clicking on an element with user-select: all.
We select the entire element regardless of whether the user had clicked on text or an image
to be consistent even though Firefox requires a double click on the latter case.

* editing/selection/user-select-all-with-image-single-click-expected.txt: Added.
* editing/selection/user-select-all-with-image-single-click.html: Added.
* editing/selection/user-select-all-with-single-click-expected.txt: Added.
* editing/selection/user-select-all-with-single-click.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove unused attachChildrenLazily method and make attach/detachChildren private
rniwa@webkit.org [Sat, 29 Jun 2013 00:01:37 +0000 (00:01 +0000)]
Remove unused attachChildrenLazily method and make attach/detachChildren private
https://bugs.webkit.org/show_bug.cgi?id=118016

Reviewed by Darin Adler.

Merge https://chromium.googlesource.com/chromium/blink/+/009520dc31c9458e0cf71cf212fa5688c4ca68b0

No one should be manually trying to attach or detach all their children so there's
no reason for these methods to be public.

In doing this I realized that attachChildrenLazily is not used and can be removed.

I also realized that we were detaching all our children before the ShadowRoots which
is sad since the InsertionPoints will call detach() on them as well, and then when we
call ContainerNode::detach at the end of Element::detach we'll go detach them again!
This patch makes it so we only go through and detach them twice instead of three times.
In the future we should figure out a way to only do this once.

* dom/ContainerNode.h:
* dom/Element.cpp:
(WebCore::Element::detach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago [Mac] Crash when loading is stopped from -didReceiveResponse
ap@apple.com [Fri, 28 Jun 2013 23:57:16 +0000 (23:57 +0000)]
    [Mac] Crash when loading is stopped from -didReceiveResponse
        https://bugs.webkit.org/show_bug.cgi?id=118209
        <rdar://problem/14259249>

        Reviewed by Brady Eidson.

        Test: TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm.

        * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse):
        Added yet another check for reachedTerminalState().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Newer versions of clang use a default template instantiation depth that is...
aestes@apple.com [Fri, 28 Jun 2013 23:40:09 +0000 (23:40 +0000)]
[Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=118208

Reviewed by Mark Rowe.

Newer versions of clang use a default template depth of 128, but this
is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
previous default.

Clang lowered the default to keep recursive template instantiation
from overflowing the stack (see <rdar://problem/13935016>), but
TestWebKitAPI's C++ files don't trigger a stack overflow even with the
higher limit. If for some reason this starts happening then we can
lower the limit back down.

* TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCached pages don't update their backing scale factor when it changes
bdakin@apple.com [Fri, 28 Jun 2013 23:11:39 +0000 (23:11 +0000)]
Cached pages don't update their backing scale factor when it changes
https://bugs.webkit.org/show_bug.cgi?id=118206
-and-
<rdar://problem/14261627>

Reviewed by Tim Horton.

It is not sufficient to mark pages in the PageCache as needing a full style
recalc. We also need to ensure that the RenderLayerCompositors for the CachesPages
get updated.

Keep track of whether device scale has been updated with
m_needsDeviceScaleChanged. If that has been marked true, then restore() will call
Frame::deviceOrPageScaleFactorChanged().
* history/CachedPage.cpp:
(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
* history/CachedPage.h:
(WebCore::CachedPage::markForDeviceScaleChanged):

Propagate markForDeviceScaleChanged() to all of the CachedPages.
* history/PageCache.cpp:
(WebCore::PageCache::markPagesForDeviceScaleChanged):
* history/PageCache.h:

Call PageCache::markPagesForDeviceScaleChanged()
* page/Page.cpp:
(WebCore::Page::setDeviceScaleFactor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded template parameters to std::min to fix compile errors in Visual Studio x64.
achristensen@apple.com [Fri, 28 Jun 2013 22:48:13 +0000 (22:48 +0000)]
Added template parameters to std::min to fix compile errors in Visual Studio x64.
https://bugs.webkit.org/show_bug.cgi?id=118204

Reviewed by Geoffrey Garen.

* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeURLToDataObject): Added <unsigned> to std::min.
(WebCore::createGlobalImageFileDescriptor): Added <int> to std::min.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded WebGL files to Windows build.
achristensen@apple.com [Fri, 28 Jun 2013 22:43:33 +0000 (22:43 +0000)]
Added WebGL files to Windows build.
https://bugs.webkit.org/show_bug.cgi?id=118200

Reviewed by Brent Fulgham.

* WebCore.vcxproj/WebCore.vcxproj: Added WebGL files, removed unused GraphicsContext3DOpenGLES.cpp.
* WebCore.vcxproj/WebCore.vcxproj.filters: Added WebGL files, removed unused GraphicsContext3DOpenGLES.cpp.
* platform/graphics/cairo/GLContext.cpp: Only include GLContextEGL.h or GLContextGLX.h if they're needed.
* platform/graphics/cg/GraphicsContext3DCG.cpp: Only include GraphicsContext3DNEON.h if it's needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
commit-queue@webkit.org [Fri, 28 Jun 2013 22:21:03 +0000 (22:21 +0000)]
[Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
https://bugs.webkit.org/show_bug.cgi?id=118195

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-06-28
Reviewed by Daniel Bates.

Currently, ports that use jhbuild fail to determine jhbuild directory
when "webKitBranchBuild" git configuration property is enabled. To reproduce
that issue in Efl port, enable that flag in .git/config, switch to a git branch
other than "master" and try to build webkit. The build will fail to
locate dependencies due to lack of pkg-config paths which should be set
by jhbuild.

For more details about "webKitBranchBuild" option, see:
https://trac.webkit.org/wiki/UsingGitWithWebKit

* Scripts/webkitdirs.pm:
(getJhbuildPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[wk2] WKView shouldn't force scrolling off if shouldClipToVisibleRect is set
timothy_horton@apple.com [Fri, 28 Jun 2013 22:15:53 +0000 (22:15 +0000)]
[wk2] WKView shouldn't force scrolling off if shouldClipToVisibleRect is set
https://bugs.webkit.org/show_bug.cgi?id=118174
<rdar://problem/14301175>

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView _updateViewExposedRect]):
Pass whether or not clips-to-visibleRect is enabled down to the WebPageProxy.

(-[WKView setMinimumSizeForAutoLayout:]):
Disable scrolling when using autolayout instead of when using clips-to-visibleRect.

(-[WKView setShouldClipToVisibleRect:]):
Clipping to the WKView's visibleRect does not strictly require scrolling to be disabled,
and in fact there are cases (RTL/TB pagination) where we *must* scroll, even when the view
is big enough to fit the content (the case clip-to-visibleRect was added for).

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::viewExposedRectChanged):
(WebKit::WebPageProxy::exposedRectChangedTimerFired):
Keep track of and forward to the drawing area whether or not clips-to-visibleRect is enabled.

* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setClipsToExposedRect): Added.
(WebKit::DrawingArea::didChangeScrollOffsetForAnyFrame): Added a missing space.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewExposedRectChanged):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
Forward clips-to-visibleRect enabled state to the drawing area.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
Add storage for m_clipsToExposedRect.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setClipsToExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::updateMainFrameClipsToExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
Check m_clipsToExposedRect instead of the main-frame's isScrollable() to determine
whether we should tell our TiledBackings to clip to the exposed rect we provide.

We don't need to listen to mainFrameScrollabilityChanged anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebKitTestRunner should disable automatic quote and dash substitution like DumpRender...
jberlin@webkit.org [Fri, 28 Jun 2013 21:45:26 +0000 (21:45 +0000)]
WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
https://bugs.webkit.org/show_bug.cgi?id=118201

Reviewed by Dean Jackson.

* WebKitTestRunner/mac/main.mm:
(main):
Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
setAutomaticDashSubstitutionEnabled are not exposed on WKView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStale occlusion state after moving page back into window
barraclough@apple.com [Fri, 28 Jun 2013 20:40:43 +0000 (20:40 +0000)]
Stale occlusion state after moving page back into window
https://bugs.webkit.org/show_bug.cgi?id=118202

Reviewed by Anders Carlsson.

We need to update the occlusion state when the page goes back into the window.

* UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
    - update occlusion state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpstream WebKit Nightly’s WebKitLauncher
dfarler@apple.com [Fri, 28 Jun 2013 20:38:55 +0000 (20:38 +0000)]
Upstream WebKit Nightly’s WebKitLauncher
https://bugs.webkit.org/show_bug.cgi?id=117418

Reviewed by Mark Rowe.

Literal patch from Nightly's OpenSource repo.

* WebKitLauncher/Configurations/Base.xcconfig:
* WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
* WebKitLauncher/Info.plist:
* WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
* WebKitLauncher/WebKitLauncherURLProtocol.m:
(+[WebKitLauncherURLProtocol load]):
(+[WebKitLauncherURLProtocol canInitWithRequest:]):
(-[WebKitLauncherURLProtocol startLoading]):
(-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
(-[WebKitLauncherURLProtocol resourceNotFound]):
* WebKitLauncher/WebKitNightlyEnablerSparkle.m:
(initializeSparkle):
* WebKitLauncher/main.m:
(determineExecutablePath):
(currentMacOSXVersion):
(main):
* WebKitLauncher/start.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago-webkit-line-break: after-white-space sometimes truncates DOM on copy & paste
rniwa@webkit.org [Fri, 28 Jun 2013 19:59:04 +0000 (19:59 +0000)]
-webkit-line-break: after-white-space sometimes truncates DOM on copy & paste
https://bugs.webkit.org/show_bug.cgi?id=118164

Reviewed by Sam Weinig.

Source/WebCore:

We can't assume that all subsequent ancestors contain exactly one child since they could have been
added in the first if statement matching: currentNode->parentNode() != rootNode && isRemovableBlock(currentNode)

Exit early when we encounter such an ancestor since removing its ancestor (that contains multiple children
some of which aren't in nodesToRemove) can clobber more nodes than we're allowed to remove.

Test: editing/pasteboard/simplfiying-markup-should-not-strip-content.html

* editing/SimplifyMarkupCommand.cpp:
(WebCore::SimplifyMarkupCommand::doApply):
(WebCore::SimplifyMarkupCommand::pruneSubsequentAncestorsToRemove):

LayoutTests:

Add a regression test.

* editing/pasteboard/simplfiying-markup-should-not-strip-content-expected.txt: Added.
* editing/pasteboard/simplfiying-markup-should-not-strip-content.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agomedia/video-currentTime.html flakey
jer.noble@apple.com [Fri, 28 Jun 2013 19:55:18 +0000 (19:55 +0000)]
media/video-currentTime.html flakey
https://bugs.webkit.org/show_bug.cgi?id=118198

Reviewed by Jessie Berlin.

Update video-currentTime.html so that it listens for timeupdate events, and ends the test
after the first one with a >0 currentTime. Add a 3s watchdog for the failure case.

* media/video-currentTime-expected.txt:
* media/video-currentTime.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCoordinated Graphics: Separate CoordinatedLayerTreeHost into CoordinatedLayerTreeHost...
commit-queue@webkit.org [Fri, 28 Jun 2013 19:09:52 +0000 (19:09 +0000)]
Coordinated Graphics: Separate CoordinatedLayerTreeHost into CoordinatedLayerTreeHost and CompositingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=104360

Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-06-28
Reviewed by Noam Rosenthal.

The CoordinatedLayerTreeHost has too many responsibilities. It
implements LayerTreeHost, GraphicsLayerClient,
CoordinatedGraphicsLayerClient, CoordinatedImageBacking::Client,
UpdateAtlas::Client, GraphicsLayerFactory and
WebCustomFilterProgramProxyClient.

This refactoring reduces the responsibilities of CoordinatedLayerTreeHost.

This patch introduces a new class called CompositingCoordinator, which
takes the responsibility of managing compositing resources in
WebProcess.

CoordinatedLayerTreeHost is responsible only for the scheduling and
IPC-specific stuff, which are relevant only for WebKit2.

No new tests, covered by existing tests.

Source/WebCore:

* CMakeLists.txt:
* Target.pri:
* platform/graphics/texmap/coordinated/CompositingCoordinator.cpp: Added.
(WebCore::CompositingCoordinator::create):
(WebCore::CompositingCoordinator::~CompositingCoordinator):
(WebCore::CompositingCoordinator::CompositingCoordinator):
(WebCore::CompositingCoordinator::setRootCompositingLayer):
(WebCore::CompositingCoordinator::sizeDidChange):
(WebCore::CompositingCoordinator::flushPendingLayerChanges):
(WebCore::CompositingCoordinator::syncDisplayState):
(WebCore::CompositingCoordinator::nextAnimationServiceTime):
(WebCore::CompositingCoordinator::clearPendingStateChanges):
(WebCore::CompositingCoordinator::initializeRootCompositingLayerIfNeeded):
(WebCore::CompositingCoordinator::createRootLayer):
(WebCore::CompositingCoordinator::syncLayerState):
(WebCore::CompositingCoordinator::createImageBackingIfNeeded):
(WebCore::CompositingCoordinator::createImageBacking):
(WebCore::CompositingCoordinator::updateImageBacking):
(WebCore::CompositingCoordinator::clearImageBackingContents):
(WebCore::CompositingCoordinator::removeImageBacking):
(WebCore::CompositingCoordinator::flushPendingImageBackingChanges):
(WebCore::CompositingCoordinator::notifyAnimationStarted):
(WebCore::CompositingCoordinator::notifyFlushRequired):
(WebCore::CompositingCoordinator::paintContents):
(WebCore::CompositingCoordinator::createGraphicsLayer):
(WebCore::CompositingCoordinator::deviceScaleFactor):
(WebCore::CompositingCoordinator::pageScaleFactor):
(WebCore::CompositingCoordinator::createUpdateAtlas):
(WebCore::CompositingCoordinator::removeUpdateAtlas):
(WebCore::CompositingCoordinator::visibleContentsRect):
(WebCore::CompositingCoordinator::mainContentsLayer):
(WebCore::CompositingCoordinator::setVisibleContentsRect):
(WebCore::CompositingCoordinator::deviceOrPageScaleFactorChanged):
(WebCore::CompositingCoordinator::detachLayer):
(WebCore::CompositingCoordinator::commitScrollOffset):
(WebCore::CompositingCoordinator::renderNextFrame):
(WebCore::CompositingCoordinator::purgeBackingStores):
(WebCore::CompositingCoordinator::paintToSurface):
(WebCore::CompositingCoordinator::scheduleReleaseInactiveAtlases):
(WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):
* platform/graphics/texmap/coordinated/CompositingCoordinator.h: Added.
(WebCore::CompositingCoordinator::clearRootLayer):
(WebCore::CompositingCoordinator::rootLayer):
(WebCore::CompositingCoordinator::state):

Source/WebKit2:

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::~CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::setRootCompositingLayer):
(WebKit::CoordinatedLayerTreeHost::invalidate):
(WebKit::CoordinatedLayerTreeHost::forceRepaint):
(WebKit::CoordinatedLayerTreeHost::sizeDidChange):
(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHost::renderNextFrame):
(WebKit::CoordinatedLayerTreeHost::purgeBackingStores):
(WebKit::CoordinatedLayerTreeHost::willSyncLayerState):
(WebKit::CoordinatedLayerTreeHost::prepareCustomFilterProxiesForAnimations):
(WebKit::CoordinatedLayerTreeHost::checkCustomFilterProgramProxies):
(WebKit::CoordinatedLayerTreeHost::removeCustomFilterProgramProxy):
(WebKit::CoordinatedLayerTreeHost::didFlushRootLayer):
(WebKit::CoordinatedLayerTreeHost::performScheduledLayerFlush):
(WebKit::CoordinatedLayerTreeHost::createPageOverlayLayer):
(WebKit::CoordinatedLayerTreeHost::paintLayerContents):
(WebKit::CoordinatedLayerTreeHost::commitSceneState):
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
(WebKit::CoordinatedLayerTreeHost::graphicsLayerFactory):
(WebKit::CoordinatedLayerTreeHost::scheduleAnimation):
(WebKit::CoordinatedLayerTreeHost::commitScrollOffset):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
* WebProcess/WebPage/LayerTreeHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake the UI process run the Java Updater
andersca@apple.com [Fri, 28 Jun 2013 18:57:39 +0000 (18:57 +0000)]
Make the UI process run the Java Updater
https://bugs.webkit.org/show_bug.cgi?id=118197
<rdar://problem/14255677>

Reviewed by Sam Weinig.

Patch the relevant NSWorkspace method and pipe through the request to launch the Java updater to the UI process.

* PluginProcess/PluginProcess.h:
* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::replacedNSWorkspace_launchApplicationAtURL_options_configuration_error):
(WebKit::initializeCocoaOverrides):
(WebKit::PluginProcess::launchApplicationAtURL):
* UIProcess/Plugins/PluginProcessProxy.h:
* UIProcess/Plugins/PluginProcessProxy.messages.in:
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::isJavaUpdaterURL):
(WebKit::shouldLaunchApplicationAtURL):
(WebKit::PluginProcessProxy::launchApplicationAtURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r152135.
commit-queue@webkit.org [Fri, 28 Jun 2013 18:47:55 +0000 (18:47 +0000)]
Unreviewed, rolling out r152135.
http://trac.webkit.org/changeset/152135
https://bugs.webkit.org/show_bug.cgi?id=118199

Rolling out temporary patch used for debugging the test bots
(Requested by rfong on #webkit).

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::load):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate TestExpectations so new Shapes tests are skipped where the old ones were
commit-queue@webkit.org [Fri, 28 Jun 2013 18:08:13 +0000 (18:08 +0000)]
Update TestExpectations so new Shapes tests are skipped where the old ones were
https://bugs.webkit.org/show_bug.cgi?id=118192

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-06-28
Reviewed by Brent Fulgham.

Shapes still aren't enabled on some ports, so skip the tests there.
As part of this patch, it was discovered that they work on EFL, so the
skipping has been removed from there.

* platform/efl/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] back/forward keyboard shortcuts are non-intuitive
commit-queue@webkit.org [Fri, 28 Jun 2013 18:07:44 +0000 (18:07 +0000)]
[EFL] back/forward keyboard shortcuts are non-intuitive
https://bugs.webkit.org/show_bug.cgi?id=118193

Patch by Balazs Kelemen <b.kelemen@samsung.com> on 2013-06-28
Reviewed by Christophe Dumez.

Changed shortcuts for go-back/go-forward to alt+left and alt+right.

* EWebLauncher/main.c:
(on_key_down):
* MiniBrowser/efl/main.c:
(on_key_down):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSVG relayout problem when displayed with different image box heights
commit-queue@webkit.org [Fri, 28 Jun 2013 18:00:53 +0000 (18:00 +0000)]
SVG relayout problem when displayed with different image box heights
https://bugs.webkit.org/show_bug.cgi?id=118140

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-06-28
Reviewed by Philip Rogers.

Source/WebCore:

If the root element is an SVG, its position and height are affected
by the view height.

Test: svg/as-image/same-source-different-height.html

* rendering/RenderView.cpp:
(WebCore::RenderView::layout):

LayoutTests:

* svg/as-image/same-source-different-height-expected.html: Added.
* svg/as-image/same-source-different-height.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWARN_UNUSED_RESULT can't be used in API headers, but WKBundlePageExtendIncrementalRen...
timothy_horton@apple.com [Fri, 28 Jun 2013 17:54:50 +0000 (17:54 +0000)]
WARN_UNUSED_RESULT can't be used in API headers, but WKBundlePageExtendIncrementalRenderingSuppression tries to
https://bugs.webkit.org/show_bug.cgi?id=118196
<rdar://problem/14303613>

Reviewed by Anders Carlsson.

* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEnable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
roger_fong@apple.com [Fri, 28 Jun 2013 17:54:00 +0000 (17:54 +0000)]
Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
https://bugs.webkit.org/show_bug.cgi?id=118194.

Reviewed by Brent Fulgham.

* DumpRenderTree/win/DumpRenderTree.cpp:
(dllLauncherEntryPoint):
* WinLauncher/WinLauncher.cpp:
(dllLauncherEntryPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAllow some LayoutPoint and LayoutSize conversions to be inlined
simon.fraser@apple.com [Fri, 28 Jun 2013 17:31:30 +0000 (17:31 +0000)]
Allow some LayoutPoint and LayoutSize conversions to be inlined
https://bugs.webkit.org/show_bug.cgi?id=118167

Reviewed by Ryosuke Niwa.

Construction of FloatSize from LayoutSize, and FloatPoint's move(const LayoutSize&)
and moveBy(const LayoutPoint&) were not inlined, and showed up on some profiles.

Make them inlined by removing the overloaded functions, and instead providing
conversion operators from LayoutSize to FloatSize, and LayoutPoint to FloatPoint.
Do the same to allow a LayoutRect to be converted to a FloatRect.

This is nice because it removes pollution of FloatRect, FloatPoint and FloatSize with
Layout* entirely.

Remove Qt-specific conversions on LayoutRect, LayoutPoint and LayoutSize. Qt can
convert via IntRect/FloatRect as necessary.

* platform/graphics/FloatPoint.cpp:
* platform/graphics/FloatPoint.h:
(WebCore::FloatPoint::move):
(WebCore::FloatPoint::moveBy):
* platform/graphics/FloatRect.cpp:
* platform/graphics/FloatRect.h:
* platform/graphics/FloatSize.cpp:
* platform/graphics/FloatSize.h:
* platform/graphics/LayoutPoint.h:
(WebCore::LayoutPoint::operator FloatPoint):
* platform/graphics/LayoutRect.cpp:
* platform/graphics/LayoutRect.h:
(WebCore::LayoutRect::operator FloatRect):
* platform/graphics/LayoutSize.h:
(WebCore::LayoutSize::operator FloatSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix for AppleWin port. Fix some file paths.
roger_fong@apple.com [Fri, 28 Jun 2013 17:13:41 +0000 (17:13 +0000)]
Unreviewed build fix for AppleWin port. Fix some file paths.

* WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
* WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoaccessibility/media-element.html does not support platforms without subroles
mario@webkit.org [Fri, 28 Jun 2013 16:39:33 +0000 (16:39 +0000)]
accessibility/media-element.html does not support platforms without subroles
https://bugs.webkit.org/show_bug.cgi?id=118187

Reviewed by Chris Fleizach.

Update the test to be more friendly with platforms not supporting subroles.

* accessibility/media-element.html: Updated test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd IAccessibilityDelegate implementation to WinLauncher for testing purposes.
roger_fong@apple.com [Fri, 28 Jun 2013 16:23:18 +0000 (16:23 +0000)]
Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
https://bugs.webkit.org/show_bug.cgi?id=118160.

Reviewed by Brent Fulgham.

* WinLauncher/AccessibilityDelegate.cpp: Added.
(AccessibilityDelegate::QueryInterface):
(AccessibilityDelegate::AddRef):
(AccessibilityDelegate::Release):
(AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
(AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
* WinLauncher/AccessibilityDelegate.h: Added.
(AccessibilityDelegate::AccessibilityDelegate):
* WinLauncher/WinLauncher.cpp:
(dllLauncherEntryPoint):
* WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
* WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClean up temporary files created by the bindings test script
ch.dumez@sisa.samsung.com [Fri, 28 Jun 2013 16:08:24 +0000 (16:08 +0000)]
Clean up temporary files created by the bindings test script
https://bugs.webkit.org/show_bug.cgi?id=118189

Reviewed by Kentaro Hara.

Remove temporary files created by preprocess-idls.pl script after
the bindings tests are executed.

Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.

* Scripts/webkitpy/bindings/main.py:
(BindingsTests.main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WinCairo] Compilation error.
commit-queue@webkit.org [Fri, 28 Jun 2013 16:07:37 +0000 (16:07 +0000)]
[WinCairo] Compilation error.
https://bugs.webkit.org/show_bug.cgi?id=118131

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-06-28
Reviewed by Brent Fulgham.

* Interfaces/IWebView.idl: Include needed accessibility interface.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::AXFinishFrameLoad): Accessibility methods should not be inside FULLSCREEN_API ifdef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of IsWorkerGlobalScope and ExtendsDOMGlobalObject extended attributes
ch.dumez@sisa.samsung.com [Fri, 28 Jun 2013 16:01:32 +0000 (16:01 +0000)]
Get rid of IsWorkerGlobalScope and ExtendsDOMGlobalObject extended attributes
https://bugs.webkit.org/show_bug.cgi?id=118191

Reviewed by Kentaro Hara.

Remove WebKit-specific [IsWorkerGlobalScope] and [ExtendsDOMGlobalObject] IDL
extended attributes and update the JSC bindings generator to figure this out
on its own.

No new tests, no behavior change.

* bindings/scripts/CodeGeneratorJS.pm:
(IsDOMGlobalObject):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorHelperMethods):
* bindings/scripts/IDLAttributes.txt:
* page/DOMWindow.idl:
* workers/DedicatedWorkerGlobalScope.idl:
* workers/SharedWorkerGlobalScope.idl:
* workers/WorkerGlobalScope.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIntroduce SVGGraphicsElement IDL interface
ch.dumez@sisa.samsung.com [Fri, 28 Jun 2013 15:58:03 +0000 (15:58 +0000)]
Introduce SVGGraphicsElement IDL interface
https://bugs.webkit.org/show_bug.cgi?id=118178

Reviewed by Kentaro Hara.

Source/WebCore:

Introduce SVGGraphicsElement IDL interface as per the latest SVG
specification:
- https://svgwg.org/svg2-draft/types.html#InterfaceSVGGraphicsElement

SVGGraphicsElement is a merge of SVGLocatable and SVGTransformable.
This is one step towards simplifying inheritance in SVG and matching
the latest SVG2 specification.

No new tests, already covered by existing tests.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.order:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/CodeGeneratorJS.pm:
(GetGnuVTableOffsetForType):
* rendering/svg/RenderSVGEllipse.cpp:
(WebCore::RenderSVGEllipse::RenderSVGEllipse):
* rendering/svg/RenderSVGEllipse.h:
* rendering/svg/RenderSVGPath.cpp:
(WebCore::RenderSVGPath::RenderSVGPath):
* rendering/svg/RenderSVGPath.h:
* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::pathOnlyClipping):
* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
* rendering/svg/RenderSVGResourceMarker.cpp:
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::RenderSVGShape):
(WebCore::RenderSVGShape::updateShapeFromElement):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::nonScalingStrokeTransform):
(WebCore::RenderSVGShape::shouldGenerateMarkerPositions):
* rendering/svg/RenderSVGShape.h:
* rendering/svg/RenderSVGTransformableContainer.cpp:
(WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer):
(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
* rendering/svg/RenderSVGTransformableContainer.h:
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::SVGAElement):
(WebCore::SVGAElement::parseAttribute):
(WebCore::SVGAElement::svgAttributeChanged):
(WebCore::SVGAElement::defaultEventHandler):
(WebCore::SVGAElement::supportsFocus):
(WebCore::SVGAElement::isURLAttribute):
* svg/SVGAElement.h:
* svg/SVGAElement.idl:
* svg/SVGAllInOne.cpp:
* svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType):
* svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::SVGCircleElement):
(WebCore::SVGCircleElement::parseAttribute):
(WebCore::SVGCircleElement::svgAttributeChanged):
* svg/SVGCircleElement.h:
* svg/SVGCircleElement.idl:
* svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::SVGClipPathElement):
(WebCore::SVGClipPathElement::parseAttribute):
(WebCore::SVGClipPathElement::svgAttributeChanged):
(WebCore::SVGClipPathElement::childrenChanged):
* svg/SVGClipPathElement.h:
* svg/SVGClipPathElement.idl:
* svg/SVGDefsElement.cpp:
(WebCore::SVGDefsElement::SVGDefsElement):
* svg/SVGDefsElement.h:
* svg/SVGDefsElement.idl:
* svg/SVGElement.h:
(WebCore::SVGElement::isSVGGraphicsElement):
* svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::SVGEllipseElement):
(WebCore::SVGEllipseElement::parseAttribute):
(WebCore::SVGEllipseElement::svgAttributeChanged):
* svg/SVGEllipseElement.h:
* svg/SVGEllipseElement.idl:
* svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
(WebCore::SVGForeignObjectElement::parseAttribute):
(WebCore::SVGForeignObjectElement::svgAttributeChanged):
(WebCore::SVGForeignObjectElement::rendererIsNeeded):
* svg/SVGForeignObjectElement.h:
* svg/SVGForeignObjectElement.idl:
* svg/SVGGElement.cpp:
(WebCore::SVGGElement::SVGGElement):
(WebCore::SVGGElement::parseAttribute):
(WebCore::SVGGElement::svgAttributeChanged):
* svg/SVGGElement.h:
* svg/SVGGElement.idl:
* svg/SVGGraphicsElement.cpp: Renamed from Source/WebCore/svg/SVGStyledTransformableElement.cpp.
(WebCore::SVGGraphicsElement::SVGGraphicsElement):
(WebCore::SVGGraphicsElement::~SVGGraphicsElement):
(WebCore::SVGGraphicsElement::getCTM):
(WebCore::SVGGraphicsElement::getScreenCTM):
(WebCore::SVGGraphicsElement::animatedLocalTransform):
(WebCore::SVGGraphicsElement::supplementalTransform):
(WebCore::SVGGraphicsElement::isSupportedAttribute):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):
(WebCore::SVGGraphicsElement::nearestViewportElement):
(WebCore::SVGGraphicsElement::farthestViewportElement):
(WebCore::SVGGraphicsElement::getBBox):
(WebCore::SVGGraphicsElement::createRenderer):
(WebCore::SVGGraphicsElement::toClipPath):
* svg/SVGGraphicsElement.h: Renamed from Source/WebCore/svg/SVGStyledTransformableElement.h.
(WebCore::SVGGraphicsElement::localCoordinateSpaceTransform):
(WebCore::SVGGraphicsElement::synchronizeRequiredFeatures):
(WebCore::SVGGraphicsElement::synchronizeRequiredExtensions):
(WebCore::SVGGraphicsElement::synchronizeSystemLanguage):
(WebCore::toSVGGraphicsElement):
* svg/SVGGraphicsElement.idl: Copied from Source/WebCore/svg/SVGForeignObjectElement.idl.
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::SVGImageElement):
(WebCore::SVGImageElement::isPresentationAttribute):
(WebCore::SVGImageElement::collectStyleForPresentationAttribute):
(WebCore::SVGImageElement::parseAttribute):
(WebCore::SVGImageElement::svgAttributeChanged):
(WebCore::SVGImageElement::attach):
(WebCore::SVGImageElement::insertedInto):
(WebCore::SVGImageElement::addSubresourceAttributeURLs):
(WebCore::SVGImageElement::didMoveToNewDocument):
* svg/SVGImageElement.h:
* svg/SVGImageElement.idl:
* svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::SVGLineElement):
(WebCore::SVGLineElement::parseAttribute):
(WebCore::SVGLineElement::svgAttributeChanged):
* svg/SVGLineElement.h:
* svg/SVGLineElement.idl:
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::SVGPathElement):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::insertedInto):
(WebCore::SVGPathElement::removedFrom):
* svg/SVGPathElement.h:
* svg/SVGPathElement.idl:
* svg/SVGPatternElement.cpp:
* svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::SVGPolyElement):
(WebCore::SVGPolyElement::parseAttribute):
(WebCore::SVGPolyElement::svgAttributeChanged):
* svg/SVGPolyElement.h:
* svg/SVGPolygonElement.idl:
* svg/SVGPolylineElement.idl:
* svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::SVGRectElement):
(WebCore::SVGRectElement::parseAttribute):
(WebCore::SVGRectElement::svgAttributeChanged):
* svg/SVGRectElement.h:
* svg/SVGRectElement.idl:
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::didMoveToNewDocument):
(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):
* svg/SVGSVGElement.h:
* svg/SVGSVGElement.idl:
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::localCoordinateSpaceTransform):
* svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::SVGSwitchElement):
* svg/SVGSwitchElement.h:
* svg/SVGSwitchElement.idl:
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::parseAttribute):
(WebCore::SVGUseElement::insertedInto):
(WebCore::SVGUseElement::removedFrom):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::toClipPath):
(WebCore::SVGUseElement::finishParsingChildren):
* svg/SVGUseElement.h:
* svg/SVGUseElement.idl:

LayoutTests:

Rebaseline js/global-constructors-attributes.html test case now that
SVGGraphicsElement is exposed on the global Window object.

* fast/js/global-constructors-attributes-expected.txt:
* platform/efl/fast/js/global-constructors-attributes-expected.txt:
* platform/gtk/fast/js/global-constructors-attributes-expected.txt:
* platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
* platform/qt/fast/js/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDon't fire process-became-responsive callback when disconnecting it.
akling@apple.com [Fri, 28 Jun 2013 15:00:52 +0000 (15:00 +0000)]
Don't fire process-became-responsive callback when disconnecting it.
<http://webkit.org/b/118166>

Reviewed by Anders Carlsson.

When disconnecting from a web process, call ResponsivenessTimer::invalidate() instead of
stop() to avoid firing the didBecomeResponsive() callback.

This lets the UI process react faster to actually unresponsive processes.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disconnect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2][GTK] 100% CPU usage rendering a page with animations
sergio@webkit.org [Fri, 28 Jun 2013 14:49:24 +0000 (14:49 +0000)]
[WK2][GTK] 100% CPU usage rendering a page with animations
https://bugs.webkit.org/show_bug.cgi?id=117703

Reviewed by Martin Robinson.

Unconditionally update the value of m_lastFlushTime in
::flushAndRenderLayers. By doing that we avoid a neverending
sequence of layer flushes that happened when m_lastFlushTime==0
and flushPendingLayerChanges() was false. In that situation the
value m_lastFlushTime was never updated so a new flush was always
rescheduled.

* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::flushAndRenderLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Skipping failing tests, and mathml tests because not yet...
zarvai@inf.u-szeged.hu [Fri, 28 Jun 2013 14:29:58 +0000 (14:29 +0000)]
[Qt] Unreviewed gardening. Skipping failing tests, and mathml tests because not yet supported.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-28

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Autotools] Properly quote harfbuzz-icu pkg-config check
commit-queue@webkit.org [Fri, 28 Jun 2013 13:31:47 +0000 (13:31 +0000)]
[Autotools] Properly quote harfbuzz-icu pkg-config check
https://bugs.webkit.org/show_bug.cgi?id=118186

Patch by Sean Bright <sean@malleable.com> on 2013-06-28
Reviewed by Carlos Garcia Campos.

A secondary test was added in r150963 to check for harfbuzz-icu
when it was split into two packages, but the test is not properly
quoted.  If the test fails you get an error about missing
version "./configure.9.8" instead of the expected "0.9.8."

* Source/autotools/FindDependencies.m4:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd new schemes to content utils.
gyuyoung.kim@samsung.com [Fri, 28 Jun 2013 12:28:00 +0000 (12:28 +0000)]
Add new schemes to content utils.
https://bugs.webkit.org/show_bug.cgi?id=118181

Reviewed by Christophe Dumez.

Source/WebCore:

According to latest content handler spec, new schemes are added to it.
Those are "geo, magnet, sip, ssh and xmpp".

http://www.w3.org/html/wg/drafts/html/master/webappapis.html#custom-handlers

Tests: fast/dom/register-protocol-handler.html
       fast/dom/unregister-protocol-handler.html

* Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::initProtocolHandlerWhitelist):

LayoutTests:

Add new schemes as well as change SYNTAX_ERR, SECURITY_ERR.

* fast/dom/register-protocol-handler-expected.txt:
* fast/dom/register-protocol-handler.html:
* fast/dom/unregister-protocol-handler-expected.txt:
* fast/dom/unregister-protocol-handler.html:
* platform/efl/fast/dom/register-protocol-handler-expected.txt:
* platform/efl/fast/dom/unregister-protocol-handler-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid duplicating hostWindow() call in ScrollView.cpp
commit-queue@webkit.org [Fri, 28 Jun 2013 11:14:18 +0000 (11:14 +0000)]
Avoid duplicating hostWindow() call in ScrollView.cpp
https://bugs.webkit.org/show_bug.cgi?id=118168

Patch by Sanghyup Lee <sh53.lee@samsung.com> on 2013-06-28
Reviewed by Christophe Dumez.

Remove redundant hostWindow() calls in ScrollView.cpp.

* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::contentsToScreen):
(WebCore::ScrollView::screenToContents):
(WebCore::ScrollView::repaintContentRectangle):
(WebCore::ScrollView::updateOverhangAreas):
(WebCore::ScrollView::addPanScrollIcon):
(WebCore::ScrollView::removePanScrollIcon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Unreviewed gardening. Unskip and reorganize tests no longer failing in GTK...
zandobersek@gmail.com [Fri, 28 Jun 2013 11:00:33 +0000 (11:00 +0000)]
[GTK] Unreviewed gardening. Unskip and reorganize tests no longer failing in GTK-WK and GTK-WK2
https://bugs.webkit.org/show_bug.cgi?id=118180

Unreviewed GTK gardening.

Patch by Simon Pena <simon.pena@samsung.com> on 2013-06-28

* platform/gtk-wk2/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse gtk_widget_get_preferred_size instead of deprecated gtk_widget_get_requisition
commit-queue@webkit.org [Fri, 28 Jun 2013 10:59:39 +0000 (10:59 +0000)]
Use gtk_widget_get_preferred_size instead of deprecated gtk_widget_get_requisition
https://bugs.webkit.org/show_bug.cgi?id=118177

Patch by Iago Toral Quiroga <itoral@igalia.com> on 2013-06-28
Reviewed by Carlos Garcia Campos.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::contentsSizeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, EFL rebaseline.
gyuyoung.kim@samsung.com [Fri, 28 Jun 2013 10:18:26 +0000 (10:18 +0000)]
Unreviewed, EFL rebaseline.

SECURITY_ERR and SYNTAX_ERR have been changed with SecurityError and SyntaxError since r135162.

* platform/efl/fast/dom/register-protocol-handler-expected.txt:
* platform/efl/fast/dom/unregister-protocol-handler-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, fix GTK build after r152156.
ch.dumez@sisa.samsung.com [Fri, 28 Jun 2013 09:33:40 +0000 (09:33 +0000)]
Unreviewed, fix GTK build after r152156.

* GNUmakefile.list.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMerge SVGLangSpace into SVGElement
ch.dumez@sisa.samsung.com [Fri, 28 Jun 2013 08:34:42 +0000 (08:34 +0000)]
Merge SVGLangSpace into SVGElement
https://bugs.webkit.org/show_bug.cgi?id=118170

Reviewed by Kentaro Hara.

Remove SVGLangSpace IDL interface and move its attributes to SVGElement
to match the latest specification and simplify inheritance in SVG:
- https://svgwg.org/svg2-draft/types.html#InterfaceSVGElement

No new tests, no behavior change.

* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* svg/SVGAElement.h:
* svg/SVGAElement.idl:
* svg/SVGCircleElement.h:
* svg/SVGCircleElement.idl:
* svg/SVGClipPathElement.h:
* svg/SVGClipPathElement.idl:
* svg/SVGDefsElement.h:
* svg/SVGDefsElement.idl:
* svg/SVGDescElement.h:
* svg/SVGDescElement.idl:
* svg/SVGElement.cpp:
(WebCore::SVGElement::parseAttribute):
* svg/SVGElement.h:
* svg/SVGElement.idl:
* svg/SVGEllipseElement.h:
* svg/SVGEllipseElement.idl:
* svg/SVGFEImageElement.h:
* svg/SVGFEImageElement.idl:
* svg/SVGFilterElement.h:
* svg/SVGFilterElement.idl:
* svg/SVGForeignObjectElement.h:
* svg/SVGForeignObjectElement.idl:
* svg/SVGGElement.h:
* svg/SVGGElement.idl:
* svg/SVGImageElement.h:
* svg/SVGImageElement.idl:
* svg/SVGLangSpace.idl: Removed.
* svg/SVGLineElement.h:
* svg/SVGLineElement.idl:
* svg/SVGMarkerElement.h:
* svg/SVGMarkerElement.idl:
* svg/SVGMaskElement.h:
* svg/SVGMaskElement.idl:
* svg/SVGPathElement.h:
* svg/SVGPathElement.idl:
* svg/SVGPatternElement.h:
* svg/SVGPatternElement.idl:
* svg/SVGPolyElement.h:
* svg/SVGPolygonElement.idl:
* svg/SVGPolylineElement.idl:
* svg/SVGRectElement.h:
* svg/SVGRectElement.idl:
* svg/SVGSVGElement.h:
* svg/SVGSVGElement.idl:
* svg/SVGStyleElement.h:
* svg/SVGStyleElement.idl:
* svg/SVGSwitchElement.h:
* svg/SVGSwitchElement.idl:
* svg/SVGSymbolElement.h:
* svg/SVGSymbolElement.idl:
* svg/SVGTextContentElement.h:
* svg/SVGTextContentElement.idl:
* svg/SVGTitleElement.h:
* svg/SVGTitleElement.idl:
* svg/SVGUseElement.h:
* svg/SVGUseElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] MiniBrowser doesn't solve the saving location when there are no XDG settings
commit-queue@webkit.org [Fri, 28 Jun 2013 08:28:54 +0000 (08:28 +0000)]
[GTK] MiniBrowser doesn't solve the saving location when there are no XDG settings
https://bugs.webkit.org/show_bug.cgi?id=117538

Patch by Andres Gomez <agomez@igalia.com> on 2013-06-28
Reviewed by Carlos Garcia Campos.

If the XDG specification is not working for the "Downloads"
directory, let's use HOME as fallback.

* UIProcess/API/gtk/WebKitDownload.cpp:
(webkitDownloadDecideDestination):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse & instead of | in the value of [CallWith]
ch.dumez@sisa.samsung.com [Fri, 28 Jun 2013 08:20:19 +0000 (08:20 +0000)]
Use & instead of | in the value of [CallWith]
https://bugs.webkit.org/show_bug.cgi?id=118054

Reviewed by Kentaro Hara.

[CallWith=ScriptExecutionContext|ScriptState] meant that both the
ScriptExecutionContext AND the ScriptState would be passed as
arguments to the implementation (not one OR the other).

This patch changes the semantics for those IDL extended attributes
to make it less confusing. Proper usage is now:
[CallWith=ScriptExecutionContext&ScriptState]

No new tests, covered by existing bindings tests.

* bindings/scripts/CodeGenerator.pm:
(ExtendedAttributeContains):
* bindings/scripts/test/TestObj.idl:
* page/Console.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Add spellcheck API tests in unit tests.
commit-queue@webkit.org [Fri, 28 Jun 2013 07:34:43 +0000 (07:34 +0000)]
[EFL][WK2] Add spellcheck API tests in unit tests.
https://bugs.webkit.org/show_bug.cgi?id=118123

Patch by Dariusz Frankiewicz <d.frankiewic@samsung.com> on 2013-06-28
Reviewed by Christophe Dumez.

According to discussion in bug https://bugs.webkit.org/show_bug.cgi?id=113742
we're moving spelling tests from layout tests to unit tests.

* UIProcess/API/efl/tests/resources/spelling_selection_tests.html: Added.
New file is needed to make tests, with and without spellcheck attribute.
File contains basic site with content editable fields and buttons which select
different parts of misspelled words.

* UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(countContextMenuItems):
Added method used to count number of items in context menu.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHTMLAudioElement doesn't have to know about isVideo function
kangil.han@samsung.com [Fri, 28 Jun 2013 02:28:21 +0000 (02:28 +0000)]
HTMLAudioElement doesn't have to know about isVideo function
https://bugs.webkit.org/show_bug.cgi?id=118116

Reviewed by Eric Carlson.

Minor code cleanup to remove isVideo function from HTMLAudioElement.
We can use default function in HTMLMediaElement as hasVideo does.

* html/HTMLAudioElement.h:
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::isVideo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdopt is/toHTMLInputElement for code cleanup
kangil.han@samsung.com [Fri, 28 Jun 2013 02:26:41 +0000 (02:26 +0000)]
Adopt is/toHTMLInputElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118130

Reviewed by Antti Koivisto.

To enhance readability, this patch adopts is/toHTMLInputElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

* accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaTimeline::valueDescription):
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isNativeImage):
(WebCore::AccessibilityNodeObject::isInputImage):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::valueForRange):
(WebCore::AccessibilityNodeObject::maxValueForRange):
(WebCore::AccessibilityNodeObject::minValueForRange):
(WebCore::AccessibilityNodeObject::actionElement):
(WebCore::AccessibilityNodeObject::titleElementText):
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):
(WebCore::AccessibilityNodeObject::text):
(WebCore::AccessibilityNodeObject::colorValue):
(WebCore::accessibleNameForNode):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isFileUploadButton):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::url):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::element):
* accessibility/ios/AccessibilityObjectIOS.mm:
(WebCore::AccessibilityObject::accessibilityPasswordFieldLength):
* bindings/js/JSHTMLInputElementCustom.cpp:
(WebCore::JSHTMLInputElement::selectionStart):
(WebCore::JSHTMLInputElement::setSelectionStart):
(WebCore::JSHTMLInputElement::selectionEnd):
(WebCore::JSHTMLInputElement::setSelectionEnd):
(WebCore::JSHTMLInputElement::selectionDirection):
(WebCore::JSHTMLInputElement::setSelectionDirection):
(WebCore::JSHTMLInputElement::setSelectionRange):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::isInPasswordField):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):
* html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::getTextFieldValues):
* html/HTMLInputElement.h:
(WebCore::isHTMLInputElement):
(WebCore::toHTMLInputElement):
* html/RadioInputType.cpp:
(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::isKeyboardFocusable):
* html/shadow/MediaControlElementTypes.cpp:
(WebCore::mediaControlElementType):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):
* loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
* page/Chrome.cpp:
(WebCore::Chrome::setToolTip):
* page/EventHandler.cpp:
(WebCore::isSubmitImage):
(WebCore::EventHandler::handleMousePressEvent):
* page/FocusController.cpp:
(WebCore::clearSelectionIfNeeded):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::getURLForImageNode):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
* platform/qt/RenderThemeQtMobile.cpp:
(WebCore::RenderThemeQtMobile::paintSliderTrack):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::isContentEditable):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::hasLineIfEmpty):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesLogicalWidthToFitContent):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::updateFromElement):
(WebCore::RenderButton::canHaveGeneratedChildren):
* rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::isOpen):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::updateFromElement):
(WebCore::RenderFileUploadControl::maxFilenameWidth):
(WebCore::RenderFileUploadControl::paintObject):
(WebCore::RenderFileUploadControl::uploadButton):
(WebCore::RenderFileUploadControl::fileTextValue):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::updateAltText):
* testing/Internals.cpp:
(WebCore::Internals::selectColorInColorChooser):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
* WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::findPasswordFormFields):
* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isPasswordElement):
(BlackBerry::WebKit::DOMSupport::inputElementText):
(BlackBerry::WebKit::DOMSupport::isDateTimeInputField):
(BlackBerry::WebKit::DOMSupport::isColorInputField):
(BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesNoAutocomplete):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::elementType):
(BlackBerry::WebKit::InputHandler::setInputValue):
(BlackBerry::WebKit::InputHandler::extractedTextRequest):
(BlackBerry::WebKit::InputHandler::showTextInputTypeSuggestionBox):

Source/WebKit/efl:

* ewk/ewk_view.cpp:
(ewk_view_input_method_state_set):

Source/WebKit/mac:

* DOM/WebDOMOperations.mm:
(-[DOMHTMLInputElement _setAutofilled:]):
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::focusedNodeChanged):
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::textFieldDidBeginEditing):
(WebEditorClient::textFieldDidEndEditing):
(WebEditorClient::textDidChangeInTextField):
(WebEditorClient::doTextFieldCommandFromEvent):
(WebEditorClient::textWillBeDeletedInTextField):
* WebView/WebHTMLRepresentation.mm:
(inputElementFromDOMElement):

Source/WebKit/qt:

* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState):
* WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::inputMethodQuery):

Source/WebKit/win:

* DOMCoreClasses.cpp:
(DOMElement::createInstance):
* DOMHTMLClasses.cpp:
(DOMHTMLInputElement::form):
(DOMHTMLInputElement::disabled):
(DOMHTMLInputElement::readOnly):
(DOMHTMLInputElement::setType):
(DOMHTMLInputElement::value):
(DOMHTMLInputElement::setValue):
(DOMHTMLInputElement::setValueForUser):
(DOMHTMLInputElement::select):
(DOMHTMLInputElement::setSelectionStart):
(DOMHTMLInputElement::selectionStart):
(DOMHTMLInputElement::setSelectionEnd):
(DOMHTMLInputElement::selectionEnd):
(DOMHTMLInputElement::isTextField):
(DOMHTMLInputElement::rectOnScreen):
(DOMHTMLInputElement::replaceCharactersInRange):
(DOMHTMLInputElement::selectedRange):
(DOMHTMLInputElement::setAutofilled):
(DOMHTMLInputElement::isAutofilled):
(DOMHTMLInputElement::isUserEdited):
* WebFrame.cpp:
(inputElementFromDOMElement):

Source/WebKit2:

* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementValueForUser):
(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit):
* WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::focusedNodeChanged):
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::textFieldDidBeginEditing):
(WebKit::WebEditorClient::textFieldDidEndEditing):
(WebKit::WebEditorClient::textDidChangeInTextField):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::containsAnyFormControls):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse DeferrableOneShotTimer for deleting decoded data
antti@apple.com [Fri, 28 Jun 2013 02:00:45 +0000 (02:00 +0000)]
Use DeferrableOneShotTimer for deleting decoded data
https://bugs.webkit.org/show_bug.cgi?id=118150

Reviewed by Andreas Kling.

Up to 1% of page load time can be used under CachedScript::script() for restarting
the decoded data deletion timer.

Using DeferrableOneShotTimer instead of a plain Timer avoids unnecessary low level timer access.

* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::destroyDecodedDataIfNeeded):
(WebCore::CachedResource::decodedDataDeletionTimerFired):
(WebCore::CachedResource::decodedDataDeletionTimerDelay):

    Adopt DeferrableOneShotTimer.

* loader/cache/CachedResource.h:
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::script):
(WebCore::CachedScript::decodedDataDeletionTimerDelay):

    Keep using zero delay for scripts.

* platform/Timer.h:
(WebCore::DeferrableOneShotTimer::stop):

    Avoid unnecessary restart after stopping and starting again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Add WK2 C API to handle touch events.
commit-queue@webkit.org [Fri, 28 Jun 2013 01:53:32 +0000 (01:53 +0000)]
[EFL][WK2] Add WK2 C API to handle touch events.
https://bugs.webkit.org/show_bug.cgi?id=108915

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-06-27
Reviewed by Gyuyoung Kim.

Touch events for our target platforms differ (XInput2, Wayland, Tizen) so
for the EFL port we want to be able to feed events manually.

To keep our current API for desktop EFL/Enlightenment working, we convert
our currently limited EFL events to the new EFL specific C EwkTouchPoint
and EwkTouchEvent type.

EwkTouchPoint and EwkTouchEvent are exposed as WKTouchPointRef and
WKTouchEventRef, so they are opaque in the applications.

The WKViewSendTouchEvent can be used for any use-case (platform/product)
not involving the EFL events.

At the same time we make sure to avoid using WK2 internals in our EFL API
implementation.

* PlatformEfl.cmake:
* Shared/API/c/efl/WKBaseEfl.h:
* Shared/APIObject.h:
* Shared/NativeWebTouchEvent.h:
(WebKit::NativeWebTouchEvent::nativeEvent):
* Shared/efl/NativeWebTouchEventEfl.cpp:
(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):
* Shared/efl/WebEventFactory.cpp:
(WebKit::toWebPlatformTouchPointState):
(WebKit::toWebEventType):
(WebKit::toWebEventModifiers):
(WebKit::WebEventFactory::createWebTouchEvent):
* Shared/efl/WebEventFactory.h:
* UIProcess/API/C/efl/WKAPICastEfl.h:
* UIProcess/API/C/efl/WKEventEfl.cpp: Added.
(WKTouchPointCreate):
(WKTouchEventCreate):
* UIProcess/API/C/efl/WKEventEfl.h: Added.
* UIProcess/API/C/efl/WKViewEfl.cpp:
(WKViewSendTouchEvent):
* UIProcess/API/C/efl/WKViewEfl.h:
* UIProcess/API/efl/EwkView.cpp:
(toWKTouchPointState):
(toWKEventModifiers):
(EwkView::feedTouchEvent):
(EwkView::feedTouchEvents):
* UIProcess/efl/EwkTouchEvent.cpp: Added.
(WebKit::EwkTouchEvent::EwkTouchEvent):
* UIProcess/efl/EwkTouchEvent.h: Added.
(WebKit::EwkTouchEvent::create):
(WebKit::EwkTouchEvent::eventType):
(WebKit::EwkTouchEvent::touchPoints):
(WebKit::EwkTouchEvent::modifiers):
(WebKit::EwkTouchEvent::timestamp):
(WebKit::EwkTouchEvent::type):
* UIProcess/efl/EwkTouchPoint.cpp: Added.
(WebKit::EwkTouchPoint::EwkTouchPoint):
* UIProcess/efl/EwkTouchPoint.h: Added.
(WebKit::EwkTouchPoint::create):
(WebKit::EwkTouchPoint::id):
(WebKit::EwkTouchPoint::state):
(WebKit::EwkTouchPoint::screenPosition):
(WebKit::EwkTouchPoint::position):
(WebKit::EwkTouchPoint::radius):
(WebKit::EwkTouchPoint::rotationAngle):
(WebKit::EwkTouchPoint::forceFactor):
(WebKit::EwkTouchPoint::type):
* UIProcess/efl/WebViewEfl.cpp:
(WebKit::WebViewEfl::sendTouchEvent):
* UIProcess/efl/WebViewEfl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Add Mavericks system font to Test systems
dino@apple.com [Fri, 28 Jun 2013 01:02:03 +0000 (01:02 +0000)]
[Mac] Add Mavericks system font to Test systems
https://bugs.webkit.org/show_bug.cgi?id=118109

Reviewed by Simon Fraser.

OS X Mavericks uses a different font for system controls. Tell DRT and
WKTR about them otherwise they use a fallback font. Unfortunately the
fonts are hidden (not found in the list of available fonts) so I
had to add them manually.

Even though there is only one at the moment, I implemented this
as a set so it will be easier to add new fonts if necessary.

* DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet): Fixed typo.
(systemHiddenFontFamilySet): New method that returns the system control font.
(drt_NSFontManager_availableFonts): Merge the hidden fonts.
* WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
(WTR::allowedFontFamilySet): Fixed typo.
(WTR::systemHiddenFontFamilySet): As above.
(WTR::wtr_NSFontManager_availableFonts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of the last uses of deprecatedCharactersWithNullTermination()
andersca@apple.com [Fri, 28 Jun 2013 00:33:21 +0000 (00:33 +0000)]
Get rid of the last uses of deprecatedCharactersWithNullTermination()
https://bugs.webkit.org/show_bug.cgi?id=118159

Reviewed by Andreas Kling.

Replace calls to deprecatedCharactersWithNullTermination() with charactersWithNullTermination().data().

Source/WebKit/win:

* COMPropertyBag.h:
(::GetPropertyInfo):
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::runOpenPanel):
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::updateWindowTitle):
* WebDownloadCFNet.cpp:
(WebDownload::didFinish):
* WebKitSystemBits.cpp:
(WebVolumeFreeSize):
* WebLocalizableStrings.cpp:
(LocalizedString::operator LPCTSTR):
* WebView.cpp:
(WebView::setToolTip):

Tools:

* DumpRenderTree/win/DumpRenderTree.cpp:
(findFontFallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a new String::charactersWithNullTermination() function that returns a vector
andersca@apple.com [Fri, 28 Jun 2013 00:19:42 +0000 (00:19 +0000)]
Add a new String::charactersWithNullTermination() function that returns a vector
https://bugs.webkit.org/show_bug.cgi?id=118155

Reviewed by Andreas Kling.

Source/WebCore:

Change calls to deprecatedCharactersWithNullTermination() to charactersWithNullTermination().data()

* platform/graphics/win/FontCacheWin.cpp:
(WebCore::getLinkedFonts):
* platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* platform/graphics/win/IconWin.cpp:
(WebCore::Icon::createIconForFiles):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpCookiesForQuickTime):
* platform/graphics/wince/FontPlatformData.cpp:
(WebCore::FontPlatformData::FontPlatformData):
* platform/network/curl/CurlDownload.cpp:
(CurlDownload::moveFileToDestination):
* platform/network/win/CookieJarWin.cpp:
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
* platform/network/win/DownloadBundleWin.cpp:
(WebCore::DownloadBundle::appendResumeData):
(WebCore::DownloadBundle::extractResumeData):
* platform/network/win/ResourceHandleWin.cpp:
(WebCore::createInternetHandle):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::fileLoadTimer):
* platform/text/win/LocaleWin.cpp:
(WebCore::LCIDFromLocaleInternal):
* platform/text/win/TextCodecWin.cpp:
(WebCore::TextCodecWin::enumerateSupportedEncodings):
* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::getWebLocData):
(WebCore::createGlobalData):
(WebCore::setFileDescriptorData):
(WebCore::getURL):
(WebCore::setCFData):
* platform/win/ContextMenuWin.cpp:
(WebCore::ContextMenu::createPlatformContextMenuFromItems):
* platform/win/DragImageWin.cpp:
(WebCore::createDragImageIconForCachedImageFilename):
* platform/win/FileSystemWin.cpp:
(WebCore::getFindData):
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::pathByAppendingComponent):
(WebCore::makeAllDirectories):
(WebCore::pathGetFileName):
(WebCore::openTemporaryFile):
(WebCore::openFile):
* platform/win/MIMETypeRegistryWin.cpp:
(WebCore::mimeTypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
* platform/win/PasteboardWin.cpp:
(WebCore::createGlobalImageFileDescriptor):
(WebCore::createGlobalHDropContent):
* platform/win/PathWalker.cpp:
(WebCore::PathWalker::PathWalker):
* platform/win/SSLKeyGeneratorWin.cpp:
(WebCore::WebCore::signedPublicKeyAndChallengeString):
* platform/win/SharedBufferWin.cpp:
(WebCore::SharedBuffer::createWithContentsOfFile):
* platform/wince/FileSystemWinCE.cpp:
(WebCore::getFileInfo):
(WebCore::fileExists):
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::makeAllDirectories):
(WebCore::openTemporaryFile):
(WebCore::openFile):
* plugins/win/PluginDatabaseWin.cpp:
(WebCore::PluginDatabase::getPluginPathsInDirectories):
(WebCore::addMozillaPluginDirectories):
(WebCore::addAdobeAcrobatPluginDirectory):
(WebCore::addJavaPluginDirectory):
* plugins/win/PluginPackageWin.cpp:
(WebCore::getVersionInfo):
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::handlePostReadFile):

Source/WTF:

This new String::charactersWithNullTermination() function returns a new Vector<UChar>
and does not modify the underlying string data.

* wtf/text/WTFString.cpp:
(WTF::String::charactersWithNullTermination):
* wtf/text/WTFString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: AX: Add container ARIA roles (toolbar, main, labeled regions, etc.)
commit-queue@webkit.org [Fri, 28 Jun 2013 00:17:22 +0000 (00:17 +0000)]
Web Inspector: AX: Add container ARIA roles (toolbar, main, labeled regions, etc.)
so the layout is more discoverable to screen reader users
https://bugs.webkit.org/show_bug.cgi?id=118104

Patch by James Craig <james@cookiecrook.com> on 2013-06-27
Reviewed by Timothy Hatcher.

Made the basic layout (toolbar, sidebars, main) of the Web Inspector understandable
and navigable with VoiceOver.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/ButtonNavigationItem.js:
* UserInterface/CSSStyleDetailsSidebarPanel.js:
* UserInterface/DashboardManager.js:
* UserInterface/Main.js:
* UserInterface/NavigationBar.js:
* UserInterface/NavigationItem.js:
* UserInterface/NavigationSidebarPanel.js:
* UserInterface/RadioButtonNavigationItem.js:
* UserInterface/Sidebar.js:
* UserInterface/SidebarPanel.js:
* UserInterface/Toolbar.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement parsing of MathML lengths.
commit-queue@webkit.org [Fri, 28 Jun 2013 00:14:57 +0000 (00:14 +0000)]
Implement parsing of MathML lengths.
https://bugs.webkit.org/show_bug.cgi?id=118053

Patch by Frédéric Wang <fred.wang@free.fr> on 2013-06-27
Reviewed by Chris Fleizach.

Source/WebCore:

A parsing function for MathML lengths, similar to Gecko's one, is
implemented. It is currently only used to parse mfrac@linethickness but
will be convenient to parse other MathML attributes in the future.

Tests: mathml/presentation/mfrac-linethickness1.html
       mathml/presentation/mfrac-linethickness2.html
       mathml/presentation/mfrac-linethickness3.html

* rendering/mathml/RenderMathMLBlock.cpp: add parsing functions
(WebCore::parseMathMLLength): parsing MathML Length (number unit)
(WebCore::parseNamedSpace): parsing MathML namedspaces
* rendering/mathml/RenderMathMLBlock.h: declare parsing functions
* rendering/mathml/RenderMathMLFraction.cpp: use the parsing function for linethickness
(WebCore::RenderMathMLFraction::updateFromElement):

LayoutTests:

Add some reftests for mfrac@linethickness. Better tests for the parsing
of MathML lengths will be provided when mspace is implemented
(bug 115610)

* mathml/presentation/mfrac-linethickness1-expected-mismatch.html: Added.
* mathml/presentation/mfrac-linethickness1.html: Added.
* mathml/presentation/mfrac-linethickness2-expected.html: Added.
* mathml/presentation/mfrac-linethickness2.html: Added.
* mathml/presentation/mfrac-linethickness3-expected-mismatch.html: Added.
* mathml/presentation/mfrac-linethickness3.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac WK2] compositing/repaint/positioned-movement.html flaky, missing repaint
jberlin@webkit.org [Thu, 27 Jun 2013 23:41:19 +0000 (23:41 +0000)]
[Mac WK2] compositing/repaint/positioned-movement.html flaky, missing repaint
https://bugs.webkit.org/show_bug.cgi?id=118153

Update the expectation to reflect that the test is also flakey on release and other
platforms

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove call to deprecatedCharactersWithNullTermination() in WebGL code
andersca@apple.com [Thu, 27 Jun 2013 23:31:13 +0000 (23:31 +0000)]
Remove call to deprecatedCharactersWithNullTermination() in WebGL code
https://bugs.webkit.org/show_bug.cgi?id=118154

Reviewed by Dean Jackson.

Remove an unneeded call to deprecatedCharactersWithNullTermination(). Ultimately,
the string we used to call it on gets converted to an UTF-8 CString that has a null character anyway.

* html/canvas/WebGLProgram.cpp:
(WebCore::WebGLProgram::cacheActiveAttribLocations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: AX: Console log of the Inspector does not announce output for screen...
commit-queue@webkit.org [Thu, 27 Jun 2013 23:04:34 +0000 (23:04 +0000)]
Web Inspector: AX: Console log of the Inspector does not announce output for screen readers
https://bugs.webkit.org/show_bug.cgi?id=115976

Patch by James Craig <james@cookiecrook.com> on 2013-06-27
Reviewed by Timothy Hatcher.

Main console log area (div.console-messages) is now an ARIA live region (role="log")
so screen readers speak plain text updates.

Also added contextual labels (e.g. input/output) but speech output verification of
those is currently blocked by http://webkit.org/b/118096

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/ConsoleCommand.js:
(WebInspector.ConsoleCommand.prototype.toMessageElement):
* UserInterface/ConsoleCommandResult.js:
(WebInspector.ConsoleCommandResult.prototype.toMessageElement):
* UserInterface/LogContentView.css:
(@media reader):
* UserInterface/LogContentView.js:
(WebInspector.LogContentView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Temporarily add some stderr output to Media Engine load methods to determ...
roger_fong@apple.com [Thu, 27 Jun 2013 23:00:42 +0000 (23:00 +0000)]
Unreviewed. Temporarily add some stderr output to Media Engine load methods to determine which engine buildbots are using for layout tests.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::load):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStop using deprecatedCharactersWithNullTermination in SQLite code
andersca@apple.com [Thu, 27 Jun 2013 22:56:32 +0000 (22:56 +0000)]
Stop using deprecatedCharactersWithNullTermination in SQLite code
https://bugs.webkit.org/show_bug.cgi?id=118146

Reviewed by Filip Pizlo.

Turns out SQLite uses UTF-8 internally so we might just as well use the SQLite functions
that take UTF-8 strings and do the conversion ourselves. This has the added advantage that we can
use String::utf8() which returns a null-terminated string.

Require a version of SQLite newer than 3.6.16 so we can remove two workarounds. 3.6.16 was released
4 years ago so supported port is likely to have it.

* platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
Use sqlite3_open instead of sqlite3_open16.

* platform/sql/SQLiteFileSystem.h:
Fix parameter name capitalization.

* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
Use sqlite3_prepare_v2. Also, pass the length of the string (including the null character), since
that lets SQLite avoid a buffer copy. Remove a workaround for versions of SQLite older than 3.6.16.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSync up w3c import script with changes in Blink
commit-queue@webkit.org [Thu, 27 Jun 2013 22:43:27 +0000 (22:43 +0000)]
Sync up w3c import script with changes in Blink
https://bugs.webkit.org/show_bug.cgi?id=118149

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-06-27
Reviewed by Dirk Pranke.

This is a port of the following blink changes:

https://codereview.chromium.org/15366004
https://chromiumcodereview.appspot.com/15592005
https://codereview.chromium.org/16021006
https://codereview.chromium.org/15590004
https://codereview.chromium.org/15901008
https://codereview.chromium.org/16171009
https://codereview.chromium.org/16465007
https://codereview.chromium.org/15981013

* Scripts/webkitpy/common/checkout/checkout_unittest.py:
(setUp):
(test_commit_message_for_this_commit):
* Scripts/webkitpy/port/base.py:
(Port):
* Scripts/webkitpy/port/test.py:
* Scripts/webkitpy/w3c/test_converter.py:
(W3CTestConverter.__init__):
(W3CTestConverter.read_webkit_prefixed_css_property_list):
(W3CTestConverter.convert_for_webkit):
(W3CTestConverter.convert_css):
(W3CTestConverter.convert_html):
(W3CTestConverter.convert_testharness_paths):
(W3CTestConverter.convert_prefixed_properties):
(W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
* Scripts/webkitpy/w3c/test_converter_unittest.py:
* Scripts/webkitpy/w3c/test_importer.py:
(main):
(configure_logging):
(configure_logging.LogHandler):
(configure_logging.LogHandler.format):
(parse_args):
(TestImporter.__init__):
(TestImporter.find_importable_tests):
(TestImporter.import_tests):
(TestImporter.setup_destination_directory):
(TestImporter.remove_deleted_files):
* Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
(TestImporterTest.test_import_dir_with_no_tests):
(TestImporterTest):
* Scripts/webkitpy/w3c/test_parser.py:
(TestParser.load_file):
(TestParser.analyze_test):
(TestParser.support_files):
* Scripts/webkitpy/w3c/test_parser_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Unnecessary root layer commits occur during html5 video playback
commit-queue@webkit.org [Thu, 27 Jun 2013 22:40:32 +0000 (22:40 +0000)]
[BlackBerry] Unnecessary root layer commits occur during html5 video playback
https://bugs.webkit.org/show_bug.cgi?id=118147

Patch by Andrew Lo <anlo@blackberry.com> on 2013-06-27
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson, John Griggs.

Only request layer commits when layer properties change in
GraphicsLayerBlackBerry::updateContentsRect and
GraphicsLayerBlackBerry::setContentsToMedia.
JIRA112749.

* platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayerBlackBerry::setContentsToMedia):
(WebCore::GraphicsLayerBlackBerry::updateContentsRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] New positioning model: basic support for rectangle shape-outside
commit-queue@webkit.org [Thu, 27 Jun 2013 20:33:07 +0000 (20:33 +0000)]
[CSS Shapes] New positioning model: basic support for rectangle shape-outside
https://bugs.webkit.org/show_bug.cgi?id=118080

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-06-27
Reviewed by David Hyatt.

Source/WebCore:

With the latest Editor's Draft of the CSS Shapes specification,
shape-outside no longer affects the positioning of floats. This is the
first step in changing the implementation to reflect this
specification change. The bulk of this change is reverting the code
that was needed to position floats based on the bounding box of the
shape.

Tests: csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html
       csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html
       csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html
       csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html
       csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html
       csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html
       csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html

* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState): Revert changes to support float
    positioning from shape-outside.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::blockSelectionGaps): Ditto.
(WebCore::RenderBlock::insertFloatingObject): Ditto.
(WebCore::RenderBlock::positionNewFloats): Ditto.
(WebCore::RenderBlock::logicalLeftOffsetForLine): Instead of
    converting to shape bounding box coordinates, convert to the
    float's margin box coordinates.
(WebCore::RenderBlock::logicalRightOffsetForLine): Ditto.
(WebCore::positionForPointRespectingEditingBoundaries): Revert changes
    to support float positioning from shape-outside.
* rendering/RenderBlock.h:
(WebCore::RenderBlock::xPositionForFloatIncludingMargin): Ditto.
(WebCore::RenderBlock::yPositionForFloatIncludingMargin): Ditto.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Instead
    of converting to shape bounding box coordinates, convert to the
    float's margin box coordinates.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::mapLocalToContainer): Revert changes to support
    float positioning from shape-outside.
(WebCore::RenderBox::offsetFromContainer): Ditto.
(WebCore::RenderBox::computeRectForRepaint): Ditto.
(WebCore::RenderBox::layoutOverflowRectForPropagation): Ditto.
* rendering/RenderBoxModelObject.cpp: Ditto.
* rendering/RenderBoxModelObject.h: Ditto.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint): Ditto.
(WebCore::RenderInline::computeRectForRepaint): Ditto.
(WebCore::RenderInline::mapLocalToContainer): Ditto.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition): Ditto.
(WebCore::RenderLayer::calculateClipRects): Ditto.
(WebCore::RenderLayer::shouldBeNormalFlowOnly): Ditto.
* rendering/RenderLayer.h:
(WebCore::RenderLayer::offsetForInFlowPosition): Ditto.
* rendering/RenderObject.h: Ditto.
* rendering/shapes/ShapeInfo.h: Make m_renderer protected, since we
    now need it in the subclass to compute the segments.
* rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::computeSegmentsForLine): Update segment
    computation to use the float's margin box instead of the shape's
    bounding box for computing the deltas.
(WebCore::ShapeOutsideInfo::leftSegmentMarginBoxDelta): This used to
    be leftSegmentShapeBoundingBoxDelta, which has been renamed in the
    obvious way.
(WebCore::ShapeOutsideInfo::rightSegmentMarginBoxDelta): This used to
    be rightSegmentShapeBoundingBoxDelta, which has been renamed in the
    obvious way.
* rendering/shapes/ShapeOutsideInfo.h: Revert changes to support float
    positioning from shape-outside.
* rendering/style/RenderStyle.h: Ditto.

LayoutTests:

Added new tests for the new model. These tests are also spec tests, so
their canonical location is now in the CSS WG's repository. They have
been imported to WebKit using the import-w3c-tests script, and that's
why they live under the csswg directory.

The new tests replace the shape-outside-floats-simple-rectangle.html
test, which was anything but simple.

Tests that have not been rewritten yet have been marked as skipped.
Tests for the old positioning behavior that are not applicable to the
new behavior have been deleted.

* TestExpectations: Skip all the tests that need to be rewritten.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000-expected.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001-expected.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002-expected.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000-expected.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000-expected.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001-expected.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002-expected.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html: Added.
* csswg/submitted/shapes/shape-outside/w3c-import.log: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-margin-is-ignored-expected.html: Removed.
* fast/exclusions/shape-outside-floats/shape-outside-floats-margin-is-ignored.html: Removed.
* fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y-expected.html: Removed.
* fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y.html: Removed.
* fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden-expected.html: Removed.
* fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden.html: Removed.
* fast/exclusions/shape-outside-floats/shape-outside-floats-overhang-expected.html: Removed.
* fast/exclusions/shape-outside-floats/shape-outside-floats-overhang.html: Removed.
* fast/exclusions/shape-outside-floats/shape-outside-floats-positioning-expected.html: Removed.
* fast/exclusions/shape-outside-floats/shape-outside-floats-positioning.html: Removed.
* fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rectangle-expected.html: Removed.
* fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rectangle.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRenderLayerCompositor destructor is fragile
antti@apple.com [Thu, 27 Jun 2013 20:02:12 +0000 (20:02 +0000)]
RenderLayerCompositor destructor is fragile
https://bugs.webkit.org/show_bug.cgi?id=118143

Reviewed by Simon Fraser.

With iOS tile cache implementation deleting RenderLayerCompositor may end up starting a deleted timer.
This corrupts the timer heap and leads to a crash later. This happens because GraphicsLayers destructor
calls back to the RenderLayerCompositor that is being deleted. This is pretty fragile in general.

No test as there is no known way to repro this with plain webkit.

* platform/Timer.cpp:
(WebCore::TimerBase::TimerBase):
(WebCore::TimerBase::~TimerBase):
(WebCore::TimerBase::setNextFireTime):
* platform/Timer.h:

    Assert that the timer is alive before starting it. This turns bugs like this into clear crash stacks
    instead of hard-to-debug timer heap corruptions.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::~RenderLayerCompositor):

    Take care to delete owned GraphicsLayers before proceeding with the rest of the destructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate SVG interfaces to stop inheriting from SVGURIReference and SVGTests
ch.dumez@sisa.samsung.com [Thu, 27 Jun 2013 19:36:25 +0000 (19:36 +0000)]
Update SVG interfaces to stop inheriting from SVGURIReference and SVGTests
https://bugs.webkit.org/show_bug.cgi?id=118142

Reviewed by Ryosuke Niwa.

Stop inheriting from SVGURIReference and SVGTests and use IDL implements statements
instead. This is one step towards getting rid of multiple inheritance in SVG (which
is no longer supported by Web IDL) and matching the latest specification:
- https://svgwg.org/svg2-draft/types.html#BasicDOMInterfaces

No new tests, no behavior change.

* CMakeLists.txt:
* DerivedSources.pri:
* GNUmakefile.list.am:
* svg/SVGAElement.idl:
* svg/SVGAltGlyphElement.idl:
* svg/SVGAnimationElement.idl:
* svg/SVGCircleElement.idl:
* svg/SVGClipPathElement.idl:
* svg/SVGCursorElement.idl:
* svg/SVGDefsElement.idl:
* svg/SVGEllipseElement.idl:
* svg/SVGFEImageElement.idl:
* svg/SVGFilterElement.idl:
* svg/SVGForeignObjectElement.idl:
* svg/SVGGElement.idl:
* svg/SVGGlyphRefElement.idl:
* svg/SVGGradientElement.idl:
* svg/SVGImageElement.idl:
* svg/SVGLineElement.idl:
* svg/SVGMPathElement.idl:
* svg/SVGMaskElement.idl:
* svg/SVGPathElement.idl:
* svg/SVGPatternElement.idl:
* svg/SVGPolygonElement.idl:
* svg/SVGPolylineElement.idl:
* svg/SVGRectElement.idl:
* svg/SVGSVGElement.idl:
* svg/SVGScriptElement.idl:
* svg/SVGSwitchElement.idl:
* svg/SVGTRefElement.idl:
* svg/SVGTextContentElement.idl:
* svg/SVGTextPathElement.idl:
* svg/SVGUseElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate required tools for Windows instructions.
roger_fong@apple.com [Thu, 27 Jun 2013 18:37:17 +0000 (18:37 +0000)]
Update required tools for Windows instructions.

* building/tools.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPolish context menus for media elements
commit-queue@webkit.org [Thu, 27 Jun 2013 18:13:47 +0000 (18:13 +0000)]
Polish context menus for media elements
https://bugs.webkit.org/show_bug.cgi?id=118078
<rdar://problem/14278960>

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-27
Reviewed by Eric Carlson.

No new tests: media/context-menu-action.html,
which has been disabled by bug 116651, is used to test context menus.

* English.lproj/Localizable.strings: Changed "Fullscreen" to "Full Screen"
and added strings "Show Controls" and "Hide Controls".

* page/ContextMenuController.cpp: Updated to include a new context menu item
that toggles betweeen "Show Controls" and "Hide Controls".

* platform/ContextMenuItem.h:

* platform/LocalizedStrings.cpp:
* platform/LocalizedStrings.h:
* platform/efl/LocalizedStringsEfl.cpp:
* platform/gtk/LocalizedStringsGtk.cpp:
* platform/qt/LocalizedStringsQt.cpp:
Added equivalents of localized strings "Show Controls" and "Hide Controls".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[webkitpy] AbstractPatchSequencingCommand should have _prepare_state
ossy@webkit.org [Thu, 27 Jun 2013 17:49:51 +0000 (17:49 +0000)]
[webkitpy] AbstractPatchSequencingCommand should have _prepare_state
https://bugs.webkit.org/show_bug.cgi?id=118128

Reviewed by Ryosuke Niwa.

It is a preparation for a new webkit-patch command: run-tests-touched-by-attachment
https://bugs.webkit.org/show_bug.cgi?id=117831

* Scripts/webkitpy/tool/commands/download.py:
(AbstractPatchSequencingCommand):
(AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.
(AbstractPatchSequencingCommand._process_patch): Use the same initial state for each patch.
(AbstractPatchSequencingCommand._prepare_state): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix cast-align warnings in WebKit2/Platform/CoreIPC
ossy@webkit.org [Thu, 27 Jun 2013 17:44:00 +0000 (17:44 +0000)]
Fix cast-align warnings in WebKit2/Platform/CoreIPC
https://bugs.webkit.org/show_bug.cgi?id=117987

Reviewed by Rob Buis, WK2 signed-off by Anders Carlsson.

* Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::decode):
* Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::encode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: IOS: crash while navigating with SVG
cfleizach@apple.com [Thu, 27 Jun 2013 16:51:01 +0000 (16:51 +0000)]
AX: IOS: crash while navigating with SVG
https://bugs.webkit.org/show_bug.cgi?id=118101

Source/WebCore:

Need to check if the SVG path exists before copying it.

Reviewed by Stephen Chenney.

Test: platform/iphone-simulator/accessibility/svg-path-crash.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::elementPath):
* rendering/svg/RenderSVGShape.h:
(WebCore::RenderSVGShape::hasPath):

LayoutTests:

Reviewed by Stephen Chenney.

* platform/iphone-simulator/accessibility/svg-path-crash-expected.txt: Added.
* platform/iphone-simulator/accessibility/svg-path-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Build overrides -j when given --makeargs="-sj40"
commit-queue@webkit.org [Thu, 27 Jun 2013 16:44:21 +0000 (16:44 +0000)]
[Qt] Build overrides -j when given --makeargs="-sj40"
https://bugs.webkit.org/show_bug.cgi?id=116897

Patch by Brendan Long <b.long@cablelabs.com> on 2013-06-27
Reviewed by Csaba Osztrogonác.

* Scripts/webkitdirs.pm:
(buildQMakeProjects):
Change regex checking for -j* to also check for -*j*

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoving the redundant checks after r152078
commit-queue@webkit.org [Thu, 27 Jun 2013 16:33:05 +0000 (16:33 +0000)]
Removing the redundant checks after r152078
https://bugs.webkit.org/show_bug.cgi?id=118117

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-06-27
Reviewed by Simon Fraser.

Avoided redundant checks in RenderLayerCompositor::reasonsForCompositing() after r152078.

No new tests as no functionality change.

* inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logReasonsForCompositing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] We should clear all markers when input changes a word
commit-queue@webkit.org [Thu, 27 Jun 2013 16:32:52 +0000 (16:32 +0000)]
[BlackBerry] We should clear all markers when input changes a word
https://bugs.webkit.org/show_bug.cgi?id=118136
JIRA115313.

For the case where a letter is added to the middle of a misspelled word, we were
sending incorrect offsets to clear spelling markers. However, since this
expanded the current word, it overlaps entirely the previous spelling marker so
no issue is found. However, if the keypress is backspace, the incorrect range
is smaller, causing an overlap which recreates the marker over the last character.
Setting shouldEraseMarkersAfterChangeSelection to follow continuous spell checking,
which will clear all markers regardless of overlap.
This patch also sustains spelling markers after the user taps to move the caret onto
the word, which is a nice gain as it was asked for previously.

Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-06-27
Reviewed by Rob Buis.

Internally Reviewed by Mike Fenton

* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldEraseMarkersAfterChangeSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Unreviewed gardening. Unskip tests no longer timing out.
mario@webkit.org [Thu, 27 Jun 2013 16:19:09 +0000 (16:19 +0000)]
[GTK] Unreviewed gardening. Unskip tests no longer timing out.
https://bugs.webkit.org/show_bug.cgi?id=118135

Unreviewed GTK gardening.

Patch by Simon Pena <simon.pena@samsung.com> on 2013-06-27

* platform/gtk-wk1/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove [NoInterfaceObject] from WorkerGlobalScope
ch.dumez@sisa.samsung.com [Thu, 27 Jun 2013 15:46:35 +0000 (15:46 +0000)]
Remove [NoInterfaceObject] from WorkerGlobalScope
https://bugs.webkit.org/show_bug.cgi?id=118071

Reviewed by Kentaro Hara.

.:

Update GENERATE_BINDINGS CMake macro to take 2 additional parameters
now needed by the preprocess-idls.pl script.

* Source/cmake/WebKitMacros.cmake:

Source/WebCore:

Expose WorkerGlobalScope interface in worker environment as per the latest
specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#the-workerglobalscope-common-interface

Also expose the SharedWorkerGlobalScope interface when the JavaScript global environment is a
shared worker environment, and the DedicatedWorkerGlobalScope interface when the JavaScript
global environment is a dedicated worker environment:
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#sharedworkerglobalscope
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#dedicatedworkerglobalscope

The semantics of the [GlobalContext] IDL extended attribute has changed to support this
use case. The value for the extended attribute is now the name of the interface to which the
Constructor attribute should be added (Window, WorkerGlobalScope, SharedWorkerGlobalScope...).
It is possible to specify several interface names by using '&' as separator. For e.g.
[GlobalContext=DOMWindow&WorkerGlobalScope].

Tests: fast/js/global-constructors-attributes-dedicated-worker.html
       fast/js/global-constructors-attributes-shared-worker.html

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* Modules/websockets/WebSocket.idl:
* UseJSC.cmake:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorHelperMethods):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/generate-bindings.pl:
(checkIfIDLAttributesExists):
* bindings/scripts/preprocess-idls.pl:
* dom/MessageChannel.idl:
* dom/MessageEvent.idl:
* fileapi/Blob.idl:
* fileapi/FileReader.idl:
* fileapi/FileReaderSync.idl:
* html/DOMURL.idl:
* html/canvas/ArrayBuffer.idl:
* html/canvas/DataView.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* page/EventSource.idl:
* workers/DedicatedWorkerGlobalScope.idl:
* workers/SharedWorkerGlobalScope.idl:
* workers/WorkerGlobalScope.idl:
* workers/WorkerLocation.idl:
* xml/XMLHttpRequest.idl:

Tools:

Update bindings test script to pass 2 additional parameters
now needed by the preprocess-idls.pl script.

* Scripts/webkitpy/bindings/main.py:
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.main):

LayoutTests:

Split fast/js/global-constructors-attributes-worker.html test into 2 for both
shared and dedicated workers, as the output is now different.

* fast/js/global-constructors-attributes-dedicated-worker-expected.txt: Copied from LayoutTests/fast/js/global-constructors-attributes-worker-expected.txt.
* fast/js/global-constructors-attributes-dedicated-worker.html: Copied from LayoutTests/fast/js/global-constructors-attributes-worker.html.
* fast/js/global-constructors-attributes-shared-worker-expected.txt: Renamed from LayoutTests/fast/js/global-constructors-attributes-worker-expected.txt.
* fast/js/global-constructors-attributes-shared-worker.html: Renamed from LayoutTests/fast/js/global-constructors-attributes-worker.html.
* fast/js/script-tests/global-constructors-attributes.js:
(.self.postMessage):
(.self.onconnect.self.postMessage):
(.self.onconnect):
* platform/efl/fast/js/global-constructors-attributes-dedicated-worker-expected.txt: Copied from LayoutTests/platform/gtk/fast/js/global-constructors-attributes-worker-expected.txt.
* platform/efl/fast/js/global-constructors-attributes-shared-worker-expected.txt: Copied from LayoutTests/platform/gtk/fast/js/global-constructors-attributes-worker-expected.txt.
* platform/gtk/fast/js/global-constructors-attributes-dedicated-worker-expected.txt: Renamed from LayoutTests/platform/gtk/fast/js/global-constructors-attributes-worker-expected.txt.
* platform/gtk/fast/js/global-constructors-attributes-shared-worker-expected.txt: Renamed from LayoutTests/platform/efl/fast/js/global-constructors-attributes-worker-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r152074.
commit-queue@webkit.org [Thu, 27 Jun 2013 15:42:18 +0000 (15:42 +0000)]
Unreviewed, rolling out r152074.
http://trac.webkit.org/changeset/152074
https://bugs.webkit.org/show_bug.cgi?id=118137

It caused lots of layout and API test crash on Qt Wk2.
(Requested by kadam on #webkit).

Source/WebCore:

* CMakeLists.txt:
* Target.pri:
* platform/graphics/texmap/coordinated/CompositingCoordinator.cpp: Removed.
* platform/graphics/texmap/coordinated/CompositingCoordinator.h: Removed.

Source/WebKit2:

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::~CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::setRootCompositingLayer):
(WebKit::CoordinatedLayerTreeHost::invalidate):
(WebKit::CoordinatedLayerTreeHost::forceRepaint):
(WebKit::CoordinatedLayerTreeHost::sizeDidChange):
(WebKit::CoordinatedLayerTreeHost::flushPendingLayerChanges):
(WebKit::CoordinatedLayerTreeHost::clearPendingStateChanges):
(WebKit::CoordinatedLayerTreeHost::initializeRootCompositingLayerIfNeeded):
(WebKit::CoordinatedLayerTreeHost::syncLayerState):
(WebKit::CoordinatedLayerTreeHost::prepareCustomFilterProxiesIfNeeded):
(WebKit::CoordinatedLayerTreeHost::checkCustomFilterProgramProxies):
(WebKit::CoordinatedLayerTreeHost::removeCustomFilterProgramProxy):
(WebKit::CoordinatedLayerTreeHost::detachLayer):
(WebKit::CoordinatedLayerTreeHost::performScheduledLayerFlush):
(WebKit::CoordinatedLayerTreeHost::syncDisplayState):
(WebKit::CoordinatedLayerTreeHost::didPerformScheduledLayerFlush):
(WebKit::CoordinatedLayerTreeHost::createPageOverlayLayer):
(WebKit::CoordinatedLayerTreeHost::createImageBackingIfNeeded):
(WebKit::CoordinatedLayerTreeHost::createImageBacking):
(WebKit::CoordinatedLayerTreeHost::updateImageBacking):
(WebKit::CoordinatedLayerTreeHost::clearImageBackingContents):
(WebKit::CoordinatedLayerTreeHost::removeImageBacking):
(WebKit::CoordinatedLayerTreeHost::flushPendingImageBackingChanges):
(WebKit::CoordinatedLayerTreeHost::notifyAnimationStarted):
(WebKit::CoordinatedLayerTreeHost::notifyFlushRequired):
(WebKit::CoordinatedLayerTreeHost::paintContents):
(WebKit::CoordinatedLayerTreeHost::createGraphicsLayer):
(WebKit::CoordinatedLayerTreeHost::deviceScaleFactor):
(WebKit::CoordinatedLayerTreeHost::pageScaleFactor):
(WebKit::CoordinatedLayerTreeHost::createUpdateAtlas):
(WebKit::CoordinatedLayerTreeHost::removeUpdateAtlas):
(WebKit::CoordinatedLayerTreeHost::visibleContentsRect):
(WebKit::CoordinatedLayerTreeHost::mainContentsLayer):
(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
(WebKit::CoordinatedLayerTreeHost::graphicsLayerFactory):
(WebKit::CoordinatedLayerTreeHost::scheduleAnimation):
(WebKit::CoordinatedLayerTreeHost::renderNextFrame):
(WebKit::CoordinatedLayerTreeHost::purgeBackingStores):
(WebKit::CoordinatedLayerTreeHost::paintToSurface):
(WebKit::CoordinatedLayerTreeHost::scheduleReleaseInactiveAtlases):
(WebKit::CoordinatedLayerTreeHost::releaseInactiveAtlasesTimerFired):
(WebKit::CoordinatedLayerTreeHost::commitScrollOffset):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
* WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::setVisibleContentsRect):
(WebKit::LayerTreeHost::renderNextFrame):
(WebKit::LayerTreeHost::purgeBackingStores):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid duplicating hostWindow() call in FrameView::setFrameRect()
commit-queue@webkit.org [Thu, 27 Jun 2013 15:11:32 +0000 (15:11 +0000)]
Avoid duplicating hostWindow() call in FrameView::setFrameRect()
https://bugs.webkit.org/show_bug.cgi?id=118115

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-06-27
Reviewed by Christophe Dumez.

Remove a redundant call in FrameView::setFrameRect().

No function change, no tests.

* page/FrameView.cpp:
(WebCore::FrameView::scheduleAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening
commit-queue@webkit.org [Thu, 27 Jun 2013 14:35:32 +0000 (14:35 +0000)]
[Qt] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=118100

Unreviewed Qt gardening.

Moved hover-display-block-none.html from fast/regions to fast/css.

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-06-27

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Rebase the previous test.
zarvai@inf.u-szeged.hu [Thu, 27 Jun 2013 14:19:52 +0000 (14:19 +0000)]
[Qt] Unreviewed gardening. Rebase the previous test.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-27

* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFixing some compiler warnings
commit-queue@webkit.org [Thu, 27 Jun 2013 13:48:36 +0000 (13:48 +0000)]
Fixing some compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=117791

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-06-27
Reviewed by Martin Robinson.

Source/WebCore:

No new tests needed.

* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetTextForOffset): Fixed warning about
uninitialized variable.

Source/WebKit2:

* UIProcess/API/gtk/tests/WebExtensionTest.cpp: Properly
initialized GDBusInterfaceVTable.
* WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkitWebPageCreate): Added missing fields to the
WKBundlePageLoaderClient.

Tools:

* GNUmakefile.am: Silenced format warning.
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
(TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
Solved warning about uninitialized variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse consistent file names for WidgetBackingStoreGtkX11 class
commit-queue@webkit.org [Thu, 27 Jun 2013 13:31:31 +0000 (13:31 +0000)]
Use consistent file names for WidgetBackingStoreGtkX11 class
https://bugs.webkit.org/show_bug.cgi?id=118124

Patch by Iago Toral Quiroga <itoral@igalia.com> on 2013-06-27
Reviewed by Carlos Garcia Campos.

Source/WebCore:

* GNUmakefile.list.am:
* PlatformGTK.cmake:
* platform/gtk/GtkWidgetBackingStoreX11.cpp: Removed.
* platform/gtk/GtkWidgetBackingStoreX11.h: Removed.
* platform/gtk/WidgetBackingStoreGtkX11.cpp: Added.
(WebCore::WidgetBackingStoreGtkX11::create):
(WebCore::WidgetBackingStoreGtkX11::WidgetBackingStoreGtkX11):
(WebCore::WidgetBackingStoreGtkX11::~WidgetBackingStoreGtkX11):
(WebCore::WidgetBackingStoreGtkX11::cairoSurface):
(WebCore::WidgetBackingStoreGtkX11::scroll):
* platform/gtk/WidgetBackingStoreGtkX11.h: Added.

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.cpp:

Source/WebKit2:

* UIProcess/cairo/BackingStoreCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Rebase and skipping failing tests.
zarvai@inf.u-szeged.hu [Thu, 27 Jun 2013 12:46:38 +0000 (12:46 +0000)]
[Qt] Unreviewed gardening. Rebase and skipping failing tests.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-27

* platform/qt-5.0-wk1/TestExpectations:
* platform/qt/TestExpectations:
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Display color picker in popover on color swatch click
commit-queue@webkit.org [Thu, 27 Jun 2013 11:07:33 +0000 (11:07 +0000)]
Web Inspector: Display color picker in popover on color swatch click
https://bugs.webkit.org/show_bug.cgi?id=117919

Patch by Matthew Holden <jftholden@yahoo.com> on 2013-06-27
Reviewed by Timothy Hatcher.

Includes fixes from second code review.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/CSSColorPicker.css: Added.
(.colorpicker-container):
(.colorpicker-fill-parent):
(.colorpicker-top):
(.colorpicker-color):
(.colorpicker-bottom span):
(.colorpicker-text):
(.colorpicker-color-text-value):
(.colorpicker-hue):
(.colorpicker-fill):
(.colorpicker-range-container):
(.colorpicker-range-container *):
(.colorpicker-range-container label):
(.colorpicker-range-container input):
(.colorpicker-saturation):
(.colorpicker-value):
(.colorpicker-dragger):
(.colorpicker-slider):
(.colorpicker-container .swatch):
(.colorpicker-container .swatch-inner):
* UserInterface/CSSColorPicker.js: Added.
(WebInspector.CSSColorPicker.consume):
(WebInspector.CSSColorPicker.move):
(WebInspector.CSSColorPicker.start):
(WebInspector.CSSColorPicker.stop):
(WebInspector.CSSColorPicker.makeDraggable):
(WebInspector.CSSColorPicker.hueDrag):
(WebInspector.CSSColorPicker.colorDragStart):
(WebInspector.CSSColorPicker.colorDrag):
(WebInspector.CSSColorPicker.alphaDrag):
(WebInspector.CSSColorPicker.colorSwatchClicked):
(WebInspector.CSSColorPicker):
(WebInspector.CSSColorPicker.prototype.get element):
(WebInspector.CSSColorPicker.prototype.set color):
(WebInspector.CSSColorPicker.prototype.get color):
(WebInspector.CSSColorPicker.prototype.get outputColorFormat):
(WebInspector.CSSColorPicker.prototype.get colorHueOnly):
(WebInspector.CSSColorPicker.prototype.set displayText):
(WebInspector.CSSColorPicker.prototype.shown):
(WebInspector.CSSColorPicker.prototype._updateHelperLocations):
(WebInspector.CSSColorPicker.prototype._updateDisplay):
(WebInspector.CSSColorPicker.hsvaToRGBA):
(WebInspector.CSSColorPicker.rgbaToHSVA):
* UserInterface/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype.didDismissPopover):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.event.newColorText.colorTextMarker):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.event.newColorText):
* UserInterface/Main.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNotify the debugger about functions created from source code via new Function() or...
timothy@apple.com [Thu, 27 Jun 2013 11:03:32 +0000 (11:03 +0000)]
Notify the debugger about functions created from source code via new Function() or WebCore::JSLazyEventListener.

https://bugs.webkit.org/show_bug.cgi?id=118063

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::fromGlobalCode): Call Debugger::sourceParsed.

LayoutTests:

* inspector/debugger/debugger-script-preprocessor-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Thu, 27 Jun 2013 10:36:01 +0000 (10:36 +0000)]
Unreviewed EFL gardening.

Rebaseline fast/js/global-constructors-attributes.html for EFL port
after r151914. WaveTable was renamed to PeriodicWave.

* platform/efl/fast/js/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuildfix for !ENABLE(SVG) builds.
zarvai@inf.u-szeged.hu [Thu, 27 Jun 2013 10:35:07 +0000 (10:35 +0000)]
Buildfix for !ENABLE(SVG) builds.

Reviewed by Csaba Osztrogonác.

Moving RenderObject::hasAspectRatio() outside from ENABLE(SVG) guard.

* rendering/RenderObject.h:
(WebCore::RenderObject::hasAspectRatio):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdopt is/toHTMLLabelElement for code cleanup
kangil.han@samsung.com [Thu, 27 Jun 2013 10:30:32 +0000 (10:30 +0000)]
Adopt is/toHTMLLabelElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118113

Reviewed by Andreas Kling.

To enhance readability, this patch adopts is/toHTMLLabelElement.
This also helps out to reduce duplicated use of static_cast.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::labelChanged):
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::labelForElement):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::labelElementContainer):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
* dom/DocumentOrderedMap.cpp:
(WebCore::keyMatchesLabelForAttribute):
* dom/Element.cpp:
(WebCore::Element::updateLabel):
* dom/TreeScope.cpp:
(WebCore::TreeScope::labelElementForId):
* html/HTMLLabelElement.h:
(WebCore::isHTMLLabelElement):
(WebCore::toHTMLLabelElement):
* html/LabelsNodeList.cpp:
(WebCore::LabelsNodeList::nodeMatches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[curl] Fix unused variable/parameter warnings
commit-queue@webkit.org [Thu, 27 Jun 2013 10:28:07 +0000 (10:28 +0000)]
[curl] Fix unused variable/parameter warnings
https://bugs.webkit.org/show_bug.cgi?id=118050

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-06-27
Reviewed by Christophe Dumez.

Commented out unused parameters and removed an unused variable in the curl backend.

No tests required.

* platform/network/curl/CredentialStorageCurl.cpp:
(WebCore::CredentialStorage::getFromPersistentStorage):
* platform/network/curl/DNSCurl.cpp:
(WebCore::prefetchDNS):
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::curl_lock_callback):
(WebCore::curl_unlock_callback):
(WebCore::headerCallback):
(WebCore::ResourceHandleManager::downloadTimerCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix cast-align warnings in WebCore/platform/graphics/cairo
ossy@webkit.org [Thu, 27 Jun 2013 10:10:08 +0000 (10:10 +0000)]
Fix cast-align warnings in WebCore/platform/graphics/cairo
https://bugs.webkit.org/show_bug.cgi?id=117990

Reviewed by Rob Buis.

* platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::checkForSolidColor):
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[curl] Add "set-cookie" to appendable headers
commit-queue@webkit.org [Thu, 27 Jun 2013 10:05:14 +0000 (10:05 +0000)]
[curl] Add "set-cookie" to appendable headers
https://bugs.webkit.org/show_bug.cgi?id=118061

Patch by Szabolcs Dávid <davidsz@inf.u-szeged.hu> on 2013-06-27
Reviewed by Christophe Dumez.

Mark set-cookie as an appendable header.

* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::isAppendableHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] [WK2] Check value of WEBKIT_INJECTED_BUNDLE_PATH
commit-queue@webkit.org [Thu, 27 Jun 2013 08:49:15 +0000 (08:49 +0000)]
[GTK] [WK2] Check value of WEBKIT_INJECTED_BUNDLE_PATH
https://bugs.webkit.org/show_bug.cgi?id=118055

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-06-27
Reviewed by Carlos Garcia Campos.

If the directory pointed at by WEBKIT_INJECTED_BUNDLE_PATH does
not exist, fall back to the system directory.

This makes MiniBrowser work outside the build tree.

* UIProcess/API/gtk/WebKitWebContext.cpp:
(injectedBundleDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: Remove ENABLE_CSS_COMPOSITING guards around -webkit-background-blend...
commit-queue@webkit.org [Thu, 27 Jun 2013 07:49:32 +0000 (07:49 +0000)]
Source/WebCore: Remove ENABLE_CSS_COMPOSITING guards around -webkit-background-blend mode related code. The same flag guards -webkit-blend-mode code, but those guards are not touched by this change.

https://bugs.webkit.org/show_bug.cgi?id=117619

Patch by Horia Iosif Olaru <olaru@adobe.com> on 2013-06-27
Reviewed by Dean Jackson.

Test: css3/compositing/effect-background-blend-mode-tiled.html

* WebCore.exp.in:
* bindings/generic/RuntimeEnabledFeatures.h:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillProperty):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

LayoutTests: Add an extra test to check if tiled background images get blended as expected. This test passed before this change. The tests for this change are the existing background-blend-mode tests.

https://bugs.webkit.org/show_bug.cgi?id=117619

Patch by Horia Iosif Olaru <olaru@adobe.com> on 2013-06-27
Reviewed by Dean Jackson.

* css3/compositing/effect-background-blend-mode-tiled-expected.txt: Added.
* css3/compositing/effect-background-blend-mode-tiled.html: Added.
* platform/mac/css3/compositing/effect-background-blend-mode-tiled-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix bindings tests after r152080
ch.dumez@sisa.samsung.com [Thu, 27 Jun 2013 07:28:05 +0000 (07:28 +0000)]
Fix bindings tests after r152080
https://bugs.webkit.org/show_bug.cgi?id=118118

Reviewed by Gyuyoung Kim.

r152080 renamed argument to preprocess-idls.pl from --workerContextConstructorsFile
to --workerGlobalScopeConstructorsFile. This patch updates to bindings test script
accordingly.

* Scripts/webkitpy/bindings/main.py:
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Handle testRunner.setCustomPolicyDelegate()
carlosgc@webkit.org [Thu, 27 Jun 2013 07:00:00 +0000 (07:00 +0000)]
[BlackBerry] Handle testRunner.setCustomPolicyDelegate()
https://bugs.webkit.org/show_bug.cgi?id=117982

Patch by Carlos Garcia Campos <cargarcia@blackberry.com> on 2013-06-26
Reviewed by Rob Buis.

Source/WebKit/blackberry:

Take custom policy into account when deciding the policy for
navigation actions.

Fixes test fast/loader/onload-policy-ignore-for-frame.html.

* Api/DumpRenderTreeClient.h:
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
If custom policy is enabled ignore the navigation action when it's
not permissive.

Tools:

* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::DumpRenderTree): Initialize
m_policyDelegateIsPermissive.
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
Reset m_policyDelegateIsPermissive.
(BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate): Set
m_policyDelegateIsPermissive.
* DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
(BlackBerry::WebKit::DumpRenderTree::policyDelegateEnabled):
Return whether custom policy is enabled.
(BlackBerry::WebKit::DumpRenderTree::policyDelegateIsPermissive):
Return whether custom policy is permissive.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRename WorkerContext to WorkerGlobalScope
ch.dumez@sisa.samsung.com [Thu, 27 Jun 2013 06:21:54 +0000 (06:21 +0000)]
Rename WorkerContext to WorkerGlobalScope
https://bugs.webkit.org/show_bug.cgi?id=118059

Reviewed by Kentaro Hara.

Source/WebCore:

Rename WorkerContext / SharedWorkerContext / DedicatedWorkerContext to
WorkerGlobalScope / SharedWorkerGlobalScope / DedicatedWorkerGlobalScope
to match the latest specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#workerglobalscope

Those interfaces have [NoInterfaceObject] IDL extended attribute so the
name did not matter much so far. However, the specification was updated
and [NoInterfaceObject] was removed. We should therefore rename those
interfaces as a preparation for this change.

No new tests, no behavior change as these interfaces are not exposed to
JavaScript yet.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Modules/filesystem/WorkerGlobalScopeFileSystem.cpp: Renamed from Source/WebCore/Modules/filesystem/WorkerContextFileSystem.cpp.
(WebCore::WorkerGlobalScopeFileSystem::webkitRequestFileSystem):
(WebCore::WorkerGlobalScopeFileSystem::webkitRequestFileSystemSync):
(WebCore::WorkerGlobalScopeFileSystem::webkitResolveLocalFileSystemURL):
(WebCore::WorkerGlobalScopeFileSystem::webkitResolveLocalFileSystemSyncURL):
* Modules/filesystem/WorkerGlobalScopeFileSystem.h: Renamed from Source/WebCore/Modules/filesystem/WorkerContextFileSystem.h.
* Modules/filesystem/WorkerGlobalScopeFileSystem.idl: Renamed from Source/WebCore/Modules/filesystem/WorkerContextFileSystem.idl.
* Modules/indexeddb/IDBFactory.cpp:
* Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp: Renamed from Source/WebCore/Modules/indexeddb/WorkerContextIndexedDatabase.cpp.
(WebCore::WorkerGlobalScopeIndexedDatabase::WorkerGlobalScopeIndexedDatabase):
(WebCore::WorkerGlobalScopeIndexedDatabase::~WorkerGlobalScopeIndexedDatabase):
(WebCore::WorkerGlobalScopeIndexedDatabase::supplementName):
(WebCore::WorkerGlobalScopeIndexedDatabase::from):
(WebCore::WorkerGlobalScopeIndexedDatabase::indexedDB):
* Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.h: Renamed from Source/WebCore/Modules/indexeddb/WorkerContextIndexedDatabase.h.
* Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.idl: Renamed from Source/WebCore/Modules/indexeddb/WorkerContextIndexedDatabase.idl.
* Modules/notifications/Notification.cpp:
* Modules/notifications/NotificationCenter.cpp:
* Modules/notifications/WorkerGlobalScopeNotifications.cpp: Renamed from Source/WebCore/Modules/notifications/WorkerContextNotifications.cpp.
(WebCore::WorkerGlobalScopeNotifications::WorkerGlobalScopeNotifications):
(WebCore::WorkerGlobalScopeNotifications::~WorkerGlobalScopeNotifications):
(WebCore::WorkerGlobalScopeNotifications::supplementName):
(WebCore::WorkerGlobalScopeNotifications::from):
(WebCore::WorkerGlobalScopeNotifications::webkitNotifications):
* Modules/notifications/WorkerGlobalScopeNotifications.h: Renamed from Source/WebCore/Modules/notifications/WorkerContextNotifications.h.
* Modules/notifications/WorkerGlobalScopeNotifications.idl: Renamed from Source/WebCore/Modules/notifications/WorkerContextNotifications.idl.
* Modules/webdatabase/DatabaseContext.cpp:
(WebCore::DatabaseContext::allowDatabaseAccess):
(WebCore::DatabaseContext::databaseExceededQuota):
* Modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp: Renamed from Source/WebCore/Modules/webdatabase/WorkerContextWebDatabase.cpp.
(WebCore::WorkerGlobalScopeWebDatabase::openDatabase):
(WebCore::WorkerGlobalScopeWebDatabase::openDatabaseSync):
* Modules/webdatabase/WorkerGlobalScopeWebDatabase.h: Renamed from Source/WebCore/Modules/webdatabase/WorkerContextWebDatabase.h.
(WebCore::WorkerGlobalScopeWebDatabase::WorkerGlobalScopeWebDatabase):
(WebCore::WorkerGlobalScopeWebDatabase::~WorkerGlobalScopeWebDatabase):
* Modules/webdatabase/WorkerGlobalScopeWebDatabase.idl: Renamed from Source/WebCore/Modules/webdatabase/WorkerContextWebDatabase.idl.
* Modules/websockets/ThreadableWebSocketChannel.cpp:
(WebCore::ThreadableWebSocketChannel::create):
* Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasksCallback):
* Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
(WebCore::workerGlobalScopeDidSend):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::workerGlobalScopeDidGetBufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::bufferedAmount):
(WebCore::workerGlobalScopeDidConnect):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect):
(WebCore::workerGlobalScopeDidReceiveMessage):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessage):
(WebCore::workerGlobalScopeDidReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveBinaryData):
(WebCore::workerGlobalScopeDidUpdateBufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didUpdateBufferedAmount):
(WebCore::workerGlobalScopeDidStartClosingHandshake):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake):
(WebCore::workerGlobalScopeDidClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
(WebCore::workerGlobalScopeDidReceiveMessageError):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessageError):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::create):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::~WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::waitForMethodCompletion):
* Modules/websockets/WorkerThreadableWebSocketChannel.h:
(WebCore::WorkerThreadableWebSocketChannel::create):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::create):
* Target.pri:
* UseJSC.cmake:
* WebCore.order:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/cpp/WebDOMEventTarget.cpp:
(toWebKit):
* bindings/cpp/WebDOMEventTarget.h:
* bindings/generic/ActiveDOMCallback.cpp:
* bindings/js/DOMRequestState.h:
(WebCore::DOMRequestState::DOMRequestState):
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::scriptExecutionContext):
(WebCore::toJSDOMGlobalObject):
* bindings/js/JSDedicatedWorkerGlobalScopeCustom.cpp: Renamed from Source/WebCore/bindings/js/JSDedicatedWorkerContextCustom.cpp.
(WebCore::JSDedicatedWorkerGlobalScope::postMessage):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSEventTargetCustom.cpp:
(WebCore::toJS):
* bindings/js/JSWorkerGlobalScopeBase.cpp: Renamed from Source/WebCore/bindings/js/JSWorkerContextBase.cpp.
(WebCore::JSWorkerGlobalScopeBase::JSWorkerGlobalScopeBase):
(WebCore::JSWorkerGlobalScopeBase::finishCreation):
(WebCore::JSWorkerGlobalScopeBase::destroy):
(WebCore::JSWorkerGlobalScopeBase::scriptExecutionContext):
(WebCore::toJS):
(WebCore::toJSDedicatedWorkerGlobalScope):
(WebCore::toJSSharedWorkerGlobalScope):
(WebCore::toJSWorkerGlobalScope):
* bindings/js/JSWorkerGlobalScopeBase.h: Renamed from Source/WebCore/bindings/js/JSWorkerContextBase.h.
(WebCore::JSWorkerGlobalScopeBase::impl):
(WebCore::JSWorkerGlobalScopeBase::createStructure):
* bindings/js/JSWorkerGlobalScopeCustom.cpp: Renamed from Source/WebCore/bindings/js/JSWorkerContextCustom.cpp.
(WebCore::JSWorkerGlobalScope::visitChildren):
(WebCore::JSWorkerGlobalScope::getOwnPropertySlotDelegate):
(WebCore::JSWorkerGlobalScope::getOwnPropertyDescriptorDelegate):
(WebCore::JSWorkerGlobalScope::importScripts):
(WebCore::JSWorkerGlobalScope::setTimeout):
(WebCore::JSWorkerGlobalScope::setInterval):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
* bindings/js/ScheduledAction.h:
* bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::startForWorkerGlobalScope):
(WebCore::ScriptProfiler::stopForWorkerGlobalScope):
* bindings/js/ScriptProfiler.h:
* bindings/js/ScriptState.cpp:
(WebCore::scriptStateFromWorkerGlobalScope):
* bindings/js/ScriptState.h:
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::~WorkerScriptController):
(WebCore::WorkerScriptController::initScript):
(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::setException):
(WebCore::WorkerScriptController::forbidExecution):
(WebCore::WorkerScriptController::isExecutionForbidden):
(WebCore::WorkerScriptController::disableEval):
(WebCore::WorkerScriptController::attachDebugger):
(WebCore::WorkerScriptController::detachDebugger):
* bindings/js/WorkerScriptController.h:
(WebCore::WorkerScriptController::workerGlobalScopeWrapper):
(WebCore::WorkerScriptController::initScriptIfNeeded):
* bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
(WebCore::WorkerScriptDebugServer::removeListener):
(WebCore::WorkerScriptDebugServer::runEventLoopWhilePaused):
* bindings/js/WorkerScriptDebugServer.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/preprocess-idls.pl:
* dom/ActiveDOMObject.cpp:
* dom/EventTarget.h:
* dom/EventTargetFactory.in:
* dom/MessagePort.cpp:
(WebCore::MessagePort::dispatchMessages):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::createdMessagePort):
(WebCore::ScriptExecutionContext::destroyedMessagePort):
(WebCore::ScriptExecutionContext::vm):
* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::isWorkerGlobalScope):
* inspector/InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::createForWorker):
(WebCore::InjectedScriptManager::canAccessInspectedWorkerGlobalScope):
* inspector/InjectedScriptManager.h:
* inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::addMessageToConsole):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didStartWorkerGlobalScopeImpl):
(WebCore::InspectorInstrumentation::willEvaluateWorkerScript):
(WebCore::InspectorInstrumentation::workerGlobalScopeTerminatedImpl):
(WebCore::InspectorInstrumentation::instrumentingAgentsForWorkerGlobalScope):
(WebCore::InspectorInstrumentation::instrumentingAgentsForNonDocumentContext):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didStartWorkerGlobalScope):
(WebCore::InspectorInstrumentation::workerGlobalScopeTerminated):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::WorkerProfilerAgent::WorkerProfilerAgent):
(WebCore::WorkerProfilerAgent::startProfiling):
(WebCore::WorkerProfilerAgent::stopProfiling):
(WebCore::InspectorProfilerAgent::create):
* inspector/InspectorProfilerAgent.h:
* inspector/InspectorRuntimeAgent.h:
* inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::proxy):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::connectToWorkerGlobalScope):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::disconnectFromWorkerGlobalScope):
(WebCore::InspectorWorkerAgent::connectToWorker):
(WebCore::InspectorWorkerAgent::disconnectFromWorker):
(WebCore::InspectorWorkerAgent::didStartWorkerGlobalScope):
(WebCore::InspectorWorkerAgent::workerGlobalScopeTerminated):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):
* inspector/InspectorWorkerAgent.h:
* inspector/InstrumentingAgents.cpp:
(WebCore::instrumentationForWorkerGlobalScope):
* inspector/InstrumentingAgents.h:
* inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::create):
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::interruptAndDispatchInspectorCommands):
(WebCore::WorkerDebuggerAgent::injectedScriptForEval):
* inspector/WorkerDebuggerAgent.h:
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
* inspector/WorkerInspectorController.h:
* inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
(WebCore::WorkerRuntimeAgent::injectedScriptForEval):
(WebCore::WorkerRuntimeAgent::pauseWorkerGlobalScope):
* inspector/WorkerRuntimeAgent.h:
(WebCore::WorkerRuntimeAgent::create):
* loader/ThreadableLoader.cpp:
(WebCore::ThreadableLoader::create):
(WebCore::ThreadableLoader::loadResourceSynchronously):
* loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
(WebCore::WorkerThreadableLoader::loadResourceSynchronously):
(WebCore::workerGlobalScopeDidSendData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
(WebCore::workerGlobalScopeDidReceiveResponse):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
(WebCore::workerGlobalScopeDidReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
(WebCore::workerGlobalScopeDidFinishLoading):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
(WebCore::workerGlobalScopeDidFail):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
(WebCore::workerGlobalScopeDidFailAccessControlCheck):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFailAccessControlCheck):
(WebCore::workerGlobalScopeDidFailRedirectCheck):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
* loader/WorkerThreadableLoader.h:
(WebCore::WorkerThreadableLoader::create):
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::removeRequestFromCache):
* platform/blackberry/LocalFileSystemBlackBerry.cpp:
(WebCore::openFileSystem):
(WebCore::LocalFileSystem::deleteFileSystem):
* platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp:
(WebCore::WorkerAsyncFileSystemBlackBerry::WorkerAsyncFileSystemBlackBerry):
(WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystem):
(WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystem):
* platform/blackberry/WorkerAsyncFileSystemBlackBerry.h:
(WebCore::WorkerAsyncFileSystemBlackBerry::create):
* platform/blackberry/WorkerAsyncFileWriterBlackBerry.h:
* platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.cpp:
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::postTaskToWorkerThread):
* platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.h:
* platform/blackberry/WorkerPlatformFileWriterClient.cpp:
(WebCore::WorkerPlatformFileWriterClient::postTaskToWorkerThreadIfNeeded):
* platform/blackberry/WorkerPlatformFileWriterClient.h:
* workers/DedicatedWorkerGlobalScope.cpp: Renamed from Source/WebCore/workers/DedicatedWorkerContext.cpp.
(WebCore::DedicatedWorkerGlobalScope::create):
(WebCore::DedicatedWorkerGlobalScope::DedicatedWorkerGlobalScope):
(WebCore::DedicatedWorkerGlobalScope::~DedicatedWorkerGlobalScope):
(WebCore::DedicatedWorkerGlobalScope::interfaceName):
(WebCore::DedicatedWorkerGlobalScope::postMessage):
(WebCore::DedicatedWorkerGlobalScope::importScripts):
(WebCore::DedicatedWorkerGlobalScope::thread):
* workers/DedicatedWorkerGlobalScope.h: Renamed from Source/WebCore/workers/DedicatedWorkerContext.h.
* workers/DedicatedWorkerGlobalScope.idl: Renamed from Source/WebCore/workers/DedicatedWorkerContext.idl.
* workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope):
(WebCore::DedicatedWorkerThread::runEventLoop):
* workers/DedicatedWorkerThread.h:
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::SharedWorkerProxy::workerGlobalScopeClosed):
(WebCore::SharedWorkerProxy::workerGlobalScopeDestroyed):
(WebCore::SharedWorkerConnectTask::performTask):
(WebCore::SharedWorkerScriptLoader::notifyFinished):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
* workers/SharedWorkerGlobalScope.cpp: Renamed from Source/WebCore/workers/SharedWorkerContext.cpp.
(WebCore::createConnectEvent):
(WebCore::SharedWorkerGlobalScope::create):
(WebCore::SharedWorkerGlobalScope::SharedWorkerGlobalScope):
(WebCore::SharedWorkerGlobalScope::~SharedWorkerGlobalScope):
(WebCore::SharedWorkerGlobalScope::interfaceName):
(WebCore::SharedWorkerGlobalScope::thread):
(WebCore::SharedWorkerGlobalScope::logExceptionToConsole):
* workers/SharedWorkerGlobalScope.h: Renamed from Source/WebCore/workers/SharedWorkerContext.h.
(WebCore::SharedWorkerGlobalScope::name):
* workers/SharedWorkerGlobalScope.idl: Renamed from Source/WebCore/workers/SharedWorkerContext.idl.
* workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::createWorkerGlobalScope):
* workers/SharedWorkerThread.h:
* workers/Worker.cpp:
(WebCore::Worker::Worker):
(WebCore::Worker::postMessage):
(WebCore::Worker::terminate):
(WebCore::Worker::notifyFinished):
* workers/Worker.h:
* workers/WorkerGlobalScope.cpp: Renamed from Source/WebCore/workers/WorkerContext.cpp.
(WebCore::CloseWorkerGlobalScopeTask::create):
(WebCore::CloseWorkerGlobalScopeTask::performTask):
(WebCore::CloseWorkerGlobalScopeTask::isCleanupTask):
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
(WebCore::WorkerGlobalScope::~WorkerGlobalScope):
(WebCore::WorkerGlobalScope::applyContentSecurityPolicyFromString):
(WebCore::WorkerGlobalScope::scriptExecutionContext):
(WebCore::WorkerGlobalScope::virtualURL):
(WebCore::WorkerGlobalScope::virtualCompleteURL):
(WebCore::WorkerGlobalScope::completeURL):
(WebCore::WorkerGlobalScope::userAgent):
(WebCore::WorkerGlobalScope::disableEval):
(WebCore::WorkerGlobalScope::location):
(WebCore::WorkerGlobalScope::close):
(WebCore::WorkerGlobalScope::navigator):
(WebCore::WorkerGlobalScope::hasPendingActivity):
(WebCore::WorkerGlobalScope::postTask):
(WebCore::WorkerGlobalScope::setTimeout):
(WebCore::WorkerGlobalScope::clearTimeout):
(WebCore::WorkerGlobalScope::clearInspector):
(WebCore::WorkerGlobalScope::setInterval):
(WebCore::WorkerGlobalScope::clearInterval):
(WebCore::WorkerGlobalScope::importScripts):
(WebCore::WorkerGlobalScope::errorEventTarget):
(WebCore::WorkerGlobalScope::logExceptionToConsole):
(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessage):
(WebCore::WorkerGlobalScope::addMessageToWorkerConsole):
(WebCore::WorkerGlobalScope::isContextThread):
(WebCore::WorkerGlobalScope::isJSExecutionForbidden):
(WebCore::WorkerGlobalScope::eventTargetData):
(WebCore::WorkerGlobalScope::ensureEventTargetData):
(WebCore::WorkerGlobalScope::Observer::Observer):
(WebCore::WorkerGlobalScope::Observer::~Observer):
(WebCore::WorkerGlobalScope::Observer::stopObserving):
(WebCore::WorkerGlobalScope::registerObserver):
(WebCore::WorkerGlobalScope::unregisterObserver):
(WebCore::WorkerGlobalScope::notifyObserversOfStop):
(WebCore::WorkerGlobalScope::eventQueue):
* workers/WorkerGlobalScope.h: Renamed from Source/WebCore/workers/WorkerContext.h.
(WebCore::WorkerGlobalScope::isSharedWorkerGlobalScope):
(WebCore::WorkerGlobalScope::isDedicatedWorkerGlobalScope):
(WebCore::WorkerGlobalScope::url):
(WebCore::WorkerGlobalScope::groupSettings):
(WebCore::WorkerGlobalScope::script):
(WebCore::WorkerGlobalScope::clearScript):
(WebCore::WorkerGlobalScope::thread):
(WebCore::WorkerGlobalScope::self):
(WebCore::WorkerGlobalScope::workerInspectorController):
(WebCore::WorkerGlobalScope::optionalNavigator):
(WebCore::WorkerGlobalScope::optionalLocation):
(WebCore::WorkerGlobalScope::isClosing):
* workers/WorkerGlobalScope.idl: Renamed from Source/WebCore/workers/WorkerContext.idl.
* workers/WorkerGlobalScopeProxy.h: Renamed from Source/WebCore/workers/WorkerContextProxy.h.
(WebCore::WorkerGlobalScopeProxy::~WorkerGlobalScopeProxy):
(WebCore::WorkerGlobalScopeProxy::PageInspector::~PageInspector):
(WebCore::WorkerGlobalScopeProxy::connectToInspector):
(WebCore::WorkerGlobalScopeProxy::disconnectFromInspector):
(WebCore::WorkerGlobalScopeProxy::sendMessageToInspector):
* workers/WorkerLoaderProxy.h:
* workers/WorkerMessagingProxy.cpp:
(WebCore::MessageWorkerGlobalScopeTask::create):
(WebCore::MessageWorkerGlobalScopeTask::MessageWorkerGlobalScopeTask):
(WebCore::MessageWorkerGlobalScopeTask::performTask):
(WebCore::WorkerGlobalScopeDestroyedTask::create):
(WebCore::WorkerGlobalScopeDestroyedTask::WorkerGlobalScopeDestroyedTask):
(WebCore::WorkerGlobalScopeDestroyedTask::performTask):
(WebCore::WorkerTerminateTask::performTask):
(WebCore::PostMessageToPageInspectorTask::performTask):
(WebCore::WorkerGlobalScopeProxy::create):
(WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::~WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::workerObjectDestroyedInternal):
(WebCore::connectToWorkerGlobalScopeInspectorTask):
(WebCore::WorkerMessagingProxy::connectToInspector):
(WebCore::disconnectFromWorkerGlobalScopeInspectorTask):
(WebCore::WorkerMessagingProxy::disconnectFromInspector):
(WebCore::dispatchOnInspectorBackendTask):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeClosed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyedInternal):
(WebCore::WorkerMessagingProxy::terminateWorkerGlobalScope):
* workers/WorkerMessagingProxy.h:
* workers/WorkerObjectProxy.h:
* workers/WorkerReportingProxy.h:
* workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::run):
(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::runCleanupTasks):
(WebCore::WorkerRunLoop::Task::performTask):
* workers/WorkerRunLoop.h:
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadSynchronously):
* workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::runEventLoop):
(WebCore::WorkerThreadShutdownFinishTask::performTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):
(WebCore::WorkerThread::stop):
* workers/WorkerThread.h:
(WebCore::WorkerThread::workerGlobalScope):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::usesDashboardBackwardCompatibilityMode):
(WebCore::XMLHttpRequest::responseXML):

Source/WebKit/qt:

Update calls to ScriptExecutionContext::isWorkerContext() as it was
renamed to ScriptExecutionContext::isWorkerGlobalScope().

* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::show):
(WebCore::NotificationPresenterClientQt::toPage):
(WebCore::NotificationPresenterClientQt::toFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed WinCE build fix after r152065.
paroga@webkit.org [Thu, 27 Jun 2013 06:15:39 +0000 (06:15 +0000)]
Unreviewed WinCE build fix after r152065.

* WebCoreSupport/ChromeClientWinCE.cpp:
(WebKit::ChromeClientWinCE::AXStartFrameLoad):
(WebKit::ChromeClientWinCE::AXFinishFrameLoad):
* WebCoreSupport/ChromeClientWinCE.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid redundant checks for Compositing reasons in RenderLayerCompositor
commit-queue@webkit.org [Thu, 27 Jun 2013 06:02:51 +0000 (06:02 +0000)]
Avoid redundant checks for Compositing reasons in RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=118114

Patch by Sanjoy Pal <sanjoy.pal@samsung.com> on 2013-06-26
Reviewed by Anders Carlsson.

A RenderObject can be any one of the Video, Canvas, Plugin or Iframe.
Hence removing the redundant checks.

No new tests as no functionality change.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::reasonsForCompositing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152078 268f45cc-cd09-0410-ab3c-d52691b4dbfc