WebKit-https.git
11 years ago2009-02-25 Scott Violet <sky@google.com>
dglazkov@chromium.org [Wed, 25 Feb 2009 23:52:29 +0000 (23:52 +0000)]
2009-02-25  Scott Violet  <sky@google.com>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=24171
        Provides a RenderTheme method for getting the scroll bar size and
        changes RenderListBox to use it. RenderTheme returns a size of regular,
        and Mac's override to return small. Changes ScrollbarThemeChromium to
        use the scrollbarsize of the scrollbar when getting the size
        instead of passing in no-args.

        * platform/chromium/ScrollbarThemeChromium.cpp:
        (WebCore::ScrollbarThemeChromium::trackRect):
        (WebCore::ScrollbarThemeChromium::buttonSize):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::createScrollbar):
        * rendering/RenderTheme.h:
        (WebCore::RenderTheme::scrollbarControlSizeForPart):
        * rendering/RenderThemeChromiumMac.h:
        (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart):
        * rendering/RenderThemeMac.h:
        (WebCore::RenderThemeMac::scrollbarControlSizeForPart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
ggaren@apple.com [Wed, 25 Feb 2009 23:44:07 +0000 (23:44 +0000)]
JavaScriptCore:

2009-02-25  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Maciej Stachowiak.

        Fixed <rdar://problem/6611174> REGRESSION (r36701): Unable to select
        messages on hotmail (24052)

        The bug was that for-in enumeration used a cached prototype chain without
        validating that it was up-to-date.

        This led me to refactor prototype chain caching so it was easier to work
        with and harder to get wrong.

        After a bit of inlining, this patch is performance-neutral on SunSpider
        and the v8 benchmarks.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::tryCachePutByID):
        (JSC::Interpreter::tryCacheGetByID):
        * jit/JITStubs.cpp:
        (JSC::JITStubs::tryCachePutByID):
        (JSC::JITStubs::tryCacheGetByID):
        (JSC::JITStubs::cti_op_get_by_id_proto_list): Use the new refactored goodness. See
        lines beginning with "-" and smile.

        * runtime/JSGlobalObject.h:
        (JSC::Structure::prototypeForLookup): A shout out to const.

        * runtime/JSPropertyNameIterator.h:
        (JSC::JSPropertyNameIterator::next): We can use a pointer comparison to
        see if our cached structure chain is equal to the object's structure chain,
        since in the case of a cache hit, we share references to the same structure
        chain.

        * runtime/Operations.h:
        (JSC::countPrototypeChainEntriesAndCheckForProxies): Use the new refactored
        goodness.

        * runtime/PropertyNameArray.h:
        (JSC::PropertyNameArray::PropertyNameArray):
        (JSC::PropertyNameArray::setShouldCache):
        (JSC::PropertyNameArray::shouldCache): Renamed "cacheable" to "shouldCache"
        to communicate that the client is specifying a recommendation, not a
        capability.

        * runtime/Structure.cpp:
        (JSC::Structure::Structure): No need to initialize a RefPtr.
        (JSC::Structure::getEnumerablePropertyNames): Moved some code into helper
        functions.

        (JSC::Structure::prototypeChain): New centralized accessor for a prototype
        chain. Revalidates on every access, since the objects in the prototype
        chain may have mutated.

        (JSC::Structure::isValid): Helper function for revalidating a cached
        prototype chain.

        (JSC::Structure::getEnumerableNamesFromPropertyTable):
        (JSC::Structure::getEnumerableNamesFromClassInfoTable): Factored out of
        getEnumerablePropertyNames.

        * runtime/Structure.h:

        * runtime/StructureChain.cpp:
        (JSC::StructureChain::StructureChain):
        * runtime/StructureChain.h:
        (JSC::StructureChain::create): No need for structureChainsAreEqual, since
        we use pointer equality now. Refactored StructureChain to make a little
        more sense and eliminate special cases for null prototypes.

LayoutTests:

2009-02-24  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Maciej Stachowiak.

        Added a test for <rdar://problem/6611174> REGRESSION (r36701): Unable to
        select messages on hotmail (24052)

        * fast/js/for-in-cached-expected.txt: Added.
        * fast/js/for-in-cached.html: Added.
        * fast/js/resources/for-in-cached.js: Added.
        (forIn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
bdakin@apple.com [Wed, 25 Feb 2009 22:58:33 +0000 (22:58 +0000)]
WebCore:

2009-02-25  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler.

        Fix for <rdar://problem/6487249> repro crash in
        WebCore::CSSParser::parseFillImage copying entire contents of this
        page
        -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue): Null-check m_styleSheet

LayoutTests:

2009-02-25  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler.

        Test for <rdar://problem/6487249> repro crash in
        WebCore::CSSParser::parseFillImage copying entire contents of this
        page
        -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172

        * editing/pasteboard/copy-crash-with-extraneous-attribute-expected.txt: Added.
        * editing/pasteboard/copy-crash-with-extraneous-attribute.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Wed, 25 Feb 2009 21:37:33 +0000 (21:37 +0000)]
2009-02-25  Adam Treat  <adam.treat@torchmobile.com>

        Fix the Qt build.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 25 Feb 2009 20:59:18 +0000 (20:59 +0000)]
2009-02-25  Simon Fraser  <simon.fraser@apple.com>

        Build fix with ACCELERATED_COMPOSITING turned on.

        I missed a spot in my last commit in renaming to
        _stoppedAcceleratedCompositingForFrame:

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView close]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Wed, 25 Feb 2009 20:45:17 +0000 (20:45 +0000)]
2009-02-25  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Alexey Proskuryakov.

        Do not queue the calls to 'DumpRenderTree::dump()' as this can result
        in more than one call as a test that calls 'notifyDone()' can then be
        subsequently fully loaded and initiate a second dump.  Also make sure
        to stop any existing page load that is happening before running the next
        test.  Combined this serves to produce 217 more passing tests for the
        Qt port or roughly 5% at this point.

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::DumpRenderTree):
        (WebCore::DumpRenderTree::open):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 25 Feb 2009 20:39:59 +0000 (20:39 +0000)]
2009-02-25  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix. Not reviewed.

        Add files to the build per r41218.
        Rename WebkitPoint.h to WebKitPoint.h in DOMWindow.cpp

        * GNUmakefile.am:
        * page/DOMWindow.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Zan Dobersek <zandobersek@gmail.com>
kov@webkit.org [Wed, 25 Feb 2009 20:29:45 +0000 (20:29 +0000)]
2009-02-25  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24043
        When faced with URLs with unsupported protocol on Gtk port,
        report the error through an idle function and return true, so
        a proper resource handle is created.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::reportUnknownProtocolError):
        (WebCore::ResourceHandle::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fix.
sfalken@apple.com [Wed, 25 Feb 2009 20:22:34 +0000 (20:22 +0000)]
    Windows build fix.
        Use struct to forward declare ResourceRequest.

        * history/HistoryItem.h:
        * inspector/InspectorController.h:
        * loader/DocumentThreadableLoader.h:
        * loader/FrameLoaderClient.h:
        * loader/MainResourceLoader.h:
        * loader/SubresourceLoader.h:
        * loader/SubresourceLoaderClient.h:
        * loader/ThreadableLoader.h:
        * loader/WorkerThreadableLoader.h:
        * platform/CrossThreadCopier.h:
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleClient.h:
        * platform/network/ResourceRequestBase.h:
        * platform/network/cf/ResourceRequestCFNet.h:
        * xml/XMLHttpRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 25 Feb 2009 20:12:24 +0000 (20:12 +0000)]
2009-02-25  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=23854

        Make an observable property, _isUsingAcceleratedCompositing, on
        WebView that DumpRenderTree can use to specialize behavior.

        This is implemented via a count of Frames that are using
        accelerated compositing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Andreia Gaita <shana@jitted.com>
alp@webkit.org [Wed, 25 Feb 2009 19:56:20 +0000 (19:56 +0000)]
2009-02-25  Andreia Gaita  <shana@jitted.com>

        Reviewed by Alp Toker.

        Update Win def files with recent JavaScriptCore API additions.

        * WebKit.vcproj/WebKit.def:
        * WebKit.vcproj/WebKit_Cairo.def:
        * WebKit.vcproj/WebKit_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Partial Windows build fix.
sfalken@apple.com [Wed, 25 Feb 2009 19:50:12 +0000 (19:50 +0000)]
    Partial Windows build fix.

        * DerivedSources.cpp:
        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 25 Feb 2009 19:43:00 +0000 (19:43 +0000)]
2009-02-25  Dirk Schulze  <krit@webkit.org>

        Reviewed by Oliver Hunt.

        Ported arcTo to Qt. Qt has no native support for arcTo. This changes
        calculate the behavior of arcTo and draws it with lineTo and arc.

        [QT] implement Canvas arcTo
        https://bugs.webkit.org/show_bug.cgi?id=23873

        * platform/graphics/qt/PathQt.cpp:
        (WebCore::Path::addArcTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 25 Feb 2009 19:29:00 +0000 (19:29 +0000)]
2009-02-25  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        Remove idl files from Resources, and sort.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Use timeBeginPeriod to enable timing resolution greater than 16ms in command...
sfalken@apple.com [Wed, 25 Feb 2009 19:11:39 +0000 (19:11 +0000)]
    Use timeBeginPeriod to enable timing resolution greater than 16ms in command line jsc for Windows.
        Allows more accurate reporting of benchmark times via command line jsc.exe. Doesn't affect WebKit's use of JavaScriptCore.

        Reviewed by Adam Roben.

        * jsc.cpp:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
cmarrin@apple.com [Wed, 25 Feb 2009 19:09:37 +0000 (19:09 +0000)]
    Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=23943

        Added webkitConvertPointFromNodeToPage and webkitConvertPointFromPageToNode on
        the window object. Also added WebKitPoint object, which is passed in and out
        of these functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Jian Li <jianli@chromium.org>
levin@chromium.org [Wed, 25 Feb 2009 18:06:47 +0000 (18:06 +0000)]
2009-02-25  Jian Li  <jianli@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Remove "#if ENABLE(WORKERS)" wrap from CrossThreadCopier files.
        https://bugs.webkit.org/show_bug.cgi?id=24145

        * platform/CrossThreadCopier.cpp:
        * platform/CrossThreadCopier.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 25 Feb 2009 18:06:35 +0000 (18:06 +0000)]
2009-02-25  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 23688: ThreadableLoader needs a sync implementation for Workers.
        <https://bugs.webkit.org/show_bug.cgi?id=23688>

        No observable change in behavior, so no test.

        * loader/ThreadableLoader.cpp:
        (WebCore::ThreadableLoader::loadResourceSynchronously):
        * loader/ThreadableLoaderClientWrapper.h:
        (WebCore::ThreadableLoaderClientWrapper::clearClient):
        (WebCore::ThreadableLoaderClientWrapper::done):
        (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
        (WebCore::ThreadableLoaderClientWrapper::didFail):
        (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
        (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
        Expose whether the loader is done (based on what callbacks were done).

        * loader/WorkerThreadableLoader.cpp:
        (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
        (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
        Each loader is given its own mode so that only its callbacks get through the run loop.

        The xhr spec says that the readystatechange events are synchronous, so in the case of a
        nested sync xhr no readystatechange events should be fired for the outer xhr.

        (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):

        * loader/WorkerThreadableLoader.h:
        (WebCore::WorkerThreadableLoader::create):
        (WebCore::WorkerThreadableLoader::done):

        * workers/WorkerRunLoop.cpp:
        (WebCore::WorkerRunLoop::WorkerRunLoop):
        * workers/WorkerRunLoop.h:
        (WebCore::WorkerRunLoop::createUniqueId):
        Simple method to create a uniqueId on demand with respect to the run loop.

        * workers/WorkerThread.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
levin@chromium.org [Wed, 25 Feb 2009 18:06:20 +0000 (18:06 +0000)]
WebCore:

2009-02-25  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code.
        <https://bugs.webkit.org/show_bug.cgi?id=24089>

        Make threadable loader callbacks to happen during the sync load call.

        Changes the behavior of sync xhr for insecure redirects in two ways:
        + Sends an error event instead of an abort event (which is the same as async xhr's behavior).
        + Throws a network exception which is what other browsers do and what the spec
        says to do (http://www.w3.org/TR/XMLHttpRequest/).

        * loader/DocumentThreadableLoader.cpp:
        (WebCore::DocumentThreadableLoader::loadResourceSynchronously):
        * loader/DocumentThreadableLoader.h:
        * loader/ThreadableLoader.cpp:
        (WebCore::ThreadableLoader::loadResourceSynchronously):
        * loader/ThreadableLoader.h:
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::XMLHttpRequest):
        (WebCore::XMLHttpRequest::loadRequestSynchronously):
        (WebCore::XMLHttpRequest::loadRequestAsynchronously):
        (WebCore::XMLHttpRequest::didFail):
        (WebCore::XMLHttpRequest::didFailRedirectCheck):
        * xml/XMLHttpRequest.h:

LayoutTests:

2009-02-25  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code.
        <https://bugs.webkit.org/show_bug.cgi?id=24089>

        Modified the test to account for behavior change and output more information to better detect
        future changes in behavior.

        * http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt:
        * http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by David Hyatt.
cmarrin@apple.com [Wed, 25 Feb 2009 17:55:44 +0000 (17:55 +0000)]
    Reviewed by David Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=23368

        Added logic to correctly hit test accelerated layers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Wed, 25 Feb 2009 17:01:02 +0000 (17:01 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24067
        REGRESSION: Crash in WebCore::Document::initSecurityContext

        The crash started to happen when we removed a check for frame->document() being null.
        However, the original document shouldn't be null here, because it is needed to alias
        security origins. So, this patch fixes the crash by correcting security origin behavior.

        Test: http/tests/security/aboutBlank/window-open-self-about-blank.html
        This tests for not crashing, and for inheriting the domain from the document being replaced.
        Preserving the aliasing cannot be tested for automatically, because we'd need a non-trivial
        domain to remove a prefix from.

        * loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a new document before
        clearing the frame, so that Document::initSecurityContext() could access the old one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Jay Campan <jcampan@google.com>
darin@chromium.org [Wed, 25 Feb 2009 16:58:35 +0000 (16:58 +0000)]
2009-02-25  Jay Campan  <jcampan@google.com>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24066

        Items in drop-downs were not painted correctly.  Makes sure the
        PopupListBox invalidates in the coordinates of the window as this is
        FramelessScrollView::invalidateRect paints to.

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::invalidateRow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Wed, 25 Feb 2009 14:12:19 +0000 (14:12 +0000)]
2009-02-25  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Zack Rusin.

        https://bugs.webkit.org/show_bug.cgi?id=24158
        Implement the queue*() methods of the layoutTestController and begin
        implementing the dump of the back/forward list.  This results in 2% more
        tests passing as well as 23 currently skipped tests now passing.

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::dumpBackForwardList):
        (WebCore::DumpRenderTree::dump):
        * DumpRenderTree/qt/DumpRenderTree.h:
        * DumpRenderTree/qt/DumpRenderTree.pro:
        * DumpRenderTree/qt/jsobjects.cpp:
        (findFrameNamed):
        (LoadItem::invoke):
        (ReloadItem::invoke):
        (ScriptItem::invoke):
        (BackForwardItem::invoke):
        (LayoutTestController::reset):
        (LayoutTestController::processWork):
        (LayoutTestController::maybeDump):
        (LayoutTestController::queueBackNavigation):
        (LayoutTestController::queueForwardNavigation):
        (LayoutTestController::queueLoad):
        (LayoutTestController::queueReload):
        (LayoutTestController::queueScript):
        * DumpRenderTree/qt/jsobjects.h:
        (LayoutTestController::shouldDumpBackForwardList):
        (LayoutTestController::dumpBackForwardList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-25 Kavindra Palaraja <kavindra.palaraja@nokia.com>
hausmann@webkit.org [Wed, 25 Feb 2009 12:12:07 +0000 (12:12 +0000)]
2009-02-25  Kavindra Palaraja  <kavindra.palaraja@nokia.com>

        Reviewed by Simon Hausmann.

        Fix the documentation for the linkHovered signal.

        * Api/qwebpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 25 Feb 2009 06:18:17 +0000 (06:18 +0000)]
2009-02-24  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson

        https://bugs.webkit.org/show_bug.cgi?id=15081

        Make display:none work for applet, emebed and object elements
        by calling rendererIsNeeded() on superclasses.

        Tests: fast/replaced/applet-display-none.html
               fast/replaced/embed-display-none.html
               fast/replaced/object-display-none.html

        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::rendererIsNeeded):
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::rendererIsNeeded):
        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::rendererIsNeeded):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::rendererIsNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 25 Feb 2009 02:50:28 +0000 (02:50 +0000)]
2009-02-24  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24137

        Fix localToAbsolute() and absoluteToLocal() to map points through 3d transforms,
        taking perspective and transform-style: preserve-3d into account.

        In order to support transform-style: preserve-3d, which keeps elements in a
        3d space, we have to carry along an accumulated matrix in TransformState.
        We also need to apply the perspective from the parent, if any, with the
        appropriate origin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Wed, 25 Feb 2009 02:38:21 +0000 (02:38 +0000)]
WebCore:

2009-02-24  Sam Weinig  <sam@webkit.org>

        Reviewed by David Hyatt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23990
        Regression (r40837): JavaScript image popup doesn't work

        Make the getClientRects and getBoundingClientRect methods return rects
        relative to the viewport.

        Test: fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html

        * dom/Element.cpp:
        (WebCore::Element::getClientRects):
        (WebCore::Element::getBoundingClientRect):

LayoutTests:

2009-02-24  Sam Weinig  <sam@webkit.org>

        Reviewed by David Hyatt.

        Test for https://bugs.webkit.org/show_bug.cgi?id=23990
        Regression (r40837): JavaScript image popup doesn't work

        * fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Added.
        * fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Ojan Vafai <ojan@chromium.org>
eric@webkit.org [Wed, 25 Feb 2009 01:46:27 +0000 (01:46 +0000)]
2009-02-24  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        SVG pages don't have a body or an html element!
        Don't return early if there is no body.

        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::canonicalPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate some layout test results from my previous checkin.
hyatt@apple.com [Wed, 25 Feb 2009 01:34:30 +0000 (01:34 +0000)]
Update some layout test results from my previous checkin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate some layout test results from my previous checkin.
hyatt@apple.com [Wed, 25 Feb 2009 01:33:27 +0000 (01:33 +0000)]
Update some layout test results from my previous checkin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Wed, 25 Feb 2009 01:21:03 +0000 (01:21 +0000)]
WebCore:

2009-02-23  David Hyatt  <hyatt@apple.com>

        Reviewed by Eric Seidel

        https://bugs.webkit.org/show_bug.cgi?id=23740, painting order wrong for normal flow elements with overflow: hidden

        This patch reworks the painting of overflow.  There is now the concept of a "self-painting layer."  All
        layers are considered to be self-painting except for overflow layers that are normal flow (and that don't have
        reflections or masks).

        If an overflow layer is not self-painting, then it ends up painted by its parent just like any other normal flow object.
        The only difference is that the clip has to be pushed and popped when painting the object's children.

        The lightweight clipping scheme used for controls has been extended to cover overflow now in this simplified case.  With
        the code consolidated into reusable push/pop functions, all of the renderers that use overflow have been patched to
        use the new functions.

        Hit testing has also been patched to check the overflow clip rect first before recurring into children.

        Scrollbar paint has been moved into RenderBlock for now, since none of the table objects support scrollbars
        yet, and scrollbar hit testing was already there anyway.  Now the two code paths are more symmetrical.

        Masks are now treated like normal flow layers (just like reflections).

        A couple of test cases have been added to fast/overflow to test the stacking order.

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::nodeAtPoint):
        (WebCore::InlineFlowBox::paint):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::repaintOverhangingFloats):
        (WebCore::RenderBlock::paint):
        (WebCore::RenderBlock::paintChildren):
        (WebCore::RenderBlock::paintObject):
        (WebCore::RenderBlock::paintFloats):
        (WebCore::RenderBlock::insertFloatingObject):
        (WebCore::RenderBlock::floatRect):
        (WebCore::RenderBlock::lowestPosition):
        (WebCore::RenderBlock::rightmostPosition):
        (WebCore::RenderBlock::leftmostPosition):
        (WebCore::RenderBlock::addOverhangingFloats):
        (WebCore::RenderBlock::nodeAtPoint):
        (WebCore::RenderBlock::hitTestContents):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::nodeAtPoint):
        (WebCore::RenderBox::pushContentsClip):
        (WebCore::RenderBox::popContentsClip):
        * rendering/RenderBox.h:
        (WebCore::RenderBox::paintObject):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::hasSelfPaintingLayer):
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::hitTestLayer):
        (WebCore::RenderLayer::shouldBeNormalFlowOnly):
        (WebCore::RenderLayer::isSelfPaintingLayer):
        * rendering/RenderLayer.h:
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paint):
        (WebCore::RenderTable::paintObject):
        (WebCore::RenderTable::nodeAtPoint):
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paint):
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::nodeAtPoint):
        (WebCore::RenderTableRow::paint):
        * rendering/RenderTableRow.h:
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::paint):
        (WebCore::RenderTableSection::paintObject):
        (WebCore::RenderTableSection::nodeAtPoint):
        * rendering/RenderTableSection.h:
        * rendering/RenderTreeAsText.cpp:
        (WebCore::write):
        (WebCore::writeLayers):

LayoutTests:

2009-02-24  David Hyatt  <hyatt@apple.com>

        Reviewed by Eric Seidel

        https://bugs.webkit.org/show_bug.cgi?id=23740, painting order wrong for normal flow elements with overflow: hidden

        This patch reworks the painting of overflow.  There is now the concept of a "self-painting layer."  All
        layers are considered to be self-painting except for overflow layers that are normal flow (and that don't have
        reflections or masks).

        If an overflow layer is not self-painting, then it ends up painted by its parent just like any other normal flow object.
        The only difference is that the clip has to be pushed and popped when painting the object's children.

        The lightweight clipping scheme used for controls has been extended to cover overflow now in this simplified case.  With
        the code consolidated into reusable push/pop functions, all of the renderers that use overflow have been patched to
        use the new functions.

        Hit testing has also been patched to check the overflow clip rect first before recurring into children.

        Scrollbar paint has been moved into RenderBlock for now, since none of the table objects support scrollbars
        yet, and scrollbar hit testing was already there anyway.  Now the two code paths are more symmetrical.

        Masks are now treated like normal flow layers (just like reflections).

        A couple of test cases have been added to fast/overflow to test the stacking order.

        * fast/overflow/overflow-float-stacking.html: Added.
        * fast/overflow/overflow-stacking.html: Added.
        * platform/mac/fast/overflow/overflow-float-stacking-expected.checksum: Added.
        * platform/mac/fast/overflow/overflow-float-stacking-expected.png: Added.
        * platform/mac/fast/overflow/overflow-float-stacking-expected.txt: Added.
        * platform/mac/fast/overflow/overflow-stacking-expected.checksum: Added.
        * platform/mac/fast/overflow/overflow-stacking-expected.png: Added.
        * platform/mac/fast/overflow/overflow-stacking-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 25 Feb 2009 01:05:03 +0000 (01:05 +0000)]
2009-02-24  David Levin  <levin@chromium.org>

        Reviewed by NOBODY (build fix).

        Attempted build fix for wx-mac.

        * WebCoreSources.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 25 Feb 2009 00:54:19 +0000 (00:54 +0000)]
2009-02-24  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel

        https://bugs.webkit.org/show_bug.cgi?id=24135

        Update the expected value after testcase change.

        * fast/events/offsetX-offsetY-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 25 Feb 2009 00:46:51 +0000 (00:46 +0000)]
2009-02-24  David Levin  <levin@chromium.org>

        Reviewed by NOBODY (build fix).

        Attempted build fixes for qt-linux and wx-mac.

        * WebCore.pro:
        * webcore-base.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Ojan Vafai <ojan@chromium.org>
weinig@apple.com [Wed, 25 Feb 2009 00:32:31 +0000 (00:32 +0000)]
2009-02-24  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Sam Weinig

        Fix null pointer error. If the node is the Document, then ownerDocument()
        returns null, document() does not.

        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::canonicalPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Jian Li <jianli@chromium.org>
levin@chromium.org [Wed, 25 Feb 2009 00:20:26 +0000 (00:20 +0000)]
2009-02-24  Jian Li  <jianli@chromium.org>

        Reviewed by NOBODY (attempted build fixes).

        Fix build break for Windows and Linux.

        * GNUmakefile.am:
        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 25 Feb 2009 00:18:06 +0000 (00:18 +0000)]
2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24131
        Fix-up COM/RefCounted dichotomy in Chromium port.

        * page/chromium/AccessibilityObjectWrapper.h:
        (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Added
        explicit setting of recount.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 25 Feb 2009 00:13:30 +0000 (00:13 +0000)]
2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24141
        Add clarity to V8 interceptor helper function.

        * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
        (WebCore::NAMED_PROPERTY_GETTER): Renamed to notHandledByInterceptor.
        (WebCore::NAMED_PROPERTY_SETTER): Ditto.
        (WebCore::INDEXED_PROPERTY_GETTER): Ditto.
        (WebCore::INDEXED_PROPERTY_SETTER): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 24 Feb 2009 23:57:43 +0000 (23:57 +0000)]
2009-02-24  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel

        Minor numeric cleanup: convert float literals to doubles.

        * platform/graphics/transforms/RotateTransformOperation.cpp:
        (WebCore::RotateTransformOperation::blend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Mark Mentovai <mark@chromium.org>
dglazkov@chromium.org [Tue, 24 Feb 2009 23:22:30 +0000 (23:22 +0000)]
2009-02-24  Mark Mentovai  <mark@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24139
        Add missing include.

        * bindings/v8/ScriptInstance.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Jian Li <jianli@chromium.org>
levin@chromium.org [Tue, 24 Feb 2009 23:16:42 +0000 (23:16 +0000)]
2009-02-24  Jian Li  <jianli@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Move worker related files from dom directory to worker directory under WebCore.
        https://bugs.webkit.org/show_bug.cgi?id=24123

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.scons:
        * WebCore.vcproj/MigrateIDLAndScripts:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/CrossThreadCopier.cpp: Renamed from WebCore/dom/CrossThreadCopier.cpp.
        * platform/CrossThreadCopier.h: Renamed from WebCore/dom/CrossThreadCopier.h.
        * workers/GenericWorkerTask.h: Renamed from WebCore/dom/GenericWorkerTask.h.
        * workers/Worker.cpp: Renamed from WebCore/dom/Worker.cpp.
        * workers/Worker.h: Renamed from WebCore/dom/Worker.h.
        * workers/Worker.idl: Renamed from WebCore/dom/Worker.idl.
        * workers/WorkerContext.cpp: Renamed from WebCore/dom/WorkerContext.cpp.
        * workers/WorkerContext.h: Renamed from WebCore/dom/WorkerContext.h.
        * workers/WorkerContext.idl: Renamed from WebCore/dom/WorkerContext.idl.
        * workers/WorkerContextProxy.h: Renamed from WebCore/dom/WorkerContextProxy.h.
        * workers/WorkerLocation.cpp: Renamed from WebCore/dom/WorkerLocation.cpp.
        * workers/WorkerLocation.h: Renamed from WebCore/dom/WorkerLocation.h.
        * workers/WorkerLocation.idl: Renamed from WebCore/dom/WorkerLocation.idl.
        * workers/WorkerMessagingProxy.cpp: Renamed from WebCore/dom/WorkerMessagingProxy.cpp.
        * workers/WorkerMessagingProxy.h: Renamed from WebCore/dom/WorkerMessagingProxy.h.
        * workers/WorkerObjectProxy.h: Renamed from WebCore/dom/WorkerObjectProxy.h.
        * workers/WorkerRunLoop.cpp: Renamed from WebCore/dom/WorkerRunLoop.cpp.
        * workers/WorkerRunLoop.h: Renamed from WebCore/dom/WorkerRunLoop.h.
        * workers/WorkerThread.cpp: Renamed from WebCore/dom/WorkerThread.cpp.
        * workers/WorkerThread.h: Renamed from WebCore/dom/WorkerThread.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 24 Feb 2009 22:57:56 +0000 (22:57 +0000)]
2009-02-24  Simon Fraser  <simon.fraser@apple.com>

        Fix build when ACCELERATED_COMPOSITING is turned on
        (overflowList() -> normalFlowList()).

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::hasNonCompositingContent):
        (WebCore::RenderLayerBacking::paintIntoLayer):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::calculateCompositedBounds):
        (WebCore::RenderLayerCompositor::computeCompositingRequirements):
        (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
        (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
        (WebCore::RenderLayerCompositor::layerHas3DContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-05 Ojan Vafai <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 24 Feb 2009 22:28:31 +0000 (22:28 +0000)]
2009-02-05  Ojan Vafai  <ojan@chromium.org> and Eric Seidel <eric@webkit.org>

        Reviewed by Dave Hyatt.

        Make cursor positions match IE6/IE7/FF3 when clicking in margins/padding
        around divs inside editable regions.
        https://bugs.webkit.org/show_bug.cgi?id=23605

        Fix clicks outside editable regions from focusing the editable region.
        https://bugs.webkit.org/show_bug.cgi?id=23607

        Removed editing/selection/contenteditable-click-outside.html as it's
        not as useful as our new tests.

        Clean up RenderBlock::positionForCoordinates to remove dead code,
        duplicate code, and generally make it more readable.

        Tests: editing/selection/click-in-margins-inside-editable-div.html
               editing/selection/click-in-padding-with-multiple-line-boxes.html
               editing/selection/click-outside-editable-div.html

        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::canonicalPosition):
        * rendering/RenderBlock.cpp:
        (WebCore::positionForPointRespectingEditingBoundaries):
        (WebCore::positionForPointWithInlineChildren):
        (WebCore::RenderBlock::positionForCoordinates):
        (WebCore::RenderBlock::updateFirstLetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Tue, 24 Feb 2009 22:22:29 +0000 (22:22 +0000)]
WebCore:

2009-02-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Related to <rdar://problem/6590295>
        Allow disabling javascript: urls.

        * WebCore.base.exp:
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::parseMappedAttribute):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::executeIfJavaScriptURL):
        * page/Page.cpp:
        (WebCore::Page::Page):
        (WebCore::Page::setJavaScriptURLsAreAllowed):
        (WebCore::Page::javaScriptURLsAreAllowed):
        * page/Page.h:

WebKit/mac:

2009-02-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Related to <rdar://problem/6590295>
        Allow disabling javascript: urls.

        * WebView/WebView.mm:
        (-[WebView _setJavaScriptURLsAreAllowed:]):
        * WebView/WebViewPrivate.h:

WebKit/win:

2009-02-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Related to <rdar://problem/6590295>
        Allow disabling javascript: urls.

        * Interfaces/IWebViewPrivate.idl:
        * WebView.cpp:
        (WebView::setJavaScriptURLsAreAllowed):
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 24 Feb 2009 22:19:04 +0000 (22:19 +0000)]
2009-02-24  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=24135

        Round the FloatPoint returned by absoluteToLocal(), rather than
        truncating it.

        * dom/MouseRelatedEvent.cpp:
        (WebCore::MouseRelatedEvent::receivedTarget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
bdakin@apple.com [Tue, 24 Feb 2009 21:34:18 +0000 (21:34 +0000)]
WebCore:

2009-02-24  Beth Dakin  <bdakin@apple.com>

        Reviewed by Sam Weinig.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=24004 REGRESSION:
        Ordered list item marker misaligned when line height is not 1.2
        -and corresponding <rdar://problem/6602506>

        This is a regression from http://trac.webkit.org/changeset/40880
        where createInlineBox was taken off of RenderObject and moved to
        RenderBox. The problem was that the RenderBox version still needs
        to be virtual because there is still an existing implementation in
        RenderListMarker.

        * rendering/RenderBox.h:
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::createInlineBox):
        * rendering/RenderListMarker.h:

LayoutTests:

2009-02-24  Beth Dakin  <bdakin@apple.com>

        Reviewed by Sam Weinig.

        Test for https://bugs.webkit.org/show_bug.cgi?id=24004 REGRESSION:
        Ordered list item marker misaligned when line height is not 1.2
        -and corresponding <rdar://problem/6602506>

        * fast/lists/list-marker-with-line-height.html: Added.
        * platform/mac/fast/lists/list-marker-with-line-height-expected.checksum: Added.
        * platform/mac/fast/lists/list-marker-with-line-height-expected.png: Added.
        * platform/mac/fast/lists/list-marker-with-line-height-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fix
aroben@apple.com [Tue, 24 Feb 2009 20:47:52 +0000 (20:47 +0000)]
    Windows build fix

        * WebKit.vcproj/WebKit.def:
        * WebKit.vcproj/WebKit_debug.def:
        Export WTF::ThreadCondition::timedWait.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 24 Feb 2009 20:23:30 +0000 (20:23 +0000)]
2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24128
        Upstream more V8 custom bindings: constructors, XSLTProcessor.

        * bindings/v8/custom/V8DOMParserConstructor.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8MessageChannelConstructor.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8XMLSerializerConstructor.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8XSLTProcessorCustom.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Tue, 24 Feb 2009 19:46:38 +0000 (19:46 +0000)]
2009-02-24  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Simon Fraser.

        Adding these tests back in and removing from the Skipped list as
        these tests are all now passing on my machine as of latest revision.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 David Levin <levin@chromium.org>
levin@chromium.org [Tue, 24 Feb 2009 18:54:04 +0000 (18:54 +0000)]
2009-02-24  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 24090: WorkerThreadableLoader needs to be able to post tasks for a mode.
        <https://bugs.webkit.org/show_bug.cgi?id=24090>

        No observable change in behavior, so no test.

        * dom/WorkerMessagingProxy.cpp:
        (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
        (WebCore::WorkerMessagingProxy::postTaskToWorkerContext):
        Fixed the bug that m_unconfirmedMessageCount was getting incremented for non-message tasks.

        (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):

        * dom/WorkerMessagingProxy.h:
        * loader/ThreadableLoader.cpp:
        (WebCore::ThreadableLoader::create):
        * loader/WorkerThreadableLoader.cpp:
        (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation):
        Changed these methods to post task using a mode.

        * loader/WorkerThreadableLoader.h:
        (WebCore::WorkerThreadableLoader::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Tue, 24 Feb 2009 18:17:32 +0000 (18:17 +0000)]
2009-02-24  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Alexey Proskuryakov.

        Don't print out that you are generating new results if you are not in fact
        generating new results and disable generating new results by default for
        the all ports other than the canonical Apple Mac port since this can litter
        the source directory with hundreds of new results since other ports
        are not as up to date.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Tue, 24 Feb 2009 16:23:47 +0000 (16:23 +0000)]
2009-02-24  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Cameron Zwarich.

        The Qt port does not support these yet nor does the nm check work with
        QMake based build.

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Tue, 24 Feb 2009 16:12:30 +0000 (16:12 +0000)]
2009-02-24  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Cameron Zwarich.

        Remove tests from the Qt Skipped list that no longer even exist.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 24 Feb 2009 15:23:37 +0000 (15:23 +0000)]
2009-02-24  Geoffrey Garen  <ggaren@apple.com>

        Build fix?

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Tue, 24 Feb 2009 13:42:36 +0000 (13:42 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24091
        <rdar://problem/6468660> Start of redirect chain ends up as master entry in Application Cache

        Test: http/tests/appcache/access-via-redirect.php

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Use the URL we ended up with,
        not the original one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6407844> JavaScriptGlue should use -Os rather than -O2
mrowe@apple.com [Tue, 24 Feb 2009 13:26:46 +0000 (13:26 +0000)]
<rdar://problem/6407844> JavaScriptGlue should use -Os rather than -O2

Rubber-stamped by Dan Bernstein.

* Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6259220> Rename AVAILABLE_AFTER_WEBKIT_VERSION_3_1 (etc.) to match...
mrowe@apple.com [Tue, 24 Feb 2009 12:35:43 +0000 (12:35 +0000)]
<rdar://problem/6259220> Rename AVAILABLE_AFTER_WEBKIT_VERSION_3_1 (etc.) to match the other macros

Reviewed by Oliver Hunt.

* API/JSBasePrivate.h:
* API/JSContextRef.h:
* API/JSObjectRef.h:
* API/WebKitAvailability.h:

* Carbon/CarbonUtils.h:
* Carbon/HIWebView.h:
* Plugins/WebPlugin.h:
* Plugins/WebPluginViewFactory.h:
* WebView/WebUIDelegate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Mark Rowe ("awesome!").
ap@webkit.org [Tue, 24 Feb 2009 10:21:39 +0000 (10:21 +0000)]
    Reviewed by Mark Rowe ("awesome!").

        Make test for <https://bugs.webkit.org/show_bug.cgi?id=15707> more reliable.

        * fast/dom/onload-open.html: Added waitUntilDone().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Jian Li <jianli@chromium.org>
levin@chromium.org [Tue, 24 Feb 2009 09:44:54 +0000 (09:44 +0000)]
2009-02-24  Jian Li  <jianli@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Change to include WorkerObjectProxy.h instead of WorkerMessagingProxy.h in WorkerContext.cpp and WorkerScriptController.cpp.
        https://bugs.webkit.org/show_bug.cgi?id=24112

        * bindings/js/WorkerScriptController.cpp:
        * dom/WorkerContext.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 Peter Ammon <pammon@apple.com>
mrowe@apple.com [Tue, 24 Feb 2009 09:39:47 +0000 (09:39 +0000)]
2009-02-24  Peter Ammon  <pammon@apple.com>

        Reviewed by Mark Rowe.

        Fix <rdar://problem/6251410> Services can modify non-editable content in Safari

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView validRequestorForSendType:returnType:]): Return self only if we can handle
        both the send and return type.  We should also handle a nil send or return type by ignoring
        the argument and returning whether we can handle the other type passed in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Gtk] add options for 3D transforms and HTML5 channel messaging to the build
jmalonzo@webkit.org [Tue, 24 Feb 2009 09:22:35 +0000 (09:22 +0000)]
[Gtk] add options for 3D transforms and HTML5 channel messaging to the build
https://bugs.webkit.org/show_bug.cgi?id=24072

Reviewed by Alexey Proskuryakov.

Add options for toggling 3D transforms and HTML5 channel messaging
support on or off.

Also fix the web-workers option. It should be web-workers and not workers.

    * configure.ac:

Allow toggling of 3D transforms and HTML5 channel messaging
support for the Autotools (Gtk) build.

Also add '--gtk' in the build-webkit help doc and fix autotools
option for web-workers support.

    * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-24 David Levin <levin@chromium.org>
levin@chromium.org [Tue, 24 Feb 2009 08:57:34 +0000 (08:57 +0000)]
2009-02-24  David Levin  <levin@chromium.org>

        Reviewed by Dave Hyatt.

        Update expected results due to better results introduced by r41090.

        * platform/mac/media/video-layer-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-23 Antti Koivisto <antti@apple.com>
antti@apple.com [Tue, 24 Feb 2009 07:47:48 +0000 (07:47 +0000)]
2009-02-23  Antti Koivisto  <antti@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/6613796> Extended text codecs registered on webview creation

        Comparing a text encoding with string "GBK" ended up constructing
        TextEncoding("GBK") which in turn initialized all extended
        text codecs.

        * platform/text/TextCodecICU.cpp:
        (WebCore::TextCodecICU::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-23 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 24 Feb 2009 04:29:10 +0000 (04:29 +0000)]
2009-02-23  Sam Weinig  <sam@webkit.org>

        Fix Qt build.

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::valueRealType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-23 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 24 Feb 2009 03:58:09 +0000 (03:58 +0000)]
2009-02-23  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Next step in splitting JIT functionality out of the Interpreter class:
        Moved vptr storage from Interpreter to JSGlobalData, so it could be shared
        between Interpreter and JITStubs, and moved the *Trampoline JIT stubs
        into the JITStubs class. Also added a VPtrSet class to encapsulate vptr
        hacks during JSGlobalData initialization.

        SunSpider says 0.4% faster. Meh.

        * JavaScriptCore.exp:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::Interpreter):
        (JSC::Interpreter::tryCacheGetByID):
        (JSC::Interpreter::privateExecute):
        * interpreter/Interpreter.h:
        * jit/JIT.cpp:
        (JSC::JIT::privateCompileMainPass):
        (JSC::JIT::privateCompile):
        (JSC::JIT::privateCompileCTIMachineTrampolines):
        * jit/JIT.h:
        (JSC::JIT::compileCTIMachineTrampolines):
        * jit/JITCall.cpp:
        (JSC::JIT::compileOpCall):
        (JSC::JIT::compileOpCallSlowCase):
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::privateCompilePatchGetArrayLength):
        * jit/JITStubs.cpp:
        (JSC::JITStubs::JITStubs):
        (JSC::JITStubs::tryCacheGetByID):
        (JSC::JITStubs::cti_vm_dontLazyLinkCall):
        (JSC::JITStubs::cti_op_get_by_val):
        (JSC::JITStubs::cti_op_get_by_val_byte_array):
        (JSC::JITStubs::cti_op_put_by_val):
        (JSC::JITStubs::cti_op_put_by_val_array):
        (JSC::JITStubs::cti_op_put_by_val_byte_array):
        (JSC::JITStubs::cti_op_is_string):
        * jit/JITStubs.h:
        (JSC::JITStubs::ctiArrayLengthTrampoline):
        (JSC::JITStubs::ctiStringLengthTrampoline):
        (JSC::JITStubs::ctiVirtualCallPreLink):
        (JSC::JITStubs::ctiVirtualCallLink):
        (JSC::JITStubs::ctiVirtualCall):
        * runtime/ArrayPrototype.cpp:
        (JSC::arrayProtoFuncPop):
        (JSC::arrayProtoFuncPush):
        * runtime/FunctionPrototype.cpp:
        (JSC::functionProtoFuncApply):
        * runtime/JSArray.h:
        (JSC::isJSArray):
        * runtime/JSByteArray.h:
        (JSC::asByteArray):
        (JSC::isJSByteArray):
        * runtime/JSCell.h:
        * runtime/JSFunction.h:
        * runtime/JSGlobalData.cpp:
        (JSC::VPtrSet::VPtrSet):
        (JSC::JSGlobalData::JSGlobalData):
        (JSC::JSGlobalData::create):
        (JSC::JSGlobalData::sharedInstance):
        * runtime/JSGlobalData.h:
        * runtime/JSString.h:
        (JSC::isJSString):
        * runtime/Operations.h:
        (JSC::jsLess):
        (JSC::jsLessEq):
        * wrec/WREC.cpp:
        (JSC::WREC::Generator::compileRegExp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
jchaffraix@webkit.org [Tue, 24 Feb 2009 01:21:29 +0000 (01:21 +0000)]
WebCore:

2009-02-23  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin Adler.

        Bug 23956: Safari crashes when cloneNode fails (cloning a XML element with an invalid nodeName)

        The crash occurred because Document::cloneNode would call Document::createElementNS. Unfortunately
        element created with createElement could have a wrong nodeName (createElement sets the string as the
        localName without checking for a prefix).

        The fix is to call Document::createElement(const QualifiedName&, bool) that will not do any checks on the QualifiedName
        and will always succeed.
        Also rolled-out the HTMLElement specialisation of clonedNode as it was equivalent to what is done now (added an ASSERT
        to ensure that).

        Test: fast/dom/cloneNode.html

        * dom/Element.cpp:
        (WebCore::Element::cloneNode): Call createElement(const QualifiedName&, bool) instead of createElementNS as it will
        always return an element.

        * html/HTMLElement.cpp:
        * html/HTMLElement.h: Removed HTMLElement::clonedNode as it is equivalent to what is now done.

LayoutTests:

2009-02-23  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin Adler.

        Test for bug 23956: Safari crashes when cloneNode fails (cloning a XML element with an invalid nodeName)

        * fast/dom/cloneNode-expected.txt: Added.
        * fast/dom/cloneNode.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 23787: Allow JIT to generate SSE2 code if using GCC
oliver@apple.com [Tue, 24 Feb 2009 00:29:56 +0000 (00:29 +0000)]
Bug 23787: Allow JIT to generate SSE2 code if using GCC
<https://bugs.webkit.org/show_bug.cgi?id=23787>

Reviewed by Oliver Hunt
Contributed by Csaba Osztrogonac

GCC version of the cpuid check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-23 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 24 Feb 2009 00:04:16 +0000 (00:04 +0000)]
2009-02-23  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24109
        Upstream V8 Script abstractions, all except ScriptController.

        * bindings/v8/ScriptCachedFrameData.h: Added.
        (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
        (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
        (WebCore::ScriptCachedFrameData::restore):
        (WebCore::ScriptCachedFrameData::clear):
        (WebCore::ScriptCachedFrameData::domWindow):
        * bindings/v8/ScriptCallFrame.cpp: Added.
        (WebCore::ScriptCallFrame::ScriptCallFrame):
        (WebCore::ScriptCallFrame::~ScriptCallFrame):
        (WebCore::ScriptCallFrame::argumentAt):
        * bindings/v8/ScriptCallFrame.h: Added.
        (WebCore::ScriptCallFrame::functionName):
        (WebCore::ScriptCallFrame::sourceURL):
        (WebCore::ScriptCallFrame::lineNumber):
        (WebCore::ScriptCallFrame::argumentCount):
        * bindings/v8/ScriptCallStack.cpp: Added.
        (WebCore::ScriptCallStack::ScriptCallStack):
        (WebCore::ScriptCallStack::~ScriptCallStack):
        (WebCore::ScriptCallStack::at):
        * bindings/v8/ScriptCallStack.h: Added.
        (WebCore::ScriptCallStack::size):
        * bindings/v8/ScriptInstance.cpp: Added.
        (WebCore::V8ScriptInstance::V8ScriptInstance):
        (WebCore::V8ScriptInstance::~V8ScriptInstance):
        (WebCore::V8ScriptInstance::instance):
        (WebCore::V8ScriptInstance::clear):
        (WebCore::V8ScriptInstance::set):
        * bindings/v8/ScriptInstance.h: Added.
        (WebCore::V8ScriptInstance::create):
        * bindings/v8/ScriptSourceCode.h: Added.
        (WebCore::ScriptSourceCode::ScriptSourceCode):
        (WebCore::ScriptSourceCode::isEmpty):
        (WebCore::ScriptSourceCode::source):
        (WebCore::ScriptSourceCode::url):
        (WebCore::ScriptSourceCode::startLine):
        * bindings/v8/ScriptState.h: Added.
        (WebCore::ScriptState::hadException):
        (WebCore::ScriptState::setException):
        (WebCore::ScriptState::exception):
        * bindings/v8/ScriptString.h: Added.
        (WebCore::ScriptString::ScriptString):
        (WebCore::ScriptString::operator String):
        (WebCore::ScriptString::isNull):
        (WebCore::ScriptString::size):
        (WebCore::ScriptString::operator=):
        (WebCore::ScriptString::operator+=):
        * bindings/v8/ScriptValue.cpp: Added.
        (WebCore::ScriptValue::getString):
        * bindings/v8/ScriptValue.h: Added.
        (WebCore::ScriptValue::ScriptValue):
        (WebCore::ScriptValue::operator=):
        (WebCore::ScriptValue::operator==):
        (WebCore::ScriptValue::operator!=):
        (WebCore::ScriptValue::isNull):
        (WebCore::ScriptValue::isUndefined):
        (WebCore::ScriptValue::clear):
        (WebCore::ScriptValue::~ScriptValue):
        (WebCore::ScriptValue::v8Value):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-23 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Mon, 23 Feb 2009 23:20:33 +0000 (23:20 +0000)]
2009-02-23  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=24106
        The Qt port is crashing on exit because the tear down procedure involves
        the WebCore::InspectorController trying to access the JS execution context
        for a page that is being deleted.  This patch amends the inspector so
        that it does not try and access the execution context of the WebCore::Page
        in the midst of deletion.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::inspectedPageDestroyed):
        (WebCore::InspectorController::stopUserInitiatedProfiling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-23 David Levin <levin@chromium.org>
levin@chromium.org [Mon, 23 Feb 2009 22:37:35 +0000 (22:37 +0000)]
2009-02-23  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 24088: ThreadableLoaderClient::didFailWillSendRequestCheck isn't wired up completely for workers and could use a better name.
        <https://bugs.webkit.org/show_bug.cgi?id=24088>

        No observable change in behavior, so no test.

        * loader/DocumentThreadableLoader.cpp:
        (WebCore::DocumentThreadableLoader::create):
        * loader/ThreadableLoaderClient.h:
        (WebCore::ThreadableLoaderClient::didFailRedirectCheck):
        * loader/ThreadableLoaderClientWrapper.h:
        (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
        * loader/WorkerThreadableLoader.cpp:
        (WebCore::workerContextDidFailRedirectCheck):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
        * loader/WorkerThreadableLoader.h:
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::didFinishLoading):
        * xml/XMLHttpRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
levin@chromium.org [Mon, 23 Feb 2009 22:37:17 +0000 (22:37 +0000)]
JavaScriptCore:

2009-02-23  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode
        <https://bugs.webkit.org/show_bug.cgi?id=24047>

        * wtf/MessageQueue.h:
        (WTF::MessageQueue::infiniteTime):
        Allows for one to call waitForMessageFilteredWithTimeout and wait forever.

        (WTF::MessageQueue::alwaysTruePredicate):
        (WTF::MessageQueue::waitForMessage):
        Made waitForMessage call waitForMessageFilteredWithTimeout, so that there is less
        duplicate code.

        (WTF::MessageQueue::waitForMessageFilteredWithTimeout):

        * wtf/ThreadingQt.cpp:
        (WTF::ThreadCondition::timedWait):
        * wtf/ThreadingWin.cpp:
        (WTF::ThreadCondition::timedWait):
        Made these two implementations consistent with the pthread and gtk implementations.
        Currently, the time calculations would overflow when passed large values.

WebCore:

2009-02-23  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode
        <https://bugs.webkit.org/show_bug.cgi?id=24047>

        Made a nested if inside of WorkerRunLoop::runInMode a lot simpler by
        using only MessageQueue::waitForMessageFilteredWithTimeout instead
        of three different MessageQueue methods.

        No observable change in behavior, so no test.

        * dom/WorkerRunLoop.cpp:
        (WebCore::ModePredicate::operator()):
        Minor clean-up to able to pass a const ref point for ModePredicate into runInMode.
        (WebCore::WorkerRunLoop::runInMode):
        * dom/WorkerRunLoop.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 23 Feb 2009 22:08:43 +0000 (22:08 +0000)]
2009-02-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoffrey Garen and Darin Adler.

        WebKit side of <rdar://problem/6613151>.

        Make sure to vm_deallocate all memory we get from MIG callbacks.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (DataDeallocator::DataDeallocator):
        (DataDeallocator::~DataDeallocator):
        Add a simple deallocator class.

        (WKPCStatusText):
        (WKPCLoadURL):
        (WKPCBooleanAndDataReply):
        (WKPCEvaluate):
        (WKPCGetStringIdentifier):
        (WKPCInvoke):
        (WKPCInvokeDefault):
        (WKPCConstruct):
        (WKPCSetProperty):
        Use the new deallocator class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-23 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 23 Feb 2009 20:40:23 +0000 (20:40 +0000)]
2009-02-23  David Hyatt  <hyatt@apple.com>

        In preparation for making layers for multicol objects (so that they can properly split child layers
        into multiple columns), rename all of the "overflowOnly" and "overflowList" members and functions
        of RenderLayer to use the term "normal flow" instead.

        Reviewed by Cameron Zwarich

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::RenderLayer):
        (WebCore::RenderLayer::~RenderLayer):
        (WebCore::RenderLayer::setHasVisibleContent):
        (WebCore::RenderLayer::enclosingCompositingLayer):
        (WebCore::RenderLayer::addChild):
        (WebCore::RenderLayer::removeChild):
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::hitTestLayer):
        (WebCore::RenderLayer::dirtyNormalFlowList):
        (WebCore::RenderLayer::updateNormalFlowList):
        (WebCore::RenderLayer::collectLayers):
        (WebCore::RenderLayer::updateLayerListsIfNeeded):
        (WebCore::RenderLayer::shouldBeNormalFlowOnly):
        (WebCore::RenderLayer::styleChanged):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::isNormalFlowOnly):
        (WebCore::RenderLayer::normalFlowList):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::writeLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Mon, 23 Feb 2009 20:16:43 +0000 (20:16 +0000)]
WebCore:

2009-02-23  David Hyatt  <hyatt@apple.com>

        Fix the stacking order for column rules in multi-column layout.  Column rules should paint as part of the background of an element, just
        after all other components of the background have been painted.  This allows negative z-index children to still paint on top of the
        column rules (rather than ending up above the background of the box but behind the column rules).

        Reviewed by Eric Seidel

        Added fast/multicol/column-rules-stacking.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintColumnRules):
        (WebCore::RenderBlock::paintColumnContents):
        (WebCore::RenderBlock::paintObject):
        * rendering/RenderBlock.h:

LayoutTests:

2009-02-23  David Hyatt  <hyatt@apple.com>

        Fix the stacking order for column rules in multi-column layout.  Column rules should paint as part of the background of an element, just
        after all other components of the background have been painted.  This allows negative z-index children to still paint on top of the
        column rules (rather than ending up above the background of the box but behind the column rules).

        Reviewed by Eric Seidel

        * fast/multicol/column-rules-stacking.html: Added.
        * platform/mac/fast/multicol/column-rules-stacking-expected.checksum: Added.
        * platform/mac/fast/multicol/column-rules-stacking-expected.png: Added.
        * platform/mac/fast/multicol/column-rules-stacking-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-23 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Mon, 23 Feb 2009 20:11:05 +0000 (20:11 +0000)]
2009-02-23  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by David Hyatt.

        No testcases have been added or modified since this patch should not result in
        a behavior change for ports that have layout tests enabled.

        Currently, the implementation of GraphicsContext::drawLineForText amongst
        the various ports differ in that some of them are honoring the context's
        strokeStyle when drawing a text-decoration and some of them are not.
        For instance, Apple's Mac port *does not* honor the context's strokeStyle(),
        but the Cairo implementation does and has an explicit workaround that
        sets the strokeStyle() temporarily.

        This patch fixes so that all ports are consistent by explicitly making sure
        to set the GraphicsContext strokeStyle to SolidStroke whenever
        painting the text-decoration of an InlineFlowBox or InlineTextBox as these
        should always use a solid stroke.

        This patch addresses these bugs:
        https://bugs.webkit.org/show_bug.cgi?id=19364
        https://bugs.webkit.org/show_bug.cgi?id=15659

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintTextDecorations):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintDecoration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-23 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Mon, 23 Feb 2009 19:52:52 +0000 (19:52 +0000)]
2009-02-23  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24094
        Make sure to empty the cache on exit to get rid of superfluous leak messages
        for CachedResource's in order to keep the leak messages accurate.  This
        is analagous to what the Mac port is doing on application exit when all
        WebView's have been closed.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::_q_cleanupLeakMessages):
        (QWebPage::QWebPage):
        * Api/qwebpage.h:
        * Api/qwebpage_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-23 Scott Violet <sky@google.com>
dglazkov@chromium.org [Mon, 23 Feb 2009 19:35:42 +0000 (19:35 +0000)]
2009-02-23  Scott Violet  <sky@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24098
        Bugs in ClipboardChromium

        Fixes the following bugs in ClipboardChromium:
        * It's possible for the extension to be empty, resulting in a bad file
          name, for example, 'foo.' or just '.'.
        * We weren't restricting the size of the file to MAX_PATH.
        * We weren't removing characters that are invalid for file system names.

        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::writeImageToDataObject):
        * platform/chromium/ClipboardChromium.h:
        * platform/chromium/ClipboardChromiumLinux.cpp: Added.
        (WebCore::ClipboardChromium::validateFileName):
        * platform/chromium/ClipboardChromiumMac.cpp: Added.
        (WebCore::ClipboardChromium::validateFileName):
        * platform/chromium/ClipboardChromiumWin.cpp: Added.
        (WebCore::isInvalidFileCharacter):
        (WebCore::ClipboardChromium::validateFileName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-23 Jeremy Moskovich <jeremy@chromium.org>
dglazkov@chromium.org [Mon, 23 Feb 2009 17:48:25 +0000 (17:48 +0000)]
2009-02-23  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=24096
        PLATFORM(MAC)->PLATFORM(CF) since we want to use the CF functions in Chrome on OS X.

        * wtf/CurrentTime.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 23 Feb 2009 17:20:29 +0000 (17:20 +0000)]
2009-02-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Fix <rdar://problem/6450656>.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::insertText):
        Add insert text which just calls the new WKPH function.

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView inputContext]):
        Get the input context from the shared input panel.

        (-[WebHostedNetscapePluginView keyDown:]):
        Let the shared input panel have a go at the event first.

        * Plugins/Hosted/WebKitPluginHost.defs:
        Add new InsertText function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-23 Thiago Macieira <thiago.macieira@nokia.com>
hausmann@webkit.org [Mon, 23 Feb 2009 16:19:31 +0000 (16:19 +0000)]
2009-02-23  Thiago Macieira  <thiago.macieira@nokia.com>

        Reviewed by Simon Hausmann.

        Fix the Copyright notices in a few files

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-23 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Mon, 23 Feb 2009 15:08:10 +0000 (15:08 +0000)]
2009-02-23  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24011
        KURL's setPort doesn't unset port if 0 is given

        Adding regression tests for change done on KURL's setPort in
        r41076. It is worth noting that Firefox doesn't render this test
        correctly since it raises an exception when javascript tries to
        change the iframe's contentWindow.location.port, though other
        properties are modifiable.

        * fast/loader/location-port-expected.txt: Added.
        * fast/loader/location-port.html: Added.
        * fast/loader/resources/location-port-iframe.html: Added.

Also added bug URL to the WebCore entry for the r41076 change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Rubber-stamped by Mark Rowe.
ap@webkit.org [Mon, 23 Feb 2009 14:46:00 +0000 (14:46 +0000)]
    Rubber-stamped by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=15690
        Bug in layout test framework (setUpPage vs. setUpPageStatus)

        * (Many JS files in dom/):
        (setUpPage): Replaced setUpPage with setUpPageStatus where appropriate, downstreaming
        a W3C fix.

        Committing dom/xhtml/level3.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Rubber-stamped by Mark Rowe.
ap@webkit.org [Mon, 23 Feb 2009 14:23:20 +0000 (14:23 +0000)]
    Rubber-stamped by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=15690
        Bug in layout test framework (setUpPage vs. setUpPageStatus)

        * (Many JS files in dom/):
        (setUpPage): Replaced setUpPage with setUpPageStatus where appropriate, downstreaming
        a W3C fix.

        Committing dom/xhtml/level2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Rubber-stamped by Mark Rowe.
ap@webkit.org [Mon, 23 Feb 2009 14:03:34 +0000 (14:03 +0000)]
    Rubber-stamped by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=15690
        Bug in layout test framework (setUpPage vs. setUpPageStatus)

        * (Many JS files in dom/):
        (setUpPage): Replaced setUpPage with setUpPageStatus where appropriate, downstreaming
        a W3C fix.

        Committing dom/xhtml/level1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Rubber-stamped by Mark Rowe.
ap@webkit.org [Mon, 23 Feb 2009 13:56:16 +0000 (13:56 +0000)]
    Rubber-stamped by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=15690
        Bug in layout test framework (setUpPage vs. setUpPageStatus)

        * (Many JS files in dom/):
        (setUpPage): Replaced setUpPage with setUpPageStatus where appropriate, downstreaming
        a W3C fix.

        Committing dom/html/level2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Rubber-stamped by Mark Rowe.
ap@webkit.org [Mon, 23 Feb 2009 13:34:52 +0000 (13:34 +0000)]
    Rubber-stamped by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=15690
        Bug in layout test framework (setUpPage vs. setUpPageStatus)

        * (Many JS files in dom/):
        (setUpPage): Replaced setUpPage with setUpPageStatus where appropriate, downstreaming
        a W3C fix.

        Committing  dom/html/level1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Rubber-stamped by Mark Rowe.
ap@webkit.org [Mon, 23 Feb 2009 13:27:32 +0000 (13:27 +0000)]
    Rubber-stamped by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=15690
        Bug in layout test framework (setUpPage vs. setUpPageStatus)

        * (Many JS files in dom/):
        (setUpPage): Replaced setUpPage with setUpPageStatus where appropriate, downstreaming
        a W3C fix.

        First part: dom/svg.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAllow retrieving the Soup session and modify the code to take
christian@webkit.org [Mon, 23 Feb 2009 11:24:02 +0000 (11:24 +0000)]
Allow retrieving the Soup session and modify the code to take
into account users changing features on it.

https://bugs.webkit.org/show_bug.cgi?id=22624
[SOUP][GTK] Need API to get SoupSession from WebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove CURL support in the Gtk port, the HTTP backend is SOUP now.
christian@webkit.org [Mon, 23 Feb 2009 11:15:30 +0000 (11:15 +0000)]
Remove CURL support in the Gtk port, the HTTP backend is SOUP now.

https://bugs.webkit.org/show_bug.cgi?id=22624
[SOUP][GTK] Need API to get SoupSession from WebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-23 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Mon, 23 Feb 2009 10:00:23 +0000 (10:00 +0000)]
2009-02-23  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Mark Rowe.

        [GTK] Back / Forward history menus are flipped
        https://bugs.webkit.org/show_bug.cgi?id=22694

        Don't call g_list_reverse when returning the back or forward list.

        * tests/main.c:
        (test_webkit_web_back_forward_list_order):
        (main):
        * webkit/webkitwebbackforwardlist.cpp:
        (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit):
        (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Mark Rowe.
ap@webkit.org [Mon, 23 Feb 2009 09:44:16 +0000 (09:44 +0000)]
    Reviewed by Mark Rowe.

        Test: fast/dom/empty-hash-and-search.html

        https://bugs.webkit.org/show_bug.cgi?id=21147
        hash property returns incorrect value for links w/o hash

        Make hash() and search() behavior for empty and missing parts match IE and Firefox.

        * platform/KURL.cpp:
        (WebCore::KURL::query): Changed to return query without '?', as it is already done for ref().
        (WebCore::KURL::prettyURL): Append the query with the question mark.

        * page/Location.cpp:
        (WebCore::Location::search): Return an empty string if query is empty or missing.
        (WebCore::Location::hash): Return an empty string for empty hashes, not only missing ones.

        * dom/WorkerLocation.cpp:
        (WebCore::WorkerLocation::search):
        (WebCore::WorkerLocation::hash):
        Match document.location fixes above.

        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::hash):
        (WebCore::HTMLAnchorElement::search):
        Return an empty string for empty and missing parts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Mon, 23 Feb 2009 09:21:54 +0000 (09:21 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=20184
        SELECT with no name generates invalid query string

        Test: fast/forms/select-no-name.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::appendFormData): Added a check for empty name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Apply review comments for the previous check-in (forgot to save the file...
ap@webkit.org [Mon, 23 Feb 2009 09:10:59 +0000 (09:10 +0000)]
    Apply review comments for the previous check-in (forgot to save the file, oops).

        * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Mon, 23 Feb 2009 09:03:15 +0000 (09:03 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=15707
        Crash when manipulating document from within an iframe onload function

        Test: fast/dom/onload-open.html

        * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Protect the container and
        the current node, because anything can happen when dispatching events.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the build after r41126.
mrowe@apple.com [Mon, 23 Feb 2009 08:58:00 +0000 (08:58 +0000)]
Fix the build after r41126.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
(WebKit::NetscapePluginInstanceProxy::construct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Mon, 23 Feb 2009 08:52:20 +0000 (08:52 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=18970
        Numerically named input fields cause document.forms loop problems

        Test: fast/forms/numeric-input-name.html

        * bindings/scripts/CodeGeneratorJS.pm: Try index getter before name getter, even if the
        latter overrides properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Sam Weinig.
ap@webkit.org [Mon, 23 Feb 2009 08:44:57 +0000 (08:44 +0000)]
    Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=24059
        Tokenizer::write() return value is never used

        * dom/Tokenizer.h:
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::write):
        * dom/XMLTokenizer.h:
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::write):
        * html/HTMLTokenizer.h:
        * loader/FTPDirectoryDocument.cpp:
        (WebCore::FTPDirectoryTokenizer::write):
        * loader/ImageDocument.cpp:
        (WebCore::ImageTokenizer::write):
        * loader/MediaDocument.cpp:
        (WebCore::MediaTokenizer::write):
        * loader/PluginDocument.cpp:
        (WebCore::PluginTokenizer::write):
        * loader/TextDocument.cpp:
        (WebCore::TextTokenizer::write):
        Made write() return void, not bool.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
mitz@apple.com [Mon, 23 Feb 2009 06:22:34 +0000 (06:22 +0000)]
    Reviewed by Darin Adler.

        - fix <rdar://problem/5966123> REGRESSION (r30741): Generic Sun Applet loading logo appears half off screen

        * WebCoreSupport/WebFrameLoaderClient.mm: Correct a copy & paste error
        in r30741, and assign the height value, rather than the width, to the
        "height" parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-22 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 23 Feb 2009 00:53:05 +0000 (00:53 +0000)]
2009-02-22  Geoffrey Garen  <ggaren@apple.com>

        Build fix?

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-22 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 23 Feb 2009 00:34:49 +0000 (00:34 +0000)]
2009-02-22  Geoffrey Garen  <ggaren@apple.com>

        Build fix.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41127 268f45cc-cd09-0410-ab3c-d52691b4dbfc