WebKit-https.git
6 years ago[Qt][WK1][CSS Regions] New test fast/regions/hover-on-child-parent-different-regions...
commit-queue@webkit.org [Mon, 3 Jun 2013 12:52:49 +0000 (12:52 +0000)]
[Qt][WK1][CSS Regions]  New test fast/regions/hover-on-child-parent-different-regions.html fails
https://bugs.webkit.org/show_bug.cgi?id=117035

Used waitUntilDone() to ensure correct results.

Patch by Radu Stavila <stavila@adobe.com> on 2013-06-03
Reviewed by Antti Koivisto.

* fast/regions/hover-on-child-parent-different-regions-expected.txt:
* fast/regions/hover-on-child-parent-different-regions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK][WK2] accessibility/placeholder.html is failing
commit-queue@webkit.org [Mon, 3 Jun 2013 12:40:37 +0000 (12:40 +0000)]
[GTK][WK2] accessibility/placeholder.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106344

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-06-03
Reviewed by Gyuyoung Kim.

Tools:

Adds support for retrieving attribute value.

* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::coreAttributeToAtkAttribute):
(WTR::AccessibilityUIElement::stringAttributeValue):

LayoutTests:

Unskipping failing test. It's been fixed.

* platform/gtk-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed WinCE build fix after r150833.
paroga@webkit.org [Mon, 3 Jun 2013 12:38:03 +0000 (12:38 +0000)]
Unreviewed WinCE build fix after r150833.

* wtf/DateMath.cpp:
(WTF::calculateDSTOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago'onended' event is not received in AudioBufferSourceNode and OscillatorNode.
commit-queue@webkit.org [Mon, 3 Jun 2013 11:47:46 +0000 (11:47 +0000)]
'onended' event is not received in AudioBufferSourceNode and OscillatorNode.
https://bugs.webkit.org/show_bug.cgi?id=117132.

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-06-03
Reviewed by Christophe Dumez.

Source/WebCore:

The listener argument is a PassRefPtr which becomes NULL after the call to
setAttributeEventListener() in setOnended(). This causes the m_hasEndedListener
boolean to be incorrectly initialized. This patch reverses the two statements so
that the m_hasEndedListener is updated before the call to setAttributeEventListener().

No new tests, already covered by existing tests.

* Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::setOnended):

LayoutTests:

Unskip webaudio test cases that were failing due to the 'onended' event not being fired.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL]<select> element's text is clipped when a height is specified along with CSS...
commit-queue@webkit.org [Mon, 3 Jun 2013 10:30:07 +0000 (10:30 +0000)]
[EFL]<select> element's text is clipped when a height is specified along with CSS line-height.
https://bugs.webkit.org/show_bug.cgi?id=114862

Patch by Rashmi Kulakarni <rashmi.vijay@samsung.com> on 2013-06-03
Reviewed by Gyuyoung Kim.

Source/WebCore:

Fix <select> element getting clipped when element height becomes less than the line-height.
Set minimum height for <select> element.

No new tests, no behavior change.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::adjustMenuListButtonStyle):

LayoutTests:

Rebaselined the test case fast/forms/001.html.

* platform/efl/fast/forms/001-expected.png:
* platform/efl/fast/forms/001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: Webkit crashes while loading content from Application Cache.
charles.wei@torchmobile.com.cn [Mon, 3 Jun 2013 08:58:34 +0000 (08:58 +0000)]
Source/WebCore: Webkit crashes while loading content from Application Cache.
https://bugs.webkit.org/show_bug.cgi?id=116814

Reviewed by Darin Adler.

With the refacor for 112722, which removes MainResourceLoader and moves the functionality to DocumentLoader,
the processing of appcache for main resource error (because of network error) was moved DocumentLoader::
mainReceivedError(), which was trigged by ResourceHandle::didFail->SubResourceLoader::didFail, which already
in a Finishing state after notifying the DocumentLoader of the load failure.

Before patch for 112722, the appcache for main resource error was in MainResourceLoader::didFail(),
which will start processing the potential fallback before notifying DocumentLoader and moving the the state
of the resource loader to finishing state.

So we should move maybeLoadFallbackForMainError out of DocumentLoader::mainReceivedError, and move it to
ApplicationCacheHost::maybeLoadFallbackForError, if the resource that has error is the main resource.

Test: http/tests/appcache/main-resource-fallback-for-network-error-crash.html

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::mainReceivedError):
* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::maybeLoadFallbackForError):
* loader/appcache/ApplicationCacheHost.h:

LayoutTests: Webkit crashes while loading  content from Application Cache.
https://bugs.webkit.org/show_bug.cgi?id=116814

Reviewed by Darin Adler.

* http/tests/appcache/main-resource-fallback-for-network-error-crash-expected.txt: Added.
* http/tests/appcache/main-resource-fallback-for-network-error-crash.html: Added.
* http/tests/appcache/resources/main-resource-fallback-for-network-error-crash.manifest: Added.
* http/tests/appcache/resources/success-and-notify-done.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Process launcher uses system() for wrapping the WebProcess when using...
commit-queue@webkit.org [Mon, 3 Jun 2013 08:34:34 +0000 (08:34 +0000)]
[EFL][WK2] Process launcher uses system() for wrapping the WebProcess when using WEB_PROCESS_CMD_PREFIX
https://bugs.webkit.org/show_bug.cgi?id=105156

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-06-03
Reviewed by Christophe Dumez.

When using WEB_PROCESS_CMD_PREFIX - which allows us for instance to analyze
WebProcess under tools like valgrind or gdb -, the ProcessLauncher would
spawn the new process using system(), which would, among other things, keep
an extra UIProcess waiting and executing the shell.

This patch handles the normal case and the case where we have something to
prefix WebProcess (i.e., by using WEB_PROCESS_CMD_PREFIX in a debug build)
the same way, through a call to execvp().

To achieve this a function was introduced to create an array with the given
arguments to the full command to be executed, to be used by execvp(). We use
a Vector<OwnArrayPtr<char>>, so that we can take advantage of the destructor
of OwnArrayPtr to handle the memory deallocation when it goes out of scope.

* UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::createArgsArray):  This function creates the array to be used by
execvp(), out of the Strings given as arguments.
(WebKit::ProcessLauncher::launchProcess): Rework the logic to accomodate
both the cases with and without WEB_PROCESS_CMD_PREFIX. The execl() call
was replaced with an execvp() call, since now we should deal with having
a variable number of arguments (WEB_PROCESS_CMD_PREFIX) as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Mon, 3 Jun 2013 08:02:00 +0000 (08:02 +0000)]
Unreviewed EFL gardening.

Rebaseline 2 printing test cases on EFL port.

* platform/efl/printing/compositing-layer-printing-expected.png:
* platform/efl/printing/compositing-layer-printing-expected.txt:
* platform/efl/printing/page-rule-in-media-query-expected.png:
* platform/efl/printing/page-rule-in-media-query-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Mon, 3 Jun 2013 07:48:55 +0000 (07:48 +0000)]
Unreviewed EFL gardening.

Skip 2 webaudio tests that are failing due to the onended event not getting
fired.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Mon, 3 Jun 2013 07:44:38 +0000 (07:44 +0000)]
Unreviewed EFL gardening.

Rebaseline several test cases on EFL.

* platform/efl-wk2/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
* platform/efl-wk2/compositing/overflow/content-loses-scrollbars-expected.txt: Added.
* platform/efl-wk2/fast/dynamic/002-expected.txt:
* platform/efl/fast/block/float/float-not-removed-from-next-sibling2-expected.png:
* platform/efl/fast/block/float/float-not-removed-from-next-sibling2-expected.txt:
* platform/efl/fast/dynamic/002-expected.png:
* platform/efl/fast/table/007-expected.png:
* platform/efl/fast/table/007-expected.txt:
* platform/efl/fast/table/colspanMinWidth-expected.png:
* platform/efl/fast/table/colspanMinWidth-expected.txt:
* platform/efl/fast/table/spanOverlapRepaint-expected.png:
* platform/efl/fast/table/spanOverlapRepaint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Mon, 3 Jun 2013 07:14:37 +0000 (07:14 +0000)]
Unreviewed EFL gardening.

Rebaseline several mozilla tables layout tests for EFL port.

* platform/efl/tables/mozilla/bugs/bug13169-expected.png:
* platform/efl/tables/mozilla/bugs/bug13169-expected.txt:
* platform/efl/tables/mozilla/bugs/bug133756-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug133756-1-expected.txt:
* platform/efl/tables/mozilla/bugs/bug133756-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug133756-2-expected.txt:
* platform/efl/tables/mozilla/bugs/bug17138-expected.png:
* platform/efl/tables/mozilla/bugs/bug17138-expected.txt:
* platform/efl/tables/mozilla/bugs/bug17548-expected.png:
* platform/efl/tables/mozilla/bugs/bug17548-expected.txt:
* platform/efl/tables/mozilla/bugs/bug220536-expected.png:
* platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
* platform/efl/tables/mozilla/bugs/bug6304-expected.png:
* platform/efl/tables/mozilla/bugs/bug6304-expected.txt:
* platform/efl/tables/mozilla/bugs/bug73321-expected.png:
* platform/efl/tables/mozilla/bugs/bug73321-expected.txt:
* platform/efl/tables/mozilla/bugs/bug7714-expected.txt:
* platform/efl/tables/mozilla/bugs/bug8858-expected.png:
* platform/efl/tables/mozilla/bugs/bug8858-expected.txt:
* platform/efl/tables/mozilla/core/bloomberg-expected.png:
* platform/efl/tables/mozilla/core/bloomberg-expected.txt:
* platform/efl/tables/mozilla/core/cell_heights-expected.png:
* platform/efl/tables/mozilla/core/cell_heights-expected.txt:
* platform/efl/tables/mozilla/other/test6-expected.png:
* platform/efl/tables/mozilla/other/test6-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug1010-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug6933-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WTF] Add OwnArrayPtr vectortraits template
gyuyoung.kim@samsung.com [Mon, 3 Jun 2013 07:09:56 +0000 (07:09 +0000)]
[WTF] Add OwnArrayPtr vectortraits template
https://bugs.webkit.org/show_bug.cgi?id=117131

Reviewed by Darin Adler.

To support Vector<OwnArrayPtr<P>>, which will be used by EFL port.

* wtf/VectorTraits.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL Gardening.
gyuyoung.kim@samsung.com [Mon, 3 Jun 2013 05:32:22 +0000 (05:32 +0000)]
Unreviewed EFL Gardening.

* platform/efl-wk2/TestExpectations: Unskipping some of webgl passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Move Qt port off legacy clipboard
commit-queue@webkit.org [Mon, 3 Jun 2013 04:53:33 +0000 (04:53 +0000)]
[Qt] Move Qt port off legacy clipboard
https://bugs.webkit.org/show_bug.cgi?id=116416

Patch by Arunprasad Rajkumar <arurajku@cisco.com> on 2013-06-02
Reviewed by Darin Adler.

Source/WebCore:

No change in behavior, no new tests added.

* Target.pri: Removed ClipboardQt.h and EditorQt.cpp from compilation.
* dom/Clipboard.h:
* editing/qt/EditorQt.cpp: Removed.
* page/qt/EventHandlerQt.cpp: Use Clipboard::createForDragAndDrop().
(WebCore::EventHandler::createDraggingClipboard):
* platform/Pasteboard.h:
(WebCore::Pasteboard::clipboardData): Expose writable QMimeData* to outside, so that it is accessible
from DragClientQt.cpp and WebDragClientQt.cpp.
(WebCore::Pasteboard::invalidateWritableData):
(WebCore::Pasteboard::isForDragAndDrop):
(WebCore::Pasteboard::isForCopyAndPaste):
* platform/qt/ClipboardQt.cpp:
(WebCore::Clipboard::createDragImage):
(WebCore::Clipboard::declareAndWriteDragImage):
* platform/qt/ClipboardQt.h: Removed.
* platform/qt/PasteboardQt.cpp: Moved required methods from ClipboardQt.cpp.
(WebCore::isTextMimeType):
(WebCore::isHtmlMimeType):
(WebCore::Pasteboard::create):
(WebCore::Pasteboard::createForCopyAndPaste):
(WebCore::Pasteboard::createPrivate):
(WebCore::Pasteboard::createForDragAndDrop):
(WebCore::Pasteboard::Pasteboard):
(WebCore::Pasteboard::~Pasteboard):
(WebCore::Pasteboard::generalPasteboard):
(WebCore::Pasteboard::isSelectionMode):
(WebCore::Pasteboard::setSelectionMode):
(WebCore::Pasteboard::readData):
(WebCore::Pasteboard::hasData):
(WebCore::Pasteboard::clear):
(WebCore::Pasteboard::readString):
(WebCore::Pasteboard::writeString):
(WebCore::Pasteboard::types):
(WebCore::Pasteboard::readFilenames):
(WebCore::Pasteboard::setDragImage):
(WebCore::Pasteboard::writePasteboard):

Source/WebKit/qt:

* WebCoreSupport/DragClientQt.cpp:
(WebCore::DragClientQt::startDrag):

Source/WebKit2:

* WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:
(WebKit::WebDragClient::startDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGoing "back" to a cached page from a page with a main resource error breaks scrolling...
beidson@apple.com [Mon, 3 Jun 2013 01:43:24 +0000 (01:43 +0000)]
Going "back" to a cached page from a page with a main resource error breaks scrolling, amongst other issues.
<rdar://problem/13751844> and https://bugs.webkit.org/show_bug.cgi?id=117112

Reviewed by Alexey Proskuryakov.

Source/WebCore:

If a main resource load ends in error, the Document's parser is never cleared out.

If you then return to a CachedPage, we run the Document->clearParser() step for the
old page and that incorrectly dispatches didFinishLoad for the previous page load
in the middle of the load for the cached page.

The parser should never be needed after a load completes (even if it fails) and
holding on to the parser after the page load failed but before a new navigation is
actually using unnecessary resources.

So we should just clear the parser right when the main resource fails.

Test: http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::stopLoading): After canceling the main resource load, also clear the parser.

LayoutTests:

* http/tests/loading/resources/resource-that-goes-back-while-still-loading.php: Added.
* http/tests/loading/unfinished-load-back-to-cached-page-callbacks-expected.txt: Added.
* http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago The empty directory did not get deleted by commit queue, deleting manually.
ap@apple.com [Sun, 2 Jun 2013 20:37:05 +0000 (20:37 +0000)]
    The empty directory did not get deleted by commit queue, deleting manually.

        * xmlviewer: Removed.
        * xmlviewer/resources: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CMake] Unreviewed buildfix after r148896 and r150940.
ossy@webkit.org [Sun, 2 Jun 2013 19:08:20 +0000 (19:08 +0000)]
[CMake] Unreviewed buildfix after r148896 and r150940.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][CoordinatedGraphics]: Use a properly initialized WebPage when creating a PageClient
commit-queue@webkit.org [Sun, 2 Jun 2013 08:33:09 +0000 (08:33 +0000)]
[WK2][CoordinatedGraphics]: Use a properly initialized WebPage when creating a PageClient
https://bugs.webkit.org/show_bug.cgi?id=117116

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-06-02
Reviewed by Tim Horton.

Valgrind reported a "conditional jump or move depends on uninitialised value"
at WebPageProxy constructor, when checking the m_isVisible variable inside
the ENABLE(PAGE_VISIBILITY_API) guard.

The issue was tracked down to the WebView constructor, which was creating a
WebKit::PageClient* making use of `this' before having initialized all of its
attributes.

The solution was to move the initialization of the `page' member to inside the
constructor itself - out of the initialization list -, where we can guarantee
all the relevant stuff has already been properly initialized.

Here's the relevant valgrind trace for reference:

Conditional jump or move depends on uninitialised value(s)
    at 0x65A35A4: WebKit::WebPageProxy::WebPageProxy(WebKit::PageClient*,
                  WTF::PassRefPtr<WebKit::WebProcessProxy>,
                  WebKit::WebPageGroup*, unsigned long) (WebPageProxy.cpp:322)
    by 0x65A2BA2: WebKit::WebPageProxy::create(WebKit::PageClient*,
                  WTF::PassRefPtr<WebKit::WebProcessProxy>,
                  WebKit::WebPageGroup*, unsigned long) (WebPageProxy.cpp:233)
    by 0x65E94BB: WebKit::WebProcessProxy::createWebPage(WebKit::PageClient*,
                  WebKit::WebContext*, WebKit::WebPageGroup*)
                  (WebProcessProxy.cpp:172)
    by 0x6570957: WebKit::WebContext::createWebPage(WebKit::PageClient*,
                  WebKit::WebPageGroup*, WebKit::WebPageProxy*)
                  (WebContext.cpp:735)
    by 0x67673E3: WebKit::WebView::WebView(WebKit::WebContext*,
                  WebKit::WebPageGroup*) (WebView.cpp:52)
    by 0x6775F18: WebKit::WebViewEfl::WebViewEfl(WebKit::WebContext*,
                  WebKit::WebPageGroup*) (WebViewEfl.cpp:54)
    by 0x6775EB4: WebKit::WebView::create(WebKit::WebContext*,
                  WebKit::WebPageGroup*) (WebViewEfl.cpp:49)
    by 0x673E13D: WKViewCreate (WKView.cpp:33)
    by 0x6763ECE: EWKViewCreate (ewk_view.cpp:92)

* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::WebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnstyled XML viewer crashes when XML contains an element with id="tree"
ap@apple.com [Sun, 2 Jun 2013 08:14:48 +0000 (08:14 +0000)]
Unstyled XML viewer crashes when XML contains an element with id="tree"
https://bugs.webkit.org/show_bug.cgi?id=117117
<rdar://problem/13727267>

Reviewed by Darin Adler.

Source/WebCore:

Test: http/tests/xmlviewer/dumpAsText/existing-tree-element-crash.xml

* xml/XMLViewer.css: Removed the rule to hide source document, as we no longer
keep it in the tree.

* xml/XMLViewer.js:
(prepareWebKitXMLViewer): Make sourceXML a detached tree, as otherwise it can
have ID conflicts with elements we add.
(sourceXMLLoaded): Removed some commented out code. Removed code that was checking
whether an extension took over XML display, as it makes no sense to duplicate this
functionality in an extension.

LayoutTests:

* http/tests/xmlviewer/dumpAsText/existing-tree-element-crash-expected.txt: Added.
* http/tests/xmlviewer/dumpAsText/existing-tree-element-crash.xml: Added.

* xmlviewer: Removed.
* xmlviewer/extensions-api-expected.txt: Removed.
* xmlviewer/extensions-api.html: Removed.
* xmlviewer/resources: Removed.
* xmlviewer/resources/sample.xml: Removed.
The "API" no longer exists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKit ignores aria-hidden when traversing nodes for name calculation
cfleizach@apple.com [Sun, 2 Jun 2013 04:42:57 +0000 (04:42 +0000)]
WebKit ignores aria-hidden when traversing nodes for name calculation
https://bugs.webkit.org/show_bug.cgi?id=117101

Reviewed by Tim Horton.

Source/WebCore:

When calculating the inner text, aria-hidden should be considered.

Test: accessibility/text-role-with-aria-hidden-inside.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::shouldUseAccessiblityObjectInnerText):

LayoutTests:

* accessibility/text-role-with-aria-hidden-inside-expected.txt: Added.
* accessibility/text-role-with-aria-hidden-inside.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowindow.speechSynthesis needs to be cheap
darin@apple.com [Sat, 1 Jun 2013 23:26:02 +0000 (23:26 +0000)]
window.speechSynthesis needs to be cheap
https://bugs.webkit.org/show_bug.cgi?id=117111
rdar://problem/14042030

Reviewed by Dean Jackson.

Add the traditional laziness to all of the speech synthesis code, wherever
it was omitted.

* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::create): Tweaked style (took out unneeded parentheses).
(WebCore::SpeechSynthesis::SpeechSynthesis): Don't create m_platformSpeechSynthesizer.
(WebCore::SpeechSynthesis::setPlatformSynthesizer): Clear state when changing the
platform speech synthesizer. Since this code is only used to set up a mock in the
test runner, the fact that it was wrong before was harmless, but still not good.
(WebCore::SpeechSynthesis::getVoices): Create the platform speech synthesizer here
so we can get the voice list from it.
(WebCore::SpeechSynthesis::startSpeakingImmediately): Create the platform speech
synthesizer here.
(WebCore::SpeechSynthesis::cancel): Check the platform speech synthesizer for
null and do nothing if it's not present.
(WebCore::SpeechSynthesis::pause): Ditto.
(WebCore::SpeechSynthesis::resume): Ditto.

* platform/PlatformSpeechSynthesizer.cpp:
(WebCore::PlatformSpeechSynthesizer::create): Don't call initializeVoiceList just
to create a synthesizer.
(WebCore::PlatformSpeechSynthesizer::voiceList): Do call initializeVoiceList once
when asked for a voice list.

* platform/PlatformSpeechSynthesizer.h: The voiceList function is no longer inlined.
The unused setVoiceList function has been removed. The initializeVoiceList is now
private rather than protected. Added a new m_voiceListIsInitialized boolean.

* platform/mac/PlatformSpeechSynthesizerMac.mm:
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer): Initialize
m_voiceListIsInitialized to false.

* platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::create): Don't call initializeVoiceList just
to create a synthesizer.
(WebCore::PlatformSpeechSynthesizerMock::~PlatformSpeechSynthesizerMock):
Removed unneeded call to m_speakingFinishedTimer.stop() since timers automatically
stop when you destroy them.
(WebCore::PlatformSpeechSynthesizerMock::initializeVoiceList): Removed unneeded
call to m_voiceList.clear(), since the caller only calls this once when the
voice list is already clear.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a preferred email address and "expertise" for me.
timothy_horton@apple.com [Sat, 1 Jun 2013 23:09:44 +0000 (23:09 +0000)]
Add a preferred email address and "expertise" for me.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix typo in r151071.
akling@apple.com [Sat, 1 Jun 2013 18:02:36 +0000 (18:02 +0000)]
Fix typo in r151071.

* dom/Element.cpp:
(WebCore::Element::attributeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove Node::hasName() to Element.
akling@apple.com [Sat, 1 Jun 2013 10:20:25 +0000 (10:20 +0000)]
Move Node::hasName() to Element.
<http://webkit.org/b/117107>

Reviewed by Antti Koivisto.

A Node can't have attributes, and thus can't have a name.
Use a bit on ElementData instead of (half) a Node flag to track whether we have a name.

* dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore::ElementData::ElementData):
* dom/Element.h:
(WebCore::ElementData::hasName):
(WebCore::Element::hasName):
* dom/Node.h:
(WebCore::Node::isEditingText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unnused WebDOMNodeOperationsInternal category.
akling@apple.com [Sat, 1 Jun 2013 09:48:33 +0000 (09:48 +0000)]
Remove unnused WebDOMNodeOperationsInternal category.
<http://webkit.org/b/117105>

Reviewed by Ryosuke Niwa.

_subresourceURLs had no clients.

* DOM/WebDOMOperations.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove Node::hasID() and hasClass() to Element.
akling@apple.com [Sat, 1 Jun 2013 09:39:59 +0000 (09:39 +0000)]
Move Node::hasID() and hasClass() to Element.
<http://webkit.org/b/117104>

Reviewed by Ryosuke Niwa.

Source/WebCore:

A Node can't have attributes, and thus can't have an ID or a class.
Move these to Element instead, and fix up a few call sites that called through on a Node*.

* dom/Element.h:
* dom/LiveNodeList.cpp:
(WebCore::LiveNodeList::namedItem):
* dom/Node.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::name):
* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeRenderRegionList):

Source/WebKit/mac:

* WebView/WebRenderLayer.mm:
(+[WebRenderLayer nameForLayer:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, EFL gardening. Remove passed accessibility test from EFL WK1.
gyuyoung.kim@samsung.com [Sat, 1 Jun 2013 06:00:19 +0000 (06:00 +0000)]
Unreviewed, EFL gardening. Remove passed accessibility test from EFL WK1.

* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Curl] Unable to download files.
commit-queue@webkit.org [Sat, 1 Jun 2013 05:41:42 +0000 (05:41 +0000)]
[Curl] Unable to download files.
https://bugs.webkit.org/show_bug.cgi?id=116150

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-05-31
Reviewed by Brent Fulgham.

Implemented basic download functionality for Curl.

Source/WebCore:

* WebCore.vcproj/WebCore.vcproj: Added file.
* WebCore.vcxproj/WebCore.vcxproj: Added file.
* WebCore.vcxproj/WebCore.vcxproj.filters: Added file.
* platform/network/curl/CurlDownload.h: Added.
* platform/network/curl/CurlDownload.cpp: Added.

Source/WebKit/win:

* WebDownload.h:
* WebDownloadCurl.cpp:
(WebDownload::init):
(WebDownload::start):
(WebDownload::cancel):
(WebDownload::deletesFileUponFailure):
(WebDownload::setDeletesFileUponFailure):
(WebDownload::setDestination):
(WebDownload::useCredential):
(WebDownload::didReceiveResponse):
(WebDownload::didReceiveDataOfLength):
(WebDownload::didFinish):
(WebDownload::didFail):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Make windows test bots search in the correct directory for build output.
roger_fong@apple.com [Sat, 1 Jun 2013 04:21:09 +0000 (04:21 +0000)]
Unreviewed. Make windows test bots search in the correct directory for build output.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitTests.start):
* Scripts/webkitdirs.pm:
(determineConfigurationProductDir):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Windows build fix...
roger_fong@apple.com [Sat, 1 Jun 2013 03:54:25 +0000 (03:54 +0000)]
Unreviewed. Windows build fix...

* BuildSlaveSupport/built-product-archive:
(createZip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Windows build fix. One more time!
roger_fong@apple.com [Sat, 1 Jun 2013 03:34:35 +0000 (03:34 +0000)]
Unreviewed. Windows build fix. One more time!

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):
(extractBuiltProduct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Windows build fix.
roger_fong@apple.com [Sat, 1 Jun 2013 03:04:24 +0000 (03:04 +0000)]
Unreviewed. Windows build fix.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add a null checking condition to in hide() of EwkContextMenu
gyuyoung.kim@samsung.com [Sat, 1 Jun 2013 02:59:08 +0000 (02:59 +0000)]
[EFL][WK2] Add a null checking condition to in hide() of EwkContextMenu
https://bugs.webkit.org/show_bug.cgi?id=117014

Reviewed by Christophe Dumez.

m_viewImpl is able to be null. So, we need to protect this function against such case.

* UIProcess/API/efl/ewk_context_menu.cpp:
(EwkContextMenu::hide):
(ewk_context_menu_hide):
* UIProcess/API/efl/ewk_context_menu_private.h:
(EwkContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix bug in active page tracking that lead to plugins hanging during destruction
oliver@apple.com [Sat, 1 Jun 2013 01:39:17 +0000 (01:39 +0000)]
Fix bug in active page tracking that lead to plugins hanging during destruction
https://bugs.webkit.org/show_bug.cgi?id=117099

Reviewed by Anders Carlsson.

NPRuntimeObjectMap no longer keeps its own reference to the
throttler, and no longer reports activity during destruction.

* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::NPRuntimeObjectMap):
(WebKit::NPRuntimeObjectMap::evaluate):
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Windows build fix.
roger_fong@apple.com [Sat, 1 Jun 2013 01:07:15 +0000 (01:07 +0000)]
Unreviewed. Windows build fix.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[wk2] All intrinsic content size changes should go through the 0-delay timer
timothy_horton@apple.com [Sat, 1 Jun 2013 00:01:54 +0000 (00:01 +0000)]
[wk2] All intrinsic content size changes should go through the 0-delay timer
https://bugs.webkit.org/show_bug.cgi?id=117058
<rdar://problem/13935042>

Reviewed by Anders Carlsson.

In r146913, I added a 0-delay timer so that we'd coalesce intrinsic
content size changes. However, didUpdateGeometry was still immediately
invalidating the intrinsic content size without coalescing.

Move that update to the WebProcess to share the timer.

* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::didUpdateGeometry):
* UIProcess/DrawingAreaProxy.messages.in:
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):
Remove the newIntrinsicContentSize argument, and don't invalidate intrinsic
content size inside didUpdateGeometry.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
Start the intrinsic content size update timer when we finish updateGeometry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake build-webkit output VCExpress 2010 build logs properly.
roger_fong@apple.com [Fri, 31 May 2013 23:47:23 +0000 (23:47 +0000)]
Make build-webkit output VCExpress 2010 build logs properly.
https://bugs.webkit.org/show_bug.cgi?id=117096

Reviewed by Brent Fulgham.

Make it so that output from VCExpress is always printed to console.
Get build log results from AssembleBuildLogs project output.
We don't need those old VCExpress scripts anymore either.

* Scripts/build-webkit:
* Scripts/print-msvc-project-dependencies: Removed.
* Scripts/print-vse-failure-logs: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Sandbox violations when trying to access fonts in non-standard locations
ap@apple.com [Fri, 31 May 2013 23:40:40 +0000 (23:40 +0000)]
    Sandbox violations when trying to access fonts in non-standard locations
        https://bugs.webkit.org/show_bug.cgi?id=117097
        <rdar://problem/9264746>

        Reviewed by Anders Carlsson.

        The issue was that lack of a main xib was resulting in font machinery being
        initialized too early, before we entered sandbox.

        * Resources/WebContentProcess.xib: Added.
        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
        * WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
        * WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNeed the ability to get the information for a plug-in with a particular process id...
jberlin@webkit.org [Fri, 31 May 2013 23:32:53 +0000 (23:32 +0000)]
Need the ability to get the information for a plug-in with a particular process id that may
be running on a page
https://bugs.webkit.org/show_bug.cgi?id=117090

Rubber-stamped by Anders Carlsson.

Follow-up to r151043 incorprating some feedback I got from Darin after I had already
committed the patch.

* UIProcess/API/C/mac/WKPagePrivateMac.cpp:
(callGetPlugInInformationBlockAndDispose):
Renamed to be less wordy.
(WKPageGetPlugInInformation):
Ditto.
* UIProcess/API/C/mac/WKPagePrivateMac.h:
Ditto.

* UIProcess/Plugins/PluginProcessManager.h:
* UIProcess/Plugins/mac/PluginProcessManagerMac.mm:
(WebKit::PluginProcessManager::findPlugInProcessByID):
Renamed to not use "Cocoa method style" in non-Cocoa functions.
(WebKit::PluginProcessManager::findPlugInProcessByToken):
Ditto.

* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::getPlugInInformation):
Reduce ref count churn and fix a variable name.
Updated for the change to findPlugInProcessByID.
(WebKit::WebPageProxy::containsPlugInCallback):
Updated for the change to findPlugInProcessByToken.

* WebProcess/Plugins/PDF/SimplePDFPlugin.h:
Move the override of a virtual function to the private section.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago <rdar://problem/14036464> Sandbox violation when using Web SpeechSynthesis
ap@apple.com [Fri, 31 May 2013 22:32:27 +0000 (22:32 +0000)]
    <rdar://problem/14036464> Sandbox violation when using Web SpeechSynthesis

        Reviewed by Anders Carlsson

        * WebProcess/com.apple.WebProcess.sb.in: Allow com.apple.speech.synthesis.console.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Use WinLauncher to display LayoutTest results
bfulgham@apple.com [Fri, 31 May 2013 22:14:28 +0000 (22:14 +0000)]
[Windows] Use WinLauncher to display LayoutTest results
https://bugs.webkit.org/show_bug.cgi?id=117085

Reviewed by Oliver Hunt.

* Scripts/webkitdirs.pm:
(runSafari): Use WinLauncher to display content
* WinLauncher/WinLauncher.cpp:
(dllLauncherEntryPoint): Check for URL argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIncorrect assertion in DFG::Graph::uncheckedActivationRegisterFor()
fpizlo@apple.com [Fri, 31 May 2013 22:08:16 +0000 (22:08 +0000)]
Incorrect assertion in DFG::Graph::uncheckedActivationRegisterFor()
<rdar://problem/13989324>

Rubber stamped by Mark Hahnenberg.

This has a bogus assertion that checks that the passed CodeOrigin doesn't have
an inline call frame. This was well intentioned in the sense that it is true
that inlined call frames wouldn't have an activation register. But that doesn't
mean that people won't ask. Removing the assertion fixes a debug-only crash and
has no impact on production code. This change adds a comment to that effect.

* dfg/DFGGraph.h:
(JSC::DFG::Graph::uncheckedActivationRegisterFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Modify AssembleBuildLogs project to WebKit solution in preparation for...
roger_fong@apple.com [Fri, 31 May 2013 22:01:56 +0000 (22:01 +0000)]
Unreviewed. Modify AssembleBuildLogs project to WebKit solution in preparation for moving buildbots to VCExpress 2010.
Add it to the WebKit solution as well.

* win/AssembleBuildLogs/AssembleLogs.cmd:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNeed the ability to get the information for a plug-in with a particular process id...
jberlin@webkit.org [Fri, 31 May 2013 21:59:58 +0000 (21:59 +0000)]
Need the ability to get the information for a plug-in with a particular process id that may
be running on a page
https://bugs.webkit.org/show_bug.cgi?id=117090

Reviewed by Anders Carlsson.

* UIProcess/API/C/mac/WKPagePrivateMac.cpp:
(callGetInformationForPlugInWithProcessIDBlockAndDispose):
Get the block from the context, invoke it with the result, and dispose of it.
(WKPageGetInformationForPlugInWithProcessID):
Ask the WebPageProxy and provide it with a dictionary callback that uses the
above function to invoke the passed in block.
* UIProcess/API/C/mac/WKPagePrivateMac.h:
Add WKPageGetInformationForPlugInWithProcessID and a typedef for the callback block.

* UIProcess/Plugins/PluginProcessManager.h:
Add ways to get the PluginProcessProxy associated with a process id or process token.
* UIProcess/Plugins/mac/PluginProcessManagerMac.mm:
(WebKit::PluginProcessManager::plugInProcessWithProcessID):
Return the first PluginProcessProxy with the passed in process ID.
(WebKit::PluginProcessManager::plugInProcessWithToken):
Return the first PluginProcessProxy with the passed in process token.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
Invalidate any outstanding requests for plug-in information.
* UIProcess/WebPageProxy.h:
Keep track of the callbacks for the requests for plug-in information.
* UIProcess/WebPageProxy.messages.in:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::getInformationForPlugInWithProcessID):
If there are no known plug-ins with the provided process ID, invoke the callback with a null
dictionary of plug-in information.
Otherwise, keep track of the callback and send a message to the web process asking for the
information.
(WebKit::WebPageProxy::containsPlugInCallback):
If the page did not contain the plug-in, invoke the callback with a null dictionary of
plug-in information.
Invoke the callback with a dictionary containing the PlugInModuleInfo.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
Return 0 for the plugInProcessToken.
* WebProcess/Plugins/PDF/SimplePDFPlugin.h:
Ditto.
* WebProcess/Plugins/Plugin.h:
Add a pure virtual method for plugInProcessToken so it can be accessed from from the Plugin
on the PluginView.
* WebProcess/Plugins/PluginProxy.h:
Return the actual plug-in process token.

* WebProcess/Plugins/PluginView.h:
(WebKit::PluginView::plugIn):
Make it possible to get at the plug-in process token through the Plugin.

* WebProcess/WebPage/WebPageMac.mm:
(WebKit::WebPage::containsPluginViewsWithPluginProcessToken):
If there is an instance of the plug-in with that token, send a confirmation to the ui
process.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTake the normal NSView code path when drawing into an inclusive layer
andersca@apple.com [Fri, 31 May 2013 21:55:24 +0000 (21:55 +0000)]
Take the normal NSView code path when drawing into an inclusive layer
https://bugs.webkit.org/show_bug.cgi?id=117094
<rdar://problem/13812355>

Reviewed by Sam Weinig.

For now, take the normal code path when drawing into an inclusive layer.

* platform/mac/WidgetMac.mm:
(WebCore::Widget::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Update low memory handler to use new memory pressure notifications...
slewis@apple.com [Fri, 31 May 2013 21:44:26 +0000 (21:44 +0000)]
Source/WebCore: Update low memory handler to use new memory pressure notifications on new OS versions.
<rdar://problem/14027095>

Reviewed by Mark Rowe.

No change in functionality.

* WebCore.exp.in:
* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::install): Call new API
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac: Update low memory handler to use new memory pressure notifications on new OS versions.
<rdar://problem/14027095>

Reviewed by Mark Rowe.

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKit2: Update low memory handler to use new memory pressure notifications on new OS versions.
<rdar://problem/14027095>

Reviewed by Mark Rowe.

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Update Button UX.
commit-queue@webkit.org [Fri, 31 May 2013 20:44:53 +0000 (20:44 +0000)]
[BlackBerry] Update Button UX.
https://bugs.webkit.org/show_bug.cgi?id=116992

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-05-31
Reviewed by Rob Buis.

BlackBerry PR 342298.
Internally Review by Jeff Rogers.

* css/themeBlackBerry.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDerivedSources.make: any rules that use $(FEATURE_DEFINES) should be rebuilt when...
ddkilzer@apple.com [Fri, 31 May 2013 20:27:41 +0000 (20:27 +0000)]
DerivedSources.make: any rules that use $(FEATURE_DEFINES) should be rebuilt when FeatureDefines.xcconfig changes
<http://webkit.org/b/117081>

Reviewed by Mark Rowe.

* DerivedSources.make: Add $(PLATFORM_FEATURE_DEFINES)
dependency for all rules that use $(FEATURE_DEFINES) to generate
files.
(PLATFORM_FEATURE_DEFINES): Set this variable to
Configurations/FeatureDefines.xcconfig if not already set on
Mac OS X.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago REGRESSION (r141445): MPEG-4 videos do not play on certain hardware configura...
ap@apple.com [Fri, 31 May 2013 20:16:26 +0000 (20:16 +0000)]
    REGRESSION (r141445): MPEG-4 videos do not play on certain hardware configurations
        https://bugs.webkit.org/show_bug.cgi?id=117089
        <rdar://problem/13839717>

        Reviewed by Mark Rowe.

        * Configurations/WebContentProcess.xcconfig: Statically link to a framework that
        uses an XPC service to work around a libxpc limitation on Lion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoText Field UX updates.
commit-queue@webkit.org [Fri, 31 May 2013 19:08:58 +0000 (19:08 +0000)]
Text Field UX updates.
https://bugs.webkit.org/show_bug.cgi?id=116996

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-05-31
Reviewed by Rob Buis.

BlackBerry PR 342333.
Internally Reviewed by Jeff Rogers.

Update disabled text field font color.

* css/themeBlackBerry.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[sh4] Fix Overflow case of branchMul32 in baseline JIT.
commit-queue@webkit.org [Fri, 31 May 2013 18:22:57 +0000 (18:22 +0000)]
[sh4] Fix Overflow case of branchMul32 in baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=117057

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-31
Reviewed by Oliver Hunt.

Current implementation of Overflow case in branchMul32 performs an
unsigned multiplication whereas a signed multiplication is expected.

* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchMul32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[sh4] Fix floating point comparisons in baseline JIT.
commit-queue@webkit.org [Fri, 31 May 2013 18:22:05 +0000 (18:22 +0000)]
[sh4] Fix floating point comparisons in baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=117066.

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-31
Reviewed by Oliver Hunt.

Current implementation of branchDouble function in baseline JIT is wrong
for some conditions and overkill for others. For instance:
- With DoubleGreaterThanOrEqual condition, branch will be taken if either
  operand is NaN with current implementation whereras it should not.
- With DoubleNotEqualOrUnordered condition, performed NaN checks are
  useless (because comparison result is false if either operand is NaN).

* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[sh4] Fix double floating point transfer in baseline JIT.
commit-queue@webkit.org [Fri, 31 May 2013 18:21:23 +0000 (18:21 +0000)]
[sh4] Fix double floating point transfer in baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=117054

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-31
Reviewed by Oliver Hunt.

In current implementation, dmovRegReg function transfers only one single
FPRegister as PR=1 and SZ=0 in floating point status/control register.
Double transfers must be performed with two fmov.s opcodes.

* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::moveDouble):
(JSC::MacroAssemblerSH4::addDouble): Handle (op2==dest) case properly.
(JSC::MacroAssemblerSH4::sqrtDouble):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::fmovsRegReg):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[sh4] Handle branchType properly in branchTruncateDoubleToInt32.
commit-queue@webkit.org [Fri, 31 May 2013 18:19:15 +0000 (18:19 +0000)]
[sh4] Handle branchType properly in branchTruncateDoubleToInt32.
https://bugs.webkit.org/show_bug.cgi?id=117062

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-31
Reviewed by Oliver Hunt.

Current implementation of branchTruncateDoubleToInt32 is incorrect
when branchType == BranchIfTruncateSuccessful in sh4 baseline JIT.

* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchTruncateDoubleToInt32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate CheckedInt.h to latest version from Mozilla
dino@apple.com [Fri, 31 May 2013 17:45:51 +0000 (17:45 +0000)]
Update CheckedInt.h to latest version from Mozilla
https://bugs.webkit.org/show_bug.cgi?id=117009

Reviewed by Darin Adler.

Mozilla have updated their version of CheckedInt and suggested
we sync. Here are the improvements:

- CheckedInt now consistently rejects unsupported types. Before, you
could sometimes construct a CheckedInt from an unsupported type (like,
float) or multiply a CheckedInt by a float, and have it not caught! See
https://bugzilla.mozilla.org/show_bug.cgi?id=869194
 - Fixed a possibility of undefined behavior in unary operator-. See bug
https://bugzilla.mozilla.org/show_bug.cgi?id=849666
 - CheckedInt now supports the "long long" and "unsigned long long"
types. We don't like "long long" (and neither does the Google C++ style
guide!) but we had to do that because libogg exposes typedefs to those
types. See Bug https://bugzilla.mozilla.org/show_bug.cgi?id=869685
 - CheckedInt also now supports "signed char" in addition to "char" ---
they are not the same type! See Bug https://bugzilla.mozilla.org/show_bug.cgi?id=847521
 - Fixed and simplified usage of CheckedInt outside of Mozilla. You'll
like this one! See Bug https://bugzilla.mozilla.org/show_bug.cgi?id=849667
 - Fixed compilation with the Intel C++ compiler. See bug https://bugzilla.mozilla.org/show_bug.cgi?id=784309

* html/canvas/CheckedInt.h: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't create an accelerated compositing layer unless we have to for snapshotting...
dino@apple.com [Fri, 31 May 2013 17:04:13 +0000 (17:04 +0000)]
Don't create an accelerated compositing layer unless we have to for snapshotting plug-ins
https://bugs.webkit.org/show_bug.cgi?id=117076
<rdar://problem/14030364>

Reviewed by Beth Dakin and Anders Carlsson.

If a plug-in can support software snapshotting, then don't create an
accelerated compositing layer for it while in snapshot mode. This is a
better user experience -- otherwise the page/plug-in looks like it broke.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::isAcceleratedCompositingEnabled): If we are in snapshotting mode
and we are a Flash plugin (the only one that supports software snapshots at the moment)
then do not create an accelerated compositing layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Unreviewed build fix for VS2005 builders.
bfulgham@apple.com [Fri, 31 May 2013 17:02:14 +0000 (17:02 +0000)]
[Windows] Unreviewed build fix for VS2005 builders.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def: Add
missing export for WTF::SHA1::computeHexDigest

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r151022.
commit-queue@webkit.org [Fri, 31 May 2013 16:57:56 +0000 (16:57 +0000)]
Unreviewed, rolling out r151022.
http://trac.webkit.org/changeset/151022
https://bugs.webkit.org/show_bug.cgi?id=117084

Also breaks build by introducing duplicate symbols (Requested
by bfulgham on #webkit).

* TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Unreviewed build fix to NRWT
bfulgham@apple.com [Fri, 31 May 2013 16:45:31 +0000 (16:45 +0000)]
[Windows] Unreviewed build fix to NRWT

* Scripts/webkitpy/port/win.py:
(WinPort.create_debugger_command_file): Use proper argument for _filesystem.write_text_file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Unreviewed build fix after r151012
bfulgham@apple.com [Fri, 31 May 2013 16:31:29 +0000 (16:31 +0000)]
[Windows] Unreviewed build fix after r151012

* TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Add dependency on
WTF library to support SHA tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake sure gstreamer source element is thread-safe
commit-queue@webkit.org [Fri, 31 May 2013 16:17:47 +0000 (16:17 +0000)]
Make sure gstreamer source element is thread-safe
https://bugs.webkit.org/show_bug.cgi?id=115352

Patch by Andre Moreira Magalhaes <andre.magalhaes@collabora.co.uk> on 2013-05-31
Reviewed by Philippe Normand.

GStreamer source element may be created by any gstreamer element on any thread by calling
gst_element_make_from_uri with the URIs handled by the source element.
This patch makes sure the gstreamer source element is thread-safe to avoid issues with it
being created outside the main thread.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(_WebKitWebSrcPrivate):
(webkit_web_src_init):
(webKitWebSrcFinalize):
(webKitWebSrcSetProperty):
(webKitWebSrcGetProperty):
(webKitWebSrcStop):
(webKitWebSrcStart):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(webKitWebSrcNeedDataMainCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcSeekMainCb):
(webKitWebSrcSeekDataCb):
(webKitWebSrcSetMediaPlayer):
(StreamingClient::StreamingClient):
(StreamingClient::~StreamingClient):
(StreamingClient::didReceiveResponse):
(StreamingClient::didReceiveData):
(StreamingClient::didFinishLoading):
(StreamingClient::wasBlocked):
(StreamingClient::cannotShowURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix double hash lookup in PageMapMemoryUsageRecorder::visit
rafael.lobo@openbossa.org [Fri, 31 May 2013 16:16:11 +0000 (16:16 +0000)]
Fix double hash lookup in PageMapMemoryUsageRecorder::visit
https://bugs.webkit.org/show_bug.cgi?id=117071

Reviewed by Andreas Kling.

* wtf/FastMalloc.cpp:
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Unreviewed build fix after r151012
bfulgham@apple.com [Fri, 31 May 2013 16:14:22 +0000 (16:14 +0000)]
[Windows] Unreviewed build fix after r151012

* TestWebKitAPI/Tests/WTF/MD5.cpp: Include <wtf/StringExtras.h> to provide
snprintf definition for Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Speculative build fix for pre-VS2010 compilers
bfulgham@apple.com [Fri, 31 May 2013 16:01:35 +0000 (16:01 +0000)]
[Windows] Speculative build fix for pre-VS2010 compilers

* wtf/Platform.h: Only treat WTF as DLL for VS2010 builds

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Update test-expectations after r151000.
jer.noble@apple.com [Fri, 31 May 2013 15:53:54 +0000 (15:53 +0000)]
Unreviewed gardening. Update test-expectations after r151000.

* fast/js/date-DST-time-cusps-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix when CSSParser debugging is enabled
sergio@webkit.org [Fri, 31 May 2013 15:52:08 +0000 (15:52 +0000)]
Build fix when CSSParser debugging is enabled
https://bugs.webkit.org/show_bug.cgi?id=117075

Reviewed by Andreas Kling.

Build fails when enabling parser debugging by setting YYDEBUG to
1 because of a missing include.

* css/CSSGrammar.y.includes:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Newly added editing/selection/caret-after-keypress.html crashing
eustas@chromium.org [Fri, 31 May 2013 15:21:40 +0000 (15:21 +0000)]
[Qt][WK2] Newly added editing/selection/caret-after-keypress.html crashing
https://bugs.webkit.org/show_bug.cgi?id=117070

Unreviewed test expectations update.

WebKitTestRunner needs a more-complete implementation of eventSender.
Until then caret-after-keypress test is disabled

See https://bugs.webkit.org/show_bug.cgi?id=42194

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
zarvai@inf.u-szeged.hu [Fri, 31 May 2013 13:29:28 +0000 (13:29 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0-wk1/TestExpectations: Skip flaky test.
* platform/qt-5.0-wk2/TestExpectations: Skip crashing test.
* platform/qt/fast/js/date-DST-time-cusps-expected.txt: Rebaselining after r151000.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Soup] [Gstreamer] ASSERT in StreamingClient::getOrCreateReadBuffer
commit-queue@webkit.org [Fri, 31 May 2013 10:25:08 +0000 (10:25 +0000)]
[Soup] [Gstreamer] ASSERT in StreamingClient::getOrCreateReadBuffer
https://bugs.webkit.org/show_bug.cgi?id=116686

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-31
Reviewed by Carlos Garcia Campos.

We were using g_input_stream_read_async() to handle redirections
because of Gnome bug #691489.

This produces an unexpected read attempt which triggers an assert
in StreamingClient::getOrCreateReadBuffer().

Now that the Gnome bug is fixed we can replace read_async() with
skip_async().

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::ensureReadBuffer):
(WebCore::redirectSkipCallback):
(WebCore::sendRequestCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove MD5, SHA1 unit tests from WTF to TestWebKitAPI
commit-queue@webkit.org [Fri, 31 May 2013 10:06:32 +0000 (10:06 +0000)]
Move MD5, SHA1 unit tests from WTF to TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=116445

Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-05-31
Reviewed by Benjamin Poulain.

Source/WTF:

Remove the MD5 and SHA1 test cases from the WTF code. The same cases are now built and run under TestWebKitAPI.

* wtf/MD5.cpp:
(WTF::MD5::MD5):
* wtf/SHA1.cpp:
(WTF::SHA1::SHA1):

Tools:

Add the MD5 and SHA1 unit tests that were previously located inside WTF.

* TestWebKitAPI/CMakeLists.txt:
* TestWebKitAPI/GNUmakefile.am:
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WTF/MD5.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::expectMD5):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/SHA1.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::expectSHA1):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/WTF.pro:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Update EFL TextExpectation for WebAudio cases.
commit-queue@webkit.org [Fri, 31 May 2013 08:58:04 +0000 (08:58 +0000)]
[EFL] Update EFL TextExpectation for WebAudio cases.
https://bugs.webkit.org/show_bug.cgi?id=117061.

Unreviewed EFL Gardening.

WebAudio test cases delaynode-max-nondefault-delay.html, delaynode-scheduling.html
and javascriptaudionode.html pass with latest updates in efl port. Updating
TestExpectation accordingly.

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-05-31

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Should pass http/tests/images/png-partial-load-no-alpha.html
noel.gordon@gmail.com [Fri, 31 May 2013 07:15:03 +0000 (07:15 +0000)]
[Mac] Should pass http/tests/images/png-partial-load-no-alpha.html
https://bugs.webkit.org/show_bug.cgi?id=97170

Unreviewed test expectations update.

* platform/mac/TestExpectations: Passing after r150340: remove the
Mac-specfic [ImageOnlyFailure] for this test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoselectionStart/selectionEnd return "obsolete" values when requested during "input...
eustas@chromium.org [Fri, 31 May 2013 05:14:45 +0000 (05:14 +0000)]
selectionStart/selectionEnd return "obsolete" values when requested during "input" event
https://bugs.webkit.org/show_bug.cgi?id=110742

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch defers firing "webkitEditableContentChanged" until new
selection is applied to control. This makes selection during "input"
more consistent and reliable.

Background: "input" event is fired by "webkitEditableContentChanged"
dispatcher. But "input" is scoped event, so under some conditions its
dispatching may be deferred. When "input" dispatching is deferred,
dispatcher observes updated selectionStart and selectionEnd.
Otherwise values repersent state before applying editing command.

So, to make selectionStart/End to be more predictable and useful, we
need either always dispatch "input" before selection is updated, or
always dispatch "input" after selection is updated.

As it was mentioned, dispatching could be deferred by scoping. So
dispatching before updating selection couldn't be guaranteed.
Moreover, it will be hard to calculate updated selection in user
code. On the other side - old selection could be easily tracked.

So, it looks logically that we should guarantee dispatching "input"
after updating selection. There are no execution paths in
"webkitEditableContentChanged" dispatched that depends on current
selection. So it is safe to fire this event after selection is updated.

Test: editing/selection/caret-after-keypress.html

* editing/Editor.cpp:
Dispatch "input" event after new selection in applied.

LayoutTests:

Test that cursor is up-to-date during "input" event.

* editing/selection/caret-after-keypress-expected.txt: Added.
* editing/selection/caret-after-keypress.html: Added.
* platform/mac-wk2/TestExpectations: Exclude new test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, EFL gardening.
gyuyoung.kim@samsung.com [Fri, 31 May 2013 04:32:12 +0000 (04:32 +0000)]
Unreviewed, EFL gardening.

Some of tests in printing are passing on EFL WK2. But, they are still failing on EFL WK1.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Unreviewed build correction.
bfulgham@apple.com [Fri, 31 May 2013 03:59:58 +0000 (03:59 +0000)]
[Windows] Unreviewed build correction.

* Scripts/webkitpy/port/win.py:
(WinPort.create_debugger_command_file): The directory needs to be
a string, not a temporary directory object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] NRWT doesn't save crash logs on Apple's Windows port.
bfulgham@apple.com [Fri, 31 May 2013 03:31:18 +0000 (03:31 +0000)]
[Windows] NRWT doesn't save crash logs on Apple's Windows port.
https://bugs.webkit.org/show_bug.cgi?id=76935

Reviewed by Ryosuke Niwa.

Extend the WinPort class with commands to set and clean up various registry
values needed to invoke the correct debugger to get crash files.

* Scripts/webkitpy/port/win.py:
(WinPort): Added global caches for registry keys and settings
(WinPort._ntsd_location): Added
(WinPort.create_debugger_command_file): Added
(WinPort.read_registry_string): Added
(WinPort.write_registry_string): Added
(WinPort.setup_crash_log_saving): Added
(WinPort.restore_crash_log_saving): Added
(WinPort.setup_test_run): Added overload to add registry settings.
(WinPort.clean_up_test_run): Added overload to clean up registry settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKit's Enter Full Screen for <video> elements isn't working
commit-queue@webkit.org [Fri, 31 May 2013 02:32:03 +0000 (02:32 +0000)]
WebKit's Enter Full Screen for <video> elements isn't working
https://bugs.webkit.org/show_bug.cgi?id=117001

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-05-30
Reviewed by Jer Noble.

Fix workflow to allow a video to enter into full screen
mode from a kWKContextMenuItemTagEnterVideoFullscreen
context menu item by denoting the enterFullscreenForVideo
call as a user gesture, so Document::requestFullScreenForElement
will execute correctly.

No new tests. Covered by media/context-menu-actions.html,
which is disabled due to bug #116651.

* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::enterFullscreenForVideo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIt's easy to hit ASSERT_NOT_REACHED in WKDOMNodeClass
timothy_horton@apple.com [Fri, 31 May 2013 02:05:52 +0000 (02:05 +0000)]
It's easy to hit ASSERT_NOT_REACHED in WKDOMNodeClass
https://bugs.webkit.org/show_bug.cgi?id=117051

Reviewed by Anders Carlsson.

Re-add the ASSERT_NOT_REACHED, and return [WKDOMNode class] in the case
where we don't have a specific subclass.

* WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:
(WebKit::WKDOMNodeClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/js/date-DST-time-cusps.html fails after http://trac.webkit.org/changeset/150833
barraclough@apple.com [Fri, 31 May 2013 01:52:47 +0000 (01:52 +0000)]
fast/js/date-DST-time-cusps.html fails after trac.webkit.org/changeset/150833
https://bugs.webkit.org/show_bug.cgi?id=116895
<rdar://problem/4777813> Safari incorrectly handles times that shouldn't exist
https://bugs.webkit.org/show_bug.cgi?id=11157

Reviewed by Alexey Proskuryakov.

Accidental progression, updating results to expect success.

* TestExpectations:
    - Remove expectations of failure.
* fast/js/script-tests/date-DST-time-cusps.js:
    - Prefer the latter option for non-existent time (due to clock rolling forward).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother unreviewed speculative build fix for Mac.
roger_fong@apple.com [Fri, 31 May 2013 01:52:39 +0000 (01:52 +0000)]
Another unreviewed speculative build fix for Mac.

* wtf/text/WTFString.h:
(WTF::String::fromUTF8WithLatin1Fallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix jscore-test when not using --sdk option with jsDriver.pl
dfarler@apple.com [Fri, 31 May 2013 01:46:19 +0000 (01:46 +0000)]
Fix jscore-test when not using --sdk option with jsDriver.pl
https://bugs.webkit.org/show_bug.cgi?id=116339

Reviewed by Joe Pecoraro.

* tests/mozilla/jsDriver.pl:
(execute_tests):
With each test, the shell_command needs to be started from scratch.

This fix will clear the shell_command and start over as before with
the opt_arch option when not using --sdk with jsDriver.pl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix for Mac.
roger_fong@apple.com [Fri, 31 May 2013 01:07:10 +0000 (01:07 +0000)]
Unreviewed build fix for Mac.

* wtf/OSAllocator.h:
* wtf/text/WTFString.h:
(WTF::String::fromUTF8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix double hash lookup in RenderTableSection::paintObject loop
rafael.lobo@openbossa.org [Fri, 31 May 2013 00:53:31 +0000 (00:53 +0000)]
Fix double hash lookup in RenderTableSection::paintObject loop
https://bugs.webkit.org/show_bug.cgi?id=117055

Reviewed by Antonio Gomes.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of JavaScript exports file on AppleWin port.
roger_fong@apple.com [Fri, 31 May 2013 00:38:15 +0000 (00:38 +0000)]
Get rid of JavaScript exports file on AppleWin port.
https://bugs.webkit.org/show_bug.cgi?id=117050.

Reviewed by Darin Adler.

This requires turning WTF into a shared library and adding the WTF_EXPORT_PRIVATE to some methods where it was missed.
Start linking in WTF.lib now that it's a shared library.
Also, delete the JavaScriptCoreExportGenerator folder and remove dependencies.

* JavaScriptCore.vcxproj/JavaScriptCore.submit.sln:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator: Removed.
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj: Removed.
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.filters: Removed.
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorBuildCmd.cmd: Removed.
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props: Removed.
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorDebug.props: Removed.
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPostBuild.cmd: Removed.
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPreBuild.cmd: Removed.
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorProduction.props: Removed.
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorRelease.props: Removed.
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in: Removed.
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/make-export-file-generator: Removed.
* JavaScriptCore.vcxproj/jsc/jscCommon.props:
* JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
* JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj.filters:
* JavaScriptCore.vcxproj/testRegExp/testRegExpCommon.props:
* JavaScriptCore.vcxproj/testapi/testapiCommon.props:
* WTF.vcxproj/WTF.vcxproj:
* WTF.vcxproj/WTFCommon.props:
* wtf/DateMath.h:
* wtf/ExportMacros.h:
* wtf/FilePrintStream.h:
* wtf/OSAllocator.h:
* wtf/PageAllocationAligned.h:
* wtf/Platform.h:
* wtf/PrintStream.h:
* wtf/StackBounds.h:
* wtf/StringPrintStream.h:
* wtf/ThreadSpecific.h:
* wtf/WTFThreadData.h:
* wtf/dtoa/cached-powers.h:
* wtf/dtoa/double-conversion.h:
* wtf/text/WTFString.h:
* wtf/unicode/Collator.h:
* wtf/unicode/UTF8.h:
* WebKit.vcxproj/WebKit.sln:
* WebKit.vcxproj/WebKit/WebKitCommon.props:
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd --sdk option to jsDriver.pl to run with iOS Simulator
dfarler@apple.com [Fri, 31 May 2013 00:16:29 +0000 (00:16 +0000)]
Add --sdk option to jsDriver.pl to run with iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=116339

Reviewed by David Kilzer.

* tests/mozilla/jsDriver.pl:
(execute_tests):
Prefix shell command with the path to the "sim" tool.
(parse_args):
Add -d / --sdk option.
(usage):
Help message for -d / --sdk option.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[sh4] Optimize NaN checks in LLINT for floating point comparisons.
commit-queue@webkit.org [Thu, 30 May 2013 23:21:17 +0000 (23:21 +0000)]
[sh4] Optimize NaN checks in LLINT for floating point comparisons.
https://bugs.webkit.org/show_bug.cgi?id=117049

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-30
Reviewed by Oliver Hunt.

Use the fcmp/eq opcode in sh4 LLINT to test if a double is NaN.
This is more efficient, doesn't require two tmp registers and requires
less code than current implementation (which converts double to float,
then checks 'E = Emax + 1' and 'f != 0').

* offlineasm/sh4.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix double hash lookup in WebSocket::connect loop
rafael.lobo@openbossa.org [Thu, 30 May 2013 23:15:36 +0000 (23:15 +0000)]
Fix double hash lookup in WebSocket::connect loop
https://bugs.webkit.org/show_bug.cgi?id=117052

Reviewed by Anders Carlsson.

* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSCallbackObject does not correctly initialise the PropertySlot for getOwnPropertyDes...
oliver@apple.com [Thu, 30 May 2013 22:58:12 +0000 (22:58 +0000)]
JSCallbackObject does not correctly initialise the PropertySlot for getOwnPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=117053

Reviewed by Mark Hahnenberg.

Set appropriate thisValue on the PropertySlot

* API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertyDescriptor):
* API/tests/testapi.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove ASSERT_NOT_REACHED from WKDOMNodeClass
timothy_horton@apple.com [Thu, 30 May 2013 22:55:28 +0000 (22:55 +0000)]
Remove ASSERT_NOT_REACHED from WKDOMNodeClass
https://bugs.webkit.org/show_bug.cgi?id=117051

Reviewed by Anders Carlsson.

It's easy to fail this assertion in seemingly-legitimate cases.

* WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:
(WebKit::WKDOMNodeClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Updated as-IN translations
kov@webkit.org [Thu, 30 May 2013 22:47:36 +0000 (22:47 +0000)]
[GTK] Updated as-IN translations
https://bugs.webkit.org/show_bug.cgi?id=116953

Patch by Nilamdyuti Goswami <ngoswami@redhat.com> on 2013-05-30
Reviewed by Gustavo Noronha Silva (kov).

* as.po: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/dom/location-new-window-no-crash.html times out flakily on mac-wk2
timothy_horton@apple.com [Thu, 30 May 2013 21:31:21 +0000 (21:31 +0000)]
fast/dom/location-new-window-no-crash.html times out flakily on mac-wk2
https://bugs.webkit.org/show_bug.cgi?id=117037

Reviewed by Alexey Proskuryakov.

Close the window on a zero-delay timer, working around a bug where WKTR
will hang if a window is closed while a load is in progress.

Doesn't affect the test in an important way.

* fast/dom/script-tests/location-new-window-no-crash.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove some 16bits conversion.
benjamin@webkit.org [Thu, 30 May 2013 21:15:46 +0000 (21:15 +0000)]
Remove some 16bits conversion.
https://bugs.webkit.org/show_bug.cgi?id=116935

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-30
Reviewed by Darin Adler.

Merge chromium ce35a544d09e6cb907457535340eb0e9984e57b8.
https://chromium.googlesource.com/chromium/blink/+/ce35a544d09e6cb907457535340eb0e9984e57b8

* html/parser/InputStreamPreprocessor.h:
* platform/FileSystem.cpp:
(WebCore::encodeForFileName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r119759): Adobe Flash Player "smaller" installer relies on the incorrect...
andersca@apple.com [Thu, 30 May 2013 20:50:03 +0000 (20:50 +0000)]
REGRESSION (r119759): Adobe Flash Player "smaller" installer relies on the incorrect firing of a load event and needs an app-specific hack for compatibility
https://bugs.webkit.org/show_bug.cgi?id=117042
<rdar://problem/13916291>

Reviewed by Mark Rowe.

Ignore HTTP errors for scripts requested from within the installer. Instead of just checking for the
Adobe Flash installer, we use the "com.solidstatenetworks.awkhost" bundle identifier to determine
whether to apply the workaround. This could in theory fix other installers that use the same mechanism.

* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::shouldIgnoreHTTPStatusCodeErrors):
* loader/cache/CachedScript.h:
* platform/RuntimeApplicationChecks.cpp:
(WebCore::applicationIsSolidStateNetworksDownloader):
* platform/RuntimeApplicationChecks.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Fix pass_by_value coverity warning in ChromeClientGtk
commit-queue@webkit.org [Thu, 30 May 2013 20:39:15 +0000 (20:39 +0000)]
[GTK] Fix pass_by_value coverity warning in ChromeClientGtk
https://bugs.webkit.org/show_bug.cgi?id=117021

Patch by Enrique Ocana Gonzalez <eocanha@igalia.com> on 2013-05-30
Reviewed by Anders Carlsson.

Pass dirtyRegion parameter in paintWebView() by reference to avoid object copying.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::paintWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate XMLHttpRequest timeout tests to a newer version from W3C
zandobersek@gmail.com [Thu, 30 May 2013 18:34:56 +0000 (18:34 +0000)]
Update XMLHttpRequest timeout tests to a newer version from W3C
https://bugs.webkit.org/show_bug.cgi?id=117023

Reviewed by Alexey Proskuryakov.

The XMLHttpRequest Timeout tests have gone through a bit of restructuring and should
be updated. This is being primarily done because of the intention of updating the
testharness scripts which would break these tests if they were left not updated.

These tests were updated from the W3C web-platform-tests GitHub repository.
https://github.com/w3c/web-platform-tests

* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html:
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.js: Added.
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.html:
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.js: Added.
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overrides-expected.txt: Added.
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overrides.html: Added.
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overrides.js: Added.
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html:
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.js: Added.
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-runner.js:
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html:
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.js: Added.
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain.html:
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain.js: Added.
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconworker.js: Added.
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html:
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.js: Added.
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html:
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overrides-expected.txt: Added.
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overrides.html: Added.
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html:
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html:
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html:
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice.html:
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout.js:
(RequestTracker.prototype.startXHR):
(AbortedRequest.prototype.startXHR.handleEvent):
(runTestRequests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAllow no space between "background-position:" dimensions
sergio@webkit.org [Thu, 30 May 2013 18:20:32 +0000 (18:20 +0000)]
Allow no space between "background-position:" dimensions
https://bugs.webkit.org/show_bug.cgi?id=116870

Reviewed by Darin Adler.

From Blink r149314 by <ericwilligers@chromium.org>

Source/WebCore:

Specs allow no spaces between the dimensions of a
"background-position:" like "1px+1px", we should support
that.

Whitespaces are no longer early consumed, dramatically dropping
the shift/reduce conflicts to half. The productions unary_term,
calc_func_term, calc_func_expr and calc_func_paren_expr no longer
consume whitespaces.

* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParser::realLex):

LayoutTests:

* fast/backgrounds/background-position-parsing-2-expected.txt:
* fast/backgrounds/background-position-parsing-2.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHTMLMediaElement will not unthrottle page when playback stops for nreasons other...
jer.noble@apple.com [Thu, 30 May 2013 18:19:00 +0000 (18:19 +0000)]
HTMLMediaElement will not unthrottle page when playback stops for nreasons other than user-initiated pause.
https://bugs.webkit.org/show_bug.cgi?id=117016

Reviewed by Oliver Hunt.

Add a new class PageActivityAssertionToken to allow HTMLMediaElement to decouple
knowledge of and control over the lifetime of PageThrottler. The new class will
have weak references to and from the PageThrottler so that holders of the token
will not need to care if the Page or PageThrottler has been destroyed.

HTMLMediaElement will create one of these PageActivityAssertionTokens when playback
begins and destroy it when playback stops for any reason, or when the element is
destroyed.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::pauseInternal):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::updatePlayState):
* html/HTMLMediaElement.h:
* page/Page.cpp:
(WebCore::createActivityToken): Added simple factory method.
* page/Page.h:
* page/PageActivityAssertionToken.cpp:
(WebCore::PageActivityAssertionToken::PageActivityAssertionToken): Call addActivityToken();
(WebCore::PageActivityAssertionToken::~PageActivityAssertionToken): Call removeActivityToken();
(WebCore::PageActivityAssertionToken::invalidate): Clear m_throttler.
* page/PageActivityAssertionToken.h:
* page/PageThrottler.cpp:
(WebCore::PageThrottler::~PageThrottler): Invalidate all outstanding tokens.
(WebCore::PageThrottler::addActivityToken): Bump the activity count.
(WebCore::PageThrottler::removeActivityToken): Lower the activity count.
* page/PageThrottler.h:

Add the new files to the various build systems:
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Enable cache partitioning and the public suffix list on 10.8
jpfau@apple.com [Thu, 30 May 2013 17:52:33 +0000 (17:52 +0000)]
[Mac] Enable cache partitioning and the public suffix list on 10.8
<rdar://problem/13679019>

Rubber-stamped by David Kilzer.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

WebKitLibraries:

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceMountainLion.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix double hash lookup in DocumentEventQueue::cancelEvent().
akling@apple.com [Thu, 30 May 2013 17:09:07 +0000 (17:09 +0000)]
Fix double hash lookup in DocumentEventQueue::cancelEvent().
<http://webkit.org/b/117031>

Reviewed by Anders Carlsson.

* dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::cancelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix double hash lookup in WebPage::determinePrimarySnapshottedPlugIn() loop.
akling@apple.com [Thu, 30 May 2013 17:06:52 +0000 (17:06 +0000)]
Fix double hash lookup in WebPage::determinePrimarySnapshottedPlugIn() loop.
<http://webkit.org/b/117032>

Reviewed by Anders Carlsson.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150968 268f45cc-cd09-0410-ab3c-d52691b4dbfc