WebKit-https.git
8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 16 Aug 2012 14:16:16 +0000 (14:16 +0000)]
Unreviewed GTK gardening.

Adding a platform-specific baseline after r125772.

* platform/gtk/http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening after r125758, r125759
commit-queue@webkit.org [Thu, 16 Aug 2012 13:57:06 +0000 (13:57 +0000)]
[EFL] Gardening after r125758, r125759
https://bugs.webkit.org/show_bug.cgi?id=94215

Unreviewed, gardening.

Newly added tests: compositing/overflow/overflow-hidden-canvas-layer.html,
fast/forms/file/selected-files-from-history-state.html fail on EFL and need gardening.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-16

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake GraphicsSurface double buffered by default.
zeno.albisser@nokia.com [Thu, 16 Aug 2012 13:24:22 +0000 (13:24 +0000)]
Make GraphicsSurface double buffered by default.
https://bugs.webkit.org/show_bug.cgi?id=93252

Create only a single GraphicsSurface per canvas
on both supported platforms Mac/Linux.
The GraphicsSurface on Mac internally uses two IOSurface
to provide a front and a back buffer.
The GLX implementation of GraphicsSurface uses
an XWindow which already provides a front and a back buffer.

Reviewed by Noam Rosenthal.

Source/WebCore:

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(GraphicsContext3DPrivate):
    Remove creation of second GraphicsSurface.
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
(WebCore):
(WebCore::GraphicsContext3DPrivate::graphicsSurfaceToken):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurfaces):
* platform/graphics/surfaces/GraphicsSurface.cpp:
(WebCore::GraphicsSurface::create):
    Adjust token type to uint64_t.
(WebCore::GraphicsSurface::exportToken):
    Adjust return type to uint64_t.
(WebCore::GraphicsSurface::frontBuffer):
(WebCore):
(WebCore::GraphicsSurface::swapBuffers):
    Add forwarding function to swap buffers inside GraphicsSurface.
* platform/graphics/surfaces/GraphicsSurface.h:
(GraphicsSurface):
    Add SupportsSingleBuffered flag to allow for single buffered implementations.
    Currently single buffered surfaces are either not implemented or disabled.
* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
    Move implementation details into GraphicsSurfacePrivate.
    This way the platform specific code can be hidden in the specific cpp file
    instead of polluting the global GraphicsSurface header.
(WebCore::createTexture):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurfacePrivate::token):
(WebCore::GraphicsSurfacePrivate::frontBufferTextureID):
(WebCore::GraphicsSurfacePrivate::backBufferTextureID):
(WebCore::GraphicsSurfacePrivate::frontBuffer):
(WebCore::GraphicsSurfacePrivate::backBuffer):
(WebCore):
(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformCopyToGLTexture):
(WebCore::GraphicsSurface::platformCopyFromFramebuffer):
(WebCore::GraphicsSurface::platformFrontBuffer):
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::ioSurfaceLockOptions):
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
(WebCore::GraphicsSurface::platformDestroy):
* platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::OffScreenRootWindow::get):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
    Make sure that framebuffer bindings remain consistent
    after swapping buffers on the XWindow.
(WebCore::GraphicsSurface::platformExport):
    Make sure the GLXPixmap is only bound to the texture once.
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformCopyFromFramebuffer):
(WebCore):
(WebCore::GraphicsSurface::platformFrontBuffer):
    The GLX surface does not know how to destinguish between
    the front and the back buffer by an id. This is not necessary
    for GraphicsSurfaceGLX, because the texture can just be
    read from the XWindow at any time.
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
* platform/graphics/texmap/TextureMapperBackingStore.cpp:
    Remove code that was used for switching between two GraphicsSurfaces,
    as this is now handled directly inside GraphicsSurface.
(WebCore::TextureMapperSurfaceBackingStore::setGraphicsSurface):
(WebCore::TextureMapperSurfaceBackingStore::paintToTextureMapper):
(WebCore::TextureMapperSurfaceBackingStore::setSurface):
(WebCore):
* platform/graphics/texmap/TextureMapperBackingStore.h:
    Remove GraphicsSurfaceData struct. This class is not needed anymore
    as we do not keep track of more than one GraphicsSurface at the time.
(WebCore):
(TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::graphicsSurface):
(WebCore::TextureMapperSurfaceBackingStore::TextureMapperSurfaceBackingStore):
* platform/graphics/texmap/TextureMapperPlatformLayer.h:
(WebCore::TextureMapperPlatformLayer::graphicsSurfaceToken):

Source/WebKit2:

* Shared/ShareableSurface.h:
(Handle):
    Change the type of GraphicsSurface token to uint64_t.
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::syncCanvas):
    Add a parameter that denotes the current front buffer of the
    GraphicsSurface.
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::syncCanvas):
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::syncCanvas):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::syncCanvas):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement the form-action Content Security Policy directive.
commit-queue@webkit.org [Thu, 16 Aug 2012 12:42:09 +0000 (12:42 +0000)]
Implement the form-action Content Security Policy directive.
https://bugs.webkit.org/show_bug.cgi?id=93777

Patch by Mike West <mkwst@chromium.org> on 2012-08-16
Reviewed by Jochen Eisinger.

Source/WebCore:

The CSP 1.1 editor's draft defines the 'form-action' directive as a
mechanism for whitelisting valid targets for form submission from a
protected resource. A web author might desire to restrict form
submissions to the same origin as the protected resource itself via
a Content Security Policy of "form-action 'self'", or ensure that all
submissions were sent over an SSL connection via "form-action https:".

Specification details available at: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#form-action--experimental

This experimental directive is gated on the ENABLE_CSP_NEXT flag, which
is currently only enabled in Chromium.

Tests: http/tests/security/contentSecurityPolicy/1.1/form-action-src-allowed.html
       http/tests/security/contentSecurityPolicy/1.1/form-action-src-blocked.html
       http/tests/security/contentSecurityPolicy/1.1/form-action-src-default-ignored.html
       http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-allowed.html
       http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked.html
       http/tests/security/contentSecurityPolicy/1.1/form-action-src-javascript-blocked.html
       http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkIfFormActionAllowedByCSP):
    Adding a callback to FrameLoader in order to allow the
    MainResourceLoader to check the relevant CSP status without knowing
    anything about CSP.
(WebCore):
* loader/FrameLoader.h:
(FrameLoader):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::willSendRequest):
    Check against the protected resource's Content Security Policy when
    presented with a request that is itself a form submission, or is the
    result of a redirect in response to a form submission. If CSP would
    block the target, cancel the request.
* page/ContentSecurityPolicy.cpp:
(CSPDirectiveList):
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
    Added explanatory text to the source violation console warning that
    specifically calls out sending form data (as opposed to "connect to"
    or "load the").
(WebCore::CSPDirectiveList::allowFormAction):
    Check a URL against a directive list's the 'form-action' source list.
(WebCore):
(WebCore::CSPDirectiveList::addDirective):
    Recognize the 'form-action' CSP directive.
(WebCore::ContentSecurityPolicy::allowFormAction):
    Public interface to check a form action.
* page/ContentSecurityPolicy.h:

LayoutTests:

* http/tests/navigation/resources/redirection-response.php:
    Allow for the specification of alternate hosts for the redirect. We
    need this capability in order to check that an initial submission
    followed by a blocked redirect results in the correct behavior.
* http/tests/security/contentSecurityPolicy/1.1/form-action-src-allowed-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/form-action-src-allowed.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/form-action-src-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/form-action-src-blocked.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/form-action-src-default-ignored-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/form-action-src-default-ignored.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-allowed-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-allowed.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/form-action-src-javascript-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/form-action-src-javascript-blocked.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] WebGL and Canvas fail to display after being restored from page cache
commit-queue@webkit.org [Thu, 16 Aug 2012 12:12:36 +0000 (12:12 +0000)]
[BlackBerry] WebGL and Canvas fail to display after being restored from page cache
https://bugs.webkit.org/show_bug.cgi?id=94105

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-16
Reviewed by George Staikos.

The EGLImage was being destroyed when releasing layer resources on the
compositing thread, but the WebKit thread layer never found out and
failed to create a new image.

Fixed by extending the release layer resources mechanism to also make a
pass on the WebKit thread so that thread's layers have a chance to
delete their textures and related resources.

Source/WebCore:

WebGL and canvas layers now take this opportunity to release their
textures so the EGLImage gets recreated when compositing commits
resume.

The only detail that deserves extra explanation is the ownership of the
EGLImage.

Since the EGLImage is created in updateTextureContentsIfNeeded() and
that one is always followed by commitPendingTextureUploads() which
transfers the EGLImage to the compositing thread layer's custody, the
EGLImage currently referenced by EGLImageLayerWebKitThread::m_image
should never be deleted by the WebKit thread layer.

Thus all we have to do in deleteFrontBuffer() is to set the m_image
member to 0 so the image gets recreated on the next commit. It will be
deleted by the part of releaseLayerResources() that executes on the
compositing thread (which, if you recall, was the original source of
this bug).

Reviewed internally by Filip Spacek.

PR 192899

Not currently testable by the BlackBerry testing infrastructure.

* platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
(WebCore::CanvasLayerWebKitThread::deleteTextures):
(WebCore):
* platform/graphics/blackberry/CanvasLayerWebKitThread.h:
(CanvasLayerWebKitThread):
* platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:
(WebCore::EGLImageLayerWebKitThread::~EGLImageLayerWebKitThread):
(WebCore::EGLImageLayerWebKitThread::deleteFrontBuffer):
* platform/graphics/blackberry/EGLImageLayerWebKitThread.h:
(EGLImageLayerWebKitThread):
* platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::releaseLayerResources):
(WebCore):
* platform/graphics/blackberry/LayerWebKitThread.h:
(LayerWebKitThread):
(WebCore::LayerWebKitThread::deleteTextures):
* platform/graphics/blackberry/WebGLLayerWebKitThread.cpp:
(WebCore::WebGLLayerWebKitThread::~WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::deleteTextures):
(WebCore):
* platform/graphics/blackberry/WebGLLayerWebKitThread.h:
(WebGLLayerWebKitThread):

Source/WebKit/blackberry:

Reviewed internally by Filip Spacek.

PR 192899

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::releaseLayerResources):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::releaseLayerResourcesCompositingThread):
(BlackBerry::WebKit::WebPagePrivate::suspendRootLayerCommit):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebKitSupport/FrameLayers.cpp:
(BlackBerry::WebKit::FrameLayers::releaseLayerResources):
(WebKit):
* WebKitSupport/FrameLayers.h:
(FrameLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: enable instrumentation of platform code
caseq@chromium.org [Thu, 16 Aug 2012 12:06:20 +0000 (12:06 +0000)]
Web Inspector: enable instrumentation of platform code
https://bugs.webkit.org/show_bug.cgi?id=94125

Reviewed by Pavel Feldman.

- add PlatformInstrumentation class that exposes instrumentation methods that may be used by code under WebCore/platform;
- move TRACE_EVENT_XXX() macros into PlatformInstrumentation.h to minimize instrumentation hassle in the client code;
- implement PlatformInstrumentationClient by InspectorTimelineAgent;
- only install PlatformInstrumentationClient when we have outer events for which we expect low-level details

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willDecodeImage): to be implemented by subsequent change;
(WebCore::InspectorTimelineAgent::didDecodeImage): to be implemented by subsequent change;
(WebCore::InspectorTimelineAgent::willResizeImage): to be implemented by subsequent change;
(WebCore::InspectorTimelineAgent::didResizeImage): to be implemented by subsequent change;
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::clearRecordStack):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
* platform/PlatformInstrumentation.cpp: Added.
(WebCore):
(WebCore::PlatformInstrumentation::setClient):
* platform/PlatformInstrumentation.h: Added.
(WebCore):
(PlatformInstrumentationClient):
(PlatformInstrumentation):
(WebCore::PlatformInstrumentation::hasClient):
(WebCore::PlatformInstrumentation::willDecodeImage):
(WebCore::PlatformInstrumentation::didDecodeImage):
(WebCore::PlatformInstrumentation::willResizeImage):
(WebCore::PlatformInstrumentation::didResizeImage):
* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::resizedBitmap): added calls to PlatformInstrumentation, removed TRACE_EVENT();
* platform/image-decoders/bmp/BMPImageDecoder.cpp:
(WebCore::BMPImageDecoder::frameBufferAtIndex): added calls to PlatformInstrumentation;
(WebCore::BMPImageDecoder::decode): removed TRACE_EVENT()
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::frameBufferAtIndex): added calls to PlatformInstrumentation;
(WebCore::GIFImageDecoder::decode): removed TRACE_EVENT()
* platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::frameBufferAtIndex): added calls to PlatformInstrumentation;
(WebCore::ICOImageDecoder::decode): removed TRACE_EVENT()
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::frameBufferAtIndex): added calls to PlatformInstrumentation;
(WebCore::JPEGImageDecoder::decode): removed TRACE_EVENT()
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::frameBufferAtIndex): added calls to PlatformInstrumentation;
* platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::frameBufferAtIndex): added calls to PlatformInstrumentation;
(WebCore::WEBPImageDecoder::decode): removed TRACE_EVENT();
* inspector/InspectorInstrumentation.cpp: removed orphan event support;
(WebCore):
* inspector/InspectorInstrumentation.h: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Update pixel test expectations for layout test fast/dom/
commit-queue@webkit.org [Thu, 16 Aug 2012 11:54:10 +0000 (11:54 +0000)]
[EFL] Update pixel test expectations for layout test fast/dom/
https://bugs.webkit.org/show_bug.cgi?id=94177

Unreviewed, rebaseline.

Some tests have wrong pixel test results. They should be replaced.

And, two tests related image seem to fail. Alt text should be displayed
if src attribute is not set.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-16

* platform/efl/TestExpectations: Added two tests related to display alt text without src.
* platform/efl/fast/dom/34176-expected.png:
* platform/efl/fast/dom/Element/class-attribute-whitespace-expected.png:
* platform/efl/fast/dom/HTMLElement/bdo-expected.png:
* platform/efl/fast/dom/HTMLHeadElement/head-link-style-href-check-expected.png:
* platform/efl/fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.png:
* platform/efl/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
* platform/efl/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
* platform/efl/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
* platform/efl/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
* platform/efl/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
* platform/efl/fast/dom/HTMLMeterElement/meter-styles-expected.png:
* platform/efl/fast/dom/HTMLObjectElement/vspace-hspace-as-number-expected.png:
* platform/efl/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
* platform/efl/fast/dom/HTMLTableElement/colSpan-expected.png:
* platform/efl/fast/dom/HTMLTableElement/createCaption-expected.png:
* platform/efl/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
* platform/efl/fast/dom/Range/surroundContents-1-expected.png:
* platform/efl/fast/dom/Window/open-existing-pop-up-blocking-expected.png:
* platform/efl/fast/dom/blur-contenteditable-expected.png:
* platform/efl/fast/dom/children-nodes-expected.png:
* platform/efl/fast/dom/clone-contents-0-end-offset-expected.png:
* platform/efl/fast/dom/css-rule-functions-expected.png:
* platform/efl/fast/dom/focus-contenteditable-expected.png:
* platform/efl/fast/dom/gc-10-expected.png:
* platform/efl/fast/dom/importNodeHTML-expected.png:
* platform/efl/fast/dom/importNodeXML-expected.png:
* platform/efl/fast/dom/row-inner-text-expected.png:
* platform/efl/fast/dom/scroll-reveal-left-overflow-expected.png:
* platform/efl/fast/dom/scroll-reveal-top-overflow-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Breakpoints are not correctly restored on reload.
vsevik@chromium.org [Thu, 16 Aug 2012 11:42:13 +0000 (11:42 +0000)]
Web Inspector: Breakpoints are not correctly restored on reload.
https://bugs.webkit.org/show_bug.cgi?id=94209

Reviewed by Pavel Feldman.

Source/WebCore:

BreakpointManager now resets uiLocations on workspace reset (was doing it on GlobalObjectCleared).
Breakpoint manager now calls restoreBreakpoints automatically when uiSourceCode is added to workspace.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype._uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype._workspaceReset):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
* inspector/front-end/inspector.js:

LayoutTests:

restoreBreakpoints is not called inside the test anymore to test that it is called automatically.

* inspector/debugger/breakpoint-manager-expected.txt:
* inspector/debugger/breakpoint-manager.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Remove FontQt4, HAVE_QRAWFONT flag and the related dead code
pierre.rossi@gmail.com [Thu, 16 Aug 2012 10:53:07 +0000 (10:53 +0000)]
[Qt] Remove FontQt4, HAVE_QRAWFONT flag and the related dead code
https://bugs.webkit.org/show_bug.cgi?id=93960

Reviewed by Simon Hausmann.

Following the removal of Qt 4 support from trunk in r124879.

Source/WebCore:

No new tests. Simple cleanup job.

* Target.pri:
* platform/graphics/Font.cpp:
(WebCore::Font::codePath):
* platform/graphics/Font.h:
(Font):
* platform/graphics/GraphicsContext.cpp:
(WebCore):
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::platformGlyphInit):
(WebCore::SimpleFontData::glyphForCharacter):
* platform/graphics/SimpleFontData.h:
(SimpleFontData):
(WebCore::SimpleFontData::widthForGlyph):
* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::rawFontForCharacters):
(WebCore::FontCache::getFontDataForCharacters):
* platform/graphics/qt/FontCustomPlatformData.h:
(FontCustomPlatformData):
* platform/graphics/qt/FontCustomPlatformDataQt.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::createFontCustomPlatformData):
* platform/graphics/qt/FontPlatformData.h:
(WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
(FontPlatformDataPrivate):
(FontPlatformData):
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator==):
(WebCore::FontPlatformData::hash):
* platform/graphics/qt/FontQt4.cpp: Removed.
* platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
(WebCore::GlyphPage::fill):
* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformCharWidthInit):
* rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceSimpleText):
(WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):

Source/WebKit/blackberry:

* WebCoreSupport/AboutDataHaveFeatures.in: Remove all traces of HAVE_QRAWFONT's existence.

Source/WebKit2:

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::getWebCoreStatistics):

Tools:

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening after r125592, r125635
commit-queue@webkit.org [Thu, 16 Aug 2012 09:56:41 +0000 (09:56 +0000)]
[EFL] Gardening after r125592, r125635
https://bugs.webkit.org/show_bug.cgi?id=94197

Unreviewed gardening.

Gardening of fast/overflow/line-clamp-and-columns.html and
http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-16

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDOMWindowPagePopup needs to be installed before loading the html inside the page...
keishi@webkit.org [Thu, 16 Aug 2012 09:28:20 +0000 (09:28 +0000)]
DOMWindowPagePopup needs to be installed before loading the html inside the page popup
https://bugs.webkit.org/show_bug.cgi?id=94193

Reviewed by Kent Tamura.

We are using window.pagePopupController.localizeNumberString while loading so we need to install DOMWindowPagePopup before loading the html.

* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::initPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: memory instrumentation for Resource{Request/Response}Base
yurys@chromium.org [Thu, 16 Aug 2012 09:18:34 +0000 (09:18 +0000)]
Web Inspector: memory instrumentation for Resource{Request/Response}Base
https://bugs.webkit.org/show_bug.cgi?id=94109

Reviewed by Vsevolod Vlasov.

Added reportMemoryUsage methods to ResourceRequestBase, ResourceResponseBase
and several related classes.

* dom/MemoryInstrumentation.cpp:
(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl): added overrides
for String, StringImpl and AtomicString object types so that we can reuse
existing addInstrumentedCollection method instead of adding a counterpart
that would operate on not instrumented content. Next step would be to get
rid od addObject overrides for these types so that all kinds of Strings are
considered as instrumented classes despite they don't have reportMemoryUsage
method.
(WebCore):
* dom/MemoryInstrumentation.h:
(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
(MemoryInstrumentation):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
* platform/network/FormData.cpp:
(WebCore::FormData::reportMemoryUsage):
(WebCore):
* platform/network/FormData.h:
(WebCore):
(FormData):
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsage):
(WebCore):
* platform/network/ResourceRequestBase.h:
(ResourceRequestBase):
* platform/network/ResourceResponseBase.cpp:
(WebCore):
(WebCore::ResourceResponseBase::reportMemoryUsage):
* platform/network/ResourceResponseBase.h:
(WebCore):
(ResourceResponseBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Add unit tests for Web intent registration
commit-queue@webkit.org [Thu, 16 Aug 2012 09:12:57 +0000 (09:12 +0000)]
[EFL][WK2] Add unit tests for Web intent registration
https://bugs.webkit.org/show_bug.cgi?id=94133

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-16
Reviewed by Kenneth Rohde Christiansen.

Add unit tests for Web Intent service registration.
This tests the "intent,service,register" signaling
on the Ewk_View as well as Ewk_Intent_Service.

* PlatformEfl.cmake:
* UIProcess/API/efl/tests/resources/intent-service.html: Added.
* UIProcess/API/efl/tests/test_ewk2_intents.cpp: Added.
(onIntentServiceRegistration):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDelete DOMWindow::securityOrigin()
abarth@webkit.org [Thu, 16 Aug 2012 09:09:42 +0000 (09:09 +0000)]
Delete DOMWindow::securityOrigin()
https://bugs.webkit.org/show_bug.cgi?id=93991

Reviewed by Eric Seidel.

DOMWindow::securityOrigin() just calls through to
document()->securityOrigin(). This patch updates all the callers to do
that work themselves, making it clearer what's going on at each call
site.

* bindings/generic/BindingSecurity.cpp:
(WebCore::canAccessDocument):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::allowsAccessFrom):
* bindings/js/JSDOMWindowCustom.h:
(WebCore::JSDOMWindowBase::allowsAccessFromPrivate):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::collectIsolatedContexts):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::isInsecureScriptAccess):
(WebCore::DOMWindow::createWindow):
* page/DOMWindow.h:
(DOMWindow):
* page/Location.cpp:
(WebCore::Location::reload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r125751.
commit-queue@webkit.org [Thu, 16 Aug 2012 08:54:22 +0000 (08:54 +0000)]
Unreviewed, rolling out r125751.
http://trac.webkit.org/changeset/125751
https://bugs.webkit.org/show_bug.cgi?id=94206

we shouldn't be rolling out this patch without a formal
review. (Requested by rniwa_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-16

* dom/CharacterData.cpp:
(WebCore::CharacterData::setDataAndUpdate):
* editing/FrameSelection.cpp:
(WebCore::updatePositionAfterAdoptingTextReplacement):
(WebCore::FrameSelection::textWasReplaced):
* editing/FrameSelection.h:
(FrameSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago.: FormController, WebHistoryItem: Enable reading selected file names from document...
commit-queue@webkit.org [Thu, 16 Aug 2012 08:52:25 +0000 (08:52 +0000)]
.: FormController, WebHistoryItem: Enable reading selected file names from document state
https://bugs.webkit.org/show_bug.cgi?id=91231

Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
Reviewed by Jochen Eisinger.

This change enables Chromium to set up file permissions properly when
the session restore feature restores a page with selected files.

* Source/autotools/symbols.filter: Exported FormController::getReferencedFilePaths and HistoryController::saveDocumentAndScrollState.

Source/WebCore: FormController, FileInputType: Enable reading selected file names from document state
https://bugs.webkit.org/show_bug.cgi?id=91231

Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
Reviewed by Jochen Eisinger.

This change enables Chromium to set up file permissions properly when
the session restore feature restores a page with selected files.

Test: fast/forms/file/selected-files-from-history-state.html

* WebCore.exp.in: Exported FormController::getReferencedFilePaths.
* html/FileInputType.cpp:
(WebCore::FileInputType::filesFromFormControlState): Added. Extracts FileChooserFileInfos from a FormControlState.
(WebCore):
(WebCore::FileInputType::restoreFormControlState): Refactored to use filesFromFormControlState.
* html/FileInputType.h:
(FileInputType): Added filesFromFormControlState.
* html/FormController.cpp:
(SavedFormState): Added getReferencedFilePaths.
(WebCore::SavedFormState::getReferencedFilePaths): Added. Extracts selected file paths from SavedFormState.
(WebCore):
(WebCore::FormController::setStateForNewFormElements): Refactored to use formStatesFromStateVector.
(WebCore::FormController::formStatesFromStateVector):
(WebCore::FormController::getReferencedFilePaths): Added. Static. Extracts selected file paths from a document state.
* html/FormController.h:
(FormController): Added getReferencedFilePaths and formStatesFromStateVector.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::filesFromFileInputFormControlState): Added. Delegates to FileInputType::filesFromFormControlState.
(WebCore):
* html/HTMLInputElement.h: Added filesFromFileInputFormControlState.
(HTMLInputElement):
* testing/Internals.cpp:
(WebCore::Internals::getReferencedFilePaths): Calls FormController::getReferencedFilePaths.
(WebCore):
* testing/Internals.h:
(Internals): Added getReferencedFilePaths.
* testing/Internals.idl: Added binding for getReferencedFilePaths.

Source/WebKit/chromium: WebHistoryItem: Enable reading selected file names from document state
https://bugs.webkit.org/show_bug.cgi?id=91231

Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
Reviewed by Jochen Eisinger.

This change enables Chromium to set up file permissions properly when
the session restore feature restores a page with selected files.

* public/WebHistoryItem.h:
(WebHistoryItem): Added getReferencedFilePaths.
* src/WebHistoryItem.cpp:
(WebKit::WebHistoryItem::getReferencedFilePaths): Extracts selected and posted file paths from a document state.
(WebKit):

Source/WebKit2: FormController, WebHistoryItem: Enable reading selected file names from document state
https://bugs.webkit.org/show_bug.cgi?id=91231

Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
Reviewed by Jochen Eisinger.

This change enables Chromium to set up file permissions properly when
the session restore feature restores a page with selected files.

* win/WebKit2.def: Exported FormController::getReferencedFilePaths and HistoryController::saveDocumentAndScrollState.

LayoutTests: FormController: Enable reading selected file names from document state
https://bugs.webkit.org/show_bug.cgi?id=91231

Patch by Marja Hölttä <marja@chromium.org> on 2012-08-16
Reviewed by Jochen Eisinger.

This change enables Chromium to set up file permissions properly when
the session restore feature restores a page with selected files.

* fast/forms/file/selected-files-from-history-state-expected.txt: Added.
* fast/forms/file/selected-files-from-history-state.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] set scissorRect per quad so that quads are correctly clipped
shawnsingh@chromium.org [Thu, 16 Aug 2012 08:50:21 +0000 (08:50 +0000)]
[chromium] set scissorRect per quad so that quads are correctly clipped
https://bugs.webkit.org/show_bug.cgi?id=94050

Reviewed by Adrienne Walker.

Source/WebCore:

Certain quad types rely on scissoring to do correct
clipping. Refactoring the quad types to remove this assumption
will be done in a later patch, but for now, we have to apply the
scissor rect to every quad to ensure that those quads are
correctly clipped.

Test: compositing/overflow/overflow-hidden-canvas-layer.html

Also updated two unit tests to reflect the change in semantics.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawRenderPass):
(WebCore::LayerRendererChromium::drawQuad):

Source/WebKit/chromium:

Updated two unit tests to reflect that we need to always scissor,
until we refactor so that quads do not depend on scissoring.

* tests/CCLayerTreeHostImplTest.cpp:

LayoutTests:

* compositing/overflow/overflow-hidden-canvas-layer-expected.png: Added.
* compositing/overflow/overflow-hidden-canvas-layer-expected.txt: Added.
* compositing/overflow/overflow-hidden-canvas-layer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPrevent showing suggestions when right-clicking a selection range.
hbono@chromium.org [Thu, 16 Aug 2012 08:07:51 +0000 (08:07 +0000)]
Prevent showing suggestions when right-clicking a selection range.
https://bugs.webkit.org/show_bug.cgi?id=94189

Reviewed by Hajime Morita.

To emulate Safari, my r120810 changes selection when right-clicking a misspelled
word. Unfortunately, this change somehow uses VisibleSelection::isCaretOrRange
and it changes the existing selection when right-clicking a selection which
includes a misspelled word. This change uses VisibleSelection::isCaret to
prevent showing suggestions when right-clicking a selection range. (Neither does
Safari show suggestions when there is a selection range.)

* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 16 Aug 2012 07:57:39 +0000 (07:57 +0000)]
Unreviewed GTK gardening.

Adding failure expectations for two accessibility tests introduced in r125710.

Rebaselining fast/css/word-space-extra.html after r125578.

* platform/gtk/TestExpectations:
* platform/gtk/fast/css/word-space-extra-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd deleteFileSystem support to DumpRenderTree for chromium
commit-queue@webkit.org [Thu, 16 Aug 2012 07:54:35 +0000 (07:54 +0000)]
Add deleteFileSystem support to DumpRenderTree for chromium
https://bugs.webkit.org/show_bug.cgi?id=94071

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-16
Reviewed by Kent Tamura.

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::deleteFileSystem): Added
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] Wheel event support in multiple fields time input UI
yosin@chromium.org [Thu, 16 Aug 2012 07:34:13 +0000 (07:34 +0000)]
[Forms] Wheel event support in multiple fields time input UI
https://bugs.webkit.org/show_bug.cgi?id=94166

Reviewed by Kent Tamura.

Source/WebCore:

This patch makes multiple fields time input UI to handle wheel event
on spin button.

This patch affects if ENABLE_INPUT_TYPE_TIME and ENABLE_INPUT_TYPE_MULTIPLE_FIELDS
are enabled.

Test: fast/forms/time-multiple-fields/time-multiple-fields-wheel-event.html

* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::defaultEventHandler): Changed to forward
event to spin button if available.

LayoutTests:

This patch adds a test for wheel event handling in multiple fields
time input UI.

* fast/forms/time-multiple-fields/time-multiple-fields-wheel-event-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-wheel-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTextureMapperGL::beginPainting has a duplicate call to get GL_FRAMEBUFFER_BINDING.
commit-queue@webkit.org [Thu, 16 Aug 2012 07:18:45 +0000 (07:18 +0000)]
TextureMapperGL::beginPainting has a duplicate call to get GL_FRAMEBUFFER_BINDING.
https://bugs.webkit.org/show_bug.cgi?id=94180

Patch by Zhigang Gong <zhigang.gong@linux.intel.com> on 2012-08-16
Reviewed by Noam Rosenthal.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::beginPainting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r119705.
inferno@chromium.org [Thu, 16 Aug 2012 07:06:14 +0000 (07:06 +0000)]
Unreviewed, rolling out r119705.
http://trac.webkit.org/changeset/119705
https://bugs.webkit.org/show_bug.cgi?id=94192

Causing crash on ClusterFuzz due to incorrect layout ordering
change (Requested by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-16

* dom/CharacterData.cpp:
(WebCore::CharacterData::setDataAndUpdate):
* editing/FrameSelection.cpp:
(WebCore::updatePositionAfterAdoptingTextReplacement):
(WebCore::FrameSelection::textWillBeReplaced):
* editing/FrameSelection.h:
(FrameSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Thu, 16 Aug 2012 06:20:00 +0000 (06:20 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-15

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Refactoring: Introduce a new function for some part of PopupContainer...
tkent@chromium.org [Thu, 16 Aug 2012 06:01:33 +0000 (06:01 +0000)]
[Chromium] Refactoring: Introduce a new function for some part of PopupContainer::layoutAndCalculateWidgetRect()
https://bugs.webkit.org/show_bug.cgi?id=94087

Reviewed by Hajime Morita.

Move some part of PopupContainer::layoutAndCalculateWidgetRect() to a
new function which is not a member of PopupContainer because we'd like
to add a unit test for the position calculation code, and to reduce the
dependency.

No new tests. Popup positioning code is not testable in WebKit.

* platform/chromium/PopupContainer.cpp:
(WebCore::layoutAndCalculateWidgetRectInternal):
Added. Move the code from PopupContainer::layoutAndCalculateWidgetRect.
In order to avoid to call member functions of PopupContainer, we
don't call layoutAndGetRTLOffset() and height(). Use
PopupListBox::layout() to recalculate the popup content size, and use
PopupListBox::height() + kBorderSize * 2 instead of height(). We
resize the view after finishing layoutAndCalculateWidgetRectInternal
in PopupContainer::layoutAndCalculateWidgetRect.
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
Move some code to layoutAndCalculateWidgetRectInternal.
(WebCore::PopupContainer::fitToListBox):
Added. Move the code from PopupContainer::layoutAndGetRTLOffset.
(WebCore::PopupContainer::layoutAndGetRTLOffset):
Move some code to fitToListBox.
* platform/chromium/PopupContainer.h:
(PopupContainer): Added fitToListBox.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Tests] Disable fast/forms/time-multiple-fields tests for port which don't enable...
yosin@chromium.org [Thu, 16 Aug 2012 05:59:39 +0000 (05:59 +0000)]
[Tests] Disable fast/forms/time-multiple-fields tests for port which don't enable multiple fields time input UI feature
https://bugs.webkit.org/show_bug.cgi?id=94186

Reviewed by Kent Tamura.

This patch disables tests in fast/forms/time-multiple-fields.
These tests are enabled if both ENABLE_INPUT_TYPE_TIME and
ENABLED_INPUT_TYPE_TIME_MULTIPLE_FIELDS enabled.

* platform/chromium/TestExpectations:
* platform/efl/tExpectations:
* platform/gtk/TestExpectations:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] Re-factor fast/forms/number/number-wheel-event.html
yosin@chromium.org [Thu, 16 Aug 2012 05:37:03 +0000 (05:37 +0000)]
[Forms] Re-factor fast/forms/number/number-wheel-event.html
https://bugs.webkit.org/show_bug.cgi?id=94172

Reviewed by Kent Tamura.

This patch moves test code from number-wheel-event.html to common-wheel-event.js
for sharing test code among input types.

* fast/forms/number/number-wheel-event.html:
* fast/forms/resources/common-wheel-event.js:
(testWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r125659): 4 HTMLMeterElement tests fail on Mac.
shinyak@chromium.org [Thu, 16 Aug 2012 05:21:33 +0000 (05:21 +0000)]
REGRESSION (r125659): 4 HTMLMeterElement tests fail on Mac.
https://bugs.webkit.org/show_bug.cgi?id=94157

Unreviewed, unskip failing tests and  rebaseline after r125659.

* platform/mac/Skipped:
* platform/mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVoidCallback should not be a special snowflake
abarth@webkit.org [Thu, 16 Aug 2012 05:01:52 +0000 (05:01 +0000)]
VoidCallback should not be a special snowflake
https://bugs.webkit.org/show_bug.cgi?id=94119

Reviewed by Eric Seidel.

VoidCallback is the oldest of the callbacks and it predates our ability
to autogenerate callback objects. The existing implementation of
VoidCallback is wrong because it doesn't call
ActiveDOMCallback::canInvokeCallback. The net result of that is that
void callbacks can race with navigations and occationally execute after
the Frame has navigated to a new Document, which was causing the
flakiness.

This patch changes VoidCallback to no longer be a unique snowflake.
Instead, we autogenerate the implementation, just like every other
callback in WebCore.

Tests: storage/websql/database-lock-after-reload.html is no longer flaky.

* DerivedSources.make:
* GNUmakefile.list.am:
* Modules/filesystem/SyncCallbackHelper.h:
(WebCore::SyncCallbackHelper::SuccessCallbackImpl::handleEvent):
* Target.pri:
* UseJSC.cmake:
* UseV8.cmake:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/cpp/WebDOMCustomVoidCallback.cpp: Removed.
* bindings/cpp/WebDOMCustomVoidCallback.h: Removed.
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSCustomVoidCallback.cpp: Removed.
* bindings/js/JSCustomVoidCallback.h: Removed.
* bindings/js/JSDesktopNotificationsCustom.cpp:
(WebCore::JSNotificationCenter::requestPermission):
* bindings/scripts/CodeGeneratorCPP.pm:
(GetClassName):
(AddIncludesForType):
* bindings/scripts/CodeGeneratorJS.pm:
(GetCallbackClassName):
(GenerateCallbackImplementation):
(JSValueToNative):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallbackImplementation):
(TypeCanFailConversion):
(GetCallbackClassName):
* bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::callbackWithNoParam):
* bindings/scripts/test/V8/V8TestCallback.cpp:
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
* bindings/v8/custom/V8CustomVoidCallback.cpp: Removed.
* bindings/v8/custom/V8CustomVoidCallback.h: Removed.
* bindings/v8/custom/V8MutationCallbackCustom.cpp:
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::requestPermissionCallback):
* html/VoidCallback.h:
(VoidCallback):
* html/VoidCallback.idl:
* inspector/InspectorDatabaseAgent.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Shadow] Stop 'load' and 'error' events at shadow boundaries
hayato@chromium.org [Thu, 16 Aug 2012 04:51:14 +0000 (04:51 +0000)]
[Shadow] Stop 'load' and 'error' events at shadow boundaries
https://bugs.webkit.org/show_bug.cgi?id=93425

Reviewed by Dimitri Glazkov.

Source/WebCore:

The shadow DOM spec has added these events as 'always-be-stopped' events at shadow boundaries.
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#events-that-are-always-stopped

Test: fast/dom/shadow/events-stopped-at-shadow-boundary.html

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::determineDispatchBehavior):

LayoutTests:

* fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt:
* fast/dom/shadow/events-stopped-at-shadow-boundary.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Tests] Copy to fast/forms/resources/common-wheel-event.js from fast/forms/number...
yosin@chromium.org [Thu, 16 Aug 2012 04:21:53 +0000 (04:21 +0000)]
[Tests] Copy to fast/forms/resources/common-wheel-event.js from fast/forms/number/number-wheel-event.html
https://bugs.webkit.org/show_bug.cgi?id=94184

Reviewed by Kent Tamura.

This patch copies fast/forms/number/number-wheel-event.html
to fast/forms/resources/common-wheel-event.js for sharing
test code among input types.

* fast/forms/resources/common-wheel-event.js: Copied from LayoutTests/fast/forms/number/number-wheel-event.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago(r125629): Newly added test css3/filters/custom/filter-fallback-to-software.html...
commit-queue@webkit.org [Thu, 16 Aug 2012 03:56:38 +0000 (03:56 +0000)]
(r125629): Newly added test css3/filters/custom/filter-fallback-to-software.html failing on mac
https://bugs.webkit.org/show_bug.cgi?id=94169

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-08-15
Reviewed by Sam Weinig.

Update TestExpecatations of failing test to make the bot green.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCalendar Picker: Localize numbers in a calendar picker
tkent@chromium.org [Thu, 16 Aug 2012 03:54:03 +0000 (03:54 +0000)]
Calendar Picker: Localize numbers in a calendar picker
https://bugs.webkit.org/show_bug.cgi?id=93704

Reviewed by Hajime Morita.

.:

* ManualTests/forms/calendar-picker.html:
Add a mock pagePopupController.localizeNumberString().

Source/WebCore:

Because Number.toLocaleString() of V8 returns no localized
numbers, we provide a localization function via
PagePopupController.

No new tests. We have no ways to change the locale in layout tests.

* Resources/pagepopups/calendarPicker.js:
(localizeNumber): Added. A wrapper for pagePopupController.localizeNumberString().
(formatJapaneseImperialEra): Use localizeNumber().
(formatYearMonth): ditto.
(DaysTable.prototype._renderMonth): ditto.
* page/PagePopupController.cpp:
(WebCore::PagePopupController::localizeNumberString):
Added. Just calls WebCore::convertToLocalizedNumber().
* page/PagePopupController.h:
(PagePopupController): Declare localizeNumberString().
* page/PagePopupController.idl: Add localizeNumberString().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] Rename LayoutTests/fast/forms/number/number-wheel.html to number-wheel-event...
yosin@chromium.org [Thu, 16 Aug 2012 03:45:39 +0000 (03:45 +0000)]
[Forms] Rename LayoutTests/fast/forms/number/number-wheel.html to number-wheel-event.html
https://bugs.webkit.org/show_bug.cgi?id=94173

Reviewed by Kent Tamura.

This patch renames LayoutTest/fast/forms/number/number-wheel.html to
number-wheel-event.html to indicate the test checks wheel event
handling.

* fast/forms/number/number-wheel-event-expected.txt: Copied from LayoutTests/fast/forms/number/number-wheel-expected.txt.
* fast/forms/number/number-wheel-event.html: Copied from LayoutTests/fast/forms/number/number-wheel.html.
* fast/forms/number/number-wheel-expected.txt: Removed.
* fast/forms/number/number-wheel.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegression(121518) TextFieldDecorationElement formatting is broken.
morrita@google.com [Thu, 16 Aug 2012 03:05:59 +0000 (03:05 +0000)]
Regression(121518) TextFieldDecorationElement formatting is broken.
https://bugs.webkit.org/show_bug.cgi?id=90913

Reviewed by Dimitri Glazkov.

Source/WebCore:

NodeRenderingContext::nextRenderer() has a problem which cannot retrieve the renderer
across an insertion point in some case. That is because ad-hoc composed tree traversal on
NodeRenderingContext is broken. The problem is hidden before r121518 though.

This change rewrite nextRenderer() using ComposedShadowTreeWalker to eliminate the ad-hoc
traversal. previousRenderer() is also rewritten in the same way.

Test: fast/dom/shadow/shadow-div-reflow.html

* dom/NodeRenderingContext.cpp:
(WebCore):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):

LayoutTests:

* fast/dom/shadow/shadow-div-reflow-expected.html: Added.
* fast/dom/shadow/shadow-div-reflow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate manual tests and comments to refer to TestRunner instead of LayoutTestController
rniwa@webkit.org [Thu, 16 Aug 2012 02:40:21 +0000 (02:40 +0000)]
Update manual tests and comments to refer to TestRunner instead of LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=94168

Reviewed by Kent Tamura.

.:

* ManualTests/resources/multiFileResources/post-echo-and-notify-done.cgi:

Source/WebKit:

* PlatformBlackBerry.cmake:

Source/WebKit/chromium:

* public/WebDevToolsAgent.h:
(WebDevToolsAgent):
* public/WebView.h:
(WebView):

Source/WebKit/qt:

* Api/qwebelement.cpp:
(convertJSValueToWebElementVariant):
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

* Interfaces/IWebPreferencesPrivate.idl:

Source/WebKit2:

* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::getBoolValueForKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a was-inserted-into-tree notification to RenderObject
jchaffraix@webkit.org [Thu, 16 Aug 2012 02:35:29 +0000 (02:35 +0000)]
Add a was-inserted-into-tree notification to RenderObject
https://bugs.webkit.org/show_bug.cgi?id=93874

Reviewed by Eric Seidel.

This change adds insertedIntoTree to RenderObject so that renderers
can now do their post-insertion task inside this function.

Our current architecture has 2 ways of doing post-insertion tasks:
- overriding RenderObject::addChild
- RenderObjectChildList::insertChildNode / appendChildNode

Because the former is not guaranteed to be called for each insertion
(on top of being called on the parent and not the inserted child), the
2 latter functions are the one that have been mostly used recently. This
led to code duplication between the functions but also doesn't scale as
other renderers need to hop on this notification and currently don't (for
example, table parts). The other renderer's migration will be done in
follow-up patches.

Refactoring covered by existing tests.

* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::enclosingRenderNamedFlowThread):
Moved the code from renderNamedFlowThreadContainer to RenderObject::enclosingRenderNamedFlowThread.
This is needed as now 2 classes need to access the function.

* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Moved the code duplicated from those 2 functions into
the instances of insertedIntoTree below.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::insertedIntoTree):
Base function that needs to be called from all the other
specialized functions below.

* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::insertedIntoTree):
* rendering/RenderListItem.h:
* rendering/RenderObject.h:
* rendering/RenderObjectChildList.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::insertedIntoTree):
* rendering/RenderRegion.h:
Added the overriden insertedIntoTree function.

* rendering/RenderQuote.h:
Moved the comment from RenderObjectChildList about RenderQuote here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow blocking of Web SQL databases in third-party documents
jpfau@apple.com [Thu, 16 Aug 2012 02:14:16 +0000 (02:14 +0000)]
Allow blocking of Web SQL databases in third-party documents
https://bugs.webkit.org/show_bug.cgi?id=94057

Reviewed by Adam Barth.

Source/WebCore:

Add a check for pages in third-party pages to allow third-party storage blocking of Web SQL databases.

Tests: http/tests/security/cross-origin-websql-allowed.html
       http/tests/security/cross-origin-websql.html

* Modules/webdatabase/DOMWindowWebDatabase.cpp:
(WebCore::DOMWindowWebDatabase::openDatabase): Pass top origin to canAccessDatabase
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canAccessStorage): Common method for various types of storage that use the same criteria
* page/SecurityOrigin.h:
(WebCore::SecurityOrigin::canAccessDatabase): Use canAccessStorage
(WebCore::SecurityOrigin::canAccessLocalStorage): Change to using canAccessStorage
(SecurityOrigin):

LayoutTests:

Created tests for accessing openDatabase from a third party and first party context when third-party blocking is on and off.

* http/tests/security/cross-origin-websql-allowed-expected.txt: Added.
* http/tests/security/cross-origin-websql-allowed.html: Added.
* http/tests/security/cross-origin-websql-expected.txt: Added.
* http/tests/security/cross-origin-websql.html: Added.
* http/tests/security/resources/cross-origin-iframe-for-websql.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix TestExpectations line format for two fast/css tests failing on mac
commit-queue@webkit.org [Thu, 16 Aug 2012 01:48:18 +0000 (01:48 +0000)]
Fix TestExpectations line format for two fast/css tests failing on mac
https://bugs.webkit.org/show_bug.cgi?id=94160

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-08-15
Reviewed by Sam Weinig.

Remove "MAC" modifier, which seems to prevent the expectations from taking effect.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImprove Document.h compile time - reduce includes of ScriptCallStack.h
commit-queue@webkit.org [Thu, 16 Aug 2012 01:41:37 +0000 (01:41 +0000)]
Improve Document.h compile time - reduce includes of ScriptCallStack.h
https://bugs.webkit.org/show_bug.cgi?id=94161

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-08-15
Reviewed by Eric Seidel.

ScriptCallStack.h no longer included from ScriptExecutionContext. It's
relatively expensive to compile and gets compiled a ton because
Document.h indirectly includes it.

No new tests. Functionality should remain the same

* Modules/indexeddb/IDBDatabase.cpp:
* Modules/indexeddb/IDBIndex.cpp:
* Modules/indexeddb/IDBObjectStore.cpp:
* bindings/js/ScriptController.cpp:
* dom/ScriptElement.cpp:
* dom/ScriptExecutionContext.h:
(WebCore):
* fileapi/Blob.cpp:
* fileapi/WebKitBlobBuilder.cpp:
* html/HTMLTrackElement.cpp:
* loader/TextTrackLoader.cpp:
* page/DOMSecurityPolicy.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename LayoutTestController to TestRunner in WebKitTestRunner
rniwa@webkit.org [Thu, 16 Aug 2012 01:22:26 +0000 (01:22 +0000)]
Rename LayoutTestController to TestRunner in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=93942

Reviewed by Simon Fraser.

Renamed the class and relevant files.

* WebKitTestRunner/CMakeLists.txt:
* WebKitTestRunner/DerivedSources.make:
* WebKitTestRunner/GNUmakefile.am:
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl.
* WebKitTestRunner/InjectedBundle/DerivedSources.pri:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::testRunner):
(InjectedBundle):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h: Removed.
* WebKitTestRunner/InjectedBundle/Target.pri:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp.
* WebKitTestRunner/InjectedBundle/TestRunner.h: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h.
(TestRunner):
* WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp: Removed.
* WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp.
(WTR::waitToDumpWatchdogTimerCallback):
(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::TestRunner::pathToLocalResource):
(WTR::TestRunner::platformName):
* WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Removed.
* WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp.
(WTR::waitToDumpWatchdogTimerCallback):
(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::TestRunner::pathToLocalResource):
(WTR::TestRunner::platformName):
* WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm: Removed.
* WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm.
(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::waitUntilDoneWatchdogTimerFired):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::TestRunner::pathToLocalResource):
(WTR::TestRunner::platformName):
* WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Removed.
* WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp.
(WTR::WatchdogTimerHelper::timerFired):
(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::TestRunner::pathToLocalResource):
(WTR::TestRunner::platformName):
* WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp: Removed.
* WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp.
(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::waitToDumpWatchdogTimerFired):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::TestRunner::pathToLocalResource):
(WTR::TestRunner::platformName):
* WebKitTestRunner/PlatformEfl.cmake:
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/win/InjectedBundle.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate test expectations for css3/filters/custom/invalid-custom-filter-shader.html...
commit-queue@webkit.org [Thu, 16 Aug 2012 01:03:55 +0000 (01:03 +0000)]
Update test expectations for css3/filters/custom/invalid-custom-filter-shader.html failing on Apple Lion Debug WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=94067

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-08-15
Reviewed by Brady Eidson.

Add to the list of tests needing rebaselining after https://bugs.webkit.org/show_bug.cgi?id=6033

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: IDB*::keyPath should return IDBKeyPath, not IDBAny
commit-queue@webkit.org [Thu, 16 Aug 2012 00:57:53 +0000 (00:57 +0000)]
IndexedDB: IDB*::keyPath should return IDBKeyPath, not IDBAny
https://bugs.webkit.org/show_bug.cgi?id=92434

Patch by Alec Flett <alecflett@chromium.org> on 2012-08-15
Reviewed by Tony Chang.

Clean up IDBKeyPath conversion to IDBAny objects. This gets rid of
some implicit conversion from IDBKeyPath to IDBAny.

No new tests, just changing method signatures.

* Modules/indexeddb/IDBAny.cpp:
(WebCore::IDBAny::set):
(WebCore):
* Modules/indexeddb/IDBAny.h:
(WebCore):
(WebCore::IDBAny::create):
(IDBAny):
* Modules/indexeddb/IDBIndex.h:
(WebCore::IDBIndex::keyPathAny):
(WebCore::IDBIndex::keyPath):
* Modules/indexeddb/IDBIndex.idl:
* Modules/indexeddb/IDBKeyPath.cpp:
* Modules/indexeddb/IDBKeyPath.h:
* Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::keyPathAny):
(WebCore::IDBObjectStore::keyPath):
* Modules/indexeddb/IDBObjectStore.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEFL build fix attempt after r125711. Touch an IDL file to regenerate derived sources.
rniwa@webkit.org [Thu, 16 Aug 2012 00:52:20 +0000 (00:52 +0000)]
EFL build fix attempt after r125711. Touch an IDL file to regenerate derived sources.

* html/HTMLAllCollection.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: generate index keys for existing data in createIndex in front end
commit-queue@webkit.org [Thu, 16 Aug 2012 00:50:52 +0000 (00:50 +0000)]
IndexedDB: generate index keys for existing data in createIndex in front end
https://bugs.webkit.org/show_bug.cgi?id=91125

Patch by Alec Flett <alecflett@chromium.org> on 2012-08-15
Reviewed by Tony Chang.

Source/WebCore:

Make createIndex() do index key generation in the frontend, rather
than the backend. When an index is created, the frontend uses the
cursor API to iterate through the values in the backend to
generate keys, sending them back to the backend using
IDBObjectStore::setIndexKeys()

This confines all key injection/extraction to the frontend.

The new test verifies the implemented behavior with respect to
error handling in degenerate uses of put(), though that behavior
is still in discussion as the spec is vague on the proper error
behavior.

Test: storage/indexeddb/lazy-index-population.html

* Modules/indexeddb/IDBCursorBackendImpl.cpp: Make sure that the
TaskType propagates throught the cursor and all subsequent
continue() calls.
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::prefetchContinue):
* Modules/indexeddb/IDBCursorBackendImpl.h:
(WebCore::IDBCursorBackendImpl::create):
(IDBCursorBackendImpl):
* Modules/indexeddb/IDBObjectStore.cpp: Add an IndexPopulator
class to run a cursor from the frontend.
(WebCore):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::openCursor):
* Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):
(WebCore::IDBObjectStore::createIndex):
* Modules/indexeddb/IDBObjectStore.idl: Pass along ScriptContext
so that openCursor can be called from createIndex.
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore):
(WebCore::makeIndexWriters):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReady):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReadyInternal):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::iterIndexesBegin):
(WebCore::IDBObjectStoreBackendImpl::iterIndexesEnd):
(WebCore::IDBObjectStoreBackendImpl::backingStore):
(WebCore::IDBObjectStoreBackendImpl::databaseId):
* Modules/indexeddb/IDBObjectStoreBackendInterface.h:
* Modules/indexeddb/IDBRequest.cpp:
Allow requests to keep their own TaskType, to give certain
requests priority over others.
(WebCore::IDBRequest::create):
(WebCore):
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::abort):
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):
(WebCore::IDBRequest::taskType):
* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
Introduce a second, higher priority event queue, m_preemptiveTaskQueue,
which takes priority over the regular task queue.
(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::scheduleTask):
(WebCore::IDBTransactionBackendImpl::isTaskQueueEmpty):
(WebCore):
(WebCore::IDBTransactionBackendImpl::commit):
(WebCore::IDBTransactionBackendImpl::taskTimerFired):
(WebCore::IDBTransactionBackendImpl::taskEventTimerFired):
* Modules/indexeddb/IDBTransactionBackendImpl.h:
(WebCore::IDBTransactionBackendImpl::scheduleTask):
(IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::addEarlyEvent):
(WebCore::IDBTransactionBackendImpl::didCompleteEarlyEvent):
* Modules/indexeddb/IDBVersionChangeRequest.cpp:
(WebCore::IDBVersionChangeRequest::IDBVersionChangeRequest):

Source/WebKit/chromium:

Add Chromium API methods to let the renderer process tell the
browser process about indexing progress.

* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::openCursor):
* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::setIndexKeys):
(WebKit):
(WebKit::IDBObjectStoreBackendProxy::setIndexesReady):
(WebKit::IDBObjectStoreBackendProxy::openCursor):
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::setIndexKeys):
(WebKit):
(WebKit::WebIDBObjectStoreImpl::setIndexesReady):
(WebKit::WebIDBObjectStoreImpl::openCursor):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):

LayoutTests:

The transaction should be aborted when existing data in an
objectStore causes uniqueness errors during index creation.

* storage/indexeddb/lazy-index-population-expected.txt: Added.
* storage/indexeddb/lazy-index-population.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoA 'load' event should be fired on the shadow host directly, not on an inner image...
hayato@chromium.org [Thu, 16 Aug 2012 00:43:01 +0000 (00:43 +0000)]
A 'load' event should be fired on the shadow host directly, not on an inner image element of shadow dom subtree.
https://bugs.webkit.org/show_bug.cgi?id=93920

Reviewed by Dimitri Glazkov.

Source/WebCore:

A 'load' event is a must-stoppable event at shadow boundary. So we
should fire a 'load' event on a shadow host directly, not on an
inner image element.

Test: fast/dom/shadow/shadowdom-for-image-event.html

* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::dispatchLoadEvent):
* loader/ImageLoaderClient.h:
(WebCore::ImageLoaderClient::eventTarget):

LayoutTests:

* fast/dom/shadow/shadowdom-for-image-event-expected.txt: Added.
* fast/dom/shadow/shadowdom-for-image-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium-Android] DumpRenderTree timeouts before NRWT timeouts
wangxianzhu@chromium.org [Thu, 16 Aug 2012 00:38:07 +0000 (00:38 +0000)]
[Chromium-Android] DumpRenderTree timeouts before NRWT timeouts
https://bugs.webkit.org/show_bug.cgi?id=94155

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.create_driver): Force no_timeout=True

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a hyperlink to perf-o-matic from build.webkit.org/root.html
rniwa@webkit.org [Thu, 16 Aug 2012 00:18:46 +0000 (00:18 +0000)]
Add a hyperlink to perf-o-matic from build.webkit.org/root.html
https://bugs.webkit.org/show_bug.cgi?id=93749

Reviewed by Csaba Osztrogonác.

Added the hyperlink to webkit-perf.appspot.com. Also added hyperlinks to the waterfall display
of performance tests.

* BuildSlaveSupport/build.webkit.org-config/templates/root.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] new test fast/forms/radio/radio-group.html introduced in r104668 fails
commit-queue@webkit.org [Thu, 16 Aug 2012 00:05:22 +0000 (00:05 +0000)]
[Qt] new test fast/forms/radio/radio-group.html introduced in r104668 fails
https://bugs.webkit.org/show_bug.cgi?id=76051

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-08-15
Reviewed by Csaba Osztrogonác.

Unskip now working test.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a layout test for :lang() selector observing dynamic changes to lang
commit-queue@webkit.org [Wed, 15 Aug 2012 23:43:11 +0000 (23:43 +0000)]
Add a layout test for :lang() selector observing dynamic changes to lang
https://bugs.webkit.org/show_bug.cgi?id=94092

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-08-15
Reviewed by Alexey Proskuryakov.

This patch adds a test that dynamic changes to the lang attribute are seen by the :lang selector.
This behavior was first added in an earlier patch (probably http://trac.webkit.org/changeset/103608)
but there was no layout test for it yet.

* fast/selectors/lang-dynamic-expected.html: Added.
* fast/selectors/lang-dynamic.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (125659): 4 HTMLMeterElement tests fail on Mac
beidson@apple.com [Wed, 15 Aug 2012 23:38:41 +0000 (23:38 +0000)]
REGRESSION (125659): 4 HTMLMeterElement tests fail on Mac
https://bugs.webkit.org/show_bug.cgi?id=94157

Skipping these 4 tests until the perpetrator can fix.

Not reviewed (Bot gardening).

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] When there is an exception we want to check if the ref is 0, not the
commit-queue@webkit.org [Wed, 15 Aug 2012 23:34:51 +0000 (23:34 +0000)]
[BlackBerry] When there is an exception we want to check if the ref is 0, not the
value as JSObjectCallAsFunction returns 0 in that case.
https://bugs.webkit.org/show_bug.cgi?id=94153

Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-08-15
Reviewed by Yong Li.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Some late night gardening
commit-queue@webkit.org [Wed, 15 Aug 2012 23:32:28 +0000 (23:32 +0000)]
[EFL] Some late night gardening
https://bugs.webkit.org/show_bug.cgi?id=94151

Unreviewed, EFL gardening.

Moving the autoscroll test out, adding platform specific baselines for the HTMLMeterElement tests.

Patch by Dominik Röttsches <d-r@roettsches.de> on 2012-08-15

* platform/efl/TestExpectations:
* platform/efl/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
* platform/efl/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
* platform/efl/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
* platform/efl/fast/dom/HTMLMeterElement/meter-clone-expected.txt: Added.
* platform/efl/fast/dom/HTMLMeterElement/meter-element-crash-expected.txt: Added.
* platform/efl/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
* platform/efl/fast/dom/HTMLMeterElement/meter-element-form-expected.txt: Added.
* platform/efl/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt: Added.
* platform/efl/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
* platform/efl/fast/dom/HTMLMeterElement/meter-element-with-child-crash-expected.txt: Added.
* platform/efl/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
* platform/efl/fast/dom/HTMLMeterElement/meter-percent-size-expected.txt: Added.
* platform/efl/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
* platform/efl/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
* platform/efl/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Added.
* platform/efl/fast/dom/HTMLMeterElement/set-meter-properties-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Mark canvas-fallback-content tests as asserting in debug builds
enne@google.com [Wed, 15 Aug 2012 22:54:36 +0000 (22:54 +0000)]
[chromium] Mark canvas-fallback-content tests as asserting in debug builds
https://bugs.webkit.org/show_bug.cgi?id=94156

Unreviewed gardening. Update expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Show custom error page when 407 is received
commit-queue@webkit.org [Wed, 15 Aug 2012 22:42:52 +0000 (22:42 +0000)]
[BlackBerry] Show custom error page when 407 is received
https://bugs.webkit.org/show_bug.cgi?id=94138

 Reviewed by George Staikos.
 Internally reviewed by Lianghui Chen

 Adding a new custom error page when the browser receieves
 a Wifi proxy authentication error. The previous behaviour
 is to ask for user credentials everytime, and silently fails
 when the username and password fields in the Wifi settings
 are not empty. UX suggests modifying the behaviour to simply
 asks the user to change their credentials in the Wifi settings
 when we receive such an error.

 The fix is to prevent notifyAuthReceived from sending another
 networkjob when authCallbacks are called, and to listen to any 407
 calls in notifyStatusReceived. Once we hit a 407, tell the frame we
 failed and should load the custom error page.

 Also removed checking functions in sendRequestWithCredentials because
 proxy auth requests won't get into that function anymore.

 #PR163400

 Tested by loading on device and loading/reloading pages under
 these scenarios:
 - Connected to wifi (no proxy)
 - Connected to wifi (proxy with no credentials)
 - Connected to wifi (proxy with invalid credentials)
 - Connected to wifi (proxy with valid credentials)

 * platform/network/blackberry/NetworkJob.cpp:
 (WebCore::NetworkJob::handleNotifyStatusReceived):
 (WebCore::NetworkJob::notifyAuthReceived):
 (WebCore::NetworkJob::sendRequestWithCredentials):

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-08-15

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactor away IsolatedWorld
commit-queue@webkit.org [Wed, 15 Aug 2012 22:37:00 +0000 (22:37 +0000)]
Refactor away IsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=93971

Patch by Dan Carney <dcarney@google.com> on 2012-08-15
Reviewed by Adam Barth.

Remove IsolatedWorld class as it was 1:1 with DOMWrapperWorld.
This paves the way towards a JSC-like use of DOMWrapperWorld.

No tests.  No change in functionality.

* UseV8.cmake:
* WebCore.gypi:
* bindings/v8/DOMWrapperWorld.cpp:
(WebCore):
(WebCore::mainThreadNormalWorld):
* bindings/v8/DOMWrapperWorld.h:
(WebCore):
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::create):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::count):
(WebCore::DOMWrapperWorld::worldId):
(WebCore::DOMWrapperWorld::domDataStore):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
* bindings/v8/IsolatedWorld.cpp: Removed.
* bindings/v8/IsolatedWorld.h: Removed.
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):
* bindings/v8/V8IsolatedContext.h:
(WebCore::V8IsolatedContext::getEntered):
(WebCore::V8IsolatedContext::world):
(V8IsolatedContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[css3-text] Add CSS3 Text decoration compile flag
commit-queue@webkit.org [Wed, 15 Aug 2012 22:31:26 +0000 (22:31 +0000)]
[css3-text] Add CSS3 Text decoration compile flag
https://bugs.webkit.org/show_bug.cgi?id=93863

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-08-15
Reviewed by Julien Chaffraix.

This patch handles the compile flag implementation, which will come disabled by
default, thus not exposing the CSS3 text decoration features to the web, unless
when explicitly enabling it with "--css3-text-decoration" build parameter.

.:

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:
* configure.ac:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Changeset r125205 added "-webkit-text-decoration-line" support without proper
compile flag. I am fixing this on this patch by adding #ifdef's along the added
code and reverting getComputedStyle* layout test changes until further notice.
The text-decoration-line.html layout test is now moved to
fast/css3-text-decoration directory, which is skipped on all platforms until
feature is sound and ready to be exposed to web.

Test: fast/css3-text-decoration/text-decoration-line.html

* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::addTextDecorationProperty):
(WebCore::CSSParser::parseTextDecoration):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
Added #ifdefs to enable/disable CSS3 Text Decoration code implemented by r125205.

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Changeset r125205 added "-webkit-text-decoration-line" support without proper
compile flag. I am fixing this on this patch by adding #ifdef's along the added
code and reverting getComputedStyle* layout test changes until further notice.
The text-decoration-line.html layout test is now moved to
fast/css3-text-decoration directory, which is skipped on all platforms until
feature is sound and ready to be exposed to web.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/css/getComputedStyle/resources/property-names.js:
* svg/css/getComputedStyle-basic-expected.txt:
Avoid regression by reverting changes from r125205.
* fast/css3-text-decoration/text-decoration-line-expected.html: Renamed from LayoutTests/fast/css/text-decoration-line-expected.html.
* fast/css3-text-decoration/text-decoration-line.html: Renamed from LayoutTests/fast/css/text-decoration-line.html.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
fast/css3-text-decoration directory is skipped until feature is enabled by default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactoring: move EventHandler::targetNode into HitTestResult
commit-queue@webkit.org [Wed, 15 Aug 2012 22:14:05 +0000 (22:14 +0000)]
Refactoring: move EventHandler::targetNode into HitTestResult
https://bugs.webkit.org/show_bug.cgi?id=94107

Patch by Iain Merrick <husky@chromium.org> on 2012-08-15
Reviewed by Dimitri Glazkov.

Source/WebCore:

This static helper method in EventHandler was made public so that
WebFrameImpl can call it. That's untidy because EventHandler isn't
really involved. This patch turns it into an instance method of
HitTestResult (with a wrapper in MouseEventWithHitTestResult for
convenience).

Pure refactoring, no behavior change, no new test needed.

* page/EventHandler.cpp:
(WebCore::EventHandler::selectClosestWordFromMouseEvent):
(WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
(WebCore::EventHandler::handleMousePressEventTripleClick):
(WebCore::EventHandler::handleMousePressEventSingleClick):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::subframeForHitTestResult):
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::sendContextMenuEvent):
* page/EventHandler.h:
(EventHandler):
* page/MouseEventWithHitTestResults.h:
(WebCore::MouseEventWithHitTestResults::targetNode):
* page/chromium/EventHandlerChromium.cpp:
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
* page/efl/EventHandlerEfl.cpp:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
* page/gtk/EventHandlerGtk.cpp:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passSubframeEventToSubframe):
* page/wx/EventHandlerWx.cpp:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::targetNode):
(WebCore):
* rendering/HitTestResult.h:
(HitTestResult):

Source/WebKit/chromium:

This static helper method in EventHandler was made public so that
WebFrameImpl can call it. That's untidy because EventHandler isn't
really involved. This patch turns it into an instance method of
HitTestResult (with a wrapper in MouseEventWithHitTestResult for
convenience).

Pure refactoring, no behavior change, no new test needed.

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::visiblePositionForWindowPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Upstream FrameLoaderClientBlackBerry::securityOriginForNewDocument()
commit-queue@webkit.org [Wed, 15 Aug 2012 22:07:46 +0000 (22:07 +0000)]
[BlackBerry] Upstream FrameLoaderClientBlackBerry::securityOriginForNewDocument()
https://bugs.webkit.org/show_bug.cgi?id=94139

Patch by Yong Li <yoli@rim.com> on 2012-08-15
Reviewed by Antonio Gomes.

Keep same security origin when a file URL automatically redirects to its child folder.
This patch will be reverted when we finish the better solution.
PR# 172333 and PR# 180590.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidStartProvisionalLoad):
(WebCore::FrameLoaderClientBlackBerry::securityOriginForNewDocument):
(WebCore):
* WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Add some ASSERTs
dgrogan@chromium.org [Wed, 15 Aug 2012 21:54:50 +0000 (21:54 +0000)]
IndexedDB: Add some ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=94055

Reviewed by Ojan Vafai.

Source/WebCore:

These are just some additional ASSERTS and some ASSERT_WITH_MESSAGE in
place of ASSERT. They are from the patch in
https://bugs.webkit.org/show_bug.cgi?id=92897

No new tests - we should never hit this behavior.

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::registerFrontendCallbacks):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::enqueueEvent):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::setActive):

Source/WebKit/chromium:

* src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::setVersion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore unreviewed updated expectations from r125694.
leviw@chromium.org [Wed, 15 Aug 2012 21:41:59 +0000 (21:41 +0000)]
More unreviewed updated expectations from r125694.

* platform/chromium-linux/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
* platform/chromium-linux/fast/transforms/bounding-rect-zoom-expected.txt: Removed.
* platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Removed.
* platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.png:
* platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.txt:
* platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r125687.
commit-queue@webkit.org [Wed, 15 Aug 2012 21:35:55 +0000 (21:35 +0000)]
Unreviewed, rolling out r125687.
http://trac.webkit.org/changeset/125687
https://bugs.webkit.org/show_bug.cgi?id=94147

It broke the whole world (Requested by Ossy_night on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-15

Source/JavaScriptCore:

* API/JSValueRef.cpp:
(JSValueToBoolean):
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* bytecode/Watchpoint.h:
(WatchpointSet):
* debugger/DebuggerCallFrame.h:
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compile):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncSome):
* runtime/BooleanConstructor.cpp:
(JSC::constructBoolean):
(JSC::callBooleanConstructor):
* runtime/JSCell.h:
(JSCell):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::JSGlobalObject):
* runtime/JSGlobalObject.h:
(JSGlobalObject):
* runtime/JSString.h:
(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):
* runtime/JSValue.h:
* runtime/ObjectConstructor.cpp:
(JSC::toPropertyDescriptor):
* runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):
* runtime/Operations.h:
(JSC):
(JSC::JSValue::equalSlowCaseInline):
* runtime/RegExpConstructor.cpp:
(JSC::setRegExpConstructorMultiline):
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncToString):
* runtime/Structure.h:

Source/WebCore:

* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSSQLStatementErrorCallback::handleEvent):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):
* bindings/js/JSDataViewCustom.cpp:
(WebCore::getDataViewMember):
* bindings/js/JSDeviceMotionEventCustom.cpp:
(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):
* bindings/js/JSDeviceOrientationEventCustom.cpp:
(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
* bindings/js/JSDirectoryEntryCustom.cpp:
(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):
* bindings/js/JSDirectoryEntrySyncCustom.cpp:
(WebCore::getFlags):
* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
* bindings/js/JSInspectorFrontendHostCustom.cpp:
(WebCore::populateContextMenuItems):
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::handleInitMessageEvent):
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::dataFunctionMatrix):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::open):
* bindings/js/JavaScriptCallFrame.cpp:
* bindings/js/JavaScriptCallFrame.h:
(JavaScriptCallFrame):
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::hasBreakpoint):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateEventListenerCall):
(GenerateHeader):
(JSValueToNative):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):
* bindings/scripts/test/JS/JSTestEventTarget.h:
(WebCore::JSTestEventTarget::create):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
* bridge/c/c_utility.cpp:
(JSC::Bindings::convertValueToNPVariant):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::convertValueToJObject):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):

Source/WebKit/mac:

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::addValueToArray):

Source/WebKit2:

* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):

LayoutTests:

* fast/js/document-all-between-frames-expected.txt: Removed.
* fast/js/document-all-between-frames.html: Removed.
* fast/js/resources/document-all-between-frames-subframe.html: Removed.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: Calls to AXObjectCache should prefer Node over Renderer
dmazzoni@google.com [Wed, 15 Aug 2012 21:31:35 +0000 (21:31 +0000)]
AX: Calls to AXObjectCache should prefer Node over Renderer
https://bugs.webkit.org/show_bug.cgi?id=91794

Reviewed by Chris Fleizach.

Source/WebCore:

Now that it's possible for nodes inside a canvas subtree to be focused and
represent accessible content, accessibility notifications should be triggered
with a Node* rather than with a RenderObject* whenever possible.

Every public API in AXObjectCache that took a RenderObject* before now either
takes a Node* instead, or has a parallel method that takes a Node*.

Tests: accessibility/accessibility-node-memory-management.html
       accessibility/accessibility-node-reparent.html
       accessibility/canvas-fallback-content.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedImageMapUIElement):
(WebCore::AXObjectCache::focusedUIElementForPage):
(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::contentChanged):
(WebCore):
(WebCore::AXObjectCache::updateCacheAfterNodeIsAttached):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::checkedStateChanged):
(WebCore::AXObjectCache::selectedChildrenChanged):
(WebCore::AXObjectCache::nodeTextChangeNotification):
(WebCore::AXObjectCache::handleAriaExpandedChange):
(WebCore::AXObjectCache::handleActiveDescendantChanged):
(WebCore::AXObjectCache::handleAriaRoleChanged):
(WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
(WebCore::AXObjectCache::rootAXEditableElement):
(WebCore::AXObjectCache::nodeIsTextControl):
* accessibility/AXObjectCache.h:
(AXObjectCache):
(WebCore::AXObjectCache::setNodeInUse):
(WebCore::AXObjectCache::removeNodeForUse):
(WebCore::AXObjectCache::isNodeInUse):
(WebCore::AXObjectCache::checkedStateChanged):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::contentChanged):
(WebCore::AXObjectCache::updateCacheAfterNodeIsAttached):
(WebCore::AXObjectCache::handleActiveDescendantChanged):
(WebCore::AXObjectCache::handleAriaExpandedChange):
(WebCore::AXObjectCache::handleAriaRoleChanged):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::nodeTextChangeNotification):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::selectedChildrenChanged):
* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::parentObject):
* accessibility/AccessibilityObject.cpp:
(WebCore::appendAccessibilityObject):
(WebCore::replacedNodeNeedsCharacter):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::menuForMenuButton):
(WebCore::AccessibilityRenderObject::menuButtonForMenu):
(WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::titleUIElement):
(WebCore::AccessibilityRenderObject::isTabItemSelected):
(WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
(WebCore::AccessibilityRenderObject::nodeIsTextControl):
(WebCore::AccessibilityRenderObject::activeDescendant):
(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):
(WebCore::AccessibilityRenderObject::correspondingLabelForControlElement):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):
* accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
* accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
* bindings/cpp/WebDOMCustomVoidCallback.cpp:
(toWebCore):
* dom/Document.cpp:
(WebCore::Document::setFocusedNode):
* dom/Element.cpp:
(WebCore::Element::attributeChanged):
* dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::attach):
* editing/AppendNodeCommand.cpp:
(WebCore::sendAXTextChangedIgnoringLineBreaks):
* editing/DeleteFromTextNodeCommand.cpp:
(WebCore::DeleteFromTextNodeCommand::doApply):
(WebCore::DeleteFromTextNodeCommand::doUnapply):
* editing/Editor.cpp:
(WebCore::Editor::respondToChangedContents):
(WebCore::Editor::markAndReplaceFor):
* editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):
* editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):
* editing/chromium/FrameSelectionChromium.cpp:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setChecked):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childrenChanged):
(WebCore::HTMLSelectElement::optionElementChildrenChanged):
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setInnerTextValue):
* html/InputType.cpp:
(WebCore::InputType::applyStep):
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleKeydownEvent):
* page/FocusController.cpp:
(WebCore::FocusController::setInitialFocus):

LayoutTests:

New tests:
- canvas-fallback-content tests that objects in a canvas subtree can be
  focused and then you can retrieve the role of the accessible object.
- accessibility-node-memory-management ensures that an AccessibilityNodeObject
  is detached when its node is destroyed.
- accessibility-node-reparent ensures that if an AccessibilityNodeObject is
  created for a node without a renderer, but the node later gets a renderer,
  the AccessibilityNodeObject is detached and an AccessibilityRenderObject is
  created instead.

* accessibility/accessibility-node-memory-management-expected.txt: Added.
* accessibility/accessibility-node-memory-management.html: Added.
* accessibility/accessibility-node-reparent-expected.txt: Added.
* accessibility/accessibility-node-reparent.html: Added.
* accessibility/canvas-fallback-content-expected.txt: Added.
* accessibility/canvas-fallback-content.html: Added.
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 15 Aug 2012 21:24:24 +0000 (21:24 +0000)]
Unreviewed GTK gardening.

Updating baselines for <meter> tests after r125659.

Marking fullscreen/full-screen-iframe-legacy.html and
storage/websql/database-lock-after-reload.html as flaky.

* platform/gtk/TestExpectations:
* platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
* platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
* platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
* platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNinePieceImage: Avoid unnecessary duplication of default data in assignment operator.
kling@webkit.org [Wed, 15 Aug 2012 21:22:01 +0000 (21:22 +0000)]
NinePieceImage: Avoid unnecessary duplication of default data in assignment operator.
<http://webkit.org/b/94046>

Reviewed by Geoffrey Garen.

If copying a NinePieceImage with a null m_data, don't create a copy of it's data()
as that will point to the default NinePieceImageData. ~200kB progression on Membuster.

* rendering/style/NinePieceImage.h:
(WebCore::NinePieceImage::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] unskip passing fast/text tests.
commit-queue@webkit.org [Wed, 15 Aug 2012 21:20:42 +0000 (21:20 +0000)]
[Qt] unskip passing fast/text tests.
https://bugs.webkit.org/show_bug.cgi?id=94127

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-08-15
Reviewed by Csaba Osztrogonác.

Three fast/text tests are working for Qt5 (WK1 and WK2).

* platform/qt-5.0/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Updating test expectations after r125694.
leviw@chromium.org [Wed, 15 Aug 2012 21:19:01 +0000 (21:19 +0000)]
Unreviewed gardening. Updating test expectations after r125694.

* fast/table/rowindex-expected.txt: Added.
* fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
* fast/text/international/bidi-override-expected.txt: Added.
* fast/transforms/bounding-rect-zoom-expected.txt: Replaced.
* platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
* platform/chromium-linux/fast/text/international/bidi-layout-across-linebreak-expected.png:
* platform/chromium-linux/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
* platform/chromium-linux/fast/transforms/bounding-rect-zoom-expected.txt: Added.
* platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/001-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-button-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-checkbox-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-radio-expected.png:
* platform/chromium-mac-snowleopard/fast/table/rowindex-expected.png:
* platform/chromium-mac-snowleopard/fast/table/rowindex-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-CSS-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-HTML-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/text/international/bidi-override-expected.png:
* platform/chromium-mac-snowleopard/fast/text/international/bidi-override-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug33855-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug39209-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55527-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-mac/fast/table/rowindex-expected.txt: Removed.
* platform/chromium-mac/fast/text/international/bidi-override-expected.txt: Removed.
* platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Removed.
* platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
* platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.txt:
* platform/chromium/TestExpectations:
* platform/efl/fast/table/rowindex-expected.txt: Removed.
* platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
* platform/efl/fast/text/international/bidi-override-expected.txt: Removed.
* platform/efl/fast/transforms/bounding-rect-zoom-expected.txt: Removed.
* platform/gtk/fast/table/rowindex-expected.txt: Removed.
* platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
* platform/gtk/fast/text/international/bidi-override-expected.txt: Removed.
* platform/gtk/fast/transforms/bounding-rect-zoom-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Should not keep recreating GeoTracker in setEnableHighAccuracy()
commit-queue@webkit.org [Wed, 15 Aug 2012 21:13:15 +0000 (21:13 +0000)]
[BlackBerry] Should not keep recreating GeoTracker in setEnableHighAccuracy()
https://bugs.webkit.org/show_bug.cgi?id=94136

Patch by Yong Li <yoli@rim.com> on 2012-08-15
Reviewed by Rob Buis.
Internally reviewed by Lyon Chen.

PR# 192401.
1. The prototype of GeoTracker::create() has changed.
2. Fix the issue that it could recreate tracker unnecessarily when
   setEnableHighAccuracy() is called but accuracy requirment hasn't
   changed.
3. Fix the issue setEnableHighAccuracy() could start tracking when
   tracker was suspended.

* WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:
(GeolocationControllerClientBlackBerry::startUpdating):
(GeolocationControllerClientBlackBerry::setEnableHighAccuracy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuildfix after r125541
commit-queue@webkit.org [Wed, 15 Aug 2012 21:09:00 +0000 (21:09 +0000)]
Buildfix after r125541
https://bugs.webkit.org/show_bug.cgi?id=94097

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-08-15
Reviewed by Filip Pizlo.

r125541 has broken the traditional ARM port build of JSC.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::neg32):
(JSC::MacroAssemblerARM::xor32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMark Skia and Compositor Contexts
commit-queue@webkit.org [Wed, 15 Aug 2012 20:51:43 +0000 (20:51 +0000)]
Mark Skia and Compositor Contexts
https://bugs.webkit.org/show_bug.cgi?id=94129

Patch by Gregg Tavares <gman@google.com> on 2012-08-15
Reviewed by James Robinson.

Marks the Skia and Compositor contexts to aid in debugging.

No new tests as no new functionality.

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::createAcceleratedCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Must account for empty transformation lists when checking for big rotations.
vollick@chromium.org [Wed, 15 Aug 2012 20:50:10 +0000 (20:50 +0000)]
[chromium] Must account for empty transformation lists when checking for big rotations.
https://bugs.webkit.org/show_bug.cgi?id=93975

Reviewed by James Robinson.

Source/WebCore:

AnimationTranslationUtil.cpp is supposed to reject large rotations
(>= 180 degrees between keyframes). The current code assumes that if
the lists of transforms at two consecutive keyframes do not match
(i.e., are different types), then do not need to reject. The rationale
is that we will revert to matrix blending -- we will collapse the lists
of transform operations to matrices at each keyframe and blend those.
Unfortunately, this is not true if a list is empty. It can be the case
that we transition from no transform to a rotation about the z axis of
360 degrees. In this case, the first list of transform operations will
be empty and the second will have a single rotation of 360 degrees. An
empty list should be treated as a rotation of zero degrees.

Unit tested in: GraphicsLayerChromiumTest.createTransformAnimationWithBigRotationAndEmptyTransformOperationList

* platform/graphics/chromium/AnimationTranslationUtil.cpp:
(WebCore::causesRotationOfAtLeast180Degrees):

Source/WebKit/chromium:

Adds a test to check that creating an animation with a big (> 180
degree) rotation, where the transform operations list in the 1st
keyframe is empty fails as expected.

* tests/AnimationTranslationUtilTest.cpp:
(WebKit::TEST):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Use the unconverted attribute instead of composing when deciding to...
mifenton@rim.com [Wed, 15 Aug 2012 20:40:04 +0000 (20:40 +0000)]
[BlackBerry] Use the unconverted attribute instead of composing when deciding to how to handle key input.
https://bugs.webkit.org/show_bug.cgi?id=94132

Reviewed by Rob Buis.

PR 139838.

Switch direct key input handling to be based on the unconverted
attribute being present.  Converted keys, even during composition
are now input directly.

Reviewed Internally by Nima Ghanavatian.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=93693
bdakin@apple.com [Wed, 15 Aug 2012 19:58:58 +0000 (19:58 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=93693
[WK2] REGRESSION(125091): pixel results don't sow scrollbars
anymore

Reviewed by Sam Weinig.

Source/WebCore:

This is a regression from http://trac.webkit.org/changeset/125091
in which I failed to noticed that
WKBundlePageCreateSnapshotInViewCoordinates() did actually do
something different than
WKBundlePageCreateSnapshotInDocumentCoordinates(). Specifically,
it used ScrollView::paint() to paint instead of
FrameView::paintContents(). So this patch restores that
functionality by adding a value to SnapshotOptions indicating
whether the snapshot should be taken in ViewCoordinates
(otherwise it defaults to DocumentCoordinates).

FrameView:: paintContentsForSnapshot() now takes a new parameter
that indicates whether to take the snapshot in document
coordinates or view coordinates.
* WebCore.exp.in:
* page/FrameView.cpp:
(WebCore::FrameView::paintContentsForSnapshot):
* page/FrameView.h:

Source/WebKit2:

This is a regression from http://trac.webkit.org/changeset/125091
in which I failed to noticed that
WKBundlePageCreateSnapshotInViewCoordinates() did actually do
something different than
WKBundlePageCreateSnapshotInDocumentCoordinates(). Specifically,
it used ScrollView::paint() to paint instead of
FrameView::paintContents(). So this patch restores that
functionality by adding a value to SnapshotOptions indicating
whether the snapshot should be taken in ViewCoordinates
(otherwise it defaults to DocumentCoordinates).

* Shared/API/c/WKImage.h:
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toSnapshotOptions):
* Shared/ImageOptions.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scaledSnapshotWithOptions):

Even though we plan to deprecate this API, it should keep doing
the right thing until it's gone.
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCreateSnapshotInViewCoordinates):

Tools:

Use new API WKBundlePageCreateSnapshotWithOptions().
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Add rfong to Bugzilla CC "contributor" list.
ap@apple.com [Wed, 15 Aug 2012 19:39:41 +0000 (19:39 +0000)]
    Add rfong to Bugzilla CC "contributor" list.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse literal initialization for CSS's pseudo types
benjamin@webkit.org [Wed, 15 Aug 2012 19:38:35 +0000 (19:38 +0000)]
Use literal initialization for CSS's pseudo types
https://bugs.webkit.org/show_bug.cgi?id=94066

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-15
Reviewed by Kenneth Rohde Christiansen.

Initialize CSS pseudo type strings with the new initialization from literal.

The first invocation of nameToPseudoTypeMap() becomes 20% faster and we use
less memory to store the strings.

* css/CSSSelector.cpp:
(WebCore::nameToPseudoTypeMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] IndexedDB: Delete unused WebKit API cursor accessors
jsbell@chromium.org [Wed, 15 Aug 2012 19:36:46 +0000 (19:36 +0000)]
[chromium] IndexedDB: Delete unused WebKit API cursor accessors
https://bugs.webkit.org/show_bug.cgi?id=94134

Reviewed by Adam Barth.

Last bit of refactor work from http://webkit.org/b/92278 that ships the
cursor key/primaryKey/value to the front end via success messages, eliminating
the need for these accessors and the old success messages.

* public/WebIDBCallbacks.h:
* public/WebIDBCursor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemoving a plug-in element from a page opened in a background tab in Safari crashes
beidson@apple.com [Wed, 15 Aug 2012 19:33:37 +0000 (19:33 +0000)]
Removing a plug-in element from a page opened in a background tab in Safari crashes
<rdar://problem/12057991> and https://bugs.webkit.org/show_bug.cgi?id=93913

Reviewed by Beth Dakin.

.:

* Source/autotools/symbols.filter: Allow this symbol through for DRT's sake.

Source/WebCore:

Expose Page::setCanStartMedia to regression tests so they can pretend to be in a non-windowed WebView.

Test: platform/mac-wk2/plugins/asynchronous-destroy-before-initialization.html

* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setCanStartMedia):
(WebCore):
* testing/InternalSettings.h:
(Backup):
(InternalSettings):
* testing/InternalSettings.idl:

Source/WebKit2:

This only happens in WebKit2 with asynchronous plug-in initialization enabled.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::destroy): Null-check m_connection, as it might not have been created yet.

* win/WebKit2.def: Export Page::setCanStartMedia for InternalSettings/DRT use.

LayoutTests:

Using internal setting setCanStartMedia, pretend the page is in an unwindowed WebView then remove
the plug-in element.

* platform/mac-wk2/plugins/asynchronous-destroy-before-initialization-expected.txt: Added.
* platform/mac-wk2/plugins/asynchronous-destroy-before-initialization.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAutoTableLayout truncates preferred widths for cells when it needs to ceil them to...
leviw@chromium.org [Wed, 15 Aug 2012 19:32:30 +0000 (19:32 +0000)]
AutoTableLayout truncates preferred widths for cells when it needs to ceil them to contain the contents
https://bugs.webkit.org/show_bug.cgi?id=93911

Reviewed by Eric Seidel.

Source/WebCore:

Avoiding truncation of sub-pixel accumulated values when determining the preferred width of a table cell
in AutoTableLayout. Since we continue to layout tables using integers, we need to ceil the contents to
prevent premature wrapping of the contents.

This only affects ports with sub-pixel layout enabled, and fixes regressions of a handful of tests that
were missed when updating expectations when sub-pixel was enabled.

Test: fast/sub-pixel/auto-table-layout-should-avoid-text-wrapping.html

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):

LayoutTests:

This only affects ports with sub-pixel layout enabled, and fixes regressions of a handful of tests that
were missed when updating expectations when sub-pixel was enabled.

* fast/sub-pixel/auto-table-layout-should-avoid-text-wrapping-expected.txt: Added.
* fast/sub-pixel/auto-table-layout-should-avoid-text-wrapping.html: Added.
* platform/chromium-mac/editing/deleting/5144139-2-expected.txt:
* platform/chromium-mac/fast/forms/001-expected.png:
* platform/chromium-mac/fast/forms/001-expected.txt:
* platform/chromium-mac/fast/forms/button-white-space-expected.txt:
* platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
* platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
* platform/chromium-mac/fast/forms/formmove3-expected.txt:
* platform/chromium-mac/fast/replaced/width100percent-button-expected.png:
* platform/chromium-mac/fast/replaced/width100percent-button-expected.txt:
* platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png:
* platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.txt:
* platform/chromium-mac/fast/replaced/width100percent-radio-expected.png:
* platform/chromium-mac/fast/replaced/width100percent-radio-expected.txt:
* platform/chromium-mac/fast/table/rowindex-expected.png:
* platform/chromium-mac/fast/table/rowindex-expected.txt:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
* platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
* platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.png:
* platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.txt:
* platform/chromium-mac/fast/text/international/bidi-override-expected.png:
* platform/chromium-mac/fast/text/international/bidi-override-expected.txt:
* platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
* platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt:
* platform/chromium-mac/fast/transforms/bounding-rect-zoom-expected.txt:
* platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
* platform/chromium/TestExpectations:
* platform/mac/tables/mozilla/bugs/bug55527-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoz-index should work without position on flexitems
ojan@chromium.org [Wed, 15 Aug 2012 19:28:20 +0000 (19:28 +0000)]
z-index should work without position on flexitems
https://bugs.webkit.org/show_bug.cgi?id=91405

Reviewed by Tony Chang.

Source/WebCore:

Require a layer on any RenderBox that has a non-auto z-index.
Statically positioned, non-flex-item's have their z-index coerced to auto,
so it's safe to check z-index unconditionally.

Test: css3/flexbox/z-index.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
-Don't coerce z-index to auto on statically positioned flex-items.
-Use the parentStyle to determine if the parent is a flexbox instead of
looking at the element's parentNode's renderer.
* rendering/RenderBox.h:
-Add having a non-auto z-index to the list of things that require a layer.

LayoutTests:

* css3/flexbox/z-index-expected.html: Added.
* css3/flexbox/z-index.html: Added.
Use a ref-test since we want to be sure that the elements get painted in the right order.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Gtk] atk_text_set_caret_offset() fails for table cells
commit-queue@webkit.org [Wed, 15 Aug 2012 19:18:27 +0000 (19:18 +0000)]
[Gtk] atk_text_set_caret_offset() fails for table cells
https://bugs.webkit.org/show_bug.cgi?id=83501

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-08-15
Reviewed by Chris Fleizach.

Source/WebCore:

Allow using text ranges in accessible table cells.

* accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::allowsTextRanges):
Add table cells to the list of accessibility objects supporting text ranges.

Source/WebKit/gtk:

Update unit test to include setting the caret in a table cell via the AtkText interface.

* tests/testatk.c:
(testWebkitAtkCaretOffsets): Add setting the caret inside the text of a table cell.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename window.internals.fastMallocStatistics to mallocStatistics
commit-queue@webkit.org [Wed, 15 Aug 2012 19:08:06 +0000 (19:08 +0000)]
Rename window.internals.fastMallocStatistics to mallocStatistics
https://bugs.webkit.org/show_bug.cgi?id=94033

Patch by Scott Graham <scottmg@chromium.org> on 2012-08-15
Reviewed by Adam Barth.

PerformanceTests:

* resources/runner.js:
(PerfTestRunner.storeHeapResults):
(PerfTestRunner.getUsedMallocHeap):
(PerfTestRunner.getAndPrintMemoryStatistics):
(PerfTestRunner.initAndStartLoop):

Source/WebCore:

Mechanical rename. In preparation for plumbing allocation information
from allocators that aren't "fastMalloc".

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.vcproj/WebCoreTestSupport.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* loader/DocumentLoader.h:
(WebCore::DocumentLoader::didTellClientAboutLoad):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::loadResource):
* testing/FastMallocStatistics.h: Removed.
* testing/FastMallocStatistics.idl: Removed.
* testing/Internals.cpp:
(WebCore::Internals::mallocStatistics):
* testing/Internals.h:
(WebCore):
(Internals):
* testing/Internals.idl:
* testing/MallocStatistics.h: Added.
* testing/MallocStatistics.idl: Added.

Tools:

* GNUmakefile.am:
* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_memory_test):

LayoutTests:

* fast/harness/fastmallocstatistics-object.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Upstream BlackBerry build fixes
commit-queue@webkit.org [Wed, 15 Aug 2012 18:54:33 +0000 (18:54 +0000)]
[BlackBerry] Upstream BlackBerry build fixes
https://bugs.webkit.org/show_bug.cgi?id=94121

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-08-15
Reviewed by Rob Buis.

This includes several build fixes due to incorrect upstream patches.
These mistakes were never present downstream.

No new tests, because no new functionality is added.

Source/WebCore:

* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::computeFormatAndTypeParameters):
* platform/graphics/GraphicsContext3D.h:
(GraphicsContext3D):
(WebCore::GraphicsContext3D::ShaderSourceEntry::ShaderSourceEntry):
* platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore::LayerFilterRendererAction::LayerFilterRendererAction):
* platform/graphics/blackberry/LayerFilterRenderer.h:
(LayerFilterRendererAction):

Source/WebKit/blackberry:

* WebCoreSupport/AboutDataEnableFeatures.in:
* WebCoreSupport/AboutTemplate.html.cpp:
(writeHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate expectations to match the bots. This test hasn't timed out in over 500 runs.
ojan@chromium.org [Wed, 15 Aug 2012 18:44:17 +0000 (18:44 +0000)]
Update expectations to match the bots. This test hasn't timed out in over 500 runs.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJSDOMWrapper should ASSERT that it has an associated ScriptExecutionContext
abarth@webkit.org [Wed, 15 Aug 2012 18:44:02 +0000 (18:44 +0000)]
JSDOMWrapper should ASSERT that it has an associated ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=94053

Reviewed by Sam Weinig.

Previously we were unable have this ASSERT because DOMWindow needed a
Frame to find Document. Now that we can find the Document without a
Frame, we can include the ASSERT and sanity will rein across the land.

* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::globalObject):
(WebCore::JSDOMWrapper::scriptExecutionContext):
(WebCore::JSDOMWrapper::JSDOMWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange behavior of MasqueradesAsUndefined to better accommodate DFG changes
mhahnenberg@apple.com [Wed, 15 Aug 2012 18:32:41 +0000 (18:32 +0000)]
Change behavior of MasqueradesAsUndefined to better accommodate DFG changes
https://bugs.webkit.org/show_bug.cgi?id=93884

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

With some upcoming changes to the DFG to remove uses of ClassInfo, we will be changing the behavior of
MasqueradesAsUndefined. In order to make this change consistent across all of our execution engines,
we will make this change to MasqueradesAsUndefined as a separate patch. After this patch, MasqueradesAsUndefined
objects will only masquerade as undefined in their original context (i.e. their original JSGlobalObject).
For example, if an object that masquerades as undefined in frame A is passed to frame B, it will not
masquerade as undefined within frame B, but it will continue to masquerade in frame A.

There are two primary changes that are taking place here. One is to thread the ExecState* through
JSValue::toBoolean and JSCell::toBoolean so that JSCell::toBoolean can check the object's
JSGlobalObject to compare it to the lexical JSGlobalObject of the currently running code. If the two
are distinct, then the object cannot MasqueradeAsUndefined.

The other change is to perform this comparison of JSGlobalObjects everywhere where the MasqueradesAsUndefined
flag in the Structure is checked. For C++ code, this check has been factored into its own function in
Structure::masqueradesAsUndefined. We only perform this check in the DFG if the current JSGlobalObject has
had a MasqueradesAsUndefined object allocated within its context. This conditional compilation is managed
through the use of a WatchpointSet in each JSGlobalObject and alternate create() functions for JS DOM wrappers
that are MasqueradesAsUndefined.

* API/JSValueRef.cpp:
(JSValueToBoolean):
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* bytecode/Watchpoint.h:
(WatchpointSet):
* debugger/DebuggerCallFrame.h:
(JSC::DebuggerCallFrame::callFrame):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compile):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncSome):
* runtime/BooleanConstructor.cpp:
(JSC::constructBoolean):
(JSC::callBooleanConstructor):
* runtime/JSCell.h:
(JSCell):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::JSGlobalObject):
* runtime/JSGlobalObject.h:
(JSGlobalObject):
(JSC::JSGlobalObject::masqueradesAsUndefinedWatchpoint):
* runtime/JSString.h:
(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):
* runtime/JSValue.h:
* runtime/ObjectConstructor.cpp:
(JSC::toPropertyDescriptor):
* runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):
* runtime/Operations.h:
(JSC):
(JSC::JSValue::equalSlowCaseInline):
* runtime/RegExpConstructor.cpp:
(JSC::setRegExpConstructorMultiline):
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncToString):
* runtime/Structure.h:
(Structure):
(JSC::Structure::globalObjectOffset):
(JSC::Structure::masqueradesAsUndefined):
(JSC):

Source/WebCore:

With some upcoming changes to the DFG to remove uses of ClassInfo, we will be changing the behavior of
MasqueradesAsUndefined. In order to make this change consistent across all of our execution engines,
we will make this change to MasqueradesAsUndefined as a separate patch. After this patch, MasqueradesAsUndefined
objects will only masquerade as undefined in their original context (i.e. their original JSGlobalObject).
For example, if an object that masquerades as undefined in frame A is passed to frame B, it will not
masquerade as undefined within frame B, but it will continue to masquerade in frame A.

Test: fast/js/document-all-between-frames.html

All of the changes in WebCore are simply passing the additional ExecState argument to JSValue::toBoolean.

* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSSQLStatementErrorCallback::handleEvent):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):
* bindings/js/JSDataViewCustom.cpp:
(WebCore::getDataViewMember):
* bindings/js/JSDeviceMotionEventCustom.cpp:
(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):
* bindings/js/JSDeviceOrientationEventCustom.cpp:
(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
* bindings/js/JSDirectoryEntryCustom.cpp:
(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):
* bindings/js/JSDirectoryEntrySyncCustom.cpp:
(WebCore::getFlags):
* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
* bindings/js/JSInspectorFrontendHostCustom.cpp:
(WebCore::populateContextMenuItems):
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::handleInitMessageEvent):
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::dataFunctionMatrix):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::open):
* bindings/js/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::exec):
(WebCore):
* bindings/js/JavaScriptCallFrame.h:
(JavaScriptCallFrame):
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::hasBreakpoint):
* bindings/scripts/CodeGeneratorJS.pm: Also add the custom create function for MasqueradesAsUndefined JS DOM wrappers.
(GenerateEventListenerCall):
(GenerateHeader):
(JSValueToNative):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):
* bindings/scripts/test/JS/JSTestEventTarget.h:
(WebCore::JSTestEventTarget::create):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
* bridge/c/c_utility.cpp:
(JSC::Bindings::convertValueToNPVariant):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::convertValueToJObject):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):

Source/WebKit/mac:

With some upcoming changes to the DFG to remove uses of ClassInfo, we will be changing the behavior of
MasqueradesAsUndefined. In order to make this change consistent across all of our execution engines,
we will make this change to MasqueradesAsUndefined as a separate patch. After this patch, MasqueradesAsUndefined
objects will only masquerade as undefined in their original context (i.e. their original JSGlobalObject).
For example, if an object that masquerades as undefined in frame A is passed to frame B, it will not
masquerade as undefined within frame B, but it will continue to masquerade in frame A.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::addValueToArray): Passing ExecState to toBoolean call.

Source/WebKit2:

With some upcoming changes to the DFG to remove uses of ClassInfo, we will be changing the behavior of
MasqueradesAsUndefined. In order to make this change consistent across all of our execution engines,
we will make this change to MasqueradesAsUndefined as a separate patch. After this patch, MasqueradesAsUndefined
objects will only masquerade as undefined in their original context (i.e. their original JSGlobalObject).
For example, if an object that masquerades as undefined in frame A is passed to frame B, it will not
masquerade as undefined within frame B, but it will continue to masquerade in frame A.

* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant): Passing ExecState to toBoolean call.

LayoutTests:

Added a test that uses a variety of ways of checking whether something is correctly
masquerading as undefined (or not) in a subframe.

* fast/js/document-all-between-frames-expected.txt: Added.
* fast/js/document-all-between-frames.html: Added.
* fast/js/resources/document-all-between-frames-subframe.html: Added.
* platform/chromium/TestExpectations: Chromium treats document.all differently, so skip our new test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate TestExpectations entry to refer to an actual bug.
abarth@webkit.org [Wed, 15 Aug 2012 18:31:03 +0000 (18:31 +0000)]
Update TestExpectations entry to refer to an actual bug.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Gtk] atk_text_get_text_at_offset() fails to provide the correct line for paragraphs...
commit-queue@webkit.org [Wed, 15 Aug 2012 18:13:46 +0000 (18:13 +0000)]
[Gtk] atk_text_get_text_at_offset() fails to provide the correct line for paragraphs in list items whose text wraps
https://bugs.webkit.org/show_bug.cgi?id=83435

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-08-15
Reviewed by Chris Fleizach.

Source/WebCore:

Fix a logic error when checking if an object is a list marker.

* accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
(textForRenderer):

Source/WebKit/gtk:

Updated unit test to include a paragraph in a list item when testing atk_text_get_text_at_offset().

* tests/testatk.c:
(testWebkitAtkGetTextAtOffsetWithSpecialCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThere is additional space not belonged to a table between the table cells
commit-queue@webkit.org [Wed, 15 Aug 2012 18:01:05 +0000 (18:01 +0000)]
There is additional space not belonged to a table between the table cells
https://bugs.webkit.org/show_bug.cgi?id=74864

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-08-15
Reviewed by Julien Chaffraix.

Source/WebCore:

Hittest for a point on the edge, i.e. between two table columns, currently
does not return any matching underlying element.

A hittest on such a point (on the edge of two table columns) should return
the column that lies either on the logical right/bottom of the said point.

Tests: fast/table/hittest-tablecell-bottom-edge.html
       fast/table/hittest-tablecell-right-edge.html
       fast/table/hittest-tablecell-with-borders-bottom-edge.html
       fast/table/hittest-tablecell-with-borders-right-edge.html

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::spannedRows):
Removed the FIXME regarding the correctness of the usage of the upper_bound algorithm
since that is now verified by the testcases in this patch. Also, the comment
regarding the inconsistency between the algorithms used in spannedRows and spannedColumns
is no longer valid.

(WebCore::RenderTableSection::spannedColumns):
Changed lower_bound() algorithm to upper_bound() for obtaining the next column.
This is now similar to what is used for obtaining the next row in spannedRows().

LayoutTests:

* fast/table/hittest-tablecell-bottom-edge-expected.txt: Added.
* fast/table/hittest-tablecell-bottom-edge.html: Added.
* fast/table/hittest-tablecell-right-edge-expected.txt: Added.
* fast/table/hittest-tablecell-right-edge.html: Added.
Testcases added for verifying that the proper node is returned upon hit test
carried out at a point lying on the edge of two table cells.

* fast/table/hittest-tablecell-with-borders-bottom-edge-expected.txt: Added.
* fast/table/hittest-tablecell-with-borders-bottom-edge.html: Added.
* fast/table/hittest-tablecell-with-borders-right-edge-expected.txt: Added.
* fast/table/hittest-tablecell-with-borders-right-edge.html: Added.
These testcases verify the aforementioned behavior when the table cells
also have border specified for them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a warning in TestWebKitAPI's MediaTime test-suite
peter@chromium.org [Wed, 15 Aug 2012 17:59:08 +0000 (17:59 +0000)]
Fix a warning in TestWebKitAPI's MediaTime test-suite
https://bugs.webkit.org/show_bug.cgi?id=94096

Reviewed by Adam Barth.

This warning is visible when building the file with certain GCC versions,
including the one used by Chromium for Android. The warning is visible in
the cr-android build bot output:

MediaTime.cpp:152: warning: this decimal constant is unsigned only in ISO C90

* TestWebKitAPI/Tests/WTF/MediaTime.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd the timestampOffset attribute to SourceBuffer.
annacc@chromium.org [Wed, 15 Aug 2012 16:58:02 +0000 (16:58 +0000)]
Add the timestampOffset attribute to SourceBuffer.
https://bugs.webkit.org/show_bug.cgi?id=93303

Reviewed by Dimitri Glazkov.

On the 30 July 2012 version of the Media Source Extensions spec, a timestampOffset
attribute was added to the SourceBuffer object:
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html#dom-timestampoffset

Source/WebCore:

Tests: additions to http/tests/media/media-source/video-media-source-objects.html

* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::setTimestampOffset): Set the timestampOffset on MediaPlayer.
(WebCore):
* Modules/mediasource/MediaSource.h:
(MediaSource):
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::SourceBuffer): Let the timestampOffset be 0 initially
(WebCore::SourceBuffer::timestampOffset): Return the last value set.
(WebCore):
(WebCore::SourceBuffer::setTimestampOffset): Forward the call onto MediaSouce.
* Modules/mediasource/SourceBuffer.h:
(SourceBuffer):
* Modules/mediasource/SourceBuffer.idl: Create the new timestampOffset attr.
* platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::sourceSetTimestampOffset): A null media player
    should just return false (nothing to set).
(WebCore):
(WebCore::MediaPlayer::sourceSetTimestampOffset):  Forward the call.
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::sourceSetTimestampOffset):

Source/WebKit/chromium:

* public/WebMediaPlayer.h:
(WebKit::WebMediaPlayer::sourceSetTimestampOffset): Add the new method.
* src/WebMediaPlayerClientImpl.cpp:
(WebKit):
(WebKit::WebMediaPlayerClientImpl::sourceSetTimestampOffset): Forward the call.
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):

LayoutTests:

* http/tests/media/media-source/video-media-source-objects-expected.txt:
* http/tests/media/media-source/video-media-source-objects.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Web Inspector: Incorrect XHR responses when two async xhrs are sent...
vsevik@chromium.org [Wed, 15 Aug 2012 16:50:13 +0000 (16:50 +0000)]
Source/WebCore: Web Inspector: Incorrect XHR responses when two async xhrs are sent synchronously
https://bugs.webkit.org/show_bug.cgi?id=91630

Patch by Pavel Chadnov <chadnov@google.com> on 2012-08-15
Reviewed by Vsevolod Vlasov.

CachedResource object for XHR response is now taken from ResourceLoader (if it's possible).

Test: http/tests/inspector/network/network-xhr-async-double.html

* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didReceiveResourceResponseButCanceledImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didReceiveResourceResponse):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::didReceiveResponse):
* inspector/InspectorResourceAgent.h:
(WebCore):
(InspectorResourceAgent):
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::didReceiveResponse):
* loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::didReceiveResponse):
(WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
* loader/ResourceLoadNotifier.h:
(ResourceLoadNotifier):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::isSubresourceLoader):
(WebCore):
* loader/ResourceLoader.h:
(ResourceLoader):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::cachedResource):
(WebCore):
(WebCore::SubresourceLoader::isSubresourceLoader):
* loader/SubresourceLoader.h:
(SubresourceLoader):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didReceiveResponse):

LayoutTests: Web Inspector: Incorrect XHR responses when two async xhrs are sent synchronously
https://bugs.webkit.org/show_bug.cgi?id=91630

Patch by Pavel Chadnov <chadnov@google.com> on 2012-08-15
Reviewed by Vsevolod Vlasov.

New test for two async XHRs sent synchronously.

* http/tests/inspector/network-test.js:
(doXHR):
(doXHRWithPayload.xhr.onreadystatechange):
(doXHRWithPayload):
* http/tests/inspector/network/network-xhr-async-double-expected.txt: Added.
* http/tests/inspector/network/network-xhr-async-double.html: Added.
* http/tests/inspector/network/resources/echo-payload.php: Added.
* platform/chromium/http/tests/inspector/console-xhr-logging-async-expected.txt:
* platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Use nested layout when rotating
commit-queue@webkit.org [Wed, 15 Aug 2012 16:20:39 +0000 (16:20 +0000)]
[BlackBerry] Use nested layout when rotating
https://bugs.webkit.org/show_bug.cgi?id=94117

Partially patched by Arvid Nilsson.

Patch by Leo Yang <leoyang@rim.com> on 2012-08-15
Reviewed by George Staikos.
Reviewed internally by Arvid Nilsson.

When rotating the content width used for fixedLayoutSize is not
correct because we are changing the rotation and the content with
should be determined after layout. So we set the with to 0 if we
are rotating and beginning the nested layout. And in setViewportSize
we need a nested layout loop to trigger zoom-to-fit.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Stop copying ScrollViewBase vector all over
tonikitoo@webkit.org [Wed, 15 Aug 2012 16:06:30 +0000 (16:06 +0000)]
[BlackBerry] Stop copying ScrollViewBase vector all over
https://bugs.webkit.org/show_bug.cgi?id=94021

Reviewed by Rob Buis.

It outlives long enough in WebKit that we can
just pass a const+ref of it.

Internally reviewed by Gen Mak.

* Api/WebPageClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRobust-fy the LayerWebKitThread ownership with InRegionScroller
tonikitoo@webkit.org [Wed, 15 Aug 2012 16:05:56 +0000 (16:05 +0000)]
Robust-fy the LayerWebKitThread ownership with InRegionScroller
https://bugs.webkit.org/show_bug.cgi?id=93983
PR #191737

Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>

Patch changes the way we currently keep track of the active scrollable area
objects: before, we acquired the scrollable areas and just passed them in a vector up
to the client, copying it over and over again. Also, it was a client responsability to
delete stuff (BAD!).
Now, we keep track of vector within InRegionScroller, as a class member, which allows us to
avoid copies (in follow up patch), and control until when these objects outlive.

Patch also changes InRegionScrollableArea to "retptr" the composited layer
associated to it (if any). This ensure we have a non-null scrollable element always.

As mentioned, InRegionScroller is now responsible for deleting and vector of scrollable areas.

Internally reviewed by Arvid Nilsson.

* Api/InRegionScroller.cpp:
(WebKit):
(BlackBerry::WebKit::InRegionScrollerPrivate::reset): Method is now responsible for
deleting the tracked scrollable areas.
(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
Renamed from 'inRegionScrollableAreasForPoint'. It was changed in order to store the
scrollable area objects instead of just pass a copy of them up to the client.
(BlackBerry::WebKit::InRegionScrollerPrivate::activeInRegionScrollableAreas): Getter.
(BlackBerry::WebKit::InRegionScrollerPrivate::pushBackInRegionScrollable): It was
promoted to a class method instead of a local helper.
* Api/InRegionScroller_p.h:
(WebKit):
(InRegionScrollerPrivate):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint): Adjustments needed due to the
above changed.
* WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::~InRegionScrollableArea): Clear up the cached layer.
(WebKit):
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
* WebKitSupport/InRegionScrollableArea.h:
(InRegionScrollableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Use default parameter on reportResult in InspectorFileSystemAgent
commit-queue@webkit.org [Wed, 15 Aug 2012 15:56:28 +0000 (15:56 +0000)]
Web Inspector: Use default parameter on reportResult in InspectorFileSystemAgent
https://bugs.webkit.org/show_bug.cgi?id=93930

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-15
Reviewed by Vsevolod Vlasov.

No functional change.

* inspector/InspectorFileSystemAgent.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Check for valid field focus before processing a spellcheck request
commit-queue@webkit.org [Wed, 15 Aug 2012 15:50:04 +0000 (15:50 +0000)]
[BlackBerry] Check for valid field focus before processing a spellcheck request
https://bugs.webkit.org/show_bug.cgi?id=94115

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-08-15
Reviewed by Rob Buis.

PR192891
Checking for valid field focus before processing the spellcheck
request.

Internally reviewed by Mike Fenton.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the 'git log' call in VCSUtils.pm for Windows
commit-queue@webkit.org [Wed, 15 Aug 2012 15:46:47 +0000 (15:46 +0000)]
Fix the 'git log' call in VCSUtils.pm for Windows
https://bugs.webkit.org/show_bug.cgi?id=94113

Patch by Kevin Funk <kevin.funk@kdab.com> on 2012-08-15
Reviewed by Kenneth Rohde Christiansen.

Failed because of invalid enquoting characters.

* Scripts/VCSUtils.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[jhbuild] move md5sum checking to update-webkit-libs-jhbuild
kov@webkit.org [Wed, 15 Aug 2012 14:17:44 +0000 (14:17 +0000)]
[jhbuild] move md5sum checking to update-webkit-libs-jhbuild
https://bugs.webkit.org/show_bug.cgi?id=93208

Reviewed by Martin Robinson.

This change makes the md5sum check and saving be done by the script
that performs the dependencies update. build-webkit no longer prefixes
calls to commands with jhbuild-wrapper if jhbuild has not been
bootstrapped by the developer and --update-gtk is not given.

* Scripts/update-webkit-libs-jhbuild:
(getMD5HashForFile): moved from webkitdirs.
(jhbuildConfigurationChanged): ditto.
(saveJhbuildMd5): ditto.
(cleanJhbuild): ditto, and changed to run jhbuild clean before removing
jhbuild.
* Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary): use jhbuildWrapperPrefixIfNeeded.
(buildAutotoolsProject): ditto.
(jhbuildWrapperPrefixIfNeeded): add a code branch for GTK+.
(generateBuildSystemFromCMakeProject): call update-webkitefl-libs
unconditionally for EFL.
* jhbuild/jhbuild-wrapper:
(update_webkit_libs_jhbuild): removed, jhbuild-wrapper no longer runs the
update script itself
(ensure_jhbuild): remove update call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: TabbedEditorContainer Doens't show '*' near modified file name sometimes.
vsevik@chromium.org [Wed, 15 Aug 2012 13:58:40 +0000 (13:58 +0000)]
Web Inspector: TabbedEditorContainer Doens't show '*' near modified file name sometimes.
https://bugs.webkit.org/show_bug.cgi?id=94095

Reviewed by Pavel Feldman.

TabbedEditorContainer now correctly updates event listeners on UISourceCodeReplaced event.

* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._appendFileTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._addUISourceCodeListeners):
(WebInspector.TabbedEditorContainer.prototype._removeUISourceCodeListeners):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Scroll/selection are not saved in sources panel editors sometimes.
vsevik@chromium.org [Wed, 15 Aug 2012 13:53:53 +0000 (13:53 +0000)]
Web Inspector: Scroll/selection are not saved in sources panel editors sometimes.
https://bugs.webkit.org/show_bug.cgi?id=94098

Reviewed by Pavel Feldman.

SourceFrame listeners and _currentFile field are now cleared only when currently open tab is closed.

* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._tabClosed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125672 268f45cc-cd09-0410-ab3c-d52691b4dbfc