WebKit-https.git
9 years agoVersioning.
mrowe@apple.com [Fri, 10 Dec 2010 00:28:29 +0000 (00:28 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry and fix the mac build.
weinig@apple.com [Thu, 9 Dec 2010 23:47:37 +0000 (23:47 +0000)]
Try and fix the mac build.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Chromium test expectations update.
pkasting@chromium.org [Thu, 9 Dec 2010 23:24:46 +0000 (23:24 +0000)]
Unreviewed Chromium test expectations update.

Mark a test as timing out on Win Debug.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 9 Dec 2010 23:22:15 +0000 (23:22 +0000)]
2010-12-09  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        Make new-run-webkit-tests --lint-test-files log slightly better
        messages and return -1 if lint fails. Remove the
        'suppress_errors' keyword param to the TestExpectationsFile
        class, and clean up logging and exception raising for error
        handling. Also add more unit tests and clean up the unit test code a bit.

        https://bugs.webkit.org/show_bug.cgi?id=50205

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/style/checkers/test_expectations.py:
        * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoved an unused variable.
mitz@apple.com [Thu, 9 Dec 2010 23:02:54 +0000 (23:02 +0000)]
Removed an unused variable.

Reviewed by Dave Hyatt.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights): Removed parentLineHeight.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8749750> and https://bugs.webkit.org/show_bug.cgi?id=50786
beidson@apple.com [Thu, 9 Dec 2010 22:35:45 +0000 (22:35 +0000)]
<rdar://problem/8749750> and https://bugs.webkit.org/show_bug.cgi?id=50786
WK2 authentication never consults WebCore session credential storage.

Reviewed by Sam Weinig.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage): Since we don't need to expose this as
  API at this time, always return true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Chromium test expectations update.
pkasting@chromium.org [Thu, 9 Dec 2010 22:32:06 +0000 (22:32 +0000)]
Unreviewed Chromium test expectations update.

Rebaseline a Linux test.

* platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.checksum:
* platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Add support for access keys
weinig@apple.com [Thu, 9 Dec 2010 22:31:40 +0000 (22:31 +0000)]
WebKit2: Add support for access keys
https://bugs.webkit.org/show_bug.cgi?id=49832

Reviewed by Alexey Proskuryakov.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::handleKeyEvent): Match windows WebKit and call
the event handler's for handleAccessKey function for
system keys. This will never be hit on the Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoQt build fix.
darin@apple.com [Thu, 9 Dec 2010 22:30:54 +0000 (22:30 +0000)]
Qt build fix.

* WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp: Include "NotImplemented.h".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix date.
darin@apple.com [Thu, 9 Dec 2010 22:29:22 +0000 (22:29 +0000)]
Fix date.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 9 Dec 2010 22:24:40 +0000 (22:24 +0000)]
2010-12-08  Darin Adler  <darin@apple.com>

        Reviewed by Geoffrey Garen.

        Move DOMWindow::setLocation logic into DOMWindow class and out of JavaScript binding
        https://bugs.webkit.org/show_bug.cgi?id=50640

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::printErrorMessageForFrame): Removed body; just call through to
        DOMWindow::printErrorMessage.

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Removed body;
        just call through to DOMWindow::crossDomainAccessErrorMessage.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::setLocation): Changed terminology to use activeFrame and
        firstFrame, rather than the older lexicalFrame and dynamicFrame. Removed most
        of the body and moved it into DOMWindow::setLocation.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::setLocation): Added. Does all the same work that
        JSDOMWindow::setLocation used to do, but in a way that's not specific
        to JavaScript.
        (WebCore::DOMWindow::printErrorMessage): Added.
        (WebCore::DOMWindow::crossDomainAccessErrorMessage): Added.

        * page/DOMWindow.h: Added setLocation, printErrorMessage, and
        crossDomainAccessErrorMessage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix.
sfalken@apple.com [Thu, 9 Dec 2010 22:17:02 +0000 (22:17 +0000)]
Windows build fix.

* WebProcess/WebCoreSupport/win/WebContextMenuClientWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect
hyatt@apple.com [Thu, 9 Dec 2010 21:49:44 +0000 (21:49 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect
writing-mode.  This first part of the patch just patches Mac WebKit 1 views.

Reviewed by Dan Bernstein.

* WebView/WebFrameView.mm:
(-[WebFrameView _isVerticalDocument]):
(-[WebFrameView _isFlippedDocument]):
(-[WebFrameView _scrollToEndOfDocument]):
(-[WebFrameView _pageInBlockProgressionDirection:]):
(-[WebFrameView scrollPageUp:]):
(-[WebFrameView scrollPageDown:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2 needs smooth scrolling support on the mac
weinig@apple.com [Thu, 9 Dec 2010 21:47:06 +0000 (21:47 +0000)]
WebKit2 needs smooth scrolling support on the mac
<rdar://problem/8219402>

Reviewed by Dan Bernstein.

* WebCore.xcodeproj/project.pbxproj: Change ScrollAnimatorMac.cpp to ScrollAnimatorMac.mm.
* platform/mac/ScrollAnimatorMac.cpp: Removed.
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm: Copied from platform/mac/ScrollAnimatorMac.cpp.
(-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollAnimationHelperDelegate bounds]):
(-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
(-[ScrollAnimationHelperDelegate convertSizeToBase:]):
(-[ScrollAnimationHelperDelegate convertSizeFromBase:]):
(-[ScrollAnimationHelperDelegate superview]):
(-[ScrollAnimationHelperDelegate documentView]):
(-[ScrollAnimationHelperDelegate window]):
(-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scroll):
(WebCore::ScrollAnimatorMac::setScrollPositionAndStopAnimation):
(WebCore::ScrollAnimatorMac::currentPosition):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
Add implementation of ScrollAnimator for the Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8613779> and https://bugs.webkit.org/show_bug.cgi?id=50777
beidson@apple.com [Thu, 9 Dec 2010 21:12:54 +0000 (21:12 +0000)]
<rdar://problem/8613779> and https://bugs.webkit.org/show_bug.cgi?id=50777
WebKit2 ContextMenuClient support

Reviewed by Anders Carlsson.

WebCore:

Export some symbols and headers needed by WebKit2 Mac:
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:

WebKit2:

Implement google search in a cross platform manner, and add a FIXME for download support:
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::downloadURL):
(WebKit::WebContextMenuClient::searchWithGoogle):

Mac implementations for speaking and searching:
* WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm: Added.
(WebKit::WebContextMenuClient::lookUpInDictionary): Add a FIXME for now.
(WebKit::WebContextMenuClient::isSpeaking):
(WebKit::WebContextMenuClient::speak):
(WebKit::WebContextMenuClient::stopSpeaking):
(WebKit::WebContextMenuClient::searchWithSpotlight):

Stubs for Win and Qt:
* WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp: Added.
(WebKit::WebContextMenuClient::lookUpInDictionary):
(WebKit::WebContextMenuClient::isSpeaking):
(WebKit::WebContextMenuClient::speak):
(WebKit::WebContextMenuClient::stopSpeaking):
* WebProcess/WebCoreSupport/win/WebContextMenuClientWin.cpp: Added.
(WebKit::WebContextMenuClient::lookUpInDictionary):
(WebKit::WebContextMenuClient::isSpeaking):
(WebKit::WebContextMenuClient::speak):
(WebKit::WebContextMenuClient::stopSpeaking):

Project file stuffs:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 9 Dec 2010 21:10:26 +0000 (21:10 +0000)]
2010-12-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r73635.
        http://trac.webkit.org/changeset/73635
        https://bugs.webkit.org/show_bug.cgi?id=50778

        'Side-effects on 3 css tests needs closer review' (Requested
        by mwenge on #webkit).

        * platform/qt/Skipped:
2010-12-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r73635.
        http://trac.webkit.org/changeset/73635
        https://bugs.webkit.org/show_bug.cgi?id=50778

        'Side-effects on 3 css tests needs closer review' (Requested
        by mwenge on #webkit).

        * platform/graphics/qt/ImageQt.cpp:
        (loadResourcePixmap):
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
        (WebCore::RenderThemeQt::paintSearchField):
        (WebCore::RenderThemeQt::adjustSearchFieldStyle):
        (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
        (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
        * platform/qt/RenderThemeQt.h:
2010-12-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r73635.
        http://trac.webkit.org/changeset/73635
        https://bugs.webkit.org/show_bug.cgi?id=50778

        'Side-effects on 3 css tests needs closer review' (Requested
        by mwenge on #webkit).

        * Api/qwebsettings.cpp:
        (graphics):
        * Api/qwebsettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Alex Bredariol Grilo <abgrilo@profusion.mobi>
commit-queue@webkit.org [Thu, 9 Dec 2010 21:06:51 +0000 (21:06 +0000)]
2010-12-09  Alex Bredariol Grilo  <abgrilo@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Add missing function in WebKit-EFL API

        Add ewk_tiled_backing_store_zoom_weak_smooth_scale_set function in
        WebKit-EFL API. This function was already implemented but missing in
        header file.

        * ewk/ewk_tiled_backing_store.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Thu, 9 Dec 2010 21:06:11 +0000 (21:06 +0000)]
2010-12-09  Michael Saboff  <msaboff@apple.com>

        Reviewed by Gavin Barraclough.

        REGRESSION (r73065?): A regex no longer works
        https://bugs.webkit.org/show_bug.cgi?id=50570

        Changed the handling of adjacent parentheses backtracks in two ways.
        First, only outer most paren backtracks default to back tracking
        to the "next character" looping code.  Second, added a jump around
        backtracks that fall through to the next backtrack where the
        second backtrack has some greedy processing before the backtracking
        from outside the parentheses code.
        Also cleaned up extraneous white spce, removing white space at the
        end of or that makes up a whole line.

        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::GenerationState::GenerationState):
        (JSC::Yarr::RegexGenerator::GenerationState::incrementParenNestingLevel):
        (JSC::Yarr::RegexGenerator::GenerationState::decrementParenNestingLevel):
        (JSC::Yarr::RegexGenerator::GenerationState::addParenthesesTail):
        (JSC::Yarr::RegexGenerator::GenerationState::emitParenthesesTail):
        (JSC::Yarr::RegexGenerator::ParenthesesTail::ParenthesesTail):
        (JSC::Yarr::RegexGenerator::ParenthesesTail::setNextIteration):
        (JSC::Yarr::RegexGenerator::ParenthesesTail::generateCode):
        (JSC::Yarr::RegexGenerator::generateParenthesesSingle):
2010-12-09  Michael Saboff  <msaboff@apple.com>

        Reviewed by Gavin Barraclough.

        REGRESSION (r73065?): A regex no longer works
        https://bugs.webkit.org/show_bug.cgi?id=50570

        Added tests that came from submitter to validate change.

        * fast/regex/parentheses-expected.txt:
        * fast/regex/script-tests/parentheses.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Chromium test expectations update.
pkasting@chromium.org [Thu, 9 Dec 2010 20:57:32 +0000 (20:57 +0000)]
Unreviewed Chromium test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 9 Dec 2010 20:56:27 +0000 (20:56 +0000)]
2010-12-09  Tony Chang  <tony@chromium.org>

        Unreviewed, fix for windows code.  We were catching the wrong
        exception in Windows.

        * Scripts/webkitpy/common/system/filesystem.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Cosmin Truta <ctruta@chromium.org>
commit-queue@webkit.org [Thu, 9 Dec 2010 20:51:20 +0000 (20:51 +0000)]
2010-12-09  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by Adam Barth.

        Rebaseline svg/custom/text-linking.svg
        https://bugs.webkit.org/show_bug.cgi?id=50310

        * platform/chromium/test_expectations.txt:
        * platform/chromium-win/svg/custom/text-linking-expected.checksum: Added.
        * platform/chromium-win/svg/custom/text-linking-expected.png: Added.
        * platform/chromium-win/svg/custom/text-linking-expected.txt: Added.
        * platform/mac-leopard/svg/custom/text-linking-expected.checksum: Updated.
        * platform/mac-leopard/svg/custom/text-linking-expected.png: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Chromium test expectations update.
pkasting@chromium.org [Thu, 9 Dec 2010 20:09:24 +0000 (20:09 +0000)]
Unreviewed Chromium test expectations update.

* platform/chromium-gpu/test_expectations.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Robert Hogan <robert@webkit.org>
robert@webkit.org [Thu, 9 Dec 2010 19:54:19 +0000 (19:54 +0000)]
2010-12-09  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Search input field doesn't have cancel button
        Add a cancel button to the search field and make it customizable
        by the client. For now, use the close dialog button associated
        with the application's style as the default.

        Unskip a bunch of search field related tests that pass now:

        fast/forms/search-cancel-button-mouseup.html
        fast/forms/search-rtl.html
        fast/forms/search-abs-pos-cancel-button.html
        fast/forms/search-styled.html
        fast/forms/search-transformed.html
        fast/forms/search-zoomed.html
        fast/forms/search-cancel-button-style-sharing.html
        fast/forms/search-display-none-cancel-button.html
        fast/forms/search-placeholder-value-changed.html
        fast/repaint/search-field-cancel.html
        fast/forms/search-cancel-button-events.html

        https://bugs.webkit.org/show_bug.cgi?id=42887

        * platform/qt/Skipped:
2010-12-09  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Search input field doesn't have cancel button

        Add a cancel button to the search field and make it customizable
        by the client. For now, use the close dialog button associated
        with the application's style as the default.

        https://bugs.webkit.org/show_bug.cgi?id=42887

        * platform/graphics/qt/ImageQt.cpp:
        (loadResourcePixmap):
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
        (WebCore::RenderThemeQt::paintSearchField):
        (WebCore::RenderThemeQt::adjustSearchFieldStyle):
        (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
        (WebCore::RenderThemeQt::convertToPaintingRect):
        (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
        * platform/qt/RenderThemeQt.h:
2010-12-09  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Search input field doesn't have cancel button

        Add a cancel button to the search field and make it customizable
        by the client. For now, use the close dialog button associated
        with the application's style as the default.

        https://bugs.webkit.org/show_bug.cgi?id=42887

        * Api/qwebsettings.cpp:
        (graphics):
        * Api/qwebsettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Thu, 9 Dec 2010 19:36:44 +0000 (19:36 +0000)]
2010-12-09  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: Crash when handling iframe of size 0.
        https://bugs.webkit.org/show_bug.cgi?id=50730

        * fast/spatial-navigation/snav-hidden-iframe-zero-size-expected.txt: Added.
        * fast/spatial-navigation/snav-hidden-iframe-zero-size.html: Added.
2010-12-09  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: Crash when handling iframe of size 0.
        https://bugs.webkit.org/show_bug.cgi?id=50730

        if we have a frame of size 0, we would get into infinite loop and eventually crash. The reason is
        that when the algorithm sees a starting rect of size 0, it assumes that there is no focused node,
        thus restarts itself. The solution is to avoid considering iframes with size 0 for the spatial
        navigation algorithm.

        Test: fast/spatial-navigation/snav-hidden-iframe-zero-size.html

        * page/FocusController.cpp:
        (WebCore::updateFocusCandidateIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com>
hans@chromium.org [Thu, 9 Dec 2010 19:35:28 +0000 (19:35 +0000)]
2010-12-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r73616.
        http://trac.webkit.org/changeset/73616
        https://bugs.webkit.org/show_bug.cgi?id=50772

        Breaks chromium win build (Requested by hwennborg on #webkit).

        * public/WebIDBKey.h:
        (WebKit::WebIDBKey::WebIDBKey):
        * src/WebIDBKey.cpp:
        (WebKit::WebIDBKey::assign):
        (WebKit::WebIDBKey::number):
2010-12-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r73616.
        http://trac.webkit.org/changeset/73616
        https://bugs.webkit.org/show_bug.cgi?id=50772

        Breaks chromium win build (Requested by hwennborg on #webkit).

        * bindings/v8/IDBBindingUtilities.cpp:
        (WebCore::createIDBKeyFromValue):
        * bindings/v8/custom/V8IDBKeyCustom.cpp:
        (WebCore::toV8):
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::createTables):
        (WebCore::IDBFactoryBackendImpl::open):
        * storage/IDBKey.cpp:
        (WebCore::IDBKey::IDBKey):
        (WebCore::IDBKey::fromQuery):
        (WebCore::IDBKey::bind):
        (WebCore::IDBKey::bindWithNulls):
        * storage/IDBKey.h:
        (WebCore::IDBKey::create):
        (WebCore::IDBKey::number):
2010-12-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r73616.
        http://trac.webkit.org/changeset/73616
        https://bugs.webkit.org/show_bug.cgi?id=50772

        Breaks chromium win build (Requested by hwennborg on #webkit).

        * storage/indexeddb/index-basics-expected.txt:
        * storage/indexeddb/index-basics.html:
        * storage/indexeddb/index-cursor.html:
        * storage/indexeddb/keyrange-expected.txt:
        * storage/indexeddb/keyrange.html:
        * storage/indexeddb/objectstore-cursor.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLand failing expected results for editing tests that have been failing since they...
bweinstein@apple.com [Thu, 9 Dec 2010 19:28:00 +0000 (19:28 +0000)]
Land failing expected results for editing tests that have been failing since they were
added in r73548.

Fixing the failures is being tracked by: https://bugs.webkit.org/show_bug.cgi?id=50731.

* platform/win/editing/selection/caret-ltr-right-expected.txt: Added.
* platform/win/editing/selection/caret-rtl-2-left-expected.txt: Added.
* platform/win/editing/selection/caret-rtl-right-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't leak the PDFDocument
andersca@apple.com [Thu, 9 Dec 2010 19:17:42 +0000 (19:17 +0000)]
Don't leak the PDFDocument
https://bugs.webkit.org/show_bug.cgi?id=50771

Reviewed by Sam Weinig.

* UIProcess/API/mac/PDFViewController.mm:
(WebKit::PDFViewController::setPDFDocumentData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a basic implementation of PDF support on Mac
andersca@apple.com [Thu, 9 Dec 2010 18:58:13 +0000 (18:58 +0000)]
Add a basic implementation of PDF support on Mac
https://bugs.webkit.org/show_bug.cgi?id=50768

Reviewed by Sam Weinig.

* UIProcess/API/mac/PDFViewController.h:
* UIProcess/API/mac/PDFViewController.mm: Added.
(-[WKPDFView initWithFrame:PDFViewController:WebKit::]):
Setup the view hierarchy.

(-[WKPDFView invalidate]):
Set the controller to null.

(-[WKPDFView pdfView]):
Return the PDF view.

(WebKit::PDFViewController::create):
(WebKit::PDFViewController::PDFViewController):
Create a WKPDFView and insert it as a subview of the WKView.

(WebKit::PDFViewController::~PDFViewController):
Remove the WKPDFView from the view hierarchy and invalidate it.

(WebKit::convertPostScriptDataSourceToPDF):
Convert the data in the data reference to PDF and return it as a CFDataRef.

(WebKit::PDFViewController::setPDFDocumentData):
Create a PDFDocument and set it on the PDF view.

(WebKit::PDFViewController::pdfDocumentClass):
(WebKit::PDFViewController::pdfPreviewViewClass):
(WebKit::PDFViewController::pdfKitBundle):
Add soft-linking helper functions.

* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
Call the WKView methods.

* UIProcess/API/mac/WKView.mm:
(-[WKView _setPageHasCustomRepresentation:]):
Create a PDF view controller if necessary.

(-[WKView _didFinishLoadingDataForCustomRepresentation:CoreIPC::]):
Pass the data along to the PDF view controller.

* WebKit2.xcodeproj/project.pbxproj:
Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Thu, 9 Dec 2010 18:54:30 +0000 (18:54 +0000)]
2010-12-09  Antonio Gomes  <agomes@rim.com>

        Rubber stamped by Gustavo Noronha.

        Buildfix for GTK+ with building with -no-video.

        paintStockIcon static function was implemented under the ENABLE(VIDEO) guard
        but used from outside the guard. See RenderThemeGtk::paintSearchFieldResultsDecoration()
        and RenderThemeGtk::paintSearchFieldCancelButton() methods.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::getMediaElementFromRenderObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Thu, 9 Dec 2010 18:54:14 +0000 (18:54 +0000)]
2010-12-09  Antonio Gomes  <agomes@rim.com>

        Reviewed by Martin Robinson.

        [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
        https://bugs.webkit.org/show_bug.cgi?id=48429

        WebKit/gtk:
        Moved also webkit_worker_thread_count() to DumpRenderTreeSupportGtk,
        since it was only used by DRT for now.

        Since this method was the only one in webkitworker.cpp, the file was
        also removed.

        * GNUmakefile.am:
        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::workerThreadCount):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
        * webkit/webkitprivate.h:
        * webkit/webkitworkers.cpp: Removed.

        WebKitTools/DumpRenderTree/gtk:
        Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::workerThreadCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-07 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Thu, 9 Dec 2010 18:53:47 +0000 (18:53 +0000)]
2010-12-07  Antonio Gomes  <agomes@rim.com>

        Reviewed by Daniel Bates.

        Spatial Navigation: code clean up
        https://bugs.webkit.org/show_bug.cgi?id=50666

        Patch unifies two FocusCandidate constructors, making caller sites
        simpler. Now the special handling HTMLAreaElement gets is done within
        the non default constructor (i.e. FocusCanditate(Node*, FocusDirection)).

        No new tests needed.

        * page/FocusController.cpp:
        (WebCore::FocusController::findFocusCandidateInContainer):
        * page/SpatialNavigation.cpp:
        (WebCore::FocusCandidate::FocusCandidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 9 Dec 2010 18:49:38 +0000 (18:49 +0000)]
2010-12-09  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        [GStreamer] disable fullscreen on MacOS Tiger and Leopard
        https://bugs.webkit.org/show_bug.cgi?id=50748

        Don't support fullscreen video on Tiger and Leopard, just like the
        QTKit player.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::supportsFullscreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for custom representation
andersca@apple.com [Thu, 9 Dec 2010 18:37:30 +0000 (18:37 +0000)]
Add support for custom representation
https://bugs.webkit.org/show_bug.cgi?id=50767

Reviewed by Sam Weinig.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
Add mimeTypesWithCustomRepresentation and encode and decode accordingly.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
Add empty stubs for now.

* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::didCommitLoadForMainFrame):
(QWKPagePrivate::didFinishLoadingDataForCustomRepresentation):
* UIProcess/API/qt/qwkpage_p.h:
Add empty stubs.

* UIProcess/PageClient.h:
Add new functions for custom representations.

* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::canShowMIMEType):
Check that the mime type is not null.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
This now takes an additional frameHasCustomRepresentation parameter.
Call the page client function.

(WebKit::WebPageProxy::didFinishLoadingDataForCustomRepresentation):
Call the page client function.

* UIProcess/WebPageProxy.messages.in:
Change DidCommitLoadForFrame message, add DidFinishLoadingDataForCustomRepresentation message.

* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
We want to use custom representations for PDF and PostScript MIME types.

* UIProcess/win/WebView.cpp:
(WebKit::WebView::didCommitLoadForMainFrame):
(WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
* UIProcess/win/WebView.h:
Add stubs.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::WebFrameLoaderClient):
Initialize m_frameHasCustomRepresentation.

(WebKit::WebFrameLoaderClient::hasHTMLView):
The frame has a HTML view unless it has a custom representation.

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
Pass along whether the frame has a custom representation.

(WebKit::WebFrameLoaderClient::committedLoad):
Don't send data back to WebCore if the frame has a custom representation.

(WebKit::WebFrameLoaderClient::finishedLoading):
Send all the data to the UI process.

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Update the m_frameHasCustomRepresentation state based on the MIME type.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
(WebKit::WebFrameLoaderClient::frameHasCustomRepresentation):
Add getter.

* WebProcess/WebPage/mac/ChunkedUpdateDrawingAreaMac.cpp:
(WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
Don't do any painting if the main frame has a custom representation.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Add all the MIME types with custom representations.

* WebProcess/WebProcess.h:
(WebKit::WebProcess::shouldUseCustomRepresentationForMIMEType):
Add getter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-06 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 9 Dec 2010 18:31:52 +0000 (18:31 +0000)]
2010-12-06  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Support the Mozilla-style Fullscreen Javascript API
        https://bugs.webkit.org/show_bug.cgi?id=50572

        * configure.ac: new configure flag to disable the new Javascript
        Fullscreen API build. It is enabled by default.

WebCore:

        Reviewed by Martin Robinson.

        [GTK] Support the Mozilla-style Fullscreen Javascript API
        https://bugs.webkit.org/show_bug.cgi?id=50572

        * GNUmakefile.am: enable the Javascript Fullscreen API feature if
        it's been requested at configure time.

WebKit/gtk:

        Reviewed by Martin Robinson.

        [GTK] Support the Mozilla-style Fullscreen Javascript API
        https://bugs.webkit.org/show_bug.cgi?id=50572

        Fullscreen API support. It is controlled at runtime using a new
        setting called enable-fullscreen, set to FALSE by default.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::supportsFullScreenForElement):
        (WebKit::ChromeClient::enterFullScreenForElement):
        (WebKit::ChromeClient::exitFullScreenForElement):
        * WebCoreSupport/ChromeClientGtk.h:
        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):

WebKitTools:

        Reviewed by Martin Robinson.

        [GTK] Support the Mozilla-style Fullscreen Javascript API
        https://bugs.webkit.org/show_bug.cgi?id=50572

        Enable the Javascript Fullscreen support in the GtkLauncher. Also
        make DRT update the Chrome when the WebView settings have been
        reset to consistent values.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):
        * GtkLauncher/main.c:
        (create_window):
        * Scripts/build-webkit:

LayoutTests:

        Reviewed by Martin Robinson.

        [GTK] Support the Mozilla-style Fullscreen Javascript API
        https://bugs.webkit.org/show_bug.cgi?id=50572

        * platform/gtk/Skipped: Unskip now passing fullscreen tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Thu, 9 Dec 2010 18:27:13 +0000 (18:27 +0000)]
2010-12-09  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Addressed the "FIXME" issues in array sort for toString() methods that
        mutate the array in either size or contents.  The change is to mark
        the temporary array contents so that they are not garbage collected
        and to make sure the array is large enough to hold the contents
        of the sorted temporary vector.
        https://bugs.webkit.org/show_bug.cgi?id=50718

        * runtime/Collector.cpp:
        (JSC::Heap::addTempSortVector):
        (JSC::Heap::removeTempSortVector):
        (JSC::Heap::markTempSortVectors):
        (JSC::Heap::markRoots):
        * runtime/Collector.h:
        * runtime/JSArray.cpp:
        (JSC::JSArray::sort):
        * runtime/JSValue.h:
2010-12-09  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        New test to verify that arrays sort per the standard even it
        there is an override for toString() that modifies the array.
        https://bugs.webkit.org/show_bug.cgi?id=50718

        * fast/js/array-sort-modifying-tostring-expected.txt: Added.
        * fast/js/array-sort-modifying-tostring.html: Added.
        * fast/js/script-tests/array-sort-modifying-tostring.js: Added.
        (do_gc):
        (Item):
        (toString_Mutate):
        (test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Yong Li <yoli@rim.com>
commit-queue@webkit.org [Thu, 9 Dec 2010 18:26:54 +0000 (18:26 +0000)]
2010-12-09  Yong Li  <yoli@rim.com>

        Reviewed by Darin Adler.

        Check the return value of ImageBuffer::create()
        to avoid crash when ImageBuffer::create() fails.
        https://bugs.webkit.org/show_bug.cgi?id=50631

        No new test because it relies on the platform implementation
        of ImageBuffer. It is hard to make ImageBuffer::create() fail
        in most ports.

        * platform/graphics/GeneratedImage.cpp:
        (WebCore::GeneratedImage::drawPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 9 Dec 2010 18:07:52 +0000 (18:07 +0000)]
2010-12-09  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Implement "Use Selection for Find" in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=50737
        <rdar://problem/8564881>

        Implement a TakeFindStringFromSelection editor command. This is
        used solely to implement the "Use Selection for Find" menu command
        on Mac, and is not made available to script. On WebKit2, it is
        very convenient to reuse the editing machinery since this command
        is very similar to Copy.

        * editing/Editor.h:
        * editing/EditorCommand.cpp:
        (WebCore::executeTakeFindStringFromSelection): Call to a mac-only Editor function.
        (WebCore::enabledTakeFindStringFromSelection): Check using Editor::canCopyExcludingStandaloneImage
        (WebCore::createCommandMap): Add "TakeFindStringFromSelection" command.
        * editing/mac/EditorMac.mm:
        (WebCore::Editor::canCopyExcludingStandaloneImages): Helper function; we can't use Editor::canCopy
        since it would make no sense to enable "Use Selection for Find" when viewing a standalone image
        document.
        (WebCore::Editor::takeFindStringFromSelection): Implement by copying the selected text
        to the special Find pasteboard.
2010-12-09  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Implement "Use Selection for Find" in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=50737
        <rdar://problem/8564881>

        * UIProcess/API/mac/WKView.mm: Add support for the takeFindStringFromSelection:
        selector as a command.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Thu, 9 Dec 2010 17:51:07 +0000 (17:51 +0000)]
2010-12-09  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        As part of r73559, I added the referenceNode check to validate whether the root
        node of the iterator matches the node which is getting moved to other document.
        referenceNode is initialized to root, however can get moved using previousNode
        and nextNode methods, so it is required to use root directly.
        https://bugs.webkit.org/show_bug.cgi?id=50764

        Test: fast/dom/node-iterator-reference-node-moved-crash.html

        * dom/Document.cpp:
        (WebCore::Document::moveNodeIteratorsToNewDocument): change referenceNode to root.
2010-12-09  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        Tests that we do not crash when we move the referenceNode using node iterator
        methods previousNode and nextNode.
        https://bugs.webkit.org/show_bug.cgi?id=50764

        * fast/dom/node-iterator-reference-node-moved-crash-expected.txt: Added.
        * fast/dom/node-iterator-reference-node-moved-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 9 Dec 2010 17:23:00 +0000 (17:23 +0000)]
2010-12-08  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Provide a generic way to store shadowParent on a Node.
        https://bugs.webkit.org/show_bug.cgi?id=50184

        This patch makes TreeShared::m_parent act as either parentNode() or
        shadowHost() for Node. The distinction is controlled by IsShadowRootFlag.

        Refactoring, so no new tests. See performance result testing in bug.

        * dom/Element.cpp:
        (WebCore::Element::recalcStyle): Changed to use parentOrHostNode().
        * dom/Node.cpp:
        (WebCore::Node::shadowHost): Added.
        (WebCore::Node::setShadowHost): Added.
        (WebCore::Node::isContentEditable): Changed to use parentOrHostNode().
        (WebCore::Node::isContentRichlyEditable): Ditto.
        (WebCore::Node::nextRenderer): Ditto.
        (WebCore::Node::virtualComputedStyle): Ditto.
        (WebCore::Node::canStartSelection): Ditto.
        (WebCore::Node::shadowTreeRootNode): Changed to use parentNodeGuaranteedHostFree().
        (WebCore::Node::getEventAncestors): Ditto.
        (WebCore::Node::defaultEventHandler): Changed to use parentOrHostNode().
        * dom/Node.h: Added an extra flag and adjusted bit counts.
        (WebCore::Node::isShadowNode): Made non-virtual, switched to use flag.
        (WebCore::Node::parentNode): Made to recognize flag.
        (WebCore::Node::parentOrHostNode): Changed to use straight parent() and made const.
        (WebCore::Node::parentNodeGuaranteedHostFree): Added.
        (WebCore::Node::shadowParentNode): Made non-virtual and const.
        * editing/TextIterator.cpp:
        (WebCore::depthCrossingShadowBoundaries): Changed to use parentOrHostNode();
        (WebCore::nextInPreOrderCrossingShadowBoundaries): Ditto.
        (WebCore::previousInPostOrderCrossingShadowBoundaries):  Ditto.
        (WebCore::setUpFullyClippedStack): Ditto.
        (WebCore::TextIterator::advance): Ditto.
        (WebCore::SimplifiedBackwardsTextIterator::advance): Ditto.
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::anchorNode): Changed to use parentNodeGuaranteedHostFree().
        (WebCore::DOMSelection::focusNode): Ditto.
        (WebCore::DOMSelection::baseNode): Ditto.
        (WebCore::DOMSelection::extentNode): Ditto.
        (WebCore::DOMSelection::getRangeAt): Ditto.
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
            Changed to setShadowHost().
        (WebCore::MediaControlShadowRootElement::updateStyle): Changed to use shadowHost().
        (WebCore::MediaControlShadowRootElement::detach): Added an override to
            explicitly set shadowHost to 0. Otherwise, the element will leak.
        * rendering/MediaControlElements.h: Added detach def, removed members that are
            no longer needed.
        * rendering/RenderSVGShadowTreeRootContainer.cpp:
        (WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer):
            Added explicit clearing of shadowHost to avoid leaking and crashes,
            because SVG shadow DOM can be dynamically attached/detached, producing
            stale nodes in over/out event handling.
        * rendering/RenderSlider.cpp:
        (WebCore::SliderThumbElement::defaultEventHandler): Changed to use shadowHost().
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
            Added explicit clearing of shadowHost and explicit destruction to
            avoid out-of-order removal of children.
        * rendering/RenderTreeAsText.cpp:
        (WebCore::nodePosition): Simplified code.
        * rendering/SVGShadowTreeElements.cpp:
        (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): Added
            setting of shadowHost.
        (WebCore::SVGShadowTreeRootElement::attachElement): Changed to use shadowHost().
        (WebCore::SVGShadowTreeRootElement::clearShadowHost): Added.
        * rendering/SVGShadowTreeElements.h: Added def, removed members that are
             no longer needed.
        * rendering/ShadowElement.cpp:
        (WebCore::ShadowBlockElement::initAsPart): Changed to use shadowHost().
        * rendering/ShadowElement.h: Removed members that are no longer needed.
        (WebCore::ShadowElement::ShadowElement): Added setting of shadowHost.
        (WebCore::ShadowElement::detach): Added.
        * rendering/TextControlInnerElements.cpp:
        (WebCore::TextControlInnerElement::TextControlInnerElement): Added setting
            of shadowHost.
        (WebCore::TextControlInnerElement::attachInnerElement): Changed to use
            isShadowNode().
        (WebCore::TextControlInnerElement::detach): Added.
        * rendering/TextControlInnerElements.h: Removed members that are no
            longer needed.
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::ownerSVGElement): Simplified code.
        (WebCore::SVGElement::viewportElement): Ditto.
        * svg/SVGLocatable.cpp:
        (WebCore::SVGLocatable::computeCTM): Ditto.
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::title): Ditto.
        * svg/SVGUseElement.cpp:
        (WebCore::ShadowTreeUpdateBlocker::while): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Thu, 9 Dec 2010 17:18:29 +0000 (17:18 +0000)]
2010-12-09  Michael Saboff  <msaboff@apple.com>

        Reviewed by Darin Adler.

        Changed setting of backtrack labels to not overwrite a prior
        label.  Where losing prior labe which then reverted back to
        next character label.
        https://bugs.webkit.org/show_bug.cgi?id=50579

        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::BacktrackDestination::setBacktrackToLabel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Thu, 9 Dec 2010 17:18:13 +0000 (17:18 +0000)]
2010-12-09  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Numeric keys are floats.
        https://bugs.webkit.org/show_bug.cgi?id=50674

        Update layout tests to use floating-point values for keys.

        * storage/indexeddb/keyrange-expected.txt:
        * storage/indexeddb/keyrange.html:
        Make sure creating the keys works.
        * storage/indexeddb/objectstore-cursor-expected.txt:
        * storage/indexeddb/objectstore-cursor.html:
        Make sure retrieving the keys from the DB objectstore works.
2010-12-09  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Numeric keys are floats.
        https://bugs.webkit.org/show_bug.cgi?id=50674

        Use floating point to represent numeric keys,
        add version meta data to the SQLite db,
        and migrate object stores that use integers.

        * bindings/v8/IDBBindingUtilities.cpp:
        (WebCore::createIDBKeyFromValue):
        * bindings/v8/custom/V8IDBKeyCustom.cpp:
        (WebCore::toV8):
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::createTables):
        (WebCore::migrateDatabase):
        (WebCore::IDBFactoryBackendImpl::open):
        * storage/IDBKey.cpp:
        (WebCore::IDBKey::IDBKey):
        (WebCore::IDBKey::fromQuery):
        (WebCore::IDBKey::bind):
        (WebCore::IDBKey::bindWithNulls):
        * storage/IDBKey.h:
        (WebCore::IDBKey::create):
        (WebCore::IDBKey::number):
2010-12-09  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Numeric keys are floats.
        https://bugs.webkit.org/show_bug.cgi?id=50674

        Represent numeric keys as floating point values.

        * public/WebIDBKey.h:
        (WebKit::WebIDBKey::WebIDBKey):
        * src/WebIDBKey.cpp:
        (WebKit::WebIDBKey::assign):
        (WebKit::WebIDBKey::number):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-28 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Thu, 9 Dec 2010 17:14:47 +0000 (17:14 +0000)]
2010-06-28  Michael Saboff  <msaboff@apple.com>

        Reviewed by Darin Adler.

        Bug 41238 - RegExp performance slow on Dromaeo benchmark

        Other javascript engines appear to cache prior results of regular
        expression operations.

        Suggest adding some sort of caching mechanism to regular expression
        processing.

        Added a single entry cache of match() results to RegExp class.

        Also added performance improvements to UString == operator.
        First check the impls for equality.  Then get the length of
        each of the non-null impls.  Next check the sizes for equality.
        Then check the data for the case of different impls that point
        to the same data (most likely due to substrings from the beginning of
        another string).  Lastly we check the underlying data for equality.

        Refactored Vector<>::operator=() method into a separate copy() method
        that it calls.  The copy() method is explicitly used for deep copying.

        * runtime/RegExp.cpp:
        (JSC::RegExp::RegExp):
        (JSC::RegExp::match):
        * runtime/RegExp.h:
        * runtime/UString.h:
        (JSC::operator==):
        * wtf/Vector.h:
        (WTF::::operator):
        (WTF::::copy):

2010-12-09  Michael Saboff  <msaboff@apple.com>

        Reviewed by Darin Adler.

        Added test to verify proper operation of backtrack labels.
        https://bugs.webkit.org/show_bug.cgi?id=50579

        * fast/regex/parentheses-expected.txt:
        * fast/regex/script-tests/parentheses.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
beidson@apple.com [Thu, 9 Dec 2010 16:55:19 +0000 (16:55 +0000)]
<rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
WebKit2 Authentication Support

Reviewed by Maciej Stachowiak.

WebCore:

* WebCore.exp.in:

WebKit2:

Implement authentication-related coders:
* Shared/WebCoreArgumentCoders.h:

Allow the ResourceResponse coders to handle null responses:
* Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::encodeResourceResponse):
(CoreIPC::decodeResourceResponse):

Add new API and Impl casts for ProtectionSpace and Credential enums:
* UIProcess/API/C/WKAPICast.h:
(WebKit::toAPI):
(WebKit::toCredentialPersistence):

Move the DecisionListener to be accessed off the challenge itself, and fill in other
necessary API:
* UIProcess/API/C/WKAuthenticationChallenge.cpp:
(WKAuthenticationChallengeGetDecisionListener):
(WKAuthenticationChallengeGetProtectionSpace):
(WKAuthenticationChallengeGetProposedCredential):
(WKAuthenticationChallengeGetPreviousFailureCount):
* UIProcess/API/C/WKAuthenticationChallenge.h:
* UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::~AuthenticationChallengeProxy):
(WebKit::AuthenticationChallengeProxy::proposedCredential):
(WebKit::AuthenticationChallengeProxy::protectionSpace):
* UIProcess/Authentication/AuthenticationChallengeProxy.h:
(WebKit::AuthenticationChallengeProxy::previousFailureCount):

Fill in some credential API:
* UIProcess/API/C/WKCredential.cpp:
(WKCredentialCreate):
(WKCredentialCopyUser):
* UIProcess/API/C/WKCredential.h:
* UIProcess/API/C/WKCredentialTypes.h: Added.
* UIProcess/Authentication/WebCredential.cpp:
(WebKit::WebCredential::WebCredential):
(WebKit::WebCredential::user):
* UIProcess/Authentication/WebCredential.h:
(WebKit::WebCredential::create):

Fill in some protection space API:
* UIProcess/API/C/WKProtectionSpace.cpp:
(WKProtectionSpaceCopyHost):
(WKProtectionSpaceGetPort):
(WKProtectionSpaceCopyRealm):
(WKProtectionSpaceGetIsProxy):
(WKProtectionSpaceGetServerType):
(WKProtectionSpaceGetReceivesCredentialSecurely):
(WKProtectionSpaceGetAuthenticationScheme):
* UIProcess/API/C/WKProtectionSpace.h:
* UIProcess/API/C/WKProtectionSpaceTypes.h: Added.
* UIProcess/Authentication/WebProtectionSpace.cpp:
(WebKit::WebProtectionSpace::WebProtectionSpace):
(WebKit::WebProtectionSpace::host):
(WebKit::WebProtectionSpace::port):
(WebKit::WebProtectionSpace::realm):
(WebKit::WebProtectionSpace::isProxy):
(WebKit::WebProtectionSpace::serverType):
(WebKit::WebProtectionSpace::receivesCredentialSecurely):
(WebKit::WebProtectionSpace::authenticationScheme):
* UIProcess/Authentication/WebProtectionSpace.h:

Change the authentication challenge callback to reflect the new ownership of
the DecisionListener:
* UIProcess/API/C/WKPage.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didReceiveAuthenticationChallengeInFrame):
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveAuthenticationChallenge):

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Peter Beverloo <peter@lvp-media.com>
commit-queue@webkit.org [Thu, 9 Dec 2010 16:40:53 +0000 (16:40 +0000)]
2010-12-09  Peter Beverloo  <peter@lvp-media.com>

        Reviewed by Maciej Stachowiak.

        Default CSS definitions for the figure and figcaption elements.

        * fast/html/figcaption-element-expected.txt: Added.
        * fast/html/figcaption-element.html: Added.
        * fast/html/figure-element-expected.txt: Added.
        * fast/html/figure-element.html: Added.
        * fast/html/script-tests/figcaption-element.js: Added.
        * fast/html/script-tests/figure-element.js: Added.
2010-12-09  Peter Beverloo  <peter@lvp-media.com>

        Reviewed by Maciej Stachowiak.

        Default CSS definitions for the figure and figcaption elements.

        Tests: fast/html/figcaption-element.html
               fast/html/figure-element.html

        * css/html.css:
        (figure): The default figure-style equals a blockquote
        (figcaption): A non-sectioning block-level element

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Thu, 9 Dec 2010 16:22:26 +0000 (16:22 +0000)]
2010-12-09  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: more tests.
        https://bugs.webkit.org/show_bug.cgi?id=50728

        * fast/spatial-navigation/snav-hidden-focusable-element-expected.txt: Added.
        * fast/spatial-navigation/snav-hidden-focusable-element.html: Added.
        * fast/spatial-navigation/snav-hidden-iframe-expected.txt: Added.
        * fast/spatial-navigation/snav-hidden-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Koan-Sin Tan <koansin.tan@gmail.com>
andreas.kling@nokia.com [Thu, 9 Dec 2010 16:06:27 +0000 (16:06 +0000)]
2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>

        Reviewed by Tor Arne Vestbø

        [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
        https://bugs.webkit.org/show_bug.cgi?id=50742

        check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Alex Bredariol Grilo <abgrilo@profusion.mobi>
commit-queue@webkit.org [Thu, 9 Dec 2010 16:06:23 +0000 (16:06 +0000)]
2010-12-09  Alex Bredariol Grilo  <abgrilo@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Fix scroll operation in WebKit-EFL
        https://bugs.webkit.org/show_bug.cgi?id=50752

        Add the _ewk_view_scroll_add call in WebKit-EFL scroll function. This
        call was wrongly removed in previous commit and performs the scroll
        operation on the page.

        * ewk/ewk_view.cpp:
        (ewk_view_scroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Thu, 9 Dec 2010 16:00:17 +0000 (16:00 +0000)]
Unreviewed.

Add Qt specific expected results for tests introduced in r73548.
Compared to Mac png files and Mac expected files.

* platform/qt/editing/selection/caret-ltr-2-expected.checksum: Added.
* platform/qt/editing/selection/caret-ltr-2-expected.png: Added.
* platform/qt/editing/selection/caret-ltr-2-expected.txt: Added.
* platform/qt/editing/selection/caret-ltr-2-left-expected.checksum: Added.
* platform/qt/editing/selection/caret-ltr-2-left-expected.png: Added.
* platform/qt/editing/selection/caret-ltr-2-left-expected.txt: Added.
* platform/qt/editing/selection/caret-ltr-expected.checksum: Added.
* platform/qt/editing/selection/caret-ltr-expected.png: Added.
* platform/qt/editing/selection/caret-ltr-expected.txt: Added.
* platform/qt/editing/selection/caret-ltr-right-expected.checksum: Added.
* platform/qt/editing/selection/caret-ltr-right-expected.png: Added.
* platform/qt/editing/selection/caret-ltr-right-expected.txt: Added.
* platform/qt/editing/selection/caret-rtl-2-left-expected.checksum: Added.
* platform/qt/editing/selection/caret-rtl-2-left-expected.png: Added.
* platform/qt/editing/selection/caret-rtl-2-left-expected.txt: Added.
* platform/qt/editing/selection/caret-rtl-right-expected.checksum: Added.
* platform/qt/editing/selection/caret-rtl-right-expected.png: Added.
* platform/qt/editing/selection/caret-rtl-right-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Joone Hur <joone@kldp.org>
commit-queue@webkit.org [Thu, 9 Dec 2010 14:56:33 +0000 (14:56 +0000)]
2010-12-09  Joone Hur  <joone@kldp.org>

        Reviewed by Martin Robinson.

        [GTK] Support for viewport meta tag
        https://bugs.webkit.org/show_bug.cgi?id=45443

        Included viewport test cases for WebKitGtk

        * platform/gtk/Skipped: Unskip fast/viewport except viewport-45.html.
2010-12-09  Joone Hur  <joone@kldp.org>

        Reviewed by Martin Robinson.

        [GTK] Support for viewport meta tag
        https://bugs.webkit.org/show_bug.cgi?id=45443

        This patch adds a new gobject to offer the viewport properties to user agents.
        It is WebKitViewportAttributes that contains the viewport size, initial scale with limits,
        and information about whether a user is able to scale the contents in the viewport.

        This feature was introduced by Safari on the iPhone. For more information on
        the viewport properties, refer to the Safari reference library at
        http://developer.apple.com/safari/library/documentation/appleapplications/reference/safarihtmlref/articles/metatags.html

        * GNUmakefile.am: Added webkitviewportattributes.h webkitviewportattributes.cpp.
        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::dispatchViewportDataDidChange): Added this callback to know whether the viewport arguments is available.
        * WebCoreSupport/ChromeClientGtk.h:
        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): Added this function to compute the viewport attributes with the given availableWidth and availableHeight.
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::postCommitFrameViewSetup): Invalidate the viewport attributes.
        * webkit/webkit.h:
        * webkit/webkitdefines.h:
        * webkit/webkitprivate.h: Added webkitViewportAttributesRecompute as a private function.
        * webkit/webkitviewportattributes.cpp: Added.
        (webkit_viewport_attributes_class_init):
        (webkit_viewport_attributes_init):
        (webkit_viewport_attributes_get_property):
        (webkit_viewport_attributes_set_property):
        (webkitViewportAttributesRecompute): Recompute the optimal viewport attributes and emit the viewport-attributes-changed signal.
        (webkit_viewport_attributes_recompute): a public API for calling webkitViewportAttributesRecompute.
        * webkit/webkitviewportattributes.h: Added.
        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_property): Added PROP_VIEWPORT_ATTRIBUTES.
        (webkit_web_view_dispose): Deallocate the WebKitViewportAttributes instance.
        (webkit_web_view_class_init): Added the viewport-attributes-recompute-requested and viewport-attributes-changed signals.
        (webkit_web_view_init): Set the WebKitViewportAttributes instance.
        (webkit_web_view_get_viewport_attributes): Added a getter to obtain the WebKitViewportAttributes instance held by the given WebKitWebView.
        * webkit/webkitwebview.h:
        * webkit/webkitwebviewprivate.h: Added WebKitViewportAttributes as a private variable.
2010-12-09  Joone Hur  <joone@kldp.org>

         Reviewed by Martin Robinson.

         [GTK] Support for viewport meta tag
         https://bugs.webkit.org/show_bug.cgi?id=45443

         Add support for testing the viewport properties for WebKitGtk.

         * DumpRenderTree/LayoutTestController.cpp:
         (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
         (LayoutTestController::staticFunctions):
         * DumpRenderTree/LayoutTestController.h:
         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
         (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
         (LayoutTestController::dumpConfigurationForViewport): Ditto.
         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
         (LayoutTestController::dumpConfigurationForViewport): Ditto.
         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
         (LayoutTestController::dumpConfigurationForViewport): Ditto.
         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
         (LayoutTestController::dumpConfigurationForViewport): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 9 Dec 2010 13:34:22 +0000 (13:34 +0000)]
2010-12-09  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Console records for failed XHRs should contain call stack and request method
        https://bugs.webkit.org/show_bug.cgi?id=50390

        The expectations needed update ue to log format changes.

        * http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
        * http/tests/inspector/console-resource-errors-expected.txt:
        * http/tests/inspector/console-xhr-logging-expected.txt:
        * platform/chromium/http/tests/inspector/console-resource-errors-expected.txt: Added.
        * platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Copied from LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt.
2010-12-09  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Console records for failed XHRs should contain call stack and request method
        https://bugs.webkit.org/show_bug.cgi?id=50390

        When inspector front-end is open we capture call stack at the place where request is sent and
        pass the stack along with other request data. There is a new type of console messages which
        is NetworkErrorMessageType, all messages of that type will have requestId field initialized
        with the corresponding network request identifier so that later on when we need to display
        that message in the front-end we could pull request data from the Network panel using
        this identifier. If there are no data for given requestId message formatting falls back to
        the old implementation which lacks such things as call stack, request method and exact
        source location.

        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::ConsoleMessage):
        (WebCore::ConsoleMessage::addToFrontend):
        (WebCore::ConsoleMessage::isEqual):
        * inspector/ConsoleMessage.h:
        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didFailLoading):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::identifierForInitialRequest):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.updateMessageRepeatCount):
        (WebInspector.ConsoleMessage):
        (WebInspector.ConsoleMessage.prototype._formatMessage):
        (WebInspector.ConsoleMessage.prototype.toMessageElement):
        (WebInspector.ConsoleMessage.prototype.toString):
        (WebInspector.ConsoleMessage.prototype.isEqual):
        * inspector/front-end/ResourceManager.js:
        (WebInspector.ResourceManager.prototype.identifierForInitialRequest):
        * inspector/front-end/inspector.js:
        (WebInspector.addConsoleMessage):
        * page/Console.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Dai Mikurube <dmikurube@google.com>
commit-queue@webkit.org [Thu, 9 Dec 2010 13:07:15 +0000 (13:07 +0000)]
2010-12-09  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        Implement "required" attribute for select tags
        https://bugs.webkit.org/show_bug.cgi?id=50380

        Added tests for require attributes, valueMissing and vadility check for select elements.

        * fast/forms/ValidityState-valueMissing-001-expected.txt:
        * fast/forms/ValidityState-valueMissing-001.html:
        * fast/forms/ValidityState-valueMissing-002-expected.txt:
        * fast/forms/ValidityState-valueMissing-002.html:
        * fast/forms/ValidityState-valueMissing-003-expected.txt:
        * fast/forms/ValidityState-valueMissing-003.html:
        * fast/forms/checkValidity-002-expected.txt:
        * fast/forms/checkValidity-002.html:
        * fast/forms/required-attribute-001-expected.txt:
        * fast/forms/required-attribute-001.html:
        * fast/forms/required-attribute-002-expected.txt:
        * fast/forms/required-attribute-002.html:
        * fast/forms/resources/select-live-pseudo-selectors.js: Added.
        (makeInvalid):
        (appendOption):
        (backgroundOf):
        * fast/forms/script-tests/validationMessage.js:
        * fast/forms/select-live-pseudo-selectors-expected.txt: Added.
        * fast/forms/select-live-pseudo-selectors.html: Added.
        * fast/forms/validationMessage-expected.txt:
        * platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html: Added.
        * platform/mac/fast/objc/dom-html-select-live-pseudo-selectors-expected.txt: Added.
2010-12-09  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        Implement "required" attribute for select tags
        https://bugs.webkit.org/show_bug.cgi?id=50380

        Test: fast/forms/select-live-pseudo-selectors.html
              platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::updateValidity): Added. It's a pure virtual function which is prepared so that HTMLSelectElement::updateValidity() calls HTMLSelectElement::setNeedsValidityCheck().
        (WebCore::SelectElement::parseMultipleAttribute): Added calling updateValidity().
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::deselectItems): Added calling setNeedsValidityCheck() to enable validity check after changing. No tests for this change since this function is not exposed to JavaScript or any web interface.
        (WebCore::HTMLSelectElement::setSelectedIndex): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::setSelectedIndexByUser): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::valueMissing): Added valueMissing() to check if selecting an invalid or placeholder label option when a valid required attribute is specified.
        (WebCore::HTMLSelectElement::listBoxSelectItem): Added calling setNeedsValidityCheck(). No tests for this change since it is not called yet. Look at the bug 36177 and the changeset 56180.
        (WebCore::HTMLSelectElement::add): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::remove): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::restoreFormControlState): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::parseMappedAttribute): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::selectAll): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::reset): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::updateListBoxSelection): Added calling setNeedsValidityCheck(). Skipped adding tests for this change as too complicated..
        (WebCore::HTMLSelectElement::setLength): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::isRequiredFormControl): Check if required or not.
        (WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Added.
        (WebCore::HTMLSelectElement::updateValidity): Added. It calls setNeedsValidityCheck().
        * html/HTMLSelectElement.h:
        (WebCore::HTMLSelectElement::isOptionalFormControl): Check if not required.
        * html/HTMLSelectElement.idl: Added a required attribute to select elements..
        * html/ValidityState.cpp:
        (WebCore::ValidityState::valueMissing): Added valueMissing check for select elements into the global checker, ValidityState::valueMissing().
        * wml/WMLSelectElement.h:
        (WebCore::WMLSelectElement::updateValidity): Added. It does nothing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-07 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 9 Dec 2010 12:29:55 +0000 (12:29 +0000)]
2010-12-07  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        IndexedDB returns the wrong exceptions
        https://bugs.webkit.org/show_bug.cgi?id=50632

        * storage/indexeddb/constants-expected.txt:
        * storage/indexeddb/constants.html:
        * storage/indexeddb/objectstore-removeobjectstore-expected.txt:
        * storage/indexeddb/objectstore-removeobjectstore.html:
2010-12-07  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        IndexedDB returns the wrong exceptions
        https://bugs.webkit.org/show_bug.cgi?id=50632

        IndexedDB exceptions need to have an offset so they can
        be distinguished from DOM exceptions.  We also need to
        add strings for the various exceptions.  Lastly, make
        IDBDatabaseException use the common exception base class.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::setDOMException):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::setDOMException):
        * dom/ExceptionCode.cpp:
        (WebCore::getExceptionCodeDescription):
        * dom/ExceptionCode.h:
        * storage/IDBDatabaseError.h:
        (WebCore::IDBDatabaseError::code):
        * storage/IDBDatabaseException.h:
        (WebCore::IDBDatabaseException::create):
        (WebCore::IDBDatabaseException::ErrorCodeToExceptionCode):
        (WebCore::IDBDatabaseException::IDBDatabaseException):
        * storage/IDBDatabaseException.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 9 Dec 2010 12:09:59 +0000 (12:09 +0000)]
2010-12-09  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Fix 'make install' woes with some versions of automake.

        * GNUmakefile.am: use $(top_builddir) instead of $(builddir),
        since we actually want a valid path for the file regardless of the
        place from where the script is called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 9 Dec 2010 11:18:48 +0000 (11:18 +0000)]
2010-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Build fix for GTK+3. Use functions added for GTK+ 2.24 to get the
        GDK window size.

        * plugins/gtk/gtk2xtbin.c:
        (gtk_xtbin_realize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Siddharth Mathur <siddharth.mathur@nokia.com>
commit-queue@webkit.org [Thu, 9 Dec 2010 11:12:48 +0000 (11:12 +0000)]
2010-12-09  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        Use BUILDING_WEBKIT like other ports
        https://bugs.webkit.org/show_bug.cgi?id=50713

        * WebCore.pro: Change BUILD_WEBKIT to BUILDING_WEBKIT
2010-12-09  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        Use BUILDING_WEBKIT like other ports
        https://bugs.webkit.org/show_bug.cgi?id=50713

        * Api/qwebkitglobal.h: change BUILD_WEBKIT to BUILDING_WEBKIT

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 9 Dec 2010 11:12:33 +0000 (11:12 +0000)]
2010-12-09  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Rebaselined Chromium expectations.
        Reverts r73518 and r73522.

        * platform/chromium-linux/fast/forms/placeholder-position-expected.checksum: Added.
        * platform/chromium-linux/fast/forms/placeholder-position-expected.png: Added.
        * platform/chromium-mac/fast/forms/placeholder-position-expected.checksum: Added.
        * platform/chromium-mac/fast/forms/placeholder-position-expected.png: Added.
        * platform/chromium-win/fast/forms/placeholder-position-expected.checksum: Added.
        * platform/chromium-win/fast/forms/placeholder-position-expected.png: Added.
        * platform/chromium-win/fast/forms/placeholder-position-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 9 Dec 2010 11:07:56 +0000 (11:07 +0000)]
2010-12-09  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] configure: error out if video is enabled and gstreamer pkg-config check fails
        https://bugs.webkit.org/show_bug.cgi?id=50741

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Add Qt specific expected results for tests introduced in r73529.
ossy@webkit.org [Thu, 9 Dec 2010 10:41:42 +0000 (10:41 +0000)]
Unreviewed. Add Qt specific expected results for tests introduced in r73529.

* platform/qt/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
* platform/qt/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 9 Dec 2010 10:03:08 +0000 (10:03 +0000)]
2010-12-09  Martin Robinson  <mrobinson@igalia.com>

        Update GTK+ baselines after r73561.

        * platform/gtk/fast/css/input-search-padding-expected.txt:
        * platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
        * platform/gtk/fast/forms/box-shadow-override-expected.txt:
        * platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
        * platform/gtk/fast/forms/input-appearance-height-expected.txt:
        * platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
        * platform/gtk/fast/forms/placeholder-set-value-expected.txt:
        * platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
        * platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
        * platform/gtk/fast/forms/search-rtl-expected.txt:
        * platform/gtk/fast/forms/search-styled-expected.txt:
        * platform/gtk/fast/forms/search-transformed-expected.txt:
        * platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
        * platform/gtk/fast/forms/search-zoomed-expected.txt:
        * platform/gtk/fast/forms/searchfield-heights-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 9 Dec 2010 09:37:14 +0000 (09:37 +0000)]
2010-12-09  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, update test baselines as asked by MORITA Hajime.

        [GTK] r73488 broke fast/dom/HTMLProgressElement/progress-element.html
        https://bugs.webkit.org/show_bug.cgi?id=50687

        * platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:
        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Thu, 9 Dec 2010 08:09:45 +0000 (08:09 +0000)]
2010-12-09  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed.

        Chromium rebaselines for r73488.

        * platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.txt:
        * platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
        * platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
        * platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
        * platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
        * platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
        * platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
        * platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 9 Dec 2010 06:43:36 +0000 (06:43 +0000)]
2010-12-08  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Updated Chromium expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPermit Character Class Escape in CharacterRange in Character Class.
barraclough@apple.com [Thu, 9 Dec 2010 05:40:29 +0000 (05:40 +0000)]
Permit Character Class Escape in CharacterRange in Character Class.
https://bugs.webkit.org/show_bug.cgi?id=50483
https://bugs.webkit.org/show_bug.cgi?id=50538
https://bugs.webkit.org/show_bug.cgi?id=50654
https://bugs.webkit.org/show_bug.cgi?id=50646

Reviewed by Sam Weinig.

We recently tightened up our spec conformance in generating syntax
error in these cases, however testing in the wild has shown this
to be problematic. This reverts the previous change in allowing
class escapes (e.g. \d) in ranges in character classes ([]), but
does retain some closer conformance to the spec in only allowing
ranges that would be permitted per the grammar rules in the spec
(e.g. in /[\d-a-z]/ "a-z" cannot be considered as a range).

JavaScriptCore:

* yarr/RegexParser.h:
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomPatternCharacter):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBuiltInCharacterClass):
(JSC::Yarr::Parser::parse):

LayoutTests:

* fast/js/regexp-ranges-and-escaped-hyphens-expected.txt:
* fast/js/script-tests/regexp-ranges-and-escaped-hyphens.js:
* fast/regex/invalid-range-in-class-expected.txt:
* fast/regex/pcre-test-1-expected.txt:
* fast/regex/script-tests/invalid-range-in-class.js:
* fast/regex/script-tests/pcre-test-1.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Thu, 9 Dec 2010 05:03:01 +0000 (05:03 +0000)]
2010-12-08  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed.

        Update Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix crash-on-launch seen on Windows builder.
ggaren@apple.com [Thu, 9 Dec 2010 04:32:59 +0000 (04:32 +0000)]
Try to fix crash-on-launch seen on Windows builder.

Reviewed by Sam Weinig.

* wtf/OSAllocatorWin.cpp:
(WTF::OSAllocator::release): Disabled an ASSERT, because it checks for
a bug that hasn't been fixed yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix typo: Diplaying -> Displaying
weinig@apple.com [Thu, 9 Dec 2010 04:30:29 +0000 (04:30 +0000)]
Fix typo: Diplaying -> Displaying

Reviewed by Geoffrey "Error" Garen.

* UIProcess/API/C/WKFrame.cpp:
(WKFrameIsDisplayingStandaloneImageDocument):
(WKFrameIsDisplayingMarkupDocument):
* UIProcess/API/C/WKFrame.h:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::canProvideSource):
(WebKit::WebFrameProxy::isDisplayingStandaloneImageDocument):
(WebKit::WebFrameProxy::isDisplayingMarkupDocument):
* UIProcess/WebFrameProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 William Siegrist <wsiegrist@apple.com>
wsiegrist@apple.com [Thu, 9 Dec 2010 04:22:21 +0000 (04:22 +0000)]
2010-12-08  William Siegrist <wsiegrist@apple.com>

        Reviewed by Eric Seidel.

        Migrate buildbot.py from xmlrpc to json.
        https://bugs.webkit.org/show_bug.cgi?id=50647

        * Scripts/webkitpy/common/net/buildbot.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Erik Arvidsson <arv@chromium.org>
arv@chromium.org [Thu, 9 Dec 2010 03:55:39 +0000 (03:55 +0000)]
2010-12-08  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Darin Adler.

        Replace getAttribute().isNull() with fastHasAttribute()
        https://bugs.webkit.org/show_bug.cgi?id=50719

        Covered by existing tests.

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::reset):
        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::rendererIsNeeded):
        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::itemAfter):
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::formNoValidate):
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::noValidate):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::defaultChecked):
        (WebCore::HTMLInputElement::multiple):
        (WebCore::HTMLInputElement::webkitdirectory):
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::defaultSelected):
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::asyncAttributeValue):
        (WebCore::HTMLScriptElement::deferAttributeValue):
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::allowsMultipleFiles):
        (WebCore::RenderFileUploadControl::allowsDirectoryUpload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 9 Dec 2010 03:37:39 +0000 (03:37 +0000)]
2010-12-08  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; Yet another Chromium rebaselines for r73548.

        * platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.checksum: Removed.
        * platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.png: Removed.
        * platform/chromium-mac/fast/text/international/khmer-selection-expected.checksum: Added.
        * platform/chromium-mac/fast/text/international/khmer-selection-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
commit-queue@webkit.org [Thu, 9 Dec 2010 03:33:39 +0000 (03:33 +0000)]
2010-12-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>

        Reviewed by Martin Robinson.

        Full page size flash plugins do not show in all situations
        https://bugs.webkit.org/show_bug.cgi?id=47742

        This patch moves the plugin widget size allocation after the
        NPP_SetWindow is called with the effect that the resize of Flash
        content no longer result in grey flash. This seems logical since the
        widget tree cannot be fully constructed before the plugin receives
        the new container window.

        Test: manual-tests/plugins/gtk-windowed-grey-glitch.html

        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::setNPWindowIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix regression from xji's wheel scroll patch. The vertical case is looking at the...
hyatt@apple.com [Thu, 9 Dec 2010 03:29:45 +0000 (03:29 +0000)]
Fix regression from xji's wheel scroll patch.  The vertical case is looking at the horizontal
maximum position and not the vertical position.

Reviewed by Simon Fraser.

* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Andy Estes <aestes@apple.com>
aestes@apple.com [Thu, 9 Dec 2010 03:13:08 +0000 (03:13 +0000)]
2010-12-08  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        Enable pre-HTML5 parser quirks for Apple Mail.app
        https://bugs.webkit.org/show_bug.cgi?id=50727

        * WebView/WebView.mm:
        (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding
        application is Mail.app.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Qi Zhang <qi.2.zhang@nokia.com>
commit-queue@webkit.org [Thu, 9 Dec 2010 03:10:51 +0000 (03:10 +0000)]
2010-12-08  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Support OrientationChange event
        https://bugs.webkit.org/show_bug.cgi?id=50685

        Get OrientationChange event from qtmobility then send to webkit.

        * Api/qwebframe.cpp:
        (QWebFrame::orientationChanged):
        (QWebFrame::QWebFrame):
        * Api/qwebframe.h:
        * Api/qwebframe_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed a way to get a WKBundleFrameRef from JS HTMLIFrameElement
weinig@apple.com [Thu, 9 Dec 2010 02:25:19 +0000 (02:25 +0000)]
Need a way to get a WKBundleFrameRef from JS HTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=50726

Reviewed by Darin Adler.

* WebCore.xcodeproj/project.pbxproj: Expose HTMLIFrameElement.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd WebKit2 Preference for TabsToLinks behavior.
weinig@apple.com [Thu, 9 Dec 2010 02:20:02 +0000 (02:20 +0000)]
Add WebKit2 Preference for TabsToLinks behavior.
<rdar://problem/8664263>

Reviewed by Gavin Barraclough.

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetTabsToLinks):
(WKPreferencesGetTabsToLinks):
* UIProcess/API/C/WKPreferences.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::tabsToLinks):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::updatePreferences):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::tabsToLinks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Thu, 9 Dec 2010 02:15:09 +0000 (02:15 +0000)]
2010-12-08  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        WebTouchEvent::isTouchEventType() does not take into account the type TouchCancel
        https://bugs.webkit.org/show_bug.cgi?id=50680

        Add the missing type check to WebTouchEvent::isTouchEventType().

        * Shared/WebTouchEvent.cpp:
        (WebKit::WebTouchEvent::isTouchEventType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix Windows build.
ggaren@apple.com [Thu, 9 Dec 2010 02:03:00 +0000 (02:03 +0000)]
Try to fix Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Updated .def file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed a way to get a WKBundleFrameRef from JS HTMLIFrameElement
weinig@apple.com [Thu, 9 Dec 2010 02:02:13 +0000 (02:02 +0000)]
Need a way to get a WKBundleFrameRef from JS HTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=50726

Reviewed by Darin Adler.

Adds WKBundleNodeHandleCopyDocumentFrame, WKBundleNodeHandleCopyHTMLFrameElementContentFrame
and WKBundleNodeHandleCopyHTMLIFrameElementContentFrame, to handle the document, <frame>
and <iframe> cases.

* WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(WKBundleNodeHandleCopyDocumentFrame):
(WKBundleNodeHandleCopyHTMLFrameElementContentFrame):
(WKBundleNodeHandleCopyHTMLIFrameElementContentFrame):
* WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::copyDocumentFrame):
(WebKit::InjectedBundleNodeHandle::copyHTMLFrameElementContentFrame):
(WebKit::InjectedBundleNodeHandle::copyHTMLIFrameElementContentFrame):
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Thu, 9 Dec 2010 01:54:49 +0000 (01:54 +0000)]
2010-12-08  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Add getter and setters for acceleratesRendering flag on layers
        https://bugs.webkit.org/show_bug.cgi?id=50717

        * platform/graphics/GraphicsLayer.cpp:
        * platform/graphics/ca/GraphicsLayerCA.cpp:
        * platform/graphics/ca/mac/PlatformCALayerMac.mm:
        Plumbed through acceleratedRendering flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix Windows build.
ggaren@apple.com [Thu, 9 Dec 2010 01:50:40 +0000 (01:50 +0000)]
Try to fix Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Updated .def
file to remove a symbol -- the next build failure will say which symbol
to add back.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 9 Dec 2010 01:45:22 +0000 (01:45 +0000)]
2010-12-08  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        Update expectations for r73566.

        * platform/gtk/editing/selection/find-yensign-and-backslash-expected.txt:
        * platform/qt/editing/selection/find-yensign-and-backslash-expected.txt: Removed.
        * platform/win/editing/selection/find-yensign-and-backslash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix Windows build.
ggaren@apple.com [Thu, 9 Dec 2010 01:42:24 +0000 (01:42 +0000)]
Try to fix Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Updated .def file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed a WebKit2 way to test whether a frame is displaying a standalone image
weinig@apple.com [Thu, 9 Dec 2010 01:41:57 +0000 (01:41 +0000)]
Need a WebKit2 way to test whether a frame is displaying a standalone image
<rdar://problem/8443059>
WebKit2: Need a way to test whether a page or frame is showing HTML content
<rdar://problem/8642563>

Reviewed by Gavin Barraclough.

Add WKFrameIsDiplayingStandaloneImageDocument and WKFrameIsDiplayingMarkupDocument.

* UIProcess/API/C/WKFrame.cpp:
(WKFrameIsDiplayingStandaloneImageDocument):
(WKFrameIsDiplayingMarkupDocument):
* UIProcess/API/C/WKFrame.h:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::canProvideSource): This now just calls isDiplayingMarkupDocument.
(WebKit::WebFrameProxy::isDiplayingStandaloneImageDocument):
(WebKit::WebFrameProxy::isDiplayingMarkupDocument):
* UIProcess/WebFrameProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 9 Dec 2010 01:38:56 +0000 (01:38 +0000)]
2010-12-07  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        WebGLUniformLocation objects must be invalidated during linkProgram
        https://bugs.webkit.org/show_bug.cgi?id=37118

        * html/canvas/WebGLProgram.cpp:
        (WebCore::WebGLProgram::WebGLProgram): Initialize link count to 0.
        (WebCore::WebGLProgram::cacheActiveAttribLocations): Don't check link status through gl call; use the cached status instead.
        * html/canvas/WebGLProgram.h:
        (WebCore::WebGLProgram::getLinkCount): Get link count.
        (WebCore::WebGLProgram::increaseLinkCount): Increase link count by 1.
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::getUniform): Fix a bug where wrong error is generated.
        (WebCore::WebGLRenderingContext::linkProgram): call increaseLinkCount after linkProgram.
        * html/canvas/WebGLUniformLocation.cpp:
        (WebCore::WebGLUniformLocation::WebGLUniformLocation): Set program's link count upon creation.
        (WebCore::WebGLUniformLocation::program): Return null if count doesn't match the program's.
        (WebCore::WebGLUniformLocation::location): Return -1 if count doesn't match the program's.
        * html/canvas/WebGLUniformLocation.h:
2010-12-07  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        WebGLUniformLocation objects must be invalidated during linkProgram
        https://bugs.webkit.org/show_bug.cgi?id=37118

        * fast/canvas/webgl/uniform-location-expected.txt:
        * fast/canvas/webgl/uniform-location.html: Check that after linkProgram, all previous uniform locations become invalid.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=50725
adele@apple.com [Thu, 9 Dec 2010 01:36:04 +0000 (01:36 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=50725
<rdar://problem/8694972> REGRESSION (r72052): "Search" placeholder in MobileMe mail is positioned too high

Reviewed by Darin Adler.

Test: fast/forms/placeholder-position.html

Since we center the inner text element for single line text controls,
we should ask the subclass to give us the y offset instead of trying to calculate it in the RenderTextControl class.

* rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::paintPlaceholder):
* rendering/RenderTextControl.h:
* rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::textBlockInsetTop):
* rendering/RenderTextControlMultiLine.h:
* rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::textBlockInsetTop):
* rendering/RenderTextControlSingleLine.h:

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=50725
<rdar://problem/8694972> REGRESSION (r72052): "Search" placeholder in MobileMe mail is positioned too high

Reviewed by Darin Adler.

* fast/forms/placeholder-position.html: Added.
* platform/mac/fast/forms/placeholder-position-expected.checksum: Added.
* platform/mac/fast/forms/placeholder-position-expected.png: Added.
* platform/mac/fast/forms/placeholder-position-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix GTK Linux build.
ggaren@apple.com [Thu, 9 Dec 2010 01:35:13 +0000 (01:35 +0000)]
Try to fix GTK Linux build.

* jit/ExecutableAllocator.cpp:
(JSC::ExecutablePool::systemAlloc):
* runtime/AlignedMemoryAllocator.h:
(JSC::::AlignedMemoryAllocator): Updated for Usage enum moving to OSAllocator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMigrated OS-specific allocation code from PageReservation and PageAllocation to OSAll...
ggaren@apple.com [Thu, 9 Dec 2010 01:30:18 +0000 (01:30 +0000)]
Migrated OS-specific allocation code from PageReservation and PageAllocation to OSAllocator
https://bugs.webkit.org/show_bug.cgi?id=50653

Reviewed by Sam Weinig.

* JavaScriptCore.exp: Updated for new function signature.

* interpreter/RegisterFile.h:
(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::grow):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator): Removed checkAllocatedOkay.
OSAllocator is now the central location for verifying that allocation succeeds.
This allowed me to remove some complicating cross-platform cruft.

* runtime/AlignedMemoryAllocator.h:
(JSC::::allocate): Updated for code motion.

* wtf/OSAllocator.h: Added Usage, writable, and executable parameters, to
support VM features required by clients of PageAllocation and PageReservation.

* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit): Moved PageAllocation support for randomizing
executable memory here.

* wtf/OSAllocatorSymbian.cpp:
(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit): Updated for new function signatures.

* wtf/OSAllocatorWin.cpp:
(WTF::protection):
(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::release): Updated for new function signatures. Moved
some protection-related and WINCE-related code from PageAllocation here.

* wtf/PageAllocation.cpp: Nixed cross-platform lastError abstraction, since
it was only used by checkAllocatedOkay, which is now gone.

* wtf/PageAllocation.h:
(WTF::PageAllocation::allocate):
(WTF::PageAllocation::allocateAligned):
(WTF::PageAllocation::deallocate):
(WTF::PageAllocation::isPowerOfTwo):
(WTF::PageAllocation::systemAllocateAligned): Removed system* functions,
and replaced calls to them with calls to OSAllocator.

* wtf/PageReservation.h:
(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):
(WTF::PageReservation::reserve):
(WTF::PageReservation::deallocate):
(WTF::PageReservation::PageReservation): Ditto. Added m_writable and
m_executable because these flags are now required when committing memory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebFrameProxy::canShowMIMEType should return true for PDF MIME types in the main...
andersca@apple.com [Thu, 9 Dec 2010 01:09:03 +0000 (01:09 +0000)]
WebFrameProxy::canShowMIMEType should return true for PDF MIME types in the main frame
https://bugs.webkit.org/show_bug.cgi?id=50724

Reviewed by Darin Adler.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::pdfAndPostScriptMIMETypes):
* UIProcess/WebContext.h:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::canShowMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Chris Rogers <crogers@google.com>
crogers@google.com [Thu, 9 Dec 2010 01:03:51 +0000 (01:03 +0000)]
2010-12-08  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Add web audio files to mac port Xcode projects
        https://bugs.webkit.org/show_bug.cgi?id=50721

        * JavaScriptCore.xcodeproj/project.pbxproj:
2010-12-08  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Add web audio files to mac port Xcode projects
        https://bugs.webkit.org/show_bug.cgi?id=50721

        No new tests since audio API is not yet implemented.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::webkitAudioContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebMenuTarget implemented in both WebKit and WebKit2
bweinstein@apple.com [Thu, 9 Dec 2010 01:03:06 +0000 (01:03 +0000)]
WebMenuTarget implemented in both WebKit and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50665
<rdar://problem/8742640>

Reviewed by Brady Eidson.

Rename WebMenuTarget to WKMenuTarget to prevent this warning and stay consistent with
other WebKit2 namings.

* UIProcess/mac/WebContextMenuProxyMac.mm:
(+[WKMenuTarget sharedMenuTarget]):
(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::showContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoYensign hack should work with Shift_JIS and ISO-2022-JP encodings.
tkent@chromium.org [Thu, 9 Dec 2010 00:54:23 +0000 (00:54 +0000)]
Yensign hack should work with Shift_JIS and ISO-2022-JP encodings.
https://bugs.webkit.org/show_bug.cgi?id=49714

Reviewed by Alexey Proskuryakov.

WebCore:

IE chooses a font which shows a yensign for 0x5c code point for a page
encoded in x-mac-japanese, ISO-2022-JP, EUC-JP, Shift_JIS, Shift_JIS_X0213-2000,
x-sjis, and Windows-31J.
We have emulated this behavior by replacing 0x5c with 0xa5 for EUC-JP and
Shift_JIS_X0213-2000. This change adds other encodings above.

Also, we move the HashSet initialization for isJapanese() and
backslashAsCurrencySymbol() to TextEncodingRegistry.cpp because of
ease of making them multi-thread safe.

* platform/text/TextEncoding.cpp:
(WebCore::TextEncoding::isJapanese): Just calls isJapaneseEncoding().
(WebCore::TextEncoding::backslashAsCurrencySymbol): Uses shouldShowBackslashAsCurrencySymbolIn().
* platform/text/TextEncodingRegistry.cpp:
(WebCore::addEncodingName): Moved from TextEncoding.cpp, and stop using atomicCanonicalTextEncodingName().
(WebCore::buildQuirksSets): Added. Initializes HashSets for isJapaneseEncoding() and shouldShowBackslashAsCurrencySymbolIn().
(WebCore::isJapaneseEncoding):
(WebCore::shouldShowBackslashAsCurrencySymbolIn):
(WebCore::extendTextCodecMaps): Add a call to buildQuirksSets().
* platform/text/TextEncodingRegistry.h:

LayoutTests:

Use Shift_JIS instead of Shift_JIS_X0213-2000 because Shift_JIS_X0213-2000
encoding is available only on Mac.
Add a test for ISO-2022-JP.

* editing/selection/find-yensign-and-backslash-expected.txt:
* editing/selection/find-yensign-and-backslash.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove canShowMIMEType to Frame
andersca@apple.com [Thu, 9 Dec 2010 00:47:38 +0000 (00:47 +0000)]
Move canShowMIMEType to Frame
https://bugs.webkit.org/show_bug.cgi?id=50723

Reviewed by Sam Weinig.

* UIProcess/API/C/WKFrame.cpp:
(WKFrameCanShowMIMEType):
* UIProcess/API/C/WKFrame.h:
* UIProcess/API/C/WKPage.cpp:
* UIProcess/API/C/WKPage.h:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::canShowMIMEType):
* UIProcess/WebFrameProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Andy Estes <aestes@apple.com>
aestes@apple.com [Thu, 9 Dec 2010 00:37:34 +0000 (00:37 +0000)]
2010-12-08  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        Reflected unsigned attributes should be in the range [0, 2^31).
        https://bugs.webkit.org/show_bug.cgi?id=50472

        HTML5 says that unsigned reflected attributes should be in the range
        [0, 2^31). When a value isn't in this range, a default value (or 0)
        should be returned instead. Update the JS bindings code generator to
        ensure 0 is returned when a content attribute value falls outside of
        this range.

        Tests: bindings/scripts/test/TestObj.idl
               fast/html/marquee-element.html

        * bindings/scripts/CodeGeneratorJS.pm: Return the maximum of 0 and the
        content attribute as a 32-bit signed int when converting a native value
        to an unsigned JS value.
        * bindings/scripts/test/TestObj.idl: Add a reflected unsigned attribute
        to test code generation.
        * bindings/scripts/test/CPP/WebDOMTestObj.cpp: Update test results.
        * bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
        * bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
        * bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
        * bindings/scripts/test/JS/JSTestObj.h: Ditto.
        * bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
        * bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
        * bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
2010-12-08  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        Reflected unsigned attributes should be in the range [0, 2^31).
        https://bugs.webkit.org/show_bug.cgi?id=50472

        * fast/html/marquee-element.html: Give hspace and vspace negative values
        and test what their corresponding IDL attributes reflect.
        * fast/html/marquee-element-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 9 Dec 2010 00:13:04 +0000 (00:13 +0000)]
2010-12-08  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        make starting the websocket server more reliable on windows
        https://bugs.webkit.org/show_bug.cgi?id=50712

        * Scripts/webkitpy/common/system/filesystem.py:
        (remove): Substitute method for os.remove to retry on error on Windows
        * Scripts/webkitpy/common/system/filesystem_unittest.py:
        * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 8 Dec 2010 23:58:51 +0000 (23:58 +0000)]
2010-12-08  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium rebaseline for r73548.

        * platform/chromium-linux/fast/text/international/khmer-selection-expected.checksum:
        * platform/chromium-linux/fast/text/international/khmer-selection-expected.png:
        * platform/chromium-linux/fast/text/international/khmer-selection-expected.txt:
        * platform/chromium-win-xp/fast/text/international/khmer-selection-expected.checksum: Removed.
        * platform/chromium-win-xp/fast/text/international/khmer-selection-expected.png: Removed.
        * platform/chromium-win-xp/fast/text/international/khmer-selection-expected.txt: Removed.
        * platform/chromium-win/fast/text/international/khmer-selection-expected.checksum:
        * platform/chromium-win/fast/text/international/khmer-selection-expected.png:
        * platform/chromium-win/fast/text/international/khmer-selection-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Carlos Garcia Campos <cgarcia@igalia.com>
commit-queue@webkit.org [Wed, 8 Dec 2010 23:50:25 +0000 (23:50 +0000)]
2010-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Use gtk_icon_set_render_icon() to render icons in RenderThemeGtk
        https://bugs.webkit.org/show_bug.cgi?id=50623

        We don't need to cache the icons since the will be cached by GTK+,
        and they will be rendered using the state and text direction.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::paintStockIcon):
        (WebCore::getMediaButtonIconSize):
        (WebCore::RenderThemeGtk::initMediaColors):
        (WebCore::RenderThemeGtk::initMediaButtons):
        (WebCore::RenderThemeGtk::RenderThemeGtk):
        (WebCore::RenderThemeGtk::~RenderThemeGtk):
        (WebCore::RenderThemeGtk::gtkIconState):
        (WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle):
        (WebCore::centerRectVerticallyInParentInputElement):
        (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
        (WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle):
        (WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
        (WebCore::RenderThemeGtk::platformColorsDidChange):
        (WebCore::RenderThemeGtk::paintMediaButton):
        (WebCore::RenderThemeGtk::paintMediaFullscreenButton):
        (WebCore::RenderThemeGtk::paintMediaMuteButton):
        (WebCore::RenderThemeGtk::paintMediaPlayButton):
        (WebCore::RenderThemeGtk::paintMediaSeekBackButton):
        (WebCore::RenderThemeGtk::paintMediaSeekForwardButton):
        * platform/gtk/RenderThemeGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open...
bweinstein@apple.com [Wed, 8 Dec 2010 23:33:49 +0000 (23:33 +0000)]
REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
https://bugs.webkit.org/show_bug.cgi?id=50683

Reviewed by John Sullivan.

If our context menu item already has an action, don't overwrite the action with the context menu
forwarder.

* WebView/WebHTMLView.mm:
(setMenuItemTarget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Wed, 8 Dec 2010 23:31:04 +0000 (23:31 +0000)]
2010-12-08  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        Detach node iterator and move to new document when node gets moved.
        https://bugs.webkit.org/show_bug.cgi?id=50697

        Test: fast/dom/node-iterator-document-moved-crash.html

        * dom/Document.cpp: Method that takes a node and new document as argument.
        It detaches the node iterators belonging to the current document and attaches
        them to the new document.
        (WebCore::Document::moveNodeIteratorsToNewDocument):
        * dom/Document.h: Function definition.
        * dom/Node.cpp: When node is moved to another document, call the function to move
        the iterators appropriately.
        (WebCore::Node::setDocument):
2010-12-08  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        Tests that we do not crash when node iterator gets moved across documents.
        https://bugs.webkit.org/show_bug.cgi?id=50697

        * fast/dom/node-iterator-document-moved-crash-expected.txt: Added.
        * fast/dom/node-iterator-document-moved-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 8 Dec 2010 23:27:47 +0000 (23:27 +0000)]
2010-12-08  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium rebaseline for r73548.

        * platform/chromium-linux/editing/selection/caret-ltr-2-expected.checksum: Added.
        * platform/chromium-linux/editing/selection/caret-ltr-2-expected.png: Added.
        * platform/chromium-linux/editing/selection/caret-ltr-2-left-expected.checksum: Added.
        * platform/chromium-linux/editing/selection/caret-ltr-2-left-expected.png: Added.
        * platform/chromium-linux/editing/selection/caret-ltr-expected.checksum: Added.
        * platform/chromium-linux/editing/selection/caret-ltr-expected.png: Added.
        * platform/chromium-linux/editing/selection/caret-ltr-right-expected.checksum: Added.
        * platform/chromium-linux/editing/selection/caret-ltr-right-expected.png: Added.
        * platform/chromium-linux/editing/selection/caret-rtl-2-expected.checksum: Added.
        * platform/chromium-linux/editing/selection/caret-rtl-2-expected.png: Added.
        * platform/chromium-linux/editing/selection/caret-rtl-2-left-expected.checksum: Added.
        * platform/chromium-linux/editing/selection/caret-rtl-2-left-expected.png: Added.
        * platform/chromium-linux/editing/selection/caret-rtl-expected.checksum:
        * platform/chromium-linux/editing/selection/caret-rtl-expected.png:
        * platform/chromium-linux/editing/selection/caret-rtl-right-expected.checksum: Added.
        * platform/chromium-linux/editing/selection/caret-rtl-right-expected.png: Added.
        * platform/chromium-mac/editing/selection/caret-ltr-2-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/caret-ltr-2-expected.png: Added.
        * platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png: Added.
        * platform/chromium-mac/editing/selection/caret-ltr-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/caret-ltr-expected.png: Added.
        * platform/chromium-mac/editing/selection/caret-ltr-right-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/caret-ltr-right-expected.png: Added.
        * platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Added.
        * platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Added.
        * platform/chromium-mac/editing/selection/caret-rtl-expected.checksum:
        * platform/chromium-mac/editing/selection/caret-rtl-expected.png:
        * platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Added.
        * platform/chromium-win/editing/selection/caret-ltr-2-expected.checksum: Added.
        * platform/chromium-win/editing/selection/caret-ltr-2-expected.png: Added.
        * platform/chromium-win/editing/selection/caret-ltr-2-expected.txt: Added.
        * platform/chromium-win/editing/selection/caret-ltr-2-left-expected.checksum: Added.
        * platform/chromium-win/editing/selection/caret-ltr-2-left-expected.png: Added.
        * platform/chromium-win/editing/selection/caret-ltr-2-left-expected.txt: Added.
        * platform/chromium-win/editing/selection/caret-ltr-expected.checksum: Added.
        * platform/chromium-win/editing/selection/caret-ltr-expected.png: Added.
        * platform/chromium-win/editing/selection/caret-ltr-expected.txt: Added.
        * platform/chromium-win/editing/selection/caret-ltr-right-expected.checksum: Added.
        * platform/chromium-win/editing/selection/caret-ltr-right-expected.png: Added.
        * platform/chromium-win/editing/selection/caret-ltr-right-expected.txt: Added.
        * platform/chromium-win/editing/selection/caret-rtl-2-expected.checksum:
        * platform/chromium-win/editing/selection/caret-rtl-2-expected.png:
        * platform/chromium-win/editing/selection/caret-rtl-2-expected.txt:
        * platform/chromium-win/editing/selection/caret-rtl-2-left-expected.checksum: Added.
        * platform/chromium-win/editing/selection/caret-rtl-2-left-expected.png: Added.
        * platform/chromium-win/editing/selection/caret-rtl-2-left-expected.txt: Added.
        * platform/chromium-win/editing/selection/caret-rtl-expected.checksum:
        * platform/chromium-win/editing/selection/caret-rtl-expected.png:
        * platform/chromium-win/editing/selection/caret-rtl-expected.txt:
        * platform/chromium-win/editing/selection/caret-rtl-right-expected.checksum: Added.
        * platform/chromium-win/editing/selection/caret-rtl-right-expected.png: Added.
        * platform/chromium-win/editing/selection/caret-rtl-right-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 8 Dec 2010 23:24:24 +0000 (23:24 +0000)]
2010-12-08  Martin Robinson  <mrobinson@igalia.com>

        Replace some GTK+ test results after r73548.

        * platform/gtk/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
        * platform/gtk/fast/dom/vertical-scrollbar-in-rtl-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73557 268f45cc-cd09-0410-ab3c-d52691b4dbfc