WebKit-https.git
7 years agoThe assertions in updateLayerPositionsAfterScroll were commented out in r141278,...
jberlin@webkit.org [Sat, 2 Feb 2013 00:25:01 +0000 (00:25 +0000)]
The assertions in updateLayerPositionsAfterScroll were commented out in r141278, so stop
expecting http/tests/inspector/resource-har-pages.html to assert in debug builds.
(see https://bugs.webkit.org/show_bug.cgi?id=103432).

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled Chromium DEPS to r180186. Requested by
commit-queue@webkit.org [Sat, 2 Feb 2013 00:19:44 +0000 (00:19 +0000)]
Unreviewed.  Rolled Chromium DEPS to r180186.  Requested by
"Nico Weber" <thakis@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake svg-fonts-in-text-controls.html have the same results across platforms
ojan@chromium.org [Sat, 2 Feb 2013 00:14:17 +0000 (00:14 +0000)]
Make svg-fonts-in-text-controls.html have the same results across platforms
https://bugs.webkit.org/show_bug.cgi?id=108676

Reviewed by Dirk Pranke.

Mac uses a different default font-size for form controls and Windows
uses different padding for textareas/inputs. Override these so
this test doesn't need platform specific expectations.

* platform/chromium/TestExpectations:
* platform/gtk/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
* platform/qt/svg/custom/svg-fonts-in-text-controls-expected.png: Removed.
* platform/qt/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
* svg/custom/script-tests/svg-fonts-in-text-controls.js:
* svg/custom/svg-fonts-in-text-controls-expected.txt:
* svg/custom/svg-fonts-in-text-controls.html:
These dummy elements aren't needed anymore. js-test-pre.js inserts them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Use light supplement names instead of static AtomicStrings
benjamin@webkit.org [Sat, 2 Feb 2013 00:10:09 +0000 (00:10 +0000)]
[WK2] Use light supplement names instead of static AtomicStrings
https://bugs.webkit.org/show_bug.cgi?id=108570

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-01
Reviewed by Anders Carlsson.

Since all the supplement names are just string literals and are all different,
we can just use their pointer as the key in the supplement hashmaps.

This is lighter and faster than using AtomicString. WebCore already moved to this
in Supplementable.

* NetworkProcess/NetworkProcess.h:
(WebKit::NetworkProcess::addSupplement):
(NetworkProcess):
* Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::supplementName):
* Shared/Authentication/AuthenticationManager.h:
(AuthenticationManager):
* Shared/Network/CustomProtocols/CustomProtocolManager.h:
(CustomProtocolManager):
* Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
(WebKit::CustomProtocolManager::supplementName):
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::supplementName):
* UIProcess/Notifications/WebNotificationManagerProxy.h:
(WebNotificationManagerProxy):
* UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::supplementName):
* UIProcess/WebApplicationCacheManagerProxy.h:
(WebApplicationCacheManagerProxy):
* UIProcess/WebContext.h:
(WebContext):
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::supplementName):
* UIProcess/WebCookieManagerProxy.h:
(WebCookieManagerProxy):
* UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::supplementName):
* UIProcess/WebDatabaseManagerProxy.h:
(WebDatabaseManagerProxy):
* UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::supplementName):
* UIProcess/WebGeolocationManagerProxy.h:
(WebGeolocationManagerProxy):
* UIProcess/WebKeyValueStorageManagerProxy.cpp:
(WebKit::WebKeyValueStorageManagerProxy::supplementName):
* UIProcess/WebKeyValueStorageManagerProxy.h:
(WebKeyValueStorageManagerProxy):
* UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::supplementName):
* UIProcess/WebMediaCacheManagerProxy.h:
(WebMediaCacheManagerProxy):
* UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::supplementName):
* UIProcess/WebResourceCacheManagerProxy.h:
(WebResourceCacheManagerProxy):
* UIProcess/soup/WebSoupRequestManagerProxy.cpp:
(WebKit::WebSoupRequestManagerProxy::supplementName):
* UIProcess/soup/WebSoupRequestManagerProxy.h:
(WebSoupRequestManagerProxy):
* WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::supplementName):
* WebProcess/ApplicationCache/WebApplicationCacheManager.h:
(WebApplicationCacheManager):
* WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::supplementName):
* WebProcess/Cookies/WebCookieManager.h:
(WebCookieManager):
* WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::supplementName):
* WebProcess/Geolocation/WebGeolocationManager.h:
(WebGeolocationManager):
* WebProcess/MediaCache/WebMediaCacheManager.cpp:
(WebKit::WebMediaCacheManager::supplementName):
* WebProcess/MediaCache/WebMediaCacheManager.h:
(WebMediaCacheManager):
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::supplementName):
* WebProcess/Notifications/WebNotificationManager.h:
(WebNotificationManager):
* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::supplementName):
* WebProcess/ResourceCache/WebResourceCacheManager.h:
(WebResourceCacheManager):
* WebProcess/Storage/WebKeyValueStorageManager.cpp:
(WebKit::WebKeyValueStorageManager::supplementName):
* WebProcess/Storage/WebKeyValueStorageManager.h:
(WebKeyValueStorageManager):
* WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit::WebDatabaseManager::supplementName):
* WebProcess/WebCoreSupport/WebDatabaseManager.h:
(WebDatabaseManager):
* WebProcess/WebProcess.h:
(WebKit::WebProcess::addSupplement):
(WebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] WebWidget::selectionBounds should return the bounds in document space
commit-queue@webkit.org [Fri, 1 Feb 2013 23:59:32 +0000 (23:59 +0000)]
[Chromium] WebWidget::selectionBounds should return the bounds in document space
https://bugs.webkit.org/show_bug.cgi?id=108386

Patch by Chris Hopman <cjhopman@chromium.org> on 2013-02-01
Reviewed by James Robinson.

When in applyPageScaleFactorInCompositor mode, selectionBounds needs
to scale the anchor/focus window points by the pageScaleFactor.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::selectionBounds):
(WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClean the String->AtomicString conversion for AnimationController::pauseAnimationAtTime
benjamin@webkit.org [Fri, 1 Feb 2013 23:55:46 +0000 (23:55 +0000)]
Clean the String->AtomicString conversion for AnimationController::pauseAnimationAtTime
https://bugs.webkit.org/show_bug.cgi?id=108558

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-01
Reviewed by Dean Jackson.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

This is a step torward killing the implicit conversion from String to AtomicString.

The animation name are AtomicString. The API is changed all the way to the callers
to take an AtomicString. When needed, we use explicit conversion.

* WebCore.exp.in:
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::AnimationController::pauseAnimationAtTime):
* page/animation/AnimationController.h:
(AnimationController):
* page/animation/AnimationControllerPrivate.h:
(AnimationControllerPrivate):
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::pauseAnimationAtTime):
We should not null check the name. Getting a null name from the HashMap would be
an error from the tests, and the HashMap would never return a value anyway.
* testing/Internals.cpp:
(WebCore::Internals::pauseAnimationAtTimeOnPseudoElement):

Source/WebKit2:

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFramePauseAnimationOnElementWithId):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::pauseAnimationOnElementWithId):
* WebProcess/WebPage/WebFrame.h:
(WebFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: memoize expensive computation during blocks where tree doesn't change
dmazzoni@google.com [Fri, 1 Feb 2013 23:50:41 +0000 (23:50 +0000)]
AX: memoize expensive computation during blocks where tree doesn't change
https://bugs.webkit.org/show_bug.cgi?id=106497

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add a cache for computed attributes of AXObjects.
The cache can be enabled at the start of a batch of
read-only operations on the accessibility tree, and
it's cleared automatically when the tree mutates.
Currently accessibilityIsIgnored is cached, since it's
frequently called and relatively expensive to compute.

No new tests.

* accessibility/AXObjectCache.cpp:
(WebCore):
(WebCore::AXComputedObjectAttributeCache::getIgnored):
(WebCore::AXComputedObjectAttributeCache::setIgnored):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::nodeTextChangeNotification):
(WebCore::AXObjectCache::handleScrollbarUpdate):
(WebCore::AXObjectCache::startCachingComputedObjectAttributesUntilTreeMutates):
(WebCore::AXObjectCache::stopCachingComputedObjectAttributes):
* accessibility/AXObjectCache.h:
(AXComputedObjectAttributeCache):
(WebCore::AXComputedObjectAttributeCache::create):
(WebCore::AXComputedObjectAttributeCache::AXComputedObjectAttributeCache):
(WebCore::AXComputedObjectAttributeCache::CachedAXObjectAttributes::CachedAXObjectAttributes):
(CachedAXObjectAttributes):
(WebCore):
(WebCore::AXObjectCache::computedObjectAttributeCache):
(AXObjectCache):
(WebCore::AXComputedObjectAttributeCache::getIgnored):
(WebCore::AXComputedObjectAttributeCache::setIgnored):
(WebCore::startCachingComputedObjectAttributesUntilTreeMutates):
(WebCore::stopCachingComputedObjectAttributes):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::findMatchingObjects):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):

Source/WebKit/chromium:

Expose two methods to enable and disable caching of
computed WebAccessibilityObject attributes, to speed up
batch read-only operations.

* public/WebAccessibilityObject.h:
(WebAccessibilityObject):
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::startCachingComputedObjectAttributesUntilTreeMutates):
(WebKit):
(WebKit::WebAccessibilityObject::stopCachingComputedObjectAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Build fix.
ap@apple.com [Fri, 1 Feb 2013 23:46:58 +0000 (23:46 +0000)]
    Build fix.

        * Modules/webdatabase/DatabaseBackend.cpp: (DoneCreatingDatabaseOnExitCaller):
        Don't fail because of an unused member variable in cross-plaform code path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Expose WebNode::shadowHost()
fsamuel@chromium.org [Fri, 1 Feb 2013 23:30:15 +0000 (23:30 +0000)]
[Chromium] Expose WebNode::shadowHost()
https://bugs.webkit.org/show_bug.cgi?id=108681

Reviewed by Dimitri Glazkov.

BrowserPlugin needs to be able to check the event listeners attached to
<webview> and so we expose shadowHost to permit it to poke at the webview
node.

* public/WebNode.h:
* src/WebNode.cpp:
(WebKit::WebNode::shadowHost):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fat scrollbars on Windows in high-DPI mode.
commit-queue@webkit.org [Fri, 1 Feb 2013 23:23:51 +0000 (23:23 +0000)]
[chromium] Fat scrollbars on Windows in high-DPI mode.
https://bugs.webkit.org/show_bug.cgi?id=108637

Updates mechanism for retrieving scrollbar metrics on the
Windows port of Chromium.  Previously, GetSystemMetrics calls
were used, which fetches prescaled sizes in pixel rather than
logical units, resulting in a double scaling when a device
scale factor is set.  With the patch, the size is retrieved
from the theme engine in DIP.

Patch by Kevin Ellis <kevers@chromium.org> on 2013-02-01
Reviewed by Adam Barth.

Source/Platform:

* chromium/public/win/WebThemeEngine.h:
(WebThemeEngine):

Source/WebCore:

No new tests.

* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::menuListButtonWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStructure should have a StructureRareData field to save space
mhahnenberg@apple.com [Fri, 1 Feb 2013 23:10:49 +0000 (23:10 +0000)]
Structure should have a StructureRareData field to save space
https://bugs.webkit.org/show_bug.cgi?id=108659

Reviewed by Oliver Hunt.

Many of the fields in Structure are used in a subset of all total Structures; however, all Structures must
pay the memory cost of those fields, regardless of whether they use them or not. Since we can have potentially
many Structures on a single page (e.g. bing.com creates ~1500 Structures), it would be profitable to
refactor Structure so that not every Structure has to pay the memory costs for these infrequently used fields.

To accomplish this, we can create a new StructureRareData class to house these seldom used fields which we
can allocate on demand whenever a Structure requires it. This StructureRareData can itself be a JSCell, and
can do all the marking of the fields for the Structure. The StructureRareData field will be part of a union
with m_previous to minimize overhead. We'll add a new field to JSTypeInfo to indicate that the Structure has
a StructureRareData field. During transitions, a Structure will clone its previous Structure's StructureRareData
if it has one. There could be some potential for optimizing this process, but the initial implementation will
be dumb since we'd be paying these overhead costs for each Structure anyways.

Initially we'll only put two fields in the StructureRareData to avoid a memory regression. Over time we'll
continue to move fields from Structure to StructureRareData. Optimistically, this could potentially reduce our
Structure memory footprint by up to around 75%. It could also clear the way for removing destructors from
Structures (and into StructureRareData).

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* dfg/DFGRepatch.cpp: Includes for linking purposes.
* jit/JITStubs.cpp:
* jsc.cpp:
* llint/LLIntSlowPaths.cpp:
* runtime/JSCellInlines.h: Added ifdef guards.
* runtime/JSGlobalData.cpp: New Structure for StructureRareData class.
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSGlobalData):
* runtime/JSGlobalObject.h:
* runtime/JSTypeInfo.h: New flag to indicate whether or not a Structure has a StructureRareData field.
(JSC::TypeInfo::flags):
(JSC::TypeInfo::structureHasRareData):
* runtime/ObjectPrototype.cpp:
* runtime/Structure.cpp: We use a combined WriteBarrier<JSCell> field m_previousOrRareData to avoid compiler issues.
(JSC::Structure::dumpStatistics):
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::pin):
(JSC::Structure::allocateRareData): Handles allocating a brand new StructureRareData field.
(JSC::Structure::cloneRareDataFrom): Handles cloning a StructureRareData field from another. Used during Structure
transitions.
(JSC::Structure::visitChildren): We no longer have to worry about marking m_objectToStringValue.
* runtime/Structure.h:
(JSC::Structure::previousID): Checks the structureHasRareData flag to see where it should get the previous Structure.
(JSC::Structure::objectToStringValue): Reads the value from the StructureRareData. If it doesn't exist, returns 0.
(JSC::Structure::setObjectToStringValue): Ensures that we have a StructureRareData field, then forwards the function
call to it.
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::setPreviousID): Checks for StructureRareData and forwards if necessary.
(Structure):
(JSC::Structure::clearPreviousID): Ditto.
(JSC::Structure::create):
* runtime/StructureRareData.cpp: Added. All of the basic functionality of a JSCell with the fields that we've moved
from Structure and the functions required to access/modify those fields as Structure would have done.
(JSC):
(JSC::StructureRareData::createStructure):
(JSC::StructureRareData::create):
(JSC::StructureRareData::clone):
(JSC::StructureRareData::StructureRareData):
(JSC::StructureRareData::visitChildren):
* runtime/StructureRareData.h: Added.
(JSC):
(StructureRareData):
* runtime/StructureRareDataInlines.h: Added.
(JSC):
(JSC::StructureRareData::previousID):
(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::clearPreviousID):
(JSC::Structure::previous): Handles the ugly casting to get the value of the right type of m_previousOrRareData.
(JSC::Structure::rareData): Ditto.
(JSC::StructureRareData::objectToStringValue):
(JSC::StructureRareData::setObjectToStringValue):

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* dfg/DFGRepatch.cpp:
* jit/JITStubs.cpp:
* jsc.cpp:
* llint/LLIntSlowPaths.cpp:
* runtime/JSCellInlines.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSGlobalData):
* runtime/JSGlobalObject.h:
* runtime/JSTypeInfo.h:
(JSC):
(JSC::TypeInfo::flags):
(JSC::TypeInfo::structureHasRareData):
* runtime/ObjectPrototype.cpp:
* runtime/Structure.cpp:
(JSC::Structure::dumpStatistics):
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::pin):
(JSC::Structure::allocateRareData):
(JSC):
(JSC::Structure::cloneRareDataFrom):
(JSC::Structure::visitChildren):
* runtime/Structure.h:
(JSC::Structure::previousID):
(JSC::Structure::objectToStringValue):
(JSC::Structure::setObjectToStringValue):
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::setPreviousID):
(Structure):
(JSC::Structure::clearPreviousID):
(JSC::Structure::previous):
(JSC::Structure::rareData):
(JSC::Structure::create):
* runtime/StructureRareData.cpp: Added.
(JSC):
(JSC::StructureRareData::createStructure):
(JSC::StructureRareData::create):
(JSC::StructureRareData::clone):
(JSC::StructureRareData::StructureRareData):
(JSC::StructureRareData::visitChildren):
* runtime/StructureRareData.h: Added.
(JSC):
(StructureRareData):
* runtime/StructureRareDataInlines.h: Added.
(JSC):
(JSC::StructureRareData::previousID):
(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::clearPreviousID):
(JSC::StructureRareData::objectToStringValue):
(JSC::StructureRareData::setObjectToStringValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebKit/chromium: [Chromium] Ignore punctuation in spellcheck
commit-queue@webkit.org [Fri, 1 Feb 2013 23:03:57 +0000 (23:03 +0000)]
Source/WebKit/chromium: [Chromium] Ignore punctuation in spellcheck
https://bugs.webkit.org/show_bug.cgi?id=108511

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
Reviewed by Tony Chang.

* src/ContextMenuClientImpl.cpp:
(WebKit::IsWhiteSpaceOrPunctuation): Added utility function to detect whitespace or punctuation.
(WebKit::selectMisspellingAsync): Ignore punctuation when selecting the misspelling.

LayoutTests: [Chromium] Expect spellcheck to ignore punctuation
https://bugs.webkit.org/show_bug.cgi?id=108511

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
Reviewed by Tony Chang.

* platform/chromium/TestExpectations: Expect spellcheck to ignore punctuation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClean up calls to DatabaseTracker::add/removeOpenDatabase().
mark.lam@apple.com [Fri, 1 Feb 2013 23:03:33 +0000 (23:03 +0000)]
Clean up calls to DatabaseTracker::add/removeOpenDatabase().
https://bugs.webkit.org/show_bug.cgi?id=108431

Reviewed by Geoffrey Garen.

Also adapted the chromium port to work with this new code.
Chromium parts reviewed by Michael Nordman and David Levin.

This is part of the webdatabase refactoring effort.

No new tests.

* Modules/webdatabase/AbstractDatabaseServer.h:
(AbstractDatabaseServer):
* Modules/webdatabase/Database.cpp:
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::close):
* Modules/webdatabase/DatabaseBackend.cpp:
(WebCore::DatabaseBackend::DatabaseBackend):
(WebCore::DatabaseBackend::closeDatabase):
(DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
(WebCore::DatabaseBackend::performOpenAndVerify):
* Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):
* Modules/webdatabase/DatabaseManager.h:
(DatabaseManager):
* Modules/webdatabase/DatabaseServer.cpp:
* Modules/webdatabase/DatabaseServer.h:
* Modules/webdatabase/DatabaseSync.cpp:
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::openAndVerifyVersion):
(WebCore::DatabaseSync::closeImmediately):
* Modules/webdatabase/DatabaseSync.h:
(DatabaseSync):
* Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::addOpenDatabase):
* Modules/webdatabase/DatabaseTracker.h:
(DatabaseTracker):
* Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::prepareToOpenDatabase):
(WebCore::DatabaseTracker::failedToOpenDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMore work on UI side storage
andersca@apple.com [Fri, 1 Feb 2013 22:56:20 +0000 (22:56 +0000)]
More work on UI side storage
https://bugs.webkit.org/show_bug.cgi?id=108700

Reviewed by Sam Weinig.

* DerivedSources.make:
Add StorageManager.messages.in.

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
Add new overload.

* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::didReceiveMessageOnConnectionWorkQueue):
Call the right function.

(WebKit::StorageManager::createStorageArea):
(WebKit::StorageManager::destroyStorageArea):
Add stubs.

* UIProcess/Storage/StorageManager.messages.in: Added.
Add new messages files.

* WebKit2.xcodeproj/project.pbxproj:
Add new files.

* WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::~StorageAreaProxy):
Add another FIXME.

(WebKit::StorageAreaProxy::canAccessStorage):
(WebKit::StorageAreaProxy::incrementAccessCount):
(WebKit::StorageAreaProxy::decrementAccessCount):
Implement these.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: remove extra padding around overlay highlight.
commit-queue@webkit.org [Fri, 1 Feb 2013 22:55:51 +0000 (22:55 +0000)]
Web Inspector: remove extra padding around overlay highlight.
https://bugs.webkit.org/show_bug.cgi?id=108679

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-01
Reviewed by Alexander Pavlov.

Source/WebCore:

No new tests: no change in behaviour.

Remove extraWidth from overlay highlight spans.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):

LayoutTests:

Update layout test expectations to correspond to updated overlay highlight style.

* inspector/editor/text-editor-highlight-api-expected.txt:
* inspector/editor/text-editor-highlight-token-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAllow prettify.rb to be run from any directory, and don't hard-code the system ruby...
commit-queue@webkit.org [Fri, 1 Feb 2013 22:46:16 +0000 (22:46 +0000)]
Allow prettify.rb to be run from any directory, and don't hard-code the system ruby path
https://bugs.webkit.org/show_bug.cgi?id=108569

Patch by Nathan de Vries <ndevries@apple.com> on 2013-02-01
Reviewed by Joseph Pecoraro.

* PrettyPatch/prettify.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrevent skipped repaints for children of inner SVG elements
pdr@google.com [Fri, 1 Feb 2013 22:38:50 +0000 (22:38 +0000)]
Prevent skipped repaints for children of inner SVG elements
https://bugs.webkit.org/show_bug.cgi?id=108429

Reviewed by Eric Seidel.

Source/WebCore:

This patch fixes a bug caused by r108699 and r133786 where we would not repaint children
of inner SVG elements because "m_didTransformToRootUpdate" was never reset on viewport
containers. The stale m_didTransformToRootUpdate variable caused us to skip child repaints.

I verified that the Robohornet SVG benchmark performance gains in r133786 are not regressed
with this patch.

Test: svg/repaint/svgsvgelement-repaint-children.html

* rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::calcViewport):

    This can be removed because setNeedsTransformUpdate() will set m_needsTransformUpdate.

(WebCore::RenderSVGViewportContainer::calculateLocalTransform):

    This change is straightforward and is similar to the equivalent assignment in
    RenderSVGTransformableContainer::calculateLocalTransform().

LayoutTests:

Need to update expectations for a single file (just a 1px difference).

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* svg/repaint/svgsvgelement-repaint-children-expected.png: Added.
* svg/repaint/svgsvgelement-repaint-children-expected.txt: Added.
* svg/repaint/svgsvgelement-repaint-children.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening of two svg/zoom/page tests.
pdr@google.com [Fri, 1 Feb 2013 22:24:05 +0000 (22:24 +0000)]
[Chromium] Unreviewed gardening of two svg/zoom/page tests.

This change rebaselines two tests for WK108108.

Unreviewed update of test expectations.

* platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix webkitpy tests since a build_style is not specified in some cases.
roger_fong@apple.com [Fri, 1 Feb 2013 22:10:40 +0000 (22:10 +0000)]
Unreviewed. Fix webkitpy tests since a build_style is not specified in some cases.

* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
fmalita@chromium.org [Fri, 1 Feb 2013 22:00:08 +0000 (22:00 +0000)]
[Chromium] Unreviewed gardening.

Skip a test added in r14618 that uses setAutomaticLinkDetectionEnabled.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoofflineasm BaseIndex handling is broken on ARM due to MIPS changes
commit-queue@webkit.org [Fri, 1 Feb 2013 22:00:00 +0000 (22:00 +0000)]
offlineasm BaseIndex handling is broken on ARM due to MIPS changes
https://bugs.webkit.org/show_bug.cgi?id=108261

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-02-01
Reviewed by Filip Pizlo.

offlineasm BaseIndex handling fix on MIPS.

* offlineasm/mips.rb:
* offlineasm/risc.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] [WK2] Fix build after r141619
caio.oliveira@openbossa.org [Fri, 1 Feb 2013 21:56:29 +0000 (21:56 +0000)]
[Gtk] [WK2] Fix build after r141619
https://bugs.webkit.org/show_bug.cgi?id=108687

Reviewed by Benjamin Poulain.

Take a reference instead of a pointer for decoding functions.

* Platform/gtk/SharedMemoryGtk.cpp:
(WebKit::SharedMemory::Handle::decode):
* Shared/gtk/ArgumentCodersGtk.cpp:
(CoreIPC::decodeImage):
(CoreIPC::decodeDataObject):
(CoreIPC::::decode):
(CoreIPC::decodeGKeyFile):
(CoreIPC::decode):
* Shared/gtk/ArgumentCodersGtk.h:
* Shared/gtk/LayerTreeContextGtk.cpp:
(WebKit::LayerTreeContext::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] [WK2] Fix build after r141619
caio.oliveira@openbossa.org [Fri, 1 Feb 2013 21:40:29 +0000 (21:40 +0000)]
[EFL] [WK2] Fix build after r141619
https://bugs.webkit.org/show_bug.cgi?id=108683

Reviewed by Benjamin Poulain.

Take a reference instead of a pointer for decoding functions.

* Shared/WebBatteryStatus.cpp:
(WebKit::WebBatteryStatus::Data::decode):
* Shared/WebBatteryStatus.h:
(Data):
* Shared/WebNetworkInfo.cpp:
(WebKit::WebNetworkInfo::Data::decode):
* Shared/WebNetworkInfo.h:
(Data):
* Shared/cairo/LayerTreeContextCairo.cpp:
(WebKit::LayerTreeContext::decode):
* Shared/efl/LayerTreeContextEfl.cpp:
(WebKit::LayerTreeContext::decode):
* Shared/soup/PlatformCertificateInfo.cpp:
(WebKit::PlatformCertificateInfo::decode):
* Shared/soup/PlatformCertificateInfo.h:
(PlatformCertificateInfo):
* Shared/soup/WebCoreArgumentCodersSoup.cpp:
(CoreIPC::::decodePlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Layout test fast/parser/parser-yield-timing.html is flaky on debug bots
commit-queue@webkit.org [Fri, 1 Feb 2013 21:34:01 +0000 (21:34 +0000)]
[Mac] Layout test fast/parser/parser-yield-timing.html is flaky on debug bots
https://bugs.webkit.org/show_bug.cgi?id=108677

Patch by David Farler <dfarler@apple.com> on 2013-02-01
Reviewed by Tim Horton.

* platform/mac/TestExpectations:
Mark fast/parser/parser-yield-timing.html as [ Pass Failure ]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange hasAlpha to isKnownToBeOpaque and correct the return value for SVG images.
pdr@google.com [Fri, 1 Feb 2013 21:31:00 +0000 (21:31 +0000)]
Change hasAlpha to isKnownToBeOpaque and correct the return value for SVG images.
https://bugs.webkit.org/show_bug.cgi?id=106966

Reviewed by Stephen White.

Source/WebCore:

Previously, Image::currentFrameHasAlpha's default implementation returned false so SVG
images always returned false for currentFrameHasAlpha. Additionally, currentFrameHasAlpha
was treated as returning whether the frame had alpha when it would actually conservatively
return true.

This patch renames hasAlpha and currentFrameHasAlpha to isKnownToBeOpaque and
currentFrameIsKnownToBeOpaque, respectively. This rename better describes the actual
functionality. This patch also makes Image::isKnownToBeOpaque a pure virtual function and
correctly implements it for SVG images.

All users of isKnownToBeOpaque access SVG images using CachedImage::imageForRenderer which
currently returns a cached bitmap image. Therefore, this patch will not affect existing
functionality. A regression test has been added that will catch if this changes in the
future (e.g., WK106159 which proposes not returning cached bitmaps). The now unnecessary
isBitmapImage() calls have been removed in this patch.

image-box-shadow.html has been modified to test SVG images.

* css/CSSCrossfadeValue.cpp:
(WebCore::subimageKnownToBeOpaque):
(WebCore::CSSCrossfadeValue::knownToBeOpaque):

    Mostly straightforward rename but note the logic has been slightly altered: AND -> OR.

* css/CSSCrossfadeValue.h:
(CSSCrossfadeValue):
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::knownToBeOpaque):
* css/CSSGradientValue.h:
(CSSGradientValue):
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::knownToBeOpaque):
* css/CSSImageGeneratorValue.h:
(CSSImageGeneratorValue):
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::knownToBeOpaque):
* css/CSSImageValue.h:
(CSSImageValue):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::currentFrameKnownToBeOpaque):
* loader/cache/CachedImage.h:
(CachedImage):
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::currentFrameKnownToBeOpaque):
* platform/graphics/BitmapImage.h:
(BitmapImage):
* platform/graphics/GeneratedImage.h:
(GeneratedImage):
* platform/graphics/Image.h:

    Note: now a pure virtual function!

(Image):
* platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::updateTextureContentsIfNeeded):

    Removed unnecessary isBitmapImage() checks.

* platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

    Removed unnecessary isBitmapImage() checks.

* platform/graphics/cg/PDFDocumentImage.h:
(PDFDocumentImage):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:

    Removed unnecessary isBitmapImage() checks.

(WebCore::GraphicsLayerChromium::setContentsToImage):
* platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::currentFrameKnownToBeOpaque):
* platform/graphics/qt/StillImageQt.h:
(StillImage):
* platform/graphics/skia/BitmapImageSingleFrameSkia.cpp:
(WebCore::BitmapImageSingleFrameSkia::currentFrameKnownToBeOpaque):
* platform/graphics/skia/BitmapImageSingleFrameSkia.h:
(BitmapImageSingleFrameSkia):
* platform/graphics/texmap/TextureMapperBackingStore.cpp:
(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTiledBackingStore::updateContents):
* platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
(WebCore::CoordinatedImageBacking::update):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::backgroundIsObscured):

    Removed unnecessary isBitmapImage() checks and slightly reworked the logic.

* rendering/style/FillLayer.cpp:
(WebCore::FillLayer::hasOpaqueImage):
* rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::knownToBeOpaque):
* rendering/style/StyleCachedImage.h:
(StyleCachedImage):
* rendering/style/StyleCachedImageSet.cpp:
(WebCore::StyleCachedImageSet::knownToBeOpaque):
* rendering/style/StyleCachedImageSet.h:
(StyleCachedImageSet):
* rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::knownToBeOpaque):
* rendering/style/StyleGeneratedImage.h:
(StyleGeneratedImage):
* rendering/style/StyleImage.h:
(StyleImage):
* rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::knownToBeOpaque):
* svg/graphics/SVGImage.h:
(SVGImage):

Source/WebKit/chromium:

* tests/DragImageTest.cpp:
(WebCore::TestImage::currentFrameKnownToBeOpaque):
(TestImage):
* tests/ImageLayerChromiumTest.cpp:
(WebCore::TestImage::currentFrameKnownToBeOpaque):
* tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):

Source/WebKit/win:

* WebKit.vcproj/WebKitExports.def.in:

LayoutTests:

An SVG image has been added to this test to check for regressions.

* fast/box-shadow/image-box-shadow-expected.html:
* fast/box-shadow/image-box-shadow.html:

    Add an SVG image and correct a small mistake in the test that used values of 256
    instead of 255.

* fast/box-shadow/resources/green.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK TestExpectations update.
philn@webkit.org [Fri, 1 Feb 2013 21:26:26 +0000 (21:26 +0000)]
Unreviewed, GTK TestExpectations update.

* platform/gtk/TestExpectations: Flag some new media tests
crashing until a fix is figured out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClean up WebArchive loading with the NetworkProcess
beidson@apple.com [Fri, 1 Feb 2013 21:18:43 +0000 (21:18 +0000)]
Clean up WebArchive loading with the NetworkProcess
<rdar://problem/12695840> and https://bugs.webkit.org/show_bug.cgi?id=108673

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests (No change in WebCore behavior).

Remove a now unneeded function and add a needed export.

* WebCore.exp.in:
* loader/ResourceLoadScheduler.cpp:
* loader/ResourceLoadScheduler.h:

Source/WebKit2:

* NetworkProcess/HostRecord.cpp:
(WebKit::HostRecord::servePendingRequestsForQueue):  Add new logging.
(WebKit::HostRecord::servePendingRequests): Tweak existing logging.

* NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::servePendingRequests): Tweak existing logging.

* WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad): Handle archive resource scheduling better,
  and add new logging to better explore archive loading behavior in the future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrint GraphicsLayer::m_contentsOpaque if non-default (true)
alokp@chromium.org [Fri, 1 Feb 2013 21:16:42 +0000 (21:16 +0000)]
Print GraphicsLayer::m_contentsOpaque if non-default (true)
https://bugs.webkit.org/show_bug.cgi?id=108354

Reviewed by Simon Fraser.

Source/WebCore:

No new tests. This change facilitates testing of GraphicsLayer opaqueness.

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties):

LayoutTests:

* compositing/absolute-inside-out-of-view-fixed-expected.txt:
* compositing/backing/no-backing-for-clip-expected.txt:
* compositing/backing/no-backing-for-clip-overlap-expected.txt:
* compositing/backing/no-backing-for-perspective-expected.txt:
* compositing/bounds-in-flipped-writing-mode-expected.txt:
* compositing/clip-child-by-non-stacking-ancestor-expected.txt:
* compositing/columns/composited-in-paginated-expected.txt:
* compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
* compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt:
* compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
* compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
* compositing/geometry/ancestor-overflow-change-expected.txt:
* compositing/geometry/bounds-clipped-composited-child-expected.txt:
* compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
* compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt:
* compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
* compositing/geometry/bounds-ignores-hidden-expected.txt:
* compositing/geometry/clip-expected.txt:
* compositing/geometry/clip-inside-expected.txt:
* compositing/geometry/composited-in-columns-expected.txt:
* compositing/geometry/fixed-position-composited-switch-expected.txt:
* compositing/geometry/flipped-writing-mode-expected.txt:
* compositing/geometry/foreground-layer-expected.txt:
* compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
* compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
* compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
* compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
* compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
* compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
* compositing/geometry/limit-layer-bounds-positioned-expected.txt:
* compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
* compositing/geometry/limit-layer-bounds-transformed-expected.txt:
* compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
* compositing/geometry/preserve-3d-switching-expected.txt:
* compositing/iframes/become-composited-nested-iframes-expected.txt:
* compositing/iframes/become-overlapped-iframe-expected.txt:
* compositing/iframes/composited-parent-iframe-expected.txt:
* compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
* compositing/iframes/connect-compositing-iframe-expected.txt:
* compositing/iframes/connect-compositing-iframe2-expected.txt:
* compositing/iframes/connect-compositing-iframe3-expected.txt:
* compositing/iframes/enter-compositing-iframe-expected.txt:
* compositing/iframes/iframe-resize-expected.txt:
* compositing/iframes/iframe-size-from-zero-expected.txt:
* compositing/iframes/invisible-nested-iframe-hide-expected.txt:
* compositing/iframes/invisible-nested-iframe-show-expected.txt:
* compositing/iframes/overlapped-iframe-expected.txt:
* compositing/iframes/overlapped-iframe-iframe-expected.txt:
* compositing/iframes/overlapped-nested-iframes-expected.txt:
* compositing/iframes/page-cache-layer-tree-expected.txt:
* compositing/iframes/scrolling-iframe-expected.txt:
* compositing/images/clip-on-directly-composited-image-expected.txt:
* compositing/layer-creation/animation-overlap-with-children-expected.txt:
* compositing/layer-creation/fixed-position-and-transform-expected.txt:
* compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
* compositing/layer-creation/fixed-position-out-of-view-expected.txt:
* compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
* compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
* compositing/layer-creation/fixed-position-under-transform-expected.txt:
* compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt:
* compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
* compositing/layer-creation/overflow-scroll-overlap-expected.txt:
* compositing/layer-creation/overlap-animation-clipping-expected.txt:
* compositing/layer-creation/overlap-animation-container-expected.txt:
* compositing/layer-creation/overlap-animation-expected.txt:
* compositing/layer-creation/overlap-child-layer-expected.txt:
* compositing/layer-creation/overlap-clipping-expected.txt:
* compositing/layer-creation/overlap-transformed-3d-expected.txt:
* compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
* compositing/layer-creation/overlap-transformed-layer-expected.txt:
* compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
* compositing/layer-creation/overlap-transforms-expected.txt:
* compositing/layer-creation/rotate3d-overlap-expected.txt:
* compositing/layer-creation/scroll-partial-update-expected.txt:
* compositing/layer-creation/spanOverlapsCanvas-expected.txt:
* compositing/layer-creation/stacking-context-overlap-expected.txt:
* compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
* compositing/layer-creation/translatez-overlap-expected.txt:
* compositing/masks/mask-layer-size-expected.txt:
* compositing/overflow-trumps-transform-style-expected.txt:
* compositing/overflow/clip-descendents-expected.txt:
* compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
* compositing/overflow/content-gains-scrollbars-expected.txt:
* compositing/overflow/content-loses-scrollbars-expected.txt:
* compositing/overflow/overflow-auto-with-touch-expected.txt:
* compositing/overflow/overflow-auto-with-touch-toggle-expected.txt:
* compositing/overflow/overflow-overlay-with-touch-expected.txt:
* compositing/overflow/overflow-scrollbar-layers-expected.txt:
* compositing/overflow/resize-painting-expected.txt:
* compositing/overflow/scrolling-content-clip-to-viewport-expected.txt:
* compositing/overflow/scrolling-without-painting-expected.txt:
* compositing/overflow/textarea-scroll-touch-expected.txt:
* compositing/overflow/updating-scrolling-content-expected.txt:
* compositing/plugins/no-backing-store-expected.txt:
* compositing/plugins/small-to-large-composited-plugin-expected.txt:
* compositing/repaint/invalidations-on-composited-layers-expected.txt:
* compositing/repaint/resize-repaint-expected.txt:
* compositing/rtl/rtl-absolute-expected.txt:
* compositing/rtl/rtl-absolute-overflow-expected.txt:
* compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
* compositing/rtl/rtl-fixed-expected.txt:
* compositing/rtl/rtl-fixed-overflow-expected.txt:
* compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
* compositing/rtl/rtl-iframe-absolute-expected.txt:
* compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
* compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
* compositing/rtl/rtl-iframe-fixed-expected.txt:
* compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
* compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
* compositing/rtl/rtl-iframe-relative-expected.txt:
* compositing/rtl/rtl-relative-expected.txt:
* compositing/tiled-layers-hidpi-expected.txt:
* compositing/tiling/backface-preserve-3d-tiled-expected.txt:
* compositing/tiling/crash-reparent-tiled-layer-expected.txt:
* compositing/tiling/huge-layer-add-remove-child-expected.txt:
* compositing/tiling/huge-layer-expected.txt:
* compositing/tiling/huge-layer-img-expected.txt:
* compositing/tiling/huge-layer-resize-expected.txt:
* compositing/tiling/huge-layer-with-layer-children-expected.txt:
* compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
* compositing/tiling/rotated-tiled-clamped-expected.txt:
* compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
* compositing/tiling/tile-cache-zoomed-expected.txt:
* compositing/tiling/tiled-layer-resize-expected.txt:
* compositing/visibility/layer-visible-content-expected.txt:
* compositing/visibility/visibility-image-layers-dynamic-expected.txt:
* compositing/visible-rect/2d-transformed-expected.txt:
* compositing/visible-rect/3d-transform-style-expected.txt:
* compositing/visible-rect/3d-transformed-expected.txt:
* compositing/visible-rect/animated-expected.txt:
* compositing/visible-rect/animated-from-none-expected.txt:
* compositing/visible-rect/clipped-by-viewport-expected.txt:
* compositing/visible-rect/clipped-visible-rect-expected.txt:
* compositing/visible-rect/iframe-and-layers-expected.txt:
* compositing/visible-rect/iframe-no-layers-expected.txt:
* compositing/visible-rect/nested-transform-expected.txt:
* compositing/visible-rect/scrolled-expected.txt:
* css3/compositing/should-have-compositing-layer-expected.txt:
* css3/filters/filtered-compositing-descendant-expected.txt:
* platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt:
* platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
* platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
* platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
* platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
* platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
* platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
* platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
* platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
* platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
* platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
* platform/chromium-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
* platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
* platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
* platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
* platform/chromium-mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
* platform/chromium-mac/css3/filters/composited-during-animation-layertree-expected.txt:
* platform/chromium-mac/css3/filters/composited-during-transition-layertree-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
* platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
* platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
* platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
* platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
* platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
* platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
* platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt:
* platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt:
* platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt:
* platform/chromium-win/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
* platform/chromium-win/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
* platform/chromium-win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
* platform/chromium-win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
* platform/chromium-win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
* platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
* platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
* platform/chromium-win/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
* platform/chromium-win/compositing/layer-creation/scroll-partial-update-expected.txt:
* platform/chromium-win/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
* platform/chromium-win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
* platform/chromium-win/compositing/tiling/huge-layer-expected.txt:
* platform/chromium-win/compositing/tiling/huge-layer-resize-expected.txt:
* platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-expected.txt:
* platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
* platform/chromium-win/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
* platform/chromium-win/css3/filters/composited-during-animation-layertree-expected.txt:
* platform/chromium-win/css3/filters/composited-during-transition-layertree-expected.txt:
* platform/chromium/TestExpectations:
* platform/chromium/compositing/backing/no-backing-for-clip-expected.txt:
* platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt:
* platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt:
* platform/chromium/compositing/canvas/accelerated-canvas-compositing-expected.txt:
* platform/chromium/compositing/columns/composited-in-paginated-expected.txt:
* platform/chromium/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
* platform/chromium/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
* platform/chromium/compositing/force-compositing-mode/force-composite-empty-expected.txt:
* platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer-expected.txt:
* platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer-expected.txt:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing-expected.txt:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer-expected.txt:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing-expected.txt:
* platform/chromium/compositing/geometry/ancestor-overflow-change-expected.txt:
* platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
* platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
* platform/chromium/compositing/geometry/clip-expected.txt:
* platform/chromium/compositing/geometry/clip-inside-expected.txt:
* platform/chromium/compositing/geometry/composited-in-columns-expected.txt:
* platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt:
* platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt:
* platform/chromium/compositing/geometry/foreground-layer-expected.txt:
* platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
* platform/chromium/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
* platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
* platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt:
* platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
* platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt:
* platform/chromium/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
* platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt:
* platform/chromium/compositing/iframes/become-composited-nested-iframes-expected.txt:
* platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt:
* platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt:
* platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
* platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt:
* platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt:
* platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt:
* platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt:
* platform/chromium/compositing/iframes/iframe-resize-expected.txt:
* platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt:
* platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt:
* platform/chromium/compositing/iframes/overlapped-iframe-expected.txt:
* platform/chromium/compositing/iframes/overlapped-iframe-iframe-expected.txt:
* platform/chromium/compositing/iframes/overlapped-nested-iframes-expected.txt:
* platform/chromium/compositing/iframes/resizer-expected.txt:
* platform/chromium/compositing/iframes/scrolling-iframe-expected.txt:
* platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt:
* platform/chromium/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
* platform/chromium/compositing/layer-creation/fixed-position-out-of-view-expected.txt:
* platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
* platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
* platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt:
* platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
* platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt:
* platform/chromium/compositing/layer-creation/overlap-animation-clipping-expected.txt:
* platform/chromium/compositing/layer-creation/overlap-animation-container-expected.txt:
* platform/chromium/compositing/layer-creation/overlap-animation-expected.txt:
* platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt:
* platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt:
* platform/chromium/compositing/layer-creation/overlap-transformed-3d-expected.txt:
* platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
* platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt:
* platform/chromium/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
* platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt:
* platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt:
* platform/chromium/compositing/layer-creation/spanOverlapsCanvas-expected.txt:
* platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt:
* platform/chromium/compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
* platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt:
* platform/chromium/compositing/overflow-trumps-transform-style-expected.txt:
* platform/chromium/compositing/overflow/clip-descendents-expected.txt:
* platform/chromium/compositing/overflow/content-gains-scrollbars-expected.txt:
* platform/chromium/compositing/overflow/content-loses-scrollbars-expected.txt:
* platform/chromium/compositing/overflow/overflow-scrollbar-layers-expected.txt:
* platform/chromium/compositing/overflow/resize-painting-expected.txt:
* platform/chromium/compositing/rtl/rtl-absolute-expected.txt:
* platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt:
* platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
* platform/chromium/compositing/rtl/rtl-fixed-expected.txt:
* platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt:
* platform/chromium/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
* platform/chromium/compositing/rtl/rtl-iframe-absolute-expected.txt:
* platform/chromium/compositing/rtl/rtl-iframe-fixed-expected.txt:
* platform/chromium/compositing/rtl/rtl-iframe-relative-expected.txt:
* platform/chromium/compositing/rtl/rtl-relative-expected.txt:
* platform/chromium/compositing/tiling/huge-layer-img-expected.txt:
* platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt:
* platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/content-gains-scrollbars-expected.txt:
* platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt:
* platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-scrollbar-layers-expected.txt:
* platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/resize-painting-expected.txt:
* platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
* platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt:
* platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
* platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
* platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/content-gains-scrollbars-expected.txt:
* platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/overflow-scrollbar-layers-expected.txt:
* platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/resize-painting-expected.txt:
* platform/efl/compositing/geometry/foreground-layer-expected.txt:
* platform/efl/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
* platform/efl/compositing/repaint/invalidations-on-composited-layers-expected.txt:
* platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
* platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
* platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt:
* platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt:
* platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
* platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
* platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
* platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
* platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt:
* platform/mac/TestExpectations:
* platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt:
* platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt:
* platform/mac/compositing/iframes/resizer-expected.txt:
* platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
* platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
* platform/mac/compositing/tiling/backface-preserve-3d-tiled-expected.txt:
* platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
* platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
* platform/mac/compositing/tiling/huge-layer-expected.txt:
* platform/mac/compositing/tiling/huge-layer-img-expected.txt:
* platform/mac/compositing/tiling/huge-layer-resize-expected.txt:
* platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
* platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
* platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
* platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
* platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
* platform/mac/compositing/tiling/tiled-layer-resize-expected.txt:
* platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
* platform/mac/css3/filters/composited-during-animation-layertree-expected.txt:
* platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
* platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/leave-compositing-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
* platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
* platform/qt-5.0-wk2/compositing/overflow/content-gains-scrollbars-expected.txt:
* platform/qt-5.0-wk2/compositing/overflow/overflow-scrollbar-layers-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
* platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
* platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
* platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt:
* platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt:
* platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
* platform/qt-5.0-wk2/css3/filters/composited-during-animation-layertree-expected.txt:
* platform/qt/compositing/backing/no-backing-for-clip-expected.txt:
* platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
* platform/qt/compositing/backing/no-backing-for-perspective-expected.txt:
* platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
* platform/qt/compositing/iframes/invisible-nested-iframe-show-expected.txt:
* platform/qt/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
* platform/qt/compositing/layer-creation/overlap-animation-container-expected.txt:
* platform/qt/compositing/overflow/clip-descendents-expected.txt:
* platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
* platform/qt/css3/compositing/should-have-compositing-layer-expected.txt:
* platform/qt/css3/filters/composited-during-transition-layertree-expected.txt:
* platform/win/compositing/iframes/composited-iframe-expected.txt:
* platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
* platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
* platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
* platform/win/compositing/tiling/rotated-tiled-clamped-expected.txt:
* platform/win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoContinue making XSSAuditor thread safe: Remove dependency on parser's Document URL
tonyg@chromium.org [Fri, 1 Feb 2013 21:13:32 +0000 (21:13 +0000)]
Continue making XSSAuditor thread safe: Remove dependency on parser's Document URL
https://bugs.webkit.org/show_bug.cgi?id=108655

Reviewed by Adam Barth.

No new tests because no new functionality.

* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::isLikelySafeResource):
* html/parser/XSSAuditor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] [WK2] Fix build after r141619
caio.oliveira@openbossa.org [Fri, 1 Feb 2013 21:08:31 +0000 (21:08 +0000)]
[Qt] [WK2] Fix build after r141619
https://bugs.webkit.org/show_bug.cgi?id=108680

Reviewed by Benjamin Poulain.

Take a reference instead of a pointer for decoding functions.

* Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::Handle::decode):
* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::decode):
(CoreIPC::decodeTimingFunction):
* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
* Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::Handle::decode):
* Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
(Handle):
* Shared/qt/ArgumentCodersQt.cpp:
(CoreIPC::::decode):
* Shared/qt/ArgumentCodersQt.h:
(CoreIPC):
* Shared/qt/LayerTreeContextQt.cpp:
(WebKit::LayerTreeContext::decode):
* Shared/qt/PlatformCertificateInfo.h:
(WebKit::PlatformCertificateInfo::decode):
* Shared/qt/QtNetworkReplyData.cpp:
(WebKit::QtNetworkReplyData::decode):
* Shared/qt/QtNetworkReplyData.h:
(QtNetworkReplyData):
* Shared/qt/QtNetworkRequestData.cpp:
(WebKit::QtNetworkRequestData::decode):
* Shared/qt/QtNetworkRequestData.h:
(QtNetworkRequestData):
* Shared/qt/WebCoreArgumentCodersQt.cpp:
(CoreIPC::::decodePlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Re-try enabling Win-EWS tests for the third time.
roger_fong@apple.com [Fri, 1 Feb 2013 20:46:26 +0000 (20:46 +0000)]
Unreviewed. Re-try enabling Win-EWS tests for the third time.
https://bugs.webkit.org/show_bug.cgi?id=107968

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r141281): Navigating to this HTTP Live Streaming (application/vnd.apple...
jer.noble@apple.com [Fri, 1 Feb 2013 20:44:28 +0000 (20:44 +0000)]
REGRESSION (r141281): Navigating to this HTTP Live Streaming (application/vnd.apple.mpegurl) URL downloads a file instead of playing it in the browser
https://bugs.webkit.org/show_bug.cgi?id=108674
<rdar://problem/13133595>

Reviewed by Eric Carlson.

When passed a HashSet of available MIME types to fill out, QTKit was overwriting the contents, which were
AVFoundation's supported types. Instead, it should be appending to the list of supported types.

* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::concatenateHashSets): Added static utility function.
(WebCore::MediaPlayerPrivateQTKit::getSupportedTypes): Concatenate instead of overwriting the passed in MIME types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Skip more test in preparation for Win EWS bots (round 2).
roger_fong@apple.com [Fri, 1 Feb 2013 20:43:23 +0000 (20:43 +0000)]
Unreviewed. Skip more test in preparation for Win EWS bots (round 2).
https://bugs.webkit.org/show_bug.cgi?id=108249

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix test scripts for EWS bots to get them running once and for all.
roger_fong@apple.com [Fri, 1 Feb 2013 20:36:30 +0000 (20:36 +0000)]
Fix test scripts for EWS bots to get them running once and for all.
https://bugs.webkit.org/show_bug.cgi?id=108422

Reviewed by Timothy Horton.

Disabling --quiet option on Windows for now because that fails when we try to use /dev/null.
runtests.py was not passing in a configuration to run-webkit-tests which causes DRT to build in release by default.
However, we build in Debug only on the EWS Windows bots, which caused the build to fail.

* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.options):
(RunTests.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWTR needs an implementation of setAutomaticLinkDetectionEnabled
jberlin@webkit.org [Fri, 1 Feb 2013 20:27:05 +0000 (20:27 +0000)]
WTR needs an implementation of setAutomaticLinkDetectionEnabled
https://bugs.webkit.org/show_bug.cgi?id=87162

Skip a test on wk2 added in r14618 that uses setAutomaticLinkDetectionEnabled.

* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Zooming in during page load of non-scalable webpage results in fixed...
zhajiang@rim.com [Fri, 1 Feb 2013 20:21:02 +0000 (20:21 +0000)]
[BlackBerry] Zooming in during page load of non-scalable webpage results in fixed magnification
https://bugs.webkit.org/show_bug.cgi?id=108252

Patch by Jacky Jiang  <zhajiang@rim.com>.
Reviewed by Yong Li.
Internally reviewed by Konrad Piascik.

PR: 284828
We got float layoutSize(342.284122, 521.448467) and
m_maximumScale(2.243750) after computing viewport meta based on the
device pixel ratio and laid out the contents at IntSize(342, 521).
Therefore, zoomToFitScale(2.245681) would be a bit larger than
m_maximumScale based on that contents size and resulted in
maximumScale()!=minimumScale(), which made the non-scalable page
scalable.
Return zoomToFitScale for maximumScale() in such kind of case.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::maximumScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother speculative windows build fix.
bdakin@apple.com [Fri, 1 Feb 2013 20:13:45 +0000 (20:13 +0000)]
Another speculative windows build fix.

* platform/ScrollAnimator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[canvas] Add more constructors to Path
krit@webkit.org [Fri, 1 Feb 2013 20:11:41 +0000 (20:11 +0000)]
[canvas] Add more constructors to Path
https://bugs.webkit.org/show_bug.cgi?id=108587

Patch by Dirk Schulze <krit@webkit.org> on 2013-01-31
Reviewed by Dean Jackson.

Source/WebCore:

Add more constructors to Path object to make it possible
to copy Path objects and parse SVG strings into a Path
object that can be used on the canvas context afterwards.

Test: fast/canvas/canvas-path-constructors.html

* html/canvas/DOMPath.h: New constructors for Path.
(WebCore::DOMPath::create):
(WebCore::DOMPath::DOMPath):
* html/canvas/DOMPath.idl: Ditto.

LayoutTests:

Add tests for new constructors of Path objects.
Since the feature is behind a flag, the test is skipped on
all platforms for now.

* fast/canvas/canvas-path-constructors-expected.txt: Added.
* fast/canvas/canvas-path-constructors.html: Added.
* fast/canvas/script-tests/canvas-path-constructors.js: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] InputHandler status is not restored when page history goes back
commit-queue@webkit.org [Fri, 1 Feb 2013 20:11:15 +0000 (20:11 +0000)]
[BlackBerry] InputHandler status is not restored when page history goes back
https://bugs.webkit.org/show_bug.cgi?id=108448

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2013-02-01
Reviewed by Yong Li.

PR288406 Internally reviewed by Mike Fenton

When webpage goes back, it restores the old frame's selection and focused node,
but we don't save the InputHandler's status, it becomes non-input mode when page
goes back. When it restores the focus, since the new focus node is same as the old
document focused node, webcore will not notify client to update the input handler.

This patch updates the input handler's status by notifying it focus node changed.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::restoreViewState):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::restoreViewState):
(WebKit):
* WebKitSupport/InputHandler.h:
(InputHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add WTFURL source files to the build
zandobersek@gmail.com [Fri, 1 Feb 2013 20:06:55 +0000 (20:06 +0000)]
[GTK] Add WTFURL source files to the build
https://bugs.webkit.org/show_bug.cgi?id=108215

Reviewed by Benjamin Poulain.

.:

* Source/autotools/symbols.filter: Force the export of the KURL::string() symbol.
This is required when using the WTFURL backend but otherwise doesn't affect the build.

Source/WebCore:

* platform/KURLWTFURL.cpp:
(WebCore): Only use the stub implementation of the fileSystemPath method for the
Apple ports, other ports should for now still rely on their platform-specific implementations.

Source/WTF:

The WTFURL implementation sources are all still guarded by the USE(WTFURL) guard,
meaning that the GTK port still uses the default KURL backend. To use the WTFURL
backend instead, one would have to define WTF_USE_WTFURL in Platform.h.

* GNUmakefile.am: List the directories from which source headers will be included.
Plenty of WTFURL code currently just includes the required header by name rather
than specifying the header path as relative to Source/WTF. In the future all the inclusions
should probaby be changed to include the header through the path relative to Source/WTF.
* GNUmakefile.list.am: Add build targets for the WTFURL source files.
* wtf/url/api/ParsedURL.cpp: Specify the complete path to the required headers and
reorder the inclusions.
* wtf/url/src/URLCanon.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove call to SecurityOrigin::canAccessDatabase from IDB constructor.
mkwst@chromium.org [Fri, 1 Feb 2013 19:58:47 +0000 (19:58 +0000)]
Remove call to SecurityOrigin::canAccessDatabase from IDB constructor.
https://bugs.webkit.org/show_bug.cgi?id=108477

Reviewed by Adam Barth.

Source/WebCore:

This change removes the 'SecurityOrigin::canAccessDatabase' check from
the constructor for the 'indexedDB' property on both DOMWindow and
WorkerContext. After the patch for http://wkbug.com/94171 this check
is redundant, as all the entry points to IDB are now gated on access
being granted.

As a side-effect, dropping the check in WorkerContextIndexedDatabase
allows us to stop holding a pointer to the ScriptExecutionContext we're
extending, which can only be a good thing.

The tests in storage/indexeddb should continue to pass.

* Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::indexedDB):
    Drop the SecurityOrigin::canAccessDatabase check.
* Modules/indexeddb/WorkerContextIndexedDatabase.cpp:
(WebCore::WorkerContextIndexedDatabase::WorkerContextIndexedDatabase):
(WebCore::WorkerContextIndexedDatabase::from):
    Drop the ScriptExecutionContext parameter from the class's
    constructor and callsites.
(WebCore::WorkerContextIndexedDatabase::indexedDB):
    Drop the SecurityOrigin::canAccessDatabase check.
* Modules/indexeddb/WorkerContextIndexedDatabase.h:
(WorkerContextIndexedDatabase):
    Drop the stored pointer to ScriptExecutionContext, as we no longer
    need it in ::indexedDB.

LayoutTests:

* http/tests/security/no-indexeddb-from-sandbox-expected.txt:
* http/tests/security/no-indexeddb-from-sandbox.html:
    This test expected the 'webkitIndexedDB' property to be missing
    entirely inside a sandbox. The expectation has been updated to
    expect 'webkitIndexedDB.open()' to throw a SECURITY_ERR.
* platform/efl/TestExpectations:
* platform/mac-snowleopard/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:
    This test was accidentally passing on a variety of platforms that
    don't yet implement IndexedDB. Now that failure is distinguishable
    we should skip it on a variety of platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpeculative Windows build fix.
bdakin@apple.com [Fri, 1 Feb 2013 19:54:03 +0000 (19:54 +0000)]
Speculative Windows build fix.

* platform/ScrollAnimator.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMessage decoding functions should take a MessageDecoder reference
andersca@apple.com [Fri, 1 Feb 2013 19:53:44 +0000 (19:53 +0000)]
Message decoding functions should take a MessageDecoder reference
https://bugs.webkit.org/show_bug.cgi?id=108669

Reviewed by Andreas Kling.

Message encoding functions already take a reference instead of a pointer, so
make the decoding functions take a reference as well.

* Platform/CoreIPC/ArgumentCoder.h:
(CoreIPC::ArgumentCoder::decode):
* Platform/CoreIPC/ArgumentCoders.cpp:
(CoreIPC::::decode):
(CoreIPC::decodeStringText):
* Platform/CoreIPC/ArgumentCoders.h:
(CoreIPC::SimpleArgumentCoder::decode):
* Platform/CoreIPC/ArgumentDecoder.h:
(CoreIPC::ArgumentDecoder::decode):
* Platform/CoreIPC/Arguments.h:
(CoreIPC::Arguments0::decode):
(CoreIPC::Arguments1::decode):
(CoreIPC::Arguments2::decode):
(CoreIPC::Arguments3::decode):
(CoreIPC::Arguments4::decode):
(CoreIPC::Arguments5::decode):
(CoreIPC::Arguments6::decode):
(CoreIPC::Arguments7::decode):
(CoreIPC::Arguments8::decode):
(CoreIPC::Arguments10::decode):
* Platform/CoreIPC/Attachment.cpp:
(CoreIPC::Attachment::decode):
* Platform/CoreIPC/Attachment.h:
(Attachment):
* Platform/CoreIPC/DataReference.cpp:
(CoreIPC::DataReference::decode):
* Platform/CoreIPC/DataReference.h:
(DataReference):
* Platform/CoreIPC/StringReference.cpp:
(CoreIPC::StringReference::decode):
* Platform/CoreIPC/StringReference.h:
(StringReference):
* Platform/CoreIPC/mac/MachPort.h:
(CoreIPC::MachPort::decode):
* Platform/SharedMemory.h:
(Handle):
* Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::Handle::decode):
* PluginProcess/PluginCreationParameters.cpp:
(WebKit::PluginCreationParameters::decode):
* PluginProcess/PluginCreationParameters.h:
(PluginCreationParameters):
* Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::decode):
* Shared/DictionaryPopupInfo.h:
(DictionaryPopupInfo):
* Shared/EditorState.cpp:
(WebKit::EditorState::decode):
* Shared/EditorState.h:
(EditorState):
* Shared/FontInfo.cpp:
(WebKit::FontInfo::decode):
* Shared/FontInfo.h:
(FontInfo):
* Shared/LayerTreeContext.h:
(LayerTreeContext):
* Shared/Network/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::decode):
* Shared/Network/NetworkProcessCreationParameters.h:
(NetworkProcessCreationParameters):
* Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::decode):
* Shared/Network/NetworkResourceLoadParameters.h:
(NetworkResourceLoadParameters):
* Shared/OriginAndDatabases.cpp:
(WebKit::OriginAndDatabases::decode):
* Shared/OriginAndDatabases.h:
(OriginAndDatabases):
* Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::decode):
* Shared/PlatformPopupMenuData.h:
(PlatformPopupMenuData):
* Shared/Plugins/NPIdentifierData.cpp:
(WebKit::NPIdentifierData::decode):
* Shared/Plugins/NPIdentifierData.h:
(NPIdentifierData):
* Shared/Plugins/NPVariantData.cpp:
(WebKit::NPVariantData::decode):
* Shared/Plugins/NPVariantData.h:
(NPVariantData):
* Shared/Plugins/PluginProcessCreationParameters.cpp:
(WebKit::PluginProcessCreationParameters::decode):
* Shared/Plugins/PluginProcessCreationParameters.h:
(PluginProcessCreationParameters):
* Shared/PrintInfo.cpp:
(WebKit::PrintInfo::decode):
* Shared/PrintInfo.h:
(PrintInfo):
* Shared/SandboxExtension.h:
(Handle):
(HandleArray):
(WebKit::SandboxExtension::Handle::decode):
(WebKit::SandboxExtension::HandleArray::decode):
* Shared/SecurityOriginData.cpp:
(WebKit::SecurityOriginData::decode):
* Shared/SecurityOriginData.h:
(SecurityOriginData):
* Shared/SessionState.cpp:
(WebKit::SessionState::decode):
* Shared/SessionState.h:
(SessionState):
* Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::Handle::decode):
* Shared/ShareableBitmap.h:
(Handle):
* Shared/ShareableResource.cpp:
(WebKit::ShareableResource::Handle::decode):
* Shared/ShareableResource.h:
(Handle):
* Shared/SharedWorkerProcessCreationParameters.cpp:
(WebKit::SharedWorkerProcessCreationParameters::decode):
* Shared/SharedWorkerProcessCreationParameters.h:
(SharedWorkerProcessCreationParameters):
* Shared/StatisticsData.cpp:
(WebKit::StatisticsData::decode):
* Shared/StatisticsData.h:
(StatisticsData):
* Shared/StringPairVector.h:
(WebKit::StringPairVector::decode):
* Shared/UpdateInfo.cpp:
(WebKit::UpdateInfo::decode):
* Shared/UpdateInfo.h:
(UpdateInfo):
* Shared/UserMessageCoders.h:
(WebKit::UserMessageDecoder::baseDecode):
* Shared/WebContextMenuItemData.cpp:
(WebKit::WebContextMenuItemData::decode):
* Shared/WebContextMenuItemData.h:
(WebContextMenuItemData):
* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::decode):
(CoreIPC::decodeImage):
* Shared/WebCoreArgumentCoders.h:
* Shared/WebEvent.cpp:
(WebKit::WebEvent::decode):
* Shared/WebEvent.h:
(WebEvent):
(WebMouseEvent):
(WebWheelEvent):
(WebKeyboardEvent):
(WebGestureEvent):
(WebPlatformTouchPoint):
(WebTouchEvent):
* Shared/WebGeolocationPosition.cpp:
(WebKit::WebGeolocationPosition::Data::decode):
* Shared/WebGeolocationPosition.h:
(Data):
* Shared/WebGestureEvent.cpp:
(WebKit::WebGestureEvent::decode):
* Shared/WebHitTestResult.cpp:
(WebKit::WebHitTestResult::Data::decode):
* Shared/WebHitTestResult.h:
(Data):
* Shared/WebKeyboardEvent.cpp:
(WebKit::WebKeyboardEvent::decode):
* Shared/WebMouseEvent.cpp:
(WebKit::WebMouseEvent::decode):
* Shared/WebNavigationDataStore.h:
(WebKit::WebNavigationDataStore::decode):
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
(WebPageCreationParameters):
* Shared/WebPageGroupData.cpp:
(WebKit::WebPageGroupData::decode):
* Shared/WebPageGroupData.h:
(WebPageGroupData):
* Shared/WebPlatformTouchPoint.cpp:
(WebKit::WebPlatformTouchPoint::decode):
* Shared/WebPopupItem.cpp:
(WebKit::WebPopupItem::decode):
* Shared/WebPopupItem.h:
* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::decode):
* Shared/WebPreferencesStore.h:
(WebPreferencesStore):
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
* Shared/WebTouchEvent.cpp:
(WebKit::WebTouchEvent::decode):
* Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::decode):
* Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::decode):
* Shared/cf/ArgumentCodersCF.h:
(CoreIPC):
* Shared/mac/ArgumentCodersMac.h:
(CoreIPC):
* Shared/mac/ArgumentCodersMac.mm:
(CoreIPC::decode):
* Shared/mac/AttributedString.h:
(AttributedString):
* Shared/mac/AttributedString.mm:
(WebKit::AttributedString::decode):
* Shared/mac/ColorSpaceData.h:
(ColorSpaceData):
* Shared/mac/ColorSpaceData.mm:
(WebKit::ColorSpaceData::decode):
* Shared/mac/LayerTreeContextMac.mm:
(WebKit::LayerTreeContext::decode):
* Shared/mac/ObjCObjectGraphCoders.h:
(WebContextObjCObjectGraphDecoder):
(InjectedBundleObjCObjectGraphDecoder):
* Shared/mac/ObjCObjectGraphCoders.mm:
(WebKit::ObjCObjectGraphDecoder::baseDecode):
(WebKit::WebContextObjCObjectGraphDecoderImpl::decode):
(WebKit::InjectedBundleObjCObjectGraphDecoderImpl::decode):
(WebKit::WebContextObjCObjectGraphDecoder::decode):
(WebKit::InjectedBundleObjCObjectGraphDecoder::decode):
* Shared/mac/PlatformCertificateInfo.h:
(PlatformCertificateInfo):
* Shared/mac/PlatformCertificateInfo.mm:
(WebKit::PlatformCertificateInfo::decode):
* Shared/mac/RemoteLayerTreeTransaction.h:
(LayerProperties):
(RemoteLayerTreeTransaction):
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::RemoteLayerTreeTransaction::decode):
* Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::Handle::decode):
(WebKit::SandboxExtension::HandleArray::decode):
* Shared/mac/SecItemRequestData.cpp:
(WebKit::SecItemRequestData::decode):
* Shared/mac/SecItemRequestData.h:
* Shared/mac/SecItemResponseData.cpp:
(WebKit::SecItemResponseData::decode):
* Shared/mac/SecItemResponseData.h:
(SecItemResponseData):
* Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::::decodePlatformData):
(CoreIPC::::decode):
* UIProcess/WebContextUserMessageCoders.h:
(WebKit::WebContextUserMessageDecoder::decode):
* WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
(WebKit::InjectedBundleUserMessageDecoder::decode):
* WebProcess/Plugins/Plugin.cpp:
(WebKit::Plugin::Parameters::decode):
* WebProcess/Plugins/Plugin.h:
(Parameters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSmart link can erroneously move caret after an URL when typing immediately before it
rniwa@webkit.org [Fri, 1 Feb 2013 19:44:37 +0000 (19:44 +0000)]
Smart link can erroneously move caret after an URL when typing immediately before it
https://bugs.webkit.org/show_bug.cgi?id=92812

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by smart link being triggered even when a user finished typing a word
immediately before an URL. We already had a logic to avoid smart-linking an URL when the caret
was after the URL but we were missing a check for when the caret is before the URL.

Fixed the bug by adding this check.

Test: editing/inserting/smart-link-when-caret-is-moved-before-URL.html

* editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):

LayoutTests:

Add a regression for typing immediately before an URL while smart link is enabled.
WebKit should not be moving the caret erroneously.

* editing/inserting/smart-link-when-caret-is-moved-before-URL-expected.txt: Added.
* editing/inserting/smart-link-when-caret-is-moved-before-URL.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Windows build fix. FloatSize.cpp was not included in the project.
roger_fong@apple.com [Fri, 1 Feb 2013 19:40:32 +0000 (19:40 +0000)]
Unreviewed. Windows build fix. FloatSize.cpp was not included in the project.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Grid Layout] computePreferredLogicalWidths doesn't handle minmax tracks
jchaffraix@webkit.org [Fri, 1 Feb 2013 19:29:18 +0000 (19:29 +0000)]
[CSS Grid Layout] computePreferredLogicalWidths doesn't handle minmax tracks
https://bugs.webkit.org/show_bug.cgi?id=108403

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-preferred-logical-widths.html

The code before this change was only handling minmax() with 2 fixed widths.
The new code was updated to remove this artificial limitation and we now
support all combination of minmax().

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computePreferredLogicalWidths):
Updated to use computePreferredTrackWidth..

(WebCore::RenderGrid::computePreferredTrackWidth):
Added this helper function that implements the core of the preferred width
computation.

* rendering/RenderGrid.h: Added computePreferredTrackWidth.

LayoutTests:

* fast/css-grid-layout/grid-preferred-logical-widths-expected.txt: Added.
* fast/css-grid-layout/grid-preferred-logical-widths.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCached main resources report a zero identifer on 304s
japhet@chromium.org [Fri, 1 Feb 2013 19:25:38 +0000 (19:25 +0000)]
Cached main resources report a zero identifer on 304s
https://bugs.webkit.org/show_bug.cgi?id=108402

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/cache/iframe-304-crash.html

* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::responseReceived): Throughout, check m_identifierForLoadWithoutResourceLoader
    instead of !loader() to determine whether MainResourceLoader needs to synthesize resource load callbacks.
(WebCore::MainResourceLoader::dataReceived):
(WebCore::MainResourceLoader::didFinishLoading):

LayoutTests:

* http/tests/cache/iframe-304-crash-expected.txt: Added.
* http/tests/cache/iframe-304-crash.html: Added.
* http/tests/cache/resources/iframe304.php: Added.
* platform/chromium/TestExpectations: New test requires main resource caching, which isn't supported on chromium at the moment.
* platform/mac/TestExpectations: New test requires main resource caching, which isn't supported on mac at the moment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Build webkit with enable_web_intents set to 0.
thakis@chromium.org [Fri, 1 Feb 2013 19:14:03 +0000 (19:14 +0000)]
[chromium] Build webkit with enable_web_intents set to 0.
https://bugs.webkit.org/show_bug.cgi?id=108408

Reviewed by Tony Chang.

I'll then make chromium build fine with that, then switch
enable_web_intents to 0, roll that into webkit, and then
actually remove the code hidden behind this flag.

Source/WebCore:

* bindings/v8/custom/V8IntentCustom.cpp:

Source/WebKit/chromium:

The features.gypi bit depends on https://codereview.chromium.org/12143002/
and will disable web intents support on android. Since common.gypi
sets enable_web_intents to 0 explicitly, it seems this is currently on
by accident anyway.

While it looks like this CL just removes ENABLE_WEB_INTENTS=1 from
features.gypi completely, it's still set further down the file if
enable_web_intents is on.

* WebKit.gyp:
* features.gypi:
* src/WebFrameImpl.cpp:

Tools:

* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
* DumpRenderTree/chromium/WebViewHost.cpp:
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: make console object state hint non-active
pfeldman@chromium.org [Fri, 1 Feb 2013 19:07:46 +0000 (19:07 +0000)]
Web Inspector: make console object state hint non-active
https://bugs.webkit.org/show_bug.cgi?id=108642

Reviewed by Vsevolod Vlasov.

Otherwise it seems like an active element user could click.

* inspector/front-end/inspector.css:
(.object-info-state-note):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoZero size gradient should paint nothing on canvas
commit-queue@webkit.org [Fri, 1 Feb 2013 19:04:43 +0000 (19:04 +0000)]
Zero size gradient should paint nothing on canvas
https://bugs.webkit.org/show_bug.cgi?id=102654

Patch by Rashmi Shyamasundar <rashmi.s2@samsung.com> on 2013-02-01
Reviewed by Dirk Schulze.

Source/WebCore:

The functions fill(), fillText(), stroke(), strokeRect() and strokeText()
should paint nothing on canvas when the canvas fillStyle/strokeStyle
is set to a zero size gradient.

Tests: fast/canvas/canvas-fill-zeroSizeGradient.html
       fast/canvas/canvas-fillRect-zeroSizeGradient.html
       fast/canvas/canvas-fillText-zeroSizeGradient.html
       fast/canvas/canvas-stroke-zeroSizeGradient.html
       fast/canvas/canvas-strokeRect-zeroSizeGradient.html
       fast/canvas/canvas-strokeText-zeroSizeGradient.html

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::strokeRect):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

LayoutTests:

The functions fill(), fillText(), stroke(), strokeRect() and strokeText()
should paint nothing on canvas when the canvas fillStyle/strokeStyle
is set to a zero size gradient.

* fast/canvas/canvas-fill-zeroSizeGradient-expected.txt: Added.
* fast/canvas/canvas-fill-zeroSizeGradient.html: Added.
* fast/canvas/canvas-fillRect-zeroSizeGradient-expected.txt: Added.
* fast/canvas/canvas-fillRect-zeroSizeGradient.html: Added.
* fast/canvas/canvas-fillText-zeroSizeGradient-expected.txt: Added.
* fast/canvas/canvas-fillText-zeroSizeGradient.html: Added.
* fast/canvas/canvas-stroke-zeroSizeGradient-expected.txt: Added.
* fast/canvas/canvas-stroke-zeroSizeGradient.html: Added.
* fast/canvas/canvas-strokeRect-zeroSizeGradient-expected.txt: Added.
* fast/canvas/canvas-strokeRect-zeroSizeGradient.html: Added.
* fast/canvas/canvas-strokeText-zeroSizeGradient-expected.txt: Added.
* fast/canvas/canvas-strokeText-zeroSizeGradient.html: Added.
* fast/canvas/script-tests/canvas-fill-zeroSizeGradient.js: Added.
* fast/canvas/script-tests/canvas-fillRect-zeroSizeGradient.js: Added.
* fast/canvas/script-tests/canvas-fillText-zeroSizeGradient.js: Added.
* fast/canvas/script-tests/canvas-stroke-zeroSizeGradient.js: Added.
* fast/canvas/script-tests/canvas-strokeRect-zeroSizeGradient.js: Added.
* fast/canvas/script-tests/canvas-strokeText-zeroSizeGradient.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHRTFElevation segfault if a null AudioBus is returned by loadPlatformResource
commit-queue@webkit.org [Fri, 1 Feb 2013 19:00:13 +0000 (19:00 +0000)]
HRTFElevation segfault if a null AudioBus is returned by loadPlatformResource
https://bugs.webkit.org/show_bug.cgi?id=108504

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-02-01
Reviewed by Kenneth Russell.

Fixed a segfault by checking if the returned AudioBus is null or not.
If it is, we should early return in the same way it was being done already
in HRTFElevation::calculateKernelsForAzimuthElevation();

No new tests, covered by existing tests.

* platform/audio/HRTFElevation.cpp:
(WebCore::getConcatenatedImpulseResponsesForSubject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoScrollAnimatorMac should adopt contentAreaScrolledInDirection
bdakin@apple.com [Fri, 1 Feb 2013 18:59:08 +0000 (18:59 +0000)]
ScrollAnimatorMac should adopt contentAreaScrolledInDirection
https://bugs.webkit.org/show_bug.cgi?id=108647
-and corresponding-
<rdar://problem/12434779>

Reviewed by Anders Carlsson.

This patch makes notifyContentAreaScrolled() and notifyPositionChanged() take a
FloatSize parameter that represents the scroll delta so that it can be passed
along to contentAreaScrolledInDirection:.

Pass along the scroll delta.
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):

The delta is not needed in this base-class implementation. It will only be needed
in the ScrollAnimatorMac override.
(WebCore::ScrollAnimator::notifyPositionChanged):
* platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::notifyContentAreaScrolled):

Pass along the delta.
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorNone::animationTimerFired):
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scrollPositionChanged):

Add contentAreaScrolledInDirection: to the NSScrollerImpDetails.
* platform/mac/NSScrollerImpDetails.h:

New member variable m_contentAreaScrolledTimerScrollDelta stores the current
scroll delta while we are waiting for m_sendContentAreaScrolledTimer to fire.
* platform/mac/ScrollAnimatorMac.h:

We need this so that we can call just contentAreaScrolled if
contentAreaScrolledInDirection: is not available.
* platform/mac/ScrollAnimatorMac.mm:
(supportsContentAreaScrolledInDirection):

Pass along the delta.
(WebCore::ScrollAnimatorMac::immediateScrollTo):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::mayBeginScrollGesture):
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::immediateScrollBy):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledSoon):

If contentAreaScrolledInDirection: is available, call it with the delta, and then
reset our delta. Otherwise, still call contentAreaScrolled.
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebKit/chromium: [Chromium] Ignore whitespace in spellcheck
commit-queue@webkit.org [Fri, 1 Feb 2013 18:55:09 +0000 (18:55 +0000)]
Source/WebKit/chromium: [Chromium] Ignore whitespace in spellcheck
https://bugs.webkit.org/show_bug.cgi?id=108510

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
Reviewed by Ryosuke Niwa.

* src/ContextMenuClientImpl.cpp:
(WebKit::selectMisspellingAsync): Ignore whitespace when selecting the misspelling.

LayoutTests: [Chromium] Expect spellcheck to ignore whitespace
https://bugs.webkit.org/show_bug.cgi?id=108510

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
Reviewed by Ryosuke Niwa.

* platform/chromium/TestExpectations: Expect spellcheck to ignore whitespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [file selector dialog] for mixed case queries, score uppercase letters...
pfeldman@chromium.org [Fri, 1 Feb 2013 18:49:10 +0000 (18:49 +0000)]
Web Inspector: [file selector dialog] for mixed case queries, score uppercase letters only when assessing camelcase.
https://bugs.webkit.org/show_bug.cgi?id=108639

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._createScoringRegex):

LayoutTests:

* inspector/filtered-item-selection-dialog-filtering-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPadding in a parent inline preceding an empty inline child should be counted towards...
robert@webkit.org [Fri, 1 Feb 2013 18:45:27 +0000 (18:45 +0000)]
Padding in a parent inline preceding an empty inline child should be counted towards width
https://bugs.webkit.org/show_bug.cgi?id=108226

Reviewed by Levi Weintraub.

Source/WebCore:

Add the border/padding/margin from an empty inline's parent inline if it is the first or last
child of the inline.

Tests: fast/inline/parent-inline-element-padding-contributes-width.html
       fast/inline/positioned-element-padding-contributes-width.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

* fast/inline/parent-inline-element-padding-contributes-width-expected.txt: Added.
* fast/inline/parent-inline-element-padding-contributes-width.html: Added.
* fast/inline/positioned-element-padding-contributes-width-expected.txt: Added.
* fast/inline/positioned-element-padding-contributes-width.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoContinue making XSSAuditor thread safe: Remove dependencies on m_parser from init()
tonyg@chromium.org [Fri, 1 Feb 2013 18:40:20 +0000 (18:40 +0000)]
Continue making XSSAuditor thread safe: Remove dependencies on m_parser from init()
https://bugs.webkit.org/show_bug.cgi?id=108531

Reviewed by Adam Barth.

The threaded HTML parser will create and init() the XSSAuditor on the main thread, but filterToken() will be called on the background.

No new tests because no change in functionality.

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
* html/parser/XSSAuditor.h:
(WebCore):
(XSSAuditor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved an unused function: JSGlobalObject::createFunctionExecutableFromGlobalCode
ggaren@apple.com [Fri, 1 Feb 2013 18:32:23 +0000 (18:32 +0000)]
Removed an unused function: JSGlobalObject::createFunctionExecutableFromGlobalCode
https://bugs.webkit.org/show_bug.cgi?id=108657

Reviewed by Anders Carlsson.

* runtime/JSGlobalObject.cpp:
(JSC):
* runtime/JSGlobalObject.h:
(JSGlobalObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unnecessary parameter from DocumentLoader::scheduleArchiveLoad
beidson@apple.com [Fri, 1 Feb 2013 18:31:09 +0000 (18:31 +0000)]
Remove unnecessary parameter from DocumentLoader::scheduleArchiveLoad
https://bugs.webkit.org/show_bug.cgi?id=108654

Reviewed by Alexey Proskuryakov.

No new tests (No behavior change.)

Remove the KURL parameter parameter from this method which, in practice,
is always the same as the url of the ResourceRequest parameter.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::scheduleArchiveLoad):
* loader/DocumentLoader.h:

* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSet the GTK 64-bit Debug builder to build and test only WebKit1
zandobersek@gmail.com [Fri, 1 Feb 2013 18:18:27 +0000 (18:18 +0000)]
Set the GTK 64-bit Debug builder to build and test only WebKit1
https://bugs.webkit.org/show_bug.cgi?id=108648

Reviewed by Philippe Normand.

* BuildSlaveSupport/build.webkit.org-config/config.json: Change the builder name, type and
build directory to note that the builder builds and tests only the WebKit1 port on the GTK platform.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit1Only): Add the new build class that builds only the WebKit1 port of the builder's platform.
(BuildAndTestWebKit1OnlyFactory): Add the new factory that uses the CompileWebKit1Only build class
for building and testing only WebKit1 on the builder's platform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Adapt WorkQueueGtk to the latest changes in WebKit2 after r141497
carlosgc@webkit.org [Fri, 1 Feb 2013 17:18:16 +0000 (17:18 +0000)]
[GTK] Adapt WorkQueueGtk to the latest changes in WebKit2 after r141497
https://bugs.webkit.org/show_bug.cgi?id=108607

Reviewed by Anders Carlsson.

* Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::EventSource::executeEventSource): Remove the is valid
work queue check.
(WorkQueue::EventSource): WorkQueue is now refcounted, so keep a
reference when a new job is scheduled and unref it when it
finishes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make QWebHistory unit tests more robust
hausmann@webkit.org [Fri, 1 Feb 2013 16:34:05 +0000 (16:34 +0000)]
[Qt] Make QWebHistory unit tests more robust

Reviewed by Jocelyn Turcotten.

The tests were using a QEventLoop::exec() call to verify the emission
of the loadFinished() signal after calling for example back() or forward().
However sometimes the call to back() may emit the signal immediately and
sometimes async, causing instabilities in test runs. The call to exec()
also means that if there was a bug then the rest would hang forever because
exec() has no timeout.

This patch introduces a simple SignalBarrier class that solves both issues:

(1) ensureSignalEmitted() supports the immediate signal emission case as well
as the async one.

(2) Through the use of QSignalSpy's wait() there's an actual timeout.

* tests/qwebhistory/tst_qwebhistory.cpp:
(tst_QWebHistory::init):
(tst_QWebHistory::cleanup):
(tst_QWebHistory::back):
(tst_QWebHistory::forward):
(tst_QWebHistory::goToItem):
(tst_QWebHistory::serialize_2):
* tests/util.h:
(waitForSignal):
(SignalBarrier):
(SignalBarrier::SignalBarrier):
(SignalBarrier::ensureSignalEmitted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK build fix after r141566.
philn@webkit.org [Fri, 1 Feb 2013 16:14:46 +0000 (16:14 +0000)]
Unreviewed, GTK build fix after r141566.

* POTFILES.in: The FullscreenVideoController moved to WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] move ownership of TestRunner object to TestInterfaces
jochen@chromium.org [Fri, 1 Feb 2013 16:02:07 +0000 (16:02 +0000)]
[chromium] move ownership of TestRunner object to TestInterfaces
https://bugs.webkit.org/show_bug.cgi?id=108464

Reviewed by Adam Barth.

Before, TestShell owned the class. This also removes the last include
from DumpRenderTree to TestRunner/src.

This also deletes TestDelegate and uses WebTestDelegate everywhere
instead.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebTestInterfaces):
* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebKit):
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
* DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:
(WebTestRunner):
(WebTestRunner::AccessibilityController::setDelegate):
(AccessibilityController):
* DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::makeMenuItemStringsFor):
* DumpRenderTree/chromium/TestRunner/src/EventSender.h:
(WebTestRunner):
(WebTestRunner::EventSender::setDelegate):
(EventSender):
* DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:
(WebTestRunner::GamepadController::setDelegate):
* DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
(WebTestRunner):
(GamepadController):
* DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: Removed.
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
(WebTestRunner::TestInterfaces::~TestInterfaces):
(WebTestRunner::TestInterfaces::setWebView):
(WebTestRunner::TestInterfaces::setDelegate):
(WebTestRunner::TestInterfaces::bindTo):
(WebTestRunner::TestInterfaces::resetAll):
(WebTestRunner):
(WebTestRunner::TestInterfaces::setTestIsRunning):
(WebTestRunner::TestInterfaces::testRunner):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(WebTestRunner):
(TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebKit):
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::Internal::testRunner):
(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::Internal):
(WebTestRunner::WebTestInterfaces::Internal::setDelegate):
(WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
* DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp: Added.
(WebTestRunner):
(WebTestRunner::WebTestRunner::WebTestRunner):
(WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpAsText):
(WebTestRunner::WebTestRunner::setShouldDumpAsText):
(WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
(WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
(WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
(WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
(WebTestRunner::WebTestRunner::shouldDumpAsAudio):
(WebTestRunner::WebTestRunner::audioData):
(WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
(WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
(WebTestRunner::WebTestRunner::shouldDumpCreateView):
(WebTestRunner::WebTestRunner::canOpenWindows):
(WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
(WebTestRunner::WebTestRunner::webPermissions):
(WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
(WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
(WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
(WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
(WebTestRunner::WebTestRunner::testRepaint):
(WebTestRunner::WebTestRunner::sweepHorizontally):
(WebTestRunner::WebTestRunner::isPrinting):
(WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
(WebTestRunner::WebTestRunner::setTitleTextDirection):
(WebTestRunner::WebTestRunner::httpHeadersToClear):
(WebTestRunner::WebTestRunner::shouldBlockRedirects):
(WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
(WebTestRunner::WebTestRunner::setTopLoadingFrame):
(WebTestRunner::WebTestRunner::topLoadingFrame):
(WebTestRunner::WebTestRunner::policyDelegateDone):
(WebTestRunner::WebTestRunner::policyDelegateEnabled):
(WebTestRunner::WebTestRunner::policyDelegateIsPermissive):
(WebTestRunner::WebTestRunner::policyDelegateShouldNotifyDone):
(WebTestRunner::WebTestRunner::shouldInterceptPostMessage):
(WebTestRunner::WebTestRunner::isSmartInsertDeleteEnabled):
(WebTestRunner::WebTestRunner::isSelectTrailingWhitespaceEnabled):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::runFileTest):
(TestShell::resetTestController):
(TestShell::dump):
(TestShell::bindJSObjectsToWindow):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::testRunner):
(TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled Chromium DEPS to r180131. Requested by
commit-queue@webkit.org [Fri, 1 Feb 2013 15:58:35 +0000 (15:58 +0000)]
Unreviewed.  Rolled Chromium DEPS to r180131.  Requested by
"Florin Malita" <fmalita@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: relax goto file matching again.
pfeldman@chromium.org [Fri, 1 Feb 2013 15:46:32 +0000 (15:46 +0000)]
Web Inspector: relax goto file matching again.
https://bugs.webkit.org/show_bug.cgi?id=108346

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change brings back behavior introduced in r116244.

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._createSearchRegex):
(WebInspector.FilteredItemSelectionDialog.prototype._createScoringRegex):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems.compareFunction):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):
(WebInspector.FilteredItemSelectionDialog.prototype.itemElement):
(WebInspector.OpenResourceDialog):
* inspector/front-end/utilities.js:
(String.regexSpecialCharacters):
(String.prototype.escapeForRegExp):

LayoutTests:

* inspector/filtered-item-selection-dialog-filtering-expected.txt:
* inspector/filtered-item-selection-dialog-filtering.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Navigator should not create tree elements for uiSourceCodes unless...
vsevik@chromium.org [Fri, 1 Feb 2013 15:43:25 +0000 (15:43 +0000)]
Web Inspector: Navigator should not create tree elements for uiSourceCodes unless neededm should populate folders on expand only.
https://bugs.webkit.org/show_bug.cgi?id=108601

Reviewed by Pavel Feldman.

Source/WebCore:

Tree elememnts for uiSourceCodes are not created until really needed anymore.
They are now created when parent folder tree elememnts are expanded or when uiSourceCode is revealed in navigator.

* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView):
(WebInspector.NavigatorView.prototype.addUISourceCode):
(WebInspector.NavigatorView.prototype._getOrCreateScriptTreeElement):
(WebInspector.NavigatorView.prototype._getScriptTreeElement):
(WebInspector.NavigatorView.prototype._createScriptTreeElement):
(WebInspector.NavigatorView.prototype._removeScriptTreeElement):
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype.isScriptSourceAdded):
(WebInspector.NavigatorView.prototype.revealUISourceCode):
(WebInspector.NavigatorView.prototype.removeUISourceCode):
(WebInspector.NavigatorView.prototype.reset):
(WebInspector.NavigatorView.prototype.createFolderTreeElement):
(WebInspector.NavigatorView.prototype._populateFolderTreeElement):
(WebInspector.NavigatorView.prototype._addScriptTreeElement):
(WebInspector.NavigatorView.prototype._adoptUISourceCode):
(WebInspector.NavigatorFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement.prototype.onpopulate):

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest.):
(initialize_DebuggerTest):
* inspector/debugger/scripts-file-selector-expected.txt:
* inspector/debugger/scripts-file-selector.html:
* inspector/debugger/scripts-sorting-expected.txt:
* inspector/debugger/scripts-sorting.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, flagging more fullscreen tests in GTK due to bug 108363.
philn@webkit.org [Fri, 1 Feb 2013 15:40:12 +0000 (15:40 +0000)]
Unreviewed, flagging more fullscreen tests in GTK due to bug 108363.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Native Memory Instrumentation: provide edge names and class names...
loislo@chromium.org [Fri, 1 Feb 2013 15:32:35 +0000 (15:32 +0000)]
Web Inspector: Native Memory Instrumentation: provide edge names and class names for WTF containers and strings
https://bugs.webkit.org/show_bug.cgi?id=107303

Reviewed by Yury Semikhatsky.

I'd like to use ValueType[] as className for the container data members
because class names of template parameters already present in the container class names.

* wtf/MemoryInstrumentationArrayBufferView.h:
(WTF::reportMemoryUsage):
* wtf/MemoryInstrumentationHashCountedSet.h:
(WTF::reportMemoryUsage):
* wtf/MemoryInstrumentationHashMap.h:
(WTF::reportMemoryUsage):
* wtf/MemoryInstrumentationHashSet.h:
(WTF::reportMemoryUsage):
* wtf/MemoryInstrumentationListHashSet.h:
(WTF::reportMemoryUsage):
* wtf/MemoryInstrumentationSequence.h:
* wtf/MemoryInstrumentationString.h:
(WTF::reportMemoryUsage):
* wtf/MemoryInstrumentationVector.h:
(WTF::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPatchLog process durations are increasing linearly with time (faulty data logging)
commit-queue@webkit.org [Fri, 1 Feb 2013 15:27:15 +0000 (15:27 +0000)]
PatchLog process durations are increasing linearly with time (faulty data logging)
https://bugs.webkit.org/show_bug.cgi?id=108621

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-01
Reviewed by Eric Seidel.

Added a check to prevent a stop event from happening to the same patch multiple times.

* QueueStatusServer/loggers/recordpatchevent.py:
(RecordPatchEvent.stopped):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: TabbedEditorContainer.History performance optimization.
vsevik@chromium.org [Fri, 1 Feb 2013 15:27:03 +0000 (15:27 +0000)]
Web Inspector: TabbedEditorContainer.History performance optimization.
https://bugs.webkit.org/show_bug.cgi?id=108581

Introduced history items indexing by url.

Reviewed by Pavel Feldman.

Covered by existing test.

* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.History):
(WebInspector.TabbedEditorContainer.History.prototype.index):
(WebInspector.TabbedEditorContainer.History.prototype._rebuildItemIndex):
(WebInspector.TabbedEditorContainer.History.prototype.update):
(WebInspector.TabbedEditorContainer.History.prototype.remove):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdded TriState to WTF and started using it in one place
ggaren@apple.com [Fri, 1 Feb 2013 15:01:34 +0000 (15:01 +0000)]
Added TriState to WTF and started using it in one place
https://bugs.webkit.org/show_bug.cgi?id=108628

Reviewed by Beth Dakin.

../JavaScriptCore:

* runtime/PrototypeMap.h:
(JSC::PrototypeMap::isPrototype): Use TriState instead of boolean. In
response to review feedback, this is an attempt to clarify that our
'true' condition is actually just a 'maybe'.

* runtime/PrototypeMap.h:
(PrototypeMap):
(JSC::PrototypeMap::isPrototype):

../WebCore:

* editing/EditingStyle.h:
(WebCore): Moved TriState to WTF so it can be used in more places.

../WTF:

Useful for expressing "maybe" conditions in a boolean context.

* WTF.xcodeproj/project.pbxproj:
* wtf/TriState.h: Added.
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r141319.
commit-queue@webkit.org [Fri, 1 Feb 2013 14:17:49 +0000 (14:17 +0000)]
Unreviewed, rolling out r141319.
http://trac.webkit.org/changeset/141319
https://bugs.webkit.org/show_bug.cgi?id=108629

This patch is causing the UIProcess to hang on GTK port when
loading plugins (Requested by chris-qBT_laptop on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01

* UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::scanPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r137709
paroga@webkit.org [Fri, 1 Feb 2013 14:12:51 +0000 (14:12 +0000)]
Build fix for WinCE after r137709
https://bugs.webkit.org/show_bug.cgi?id=105767

Do not pass functions as const references to
templated arguments to make the compiler happy.

* wtf/StdLibExtras.h:
(WTF::binarySearch):
(WTF::tryBinarySearch):
(WTF::approximateBinarySearch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][WK2] MiniBrowser fullscreen signals support
commit-queue@webkit.org [Fri, 1 Feb 2013 14:11:18 +0000 (14:11 +0000)]
[GTK][WK2] MiniBrowser fullscreen signals support
https://bugs.webkit.org/show_bug.cgi?id=108005

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-02-01
Reviewed by Carlos Garcia Campos.

Shows a label for 2 seconds using overlay (if GTK >= 3.2.0) and hides
the toolbar when entering fullscreen. When leaving fullscreen the
label is hidden (if it's not hidden yet) and the toolbar is shown again.

* MiniBrowser/gtk/BrowserWindow.c:
(_BrowserWindow):
(fullScreenMessageTimeoutCallback):
(webViewEnterFullScreen):
(webViewLeaveFullScreen):
(browserWindowFinalize):
(browserWindowConstructed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
sudarsana.nagineni@linux.intel.com [Fri, 1 Feb 2013 13:42:25 +0000 (13:42 +0000)]
Unreviewed EFL gardening.

Skip some failing tests on EFL bots after r141459 and r141310.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:
* platform/efl/fast/js/global-constructors-expected.txt: Revert change from r141573.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EwkContext should be based on C WK2 API
mikhail.pozdnyakov@intel.com [Fri, 1 Feb 2013 13:08:17 +0000 (13:08 +0000)]
[EFL][WK2] EwkContext should be based on C WK2 API
https://bugs.webkit.org/show_bug.cgi?id=107666

Reviewed by Andreas Kling.

EwkContext should be based on C WK2 API so that API layering is not violated.

* UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
* UIProcess/API/efl/ewk_context.cpp:
(EwkContext::EwkContext):
(EwkContext::create):
(EwkContext::cookieManager):
(EwkContext::ensureFaviconDatabase):
(EwkContext::setFaviconDatabaseDirectoryPath):
(EwkContext::addVisitedLink):
(EwkContext::setCacheModel):
(EwkContext::cacheModel):
(EwkContext::setAdditionalPluginPath):
(EwkContext::clearResourceCache):
* UIProcess/API/efl/ewk_context_private.h:
(EwkContext):
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_base_add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix hanging deleteQWebViewTwice test
hausmann@webkit.org [Fri, 1 Feb 2013 13:00:32 +0000 (13:00 +0000)]
[Qt] Fix hanging deleteQWebViewTwice test

Reviewed by Allan Sandfeld Jensen.

Don't use QCoreApplication::instance()->exec(), because in case of a bug
that never finishes. Instead use waitForSignal() which has the concept of
a timeout.

* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::deleteQWebViewTwice):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Use C API inside ewk_auth_request
christophe.dumez@intel.com [Fri, 1 Feb 2013 12:56:17 +0000 (12:56 +0000)]
[EFL][WK2] Use C API inside ewk_auth_request
https://bugs.webkit.org/show_bug.cgi?id=107806

Reviewed by Andreas Kling.

Use C API inside ewk_auth_request instead of accessing C++ internal
classes directly, to avoid violating layering.

* UIProcess/API/efl/ewk_auth_request.cpp:
(EwkAuthRequest::EwkAuthRequest):
(EwkAuthRequest::suggestedUsername):
(EwkAuthRequest::realm):
(EwkAuthRequest::host):
(EwkAuthRequest::continueWithoutCredential):
(EwkAuthRequest::authenticate):
(EwkAuthRequest::isRetrying):
(ewk_auth_request_authenticate):
* UIProcess/API/efl/ewk_auth_request_private.h:
(EwkAuthRequest::create):
(EwkAuthRequest):
* UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didReceiveAuthenticationChallengeInFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk][WK2] Fix build after recent WebKit2 changes
hausmann@webkit.org [Fri, 1 Feb 2013 12:54:33 +0000 (12:54 +0000)]
[Gtk][WK2] Fix build after recent WebKit2 changes
https://bugs.webkit.org/show_bug.cgi?id=108588

Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-01
Reviewed by Andreas Kling.

Don't remove WorkQueue during execution.
Following the logic on https://bugs.webkit.org/show_bug.cgi?id=108544

* Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::EventSource::~EventSource):
(WorkQueue::EventSource::executeEventSource):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
(WorkQueue::dispatchOnTermination):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Follow up to r141260: fixing renamed style.
pfeldman@chromium.org [Fri, 1 Feb 2013 12:23:56 +0000 (12:23 +0000)]
Web Inspector: Follow up to r141260: fixing renamed style.
Not reviewed.

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._onClick):
(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable unprefixed CSS transitions by default.
alexis@webkit.org [Fri, 1 Feb 2013 12:16:51 +0000 (12:16 +0000)]
Enable unprefixed CSS transitions by default.
https://bugs.webkit.org/show_bug.cgi?id=108216

Reviewed by Dean Jackson.

.:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations. Remove the
various #ifdefs and conditional generations.

* Configurations/FeatureDefines.xcconfig:
* DerivedSources.cpp:
* GNUmakefile.features.am.in:
* css/CSSPropertyNames.in:
* dom/EventNames.in:
* dom/TransitionEvent.cpp:
* dom/TransitionEvent.h:
* dom/TransitionEvent.idl:
* page/DOMWindow.idl:
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):

Source/WebKit/chromium:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* features.gypi:

Source/WebKit/mac:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* Configurations/FeatureDefines.xcconfig:

Tools:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

WebKitLibraries:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Unskip the tests by default as now unprefixed CSS Transitions are
enabled by default.

* fast/events/event-creation-expected.txt:
* fast/events/event-creation.html: Add the test that was commented out
before.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r141548.
haraken@chromium.org [Fri, 1 Feb 2013 11:49:35 +0000 (11:49 +0000)]
Unreviewed, rolling out r141548.
http://trac.webkit.org/changeset/141548
https://bugs.webkit.org/show_bug.cgi?id=108579

userscript-plugin-document.html is flaky

* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::setWrapperInObject):
* bindings/v8/V8GCController.cpp:
(WebCore):
(WebCore::gcTree):
(WebCore::V8GCController::didCreateWrapperForNode):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):
* bindings/v8/V8GCController.h:
(V8GCController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Skipped some failing tests.
kadam@inf.u-szeged.hu [Fri, 1 Feb 2013 11:39:56 +0000 (11:39 +0000)]
[Qt] Unreviewed gardening. Skipped some failing tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Skip hanging WebGL software fallback tests
hausmann@webkit.org [Fri, 1 Feb 2013 11:27:47 +0000 (11:27 +0000)]
[Qt] Skip hanging WebGL software fallback tests

Reviewed by Allan Sandfeld Jensen.

See also https://bugs.webkit.org/show_bug.cgi?id=105820.

* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
(tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: fix jscompiler warnings
aandrey@chromium.org [Fri, 1 Feb 2013 11:26:17 +0000 (11:26 +0000)]
Web Inspector: fix jscompiler warnings
https://bugs.webkit.org/show_bug.cgi?id=108604

Reviewed by Pavel Feldman.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleGroup.prototype.addMessage):
* inspector/front-end/ContextMenu.js:
(WebInspector.ContextSubMenuItem):
* inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype._copyImageURL):
(WebInspector.ImageView.prototype._openInNewTab):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._clearBrowserCache):
(WebInspector.NetworkLogView.prototype._clearBrowserCookies):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.IDBDatabaseTreeElement.prototype._refreshIndexedDB):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRenameSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleCreateSnippet):
* inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.prototype._isDockedToBottom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
sudarsana.nagineni@linux.intel.com [Fri, 1 Feb 2013 11:22:04 +0000 (11:22 +0000)]
Unreviewed EFL gardening.

Update platform expectations for failing tests after the
WEB_INTENTS flag turned off for EFL port in r141439

* platform/efl/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
* platform/efl/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
sudarsana.nagineni@linux.intel.com [Fri, 1 Feb 2013 11:00:58 +0000 (11:00 +0000)]
Unreviewed EFL gardening.

Renamed inspector/editor/text-editor-ctrl-movements.html to
inspector/editor/text-editor-word-jumps.html after r141399.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics : Sort Target.pri and class declarations in alphabetical order.
commit-queue@webkit.org [Fri, 1 Feb 2013 10:51:59 +0000 (10:51 +0000)]
Coordinated Graphics : Sort Target.pri and class declarations in alphabetical order.
https://bugs.webkit.org/show_bug.cgi?id=108590

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-02-01
Reviewed by Noam Rosenthal.

Source/WebCore:

Sort CoordinatedGraphics files in Target.pri in alphabetical order.

No new tests. No change in behavior.

* Target.pri:

Source/WebKit2:

Sort class declarations in alphabetical order.

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Native Memory Instrumentation: provide edge names to class members...
loislo@chromium.org [Fri, 1 Feb 2013 10:42:37 +0000 (10:42 +0000)]
Web Inspector: Native Memory Instrumentation: provide edge names to class members in all WebCore instrumented classes.
https://bugs.webkit.org/show_bug.cgi?id=107369

Reviewed by Yury Semikhatsky.

It is almost mechanical change generated by a script.
Late I'll implement name to edge name consistency check in clang plugin.

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::reportMemoryUsage):
* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::reportMemoryUsage):
* bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::reportMemoryUsage):
* bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperMap::reportMemoryUsage):
* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage):
* bindings/v8/V8ValueCache.cpp:
(WebCore::StringCache::reportMemoryUsage):
* css/CSSBorderImageSliceValue.cpp:
(WebCore::CSSBorderImageSliceValue::reportDescendantMemoryUsage):
* css/CSSCalculationValue.cpp:
* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::reportDescendantMemoryUsage):
* css/CSSCharsetRule.cpp:
(WebCore::CSSCharsetRule::reportMemoryUsage):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::reportMemoryUsage):
* css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::reportDescendantMemoryUsage):
* css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):
* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::reportMemoryUsage):
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):
* css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::reportDescendantMemoryUsage):
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientColorStop::reportMemoryUsage):
(WebCore::CSSGradientValue::reportBaseClassMemoryUsage):
(WebCore::CSSLinearGradientValue::reportDescendantMemoryUsage):
(WebCore::CSSRadialGradientValue::reportDescendantMemoryUsage):
* css/CSSGroupingRule.cpp:
(WebCore::CSSGroupingRule::reportMemoryUsage):
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::reportDescendantMemoryUsage):
(WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::reportDescendantMemoryUsage):
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::reportMemoryUsage):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::reportMemoryUsage):
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::reportMemoryUsage):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::reportMemoryUsage):
* css/CSSReflectValue.cpp:
(WebCore::CSSReflectValue::reportDescendantMemoryUsage):
* css/CSSRule.cpp:
(WebCore::CSSRule::reportMemoryUsage):
* css/CSSRuleList.cpp:
(WebCore::StaticCSSRuleList::reportMemoryUsage):
* css/CSSRuleList.h:
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::reportMemoryUsage):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::reportMemoryUsage):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::reportMemoryUsage):
* css/CSSValue.cpp:
(WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::reportDescendantMemoryUsage):
* css/CSSVariableValue.h:
(WebCore::CSSVariableValue::reportDescendantMemoryUsage):
* css/FontFeatureValue.cpp:
(WebCore::FontFeatureValue::reportDescendantMemoryUsage):
* css/FontValue.cpp:
(WebCore::FontValue::reportDescendantMemoryUsage):
* css/MediaList.cpp:
(WebCore::MediaQuerySet::reportMemoryUsage):
(WebCore::MediaList::reportMemoryUsage):
* css/MediaQuery.cpp:
(WebCore::MediaQuery::reportMemoryUsage):
* css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::reportMemoryUsage):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::reportMemoryUsage):
(WebCore::StyleRuleCSSStyleDeclaration::reportMemoryUsage):
(WebCore::InlineCSSStyleDeclaration::reportMemoryUsage):
* css/RuleFeature.cpp:
(WebCore::RuleFeatureSet::reportMemoryUsage):
* css/RuleSet.cpp:
(WebCore::RuleData::reportMemoryUsage):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):
* css/ShadowValue.cpp:
(WebCore::ShadowValue::reportDescendantMemoryUsage):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::reportMemoryUsage):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::MatchedProperties::reportMemoryUsage):
(WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
(WebCore::MediaQueryResult::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):
* css/StyleRule.cpp:
(WebCore::StyleRule::reportDescendantMemoryUsage):
(WebCore::StyleRulePage::reportDescendantMemoryUsage):
(WebCore::StyleRuleFontFace::reportDescendantMemoryUsage):
(WebCore::StyleRuleGroup::reportDescendantMemoryUsage):
(WebCore::StyleRuleMedia::reportDescendantMemoryUsage):
(WebCore::StyleRuleRegion::reportDescendantMemoryUsage):
(WebCore::StyleRuleViewport::reportDescendantMemoryUsage):
* css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::reportDescendantMemoryUsage):
* css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::reportMemoryUsage):
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::reportMemoryUsage):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::reportMemoryUsage):
(WebCore::WebKitCSSKeyframeRule::reportMemoryUsage):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
(WebCore::WebKitCSSKeyframesRule::reportMemoryUsage):
* css/WebKitCSSSVGDocumentValue.cpp:
(WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):
* css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):
* css/WebKitCSSViewportRule.cpp:
(WebCore::WebKitCSSViewportRule::reportMemoryUsage):
* dom/Attribute.h:
(WebCore::Attribute::reportMemoryUsage):
* dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::reportMemoryUsage):
* dom/ContainerNode.h:
(ContainerNode):
* dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
* dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::reportMemoryUsage):
* dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::reportMemoryUsage):
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):
* dom/Element.cpp:
(WebCore::Element::reportMemoryUsage):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::reportMemoryUsage):
* dom/ElementRareData.cpp:
(WebCore::ElementRareData::reportMemoryUsage):
* dom/ElementShadow.cpp:
(WebCore::ElementShadow::reportMemoryUsage):
* dom/Event.cpp:
(WebCore::Event::reportMemoryUsage):
* dom/LiveNodeList.cpp:
(WebCore::LiveNodeListBase::reportMemoryUsage):
* dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
* dom/NodeRareData.cpp:
(WebCore::NodeListsNodeData::reportMemoryUsage):
(WebCore::NodeRareData::reportMemoryUsage):
* dom/QualifiedName.cpp:
(WebCore::QualifiedName::reportMemoryUsage):
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::reportMemoryUsage):
* dom/SecurityContext.cpp:
(WebCore::SecurityContext::reportMemoryUsage):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::reportMemoryUsage):
* dom/TreeScope.cpp:
(WebCore::TreeScope::reportMemoryUsage):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::reportMemoryUsage):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::reportMemoryUsage):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::reportMemoryUsage):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::reportMemoryUsage):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::reportMemoryUsage):
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::reportMemoryUsage):
* inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::reportMemoryUsage):
* inspector/HeapGraphSerializer.h:
(HeapGraphSerializer):
* inspector/InspectorBaseAgent.cpp:
(WebCore::InspectorBaseAgentInterface::reportMemoryUsage):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::reportMemoryUsage):
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::reportMemoryUsage):
* inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::reportMemoryUsage):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::reportMemoryUsage):
(WebCore::ScriptDebugListener::Script::reportMemoryUsage):
* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::reportMemoryUsage):
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::reportMemoryUsage):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::reportMemoryUsage):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::reportMemoryUsage):
* inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):
(WebCore::MemoryInstrumentationImpl::reportMemoryUsage):
* inspector/NetworkResourcesData.cpp:
(WebCore::XHRReplayData::reportMemoryUsage):
(WebCore::NetworkResourcesData::ResourceData::reportMemoryUsage):
(WebCore::NetworkResourcesData::reportMemoryUsage):
* loader/CachedMetadata.cpp:
(WebCore::CachedMetadata::reportMemoryUsage):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportMemoryUsage):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::reportMemoryUsage):
* loader/Prerenderer.cpp:
(WebCore::Prerenderer::reportMemoryUsage):
* loader/ResourceBuffer.cpp:
(WebCore::ResourceBuffer::reportMemoryUsage):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::reportMemoryUsage):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::reportMemoryUsage):
* loader/SubstituteData.cpp:
(WebCore::SubstituteData::reportMemoryUsage):
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::reportMemoryUsage):
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::reportMemoryUsage):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::reportMemoryUsage):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::reportMemoryUsage):
* loader/cache/CachedResourceHandle.cpp:
(WebCore::CachedResourceHandleBase::reportMemoryUsage):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::reportMemoryUsage):
* loader/cache/CachedSVGDocument.cpp:
(WebCore::CachedSVGDocument::reportMemoryUsage):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::reportMemoryUsage):
* loader/cache/CachedShader.cpp:
(WebCore::CachedShader::reportMemoryUsage):
* loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::reportMemoryUsage):
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::reportMemoryUsage):
* page/DOMTimer.cpp:
(WebCore::DOMTimer::reportMemoryUsage):
* page/Frame.cpp:
(WebCore::Frame::reportMemoryUsage):
* page/Page.cpp:
(WebCore::Page::reportMemoryUsage):
* platform/KURL.cpp:
(WebCore::KURL::reportMemoryUsage):
* platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::reportMemoryUsage):
* platform/KURLWTFURLImpl.h:
(WebCore::KURLWTFURLImpl::reportMemoryUsage):
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::reportMemoryUsage):
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::reportMemoryUsage):
* platform/audio/AudioArray.h:
(WebCore::AudioArray::reportMemoryUsage):
* platform/audio/FFTFrame.cpp:
(WebCore::FFTFrame::reportMemoryUsage):
* platform/audio/HRTFDatabase.cpp:
(WebCore::HRTFDatabase::reportMemoryUsage):
* platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::HRTFDatabaseLoader::reportMemoryUsage):
* platform/audio/HRTFElevation.cpp:
(WebCore::HRTFElevation::reportMemoryUsage):
* platform/audio/HRTFKernel.cpp:
(WebCore::HRTFKernel::reportMemoryUsage):
* platform/audio/ffmpeg/FFTFrameFFMPEG.cpp:
(reportMemoryUsage):
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::reportMemoryUsage):
(WebCore::FrameData::reportMemoryUsage):
* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::reportMemoryUsage):
* platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::reportMemoryUsage):
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::reportMemoryUsage):
* platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::reportMemoryUsage):
* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::reportMemoryUsage):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::reportMemoryUsage):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBufferData::reportMemoryUsage):
* platform/graphics/skia/MemoryInstrumentationSkia.cpp:
(reportMemoryUsage):
* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::reportMemoryUsage):
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageFrame::reportMemoryUsage):
(WebCore):
(WebCore::ImageDecoder::reportMemoryUsage):
* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::reportMemoryUsage):
* platform/network/FormData.cpp:
(WebCore::FormData::reportMemoryUsage):
(WebCore::FormDataElement::reportMemoryUsage):
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsageBase):
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::reportMemoryUsage):
* platform/network/chromium/ResourceRequest.cpp:
(WebCore::ResourceRequest::reportMemoryUsage):
* rendering/InlineBox.cpp:
(WebCore::InlineBox::reportMemoryUsage):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::reportMemoryUsage):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::reportMemoryUsage):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::reportMemoryUsage):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::reportMemoryUsage):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::reportMemoryUsage):
(WebCore::RenderFrameSet::GridAxis::reportMemoryUsage):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::reportMemoryUsage):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::reportMemoryUsage):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::reportMemoryUsage):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::reportMemoryUsage):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::reportMemoryUsage):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::reportMemoryUsage):
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::reportMemoryUsage):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::reportMemoryUsage):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::reportMemoryUsage):
(WebCore::RenderTableSection::RowStruct::reportMemoryUsage):
(WebCore::RenderTableSection::CellStruct::reportMemoryUsage):
* rendering/RenderText.cpp:
(WebCore::RenderText::reportMemoryUsage):
* rendering/RenderView.cpp:
(WebCore::RenderView::reportMemoryUsage):
* rendering/style/DataRef.h:
(WebCore::DataRef::reportMemoryUsage):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::reportMemoryUsage):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::reportMemoryUsage):
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::reportMemoryUsage):
* svg/SVGPaint.cpp:
(WebCore::SVGPaint::reportDescendantMemoryUsage):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::reportMemoryUsage):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] visibility of embedded widget
pierre.rossi@gmail.com [Fri, 1 Feb 2013 10:40:18 +0000 (10:40 +0000)]
[Qt] visibility of embedded widget
https://bugs.webkit.org/show_bug.cgi?id=108327

Rubber-stamped by Simon Hausmann.

In overriding Widget::hide in QtPluginWidget, we forgot to call the
parent implementation, which as it turns, out does sensible stuff.

* WebCoreSupport/FrameLoaderClientQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Convert fast/regions/region-overflow-auto-overflow* to reftests
mihnea@adobe.com [Fri, 1 Feb 2013 10:37:50 +0000 (10:37 +0000)]
[CSS Regions] Convert fast/regions/region-overflow-auto-overflow* to reftests
https://bugs.webkit.org/show_bug.cgi?id=108333

Reviewed by Tony Chang.

Add reftests, cleanup existing tests.

* fast/regions/region-overflow-auto-overflow-hidden-expected.html: Added.
* fast/regions/region-overflow-auto-overflow-hidden.html:
* fast/regions/region-overflow-auto-overflow-visible-expected.html: Added.
* fast/regions/region-overflow-auto-overflow-visible.html:
* platform/chromium-linux-x86/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/chromium-linux-x86/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/chromium-linux/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/chromium-linux/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/chromium-linux/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/chromium-linux/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/chromium-mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/chromium-mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/chromium/TestExpectations:
* platform/chromium/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/chromium/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] visibility of embedded widget
pierre.rossi@gmail.com [Fri, 1 Feb 2013 10:35:31 +0000 (10:35 +0000)]
[Qt] visibility of embedded widget
https://bugs.webkit.org/show_bug.cgi?id=108327

Rubber-stamped by Simon Hausmann.

In overriding Widget::show in QtPluginWidget, we forgot to call the
parent implementation, which as it turns, out does sensible stuff.

* WebCoreSupport/FrameLoaderClientQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][GStreamer] FullscreenVideoControllerGtk implementation
philn@webkit.org [Fri, 1 Feb 2013 10:25:16 +0000 (10:25 +0000)]
[GTK][GStreamer] FullscreenVideoControllerGtk implementation
https://bugs.webkit.org/show_bug.cgi?id=107398

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

NATIVE_FULLSCREEN_VIDEO support for the GTK port. The previous
FullscreenVideoController implementation was refactored as a
sub-class of FullscreenVideoControllerGStreamer and hooked in the
MediaPlayerPrivateGStreamer backend.

* GNUmakefile.list.am:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
* platform/graphics/gtk/FullscreenVideoControllerGtk.cpp: Renamed from Source/WebKit/gtk/WebCoreSupport/FullscreenVideoController.cpp.
* platform/graphics/gtk/FullscreenVideoControllerGtk.h: Renamed from Source/WebKit/gtk/WebCoreSupport/FullscreenVideoController.h.

Source/WebKit/gtk:

Remove the FullscreenVideoController as it moved to
FullscreenVideoControllerGStreamer and its Gtk subclass in
WebCore. Hook in NATIVE_FULLSCREEN_VIDEO in the ChromeClient in
the two possible scenarios, wether FULLSCREEN_API is enabled or not.

* GNUmakefile.am: Remove FullscreenVideoController.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit):
(WebKit::ChromeClient::enterFullscreenForNode): Hook
NATIVE_FULLSCREEN_VIDEO support.
(WebKit::ChromeClient::exitFullscreenForNode): Ditto
(WebKit::ChromeClient::enterFullScreenForElement): Ditto
(WebKit::ChromeClient::exitFullScreenForElement): Ditto
* WebCoreSupport/ChromeClientGtk.h:
(ChromeClient):
* WebCoreSupport/FullscreenVideoController.cpp: Removed.
* WebCoreSupport/FullscreenVideoController.h: Removed.
* webkit/webkitwebview.cpp: Remove FullscreenVideoController support.
* webkit/webkitwebviewprivate.h: Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: fix cursor location in Source Frame
commit-queue@webkit.org [Fri, 1 Feb 2013 10:11:24 +0000 (10:11 +0000)]
Web Inspector: fix cursor location in Source Frame
https://bugs.webkit.org/show_bug.cgi?id=108592

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-01
Reviewed by Pavel Feldman.

Normalize range before computing amount of lines in
_updateSourcePosition.

No new tests.

* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._updateSourcePosition): Normalize text range.
* inspector/front-end/inspector.css: Slightly bigger left padding for the text.
(.source-frame-position):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix after r141553.
haraken@chromium.org [Fri, 1 Feb 2013 10:09:47 +0000 (10:09 +0000)]
Unreviewed build fix after r141553.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::HasInstance):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::HasInstance):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::HasInstance):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::HasInstance):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::HasInstance):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::HasInstance):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::HasInstance):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::HasInstance):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::HasInstance):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::HasInstance):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Sources panel navigator reveal and expand fixes.
vsevik@chromium.org [Fri, 1 Feb 2013 10:07:25 +0000 (10:07 +0000)]
Web Inspector: Sources panel navigator reveal and expand fixes.
https://bugs.webkit.org/show_bug.cgi?id=108584

Reviewed by Pavel Feldman.

Navigator folders are not expanded by default anymore.
Made domain folder expanded for inspected page main frame domain.
UISourceCodes are now added to navigator before editor container
so that they could be revealed if editor container decides to show them.

* inspector/front-end/NavigatorView.js:
(WebInspector.BaseNavigatorTreeElement.prototype.onattach):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addUISourceCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] MiniBrowser segfaults on loading google.com
hausmann@webkit.org [Fri, 1 Feb 2013 10:06:06 +0000 (10:06 +0000)]
[EFL][WK2] MiniBrowser segfaults on loading google.com
https://bugs.webkit.org/show_bug.cgi?id=108597

Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-02-01
Reviewed by Andreas Kling.

* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::processMessage):
oolMessageBody should be properly initialized before it is used.

This patch also adds omitted break statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Canvas] drop trace log in the backend when deleting profile in frontend
aandrey@chromium.org [Fri, 1 Feb 2013 09:52:10 +0000 (09:52 +0000)]
Web Inspector: [Canvas] drop trace log in the backend when deleting profile in frontend
https://bugs.webkit.org/show_bug.cgi?id=108591

Reviewed by Pavel Feldman.

Send a dropTraceLog command to the backend when deleting a profile header from the sidebar.
Before we were sending the command only upon deleting an existing view of a profile, so we  would not
sent the command if the view was not created or if a profile header was removed via context menu (the ondelete() method).
Drive-by: fixed an odd formatting of property functions.
* inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileHeader.prototype.reset):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileHeader.prototype.reset):
(WebInspector.ProfileHeader.prototype.load):
(WebInspector.ProfileHeader.prototype.canSaveToFile):
(WebInspector.ProfileHeader.prototype.saveToFile):
(WebInspector.ProfileHeader.prototype.loadFromFile):
(WebInspector.ProfileHeader.prototype.fromFile):
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: when aria-activedescendant is used with a ComboBox role, focus should not be...
cfleizach@apple.com [Fri, 1 Feb 2013 09:32:54 +0000 (09:32 +0000)]
AX: when aria-activedescendant is used with a ComboBox role, focus should not be changed
https://bugs.webkit.org/show_bug.cgi?id=108596

Reviewed by Ryosuke Niwa.

Source/WebCore:

Normally, an aria-activedescendant change causes a focus change to be triggered.
However, when used in conjunction with a combo box, this causes problems for screen readers.
Namely, the user expects focus to remain in the text field so that the user can keep typing.
If focus moves to an item in the combobox list, it is not possible to keep typing.

The solution is to not trigger a focus change in this case and instead use a selected children change notification.

Test: platform/mac/accessibility/combobox-activedescendant-notifications.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::shouldNotifyActiveDescendant):
(WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:

* platform/mac/accessibility/combobox-activedescendant-notifications-expected.txt: Added.
* platform/mac/accessibility/combobox-activedescendant-notifications.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion=
cfleizach@apple.com [Fri, 1 Feb 2013 09:17:02 +0000 (09:17 +0000)]
Source/WebCore: [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion=
https://bugs.webkit.org/show_bug.cgi?id=108291

Reviewed by Ryosuke Niwa.

This accounts for differences in what AppKit gives for accessibility role descriptions between platforms
when the subrole is not recognized, and standardizes it for WebKit.

Unskip a failing Lion test

* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper roleDescription]):

LayoutTests: [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion
https://bugs.webkit.org/show_bug.cgi?id=108291

Reviewed by Ryosuke Niwa.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141559 268f45cc-cd09-0410-ab3c-d52691b4dbfc