WebKit-https.git
10 years agoRubber-stamped by Eric Seidel.
bweinstein@apple.com [Fri, 12 Feb 2010 00:38:44 +0000 (00:38 +0000)]
Rubber-stamped by Eric Seidel.

Turn back on SVG Filters on Windows, as they were accidentally disabled and cause
test breakage.

* win/tools/vsprops/FeatureDefines.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-11 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Fri, 12 Feb 2010 00:36:11 +0000 (00:36 +0000)]
2010-02-11  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Add dummy Cursor
        https://bugs.webkit.org/show_bug.cgi?id=34672

        * platform/brew/CursorBrew.cpp: Added.
        (WebCore::Cursor::Cursor):
        (WebCore::Cursor::~Cursor):
        (WebCore::Cursor::operator=):
        (WebCore::dummyCursor):
        (WebCore::pointerCursor):
        (WebCore::crossCursor):
        (WebCore::handCursor):
        (WebCore::moveCursor):
        (WebCore::iBeamCursor):
        (WebCore::waitCursor):
        (WebCore::helpCursor):
        (WebCore::eastResizeCursor):
        (WebCore::northResizeCursor):
        (WebCore::northEastResizeCursor):
        (WebCore::northWestResizeCursor):
        (WebCore::southResizeCursor):
        (WebCore::southEastResizeCursor):
        (WebCore::southWestResizeCursor):
        (WebCore::westResizeCursor):
        (WebCore::northSouthResizeCursor):
        (WebCore::eastWestResizeCursor):
        (WebCore::northEastSouthWestResizeCursor):
        (WebCore::northWestSouthEastResizeCursor):
        (WebCore::columnResizeCursor):
        (WebCore::rowResizeCursor):
        (WebCore::verticalTextCursor):
        (WebCore::cellCursor):
        (WebCore::contextMenuCursor):
        (WebCore::noDropCursor):
        (WebCore::copyCursor):
        (WebCore::progressCursor):
        (WebCore::aliasCursor):
        (WebCore::noneCursor):
        (WebCore::notAllowedCursor):
        (WebCore::zoomInCursor):
        (WebCore::zoomOutCursor):
        (WebCore::middlePanningCursor):
        (WebCore::eastPanningCursor):
        (WebCore::northPanningCursor):
        (WebCore::northEastPanningCursor):
        (WebCore::northWestPanningCursor):
        (WebCore::southPanningCursor):
        (WebCore::southEastPanningCursor):
        (WebCore::southWestPanningCursor):
        (WebCore::westPanningCursor):
        (WebCore::grabCursor):
        (WebCore::grabbingCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-11 Chris Rogers <crogers@google.com>
eric@webkit.org [Fri, 12 Feb 2010 00:20:02 +0000 (00:20 +0000)]
2010-02-11  Chris Rogers  <crogers@google.com>

        Reviewed by David Levin.

        audio engine: add Complex number class
        https://bugs.webkit.org/show_bug.cgi?id=34538

        * wtf/Complex.h: Added.
        (WebCore::complexFromMagnitudePhase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 11 Feb 2010 23:38:05 +0000 (23:38 +0000)]
2010-02-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        run-chromium-webkit-tests fails random pixel tests on Mac
        https://bugs.webkit.org/show_bug.cgi?id=34862

        This is due to the fact that the Mac port has an
        invalid path to the image diff tool.  Currently it points
        to image_diff even though ImageDiff would be correct.  We
        can't change it to the right path yet without causing the
        script to hang.  ImageDiff expects to be long-running and
        be passed image data over stdin.  image_diff (chromium's fork)
        expects to be passed command line arguments.
        This fix works around the random failures by disabling pixel
        tests on mac and logging if the user was trying to run with pixel
        tests enabled.

        * Scripts/webkitpy/layout_tests/port/mac.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTouch prefix files to force a rebuild, also so anyone who updates will get a working...
bweinstein@apple.com [Thu, 11 Feb 2010 23:23:14 +0000 (23:23 +0000)]
Touch prefix files to force a rebuild, also so anyone who updates will get a working build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a missing semicolon to FeatureDefines.vsprops, so both ENABLE_RUBY and ENABLE_SHA...
bweinstein@apple.com [Thu, 11 Feb 2010 23:15:37 +0000 (23:15 +0000)]
Add a missing semicolon to FeatureDefines.vsprops, so both ENABLE_RUBY and ENABLE_SHARED_WORKERS are parsed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-11 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 11 Feb 2010 22:26:39 +0000 (22:26 +0000)]
2010-02-11  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Add back in a fast path for v8 object wrapping
        when it's not possible we're in a WorkerContext (the fast
        path is important for performance).

        https://bugs.webkit.org/show_bug.cgi?id=34805

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::instantiateV8ObjectInWorkerContext):
        (WebCore::V8DOMWrapper::instantiateV8Object):
        * bindings/v8/V8DOMWrapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTouch JSDOMWindowCustom.cpp to get it to build.
bweinstein@apple.com [Thu, 11 Feb 2010 22:23:40 +0000 (22:23 +0000)]
Touch JSDOMWindowCustom.cpp to get it to build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-11 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 11 Feb 2010 22:20:47 +0000 (22:20 +0000)]
2010-02-11  Gustavo Noronha Silva  <gns@gnome.org>

        Remove platform-specific expected results that only existed
        because we diverged from other ports regarding enabling
        GeoLocation (Apple ports now enable it).

        * platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
        * platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-11 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 11 Feb 2010 22:12:43 +0000 (22:12 +0000)]
2010-02-11  Gustavo Noronha Silva  <gns@gnome.org>

        Rebaseline test after 54646, and skip tests that need results
        generated.

        * platform/gtk/Skipped:
        * platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTouch DOMWindow.idl to force a rebuild of some of the DOM bindings
bweinstein@apple.com [Thu, 11 Feb 2010 22:12:22 +0000 (22:12 +0000)]
Touch DOMWindow.idl to force a rebuild of some of the DOM bindings

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTouch WebKitPrefix.h to force a WebKit rebuild
bweinstein@apple.com [Thu, 11 Feb 2010 21:53:42 +0000 (21:53 +0000)]
Touch WebKitPrefix.h to force a WebKit rebuild

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThat wasn't a fix, rolling it out
bweinstein@apple.com [Thu, 11 Feb 2010 21:44:04 +0000 (21:44 +0000)]
That wasn't a fix, rolling it out

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoHopefully final build fix for Windows (I really mean it this time)
bweinstein@apple.com [Thu, 11 Feb 2010 21:34:56 +0000 (21:34 +0000)]
Hopefully final build fix for Windows (I really mean it this time)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore: Added an SPI for asking about all the different live objects on the...
ggaren@apple.com [Thu, 11 Feb 2010 21:28:52 +0000 (21:28 +0000)]
JavaScriptCore: Added an SPI for asking about all the different live objects on the heap.
Useful for memory debugging.

Reviewed by Oliver Hunt.

* JavaScriptCore.exp: Export the new SPI.

* runtime/Collector.cpp:
(JSC::typeName): Use a little capitalization. Don't crash in the case of
a non-object cell, since it might just be an uninitialized cell.

(JSC::Heap::objectTypeCounts): The new SPI.

* runtime/Collector.h:
* runtime/CollectorHeapIterator.h:
(JSC::CollectorHeapIterator::advance):
(JSC::LiveObjectIterator::operator++):
(JSC::DeadObjectIterator::operator++):
(JSC::ObjectIterator::operator++): Made 2 tweaks to these iterators:
(1) Skip the last cell in the block, since it's a dummy sentinel, and
we don't want it to confuse the object count; (2) Fixed a logic error
in LiveObjectIterator that could cause it to iterate dead objects if
m_block were equal to m_heap.nextBlock and m_cell were less than
m_heap.nextCell. No test for this since I can't think of a way that this
could make WebKit behave badly.

WebKit/mac: Exported some new JavaScript heap introspection.

Reviewed by Oliver Hunt.

* Misc/WebCoreStatistics.h:
* Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics javaScriptObjectTypeCounts]): Just like
javaScriptProtectedObjectTypeCounts, except this function enumerates all
live objects, not just protected objects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTurn off 3D_CANVAS and touch WebCorePrefix.h to force a rebuild.
bweinstein@apple.com [Thu, 11 Feb 2010 21:20:31 +0000 (21:20 +0000)]
Turn off 3D_CANVAS and touch WebCorePrefix.h to force a rebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix for Windows
bweinstein@apple.com [Thu, 11 Feb 2010 21:04:19 +0000 (21:04 +0000)]
Build fix for Windows

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 11 Feb 2010 20:59:23 +0000 (20:59 +0000)]
2010-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Adam Roben.
        Try to fix build breakage from r54665.

        * Scripts/check-for-global-initializers:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 11 Feb 2010 20:53:39 +0000 (20:53 +0000)]
2010-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Small cleanups in SVG render tree code.
        Centralize calls to inflateShadow(), in SVGRenderSupport::computeRectForRepaint,
        instead of spreading them around the subclasses. All classes should inherit
        protected from SVGRenderBase, made it consistent.

        Doesn't affect layout tests.

        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::computeRectForRepaint):
        * rendering/RenderSVGImage.h:
        * rendering/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::computeRectForRepaint):
        * rendering/RenderSVGRoot.h:
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::computeRectForRepaint):
        (WebCore::RenderSVGText::layout):
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderBase::computeRectForRepaint):
        * rendering/SVGRootInlineBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-11 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Thu, 11 Feb 2010 20:44:03 +0000 (20:44 +0000)]
2010-02-11  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        [Chromium] Ignore subsequent requests of the same profiler log
        chunks. This eliminates emission of several instances for the same
        heap snapshot.

        https://bugs.webkit.org/show_bug.cgi?id=34833

        * src/js/ProfilerAgent.js:
        (devtools.ProfilerAgent):
        (devtools.ProfilerAgent.prototype.initializeProfiling):
        (devtools.ProfilerAgent.prototype._getNextLogLines):
        (devtools.ProfilerAgent.prototype.startProfiling):
        (devtools.ProfilerAgent.prototype._didGetActiveProfilerModules):
        (devtools.ProfilerAgent.prototype._didGetLogLines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-11 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 11 Feb 2010 20:40:03 +0000 (20:40 +0000)]
2010-02-11  Xan Lopez  <xlopez@igalia.com>

        Try to fix GTK+ build.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=34857
hyatt@apple.com [Thu, 11 Feb 2010 20:05:51 +0000 (20:05 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=34857
Move InlineIterator and BidiRun into new files so subclasses can access them.

Reviewed by Dan Bernstein.

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/BidiRun.cpp: Added.
(WebCore::BidiRun::destroy):
(WebCore::throw):
(WebCore::BidiRun::operator delete):
* rendering/BidiRun.h: Added.
(WebCore::BidiRun::BidiRun):
(WebCore::BidiRun::next):
* rendering/InlineIterator.h: Added.
(WebCore::InlineIterator::InlineIterator):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::bidiNext):
(WebCore::bidiFirst):
(WebCore::InlineIterator::increment):
(WebCore::InlineIterator::atEnd):
(WebCore::InlineIterator::current):
(WebCore::InlineIterator::direction):
(WebCore::InlineBidiResolver::increment):
(WebCore::InlineBidiResolver::appendRun):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::appendRunsForObject):
(WebCore::RenderBlock::requiresLineBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a PLATFORM(WIN) check for NO_ERROR, attempted build fix
bweinstein@apple.com [Thu, 11 Feb 2010 20:03:33 +0000 (20:03 +0000)]
Add a PLATFORM(WIN) check for NO_ERROR, attempted build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert accidental commit
bweinstein@apple.com [Thu, 11 Feb 2010 20:01:38 +0000 (20:01 +0000)]
Revert accidental commit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAttempt to fix the Windows build
bweinstein@apple.com [Thu, 11 Feb 2010 19:55:20 +0000 (19:55 +0000)]
Attempt to fix the Windows build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTouch WebCorePrefix.h to force a rebuild.
bweinstein@apple.com [Thu, 11 Feb 2010 19:43:40 +0000 (19:43 +0000)]
Touch WebCorePrefix.h to force a rebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-11 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Thu, 11 Feb 2010 19:00:27 +0000 (19:00 +0000)]
2010-02-11  Antonio Gomes <tonikitoo@webkit.org>

    Adjust gstreamer-plugins-base minimum version check (from 0.10 to 0.10.23).

    Reviewed by Xan Lopez.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-11 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 11 Feb 2010 18:55:48 +0000 (18:55 +0000)]
2010-02-11  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Test that Web Inspector can inspect styles of elements in iframe from a domain
        different from main frame domain.

        inspector-tests.js moved to LayoutTests/http/tests/inspector because it can
        be referenced by relative path from LayoutTests/inspector but not vice versa
        (html files served from LayoutTests/http/tests cannot refer it because WebKit
        tests httpd doesn't serve content not under LayoutTests/http).

        https://bugs.webkit.org/show_bug.cgi?id=31587

        * http/tests/inspector/inspect-iframe-from-different-domain-expected.txt: Added.
        * http/tests/inspector/inspect-iframe-from-different-domain.html: Added.
        * http/tests/inspector/inspector-test.js: Renamed from LayoutTests/inspector/inspector-test.js.
        (onload):
        (evaluateInWebInspector):
        (notifyDone):
        (output):
        (didEvaluateForTestInFrontend):
        * http/tests/inspector/resources/iframe-from-different-domain-data.html: Added.
        * inspector/console-clear.html:
        * inspector/console-dir.html:
        * inspector/console-dirxml.html:
        * inspector/console-format-collections-expected.txt:
        * inspector/console-format-collections.html:
        * inspector/console-format.html:
        * inspector/console-log-before-inspector-open.html:
        * inspector/console-tests.html:
        * inspector/cookie-resource-match.html:
        * inspector/elements-img-tooltip.html:
        * inspector/elements-panel-rewrite-href-expected.txt:
        * inspector/elements-panel-rewrite-href.html:
        * inspector/elements-panel-selection-on-refresh.html:
        * inspector/elements-panel-structure.html:
        * inspector/evaluate-in-frontend.html:
        * inspector/inspected-objects-not-overriden.html:
        * inspector/styles-iframe.html:
        * inspector/syntax-highlight-css.html:
        * inspector/syntax-highlight-javascript.html:
        * inspector/timeline-enum-stability.html:
        * inspector/timeline-event-dispatch.html:
        * inspector/timeline-layout.html:
        * inspector/timeline-mark-timeline.html:
        * inspector/timeline-network-resource.html:
        * inspector/timeline-paint.html:
        * inspector/timeline-parse-html.html:
        * inspector/timeline-recalculate-styles.html:
        * inspector/timeline-script-tag-1.html:
        * inspector/timeline-script-tag-2.html:
        * inspector/timeline-trivial.html:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixes CodeGeneratorV8.pm to include the header for the indexer type when using setCol...
steveblock@google.com [Thu, 11 Feb 2010 18:27:49 +0000 (18:27 +0000)]
Fixes CodeGeneratorV8.pm to include the header for the indexer type when using setCollectionIndexedGetter()
https://bugs.webkit.org/show_bug.cgi?id=34836

setCollectionIndexedGetter() uses getIndexedPropertyOfCollection(),
which in turn uses toV8() with the indexer type, which is declared in
the header for the indexer type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-11 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 11 Feb 2010 17:16:57 +0000 (17:16 +0000)]
2010-02-11  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: split source code into chunks in order to improve text
        viewer performance on large files.

        https://bugs.webkit.org/show_bug.cgi?id=34816

        This change brings back SourceFrame's canvas+style magic, restores line
        wrapping and makes things a lot like they used to be.
        It removes TextEditor for now and renames NativeTextViewer into TextViewer.
        TextViewer is no longer derived from TextEditor.
        This TextViewer is still based on TextEditorModel, no iframes are involved.

        Instead of creating div per line, TextViewer splits source code into 50 line
        chunks. Upon scroll event, visible chunks are sharded into lines and individual
        lines are highlighted. Whenever highlighted region gets outside of the visible
        area, highlight spans are thrown away and region is replaced with the original
        plain text chunk.

        Complex stuff:
        - Whenever there is a need to manipulate individual lines (add message bubble /
        set breakpoint / reveal / etc.), individual chunks for such lines are created.
        - There is also an implicit machinery that is maintaining selection when it
        goes beyond the visible area.
        - Search occurrences are implemented as artificial spans interweaving
        highlighting markup.

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/NativeTextViewer.js: Removed.
        * inspector/front-end/ScriptView.js:
        (WebInspector.ScriptView):
        * inspector/front-end/Settings.js:
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame):
        (WebInspector.SourceFrame.prototype.set visible):
        (WebInspector.SourceFrame.prototype.set executionLine):
        (WebInspector.SourceFrame.prototype.revealLine):
        (WebInspector.SourceFrame.prototype.addBreakpoint):
        (WebInspector.SourceFrame.prototype.removeBreakpoint):
        (WebInspector.SourceFrame.prototype.addMessage):
        (WebInspector.SourceFrame.prototype.clearMessages):
        (WebInspector.SourceFrame.prototype.sizeToFitContentHeight):
        (WebInspector.SourceFrame.prototype.setContent):
        (WebInspector.SourceFrame.prototype.highlightLine):
        (WebInspector.SourceFrame.prototype._createViewerIfNeeded):
        (WebInspector.SourceFrame.prototype.markAndRevealRange):
        (WebInspector.SourceFrame.prototype.clearMarkedRange):
        (WebInspector.SourceFrame.prototype._breakpointChanged):
        (WebInspector.SourceFrame.prototype._updateExecutionLine):
        (WebInspector.SourceFrame.prototype._addMessageToSource):
        (WebInspector.SourceFrame.prototype._addExistingBreakpointsToSource):
        (WebInspector.SourceFrame.prototype._addBreakpointToSource):
        (WebInspector.SourceFrame.prototype._removeBreakpointFromSource):
        (WebInspector.SourceFrame.prototype._mouseDown):
        (WebInspector.SourceFrame.prototype._editBreakpointCondition.committed):
        (WebInspector.SourceFrame.prototype._editBreakpointCondition.dismissed):
        (WebInspector.SourceFrame.prototype._editBreakpointCondition):
        (WebInspector.SourceFrame.prototype._showBreakpointConditionPopup):
        (WebInspector.SourceFrame.prototype._createConditionElement):
        (WebInspector.SourceFrame.prototype._keyDown):
        (WebInspector.SourceFrame.prototype.resize):
        (WebInspector.SourceFrame.prototype._drawProgramCounterInContext):
        (WebInspector.SourceFrame.prototype._drawProgramCounterImageIfNeeded):
        (WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded.drawBreakpoint):
        (WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView):
        (WebInspector.SourceView.prototype._removeBreakpoint):
        (WebInspector.SourceView.prototype.searchCanceled):
        (WebInspector.SourceView.prototype._jumpToSearchResult):
        * inspector/front-end/TextEditor.js: Removed.
        * inspector/front-end/TextViewer.js: Added.
        (WebInspector.TextViewer):
        (WebInspector.TextViewer.prototype.set mimeType):
        (WebInspector.TextViewer.prototype.get textModel):
        (WebInspector.TextViewer.prototype.revealLine):
        (WebInspector.TextViewer.prototype.addDecoration):
        (WebInspector.TextViewer.prototype.removeDecoration):
        (WebInspector.TextViewer.prototype.markAndRevealRange):
        (WebInspector.TextViewer.prototype.highlightLine):
        (WebInspector.TextViewer.prototype._textChanged):
        (WebInspector.TextViewer.prototype._createChunkRow):
        (WebInspector.TextViewer.prototype._makeLineAChunk):
        (WebInspector.TextViewer.prototype._indexChunks):
        (WebInspector.TextViewer.prototype._highlightChanged):
        (WebInspector.TextViewer.prototype._scroll):
        (WebInspector.TextViewer.prototype.setCoalescingUpdate):
        (WebInspector.TextViewer.prototype._repaintAll):
        (WebInspector.TextViewer.prototype._chunkForOffset):
        (WebInspector.TextViewer.prototype._chunkNumberForLine):
        (WebInspector.TextViewer.prototype._chunkStartLine):
        (WebInspector.TextViewer.prototype._restoreChunks):
        (WebInspector.TextViewer.prototype._repaint):
        (WebInspector.TextViewer.prototype._getSelection):
        (WebInspector.TextViewer.prototype._restoreSelection):
        (WebInspector.TextViewer.prototype._selectionToPosition):
        (WebInspector.TextViewer.prototype._createLineRow):
        (WebInspector.TextViewer.prototype._paintLine):
        (WebInspector.TextViewer.prototype._createSpan):
        (WebInspector.TextViewer.prototype._createLink):
        (WebInspector.TextViewer.prototype._rewriteHref):
        (WebInspector.TextViewer.prototype._markRange):
        (WebInspector.TextViewer.prototype._decimalDigits):
        (WebInspector.TextViewer.prototype.resize):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:
        * inspector/front-end/textEditor.css: Removed.
        * inspector/front-end/textViewer.css: Added.
        * inspector/front-end/utilities.js:
        (Node.prototype.traverseNextTextNode):
        (Node.prototype.rangeBoundaryForOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] ENABLE_RUBY flag was restored by r54649, but default value wasn't added for...
ossy@webkit.org [Thu, 11 Feb 2010 16:18:43 +0000 (16:18 +0000)]
[Qt] ENABLE_RUBY flag was restored by r54649, but default value wasn't added for Qt port.
https://bugs.webkit.org/show_bug.cgi?id=34698

Reviewed by Tor Arne Vestbø.

* WebCore.pri: Add ENABLE_RUBY=1 as default setting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGuard cmath using declarations in MathExtras.h on Android
steveblock@google.com [Thu, 11 Feb 2010 16:03:40 +0000 (16:03 +0000)]
Guard cmath using declarations in MathExtras.h on Android
https://bugs.webkit.org/show_bug.cgi?id=34840

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake it possible to toggle accelerated compositing from the menu
hausmann@webkit.org [Thu, 11 Feb 2010 15:44:45 +0000 (15:44 +0000)]
Make it possible to toggle accelerated compositing from the menu
at run-time.

Reviewed by Tor Arne Vestbø.

* QtLauncher/main.cpp:
(LauncherWindow::toggleAcceleratedCompositing):
(LauncherWindow::setupUI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-11 Steve Block <steveblock@google.com>
steveblock@google.com [Thu, 11 Feb 2010 13:29:36 +0000 (13:29 +0000)]
2010-02-11  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Updates Android V8 Makefile to generate Notifications and WebSockets headers required by V8DOMWrapper.cpp
        https://bugs.webkit.org/show_bug.cgi?id=34815

        No new tests, build fix only.

        * Android.derived.v8bindings.mk:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-11 Steve Block <steveblock@google.com>
steveblock@google.com [Thu, 11 Feb 2010 13:27:30 +0000 (13:27 +0000)]
2010-02-11  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Updates Android V8 Makefile to generate XPath header required by V8Proxy.cpp
        https://bugs.webkit.org/show_bug.cgi?id=34814

        No new tests, build fix only.

        * Android.derived.v8bindings.mk:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate Android V8 Makefile to generate Inspector headers required by V8 ScriptObject.cpp
steveblock@google.com [Thu, 11 Feb 2010 11:40:45 +0000 (11:40 +0000)]
Update Android V8 Makefile to generate Inspector headers required by V8 ScriptObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=34806

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGuards SVG code in V8 bindings with ENABLE(SVG)
steveblock@google.com [Thu, 11 Feb 2010 11:27:20 +0000 (11:27 +0000)]
Guards SVG code in V8 bindings with ENABLE(SVG)
https://bugs.webkit.org/show_bug.cgi?id=34812

Also updates Android V8 Makefile to generate required SVG headers.

No new tests, build fix only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-08 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 11 Feb 2010 10:55:39 +0000 (10:55 +0000)]
2010-02-08  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
        https://bugs.webkit.org/show_bug.cgi?id=34698

        * Configurations/FeatureDefines.xcconfig:
2010-02-08  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
        https://bugs.webkit.org/show_bug.cgi?id=34698

        * win/tools/vsprops/FeatureDefines.vsprops:
2010-02-08  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
        https://bugs.webkit.org/show_bug.cgi?id=34698

        * Configurations/FeatureDefines.xcconfig:
2010-02-08  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
        https://bugs.webkit.org/show_bug.cgi?id=34698

        * Configurations/FeatureDefines.xcconfig:
        * DerivedSources.make:
        * GNUmakefile.am:
        * html/HTMLTagNames.in: Make the ruby-related tag names conditional.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createObject): ifdef the code that would create ruby elements.
        * rendering/RenderObject.h: ditto above
        * rendering/RenderRuby.cpp: ifdef this whole file
        * rendering/RenderRuby.h: ditto
        * rendering/RenderRubyBase.cpp: ditto
        * rendering/RenderRubyBase.h: ditto
        * rendering/RenderRubyRun.cpp: ditto
        * rendering/RenderRubyRun.h: ditto
        * rendering/RenderRubyText.cpp: ditto
        * rendering/RenderRubyText.h: ditto
2010-02-08  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
        https://bugs.webkit.org/show_bug.cgi?id=34698

        * configure.ac:
2010-02-08  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
        https://bugs.webkit.org/show_bug.cgi?id=34698

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Rubber-stamped by Kenneth Rohde Christiansen.
abecsi@webkit.org [Thu, 11 Feb 2010 09:26:07 +0000 (09:26 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.

    [Qt] Update expected results for the following tests after r54646 because of ImageData support.

    * platform/qt/fast/dom/Window/window-properties-expected.txt:
    * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
    * platform/qt/fast/dom/prototype-inheritance-expected.txt:
    * platform/qt/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-11 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 11 Feb 2010 08:34:10 +0000 (08:34 +0000)]
2010-02-11  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Step attribute support for date&time types.
        https://bugs.webkit.org/show_bug.cgi?id=30847

        Add tests for ValidityState.stepMismatch, stepUp() and stepDown()
        for date, datetime, datetime-local, month, time, week types.
        Update valueAsDate and valueAsNumber tests for a string representation
        change.

        * fast/forms/ValidityState-stepMismatch-expected.txt: Added.
        * fast/forms/ValidityState-stepMismatch.html: Added.
        * fast/forms/input-stepup-stepdown-expected.txt: Added.
        * fast/forms/input-stepup-stepdown.html: Added.
        * fast/forms/input-valueasdate-datetime-expected.txt:
        * fast/forms/input-valueasdate-time-expected.txt:
        * fast/forms/input-valueasnumber-datetime-expected.txt:
        * fast/forms/input-valueasnumber-datetimelocal-expected.txt:
        * fast/forms/input-valueasnumber-time-expected.txt:
        * fast/forms/script-tests/ValidityState-stepMismatch.js: Added.
        * fast/forms/script-tests/input-stepup-stepdown.js: Added.
        * fast/forms/script-tests/input-valueasdate-datetime.js:
        * fast/forms/script-tests/input-valueasnumber-datetime.js:

2010-02-11  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Step attribute support for date&time types.
        https://bugs.webkit.org/show_bug.cgi?id=30847

        - Add implementation for ValidityState.stepMismatch, stepUp() and
          stepDown() for date, datetime, datetime-local, month, time, week types.
        - Fix string representation of DateComponents.

        Tests: fast/forms/ValidityState-stepMismatch.html
               fast/forms/input-stepup-stepdown.html

        * html/HTMLInputElement.cpp:
          - Change monthDefaultMaximum so that DateComponents::m_year doesn't overflow.
        (WebCore::HTMLInputElement::stepBase):
        (WebCore::HTMLInputElement::stepMismatch):
        (WebCore::HTMLInputElement::getStepParameters):
        (WebCore::HTMLInputElement::getAllowedValueStep):
        (WebCore::HTMLInputElement::applyStep):
          Renamed from applyStepForNumberOrRange(), and add support for other types.
        (WebCore::HTMLInputElement::stepUp): Rename applyStepForNumberOrRange().
        (WebCore::HTMLInputElement::stepDown): Rename applyStepForNumberOrRange().
        (WebCore::HTMLInputElement::setValueAsDate): Use setDateValue().
        (WebCore::HTMLInputElement::setDateValue):
          A helper function to make the best representation of DateComponents.
        (WebCore::HTMLInputElement::setValueAsNumber):  Use setDateValue().
        * html/HTMLInputElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 11 Feb 2010 08:30:34 +0000 (08:30 +0000)]
2010-02-10  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        postMessage does not send ImageData
        https://bugs.webkit.org/show_bug.cgi?id=34825

        Add test for postMessage passing ImageData

        Update a few other tests to cover the fact that ImageData's constructor
        is now available on the window object.

        * fast/dom/Window/window-postmessage-clone-expected.txt:
        * fast/dom/Window/window-postmessage-clone.html:
        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/Window/window-property-descriptors-expected.txt:
        * fast/dom/prototype-inheritance-2-expected.txt:
        * fast/dom/prototype-inheritance-expected.txt:
        * fast/js/global-constructors-expected.txt:
2010-02-10  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        postMessage does not send ImageData
        https://bugs.webkit.org/show_bug.cgi?id=34825

        Implement serialisation of ImageData, and for testing reasons
        expose the ImageData constructor (which should already have
        been exposed).

        * bindings/js/SerializedScriptValue.cpp:
        (WebCore::SerializedImageData::create):
        (WebCore::SerializedImageData::width):
        (WebCore::SerializedImageData::height):
        (WebCore::SerializedImageData::data):
        (WebCore::SerializedImageData::SerializedImageData):
        (WebCore::SerializedScriptValueData::SerializedScriptValueData):
        (WebCore::SharedSerializedData::asImageData):
        (WebCore::SerializingTreeWalker::convertIfTerminal):
        (WebCore::DeserializingTreeWalker::convertIfTerminal):
        (WebCore::TeardownTreeWalker::convertIfTerminal):
        * bindings/js/SerializedScriptValue.h:
        (WebCore::SerializedScriptValueData::):
        (WebCore::SerializedScriptValueData::asImageData):
        * html/canvas/CanvasPixelArray.h:
        (WebCore::CanvasPixelArray::data):
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 11 Feb 2010 07:32:08 +0000 (07:32 +0000)]
2010-02-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Address last round of review comments on r53607
        https://bugs.webkit.org/show_bug.cgi?id=33940

        Mostly renaming and cleaning up.

        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::insertedIntoParent):
        * css/CSSStyleSheet.h:
        (WebCore::CSSStyleSheet::create):
        (WebCore::CSSStyleSheet::createInline):
        * css/StyleBase.cpp:
        (WebCore::StyleBase::baseURL):
        * css/StyleSheet.cpp:
        (WebCore::StyleSheet::StyleSheet):
        * css/StyleSheet.h:
        (WebCore::StyleSheet::href):
        (WebCore::StyleSheet::setFinalURL):
        (WebCore::StyleSheet::finalURL):
        * dom/Document.cpp:
        (WebCore::Document::updateBaseURL):
        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::checkStyleSheet):
        * xml/XSLImportRule.cpp:
        (WebCore::XSLImportRule::loadSheet):
        * xml/XSLStyleSheet.h:
        (WebCore::XSLStyleSheet::create):
        (WebCore::XSLStyleSheet::createInline):
        * xml/XSLStyleSheetLibxslt.cpp:
        (WebCore::XSLStyleSheet::XSLStyleSheet):
        (WebCore::XSLStyleSheet::parseString):
        (WebCore::XSLStyleSheet::loadChildSheets):
        * xml/XSLStyleSheetQt.cpp:
        (WebCore::XSLStyleSheet::XSLStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Thu, 11 Feb 2010 07:14:33 +0000 (07:14 +0000)]
2010-02-10  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] GraphicsLayer: somtimes the item flickers at the end of an animation
        This is because we try to delete the animation when finished: that is
        unnecessary. WebCore manages the animation's lifecycle and makes sure
        to call the right function when the animation can be deleted.

        https://bugs.webkit.org/show_bug.cgi?id=34761

        No new tests.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQt::addAnimation): No need to delete here
        (WebCore::GraphicsLayerQt::removeAnimationsForProperty): deleteLater

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Build fix for wxMac/Cocoa.
kevino@webkit.org [Thu, 11 Feb 2010 06:51:40 +0000 (06:51 +0000)]
[wx] Build fix for wxMac/Cocoa.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(24929): PDF page doesn't load in background tab
jhoneycutt@apple.com [Thu, 11 Feb 2010 06:27:06 +0000 (06:27 +0000)]
REGRESSION(24929): PDF page doesn't load in background tab

Reviewed by Dan Bernstein.

* plugins/PluginView.cpp:
(WebCore::PluginView::startOrAddToUnstartedList):
Only delay loading of the plug-in if we'll kick off our own load of the
plug-in data later, in start().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash in WebKit!WebCore::RenderTextControlSingleLine::createInnerTextStyle doing...
enrica@apple.com [Thu, 11 Feb 2010 03:58:44 +0000 (03:58 +0000)]
Crash in WebKit!WebCore::RenderTextControlSingleLine::createInnerTextStyle doing anything in Safari after sitting on a page with 3D site
<rdar://problem/7557201>
https://bugs.webkit.org/show_bug.cgi?id=34823

Reviewed by Simon Fraser.

No tests added because the code is exercised by the existing tests.

The root cause was the fact that we were not releasing a reference that was held by CA.
In debug builds we had an assert in the destructor of WKCACFLayer.

* platform/graphics/win/GraphicsLayerCACF.cpp:
(WebCore::GraphicsLayerCACF::~GraphicsLayerCACF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 James Hawkins <jhawkins@chromium.org>
eric@webkit.org [Thu, 11 Feb 2010 03:47:38 +0000 (03:47 +0000)]
2010-02-10  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] Remove code from SuggestionsPopup that was removed in a
        previous revision of AutocompletePopup and accidentally added back in
        the refactoring.

        https://bugs.webkit.org/show_bug.cgi?id=34818

        * src/AutoFillPopupMenuClient.cpp:
        * src/AutoFillPopupMenuClient.h: Added property svn:eol-style.
        * src/SuggestionsPopupMenuClient.cpp:
        (WebKit::SuggestionsPopupMenuClient::popupDidHide):
        (WebKit::SuggestionsPopupMenuClient::setTextFromItem):
        (WebKit::SuggestionsPopupMenuClient::initialize):
        * src/SuggestionsPopupMenuClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 11 Feb 2010 03:30:59 +0000 (03:30 +0000)]
2010-02-10  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Typedef DragImageRef
        https://bugs.webkit.org/show_bug.cgi?id=34791

        Use IImage* as it is the BREW's image type.

        * platform/DragImage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=34185 REGRESSION:
bdakin@apple.com [Thu, 11 Feb 2010 03:04:38 +0000 (03:04 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=34185 REGRESSION:
Mask not invalidating

Reviewed by Simon Fraser and Darin Adler.

SVGMaskElement is the only class that keeps a HashMap of canvas
resources rather than just a pointer to a resource. This
patch makes SVGMaskElement invalidate all of its resources in the
HashMap instead of just one.

* svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::svgAttributeChanged):
(WebCore::SVGMaskElement::childrenChanged):
(WebCore::SVGMaskElement::invalidateCanvasResources):
* svg/SVGMaskElement.h:
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::invalidateResourcesInAncestorChain):
(WebCore::SVGStyledElement::invalidateCanvasResources):
* svg/SVGStyledElement.h:

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=34185 REGRESSION:
Mask not invalidating

Reviewed by Simon Fraser and Darin Adler.

* platform/mac/svg/custom/mask-invalidation-expected.checksum: Added.
* platform/mac/svg/custom/mask-invalidation-expected.png: Added.
* platform/mac/svg/custom/mask-invalidation-expected.txt: Added.
* svg/custom/mask-invalidation.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Stephan Aßmus <superstippi@gmx.de>
eric@webkit.org [Thu, 11 Feb 2010 02:46:59 +0000 (02:46 +0000)]
2010-02-10  Stephan Aßmus  <superstippi@gmx.de>

        Reviewed by David Levin.

        Fixes to rect conversion and image rendering on Haiku
        https://bugs.webkit.org/show_bug.cgi?id=34684

        Covered by existing tests.

        The changes to the rect conversions are indeed correct. In Haiku (to stay
        compatibly with BeOS), a BRect specifies the left/top and bottom/right pixel
        *indices*, even though the values are floating point. So a rectangle covering
        just one pixel would be specified as BRect(0, 0, 0, 0). In WebCore and other
        frame works, such rectangles would be expressed as 0, 0, 1, 1. In WebCore, the
        width and height of rectangles refer to the distance between pixels, while on
        Haiku, a one pixel rect has indeed a width and height of 0, as confusing as
        that may be.

        The part of the patch that affects
        WebCore/platform/graphics/haiku/ImageHaiku.cpp also implements the drawing
        methods more correctly. Image observers are notified, and pattern drawing takes
        the "phase" into account which makes scrolled backgrounds render correctly.
        Transformations are still not supported, since the Haiku drawing backend itself
        does not yet support them.

        Use OwnPtr when creating the BBitmap to avoid future leaks with early returns.

        Convert the bitmap data to non pre-multiplied until Haiku supports drawing
        pre-multiplied bitmaps.

        * platform/graphics/haiku/FloatRectHaiku.cpp: Fixed conversion
        * platform/graphics/haiku/ImageHaiku.cpp:
        (WebCore::BitmapImage::draw): Fixed placement, notify observers
        (WebCore::Image::drawPattern): Implemented using "phase" to fix scrolling, notify observers
        * platform/graphics/haiku/IntRectHaiku.cpp: Fixed conversion
        * platform/image-decoders/haiku/ImageDecoderHaiku.cpp: Fixed conversion

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 11 Feb 2010 02:05:07 +0000 (02:05 +0000)]
2010-02-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by David Levin.

        Clean up unused member var and initialization in Document
        https://bugs.webkit.org/show_bug.cgi?id=34820

        Remove unused m_secureForms member variable in Document.

        * dom/Document.cpp:
        (WebCore::Document::Document):
        * dom/Document.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Dirk Pranke <dpranke@chromium.org>
eric@webkit.org [Thu, 11 Feb 2010 01:50:45 +0000 (01:50 +0000)]
2010-02-10  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Fix various minor bugs keeping run-chromium-webkit-tests from actually
        working on the linux and win ports of Chromium.

        https://bugs.webkit.org/show_bug.cgi?id=34739

        * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
        * Scripts/webkitpy/layout_tests/port/__init__.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 11 Feb 2010 01:24:04 +0000 (01:24 +0000)]
2010-02-10  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        run-chromium-webkit-tests --platform=mac-leopard crashes when using a custom build directory
        https://bugs.webkit.org/show_bug.cgi?id=34817

        This doesn't fix the root cause of us not
        correctly failing when support binaries are missing.
        This only causes the DumpRenderTree binary not to be
        missing in the custom build directory case.
        Later patches will make us correctly fail fast when
        support binaries (like DumpRenderTree or ImageDiff) are missing.

        * Scripts/webkit-build-directory: Added.
         - Need a way to re-use the perl logic for finding build directories in non-perl scripts.
        * Scripts/webkitpy/layout_tests/port/base.py: Add a FIXME.
        * Scripts/webkitpy/layout_tests/port/mac.py:
         - Call webkit-build-directory to find the build directory instead of assuming "WebKitBuild"
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Add FIXMEs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Thu, 11 Feb 2010 01:22:52 +0000 (01:22 +0000)]
Reviewed by Kevin Ollivier.

[wx] Add Windows complex text support and Mac support for containsCharacters.

https://bugs.webkit.org/show_bug.cgi?id=34759

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 11 Feb 2010 00:54:40 +0000 (00:54 +0000)]
2010-02-10  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Add dummy Frame::dragImageForSelection
        https://bugs.webkit.org/show_bug.cgi?id=34792

        Add FrameBrew.cpp which contains a dummy implementation of
        Frame::dragImageForSelection.

        * page/brew/FrameBrew.cpp: Added.
        (WebCore::Frame::dragImageForSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Build fixes. Move drawPattern implementation to the Image class like other platf...
kevino@webkit.org [Thu, 11 Feb 2010 00:24:48 +0000 (00:24 +0000)]
[wx] Build fixes. Move drawPattern implementation to the Image class like other platforms have it, and add a stub for a new LayoutTestController method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Added CA_PRINT_TREE functionality to WKCACFLayer implementation
cmarrin@apple.com [Thu, 11 Feb 2010 00:11:24 +0000 (00:11 +0000)]
    Added CA_PRINT_TREE functionality to WKCACFLayer implementation
        https://bugs.webkit.org/show_bug.cgi?id=34779

        I've tried to duplicate the look of the output on Mac, but
        it's not quite the same. It shows all the useful information though.
        It is enabled by setting the environment variable CA_PRINT_TREE=1

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 11 Feb 2010 00:08:31 +0000 (00:08 +0000)]
2010-02-10  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Change V8DOMWrapper::lookupDOMWrapper() and configureTemplate()
        to not use V8ClassIndex.

        https://bugs.webkit.org/show_bug.cgi?id=34768

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8Binding.cpp:
        * bindings/v8/V8Binding.h:
        * bindings/v8/V8DOMWindowShell.cpp:
        * bindings/v8/V8DOMWrapper.cpp:
        * bindings/v8/V8DOMWrapper.h:
        * bindings/v8/V8Proxy.cpp:
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        * bindings/v8/custom/V8LocationCustom.cpp:
        * bindings/v8/custom/V8MessageEventCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Roll out r54626, because it broke GTK and Win build.
ossy@webkit.org [Thu, 11 Feb 2010 00:05:31 +0000 (00:05 +0000)]
Unreviewed. Roll out r54626, because it broke GTK and Win build.
https://bugs.webkit.org/show_bug.cgi?id=32717

WebKitTools:

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:

LayoutTests:

* platform/mac/Skipped:
* platform/mac/fast/frames/flattening: Removed.
* platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Removed.
* platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt: Removed.
* platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.txt: Removed.
* platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Removed.
* platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 10 Feb 2010 23:30:46 +0000 (23:30 +0000)]
2010-02-10  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Handle the possibility that ScheduledAction::execute() may
        retrieve a null V8Proxy* even if not in a WorkerContext (e.g., if
        JS was disallowed).

        * bindings/v8/ScheduledAction.cpp:
        (WebCore::ScheduledAction::execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
eric@webkit.org [Wed, 10 Feb 2010 23:23:06 +0000 (23:23 +0000)]
2010-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Support frameset flattening
        https://bugs.webkit.org/show_bug.cgi?id=32717

        Add expected results of the FrameSet Flattening tests.

        * platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
        * platform/mac/Skipped:
2010-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Support frameset flattening
        https://bugs.webkit.org/show_bug.cgi?id=32717

        Add FrameSet Flattening support to Mac DRT.

        * DumpRenderTree/LayoutTestController.cpp:
        (setFrameSetFlatteningEnabledCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setFrameSetFlatteningEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Kenneth Russell <kbr@google.com>
eric@webkit.org [Wed, 10 Feb 2010 23:04:56 +0000 (23:04 +0000)]
2010-02-10  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Remove automatic viewport resizing
        https://bugs.webkit.org/show_bug.cgi?id=34766

        Removed automatic viewport resizing per conclusions on the WebGL
        mailing list. Added test verifying new behavior and updated a
        couple of previous tests failing after this change.

        * fast/canvas/webgl/gl-get-calls-expected.txt:
        * fast/canvas/webgl/gl-get-calls.html:
        * fast/canvas/webgl/texImage2DImageDataTest.html:
        * fast/canvas/webgl/viewport-unchanged-upon-resize-expected.txt: Added.
        * fast/canvas/webgl/viewport-unchanged-upon-resize.html: Added.
2010-02-10  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Remove automatic viewport resizing
        https://bugs.webkit.org/show_bug.cgi?id=34766

        Removed automatic viewport resizing per conclusions on the WebGL
        mailing list. Added test verifying new behavior and updated a
        couple of previous tests failing after this change.

        Test: fast/canvas/webgl/viewport-unchanged-upon-resize.html

        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        (WebCore::GraphicsContext3D::reshape):
2010-02-10  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Remove automatic viewport resizing
        https://bugs.webkit.org/show_bug.cgi?id=34766

        Removed automatic viewport resizing per conclusions on the WebGL
        mailing list. Added test verifying new behavior and updated a
        couple of previous tests failing after this change.

        * src/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3DInternal::reshape):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Ariya Hidayat <ariya.hidayat@gmail.com>
ariya@webkit.org [Wed, 10 Feb 2010 22:37:05 +0000 (22:37 +0000)]
2010-02-10  Ariya Hidayat  <ariya.hidayat@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Implement image interpolation quality.

        https://bugs.webkit.org/show_bug.cgi?id=34629

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
        (WebCore::GraphicsContext::setImageInterpolationQuality):
        (WebCore::GraphicsContext::imageInterpolationQuality):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 10 Feb 2010 22:01:03 +0000 (22:01 +0000)]
2010-02-10  Eric Seidel  <eric@webkit.org>

        No review, Mac build fix.

        Crash in Flash at http://www.cctv.com/
        https://bugs.webkit.org/show_bug.cgi?id=34673

        * plugins/PluginViewNone.cpp:
        (WebCore::PluginView::getValueStatic):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore
kov@webkit.org [Wed, 10 Feb 2010 21:26:31 +0000 (21:26 +0000)]
WebCore

2010-02-10  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Xan Lopez.

        [GTK] Hits assertion on history back, with page cache enabled, in specific conditions
        https://bugs.webkit.org/show_bug.cgi?id=34773

        When unsetting the adjustments from a ScrollView, also disconnect
        them from the Scrollbars.

        Test: fast/frames/frame-crash-with-page-cache.html

        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::setGtkAdjustments):
        * platform/gtk/ScrollbarGtk.cpp:
        (ScrollbarGtk::~ScrollbarGtk):
        (ScrollbarGtk::detachAdjustment):
        * platform/gtk/ScrollbarGtk.h:

LayoutTests

2010-02-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [GTK] Hits assertion on history back, with page cache enabled, in specific conditions
        https://bugs.webkit.org/show_bug.cgi?id=34773

        * fast/frames/frame-crash-with-page-cache.html: Added.
        * fast/frames/resources/cached-page-1.html: Added.
        * fast/frames/resources/cached-page-2.html: Added.
        * fast/frames/resources/cached-page-3.html: Added.
        * fast/frames/resources/cached-page-iframe.html: Added.

WebKit/gtk

2010-02-09  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Xan Lopez.

        [GTK] Hits assertion on history back, with page cache enabled, in specific conditions
        https://bugs.webkit.org/show_bug.cgi?id=34773

        Make sure cached frames have their scrollbars disconnected from
        the WebView's adjustments.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::savePlatformDataToCachedFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Addressing issues found by style bot.
ap@apple.com [Wed, 10 Feb 2010 21:18:50 +0000 (21:18 +0000)]
    Addressing issues found by style bot.

        * wtf/ValueCheck.h: Renamed header guard to match final file name.

        * wtf/Vector.h: (WTF::::checkConsistency): Remove braces around a one-line clause.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Geoffrey Garen.
ap@apple.com [Wed, 10 Feb 2010 21:14:24 +0000 (21:14 +0000)]
    Reviewed by Geoffrey Garen.

        https://bugs.webkit.org/show_bug.cgi?id=34490
        WebCore::ImageEventSender::dispatchPendingEvents() crashes in certain conditions

        Test: fast/images/destroyed-image-load-event.html

        * ForwardingHeaders/wtf/ValueCheck.h: Added.

        * loader/ImageLoader.cpp:
        (WTF::ValueCheck): Special case value check for ImageLoader - it's allocated inside elements,
        so check the owner instead.
        (WebCore::ImageEventSender::hasPendingEvents): Added a debugging aid for ImageLoader destructor.
        (WebCore::ImageLoader::~ImageLoader): Assert that we're not going to leave dangling pointers
        in ImageEventSender.
        (WebCore::ImageLoader::setImage): Cancel events that could be dispatched for the previous
        image. The only client using this method that I could find was DeleteButton, which doesn't
        care about load events for the new image, so I didn't add any code for firing those.
        (WebCore::ImageLoader::setLoadingImage): This method only existed to confuse readers -
        there wasn't any meaningful code shared (callers just undid most assignments made there).
        Merged the logic into callers.
        (WebCore::ImageLoader::updateFromElement): We're forgetting the old image, so forget its
        old events, too.
        (WebCore::ImageLoader::notifyFinished): This can be called from setImage(), in which case
        no one is going to dispatch the event "soon". So, don't queue it.
        (WebCore::ImageEventSender::dispatchPendingEvents): Call checkConsistency(). This didn't
        help catch this particuar bug, but seems like a useful check anyway.

        * loader/ImageLoader.h: Removed setLoadingImage().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac build fix. Unreviewed.
jhoneycutt@apple.com [Wed, 10 Feb 2010 21:08:17 +0000 (21:08 +0000)]
Mac build fix. Unreviewed.

* WebCore.xcodeproj/project.pbxproj:
Add PluginViewNone.cpp to the Mac project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOptimize ImageBuffer::toDataURL's CG implementation
aroben@apple.com [Wed, 10 Feb 2010 21:05:55 +0000 (21:05 +0000)]
Optimize ImageBuffer::toDataURL's CG implementation

There was some unused code that could have been removed in r31830 when
this function was changed not to flip the CG image anymore.

Fixes <http://webkit.org/b/34808> ImageBuffer::toDataURL allocates
unnecessary memory under CoreGraphics

Reviewed by Sam Weinig.

* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::toDataURL): Don't allocate an unused CGImageRef
and buffer, and switch to the new overload of base64Encode that
doesn't require us to copy all the image data into a Vector first.

* platform/text/Base64.cpp:
(WebCore::base64Encode):
* platform/text/Base64.h:
Added an overload that takes a raw data pointer and length, just like
we have for base64Decode. The overload that takes a Vector as input
just calls through to the new overload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoComplete the fix for <rdar://problem/7577604> Drag and Drop: background elements...
mitz@apple.com [Wed, 10 Feb 2010 21:02:40 +0000 (21:02 +0000)]
Complete the fix for <rdar://problem/7577604> Drag and Drop: background elements are bleeding through
https://bugs.webkit.org/show_bug.cgi?id=34546

Reviewed by Dave Hyatt.

* manual-tests/drag-image-table-part-decorations.html:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paint): Don’t paint collapsed borders if this object shouldn’t
paint within the current painting root.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7436875> Crash in Flash when visiting
jhoneycutt@apple.com [Wed, 10 Feb 2010 20:18:29 +0000 (20:18 +0000)]
<rdar://problem/7436875> Crash in Flash when visiting
http://www.cctv.com/default.shtml (WER ID 819298200) [watson 2502260]

Reviewed by Darin Adler.

WebCore:

Test: platform/win/plugins/plugin-delayed-destroy.html

* bridge/NP_jsobject.cpp:
(_NPN_Evaluate):
If Flash calls this to evaluate a script that destroys the PluginView,
we crash when returning to Flash code. Before evaluating the script,
call PluginView::keepAlive() to hold a ref to this instance (and release
it asynchronously).

* plugins/PluginView.cpp:
(WebCore::instanceMap):
Return a map from the NPP to the PluginView.
(WebCore::PluginView::~PluginView):
Assert that the keep alive timer is not running; remove ourselves from
the instance map.
(WebCore::PluginView::performRequest):
The parent Frame is now a RefPtr; use .get().
(WebCore::PluginView::status):
Ditto.
(WebCore::PluginView::didReceiveResponse):
Ditto.
(WebCore::PluginView::PluginView):
Add the view to the instance map.
(WebCore::PluginView::lifeSupportTimerFired):
Deref the PluginView.
(WebCore::PluginView::keepAlive):
Ref the PluginView, then start a time to release the reference
asynchronously.
(WebCore::PluginView::keepAlive):
Find the PluginView in the map, and call its keepAlive() function.

* plugins/PluginView.h:
Made m_parentFrame a RefPtr, so that it will remain valid when the
keep alive timer fires.
(WebCore::PluginView::parentFrame):
Use .get().

* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::updatePluginWidget):
Use .get().
(WebCore::PluginView::handleKeyboardEvent):
Use .get().
(WebCore::PluginView::handleMouseEvent):
Use .get().

* plugins/PluginViewNone.cpp:
(WebCore::PluginView::keepAlive):
Stubbed.

WebKitTools:

* DumpRenderTree/win/TestNetscapePlugin/main.cpp:
(executeScript):
Moved to an earlier point in the file.
(NPP_New):
If the plug-in has an onDestroy attribute, store its value.
(NPP_Destroy):
If the plug-in has code to run on destruction, run it and free it.

LayoutTests:

* platform/win/plugins/plugin-delayed-destroy-expected.txt: Added.
* platform/win/plugins/plugin-delayed-destroy.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
eric@webkit.org [Wed, 10 Feb 2010 19:44:08 +0000 (19:44 +0000)]
2010-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Support frameset flattening
        https://bugs.webkit.org/show_bug.cgi?id=32717

        Add support for enabling/disabling FrameSet Flattening on the Mac port.

        * WebCore.base.exp:
2010-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Support frameset flattening
        https://bugs.webkit.org/show_bug.cgi?id=32717

        Add support for enabling/disabling FrameSet Flattening on the Mac port.

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences isFrameSetFlatteningEnabled]):
        (-[WebPreferences setFrameSetFlatteningEnabled:]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Diego Gonzalez <diego.gonzalez@openbossa.org>
eric@webkit.org [Wed, 10 Feb 2010 19:26:49 +0000 (19:26 +0000)]
2010-02-10  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
        to make Qt DRT able to get page number.

        LayoutTests:
            printing/page-break-always.html
            printing/pageNumerForElementById.html
            printing/css2.1/page-break-before-000.html
            printing/css2.1/page-break-after-000.html
            printing/css2.1/page-break-after-004.html
            printing/css2.1/page-break-before-001.html
            printing/css2.1/page-break-after-001.html
            printing/css2.1/page-break-after-002.html
            printing/css2.1/page-break-before-002.html
            printing/css2.1/page-break-inside-000.html

        [Qt] Make possible Qt DRT get a page number for element by ID
        https://bugs.webkit.org/show_bug.cgi?id=34777

        * platform/qt/Skipped:
2010-02-10  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
        to make Qt DRT able to get page number.

        LayoutTests:
            printing/page-break-always.html
            printing/pageNumerForElementById.html
            printing/css2.1/page-break-before-000.html
            printing/css2.1/page-break-after-000.html
            printing/css2.1/page-break-after-004.html
            printing/css2.1/page-break-before-001.html
            printing/css2.1/page-break-after-001.html
            printing/css2.1/page-break-after-002.html
            printing/css2.1/page-break-before-002.html
            printing/css2.1/page-break-inside-000.html

        [Qt] Make possible Qt DRT get a page number for element by ID
        https://bugs.webkit.org/show_bug.cgi?id=34777

        * Api/qwebframe.cpp:
        (qt_drt_pageNumberForElementById):
2010-02-10  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
        to make Qt DRT able to get page number.

        LayoutTests:
            printing/page-break-always.html
            printing/pageNumerForElementById.html
            printing/css2.1/page-break-before-000.html
            printing/css2.1/page-break-after-000.html
            printing/css2.1/page-break-after-004.html
            printing/css2.1/page-break-before-001.html
            printing/css2.1/page-break-after-001.html
            printing/css2.1/page-break-after-002.html
            printing/css2.1/page-break-before-002.html
            printing/css2.1/page-break-inside-000.html

        [Qt] Make possible Qt DRT get a page number for element by ID
        https://bugs.webkit.org/show_bug.cgi?id=34777

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::pageNumberForElementById):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTouch WebKit.idl to force a rebuild
bweinstein@apple.com [Wed, 10 Feb 2010 18:48:08 +0000 (18:48 +0000)]
Touch WebKit.idl to force a rebuild

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCommitted the wrong file, had some local changes trying to fix the build
bweinstein@apple.com [Wed, 10 Feb 2010 18:47:52 +0000 (18:47 +0000)]
Committed the wrong file, had some local changes trying to fix the build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTouch WebKit.idl to force a rebuild of Interfaces
bweinstein@apple.com [Wed, 10 Feb 2010 18:46:26 +0000 (18:46 +0000)]
Touch WebKit.idl to force a rebuild of Interfaces

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd some details to the change log I just committed. (Sorry for not being more clear.)
jorlow@chromium.org [Wed, 10 Feb 2010 18:37:13 +0000 (18:37 +0000)]
Add some details to the change log I just committed.  (Sorry for not being more clear.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert 54599
jorlow@chromium.org [Wed, 10 Feb 2010 18:29:31 +0000 (18:29 +0000)]
Revert 54599

WebCore:

* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype._insertChild):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode):
(WebInspector.ElementsTreeElement):
(WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
(WebInspector.ElementsTreeElement.prototype._updateChildren):
():
* inspector/front-end/inspector.css:

LayoutTests:

* inspector/elements-panel-limited-children-expected.txt: Removed.
* inspector/elements-panel-limited-children.html: Removed.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
eric@webkit.org [Wed, 10 Feb 2010 18:11:38 +0000 (18:11 +0000)]
2010-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Support frameset flattening
        https://bugs.webkit.org/show_bug.cgi?id=32717

        Add support for enabling/disabling FrameSet Flattening on the Windows port.

        * Interfaces/IWebPreferencesPrivate.idl:
        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):
        (WebPreferences::isFrameSetFlatteningEnabled):
        (WebPreferences::setFrameSetFlatteningEnabled):
        * WebPreferences.h:
        * WebView.cpp:
        (WebView::notifyPreferencesChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
eric@webkit.org [Wed, 10 Feb 2010 17:55:12 +0000 (17:55 +0000)]
2010-02-10  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Simon Hausmann.

        Fix QScriptValue::toBool.

        Fix ECMA compliance in the QScriptValue for values like 0, NaN and
        empty strings.

        [Qt] QScriptValue::toBool problem
        https://bugs.webkit.org/show_bug.cgi?id=34793

        * qt/api/qscriptvalue_p.h:
        (QScriptValuePrivate::toBool):
        * qt/tests/qscriptvalue/tst_qscriptvalue.h:
        * qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp:
        (tst_QScriptValue::toBool_initData):
        (tst_QScriptValue::toBool_makeData):
        (tst_QScriptValue::toBool_test):
        (tst_QScriptValue::toBoolean_initData):
        (tst_QScriptValue::toBoolean_makeData):
        (tst_QScriptValue::toBoolean_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unnecessary #include of shfolder.h
aroben@apple.com [Wed, 10 Feb 2010 16:51:02 +0000 (16:51 +0000)]
Remove unnecessary #include of shfolder.h

shfolder.h has been deprecated in newer versions of the Windows SDK.

Fixes <http://webkit.org/b/34803> WebPreferences.cpp fails to compile
under VS2010 RC due to #include of shfolder.h.

Reviewed by Darin Adler.

* WebPreferences.cpp: Removed #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix bad paths in WebCore.vcproj
aroben@apple.com [Wed, 10 Feb 2010 16:50:50 +0000 (16:50 +0000)]
Fix bad paths in WebCore.vcproj

These were harmless in VS2005, but cause project conversion errors in
VS2010 RC.

Fixes <http://webkit.org/b/34801>.

Reviewed by Dan Bernstein.

* WebCore.vcproj/WebCore.vcproj: Removed leading "." from paths to
JSHTMLFrameSetElement.{cpp,h}.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed (build fix).
jchaffraix@webkit.org [Wed, 10 Feb 2010 16:36:37 +0000 (16:36 +0000)]
Not reviewed (build fix).

* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getLastResortFallbackFont): Return a
SimpleFontData here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 23287 - Avoid using FontPlatformData outside the FontCache
jchaffraix@webkit.org [Wed, 10 Feb 2010 16:28:27 +0000 (16:28 +0000)]
Bug 23287 -  Avoid using FontPlatformData outside the FontCache

Patch by Julien Chaffraix <jchaffraix@pleyo.com> on 2010-02-10
Reviewed by Eric Seidel.

No functional change, only refactored the code using FontPlatformData to use SimpleFontData.

This change leaves the class FontCached as it needs some thoughts and more refactoring.

* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData): Call getCachedFontData with the 2 parameters directly.
* css/CSSFontSelector.cpp:
(WebCore::fontDataForGenericFamily): Ditto.
* platform/graphics/FontCache.cpp:
(WebCore::FontCache::getCachedFontData): This method is meant to replace getCachedFontPlatformData
that was moved in the private section of the class. It calls getCachedFontPlatformData and cache
the returned FontPlatformData if it is not null.
(WebCore::FontCache::getFontData): Updated to use the new getCachedFontData.
* platform/graphics/FontCache.h: Updated several methods to return a SimpleFontData in lieu of a
FontPlatformData. Moved some method in the private sections.

* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/gtk/FontCacheGtk.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/haiku/FontCacheHaiku.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/wince/FontCacheWince.cpp:
* platform/graphics/wx/FontCacheWx.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
Updated all the previous platform methods to return a SimpleFontData.

* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getSimilarFontPlatformData): Updated to return a SimpleFontData.
(WebCore::FontCache::getLastResortFallbackFont): Ditto. Also refactored the code
and moved a DEFINE_STATIC_LOCAL where it is needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 10 Feb 2010 16:06:17 +0000 (16:06 +0000)]
2010-02-10  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Add test to ensure that a call to history.forward() at the top of
        a page doesn't prevent the page from loading when there is no
        forward list.

        https://bugs.webkit.org/show_bug.cgi?id=34722

        * fast/history/forward-during-load-expected.txt: Added.
        * fast/history/forward-during-load.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 10 Feb 2010 15:45:40 +0000 (15:45 +0000)]
2010-02-10  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Elements Panel: Limit the number of initially loaded element children
        https://bugs.webkit.org/show_bug.cgi?id=34421

        Test: inspector/elements-panel-limited-children.html

        WebCore:
        * English.lproj/localizedStrings.js:
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode.prototype._insertChild):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype.createTreeElementFor):
        (WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode):
        (WebInspector.ElementsTreeElement):
        (WebInspector.ElementsTreeElement.prototype.get expandedChildrenLimit):
        (WebInspector.ElementsTreeElement.prototype.set expandedChildrenLimit):
        (WebInspector.ElementsTreeElement.prototype.get expandedChildCount):
        (WebInspector.ElementsTreeElement.prototype.showChild):
        (WebInspector.ElementsTreeElement.prototype.insertChildElement):
        (WebInspector.ElementsTreeElement.prototype.moveChild):
        (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
        (WebInspector.ElementsTreeElement.prototype._updateChildren):
        (WebInspector.ElementsTreeElement.prototype.adjustCollapsedRange):
        (WebInspector.ElementsTreeElement.prototype.handleLoadAllChildren):
        ():
        * inspector/front-end/inspector.css:

        LayoutTests:
        * inspector/elements-panel-limited-children-expected.txt: Added.
        * inspector/elements-panel-limited-children.html: Added.
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 10 Feb 2010 15:22:23 +0000 (15:22 +0000)]
2010-02-10  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Chromium Win build fix. Add third_party/nss to the dependencies list on Windows.

        https://bugs.webkit.org/show_bug.cgi?id=34789

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Wed, 10 Feb 2010 15:18:24 +0000 (15:18 +0000)]
2010-02-10  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Remove several #if USE(JSC) branches. Introduce ScriptDebugServer class for
        making JavaScriptDebugServer engine-agnostic.

        https://bugs.webkit.org/show_bug.cgi?id=34795

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/ScriptDebugServer.cpp: Added.
        (WebCore::ScriptDebugServer::recompileAllJSFunctions):
        (WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon):
        * bindings/js/ScriptDebugServer.h: Added.
        * bindings/v8/ScriptDebugServer.cpp: Added.
        (WebCore::ScriptDebugServer::recompileAllJSFunctions):
        (WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon):
        * bindings/v8/ScriptDebugServer.h: Added.
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::startUserInitiatedProfiling):
        (WebCore::InspectorController::enableProfiler):
        (WebCore::InspectorController::disableProfiler):
        * page/Console.cpp:
        (WebCore::Console::profile):
        (WebCore::Console::profileEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse derefIfNotNull() to work around WINSCW compiler forward declaration bug
vestbo@webkit.org [Wed, 10 Feb 2010 11:59:02 +0000 (11:59 +0000)]
Use derefIfNotNull() to work around WINSCW compiler forward declaration bug

Patch by Yongjun Zhang <yongjun.zhang@nokia.com> on 2009-10-06
Reviewed by Simon Hausmann.

The compiler bug is reported at
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812.

The change should be reverted when the above bug is fixed in WINSCW compiler.

JObjectWrapper::ref() and deref() made public accessible to derefIfNull().

https://bugs.webkit.org/show_bug.cgi?id=28054

* bridge/jni/jsc/JavaInstanceJSC.h:
* bridge/jni/v8/JavaInstanceV8.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGet rid of WINSCW hack for UnSpecifiedBoolType
vestbo@webkit.org [Wed, 10 Feb 2010 11:58:46 +0000 (11:58 +0000)]
Get rid of WINSCW hack for UnSpecifiedBoolType

Patch by Yongjun Zhang <yongjun.zhang@nokia.com> on 2009-10-06
Reviewed by Simon Hausmann.

Add parenthesis around (RefPtr::*UnspecifiedBoolType) to make the WINSCW
compiler work with the default UnSpecifiedBoolType() operator.

https://bugs.webkit.org/show_bug.cgi?id=28054

* wtf/RefPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 10 Feb 2010 11:14:59 +0000 (11:14 +0000)]
2010-02-10  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Rolling Chromium dependencies to match Chromium revision 38580.

        https://bugs.webkit.org/show_bug.cgi?id=34789

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Wed, 10 Feb 2010 10:36:40 +0000 (10:36 +0000)]
2010-02-10  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Adam Barth.

        Simplified RuntimeEnabledFeatures and corresponding v8 generated code
        https://bugs.webkit.org/show_bug.cgi?id=34667

        * WebCore.gypi:
        * bindings/generic/RuntimeEnabledFeatures.cpp: Added.
        (WebCore::RuntimeEnabledFeatures::audioEnabled):
        (WebCore::RuntimeEnabledFeatures::htmlMediaElementEnabled):
        (WebCore::RuntimeEnabledFeatures::htmlAudioElementEnabled):
        (WebCore::RuntimeEnabledFeatures::htmlVideoElementEnabled):
        (WebCore::RuntimeEnabledFeatures::mediaErrorEnabled):
        (WebCore::RuntimeEnabledFeatures::sharedWorkerEnabled):
        (WebCore::RuntimeEnabledFeatures::webSocketEnabled):
        (WebCore::RuntimeEnabledFeatures::openDatabaseEnabled):
        * bindings/generic/RuntimeEnabledFeatures.h: Added.
        (WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled):
        (WebCore::RuntimeEnabledFeatures::localStorageEnabled):
        (WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled):
        (WebCore::RuntimeEnabledFeatures::sessionStorageEnabled):
        (WebCore::RuntimeEnabledFeatures::setWebkitNotificationsEnabled):
        (WebCore::RuntimeEnabledFeatures::webkitNotificationsEnabled):
        (WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled):
        (WebCore::RuntimeEnabledFeatures::applicationCacheEnabled):
        (WebCore::RuntimeEnabledFeatures::setGeolocationEnabled):
        (WebCore::RuntimeEnabledFeatures::geolocationEnabled):
        (WebCore::RuntimeEnabledFeatures::setIndexedDBEnabled):
        (WebCore::RuntimeEnabledFeatures::indexedDBEnabled):
        (WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/RuntimeEnabledFeatures.cpp: Removed.
        * bindings/v8/RuntimeEnabledFeatures.h: Removed.
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        * bindings/v8/custom/V8NavigatorCustom.cpp:
        * bindings/v8/custom/V8WorkerContextCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 10 Feb 2010 10:25:47 +0000 (10:25 +0000)]
2010-02-10  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Use v8::Debug::ProcessDebugMessages instead of executing an empty function

        https://bugs.webkit.org/show_bug.cgi?id=34704

        * src/DebuggerAgent.h:
        * src/DebuggerAgentImpl.cpp:
        (WebKit::DebuggerAgentImpl::processDebugCommands):
        * src/DebuggerAgentImpl.h:
        * src/ToolsAgent.h:
        * src/WebDevToolsAgentImpl.cpp:
        * src/WebDevToolsAgentImpl.h:
        * src/js/DebuggerAgent.js:
        (devtools.DebuggerAgent.prototype.addBreakpoint):
        * src/js/DevToolsHostStub.js:
        (.RemoteDebuggerAgentStub.prototype.processDebugCommands):
        * src/js/InjectDispatch.js:
        (dispatch):
        * src/js/ProfilerAgent.js:
        (devtools.ProfilerAgent.prototype.startProfiling):
        (devtools.ProfilerAgent.prototype.stopProfiling):
        * src/js/Tests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-09 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 10 Feb 2010 09:56:01 +0000 (09:56 +0000)]
2010-02-09  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Add two basic categories for the Audits panel
        https://bugs.webkit.org/show_bug.cgi?id=32930

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/AuditCategories.js: Added.
        (WebInspector.AuditCategories.PagePerformance):
        (WebInspector.AuditCategories.PagePerformance.prototype.initialize):
        (WebInspector.AuditCategories.NetworkUtilization):
        (WebInspector.AuditCategories.NetworkUtilization.prototype.initialize):
        * inspector/front-end/AuditLauncherView.js:
        (WebInspector.AuditLauncherView.prototype.updateResourceTrackingState):
        (WebInspector.AuditLauncherView.prototype._createLauncherUI):
        (WebInspector.AuditLauncherView.prototype.show):
        * inspector/front-end/AuditRules.js: Added.
        (WebInspector.AuditRules.arrayAsUL):
        (WebInspector.AuditRules.getDomainToResourcesMap):
        (WebInspector.AuditRules.evaluateInTargetWindow):
        (WebInspector.AuditRules.GzipRule):
        (WebInspector.AuditRules.GzipRule.prototype.doRun):
        (WebInspector.AuditRules.GzipRule.prototype._isCompressed):
        (WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
        (WebInspector.AuditRules.CombineExternalResourcesRule):
        (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
        (WebInspector.AuditRules.CombineJsResourcesRule):
        (WebInspector.AuditRules.CombineCssResourcesRule):
        (WebInspector.AuditRules.MinimizeDnsLookupsRule):
        (WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
        (WebInspector.AuditRules.ParallelizeDownloadRule):
        (WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun):
        (WebInspector.AuditRules.UnusedCssRule):
        (WebInspector.AuditRules.UnusedCssRule.prototype._getUnusedStylesheetRatioMessage):
        (WebInspector.AuditRules.UnusedCssRule.prototype._getUnusedTotalRatioMessage):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.routine):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
        (WebInspector.AuditRules.CacheControlRule):
        (WebInspector.AuditRules.CacheControlRule.prototype.InfoCheck.1.FailCheck.0.WarningCheck.1.SevereCheck.2.doRun):
        (WebInspector.AuditRules.CacheControlRule.prototype.handleNonCacheableResources):
        (WebInspector.AuditRules.CacheControlRule.prototype._cacheableAndNonCacheableResources):
        (WebInspector.AuditRules.CacheControlRule.prototype.execCheck):
        (WebInspector.AuditRules.CacheControlRule.prototype.freshnessLifetimeGreaterThan):
        (WebInspector.AuditRules.CacheControlRule.prototype.responseHeader):
        (WebInspector.AuditRules.CacheControlRule.prototype.hasResponseHeader):
        (WebInspector.AuditRules.CacheControlRule.prototype.isCompressible):
        (WebInspector.AuditRules.CacheControlRule.prototype.isPubliclyCacheable):
        (WebInspector.AuditRules.CacheControlRule.prototype.responseHeaderMatch):
        (WebInspector.AuditRules.CacheControlRule.prototype.hasExplicitExpiration):
        (WebInspector.AuditRules.CacheControlRule.prototype._isExplicitlyNonCacheable):
        (WebInspector.AuditRules.CacheControlRule.prototype.isCacheableResource):
        (WebInspector.AuditRules.BrowserCacheControlRule):
        (WebInspector.AuditRules.BrowserCacheControlRule.prototype.handleNonCacheableResources):
        (WebInspector.AuditRules.BrowserCacheControlRule.prototype.runChecks):
        (WebInspector.AuditRules.BrowserCacheControlRule.prototype._missingExpirationCheck):
        (WebInspector.AuditRules.BrowserCacheControlRule.prototype._varyCheck):
        (WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneMonthExpirationCheck):
        (WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneYearExpirationCheck):
        (WebInspector.AuditRules.ProxyCacheControlRule):
        (WebInspector.AuditRules.ProxyCacheControlRule.prototype.runChecks):
        (WebInspector.AuditRules.ProxyCacheControlRule.prototype._questionMarkCheck):
        (WebInspector.AuditRules.ProxyCacheControlRule.prototype._publicCachingCheck):
        (WebInspector.AuditRules.ProxyCacheControlRule.prototype._setCookieCacheableCheck):
        (WebInspector.AuditRules.ImageDimensionsRule):
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.routine.hasDimension):
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.routine.hasWidth):
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.routine.hasHeight):
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.routine):
        (WebInspector.AuditRules.CssInHeadRule):
        (WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
        (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.routine.allViews):
        (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.routine):
        (WebInspector.AuditRules.StylesScriptsOrderRule):
        (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
        (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.routine):
        (WebInspector.AuditRules.CookieRuleBase):
        (WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback):
        (WebInspector.AuditRules.CookieRuleBase.prototype.doRun):
        (WebInspector.AuditRules.CookieRuleBase.prototype.mapResourceCookies):
        (WebInspector.AuditRules.CookieRuleBase.prototype._callbackForResourceCookiePairs):
        (WebInspector.AuditRules.CookieSizeRule):
        (WebInspector.AuditRules.CookieSizeRule.prototype._average):
        (WebInspector.AuditRules.CookieSizeRule.prototype._max):
        (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
        (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies.avgSizeSorter):
        (WebInspector.AuditRules.StaticCookielessRule):
        (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
        (WebInspector.AuditRules.StaticCookielessRule.prototype._collectorCallback):
        * inspector/front-end/AuditsPanel.js:
        (WebInspector.AuditsPanel.prototype._constructCategories):
        (WebInspector.AuditsPanel.prototype._reloadResources):
        (WebInspector.AuditsPanel.prototype.show):
        (WebInspector.AuditsPanel.prototype._updateLauncherViewControls):
        (WebInspector.AuditCategory):
        (WebInspector.AuditCategory.prototype.get id):
        (WebInspector.AuditCategory.prototype.get ruleCount):
        (WebInspector.AuditCategory.prototype.runRules):
        (WebInspector.AuditCategory.prototype._ensureInitialized):
        (WebInspector.AuditCategoryResult):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/audits.css:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.loaded):
        (WebInspector.addPanelToolbarIcon):
        (WebInspector.documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake run-iexploder-tests work on Linux.
abecsi@webkit.org [Wed, 10 Feb 2010 09:51:33 +0000 (09:51 +0000)]
Make run-iexploder-tests work on Linux.
https://bugs.webkit.org/show_bug.cgi?id=34748

Reviewed by Adam Barth.

Extract the platform dependant Apache configuration checking code in httpd.pm to a separate function
called getHTTPDConfigPathForTestDirectory and use run-launcher instead of run-safari if run on Linux.

* Scripts/run-iexploder-tests:
* Scripts/webkitperl/httpd.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 10 Feb 2010 09:23:08 +0000 (09:23 +0000)]
2010-02-10  Tony Chang  <tony@chromium.org>

        Unreviewed, build fix for Chromium Mac take 2.

        * src/AutoFillPopupMenuClient.cpp:
        (WebKit::AutoFillPopupMenuClient::removeSuggestionAtIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 10 Feb 2010 09:17:14 +0000 (09:17 +0000)]
2010-02-10  Tony Chang  <tony@chromium.org>

        Unreviewed, build fix for Chromium Mac.

        * src/AutoFillPopupMenuClient.cpp:
        (WebKit::AutoFillPopupMenuClient::removeSuggestionAtIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 10 Feb 2010 08:36:58 +0000 (08:36 +0000)]
2010-02-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Freeze sandbox attributes on creation
        https://bugs.webkit.org/show_bug.cgi?id=34184

        Test that allow-forms is frozen on document creation.

        * fast/frames/resources/sandboxed-iframe-form-dynamic-allowed.html: Added.
        * fast/frames/resources/sandboxed-iframe-form-dynamic-disallowed.html: Added.
        * fast/frames/sandboxed-iframe-forms-dynamic-expected.txt: Added.
        * fast/frames/sandboxed-iframe-forms-dynamic.html: Added.
2010-02-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Freeze sandbox attributes on creation
        https://bugs.webkit.org/show_bug.cgi?id=34184

        This is how the spec works now.

        Test: fast/frames/sandboxed-iframe-forms-dynamic.html

        * bindings/ScriptControllerBase.cpp:
        (WebCore::ScriptController::canExecuteScripts):
        * bindings/generic/BindingDOMWindow.h:
        (WebCore::::createWindow):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::createWindow):
        * dom/Document.cpp:
        * dom/Document.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::submitForm):
        (WebCore::FrameLoader::requestObject):
        (WebCore::FrameLoader::shouldAllowNavigation):
        (WebCore::FrameLoader::updateSandboxFlags):
        * page/SecurityOrigin.cpp:
        * page/SecurityOrigin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-09 James Hawkins <jhawkins@chromium.org>
eric@webkit.org [Wed, 10 Feb 2010 04:48:49 +0000 (04:48 +0000)]
2010-02-09  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Refactor AutocompletePopupMenuClient into a base class,
        SuggestionsPopupMenuClient, and two derived classes,
        AutocompletePopupMenuClient and AutoFillPopupMenuClient.  Currently
        the behavior of suggestions popups has not changed.

        https://bugs.webkit.org/show_bug.cgi?id=34721

        * WebKit.gyp:
        * public/WebView.h:
        * src/AutoFillPopupMenuClient.cpp: Added.
        * src/AutoFillPopupMenuClient.h: Added.
        * src/AutocompletePopupMenuClient.cpp:
        (WebKit::AutocompletePopupMenuClient::getSuggestionsCount):
        (WebKit::AutocompletePopupMenuClient::getSuggestion):
        (WebKit::AutocompletePopupMenuClient::removeSuggestionAtIndex):
        (WebKit::AutocompletePopupMenuClient::initialize):
        (WebKit::AutocompletePopupMenuClient::setSuggestions):
        * src/AutocompletePopupMenuClient.h:
        * src/SuggestionsPopupMenuClient.cpp: Added.
        * src/SuggestionsPopupMenuClient.h: Added.
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):
        (WebKit::WebViewImpl::keyEvent):
        (WebKit::WebViewImpl::autocompleteHandleKeyEvent):
        (WebKit::WebViewImpl::applyAutofillSuggestions):
        (WebKit::WebViewImpl::applyAutoFillSuggestions):
        (WebKit::WebViewImpl::applyAutocompleteSuggestions):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-09 Ariya Hidayat <ariya.hidayat@gmail.com>
ariya@webkit.org [Wed, 10 Feb 2010 04:23:41 +0000 (04:23 +0000)]
2010-02-09  Ariya Hidayat  <ariya.hidayat@gmail.com>

        Rubber-stamped by Kenneth Rohde Christiansen.

        [Qt] Remove old, outdated unused code block.

        * platform/graphics/qt/GraphicsContextQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54585 268f45cc-cd09-0410-ab3c-d52691b4dbfc