WebKit-https.git
11 years agoReviewed by Eric Seidel.
zimmermann@webkit.org [Thu, 22 Jan 2009 20:40:18 +0000 (20:40 +0000)]
Reviewed by Eric Seidel.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=23465

Further enhancments to share code between HTMLOptionElement and the upcoming WMLOptionElement.

Rename optionText() to textIndentedToRespectGroupLabel() in (HTML)OptionElement, as it fits better.
optionText() returns the options text prefixed with some spaces, in case it got an optgroup parent.

Add two more pure-virtual functions to OptionElement: setSelectedState(bool) & value().
These aren't used outside of html/ at the moment (unlike the other pure-virtual functions
used by RenderMenuList/RenderListBox) - but they will be used by SelectElement, once it exists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com [Thu, 22 Jan 2009 20:30:32 +0000 (20:30 +0000)]
2009-01-22  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Justin Garcia.

        Bug 23464: Infinite recursion at SelectionController::setSelection
        https://bugs.webkit.org/show_bug.cgi?id=23464

        Check for conditions leading to infinite recursion.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 22 Jan 2009 20:12:47 +0000 (20:12 +0000)]
2009-01-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Clean up the test plug-in code. We now always use the CG drawing model and the
        Cocoa event model. It is however possible to revert to the old Carbon event model by
        specifying forcecarbon=true in the embed/object tag.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
        * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
        (NPP_New):
        (handleEventCarbon):
        (handleEventCocoa):
        (NPP_HandleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 22 Jan 2009 19:06:18 +0000 (19:06 +0000)]
2009-01-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Don't crash or hang when we fail to instantiate a plug-in.

        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):
        Return 0 on failure.

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView JSC::Bindings::createPluginBindingsInstance:JSC::Bindings::]):
        Null check for the proxy member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Fix WML build problem in RenderBox.cpp, WMLNames is undefined.
zimmermann@webkit.org [Thu, 22 Jan 2009 18:55:42 +0000 (18:55 +0000)]
Not reviewed. Fix WML build problem in RenderBox.cpp, WMLNames is undefined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the Qt build after RenderBox changes.
treat@webkit.org [Thu, 22 Jan 2009 15:29:25 +0000 (15:29 +0000)]
Fix the Qt build after RenderBox changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 22 Jan 2009 09:41:39 +0000 (09:41 +0000)]
2009-01-22  David Hyatt  <hyatt@apple.com>

        Fix regressions in list box selection on Mac.  The wrong color was being used for the list box
        background, and list box colors actually weren't even being properly fetched because of a bug in
        the RenderTheme base class.  Existing pixel tests cover the bug fix.

        Reviewed by Jon Honeycutt

        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
        (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
        (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
        (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 David Levin <levin@chromium.org>
ap@webkit.org [Thu, 22 Jan 2009 08:58:16 +0000 (08:58 +0000)]
2009-01-22  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 22720: Make XMLHttpRequest work in Workers
        <https://bugs.webkit.org/show_bug.cgi?id=22720>

        Add copy/adopt for HTTPHeaderMap to allow the data to be passed across threads.

        No observable change in behavior, so no test.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.scons:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * platform/network/HTTPHeaderMap.cpp: Added.
        (WebCore::HTTPHeaderMap::copyData):
        (WebCore::HTTPHeaderMap::adopt):
        * platform/network/HTTPHeaderMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 Dmitry Titov <dimich@chromium.org>
ap@webkit.org [Thu, 22 Jan 2009 08:32:45 +0000 (08:32 +0000)]
2009-01-22  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=23373

        Implement ThreadCondition::timedWait().
        Since we borrow the code for condition variables from other sources,
        I did the same for timedWait(). See comments in ThreadingWin.cpp for
        rationale and more info.

        * wtf/CONTRIBUTORS.pthreads-win32:
        Added. A list of Pthreads-win32 contributors mentioned in their license. The license itself
        is included into wtf/ThreadingWin32.cpp.

        * wtf/Threading.h:
        * wtf/ThreadingWin.cpp:
        Additional info and Pthreads-win32 license at the beginning.
        (WTF::PlatformCondition::timedWait): new method, derived from Pthreads-win32.
        (WTF::PlatformCondition::signal): same
        (WTF::ThreadCondition::ThreadCondition):
        (WTF::ThreadCondition::~ThreadCondition):
        (WTF::ThreadCondition::wait): this now calls PlatformCondition::timedWait.
        (WTF::ThreadCondition::timedWait): same
        (WTF::ThreadCondition::signal): this now calls PlatformCondition::signal.
        (WTF::ThreadCondition::broadcast): same

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix build bustage in WML from RenderBox changes.
hyatt@apple.com [Thu, 22 Jan 2009 08:15:16 +0000 (08:15 +0000)]
Fix build bustage in WML from RenderBox changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Gtk build bustage.
hyatt@apple.com [Thu, 22 Jan 2009 08:12:35 +0000 (08:12 +0000)]
Fix Gtk build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Qt build bustage.
hyatt@apple.com [Thu, 22 Jan 2009 08:11:09 +0000 (08:11 +0000)]
Fix Qt build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 22 Jan 2009 07:54:25 +0000 (07:54 +0000)]
2009-01-21  David Hyatt  <hyatt@apple.com>

        Back out a portion of my patch that I did not mean to land.  Revert paintOutline back to the way it
        was before my landing.  Fixes failing SVG focus ring tests.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::paintOutline):
        * rendering/RenderObject.h:
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::paint):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 22 Jan 2009 07:19:19 +0000 (07:19 +0000)]
2009-01-21  David Hyatt  <hyatt@apple.com>

        Fix Node's renderBox() method on Windows.

        * dom/Node.cpp:
        (WebCore::Node::renderBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 22 Jan 2009 07:05:57 +0000 (07:05 +0000)]
2009-01-21  David Hyatt  <hyatt@apple.com>

        Fix RenderThemeSafari bustage on Win32.

        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::baselinePosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 22 Jan 2009 06:58:18 +0000 (06:58 +0000)]
2009-01-21  David Hyatt  <hyatt@apple.com>

        Fix bustage in RenderThemeWin. It's actually terrible that RenderThemeWin is using absoluteContentBox,
        but that's a problem for another day.

        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
        (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
        (WebCore::RenderThemeWin::paintSearchFieldResultsButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBecause bdash hates freedom (tyop fix).
barraclough@apple.com [Thu, 22 Jan 2009 05:59:46 +0000 (05:59 +0000)]
Because bdash hates freedom (tyop fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 22 Jan 2009 05:57:59 +0000 (05:57 +0000)]
2009-01-21  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamped by Geoff "Cameron Zwarich" Garen.

        Add pre & post standalone driver stcripts to assist running the javascript layout tests
        on jsc, rather than a full webkit build.

        * fast/js/resources/standalone-post.js: Copied from fast/js/resources/js-test-post.js.
        * fast/js/resources/standalone-pre.js: Copied from fast/js/resources/js-test-pre.js.
        (description):
        (debug):
        (escapeString):
        (testPassed):
        (testFailed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 23470: Crash when page load occurs while processing scroll event with MallocScrib...
oliver@apple.com [Thu, 22 Jan 2009 05:48:32 +0000 (05:48 +0000)]
Bug 23470: Crash when page load occurs while processing scroll event with MallocScribble enabled
<https://bugs.webkit.org/show_bug.cgi?id=23470>

Reviewed by Dave Hyatt

Add a RefPtr protector to handleWheelEvent to guard against destruction
while processing the scroll event.  Alas the absurd set of circumstances
required to trigger this do not appear to be reproducible in DRT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
barraclough@apple.com [Thu, 22 Jan 2009 04:28:05 +0000 (04:28 +0000)]
JavaScriptCore:

2009-01-21  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23469.

        We need to check all numbers in integer switches, not just those
        represented as integer JSImmediates.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute):
        (JSC::Interpreter::cti_op_switch_imm):

LayoutTests:

2009-01-21  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Add layout test for switch (-0).

        * fast/js/resources/switch-behaviour.js:
        * fast/js/switch-behaviour-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 22 Jan 2009 03:35:42 +0000 (03:35 +0000)]
2009-01-21  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23468.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Thu, 22 Jan 2009 02:31:52 +0000 (02:31 +0000)]
WebCore:

2009-01-21  David Hyatt  <hyatt@apple.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23453

        Devirtualize the width/height/x/y methods of the render tree.  The methods are now non-virtual on RenderBox.
        Many functions that were previously in RenderObject.cpp are now in RenderBox.cpp.

        Reviewed by Eric Seidel and Darin Adler

        * WebCore.base.exp:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::sizingBox):
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::getUpperLeftCorner):
        (WebCore::ContainerNode::getLowerRightCorner):
        * dom/Element.cpp:
        (WebCore::Element::offsetLeft):
        (WebCore::Element::offsetTop):
        (WebCore::Element::offsetWidth):
        (WebCore::Element::offsetHeight):
        (WebCore::Element::offsetParent):
        (WebCore::Element::clientLeft):
        (WebCore::Element::clientTop):
        (WebCore::Element::clientWidth):
        (WebCore::Element::clientHeight):
        (WebCore::Element::scrollLeft):
        (WebCore::Element::scrollTop):
        (WebCore::Element::setScrollLeft):
        (WebCore::Element::setScrollTop):
        (WebCore::Element::scrollWidth):
        (WebCore::Element::scrollHeight):
        * dom/Node.cpp:
        (WebCore::Node::renderBox):
        (WebCore::Node::getRect):
        * dom/Node.h:
        * dom/Position.cpp:
        (WebCore::endsOfNodeAreVisuallyDistinctPositions):
        (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
        (WebCore::Position::isCandidate):
        * dom/PositionIterator.cpp:
        (WebCore::PositionIterator::isCandidate):
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
        * editing/DeleteButtonController.cpp:
        (WebCore::isDeletableElement):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::removeNode):
        * editing/Editor.cpp:
        (WebCore::Editor::insideVisibleArea):
        * editing/EditorCommand.cpp:
        (WebCore::verticalScrollDistance):
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::isKeyboardFocusable):
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::willDraw):
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::isFocusable):
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::width):
        (WebCore::HTMLFrameElementBase::height):
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::width):
        (WebCore::HTMLImageElement::height):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::drawNodeHighlight):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
        * page/FrameView.cpp:
        (WebCore::FrameView::createScrollbar):
        (WebCore::FrameView::updateDashboardRegions):
        * page/animation/AnimationBase.cpp:
        (WebCore::blendFunc):
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::imageRect):
        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::renderBox):
        (WebCore::InlineBox::adjustPosition):
        * rendering/InlineBox.h:
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::placeBoxesHorizontally):
        (WebCore::InlineFlowBox::verticallyAlignBoxes):
        (WebCore::InlineFlowBox::placeBoxesVertically):
        * rendering/InlineFlowBox.h:
        * rendering/RenderApplet.cpp:
        (WebCore::RenderApplet::createWidgetIfNecessary):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::overflowHeight):
        (WebCore::RenderBlock::overflowWidth):
        (WebCore::RenderBlock::overflowRect):
        (WebCore::RenderBlock::isSelfCollapsingBlock):
        (WebCore::RenderBlock::layout):
        (WebCore::RenderBlock::layoutBlock):
        (WebCore::RenderBlock::adjustPositionedBlock):
        (WebCore::RenderBlock::adjustFloatingBlock):
        (WebCore::RenderBlock::handleSpecialChild):
        (WebCore::RenderBlock::handlePositionedChild):
        (WebCore::RenderBlock::handleFloatingChild):
        (WebCore::RenderBlock::handleCompactChild):
        (WebCore::RenderBlock::insertCompactIfNeeded):
        (WebCore::RenderBlock::handleRunInChild):
        (WebCore::RenderBlock::collapseMargins):
        (WebCore::RenderBlock::clearFloatsIfNeeded):
        (WebCore::RenderBlock::estimateVerticalPosition):
        (WebCore::RenderBlock::determineHorizontalPosition):
        (WebCore::RenderBlock::handleBottomOfBlock):
        (WebCore::RenderBlock::layoutBlockChildren):
        (WebCore::RenderBlock::layoutOnlyPositionedObjects):
        (WebCore::RenderBlock::layoutPositionedObjects):
        (WebCore::RenderBlock::markPositionedObjectsForLayout):
        (WebCore::RenderBlock::repaintOverhangingFloats):
        (WebCore::RenderBlock::paint):
        (WebCore::RenderBlock::paintChildren):
        (WebCore::RenderBlock::paintObject):
        (WebCore::RenderBlock::paintFloats):
        (WebCore::RenderBlock::paintContinuationOutlines):
        (WebCore::clipOutPositionedObjects):
        (WebCore::RenderBlock::fillSelectionGaps):
        (WebCore::RenderBlock::fillBlockSelectionGaps):
        (WebCore::RenderBlock::leftSelectionOffset):
        (WebCore::RenderBlock::rightSelectionOffset):
        (WebCore::RenderBlock::insertPositionedObject):
        (WebCore::RenderBlock::removePositionedObject):
        (WebCore::RenderBlock::removePositionedObjects):
        (WebCore::RenderBlock::insertFloatingObject):
        (WebCore::RenderBlock::removeFloatingObject):
        (WebCore::RenderBlock::positionNewFloats):
        (WebCore::RenderBlock::newLine):
        (WebCore::RenderBlock::lowestPosition):
        (WebCore::RenderBlock::rightmostPosition):
        (WebCore::RenderBlock::leftmostPosition):
        (WebCore::RenderBlock::clearFloats):
        (WebCore::RenderBlock::addOverhangingFloats):
        (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
        (WebCore::RenderBlock::getClearDelta):
        (WebCore::RenderBlock::nodeAtPoint):
        (WebCore::RenderBlock::positionForCoordinates):
        (WebCore::RenderBlock::layoutColumns):
        (WebCore::RenderBlock::getBaselineOfFirstLineBox):
        (WebCore::RenderBlock::getBaselineOfLastLineBox):
        (WebCore::getHeightForLineCount):
        (WebCore::RenderBlock::adjustForBorderFit):
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::FloatWithRect::FloatWithRect):
        (WebCore::RenderBlock::hasOverhangingFloats):
        (WebCore::RenderBlock::CompactInfo::compact):
        (WebCore::RenderBlock::CompactInfo::set):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::RenderBox):
        (WebCore::RenderBox::offsetLeft):
        (WebCore::RenderBox::offsetTop):
        (WebCore::RenderBox::offsetParent):
        (WebCore::RenderBox::clientWidth):
        (WebCore::RenderBox::clientHeight):
        (WebCore::RenderBox::scrollWidth):
        (WebCore::RenderBox::scrollHeight):
        (WebCore::RenderBox::scrollLeft):
        (WebCore::RenderBox::scrollTop):
        (WebCore::RenderBox::setScrollLeft):
        (WebCore::RenderBox::setScrollTop):
        (WebCore::RenderBox::absoluteRects):
        (WebCore::RenderBox::absoluteQuads):
        (WebCore::RenderBox::absoluteContentBox):
        (WebCore::RenderBox::absoluteContentQuad):
        (WebCore::RenderBox::absoluteOutlineBounds):
        (WebCore::RenderBox::addFocusRingRects):
        (WebCore::RenderBox::reflectionBox):
        (WebCore::RenderBox::reflectionOffset):
        (WebCore::RenderBox::reflectedRect):
        (WebCore::RenderBox::overrideWidth):
        (WebCore::RenderBox::overrideHeight):
        (WebCore::RenderBox::nodeAtPoint):
        (WebCore::RenderBox::paint):
        (WebCore::RenderBox::maskClipRect):
        (WebCore::RenderBox::repaintLayerRectsForImage):
        (WebCore::RenderBox::paintCustomHighlight):
        (WebCore::RenderBox::getOverflowClipRect):
        (WebCore::RenderBox::getClipRect):
        (WebCore::RenderBox::containingBlockWidth):
        (WebCore::RenderBox::localToAbsolute):
        (WebCore::RenderBox::offsetFromContainer):
        (WebCore::RenderBox::position):
        (WebCore::RenderBox::computeAbsoluteRepaintRect):
        (WebCore::RenderBox::repaintDuringLayoutIfMoved):
        (WebCore::RenderBox::calcWidth):
        (WebCore::RenderBox::calcWidthUsing):
        (WebCore::RenderBox::calcHorizontalMargins):
        (WebCore::RenderBox::calcHeight):
        (WebCore::RenderBox::calcPercentageHeight):
        (WebCore::RenderBox::calcReplacedHeightUsing):
        (WebCore::RenderBox::containingBlockWidthForPositioned):
        (WebCore::RenderBox::containingBlockHeightForPositioned):
        (WebCore::RenderBox::calcAbsoluteHorizontal):
        (WebCore::RenderBox::calcAbsoluteVertical):
        (WebCore::RenderBox::calcAbsoluteVerticalValues):
        (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
        (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
        (WebCore::RenderBox::localCaretRect):
        (WebCore::RenderBox::lowestPosition):
        (WebCore::RenderBox::rightmostPosition):
        (WebCore::RenderBox::leftmostPosition):
        (WebCore::RenderBox::localTransform):
        * rendering/RenderBox.h:
        (WebCore::):
        (WebCore::RenderBox::x):
        (WebCore::RenderBox::y):
        (WebCore::RenderBox::width):
        (WebCore::RenderBox::height):
        (WebCore::RenderBox::setX):
        (WebCore::RenderBox::setY):
        (WebCore::RenderBox::setWidth):
        (WebCore::RenderBox::setHeight):
        (WebCore::RenderBox::location):
        (WebCore::RenderBox::size):
        (WebCore::RenderBox::setLocation):
        (WebCore::RenderBox::setSize):
        (WebCore::RenderBox::move):
        (WebCore::RenderBox::frameRect):
        (WebCore::RenderBox::setFrameRect):
        (WebCore::RenderBox::borderBoxRect):
        (WebCore::RenderBox::contentBoxRect):
        (WebCore::RenderBox::previousSiblingBox):
        (WebCore::RenderBox::nextSiblingBox):
        (WebCore::RenderBox::parentBox):
        (WebCore::RenderBox::overflowHeight):
        (WebCore::RenderBox::overflowWidth):
        (WebCore::RenderBox::setOverflowHeight):
        (WebCore::RenderBox::setOverflowWidth):
        (WebCore::RenderBox::overflowLeft):
        (WebCore::RenderBox::overflowTop):
        (WebCore::RenderBox::overflowRect):
        (WebCore::RenderBox::contentWidth):
        (WebCore::RenderBox::contentHeight):
        (WebCore::RenderBox::offsetWidth):
        (WebCore::RenderBox::offsetHeight):
        (WebCore::RenderBox::clientLeft):
        (WebCore::RenderBox::clientTop):
        (WebCore::RenderBox::availableWidth):
        (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
        * rendering/RenderButton.cpp:
        (WebCore::RenderButton::controlClipRect):
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::layout):
        (WebCore::RenderContainer::positionForCoordinates):
        * rendering/RenderContainer.h:
        (WebCore::RenderContainer::firstChildBox):
        (WebCore::RenderContainer::lastChildBox):
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::calcPrefWidths):
        (WebCore::RenderFieldset::layoutLegend):
        (WebCore::RenderFieldset::findLegend):
        (WebCore::RenderFieldset::paintBoxDecorations):
        (WebCore::RenderFieldset::paintMask):
        * rendering/RenderFieldset.h:
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::maxFilenameWidth):
        (WebCore::RenderFileUploadControl::paintObject):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::FlexBoxIterator::FlexBoxIterator):
        (WebCore::FlexBoxIterator::first):
        (WebCore::FlexBoxIterator::next):
        (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
        (WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
        (WebCore::RenderFlexibleBox::layoutBlock):
        (WebCore::RenderFlexibleBox::layoutHorizontalBox):
        (WebCore::RenderFlexibleBox::layoutVerticalBox):
        (WebCore::RenderFlexibleBox::placeChild):
        (WebCore::RenderFlexibleBox::allowedChildFlex):
        * rendering/RenderFlexibleBox.h:
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::absoluteClippedOverflowRect):
        (WebCore::RenderFlow::lowestPosition):
        (WebCore::RenderFlow::rightmostPosition):
        (WebCore::RenderFlow::leftmostPosition):
        (WebCore::RenderFlow::localCaretRect):
        (WebCore::RenderFlow::addFocusRingRects):
        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::paint):
        (WebCore::RenderFrameSet::layout):
        (WebCore::RenderFrameSet::positionFrames):
        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::paintReplaced):
        (WebCore::RenderHTMLCanvas::canvasSizeChanged):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::imageChanged):
        (WebCore::RenderImage::paintReplaced):
        (WebCore::RenderImage::nodeAtPoint):
        (WebCore::RenderImage::calcReplacedWidth):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::absoluteRects):
        (WebCore::RenderInline::boundingBoxWidth):
        (WebCore::RenderInline::boundingBoxHeight):
        (WebCore::RenderInline::positionForCoordinates):
        * rendering/RenderInline.h:
        (WebCore::RenderInline::offsetWidth):
        (WebCore::RenderInline::offsetHeight):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateTransform):
        (WebCore::RenderLayer::updateLayerPosition):
        (WebCore::RenderLayer::scrollbarCornerPresent):
        (WebCore::RenderLayer::createScrollbar):
        (WebCore::RenderLayer::positionOverflowControls):
        (WebCore::RenderLayer::paintScrollCorner):
        (WebCore::RenderLayer::paintResizer):
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::hitTestLayer):
        (WebCore::RenderLayer::calculateRects):
        (WebCore::RenderLayer::boundingBox):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::calcHeight):
        (WebCore::RenderListBox::controlClipRect):
        * rendering/RenderListItem.cpp:
        (WebCore::RenderListItem::positionListMarker):
        (WebCore::RenderListItem::paint):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        (WebCore::RenderListMarker::layout):
        (WebCore::RenderListMarker::imageChanged):
        (WebCore::RenderListMarker::getRelativeMarkerRect):
        (WebCore::RenderListMarker::selectionRect):
        * rendering/RenderMarquee.cpp:
        (WebCore::RenderMarquee::computePosition):
        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::layout):
        (WebCore::RenderMedia::lowestPosition):
        (WebCore::RenderMedia::rightmostPosition):
        (WebCore::RenderMedia::leftmostPosition):
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::controlClipRect):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::RenderObject):
        (WebCore::RenderObject::markAllDescendantsWithFloatsForLayout):
        (WebCore::RenderObject::paintOutline):
        (WebCore::RenderObject::addLineBoxRects):
        (WebCore::RenderObject::absoluteBoundingBoxRect):
        (WebCore::RenderObject::addAbsoluteRectForLayer):
        (WebCore::RenderObject::paintingRootRect):
        (WebCore::RenderObject::container):
        (WebCore::RenderObject::removeFromObjectLists):
        (WebCore::RenderObject::updateHitTestResult):
        (WebCore::RenderObject::addDashboardRegions):
        (WebCore::RenderObject::localTransform):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isBox):
        (WebCore::RenderObject::hasMask):
        (WebCore::RenderObject::setIsText):
        (WebCore::RenderObject::setIsBox):
        (WebCore::RenderObject::borderTop):
        (WebCore::RenderObject::borderBottom):
        (WebCore::RenderObject::absoluteRects):
        (WebCore::RenderObject::collectAbsoluteLineBoxQuads):
        (WebCore::RenderObject::absoluteQuads):
        (WebCore::RenderObject::hasReflection):
        (WebCore::RenderObject::addFocusRingRects):
        (WebCore::RenderObject::absoluteOutlineBounds):
        * rendering/RenderPart.cpp:
        (WebCore::RenderPart::updateWidgetPosition):
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::layout):
        (WebCore::RenderPath::paint):
        (WebCore::RenderPath::absoluteOutlineBounds):
        * rendering/RenderPath.h:
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::layout):
        (WebCore::RenderReplaced::paint):
        (WebCore::RenderReplaced::shouldPaint):
        (WebCore::RenderReplaced::positionForCoordinates):
        (WebCore::RenderReplaced::localSelectionRect):
        (WebCore::RenderReplaced::adjustOverflowForBoxShadow):
        (WebCore::RenderReplaced::overflowRect):
        * rendering/RenderReplica.cpp:
        (WebCore::RenderReplica::layout):
        (WebCore::RenderReplica::calcPrefWidths):
        (WebCore::RenderReplica::paint):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):
        (WebCore::RenderSVGContainer::absoluteOutlineBounds):
        * rendering/RenderSVGContainer.h:
        (WebCore::RenderSVGContainer::width):
        (WebCore::RenderSVGContainer::height):
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::layout):
        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange):
        (WebCore::RenderSVGInlineText::positionForCoordinates):
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::layout):
        (WebCore::RenderSVGRoot::applyContentTransforms):
        (WebCore::RenderSVGRoot::paint):
        (WebCore::RenderSVGRoot::absoluteTransform):
        (WebCore::RenderSVGRoot::nodeAtPoint):
        * rendering/RenderSVGTSpan.cpp:
        (WebCore::RenderSVGTSpan::absoluteRects):
        (WebCore::RenderSVGTSpan::absoluteQuads):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::layout):
        (WebCore::RenderSVGText::relativeBBox):
        * rendering/RenderSVGTextPath.cpp:
        (WebCore::RenderSVGTextPath::absoluteRects):
        (WebCore::RenderSVGTextPath::absoluteQuads):
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::nodeAtPoint):
        * rendering/RenderScrollbar.cpp:
        (WebCore::RenderScrollbar::createCustomScrollbar):
        (WebCore::RenderScrollbar::RenderScrollbar):
        (WebCore::RenderScrollbar::setParent):
        * rendering/RenderScrollbar.h:
        (WebCore::RenderScrollbar::owningRenderer):
        * rendering/RenderScrollbarPart.cpp:
        (WebCore::RenderScrollbarPart::layout):
        (WebCore::RenderScrollbarPart::layoutHorizontalPart):
        (WebCore::RenderScrollbarPart::layoutVerticalPart):
        (WebCore::RenderScrollbarPart::computeScrollbarWidth):
        (WebCore::RenderScrollbarPart::computeScrollbarHeight):
        (WebCore::RenderScrollbarPart::paintIntoRect):
        * rendering/RenderSlider.cpp:
        (WebCore::HTMLSliderThumbElement::defaultEventHandler):
        (WebCore::RenderSlider::layout):
        (WebCore::RenderSlider::mouseEventIsInThumb):
        (WebCore::RenderSlider::positionForOffset):
        (WebCore::RenderSlider::trackSize):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::calcWidth):
        (WebCore::RenderTable::layout):
        (WebCore::RenderTable::paint):
        (WebCore::RenderTable::getBaselineOfFirstLineBox):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::updateWidth):
        (WebCore::RenderTableCell::computeAbsoluteRepaintRect):
        (WebCore::RenderTableCell::localToAbsolute):
        (WebCore::RenderTableCell::absoluteToLocal):
        (WebCore::RenderTableCell::localToAbsoluteQuad):
        (WebCore::RenderTableCell::paint):
        (WebCore::RenderTableCell::paintBackgroundsBehindCell):
        * rendering/RenderTableCell.h:
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::addChild):
        (WebCore::RenderTableSection::addCell):
        (WebCore::RenderTableSection::setCellWidths):
        (WebCore::RenderTableSection::calcRowHeight):
        (WebCore::RenderTableSection::layoutRows):
        (WebCore::RenderTableSection::lowestPosition):
        (WebCore::RenderTableSection::rightmostPosition):
        (WebCore::RenderTableSection::leftmostPosition):
        (WebCore::RenderTableSection::getBaselineOfFirstLineBox):
        (WebCore::RenderTableSection::paint):
        (WebCore::RenderTableSection::recalcCells):
        (WebCore::RenderTableSection::nodeAtPoint):
        * rendering/RenderTableSection.h:
        (WebCore::RenderTableSection::overflowWidth):
        (WebCore::RenderTableSection::overflowHeight):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::RenderText):
        (WebCore::RenderText::boundingBoxX):
        (WebCore::RenderText::boundingBoxY):
        (WebCore::RenderText::firstRunX):
        (WebCore::RenderText::firstRunY):
        (WebCore::RenderText::boundingBoxHeight):
        (WebCore::RenderText::boundingBoxWidth):
        * rendering/RenderText.h:
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::textBlockHeight):
        (WebCore::RenderTextControl::textBlockWidth):
        (WebCore::RenderTextControl::setSelectionRange):
        (WebCore::RenderTextControl::calcHeight):
        (WebCore::RenderTextControl::hitInnerTextBlock):
        (WebCore::RenderTextControl::controlClipRect):
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::layout):
        (WebCore::RenderTextControlMultiLine::adjustControlHeightBasedOnLineHeight):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::paint):
        (WebCore::RenderTextControlSingleLine::layout):
        (WebCore::RenderTextControlSingleLine::nodeAtPoint):
        (WebCore::RenderTextControlSingleLine::forwardEvent):
        (WebCore::RenderTextControlSingleLine::textBlockWidth):
        (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
        (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
        (WebCore::RenderTextControlSingleLine::clientPaddingRight):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::hitTestMediaControlPart):
        (WebCore::RenderTheme::baselinePosition):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
        (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
        (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
        (WebCore::RenderThemeMac::hitTestMediaControlPart):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::operator<<):
        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::videoBox):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::RenderView):
        (WebCore::RenderView::calcHeight):
        (WebCore::RenderView::calcWidth):
        (WebCore::RenderView::layout):
        (WebCore::RenderView::viewRect):
        (WebCore::RenderView::docHeight):
        (WebCore::RenderView::docWidth):
        (WebCore::RenderView::setBestTruncatedAt):
        * rendering/RenderView.h:
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):
        (WebCore::RenderWidget::updateWidgetPosition):
        (WebCore::RenderWidget::nodeAtPoint):
        * rendering/RootInlineBox.h:
        (WebCore::RootInlineBox::floats):
        (WebCore::RootInlineBox::floatsPtr):
        * rendering/SVGInlineFlowBox.cpp:
        (WebCore::SVGInlineFlowBox::verticallyAlignBoxes):
        * rendering/SVGInlineFlowBox.h:
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::operator<<):
        (WebCore::write):
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::verticallyAlignBoxes):
        (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
        (WebCore::SVGRootInlineBox::layoutInlineBoxes):
        * rendering/SVGRootInlineBox.h:
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::computeHorizontalPositionsForLine):
        (WebCore::RenderBlock::computeVerticalPositionsForLine):
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::RenderBlock::determineStartPosition):
        (WebCore::RenderBlock::matchedEndLine):
        (WebCore::RenderBlock::skipTrailingWhitespace):
        (WebCore::RenderBlock::skipLeadingWhitespace):
        (WebCore::RenderBlock::fitBelowFloats):
        (WebCore::RenderBlock::findNextLineBreak):
        (WebCore::RenderBlock::checkLinesForOverflow):
        * svg/SVGLength.cpp:
        (WebCore::SVGLength::PercentageOfViewport):

WebKit/mac:

2009-01-21  David Hyatt  <hyatt@apple.com>

        Devirtualize width/height/x/y on RenderObject and move the methods to RenderBox.

        Reviewed by Eric Seidel and Darin Adler

        * WebView/WebRenderNode.mm:
        (copyRenderNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 22 Jan 2009 01:39:57 +0000 (01:39 +0000)]
2009-01-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        More browser->plug-in scripting support.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCNPObjectHasPropertyReply):
        (WKPCNPObjectHasMethodReply):
        (WKPCNPObjectInvokeReply):
        MIG reply functions.

        (WKPCIdentifierInfo):
        Return information about an identifier given its 64-bit value.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        Add new reply structs.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::addValueToArray):
        Split out code that adds values to the arrays from marshalValue.

        (WebKit::NetscapePluginInstanceProxy::marshalValue):
        Call addValueToArray.

        (WebKit::NetscapePluginInstanceProxy::marshalValues):
        Marshal a list of values.

        (WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
        Actually create a proxy instance.

        * Plugins/Hosted/ProxyInstance.h:
        * Plugins/Hosted/ProxyInstance.mm:
        (WebKit::ProxyClass::methodsNamed):
        (WebKit::ProxyClass::fieldNamed):
        Add a proxy ProxyClass class that just forwards everything to the ProxyInstance class.

        (WebKit::proxyClass):
        Shared proxyClass getter.

        (WebKit::ProxyField::ProxyField):
        (WebKit::ProxyField::valueFromInstance):
        (WebKit::ProxyField::setValueToInstance):
        Add a proxy ProxyField class that just forwards everything to the ProxyInstance class.

        (WebKit::ProxyMethod::ProxyMethod):
        (WebKit::ProxyMethod::serverIdentifier):
        (WebKit::ProxyMethod::numParameters):
        Add a dummy ProxyMethod class.

        (WebKit::ProxyInstance::invokeMethod):
        Call _WKPHNPObjectInvoke.

        (WebKit::ProxyInstance::defaultValue):
        (WebKit::ProxyInstance::stringValue):
        (WebKit::ProxyInstance::numberValue):
        (WebKit::ProxyInstance::booleanValue):
        (WebKit::ProxyInstance::valueOf):
        Add dummy implementations (taken from CInstance).

        (WebKit::ProxyInstance::methodsNamed):
        Call _WKPHNPObjectHasMethod to determine whether a method with the given name exists.

        (WebKit::ProxyInstance::fieldNamed):
        Call _WKPHNPObjectHasProperty to determine whether a property with the given name exists.

        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:
        Add new MIG definitions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 Pierre-Olivier Latour <pol@apple.com>
pol@apple.com [Thu, 22 Jan 2009 01:39:19 +0000 (01:39 +0000)]
2009-01-21  Pierre-Olivier Latour  <pol@apple.com>

        Tweaked earlier fix to only print a warning when Perian is installed,
        and fail completely only if attempting to generate new pixel test results.

        https://bugs.webkit.org/show_bug.cgi?id=23392

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 22 Jan 2009 00:50:44 +0000 (00:50 +0000)]
2009-01-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        * WebCore.LP64.exp:
        Add some bridge related symbols.

        * WebCore.xcodeproj/project.pbxproj:
        Make runtime_object.h a private header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 22720: Make XMLHttpRequest work in Workers
oliver@apple.com [Thu, 22 Jan 2009 00:22:45 +0000 (00:22 +0000)]
Bug 22720: Make XMLHttpRequest work in Workers
<https://bugs.webkit.org/show_bug.cgi?id=22720>

Contributed by David Levin.

Reviewed by Alexey Proskuryakov

More removal of document usage from XMLHttpRequest.
* Abstracted away the sync and async requests behind the ThreadableLoader class, which
  will get an implementation for Workers.  It follows the same model as SubresourceLoader, since
  it is a thin wrapper around it.
* Consolidated dashboard compatibility checks into usesDashboardBackwardCompatibilityMode
  which handles workers.

No observable change in behavior, so no test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix for https://bugs.webkit.org/show_bug.cgi?id=23317
cmarrin@apple.com [Thu, 22 Jan 2009 00:13:31 +0000 (00:13 +0000)]
    Fix for https://bugs.webkit.org/show_bug.cgi?id=23317

        The high CPU usage was really from repeatedly firing transitions caused
        by a bug in the way we handle background-color animations. If animating
        from a valid background color to no background color, we sometimes left
        (based on timing) the background color as transparent black, but valid
        rather than invalid, which it should be. Fixing that got rid of the
        repeated firing.

        But we really were doing more expensive iteration of all objects with
        animations or transitions on them (running or not). So I added two
        optimizations to quickly short circuit when an object had no running
        animations or transitions. Things are now as zippy as ever.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Justin Garcia.
eric@webkit.org [Wed, 21 Jan 2009 23:37:08 +0000 (23:37 +0000)]
    Reviewed by Justin Garcia.

        Remove the style='' turds left by some editing commands
        https://bugs.webkit.org/show_bug.cgi?id=23463

        Test: editing/execCommand/toggle-styles.html

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::removeCSSStyle): check if we just removed the last CSS property and remove the style attribute as well
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::removeNodeAttribute): remove extra ;

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoClean up how we force invocations of API that happened on background threads over...
mrowe@apple.com [Wed, 21 Jan 2009 23:25:36 +0000 (23:25 +0000)]
Clean up how we force invocations of API that happened on background threads over to the main thread.

This was previously accomplished in a somewhat ad-hoc manner using a mutable dictionary to pass arguments
and return values back from the function.  The new approach is to use a proxy object that forwards an
NSInvocation over to the main thread and applies it to the target object, which leads to a much cleaner
call site.

Reviewed by Tim Hatcher.

* Misc/WebNSObjectExtras.h:
* Misc/WebNSObjectExtras.mm:
(-[WebMainThreadInvoker initWithTarget:]):
(-[WebMainThreadInvoker forwardInvocation:]):
(-[WebMainThreadInvoker methodSignatureForSelector:]):
(-[WebMainThreadInvoker handleException:]):
(-[NSInvocation _webkit_invokeAndHandleException:]): Execute the invocation and forward any exception that was
raised back to the WebMainThreadInvoker.
(-[NSObject _webkit_invokeOnMainThread]):

The following methods are updated to use the proxy object to forward methods to the main thread:

* WebView/WebArchive.mm:
(-[WebArchive initWithMainResource:subresources:subframeArchives:]):
(-[WebArchive mainResource]):
(-[WebArchive subresources]):
(-[WebArchive subframeArchives]):
* WebView/WebResource.mm:
(-[WebResource data]):
(-[WebResource URL]):
(-[WebResource MIMEType]):
(-[WebResource textEncodingName]):
(-[WebResource frameName]):
(-[WebResource _ignoreWhenUnarchiving]):
(-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
(-[WebResource _initWithData:URL:response:]):
(-[WebResource _suggestedFilename]):
(-[WebResource _response]):
(-[WebResource _stringValue]):
* WebView/WebView.mm:
(-[WebView initWithFrame:frameName:groupName:]):
(-[WebView initWithCoder:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago No review, build fix.
eric@webkit.org [Wed, 21 Jan 2009 23:20:31 +0000 (23:20 +0000)]
    No review, build fix.

        Fix release-only build failure (and do a tiny code-cleanup).

        * editing/ApplyStyleCommand.cpp:
        (WebCore::createFontElement):
        (WebCore::createStyleSpanElement):
        (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 23443: Table accessibility should be re-enabled after fixing crash that occurs...
cfleizach@apple.com [Wed, 21 Jan 2009 22:55:01 +0000 (22:55 +0000)]
Bug 23443: Table accessibility should be re-enabled after fixing crash that occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when attempting to create a link in a rich text message
https://bugs.webkit.org/show_bug.cgi?id=23443

Re-enable Accessibility tables and make sure accessibility code does not interrogate the render tree
during render tree updates

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Justin Garcia.
eric@webkit.org [Wed, 21 Jan 2009 22:16:37 +0000 (22:16 +0000)]
    Reviewed by Justin Garcia.

        Fix execCommand() 'super' and 'sub' commands to add <sup> and <sub> in quirks mode, and to toggle when called twice
        https://bugs.webkit.org/show_bug.cgi?id=17733

        Test changed: editing/execCommand/toggle-styles-expected.txt

        * editing/ApplyStyleCommand.cpp:
        (WebCore::StyleChange::applySubscript):
        (WebCore::StyleChange::applySuperscript):
        (WebCore::StyleChange::StyleChange):
        (WebCore::StyleChange::init):
        (WebCore::StyleChange::checkForLegacyHTMLStyleChange):
        (WebCore::ApplyStyleCommand::isHTMLStyleNode):
        (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
        * editing/EditorCommand.cpp:
        (WebCore::executeSubscript):
        (WebCore::executeSuperscript):
        * editing/htmlediting.cpp:
        (WebCore::createHTMLElement):
        * editing/htmlediting.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 21 Jan 2009 21:52:16 +0000 (21:52 +0000)]
2009-01-21  Anders Carlsson  <andersca@apple.com>

        Fix 64-bit build.

        * WebCore.LP64.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 23458: Reintroduce CanvasPixelArray in ImageData.idl
oliver@apple.com [Wed, 21 Jan 2009 21:05:46 +0000 (21:05 +0000)]
Bug 23458: Reintroduce CanvasPixelArray in ImageData.idl
<https://bugs.webkit.org/show_bug.cgi?id=23458>

Reviewed by Alexey Proskuryakov.

Return CanvasPixelArray, et al -- the only difference between this
and the original CPA implementation is that it now uses a ByteArray
rather than a vector.  JSC still uses a custom wrapper, but this allows
ObjC, COM, and V8 bindings to be autogenerated again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 21 Jan 2009 20:07:07 +0000 (20:07 +0000)]
2009-01-21  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Remove last relics of platform dependent PaintServer in SVG.
        We draw everything with the help of GraphicsContext.

        Remove SVGPaintServerPlatform's
        [https://bugs.webkit.org/show_bug.cgi?id=23439]

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * svg/graphics/SVGPaintServer.cpp:
        (WebCore::SVGPaintServer::draw):
        (WebCore::SVGPaintServer::renderPath):
        (WebCore::SVGPaintServer::teardown):
        * svg/graphics/SVGPaintServer.h:
        * svg/graphics/SVGPaintServerGradient.cpp:
        * svg/graphics/SVGPaintServerGradient.h:
        * svg/graphics/SVGPaintServerPattern.cpp:
        * svg/graphics/SVGPaintServerPattern.h:
        * svg/graphics/SVGPaintServerSolid.cpp:
        * svg/graphics/SVGPaintServerSolid.h:
        * svg/graphics/cairo/SVGPaintServerCairo.cpp: Removed.
        * svg/graphics/cg/SVGPaintServerCg.cpp: Removed.
        * svg/graphics/qt/SVGPaintServerQt.cpp: Removed.
        * svg/graphics/skia/SVGPaintServerSkia.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Alexey Proskuryakov.
zimmermann@webkit.org [Wed, 21 Jan 2009 19:49:37 +0000 (19:49 +0000)]
Reviewed by Alexey Proskuryakov.

Move "Element -> ScriptElement" casting functionality into ScriptElement.h
to be consistent with FormControlElement/InputElement/OptionElement/OptionGroupElement.

It was living in XMLTokenizer before, which is not an obvious place for this.
TODO: Rename 'formControlElementForElement' to 'toFormControlElement' (analogous changes for InputElement etc.)
      as suggested by Alexey, it really reads better this way.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Suggested by Oliver Hunt. Reviewed by Oliver Hunt.
ap@webkit.org [Wed, 21 Jan 2009 18:09:40 +0000 (18:09 +0000)]
    Suggested by Oliver Hunt. Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=23456
        Function argument names leak

        * parser/Nodes.cpp: (JSC::FunctionBodyNode::~FunctionBodyNode): Destruct parameter names.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by George Staikos.
zimmermann@webkit.org [Wed, 21 Jan 2009 16:44:25 +0000 (16:44 +0000)]
Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=23444

Refactor some functionality from HTMLOption/OptGroupElement needed by RenderListBox/RenderMenuList
in two abstract base classes: OptionElement & OptionGroupElement living in dom/ - just like it
has been done before for FormControlElement and RenderTextControl.

This is needed to prepare the addtion of WMLOption/OptGroupElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 21 Jan 2009 07:39:02 +0000 (07:39 +0000)]
2009-01-20  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        Bug 23448: memory leak in Mac version of preferredExtensionForImageSourceType
        https://bugs.webkit.org/show_bug.cgi?id=23448

        * platform/graphics/cg/ImageSourceCGMac.mm:
        (WebCore::preferredExtensionForImageSourceType): Use RetainPtr to avoid the leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 21 Jan 2009 07:25:08 +0000 (07:25 +0000)]
2009-01-20  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        Bug 23450: string leaks seen in DumpRenderTree accessibility test code
        https://bugs.webkit.org/show_bug.cgi?id=23450

        * DumpRenderTree/AccessibilityUIElement.cpp:
        (isAttributeSettableCallback): Add the missing JSStringRelease call.
        (attributeValueCallback): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 21 Jan 2009 06:38:55 +0000 (06:38 +0000)]
2009-01-20  Darin Adler  <darin@apple.com>

        Try to fix Wx build.

        * platform/wx/PasteboardWx.cpp:
        (WebCore::Pasteboard::writeSelection): Removed code that replaces backslash
        with backslashAsCurrencySymbol. I'm pretty sure this is not needed when writing
        to the clipboard. Other platforms don't do it. If it was needed, the new function
        to use would be displayStringModifiedByEncoding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTeach Cairo post-build stage to copy animation headers.
bfulgham@webkit.org [Wed, 21 Jan 2009 05:28:57 +0000 (05:28 +0000)]
Teach Cairo post-build stage to copy animation headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Dmitry Titov <dimich@chromium.org>
alp@webkit.org [Wed, 21 Jan 2009 04:49:50 +0000 (04:49 +0000)]
2009-01-20  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=23413
        Remove unused WebCore::setDeferringTimers()

        * platform/Timer.cpp:
        (WebCore::updateSharedTimer):
        * platform/Timer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix
oliver@apple.com [Wed, 21 Jan 2009 03:51:15 +0000 (03:51 +0000)]
Windows build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 21 Jan 2009 03:19:50 +0000 (03:19 +0000)]
2009-01-20  David Hyatt  <hyatt@apple.com>

        Tighten up the type of RenderObject owned by RenderLayer to be a RenderBox.  Rename m_object to
        m_renderer to be consistent with the corresponding member function.

        Reviewed by Jon Honeycutt

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::RenderLayer):
        (WebCore::RenderLayer::updateLayerPositions):
        (WebCore::RenderLayer::updateVisibilityStatus):
        (WebCore::RenderLayer::updateLayerPosition):
        (WebCore::RenderLayer::stackingContext):
        (WebCore::RenderLayer::enclosingPositionedAncestor):
        (WebCore::RenderLayer::enclosingTransformedAncestor):
        (WebCore::RenderLayer::isTransparent):
        (WebCore::RenderLayer::convertToLayerCoords):
        (WebCore::RenderLayer::scrollByRecursively):
        (WebCore::RenderLayer::scrollToOffset):
        (WebCore::RenderLayer::scrollRectToVisible):
        (WebCore::RenderLayer::resize):
        (WebCore::RenderLayer::scrollbarCornerPresent):
        (WebCore::RenderLayer::createScrollbar):
        (WebCore::RenderLayer::setHasHorizontalScrollbar):
        (WebCore::RenderLayer::setHasVerticalScrollbar):
        (WebCore::RenderLayer::positionOverflowControls):
        (WebCore::RenderLayer::computeScrollDimensions):
        (WebCore::RenderLayer::updateOverflowStatus):
        (WebCore::RenderLayer::updateScrollInfoAfterLayout):
        (WebCore::RenderLayer::paintOverflowControls):
        (WebCore::RenderLayer::paintScrollCorner):
        (WebCore::RenderLayer::paintResizer):
        (WebCore::RenderLayer::isPointInResizeControl):
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::hitTestLayer):
        (WebCore::RenderLayer::updateClipRects):
        (WebCore::RenderLayer::calculateClipRects):
        (WebCore::RenderLayer::calculateRects):
        (WebCore::RenderLayer::clearClipRects):
        (WebCore::RenderLayer::repaintIncludingDescendants):
        (WebCore::RenderLayer::styleChanged):
        (WebCore::RenderLayer::updateScrollCornerStyle):
        (WebCore::RenderLayer::updateResizerStyle):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::renderer):
        (WebCore::RenderLayer::hasReflection):
        (WebCore::RenderLayer::hasTransform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 21 Jan 2009 01:59:22 +0000 (01:59 +0000)]
2009-01-20  David Hyatt  <hyatt@apple.com>

        Fix Mac build bustage from my selection changes.  I forgot to implement the functions on RenderThemeMac
        for returning the appropriate listbox selection colors.

        Reviewed by Adele

        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor):
        (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor):
        (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Wed, 21 Jan 2009 01:53:11 +0000 (01:53 +0000)]
2009-01-20  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Mark Rowe.

        Structure property table deleted offset maps are being leaked.
        Probably shouldn't be doing that.

        https://bugs.webkit.org/show_bug.cgi?id=23442

        * runtime/Structure.cpp:
        (JSC::Structure::~Structure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Pierre-Olivier Latour <pol@apple.com>
pol@apple.com [Wed, 21 Jan 2009 00:30:39 +0000 (00:30 +0000)]
2009-01-20  Pierre-Olivier Latour  <pol@apple.com>

        Reviewed by Darin Adler.

        Print warning regarding display color profile change in run-webkit-tests instead of DRT.

        https://bugs.webkit.org/show_bug.cgi?id=23392

        * DumpRenderTree/mac/PixelDumpSupportMac.mm:
        (setupMainDisplayColorProfile):
        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix selection colors and focus rings on Windows.
hyatt@apple.com [Tue, 20 Jan 2009 23:31:34 +0000 (23:31 +0000)]
Fix selection colors and focus rings on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Pierre-Olivier Latour <pol@apple.com>
pol@apple.com [Tue, 20 Jan 2009 23:25:15 +0000 (23:25 +0000)]
2009-01-20  Pierre-Olivier Latour  <pol@apple.com>

        Reviewed by Darin Adler.

        Changed run-webkit-tests to abort on the Mac if pixel tests are enabled and Perian is installed,
        in order to avoid result differences in some media tests.

        https://bugs.webkit.org/show_bug.cgi?id=22615

        * Scripts/run-webkit-tests:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAttempt to fix gtk build
oliver@apple.com [Tue, 20 Jan 2009 22:35:33 +0000 (22:35 +0000)]
Attempt to fix gtk build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by George Staikos.
zimmermann@webkit.org [Tue, 20 Jan 2009 22:29:09 +0000 (22:29 +0000)]
Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=23434

Add WML <input> element support - it required a lot of changes to the RenderText*/HTMLInput* code.
Now any language can provide <input>-style elements, without having to inherit from HTML* classes.

No WML specific features/attributes are handled so far. A follow-up patch will provide those bits.
Added very simple fast/wml/input.wml, just checking that input elements can be rendered properly now.
Detailed testcases will follow in conjunction with the WML specific attribute support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 20 Jan 2009 21:54:40 +0000 (21:54 +0000)]
2009-01-20  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan.

        Remove a little dead code left over after the fix for
        https://bugs.webkit.org/show_bug.cgi?id=11395, which
        moved pointer-events from SVG to be shared with HTML.

        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue): Remove SVG's parsing of this
        property since it's handled in the non-SVG function now so we'll
        never get here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago009-01-20 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Tue, 20 Jan 2009 21:54:25 +0000 (21:54 +0000)]
009-01-20  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin Adler.

        Bug 23438: Provide a default value to the .in file parser

        Added the default value 1 as it simplifies some of
        the format by removing some "=1" that were awkward.

        This was suggested by Darin Adler as par of a previous
        review.

        * bindings/scripts/InFilesParser.pm: When no value
        was entered (the second part of the split is undef),
        provide the default value.

        * html/HTMLAttributeNames.in: Removed unnecessary "=1".
        * html/HTMLTagNames.in: Ditto.
        * svg/svgattrs.in: Ditto.
        * svg/svgtags.in: Ditto.
        * svg/xlinkattrs.in: Ditto.
        * wml/WMLAttributeNames.in: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 20 Jan 2009 21:41:36 +0000 (21:41 +0000)]
2009-01-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        * bridge/c/c_class.cpp:
        * bridge/c/c_class.h:
        Get rid of CClass::name().

        * bridge/jni/jni_class.h:
        Get rid of JavaClass::name().

        * bridge/objc/objc_class.h:
        * bridge/objc/objc_class.mm:
        Get rid of ObjcClass::name().

        * bridge/objc/objc_instance.h:
        Get rid of supportsSetValueOfUndefinedField.

        * bridge/objc/objc_instance.mm:
        (ObjcInstance::setValueOfUndefinedField):
        Fold supportsSetValueOfUndefinedField into setValueOfUndefinedField.

        * bridge/runtime.cpp:
        Get rid of getValueOfField and setValueOfField.

        * bridge/runtime.h:
        (JSC::Bindings::Instance::setValueOfUndefinedField):
        Have this return a bool and get rid of supportsSetValueOfUndefinedField

        * bridge/runtime_object.cpp:
        (JSC::RuntimeObjectImp::fieldGetter):
        Call Field::valueFromInstance on the field.

        (JSC::RuntimeObjectImp::put):
        Call Field::setValueToInstance on the field.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Forgot to land build changes for non-mac platforms.
zimmermann@webkit.org [Tue, 20 Jan 2009 21:29:37 +0000 (21:29 +0000)]
Not reviewed. Forgot to land build changes for non-mac platforms.
Add InputElement.cpp & FormControlElement.cpp to build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Adam Roben.
zimmermann@webkit.org [Tue, 20 Jan 2009 21:18:19 +0000 (21:18 +0000)]
Reviewed by Adam Roben.

Fix last-minute regression, introduced by simplifying max length determination - by
clamping using min/max, negative maxLength values got broken.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Adam Roben.
zimmermann@webkit.org [Tue, 20 Jan 2009 21:02:58 +0000 (21:02 +0000)]
Reviewed by Adam Roben.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=23433

Add InputElement abstraction, similar to the FormControlElement refactorization
done a month ago. The goal is to share as much code as possible between HTML/WMLInputElement.
In a previous patch the RenderTextControl class has been split-up in RenderTextControlSingle/MultiLine,
RenderTextControl itself only depends on FormControlElement, RenderTextControlSingleLine still
depends on HTMLInputElement directly -> change that and make it use the new InputElement abstraction.

A lot of code from HTMLInputElement now lives in InputElement, as static member functions - the
InputElement class itself is an abstract virtual class, just like ScriptElement. HTML/WMLInputElement
derive from InputElement, and hold a InputElementData member variable, that they pass to the
static functions in InputElement. The abstraction is equal to the one chosen for HTML/SVGScriptElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Pierre-Olivier Latour <pol@apple.com>
pol@apple.com [Tue, 20 Jan 2009 20:54:55 +0000 (20:54 +0000)]
2009-01-20  Pierre-Olivier Latour  <pol@apple.com>

        Previously uploaded reference images were generated with Perian installed, which affected them
        as explained in https://bugs.webkit.org/show_bug.cgi?id=22615.

        * platform/mac/media/video-zoom-expected.checksum:
        * platform/mac/media/video-zoom-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Tue, 20 Jan 2009 19:52:10 +0000 (19:52 +0000)]
2009-01-20  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Make SVG pattern platform independent and remove platform code.

        Make SVGPattern platform independent
        https://bugs.webkit.org/show_bug.cgi?id=21205

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::applyStrokePattern):
        (WebCore::GraphicsContext::applyFillPattern):
        (WebCore::GraphicsContext::drawPath):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::strokeRect):
        * svg/graphics/SVGPaintServerPattern.cpp:
        (WebCore::SVGPaintServerPattern::SVGPaintServerPattern):
        (WebCore::SVGPaintServerPattern::~SVGPaintServerPattern):
        (WebCore::SVGPaintServerPattern::setup):
        (WebCore::SVGPaintServerPattern::renderPath):
        (WebCore::SVGPaintServerPattern::teardown):
        * svg/graphics/SVGPaintServerPattern.h:
        * svg/graphics/cairo/SVGPaintServerPatternCairo.cpp: Removed.
        * svg/graphics/cg/SVGPaintServerPatternCg.cpp: Removed.
        * svg/graphics/qt/SVGPaintServerPatternQt.cpp: Removed.
        * svg/graphics/skia/SVGPaintServerPatternSkia.cpp: Removed.

        LayoutTests:

        stroke-pattern is wrong and coords-units-01-b match the behavior of
        batik and Firefox.

        * platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
        * platform/mac/svg/custom/stroked-pattern-expected.checksum:
        * platform/mac/svg/custom/stroked-pattern-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 20 Jan 2009 19:39:14 +0000 (19:39 +0000)]
2009-01-20  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23436
        Upstream rendering/RenderThemeChromium*

        * rendering/RenderThemeChromiumGtk.cpp: Added.
        * rendering/RenderThemeChromiumGtk.h: Added.
        * rendering/RenderThemeChromiumMac.h: Added.
        * rendering/RenderThemeChromiumMac.mm: Added.
        * rendering/RenderThemeChromiumWin.cpp: Added.
        * rendering/RenderThemeChromiumWin.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit:
andersca@apple.com [Tue, 20 Jan 2009 19:33:48 +0000 (19:33 +0000)]
WebKit:

2009-01-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add ProxyInstance files.

        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-01-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add and implement GetScriptableNPObject.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCGetScriptableNPObjectReply):
        Create a new reply struct and set it as the current reply.

        (WKPCEvaluate):
        Get rid of an unused variable.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::Reply::):
        (WebKit::NetscapePluginInstanceProxy::GetScriptableNPObjectReply::GetScriptableNPObjectReply):
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
        Call _WKPHGetScriptableNPObject and wait for a reply.

        * Plugins/Hosted/ProxyInstance.h: Added.
        * Plugins/Hosted/ProxyInstance.mm: Added.
        Add empty files.

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView JSC::Bindings::createPluginBindingsInstance:JSC::Bindings::]):
        Call NetscapePluginInstanceProxy::createBindingsInstance.

        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:
        Add new declarations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 20 Jan 2009 18:38:58 +0000 (18:38 +0000)]
2009-01-20  Darin Adler  <darin@apple.com>

        * runtime/StringPrototype.cpp:
        (JSC::substituteBackreferences): Add back the initialization to fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
darin@apple.com [Tue, 20 Jan 2009 18:25:30 +0000 (18:25 +0000)]
JavaScriptCore:

2009-01-20  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Bug 23352: Turn on more compiler warnings in the Mac build
        https://bugs.webkit.org/show_bug.cgi?id=23352

        First patch: Fix some simple cases of various warnings.

        * pcre/pcre_compile.cpp:
        (jsRegExpCompile): Use const_cast to change const-ness.

        * runtime/StringPrototype.cpp:
        (JSC::substituteBackreferences): Remove unneeded initialization and
        use UChar instead of unsigned short for UTF-16 values.

        * wtf/dtoa.cpp:
        (WTF::strtod): Use const_cast to change const-ness.

WebCore:

2009-01-20  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Bug 23352: Turn on more compiler warnings in the Mac build
        https://bugs.webkit.org/show_bug.cgi?id=23352

        First patch: Fix some simple cases of various warnings.

        * platform/DeprecatedPtrListImpl.cpp:
        (WebCore::DeprecatedPtrListImpl::insert): Use const_cast to change const-ness.
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::containsCharacters): Ditto.

        * platform/text/PlatformString.h: Overload for short and unsigned short to avoid
        ambiguity leading to warnings.
        * platform/text/String.cpp:
        (WebCore::String::number): Implemented overloads.

        * platform/text/TextStream.cpp:
        (WebCore::TextStream::operator<<): Overload for bool to avoid ambiguity leading
        to warnings.
        * platform/text/TextStream.h: Ditto.

        * rendering/InlineFlowBox.h: Fix declaration that was specifying the wrong type.

        * svg/graphics/filters/cg/WKLinearTransferFilter.m: Fix stray characters after
        #endif that should be a comment instead.
        * svg/graphics/filters/cg/WKSpecularLightingFilter.h: Ditto.

        * xml/XPathPath.h: Remove unneeded redundant declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix for WML enabled builds, not reviewed.
zimmermann@webkit.org [Tue, 20 Jan 2009 17:44:15 +0000 (17:44 +0000)]
Build fix for WML enabled builds, not reviewed.
Fix unused variable warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix for WML enabled builds, not reviewed.
zimmermann@webkit.org [Tue, 20 Jan 2009 17:23:24 +0000 (17:23 +0000)]
Build fix for WML enabled builds, not reviewed.
Rename 'continuation' to 'virtualContinuation'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWhoops, remove runtime/ByteArray references from .pri and .scons builds, update .bkl
oliver@apple.com [Tue, 20 Jan 2009 17:04:35 +0000 (17:04 +0000)]
Whoops, remove runtime/ByteArray references from .pri and .scons builds, update .bkl

Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMove runtime/ByteArray to wtf/ByteArray
oliver@apple.com [Tue, 20 Jan 2009 16:57:04 +0000 (16:57 +0000)]
Move runtime/ByteArray to wtf/ByteArray

RS=Dan Bernstein

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 20 Jan 2009 16:06:11 +0000 (16:06 +0000)]
2009-01-20  Darin Fisher  <darin@chromium.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=23391
        Upstream plugins/chromium/

        * plugins/chromium: Added.
        * plugins/chromium/PluginDataChromium.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Friedemann Kleint <Friedemann.Kleint@nokia.com>
hausmann@webkit.org [Tue, 20 Jan 2009 12:26:09 +0000 (12:26 +0000)]
2009-01-20  Friedemann Kleint  <Friedemann.Kleint@nokia.com>

        Reviewed by Simon Hausmann.

        Fix spelling error in QWebPage

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix Windows release build.
sfalken@apple.com [Tue, 20 Jan 2009 07:01:07 +0000 (07:01 +0000)]
    Fix Windows release build.
        Move SVG files into all-in-one file for Windows build.

        * WebCore.vcproj/WebCore.vcproj:
        * svg/SVGAllInOne.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 20 Jan 2009 03:31:37 +0000 (03:31 +0000)]
2009-01-19  Simon Fraser  <simon.fraser@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=18078

        New testcases for transitions of shorthand properties.

        * transitions/shorthand-border-transitions-expected.txt: Added.
        * transitions/shorthand-border-transitions.html: Added.
        * transitions/shorthand-transitions-expected.txt: Added.
        * transitions/shorthand-transitions.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Partial build fix.
sfalken@apple.com [Tue, 20 Jan 2009 03:14:13 +0000 (03:14 +0000)]
    Partial build fix.
        Move new derived sources into all-in-one DerivedSources.cpp

        * DerivedSources.cpp:
        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 20 Jan 2009 02:34:04 +0000 (02:34 +0000)]
2009-01-19  Sam Weinig  <sam@webkit.org>

        * Scripts/do-webcore-rename: Add JSValuePtr and ProtectedJSValuePtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 20 Jan 2009 01:29:02 +0000 (01:29 +0000)]
2009-01-19  Sam Weinig  <sam@webkit.org>

        Fix Qt build.

        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtInstance::mark):
        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::valueRealType):
        (JSC::Bindings::convertValueToQVariant):
        (JSC::Bindings::QtRuntimeConnectionMethod::call):
        (JSC::Bindings::QtConnectionObject::execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 20 Jan 2009 01:15:45 +0000 (01:15 +0000)]
2009-01-19  Sam Weinig  <sam@webkit.org>

        Fix wx build.

        * plugins/PluginView.cpp:
        (WebCore::getString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
weinig@apple.com [Tue, 20 Jan 2009 00:54:18 +0000 (00:54 +0000)]
JavaScriptCore:

2009-01-19  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Gavin Barraclough.

        Remove temporary operator-> from JSValuePtr.

        * API/JSCallbackFunction.cpp:
        (JSC::JSCallbackFunction::call):
        * API/JSCallbackObjectFunctions.h:
        (JSC::::call):
        (JSC::::toNumber):
        (JSC::::toString):
        * API/JSObjectRef.cpp:
        (JSObjectSetPrototype):
        * API/JSValueRef.cpp:
        (JSValueGetType):
        (JSValueIsUndefined):
        (JSValueIsNull):
        (JSValueIsBoolean):
        (JSValueIsNumber):
        (JSValueIsString):
        (JSValueIsObject):
        (JSValueIsObjectOfClass):
        (JSValueToBoolean):
        (JSValueToNumber):
        (JSValueToStringCopy):
        (JSValueToObject):
        * bytecode/CodeBlock.cpp:
        (JSC::valueToSourceString):
        (JSC::CodeBlock::mark):
        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::isKnownNotImmediate):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::emitEqualityOp):
        (JSC::keyForImmediateSwitch):
        * interpreter/Interpreter.cpp:
        (JSC::jsLess):
        (JSC::jsLessEq):
        (JSC::jsAddSlowCase):
        (JSC::jsAdd):
        (JSC::jsTypeStringForValue):
        (JSC::jsIsObjectType):
        (JSC::jsIsFunctionType):
        (JSC::isNotObject):
        (JSC::Interpreter::callEval):
        (JSC::Interpreter::throwException):
        (JSC::cachePrototypeChain):
        (JSC::Interpreter::tryCachePutByID):
        (JSC::countPrototypeChainEntriesAndCheckForProxies):
        (JSC::Interpreter::tryCacheGetByID):
        (JSC::Interpreter::privateExecute):
        (JSC::Interpreter::tryCTICachePutByID):
        (JSC::Interpreter::tryCTICacheGetByID):
        (JSC::Interpreter::cti_op_convert_this):
        (JSC::Interpreter::cti_op_add):
        (JSC::Interpreter::cti_op_pre_inc):
        (JSC::Interpreter::cti_op_put_by_id_generic):
        (JSC::Interpreter::cti_op_get_by_id_generic):
        (JSC::Interpreter::cti_op_put_by_id):
        (JSC::Interpreter::cti_op_put_by_id_second):
        (JSC::Interpreter::cti_op_put_by_id_fail):
        (JSC::Interpreter::cti_op_get_by_id):
        (JSC::Interpreter::cti_op_get_by_id_second):
        (JSC::Interpreter::cti_op_get_by_id_self_fail):
        (JSC::Interpreter::cti_op_get_by_id_proto_list):
        (JSC::Interpreter::cti_op_get_by_id_proto_list_full):
        (JSC::Interpreter::cti_op_get_by_id_proto_fail):
        (JSC::Interpreter::cti_op_get_by_id_array_fail):
        (JSC::Interpreter::cti_op_get_by_id_string_fail):
        (JSC::Interpreter::cti_op_instanceof):
        (JSC::Interpreter::cti_op_del_by_id):
        (JSC::Interpreter::cti_op_mul):
        (JSC::Interpreter::cti_op_call_JSFunction):
        (JSC::Interpreter::cti_op_call_NotJSFunction):
        (JSC::Interpreter::cti_op_construct_JSConstruct):
        (JSC::Interpreter::cti_op_construct_NotJSConstruct):
        (JSC::Interpreter::cti_op_get_by_val):
        (JSC::Interpreter::cti_op_get_by_val_byte_array):
        (JSC::Interpreter::cti_op_sub):
        (JSC::Interpreter::cti_op_put_by_val):
        (JSC::Interpreter::cti_op_put_by_val_array):
        (JSC::Interpreter::cti_op_put_by_val_byte_array):
        (JSC::Interpreter::cti_op_loop_if_true):
        (JSC::Interpreter::cti_op_negate):
        (JSC::Interpreter::cti_op_div):
        (JSC::Interpreter::cti_op_pre_dec):
        (JSC::Interpreter::cti_op_not):
        (JSC::Interpreter::cti_op_jtrue):
        (JSC::Interpreter::cti_op_post_inc):
        (JSC::Interpreter::cti_op_lshift):
        (JSC::Interpreter::cti_op_bitand):
        (JSC::Interpreter::cti_op_rshift):
        (JSC::Interpreter::cti_op_bitnot):
        (JSC::Interpreter::cti_op_mod):
        (JSC::Interpreter::cti_op_post_dec):
        (JSC::Interpreter::cti_op_urshift):
        (JSC::Interpreter::cti_op_bitxor):
        (JSC::Interpreter::cti_op_bitor):
        (JSC::Interpreter::cti_op_push_scope):
        (JSC::Interpreter::cti_op_is_undefined):
        (JSC::Interpreter::cti_op_is_boolean):
        (JSC::Interpreter::cti_op_is_number):
        (JSC::Interpreter::cti_op_to_jsnumber):
        (JSC::Interpreter::cti_op_in):
        (JSC::Interpreter::cti_op_put_by_index):
        (JSC::Interpreter::cti_op_switch_imm):
        (JSC::Interpreter::cti_op_switch_char):
        (JSC::Interpreter::cti_op_switch_string):
        (JSC::Interpreter::cti_op_del_by_val):
        (JSC::Interpreter::cti_op_put_getter):
        (JSC::Interpreter::cti_op_put_setter):
        (JSC::Interpreter::cti_op_new_error):
        * interpreter/Interpreter.h:
        (JSC::Interpreter::isJSArray):
        (JSC::Interpreter::isJSString):
        (JSC::Interpreter::isJSByteArray):
        * interpreter/Register.h:
        (JSC::Register::marked):
        (JSC::Register::mark):
        * jit/JITInlineMethods.h:
        (JSC::JIT::getConstantOperandImmediateInt):
        (JSC::JIT::isOperandConstantImmediateInt):
        * jsc.cpp:
        (functionPrint):
        (functionDebug):
        (functionRun):
        (functionLoad):
        (runWithScripts):
        (runInteractive):
        * parser/Nodes.cpp:
        (JSC::processClauseList):
        * profiler/ProfileGenerator.cpp:
        (JSC::ProfileGenerator::addParentForConsoleStart):
        * profiler/Profiler.cpp:
        (JSC::Profiler::createCallIdentifier):
        * runtime/ArrayConstructor.cpp:
        (JSC::constructArrayWithSizeQuirk):
        * runtime/ArrayPrototype.cpp:
        (JSC::arrayProtoFuncToString):
        (JSC::arrayProtoFuncToLocaleString):
        (JSC::arrayProtoFuncJoin):
        (JSC::arrayProtoFuncConcat):
        (JSC::arrayProtoFuncPop):
        (JSC::arrayProtoFuncPush):
        (JSC::arrayProtoFuncReverse):
        (JSC::arrayProtoFuncShift):
        (JSC::arrayProtoFuncSlice):
        (JSC::arrayProtoFuncSort):
        (JSC::arrayProtoFuncSplice):
        (JSC::arrayProtoFuncUnShift):
        (JSC::arrayProtoFuncFilter):
        (JSC::arrayProtoFuncMap):
        (JSC::arrayProtoFuncEvery):
        (JSC::arrayProtoFuncForEach):
        (JSC::arrayProtoFuncSome):
        (JSC::arrayProtoFuncIndexOf):
        (JSC::arrayProtoFuncLastIndexOf):
        * runtime/BooleanConstructor.cpp:
        (JSC::constructBoolean):
        (JSC::callBooleanConstructor):
        * runtime/BooleanPrototype.cpp:
        (JSC::booleanProtoFuncToString):
        (JSC::booleanProtoFuncValueOf):
        * runtime/Collector.cpp:
        (JSC::Heap::protect):
        (JSC::Heap::unprotect):
        (JSC::Heap::heap):
        (JSC::Heap::collect):
        (JSC::typeName):
        * runtime/Completion.cpp:
        (JSC::evaluate):
        * runtime/DateConstructor.cpp:
        (JSC::constructDate):
        (JSC::dateParse):
        (JSC::dateUTC):
        * runtime/DateInstance.h:
        (JSC::DateInstance::internalNumber):
        * runtime/DatePrototype.cpp:
        (JSC::formatLocaleDate):
        (JSC::fillStructuresUsingTimeArgs):
        (JSC::fillStructuresUsingDateArgs):
        (JSC::dateProtoFuncToString):
        (JSC::dateProtoFuncToUTCString):
        (JSC::dateProtoFuncToDateString):
        (JSC::dateProtoFuncToTimeString):
        (JSC::dateProtoFuncToLocaleString):
        (JSC::dateProtoFuncToLocaleDateString):
        (JSC::dateProtoFuncToLocaleTimeString):
        (JSC::dateProtoFuncGetTime):
        (JSC::dateProtoFuncGetFullYear):
        (JSC::dateProtoFuncGetUTCFullYear):
        (JSC::dateProtoFuncToGMTString):
        (JSC::dateProtoFuncGetMonth):
        (JSC::dateProtoFuncGetUTCMonth):
        (JSC::dateProtoFuncGetDate):
        (JSC::dateProtoFuncGetUTCDate):
        (JSC::dateProtoFuncGetDay):
        (JSC::dateProtoFuncGetUTCDay):
        (JSC::dateProtoFuncGetHours):
        (JSC::dateProtoFuncGetUTCHours):
        (JSC::dateProtoFuncGetMinutes):
        (JSC::dateProtoFuncGetUTCMinutes):
        (JSC::dateProtoFuncGetSeconds):
        (JSC::dateProtoFuncGetUTCSeconds):
        (JSC::dateProtoFuncGetMilliSeconds):
        (JSC::dateProtoFuncGetUTCMilliseconds):
        (JSC::dateProtoFuncGetTimezoneOffset):
        (JSC::dateProtoFuncSetTime):
        (JSC::setNewValueFromTimeArgs):
        (JSC::setNewValueFromDateArgs):
        (JSC::dateProtoFuncSetYear):
        (JSC::dateProtoFuncGetYear):
        * runtime/ErrorConstructor.cpp:
        (JSC::constructError):
        * runtime/ErrorPrototype.cpp:
        (JSC::errorProtoFuncToString):
        * runtime/ExceptionHelpers.cpp:
        (JSC::createError):
        (JSC::createErrorMessage):
        * runtime/FunctionConstructor.cpp:
        (JSC::constructFunction):
        * runtime/FunctionPrototype.cpp:
        (JSC::functionProtoFuncToString):
        (JSC::functionProtoFuncApply):
        (JSC::functionProtoFuncCall):
        * runtime/GetterSetter.cpp:
        (JSC::GetterSetter::toObject):
        * runtime/JSActivation.cpp:
        (JSC::JSActivation::getOwnPropertySlot):
        * runtime/JSArray.cpp:
        (JSC::JSArray::put):
        (JSC::JSArray::mark):
        (JSC::JSArray::sort):
        (JSC::AVLTreeAbstractorForArrayCompare::compare_key_key):
        (JSC::JSArray::compactForSorting):
        * runtime/JSByteArray.h:
        (JSC::JSByteArray::setIndex):
        * runtime/JSCell.h:
        (JSC::asCell):
        * runtime/JSFunction.cpp:
        (JSC::JSFunction::call):
        (JSC::JSFunction::construct):
        * runtime/JSGlobalObject.cpp:
        (JSC::markIfNeeded):
        (JSC::lastInPrototypeChain):
        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::encode):
        (JSC::decode):
        (JSC::globalFuncEval):
        (JSC::globalFuncParseInt):
        (JSC::globalFuncParseFloat):
        (JSC::globalFuncIsNaN):
        (JSC::globalFuncIsFinite):
        (JSC::globalFuncEscape):
        (JSC::globalFuncUnescape):
        (JSC::globalFuncJSCPrint):
        * runtime/JSImmediate.cpp:
        (JSC::JSImmediate::toThisObject):
        (JSC::JSImmediate::toObject):
        (JSC::JSImmediate::prototype):
        (JSC::JSImmediate::toString):
        * runtime/JSImmediate.h:
        * runtime/JSObject.cpp:
        (JSC::JSObject::mark):
        (JSC::JSObject::put):
        (JSC::callDefaultValueFunction):
        (JSC::JSObject::getPrimitiveNumber):
        (JSC::JSObject::defineGetter):
        (JSC::JSObject::defineSetter):
        (JSC::JSObject::lookupGetter):
        (JSC::JSObject::lookupSetter):
        (JSC::JSObject::hasInstance):
        (JSC::JSObject::toNumber):
        (JSC::JSObject::toString):
        * runtime/JSObject.h:
        (JSC::JSObject::JSObject):
        (JSC::JSObject::inlineGetOwnPropertySlot):
        (JSC::JSObject::getOwnPropertySlotForWrite):
        (JSC::JSObject::getPropertySlot):
        (JSC::JSValuePtr::get):
        * runtime/JSPropertyNameIterator.h:
        (JSC::JSPropertyNameIterator::create):
        * runtime/JSString.cpp:
        (JSC::JSString::getOwnPropertySlot):
        * runtime/JSValue.h:
        * runtime/JSWrapperObject.cpp:
        (JSC::JSWrapperObject::mark):
        * runtime/JSWrapperObject.h:
        (JSC::JSWrapperObject::setInternalValue):
        * runtime/MathObject.cpp:
        (JSC::mathProtoFuncAbs):
        (JSC::mathProtoFuncACos):
        (JSC::mathProtoFuncASin):
        (JSC::mathProtoFuncATan):
        (JSC::mathProtoFuncATan2):
        (JSC::mathProtoFuncCeil):
        (JSC::mathProtoFuncCos):
        (JSC::mathProtoFuncExp):
        (JSC::mathProtoFuncFloor):
        (JSC::mathProtoFuncLog):
        (JSC::mathProtoFuncMax):
        (JSC::mathProtoFuncMin):
        (JSC::mathProtoFuncPow):
        (JSC::mathProtoFuncRound):
        (JSC::mathProtoFuncSin):
        (JSC::mathProtoFuncSqrt):
        (JSC::mathProtoFuncTan):
        * runtime/NativeErrorConstructor.cpp:
        (JSC::NativeErrorConstructor::NativeErrorConstructor):
        (JSC::NativeErrorConstructor::construct):
        * runtime/NumberConstructor.cpp:
        (JSC::constructWithNumberConstructor):
        (JSC::callNumberConstructor):
        * runtime/NumberPrototype.cpp:
        (JSC::numberProtoFuncToString):
        (JSC::numberProtoFuncToLocaleString):
        (JSC::numberProtoFuncValueOf):
        (JSC::numberProtoFuncToFixed):
        (JSC::numberProtoFuncToExponential):
        (JSC::numberProtoFuncToPrecision):
        * runtime/ObjectConstructor.cpp:
        (JSC::constructObject):
        * runtime/ObjectPrototype.cpp:
        (JSC::objectProtoFuncValueOf):
        (JSC::objectProtoFuncHasOwnProperty):
        (JSC::objectProtoFuncIsPrototypeOf):
        (JSC::objectProtoFuncDefineGetter):
        (JSC::objectProtoFuncDefineSetter):
        (JSC::objectProtoFuncLookupGetter):
        (JSC::objectProtoFuncLookupSetter):
        (JSC::objectProtoFuncPropertyIsEnumerable):
        (JSC::objectProtoFuncToLocaleString):
        (JSC::objectProtoFuncToString):
        * runtime/Operations.h:
        (JSC::JSValuePtr::equalSlowCaseInline):
        (JSC::JSValuePtr::strictEqual):
        (JSC::JSValuePtr::strictEqualSlowCaseInline):
        * runtime/Protect.h:
        (JSC::gcProtect):
        (JSC::gcUnprotect):
        * runtime/RegExpConstructor.cpp:
        (JSC::setRegExpConstructorInput):
        (JSC::setRegExpConstructorMultiline):
        (JSC::constructRegExp):
        * runtime/RegExpObject.cpp:
        (JSC::setRegExpObjectLastIndex):
        (JSC::RegExpObject::match):
        * runtime/RegExpPrototype.cpp:
        (JSC::regExpProtoFuncTest):
        (JSC::regExpProtoFuncExec):
        (JSC::regExpProtoFuncCompile):
        (JSC::regExpProtoFuncToString):
        * runtime/StringConstructor.cpp:
        (JSC::stringFromCharCodeSlowCase):
        (JSC::stringFromCharCode):
        (JSC::constructWithStringConstructor):
        (JSC::callStringConstructor):
        * runtime/StringPrototype.cpp:
        (JSC::stringProtoFuncReplace):
        (JSC::stringProtoFuncToString):
        (JSC::stringProtoFuncCharAt):
        (JSC::stringProtoFuncCharCodeAt):
        (JSC::stringProtoFuncConcat):
        (JSC::stringProtoFuncIndexOf):
        (JSC::stringProtoFuncLastIndexOf):
        (JSC::stringProtoFuncMatch):
        (JSC::stringProtoFuncSearch):
        (JSC::stringProtoFuncSlice):
        (JSC::stringProtoFuncSplit):
        (JSC::stringProtoFuncSubstr):
        (JSC::stringProtoFuncSubstring):
        (JSC::stringProtoFuncToLowerCase):
        (JSC::stringProtoFuncToUpperCase):
        (JSC::stringProtoFuncLocaleCompare):
        (JSC::stringProtoFuncBig):
        (JSC::stringProtoFuncSmall):
        (JSC::stringProtoFuncBlink):
        (JSC::stringProtoFuncBold):
        (JSC::stringProtoFuncFixed):
        (JSC::stringProtoFuncItalics):
        (JSC::stringProtoFuncStrike):
        (JSC::stringProtoFuncSub):
        (JSC::stringProtoFuncSup):
        (JSC::stringProtoFuncFontcolor):
        (JSC::stringProtoFuncFontsize):
        (JSC::stringProtoFuncAnchor):
        (JSC::stringProtoFuncLink):
        * runtime/Structure.cpp:
        (JSC::Structure::Structure):
        (JSC::Structure::getEnumerablePropertyNames):
        (JSC::Structure::createCachedPrototypeChain):
        * runtime/Structure.h:
        (JSC::Structure::mark):
        * runtime/StructureChain.cpp:
        (JSC::StructureChain::StructureChain):

JavaScriptGlue:

2009-01-19  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Gavin Barraclough.

        Remove temporary operator-> from JSValuePtr.

        * JSUtils.cpp:
        (KJSValueToJSObject):
        (KJSValueToCFTypeInternal):
        * JSValueWrapper.cpp:
        (JSValueWrapper::JSObjectCopyPropertyNames):
        (JSValueWrapper::JSObjectCopyProperty):
        (JSValueWrapper::JSObjectSetProperty):
        (JSValueWrapper::JSObjectCallFunction):
        (JSValueWrapper::JSObjectMark):
        * UserObjectImp.cpp:
        (UserObjectImp::getOwnPropertySlot):

WebCore:

2009-01-19  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Gavin Barraclough.

        Remove temporary operator-> from JSValuePtr.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::constructAudio):
        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        (WebCore::toHTMLCanvasStyle):
        (WebCore::JSCanvasRenderingContext2D::setFillColor):
        (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
        (WebCore::JSCanvasRenderingContext2D::strokeRect):
        (WebCore::JSCanvasRenderingContext2D::drawImage):
        (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
        (WebCore::JSCanvasRenderingContext2D::setShadow):
        (WebCore::JSCanvasRenderingContext2D::createPattern):
        (WebCore::JSCanvasRenderingContext2D::putImageData):
        (WebCore::JSCanvasRenderingContext2D::fillText):
        (WebCore::JSCanvasRenderingContext2D::strokeText):
        * bindings/js/JSClipboardCustom.cpp:
        (WebCore::JSClipboard::clearData):
        (WebCore::JSClipboard::getData):
        (WebCore::JSClipboard::setData):
        (WebCore::JSClipboard::setDragImage):
        * bindings/js/JSCustomPositionCallback.cpp:
        (WebCore::JSCustomPositionCallback::handleEvent):
        * bindings/js/JSCustomPositionErrorCallback.cpp:
        (WebCore::JSCustomPositionErrorCallback::handleEvent):
        * bindings/js/JSCustomSQLStatementCallback.cpp:
        (WebCore::JSCustomSQLStatementCallback::handleEvent):
        * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
        (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
        * bindings/js/JSCustomSQLTransactionCallback.cpp:
        (WebCore::JSCustomSQLTransactionCallback::handleEvent):
        * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
        (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
        * bindings/js/JSCustomVoidCallback.cpp:
        (WebCore::JSCustomVoidCallback::handleEvent):
        (WebCore::toVoidCallback):
        * bindings/js/JSCustomXPathNSResolver.cpp:
        (WebCore::JSCustomXPathNSResolver::create):
        (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        (WebCore::JSDOMApplicationCache::hasItem):
        (WebCore::JSDOMApplicationCache::add):
        (WebCore::JSDOMApplicationCache::remove):
        (WebCore::JSDOMApplicationCache::addEventListener):
        (WebCore::JSDOMApplicationCache::removeEventListener):
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::valueToStringWithNullCheck):
        (WebCore::valueToStringWithUndefinedOrNullCheck):
        (WebCore::reportException):
        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::JSDOMGlobalObject::findJSEventListener):
        (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
        (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener):
        (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
        * bindings/js/JSDOMStringListCustom.cpp:
        (WebCore::JSDOMStringList::item):
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::getOwnPropertySlot):
        (windowProtoFuncOpen):
        (WebCore::toJSDOMWindow):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::setLocation):
        (WebCore::JSDOMWindow::postMessage):
        (WebCore::setTimeoutOrInterval):
        (WebCore::JSDOMWindow::clearTimeout):
        (WebCore::JSDOMWindow::clearInterval):
        (WebCore::JSDOMWindow::atob):
        (WebCore::JSDOMWindow::btoa):
        (WebCore::JSDOMWindow::addEventListener):
        (WebCore::JSDOMWindow::removeEventListener):
        (WebCore::toDOMWindow):
        * bindings/js/JSDatabaseCustom.cpp:
        (WebCore::JSDatabase::changeVersion):
        (WebCore::JSDatabase::transaction):
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::setLocation):
        * bindings/js/JSElementCustom.cpp:
        (WebCore::JSElement::setAttribute):
        (WebCore::JSElement::setAttributeNS):
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSAbstractEventListener::handleEvent):
        (WebCore::JSLazyEventListener::parseCode):
        * bindings/js/JSEventTargetNodeCustom.cpp:
        (WebCore::JSEventTargetNode::addEventListener):
        (WebCore::JSEventTargetNode::removeEventListener):
        * bindings/js/JSGeolocationCustom.cpp:
        (WebCore::createPositionOptions):
        (WebCore::JSGeolocation::getCurrentPosition):
        (WebCore::JSGeolocation::watchPosition):
        * bindings/js/JSHTMLCollectionCustom.cpp:
        (WebCore::callHTMLCollection):
        (WebCore::JSHTMLCollection::canGetItemsForName):
        (WebCore::JSHTMLCollection::item):
        (WebCore::JSHTMLCollection::namedItem):
        * bindings/js/JSHTMLDocumentCustom.cpp:
        (WebCore::JSHTMLDocument::open):
        (WebCore::writeHelper):
        * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
        (WebCore::JSHTMLOptionsCollection::setLength):
        (WebCore::JSHTMLOptionsCollection::add):
        * bindings/js/JSHTMLSelectElementCustom.cpp:
        (WebCore::JSHTMLSelectElement::remove):
        (WebCore::selectIndexSetter):
        * bindings/js/JSImageConstructor.cpp:
        (WebCore::constructImage):
        * bindings/js/JSInspectedObjectWrapper.cpp:
        (WebCore::JSInspectedObjectWrapper::wrap):
        (WebCore::JSInspectedObjectWrapper::prepareIncomingValue):
        * bindings/js/JSInspectorCallbackWrapper.cpp:
        (WebCore::JSInspectorCallbackWrapper::wrap):
        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        (WebCore::JSJavaScriptCallFrame::evaluate):
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::JSLocation::setHref):
        (WebCore::JSLocation::setProtocol):
        (WebCore::JSLocation::setHost):
        (WebCore::JSLocation::setHostname):
        (WebCore::JSLocation::setPort):
        (WebCore::JSLocation::setPathname):
        (WebCore::JSLocation::setSearch):
        (WebCore::JSLocation::setHash):
        (WebCore::JSLocation::replace):
        (WebCore::JSLocation::assign):
        * bindings/js/JSMessageChannelConstructor.cpp:
        (WebCore::JSMessageChannelConstructor::mark):
        * bindings/js/JSMessagePortCustom.cpp:
        (WebCore::JSMessagePort::startConversation):
        (WebCore::JSMessagePort::addEventListener):
        (WebCore::JSMessagePort::removeEventListener):
        * bindings/js/JSNodeFilterCondition.cpp:
        (WebCore::JSNodeFilterCondition::mark):
        (WebCore::JSNodeFilterCondition::acceptNode):
        * bindings/js/JSNodeFilterCondition.h:
        * bindings/js/JSNodeFilterCustom.cpp:
        (WebCore::toNodeFilter):
        * bindings/js/JSNodeListCustom.cpp:
        (WebCore::callNodeList):
        * bindings/js/JSOptionConstructor.cpp:
        (WebCore::constructHTMLOptionElement):
        * bindings/js/JSQuarantinedObjectWrapper.cpp:
        (WebCore::JSQuarantinedObjectWrapper::asWrapper):
        (WebCore::JSQuarantinedObjectWrapper::construct):
        * bindings/js/JSSQLResultSetRowListCustom.cpp:
        (WebCore::JSSQLResultSetRowList::item):
        * bindings/js/JSSQLTransactionCustom.cpp:
        (WebCore::JSSQLTransaction::executeSql):
        * bindings/js/JSSVGElementInstanceCustom.cpp:
        (WebCore::JSSVGElementInstance::addEventListener):
        (WebCore::JSSVGElementInstance::removeEventListener):
        * bindings/js/JSSVGLengthCustom.cpp:
        (WebCore::JSSVGLength::convertToSpecifiedUnits):
        * bindings/js/JSSVGMatrixCustom.cpp:
        (WebCore::JSSVGMatrix::translate):
        (WebCore::JSSVGMatrix::scale):
        (WebCore::JSSVGMatrix::scaleNonUniform):
        (WebCore::JSSVGMatrix::rotate):
        (WebCore::JSSVGMatrix::rotateFromVector):
        (WebCore::JSSVGMatrix::skewX):
        (WebCore::JSSVGMatrix::skewY):
        * bindings/js/JSSVGPathSegListCustom.cpp:
        (WebCore::JSSVGPathSegList::getItem):
        (WebCore::JSSVGPathSegList::insertItemBefore):
        (WebCore::JSSVGPathSegList::replaceItem):
        (WebCore::JSSVGPathSegList::removeItem):
        * bindings/js/JSSVGPointListCustom.cpp:
        (WebCore::JSSVGPointList::getItem):
        (WebCore::JSSVGPointList::insertItemBefore):
        (WebCore::JSSVGPointList::replaceItem):
        (WebCore::JSSVGPointList::removeItem):
        * bindings/js/JSSVGTransformListCustom.cpp:
        (WebCore::JSSVGTransformList::getItem):
        (WebCore::JSSVGTransformList::insertItemBefore):
        (WebCore::JSSVGTransformList::replaceItem):
        (WebCore::JSSVGTransformList::removeItem):
        * bindings/js/JSStorageCustom.cpp:
        (WebCore::JSStorage::deleteProperty):
        (WebCore::JSStorage::customPut):
        * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
        (WebCore::constructWebKitCSSMatrix):
        * bindings/js/JSWorkerConstructor.cpp:
        (WebCore::constructWorker):
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::addEventListener):
        (WebCore::JSWorkerContext::removeEventListener):
        * bindings/js/JSWorkerCustom.cpp:
        (WebCore::JSWorker::addEventListener):
        (WebCore::JSWorker::removeEventListener):
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::open):
        (WebCore::JSXMLHttpRequest::setRequestHeader):
        (WebCore::JSXMLHttpRequest::send):
        (WebCore::JSXMLHttpRequest::getResponseHeader):
        (WebCore::JSXMLHttpRequest::overrideMimeType):
        (WebCore::JSXMLHttpRequest::addEventListener):
        (WebCore::JSXMLHttpRequest::removeEventListener):
        * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
        (WebCore::JSXMLHttpRequestUpload::addEventListener):
        (WebCore::JSXMLHttpRequestUpload::removeEventListener):
        * bindings/js/JSXSLTProcessorCustom.cpp:
        (WebCore::JSXSLTProcessor::importStylesheet):
        (WebCore::JSXSLTProcessor::transformToFragment):
        (WebCore::JSXSLTProcessor::transformToDocument):
        (WebCore::JSXSLTProcessor::setParameter):
        (WebCore::JSXSLTProcessor::getParameter):
        (WebCore::JSXSLTProcessor::removeParameter):
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::executeFunctionInContext):
        * bindings/js/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::initialize):
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::createScriptObjectForPluginElement):
        * bindings/js/ScriptValue.cpp:
        (WebCore::ScriptValue::getString):
        (WebCore::ScriptValue::isNull):
        (WebCore::ScriptValue::isUndefined):
        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject callWebScriptMethod:withArguments:]):
        (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/NP_jsobject.cpp:
        (_NPN_InvokeDefault):
        (_NPN_Invoke):
        (_NPN_HasMethod):
        (_NPN_Construct):
        * bridge/c/c_utility.cpp:
        (JSC::Bindings::convertValueToNPVariant):
        * bridge/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        * bridge/jni/jni_jsobject.mm:
        (JavaJSObject::call):
        (JavaJSObject::convertValueToJObject):
        * bridge/jni/jni_runtime.cpp:
        (JavaField::dispatchValueFromInstance):
        (JavaField::valueFromInstance):
        (JavaField::dispatchSetValueToInstance):
        (JavaField::setValueToInstance):
        * bridge/jni/jni_utility.cpp:
        (JSC::Bindings::convertArrayInstanceToJavaArray):
        (JSC::Bindings::convertValueToJValue):
        * bridge/objc/objc_runtime.mm:
        (JSC::Bindings::callObjCFallbackObject):
        * bridge/objc/objc_utility.mm:
        (JSC::Bindings::convertValueToObjcValue):
        * bridge/runtime_method.cpp:
        (JSC::callRuntimeMethod):
        * bridge/runtime_object.cpp:
        (JSC::RuntimeObjectImp::getOwnPropertySlot):
        (JSC::callRuntimeConstructor):

WebKit/mac:

2009-01-19  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Gavin Barraclough.

        Remove temporary operator-> from JSValuePtr.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::invoke):
        (WebKit::NetscapePluginInstanceProxy::hasMethod):
        (WebKit::NetscapePluginInstanceProxy::marshalValue):
        * WebView/WebFrame.mm:
        (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
        * WebView/WebView.mm:
        (aeDescFromJSValue):

WebKit/win:

2009-01-19  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Gavin Barraclough.

        Remove temporary operator-> from JSValuePtr.

        * WebScriptCallFrame.cpp:
        (WebScriptCallFrame::jsValueToString):
        * WebView.cpp:
        (WebView::stringByEvaluatingJavaScriptFromString):

WebKit/wx:

2009-01-19  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Gavin Barraclough.

        Remove temporary operator-> from JSValuePtr.

        * WebFrame.cpp:
        (wxWebFrame::RunScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 20 Jan 2009 00:33:38 +0000 (00:33 +0000)]
2009-01-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Make Evaluate an asynchronous method that has a reply method.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCEvaluate):
        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Gustavo Noronha Silva <gns@gnome.org>
christian@webkit.org [Tue, 20 Jan 2009 00:27:18 +0000 (00:27 +0000)]
2009-01-20  Gustavo Noronha Silva  <gns@gnome.org>

         Reviewed by Mark Rowe.

         https://bugs.webkit.org/show_bug.cgi?id=23419
         removal of FramePrivate.h breaks GTK+'s make dist

         * GNUmakefile.am: No longer mention FramePrivate.h in our build,
         since it was removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Alexander V. Butenko <alex@digiqube.com>
christian@webkit.org [Tue, 20 Jan 2009 00:16:08 +0000 (00:16 +0000)]
2009-01-20  Alexander V. Butenko  <alex@digiqube.com>

        Reviewed by Holger Freyther.

        http://bugs.webkit.org/show_bug.cgi?id=23116
        [GTK] Fix crash due a callback called from GIO after the
        destruction of the ResourceHandle

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::cancel): Only call didFinishLoading if
        'client' is set, otherwise cancelling a load could lead to a crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
darin@apple.com [Mon, 19 Jan 2009 23:33:54 +0000 (23:33 +0000)]
JavaScriptCore:

2009-01-19  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 23409: REGRESSION: RegExp 'replace()' function improperly processes '$$'
        <https://bugs.webkit.org/show_bug.cgi?id=23409>
        <rdar://problem/6505723>

        Test: fast/js/string-replace-3.html

        * runtime/StringPrototype.cpp:
        (JSC::substituteBackreferences): Remove code that adds an extra $ -- not sure
        how this ever worked.

LayoutTests:

2009-01-19  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 23409: REGRESSION: RegExp 'replace()' function improperly processes '$$'
        <https://bugs.webkit.org/show_bug.cgi?id=23409>
        <rdar://problem/6505723>

        * fast/js/resources/string-replace-3.js:
        * fast/js/string-replace-3-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChangeLog typo fix.
simon.fraser@apple.com [Mon, 19 Jan 2009 23:22:10 +0000 (23:22 +0000)]
ChangeLog typo fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 19 Jan 2009 23:20:57 +0000 (23:20 +0000)]
2009-01-19  Simon Fraser  <simon.fraser@apple.com>

        Build fix: remove duplicate entries in the Xcode project, and
        sort the project with ort-Xcode-project-file .

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 19 Jan 2009 22:23:34 +0000 (22:23 +0000)]
2009-01-19  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=18078

        Support animations and transitions of shorthand properties by creating
        PropertyWrappers that simply wrap a vector of atomci wrappers, and implement
        equal() and blend(). Build that collection of shorthand wrappers using the
        shorthand map that CSSMutableStyleDeclaration already has. Skip comparing these
        shorthand wrappers during 'all' transitions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoActually add the new header.
oliver@apple.com [Mon, 19 Jan 2009 22:16:43 +0000 (22:16 +0000)]
Actually add the new header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 David Levin <levin@chromium.org>
oliver@apple.com [Mon, 19 Jan 2009 22:09:21 +0000 (22:09 +0000)]
2009-01-19  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=22720

        Provide a generic class to handle the pattern of task callbacks across worker/parent threads.  It
        only works for methods that need 6 parameters but similar classes could be added as needed for
        other numbers of parameters.

        Add addMessage and resourceRetrievedByXMLHttpRequest to ScriptExecutionContext.

        Use these methods and others to remove document() from XMLHttpRequest in a few more places.

        No observable change in behavior, so no test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 19 Jan 2009 21:43:26 +0000 (21:43 +0000)]
2009-01-19  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Tim Hatcher

        Fix long standing typo.

        * History/WebBackForwardList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Add links to some recommended Visual Studio hotfixes
aroben@apple.com [Mon, 19 Jan 2009 20:55:40 +0000 (20:55 +0000)]
    Add links to some recommended Visual Studio hotfixes

        Reviewed by Dave Hyatt.

        * building/tools.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Update test results for https://bugs.webkit.org/show_bug.cgi?id=23417.
ap@webkit.org [Mon, 19 Jan 2009 20:51:58 +0000 (20:51 +0000)]
    Update test results for https://bugs.webkit.org/show_bug.cgi?id=23417.

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 23422: AX: AXLinks should expose access key information
cfleizach@apple.com [Mon, 19 Jan 2009 20:31:59 +0000 (20:31 +0000)]
Bug 23422: AX: AXLinks should expose access key information
https://bugs.webkit.org/show_bug.cgi?id=23422

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Anders Carlsson.
ap@webkit.org [Mon, 19 Jan 2009 19:15:10 +0000 (19:15 +0000)]
    Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=23417
        Implement application cache obsolete state

        Test: http/tests/appcache/remove-cache.html

        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        (WebCore::JSDOMApplicationCache::mark):
        * dom/EventNames.h:
        * loader/appcache/DOMApplicationCache.h:
        (WebCore::DOMApplicationCache::Status):
        (WebCore::DOMApplicationCache::setOnobsolete):
        (WebCore::DOMApplicationCache::onobsolete):
        * loader/appcache/DOMApplicationCache.idl:
        Added "obsolete" event and status.

        * loader/appcache/ApplicationCacheGroup.h:
        (WebCore::ApplicationCacheGroup::savedNewestCachePointer): Removed, there is no longer
        any need to track what the newest cache was during teardown.
        (WebCore::ApplicationCacheGroup::updateStatus): Renamed Status to UpdateStatus, reducing
        confusion with cache group lifecycle status.
        (WebCore::ApplicationCacheGroup::m_isObsolete): Added an obsolete state flag.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): Initialize m_isObsolete.
        (WebCore::ApplicationCacheGroup::cacheForMainRequest): Assert that the returned cache does
        not belong to an obsolete group.
        (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest): Ditto.
        (WebCore::ApplicationCacheGroup::disassociateDocumentLoader): Disassociation can now happen
        via a JS swapCache() call, not only when the loader is destroyed.
        (WebCore::ApplicationCacheGroup::cacheDestroyed): Don't track m_savedNewestCachePointer.
        (WebCore::ApplicationCacheGroup::setNewestCache): Remove old newest cache from storage is
        a caller responsibility, because this method is also used when loading caches from disk.
        (WebCore::ApplicationCacheGroup::makeObsolete): Added. Mark the cache group as obsolete, and
        inform cache storage, so that it could be removed.
        (WebCore::ApplicationCacheGroup::didFailToLoadManifest): Removed, as all this method did
        was call cacheUpdateFailed().
        (WebCore::ApplicationCacheGroup::didReceiveResponse): Added a FIXME about correct failure
        handing.
        (WebCore::ApplicationCacheGroup::didFail): Ditto.
        (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Call a new manifestNotFound()
        method for 404 and 410 responses.
        (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): Call cacheUpdateFailed()
        directly, instead of the removed didFailToLoadManifest().
        (WebCore::ApplicationCacheGroup::manifestNotFound): Implement "remove a cache" algorithm.
        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Remove superceded cache from storage
        after update successfully finishes (moved from setNewestCache()).
        (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): Revive the group using
        an explicitly passed pointer, without the need to save it during teardown.

        * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::~DocumentLoader):
        Call the general ApplicationCacheGroup::disassociateDocumentLoader() method.

        * loader/appcache/ApplicationCacheStorage.h: Added a cacheGroupMadeObsolete() method, updated
        some comments.

        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::cacheGroupForURL): Assert that iterated caches are not
        obsolete.
        (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Ditto.
        (WebCore::ApplicationCacheStorage::cacheGroupDestroyed): Don't do anything for obsolete
        groups, as they cannot be in storage.
        (WebCore::ApplicationCacheStorage::cacheGroupMadeObsolete): Remove the cache group from storage
        completely, so that a new one could replace it, if necessary.
        (WebCore::ApplicationCacheStorage::storeNewestCache): Added assertions.
        (WebCore::ApplicationCacheStorage::remove): Remove cache group if its newest cache is removed.

        * loader/appcache/DOMApplicationCache.cpp:
        (WebCore::DOMApplicationCache::status): Added support for OBSOLETE state.
        (WebCore::DOMApplicationCache::swapCache): Disassociate document loader from cache if the
        application was removed server-side.
        (WebCore::DOMApplicationCache::callObsoleteListener): Added support for obsolete event.

        * loader/appcache/DOMApplicationCache.h:
        (WebCore::DOMApplicationCache::Status):
        (WebCore::DOMApplicationCache::setOnobsolete):
        (WebCore::DOMApplicationCache::onobsolete):
        Added support for OBSOLETE state and obsolete event.

        * loader/appcache/DOMApplicationCache.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 19 Jan 2009 19:05:20 +0000 (19:05 +0000)]
2009-01-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Allow plug-in views to return an instance directly.

        * bindings/js/ScriptControllerMac.mm:
        (WebCore::ScriptController::createScriptInstanceForWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 23399: AX: some buttons don't expose AXPress as an action
cfleizach@apple.com [Mon, 19 Jan 2009 18:18:37 +0000 (18:18 +0000)]
Bug 23399: AX: some buttons don't expose AXPress as an action
https://bugs.webkit.org/show_bug.cgi?id=23399

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix
aroben@apple.com [Mon, 19 Jan 2009 16:28:19 +0000 (16:28 +0000)]
Windows build fix

WebCore:

        Windows build fix

        * WebCore.vcproj/WebCore.vcproj: Copy headers from page/animation into
        $WebKitOutputDir so that WebKit can access them.

        * html/HTMLBaseFontElement.cpp: Touched this file to cause a rebuild
        and header copy.

WebKit/win:

        Windows build fix

        * DOMCoreClasses.cpp: Replaced "using namespace WebCore" with
        individual using directives for each type we need from that namespace,
        to avoid conflicts between DOMObject and WebCore::DOMObject.
        (DOMElement::font): Added a now-needed WebCore::.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Mon, 19 Jan 2009 15:40:24 +0000 (15:40 +0000)]
2009-01-19  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon Hausmann.

        http://www.qtsoftware.com/developer/task-tracker/index_html?id=211228&method=entry

        [Qt] Show focus rect when a button gets the focus for the first time.
        This is important at least for Windows style.

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::applyTheme):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Mon, 19 Jan 2009 13:39:03 +0000 (13:39 +0000)]
2009-01-19  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Fix calling of onkeypress event handlers on input elements when pressing enter
        and other text insertion commands in the Qt port.

        Similar to the win and mac ports don't execute text inserting editor
        commands on RawKeyDown but continue processing the event first in
        WebCore, i.e. also get a keypress event sent. If unhandled it will
        come back to EditorClientQt::handleKeyboardEvent later and we execute
        it then.

        This also fixes search by pressing enter on www.trafikanten.no.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-19 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Mon, 19 Jan 2009 13:00:08 +0000 (13:00 +0000)]
2009-01-19  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        [Qt] Build fix after r39971.

        * platform/qt/LoggingQt.cpp:
        (WebCore::InitializeLoggingChannelsIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the build!
mrowe@apple.com [Mon, 19 Jan 2009 08:45:05 +0000 (08:45 +0000)]
Fix the build!

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::demarshalValue):
(WebKit::NetscapePluginInstanceProxy::demarshalValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-18 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 19 Jan 2009 07:15:12 +0000 (07:15 +0000)]
2009-01-18  Sam Weinig  <sam@webkit.org>

        Reviewed by Cameron Zwarich.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23415
        Remove FramePrivate

        Minor PLT speedup.

        * WebCore.base.exp:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * loader/FrameLoader.cpp:
        * page/Frame.cpp:
        (WebCore::Frame::Frame):
        (WebCore::Frame::~Frame):
        (WebCore::Frame::init):
        (WebCore::Frame::loader):
        (WebCore::Frame::view):
        (WebCore::Frame::setView):
        (WebCore::Frame::script):
        (WebCore::Frame::document):
        (WebCore::Frame::setDocument):
        (WebCore::Frame::settings):
        (WebCore::Frame::selection):
        (WebCore::Frame::editor):
        (WebCore::Frame::selectionGranularity):
        (WebCore::Frame::setSelectionGranularity):
        (WebCore::Frame::dragCaretController):
        (WebCore::Frame::animation):
        (WebCore::Frame::mark):
        (WebCore::Frame::setMark):
        (WebCore::Frame::setCaretVisible):
        (WebCore::Frame::clearCaretRectIfNeeded):
        (WebCore::Frame::selectionLayoutChanged):
        (WebCore::Frame::caretBlinkTimerFired):
        (WebCore::Frame::paintCaret):
        (WebCore::Frame::paintDragCaret):
        (WebCore::Frame::zoomFactor):
        (WebCore::Frame::isZoomFactorTextOnly):
        (WebCore::Frame::shouldApplyTextZoom):
        (WebCore::Frame::shouldApplyPageZoom):
        (WebCore::Frame::setZoomFactor):
        (WebCore::Frame::setPrinting):
        (WebCore::Frame::setJSStatusBarText):
        (WebCore::Frame::setJSDefaultStatusBarText):
        (WebCore::Frame::jsStatusBarText):
        (WebCore::Frame::jsDefaultStatusBarText):
        (WebCore::Frame::setNeedsReapplyStyles):
        (WebCore::Frame::needsReapplyStyles):
        (WebCore::Frame::reapplyStyles):
        (WebCore::Frame::isContentEditable):
        (WebCore::Frame::updateSecureKeyboardEntryIfActive):
        (WebCore::Frame::typingStyle):
        (WebCore::Frame::setTypingStyle):
        (WebCore::Frame::clearTypingStyle):
        (WebCore::Frame::computeAndSetTypingStyle):
        (WebCore::Frame::selectionComputedStyle):
        (WebCore::Frame::applyEditingStyleToBodyElement):
        (WebCore::Frame::removeEditingStyleFromBodyElement):
        (WebCore::Frame::keepAlive):
        (WebCore::Frame::cancelAllKeepAlive):
        (WebCore::Frame::clearDOMWindow):
        (WebCore::Frame::ownerElement):
        (WebCore::Frame::ownerRenderer):
        (WebCore::Frame::isDisconnected):
        (WebCore::Frame::setIsDisconnected):
        (WebCore::Frame::excludeFromTextSearch):
        (WebCore::Frame::setExcludeFromTextSearch):
        (WebCore::Frame::selectionBounds):
        (WebCore::Frame::selectionTextRects):
        (WebCore::Frame::isFrameSet):
        (WebCore::Frame::currentForm):
        (WebCore::Frame::forceLayout):
        (WebCore::Frame::sendScrollEvent):
        (WebCore::Frame::clearTimers):
        (WebCore::Frame::styleForSelectionStart):
        (WebCore::Frame::inViewSourceMode):
        (WebCore::Frame::setInViewSourceMode):
        (WebCore::Frame::markAllMatchesForText):
        (WebCore::Frame::markedTextMatchesAreHighlighted):
        (WebCore::Frame::setMarkedTextMatchesAreHighlighted):
        (WebCore::Frame::tree):
        (WebCore::Frame::setDOMWindow):
        (WebCore::Frame::domWindow):
        (WebCore::Frame::clearFormerDOMWindow):
        (WebCore::Frame::page):
        (WebCore::Frame::eventHandler):
        (WebCore::Frame::pageDestroyed):
        (WebCore::Frame::disconnectOwnerElement):
        (WebCore::Frame::documentAtPoint):
        * page/Frame.h:
        * page/FramePrivate.h: Removed.
        * page/FrameTree.h:
        * page/chromium/FrameChromium.cpp:
        * page/mac/FrameMac.mm:
        (WebCore::Frame::imageFromRect):
        (WebCore::Frame::selectionImage):
        (WebCore::Frame::snapshotDragImage):
        (WebCore::Frame::nodeImage):
        (WebCore::Frame::setUserStyleSheetLocation):
        (WebCore::Frame::setUserStyleSheet):
        * page/qt/FrameQt.cpp:
        (WebCore::Frame::setUserStyleSheetLocation):
        (WebCore::Frame::setUserStyleSheet):
        * page/win/FrameCGWin.cpp:
        (WebCore::Frame::nodeImage):
        * page/win/FrameWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix <https://bugs.webkit.org/show_bug.cgi?id=23414>.
mrowe@apple.com [Mon, 19 Jan 2009 02:31:36 +0000 (02:31 +0000)]
Fix <https://bugs.webkit.org/show_bug.cgi?id=23414>.
Bug 23414: Reproducible crash accessing View menu with plugins disabled

Reviewed by Anders Carlsson.

* WebView/WebFrame.mm:
(-[WebFrame _canProvideDocumentSource]): Null-check the PluginData before using it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40023 268f45cc-cd09-0410-ab3c-d52691b4dbfc