WebKit-https.git
12 years ago Reviewed by Alp Toker.
christian@webkit.org [Thu, 24 Apr 2008 08:15:37 +0000 (08:15 +0000)]
Reviewed by Alp Toker.

        Emit a warning about an unknown setting only if it is
        not a valid property. Otherwise applications can't
        subclass WebKitWebSettings to add new properties.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 07:55:22 +0000 (07:55 +0000)]
Tor Arne Vestbø  <tavestbo@trolltech.com>

Cleaned up copyright headers in the Qt port (removed misplaced class
descriptions and fixed inconsistent whitespace and indentation).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 07:44:52 +0000 (07:44 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Added basic URL guessing to QtLauncher (same as in the demo browser).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 07:44:39 +0000 (07:44 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Disable vanlilla focus rings since Qt provides this as part of the style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoGeorge Staikos <george@staikos.net>
hausmann@webkit.org [Thu, 24 Apr 2008 07:38:30 +0000 (07:38 +0000)]
George Staikos <george@staikos.net>

This optimization in BitmapImage::drawPattern for the identity
transform is bogus and causes incorrect results on sites like youtube.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 07:31:31 +0000 (07:31 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Prevent double deletions of the default web interface.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Dave Hyatt.
mitz@apple.com [Thu, 24 Apr 2008 04:29:49 +0000 (04:29 +0000)]
    Rubber-stamped by Dave Hyatt.

        - update computed style results for border-image and mask-image

        * fast/css/computed-style-expected.txt:
        * fast/css/computed-style-without-renderer-expected.txt:
        * svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Alp Toker.
kevino@webkit.org [Thu, 24 Apr 2008 03:55:16 +0000 (03:55 +0000)]
Reviewed by Alp Toker.

Typo fix to restore text entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-23 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 24 Apr 2008 03:39:23 +0000 (03:39 +0000)]
2008-04-23  Brady Eidson  <beidson@apple.com>

        Reviewed by Jon Honeycutt

        Preparing for making LocalStorageAreas persistent.

        Since LocalStorageAreas will need to do a lot of additional work for each of the basic
        operations a Storage object supports, this patch makes the API entry points virtual so
        LocalStorageArea can override them.  The behavior for both Local and Session StorageAreas
        is unchanged with this patch, but LocalStorageArea will override them in the future.

        * storage/StorageArea.cpp: Rename the implementations to internalFoo
        (WebCore::StorageArea::internalLength):
        (WebCore::StorageArea::internalKey):
        (WebCore::StorageArea::internalGetItem):
        (WebCore::StorageArea::internalSetItem):
        (WebCore::StorageArea::internalRemoveItem):
        (WebCore::StorageArea::internalContains):

        * storage/StorageArea.h: Call internalFoo variants
        (WebCore::StorageArea::length):
        (WebCore::StorageArea::key):
        (WebCore::StorageArea::getItem):
        (WebCore::StorageArea::setItem):
        (WebCore::StorageArea::removeItem):
        (WebCore::StorageArea::contains):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Thu, 24 Apr 2008 03:12:04 +0000 (03:12 +0000)]
WebCore:

2008-04-23  David Hyatt  <hyatt@apple.com>

        Implement getComputedStyle for border-image.

        Reviewed by Dan Bernstein

        Added fast/css/getComputedStyle-border-image.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::valueForRepeatRule):
        (WebCore::valueForNinePieceImage):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

2008-04-23  David Hyatt  <hyatt@apple.com>

        Implement getComputedStyle for -webkit-border-image.

        Reviewed by Dan Bernstein

        * fast/css/getComputedStyle-border-image-expected.txt: Added.
        * fast/css/getComputedStyle-border-image.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 23 Apr 2008 21:41:42 +0000 (21:41 +0000)]
2008-04-22  Darin Adler  <darin@apple.com>

        Reviewed by Anders.

        - simplify use of HashTraits to prepare for some upcoming hash table changes

        * page/AXObjectCache.h: Removed uneeded AXIDHashTraits, which are no different
        from the default hash traits for unsigned.
        * page/mac/AXObjectCacheMac.mm:
        (WebCore::AXObjectCache::removeAXID): Remove assertion that's already done
        by HashTable that the value is not the deleted value.

        * platform/graphics/StringTruncator.cpp: Removed unneeded include.
        * svg/SVGFontFaceElement.cpp: Removed unneeded include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 23 Apr 2008 21:41:10 +0000 (21:41 +0000)]
2008-04-22  Darin Adler  <darin@apple.com>

        Reviewed by Anders.

        - simplify use of HashTraits to prepare for some upcoming hash table changes

        * kjs/SymbolTable.h: Made SymbolTableIndexHashTraits derive from HashTraits<size_t>
        and specialize only the empty value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fixes. Changing BackgroundLayer -> FillLayer and adding Frame::disconnectPla...
kevino@webkit.org [Wed, 23 Apr 2008 21:19:01 +0000 (21:19 +0000)]
wx build fixes. Changing BackgroundLayer -> FillLayer and adding Frame::disconnectPlatformScriptObjects()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Wed, 23 Apr 2008 20:31:13 +0000 (20:31 +0000)]
WebCore:

2008-04-23  David Hyatt  <hyatt@apple.com>

        Add support for mask-box-image (similar to border-image).  This property enables a single image
        to overlay the entire mask area (with nine-piece slicing rules similar to border image).

        Reviewed by Dan Bernstein

        Added inline-mask-overlay.html, block-mask-overlay.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseBorderImage):
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintMask):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintMask):
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::paintLines):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::paintNinePieceImage):
        (WebCore::RenderObject::paintBorder):
        * rendering/RenderObject.h:
        * rendering/RenderStyle.cpp:
        (WebCore::NinePieceImage::operator==):
        * rendering/RenderStyle.h:
        (WebCore::):
        (WebCore::NinePieceImage::m_verticalRule):
        (WebCore::NinePieceImage::horizontalRule):
        (WebCore::NinePieceImage::verticalRule):
        (WebCore::RenderStyle::borderImage):
        (WebCore::RenderStyle::maskOverlayImage):
        (WebCore::RenderStyle::hasMask):
        (WebCore::RenderStyle::resetBorderImage):
        (WebCore::RenderStyle::setBorderImage):
        (WebCore::RenderStyle::setMaskOverlayImage):
        (WebCore::RenderStyle::initialNinePieceImage):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paintMask):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paintMask):

LayoutTests:

2008-04-23  David Hyatt  <hyatt@apple.com>

        Add support for a new mask-box-image property that is analogous to border-image.

        Reviewed by Dan Bernstein

        * fast/borders/block-mask-overlay-image.html: Added.
        * fast/borders/inline-mask-overlay-image.html: Added.
        * fast/borders/resources/mask.png: Added.
        * platform/mac/fast/borders/block-mask-overlay-image-expected.checksum: Added.
        * platform/mac/fast/borders/block-mask-overlay-image-expected.png: Added.
        * platform/mac/fast/borders/block-mask-overlay-image-expected.txt: Added.
        * platform/mac/fast/borders/inline-mask-overlay-image-expected.checksum: Added.
        * platform/mac/fast/borders/inline-mask-overlay-image-expected.png: Added.
        * platform/mac/fast/borders/inline-mask-overlay-image-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Wed, 23 Apr 2008 18:25:10 +0000 (18:25 +0000)]
WebCore:

2008-04-23  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/5825350> OWA: Caret disappears when navigating with arrows keys in contenteditable div

        * editing/htmlediting.cpp:
        (WebCore::firstEditablePositionAfterPositionInRoot): Return a null VisiblePosition if
        this function moves out of highestRoot.  Re-wrote so as to not duplicate code inside
        and outside of the while loop.
        (WebCore::lastEditablePositionBeforePositionInRoot): Ditto.

LayoutTests:

2008-04-23  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/5825350> OWA: Caret disappears when navigating with arrows keys in contenteditable div

        * editing/selection/5825350-1-expected.txt: Added.
        * editing/selection/5825350-1.html: Added.
        * editing/selection/5825350-2-expected.txt: Added.
        * editing/selection/5825350-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
pewtermoose@webkit.org [Wed, 23 Apr 2008 17:49:52 +0000 (17:49 +0000)]
WebCore:

2008-04-23  Daniel Zucker  <zucker@wake3.com>

        Reviewed by Adam Roben.

        Fix build errors needed to compile Curl in Cairo build.  Add stubs for
        didReceiveAuthenticationChallenge, receivedCredential,
        receivedRequestToContinueWithoutCredential, and receivedCancellation.
        <https://bugs.webkit.org/show_bug.cgi?id=18468>

        * platform/network/ResourceHandle.h:
        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
        (WebCore::ResourceHandle::receivedCredential):
        (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
        (WebCore::ResourceHandle::receivedCancellation):

WebKit/win:

2008-04-23  Daniel Zucker  <zucker@wake3.com>

        Reviewed by Adam Roben.

        <https://bugs.webkit.org/show_bug.cgi?id=18468>

        * WebError.h:  include RetainPtr.h to fix build errors in Cairo build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-23 Daniel Zucker <zucker@wake3.com>
pewtermoose@webkit.org [Wed, 23 Apr 2008 17:43:40 +0000 (17:43 +0000)]
2008-04-23  Daniel Zucker  <zucker@wake3.com>

        Reviewed by Adam Roben.

        Move the location of #if USE(CFNETWORK) to fix a cairo/curl build error.
        <https://bugs.webkit.org/show_bug.cgi?id=18470>

        * WebError.cpp:
        (WebError::sslPeerCertificate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make crashes be reported as crashes, not hangs
aroben@apple.com [Wed, 23 Apr 2008 17:35:56 +0000 (17:35 +0000)]
    Make crashes be reported as crashes, not hangs

        Reviewed by David Kilzer.

        * Scripts/run-webkit-tests:
        (top level): Use the new status field of the output from
        readFromDumpToolWithTimer to determine if the test crashed or hung.
        (sub readFromDumpToolWithTimer):
          - If we fail to read a line and $! is not EAGAIN, then we've crashed
            and should not try to read any more.
          - Changed the timedout field to a more general status field.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-23 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 23 Apr 2008 16:08:22 +0000 (16:08 +0000)]
2008-04-23  Darin Adler  <darin@apple.com>

        - updated a test affected by the addition of mask-composite

        * svg/css/getComputedStyle-basic-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Wed, 23 Apr 2008 14:50:22 +0000 (14:50 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix a bug where moving forward in bidirectional text skips over the
          position after the end of the line

        Test: editing/selection/move-past-trailing-space.html

        * dom/Position.cpp:
        (WebCore::Position::upstream): Changed the logic for identifying when a
        position is after the last character of a text box of a text node that
        continues on the next line, to make it work correctly when boxes are not
        laid out in logical order.
        (WebCore::Position::downstream): Ditto.

LayoutTests:

        Reviewed by Darin Adler.

        - test that moving forward through bidirectional text does not skip the
          position after the last character on the line

        * editing/selection/move-past-trailing-space.html: Added.
        * platform/mac/editing/selection/move-past-trailing-space-expected.checksum: Added.
        * platform/mac/editing/selection/move-past-trailing-space-expected.png: Added.
        * platform/mac/editing/selection/move-past-trailing-space-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix compilation against Qt 4.3
hausmann@webkit.org [Wed, 23 Apr 2008 14:45:02 +0000 (14:45 +0000)]
Fix compilation against Qt 4.3

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Wed, 23 Apr 2008 14:36:37 +0000 (14:36 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

* Make sure the "Inspect Element" item gets added to the ContextMenu, a call
  to ContextMenu::populate() is not adding it, the ContextMenuController does
  add it after the call to populate(). Do that as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBrad Hughes <bhughes@trolltech.com>
hausmann@webkit.org [Wed, 23 Apr 2008 14:36:24 +0000 (14:36 +0000)]
Brad Hughes <bhughes@trolltech.com>

Fix release build with the intel compiler

Intel compiler can't compile qtwebkit with -O2 or -O1, so we're left with -O0

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSimon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Wed, 23 Apr 2008 14:36:10 +0000 (14:36 +0000)]
Simon Hausmann <hausmann@webkit.org>

Fix crashes on window.close().

We should not delete the QWebPage object in the ChromeClient but leave it up to
the application when and whether to delete a browser window. For this we now
emit the windowCloseRequested() signal.

Done with Tor Arne.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix parsing of external scripts/stylesheets when using setHtml(const QString &html).
hausmann@webkit.org [Wed, 23 Apr 2008 14:21:50 +0000 (14:21 +0000)]
Fix parsing of external scripts/stylesheets when using setHtml(const QString &html).

We used to pass the html string to the frameloader in utf-16, which also meant that the default
encoding of external scripts/stylesheets became utf-16. That doesn't make sense, so assume utf-8
by default. This is now also documented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Wed, 23 Apr 2008 13:58:56 +0000 (13:58 +0000)]
Holger Hans Peter Freyther  <zecke@selfish.org>

Removed the #define for USE_SYSTEM_MALLOC that we set in WebKit.pri
already.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Wed, 23 Apr 2008 08:31:02 +0000 (08:31 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Fixes background color propagation when using a custom QWebPage

Set the palette in setPage(), not during the creation on-demand.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Wed, 23 Apr 2008 08:26:35 +0000 (08:26 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Fix the user agent on the mac to be BSD4

Put Q_OS_DARWIN before Q_OS_BSD4 sense they are both defined on the mac

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdded missing copyright notice.
hausmann@webkit.org [Wed, 23 Apr 2008 08:07:38 +0000 (08:07 +0000)]
Added missing copyright notice.
Small fixes to the documentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoZack Rusin <zack@tungstengraphics.com>
hausmann@webkit.org [Wed, 23 Apr 2008 07:49:08 +0000 (07:49 +0000)]
Zack Rusin <zack@tungstengraphics.com>

Added a contentsSize() property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Wed, 23 Apr 2008 04:22:56 +0000 (04:22 +0000)]
    Reviewed by Anders Carlsson.

        - remove unused calls to Position::upstream()

        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::insertNodeAfterPosition):
        (WebCore::InsertLineBreakCommand::insertNodeBeforePosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Wed, 23 Apr 2008 04:19:05 +0000 (04:19 +0000)]
2008-04-22  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Sam.

        Implement get_accKeyboardShortcut().

        * AccessibleBase.cpp:
        (AccessibleBase::get_accKeyboardShortcut): Report the key combination
        that will perform the object's access key action, represented as a
        string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Wed, 23 Apr 2008 04:18:33 +0000 (04:18 +0000)]
2008-04-22  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Sam.

        Add a method to query which modifier keys the platform uses for access
        key actions.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleAccessKey): Bitwise and the event's
        modifier keys with the platform's access key modifier mask to determine
        whether this event can perform an access key action.
        * page/EventHandler.h: Added s_accessKeyModifiers, a platform-defined
        mask of modifier keys used for access key actions, and a getter.
        * page/mac/EventHandlerMac.mm: Use PlatformKeyboardEvent::CtrlKey for
        access key actions.
        * page/qt/EventHandlerQt.cpp: Same.
        * page/gtk/EventHandlerGtk.cpp: Use AltKey.
        * page/win/EventHandlerWin.cpp: Same.
        * page/wx/EventHandlerWx.cpp: Same.
        * platform/PlatformKeyboardEvent.h: Added an enum, ModifierKey.
        (WebCore::PlatformKeyboardEvent::):
        (WebCore::PlatformKeyboardEvent::modifiers): Return which modifier keys
        were active, a combination of ModifierKey values.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 23 Apr 2008 03:52:21 +0000 (03:52 +0000)]
2008-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Maciej Stachowiak.

        Make the KJSProxy and FrameLoader member variables instead of pointers
        in FramePrivate in a bid to do a little clean up before the last of the
        split window patches.  Also, make the KJSProxy not lazily created, as the
        real benefit comes from lazily creating the JSDOMWindowWrapper, which we
        still do.

        * page/Frame.cpp:
        (WebCore::Frame::~Frame):
        (WebCore::Frame::init):
        (WebCore::Frame::loader):
        (WebCore::Frame::scriptProxy):
        (WebCore::Frame::document):
        (WebCore::Frame::setDocument):
        (WebCore::Frame::clearScriptProxy):
        (WebCore::Frame::pageDestroyed):
        (WebCore::FramePrivate::FramePrivate):
        (WebCore::FramePrivate::~FramePrivate):
        * page/FramePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Wed, 23 Apr 2008 03:42:31 +0000 (03:42 +0000)]
WebCore:

2008-04-22  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by Dan Bernstein.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18584
        border-color, outline-color, column-color, -webkit-text-stroke-color,
        and -webkit-text-fill-color inheritance to correctly use parent's color
        if the parent's corresponding (border, outline, etc.)-color property
        wasn't set.

        Test: fast/borders/border-color-inherit.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

2008-04-22  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=18584
        Add a test case for border-color inheritance.

        * fast/borders/border-color-inherit.html: Added.
        * platform/mac/fast/borders/border-color-inherit-expected.checksum: Added.
        * platform/mac/fast/borders/border-color-inherit-expected.png: Added.
        * platform/mac/fast/borders/border-color-inherit-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Alp Toker <alp@nuanti.com>
alp@webkit.org [Wed, 23 Apr 2008 03:14:26 +0000 (03:14 +0000)]
2008-04-22  Alp Toker  <alp@nuanti.com>

        GTK+ debug build fix for changes in r32257.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Alp Toker <alp@nuanti.com>
alp@webkit.org [Wed, 23 Apr 2008 02:15:51 +0000 (02:15 +0000)]
2008-04-22  Alp Toker  <alp@nuanti.com>

        Rubber-stamped by Dave Hyatt.

        Move GraphicsContext::clipToImageBuffer() notImplemented() stub to
        GraphicsContextCairo.

        * platform/graphics/GraphicsContext.cpp:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::clipToImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Wed, 23 Apr 2008 02:13:27 +0000 (02:13 +0000)]
WebCore:

2008-04-22  David Hyatt  <hyatt@apple.com>

        Add support for mask-composite to match background-composite.

        Reviewed by Sam Weinig

        Added fast/backgrounds/mask-composite.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseFillProperty):
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintMask):

LayoutTests:

2008-04-22  David Hyatt  <hyatt@apple.com>

        Add support for mask-composite.

        Reviewed by Sam Weinig

        * fast/backgrounds/mask-composite.html: Added.
        * fast/backgrounds/resources/mask-bottom-left.png: Added.
        * fast/backgrounds/resources/mask-bottom-right.png: Added.
        * fast/backgrounds/resources/mask-bottom.png: Added.
        * fast/backgrounds/resources/mask-center.png: Added.
        * fast/backgrounds/resources/mask-left.png: Added.
        * fast/backgrounds/resources/mask-right.png: Added.
        * fast/backgrounds/resources/mask-top-left.png: Added.
        * fast/backgrounds/resources/mask-top-right.png: Added.
        * fast/backgrounds/resources/mask-top.png: Added.
        * platform/mac/fast/backgrounds/mask-composite-expected.checksum: Added.
        * platform/mac/fast/backgrounds/mask-composite-expected.png: Added.
        * platform/mac/fast/backgrounds/mask-composite-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 23 Apr 2008 00:45:53 +0000 (00:45 +0000)]
2008-04-22  David Hyatt  <hyatt@apple.com>

        Fix for bug 18688, background-color stopped painting on inlines.  Fix a virtual function
        misnaming that led to the derived class not getting called properly.

        Reviewed by Mark Rowe

        * ChangeLog:
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintFillLayer):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::paintFillLayerExtended):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd new layout test results.
hyatt@apple.com [Wed, 23 Apr 2008 00:16:37 +0000 (00:16 +0000)]
Add new layout test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 23 Apr 2008 00:13:31 +0000 (00:13 +0000)]
2008-04-22  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        <rdar://problem/5733282> and https://bugs.webkit.org/show_bug.cgi?id=18680
        Always loads default shortcut icon URL when an external <script> is referenced before the icon URL is set.

        * dom/Document.cpp:
        (WebCore::Document::implicitClose): Call FrameLoader->startIconLoader() here, when the document is
          finished parsing.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::endIfNotLoadingMainResource):  Don't start the icon load here, when the
          document is finished parsing.  This was often too early, as document parsing may be blocked
          on an external script and therefore the correct iconURL is not set yet.
          The isLoadingFromCachedPage() check was when we started the icon load based on *loading* instead parsing,
          and is now irrelevant.
        * loader/FrameLoader.h:  Make startIconLoader() public

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Antti Koivisto <antti@apple.com>
antti@apple.com [Tue, 22 Apr 2008 23:52:11 +0000 (23:52 +0000)]
2008-04-22  Antti Koivisto  <antti@apple.com>

        Update SVG animation test results.

        * platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Antti Koivisto <antti@apple.com>
antti@apple.com [Tue, 22 Apr 2008 23:51:49 +0000 (23:51 +0000)]
2008-04-22  Antti Koivisto  <antti@apple.com>

        Reviewed by Oliver.

        Support keyPoints attribute of <animateMotion>.

        Tested by SVG test suite test
        animate-elem-33-t.svg

        * svg/SVGAnimateMotionElement.cpp:
        (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
        * svg/SVGAnimationElement.cpp:
        (WebCore::parseKeyTimes):
        (WebCore::SVGAnimationElement::parseMappedAttribute):
        (WebCore::SVGAnimationElement::calculatePercentForSpline):
        (WebCore::SVGAnimationElement::calculatePercentFromKeyPoints):
        (WebCore::SVGAnimationElement::currentValuesFromKeyPoints):
        (WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
        (WebCore::SVGAnimationElement::startedActiveInterval):
        (WebCore::SVGAnimationElement::updateAnimation):
        * svg/SVGAnimationElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Tue, 22 Apr 2008 21:49:59 +0000 (21:49 +0000)]
2008-04-22  Holger Hans Peter Freyther  <zecke@selfish.org>

        Unreviewed build fix.

        Update WebKit.qrc to catch up with the addition and removal of images
        from page/inspector/Images in recent commits.

        * page/inspector/WebKit.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Bug 18683: update-webkit returns 0 even if it fails
ddkilzer@apple.com [Tue, 22 Apr 2008 21:44:04 +0000 (21:44 +0000)]
    Bug 18683: update-webkit returns 0 even if it fails

        <https://bugs.webkit.org/show_bug.cgi?id=18683>

        Reviewed by Mitz Pettel.

        * Scripts/update-webkit:
        (runSvnUpdate): Die if close() fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Tue, 22 Apr 2008 21:40:35 +0000 (21:40 +0000)]
WebCore:

2008-04-22  David Hyatt  <hyatt@apple.com>

        Fix for <rdar://5589634>.

        Implement CSS alpha masks.  The syntax is very similar to that used for backgrounds.  Multiple mask images
        can be specified, and each one can be tiled, positioned, etc.  The following new properties have been
        added (all of which are analogous to their background-* counterparts).

        mask, mask-image, mask-clip, mask-origin, mask-repeat, mask-attachment, mask-position

        The alpha values in the final composite image are used to determine how the mask applies (alpha of 1 = show,
        alpha of 0 = don't show).

        SVG images and CSS gradients can also be used as masks.

        Reviewed by Dan

        Added fast/backgrounds/repeat/mask-negative-offset-repeat.html, fast/backgrounds/svg-as-mask.html

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
        (WebCore::initShorthandMap):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseFillProperty):
        (WebCore::CSSParser::parseTransformOrigin):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle):
        (WebCore::CSSStyleSelector::applyProperty):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paint):
        (WebCore::InlineFlowBox::paintFillLayers):
        (WebCore::InlineFlowBox::paintFillLayer):
        (WebCore::InlineFlowBox::paintBoxDecorations):
        (WebCore::InlineFlowBox::paintMask):
        * rendering/InlineFlowBox.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paint):
        (WebCore::RenderBlock::paintObject):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintRootBoxDecorations):
        (WebCore::RenderBox::paintBoxDecorations):
        (WebCore::RenderBox::paintMask):
        (WebCore::RenderBox::paintFillLayers):
        (WebCore::RenderBox::paintFillLayer):
        (WebCore::RenderBox::paintFillLayerExtended):
        * rendering/RenderBox.h:
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::paintBoxDecorations):
        (WebCore::RenderFieldset::paintMask):
        * rendering/RenderFieldset.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::requiresLayer):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::isTransparent):
        (WebCore::RenderLayer::paintLayer):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::requiresLayer):
        (WebCore::mustRepaintFillLayers):
        (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
        (WebCore::RenderObject::setStyle):
        (WebCore::RenderObject::updateFillImages):
        * rendering/RenderObject.h:
        (WebCore::):
        (WebCore::RenderObject::hasMask):
        (WebCore::RenderObject::paintMask):
        (WebCore::RenderObject::paintFillExtended):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::paint):
        * rendering/RenderStyle.cpp:
        (WebCore::FillLayer::FillLayer):
        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
        * rendering/RenderStyle.h:
        (WebCore::FillLayer::initialFillComposite):
        (WebCore::FillLayer::initialFillSize):
        (WebCore::FillLayer::FillLayer):
        (WebCore::RenderStyle::hasMask):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paint):
        (WebCore::RenderTable::paintBoxDecorations):
        (WebCore::RenderTable::paintMask):
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::requiresLayer):
        (WebCore::RenderTableCell::paintBackgroundsBehindCell):
        (WebCore::RenderTableCell::paintMask):
        * rendering/RenderTableCell.h:
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::draw):
        (WebCore::SVGImage::dataChanged):

LayoutTests:

2008-04-22  David Hyatt  <hyatt@apple.com>

        Add support for CSS alpha masks.  Test cases.

        Reviewed by Dan

        * fast/backgrounds/repeat/mask-negative-offset-repeat.html: Added.
        * fast/backgrounds/repeat/resources/white.gif: Added.
        * fast/backgrounds/svg-as-mask.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 22 Apr 2008 21:38:56 +0000 (21:38 +0000)]
2008-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Make DOMAbstractView have a weak reference to the Frame instead of ref'ing
        the DOMWindow.

        To ensure that the WindowScriptObject (which is a DOMAbstractView) stays valid
        after a navigation once the split window is completed, the DOMAbstractView must
        wrap the Frame instead of a DOMWindow since the DOMWindow will change.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMAbstractView.mm: Added.
        (-[DOMAbstractView dealloc]):
        (-[DOMAbstractView finalize]):
        (-[DOMAbstractView document]):
        (-[DOMAbstractView _disconnectFrame]):
        (-[DOMAbstractView WebCore::]):
        (-[DOMAbstractView _initWithFrame:WebCore::]):
        (+[DOMAbstractView _wrapAbstractView:WebCore::]):
        Add custom implementation to implement weak reference semantics.

        * bindings/objc/DOMAbstractViewFrame.h: Added.
        Declare the [DOMAbstractView _disconectFrame] selector.
        * bindings/objc/DOMInternal.h:
        Remove DOMRGBColor Internal category since it is now generated.

        * bindings/objc/DOMUtility.mm:
        (KJS::createDOMWrapper):
        Don't ever create a DOMAbstractView from a JSDOMWindow, only from JSDOMWindowWrapper.

        * bindings/scripts/CodeGeneratorObjC.pm:
        Generate internal header for IDLs that want custom implementations.

        * css/RGBColor.idl:
        Make this a PODType as it really is in the implementation.

        * page/AbstractView.idl:
        This now needs a custom objective-c binding implementation.

        * page/Frame.cpp:
        (WebCore::Frame::~Frame):
        disconnect the weak frame reference in the WindowScriptObject.

        * page/Frame.h:
        * page/gtk/FrameGtk.cpp:
        (WebCore::Frame::disconnectPlatformScriptObjects): Dummy implementation.
        * page/mac/FrameMac.mm:
        (WebCore::Frame::windowScriptObject): ASSERT that the windowScriptObject is a DOMAbstractView.
        (WebCore::Frame::disconnectPlatformScriptObjects): Disconnect the frame pointer from the windowScriptObject.
        * page/qt/FrameQt.cpp:
        (WebCore::Frame::disconnectPlatformScriptObjects): Dummy implementation.
        * page/win/FrameWin.cpp:
        (WebCore::Frame::disconnectPlatformScriptObjects): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix typo in ChangeLog.
mitz@apple.com [Tue, 22 Apr 2008 20:45:56 +0000 (20:45 +0000)]
Fix typo in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Tue, 22 Apr 2008 20:42:02 +0000 (20:42 +0000)]
WebCore:

        Reviewed by Sam Weinig.

        - preparation https://bugs.webkit.org/show_bug.cgi?id=3729
          <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren): Make sure to give the
        trailing white space a bidi level consistent with its position.

LayoutTests:

        Reviewed by Sam Weinig.

        - updated results with the trailing space having the right directionality

        * platform/mac/fast/text/trailing-white-space-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove many unused Web Inspector images.
timothy@apple.com [Tue, 22 Apr 2008 18:52:49 +0000 (18:52 +0000)]
Remove many unused Web Inspector images.

Rubber-stamped by Adam Roben and Sam Weinig.

* page/inspector/Images/attachedShadow.png: Removed.
* page/inspector/Images/backNormal.png: Removed.
* page/inspector/Images/bottomShadow.png: Removed.
* page/inspector/Images/breadcrumbBackground.png: Removed.
* page/inspector/Images/console.png: Removed.
* page/inspector/Images/databaseBrowserViewNormal.png: Removed.
* page/inspector/Images/databaseBrowserViewNormalSelected.png: Removed.
* page/inspector/Images/databaseBrowserViewSmall.png: Removed.
* page/inspector/Images/databaseBrowserViewSmallSelected.png: Removed.
* page/inspector/Images/databaseQueryViewNormal.png: Removed.
* page/inspector/Images/databaseQueryViewNormalSelected.png: Removed.
* page/inspector/Images/databaseQueryViewSmall.png: Removed.
* page/inspector/Images/databaseQueryViewSmallSelected.png: Removed.
* page/inspector/Images/disclosureDownPressed.png: Removed.
* page/inspector/Images/disclosureRightDown.png: Removed.
* page/inspector/Images/disclosureRightPressed.png: Removed.
* page/inspector/Images/document.png: Removed.
* page/inspector/Images/domViewNormal.png: Removed.
* page/inspector/Images/domViewNormalSelected.png: Removed.
* page/inspector/Images/domViewSmall.png: Removed.
* page/inspector/Images/domViewSmallSelected.png: Removed.
* page/inspector/Images/downTriangle.png: Removed.
* page/inspector/Images/folder.png: Removed.
* page/inspector/Images/forwardNormal.png: Removed.
* page/inspector/Images/gradient.png: Removed.
* page/inspector/Images/gradientHighlight.png: Removed.
* page/inspector/Images/gradientHighlightBottom.png: Removed.
* page/inspector/Images/hideStatusWidget.png: Removed.
* page/inspector/Images/hideStatusWidgetPressed.png: Removed.
* page/inspector/Images/network.png: Removed.
* page/inspector/Images/plainDocument.png: Removed.
* page/inspector/Images/popupArrows.png: Removed.
* page/inspector/Images/popupArrowsBlack.png: Removed.
* page/inspector/Images/reload.png: Removed.
* page/inspector/Images/rightTriangle.png: Removed.
* page/inspector/Images/showStatusWidget.png: Removed.
* page/inspector/Images/showStatusWidgetPressed.png: Removed.
* page/inspector/Images/sidbarItemBackground.png: Removed.
* page/inspector/Images/sidebarActionWidget.png: Removed.
* page/inspector/Images/sidebarActionWidgetPressed.png: Removed.
* page/inspector/Images/sidebarAttachWidget.png: Removed.
* page/inspector/Images/sidebarAttachWidgetPressed.png: Removed.
* page/inspector/Images/sidebarDetachWidget.png: Removed.
* page/inspector/Images/sidebarDetachWidgetPressed.png: Removed.
* page/inspector/Images/sidebarResizeWidget.png: Removed.
* page/inspector/Images/sidebarStatusAreaBackground.png: Removed.
* page/inspector/Images/sourceViewNormal.png: Removed.
* page/inspector/Images/sourceViewNormalSelected.png: Removed.
* page/inspector/Images/sourceViewSmall.png: Removed.
* page/inspector/Images/sourceViewSmallSelected.png: Removed.
* page/inspector/Images/tab.png: Removed.
* page/inspector/Images/tabSelected.png: Removed.
* page/inspector/Images/toggleDown.png: Removed.
* page/inspector/Images/toggleUp.png: Removed.
* page/inspector/Images/toolbarButtonNormal.png: Removed.
* page/inspector/Images/toolbarButtonNormalInactive.png: Removed.
* page/inspector/Images/toolbarButtonNormalPressed.png: Removed.
* page/inspector/Images/toolbarButtonNormalSelected.png: Removed.
* page/inspector/Images/toolbarButtonNormalSelectedInactive.png: Removed.
* page/inspector/Images/toolbarButtonSmall.png: Removed.
* page/inspector/Images/toolbarButtonSmallInactive.png: Removed.
* page/inspector/Images/toolbarButtonSmallPressed.png: Removed.
* page/inspector/Images/toolbarButtonSmallSelected.png: Removed.
* page/inspector/Images/toolbarButtonSmallSelectedInactive.png: Removed.
* page/inspector/Images/toolbarPopupButtonNormal.png: Removed.
* page/inspector/Images/toolbarPopupButtonNormalInactive.png: Removed.
* page/inspector/Images/toolbarPopupButtonNormalPressed.png: Removed.
* page/inspector/Images/toolbarPopupButtonSmall.png: Removed.
* page/inspector/Images/toolbarPopupButtonSmallInactive.png: Removed.
* page/inspector/Images/toolbarPopupButtonSmallPressed.png: Removed.
* page/inspector/Images/toolbarSplitButtonDividerNormal.png: Removed.
* page/inspector/Images/toolbarSplitButtonDividerNormalInactive.png: Removed.
* page/inspector/Images/toolbarSplitButtonDividerSmall.png: Removed.
* page/inspector/Images/toolbarSplitButtonDividerSmallInactive.png: Removed.
* page/inspector/Images/treeLeftTriangleBlack.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Tue, 22 Apr 2008 18:29:17 +0000 (18:29 +0000)]
WebCore:

2008-04-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.

        * bridge/npapi.h:
        * bridge/npruntime.h:
        * plugins/npfunctions.h:

WebKit/mac:

2008-04-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.

        * Plugins/npfunctions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
alice.liu@apple.com [Tue, 22 Apr 2008 17:55:10 +0000 (17:55 +0000)]
WebCore:

2008-04-22  Alice Liu  <alice.liu@apple.com>

        Reviewed by John Sullivan and Adam Roben.

        Test: fast/events/tabindex-focus-chain.html

        * dom/Document.cpp:
        (WebCore::Document::nextFocusableNode):
        (WebCore::Document::previousFocusableNode):
        If the focused node has been removed from the normal tabbing order,
        advancing focus from this node should advance to the next focusable
        node in tree order, and not start over at the beginning of the focus
        chain.

LayoutTests:

2008-04-22  Alice Liu  <alice.liu@apple.com>

        Reviewed by John Sullivan and Adam Roben.

        Test for new behavior when advancing focus from a focusable-by-script node, which now
        matches Firefox 2 and 3

        * fast/events/tabindex-focus-chain-expected.txt: Added.
        * fast/events/tabindex-focus-chain.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdds a debugger toggle button to the scripts status bar that will start
timothy@apple.com [Tue, 22 Apr 2008 16:54:16 +0000 (16:54 +0000)]
Adds a debugger toggle button to the scripts status bar that will start
and stop debugging of the inspected page.

Reviewed by Adam Roben.

* English.lproj/InspectorLocalizedStrings.js: Adds the two new tooltip strings.
* page/InspectorController.cpp:
(WebCore::debuggerAttached): Call InspectorController::debuggerAttached.
(WebCore::InspectorController::InspectorController): Initialize
m_debuggerAttached to false.
(WebCore::InspectorController::windowScriptObjectAvailable): Add the debuggerAttached
property to the InspectorController class.
(WebCore::InspectorController::startDebuggingAndReloadInspectedPage):
Set m_debuggerAttached to true.
(WebCore::InspectorController::stopDebugging): Set m_debuggerAttached to false.
* page/InspectorController.h:
* page/inspector/Images/debuggingButtons.png: Added.
* page/inspector/ScriptsPanel.js:
(WebInspector.ScriptsPanel): Disable the pause button. Create the debugging
button and setup the id, className and event listener. Call reset.
(WebInspector.ScriptsPanel.prototype.get statusBarItems): Return an array
(WebInspector.ScriptsPanel.prototype.reset): Call _updateDebuggerButtons.
(WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): Adjust the title of
the debugging button to match what will happen when clicked. Change the style class,
and toggle the disabled state of the pause button.
(WebInspector.ScriptsPanel.prototype._toggleDebugging): Start or stop debugging
depending on InspectorController.debuggerAttached().
* page/inspector/inspector.css: Added style rules for the debugger button.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Change PlatformWheelEvent to use GET_WHEEL_DELTA_WPARAM
aroben@apple.com [Tue, 22 Apr 2008 15:19:28 +0000 (15:19 +0000)]
    Change PlatformWheelEvent to use GET_WHEEL_DELTA_WPARAM

        Reviewed by Dan Bernstein.

        * platform/win/WheelEventWin.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use
        GET_WHEEL_DELTA_WPARAM, which is documented way of getting the wheel
        delta (it is equivalent to what we were previously doing, however).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoQt build fix.
hausmann@webkit.org [Tue, 22 Apr 2008 15:05:24 +0000 (15:05 +0000)]
Qt build fix.

Adjust the Qt resource file to removed image files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse CSS gradients to replace many image files in the Web Inspector.
timothy@apple.com [Tue, 22 Apr 2008 13:56:33 +0000 (13:56 +0000)]
Use CSS gradients to replace many image files in the Web Inspector.

Rubber-stamped by Adam Roben.

* page/inspector/Images/alternateTableRows.png: Removed.
* page/inspector/Images/darkShadow.png: Removed.
* page/inspector/Images/paneHeader.png: Removed.
* page/inspector/Images/paneHeaderActive.png: Removed.
* page/inspector/Images/sidebarSelection.png: Removed.
* page/inspector/Images/sidebarSelectionBackground.png: Removed.
* page/inspector/Images/sidebarSelectionBackgroundFocused.png: Removed.
* page/inspector/Images/sidebarSelectionBackgroundInactive.png: Removed.
* page/inspector/Images/sidebarSelectionBlurred.png: Removed.
* page/inspector/Images/sidebarSelectionBlurredTall.png: Removed.
* page/inspector/Images/sidebarSelectionGray.png: Removed.
* page/inspector/Images/sidebarSelectionGrayTall.png: Removed.
* page/inspector/Images/sidebarSelectionTall.png: Removed.
* page/inspector/Images/sidebarSmallSelectionBackground.png: Removed.
* page/inspector/Images/sidebarSmallSelectionBackgroundFocused.png: Removed.
* page/inspector/Images/sidebarSmallSelectionBackgroundInactive.png: Removed.
* page/inspector/Images/toolbarBackground.png: Removed.
* page/inspector/Images/toolbarBackgroundInactive.png: Removed.
* page/inspector/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAndre Poenitz <andre.poenitz@trolltech.com>
hausmann@webkit.org [Tue, 22 Apr 2008 12:46:00 +0000 (12:46 +0000)]
Andre Poenitz  <andre.poenitz@trolltech.com>

Remove compiler warnings on string literals used to construct QStrings
in webkit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Tue, 22 Apr 2008 11:33:44 +0000 (11:33 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Fixes: QWebPage's QNetworkManager's can be shared among webpages.

Don't force the deletion of the object, but let QObject take care of it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDocumentation for QWebPluginFactory and documentation updates for QWebPage.
hausmann@webkit.org [Tue, 22 Apr 2008 11:27:58 +0000 (11:27 +0000)]
Documentation for QWebPluginFactory and documentation updates for QWebPage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSimon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Tue, 22 Apr 2008 11:27:43 +0000 (11:27 +0000)]
Simon Hausmann <hausmann@webkit.org>

Added QWebPage::swallowContextMenuEvent and QWebPage::updatePositionDependentActions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdded Extension APIs for QWebPage.
hausmann@webkit.org [Tue, 22 Apr 2008 10:56:22 +0000 (10:56 +0000)]
Added Extension APIs for QWebPage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Tue, 22 Apr 2008 10:46:59 +0000 (10:46 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Emit loadProgress() signal on loadStarted().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoZack Rusin <zack@kde.org>
hausmann@webkit.org [Tue, 22 Apr 2008 10:33:36 +0000 (10:33 +0000)]
Zack Rusin <zack@kde.org>

Fix background propagation from the QWebView's palette.

The background brush of the palette needs to be propagated to the WebCore::FrameView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Tue, 22 Apr 2008 10:30:23 +0000 (10:30 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Fix maps.google.com

We have to include a version in the Safari tag in the user-agent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Tue, 22 Apr 2008 10:30:10 +0000 (10:30 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Fall back to last path component for suggested filename if the HTTP content disposition is not set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Tue, 22 Apr 2008 09:36:22 +0000 (09:36 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Implemented the generation of the title string for images.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Tue, 22 Apr 2008 09:31:46 +0000 (09:31 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Add visual focusing hint for clear button and
Change focus to web page after user enters new URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdded QWebFrame::hitTestContent() and QWebHitTestResult.
hausmann@webkit.org [Tue, 22 Apr 2008 08:31:28 +0000 (08:31 +0000)]
Added QWebFrame::hitTestContent() and QWebHitTestResult.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSimon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Tue, 22 Apr 2008 08:31:10 +0000 (08:31 +0000)]
Simon Hausmann <hausmann@webkit.org>

Don't crash if an input method query is done without a page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSimon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Tue, 22 Apr 2008 08:30:57 +0000 (08:30 +0000)]
Simon Hausmann <hausmann@webkit.org>

Added re-implementations of QObject::event for future safety.

This makes it easier to fix bugs with the event handling even in patch releases
and is a general style we follow in Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Tue, 22 Apr 2008 07:56:08 +0000 (07:56 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Fix construction of the user agent.

The user-agent is now composed of
* the platform and subplatform
* the Qt version or application name and version (if set)
* the locale
* the SSL settings

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoThiago Macieira <tjmaciei@trolltech.com>
hausmann@webkit.org [Tue, 22 Apr 2008 07:45:54 +0000 (07:45 +0000)]
Thiago Macieira <tjmaciei@trolltech.com>

Fixes: Pedantic compilation fix

Don't put semi-colons after braces closing namespaces.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoQt build fix.
hausmann@webkit.org [Tue, 22 Apr 2008 07:43:43 +0000 (07:43 +0000)]
Qt build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-19 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Tue, 22 Apr 2008 06:47:40 +0000 (06:47 +0000)]
2008-04-19  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

        Add a method to get the AccessibilityObject's access key,

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::accessKey): Added; returns the object's
        access key attribute.
        * page/AccessibilityObject.h: Added declaration for accessKey().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-19 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Tue, 22 Apr 2008 06:47:14 +0000 (06:47 +0000)]
2008-04-19  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

        Implement get_accHelp().

        * AccessibleBase.cpp:
        (AccessibleBase::get_accHelp): Report the result of calling the object's
        helpText() method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-19 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Tue, 22 Apr 2008 06:46:44 +0000 (06:46 +0000)]
2008-04-19  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

        Implement get_accState().

        * AccessibleBase.cpp:
        (AccessibleBase::get_accState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Tue, 22 Apr 2008 06:46:10 +0000 (06:46 +0000)]
2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

        Implement get_accRole().

        * AccessibleBase.cpp:
        (AccessibleBase::get_accRole): Report the result of role().
        (MSAARole): Added; returns the MSAA role for a WebCore role.
        (AccessibleBase::role): Return the MSAA role for the object's roleValue.
        * AccessibleBase.h: Add declaration for role().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Tue, 22 Apr 2008 06:45:31 +0000 (06:45 +0000)]
2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

        Implement get_accName(), get_accValue(), get_accDescription(). Added
        virtual methods that accessible objects can override to customize the
        result.

        * AccessibleBase.cpp:
        (AccessibleBase::get_accName): Report result of name().
        (AccessibleBase::get_accValue): Report result of value().
        (AccessibleBase::get_accDescription): Report result of description().
        (AccessibleBase::name): Added; returns AccessibilityObject::title().
        (AccessibleBase::value): Added; returns
        AccessibilityObject::stringValue().
        (AccessibleBase::description): Added; returns
        AccessibilityObject::accessibilityDescription().
        * AccessibleBase.h: Added declarations for name(), value(), and
        description().
        * ChangeLog: Fix my misuse of "definition."

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix layout test results for new props.
hyatt@apple.com [Tue, 22 Apr 2008 05:47:53 +0000 (05:47 +0000)]
Fix layout test results for new props.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-21 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 22 Apr 2008 04:44:38 +0000 (04:44 +0000)]
2008-04-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Fix numerous crashing tests.

        * html/HTMLHtmlElement.cpp:
        (WebCore::HTMLHtmlElement::insertedIntoDocument): Null check document->frame().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the case on the file names of test results for svg/custom/altglyph.svg, and remov...
mrowe@apple.com [Tue, 22 Apr 2008 04:06:05 +0000 (04:06 +0000)]
Fix the case on the file names of test results for svg/custom/altglyph.svg, and remove an extra -expected.txt that was checked in with incorrect
case.

* platform/mac/svg/custom/altGlyph-expected.checksum: Removed.
* platform/mac/svg/custom/altGlyph-expected.png: Removed.
* platform/mac/svg/custom/altGlyph-expected.txt: Removed.
* platform/mac/svg/custom/altglyph-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/altGlyph-expected.checksum.
* platform/mac/svg/custom/altglyph-expected.png: Copied from LayoutTests/platform/mac/svg/custom/altGlyph-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Tue, 22 Apr 2008 03:33:12 +0000 (03:33 +0000)]
WebCore:

2008-04-21  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        Tests: fast/media/implicit-media-all.html
               fast/media/monochrome.html

        - allow implicit "all" media in media queries
        - use a value of 0 for the monochrome media feature on color displays

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::createFloatingMediaQuery):
        * css/CSSParser.h:
        * css/MediaQueryEvaluator.cpp:
        (WebCore::monochromeMediaFeatureEval):

LayoutTests:

2008-04-21  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        - update acid3.html to reflect the updated test.
        - test for implicit "all" media in media queries
        - test that the value of the monochrome media feature is 0 on color displays

        * http/tests/misc/acid3.html:
        * fast/media/implicit-media-all.html: Added.
        * fast/media/monochrome.html: Added.
        * platform/mac/fast/media/implicit-media-all-expected.checksum: Added.
        * platform/mac/fast/media/implicit-media-all-expected.png: Added.
        * platform/mac/fast/media/implicit-media-all-expected.txt: Added.
        * platform/mac/fast/media/monochrome-expected.checksum: Added.
        * platform/mac/fast/media/monochrome-expected.png: Added.
        * platform/mac/fast/media/monochrome-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-21 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 22 Apr 2008 00:04:30 +0000 (00:04 +0000)]
2008-04-21  Brady Eidson  <beidson@apple.com>

        Rockingly reviewed by Adele

        Small StorageArea cleanups

        * storage/SessionStorageArea.cpp:
        (WebCore::SessionStorageArea::copy): Pass "this" instead of the StorageMap belonging to this
        (WebCore::SessionStorageArea::SessionStorageArea):
        * storage/SessionStorageArea.h:

        * storage/StorageArea.cpp:  Changed to not expose the StorageMap at all - it's dangerous to expose
          it since we rely explicitly on its ref-count
        (WebCore::StorageArea::StorageArea): Take another StorageArea as the c'tor argument and get the
          StorageMap from that.
        (WebCore::StorageArea::setItem):  The previous comment/code here was bogus.  All JS objects passed in
          to this API are stringified, so there's no such thing as "null" for setItem()
        * storage/StorageArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdated CSS Visual Effects proposals.
dino@apple.com [Mon, 21 Apr 2008 23:51:54 +0000 (23:51 +0000)]
Updated CSS Visual Effects proposals.

CSS Animations

* described simplified sandwich model (that animations have no effect
  outside their duration and last specified animation wins)
* diagram showing the above
* specified animations to start at style resolution or document load,
  whichever is later.
* animation start events always have elapsedTime == 0

CSS Transforms

* removed text saying that elements cannot be drawn as intersecting.
* described that preserve-3d trees often need a flattening parent, otherwise
  elements can be hidden behind their ancestor's background.
* describe that preserve-3d is not always possible, such as when
  overflow is 'hidden'.

CSS Transitions

* no change

* specs/CSSVisualEffects/CSSAnimation.html:
* specs/CSSVisualEffects/CSSTransforms.html:
* specs/CSSVisualEffects/CSSTransitions.html:
* specs/CSSVisualEffects/sandwich.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Windows bustage.
hyatt@apple.com [Mon, 21 Apr 2008 23:22:06 +0000 (23:22 +0000)]
Fix Windows bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-21 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Mon, 21 Apr 2008 23:13:27 +0000 (23:13 +0000)]
2008-04-21  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam.

        <rdar://problem/5770054> JavaScript profiler (10928)
        - When stop profiling is called we need to stop the timers on all the
        functions that are still running.

        * profiler/FunctionCallProfile.cpp:
        (KJS::FunctionCallProfile::didExecute):
        (KJS::FunctionCallProfile::stopProfiling):
        * profiler/FunctionCallProfile.h:
        * profiler/Profiler.cpp:
        (KJS::Profiler::stopProfiling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Mon, 21 Apr 2008 22:48:41 +0000 (22:48 +0000)]
WebCore:

2008-04-21  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John Sullivan.

        <rdar://problem/5803706> Pressing return at the end of a header doesn't break out of header (17460)

        If we're doing InsertParagraphSeparator at the end of a header element, do not clone it.
        Renamed m_useDefaultParagraphElement to m_mustUseDefaultParagraphElement, since now,
        when it is false, that does not necessarily mean that a default paragraph element
        will not be used.  Callers that passed false for this argument are OK with this.

        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand):
        (WebCore::InsertParagraphSeparatorCommand::shouldUseDefaultParagraphElement):
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        * editing/InsertParagraphSeparatorCommand.h:

LayoutTests:

2008-04-21  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John Sullivan.

        <rdar://problem/5803706> Pressing return at the end of a header doesn't break out of header (17460)

        * editing/inserting/5803706-1-expected.txt: Added.
        * editing/inserting/5803706-1.html: Added.
        * editing/inserting/5803706-2-expected.txt: Added.
        * editing/inserting/5803706-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLand updated results for three tests and disable three more on Tiger.
mrowe@apple.com [Mon, 21 Apr 2008 22:22:45 +0000 (22:22 +0000)]
Land updated results for three tests and disable three more on Tiger.

* http/tests/xmlhttprequest/infoOnProgressEvent-expected.txt:
* platform/mac-tiger/Skipped:  Disable three tests using font-face that fail intermittently on Tiger bots.
* platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:  Update Tiger results following r32247.
* platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:  Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-21 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 21 Apr 2008 22:21:24 +0000 (22:21 +0000)]
2008-04-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Perform cache selection. If a main resource has a URL that exists in a cache, load it from there.

        * html/HTMLAttributeNames.in:
        Add manifest attribute.

        * html/HTMLHtmlElement.cpp:
        (WebCore::HTMLHtmlElement::insertedIntoDocument):
        * html/HTMLHtmlElement.h:
        Perform cache selection.

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::load):
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::cacheHostSet):
        (WebCore::urlHostHash):
        (WebCore::ApplicationCacheGroup::cacheForRequest):
        (WebCore::ApplicationCacheGroup::selectCache):
        * loader/appcache/ApplicationCacheGroup.h:
        * platform/KURL.h:
        (WebCore::KURL::hostStart):
        (WebCore::KURL::hostEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by eseidel and darin. Landed by eseidel.
eric@webkit.org [Mon, 21 Apr 2008 22:14:14 +0000 (22:14 +0000)]
    Reviewed by eseidel and darin.  Landed by eseidel.

        Fix broken optimization in createStrippingNullCharacters.

        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::createStrippingNullCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-21 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 21 Apr 2008 21:59:33 +0000 (21:59 +0000)]
2008-04-21  David Hyatt  <hyatt@apple.com>

        Make the back end parsing of background properties generic.  Rename all the parsing functions from
        background -> fill.

        Add a new set of properties for doing masks.  The code is now refactored so that the mask properties
        and the background properties share parsing routines.

        Reviewed by Dan

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::addFillValue):
        (WebCore::CSSParser::parseFillShorthand):
        (WebCore::CSSParser::parseFillImage):
        (WebCore::CSSParser::parseFillPositionXY):
        (WebCore::CSSParser::parseFillPosition):
        (WebCore::CSSParser::parseFillSize):
        (WebCore::CSSParser::parseFillProperty):
        (WebCore::CSSParser::parseTransformOrigin):
        * css/CSSParser.h:
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector):
        (WebCore::CSSStyleSelector::mapFillAttachment):
        (WebCore::CSSStyleSelector::mapFillClip):
        (WebCore::CSSStyleSelector::mapFillComposite):
        (WebCore::CSSStyleSelector::mapFillOrigin):
        (WebCore::CSSStyleSelector::mapFillImage):
        (WebCore::CSSStyleSelector::mapFillRepeat):
        (WebCore::CSSStyleSelector::mapFillSize):
        (WebCore::CSSStyleSelector::mapFillXPosition):
        (WebCore::CSSStyleSelector::mapFillYPosition):
        * rendering/RenderStyle.cpp:
        (WebCore::FillLayer::FillLayer):
        (WebCore::FillLayer::operator=):
        (WebCore::FillLayer::operator==):
        (WebCore::StyleBackgroundData::StyleBackgroundData):
        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
        (WebCore::StyleRareNonInheritedData::operator==):
        (WebCore::RenderStyle::diff):
        * rendering/RenderStyle.h:
        (WebCore::LengthSize::LengthSize):
        (WebCore::):
        (WebCore::FillLayer::type):
        (WebCore::FillLayer::initialFillAttachment):
        (WebCore::FillLayer::initialFillClip):
        (WebCore::FillLayer::initialFillOrigin):
        (WebCore::FillLayer::initialFillRepeat):
        (WebCore::FillLayer::initialFillComposite):
        (WebCore::FillLayer::initialFillSize):
        (WebCore::FillLayer::initialFillXPosition):
        (WebCore::FillLayer::initialFillYPosition):
        (WebCore::FillLayer::initialFillImage):
        (WebCore::RenderStyle::maskImage):
        (WebCore::RenderStyle::maskRepeat):
        (WebCore::RenderStyle::maskComposite):
        (WebCore::RenderStyle::maskAttachment):
        (WebCore::RenderStyle::maskClip):
        (WebCore::RenderStyle::maskOrigin):
        (WebCore::RenderStyle::maskXPosition):
        (WebCore::RenderStyle::maskYPosition):
        (WebCore::RenderStyle::maskSize):
        (WebCore::RenderStyle::accessMaskLayers):
        (WebCore::RenderStyle::maskLayers):
        (WebCore::RenderStyle::clearBackgroundLayers):
        (WebCore::RenderStyle::clearMaskLayers):
        (WebCore::RenderStyle::inheritMaskLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes the issue were a Database view could still be visible after navigating to a...
timothy@apple.com [Mon, 21 Apr 2008 20:55:15 +0000 (20:55 +0000)]
Fixes the issue were a Database view could still be visible after navigating to a new page.

Reviewed by Darin Adler.

* page/inspector/DatabasesPanel.js:
(WebInspector.DatabasesPanel.prototype.reset): Delete the _tableViews and _queryView properties
from all databases. Remove all the children from databaseViews.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdds the ability to enter multi-line commands in the console by holding the
timothy@apple.com [Mon, 21 Apr 2008 20:54:55 +0000 (20:54 +0000)]
Adds the ability to enter multi-line commands in the console by holding the
alt/option key when pressing enter/return.

https://bugs.webkit.org/show_bug.cgi?id=18454

Reviewed by Darin Adler.

* page/inspector/Console.js:
(WebInspector.Console.prototype._enterKeyPressed): Return early if the
alt/option key is held when enter is pressed.
* page/inspector/inspector.css:
(.console-message-text): Added. Set white-space: pre-wrap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes the bug where the Database table names do not update when
timothy@apple.com [Mon, 21 Apr 2008 20:54:34 +0000 (20:54 +0000)]
Fixes the bug where the Database table names do not update when
running the CREATE TABLE or DROP TABLE queries. Also makes the
table names update every time the database is collapsed and expanded.

https://bugs.webkit.org/show_bug.cgi?id=18453

Reviewed by Darin Adler.

* page/inspector/DatabasesPanel.js:
(WebInspector.DatabasesPanel.prototype.updateDatabaseTables):
Set shouldRefreshChildren to true on the Database's tree element.
The refreshChildren property was renamed to shouldRefreshChildren.
(WebInspector.DatabaseSidebarTreeElement.prototype.oncollapse):
Request a refresh after every collapse so the next expand will
have an updated table list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdds INDEX to the list of completion words for the Databases query view.
timothy@apple.com [Mon, 21 Apr 2008 20:54:07 +0000 (20:54 +0000)]
Adds INDEX to the list of completion words for the Databases query view.

https://bugs.webkit.org/show_bug.cgi?id=18452

Reviewed by Darin Adler.

* page/inspector/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView.prototype.completions): Split up "CREATE TABLE "
and "DROP TABLE " into "CREATE ", "DROP ", "TABLE ". And added "INDEX ".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdds the UI portions of the Scripts panel to the Web Inspector.
timothy@apple.com [Mon, 21 Apr 2008 20:53:40 +0000 (20:53 +0000)]
Adds the UI portions of the Scripts panel to the Web Inspector.
The Scripts panel has not been added to the toolbar yet.

https://bugs.webkit.org/show_bug.cgi?id=18601

Reviewed by Adam Roben.

* English.lproj/InspectorLocalizedStrings.js: Changed "Show inherited properties"
to "Show inherited". Adds new strings for the Scripts' panel tooltips.
* page/inspector/BreakpointsSidebarPane.js: Added.
* page/inspector/CallStackSidebarPane.js: Added.
* page/inspector/Images/back.png: Added.
* page/inspector/Images/debuggerContinue.png: Added.
* page/inspector/Images/debuggerPause.png: Added.
* page/inspector/Images/debuggerStepInto.png: Added.
* page/inspector/Images/debuggerStepOut.png: Added.
* page/inspector/Images/debuggerStepOver.png: Added.
* page/inspector/Images/forward.png: Added.
* page/inspector/Images/statusbarResizerHorizontal.png: Added.
* page/inspector/PropertiesSection.js:
(WebInspector.PropertiesSection): Flip the order the subtile is appended
so it can float right in the CSS.
* page/inspector/ScriptsPanel.js: Added.
* page/inspector/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection): Changed "Show inherited properties"
to "Show inherited".
* page/inspector/inspector.css: Added new CSS rules for the Scripts panel.
Also changes the look of the section to match the mockup, this affects
Styles and Properties in Elements.
* page/inspector/inspector.html: Import new files.
* page/inspector/inspector.js:
(Preferences.minScriptsSidebarWidth): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-21 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Mon, 21 Apr 2008 20:25:46 +0000 (20:25 +0000)]
2008-04-21  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam.

        <rdar://problem/5770054> JavaScript profiler (10928)
        Took out debugging printing since we really want to hook into the
        inspector and not to print to the terminal.

        * page/Console.cpp:
        (WebCore::Console::profileEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-21 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 21 Apr 2008 20:23:20 +0000 (20:23 +0000)]
2008-04-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Fix up XMLHttpRequestProgressEvent.

        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS):
        * xml/XMLHttpRequestProgressEvent.cpp:
        * xml/XMLHttpRequestProgressEvent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix Bug 18615: Crash in PluginPackage::hash
aroben@apple.com [Mon, 21 Apr 2008 20:15:59 +0000 (20:15 +0000)]
    Fix Bug 18615: Crash in PluginPackage::hash

        <https://bugs.webkit.org/show_bug.cgi?id=18615>

        Reviewed by Anders Carlsson.

        * plugins/PluginDatabase.cpp:
        (WebCore::PluginDatabase::refresh): Don't pass a null PluginPackage*
        to add().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-21 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 21 Apr 2008 20:00:20 +0000 (20:00 +0000)]
2008-04-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Add cache group implementation.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::scheduleApplicationCacheLoad):
        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):
        (WebCore::ApplicationCache::resourceForRequest):
        * loader/appcache/ApplicationCache.h:
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::cacheGroupMap):
        (WebCore::ApplicationCacheGroup::ApplicationCacheGroup):
        (WebCore::ApplicationCacheGroup::selectCache):
        (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
        (WebCore::ApplicationCacheGroup::finishedLoadingMainResource):
        (WebCore::ApplicationCacheGroup::documentLoaderDestroyed):
        (WebCore::ApplicationCacheGroup::cacheDestroyed):
        (WebCore::ApplicationCacheGroup::update):
        (WebCore::ApplicationCacheGroup::didReceiveResponse):
        (WebCore::ApplicationCacheGroup::didReceiveData):
        (WebCore::ApplicationCacheGroup::didFinishLoading):
        (WebCore::ApplicationCacheGroup::didFail):
        (WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
        (WebCore::ApplicationCacheGroup::didReceiveManifestData):
        (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
        (WebCore::ApplicationCacheGroup::cacheUpdateFailed):
        (WebCore::ApplicationCacheGroup::didFailToLoadManifest):
        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
        (WebCore::ApplicationCacheGroup::startLoadingEntry):
        (WebCore::ApplicationCacheGroup::addEntry):
        (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache):
        (WebCore::ApplicationCacheGroup::callListenersOnAssociatedDocuments):
        (WebCore::ApplicationCacheGroup::callListeners):
        * loader/appcache/ApplicationCacheGroup.h:
        (WebCore::ApplicationCacheGroup::status):
        (WebCore::ApplicationCacheGroup::newestCache):
        * platform/KURL.h:
        (WebCore::KURL::hostStart):
        (WebCore::KURL::hostEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32339 268f45cc-cd09-0410-ab3c-d52691b4dbfc