WebKit-https.git
7 years ago[BlackBerry] Null check calls associated with retrieving the caret rect.
commit-queue@webkit.org [Mon, 26 Nov 2012 21:38:45 +0000 (21:38 +0000)]
[BlackBerry] Null check calls associated with retrieving the caret rect.
https://bugs.webkit.org/show_bug.cgi?id=103281

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-26
Reviewed by Rob Buis.

Some of these calls can return null, which could lead to a crash.

Internally reviewed by Gen Mak.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't blind all the things.
oliver@apple.com [Mon, 26 Nov 2012 21:20:37 +0000 (21:20 +0000)]
Don't blind all the things.
https://bugs.webkit.org/show_bug.cgi?id=102572

Reviewed by Gavin Barraclough.

No longer blind all the constants in the instruction stream.  We use a
simple non-deterministic filter to avoid blinding everything.  Also modified
the basic integer blinding logic to avoid blinding small negative values.

* assembler/MacroAssembler.h:
(MacroAssembler):
(JSC::MacroAssembler::shouldConsiderBlinding):
(JSC::MacroAssembler::shouldBlind):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSObject::copyButterfly doesn't handle undecided indexing types correctly
mhahnenberg@apple.com [Mon, 26 Nov 2012 21:00:07 +0000 (21:00 +0000)]
JSObject::copyButterfly doesn't handle undecided indexing types correctly
https://bugs.webkit.org/show_bug.cgi?id=102573

Reviewed by Filip Pizlo.

We don't do any copying into the newly allocated vector and we don't zero-initialize CopiedBlocks
during the copying phase, so we end up with uninitialized memory in arrays which have undecided indexing
types. We should just do the actual memcpy from the old block to the new one.

* runtime/JSObject.cpp:
(JSC::JSObject::copyButterfly): Just do the same thing that we do for other contiguous indexing types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd ResourceBuffer::append(CFDataRef) to get code to compile with USE(NETWORK_CFDATA_...
psolanki@apple.com [Mon, 26 Nov 2012 20:49:06 +0000 (20:49 +0000)]
Add ResourceBuffer::append(CFDataRef) to get code to compile with USE(NETWORK_CFDATA_ARRAY_CALLBACK)
https://bugs.webkit.org/show_bug.cgi?id=102706

Reviewed by Brent Fulgham.

No new tests because the flag isn't enabled. Also the functionality should be covered by
existing tests.

* loader/ResourceBuffer.cpp:
(WebCore):
(WebCore::ResourceBuffer::append):
* loader/ResourceBuffer.h:
(ResourceBuffer):
* loader/mac/ResourceLoaderMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r135743.
rjkroege@chromium.org [Mon, 26 Nov 2012 20:37:06 +0000 (20:37 +0000)]
Unreviewed, rolling out r135743.
http://trac.webkit.org/changeset/135743
https://bugs.webkit.org/show_bug.cgi?id=103280

Caused compile failure 'SK_DISABLE_DITHER_32BIT_GRADIENT'
macro redefined (Requested by rjkroege on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-26

* skia_webkit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove more functions from internals.settings to internals
tony@chromium.org [Mon, 26 Nov 2012 20:27:36 +0000 (20:27 +0000)]
Move more functions from internals.settings to internals
https://bugs.webkit.org/show_bug.cgi?id=102976

Reviewed by Adam Barth.

Source/WebCore:

Move functions that don't have to do with Settings off of internals.settings.
setPagination and configurationForViewport were defined on internals, so we
can inline the functions (no test change).

setEnableMockPagePopup is moved to Internals.

No new tests, this is a refactor.

* testing/InternalSettings.cpp:
(WebCore::InternalSettings::reset): Move reset code into Internals.
* testing/InternalSettings.h:
(InternalSettings): Remove code for setPagination, configurationForViewport and setEnableMockPagePopup.
* testing/InternalSettings.idl: Remove setPagination and setEnableMockPagePopup.
* testing/Internals.cpp:
(WebCore): Use a static to keep track of the MockPagePopupDriver.
(WebCore::Internals::resetToConsistentState): Code from InternalSettings::reset
(WebCore::Internals::setEnableMockPagePopup): Code copied from InternalSettings.
(WebCore::Internals::pagePopupController): Code copied from InternalSettings.
(WebCore::Internals::setPagination): Code copied from InternalSettings.
(WebCore::Internals::configurationForViewport): Code copied from InternalSettings.
* testing/Internals.h:
(Internals): Add setEnableMockPagePopup.
* testing/Internals.idl: Add setEnableMockPagePopup.

LayoutTests:

Move internals.settings.setEnableMockPagePopup to internals.setEnableMockPagePopup.

* fast/forms/resources/picker-common.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add setting to enable / disable HTML5 local storage functionality
commit-queue@webkit.org [Mon, 26 Nov 2012 20:17:36 +0000 (20:17 +0000)]
[EFL][WK2] Add setting to enable / disable HTML5 local storage functionality
https://bugs.webkit.org/show_bug.cgi?id=103224

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-26
Reviewed by Laszlo Gombos.

Source/WebKit2:

Add API to ewk_settings to enable / disable the HTML5
local storage functionality. The functionality is
enabled by default.

* UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_local_storage_enabled_set):
(ewk_settings_local_storage_enabled_get):
* UIProcess/API/efl/ewk_settings.h:
* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F): Add API test for ewk_settings_local_storage_enabled_get / set.

Tools:

Add --local-storage command line argument to MiniBrowser to
explicitely disable HTML5 local storage functionality. This
is useful for testing purposes.

* MiniBrowser/efl/main.c:
(window_create):
(elm_main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Add Region info for RootLineBoxes and pack the pagination data
commit-queue@webkit.org [Mon, 26 Nov 2012 20:00:49 +0000 (20:00 +0000)]
[CSS Regions] Add Region info for RootLineBoxes and pack the pagination data
https://bugs.webkit.org/show_bug.cgi?id=101332

Patch by Andrei Bucur <abucur@adobe.com> on 2012-11-26
Reviewed by David Hyatt.

Source/WebCore:

Currently the pagination information for lines is spread between the RootInlineBox and InlineFlowBox classes, consuming memory even though
the boxes were not the result of an pagination layout. To overcome this, a new struct (LineFragmentationData) is created that wraps all the data,
including two new members, the containing Region for the line and a boolean that states if the line was laid out in a Region or not.
The flag is necessary because the sanitize function on LineFragmentationData resets the containing Region to 0 if the Region was removed from
chain (so a value of 0 for the containing Region means two things). The sanitize function should prevent access to an invalid address.
The containing Region is used to detect if a line changed the Region where it resides. This will be helpful especially when implementing region
styling for layout properties (e.g. the font-size property https://bugs.webkit.org/show_bug.cgi?id=95559 ).
A line can change the region when it is shifted inside the containing block or if the entire block moves. This means it's better to delegate
the task of updating the containing Region to the block.

Tests: fast/regions/line-containing-region-crash.html

* rendering/InlineFlowBox.cpp:
(SameSizeAsInlineFlowBox):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
(InlineFlowBox):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::determineStartPosition):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::setContainingRegion):
(WebCore):
(WebCore::RootInlineBox::LineFragmentationData::sanitize): This is an O(1) function that checks if the containig Region is still valid pointer.
* rendering/RootInlineBox.h:
(WebCore):
(WebCore::RootInlineBox::paginationStrut):
(WebCore::RootInlineBox::setPaginationStrut):
(WebCore::RootInlineBox::isFirstAfterPageBreak):
(WebCore::RootInlineBox::setIsFirstAfterPageBreak):
(WebCore::RootInlineBox::paginatedLineWidth):
(WebCore::RootInlineBox::setPaginatedLineWidth):
(RootInlineBox):
(WebCore::RootInlineBox::containingRegion):
(WebCore::RootInlineBox::hasContainingRegion): Use this to determine if the line has a region or not.
(WebCore::RootInlineBox::ensureLineFragmentationData):
(LineFragmentationData):
(WebCore::RootInlineBox::LineFragmentationData::LineFragmentationData):

LayoutTests:

The test checks if there is a crash when doing a line layout if:
- the flow has no region
- the flow has a region but the lines have no containing region
- the flow has no region but the lines have a containing region

* fast/regions/line-containing-region-crash-expected.txt: Added.
* fast/regions/line-containing-region-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shaders] Add IDL file and bindings for mix function
michelangelo@webkit.org [Mon, 26 Nov 2012 19:57:40 +0000 (19:57 +0000)]
[CSS Shaders] Add IDL file and bindings for mix function
https://bugs.webkit.org/show_bug.cgi?id=93011

Reviewed by Dean Jackson.

Source/WebCore:

JavaScript bindings have been added for the Custom Filter mix()
function (WebKitCSSMixFunctionValue). As of now, this is only a
placeholder that extends CSSValueList without adding any new
property.

Test: css3/filters/custom/custom-filter-mix-bindings.html

* CMakeLists.txt: mix() IDL has been added to the Generator;
DerivedSources have been included.
* DerivedSources.cpp: Ditto.
* DerivedSources.make: Ditto.
* DerivedSources.pri: Ditto.
* GNUmakefile.list.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS): return a JSC DOM wrapper for WebKitCSSMixFunctionValue.
* bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::V8CSSValue::dispatchWrapCustom): Ditto, for V8.
* css/WebKitCSSMixFunctionValue.idl: Added.

LayoutTests:

Test for the Custom Filter mix() function JS bindings.

* css3/filters/custom/custom-filter-mix-bindings-expected.txt: Added.
* css3/filters/custom/custom-filter-mix-bindings.html: Added.
* css3/filters/script-tests/custom-filter-mix-bindings.js: Added.
(jsWrapperClass):
(shouldBeType):
* platform/chromium/css3/filters/custom/custom-filter-mix-bindings-expected.txt: Added.
* platform/efl/fast/js/global-constructors-expected.txt: Updated with the new WebKitCSSMixFunctionValueConstructor.
* platform/gtk/fast/js/global-constructors-expected.txt: Ditto.
* platform/mac/fast/js/global-constructors-expected.txt: Ditto.
* platform/qt-5.0/fast/js/global-constructors-expected.txt: Ditto.
* platform/qt/fast/js/global-constructors-expected.txt: Ditto.
* platform/win/fast/js/global-constructors-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CoordinatedGraphics] Access to LayerTreeRenderer::m_renderQueue should be thread...
rafael.lobo@openbossa.org [Mon, 26 Nov 2012 19:45:31 +0000 (19:45 +0000)]
[CoordinatedGraphics] Access to LayerTreeRenderer::m_renderQueue should be thread safe
https://bugs.webkit.org/show_bug.cgi?id=101341

Reviewed by Noam Rosenthal.

* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::syncRemoteContent): The previous swap already clears the
vector on m_renderQueue. It is also done in a thread-safe way, so clearing it afterward
can be harmful as we've already released the lock.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOptimize layer updates after scrolling
simon.fraser@apple.com [Mon, 26 Nov 2012 19:37:45 +0000 (19:37 +0000)]
Optimize layer updates after scrolling
https://bugs.webkit.org/show_bug.cgi?id=102635

Reviewed by Sam Weinig.

updateLayerPositionsAfterScroll() previously unconditionally cleared clip
rects, and recomputed repaint rects too often. Recomputing both of these
can be very expensive, as they involve tree walks up to the root.

We can optimize layer updates after document scrolling by only clearing clip
rects, and recomputing repaint rects, if we encounter a fixed- or sticky-position
element. For overflow scroll, we have to clear clip rects and recompute repaint rects.

* page/FrameView.cpp:
(WebCore::FrameView::repaintFixedElementsAfterScrolling): Call updateLayerPositionsAfterDocumentScroll().
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions): Call clearClipRects() because
updateLayerPosition() no longer does.
(WebCore::RenderLayer::updateLayerPositionsAfterDocumentScroll): Version of updateLayerPositionsAfterScroll()
that is for document scrolls. It has no need to push layers to the geometry map.
(WebCore::RenderLayer::updateLayerPositionsAfterOverflowScroll): Pushes layers to the geometry map,
and calls updateLayerPositionsAfterScroll() with the IsOverflowScroll flag.
(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Set the HasChangedAncestor flag
if our location changed, and use that as a hint to clear cached rects. Be more conservative
than before about when to clear cached clip rects.
(WebCore::RenderLayer::updateLayerPosition):  Move responsibility for calling
clearClipRects() ouf of this function and into callers.
(The one caller outside RenderLayer will be removed via bug 102624).
Return a bool indicating whether our position changed.
(WebCore::RenderLayer::scrollTo): Call updateLayerPositionsAfterOverflowScroll().
(WebCore::RenderLayer::updateClipRects): Added some #ifdeffed out code that is useful
to verify that cached clips are correct; it's too slow to leave enabled in debug builds.
* rendering/RenderLayer.h:
(WebCore::RenderLayer::setLocation): Change to take a LayoutPoint, rather than separate
x and y.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[sh4] JavaScriptCore JIT build is broken since r135330
commit-queue@webkit.org [Mon, 26 Nov 2012 19:37:18 +0000 (19:37 +0000)]
[sh4] JavaScriptCore JIT build is broken since r135330
Add missing implementation for sh4 arch.
https://bugs.webkit.org/show_bug.cgi?id=103145

Patch by Julien BRIANCEAU <jbrianceau@nds.com> on 2012-11-26
Reviewed by Oliver Hunt.

* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::canJumpReplacePatchableBranchPtrWithPatch):
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::startOfBranchPtrWithPatchOnRegister):
(JSC::MacroAssemblerSH4::revertJumpReplacementToBranchPtrWithPatch):
(JSC::MacroAssemblerSH4::startOfPatchableBranchPtrWithPatchOnAddress):
(JSC::MacroAssemblerSH4::revertJumpReplacementToPatchableBranchPtrWithPatch):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::revertJump):
(SH4Assembler):
(JSC::SH4Assembler::printInstr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove use of deprecated logging from most of webkitpy.tool
zandobersek@gmail.com [Mon, 26 Nov 2012 19:31:53 +0000 (19:31 +0000)]
Remove use of deprecated logging from most of webkitpy.tool
https://bugs.webkit.org/show_bug.cgi?id=103180

Reviewed by Dirk Pranke.

Remove calls to log and error methods of the deprecated_logging module, replacing them
by using Python's Logger objects. This patch covers the switch in all of webkitpy.tool
except the QueueEngine.

Unit tests are adjusted for these changes, moving output from expected stderr to expected logs.

* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(MockCommitQueue.run_command):
(MockCommitQueue.command_passed):
(MockCommitQueue.command_failed):
(MockCommitQueue.report_flaky_tests):
(MockCommitQueue.archive_last_test_results):
(CommitQueueTaskTest._run_through_task):
(CommitQueueTaskTest.test_success_case):
(test_fast_success_case):
(test_clean_failure):
(test_update_failure):
(test_apply_failure):
(test_validate_changelog_failure):
(test_build_failure):
(test_red_build_failure):
(test_flaky_test_failure):
(test_failed_archive):
(test_double_flaky_test_failure):
(test_test_failure):
(test_red_test_failure):
(test_very_red_tree_retry):
(test_red_tree_patch_rejection):
(test_land_failure):
* Scripts/webkitpy/tool/bot/feeders.py:
(CommitQueueFeeder._update_work_items):
(EWSFeeder.feed):
* Scripts/webkitpy/tool/bot/feeders_unittest.py:
* Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
(LayoutTestResultsReader.archive):
* Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(test_archive_last_layout_test_results):
* Scripts/webkitpy/tool/bot/sheriff.py:
* Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
(AbstractSequencedCommand.execute):
* Scripts/webkitpy/tool/commands/commandtest.py:
(CommandsTest.assert_execute_outputs):
* Scripts/webkitpy/tool/commands/download.py:
(AbstractPatchProcessingCommand._process_patch.execute):
(ProcessBugsMixin._fetch_list_of_patches_to_process):
(ProcessURLsMixin._fetch_list_of_patches_to_process):
(AbstractRolloutPrepCommand._commit_info):
* Scripts/webkitpy/tool/commands/download_unittest.py:
(AbstractRolloutPrepCommandTest.test_commit_info):
(DownloadCommandsTest.test_build):
(DownloadCommandsTest.test_build_and_test):
(test_apply_attachment):
(test_apply_from_bug):
(test_apply_watch_list):
(test_land):
(test_land_red_builders):
(test_check_style):
(test_build_attachment):
(test_land_attachment):
(test_land_from_bug):
(test_land_from_url):
(test_prepare_rollout):
(test_create_rollout):
(test_create_rollout_resolved):
(test_rollout):
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.handle_script_error.does):
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSytemTest._default_expected_stderr):
(EarlyWarningSytemTest._default_expected_logs):
(EarlyWarningSytemTest._test_testing_ews):
* Scripts/webkitpy/tool/commands/openbugs.py:
(OpenBugs.execute):
* Scripts/webkitpy/tool/commands/openbugs_unittest.py:
(OpenBugsTest.test_args_parsing):
* Scripts/webkitpy/tool/commands/perfalizer.py:
(Perfalizer.handle_unexpected_error):
* Scripts/webkitpy/tool/commands/queries.py:
(PatchesInCommitQueue.execute):
(PatchesToCommitQueue._needs_commit_queue):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(QueryCommandsTest.test_bugs_to_commit):
(QueryCommandsTest.test_patches_in_commit_queue):
(QueryCommandsTest.test_patches_to_commit_queue):
* Scripts/webkitpy/tool/commands/queues.py:
(AbstractQueue._cc_watchers):
(AbstractQueue.begin_work_queue):
(FeederQueue.handle_unexpected_error):
(CommitQueue.handle_script_error):
(AbstractReviewQueue.handle_unexpected_error):
(AbstractReviewQueue.handle_script_error):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(test_auto_retry):
* Scripts/webkitpy/tool/commands/queuestest.py:
(QueuesTest.assert_outputs):
(QueuesTest._default_begin_work_queue_stderr):
(QueuesTest):
(QueuesTest._default_begin_work_queue_logs):
(QueuesTest.assert_queue_outputs):
* Scripts/webkitpy/tool/commands/roll_unittest.py:
(RollCommandsTest.test_update_chromium_deps):
(test_update_chromium_deps_older_revision):
* Scripts/webkitpy/tool/commands/sheriffbot.py:
(SheriffBot.handle_unexpected_error):
* Scripts/webkitpy/tool/commands/stepsequence.py:
(StepSequence.run_and_handle_errors):
* Scripts/webkitpy/tool/commands/upload.py:
(AssignToCommitter._assign_bug_to_last_patch_attacher):
(AbstractPatchUploadingCommand._prepare_state):
(PostCommits.execute):
(MarkBugFixed._determine_bug_id_and_svn_revision):
(MarkBugFixed.execute):
(CreateBug.create_bug_from_commit):
(CreateBug.execute):
* Scripts/webkitpy/tool/commands/upload_unittest.py:
(test_obsolete_attachments):
(test_land_safely):
(test_mark_bug_fixed):
* Scripts/webkitpy/tool/multicommandtool.py:
(Command.check_arguments_and_execute):
(MultiCommandTool.main):
* Scripts/webkitpy/tool/multicommandtool_unittest.py:
(CommandTest.test_required_arguments):
* Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py:
(AddSvnMimetypeForPng.run):
* Scripts/webkitpy/tool/steps/applypatch.py:
(ApplyPatch.run):
* Scripts/webkitpy/tool/steps/build.py:
(Build.run):
* Scripts/webkitpy/tool/steps/checkstyle.py:
* Scripts/webkitpy/tool/steps/closebug.py:
(CloseBug.run):
* Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
(CloseBugForLandDiff.run):
* Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
(CloseBugForLandDiffTest.test_empty_state):
* Scripts/webkitpy/tool/steps/commit.py:
(Commit.run):
* Scripts/webkitpy/tool/steps/commit_unittest.py:
(CommitTest._test_check_test_expectations):
* Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
(EnsureLocalCommitIfNeeded.run):
* Scripts/webkitpy/tool/steps/obsoletepatches.py:
(ObsoletePatches.run):
* Scripts/webkitpy/tool/steps/preparechangelog.py:
(PrepareChangeLog.run):
* Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
(ReopenBugAfterRollout.run):
* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
* Scripts/webkitpy/tool/steps/runtests_unittest.py:
(RunTestsTest.test_webkit_run_unit_tests):
* Scripts/webkitpy/tool/steps/steps_unittest.py:
(StepsTest.test_update_step):
(StepsTest.test_runtests_args):
* Scripts/webkitpy/tool/steps/update.py:
(Update.run):
* Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
(UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
(UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_multipatch_bug):
* Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
(UpdateChangeLogsWithReviewer._guess_reviewer_from_bug):
(UpdateChangeLogsWithReviewer.run):
* Scripts/webkitpy/tool/steps/updatechromiumdeps.py:
(UpdateChromiumDEPS._validate_revisions):
(UpdateChromiumDEPS.run):
* Scripts/webkitpy/tool/steps/validatechangelogs.py:
(ValidateChangeLogs._check_changelog_diff):
(ValidateChangeLogs.run):
* Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
(ValidateChangeLogsTest._assert_start_line_produces_output):
* Scripts/webkitpy/tool/steps/validatereviewer.py:
(ValidateReviewer.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoadd SK_DISABLE_DITHER_32BIT_GRADIENT define, in preparation for rebaselining
reed@google.com [Mon, 26 Nov 2012 19:27:52 +0000 (19:27 +0000)]
add SK_DISABLE_DITHER_32BIT_GRADIENT define, in preparation for rebaselining
https://bugs.webkit.org/show_bug.cgi?id=103272

Reviewed by NOBODY. Unreviewed.

No behavior change, as this define already exists on the chrome side in SkUserConfig.h

* skia_webkit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Cairo] Surface should not be destroyed before its usage
rafael.lobo@openbossa.org [Mon, 26 Nov 2012 19:12:01 +0000 (19:12 +0000)]
[Cairo] Surface should not be destroyed before its usage
https://bugs.webkit.org/show_bug.cgi?id=103273

Reviewed by Brent Fulgham.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawRepaintCounter): There's some calls to get
the bits and stride from surface right after its destructions. It should
be postponed to avoid annoying bugs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderBox::computePercentageLogicalHeight should use containingBlockLogicalWidthForCo...
jchaffraix@webkit.org [Mon, 26 Nov 2012 19:07:20 +0000 (19:07 +0000)]
RenderBox::computePercentageLogicalHeight should use containingBlockLogicalWidthForContent
https://bugs.webkit.org/show_bug.cgi?id=103075

Reviewed by Ojan Vafai.

Source/WebCore:

Using the containing block's content logical block was working for most renderers but 2 renderers
were special and were broken in orthogonal writing modes:
- captions as they override containingBlockLogicalWidthForContent to return the table's logical width.
- multi-column renderers as they override availableLogicalWidth to constrain the child to the column logical width.

By switching to containingBlockLogicalWidthForContent, we got those 2 cases covered.

Tests: fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html
       fast/table/caption-orthogonal-writing-mode-sizing.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):
Updated the function to track which renderer's containing block we use and call
containingBlockLogicalWidthForContent on it.

LayoutTests:

* fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode-expected.txt: Added.
* fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html: Added.
* fast/table/caption-orthogonal-writing-mode-sizing-expected.txt: Added.
* fast/table/caption-orthogonal-writing-mode-sizing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in Frame::dispatchVisibilityStateChangeEvent.
inferno@chromium.org [Mon, 26 Nov 2012 18:58:27 +0000 (18:58 +0000)]
Crash in Frame::dispatchVisibilityStateChangeEvent.
https://bugs.webkit.org/show_bug.cgi?id=102053

Reviewed by Adam Barth.

Source/WebCore:

Child frame can go away inside webkitvisibilitychange
event handler. Store it in a ref counted vector.

Test: fast/frames/page-visibility-crash.html

* page/Frame.cpp:
(WebCore::Frame::dispatchVisibilityStateChangeEvent):

LayoutTests:

* fast/frames/page-visibility-crash-expected.txt: Added.
* fast/frames/page-visibility-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoverage testing in webkitpy should omit some paths
zandobersek@gmail.com [Mon, 26 Nov 2012 18:56:22 +0000 (18:56 +0000)]
Coverage testing in webkitpy should omit some paths
https://bugs.webkit.org/show_bug.cgi?id=103267

Reviewed by Dirk Pranke.

Omit testing coverage of any file under /usr directory and any file
that is of third party origin and was autoinstalled.

* Scripts/webkitpy/test/main.py:
(Tester._run_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse load64 instead of loadPtr to load a JSValue on JSVALUE64 platforms
yuqiang.xian@intel.com [Mon, 26 Nov 2012 18:54:50 +0000 (18:54 +0000)]
Use load64 instead of loadPtr to load a JSValue on JSVALUE64 platforms
https://bugs.webkit.org/show_bug.cgi?id=100909

Reviewed by Brent Fulgham.

This is a (trivial) fix after r132701.

* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Cairo] fillRectWithColor with Color::transparent doesn't perform anything
commit-queue@webkit.org [Mon, 26 Nov 2012 18:49:54 +0000 (18:49 +0000)]
[Cairo] fillRectWithColor with Color::transparent doesn't perform anything
https://bugs.webkit.org/show_bug.cgi?id=101911

Patch by Hurnjoo Lee <hurnjoo.lee@samsung.com> on 2012-11-26
Reviewed by Kenneth Rohde Christiansen.

fillRectWithColor with Color::transparent doesn't perform anything
because fillRectWithColor does early-return if the alpha value of
color is zero. But we expect that fill the rect with transparent color
in case the cairo_operator is CAIRO_OPERATOR_SOURCE.

Covered by existing tests.

* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::fillRectWithColor):Add condition to prevent early-return if
cairo_operator is not CAIRO_OPERATOR_OVER

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r135735.
rjkroege@chromium.org [Mon, 26 Nov 2012 18:47:18 +0000 (18:47 +0000)]
Unreviewed, rolling out r135735.
http://trac.webkit.org/changeset/135735
https://bugs.webkit.org/show_bug.cgi?id=103270

Caused breakage across the Chromium tree. (Requested by
rjkroege_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-26

* skia_webkit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoadd SK_DISABLE_DITHER_32BIT_GRADIENT define, in preparation for rebaselining
reed@google.com [Mon, 26 Nov 2012 17:43:46 +0000 (17:43 +0000)]
add SK_DISABLE_DITHER_32BIT_GRADIENT define, in preparation for rebaselining
https://bugs.webkit.org/show_bug.cgi?id=103269

Reviewed by NOBODY. Unreviewed.

No behavior change, as this define already exists on the chrome side in SkUserConfig.h

* skia_webkit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove redundant assignment in TextureMapperLayer::flushCompositingStateSelf
commit-queue@webkit.org [Mon, 26 Nov 2012 17:33:28 +0000 (17:33 +0000)]
Remove redundant assignment in TextureMapperLayer::flushCompositingStateSelf
https://bugs.webkit.org/show_bug.cgi?id=103233

Patch by Jae Hyun Park <jae.park@company100.net> on 2012-11-26
Reviewed by Noam Rosenthal.

This patch removes redundant assignment in TextureMapperLayer::flushCompositingStateSelf.

No new tests, because no change in bahavior.

* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::flushCompositingStateSelf):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOpenCL version of SourceAlpha, SourceGraphics and FETurbulence filter effects
commit-queue@webkit.org [Mon, 26 Nov 2012 17:18:25 +0000 (17:18 +0000)]
OpenCL version of SourceAlpha, SourceGraphics and FETurbulence filter effects
https://bugs.webkit.org/show_bug.cgi?id=99829

Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2012-11-26
Reviewed by Zoltan Herczeg.

This patch contains the OpenCL implementation of SourceAlpha, SourceGraphic, FETurbulence and a simple OpenCL environment.
At the moment only the Qt build system is supported
~3x speed-up (depending on hardware configuration)

* Target.pri:
* WebCore.pri:
* platform/graphics/filters/FETurbulence.h: Added platformApplyOpenCL() virtual function.
(FETurbulence):
* platform/graphics/filters/FilterEffect.cpp: Added platform specific apply.
(WebCore::FilterEffect::apply):
(WebCore):
(WebCore::FilterEffect::platformApplyOpenCL): A function to use software computing if a filter is not implemented on OpenCL. It will be deleted after all of the filters are implemented.
(WebCore::FilterEffect::clearResult):
(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::openCLImageToImageBuffer): Gets the result of the filter from the OpenCL device and converts it to ImageBuffer type.
(WebCore::FilterEffect::createOpenCLImageResult): Allocates memory on OpenCL device and if it gets an image as a parameter, it uploads the image to the OpenCL device.
(WebCore::FilterEffect::transformResultColorSpace):
* platform/graphics/filters/FilterEffect.h:
(FilterEffect):
(WebCore::FilterEffect::openCLImage):
(WebCore::FilterEffect::setOpenCLImage):
(WebCore::FilterEffect::hasResult):
* platform/graphics/filters/SourceAlpha.h:
(SourceAlpha):
* platform/graphics/filters/SourceGraphic.h:
(SourceGraphic):
* platform/graphics/gpu/opencl/FilterContextOpenCL.cpp: Added.
(WebCore):
(WebCore::FilterContextOpenCL::context): Configures the OpenCL environment.
(WebCore::FilterContextOpenCL::createOpenCLImage): Allocates memory on OpenCL device.
(WebCore::FilterContextOpenCL::openCLTransformColorSpace): OpenCL implementation of transformColorSpace.
(WebCore::FilterContextOpenCL::compileProgram):
* platform/graphics/gpu/opencl/FilterContextOpenCL.h: Added.
(WebCore):
(FilterContextOpenCL):
(WebCore::FilterContextOpenCL::deviceId):
(WebCore::FilterContextOpenCL::deviceContext):
(WebCore::FilterContextOpenCL::commandQueue):
(RunKernel):
(WebCore::FilterContextOpenCL::RunKernel::RunKernel):
(WebCore::FilterContextOpenCL::RunKernel::addArgument):
(WebCore::FilterContextOpenCL::RunKernel::run):
(WebCore::FilterContextOpenCL::kernelByName): Returns the reference of a function in the OpenCL program.
* platform/graphics/gpu/opencl/OpenCLFESourceAlpha.cpp: Added.
(WebCore):
(WebCore::SourceAlpha::platformApplyOpenCL):
* platform/graphics/gpu/opencl/OpenCLFESourceGraphic.cpp: Added.
(WebCore):
(WebCore::SourceGraphic::platformApplyOpenCL):
* platform/graphics/gpu/opencl/OpenCLFETurbulence.cpp: Added.
(WebCore):
(WebCore::FilterContextOpenCL::compileFETurbulence):
(WebCore::FilterContextOpenCL::applyFETurbulence):
(WebCore::FETurbulence::platformApplyOpenCL):
* platform/graphics/gpu/opencl/OpenCLHandle.h: Added.
(WebCore):
(OpenCLHandle):
(WebCore::OpenCLHandle::OpenCLHandle):
(WebCore::OpenCLHandle::operator cl_mem):
(WebCore::OpenCLHandle::operator=):
(WebCore::OpenCLHandle::operator UnspecifiedBoolType):
(WebCore::OpenCLHandle::handleAddress):
(WebCore::OpenCLHandle::clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed: follow up for r135720, fixing node highlight.
pfeldman@chromium.org [Mon, 26 Nov 2012 16:50:10 +0000 (16:50 +0000)]
Not reviewed: follow up for r135720, fixing node highlight.

* inspector/InspectorOverlayPage.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Crashes in compositing layout tests with AC on.
commit-queue@webkit.org [Mon, 26 Nov 2012 16:40:24 +0000 (16:40 +0000)]
[EFL] Crashes in compositing layout tests with AC on.
https://bugs.webkit.org/show_bug.cgi?id=103144

Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-11-26
Reviewed by Noam Rosenthal.

Application could leave texture packing parameters in non-zero state before
texture mapper drawing/texture uploading. To avoid crash texture upload should
specify packing parameters before each texture upload if packing is supported.

Covered by existing tests.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImport more CSS Device Adaptation layout tests
commit-queue@webkit.org [Mon, 26 Nov 2012 16:37:38 +0000 (16:37 +0000)]
Import more CSS Device Adaptation layout tests
https://bugs.webkit.org/show_bug.cgi?id=95967

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-26
Reviewed by Kenneth Rohde Christiansen.

And these are the remaining test from the Opera's CSS
Device Adaptation test suite.

* css3/device-adapt/opera/constrain-021-expected.txt: Added.
* css3/device-adapt/opera/constrain-021.xhtml: Added.
* css3/device-adapt/opera/constrain-022-expected.txt: Added.
* css3/device-adapt/opera/constrain-022.xhtml: Added.
* css3/device-adapt/opera/orientation-001-expected.txt: Added.
* css3/device-adapt/opera/orientation-001.xhtml: Added.
* css3/device-adapt/opera/orientation-002-expected.txt: Added.
* css3/device-adapt/opera/orientation-002.xhtml: Added.
* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Remove a lot of unnecessary and incorrect code causing crashes
staikos@webkit.org [Mon, 26 Nov 2012 16:32:31 +0000 (16:32 +0000)]
[BlackBerry] Remove a lot of unnecessary and incorrect code causing crashes
https://bugs.webkit.org/show_bug.cgi?id=103199

Reviewed by Yong Li.

This is the first big step to unforking this code.  It's very close to
where it needs to be now, but the first step is to get rid of the
crashes by deleting code that isn't needed and makes bad assumptions
about object lifetime.  Crashes were found by automation without
test case or reproduction steps.

* loader/blackberry/CookieJarBlackBerry.cpp:
(WebCore::cookies): delete most code
(WebCore::setCookies): delete most code

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoViewport CSS rules should not clamp values like Viewport META
commit-queue@webkit.org [Mon, 26 Nov 2012 16:22:31 +0000 (16:22 +0000)]
Viewport CSS rules should not clamp values like Viewport META
https://bugs.webkit.org/show_bug.cgi?id=103068

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-26
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

CSS Device Adaption does not clamp the length and zoom values the
same way as the Viewport META. In fact, they are not clamped at all,
but instead, we just make sure that length values are at least 1px.

Tests: css3/device-adapt/opera/constrain-018.xhtml
       css3/device-adapt/opera/constrain-019.xhtml
       css3/device-adapt/opera/constrain-023.xhtml
       css3/device-adapt/opera/constrain-024.xhtml

* dom/ViewportArguments.cpp:
(WebCore::ViewportArguments::resolve):

LayoutTests:

Imported Opera tests that makes sure we are doing the clamping right.

* css3/device-adapt/opera/constrain-018-expected.txt: Added.
* css3/device-adapt/opera/constrain-018.xhtml: Added.
* css3/device-adapt/opera/constrain-019-expected.txt: Added.
* css3/device-adapt/opera/constrain-019.xhtml: Added.
* css3/device-adapt/opera/constrain-023-expected.txt: Added.
* css3/device-adapt/opera/constrain-023.xhtml: Added.
* css3/device-adapt/opera/constrain-024-expected.txt: Added.
* css3/device-adapt/opera/constrain-024.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening: added TestExpecations failures for
rjkroege@chromium.org [Mon, 26 Nov 2012 16:12:47 +0000 (16:12 +0000)]
Unreviewed gardening: added TestExpecations failures for
media/remove-from-document.html
https://bugs.webkit.org/show_bug.cgi?id=103093

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNew baselines for test fast/backgrounds/background-opaque-images-over-color.html
junov@google.com [Mon, 26 Nov 2012 16:02:11 +0000 (16:02 +0000)]
New baselines for test fast/backgrounds/background-opaque-images-over-color.html
https://bugs.webkit.org/show_bug.cgi?id=102557

Unreviewed

* fast/backgrounds/background-opaque-images-over-color-expected.txt:
* platform/chromium-mac/fast/backgrounds/background-opaque-images-over-color-expected.png: Added.
* platform/chromium-win/fast/backgrounds/background-opaque-images-over-color-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNew baselines for test fast/backgrounds/gradient-background-leakage-2.html
junov@google.com [Mon, 26 Nov 2012 15:51:38 +0000 (15:51 +0000)]
New baselines for test fast/backgrounds/gradient-background-leakage-2.html
https://bugs.webkit.org/show_bug.cgi?id=103089

Unreviewed

* platform/chromium-linux/fast/backgrounds/gradient-background-leakage-2-expected.png: Added.
* platform/chromium-mac/fast/backgrounds/gradient-background-leakage-2-expected.png: Added.
* platform/chromium-win/fast/backgrounds/gradient-background-leakage-2-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r135640.
paroga@webkit.org [Mon, 26 Nov 2012 15:47:01 +0000 (15:47 +0000)]
Build fix for WinCE after r135640.

* wtf/DataLog.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: URLs containing '^' are improperly linked in console messages.
mkwst@chromium.org [Mon, 26 Nov 2012 15:46:41 +0000 (15:46 +0000)]
Web Inspector: URLs containing '^' are improperly linked in console messages.
https://bugs.webkit.org/show_bug.cgi?id=103248

Reviewed by Yury Semikhatsky.

Source/WebCore:

This patch adds '^' to WebInspector's regex of acceptable characters for
URLs that it knows how to display.

Test: http/tests/inspector/network/script-as-text-loading-with-caret.html

* inspector/front-end/ResourceUtils.js:
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):

LayoutTests:

* http/tests/inspector/network/script-as-text-loading-with-caret-expected.txt: Added.
* http/tests/inspector/network/script-as-text-loading-with-caret.html: Added.
* platform/chromium/http/tests/inspector/network/script-as-text-loading-with-caret-expected.txt:
    JSC vs V8. :(

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewd Gardening: updated TestExpecations for additional failures in
rjkroege@chromium.org [Mon, 26 Nov 2012 15:42:01 +0000 (15:42 +0000)]
Unreviewd Gardening: updated TestExpecations for additional failures in
media/video-preload.html
https://bugs.webkit.org/show_bug.cgi?id=103093

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix Qt minimal compilation after r135713.
yurys@chromium.org [Mon, 26 Nov 2012 15:23:45 +0000 (15:23 +0000)]
Unreviewed. Fix Qt minimal compilation after r135713.

* inspector/InspectorController.h: hid file content behind ENABLE(INSPECTOR)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: object preview does not render node id, className; logs too many funct...
pfeldman@chromium.org [Mon, 26 Nov 2012 15:17:17 +0000 (15:17 +0000)]
Web Inspector: object preview does not render node id, className; logs too many functions for jQuery.
https://bugs.webkit.org/show_bug.cgi?id=103222

Reviewed by Yury Semikhatsky.

Source/WebCore:

- Added node class name and id into the preview
- Now keeps track of properties separately from array indexes.

* inspector/InjectedScriptSource.js:
(.):
* inspector/InspectorOverlayPage.html:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
(WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreview):

LayoutTests:

* inspector/console/command-line-api-expected.txt:
* inspector/console/command-line-api-inspect-expected.txt:
* inspector/console/console-dir-expected.txt:
* inspector/console/console-format-collections-expected.txt:
* inspector/console/console-format-expected.txt:
* inspector/elements/event-listener-sidebar-expected.txt:
* inspector/elements/event-listeners-about-blank-expected.txt:
* platform/chromium-linux/inspector/console/console-format-collections-expected.txt: Removed.
* platform/chromium/inspector/console/command-line-api-inspect-expected.txt:
* platform/chromium/inspector/console/console-dir-expected.txt:
* platform/chromium/inspector/console/console-format-collections-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderSVGResourceContainer does not clear cached data on removal
fmalita@chromium.org [Mon, 26 Nov 2012 15:03:36 +0000 (15:03 +0000)]
RenderSVGResourceContainer does not clear cached data on removal
https://bugs.webkit.org/show_bug.cgi?id=102620

Reviewed by Dirk Schulze.

Source/WebCore:

RenderSVGResourceContainer::removeClient needs to also remove the client from specialized
caches, otherwise we can end up with stale references.

Test: svg/custom/stale-resource-data-crash.svg

* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::removeClient):

LayoutTests:

* svg/custom/stale-resource-data-crash-expected.txt: Added.
* svg/custom/stale-resource-data-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Make use_default_render_theme compile the right set of files
commit-queue@webkit.org [Mon, 26 Nov 2012 15:01:24 +0000 (15:01 +0000)]
[chromium] Make use_default_render_theme compile the right set of files
https://bugs.webkit.org/show_bug.cgi?id=102952

Patch by Scott Violet <sky@chromium.org> on 2012-11-26
Reviewed by Kent Tamura.

* WebKit.gyp: Adds WebRenderTheme.* and updates rules as to when to compile them.
* features.gypi: Removes use_default_render_theme default values as common.gypi sets them.
* public/default: Added.
* public/default/WebRenderTheme.h: Copy of linux/WebRenderTheme.h
* src/default: Added.
* src/default/WebRenderTheme.cpp: Copy of linux/WebRenderTheme.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][ARM] REGRESSION(r130826): It made 33 JSC test and 466 layout tests crash
ossy@webkit.org [Mon, 26 Nov 2012 14:47:40 +0000 (14:47 +0000)]
[Qt][ARM] REGRESSION(r130826): It made 33 JSC test and 466 layout tests crash
https://bugs.webkit.org/show_bug.cgi?id=98857

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-11-26
Reviewed by Zoltan Herczeg.

Implement a new version of patchableBranch32 to fix crashing JSC
tests.

* assembler/MacroAssembler.h:
(MacroAssembler):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::patchableBranch32):
(MacroAssemblerARM):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed: rolling out r135714 and r135712 for breaking debug tests.
pfeldman@chromium.org [Mon, 26 Nov 2012 14:46:14 +0000 (14:46 +0000)]
Not reviewed: rolling out r135714 and r135712 for breaking debug tests.

Source/WebCore:

* inspector/InjectedScriptSource.js:
(.):
* inspector/InspectorOverlayPage.html:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):

LayoutTests:

* inspector/console/command-line-api-expected.txt:
* inspector/console/command-line-api-inspect-expected.txt:
* inspector/console/console-dir-expected.txt:
* inspector/console/console-format-collections-expected.txt:
* inspector/console/console-format-expected.txt:
* inspector/elements/event-listener-sidebar-expected.txt:
* inspector/elements/event-listeners-about-blank-expected.txt:
* platform/chromium-linux/inspector/console/console-format-collections-expected.txt: Copied from LayoutTests/platform/chromium/inspector/console/console-format-collections-expected.txt.
* platform/chromium/inspector/console/command-line-api-inspect-expected.txt:
* platform/chromium/inspector/console/console-dir-expected.txt:
* platform/chromium/inspector/console/console-format-collections-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Win] buildfix after r135706.
zeno.albisser@digia.com [Mon, 26 Nov 2012 14:36:05 +0000 (14:36 +0000)]
[Qt][Win] buildfix after r135706.
https://bugs.webkit.org/show_bug.cgi?id=103249

The Windows implementation of GraphicsSurface cannot use
m_size anymore, as this member has been removed.
Further it needs to implement a platformSize() function.

Reviewed by Kenneth Rohde Christiansen.

* platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
(WebCore::GraphicsSurface::platformSize):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed: rolling out accidental TestExpectations change.
pfeldman@chromium.org [Mon, 26 Nov 2012 14:10:41 +0000 (14:10 +0000)]
Not reviewed: rolling out accidental TestExpectations change.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: unify agents handling in Page and Worker inspector controllers
yurys@chromium.org [Mon, 26 Nov 2012 14:06:58 +0000 (14:06 +0000)]
Web Inspector: unify agents handling in Page and Worker inspector controllers
https://bugs.webkit.org/show_bug.cgi?id=103238

Reviewed by Alexander Pavlov.

Introduced a class that represents a collection of inspector agents and allows
to call methods declared on InspectorAgentBaseInterface for all registered agents.
InspectorController and WorkerInspectorController switched to this class.

* inspector/InspectorBaseAgent.cpp:
(WebCore::InspectorAgentRegistry::append):
(WebCore):
(WebCore::InspectorAgentRegistry::setFrontend):
(WebCore::InspectorAgentRegistry::clearFrontend):
(WebCore::InspectorAgentRegistry::restore):
(WebCore::InspectorAgentRegistry::registerInDispatcher):
(WebCore::InspectorAgentRegistry::discardAgents):
* inspector/InspectorBaseAgent.h:
(InspectorAgentRegistry):
(WebCore):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::~InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::reconnectFrontend):
* inspector/InspectorController.h:
(InspectorController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: object preview does not render node id, className; logs too many funct...
pfeldman@chromium.org [Mon, 26 Nov 2012 14:01:44 +0000 (14:01 +0000)]
Web Inspector: object preview does not render node id, className; logs too many functions for jQuery.
https://bugs.webkit.org/show_bug.cgi?id=103222

Reviewed by Yury Semikhatsky.

Source/WebCore:

- Added node class name and id into the preview
- Now keeps track of properties separately from array indexes.

* inspector/InjectedScriptSource.js:
(.):
* inspector/InspectorOverlayPage.html:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
(WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreview):

LayoutTests:

* inspector/console/command-line-api-expected.txt:
* inspector/console/console-dir-expected.txt:
* inspector/console/console-format-expected.txt:
* inspector/elements/event-listener-sidebar-expected.txt:
* inspector/elements/event-listeners-about-blank-expected.txt:
* platform/chromium/inspector/console/console-dir-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [WebGL] Save WebGL extensions and restore on replay
commit-queue@webkit.org [Mon, 26 Nov 2012 13:55:16 +0000 (13:55 +0000)]
Web Inspector: [WebGL] Save WebGL extensions and restore on replay
https://bugs.webkit.org/show_bug.cgi?id=103141

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-26
Reviewed by Yury Semikhatsky.

Save WebGL extensions that were enabled by the application, and restore it before the replay.
Drive-by: remove redundant if- checks in WebGL custom function wrappers (similar to 2D canvas).
* inspector/InjectedScriptCanvasModuleSource.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHitTestResult should not be a HitTestLocation
allan.jensen@digia.com [Mon, 26 Nov 2012 13:54:02 +0000 (13:54 +0000)]
HitTestResult should not be a HitTestLocation
https://bugs.webkit.org/show_bug.cgi?id=101590

Reviewed by Sam Weinig.

Change HitTestResult from being a HitTestLocation to having a HitTestLocation.
A result of a test should not be a special case of the location of the test.

No change in functionality. No new tests.

* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::isSelected):
(WebCore::HitTestResult::spellingToolTip):
(WebCore::HitTestResult::replacedString):
* rendering/HitTestResult.h:
(WebCore::HitTestResult::isRectBasedTest):
(WebCore::HitTestResult::pointInInnerNodeFrame):
(WebCore::HitTestResult::hitTestLocation):
(HitTestResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCircular reference between Document and MediaQueryMatcher.
commit-queue@webkit.org [Mon, 26 Nov 2012 13:41:20 +0000 (13:41 +0000)]
Circular reference between Document and MediaQueryMatcher.
https://bugs.webkit.org/show_bug.cgi?id=103242

Patch by Marja Hölttä <marja@chromium.org> on 2012-11-26
Reviewed by Kenneth Rohde Christiansen.

It's not enough to clean up listeners in MediaQueryMatcher in ~Document,
since MediaQueryListListener keeps the Document alive. This caused
www.crbug.com/113983.

No new tests: No visible change in behavior (except that it doesn't leak memory).

* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::detach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: HeapProfiler: remove snapshotView reference from data-grids.
commit-queue@webkit.org [Mon, 26 Nov 2012 13:37:20 +0000 (13:37 +0000)]
Web Inspector: HeapProfiler: remove snapshotView reference from data-grids.
https://bugs.webkit.org/show_bug.cgi?id=103240

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-11-26
Reviewed by Yury Semikhatsky.

Source/WebCore:

Cleanup: remove redundant dependency.

* inspector/front-end/HeapSnapshotDataGrids.js: Do not store view ref.
* inspector/front-end/HeapSnapshotGridNodes.js:
Removed unused assignments.
* inspector/front-end/HeapSnapshotView.js:
Do not pass self to data-grids.

LayoutTests:

Directly access current view instead of getting if from the data grid.

* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening: update test expectations
commit-queue@webkit.org [Mon, 26 Nov 2012 12:40:40 +0000 (12:40 +0000)]
[EFL] Gardening: update test expectations
https://bugs.webkit.org/show_bug.cgi?id=103119

Unreviewed gardening. timeline-timer-fired-from-eval-call-site-expected.html
is passing now, other changes are just marking tests as flaky based on
the flakiness dashboard.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-26

* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGraphicsSurface should only store its size in a single place.
zeno.albisser@digia.com [Mon, 26 Nov 2012 12:32:15 +0000 (12:32 +0000)]
GraphicsSurface should only store its size in a single place.
https://bugs.webkit.org/show_bug.cgi?id=103143

Reviewed by Kenneth Rohde Christiansen.

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
    Cosmetics only.
* platform/graphics/surfaces/GraphicsSurface.cpp:
(WebCore::GraphicsSurface::size):
    Return the size as received from the platform abstraction.
(WebCore):
(WebCore::GraphicsSurface::GraphicsSurface):
* platform/graphics/surfaces/GraphicsSurface.h:
(GraphicsSurface):
    Remove data member m_size.
* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
    Always take the size of the GraphicsSurface as an argument.
(WebCore::GraphicsSurfacePrivate::size):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
    Retrieve the size from GraphicsSurfacePrivate where necessary.
(WebCore::GraphicsSurface::platformSize):
(WebCore):
(WebCore::GraphicsSurface::platformImport):
* platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
    Add a constructor that takes a window id as an argument
    for the receiving side of the GraphcisSurface.
    The GraphicsSurface can then determine its dimensions
    from the provided XWindow.
(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::size):
    Query the size of the GraphicsSurface backing from X.
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
    Retrieve the size from GraphicsSurfacePrivate where necessary.
(WebCore::GraphicsSurface::platformSize):
(WebCore):
(WebCore::GraphicsSurface::platformImport):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer] Floating reference handling fix
commit-queue@webkit.org [Mon, 26 Nov 2012 12:10:28 +0000 (12:10 +0000)]
[GStreamer] Floating reference handling fix
https://bugs.webkit.org/show_bug.cgi?id=101349

Patch by Thiago Santos <thiago.sousa.santos@collabora.com> on 2012-11-26
Reviewed by Philippe Normand.

GStreamer 0.10 and 1.0 differ when creating GstGhostPad from pad
templates, the 1.0 doesn't take ownership on the passed
GstPadTemplate, while 0.10 does. So this patch adds a
GStreamerVersioning function to handle this different approach
transparently in Webkit gstreamer elements.

Existing media tests cover this change.

* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webkit_web_audio_src_init):
* platform/graphics/gstreamer/GStreamerVersioning.cpp:
(webkitGstGhostPadFromStaticTemplate):
* platform/graphics/gstreamer/GStreamerVersioning.h:
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test platform/chromium/fast/forms/calendar-picker/week-picker-key-operations...
keishi@webkit.org [Mon, 26 Nov 2012 11:44:56 +0000 (11:44 +0000)]
Layout Test platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html is failing
https://bugs.webkit.org/show_bug.cgi?id=103225

Unreviewed.

* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html: Remove current month check because it was flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove WorkerContextExecutionProxy
haraken@chromium.org [Mon, 26 Nov 2012 11:20:49 +0000 (11:20 +0000)]
[V8] Remove WorkerContextExecutionProxy
https://bugs.webkit.org/show_bug.cgi?id=103210

Reviewed by Adam Barth.

This patch moves all methods in WorkerContextExecutionProxy
to WorkerScriptController.

Due to the dependency between WorkerContextExecutionProxy's methods,
it is a bit difficult to split this patch into pieces.
This patch simply moves methods without changing their logic.
Also this patch doesn't remove empty WorkerContextExecutionProxy.{h,cpp}
to keep the diff sane. I will address these issues in a follow-up patch.

Tests: fast/worker/*

* bindings/v8/ScriptState.cpp:
(WebCore::scriptStateFromWorkerContext):
* bindings/v8/V8Binding.cpp:
(WebCore::toV8Context):
* bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::handleEvent):
* bindings/v8/WorkerContextExecutionProxy.cpp:
* bindings/v8/WorkerContextExecutionProxy.h:
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::~WorkerScriptController):
(WebCore::WorkerScriptController::dispose):
(WebCore):
(WebCore::WorkerScriptController::initializeIfNeeded):
(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::setEvalAllowed):
(WebCore::WorkerScriptController::disableEval):
* bindings/v8/WorkerScriptController.h:
(WebCore):
(WebCore::WorkerContextExecutionState::WorkerContextExecutionState):
(WorkerContextExecutionState):
(WorkerScriptController):
(WebCore::WorkerScriptController::context):
* bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::addListener):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::SetTimeoutOrInterval):
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoText Autosizing: Add Text Autosizing APIs for WK2
commit-queue@webkit.org [Mon, 26 Nov 2012 11:16:09 +0000 (11:16 +0000)]
Text Autosizing: Add Text Autosizing APIs for WK2
https://bugs.webkit.org/show_bug.cgi?id=100633

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-11-26
Reviewed by Sam Weinig.

Source/WebKit2:

Implement basic Text Autosizing APIs for WK2.
Text Autosizing is a useful feature for mobile browsers. It adjusts the font size
of text in wide columns, and makes text more legible.
This patch adds setting APIs for Text Autosizing in WK2.

* Shared/WebPreferencesStore.h:
(WebKit):
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetTextAutosizingEnabled):
(WKPreferencesGetTextAutosizingEnabled):
* UIProcess/API/C/WKPreferences.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Tools:

Add test cases for Text Autosizing in WKPreferences.

* TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] REGRESSION(r135575): It made all tests assert
hausmann@webkit.org [Mon, 26 Nov 2012 11:06:55 +0000 (11:06 +0000)]
[Qt] REGRESSION(r135575): It made all tests assert
https://bugs.webkit.org/show_bug.cgi?id=103169

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2012-11-26
Reviewed by Simon Hausmann.

This fixes another regression introduced in r135515:
initializeWebKitQt shouldn't implicitely call initializeWebCoreQt
since it can be called from WebKit2 to initialize QStyle for testing.
This would then lead to things such as PlatformStrategies being
initialized twice.

Source/WebKit/qt:

* Api/qwebpage.cpp: Explicitely call initializeWebCoreQt().
(QWebPagePrivate::QWebPagePrivate):
* WebCoreSupport/InitWebCoreQt.cpp:
(WebKit::initializeWebKitQt):
(WebCore::initializeWebCoreQt):
* WebCoreSupport/InitWebCoreQt.h:
(WebCore):

Source/WebKit2:

* qt/MainQt.cpp: No need to initialize anything if we're not using QStyle.
(WebKit):
(main):

Tools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp: Also propagate the change to DRT this time.
(WebCore::DumpRenderTree::DumpRenderTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make sure the QGLWidget context is current when creating the TextureMapper.
zeno.albisser@digia.com [Mon, 26 Nov 2012 11:00:03 +0000 (11:00 +0000)]
[Qt] Make sure the QGLWidget context is current when creating the TextureMapper.
https://bugs.webkit.org/show_bug.cgi?id=103142

When creating the TextureMapperGL for WK1 we have to make sure
that the GL context provided by the QGLWidget is current.
Otherwise the GraphicsContext3DQt created by TextureMapperGL will pick up
the wrong pointer by calling QOpenGLContext::currentContext().

Reviewed by Simon Hausmann.

* WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Should not autofill username and password when there're more than one...
jonathan.dong@torchmobile.com.cn [Mon, 26 Nov 2012 10:53:58 +0000 (10:53 +0000)]
[BlackBerry] Should not autofill username and password when there're more than one password inputs on the same page
https://bugs.webkit.org/show_bug.cgi?id=103104

Reviewed by Rob Buis.

RIM PR: 245334
Added the oldPassword detection back into the password input
detection logic, which was removed for simplicity when imported
those pieces of codes from Chromium. And we won't do autofill
when there're more than one password field detected.

Internally reviewed by Rob Buis.

* WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::CredentialTransformData):
(WebCore::CredentialTransformData::findPasswordFormFields):
* WebCoreSupport/CredentialTransformData.h:
(CredentialTransformData):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Gardening after r135629. Skipped a newly added but failing test.
kkristof@inf.u-szeged.hu [Mon, 26 Nov 2012 10:46:59 +0000 (10:46 +0000)]
[Qt] Gardening after r135629. Skipped a newly added but failing test.
https://bugs.webkit.org/show_bug.cgi?id=103227

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-11-26
Reviewed by Csaba Osztrogonác.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(134142): ASSERT(!m_size.isZero()) hits in CoordinatedBackingStore::paintTo...
commit-queue@webkit.org [Mon, 26 Nov 2012 10:41:25 +0000 (10:41 +0000)]
REGRESSION(134142): ASSERT(!m_size.isZero()) hits in CoordinatedBackingStore::paintToTextureMapper().
https://bugs.webkit.org/show_bug.cgi?id=103217

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-26
Reviewed by Noam Rosenthal.

It is possible for CoordinatedBackingStore of directed composited image to not
have tiles, because CoordinatedImageBacking does not create tiles when the image
is invisible.

* UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:
(WebKit::CoordinatedBackingStore::paintToTextureMapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] QStyleFacadeImp build break with latest Qt 5
michael.bruning@digia.com [Mon, 26 Nov 2012 10:35:28 +0000 (10:35 +0000)]
[Qt] QStyleFacadeImp build break with latest Qt 5
https://bugs.webkit.org/show_bug.cgi?id=103198

Reviewed by Simon Hausmann.

Original patch by J-P Nurmi <jpnurmi@digia.com>.

Fixes QtWebKit build by replacing qobject_cast to
QMacStyle with calls to QObject::inherits. Also
replaces Q_WS_MAC preprocesser directives with Q_OS_MAC
for Qt 5 compatibility.

* WebCoreSupport/QStyleFacadeImp.cpp:
(WebKit::QStyleFacadeImp::getButtonMetrics):
(WebKit::QStyleFacadeImp::paintComboBox):
(WebKit::QStyleFacadeImp::paintInnerSpinButton):
(WebKit::QStyleFacadeImp::paintScrollBar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Refactoring] Some Node::isDescendant calls can be replaced with Node::contains()
morrita@google.com [Mon, 26 Nov 2012 10:21:53 +0000 (10:21 +0000)]
[Refactoring] Some Node::isDescendant calls can be replaced with Node::contains()
https://bugs.webkit.org/show_bug.cgi?id=103211

Reviewed by Daniel Bates.

A couple of call sites of isDescendant() does same as Node::contains().
This change replaces these locations with Node::contains().

No new tests, no behavior change.

* dom/Node.cpp:
(WebCore::checkAcceptChild):
* dom/Range.cpp:
(WebCore::Range::surroundContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Enable input type datetime-local
commit-queue@webkit.org [Mon, 26 Nov 2012 10:11:53 +0000 (10:11 +0000)]
[Chromium] Enable input type datetime-local
https://bugs.webkit.org/show_bug.cgi?id=103213

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-26
Reviewed by Kent Tamura.

This patch enables <input type=datetime-local> for Chromium.

No new tests. Covered by existing tests.

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore): Changed RuntimeEnabledFeatures::isInputTypeDateTimeLocalEnabled to true
if INPUT_TYPE_DATETIMELOCAL is enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Shadow DOM] Implement Element::createShadowRoot()
morrita@google.com [Mon, 26 Nov 2012 09:38:43 +0000 (09:38 +0000)]
[Shadow DOM] Implement Element::createShadowRoot()
https://bugs.webkit.org/show_bug.cgi?id=102911

Reviewed by Kentaro Hara.

Source/WebCore:

Added an API implementation and exposed it.

This is basically an alias of the ShadowRoot constructor, which
will be removed as bug 102913.

Test: fast/dom/shadow/shadow-aware-create-shdow-root.html

* bindings/gobject/GNUmakefile.am:
* dom/Element.cpp:
(WebCore::Element::createShadowRoot):
(WebCore):
* dom/Element.h:
(Element):
* dom/Element.idl:

LayoutTests:

The coverage might not seem comprehensive at a glance. However,
this is just an alias of ShadowRoot constructor and there are
bunch of test cases which cover it.

As bug 102913 will convert such callsites to use createShadowRoot(),
the API will get be covered well then.

* fast/dom/shadow/shadow-aware-create-shdow-root-expected.txt: Added.
* fast/dom/shadow/shadow-aware-create-shdow-root.html: Added.
  Further ShadowAware API will come here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed, mark platform/chromium/fast/forms/calendar-picker/week-picker...
apavlov@chromium.org [Mon, 26 Nov 2012 09:27:28 +0000 (09:27 +0000)]
[Chromium] Unreviewed, mark platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html as flaky (date-dependent).

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 26 Nov 2012 09:18:30 +0000 (09:18 +0000)]
Unreviewed GTK gardening.

Adding timeout expectation for the new a11y test added in r135680.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExtend EventDispatcher::dispatchSimulatedClick to allow sending a mouseover event
jonlee@apple.com [Mon, 26 Nov 2012 09:11:52 +0000 (09:11 +0000)]
Extend EventDispatcher::dispatchSimulatedClick to allow sending a mouseover event
https://bugs.webkit.org/show_bug.cgi?id=102610
<rdar://problem/12725663>

Reviewed by Darin Adler.

Update the dispatchSimulatedClick() to take option enums for dispatching events.

* dom/SimulatedClickOptions.h: Added. Define two options enums. One tracks which mouse
events to send. The other determines whether to force the element to repaint.

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchSimulatedClick): Refactor to use the option enums.
* dom/EventDispatcher.h:
(EventDispatcher): Update function signature.

* dom/Node.cpp: Refactor parameters to use the options enums rather than booleans.
(WebCore::Node::dispatchSimulatedClick):
* dom/Node.h:

Refactor. Remove redundant comments.
* html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::accessKeyAction):
* html/BaseClickableWithKeyInputType.cpp:
(WebCore::BaseClickableWithKeyInputType::accessKeyAction):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::accessKeyAction):
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::accessKeyAction):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::click):
(WebCore::HTMLElement::accessKeyAction):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::accessKeyAction):
* html/RadioInputType.cpp:
(WebCore::RadioInputType::handleKeydownEvent):
* html/RangeInputType.cpp:
(WebCore::RangeInputType::accessKeyAction):

Add SimulatedClickOptions.h.
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Shadow] Attaching children of a shadow host takes O(N^2) where N is the number of...
shinyak@chromium.org [Mon, 26 Nov 2012 09:07:19 +0000 (09:07 +0000)]
[Shadow] Attaching children of a shadow host takes O(N^2) where N is the number of host children
https://bugs.webkit.org/show_bug.cgi?id=103017

Reviewed by Hajime Morita.

Since ContentDistribution was just a Vector, ContentDistribution::find() took O(N). Each child of shadow host calls it.
As a result, attaching children of shadow host takes O(N^2) at all.

In this patch, we make ContentDistribution::find() O(1) amortizedly. We introduce HashMap from a Node to Vector index,
and use it for ContentDistribution::find().

No new tests, covered by existing tests.

* html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistribution::swap):
(WebCore):
(WebCore::ContentDistribution::append):
(WebCore::ContentDistribution::find):
(WebCore::ContentDistributor::distributeSelectionsTo):
* html/shadow/ContentDistributor.h:
(ContentDistribution): ContentDistribution now contains Vector and a reverse map.
(WebCore::ContentDistribution::first):
(WebCore::ContentDistribution::last):
(WebCore::ContentDistribution::at):
(WebCore::ContentDistribution::size):
(WebCore::ContentDistribution::isEmpty):
(WebCore::ContentDistribution::clear):
(WebCore::ContentDistribution::contains):
(WebCore::ContentDistribution::nodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake] Allow user specified compiler flags to take precedence
commit-queue@webkit.org [Mon, 26 Nov 2012 08:31:18 +0000 (08:31 +0000)]
[CMake] Allow user specified compiler flags to take precedence
https://bugs.webkit.org/show_bug.cgi?id=103101

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-11-26
Reviewed by Brent Fulgham.

Make sure that compiler and linker flags specified by the build system
are always prepended to the variables that can be specified by the
environment and the user as well.

* Source/cmake/OptionsCommon.cmake:
* Source/cmake/OptionsWindows.cmake:
* Source/cmake/WebKitHelpers.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Give isolated shells a lifecycle like that of main shells
commit-queue@webkit.org [Mon, 26 Nov 2012 08:10:35 +0000 (08:10 +0000)]
[V8] Give isolated shells a lifecycle like that of main shells
https://bugs.webkit.org/show_bug.cgi?id=96522

Patch by Dan Carney <dcarney@google.com> on 2012-11-26
Reviewed by Adam Barth.

Refactored the isolated shells in ScriptController
to be cleaned up the same way the main shell is.

No new tests. No change in functionality.

* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::clearForOutOfMemory):
(WebCore::ScriptController::clearForClose):
(WebCore::ScriptController::clearWindowShell):
* bindings/v8/ScriptController.h:
(ScriptController):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore::V8DOMWindowShell::clearForClose):
* bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
ryuan.choi@samsung.com [Mon, 26 Nov 2012 07:54:56 +0000 (07:54 +0000)]
Unreviewed gardening.
Unskip the fixed regressions from r135662

* platform/efl-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r135656.
commit-queue@webkit.org [Mon, 26 Nov 2012 07:50:02 +0000 (07:50 +0000)]
Unreviewed, rolling out r135656.
http://trac.webkit.org/changeset/135656
https://bugs.webkit.org/show_bug.cgi?id=103218

Made a few SVG tests crash on all platforms (Requested by
apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-25

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForFamily):
* css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFamilyValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebCore::RenderBlock::determineStartPosition crash
tasak@google.com [Mon, 26 Nov 2012 07:45:38 +0000 (07:45 +0000)]
WebCore::RenderBlock::determineStartPosition crash
https://bugs.webkit.org/show_bug.cgi?id=98993

Reviewed by Brent Fulgham.

Source/WebCore:

If we move some node and the node has some text,
InlineFlowBox::removeChild() is invoked. The method invokes
RootInlineBox::childRemoved(). childRemoved() checks whether the
removed inlinebox has the renderer of its parent's line break object.
If so, use setLineBreakInfo to make the parent's line break info to
be 0. However in RenderBlock::determineStartPosition(), the code
assume that all line break info is solved, i.e.
prevRootBox->lineBreakObj()->isText(). Since lineBreakObj() returns 0
because of removeChild(), determineStartPosition crash occurs.

Test: fast/inline/inline-box-append-child-crash.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::determineStartPosition):
Checks whether lineBreakObj() is 0 or not before using lineBreakObj().

LayoutTests:

* fast/inline/inline-box-append-child-crash-expected.txt: Added.
* fast/inline/inline-box-append-child-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: use native Element.prototype.normalize instead of custom defined Eleme...
commit-queue@webkit.org [Mon, 26 Nov 2012 06:35:57 +0000 (06:35 +0000)]
Web Inspector: use native Element.prototype.normalize instead of custom defined Element.prototype.pruneEmptyTextNodes
https://bugs.webkit.org/show_bug.cgi?id=103205

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-11-25
Reviewed by Pavel Feldman.

* inspector/front-end/DOMExtension.js:
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.applySuggestion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: remove unused DOM methods
commit-queue@webkit.org [Mon, 26 Nov 2012 06:33:08 +0000 (06:33 +0000)]
Web Inspector: remove unused DOM methods
https://bugs.webkit.org/show_bug.cgi?id=103204

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-11-25
Reviewed by Pavel Feldman.

* inspector/front-end/DOMExtension.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Remove unused Array.convert method
commit-queue@webkit.org [Mon, 26 Nov 2012 06:15:45 +0000 (06:15 +0000)]
Web Inspector: Remove unused Array.convert method
https://bugs.webkit.org/show_bug.cgi?id=103202

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-11-25
Reviewed by Daniel Bates.

* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: file upload input cannot be activated with VoiceOver
cfleizach@apple.com [Mon, 26 Nov 2012 06:07:47 +0000 (06:07 +0000)]
AX: file upload input cannot be activated with VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=100343

Reviewed by Sam Weinig.

Source/WebCore:

Simulated events were not allowed to be processed in the file input type in the DOMActivate handler.
This was a problem for accessibility clients which rely on simulated events.

The solution is to mark the UserGestureIndicator as definitely processing an event.

Test: accessibility/file-upload-button-with-axpress.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::press):

LayoutTests:

* accessibility/file-upload-button-with-axpress-expected.txt: Added.
* accessibility/file-upload-button-with-axpress.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: dispatch an event upon heap snapshot filter change
commit-queue@webkit.org [Mon, 26 Nov 2012 05:58:39 +0000 (05:58 +0000)]
Web Inspector: dispatch an event upon heap snapshot filter change
https://bugs.webkit.org/show_bug.cgi?id=103201

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-11-25
Reviewed by Pavel Feldman.

Dispatch heapSnapshotFilterChanged event so it can be received by third parties.

* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._changeFilter):
* inspector/front-end/UserMetrics.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove deprecated load-done signal
kaustubh@motorola.com [Mon, 26 Nov 2012 05:12:29 +0000 (05:12 +0000)]
Remove deprecated load-done signal
https://bugs.webkit.org/show_bug.cgi?id=72712

Reviewed by Brent Fulgham.

Remove deprecated load-done signal and migrate to load-status.

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit):
(WebKit::FrameLoaderClient::dispatchDidFinishLoad):
* webkit/webkitwebframe.cpp:
(webkit_web_frame_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-11-25 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 26 Nov 2012 01:54:54 +0000 (01:54 +0000)]
2012-11-25  Kent Tamura  <tkent@chromium.org>

        [Chromium] Fix svn:mime-type for images

        * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png: Added property svn:mime-type.
        * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png: Added property svn:mime-type.
        * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png: Added property svn:mime-type.
        * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png: Added property svn:mime-type.
        * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png: Added property svn:mime-type.
        * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png: Added property svn:mime-type.
        * platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Modified property svn:mime-type.
        * platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Modified property svn:mime-type.
        * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Modified property svn:mime-type.
        * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Modified property svn:mime-type.
        * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Modified property svn:mime-type.
        * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Modified property svn:mime-type.
        * platform/chromium-win-xp/fast/text/drawBidiText-expected.png: Modified property svn:mime-type.
        * platform/chromium-win-xp/fast/text/international/001-expected.png: Modified property svn:mime-type.
        * platform/chromium-win-xp/fast/text/international/002-expected.png: Modified property svn:mime-type.
        * platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png: Modified property svn:mime-type.
        * platform/chromium-win-xp/fast/text/international/wrap-CJK-001-expected.png: Modified property svn:mime-type.
        * platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png: Modified property svn:mime-type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Add tests for datetime/datetime-local suggestion picker
commit-queue@webkit.org [Mon, 26 Nov 2012 01:00:13 +0000 (01:00 +0000)]
[Chromium] Add tests for datetime/datetime-local suggestion picker
https://bugs.webkit.org/show_bug.cgi?id=102888

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-25
Reviewed by Kent Tamura.

Adding tests for <input type=datetime> and <input type=datetime-local> with datalist.

* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations-expected.txt: Added.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations-expected.txt: Added.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl.html: Added.
* platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar.html: Added.
* platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance.html: Added.
* platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html: Added.
* platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-min-max-attribute-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-min-max-attribute.html: Added.
* platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-mouse-operations-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-mouse-operations.html: Added.
* platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-reset-value-after-reload-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-reset-value-after-reload.html: Added.
* platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-step-attribute-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-step-attribute.html: Added.
* platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl.html: Added.
* platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar.html: Added.
* platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance.html: Added.
* platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html: Added.
* platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-min-max-attribute-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-min-max-attribute.html: Added.
* platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-mouse-operations-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-mouse-operations.html: Added.
* platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-reset-value-after-reload-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-reset-value-after-reload.html: Added.
* platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-step-attribute-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-step-attribute.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactoring: Move the content of HTMLInputElement::subtreeHasChanged to TextFieldInpu...
tkent@chromium.org [Mon, 26 Nov 2012 00:38:30 +0000 (00:38 +0000)]
Refactoring: Move the content of HTMLInputElement::subtreeHasChanged to TextFieldInputType
https://bugs.webkit.org/show_bug.cgi?id=103195

Reviewed by Kentaro Hara.

HTMLInputElement::subtreeHasChanged is called only if the input is
a text field. The code should be moved to TextFieldInputType.

No new tests. This should not change any behavior.

* html/HTMLInputElement.cpp:
- Remove unnecessary NumberInputType.h inclusion.
- Remove convertFromVisibleValue. It was used only by subtreeHasChanged.
(WebCore::HTMLInputElement::subtreeHasChanged):
Move the code to TextFieldInputType::subtreeHasChanged except
calculateAndAdjustDirectionality, which is a protected member of
HTMLElement.
* html/HTMLInputElement.h:
(HTMLInputElement): Remove convertFromVisibleValue.

* html/InputType.cpp:
Move convertFromVisibleValue to TextFieldInputType.
(WebCore::InputType::subtreeHasChanged):
Add ASSERT_NOT_REACHED.
* html/InputType.h:
(InputType): Remove convertFromVisibleValue.

* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::convertFromVisibleValue):
Moved from InputType.
(WebCore::TextFieldInputType::subtreeHasChanged):
Moved from HTMLInputElement. A latter part is moved to
didSetValueByUserEdit to be hooked by SearchInputType.
(WebCore::TextFieldInputType::didSetValueByUserEdit):
Moved from HTMLInputElement::subtreeHasChanged, and clean up the code.
* html/TextFieldInputType.h:
(TextFieldInputType):
- Move convertFromVisibleValue from InputType.
- Add didSetValueByUserEdit and subtreeHasChanged.

* html/SearchInputType.cpp:
(WebCore::SearchInputType::didSetValueByUserEdit):
Renamed from subtreeHasChanged, and calls TextFieldInputType::didSetValueByUserEdit.
* html/SearchInputType.h:
(SearchInputType): Rename subtreeHasChanged to didSetValueByUserEdit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Move WorkerExecutionContextProxy::initializeIfNeeded() to V8Initializer
haraken@chromium.org [Mon, 26 Nov 2012 00:21:24 +0000 (00:21 +0000)]
[V8] Move WorkerExecutionContextProxy::initializeIfNeeded() to V8Initializer
https://bugs.webkit.org/show_bug.cgi?id=103061

Reviewed by Adam Barth.

This is an incremental step to remove WorkerExecutionContextProxy.
This patch moves WorkerExecutionContextProxy::initializeIfNeeded() to V8Initializer.
This patch also renames methods so that the names become consistent
between the main thread and workers.

No tests. No change in behavior.

* bindings/v8/V8Initializer.cpp:
(WebCore::reportFatalErrorInMainThread):
(WebCore::messageHandlerInMainThread):
(WebCore::failedAccessCheckCallbackInMainThread):
(WebCore::V8Initializer::initializeMainThreadIfNeeded):
(WebCore::reportFatalErrorInWorker):
(WebCore):
(WebCore::messageHandlerInWorker):
(WebCore::V8Initializer::initializeWorkerIfNeeded):
* bindings/v8/V8Initializer.h:
(V8Initializer):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
* bindings/v8/WorkerContextExecutionProxy.h:
(WorkerContextExecutionProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Refactor RenderThemeEfl::ThemePartCacheEntry::reuse()
commit-queue@webkit.org [Sun, 25 Nov 2012 19:19:08 +0000 (19:19 +0000)]
[EFL] Refactor RenderThemeEfl::ThemePartCacheEntry::reuse()
https://bugs.webkit.org/show_bug.cgi?id=103189

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-25
Reviewed by Kenneth Rohde Christiansen.

Check if the entry size and type changed in
RenderThemeEfl::ThemePartCacheEntry::reuse() to avoid
useless processing if one of them did not change.

Remove useless call to cairo_surface_finish() since
we are using a smart pointer for the surface.

Resize the edge object *after* loading its content
from the theme file as it seems more logical this
way.

No new tests, no behavior change for layout tests.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::ThemePartCacheEntry::reuse):
* platform/efl/RenderThemeEfl.h:
(ThemePartCacheEntry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Get rid of resetBitmapZoomScale()
zhajiang@rim.com [Sun, 25 Nov 2012 19:06:22 +0000 (19:06 +0000)]
[BlackBerry] Get rid of resetBitmapZoomScale()
https://bugs.webkit.org/show_bug.cgi?id=103200

Patch by Jacky Jiang  <zhajiang@rim.com>.
Reviewed by Rob Buis.
Internally reviewed by Gen Mak.

PR: 235707
Right now, resetBitmapZoomScale() takes an unused paramter and
dispatches a message to end the bitmap zooming. However, the
interaction has its own state machine to start bitmap zooming when it
is active and end bitmap zooming when it is inactive. This is
expecially for pinch zoom and scroll. From WebKit side, block zoom
which will call zoomBlock when the bitmap zoom finished doesn't even
need to dispatch the useless ending message to ZoomHandler.
resetBitmapZoomScale() is basically a noop for block zoom. And likewise
that is useless for zoomToInitialScaleOnLoad(). It can also potentially
cause problem if it is used somewhere else in the future and
incidentally breaks the interaction's own state machine. So just remove
this completely.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):
* Api/WebPageClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename DynamicNodeList to LiveNodeList
rniwa@webkit.org [Sun, 25 Nov 2012 18:51:36 +0000 (18:51 +0000)]
Rename DynamicNodeList to LiveNodeList
https://bugs.webkit.org/show_bug.cgi?id=103197

Reviewed by Ojan Vafai.

Rename DynamicNodeList to LiveNodeList to match the terminology used in DOM4 working draft:
http://www.w3.org/TR/2012/WD-dom-20120405/#concept-collection-live
"A collection (either NodeList or HTMLCollection) can be either live or static".

Also rename DynamicNodeListCacheBase to LiveNodeListBase, and merge DynamicSubtreeNodeList
into LiveNodeList (old DynamicNodeList) now that the only difference between those two classes
is the former calling registerNodeListCache and unregisterNodeListCache on Document.

This patch completes the series of simplification of NodeList/HTMLCollection classes.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::getNamedItems):
* bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
* bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::opaqueRootForGC):
* dom/ChildNodeList.cpp:
(WebCore::ChildNodeList::ChildNodeList):
(WebCore::ChildNodeList::nodeMatches):
* dom/ChildNodeList.h:
* dom/ClassNodeList.cpp:
(WebCore::ClassNodeList::ClassNodeList):
* dom/ClassNodeList.h:
* dom/DOMAllInOne.cpp:
* dom/Document.cpp:
(WebCore::Document::registerNodeListCache):
(WebCore::Document::unregisterNodeListCache):
(WebCore):
* dom/Document.h:
(WebCore):
(Document):
* dom/DynamicNodeList.cpp: Removed.
* dom/DynamicNodeList.h: Removed.
* dom/LiveNodeList.cpp: Copied from Source/WebCore/dom/DynamicNodeList.cpp.
(WebCore::LiveNodeListBase::rootNode):
(WebCore::LiveNodeListBase::invalidateCache):
(WebCore::LiveNodeListBase::invalidateIdNameCacheMaps):
(WebCore::LiveNodeListBase::reportMemoryUsage):
(WebCore::LiveNodeList::namedItem):
* dom/LiveNodeList.h: Copied from Source/WebCore/dom/DynamicNodeList.h.
(WebCore::LiveNodeListBase::LiveNodeListBase):
(WebCore::LiveNodeListBase::shouldInvalidateTypeOnAttributeChange):
(WebCore::LiveNodeList::LiveNodeList):
(WebCore::LiveNodeList::~LiveNodeList):
(LiveNodeList):
* dom/MicroDataItemList.cpp:
(WebCore::MicroDataItemList::MicroDataItemList):
* dom/MicroDataItemList.h:
* dom/NameNodeList.cpp:
(WebCore::NameNodeList::NameNodeList):
* dom/NameNodeList.h:
* dom/Node.cpp:
(WebCore::shouldInvalidateNodeListCachesForAttr):
(WebCore::Document::invalidateNodeListCaches):
* dom/Node.h:
(WebCore):
* dom/NodeList.h:
(WebCore::NodeList::isLiveNodeList):
* dom/NodeRareData.h:
(NodeListsNodeData):
(WebCore::NodeListsNodeData::removeCacheWithAtomicName):
(WebCore::NodeListsNodeData::removeCacheWithName):
(WebCore::NodeListsNodeData::removeCacheWithQualifiedName):
(WebCore::NodeListsNodeData::adoptTreeScope):
* dom/PropertyNodeList.cpp:
(WebCore::PropertyNodeList::PropertyNodeList):
* dom/PropertyNodeList.h:
* dom/TagNodeList.cpp:
(WebCore::TagNodeList::TagNodeList):
* dom/TagNodeList.h:
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::LiveNodeListBase::iterateForNextNode):
(WebCore::LiveNodeListBase::itemBeforeOrAfter):
(WebCore::LiveNodeListBase::itemBefore):
(WebCore::LiveNodeListBase::itemAfter):
(WebCore::LiveNodeListBase::isLastItemCloserThanLastOrCachedItem):
(WebCore::LiveNodeListBase::isFirstItemCloserThanCachedItem):
(WebCore::LiveNodeListBase::setItemCache):
(WebCore::LiveNodeListBase::length):
(WebCore::LiveNodeListBase::item):
(WebCore::LiveNodeListBase::itemBeforeOrAfterCachedItem):
* html/HTMLCollection.h:
* html/LabelsNodeList.cpp:
(WebCore::LabelsNodeList::LabelsNodeList):
* html/LabelsNodeList.h:
* html/RadioNodeList.cpp:
(WebCore::RadioNodeList::RadioNodeList):
* html/RadioNodeList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChanging position:relative to position:static results in mis-positioned div
robert@webkit.org [Sun, 25 Nov 2012 18:35:10 +0000 (18:35 +0000)]
Changing position:relative to position:static results in mis-positioned div
https://bugs.webkit.org/show_bug.cgi?id=26397

Reviewed by Ojan Vafai.

Source/WebCore:

When a block changes position from relative to static it is no longer the containing block for any
positioned objects it may have. If any of those positioned objects actually have a position specified
they are going to need a layout as their new containing block will likely have a different location they
need to offset from. Positioned objects without a specified position always get a layout anyway
in layoutPositionedObjects() so no need to worry about them in this situation.

Test: fast/block/abspos-child-container-changes-from-relative-to-static-expected.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::removePositionedObjects):
* rendering/RenderBlock.h:
(RenderBlock):

LayoutTests:

* fast/block/abspos-child-container-changes-from-relative-to-static-expected.html: Added
* fast/block/abspos-child-container-changes-from-relative-to-static.html: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] TiledBackingStore: page contents is scaled wrongly
commit-queue@webkit.org [Sun, 25 Nov 2012 18:30:14 +0000 (18:30 +0000)]
[WK2] TiledBackingStore: page contents is scaled wrongly
https://bugs.webkit.org/show_bug.cgi?id=103090

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-25
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Before this change the page contents scaling in PageViewportController was
defined all the times by m_rawAttributes.initialScale. If initial scale had not
been specified in the viewport meta tag it was set to m_minimumScaleToFit inside
PageViewportController::didChangeViewportAttributes().

The problem was that m_minimumScaleToFit could have wrong value as contents size
might have not be updated by the time PageViewportController::didChangeViewportAttributes()
was invoked.

The solution is to use m_minimumScaleToFit for contents scaling if initial scale
is not specified in the viewport meta tag, as it is updated all the time.
Also a flag m_initiallyFitToViewport is added to PageViewportController to detect
whether m_minimumScaleToFit should be used for scaling.

* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::didChangeContentsSize):
(WebKit::PageViewportController::pageTransitionViewportReady):
(WebKit::PageViewportController::didChangeViewportAttributes):
* UIProcess/PageViewportController.h:
(PageViewportController):

LayoutTests:

Added new layout test to verify that viewport 'width' descriptor does not
affect contents width of next loaded page.

* css3/device-adapt/resources/check-contents-width.html: Added.
* css3/device-adapt/viewport-width-not-affecting-next-page-expected.txt: Added.
* css3/device-adapt/viewport-width-not-affecting-next-page.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake renderer construction less generic
antti@apple.com [Sun, 25 Nov 2012 16:53:44 +0000 (16:53 +0000)]
Make renderer construction less generic
https://bugs.webkit.org/show_bug.cgi?id=103175

Reviewed by Ojan Vafai.

The renderer construction code currently operates on Nodes and is very generic. In reality
only Element and Text nodes can have renderers and the Text case is much simpler.

This patch separates the Text and Element renderer construction paths and makes it statically
known that other Node types can't have renderers. Less generic code is less branchy and enables
further optimizations.

* dom/CharacterData.cpp:
(WebCore::CharacterData::parserAppendData):
(WebCore::CharacterData::setDataAndUpdate):
(WebCore):
(WebCore::CharacterData::rendererIsNeeded):
(WebCore::CharacterData::createRenderer):

    Only Text subclass of CharacterData can have renderers.

* dom/CharacterData.h:
(CharacterData):
* dom/ContainerNode.h:
(WebCore::ContainerNode::childShouldCreateRenderer):

    Move childShouldCreateRenderer from Node to ContainerNode.

(ContainerNode):
* dom/Element.cpp:
(WebCore::Element::rendererIsNeeded):
(WebCore):
(WebCore::Element::attach):
(WebCore::Element::childShouldCreateRenderer):
* dom/Element.h:

    Move rendererIsNeeded and createRenderer from Node to Element.

(Element):
* dom/Node.cpp:
(WebCore::Node::attach):
(WebCore):
* dom/Node.h:
(Node):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
(WebCore::NodeRenderingContext::createRendererForTextIfNeeded):

    Separate the Element and Text renderer creation paths. Both are less branchy.
    The Text path is much simpler and avoids a bunch of virtual calls.

(WebCore):
* dom/NodeRenderingContext.h:
(NodeRenderingContext):
* dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):
(WebCore::Text::createTextRendererIfNeeded):
(WebCore):
(WebCore::Text::createTextRenderer):
(WebCore::Text::attach):
(WebCore::Text::updateTextRenderer):
* dom/Text.h:

        Add non-virtual Text specific functions.

(WebCore):
(Text):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r135493): HTMLCollection and DynamicNodeList have two vtable pointers
rniwa@webkit.org [Sun, 25 Nov 2012 08:01:28 +0000 (08:01 +0000)]
REGRESSION(r135493): HTMLCollection and DynamicNodeList have two vtable pointers
https://bugs.webkit.org/show_bug.cgi?id=103096

Reviewed by Sam Weinig.

Co-authored by Ilya Tikhonovsky.

Made DynamicNodeListCacheBase inherit from NodeList. While HTMLCollection doesn't inherit
from NodeList in IDL, it makes a lot of sense for the C++ implementation to do so via
DynamicNodeListCacheBase since HTMLCollection and live NodeList share a lot of code in
DynamicNodeListCacheBase.

This lets remove proxies for item() and length() in DynamicNodeList and HTMLCollection
and directly implement them in DynamicNodeListCacheBase which used to provide itemCommon()
and lengthCommon().

Also renamed NodeList::itemWithName() to NodeList::namedItem() to match HTMLCollection's
naming convention.

Finally, removed reportMemoryUsage in DynamicNodeList::reportMemoryUsage since DynamicNodeList
now uses single inheritance.

* bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeList::canGetItemsForName): Calls namedItem, which has been renamed from
itemWithName.
(WebCore::JSNodeList::nameGetter): Ditto.
* bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::namedPropertyGetter): Ditto.
* bindings/v8/custom/V8NamedNodesCollection.cpp:
(WebCore::V8NamedNodesCollection::namedItem): Renamed from itemWithName.
* bindings/v8/custom/V8NamedNodesCollection.h:
* dom/ChildNodeList.cpp:
(WebCore::ChildNodeList::nodeMatches): Updated comment.
* dom/DynamicNodeList.cpp:
(WebCore::DynamicNodeList::namedItem): Renamed from itemWithName.
* dom/DynamicNodeList.h:
(DynamicNodeListCacheBase): Inhertis from NodeList and renamed lengthCommon and itemCommon
to virtual length and item respectively.
(DynamicNodeList): Now inherits from just DynamicNodeListCacheBase instead of NodeList
and DynamicNodeListCacheBase since the former now inhertis from NodeList. Also removed
length() and item() since they're implemented in DynamicNodeListCacheBase now and renamed
itemWithName() to namedItem() to match HTMLCollection's naming convention.
* dom/NodeList.h:
(NodeList::namedItem): Renamed from itemWithName. Note that this member function is not
exposed via IDL. It's merely used in the binding code.
* dom/StaticHashSetNodeList.cpp:
(WebCore::StaticHashSetNodeList::namedItem): Ditto.
* dom/StaticHashSetNodeList.h:
(StaticHashSetNodeList::namedItem): Ditto.
* dom/StaticNodeList.cpp:
(WebCore::StaticNodeList::namedItem): Ditto.
* dom/StaticNodeList.h:
(StaticNodeList::namedItem): Ditto.
* html/HTMLCollection.cpp:
(WebCore::DynamicNodeListCacheBase::length): Renamed from lengthCommon.
(WebCore::DynamicNodeListCacheBase::item): Renamed from itemCommon.
* html/HTMLCollection.h:
(HTMLCollection): Inherits from DynamicNodeListCacheBase since DynamicNodeListCacheBase
is already RefCount'ed and NodeList, from which DynamicNodeListCacheBase inherits,
inherits from ScriptWrappable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium should use TCMalloc on Mac to go fast
abarth@webkit.org [Sun, 25 Nov 2012 07:25:16 +0000 (07:25 +0000)]
Chromium should use TCMalloc on Mac to go fast
https://bugs.webkit.org/show_bug.cgi?id=102866

Reviewed by Eric Seidel.

This patch enables TCMalloc for some WebKit objects. It improves
dom-modify on Mac by 5-10%.

On non-Mac platforms, Chromium already uses TCMalloc throughout the
project. Unfortunately, we haven't yet figured out how to turn TCMalloc
on globally on Mac because the approach we use for other platforms makes
some OS X APIs sad.

The next best thing would be to enable TCMalloc for WebKit by
overriding the global new and delete operator, as is done on apple-mac
and other platforms. Unfortunately, we cannot use that approach either
because the Chromium WebKit API is not memory tight.

Fortunately, WebKit has a mechanism for selectively enabling TCMalloc
for a selection of objects by overriding the new and delete operators
on those objects. This patch opts chromium-mac into that scheme by
setting the appropriate preprocessor macros.

* WTF.gyp/WTF.gyp:
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSubstitute "use" for "user" in sentence about naming convention for
dbates@webkit.org [Sun, 25 Nov 2012 04:49:14 +0000 (04:49 +0000)]
Substitute "use" for "user" in sentence about naming convention for
enum members so that it reads well.

* coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Find-on-page keeps stale pointer
commit-queue@webkit.org [Sun, 25 Nov 2012 04:13:29 +0000 (04:13 +0000)]
[BlackBerry] Find-on-page keeps stale pointer
https://bugs.webkit.org/show_bug.cgi?id=103190

Patch by Andy Chen <andchen@rim.com> on 2012-11-24
Reviewed by Rob Buis.

Find on page: pendingScopingEffort stores stale pointer when frames unload,
we need to cancel those scoping efforts.
PR 250807.

Internally reviewed by Yongxin Dai and Mike Fenton.

* WebKitSupport/InPageSearchManager.cpp:
(InPageSearchManager::DeferredScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::frameUnloaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Refactor RenderThemeEfl::paintThemePart()
commit-queue@webkit.org [Sun, 25 Nov 2012 02:52:20 +0000 (02:52 +0000)]
[EFL] Refactor RenderThemeEfl::paintThemePart()
https://bugs.webkit.org/show_bug.cgi?id=103192

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-24
Reviewed by Kenneth Rohde Christiansen.

Refactor RenderThemeEfl::paintThemePart() so that:
- Some C'ism is removed
- RTL related code is moved to applyEdjeRTLState()
- evas_render() is called instead of evas_render_updates()
  to avoid creating uselessly update rects.

No new tests, no behavior change for layout tests.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::applyEdjeRTLState):
(WebCore):
(WebCore::RenderThemeEfl::paintThemePart):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Layout test comes to crash on WK1
commit-queue@webkit.org [Sun, 25 Nov 2012 02:38:09 +0000 (02:38 +0000)]
[EFL] Layout test comes to crash on WK1
https://bugs.webkit.org/show_bug.cgi?id=103170

Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-11-24
Reviewed by Kenneth Rohde Christiansen.

Switch off accelerated compositing for WK1 because GraphicsContext3D is
missing direct rendering implementation that is required for EFL WK1.

* ewk/ewk_view.cpp:
(_ewk_view_priv_new):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove traces of MediaControlRootElement
commit-queue@webkit.org [Sun, 25 Nov 2012 02:22:20 +0000 (02:22 +0000)]
[chromium] Remove traces of MediaControlRootElement
https://bugs.webkit.org/show_bug.cgi?id=103174

Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-11-24
Reviewed by Adam Barth.

Now that nothing is using MediaControlRootElement any more,
we can remove the FIXME and MediaControlRootElement enum left
over from bug 88871.

* public/WebContextMenuData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Stop the mess with DECLARE_EWK_VIEW_CALLBACK arg type definition
commit-queue@webkit.org [Sun, 25 Nov 2012 02:18:08 +0000 (02:18 +0000)]
[EFL][WK2] Stop the mess with DECLARE_EWK_VIEW_CALLBACK arg type definition
https://bugs.webkit.org/show_bug.cgi?id=103187

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-24
Reviewed by Kenneth Rohde Christiansen.

Now the client should pass to DECLARE_EWK_VIEW_CALLBACK macro exacly the
same arg type s/he wants to have in the Ewk_View callback.

* UIProcess/API/efl/EwkViewCallbacks.h:
(EvasObjectHolder):
(EwkViewCallbacks::EvasObjectHolder::EvasObjectHolder):
(EwkViewCallbacks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Avoid access violation when frame is NULL.
bfulgham@webkit.org [Sat, 24 Nov 2012 23:05:07 +0000 (23:05 +0000)]
[WinCairo] Avoid access violation when frame is NULL.
https://bugs.webkit.org/show_bug.cgi?id=68753

BitmapImage::drawFrameMatchingSourceSize causes an access violation
if BitmapImage::frameAtIndex returns NULL. (Found by David Delaune).

Reviewed by Simon Fraser.

* platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::drawFrameMatchingSourceSize): Check for null
cairo_surface_t pointer and avoid dereferencing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Refactor RenderThemeEfl::getThemePartFromCache()
commit-queue@webkit.org [Sat, 24 Nov 2012 22:25:11 +0000 (22:25 +0000)]
[EFL] Refactor RenderThemeEfl::getThemePartFromCache()
https://bugs.webkit.org/show_bug.cgi?id=103186

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-24
Reviewed by Kenneth Rohde Christiansen.

Refactor getThemePartFromCache() so that a list is used
for the cache instead of a vector. The function moves
items to the head of the container which is much more
efficient with a list than a vector.

The list ordering is also slightly altered so that the
cached parts that were used last come first. Previously,
they were sorted by creation time which may cause an
item to be removed from the cache because it is older
even if is was used recently.

This patch also gets rid of some code duplication at the
end of the function.

No new tests, no behavior change.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::ThemePartCacheEntry::create): Return
a smart pointer instead of a raw pointer.
(WebCore::RenderThemeEfl::getThemePartFromCache):
(WebCore::RenderThemeEfl::clearThemePartCache): Rename
flushThemePartCache to clearThemePartCache for clarity.
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::RenderThemeEfl):
(WebCore::RenderThemeEfl::~RenderThemeEfl):
* platform/efl/RenderThemeEfl.h:
(ThemePartCacheEntry):
(RenderThemeEfl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] RTSP should use the same MediaDocument as HTTP videos.
commit-queue@webkit.org [Sat, 24 Nov 2012 20:34:40 +0000 (20:34 +0000)]
[BlackBerry] RTSP should use the same MediaDocument as HTTP videos.
https://bugs.webkit.org/show_bug.cgi?id=103185
RIM PR 250114

Patch by Liam Quinn <lquinn@rim.com> on 2012-11-24
Reviewed by George Staikos.

Make our MediaPlayer implementation indicate that it supports RTSP. That way, DOMImplementation::createDocument will create the same MediaDocument as is used for HTTP videos.

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::supportsType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135657 268f45cc-cd09-0410-ab3c-d52691b4dbfc