WebKit-https.git
11 years ago2009-07-21 Jian Li <jianli@chromium.org>
jianli@chromium.org [Tue, 21 Jul 2009 22:54:58 +0000 (22:54 +0000)]
2009-07-21  Jian Li  <jianli@chromium.org>

        Fix the incorrect patch being landed for bug 27516 that has already been reviewed.
        https://bugs.webkit.org/show_bug.cgi?id=27516

        * workers/WorkerContext.h:
        (WebCore::WorkerContext::setOnerror):
        (WebCore::WorkerContext::onerror):
        * workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Jian Li <jianli@chromium.org>
jianli@chromium.org [Tue, 21 Jul 2009 22:44:41 +0000 (22:44 +0000)]
2009-07-21  Jian Li  <jianli@chromium.org>

        Reviewed by David Levin.

        Add onerror to WorkerContext.
        https://bugs.webkit.org/show_bug.cgi?id=27516

        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::mark):
        * workers/WorkerContext.h:
        (WebCore::WorkerContext::setOnerror):
        (WebCore::WorkerContext::onerror):
        * workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Yong Li <yong.li@torchmobile.com>
treat@webkit.org [Tue, 21 Jul 2009 22:42:21 +0000 (22:42 +0000)]
2009-07-21  Yong Li  <yong.li@torchmobile.com>

        Reviewed by George Staikos.

        https://bugs.webkit.org/show_bug.cgi?id=27509
        Add font-related files for the WinCE port.

        Written by Yong Li <yong.li@torchmobile.com>

        * platform/graphics/wince/FontCacheWince.cpp: Added.
        * platform/graphics/wince/FontCustomPlatformData.cpp: Added.
        * platform/graphics/wince/FontCustomPlatformData.h: Added.
        * platform/graphics/wince/FontPlatformData.cpp: Added.
        * platform/graphics/wince/FontPlatformData.h: Added.
        * platform/graphics/wince/FontWince.cpp: Added.
        * platform/graphics/wince/GlyphPageTreeNodeWince.cpp: Added.
        * platform/graphics/wince/SimpleFontDataWince.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the Windows build, and update the comment on top now that wx uses WebCorePrefix...
kevino@webkit.org [Tue, 21 Jul 2009 21:11:09 +0000 (21:11 +0000)]
Fix the Windows build, and update the comment on top now that wx uses WebCorePrefix.h too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCorePrefix.h build fixes for non-Mac and wx / CURL builds.
kevino@webkit.org [Tue, 21 Jul 2009 20:55:03 +0000 (20:55 +0000)]
WebCorePrefix.h build fixes for non-Mac and wx / CURL builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix. Missing header added.
kevino@webkit.org [Tue, 21 Jul 2009 20:52:35 +0000 (20:52 +0000)]
wx build fix. Missing header added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Tue, 21 Jul 2009 20:45:48 +0000 (20:45 +0000)]
2009-07-21  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by David Levin.

        We can't match implementation file and primary header exactly
        since we have so many files in WebKit where the port suffix
        is appended to the filename.

        Example: FooQt.cpp and the primary header is Foo.h.

        * Scripts/modules/cpplint.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 21 Jul 2009 20:35:39 +0000 (20:35 +0000)]
2009-07-21  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        All DOMConstructorObjects should hold a pointer to the JSDOMGlobalObject
        https://bugs.webkit.org/show_bug.cgi?id=27478

        This is just moving code.
        I've added two new classes: DOMObjectWithGlobalPointer and DOMConstructorWithDocument.

        DOMObjectWithGlobalPointer is a new baseclass for DOMConstructorObject.
        (It's a baseclass because eventually all DOMObjects will have a global pointer, but
        I'll be moving them onto DOMObjectWithGlobalPointer in stages.)

        DOMConstructorWithDocument is a new baseclass for the 3 constructor objects
        which require a backpointer to the Document to function.  I made this a subclass of
        DOMConstructorObject to make clear that most constructors can hold no-such assumptions
        about having a back-pointer to the Document (since many constructors can be used from Workers).

        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::JSAudioConstructor::JSAudioConstructor):
        * bindings/js/JSAudioConstructor.h:
        * bindings/js/JSDOMBinding.h:
        (WebCore::DOMObjectWithGlobalPointer::globalObject):
        (WebCore::DOMObjectWithGlobalPointer::scriptExecutionContext):
        (WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):
        (WebCore::DOMObjectWithGlobalPointer::mark):
        (WebCore::DOMConstructorObject::DOMConstructorObject):
        (WebCore::DOMConstructorWithDocument::document):
        (WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
        * bindings/js/JSImageConstructor.cpp:
        (WebCore::JSImageConstructor::JSImageConstructor):
        * bindings/js/JSImageConstructor.h:
        * bindings/js/JSMessageChannelConstructor.cpp:
        (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
        * bindings/js/JSMessageChannelConstructor.h:
        * bindings/js/JSOptionConstructor.cpp:
        (WebCore::JSOptionConstructor::JSOptionConstructor):
        * bindings/js/JSOptionConstructor.h:
        * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
        (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
        * bindings/js/JSWebKitPointConstructor.cpp:
        (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
        * bindings/js/JSWorkerConstructor.cpp:
        (WebCore::JSWorkerConstructor::JSWorkerConstructor):
        * bindings/js/JSXMLHttpRequestConstructor.cpp:
        (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
        * bindings/js/JSXMLHttpRequestConstructor.h:
        * bindings/js/JSXSLTProcessorConstructor.cpp:
        (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Jakob Petsovits <jakob.petsovits@torchmobile.com>
levin@chromium.org [Tue, 21 Jul 2009 20:06:15 +0000 (20:06 +0000)]
2009-07-21  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

        Reviewed by David Levin.

        Add checks for switch statement indentation to cpplint.
        https://bugs.webkit.org/show_bug.cgi?id=27508

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Kenneth Rohde Christiansen <kenneth@webkit.org>
kenneth@webkit.org [Tue, 21 Jul 2009 19:43:08 +0000 (19:43 +0000)]
2009-07-21 Kenneth Rohde Christiansen <kenneth@webkit.org>

        Reviewed by Adam Treat.

        Feature request: cpplint should check for braces - rule 2
        https://bugs.webkit.org/show_bug.cgi?id=27497

        Add the requested feature: Make sure { is on the same line
        as the foreach "keyword".

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Robert Agoston <Agoston.Robert@stud.u-szeged.hu>
levin@chromium.org [Tue, 21 Jul 2009 19:18:48 +0000 (19:18 +0000)]
2009-07-21  Robert Agoston  <Agoston.Robert@stud.u-szeged.hu>

        Reviewed by David Levin.

        Fixed #undef typo.
        https://bugs.webkit.org/show_bug.cgi?id=27506

        * bytecode/Opcode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 James Hawkins <jhawkins@google.com>
levin@chromium.org [Tue, 21 Jul 2009 19:18:43 +0000 (19:18 +0000)]
2009-07-21  James Hawkins  <jhawkins@google.com>

        Reviewed by David Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=27453
        Initialize isInt when creating a CSSParserValue for a function.

        No change in behavior, so no tests.

        * css/CSSFunctionValue.cpp:
        (WebCore::CSSFunctionValue::parserValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Jens Alfke <snej@google.com>
levin@chromium.org [Tue, 21 Jul 2009 19:18:39 +0000 (19:18 +0000)]
2009-07-20  Jens Alfke  <snej@google.com>

         Reviewed by David Levin.

         Bug 27448: [Chromium] On Mac, arrow keys should cause Select to pop up its menu.
         Mac build of Chromium doesn't follow Mac HI guidelines to pop up the menu when
         an arrow key is pressed.
         https://bugs.webkit.org/show_bug.cgi?id=27448

         No new tests; affects only control response to user input.

         * dom/SelectElement.cpp:
         Changed definition of ARROW_KEYS_POP_MENU to make it true in Mac Chromium,
         so it will behave compatibly with Mac HI guidelines on pop-up menus.
         It's not possible to have PLATFORM(MAC) be true in the Mac build of Chromium.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Paul Godavari <paul@chromium.org>
levin@chromium.org [Tue, 21 Jul 2009 19:18:34 +0000 (19:18 +0000)]
2009-07-21  Paul Godavari  <paul@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] popup menus can crash when the selected index is -1
        https://bugs.webkit.org/show_bug.cgi?id=27275

        Crash reports from users indicate a crash can occur when PopupListBox::isSelectableItem
        is passed an index of less than 0 (which is possible under certain circumstances). This
        change prevents such a value from causing a crash by enforcing valid index values passed
        by all callers of isSelectableItem. isSelectableItem is now a private method of
        PopupListBox, as there are no external callers.

        Also cleaned up a small amount of code for style and grammar errors.

        No automatic test is provided since we cannot send events to the child window used by
        the popup menu.

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::acceptIndex):
        (WebCore::PopupListBox::selectIndex):
        (WebCore::PopupListBox::isSelectableItem):
        (WebCore::PopupListBox::selectPreviousRow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix. Don't include winsock2.h on wx, it conflicts with wx's inclusion of...
kevino@webkit.org [Tue, 21 Jul 2009 19:00:07 +0000 (19:00 +0000)]
wx build fix. Don't include winsock2.h on wx, it conflicts with wx's inclusion of winsock.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Jakob Petsovits <jakob.petsovits@torchmobile.com>
treat@webkit.org [Tue, 21 Jul 2009 18:21:59 +0000 (18:21 +0000)]
2009-07-20  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

        Reviewed by David Levin.

        Add checks for namespace indentation to cpplint.
        https://bugs.webkit.org/show_bug.cgi?id=27461

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Tue, 21 Jul 2009 18:16:52 +0000 (18:16 +0000)]
2009-07-20  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by David Levin.

        Add cpplint check for proper include order
        https://bugs.webkit.org/show_bug.cgi?id=27462

        Add a new check to cpplint to flag cases where the include section of a file
        does not match the mandated include order and style of the Webkit coding style
        guidelines.

        Add associated tests.

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Roll out r46153, r46154, and r46155
aroben@apple.com [Tue, 21 Jul 2009 18:13:11 +0000 (18:13 +0000)]
    Roll out r46153, r46154, and r46155

        These changes were causing build failures and assertion failures on
        Windows.

JavaScriptCore:

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * runtime/JSArray.cpp:
        * runtime/StringPrototype.cpp:
        * runtime/UString.cpp:
        * runtime/UString.h:
        * wtf/FastMalloc.cpp:
        * wtf/FastMalloc.h:
        * wtf/Platform.h:
        * wtf/PossiblyNull.h: Removed.

WebCore:

        * ForwardingHeaders/wtf/PossiblyNull.h: Removed.
        * platform/graphics/cg/ImageBufferCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Jian Li <jianli@chromium.org>
jianli@chromium.org [Tue, 21 Jul 2009 17:34:52 +0000 (17:34 +0000)]
2009-07-21  Jian Li  <jianli@chromium.org>

        Reviewed by Eric Seidel.

        Implement ErrorEvent API.
        https://bugs.webkit.org/show_bug.cgi?id=27387

        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS):
        * dom/ErrorEvent.cpp: Added.
        * dom/ErrorEvent.h: Added.
        * dom/ErrorEvent.idl: Added.
        * dom/Event.cpp:
        (WebCore::Event::isErrorEvent):
        * dom/Event.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Priit Laes <plaes@plaes.org>
kov@webkit.org [Tue, 21 Jul 2009 17:14:20 +0000 (17:14 +0000)]
2009-07-21  Priit Laes  <plaes@plaes.org>

        Reviewed by Gustavo Noronha.

        [Gtk] Searching in thepiratebay.org doesn't work with more than 1 word
        https://bugs.webkit.org/show_bug.cgi?id=24602

        Remove workaround required for <=libsoup-2.26.1

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::restartedCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 21 Jul 2009 17:09:28 +0000 (17:09 +0000)]
2009-07-21  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        V8IsolatedWorld keeps a handle to a disposed context
        https://bugs.webkit.org/show_bug.cgi?id=27397

        Make a copy of the context handle before making it weak.  We don't want
        to make the original handle weak because we want it to survive for the
        length of the V8IsolatedWorld::evaluate method.

        * bindings/v8/V8IsolatedWorld.cpp:
        (WebCore::V8IsolatedWorld::V8IsolatedWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 21 Jul 2009 16:50:50 +0000 (16:50 +0000)]
2009-07-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Add ability to evaluate selection while on break point.

        https://bugs.webkit.org/show_bug.cgi?id=27502

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._loaded):
        (WebInspector.SourceFrame.prototype._documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 21 Jul 2009 16:42:39 +0000 (16:42 +0000)]
2009-07-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        WebInspector: Special case ConsolePanel opening since
        it is a 'fast view'.

        https://bugs.webkit.org/show_bug.cgi?id=27493

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setWindowVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix. Adding isSpeaking() to ContextMenuClientWx.
kevino@webkit.org [Tue, 21 Jul 2009 15:13:08 +0000 (15:13 +0000)]
wx build fix. Adding isSpeaking() to ContextMenuClientWx.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Volker Hilsheimer <volker.hilsheimer@nokia.com>
hausmann@webkit.org [Tue, 21 Jul 2009 13:40:32 +0000 (13:40 +0000)]
2009-07-21  Volker Hilsheimer <volker.hilsheimer@nokia.com>

        Reviewed by Simon Hausmann.

        Various improvements to the API documentation.

        * Updated link to W3c Database spec
        * Formatting fixes, cleanups
        * Add missing \since 4.6 tags to QWebPage::frameAt
        * Extend QWebDatabase and QWebSecurityOrigin docs.

        * Api/qwebdatabase.cpp:
        * Api/qwebpage.cpp:
        * Api/qwebsecurityorigin.cpp:
        * Api/qwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Tue, 21 Jul 2009 13:10:56 +0000 (13:10 +0000)]
2009-07-21  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Rubber-stamped by Simon Hausmann.

        Remove preliminary-tag from QWebElement

        * Api/qwebelement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Tue, 21 Jul 2009 12:42:50 +0000 (12:42 +0000)]
2009-07-21  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Skip fast/loader/non-html-load-event.html for the Qt DRT as it requires
        support for loading PDF documents.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
kenneth@webkit.org [Tue, 21 Jul 2009 12:02:38 +0000 (12:02 +0000)]
WebCore:

2009-07-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Eric Seidel.

        Fix Qt code to follow the WebKit Coding Style.

        * platform/graphics/qt/FontQt.cpp:
        (WebCore::qstring):
        (WebCore::fixSpacing):
        * platform/graphics/qt/FontQt43.cpp:
        (WebCore::generateComponents):
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::cursorToX):
        * platform/graphics/qt/GradientQt.cpp:
        (WebCore::Gradient::platformGradient):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::toQtFillRule):
        (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
        (WebCore::GraphicsContext::~GraphicsContext):
        (WebCore::GraphicsContext::getCTM):
        (WebCore::GraphicsContext::concatCTM):
        (WebCore::GraphicsContext::getWindowsContext):
        * platform/graphics/qt/IconQt.cpp:
        (WebCore::Icon::paint):
        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::ReadContext::read):
        (WebCore::ImageDecoderQt::ReadContext::readImageLines):
        (WebCore::ImageDecoderQt::setData):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::Image::drawPattern):
        (WebCore::BitmapImage::draw):
        * platform/graphics/qt/ImageSourceQt.cpp:
        (WebCore::ImageSource::frameDurationAtIndex):
        (WebCore::ImageSource::frameHasAlphaAtIndex):
        (WebCore::ImageSource::frameIsCompleteAtIndex):
        * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::create):
        (WebCore::MediaPlayerPrivate::bytesLoaded):
        (WebCore::MediaPlayerPrivate::updateStates):
        * platform/graphics/qt/PathQt.cpp:
        (WebCore::Path::addArcTo):
        (WebCore::Path::isEmpty):
        * platform/graphics/qt/TransformationMatrixQt.cpp:
        (WebCore::TransformationMatrix::operator QTransform):
        * platform/qt/ClipboardQt.cpp:
        (WebCore::ClipboardQt::ClipboardQt):
        (WebCore::ClipboardQt::clearData):
        (WebCore::ClipboardQt::clearAllData):
        (WebCore::ClipboardQt::getData):
        (WebCore::ClipboardQt::setData):
        (WebCore::ClipboardQt::setDragImage):
        (WebCore::getCachedImage):
        (WebCore::ClipboardQt::declareAndWriteDragImage):
        (WebCore::ClipboardQt::writeURL):
        (WebCore::ClipboardQt::writeRange):
        (WebCore::ClipboardQt::hasData):
        * platform/qt/ClipboardQt.h:
        * platform/qt/ContextMenuItemQt.cpp:
        (WebCore::ContextMenuItem::action):
        (WebCore::ContextMenuItem::title):
        * platform/qt/CursorQt.cpp:
        (WebCore::westPanningCursor):
        (WebCore::notAllowedCursor):
        * platform/qt/DragDataQt.cpp:
        (WebCore::DragData::containsFiles):
        (WebCore::DragData::asFilenames):
        (WebCore::DragData::asPlainText):
        (WebCore::DragData::asFragment):
        * platform/qt/DragImageQt.cpp:
        (WebCore::createDragImageIconForCachedImage):
        * platform/qt/FileSystemQt.cpp:
        (WebCore::getFileSize):
        (WebCore::unloadModule):
        * platform/qt/Localizations.cpp:
        (WebCore::contextMenuItemTagShowSpellingPanel):
        * platform/qt/MIMETypeRegistryQt.cpp:
        (WebCore::):
        * platform/qt/PasteboardQt.cpp:
        (WebCore::Pasteboard::Pasteboard):
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::plainText):
        * platform/qt/PlatformKeyboardEventQt.cpp:
        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
        * platform/qt/PlatformMouseEventQt.cpp:
        (WebCore::PlatformMouseEvent::PlatformMouseEvent):
        * platform/qt/PopupMenuQt.cpp:
        (WebCore::PopupMenu::populate):
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::fallbackStyle):
        (WebCore::inflateButtonRect):
        (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
        (WebCore::RenderThemeQt::paintButton):
        (WebCore::RenderThemeQt::paintMenuList):
        (WebCore::RenderThemeQt::applyTheme):
        (WebCore::WorldMatrixTransformer::WorldMatrixTransformer):
        (WebCore::RenderThemeQt::paintMediaBackground):
        (WebCore::RenderThemeQt::paintMediaFullscreenButton):
        * platform/qt/RenderThemeQt.h:
        * platform/qt/ScreenQt.cpp:
        (WebCore::screenRect):
        (WebCore::usableScreenRect):
        * platform/qt/ScrollbarQt.cpp:
        (WebCore::Scrollbar::contextMenu):
        * platform/qt/ScrollbarThemeQt.cpp:
        (WebCore::scPart):
        (WebCore::scrollbarPart):
        * platform/qt/ScrollbarThemeQt.h:
        * platform/qt/SharedBufferQt.cpp:
        (WebCore::SharedBuffer::createWithContentsOfFile):
        * platform/qt/TemporaryLinkStubs.cpp:
        (PluginDatabase::defaultPluginDirectories):
        (PluginDatabase::getPluginPathsInDirectories):
        (PluginDatabase::isPreferredPluginDirectory):
        (WebCore::getSupportedKeySizes):
        (WebCore::signedPublicKeyAndChallengeString):
        (WebCore::userIdleTime):
        (WebCore::prefetchDNS):
        * platform/text/qt/StringQt.cpp:
        (WebCore::String::String):
        * platform/text/qt/TextBoundaries.cpp:
        * platform/text/qt/TextBreakIteratorQt.cpp:
        (WebCore::TextBreakIterator::following):
        (WebCore::TextBreakIterator::preceding):
        (WebCore::WordBreakIteratorQt::first):
        (WebCore::WordBreakIteratorQt::next):
        (WebCore::WordBreakIteratorQt::previous):
        (WebCore::CharBreakIteratorQt::first):
        (WebCore::CharBreakIteratorQt::next):
        (WebCore::CharBreakIteratorQt::previous):
        (WebCore::characterBreakIterator):
        * plugins/qt/PluginPackageQt.cpp:
        (WebCore::PluginPackage::fetchInfo):
        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::userAgentStatic):
        (WebCore::PluginView::handlePostReadFile):
        (WebCore::PluginView::init):

WebKit/qt:

2009-07-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Eric Seidel.

        Fix Qt code to follow the WebKit Coding Style.

        * Api/qcookiejar.cpp:
        (QCookieJar::setCookieJar):
        (QCookieJar::cookieJar):
        * Api/qcookiejar.h:
        * Api/qwebdatabase.cpp:
        (QWebDatabase::QWebDatabase):
        (QWebDatabase::removeDatabase):
        * Api/qwebdatabase.h:
        * Api/qwebdatabase_p.h:
        * Api/qwebelement.h:
        * Api/qwebframe.cpp:
        (QWebFrame::title):
        (QWebFrame::print):
        * Api/qwebframe.h:
        * Api/qwebframe_p.h:
        * Api/qwebhistory.cpp:
        (QWebHistory::clear):
        * Api/qwebhistory.h:
        * Api/qwebhistory_p.h:
        * Api/qwebhistoryinterface.cpp:
        (gCleanupInterface):
        (QWebHistoryInterface::setDefaultInterface):
        (QWebHistoryInterface::defaultInterface):
        (QWebHistoryInterface::QWebHistoryInterface):
        * Api/qwebhistoryinterface.h:
        * Api/qwebnetworkinterface.cpp:
        (QWebNetworkManager::started):
        (QWebNetworkManager::finished):
        (QWebNetworkInterfacePrivate::parseDataUrl):
        (QWebNetworkInterface::addJob):
        (WebCoreHttp::onResponseHeaderReceived):
        (WebCoreHttp::onReadyRead):
        * Api/qwebnetworkinterface.h:
        * Api/qwebnetworkinterface_p.h:
        * Api/qwebpage.cpp:
        (QWebPagePrivate::editorCommandForWebActions):
        (QWebPagePrivate::createContextMenu):
        (QWebPagePrivate::focusInEvent):
        (QWebPage::fixedContentsSize):
        (QWebPage::setContentEditable):
        (QWebPage::swallowContextMenuEvent):
        (QWebPage::findText):
        * Api/qwebpage.h:
        * Api/qwebpage_p.h:
        * Api/qwebpluginfactory.h:
        * Api/qwebsecurityorigin.h:
        * Api/qwebsecurityorigin_p.h:
        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::QWebSettingsPrivate):
        (QWebSettingsPrivate::apply):
        (QWebSettings::globalSettings):
        (QWebSettings::QWebSettings):
        (QWebSettings::fontSize):
        (QWebSettings::setUserStyleSheetUrl):
        (QWebSettings::setDefaultTextEncoding):
        (QWebSettings::setIconDatabasePath):
        (QWebSettings::iconDatabasePath):
        (QWebSettings::iconForUrl):
        (QWebSettings::setWebGraphic):
        (QWebSettings::setFontFamily):
        (QWebSettings::fontFamily):
        (QWebSettings::testAttribute):
        (qt_websettings_setLocalStorageDatabasePath):
        * Api/qwebsettings.h:
        * Api/qwebview.cpp:
        (QWebView::setPage):
        (QWebView::event):
        * Api/qwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Priit Laes <plaes@plaes.org>
kov@webkit.org [Tue, 21 Jul 2009 11:05:25 +0000 (11:05 +0000)]
2009-07-21  Priit Laes  <plaes@plaes.org>

        Reviewed by Holger Freyther.

        [GTK+] Missing accelerator in authentication dialog
        https://bugs.webkit.org/show_bug.cgi?id=25509

        Add accelerator to checkbox text.

        * WebKit/gtk/webkit/webkitsoupauthdialog.c:
        (show_auth_dialog):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Priit Laes <plaes@plaes.org>
kov@webkit.org [Tue, 21 Jul 2009 10:51:46 +0000 (10:51 +0000)]
2009-07-21  Priit Laes  <plaes@plaes.org>

        Reviewed by Holger Freyther.

        [GTK] http auth dialog pops up twice after a cancelled atempt
        https://bugs.webkit.org/show_bug.cgi?id=24818

        Remove workaround required for libsoup versions <=2.26.2 as we depend
        on 2.27.4 now.

        * webkit/webkitsoupauthdialog.c:
        (session_authenticate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Maxime Simon <simon.maxime@gmail.com>
levin@chromium.org [Tue, 21 Jul 2009 10:41:30 +0000 (10:41 +0000)]
2009-07-21  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by David Levin.

        Added a first bunch of Haiku-specific files for WebCore.
        https://bugs.webkit.org/show_bug.cgi?id=26988

        * platform/haiku/ClipboardHaiku.cpp: Added.
        (WebCore::ClipboardHaiku::ClipboardHaiku):
        (WebCore::ClipboardHaiku::clearData):
        (WebCore::ClipboardHaiku::clearAllData):
        (WebCore::ClipboardHaiku::getData):
        (WebCore::ClipboardHaiku::setData):
        (WebCore::ClipboardHaiku::types):
        (WebCore::ClipboardHaiku::files):
        (WebCore::ClipboardHaiku::dragLocation):
        (WebCore::ClipboardHaiku::dragImage):
        (WebCore::ClipboardHaiku::setDragImage):
        (WebCore::ClipboardHaiku::dragImageElement):
        (WebCore::ClipboardHaiku::setDragImageElement):
        (WebCore::ClipboardHaiku::createDragImage):
        (WebCore::ClipboardHaiku::declareAndWriteDragImage):
        (WebCore::ClipboardHaiku::writeURL):
        (WebCore::ClipboardHaiku::writeRange):
        (WebCore::ClipboardHaiku::hasData):
        * platform/haiku/ClipboardHaiku.h: Added.
        (WebCore::ClipboardHaiku::create):
        (WebCore::ClipboardHaiku::~ClipboardHaiku):
        * platform/haiku/CookieJarHaiku.cpp: Added.
        (WebCore::setCookies):
        (WebCore::cookies):
        (WebCore::cookiesEnabled):
        * platform/haiku/CursorHaiku.cpp: Added.
        (WebCore::Cursor::Cursor):
        (WebCore::Cursor::~Cursor):
        (WebCore::Cursor::operator=):
        (WebCore::pointerCursor):
        (WebCore::moveCursor):
        (WebCore::crossCursor):
        (WebCore::handCursor):
        (WebCore::iBeamCursor):
        (WebCore::waitCursor):
        (WebCore::helpCursor):
        (WebCore::eastResizeCursor):
        (WebCore::northResizeCursor):
        (WebCore::northEastResizeCursor):
        (WebCore::northWestResizeCursor):
        (WebCore::southResizeCursor):
        (WebCore::southEastResizeCursor):
        (WebCore::southWestResizeCursor):
        (WebCore::westResizeCursor):
        (WebCore::northSouthResizeCursor):
        (WebCore::eastWestResizeCursor):
        (WebCore::northEastSouthWestResizeCursor):
        (WebCore::northWestSouthEastResizeCursor):
        (WebCore::columnResizeCursor):
        (WebCore::rowResizeCursor):
        (WebCore::verticalTextCursor):
        (WebCore::cellCursor):
        (WebCore::contextMenuCursor):
        (WebCore::noDropCursor):
        (WebCore::copyCursor):
        (WebCore::progressCursor):
        (WebCore::aliasCursor):
        (WebCore::noneCursor):
        (WebCore::notAllowedCursor):
        (WebCore::zoomInCursor):
        (WebCore::zoomOutCursor):
        (WebCore::grabCursor):
        (WebCore::grabbingCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>
levin@chromium.org [Tue, 21 Jul 2009 10:35:11 +0000 (10:35 +0000)]
2009-07-21  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        Support lint for patches
        https://bugs.webkit.org/show_bug.cgi?id=27291

        Add run-webkit-lint script, which lints recent changes in local
        repository.  Also, modified cpplint.py so that we don't need to
        specify verbose level for process_file().

        * Scripts/modules/cpplint.py:
        * Scripts/run-webkit-lint: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Albert Astals Cid <aacid@kde.org>
vestbo@webkit.org [Tue, 21 Jul 2009 10:12:43 +0000 (10:12 +0000)]
2009-07-21  Albert Astals Cid <aacid@kde.org>

        Reviewed by Tor Arne Vestbø.

        Change #error line not to have a ' (single quote)

        * DerivedSources.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>
levin@chromium.org [Tue, 21 Jul 2009 10:12:05 +0000 (10:12 +0000)]
2009-07-21  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        diff_parser should accept lines without trailing \n
        https://bugs.webkit.org/show_bug.cgi?id=27483

        Normalize the input lines by removing a trailing newline.
        Also, add a case for unittest for newly added files.

        * Scripts/modules/diff_parser.py:
        * Scripts/modules/diff_parser_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>
levin@chromium.org [Tue, 21 Jul 2009 10:12:00 +0000 (10:12 +0000)]
2009-07-21  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        cpplint.py's process_file() should accept customized error function
        https://bugs.webkit.org/show_bug.cgi?id=27487

        * Scripts/modules/cpplint.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>
levin@chromium.org [Tue, 21 Jul 2009 09:53:52 +0000 (09:53 +0000)]
2009-07-21  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        cpplint.py should have an interface to get global error count
        https://bugs.webkit.org/show_bug.cgi?id=27486

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>
levin@chromium.org [Tue, 21 Jul 2009 09:53:47 +0000 (09:53 +0000)]
2009-07-21  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        cpplint's parse_argument should not exit even if no files are specified
        https://bugs.webkit.org/show_bug.cgi?id=27489

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Shinichiro Hamaji <hamaji@chromium.org>
levin@chromium.org [Tue, 21 Jul 2009 09:53:42 +0000 (09:53 +0000)]
2009-07-21  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        diff_parser: s/add_deleted_line/add_old_line/g
        https://bugs.webkit.org/show_bug.cgi?id=27484

        * Scripts/modules/diff_parser.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago.:
levin@chromium.org [Tue, 21 Jul 2009 09:53:37 +0000 (09:53 +0000)]
.:

2009-07-21  Roland Steiner  <rolandsteiner@google.com>

        Reviewed by David Levin.

        Add ENABLE_RUBY to list of build options
        https://bugs.webkit.org/show_bug.cgi?id=27324

        * configure.ac: Added flag ENABLE_RUBY.

JavaScriptCore:

2009-07-21  Roland Steiner  <rolandsteiner@google.com>

        Reviewed by David Levin.

        Add ENABLE_RUBY to list of build options
        https://bugs.webkit.org/show_bug.cgi?id=27324

        * Configurations/FeatureDefines.xcconfig: Added flag ENABLE_RUBY.

WebCore:

2009-07-21  Roland Steiner  <rolandsteiner@google.com>

        Reviewed by David Levin.

        Add ENABLE_RUBY to list of build options
        https://bugs.webkit.org/show_bug.cgi?id=27324

        Added flag ENABLE_RUBY:

        * Configurations/FeatureDefines.xcconfig:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCoreCommon.vsprops:
        * WebCore.vcproj/build-generated-files.sh:

WebKit/mac:

2009-07-21  Roland Steiner  <rolandsteiner@google.com>

        Reviewed by David Levin.

        Add ENABLE_RUBY to list of build options
        https://bugs.webkit.org/show_bug.cgi?id=27324

        * Configurations/FeatureDefines.xcconfig: Added flag ENABLE_RUBY.

WebKit/win:

2009-07-21  Roland Steiner  <rolandsteiner@google.com>

        Reviewed by David Levin.

        Add ENABLE_RUBY to list of build options
        https://bugs.webkit.org/show_bug.cgi?id=27324

        * WebKit.vcproj/WebKit.vcproj: Added flag ENABLE_RUBY.

WebKitTools:

2009-07-21  Roland Steiner  <rolandsteiner@google.com>

        Reviewed by David Levin.

        Add ENABLE_RUBY to list of build options
        https://bugs.webkit.org/show_bug.cgi?id=27324

        * Scripts/build-webkit: Added flag ENABLE_RUBY.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 James Hawkins <jhawkins@google.com>
levin@chromium.org [Tue, 21 Jul 2009 09:53:28 +0000 (09:53 +0000)]
2009-07-21  James Hawkins  <jhawkins@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=27467
        Return an empty path in PlatformContextSkia::currentPathInLocalCoordinates
        if matrix.invert() fails.  This prevents the use of an uninitialized
        value in inverseMatrix.

        No new tests added.  Run
        LayoutTests/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr.html
        under valgrind and notice there are no errors.

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::currentPathInLocalCoordinates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-21 Stephen White <senorblanco@chromium.org>
levin@chromium.org [Tue, 21 Jul 2009 09:53:22 +0000 (09:53 +0000)]
2009-07-21  Stephen White  <senorblanco@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=27388

        Fix dotted and dashed borders on Chromium/skia.  This follows
        the logic in the Cg path, so results are much closer to Safari now
        (some tests won't be exactly the same due to font layout differences).

        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::drawLine):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::setupPaintForStroking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix <https://bugs.webkit.org/show_bug.cgi?id=27482>.
mrowe@apple.com [Tue, 21 Jul 2009 06:41:30 +0000 (06:41 +0000)]
Fix <https://bugs.webkit.org/show_bug.cgi?id=27482>.
Bug 27482: svn-apply cannot apply patch generated by Windows SVN

Reviewed by David D. Kilzer.

A regexp in svn-apply was treating everything prior to a \n as part of the
file name.  The native Windows SVN client uses \r\n for line endings which
meant that the \r was being included in the file name.  This defeated the
special-case logic for ChangeLogs to apply them with an increased fuzz factor,
meaning that the ChangeLog portions of such patches would fail to apply.

Also updated two other regexps that look like they would hit similar problems
with line-endings so that they will correctly handle patches from Windows SVN.

* Scripts/svn-apply:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix attempt #2
oliver@apple.com [Tue, 21 Jul 2009 04:35:22 +0000 (04:35 +0000)]
Build fix attempt #2

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix attempt #1
oliver@apple.com [Tue, 21 Jul 2009 04:22:24 +0000 (04:22 +0000)]
Windows build fix attempt #1

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake it harder to misuse try* allocation routines
oliver@apple.com [Tue, 21 Jul 2009 04:02:25 +0000 (04:02 +0000)]
Make it harder to misuse try* allocation routines
https://bugs.webkit.org/show_bug.cgi?id=27469

Reviewed Gavin Barraclough

Jump through a few hoops to make it much harder to accidentally
miss null-checking of values returned by the try-* allocation
routines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Add test for loading webpages...
zecke@webkit.org [Tue, 21 Jul 2009 03:33:14 +0000 (03:33 +0000)]
[Qt] Add test for loading webpages...

Performance test for loading webpages...

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Add a test case for drawing a simple viewrect to a QPixmap
zecke@webkit.org [Tue, 21 Jul 2009 03:32:49 +0000 (03:32 +0000)]
[Qt] Add a test case for drawing a simple viewrect to a QPixmap

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Adam Langley <agl@google.com>
agl@chromium.org [Tue, 21 Jul 2009 03:30:12 +0000 (03:30 +0000)]
2009-07-20  Adam Langley  <agl@google.com>

        Reviewed by Eric Seidel.

        Guard access to installedMediaEngines()[0].

        https://bugs.webkit.org/show_bug.cgi?id=27479
        http://code.google.com/p/chromium/issues/detail?id=16541

        Else where in the file, installedMediaEngines is always checked for
        being empty because access. This patch adds a case which missed that
        check.

        This triggered a crash in Chromium:
            http://www.yakeze.com/chat/example-chromium-crash/

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Tue, 21 Jul 2009 03:27:09 +0000 (03:27 +0000)]
2009-07-20  Gavin Barraclough  <barraclough@apple.com>

        RS Oliver Hunt.

        Add ARM assembler files to xcodeproj, for convenience editing.

        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Adam Langley <agl@google.com>
agl@chromium.org [Tue, 21 Jul 2009 03:06:04 +0000 (03:06 +0000)]
2009-07-20  Adam Langley  <agl@google.com>

        Reviewed by Eric Seidel.

        Allow search entries to render with a CSS border if the RenderTheme
        doesn't paint them.

        https://bugs.webkit.org/show_bug.cgi?id=27466
        http://code.google.com/p/chromium/issues/detail?id=16958

        <input type="search"> is very much like a text entry except that,
        currently, if the RenderTheme doesn't deal with it, nothing is
        rendered. With this patch, the default CSS border is rendered if the
        RenderTheme requests it.

        This will affect many layout tests, but only for Chromium Linux and
        those results are not currently in the WebKit tree.

        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::paintBorderOnly):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Jessie Berlin <jberlin@apple.com>
jberlin@apple.com [Tue, 21 Jul 2009 02:58:41 +0000 (02:58 +0000)]
2009-07-20  Jessie Berlin  <jberlin@apple.com>

        Fix an incorrect assertion in Vector::remove.

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=27477

        * wtf/Vector.h:
        (WTF::::remove):
        Assert that the position at which to start removing elements + the
        length (the number of elements to remove) is less than or equal to the
        size of the entire Vector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Correct expected results from r46136, which accidentally included the
mitz@apple.com [Tue, 21 Jul 2009 02:54:40 +0000 (02:54 +0000)]
    Correct expected results from r46136, which accidentally included the
        DumpRenderTree header and trailer

        * fast/loader/non-html-load-event-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Anton Muhin <antonm@chromium.org>
abarth@webkit.org [Tue, 21 Jul 2009 02:19:41 +0000 (02:19 +0000)]
2009-07-17  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        Switch to faster methods to access internal fields.
        https://bugs.webkit.org/show_bug.cgi?id=27372

        Minor refactoring.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertToSVGPODTypeImpl):
        (WebCore::V8DOMWrapper::setDOMWrapper):
        * bindings/v8/V8DOMWrapper.h:
        (WebCore::V8DOMWrapper::convertDOMWrapperToNative):
        (WebCore::V8DOMWrapper::convertDOMWrapperToNode):
        (WebCore::V8DOMWrapper::convertToNativeObject):
        (WebCore::V8DOMWrapper::convertToNativeEvent):
        * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8ClipboardCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8DocumentCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8ElementCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
        (WebCore::removeElement):
        * bindings/v8/custom/V8InspectorControllerCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8NodeCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8XSLTProcessorCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Adam Langley <agl@google.com>
agl@chromium.org [Tue, 21 Jul 2009 02:15:23 +0000 (02:15 +0000)]
2009-07-20  Adam Langley  <agl@google.com>

        Reviewed by Eric Seidel.

        Chromium Linux: cache Harfbuzz faces.

        https://bugs.webkit.org/show_bug.cgi?id=27473

        Previously, we recreated the Harfbuzz face for each script-run. With
        this patch, we keep the Harfbuzz face in the FontPlatformData (created
        as needed) and so they will persist for the duration of the
        FontPlatformData.

        Shouldn't affect any layout tests. Results in a significant win on the
        intl2 page cycler time.

        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::TextRunWalker::~TextRunWalker):
        (WebCore::TextRunWalker::setupFontForScriptRun):
        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::RefCountedHarfbuzzFace::~RefCountedHarfbuzzFace):
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::harfbuzzFace):
        * platform/graphics/chromium/FontPlatformDataLinux.h:
        (WebCore::FontPlatformData::RefCountedHarfbuzzFace::create):
        (WebCore::FontPlatformData::RefCountedHarfbuzzFace::face):
        (WebCore::FontPlatformData::RefCountedHarfbuzzFace::RefCountedHarfbuzzFace):
        * platform/graphics/chromium/HarfbuzzSkia.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 21 Jul 2009 01:31:18 +0000 (01:31 +0000)]
2009-07-20  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Simon Fraser.

        REGRESSION (r46142): Need to remove showTreeThisForThis
        https://bugs.webkit.org/show_bug.cgi?id=27475

        Removes showTreeThisForThis

        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::appendParagraphIntoNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
rniwa@webkit.org [Tue, 21 Jul 2009 00:55:00 +0000 (00:55 +0000)]
WebCore:

2009-07-19  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Refactoring of indentRegion to fix bugs 26816 and 25317
        https://bugs.webkit.org/show_bug.cgi?id=26816
        https://bugs.webkit.org/show_bug.cgi?id=25317
        https://bugs.webkit.org/show_bug.cgi?id=23995 (partially)

        This patch implements appendParagraphIntoNode, a simpler specialized version of moveParagraph
        and replaces all calls inside indentRegion. The following is the new behavior of indentRegion.

        1. We try to indent as many wrapping nodes as possible.
           e.g. when indenting "hello" in <div>hello</div>, we try to indent div as well.
        2. We do not delete any wrapping elements
           With moveParagraph, we used to remove all wrapping nodes, and replaced with a blockquote.
           This was causing https://bugs.webkit.org/show_bug.cgi?id=23995 for indentation.
           With appendParagraphIntoNode, we can preserve all wrapping nodes.
        3. We only split the tree until the closest block node instead of until the root editable node.
           This behavioral change fixes the bug 25317.
        4. When multiple paragraphs are indented, we indent the highest common ancestor within the selection.
           e.g. when a list is a child node of a div, and the entire div is intended,
                we enclose the div by a single blockquote.

        Note that new behavior is more consistent with that of Internet Explorer and Firefox.
        To demonstrate this, the following tests are added.

        Tests: editing/execCommand/indent-div-inside-list.html
               editing/execCommand/indent-nested-blockquotes.html
               editing/execCommand/indent-nested-div.html
               editing/execCommand/indent-second-paragraph-in-blockquote.html

        * editing/IndentOutdentCommand.cpp: prepareBlockquoteLevelForInsertion is removed
        (WebCore::IndentOutdentCommand::tryIndentingAsListItem): uses appendParagraphIntoNode now
        (WebCore::IndentOutdentCommand::indentIntoBlockquote): uses appendParagraphIntoNode now
        (WebCore::IndentOutdentCommand::appendParagraphIntoNode): removes a paragraph and appends it to a new node
        (WebCore::IndentOutdentCommand::removeUnnecessaryLineBreakAt): removes a break element at the specified position
        (WebCore::IndentOutdentCommand::indentRegion): exhibits the described behavior
        * editing/IndentOutdentCommand.h: updated prototype
        * editing/execCommand/19653-1-expected.txt: rebaselined (no longer removes wrapping div)
        * editing/execCommand/indent-div-inside-list-expected.txt: Added.
        * editing/execCommand/indent-div-inside-list.html: Added.
        * editing/execCommand/indent-nested-blockquotes-expected.txt: Added.
        * editing/execCommand/indent-nested-blockquotes.html: Added.
        * editing/execCommand/indent-nested-div-expected.txt: Added.
        * editing/execCommand/indent-nested-div.html: Added.
        * editing/execCommand/indent-nested-lists-2-expected.txt: rebaselined (selection corrected)
        * editing/execCommand/indent-nested-lists-3-expected.txt: rebaselined (selection corrected)
        * editing/execCommand/indent-nested-lists-4-expected.txt: rebaselined (selection corrected)
        * editing/execCommand/indent-nested-lists-5-expected.txt: rebaselined (selection corrected)
        * editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt: Added.
        * editing/execCommand/indent-second-paragraph-in-blockquote.html: Added.
        * platform/mac/editing/execCommand/4641880-2-expected.txt: rebaselined
        * platform/mac/editing/execCommand/4916541-expected.txt: rebaselined (no longer removes wrapping span)
        * platform/mac/editing/execCommand/5138441-expected.txt: rebaselined
        * platform/mac/editing/execCommand/5481523-expected.txt: rebaselined
        * platform/mac/editing/execCommand/indent-selection-expected.txt: rebaselined

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Try to fix release builds after r46136
mitz@apple.com [Mon, 20 Jul 2009 23:59:58 +0000 (23:59 +0000)]
    Try to fix release builds after r46136

        * dom/Element.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
pdherbemont@apple.com [Mon, 20 Jul 2009 23:59:06 +0000 (23:59 +0000)]
WebCore:

2009-07-17  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Eric Seidel.

        Media Controls: We are specifying the text height, where it is unneeded and the slider is 2px off.
        https://bugs.webkit.org/show_bug.cgi?id=27380

        Adjust the margin of the slider and remove useless height specification to fix alignement of the media controls.

        * css/mediaControlsQT.css:

LayoutTests:

2009-07-17  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Eric Seidel.

        Media Controls: We are specifying the text height, where it is unneeded and the slider is 2px off.
        https://bugs.webkit.org/show_bug.cgi?id=27380

        Adjust the margin of the slider and remove useless height specification to fix alignement of the media controls.

        * platform/mac/media/controls-after-reload-expected.txt:
        * platform/mac/media/controls-styling-expected.checksum: Removed.
        * platform/mac/media/controls-styling-expected.png: Removed.
        * platform/mac/media/controls-styling-expected.txt:
        * platform/mac/media/video-zoom-controls-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
pkasting@chromium.org [Mon, 20 Jul 2009 23:56:15 +0000 (23:56 +0000)]
JavaScriptCore:

2009-07-20  Peter Kasting  <pkasting@google.com>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=27468
        Back out r46060, which caused problems for some Apple developers.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
        * JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
        * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
        * JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:

WebCore:

2009-07-20  Peter Kasting  <pkasting@google.com>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=27468
        Back out r46060, which caused problems for some Apple developers.

        * WebCore.vcproj/QTMovieWin.vcproj:
        * WebCore.vcproj/WebCoreCommon.vsprops:
        * WebCore.vcproj/WebCoreGenerated.vcproj:

WebKit/win:

2009-07-20  Peter Kasting  <pkasting@google.com>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=27468
        Back out r46060, which caused problems for some Apple developers.

        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/InterfacesGenerated.vcproj:
        * WebKit.vcproj/WebKit.vcproj:
        * WebKit.vcproj/WebKitGUID.vcproj:

WebKitTools:

2009-07-20  Peter Kasting  <pkasting@google.com>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=27468
        Back out r46060, which caused problems for some Apple developers.

        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/ImageDiff.vcproj:
        * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 20 Jul 2009 23:35:48 +0000 (23:35 +0000)]
2009-07-20  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam Weinig.

        Fix failures seen on the bots
        https://bugs.webkit.org/show_bug.cgi?id=27463

        Ignore more global variables added by DumpRenderTree.
        Some platforms don't add all of the DRT controllers,
        thus causing this test to fail for those platforms.

        Also fix !value to value === null to handle not
        skip the cases where value == 0.

        * fast/dom/prototype-inheritance-expected.txt:
        * fast/dom/resources/prototype-inheritance.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFixed a transition LayoutTest which fails on slower machines
cmarrin@apple.com [Mon, 20 Jul 2009 23:15:28 +0000 (23:15 +0000)]
Fixed a transition LayoutTest which fails on slower machines

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Mon, 20 Jul 2009 23:08:36 +0000 (23:08 +0000)]
WebCore:

        Reviewed by Anders Carlsson.

        When loading a custom view into a frame, the old document is still
        around
        <rdar://problem/5145841>

        Safari fires onload before PDF is loaded into the browser
        <rdar://problem/6618869>

        Test: fast/loader/non-html-load-event.html

        * GNUmakefile.am: Added PlaceholderDocument.{cpp,h}
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.
        * dom/Document.h:
        (WebCore::Document::setStyleSelector): Added this protected accessor for
            PlaceholderDocument to use.
        * dom/Element.cpp:
        (WebCore::Element::clientWidth): Check whether the document has a
            renderer.
        (WebCore::Element::clientHeight): Ditto.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::begin): Create a PlaceholderDocument for frames
            that do not use an HTML view. Do not nullify the content size in
            that case.
        (WebCore::FrameLoader::transitionToCommitted): For frames that do not
            use an HTML view, call receivedFirstData(), which sets up the
            frame with a new PlaceHolderDocument.
        * loader/PlaceholderDocument.cpp: Added.
        (WebCore::PlaceholderDocument::attach): Sets up the style selector but
            does not create a RenderView.
        * loader/PlaceholderDocument.h: Added.
        (WebCore::PlaceholderDocument::create):
        (WebCore::PlaceholderDocument::PlaceholderDocument):

LayoutTests:

        Reviewed by Anders Carlsson.

        Safari fires onload before PDF is loaded into the browser
        <rdar://problem/6618869>

        * fast/loader/non-html-load-event-expected.txt: Added.
        * fast/loader/non-html-load-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Handle opacity and opacity animations on transform layers in Leopard
cmarrin@apple.com [Mon, 20 Jul 2009 22:45:38 +0000 (22:45 +0000)]
    Handle opacity and opacity animations on transform layers in Leopard
        https://bugs.webkit.org/show_bug.cgi?id=27398

        This makes two changes, and only for Leopard.

        First, whenever opacity is changed on a layer I propagate the
        change into the content layer and all the children if the layer
        on which opacity is set is a transform layer (preserve3D is true).
        The opacity set is the accumulated opacity from this layer
        and all its direct ancestor transform layers. Second, I turn off all
        hardware opacity animation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Mon, 20 Jul 2009 22:16:17 +0000 (22:16 +0000)]
2009-07-20  Peter Kasting  <pkasting@google.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=27323
        Use shorter, more correct code for determining the current directory,
        which works better with symbolic links on some systems.  Also switch
        from checking repository root to checking UUID, to match scm.py.

        * Scripts/svn-create-patch:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWork around <rdar://problem/7075373> by ensuring that the URL is absolute before...
mrowe@apple.com [Mon, 20 Jul 2009 21:46:08 +0000 (21:46 +0000)]
Work around <rdar://problem/7075373> by ensuring that the URL is absolute before handing it off to CoreText.

Rubber-stamped by Dan Bernstein.

* DumpRenderTree/mac/DumpRenderTree.mm:
(activateFonts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 David Levin <levin@chromium.org>
levin@chromium.org [Mon, 20 Jul 2009 20:41:45 +0000 (20:41 +0000)]
2009-07-20  David Levin  <levin@chromium.org>

        Reviewed by Adam Treat.

        Enable filename completion for run-webkit-test (added "-o default").

        * Scripts/webkit-tools-completion.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Yong Li <yong.li@torchmobile.com>
treat@webkit.org [Mon, 20 Jul 2009 20:08:20 +0000 (20:08 +0000)]
2009-07-20  Yong Li  <yong.li@torchmobile.com>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=27349
        Add GraphicsContext implementation for the WinCE port.

        Written by Yong Li <yong.li@torchmobile.com> and George Staikos <george.staikos@torchmobile.com>
        with trivial style fixes by Adam Treat <adam.treat@torchmobile.com>

        * platform/graphics/wince/GraphicsContextWince.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Dumitru Daniliuc <dumi@chromium.org>
eroman@chromium.org [Mon, 20 Jul 2009 17:56:55 +0000 (17:56 +0000)]
2009-07-20  Dumitru Daniliuc  <dumi@chromium.org>

        Reviewed by Dimitri Glazkov.

        Adding the Win SQLite VFS implementation for Chromium, and stubs
        for the Mac and Linux VFSs.

        https://bugs.webkit.org/show_bug.cgi?id=26940

        * WebCore.gypi:
        * platform/chromium/ChromiumBridge.h:
        * platform/sql/chromium/SQLiteFileSystemChromium.cpp: Added.
        * platform/sql/chromium/SQLiteFileSystemChromiumLinux.cpp: Added.
        * platform/sql/chromium/SQLiteFileSystemChromiumMac.cpp: Added.
        * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 20 Jul 2009 13:47:24 +0000 (13:47 +0000)]
2009-07-20  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=27097
        [Gtk] Segfault when examining an object of ROLE_TABLE via at-spi

        Check that an object is a RenderObject before trying to access its
        renderer and related node.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_get_role):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>
hausmann@webkit.org [Mon, 20 Jul 2009 13:36:18 +0000 (13:36 +0000)]
2009-07-20  Balazs Kelemen  <kelemen.balazs.3@stud.u-szeged.hu>

        Reviewed by Simon Hausmann.

        [Qt] font cache reworking
        https://bugs.webkit.org/show_bug.cgi?id=27265

        Reimplemented Qt's FontCache in a way that follows the shared one.
        Now we can release its elements when those became inactive.
        FontFallbackList had been changed to be able to hold WebCore fonts in its list and to be able to release a FontData what is in the cache.

        No change in behavior, so no tests.

        * platform/graphics/qt/FontCacheQt.cpp:
        (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
        (WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue):
        (WebCore::FontPlatformDataCacheKey::): Key type for the cache of FontPlatformData objects.
        It can be constructed from a FontPlatformData or from a FontDescription. The keys have to be consistent
        with FontPlatformData::FontPlatformData(const FontDescription&) - if we create the same
        FontPlatformData from two FontDescription then we have to create the same key from them, and vica versa.
        (WebCore::FontPlatformDataCacheKey::operator==):
        (WebCore::FontPlatformDataCacheKey::hash):
        (WebCore::FontPlatformDataCacheKey::computeHash):
        (WebCore::FontPlatformDataCacheKey::hashTableDeletedSize):
        (WebCore::FontPlatformDataCacheKeyHash::hash):
        (WebCore::FontPlatformDataCacheKeyHash::equal):
        (WebCore::FontPlatformDataCacheKeyTraits::emptyValue):
        (WebCore::FontPlatformDataCacheKeyTraits::constructDeletedValue):
        (WebCore::FontPlatformDataCacheKeyTraits::isDeletedValue):
        (WebCore::FontCache::getCachedFontPlatformData): Get a FontDescription and returns a FontPlatformData.
        (WebCore::FontCache::getCachedFontData): Get a FontPlatformData and returns a SimpleFontData.
        (WebCore::FontCache::releaseFontData): Get a SimpleFontData and releases it from the cache. Also releases the appropriate FontPlatformData.
        (WebCore::FontCache::purgeInactiveFontData): Frees inactive elements.
        (WebCore::FontCache::invalidate): Frees all inactive elements (call purgeInactiveFontData with default argument)
        * platform/graphics/qt/FontFallbackListQt.cpp:
        (WebCore::FontFallbackList::releaseFontData):
        (WebCore::FontFallbackList::fontDataAt):
        * platform/graphics/qt/FontPlatformData.h:
        (WebCore::FontPlatformData::family): Getter. It is needed for FontPlatformDataCacheKey.
        (WebCore::FontPlatformData::bold): Ditto.
        (WebCore::FontPlatformData::italic): Ditto.
        (WebCore::FontPlatformData::smallCaps): Ditto.
        (WebCore::FontPlatformData::pixelSize): Ditto.
        * platform/graphics/qt/FontPlatformDataQt.cpp:
        (WebCore::FontPlatformData::FontPlatformData): Set m_bold.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 20 Jul 2009 11:01:12 +0000 (11:01 +0000)]
2009-07-20  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Holger Freyther.

        [GTK] Widget size negotiation
        https://bugs.webkit.org/show_bug.cgi?id=17154

        Implement proper size request for the WebView widget.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::contentsSizeChanged):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_size_request):
        (webkit_web_view_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Mon, 20 Jul 2009 10:09:16 +0000 (10:09 +0000)]
2009-07-20  Simon Hausmann  <simon.hausmann@nokia.com>

        No review, just adding Gavin Barraclough as reviewer.

        * Scripts/modules/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
hausmann@webkit.org [Mon, 20 Jul 2009 10:04:10 +0000 (10:04 +0000)]
2009-07-20  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Oliver Hunt.

        Allow custom memory allocation control in NewThreadContext
        https://bugs.webkit.org/show_bug.cgi?id=27338

        Inherits NewThreadContext struct from FastAllocBase because it
        has been instantiated by 'new' JavaScriptCore/wtf/Threading.cpp:76.

        * wtf/Threading.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
hausmann@webkit.org [Mon, 20 Jul 2009 10:04:03 +0000 (10:04 +0000)]
2009-07-20  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Oliver Hunt.

        Allow custom memory allocation control in JavaScriptCore's JSClassRef.h
        https://bugs.webkit.org/show_bug.cgi?id=27340

        Inherit StaticValueEntry and StaticFunctionEntry struct from FastAllocBase because these
        have been instantiated by 'new' in JavaScriptCore/API/JSClassRef.cpp:153
        and in JavaScriptCore/API/JSClassRef.cpp:166.

        * API/JSClassRef.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
hausmann@webkit.org [Mon, 20 Jul 2009 10:03:55 +0000 (10:03 +0000)]
2009-07-20  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Allow custom memory allocation control in JavaScriptCore's RegexPattern.h
        https://bugs.webkit.org/show_bug.cgi?id=27343

        Inherits RegexPattern.h's structs (which have been instantiated by operator new) from FastAllocBase:

        CharacterClass (new call: JavaScriptCore/yarr/RegexCompiler.cpp:144)
        PatternAlternative (new call: JavaScriptCore/yarr/RegexPattern.h:221)
        PatternDisjunction (new call: JavaScriptCore/yarr/RegexCompiler.cpp:446)

        * yarr/RegexPattern.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
hausmann@webkit.org [Mon, 20 Jul 2009 10:03:45 +0000 (10:03 +0000)]
2009-07-20  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Allow custom memory allocation control for JavaScriptCore's MatchFrame struct
        https://bugs.webkit.org/show_bug.cgi?id=27344

        Inherits MatchFrame struct from FastAllocBase because it has
        been instantiated by 'new' JavaScriptCore/pcre/pcre_exec.cpp:359.

        * pcre/pcre_exec.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 20 Jul 2009 10:02:49 +0000 (10:02 +0000)]
2009-07-20  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=26716
        [Gtk] Each XMLHttpRequest leaks memory.

        Free the SoupURI we create to check the URI. Fix suggested by John
        Kjellberg.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago.:
hausmann@webkit.org [Mon, 20 Jul 2009 09:52:00 +0000 (09:52 +0000)]
.:

2009-07-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] Add an option for QtLauncher to build without QtUiTools dependency
        https://bugs.webkit.org/show_bug.cgi?id=27438

        Based on Norbert Leser's work.

        * WebKit.pri: Symbian does not have UiTools

WebKit/qt:

2009-07-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] Add an option for QtLauncher to build without QtUiTools dependency
        https://bugs.webkit.org/show_bug.cgi?id=27438

        Based on Norbert Leser's work.

        * QtLauncher/main.cpp:
        (WebPage::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
hausmann@webkit.org [Mon, 20 Jul 2009 09:50:44 +0000 (09:50 +0000)]
2009-07-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        Remove some outdated S60 platform specific code
        https://bugs.webkit.org/show_bug.cgi?id=27423

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
hausmann@webkit.org [Mon, 20 Jul 2009 09:49:33 +0000 (09:49 +0000)]
2009-07-20  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>

        Reviewed by Simon Hausmann.

        Qt build fix with MSVC and MinGW.

        * jsc.pro: Make sure jsc is a console application, and turn off
        exceptions and stl support to fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Kenneth Rohde Christiansen <kenneth@webkit.org>
hausmann@webkit.org [Mon, 20 Jul 2009 09:46:56 +0000 (09:46 +0000)]
2009-07-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by David Levin.

        Add support for Qt's foreach to cpplint
        https://bugs.webkit.org/show_bug.cgi?id=27386

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
hausmann@webkit.org [Mon, 20 Jul 2009 09:41:59 +0000 (09:41 +0000)]
2009-07-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] On Symbian link against system sqlite3
        https://bugs.webkit.org/show_bug.cgi?id=27368

        Add an option to force linking against system sqlite3
        by adding system-sqlite to the CONFIG variable.

        The Symbian specific part of this patch is contributed by
        Norbert Leser.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Mon, 20 Jul 2009 09:32:27 +0000 (09:32 +0000)]
2009-07-20  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by and done with Tor Arne Vestbø.

        Fix fast/css/pseudo-required-optional-*.html in the Qt build
        after r46062.

        These tests triggered a bug in RenderThemeQt where we did not fall back
        to the unstyled painting of text areas and input fields when they have
        a styled background.

        Our re-implementation of isControlStyled incorrectly only checked the
        border for determining whether to style or not. The base-implementation
        performs the same check, but also includes the background. Removing
        our implementation fixes the appearance.

        * platform/qt/RenderThemeQt.cpp: Removed isControlStyled reimplementation.
        * platform/qt/RenderThemeQt.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 20 Jul 2009 08:31:59 +0000 (08:31 +0000)]
2009-07-20  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Do not use C++-style comments in preprocessor directives.

        GCC does not like this in some configurations, using C-style
        comments is safer.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 20 Jul 2009 08:31:46 +0000 (08:31 +0000)]
2009-07-20  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Change the glib version check to check for the first unstable
        release with g_mapped_file_unref. Otherwise this would be useless
        until 2.22 is released, a few months from now.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::startHttp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-20 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Mon, 20 Jul 2009 07:51:44 +0000 (07:51 +0000)]
2009-07-20  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by Tor Arne Vestbø.

        Add missing (sorted) header files to the HEADERS variable in the qmake
        .pro file for improved completion in IDEs.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-19 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 20 Jul 2009 07:24:46 +0000 (07:24 +0000)]
2009-07-19  Simon Hausmann  <hausmann@webkit.org>

        Rubber-stamped by Xan Lopez.

        Skip new fast/dom/prototype-inheritance.html test in the Qt DRT
        due to missing features/properties in the window object.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 20 Jul 2009 03:56:32 +0000 (03:56 +0000)]
2009-07-19  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        [V8] Factor V8ConsoleMessage out of V8Proxy
        https://bugs.webkit.org/show_bug.cgi?id=27421

        No behavior change.

        * WebCore.gypi:
        * bindings/v8/V8ConsoleMessage.cpp: Added.
        (WebCore::V8ConsoleMessage::V8ConsoleMessage):
        (WebCore::V8ConsoleMessage::dispatchNow):
        (WebCore::V8ConsoleMessage::dispatchLater):
        (WebCore::V8ConsoleMessage::processDelayed):
        (WebCore::V8ConsoleMessage::handler):
        * bindings/v8/V8ConsoleMessage.h: Added.
        (WebCore::V8ConsoleMessage::Scope::Scope):
        (WebCore::V8ConsoleMessage::Scope::~Scope):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::logInfo):
        (WebCore::reportUnsafeAccessTo):
        (WebCore::V8Proxy::runScript):
        (WebCore::V8Proxy::callFunction):
        (WebCore::V8Proxy::newInstance):
        (WebCore::V8Proxy::initContextIfNeeded):
        (WebCore::V8Proxy::processConsoleMessages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Adam Barth.
rwlbuis@webkit.org [Sun, 19 Jul 2009 18:50:49 +0000 (18:50 +0000)]
    Reviewed by Adam Barth.

        Remove unused member variable.

        * svg/SVGPolyElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-19 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Sun, 19 Jul 2009 18:16:00 +0000 (18:16 +0000)]
2009-07-19  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        HTMLAudioElement: constructor should set "autobuffer" attribute
        https://bugs.webkit.org/show_bug.cgi?id=27422

        Test: media/audio-constructor-autobuffer.html

        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::constructAudio):
            Set 'autobuffer' attribute.

2009-07-19  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        HTMLAudioElement: constructor should set "autobuffer" attribute
        https://bugs.webkit.org/show_bug.cgi?id=27422

        * media/audio-constructor-autobuffer-expected.txt: Added.
        * media/audio-constructor-autobuffer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-19 Thierry Bastian <thierry.bastian@nokia.com>
hausmann@webkit.org [Sun, 19 Jul 2009 09:47:44 +0000 (09:47 +0000)]
2009-07-19  Thierry Bastian <thierry.bastian@nokia.com>

        Reviewed by Simon Hausmann.

        Fix the Qt build with mingw.

        * WebCore.pro: Don't use MSVC commandline options to disable warnings
        with mingw.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 19 Jul 2009 07:39:04 +0000 (07:39 +0000)]
2009-07-19  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        [V8] Phase 2: Remove event listener methods from V8Proxy
        https://bugs.webkit.org/show_bug.cgi?id=27415

        No behavior change.

        * bindings/v8/V8ObjectEventListener.cpp:
        (WebCore::weakObjectEventListenerCallback):
        (WebCore::V8ObjectEventListener::~V8ObjectEventListener):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::disconnectEventListeners):
        * bindings/v8/V8Proxy.h:
        (WebCore::V8Proxy::eventListeners):
        (WebCore::V8Proxy::objectListeners):
        * bindings/v8/custom/V8AbstractWorkerCustom.cpp:
        (WebCore::getEventListener):
        * bindings/v8/custom/V8CustomEventListener.cpp:
        (WebCore::V8EventListener::~V8EventListener):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        (WebCore::ACCESSOR_SETTER):
        * bindings/v8/custom/V8ElementCustom.cpp:
        (WebCore::ACCESSOR_SETTER):
        * bindings/v8/custom/V8MessagePortCustom.cpp:
        (WebCore::ACCESSOR_SETTER):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8NodeCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8WorkerCustom.cpp:
        (WebCore::getEventListener):
        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::getEventListener):
        * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
        (WebCore::ACCESSOR_SETTER):
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 18 Jul 2009 23:13:45 +0000 (23:13 +0000)]
2009-07-18  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Gustavo Noronha.

        [Gtk] soup/ResourceHandleSoup.cpp:533: error: 'g_mapped_file_free' was not declared in this scope
        https://bugs.webkit.org/show_bug.cgi?id=27230

        Use g_mapped_file_unref for GLIB version 2.22 onwards.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::startHttp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-18 Jorge Gonzalez <aloriel@gmail.com>
jmalonzo@webkit.org [Sat, 18 Jul 2009 23:03:06 +0000 (23:03 +0000)]
2009-07-18  Jorge Gonzalez  <aloriel@gmail.com>

        Rubber-stamped by Jan Alonzo.

        es translation
        https://bugs.webkit.org/show_bug.cgi?id=26319

        * es.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove some stray executable flags.
darin@apple.com [Sat, 18 Jul 2009 23:00:16 +0000 (23:00 +0000)]
Remove some stray executable flags.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdded Radar URLs
mitz@apple.com [Sat, 18 Jul 2009 22:59:26 +0000 (22:59 +0000)]
Added Radar URLs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Sat, 18 Jul 2009 22:58:15 +0000 (22:58 +0000)]
WebCore:

        Reviewed by Anders Carlsson.

        Add spread radius support to -webkit-box-shadow
        https://bugs.webkit.org/show_bug.cgi?id=27417

        Test: fast/box-shadow/spread.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::valueForShadow): Added a property ID parameter and used it to
            include the spread length for box-shadow but not for text-shadow.
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
            Pass the property ID to valueForShadow().

        * css/CSSParser.cpp:
        (WebCore::ShadowParseContext::ShadowParseContext): Added property,
            spread, and allowSpread members. Added a property ID parameter to
            the constructor. Initialize the property and allowSpread members.
        (WebCore::ShadowParseContext::allowLength): Added allowSpread.
        (WebCore::ShadowParseContext::commitValue): Pass the spread value to
            the ShadowValue constructor. Reset allowSpread.
        (WebCore::ShadowParseContext::commitLength): Allow spread after blur
            for the box-shadow property.
        (WebCore::ShadowParseContext::commitColor): Reset allowSpread.
        (WebCore::CSSParser::parseShadow): Pass the property ID to
            ShadowParseContext().

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): Get the spread value from
            the shadow value and pass it to the ShadowData constructor.

        * css/ShadowValue.cpp:
        (WebCore::ShadowValue::ShadowValue): Added spread.
        (WebCore::ShadowValue::cssText): Added spread.

        * css/ShadowValue.h:
        (WebCore::ShadowValue::create): Added spread.

        * page/animation/AnimationBase.cpp:
        (WebCore::blendFunc): Blend the spread value.
        (WebCore::PropertyWrapperShadow::blend): Added 0 spread to the default
            shadow.

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::placeBoxesHorizontally): Account for spread in
            the visual overflow calculations.
        (WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
        (WebCore::InlineFlowBox::paint): Ditto.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::overflowHeight): Ditto.
        (WebCore::RenderBlock::overflowWidth): Ditto.
        (WebCore::RenderBlock::overflowLeft): Ditto.
        (WebCore::RenderBlock::overflowTop): Ditto.
        (WebCore::RenderBlock::overflowRect): Ditto.
        (WebCore::RenderBlock::layoutBlock): Ditto.

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintBoxShadow): Inflate the shadow-
            casting rect by the shadow spread value. Adjust border radii if
            necessary.

        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock): Account for spread in the
            visual overflow calculations.
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::calculateRects): Ditto.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Account for spread.
        (WebCore::RenderObject::adjustRectForOutlineAndShadow): Ditto.

        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect): Ditto.

        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::setTextShadow): Assert that text shadows do not
            have spread.

        * rendering/style/ShadowData.cpp:
        (WebCore::ShadowData::ShadowData): Added spread.
        (WebCore::ShadowData::operator==): Compare spread.
        * rendering/style/ShadowData.h:
        (WebCore::ShadowData::ShadowData): Added spread.

LayoutTests:

        Reviewed by Anders Carlsson.

        Test box-shadow spread radius
        https://bugs.webkit.org/show_bug.cgi?id=27417

        * fast/box-shadow/spread.html: Added.
        * platform/mac/fast/box-shadow/spread-expected.checksum: Added.
        * platform/mac/fast/box-shadow/spread-expected.png: Added.
        * platform/mac/fast/box-shadow/spread-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 18 Jul 2009 22:53:39 +0000 (22:53 +0000)]
2009-07-18  Jan Michael Alonzo  <jmalonzo@webkit.org>

        https://bugs.webkit.org/show_bug.cgi?id=27145
        [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html fails after r45615

        Reviewed by Gustavo Noronha.

        * platform/gtk/Skipped:

        Normalize file URLs.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (dumpHistoryItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-17 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Sat, 18 Jul 2009 18:50:02 +0000 (18:50 +0000)]
2009-07-17  Peter Kasting  <pkasting@google.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=27323
        Further improve non-Cygwin SVN support.

        * Scripts/prepare-ChangeLog: Harmless change to be consistent with other
          places that consume whitespace at the end of svn output.
        * Scripts/resolve-ChangeLogs: Add support for SVN 1.6.  Slightly
          optimize svn info parsing based on technique in svn-create-patch.
          Normalize paths and consume whitespace in the same way as
          prepare-ChangeLog, for Windows systems with a non-Cygwin SVN.  Force
          diff and patch to run in binary mode so that they won't
          "intelligently" screw up line endings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 18 Jul 2009 17:48:32 +0000 (17:48 +0000)]
2009-07-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Jan Alonzo.

        Minor FrameLoader.cpp cleanup
        https://bugs.webkit.org/show_bug.cgi?id=27406

        No behavior change.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::executeIfJavaScriptURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46094 268f45cc-cd09-0410-ab3c-d52691b4dbfc