WebKit-https.git
7 years agoUse testRunner instead of layoutTestController in tests still found to be using layou...
rniwa@webkit.org [Sat, 4 Aug 2012 07:22:13 +0000 (07:22 +0000)]
Use testRunner instead of layoutTestController in tests still found to be using layoutTestController by grep
https://bugs.webkit.org/show_bug.cgi?id=93177

Reviewed by Adam Barth.

After this patch, neither grep nor spot light finds any tests that use layoutTestController
and we can safely land the patch on the bug 93173.

* editing/pasteboard/input-with-visibility-hidden.html:
* fast/encoding/resources/%25%u0435 0 %xx%%%ulike.html:
* fast/encoding/script-in-head.html:
* fast/encoding/tag-in-title.html:
* fast/encoding/tag-name-digit.html:
* fast/encoding/url-host-name-non-ascii.html:
* fast/encoding/xml-charset-utf16.html:
* fast/encoding/xml-utf-8-default.xml:
* fast/encoding/yahoo-mail.html:
* fast/encoding/yentest.html:
* fast/encoding/yentest2.html:
* fast/forms/datalist/input-appearance-range-with-datalist-zoomed.html:
* fast/forms/datalist/input-appearance-range-with-datalist.html:
* fast/forms/datalist/update-range-with-datalist.html:
* fast/forms/input-set-composition-scroll.html:
* fast/harness/internals-object.html:
* fast/harness/page-cache-crash-on-data-urls.html:
* fast/harness/perftests/perf-runner-compute-statistics.html:
* fast/harness/resources/modal-dialog.html:
* fast/harness/show-modal-dialog.html:
* fast/harness/user-preferred-language.html:
* fast/multicol/hit-test-end-of-column.html:
* fast/multicol/hit-test-gap-between-pages-flipped.html:
* fast/multicol/hit-test-gap-between-pages.html:
* fast/multicol/hit-test-gap-block-axis.html:
* fast/notifications/notifications-event-listener-crash.html:
* fast/parser/foster-parent.html:
* fast/ruby/after-doesnt-crash.html:
* fast/ruby/before-block-doesnt-crash.html:
* fast/ruby/before-doesnt-crash.html:
* fast/ruby/before-table-doesnt-crash.html:
* fast/ruby/generated-before-counter-doesnt-crash.html:
* fast/ruby/modify-positioned-ruby-text-crash.html:
* fast/ruby/parse-rp.html:
* fast/ruby/ruby-illegal-1.html:
* fast/ruby/ruby-illegal-2.html:
* fast/ruby/ruby-illegal-3.html:
* fast/ruby/ruby-illegal-4.html:
* fast/ruby/ruby-illegal-5.html:
* fast/ruby/ruby-illegal-6.html:
* fast/ruby/ruby-illegal-7.html:
* fast/ruby/ruby-illegal-combined.html:
* fast/ruby/ruby-overhang-crash.html:
* fast/ruby/ruby-remove-no-base.html:
* fast/ruby/ruby-remove.html:
* fast/ruby/ruby-text-indent.html:
* fast/ruby/rubyDOM-insert-rt-block-1.html:
* fast/ruby/rubyDOM-insert-rt-block-2.html:
* fast/ruby/rubyDOM-insert-rt-block-3.html:
* fast/ruby/rubyDOM-remove-rt-block-1.html:
* fast/ruby/rubyDOM-remove-rt-block-2.html:
* fast/ruby/rubyDOM-remove-rt-block-3.html:
* fast/runin/crash-when-reparent-sibling.html:
* fast/runin/nonblock-runin.html:
* fast/runin/progress-run-in-crash.html:
* fast/runin/run-in-layer-not-removed-crash.html:
* fast/runin/runin-continuations-crash.html:
* fast/runin/runin-reparent-crash.html:
* fast/runin/select-runin.html:
* fullscreen/empty-anonymous-block-continuation-crash.html:
* http/tests/misc/SVGFont-delayed-load.html:
* http/tests/misc/resources/a success.html:
* http/tests/misc/resources/content-iframe.html:
* http/tests/misc/resources/iframe-policy-1.html:
* http/tests/misc/resources/iframe-policy-2.html:
* http/tests/misc/resources/isindex-with-no-form-base-href-submit.html:
* http/tests/misc/resources/isindex-with-no-form-base-href.html:
* http/tests/misc/resources/redirect-to-external-url-iframe.html:
* http/tests/misc/resources/slow-preload-cancel-1.html:
* http/tests/misc/resources/success-notify-done.html:
* http/tests/misc/resources/webtiming-cross-origin-and-back1.html:
* http/tests/misc/script-500.html:
* http/tests/misc/script-no-store.html:
* http/tests/misc/set-window-opener-to-null.html:
* http/tests/misc/single-character-pi-stylesheet.xhtml:
* http/tests/misc/slow-loading-image-in-pattern.html:
* http/tests/misc/slow-preload-cancel.html:
* http/tests/misc/submit-post-keygen.html:
* http/tests/misc/svg-image-load-outlives-gc-without-crashing.html:
* http/tests/misc/text-refresh.html:
* http/tests/misc/timer-vs-loading.html:
* http/tests/misc/uncacheable-script-repeated.html:
* http/tests/misc/unloadable-script.html:
* http/tests/misc/video-poster-image-load-outlives-gc-without-crashing.html:
* http/tests/misc/webtiming-origins.html:
* http/tests/misc/will-send-request-returns-null-on-redirect.html:
* http/tests/misc/willCacheResponse-delegate-callback.html:
* http/tests/misc/window-dot-stop.html:
* http/tests/misc/window-open-then-write.html:
* http/tests/misc/write-from-dom-script.html:
* http/tests/misc/write-while-waiting.html:
* http/tests/misc/xslt-bad-import.html:
* http/tests/multipart/invalid-image-data-standalone.html:
* http/tests/multipart/invalid-image-data.html:
* http/tests/multipart/multipart-wait-before-boundary.html:
* http/tests/multipart/stop-crash.html:
* http/tests/navigation/:
* http/tests/plugins/create-v8-script-objects.html:
* http/tests/plugins/cross-frame-object-access.html:
* http/tests/plugins/get-url.html:
* http/tests/plugins/geturlnotify-from-npp-destroystream.html:
* http/tests/plugins/interrupted-get-url.html:
* http/tests/plugins/local-geturl-from-remote.html:
* http/tests/plugins/npapi-response-headers.html:
* http/tests/plugins/plugin-document-has-focus.html:
* http/tests/plugins/post-url-file.html:
* http/tests/plugins/resources/interrupted-get-url-success.html:
* http/tests/plugins/resources/third-party-cookie-accept-policy-iframe.html:
* http/tests/plugins/third-party-cookie-accept-policy.html:
* http/tests/resources/notify-done.html:
* http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed.html:
* http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked.html:
* http/tests/ssl/referer-301.html:
* http/tests/ssl/referer-303.html:
* http/tests/storage/callbacks-are-called-in-correct-context.html:
* http/tests/storage/resources/callbacks-are-called-in-correct-context-second-frame.html:
* http/tests/svg/change-id-with-pending-resources.html:
* http/tests/svg/tref-adoptNode-crash.html:
* http/tests/uri/assign-path-with-leading-slash.html:
* http/tests/uri/assign-path-without-leading-slash.html:
* http/tests/uri/escaped-entity.html:
* http/tests/uri/resolve-encoding-relative.html:
* http/tests/uri/resources/assign-path-landing.html:
* http/tests/uri/utf8-path.html:
* http/tests/webarchive/cross-origin-stylesheet-crash-expected.webarchive:
* http/tests/webarchive/cross-origin-stylesheet-crash.html:
* http/tests/webarchive/test-css-url-encoding-expected.webarchive:
* http/tests/webarchive/test-css-url-encoding-shift-jis-expected.webarchive:
* http/tests/webarchive/test-css-url-encoding-shift-jis.html:
* http/tests/webarchive/test-css-url-encoding-utf-8-expected.webarchive:
* http/tests/webarchive/test-css-url-encoding-utf-8.html:
* http/tests/webarchive/test-css-url-encoding.html:
* http/tests/webarchive/test-preload-resources-expected.webarchive:
* http/tests/webarchive/test-preload-resources.html:
* http/tests/webfont/fallback-font-while-loading.html:
* http/tests/websocket/resources/server-failed-to-start.html:
* http/tests/xmlhttprequest/reentrant-cancel.html:
* inspector/device-orientation-success.html:
* platform/chromium/TestExpectations:
* platform/chromium/permissionclient/image-permissions.html:
* platform/chromium/permissionclient/plugin-permission.html:
* platform/chromium/permissionclient/script-permissions.html:
* platform/chromium/permissionclient/storage-permission.html:
* platform/gtk/TestExpectations:
* platform/mac/editing/input/edit-dictated-text-with-alternative.html:
* platform/mac/editing/input/insert-dictated-text.html:
* platform/mac/fast/AppleScript/001.html:
* platform/mac/fast/AppleScript/array.html:
* platform/mac/fast/AppleScript/date.html:
* platform/mac/fast/objc/dom-html-select-activate.html:
* platform/mac/fast/objc/longlongTest.html:
* platform/qt/view/fixed-layout-size.html:
* platform/win/inverted-colors/non-composited.html:
* platform/win/svg/W3C-SVG-1.1/resources/run-webkit-tests-epilogue.html:
* platform/win/svg/W3C-SVG-1.1/resources/run-webkit-tests-prologue.html:
* webarchive/loading/resources/javascript-url-iframe-crash.webarchive:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSome tests still refer to layoutTestController instead of testRunner
rniwa@webkit.org [Sat, 4 Aug 2012 06:26:36 +0000 (06:26 +0000)]
Some tests still refer to layoutTestController instead of testRunner
https://bugs.webkit.org/show_bug.cgi?id=93176

Reviewed by Adam Barth.

Apparently there are still some tests referring to layoutTestController.
Removed all of them as found by spotlight.

* batterystatus/script-tests/event-after-navigation.js:
* editing/deleting/smart-editing-disabled.html:
* fast/dom/Geolocation/script-tests/callback-exception.js:
* fast/dom/Geolocation/script-tests/clear-watch-invalid-id-crash.js:
* fast/dom/Geolocation/script-tests/disconnected-frame-permission-denied.js:
* fast/dom/Geolocation/script-tests/error.js:
* fast/dom/Geolocation/script-tests/maximum-age.js:
* fast/dom/Geolocation/script-tests/multiple-requests.js:
* fast/dom/Geolocation/script-tests/no-page-cache.js:
* fast/dom/Geolocation/script-tests/permission-denied-already-clear-watch.js:
* fast/dom/Geolocation/script-tests/permission-denied-already-error.js:
* fast/dom/Geolocation/script-tests/permission-denied-already-success.js:
* fast/dom/Geolocation/script-tests/permission-denied-stops-watches.js:
* fast/dom/Geolocation/script-tests/permission-denied.js:
* fast/dom/Geolocation/script-tests/position-string.js:
* fast/dom/Geolocation/script-tests/reentrant-error.js:
* fast/dom/Geolocation/script-tests/reentrant-permission-denied.js:
* fast/dom/Geolocation/script-tests/reentrant-success.js:
* fast/dom/Geolocation/script-tests/success.js:
* fast/dom/Geolocation/script-tests/timeout.js:
* fast/dom/Geolocation/script-tests/watch.js:
* fast/dom/Geolocation/script-tests/window-close-crash.js:
* fast/encoding/resources/char-encoding-utils.js:
(testsDone):
* fast/encoding/resources/dynamic-load-target.js:
* fast/encoding/resources/invalid-xml.js:
(runNextTest):
* fast/encoding/resources/parser-tests.js:
(dotest.window.receivedResults):
(dotest):
* fast/events/touch/script-tests/touch-slider-no-js-touch-listener.js:
* fast/events/touch/script-tests/touch-slider.js:
(onKeyDown):
* fast/harness/override-preferences-2-expected.txt:
* fast/harness/override-preferences-2.html:
* fast/harness/override-preferences-expected.txt:
* fast/harness/override-preferences.html:
* fast/harness/override-zzz-reset-expected.txt:
* fast/harness/override-zzz-reset.html:
* fast/harness/resources/results-test.js:
* fast/harness/use-page-cache-expected.txt:
* fast/harness/use-page-cache.html:
* fast/ruby/after-block-doesnt-crash.html-disabled:
* fast/ruby/after-table-doesnt-crash.html-disabled:
* fast/ruby/generated-after-counter-doesnt-crash.html-disabled:
* fast/ruby/generated-before-and-after-counter-doesnt-crash.html-disabled:
* http/tests/eventsource/eventsource-events-after-close.html:
* http/tests/misc/gmail-assert-on-load.html:
* http/tests/misc/resources/char-encoding-in-hidden-charset-field.php:
* http/tests/misc/resources/check-keygen-post.php:
* http/tests/misc/resources/check-query-param.php:
* http/tests/misc/resources/check-unnamed-file-included-in-formdata.php:
* http/tests/misc/resources/chromium-selectionAsMarkup.html:
* http/tests/misc/resources/delayed-log.php:
* http/tests/misc/resources/form-post-textplain.php:
* http/tests/misc/resources/location-test-xsl-style-sheet.xsl:
* http/tests/misc/resources/percent-sign-in-form-data-field-name.cgi:
* http/tests/misc/resources/post-echo-and-notify-done.cgi:
* http/tests/misc/resources/prefetch-purpose.php:
* http/tests/misc/resources/redirect-result.php:
* http/tests/misc/resources/referrer-main-resource.php:
* http/tests/misc/resources/referrer-result.php:
* http/tests/misc/xhtml.php:
* http/tests/misc/xmltokenizer-do-not-crash.pl:
* http/tests/multipart/multipart-replace-non-html-content.php:
* http/tests/multipart/policy-ignore-crash.php:
* http/tests/multipart/win-boundary-crash.html-disabled:
* http/tests/navigation/post-goback-repost-policy.html-disabled:
* http/tests/navigation/resources/back-send-referrer-helper.php:
* http/tests/navigation/resources/check-ping.php:
* http/tests/navigation/resources/document-location.js:
(start):
* http/tests/navigation/resources/form-target.pl:
* http/tests/navigation/resources/goback-with-policydelegate.php:
* http/tests/navigation/resources/no-referrer-helper.php:
* http/tests/navigation/resources/no-referrer-same-window-helper.php:
* http/tests/navigation/resources/notify-done.html:
* http/tests/navigation/resources/post-target-policy-test.php:
* http/tests/navigation/resources/redirect-cycle-1.pl:
* http/tests/navigation/resources/redirect302-metaredirect.pl:
* http/tests/navigation/resources/redirected-post-request-contents.php:
* http/tests/navigation/resources/submit-to-fragment.pl:
* http/tests/navigation/resources/testcode.js:
(runBasicTest):
(runBackTest):
(runLoadChildFrameTest):
(runLoadChildFrameBackTest):
(runReloadTest):
(runLoadSameTest):
(runRedirectReloadTest):
* http/tests/navigation/useragent.php:
* http/tests/resources/js-test-post.js:
* http/tests/resources/js-test-pre.js:
(finishJSTest):
* http/tests/security/contentSecurityPolicy/resources/securitypolicy-tests-base.js:
* http/tests/ssl/resources/no-http-referer.cgi:
* http/tests/ssl/verify-ssl-enabled.php:
* networkinformation/script-tests/event-after-navigation.js:
* platform/mac/fast/objc/script-tests/webScriptObject-hasWebScriptKey.js:
* platform/qt/svg/repaint/filter-repaint-expected.txt:
* transforms/3d/hit-testing/resources/hit-test-utils.js:
* transforms/3d/point-mapping/point-mapping-helpers.js:
(runTest):
* transitions/resources/transition-test-helpers.js:
(expected):
* transitions/transition-end-event-helpers.js:
(runTransitionTest.processEndEvents):
* webaudio/resources/audio-codec-test.js:
(runDecodingTest):
(finishedLoading):
* webaudio/resources/audio-testing.js:
(finishAudioTest):
* webaudio/resources/audioparam-testing.js:
(createAudioGraphAndTest):
* webaudio/resources/oscillator-testing.js:
(generateExponentialOscillatorSweep):
* webintents/resources/web-intents-testing.js:
(onSuccess):
(onFailure):
(startIntentWithCallbacks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Layout Test media/media-fragments/TC0080-TC0089.html is slow
fischman@chromium.org [Sat, 4 Aug 2012 06:22:06 +0000 (06:22 +0000)]
[Chromium] Layout Test media/media-fragments/TC0080-TC0089.html is slow
https://bugs.webkit.org/show_bug.cgi?id=77523

Reviewed by Eric Carlson.

Before each of these layouttests contained 10 test cases, and would consistently skate
near the normal layouttest timeout (6s) on chromium, and some were Skipped on wk2 for slowness.
This patch splits out the cases so they each get their own timeout.

* media/media-fragments/TC0001-TC0009-expected.txt: Removed.
* media/media-fragments/TC0001-expected.txt: Added.
* media/media-fragments/TC0001.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0002-expected.txt: Added.
* media/media-fragments/TC0002.html: Renamed from LayoutTests/media/media-fragments/TC0010-TC0019.html.
* media/media-fragments/TC0003-expected.txt: Added.
* media/media-fragments/TC0003.html: Renamed from LayoutTests/media/media-fragments/TC0020-TC0029.html.
* media/media-fragments/TC0004-expected.txt: Added.
* media/media-fragments/TC0004.html: Renamed from LayoutTests/media/media-fragments/TC0030-TC0039.html.
* media/media-fragments/TC0005-expected.txt: Added.
* media/media-fragments/TC0005.html: Renamed from LayoutTests/media/media-fragments/TC0040-TC0049.html.
* media/media-fragments/TC0006-expected.txt: Added.
* media/media-fragments/TC0006.html: Renamed from LayoutTests/media/media-fragments/TC0050-TC0059.html.
* media/media-fragments/TC0009-expected.txt: Added.
* media/media-fragments/TC0009.html: Renamed from LayoutTests/media/media-fragments/TC0060-TC0069.html.
* media/media-fragments/TC0010-TC0019-expected.txt: Removed.
* media/media-fragments/TC0011-expected.txt: Added.
* media/media-fragments/TC0011.html: Renamed from LayoutTests/media/media-fragments/TC0070-TC0079.html.
* media/media-fragments/TC0012-expected.txt: Added.
* media/media-fragments/TC0012.html: Renamed from LayoutTests/media/media-fragments/TC0080-TC0089.html.
* media/media-fragments/TC0014-expected.txt: Added.
* media/media-fragments/TC0014.html: Renamed from LayoutTests/media/media-fragments/TC0090-TC0099.html.
* media/media-fragments/TC0015-expected.txt: Added.
* media/media-fragments/TC0015.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0017-expected.txt: Added.
* media/media-fragments/TC0017.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0020-TC0029-expected.txt: Removed.
* media/media-fragments/TC0024-expected.txt: Added.
* media/media-fragments/TC0024.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0027-expected.txt: Added.
* media/media-fragments/TC0027.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0028-expected.txt: Added.
* media/media-fragments/TC0028.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0029-expected.txt: Added.
* media/media-fragments/TC0029.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0030-TC0039-expected.txt: Removed.
* media/media-fragments/TC0030-expected.txt: Added.
* media/media-fragments/TC0030.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0031-expected.txt: Added.
* media/media-fragments/TC0031.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0032-expected.txt: Added.
* media/media-fragments/TC0032.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0033-expected.txt: Added.
* media/media-fragments/TC0033.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0034-expected.txt: Added.
* media/media-fragments/TC0034.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0035-expected.txt: Added.
* media/media-fragments/TC0035.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0036-expected.txt: Added.
* media/media-fragments/TC0036.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0037-expected.txt: Added.
* media/media-fragments/TC0037.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0038-expected.txt: Added.
* media/media-fragments/TC0038.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0039-expected.txt: Added.
* media/media-fragments/TC0039.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0044-expected.txt: Renamed from LayoutTests/media/media-fragments/TC0040-TC0049-expected.txt.
* media/media-fragments/TC0044.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0050-TC0059-expected.txt: Removed.
* media/media-fragments/TC0051-expected.txt: Added.
* media/media-fragments/TC0051.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0052-expected.txt: Added.
* media/media-fragments/TC0052.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0053-expected.txt: Added.
* media/media-fragments/TC0053.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0054-expected.txt: Added.
* media/media-fragments/TC0054.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0055-expected.txt: Added.
* media/media-fragments/TC0055.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0058-expected.txt: Added.
* media/media-fragments/TC0058.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0059-expected.txt: Added.
* media/media-fragments/TC0059.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0060-TC0069-expected.txt: Removed.
* media/media-fragments/TC0061-expected.txt: Added.
* media/media-fragments/TC0061.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0062-expected.txt: Added.
* media/media-fragments/TC0062.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0063-expected.txt: Added.
* media/media-fragments/TC0063.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0064-expected.txt: Added.
* media/media-fragments/TC0064.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0065-expected.txt: Added.
* media/media-fragments/TC0065.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0066-expected.txt: Added.
* media/media-fragments/TC0066.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0067-expected.txt: Added.
* media/media-fragments/TC0067.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0068-expected.txt: Added.
* media/media-fragments/TC0068.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0069-expected.txt: Added.
* media/media-fragments/TC0069.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0070-TC0079-expected.txt: Removed.
* media/media-fragments/TC0070-expected.txt: Added.
* media/media-fragments/TC0070.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0071-expected.txt: Added.
* media/media-fragments/TC0071.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0072-expected.txt: Added.
* media/media-fragments/TC0072.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0073-expected.txt: Added.
* media/media-fragments/TC0073.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0074-expected.txt: Added.
* media/media-fragments/TC0074.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0075-expected.txt: Added.
* media/media-fragments/TC0075.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0076-expected.txt: Added.
* media/media-fragments/TC0076.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0077-expected.txt: Added.
* media/media-fragments/TC0077.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0078-expected.txt: Added.
* media/media-fragments/TC0078.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0079-expected.txt: Added.
* media/media-fragments/TC0079.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0080-TC0089-expected.txt: Removed.
* media/media-fragments/TC0080-expected.txt: Added.
* media/media-fragments/TC0080.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0081-expected.txt: Added.
* media/media-fragments/TC0081.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0082-expected.txt: Added.
* media/media-fragments/TC0082.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0083-expected.txt: Added.
* media/media-fragments/TC0083.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0084-expected.txt: Added.
* media/media-fragments/TC0084.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0085-expected.txt: Added.
* media/media-fragments/TC0085.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0086-expected.txt: Added.
* media/media-fragments/TC0086.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0087-expected.txt: Added.
* media/media-fragments/TC0087.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0088-expected.txt: Added.
* media/media-fragments/TC0088.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0089-expected.txt: Added.
* media/media-fragments/TC0089.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0090-TC0099-expected.txt: Removed.
* media/media-fragments/TC0090-expected.txt: Added.
* media/media-fragments/TC0090.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0091-expected.txt: Added.
* media/media-fragments/TC0091.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0092-expected.txt: Added.
* media/media-fragments/TC0092.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0093-expected.txt: Added.
* media/media-fragments/TC0093.html: Copied from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/TC0094-expected.txt: Added.
* media/media-fragments/TC0094.html: Renamed from LayoutTests/media/media-fragments/TC0001-TC0009.html.
* media/media-fragments/media-fragments.js:
(pause):
(canplaythrough):
(start):
* platform/chromium/TestExpectations:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisabling eval changes the timing of DidCreateScriptContext
abarth@webkit.org [Sat, 4 Aug 2012 04:08:43 +0000 (04:08 +0000)]
Disabling eval changes the timing of DidCreateScriptContext
https://bugs.webkit.org/show_bug.cgi?id=92189

Reviewed by Eric Seidel.

When we implemented Content-Security-Policy, we added the ability to
disable eval in the JavaScript engine. However, when we process the
Content-Security-Policy header, we might not have initialized the
script context for the given frame.

Previously, we would initialize the context, but that generates a
DidCreateScriptContext callback to the embedder earlier in the Document's
lifetime that before. A natural thing to do in this callback is to run
script to customize the script context, but Document isn't fully
initialized yet, which leads to odd bugs and general confusion.

In this patch, we delay actually disabling eval until we would have
created the scripting context previously. From the perspective of the
web platform, this has the same behavior. The only difference is that
now the DidCreateScriptContext notification occurs at the same time
regardless of whether Content-Security-Policy disables eval.

I tried to write a test for this change, but it was unclear to me how
to write a good test. I tried writing a Chromium WebKit unit test to no
avail. The good news is that this patch will be covered by the
PlatformAppBrowserTest.Iframes test in Chromium once
https://bugs.webkit.org/show_bug.cgi?id=93079 lands. That's not the
best way to test this change, but it might be sufficient.

* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::disableEval):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::enableEval):
(WebCore::ScriptController::disableEval):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add API to make it possible to request all variants of a WebImage
thakis@chromium.org [Sat, 4 Aug 2012 03:25:21 +0000 (03:25 +0000)]
[chromium] Add API to make it possible to request all variants of a WebImage
https://bugs.webkit.org/show_bug.cgi?id=92933

Reviewed by Adam Barth.

Part of http://crbug.com/138550

Source/Platform:

* chromium/public/WebImage.h:
(WebImage):

Source/WebKit/chromium:

* src/WebImageSkia.cpp:
(WebKit::WebImage::framesFromData):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Layout Test http/tests/media/media-source/webm/video-media-source-*.html...
fischman@chromium.org [Sat, 4 Aug 2012 03:13:38 +0000 (03:13 +0000)]
[Chromium] Layout Test http/tests/media/media-source/webm/video-media-source-*.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=85952

Unreviewed test expectation update.

Test fixed by http://crrev.com/149702.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomedia/media-fragments/TC0030-TC0039.html sometimes times out on Chromium Windows
fischman@chromium.org [Sat, 4 Aug 2012 02:45:07 +0000 (02:45 +0000)]
media/media-fragments/TC0030-TC0039.html sometimes times out on Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=76967

Unreviewed, test expectation change only.

These media/media-fragments/TC00X0-TC00X9.html tests each test 10 test cases, and consistently skate in the 6-8s range. Marking them as SLOW.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse testRunner instead of layoutTestController in the remaining layout tests
rniwa@webkit.org [Sat, 4 Aug 2012 02:40:10 +0000 (02:40 +0000)]
Use testRunner instead of layoutTestController in the remaining layout tests
https://bugs.webkit.org/show_bug.cgi?id=93172

Reviewed by Adam Barth.

One last sweeping patch.

* accessibility/canvas-accessibilitynodeobject.html:
* compositing/backface-visibility/backface-visibility-webgl.html:
* compositing/fixed-position-scroll-offset-history-restore.html:
* compositing/overflow/image-load-overflow-scrollbars.html:
* css3/flexbox/flexitem.html:
* dom/html/level1/core/selfhtml.js:
(startTest):
* dom/html/level2/core/selfhtml.js:
(startTest):
* dom/html/level2/events/selfhtml.js:
(startTest):
* dom/html/level2/html/AppletsCollection.html:
* dom/html/level2/html/HTMLBaseElement01.html:
* dom/html/level2/html/HTMLBaseElement02.html:
* dom/html/level2/html/selfhtml.js:
(startTest):
* dom/svg/level3/xpath/svgunit.js:
* dom/xhtml/level1/core/selfxhtml.js:
(startTest):
* dom/xhtml/level2/core/selfxhtml.js:
(startTest):
* dom/xhtml/level2/events/selfxhtml.js:
(startTest):
* dom/xhtml/level2/html/HTMLBaseElement01.xhtml:
* dom/xhtml/level2/html/HTMLBaseElement02.xhtml:
* dom/xhtml/level2/html/selfxhtml.js:
(startTest):
* dom/xhtml/level3/core/selfxhtml.js:
(startTest):
* editing/shadow/adjusting-editing-boundary-with-table-in-shadow.html:
* editing/shadow/bold-twice-in-shadow.html:
* editing/shadow/breaking-editing-boundaries-2.html:
* editing/shadow/contenteditable-propagation-at-shadow-boundary.html:
* editing/shadow/delete-characters-in-distributed-node-crash.html:
* editing/shadow/delete-list-in-shadow.html:
* editing/shadow/insertorderedlist-crash.html:
* editing/shadow/pressing-enter-on-list.html:
* editing/spelling/grammar-edit-word-expected.txt:
* editing/spelling/grammar-edit-word.html:
* fast/block/percent-height-descendant-not-removed-crash2.html:
* fast/block/positioning/abspositioned-object-under-split-relpositioned-inline-crash.html:
* fast/block/positioning/insert-positioned-in-anonymous-crash.html:
* fast/canvas/fallback-content.html:
* fast/css/counters/counter-reset-subtree-insert-crash.html:
* fast/css/crash-on-gradient-with-derived-color.html:
* fast/dom/NodeList/childNodes-reverse-iteration.html:
* fast/dom/Window/window-property-shadowing-onclick.html:
* fast/dom/XMLSerializer-xml-namespace.html:
* fast/dom/shadow/content-after-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline MathML pixel tests with STIX fonts for Lion
dbarton@mathscribe.com [Sat, 4 Aug 2012 02:37:34 +0000 (02:37 +0000)]
Rebaseline MathML pixel tests with STIX fonts for Lion
https://bugs.webkit.org/show_bug.cgi?id=93163

Reviewed by Eric Seidel.

This is gardening in response to https://bugs.webkit.org/show_bug.cgi?id=93073, which
followed https://bugs.webkit.org/show_bug.cgi?id=43819. The latter turned on the STIX
fonts in the testing tools, and apparently the STIX fonts or their handling have been
changed (apparently improved) between Snow Leopard and Lion. I am therefore moving my
10 *-expected.txt files below to platform/mac-snowleopard, and putting the slightly
improved metrics in the 10 files in platform/mac.

* platform/mac-snowleopard/mathml: Added.
* platform/mac-snowleopard/mathml/presentation: Added.
* platform/mac-snowleopard/mathml/presentation/attributes-expected.txt: Added.
* platform/mac-snowleopard/mathml/presentation/fenced-mi-expected.txt: Added.
* platform/mac-snowleopard/mathml/presentation/fractions-expected.txt: Added.
* platform/mac-snowleopard/mathml/presentation/mo-expected.txt: Added.
* platform/mac-snowleopard/mathml/presentation/over-expected.txt: Added.
* platform/mac-snowleopard/mathml/presentation/roots-expected.txt: Added.
* platform/mac-snowleopard/mathml/presentation/row-expected.txt: Added.
* platform/mac-snowleopard/mathml/presentation/sub-expected.txt: Added.
* platform/mac-snowleopard/mathml/presentation/tokenElements-expected.txt: Added.
* platform/mac-snowleopard/mathml/presentation/underover-expected.txt: Added.
* platform/mac/mathml/presentation/attributes-expected.txt:
* platform/mac/mathml/presentation/fenced-mi-expected.txt:
* platform/mac/mathml/presentation/fractions-expected.txt:
* platform/mac/mathml/presentation/mo-expected.txt:
* platform/mac/mathml/presentation/over-expected.txt:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/row-expected.txt:
* platform/mac/mathml/presentation/sub-expected.txt:
* platform/mac/mathml/presentation/tokenElements-expected.txt:
* platform/mac/mathml/presentation/underover-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Stop relying on implicit WebFoo <-> WebCore conversion operators in compositor
jamesr@google.com [Sat, 4 Aug 2012 01:39:31 +0000 (01:39 +0000)]
[chromium] Stop relying on implicit WebFoo <-> WebCore conversion operators in compositor
https://bugs.webkit.org/show_bug.cgi?id=93169

Reviewed by Adrienne Walker.

This removes the compositor's reliance on implicit conversion operators from Web* types to WebKit-internal
types, specifically WebRect <-> WebCore::IntRect and WebString <-> WTF::String.

* platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:
(WebCore::CanvasLayerTextureUpdater::paintContents):
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::getFramebufferPixels):
* platform/graphics/chromium/ScrollbarLayerChromium.cpp:
(WebCore::ScrollbarLayerChromium::setTexturePriorities):
(WebCore::ScrollbarLayerChromium::update):
* platform/graphics/chromium/cc/CCFontAtlas.cpp:
(WebCore::CCFontAtlas::drawOneLineOfTextInternal):
* platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:
(WebCore::CCHeadsUpDisplayLayerImpl::drawFPSCounter):
(WebCore::CCHeadsUpDisplayLayerImpl::drawDebugRects):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::toUVRect):
(WebCore::CCScrollbarLayerImpl::appendQuads):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::size):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Cross-thread-copy a couple more recently added ResourceResponse data membe...
michaeln@google.com [Sat, 4 Aug 2012 01:28:22 +0000 (01:28 +0000)]
[Chromium] Cross-thread-copy a couple more recently added ResourceResponse data members, apparently
these got missed when they were added. And fix a bug with how the m_remoteIPAddress
data member is handled, an isolatedCopy() is needed for thread safety.
https://bugs.webkit.org/show_bug.cgi?id=93158

Reviewed by David Levin.

No new tests, minor cleanup.

* platform/network/chromium/ResourceResponse.cpp:
(WebCore::ResourceResponse::doPlatformCopyData): make deep copies
(WebCore::ResourceResponse::doPlatformAdopt): take ownership of them
* platform/network/chromium/ResourceResponse.h:
(ResourceResponse):
(CrossThreadResourceResponseData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[SVG] Tref target event listener cleanup
fmalita@chromium.org [Sat, 4 Aug 2012 01:23:58 +0000 (01:23 +0000)]
[SVG] Tref target event listener cleanup
https://bugs.webkit.org/show_bug.cgi?id=93004

Reviewed by Abhishek Arya.

Source/WebCore:

Currently SVGTRefElement allocates event listeners dynamically as it attaches to its
targets. Synchronizing the lifetime of the target listener vs. the tref element is
error prone, as various events can stack and trigger nested handlers.

In order to reduce complexity and address a couple of outstanding issues, this patch
changes the way event listeners are allocated: only one target listener is created
for the lifetime of the SVGTRefElement, and gets reused if the target element changes.

Test: svg/custom/tref-nested-events-crash.svg

* dom/EventListener.h:
Added new <tref> target event listener type.
* svg/SVGTRefElement.cpp:
(WebCore):
(WebCore::SVGTRefTargetEventListener::create):
(WebCore::SVGTRefTargetEventListener::cast):
(SVGTRefTargetEventListener):
(WebCore::SVGTRefTargetEventListener::isAttached):
(WebCore::SVGTRefTargetEventListener::SVGTRefTargetEventListener):
(WebCore::SVGTRefTargetEventListener::attach):
(WebCore::SVGTRefTargetEventListener::detach):
(WebCore::SVGTRefTargetEventListener::operator==):
(WebCore::SVGTRefTargetEventListener::handleEvent):
No need to check m_trefElement anymore - the listener is allocated for the whole element
lifetime, detached when the element is removed and deallocated when the element is
destroyed.
(WebCore::SVGTRefElement::SVGTRefElement):
Allocate one target listener per element, at construction time.
(WebCore::SVGTRefElement::~SVGTRefElement):
Detach the listener if necessary.
(WebCore::SVGTRefElement::detachTarget):
Check whether the element is still in document after updating the text (may have been
removed by event handlers).
(WebCore::SVGTRefElement::buildPendingResource):
Attach the event listener before updating the text content to avoid racing with event
handlers (which can remove the element).
(WebCore::SVGTRefElement::removedFrom):
* svg/SVGTRefElement.h:
(WebCore):
(SVGTRefElement):

LayoutTests:

* svg/custom/tref-nested-events-crash-expected.txt: Added.
* svg/custom/tref-nested-events-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse testRunner instead of layoutTestController in fast/scrolling through fast/xsl...
rniwa@webkit.org [Sat, 4 Aug 2012 01:13:22 +0000 (01:13 +0000)]
Use testRunner instead of layoutTestController in fast/scrolling through fast/xsl tests
https://bugs.webkit.org/show_bug.cgi?id=92947

Reviewed by Kent Tamura.

* fast/scrolling/resources/scrollable-area.js:
* fast/selectors/empty-element-made-non-empty.html:
* fast/selectors/querySelector-in-range-crash.html:
* fast/selectors/selection-window-inactive.html:
* fast/selectors/style-sharing-adjacent-selector.html:
* fast/selectors/style-sharing-last-child.html:
* fast/spatial-navigation/:
* fast/storage/storage-detached-iframe.html:
* fast/sub-pixel/client-width-height-snapping.html:
* fast/sub-pixel/float-containing-block-with-margin.html:
* fast/sub-pixel/table-rows-have-stable-height.html:
* fast/table/:
* fast/text/:
* fast/tokenizer/:
* fast/transforms/container-transform-crash.html:
* fast/transforms/matrix-with-zoom.html:
* fast/transforms/scrollIntoView-transformed.html:
* fast/transforms/selection-bounds-in-transformed-view.html:
* fast/transforms/topmost-becomes-bottomost-for-scrolling.html:
* fast/transforms/transform-hit-test-flipped.html:
* fast/transforms/transform-inside-overflow-scroll.html:
* fast/url/degenerate-file-base.html:
* fast/viewport/:
* fast/workers/:
* fast/writing-mode/auto-margins-across-boundaries.html:
* fast/writing-mode/block-formatting-context.html:
* fast/writing-mode/broken-ideographic-font.html:
* fast/writing-mode/display-mutation.html:
* fast/writing-mode/flipped-blocks-hit-test-overflow.html:
* fast/writing-mode/flipped-blocks-text-map-local-to-container.html:
* fast/writing-mode/japanese-rl-text-with-broken-font.html:
* fast/writing-mode/overhanging-float-legend-crash.html:
* fast/writing-mode/percentage-padding.html:
* fast/writing-mode/positionForPoint.html:
* fast/writing-mode/relative-positioning-percentages.html:
* fast/writing-mode/table-hit-test.html:
* fast/xmlhttprequest/null-document-xmlhttprequest-open.html:
* fast/xmlhttprequest/resources/xmlhttprequest-no-file-access-real.html:
* fast/xmlhttprequest/resources/xmlhttprequest-nonexistent-file-real.html:
* fast/xmlhttprequest/xmlhttprequest-bad-mimetype.html:
* fast/xmlhttprequest/xmlhttprequest-gc.html:
* fast/xmlhttprequest/xmlhttprequest-get.xhtml:
* fast/xmlhttprequest/xmlhttprequest-html-response-encoding.html:
* fast/xmlhttprequest/xmlhttprequest-invalid-values.html:
* fast/xmlhttprequest/xmlhttprequest-missing-file-exception.html:
* fast/xmlhttprequest/xmlhttprequest-no-file-access.html:
* fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html:
* fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html:
* fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html:
* fast/xmlhttprequest/xmlhttprequest-responsetype-abort.html:
* fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html:
* fast/xmlhttprequest/xmlhttprequest-responsetype-document.html:
* fast/xmlhttprequest/xmlhttprequest-responsetype-text.html:
* fast/xpath/4XPath/Borrowed/namespace-nodes.html:
* fast/xpath/ancestor-axis.html:
* fast/xpath/complex-id.html:
* fast/xpath/empty-string-substring.html:
* fast/xpath/ensure-null-namespace.xhtml:
* fast/xpath/id-path.html:
* fast/xpath/id-simple.html:
* fast/xpath/implicit-node-args.html:
* fast/xpath/name-null-namespace.html:
* fast/xpath/namespace-vs-predicate.xhtml:
* fast/xpath/nan-to-boolean.html:
* fast/xpath/nodeset-duplicates.html:
* fast/xpath/nsresolver-bad-object.xhtml:
* fast/xpath/nsresolver-exception.xhtml:
* fast/xpath/nsresolver-function.xhtml:
* fast/xpath/nsresolver-object.xhtml:
* fast/xpath/preceding-axis.xhtml:
* fast/xpath/text-nodes.html:
* fast/xpath/union-context-node.xhtml:
* fast/xpath/xpath-detached-iframe-resolver-crash.html:
* fast/xpath/xpath-empty-string.html:
* fast/xpath/xpath-functional-test.html:
* fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html:
* fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset.html:
* fast/xpath/xpath-result-eventlistener-crash.html:
* fast/xpath/xpath-snapshot-result-should-mark-its-nodeset.html:
* fast/xsl/default-html.html:
* fast/xsl/exslt-node-set.xsl:
* fast/xsl/extra-lf-at-end.html:
* fast/xsl/import-non-document-node.xhtml:
* fast/xsl/mozilla-tests.xsl:
* fast/xsl/nbsp-in-stylesheet.html:
* fast/xsl/resources/dtd-in-source-document.xsl:
* fast/xsl/resources/import-after-comment-transform.xsl:
* fast/xsl/resources/to-html.xsl:
* fast/xsl/resources/xslt-entity-enc.xsl:
* fast/xsl/resources/xslt-nested-stylesheets1.xsl:
* fast/xsl/resources/xslt-recursion-chain1.xsl:
* fast/xsl/resources/xslt-second-level-import.xsl:
* fast/xsl/sort-locale.xsl:
* fast/xsl/sort-unicode.xsl:
* fast/xsl/subframe-location.html:
* fast/xsl/transform-xhr-doc.xhtml:
* fast/xsl/transformToFragment-XML-declaration.html:
* fast/xsl/utf8-chunks.xsl:
* fast/xsl/xslt-bad-import-uri.html:
* fast/xsl/xslt-doc-enc.xsl:
* fast/xsl/xslt-doc-noenc.xsl:
* fast/xsl/xslt-fragment-in-empty-doc.html:
* fast/xsl/xslt-processor.html:
* fast/xsl/xslt-string-parameters.html:
* fast/xsl/xslt-text.html:
* fast/xsl/xslt-transform-to-fragment-crash.html:
* fast/xsl/xslt-url.xsl:
* platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning.html:
* platform/chromium-linux/fast/text/international/arabic-vertical-offset.html:
* platform/chromium-linux/fast/text/international/draw-complex-text-from-to.html:
* platform/chromium/fast/text/chromium-mac-duplicate-ime-composition.html:
* platform/chromium/fast/text/font-linux-normalize.html:
* platform/chromium/fast/text/international/complex-text-rectangle.html:
* platform/mac/fast/text/attributed-substring-from-range-001.html:
* platform/mac/fast/text/attributed-substring-from-range-002.html:
* platform/mac/fast/text/attributed-substring-from-range-in-textfield.html:
* platform/mac/fast/text/attributed-substring-from-range.html:
* platform/mac/fast/text/core-text-fallback-to-unknown-font.html:
* platform/mac/fast/text/justified-text-rect.html:
* platform/mac/fast/text/myanmar-shaping.html:
* platform/mac/fast/text/thai-combining-mark-positioning.html:
* platform/mac/fast/text/webfont-after-tiny-monospace-text.html:
* platform/qt/fast/spatial-navigation/resources/ensure-scrolls-with-scrollbars-disabled-by-webkit.html:
* platform/qt/fast/spatial-navigation/snav-ensure-scrolls-with-scrollbars-disabled-by-webkit.html:
* platform/win/fast/text/uniscribe-item-boundary-crash.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert HTML parser to handle 8-bit resources without converting to UChar*
msaboff@apple.com [Sat, 4 Aug 2012 01:07:49 +0000 (01:07 +0000)]
Convert HTML parser to handle 8-bit resources without converting to UChar*
https://bugs.webkit.org/show_bug.cgi?id=90321

Reviewed by Adam Barth.

Source/WebCore:

No new tests, no new functionality therefore covered by existing tests.

Changed the parsing of HTML to handle 8-bit strings without converting the
whole string to 16-bits.  Primary change was to use the appropriate
character pointer type (LChar* or UChar*) depending on the source string.
This access is abstracted in SegmentedSubstring by getCurrentChar{8,16} and
incrementAndGetCurrentChar{8,16} methods.  In SegmentedString, the advance()
and advanceAndUpdateLineNumber() methods have been refactored into a
state machine managed pair of function pointers.  The possible functions
have not only the 8 and 16 bitness factored out, they also have the
"exclude line numbers" logic factored out for advanceAndUpdateLineNumber().
This change also has improvements over http://trac.webkit.org/changeset/123679.
The most prominent change was to inline the 8 bit paths for both advance()
and advanceAndUpdateLineNumber().
This provides a net speed-up even with the 8/16 bit testing.
Other changes involve using String methods to access and compare with the
source data.

* html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::append): Changed to use currentChar()
instead of SegmentedString '*' operator.
* html/parser/HTMLEntityParser.cpp: Changed to use currentChar() instead of
SegmentedString '*' operator.
* html/parser/HTMLParserIdioms.cpp:
(WebCore::stripLeadingAndTrailingHTMLSpaces): Added 8-bit fast path.
* html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::sourceForToken): Changed to use currentChar() instead of
SegmentedString '*' operator.
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::script): Updated to use new String::dataSize() method.
* platform/text/SegmentedString.cpp:
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::operator=):
(WebCore::SegmentedString::clear):
(WebCore::SegmentedString::append):
(WebCore::SegmentedString::prepend):
(WebCore::SegmentedString::advanceSubstring):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::advance8): Fast path advance function for 8 bit data.
(WebCore::SegmentedString::advance16): Fast path advance function for 16 bit data.
(WebCore::SegmentedString::advanceAndUpdateLineNumber8): Fast path
advanceAndUpdateLineNumber for 8 bit data when we need to update the line number.
(WebCore::SegmentedString::advanceAndUpdateLineNumber16): Fast path
advanceAndUpdateLineNumber for 16 bit data when we need to update the line number.
(WebCore::SegmentedString::advanceSlowCase): Slow case advance function for both
8 and 16 bit advance.
(WebCore::SegmentedString::advanceAndUpdateLineNumberSlowCase): Slow case
advanceAndUpdateLineNumber function for both 8 and 16 bit data.
(WebCore::SegmentedString::advanceEmpty): Advance function when input has been exhausted.
(WebCore::SegmentedString::updateSlowCaseFunctionPointers): Set advance function
pointers to slow case functions.
* platform/text/SegmentedString.h:
(WebCore::SegmentedSubstring::SegmentedSubstring):
(WebCore::SegmentedSubstring::clear):
(SegmentedSubstring):
(WebCore::SegmentedSubstring::is8Bit): New getter.
(WebCore::SegmentedSubstring::appendTo):
(WebCore::SegmentedSubstring::getCurrentChar8): New getter for the 8 bit case.
(WebCore::SegmentedSubstring::getCurrentChar16): New getter for the 16 bit case.
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar8): New wrapper functions
that pre-increments the 8 bit pointer and returns the next character.
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar16): New wrapper functions
that pre-increments the 16 bit pointer and returns the next character.
(WebCore::SegmentedSubstring::currentSubString):
(WebCore::SegmentedSubstring::getCurrentChar):
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar):
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::push):
(WebCore::SegmentedString::isEmpty):
(WebCore::SegmentedString::lookAhead):
(WebCore::SegmentedString::lookAheadIgnoringCase):
(WebCore::SegmentedString::advance): Wrapper that contains 8 bit fast path
or calls via member function point to approriate advance() flavor.
(WebCore::SegmentedString::advanceAndUpdateLineNumber): Wrapper that
contains 8 bit fast path or calls via member function point to approriate
advance() flavor.
(WebCore::SegmentedString::advanceAndASSERT):
(WebCore::SegmentedString::advanceAndASSERTIgnoringCase):
(WebCore::SegmentedString::advancePastNonNewline):
(WebCore::SegmentedString::advancePastNewlineAndUpdateLineNumber):
(WebCore::SegmentedString::currentChar):
(WebCore::SegmentedString::decrementAndCheckLength): Decrement substring length and
change to slow case functions when only one character left.
(WebCore::SegmentedString::updateAdvanceFunctionPointers): Select appropriate
advance functions based on current substring.
(WebCore::SegmentedString::lookAheadInline): Changed to use String::startsWith().
(WebCore::SegmentedString::lookAheadSlowCase):
* xml/parser/CharacterReferenceParserInlineMethods.h:
(WebCore::consumeCharacterReference): Changed to use currentChar() instead of
SegmentedString '*' operator.
* xml/parser/MarkupTokenizerBase.h:
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::nextInputCharacter):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek): Changed to use
currentChar() instead of SegmentedString '*' operator.
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance):

Source/WTF:

* wtf/text/WTFString.h:
(WTF::String::dataSize): New method to return the number of bytes
the string requires.  This replaces a harcoded calculation based on
length and sizeof(UChar).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrashes in dfgBuildPutByIdList when clicking on just about anything on Google Maps
fpizlo@apple.com [Sat, 4 Aug 2012 01:01:27 +0000 (01:01 +0000)]
Crashes in dfgBuildPutByIdList when clicking on just about anything on Google Maps
https://bugs.webkit.org/show_bug.cgi?id=92691

Reviewed by Mark Hahnenberg.

The state of the stubs was changing after we determined the type (by virtue of the slow path
function that was called), since the get or put (in this case put) could cause arbitrary
side effects. Perhaps a full-blown fix would be to eliminate our reliance of the slow path
function to determine what to do, but an easier fix for now is to have the slow path give up
if its assumptions were invalidated by a side effect.

* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix Renderer4.CompositorThreadImplDrawDelay histogram.
commit-queue@webkit.org [Sat, 4 Aug 2012 00:40:01 +0000 (00:40 +0000)]
[chromium] Fix Renderer4.CompositorThreadImplDrawDelay histogram.
https://bugs.webkit.org/show_bug.cgi?id=93159

Patch by Dave Tu <dtu@chromium.org> on 2012-08-03
Reviewed by Adrienne Walker.

The histogram is using the frame number instead of the frame time by mistake.

* platform/graphics/chromium/cc/CCFrameRateCounter.cpp:
(WebCore::CCFrameRateCounter::markBeginningOfFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chrome-Android] - Prepare apk tests for switch to checked in SDK.
commit-queue@webkit.org [Sat, 4 Aug 2012 00:31:32 +0000 (00:31 +0000)]
[Chrome-Android] - Prepare apk tests for switch to checked in SDK.
https://bugs.webkit.org/show_bug.cgi?id=92931

Patch by Yaron Friedman <yfriedman@chromium.org> on 2012-08-03
Reviewed by Adam Barth.

Source/WebKit/chromium:

Pass Android-specific gyp variables to the native test generator
avoiding any dependencies on environment variables during build time.

* WebKitUnitTests.gyp:

Tools:

Pass Android-specific gyp variables to the native test generator,
avoiding any dependencies on environment variables during build time.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Core upgradeneeded logic
dgrogan@chromium.org [Sat, 4 Aug 2012 00:28:25 +0000 (00:28 +0000)]
IndexedDB: Core upgradeneeded logic
https://bugs.webkit.org/show_bug.cgi?id=92558

Reviewed by Ojan Vafai.

Source/WebCore:

This is the backend webkit logic needed for integer versions. The rest
is in https://bugs.webkit.org/show_bug.cgi?id=89505.

I tried to make use of the existing processPendingCalls and added two
more queues, pendingOpenWithVersionCalls and
pendingSecondHalfOpenWithVersionCalls. The "second half" refers to
how there are two events that need to be fired in response to an
open-with-version call. The "second half" queue holds the open
requests that should immediately follow the caller's upgradeneeded
handler.

No new tests, there are so many they are in their own patch:
https://bugs.webkit.org/show_bug.cgi?id=92560

Though this patch doesn't change any expected behavior anyway, lack of
regressions is what we're hoping for here.

* Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
* Modules/indexeddb/IDBCallbacks.h:
(WebCore::IDBCallbacks::onBlocked):
(WebCore::IDBCallbacks::onUpgradeNeeded):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(IDBDatabaseBackendImpl::PendingOpenCall):
(IDBDatabaseBackendImpl::PendingOpenWithVersionCall):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::callbacks):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::version):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::PendingOpenWithVersionCall):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::metadata):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::setIntVersionInternal):
(WebCore::IDBDatabaseBackendImpl::transactionFinished):
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndEventsFired):
When an upgradeneeded event is fired in response to an
open-with-version call, the version change transaction must receive its
complete event before processPendingCalls fires a success event at
IDBOpenDBRequest. In the future this should probably be changed
instead to transactionFinishedAndAbortFired and
transactionFinishedAndCompleteFired so that we'll know to fire a
success or error event at IDBOpenDBRequest. Currently, instead of
firing error when there's an abort, we don't fire anything.

(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
Now that this is called after a connection is opened, we unfortunately
lose the invariant that there is only one existing connection when this
is called, but nothing inside this function actually relied on that.
Additionally, the secondHalfOpen calls only ever need to be serviced
in one place: right after a version change transaction completes, so
it could be moved out of here.

(WebCore::IDBDatabaseBackendImpl::registerFrontendCallbacks):
Now that setVersion and deleteDatabase calls are queued up behind
secondHalfOpen calls, we have to service those queues when
secondHalfOpen calls complete, which is here.  So call
processPendingCalls().

(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
(WebCore::IDBDatabaseBackendImpl::close):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseCallbacks.h:
(WebCore::IDBDatabaseCallbacks::onVersionChange):
* Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
This is refactored some so that the call to openConection{WithVersion}
happens once, at the end.

* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseIntVersion):
(WebCore):
(WebCore::IDBLevelDBBackingStore::deleteDatabase):
* Modules/indexeddb/IDBLevelDBBackingStore.h:
(IDBLevelDBBackingStore):
* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::commit):
See above comments about transactionFinishedAndEventsFired. I tried
moving the call to transactionFinished after the events were fired but
that failed some asserts. But changing those asserts is still an
alternative to splitting up transactionFinished as is done here.

Source/WebKit/chromium:

Update overridden methods to match new signatures.

* tests/IDBAbortOnCorruptTest.cpp:
(WebCore::FailingBackingStore::createIDBDatabaseMetaData):
* tests/IDBFakeBackingStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test media/video-currentTime-set2.html is flakily crashing
fischman@chromium.org [Sat, 4 Aug 2012 00:10:30 +0000 (00:10 +0000)]
Layout Test media/video-currentTime-set2.html is flakily crashing
https://bugs.webkit.org/show_bug.cgi?id=92852

Unreviewed, test expectation change only.

The DCHECK in question was removed in http://crrev.com/149452

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDouble tap gesture should send dblclick event
commit-queue@webkit.org [Fri, 3 Aug 2012 23:45:04 +0000 (23:45 +0000)]
Double tap gesture should send dblclick event
https://bugs.webkit.org/show_bug.cgi?id=92412

Patch by Rick Byers <rbyers@chromium.org> on 2012-08-03
Reviewed by Adam Barth.

Source/WebCore:

Propagate the tap count from PlatformGestureEvent in the derived mouse
events.

Also fixes a crash with unexpected GestureDoubleTap events by just
supressing them early.  They will probably be removed soon anyway.

Test: fast/events/touch/gesture/gesture-dblclick.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureTap):

Source/WebKit/chromium:

Tweak comment to more completely describe the (lame) overloaded use
of deltaX in WebGestureEvent, and add a FIXME with the bug to track
cleaning it up.
* public/WebInputEvent.h:
(WebGestureEvent):

Tools:

Enable EventSender to set the tap count on tap gesture events.  The
delta X/Y parameters were not actually being used anymore (used to be
used for radius information).

* DumpRenderTree/chromium/TestRunner/EventSender.cpp:
(EventSender::gestureEvent):

LayoutTests:

Adds test for derived mouse events generated by a sequence of two tap
events.  Modeled after gesture-click.html.
* fast/events/touch/gesture/gesture-dblclick-expected.txt: Added.
* fast/events/touch/gesture/gesture-dblclick.html: Added.
* platform/chromium/fast/events/touch/gesture/gesture-dblclick-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124668.
commit-queue@webkit.org [Fri, 3 Aug 2012 23:39:16 +0000 (23:39 +0000)]
Unreviewed, rolling out r124668.
http://trac.webkit.org/changeset/124668
https://bugs.webkit.org/show_bug.cgi?id=93167

Broke Mac build (Requested by kbr_google on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-03

Source/WebCore:

* bindings/js/JSArrayBufferViewHelper.h:
(WebCore::setWebGLArrayWithTypedArrayArgument):
(WebCore::setWebGLArrayHelper):
(WebCore::constructArrayBufferViewWithTypedArrayArgument):
(WebCore::constructArrayBufferViewWithArrayBufferArgument):
(WebCore::constructArrayBufferView):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore):
(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

LayoutTests:

* fast/canvas/webgl/array-set-invalid-arguments-expected.txt: Removed.
* fast/canvas/webgl/array-set-invalid-arguments.html: Removed.
* fast/canvas/webgl/array-set-out-of-bounds-expected.txt:
* fast/canvas/webgl/data-view-crash-expected.txt:
* fast/canvas/webgl/data-view-test-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement computePreferredLogicalWidths on RenderGrid
jchaffraix@webkit.org [Fri, 3 Aug 2012 23:36:05 +0000 (23:36 +0000)]
Implement computePreferredLogicalWidths on RenderGrid
https://bugs.webkit.org/show_bug.cgi?id=92908

Reviewed by Ojan Vafai.

Source/WebCore:

This functions implements a primitive computePreferredLogicalWidths
so that we properly handle vertical writing modes.

Covered by fast/css-grid-layout/place-cell-by-index.html.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computePreferredLogicalWidths):
* rendering/RenderGrid.h:
Added computePreferredLogicalWidths.

LayoutTests:

* fast/css-grid-layout/place-cell-by-index-expected.txt:
Updated the expected file (everything passes now).
* fast/css-grid-layout/place-cell-by-index.html:
Removed some FIXMEs and added one about the expected offsets making
a wrong assumption. It's fine to keep this testing until we support
this part of the spec.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove assert when getting hardware renderingStats in software mode.
commit-queue@webkit.org [Fri, 3 Aug 2012 23:20:14 +0000 (23:20 +0000)]
[chromium] Remove assert when getting hardware renderingStats in software mode.
https://bugs.webkit.org/show_bug.cgi?id=92325

Patch by Dave Tu <dtu@chromium.org> on 2012-08-03
Reviewed by Adrienne Walker.

If a page caused hardware mode to be turned on, then off, the hardware stats are still valid, so we don't need to assert that we're in hardware mode. Checking if the LayerTreeView is null should be sufficient.

* public/WebWidget.h:
(WebWidget):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::renderingStats):
(WebKit::WebViewImpl::paint):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate TypedArrays to throw RangeError or similar instead of INDEX_SIZE_ERR
commit-queue@webkit.org [Fri, 3 Aug 2012 23:03:15 +0000 (23:03 +0000)]
Update TypedArrays to throw RangeError or similar instead of INDEX_SIZE_ERR
https://bugs.webkit.org/show_bug.cgi?id=45118

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-08-03
Reviewed by Kenneth Russell.

Source/WebCore:

Update TypedArrays to raise JavaScript RangeError instead of dom
INDEX_SIZE_ERR exceptions. Also, update TypedArrays to raise TypeError
instead of JavaScript SyntaxError or dom exceptions SYNTAX_ERR when
calling set method with invalid arguments.

Specification does not define the type of exceptions to raise, but
other browsers raise JavaScript errors, so those changes will improve
compatibility.

New Test: fast/canvas/webgl/array-set-invalid-arguments.html

Updated Tests expectations:
    fast/canvas/webgl/array-set-out-of-bounds.html
    fast/canvas/webgl/data-view-crash.html
    fast/canvas/webgl/data-view-test.html

* bindings/js/JSArrayBufferViewHelper.h:
(WebCore):
(WebCore::setWebGLArrayWithTypedArrayArgument):
(WebCore::setWebGLArrayHelper):
(WebCore::constructArrayBufferViewWithTypedArrayArgument):
(WebCore::constructArrayBufferViewWithArrayBufferArgument):
(WebCore::constructArrayBufferView):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore):
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::setWebGLArrayHelper):

LayoutTests:

New test to test invalid arguments to TypedArray set method

Update array-set-out-of-bounds.html, data-view-crash.html and
data-view-test.html test expectations no match new exceptions thrown.

* fast/canvas/webgl/array-set-invalid-arguments-expected.txt: Added.
* fast/canvas/webgl/array-set-invalid-arguments.html: Added.
* fast/canvas/webgl/array-set-out-of-bounds-expected.txt:
* fast/canvas/webgl/data-view-crash-expected.txt:
* fast/canvas/webgl/data-view-test-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG handling of get_by_id should always inject a ForceOSRExit node if there is no...
fpizlo@apple.com [Fri, 3 Aug 2012 22:42:29 +0000 (22:42 +0000)]
DFG handling of get_by_id should always inject a ForceOSRExit node if there is no prediction
https://bugs.webkit.org/show_bug.cgi?id=93162

Reviewed by Mark Hahnenberg.

This simplifies the DFG IR by ensuring that all nodes that use value profiles will be preceded
by a ForceOSRExit if the value profile had no data.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Fri, 3 Aug 2012 22:35:43 +0000 (22:35 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-03

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSwitch mapLocalToContainer to use a flag instead of boolean parameters
leviw@chromium.org [Fri, 3 Aug 2012 22:23:42 +0000 (22:23 +0000)]
Switch mapLocalToContainer to use a flag instead of boolean parameters
https://bugs.webkit.org/show_bug.cgi?id=92927

Reviewed by Dirk Schulze.

Changing mapLocalToContainer to use a uint flag to set the mode of operation. This removes
simplifies the contract, removes boolean arguments and paves the way for an additional mode
for sub-pixel layout support. See https://bugs.webkit.org/show_bug.cgi?id=89238 for the
sub-pixel use case. Other than the new MapLocalToContainerMode enum and MapLocalToContainerFlags
typedef, this change is purely mechanical.

No new tests as this doesn't change current behavior.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGapRectsForRepaint):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::mapLocalToContainer):
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::mapToAbsolute):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::mapLocalToContainer):
* rendering/RenderInline.h:
(RenderInline):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::localToAbsolute):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::localToContainerQuad):
(WebCore::RenderObject::localToContainerPoint):
* rendering/RenderObject.h:
(RenderObject): Adding the MapLocalToContainerMode enum and MapLocalToContainerFlags unsigned
int, and removing the old ApplyContainerFlipOrNot enum.
* rendering/RenderView.cpp:
(WebCore::RenderView::mapLocalToContainer):
* rendering/RenderView.h:
(RenderView):
* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::mapLocalToContainer):
* rendering/svg/RenderSVGForeignObject.h:
(RenderSVGForeignObject):
* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::mapLocalToContainer):
* rendering/svg/RenderSVGInline.h:
(RenderSVGInline):
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::mapLocalToContainer):
* rendering/svg/RenderSVGModelObject.h:
(RenderSVGModelObject):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::mapLocalToContainer):
* rendering/svg/RenderSVGRoot.h:
(RenderSVGRoot):
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::mapLocalToContainer):
* rendering/svg/RenderSVGText.h:
(RenderSVGText):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::mapLocalToContainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorun-perf-tests should generate JSON output and results page by default
rniwa@webkit.org [Fri, 3 Aug 2012 22:06:54 +0000 (22:06 +0000)]
run-perf-tests should generate JSON output and results page by default
https://bugs.webkit.org/show_bug.cgi?id=93042

Reviewed by Eric Seidel.

Generate results JSON and page named PerfTestResults.json and PerfTestResults.html by default.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.perf_results_directory): Added.
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner): Added _DEFAULT_JSON_FILENAME.
(PerfTestsRunner._parse_args): Added --no-results option in the case a user doens't want to generate
results JSON or results page.
(PerfTestsRunner.run):
(PerfTestsRunner._generate_and_show_results): Extracted from run. Set the default json file path using
port's perf_results_directory and call show_results_html_file at the end if the results page is generated.
(PerfTestsRunner._generate_results_dict): Renamed from _generate_output to disambiguate it from
_generate_and_show_results.
(PerfTestsRunner._generate_output_files): Takes results page's path instead of a boolean indicating
whether results page should be generated or not.
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(create_runner_and_setup_results_template):
(test_run_respects_results_output): Added.
(test_run_generates_json_by_default): Added.
(test_run_generates_and_show_results_page): Added a check to ensure show_results_html_file is called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNothing happens when clicking on the unavailable plug-in button for a blocked plug-in
andersca@apple.com [Fri, 3 Aug 2012 22:03:20 +0000 (22:03 +0000)]
Nothing happens when clicking on the unavailable plug-in button for a blocked plug-in
https://bugs.webkit.org/show_bug.cgi?id=93161

Reviewed by John Sullivan.

Be more robust against values being added to the RenderEmbeddedObject::PluginUnavailabilityReason
enumeration, and use a switch statement instead of blindly casting the type value to a WKPluginUnavailabilityReason.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::unavailablePluginButtonClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove dependency on LayoutTypes.h from transformation code
eae@chromium.org [Fri, 3 Aug 2012 22:00:07 +0000 (22:00 +0000)]
Remove dependency on LayoutTypes.h from transformation code
https://bugs.webkit.org/show_bug.cgi?id=93037

Reviewed by Levi Weintraub.

TransformationMatrix and HitTestingTransformState includes LayoutTypes.h
which is in rendering. This is a layering violation.
Remove this dependency as it is no longer needed.

No new tests, no change in functionality.

* rendering/LayoutTypes.h:
Remove clampToLayoutUnit

* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::clamp):
Add FractionalLayoutUnit::clamp method that clamps a double to a FractionalLayoutUnit.
* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::clampEdgeValue):
(WebCore::TransformationMatrix::clampedBoundsOfProjectedQuad):
Use clamp/max/min from FractionalLayoutUnit instead of going through LayoutUnit abstraction.
* platform/graphics/transforms/TransformationMatrix.h:
* rendering/HitTestingTransformState.cpp:
* rendering/HitTestingTransformState.h:
Replace use of LayoutRect with FractionalLayoutRect as LayoutRect maps to FractionalLayoutRect on all platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG::StructureCheckHoistingPhase keeps a Node& around for too long
fpizlo@apple.com [Fri, 3 Aug 2012 21:41:05 +0000 (21:41 +0000)]
DFG::StructureCheckHoistingPhase keeps a Node& around for too long
https://bugs.webkit.org/show_bug.cgi?id=93157

Reviewed by Mark Hahnenberg.

* dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: <rdar://problem/12005188> REGRESSION (Safari 5.1 - 6): Cannot correct...
mitz@apple.com [Fri, 3 Aug 2012 21:30:06 +0000 (21:30 +0000)]
Source/WebCore: <rdar://problem/12005188> REGRESSION (Safari 5.1 - 6): Cannot correctly display Traditional Mongolian Script
https://bugs.webkit.org/show_bug.cgi?id=92864

Reviewed by Sam Weinig.

Test: platform/mac/fast/text/combining-character-sequence-vertical.html

* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::glyphForCharacter): Added this helper function.
* platform/graphics/SimpleFontData.h:
(SimpleFontData): Declared glyphDataForCharacter.
* platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::fontDataForCombiningCharacterSequence): Added logic to use the appropriate
variant of each font in the fallback list, which mimcs the equivalent logic in
glyphDataAndPageForCharacter().

LayoutTests: REGRESSION (Safari 5.1 - 6): Cannot correctly display Traditional Mongolian Script
https://bugs.webkit.org/show_bug.cgi?id=92864

Reviewed by Sam Weinig.

* platform/mac/fast/text/combining-character-sequence-vertical-expected.html: Added.
* platform/mac/fast/text/combining-character-sequence-vertical.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Web Inspector: Win Dbg tests timing out (r123556 or r123560?)
kbr@google.com [Fri, 3 Aug 2012 21:19:36 +0000 (21:19 +0000)]
[Chromium] Web Inspector: Win Dbg tests timing out (r123556 or r123560?)
https://bugs.webkit.org/show_bug.cgi?id=92570

Reviewed by Pavel Feldman.

Try restricting the use of the GC hint for canvas contexts to only
WebGL contexts, where it is most needed, to see whether this
clears up the timeouts.

* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSmall part of "Out-of-process plug-ins should support asynchronous initialization."
beidson@apple.com [Fri, 3 Aug 2012 21:13:13 +0000 (21:13 +0000)]
Small part of "Out-of-process plug-ins should support asynchronous initialization."
<rdar://problem/10598594> and https://bugs.webkit.org/show_bug.cgi?id=92919

Unreviewed (build fix).

* Shared/WebPreferencesStore.h:
(WebKit): Include this file which has the declaration of the new pref.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake][WIN] Disable C++ exceptions and RTTI
paroga@webkit.org [Fri, 3 Aug 2012 21:10:27 +0000 (21:10 +0000)]
[CMake][WIN] Disable C++ exceptions and RTTI
https://bugs.webkit.org/show_bug.cgi?id=93104

Reviewed by Ryosuke Niwa.

Both features are not used in WebKit, so remove them to safe some code.
Also enable compilation of plain c files with multiple processes.

* Source/cmake/OptionsWindows.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124628.
dimich@chromium.org [Fri, 3 Aug 2012 21:00:37 +0000 (21:00 +0000)]
Unreviewed, rolling out r124628.
http://trac.webkit.org/changeset/124628
https://bugs.webkit.org/show_bug.cgi?id=93155

Causes random crashes of DRT on Chromium bots (Requested by
dimich on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-03

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
(MockWebKitPlatformSupport::createMediaStreamCenter):
* DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
(MockWebKitPlatformSupport):
* DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
* DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Removed.
* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSmall part of "Out-of-process plug-ins should support asynchronous initialization."
beidson@apple.com [Fri, 3 Aug 2012 20:49:03 +0000 (20:49 +0000)]
Small part of "Out-of-process plug-ins should support asynchronous initialization."
<rdar://problem/10598594> and https://bugs.webkit.org/show_bug.cgi?id=92919

Reviewed by Anders Carlsson.

Source/WebKit2:

-Add API-level preferences for forcing asynchronous initialization of all plug-ins (for testing).
-Make sure "overridePreference" is hooked up properly for all needed preferences.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAsynchronousPluginInitializationEnabledForAllPlugins):
(WKPreferencesGetAsynchronousPluginInitializationEnabledForAllPlugins):
* UIProcess/API/C/WKPreferencesPrivate.h:

* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::updatePreferences):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::setAsynchronousPluginInitializationEnabled):
(WebKit::WebPage::asynchronousPluginInitializationEnabledForAllPlugins):
(WebKit::WebPage::setAsynchronousPluginInitializationEnabledForAllPlugins):
(WebKit::WebPage::setArtificialPluginInitializationDelayEnabled):
(WebPage):

Tools:

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues): Reset all preferences related to asynchronous plugin initialization.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdded 'crash' expectation to a flaky test fast/multicol/column-span-parent-continuati...
dimich@chromium.org [Fri, 3 Aug 2012 20:41:02 +0000 (20:41 +0000)]
Added 'crash' expectation to a flaky test fast/multicol/column-span-parent-continuation-crash.html
https://bugs.webkit.org/show_bug.cgi?id=90746

Not reviewed, expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd API for enabling blanket third-party data blocking
jpfau@apple.com [Fri, 3 Aug 2012 20:24:11 +0000 (20:24 +0000)]
Add API for enabling blanket third-party data blocking
https://bugs.webkit.org/show_bug.cgi?id=93022

Reviewed by Anders Carlsson.

Source/WebCore:

Added API for enabling third-party storage blocking.

* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setThirdPartyStorageBlockingEnabled):
(WebCore::Settings::thirdPartyStorageBlockingEnabled):
(Settings):

Source/WebKit2:

Added API for enabling third-party storage blocking.

* Shared/WebPreferencesStore.h:
(WebKit):
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetThirdPartyStorageBlockingEnabled):
(WKPreferencesGetThirdPartyStorageBlockingEnabled):
* UIProcess/API/C/WKPreferences.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Tools:

Added test for default setting of new third-party storage blocking API.

* TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124632.
dimich@chromium.org [Fri, 3 Aug 2012 20:23:50 +0000 (20:23 +0000)]
Unreviewed, rolling out r124632.
http://trac.webkit.org/changeset/124632
https://bugs.webkit.org/show_bug.cgi?id=93154

Added new WebFrameTest.SelectRange which fails on bots
(Requested by dimich on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-03

* tests/WebFrameTest.cpp:
* tests/data/select_range_basic.html: Removed.
* tests/data/select_range_iframe.html: Removed.
* tests/data/select_range_scroll.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNegative timestamps for TextTrackCues should not be allowed.
annacc@chromium.org [Fri, 3 Aug 2012 20:08:53 +0000 (20:08 +0000)]
Negative timestamps for TextTrackCues should not be allowed.
https://bugs.webkit.org/show_bug.cgi?id=92939

Reviewed by Eric Carlson.

Make sure cues added in JavaScript are not allowed negative timestamps.
Attempting to add a cue with a negative timestamp is not successful
and setting a timestamp to a negative value has no effect.

Source/WebCore:

Test: media/track/track-cue-negative-timestamp.html

* html/track/TextTrack.cpp:
(WebCore::TextTrack::addCue): If the cue's startTime or endTime is
    negative, do not add the cue.
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::setStartTime): Ignore negative values.
(WebCore::TextTrackCue::setEndTime): Ignore negative values.
* html/track/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::add): Add ASSERTs to check startTime and
    endTime are positive.

LayoutTests:

* media/track/track-cue-negative-timestamp-expected.txt: Added.
* media/track/track-cue-negative-timestamp.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124594.
dimich@chromium.org [Fri, 3 Aug 2012 20:03:57 +0000 (20:03 +0000)]
Unreviewed, rolling out r124594.
http://trac.webkit.org/changeset/124594
https://bugs.webkit.org/show_bug.cgi?id=93152

Broke PlatformAppBrowserTest.Iframes browser_test on Chromium
bots (Requested by dimich on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-03

* bindings/generic/BindingSecurity.cpp:
(WebCore::canAccess):
(WebCore::BindingSecurity::canAccessFrame):
(WebCore::BindingSecurity::shouldAllowAccessToNode):
* bindings/v8/BindingState.cpp:
(WebCore::immediatelyReportUnsafeAccessTo):
* bindings/v8/BindingState.h:
(WebCore):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::reportUnsafeJavaScriptAccess):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::reportUnsafeAccessTo):
* bindings/v8/V8Proxy.h:
(V8Proxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] FrameLoaderClient::restoreViewState() shouldn't trigger painting
commit-queue@webkit.org [Fri, 3 Aug 2012 19:58:17 +0000 (19:58 +0000)]
[BlackBerry] FrameLoaderClient::restoreViewState() shouldn't trigger painting
https://bugs.webkit.org/show_bug.cgi?id=93141

Patch by Yong Li <yoli@rim.com> on 2012-08-03
Reviewed by Rob Buis.

PR# 172041.
It is not always safe to render the page at this point. So we post a message
instead.

* Api/WebPage.cpp:
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::restoreViewState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoApply target fuzzing when sending a context menu event
commit-queue@webkit.org [Fri, 3 Aug 2012 19:49:38 +0000 (19:49 +0000)]
Apply target fuzzing when sending a context menu event
https://bugs.webkit.org/show_bug.cgi?id=92914

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-08-03
Reviewed by Antonio Gomes.

Source/WebCore:

If TOUCH_ADJUSTMENT is enabled, use bestClickableNodeForTouchPoint to possibly
adjust the location of a context menu event. This change uses the same set of
candidates for touch adjustment as is used for a GestureTap event (which
admittedly is a simplifying assumption).

Test: touchadjustment/touch-links-longpress.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureTap):
Some code moved to the new function adjustGesturePosition.
(WebCore):
(WebCore::EventHandler::adjustGesturePosition):
Added this function to avoid repeated code in handleGestureTap and
sendContextMenuEventForGesture.
(WebCore::EventHandler::sendContextMenuEventForGesture):
Try to adjust the location of |mouseEvent| to correspond to the most
probable gesture target. If no such target exists, the location of
|mouseEvent| is unchanged.
* page/EventHandler.h:
(EventHandler):

Source/WebKit/chromium:

When constructing a PlatformEvent::GestureLongPress in WebInputEventConversion.cpp,
use |boundingBox| to specify |m_area|.

* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

LayoutTests:

New layout test to verify that context menus appear on links for a long press
gesture when TOUCH_ADJUSTMENT is enabled.

* platform/qt/Skipped:
Skipped on qt because gestureLongPress is not used for context menus.
* touchadjustment/touch-links-longpress-expected.txt: Added.
* touchadjustment/touch-links-longpress.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124475 and r124496.
inferno@chromium.org [Fri, 3 Aug 2012 19:47:08 +0000 (19:47 +0000)]
Unreviewed, rolling out r124475 and r124496.
http://trac.webkit.org/changeset/124475
http://trac.webkit.org/changeset/124496
https://bugs.webkit.org/show_bug.cgi?id=93151

Causing assertion failures in table-section-node-at-point-
crash.html (Requested by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-03

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Add stubs for the find-in-page match rects API
leandrogracia@chromium.org [Fri, 3 Aug 2012 19:45:43 +0000 (19:45 +0000)]
[Chromium] Add stubs for the find-in-page match rects API
https://bugs.webkit.org/show_bug.cgi?id=93110

Reviewed by Adam Barth.

The Android port allows tapping on the find-in-page result tickmarks taking
the user to the corresponding matches. This patch introduces stubs for the
new required methods in order to achieve WebKit API compatibility for this
port as soon as possible. The implementation of these methods will be added
later in https://bugs.webkit.org/show_bug.cgi?id=93111.

* public/WebFrame.h:
(WebKit):
(WebFrame):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::findMatchMarkersVersion):
(WebKit):
(WebKit::WebFrameImpl::activeFindMatchRect):
(WebKit::WebFrameImpl::findMatchRects):
(WebKit::WebFrameImpl::selectNearestFindMatch):
* src/WebFrameImpl.h:
(WebFrameImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] InspectorOverlay class duplicated in WebCore
kpiascik@rim.com [Fri, 3 Aug 2012 19:36:19 +0000 (19:36 +0000)]
[BlackBerry] InspectorOverlay class duplicated in WebCore
https://bugs.webkit.org/show_bug.cgi?id=93124

Reviewed by Rob Buis.

Changed namespace of InspectorOverlay from WebCore to
BlackBerry::WebKit

* Api/WebPage.cpp:
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::setInspectorOverlayClient):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/InspectorClientBlackBerry.h:
* WebCoreSupport/InspectorOverlay.cpp:
(BlackBerry::WebKit::InspectorOverlay::create):
(BlackBerry::WebKit::InspectorOverlay::InspectorOverlay):
(BlackBerry::WebKit::InspectorOverlay::notifySyncRequired):
(BlackBerry::WebKit::InspectorOverlay::paintContents):
(BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
(BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
(BlackBerry::WebKit::InspectorOverlay::contentsVisible):
(BlackBerry::WebKit::InspectorOverlay::update):
* WebCoreSupport/InspectorOverlay.h:
(WebKit):
(InspectorOverlayClient):
(InspectorOverlay):
(BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Create and interface for TextEditor
commit-queue@webkit.org [Fri, 3 Aug 2012 19:33:26 +0000 (19:33 +0000)]
Web Inspector: Create and interface for TextEditor
https://bugs.webkit.org/show_bug.cgi?id=93126

Patch by Jan Keromnes <janx@linux.com> on 2012-08-03
Reviewed by Pavel Feldman.

For more extensibility, TextEditor needs to be an interface that other
classes can implement, e.g. the new class DefaultTextEditor.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor):
(WebInspector.TextEditor.prototype.set mimeType):
(WebInspector.TextEditor.prototype.setReadOnly):
(WebInspector.TextEditor.prototype.readOnly):
(WebInspector.TextEditor.prototype.defaultFocusedElement):
(WebInspector.TextEditor.prototype.revealLine):
(WebInspector.TextEditor.prototype.addDecoration):
(WebInspector.TextEditor.prototype.removeDecoration):
(WebInspector.TextEditor.prototype.markAndRevealRange):
(WebInspector.TextEditor.prototype.highlightLine):
(WebInspector.TextEditor.prototype.clearLineHighlight):
(WebInspector.TextEditor.prototype.freeCachedElements):
(WebInspector.TextEditor.prototype.elementsToRestoreScrollPositionsFor):
(WebInspector.TextEditor.prototype.inheritScrollPositions):
(WebInspector.TextEditor.prototype.beginUpdates):
(WebInspector.TextEditor.prototype.endUpdates):
(WebInspector.TextEditor.prototype.onResize):
(WebInspector.TextEditor.prototype._textChanged):
(WebInspector.TextEditor.prototype.editRange):
(WebInspector.TextEditor.prototype.scrollToLine):
(WebInspector.TextEditor.prototype.selection):
(WebInspector.TextEditor.prototype.lastSelection):
(WebInspector.TextEditor.prototype.setSelection):
(WebInspector.TextEditor.prototype.setText):
(WebInspector.TextEditor.prototype.text):
(WebInspector.TextEditor.prototype.range):
(WebInspector.TextEditor.prototype.line):
(WebInspector.TextEditor.prototype.get linesCount):
(WebInspector.TextEditor.prototype.setAttribute):
(WebInspector.TextEditor.prototype.getAttribute):
(WebInspector.TextEditor.prototype.removeAttribute):
(WebInspector.TextEditor.prototype.wasShown):
(WebInspector.TextEditor.prototype._handleFocused):
(WebInspector.TextEditor.prototype.willHide):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, adding self to committers.py after becoming committer.
commit-queue@webkit.org [Fri, 3 Aug 2012 19:18:06 +0000 (19:18 +0000)]
Unreviewed, adding self to committers.py after becoming committer.

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-03

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBlocking a plugin via CSP should result in one (and only one) console message.
commit-queue@webkit.org [Fri, 3 Aug 2012 19:14:10 +0000 (19:14 +0000)]
Blocking a plugin via CSP should result in one (and only one) console message.
https://bugs.webkit.org/show_bug.cgi?id=92649

Patch by Mike West <mkwst@chromium.org> on 2012-08-03
Reviewed by Adam Barth.

Source/WebCore:

Currently, blocking a plugin via Content Security Policy results in some
leakage of console log messages between tests. I'm unclear as to the
root cause, but the symptoms exhibited include
`SubframeLoader::requestPlugin` being called multiple times for a single
element, which in turn causes multiple console logs to be sent. These
messages tend to appear in the subsequent test, making the
`http/test/security/contentSecurityPolicy/object-src-*` set of tests
flakey indeed.

This patch addresses the issue by marking elements' plugins as
unavailable when they're blocked by CSP. No new tests have been added:
this patch should simply make the current tests actually pass.

* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestPlugin):
    We check the CSP status in `SubframeLoader::loadPlugin`, which is
    called at the end of this function. Checking CSP status in both
    locations is redundant.
(WebCore::SubframeLoader::loadPlugin):
    If the plugin is blocked by CSP, tell the element's embedded object
    renderer that the plugin is unavailable.
* platform/LocalizedStrings.cpp:
(WebCore::blockedPluginByContentSecurityPolicyText):
(WebCore):
* platform/LocalizedStrings.h:
(WebCore):
* platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::blockedPluginByContentSecurityPolicyText):
(WebCore):
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::blockedPluginByContentSecurityPolicyText):
(WebCore):
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::blockedPluginByContentSecurityPolicyText):
(WebCore):
* platform/qt/LocalizedStringsQt.cpp:
(WebCore::blockedPluginByContentSecurityPolicyText):
(WebCore):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::unavailablePluginReplacementText):
* rendering/RenderEmbeddedObject.h:
    Return appropriate text when the plugin is blocked by CSP.

Source/WebKit/chromium:

* src/LocalizedStrings.cpp:
(WebCore::blockedPluginByContentSecurityPolicyText):
(WebCore):
    Adding a stub for the newly added string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLimited the number of queried cached build infos in URLs used by Garden-o-matic.
commit-queue@webkit.org [Fri, 3 Aug 2012 19:00:13 +0000 (19:00 +0000)]
Limited the number of queried cached build infos in URLs used by Garden-o-matic.
https://bugs.webkit.org/show_bug.cgi?id=92992.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-08-03
Reviewed by Adam Barth.

I added a limit to the cached builds that are included in the URL to avoid too long URLs in Garden-o-matic.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Add an IsExecutionTerminating() check to setDOMException()
haraken@chromium.org [Fri, 3 Aug 2012 18:54:07 +0000 (18:54 +0000)]
[V8] Add an IsExecutionTerminating() check to setDOMException()
https://bugs.webkit.org/show_bug.cgi?id=93101

Reviewed by Adam Barth.

In preparation for moving exception related code from V8Proxy to V8Binding,
I am going to remove throwError(ExceptionCode, v8::Isolate*) from V8Proxy.
throwError(ExceptionCode, v8::Isolate*) will be replaced with
setDOMException(ExceptionCode, v8::Isolate*). By this refactoring,
the way to throw JavaScript errors and DOM exceptions becomes simple:
"Throw JavaScript errors by throwError(). Throw DOM exceptions by setDOMException()".
(Currently some DOM exceptions are being thrown by throwError().)

To keep the current behavior of throwError(ExceptionCode, v8::Isolate*),
before the replacement, we need to insert the IsExecutionTerminating()
check to setDOMException(). This will add an extra check to the current
setDOMException(), but I don't think it's a problem.

No tests. No change in behavior.

* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::setDOMException):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAvoid dispatching gesture events of unknown types
commit-queue@webkit.org [Fri, 3 Aug 2012 18:39:31 +0000 (18:39 +0000)]
Avoid dispatching gesture events of unknown types
https://bugs.webkit.org/show_bug.cgi?id=93060

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-08-03
Reviewed by Adam Barth.

WebCore gesture events do not always correspond 1-to-1 to the Platform gesture events. So
avoid dispatching the unknown gesture events to nodes.

* dom/GestureEvent.cpp:
(WebCore::GestureEvent::create):
* dom/Node.cpp:
(WebCore::Node::dispatchGestureEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add a test to WebFrameTest for selectRange and visiblePositionForWindowPoint.
commit-queue@webkit.org [Fri, 3 Aug 2012 18:36:30 +0000 (18:36 +0000)]
[chromium] Add a test to WebFrameTest for selectRange and visiblePositionForWindowPoint.
https://bugs.webkit.org/show_bug.cgi?id=93108

Patch by Oli Lan <olilan@chromium.org> on 2012-08-03
Reviewed by Adam Barth.

Adds a new test WebFrameTest.SelectRange. This tests WebFrameImpl::selectRange, and also
serves to test WebFrameImpl::visiblePositionForWindowPoint as it is used by selectRange.

The test uses sample files that contain selected text on load. The test uses
WebViewImpl::selectionBounds to retrieve the ends of the selection, then unselects
and calls WebFrameImpl::selectRange to attempt to reselect the same text.

Three cases are tested: the normal case, the case where the selected text is offscreen
due to a scroll, and the case where the selected text is in an iframe. This allows the
problem cases and fix in https://bugs.webkit.org/show_bug.cgi?id=79117 to be tested.

* tests/WebFrameTest.cpp:
* tests/data/select_range_basic.html: Added.
* tests/data/select_range_iframe.html: Added.
* tests/data/select_range_scroll.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash when a clip path referencing a clip path changes documents
schenney@chromium.org [Fri, 3 Aug 2012 18:34:27 +0000 (18:34 +0000)]
Crash when a clip path referencing a clip path changes documents
https://bugs.webkit.org/show_bug.cgi?id=93023

Reviewed by Dirk Schulze.

Source/WebCore:

The SVGClipPathElement is set to not need pending resource handling,
when in fact it can have pending resources. The result is a crash when
the element is moved to a new document (which deletes all resources
and leaves them pending) and then immediately deleted (which asserts
that there are no pending resources). There is code to remove pending
resources upon deletion and removal from the DOM, but it was not
executing for clips because of the aforementioned code claiming that
clips don't require such handling.

The assertion that there be no pending resources is necessary to
prevent caches of pending resources from trying to access the deleted
element.

This change removes the check for needsPendingResourceHandling in
SVGStyledElement upon deletion and removal from the DOM. Pending resources
will always be checked in such cases to ensure we do not introduce
security issues.

Test: svg/custom/clip-path-document-change-assert.html

* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::~SVGStyledElement): Removed needsPendingResourceHandling in the conditional to clean up resources.
(WebCore::SVGStyledElement::removedFrom): Removed needsPendingResourceHandling in the conditional to clean up resources.

LayoutTests:

Test that asserts in debug DRT without this change. Any attempt to
delete a clip that references another clip after changing the document
results in a crash.

* svg/custom/clip-path-document-change-assert-expected.txt: Added.
* svg/custom/clip-path-document-change-assert.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove unused methods in V8Proxy
haraken@chromium.org [Fri, 3 Aug 2012 18:23:12 +0000 (18:23 +0000)]
[V8] Remove unused methods in V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=93106

Reviewed by Adam Barth.

In preparation for removing V8Proxy, we can remove unused methods in V8Proxy.

No tests. No change in behavior.

* bindings/v8/V8Proxy.h:
(V8Proxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Implement v8Undefined()
haraken@chromium.org [Fri, 3 Aug 2012 18:20:46 +0000 (18:20 +0000)]
[V8] Implement v8Undefined()
https://bugs.webkit.org/show_bug.cgi?id=93093

Reviewed by Adam Barth.

There are a couple of equivalent ways to create an undefined value,
e.g. v8::Undefined(), v8::Undefined(isolate), v8::Handle<v8::Value>(), etc.
We should implement v8Undefined() and use it everywhere.

In this bug, we implement v8Undefined() and use it in CodeGeneratorV8.pm.
We can implement v8Undefined() like this:

    v8::Handle<v8::Value> v8Undefined() { v8::Handle<v8::Value>(); }

This is based on the following performance results:

// 14.5 ns
v8::Handle<v8::Value> xxxAttrGetter(..., info) {
    return v8::Undefined();
}

// 8.24 ns (This cannot be used where isolate can be 0.)
v8::Handle<v8::Value> xxxAttrGetter(..., info) {
    return v8::Undefined(info.GetIsolate());
}

// 8.54 ns
v8::Handle<v8::Value> xxxAttrGetter(..., info) {
    v8::Isolate* isolate = info.GetIsolate();
    return isolate ? v8::Handle<v8::Value>(v8::Undefined(isolate)) : v8::Handle<v8::Value>();
}

// 8.52 ns
v8::Handle<v8::Value> xxxAttrGetter(..., info) {
    return v8::Handle<v8::Value>();
}

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorGetter):
(GenerateNormalAttrGetter):
(GenerateNewFunctionTemplate):
(GenerateEventListenerCallback):
(GenerateFunctionCallback):
(GenerateCallWith):
(GenerateParametersCheck):
(GenerateEventConstructorCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
(NativeToJSValue):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::wrapSlow):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::constructorCallback):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::addEventListenerCallback):
(WebCore::TestEventTargetV8Internal::removeEventListenerCallback):
(WebCore::ConfigureV8TestEventTargetTemplate):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalMethod1Callback):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::TestInterfaceV8Internal::supplementalMethod4Callback):
(WebCore::ConfigureV8TestInterfaceTemplate):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::TestMediaQueryListListenerV8Internal::methodCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetter):
(WebCore::TestObjV8Internal::TestObjConstructorGetter):
(WebCore::TestObjV8Internal::voidMethodCallback):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodWithSequenceArgCallback):
(WebCore::TestObjV8Internal::serializedValueCallback):
(WebCore::TestObjV8Internal::idbKeyCallback):
(WebCore::TestObjV8Internal::optionsObjectCallback):
(WebCore::TestObjV8Internal::methodWithExceptionCallback):
(WebCore::TestObjV8Internal::addEventListenerCallback):
(WebCore::TestObjV8Internal::removeEventListenerCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesCallback):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackCallback):
(WebCore::TestObjV8Internal::methodWithOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringCallback):
(WebCore::TestObjV8Internal::methodWithCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithCallbackAndOptionalArgCallback):
(WebCore::TestObjV8Internal::conditionalMethod2Callback):
(WebCore::TestObjV8Internal::conditionalMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod4Callback):
(WebCore::TestObjV8Internal::overloadedMethod5Callback):
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod8Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::overloadedMethod10Callback):
(WebCore::TestObjV8Internal::classMethodCallback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::classMethodWithClampCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Callback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert3Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::orangeCallback):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListCallback):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
* bindings/v8/V8Binding.h:
(WebCore::v8Undefined):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
tommyw@google.com [Fri, 3 Aug 2012 18:17:59 +0000 (18:17 +0000)]
[chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
https://bugs.webkit.org/show_bug.cgi?id=93091

Reviewed by Adam Barth.

Add a skeleton MockWebRTCPeerConnectionHandler to DumpRenderTree,
to complete the infrastructure for RTCPeerConnection.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
(MockWebKitPlatformSupport::createRTCPeerConnectionHandler):
* DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
(MockWebKitPlatformSupport):
* DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
* DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
(MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::initialize):
* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
(WebKit):
(MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove v8StringToWebCoreString()
haraken@chromium.org [Fri, 3 Aug 2012 17:45:09 +0000 (17:45 +0000)]
[V8] Remove v8StringToWebCoreString()
https://bugs.webkit.org/show_bug.cgi?id=93087

Reviewed by Adam Barth.

There should be only one API that converts V8 String
to WebCore String. v8ValueToWebCoreString() does it.
We can remove v8StringToWebCoreString().

No tests. No change in behavior.

* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
* bindings/v8/V8Binding.cpp:
(WebCore::v8ValueToWebCoreString):
* bindings/v8/V8Binding.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in Notification when setting a non-object as an event listener (91881)
jonlee@apple.com [Fri, 3 Aug 2012 17:32:35 +0000 (17:32 +0000)]
Crash in Notification when setting a non-object as an event listener (91881)
https://bugs.webkit.org/show_bug.cgi?id=91881
<rdar://problem/11923341>

Reviewed by Oliver Hunt.

Source/WebCore:

Check to make sure that the value being retrieved is an object. This is similar
to the isObject() check done in the bindings code.

Test: fast/notifications/notifications-event-listener-crash.html

* bindings/js/Dictionary.h:
(WebCore::Dictionary::getEventListener):

LayoutTests:

* fast/notifications/notifications-event-listener-crash-expected.txt: Added.
* fast/notifications/notifications-event-listener-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] There's no way to test the gesture tap on WTR
hugo.lima@openbossa.org [Fri, 3 Aug 2012 17:21:17 +0000 (17:21 +0000)]
[Qt][WK2] There's no way to test the gesture tap on WTR
https://bugs.webkit.org/show_bug.cgi?id=92895

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add an instance of QtViewportHandler to QQuickWebViewPrivate, so it's
now available on mobile and desktop modes, as a side effect gesture tap
events can now be created and sent to WebCore.

This is needed to test tap gestures and to get tap gestures working
when you have a WebView (in desktop mode) on notebooks equipped with
touch screens.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::onComponentComplete): Implementation
moved to QQuickWebViewPrivate::onComponentComplete.
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):

Tools:

WTR doesn't create the QQuickItem from C++, not from QML, so a call
to componentComplete() was added to mimic the QML behaviour.

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove v8StringToAtomicWebCoreString()
haraken@chromium.org [Fri, 3 Aug 2012 16:47:06 +0000 (16:47 +0000)]
[V8] Remove v8StringToAtomicWebCoreString()
https://bugs.webkit.org/show_bug.cgi?id=93086

Reviewed by Dimitri Glazkov.

There should be only one API that converts V8 String to
AtomicString. v8ValueToAtomicWebCoreString() does it.
We can remove v8StringToAtomicWebCoreString().

No tests. No change in behavior.

* bindings/v8/V8Binding.cpp:
(WebCore::v8ValueToAtomicWebCoreString):
* bindings/v8/V8Binding.h:
(WebCore):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::getter):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedPropertyGetter):
* bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
(WebCore::V8HTMLAllCollection::namedPropertyGetter):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::V8HTMLCollection::namedPropertyGetter):
* bindings/v8/custom/V8HTMLFormElementCustom.cpp:
(WebCore::V8HTMLFormElement::namedPropertyGetter):
* bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: eliminate visitBaseClass method from NMI. It introduces unnecessary...
loislo@chromium.org [Fri, 3 Aug 2012 16:44:40 +0000 (16:44 +0000)]
Web Inspector: eliminate visitBaseClass method from NMI. It introduces unnecessary complexity.
https://bugs.webkit.org/show_bug.cgi?id=93129

Reviewed by Yury Semikhatsky.

Source/WebCore:

* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::StyleRuleCSSStyleDeclaration::reportMemoryUsage):
(WebCore::InlineCSSStyleDeclaration::reportMemoryUsage):
* dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
* dom/ContainerNode.h:
(WebCore::ContainerNode::reportMemoryUsage):
* dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
* dom/Element.h:
(WebCore::Element::reportMemoryUsage):
* dom/MemoryInstrumentation.h:
* dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):

Source/WebKit/chromium:

* tests/MemoryInstrumentationTest.cpp:
(WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] Move some WebContext messages to WebProcessProxy
ap@apple.com [Fri, 3 Aug 2012 16:41:21 +0000 (16:41 +0000)]
    [WK2] Move some WebContext messages to WebProcessProxy
        https://bugs.webkit.org/show_bug.cgi?id=93046

        Reviewed by Anders Carlsson.

        * UIProcess/WebContext.cpp: (WebKit::WebContext::didReceiveSyncMessage): Unrelated
        fix - use actual process argument instead of second-guessing where the message came
        from.

        * UIProcess/WebContext.h: (WebKit::WebContext::historyClient): Expose history client,
        since WebProcessProxy now needs it.

        * UIProcess/WebContext.messages.in:
        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::didNavigateWithNavigationData):
        (WebKit::WebProcessProxy::didPerformClientRedirect):
        (WebKit::WebProcessProxy::didPerformServerRedirect):
        (WebKit::WebProcessProxy::didUpdateHistoryTitle):
        * UIProcess/WebProcessProxy.h:
        * UIProcess/WebProcessProxy.messages.in:
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::updateGlobalHistory):
        (WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
        (WebKit::WebFrameLoaderClient::setTitle):
        Move the messages.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Move ubercomp quads back into CC
commit-queue@webkit.org [Fri, 3 Aug 2012 16:25:58 +0000 (16:25 +0000)]
[chromium] Move ubercomp quads back into CC
https://bugs.webkit.org/show_bug.cgi?id=93062

Patch by Alexandre Elias <aelias@google.com> on 2012-08-03
Reviewed by James Robinson.

Because GTFO is almost done, we can move back the quad types
to CC and pickle them there.  This patch moves everything back
to where it was before and changes types like WebRect to IntRect.

As a bonus, I also added CCRenderPassDrawQuad and CCYUVVideoDrawQuad
(which had been left in the CC files) to CCDrawQuad::size(), so now
every quad type is ready for serialization.

Source/Platform:

* Platform.gypi:
* chromium/public/WebCompositorCheckerboardQuad.h: Removed.
* chromium/public/WebCompositorDebugBorderQuad.h: Removed.
* chromium/public/WebCompositorIOSurfaceQuad.h: Removed.
* chromium/public/WebCompositorQuad.h: Removed.
* chromium/public/WebCompositorSharedQuadState.h: Removed.
* chromium/public/WebCompositorSolidColorQuad.h: Removed.
* chromium/public/WebCompositorStreamVideoQuad.h: Removed.
* chromium/public/WebCompositorTextureQuad.h: Removed.
* chromium/public/WebCompositorTileQuad.h: Removed.

Source/WebCore:

No new tests (no-op refactoring).

* WebCore.gypi:
* platform/chromium/support/WebCompositorStreamVideoQuad.cpp: Removed.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawQuad):
* platform/graphics/chromium/cc/CCCheckerboardDrawQuad.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCQuadSink.h.
(WebCore):
(WebCore::CCCheckerboardDrawQuad::create):
(WebCore::CCCheckerboardDrawQuad::CCCheckerboardDrawQuad):
(WebCore::CCCheckerboardDrawQuad::materialCast):
* platform/graphics/chromium/cc/CCCheckerboardDrawQuad.h:
(WebCore):
(CCCheckerboardDrawQuad):
* platform/graphics/chromium/cc/CCDebugBorderDrawQuad.cpp: Renamed from Source/WebCore/platform/chromium/support/WebCompositorDebugBorderQuad.cpp.
(WebCore):
(WebCore::CCDebugBorderDrawQuad::create):
(WebCore::CCDebugBorderDrawQuad::CCDebugBorderDrawQuad):
(WebCore::CCDebugBorderDrawQuad::materialCast):
* platform/graphics/chromium/cc/CCDebugBorderDrawQuad.h:
(WebCore):
(CCDebugBorderDrawQuad):
(WebCore::CCDebugBorderDrawQuad::color):
(WebCore::CCDebugBorderDrawQuad::width):
* platform/graphics/chromium/cc/CCDrawQuad.cpp: Renamed from Source/WebCore/platform/chromium/support/WebCompositorQuad.cpp.
(WebCore):
(WebCore::CCDrawQuad::CCDrawQuad):
(WebCore::CCDrawQuad::opaqueRect):
(WebCore::CCDrawQuad::setQuadVisibleRect):
(WebCore::CCDrawQuad::size):
(WebCore::CCDrawQuad::setSharedQuadState):
* platform/graphics/chromium/cc/CCDrawQuad.h:
(WebCore):
(CCDrawQuad):
(WebCore::CCDrawQuad::quadRect):
(WebCore::CCDrawQuad::quadTransform):
(WebCore::CCDrawQuad::visibleContentRect):
(WebCore::CCDrawQuad::scissorRect):
(WebCore::CCDrawQuad::opacity):
(WebCore::CCDrawQuad::needsBlending):
(WebCore::CCDrawQuad::isLayerAxisAlignedIntRect):
(WebCore::CCDrawQuad::quadVisibleRect):
(WebCore::CCDrawQuad::isDebugQuad):
(WebCore::CCDrawQuad::material):
(WebCore::CCDrawQuad::sharedQuadState):
(WebCore::CCDrawQuad::sharedQuadStateId):
* platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:
(WebCore::CCHeadsUpDisplayLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.cpp: Renamed from Source/WebCore/platform/chromium/support/WebCompositorIOSurfaceQuad.cpp.
(WebCore):
(WebCore::CCIOSurfaceDrawQuad::create):
(WebCore::CCIOSurfaceDrawQuad::CCIOSurfaceDrawQuad):
(WebCore::CCIOSurfaceDrawQuad::materialCast):
* platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.h:
(WebCore):
(CCIOSurfaceDrawQuad):
(WebCore::CCIOSurfaceDrawQuad::ioSurfaceSize):
(WebCore::CCIOSurfaceDrawQuad::ioSurfaceTextureId):
(WebCore::CCIOSurfaceDrawQuad::orientation):
* platform/graphics/chromium/cc/CCQuadCuller.h:
(CCQuadCuller):
* platform/graphics/chromium/cc/CCQuadSink.h:
(WebCore):
(CCQuadSink):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::materialCast):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
(CCRenderPassDrawQuad):
* platform/graphics/chromium/cc/CCSharedQuadState.cpp: Renamed from Source/WebCore/platform/chromium/support/WebCompositorSharedQuadState.cpp.
(WebCore):
(WebCore::CCSharedQuadState::CCSharedQuadState):
(WebCore::CCSharedQuadState::create):
(WebCore::CCSharedQuadState::isLayerAxisAlignedIntRect):
* platform/graphics/chromium/cc/CCSharedQuadState.h:
(WebCore):
(CCSharedQuadState):
* platform/graphics/chromium/cc/CCSolidColorDrawQuad.cpp: Renamed from Source/WebCore/platform/chromium/support/WebCompositorSolidColorQuad.cpp.
(WebCore):
(WebCore::CCSolidColorDrawQuad::create):
(WebCore::CCSolidColorDrawQuad::CCSolidColorDrawQuad):
(WebCore::CCSolidColorDrawQuad::materialCast):
* platform/graphics/chromium/cc/CCSolidColorDrawQuad.h:
(WebCore):
(CCSolidColorDrawQuad):
(WebCore::CCSolidColorDrawQuad::color):
* platform/graphics/chromium/cc/CCStreamVideoDrawQuad.cpp: Renamed from Source/WebCore/platform/chromium/support/WebCompositorCheckerboardQuad.cpp.
(WebCore):
(WebCore::CCStreamVideoDrawQuad::create):
(WebCore::CCStreamVideoDrawQuad::CCStreamVideoDrawQuad):
(WebCore::CCStreamVideoDrawQuad::materialCast):
* platform/graphics/chromium/cc/CCStreamVideoDrawQuad.h:
(WebCore):
(CCStreamVideoDrawQuad):
(WebCore::CCStreamVideoDrawQuad::textureId):
(WebCore::CCStreamVideoDrawQuad::matrix):
* platform/graphics/chromium/cc/CCTextureDrawQuad.cpp: Renamed from Source/WebCore/platform/chromium/support/WebCompositorTextureQuad.cpp.
(WebCore):
(WebCore::CCTextureDrawQuad::create):
(WebCore::CCTextureDrawQuad::CCTextureDrawQuad):
(WebCore::CCTextureDrawQuad::setNeedsBlending):
(WebCore::CCTextureDrawQuad::materialCast):
* platform/graphics/chromium/cc/CCTextureDrawQuad.h:
(WebCore):
(CCTextureDrawQuad):
(WebCore::CCTextureDrawQuad::uvRect):
(WebCore::CCTextureDrawQuad::resourceId):
(WebCore::CCTextureDrawQuad::premultipliedAlpha):
(WebCore::CCTextureDrawQuad::flipped):
* platform/graphics/chromium/cc/CCTileDrawQuad.cpp: Renamed from Source/WebCore/platform/chromium/support/WebCompositorTileQuad.cpp.
(WebCore):
(WebCore::CCTileDrawQuad::create):
(WebCore::CCTileDrawQuad::CCTileDrawQuad):
(WebCore::CCTileDrawQuad::materialCast):
* platform/graphics/chromium/cc/CCTileDrawQuad.h:
(WebCore):
(CCTileDrawQuad):
(WebCore::CCTileDrawQuad::resourceId):
(WebCore::CCTileDrawQuad::textureOffset):
(WebCore::CCTileDrawQuad::textureSize):
(WebCore::CCTileDrawQuad::textureFilter):
(WebCore::CCTileDrawQuad::swizzleContents):
(WebCore::CCTileDrawQuad::leftEdgeAA):
(WebCore::CCTileDrawQuad::topEdgeAA):
(WebCore::CCTileDrawQuad::rightEdgeAA):
(WebCore::CCTileDrawQuad::bottomEdgeAA):
(WebCore::CCTileDrawQuad::isAntialiased):
* platform/graphics/chromium/cc/CCYUVVideoDrawQuad.cpp:
(WebCore::CCYUVVideoDrawQuad::create):
(WebCore::CCYUVVideoDrawQuad::CCYUVVideoDrawQuad):
(WebCore::CCYUVVideoDrawQuad::materialCast):
* platform/graphics/chromium/cc/CCYUVVideoDrawQuad.h:
(CCYUVVideoDrawQuad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124603.
kbalazs@webkit.org [Fri, 3 Aug 2012 16:08:09 +0000 (16:08 +0000)]
Unreviewed, rolling out r124603.
http://trac.webkit.org/changeset/124603
https://bugs.webkit.org/show_bug.cgi?id=93077

Made a few tests crash under
LayerTreeCoordinator::flushPendingLayerChanges

* WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::forceRepaint):
(WebKit::LayerTreeCoordinator::layerTreeTileUpdatesAllowed):
* WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.h:
(LayerTreeCoordinator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, restore Web Inspector JS frontend compilability after r124484 (fix JSDoc...
apavlov@chromium.org [Fri, 3 Aug 2012 16:07:57 +0000 (16:07 +0000)]
Unreviewed, restore Web Inspector JS frontend compilability after r124484 (fix JSDoc annotations).

* inspector/front-end/Settings.js:
* inspector/front-end/SettingsScreen.js:
* inspector/front-end/UserAgentSupport.js:
(WebInspector.UserAgentSupport.DeviceOrientation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124567.
kbalazs@webkit.org [Fri, 3 Aug 2012 16:05:07 +0000 (16:05 +0000)]
Unreviewed, rolling out r124567.
http://trac.webkit.org/changeset/124567
https://bugs.webkit.org/show_bug.cgi?id=89382

Broke some tests with external resources

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::willSendRequestForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124614.
philn@webkit.org [Fri, 3 Aug 2012 15:51:56 +0000 (15:51 +0000)]
Unreviewed, rolling out r124614.
http://trac.webkit.org/changeset/124614
https://bugs.webkit.org/show_bug.cgi?id=91727

gstreamer core .po files mess up the build again

Source/WebCore:

* platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef):
* platform/graphics/gstreamer/GStreamerVersioning.cpp:
(setGstElementClassMetadata):
* platform/graphics/gstreamer/GStreamerVersioning.h:
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::didReceiveResponse):

Tools:

* Scripts/webkitdirs.pm:
(buildAutotoolsProject):
* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInitialize the Event Names' string from read only memory
benjamin@webkit.org [Fri, 3 Aug 2012 15:22:29 +0000 (15:22 +0000)]
Initialize the Event Names' string from read only memory
https://bugs.webkit.org/show_bug.cgi?id=92435

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-03
Reviewed by Anders Carlsson.

Similarily to r123689, we can initialize the event names' string from memory without copying the data.
This saves us memory and initialization time.

* dom/EventNames.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Overlays display checkerboard that doesn't resolve
commit-queue@webkit.org [Fri, 3 Aug 2012 15:19:17 +0000 (15:19 +0000)]
[BlackBerry] Overlays display checkerboard that doesn't resolve
https://bugs.webkit.org/show_bug.cgi?id=93099

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-03
Reviewed by Antonio Gomes.

The WebKit-thread overlays, like tap highlight, inspector highlight and
selection are all part of a separate graphics layer tree rooted in
WebPagePrivate::m_overlayLayer.

When LayerRenderer needs to schedule a commit to reactively render
tiles and resolve checkerboard, it does so through the root layer.
Since the overlay layer root didn't have a GraphicsLayerClient, there
was no implementation of GraphicsLayerClient::notifySyncRequired() to
call, and a commit was never scheduled, thus checkerboard never
resolved.

Fixed by adding a fallback implementation of GraphicsLayerClient in
WebPagePrivate and hooking up the overlay root to it. Also, this
implementation can be shared by the various overlays to avoide code
duplication, specifically to implement notifySyncRequired(),
showDebugBorders() and showRepaintCounter() only once.

Fixing this revealed a bug where the web page would get stuck in an
endless sequence of commits. It turned out that
WebPagePrivate::updateDelegatedOverlays() was called right in the
middle of the commit operation, after performing the webkit thread part
of the commit operation but before we continued on the compositing
thread. Since updateDelegatedOverlays() typically mutates layers, this
is very bad (layers should not be mutated mid-commit). The mutations
also cause a new commit to scheduled from within the current, which
results in an endless sequence of commits.

Fixed this latter bug by moving the updateDelegatedOverlays() call to
the beginning of the method where it can cause no harm. This is before
we mark the web page as no longer needing commit, so even if the
implementation flips the "needs commit" bit, we will immediately flip
it back and proceed with commit as usual.

PR 187458, 184377

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::overlayLayer):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::notifySyncRequired):
(BlackBerry::WebKit::WebPagePrivate::showDebugBorders):
(BlackBerry::WebKit::WebPagePrivate::showRepaintCounter):
* Api/WebPage_p.h:
(WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::notifyAnimationStarted):
(BlackBerry::WebKit::WebPagePrivate::paintContents):
* WebCoreSupport/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::notifySyncRequired):
(WebCore::InspectorOverlay::showDebugBorders):
(WebCore::InspectorOverlay::showRepaintCounter):
* WebKitSupport/DefaultTapHighlight.cpp:
(BlackBerry::WebKit::DefaultTapHighlight::notifySyncRequired):
(BlackBerry::WebKit::DefaultTapHighlight::showDebugBorders):
(WebKit):
(BlackBerry::WebKit::DefaultTapHighlight::showRepaintCounter):
* WebKitSupport/DefaultTapHighlight.h:
(DefaultTapHighlight):
* WebKitSupport/SelectionOverlay.cpp:
(BlackBerry::WebKit::SelectionOverlay::notifySyncRequired):
(BlackBerry::WebKit::SelectionOverlay::showDebugBorders):
(WebKit):
(BlackBerry::WebKit::SelectionOverlay::showRepaintCounter):
* WebKitSupport/SelectionOverlay.h:
(SelectionOverlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][jhbuild] Switch to GStreamer 0.11 build
philn@webkit.org [Fri, 3 Aug 2012 14:43:52 +0000 (14:43 +0000)]
[GTK][jhbuild] Switch to GStreamer 0.11 build
https://bugs.webkit.org/show_bug.cgi?id=91727

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Add a new function to encapsulate the GStreamer API removal of
GST_OBJECT_IS_FLOATING in the upcoming 1.0 release. Use of this
macro can now be replaced by calling the g_object_is_floating
function.

* platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef):
* platform/graphics/gstreamer/GStreamerVersioning.cpp:
(gstObjectIsFloating):
* platform/graphics/gstreamer/GStreamerVersioning.h:

Tools:

Switch build-webkit --gtk to GStreamer 0.11 support and build the
necessary GStreamer git modules from JHBuild.

* Scripts/webkitdirs.pm:
(buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
* gtk/jhbuild.modules: GStreamer build support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix for GTK after r124479.
mario@webkit.org [Fri, 3 Aug 2012 14:40:21 +0000 (14:40 +0000)]
Unreviewed build fix for GTK after r124479.

.:

* Source/autotools/symbols.filter: Removed unneeded symbol.

Source/WebKit2:

* UIProcess/WebInspectorProxy.cpp:
(WebKit): Moved static const definitions from header file.
* UIProcess/WebInspectorProxy.h:
(WebInspectorProxy): Don't give values to static const members
here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium mac] DumpRenderTree compile fails with warning/error in LayoutTestHelper...
thakis@chromium.org [Fri, 3 Aug 2012 14:39:50 +0000 (14:39 +0000)]
[chromium mac] DumpRenderTree compile fails with warning/error in LayoutTestHelper.mm with 10.7sdk
https://bugs.webkit.org/show_bug.cgi?id=92820

Reviewed by Jochen Eisinger.

When building with the 10.7 SDK, use newer functions to switch color
profiles. Note that these newer functions aren't available on 10.6,
but we don't intend to ship DRT to users, and no bots that currently
build with the 10.7 SDK ship their binaries to 10.6 testers.

The new code was copied from Apple's DRT/mac/LayoutTestHelper.m.

* DumpRenderTree/chromium/LayoutTestHelper.mm:
(installLayoutTestColorProfile):
(restoreUserColorProfile):
(saveCurrentColorProfile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStringImpl created from literal should be BufferInternal
benjamin@webkit.org [Fri, 3 Aug 2012 14:37:37 +0000 (14:37 +0000)]
StringImpl created from literal should be BufferInternal
https://bugs.webkit.org/show_bug.cgi?id=92940

Reviewed by Anders Carlsson.

Source/WTF:

The ownership of string created from literal should be BufferInternal so that
StringImpl never tries to delete the characters.

The ownership was accidentaly set to BufferOwned in r123689.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::createFromLiteral): Update to use the new constructor.
* wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl):
Add a new constructor making the construction from literal explicit.
Add the flag s_hashFlagHasTerminatingNullCharacter since the data has the terminating
null character.

Tools:

Add tests for the contruction of strings from literal.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WTF/AtomicString.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/StringImpl.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[nrwt] fix unit tests after turned pixel testing to be a per test setting
kbalazs@webkit.org [Fri, 3 Aug 2012 14:15:37 +0000 (14:15 +0000)]
[nrwt] fix unit tests after turned pixel testing to be a per test setting
https://bugs.webkit.org/show_bug.cgi?id=93112

Reviewed by Csaba Osztrogonác.

Change unit tests in accordance of per test switching of pixel testing.

* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidDriverTest.test_command_from_driver_input):
* Scripts/webkitpy/layout_tests/port/driver_unittest.py:
(DriverTest.test_no_timeout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Add a null check for media implementation to fix a crash.
staikos@webkit.org [Fri, 3 Aug 2012 14:14:01 +0000 (14:14 +0000)]
[BlackBerry] Add a null check for media implementation to fix a crash.
https://bugs.webkit.org/show_bug.cgi?id=93107

Reviewed by Rob Buis.

Fixes media/video-size.html.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack): Add null check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Populate .qmake.cache from the top-level project file
vestbo@webkit.org [Fri, 3 Aug 2012 14:11:03 +0000 (14:11 +0000)]
[Qt] Populate .qmake.cache from the top-level project file

This makes it possible to build webkit without using the perl build
script. The duplicated logic in build-webkit will be removed when we
remove the Qt4 code paths. The build-webkit script will then simply
call 'qmake WebKit.pro' from WEBKITOUTPUTDIR.

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-08-03
Reviewed by Tor Arne Vestbø.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Move build config default to build-webkit instead of default_pre
vestbo@webkit.org [Fri, 3 Aug 2012 14:10:27 +0000 (14:10 +0000)]
[Qt] Move build config default to build-webkit instead of default_pre

Allows the qmake buildsystem have its own default.

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-08-03
Reviewed by Tor Arne Vestbø.

* Scripts/webkitdirs.pm:
(buildQMakeProjects):
* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fixed WinCE compilation after r124589.
yurys@chromium.org [Fri, 3 Aug 2012 14:07:44 +0000 (14:07 +0000)]
Unreviewed. Fixed WinCE compilation after r124589.

* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::StyleRuleCSSStyleDeclaration::reportMemoryUsage):
(WebCore::InlineCSSStyleDeclaration::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd keyboard support for color suggestion popup
keishi@webkit.org [Fri, 3 Aug 2012 13:53:37 +0000 (13:53 +0000)]
Add keyboard support for color suggestion popup
https://bugs.webkit.org/show_bug.cgi?id=93069

Reviewed by Kent Tamura.

Source/WebCore:

This adds support for keyboard inside the color suggestion popup.
Tab or arrow keys to move around. Return or space to select the color.
Escape closes the popup.

No new tests. Covered in platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html.

* Resources/colorSuggestionPicker.css:
(.color-swatch):
(.color-swatch:focus):
* Resources/colorSuggestionPicker.js:
(ColorPicker):
(ColorPicker.prototype._layout):
(ColorPicker.prototype.selectColorAtIndex): Selects color at index.
(ColorPicker.prototype._handleMouseMove): Set focus to the swatch under the mouse cursor.
(ColorPicker.prototype._handleKeyDown): Move focused element on arrow keys.
(ColorPicker.prototype._handleMouseDown): Prevents blur on click.

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening of failing tests
commit-queue@webkit.org [Fri, 3 Aug 2012 13:47:30 +0000 (13:47 +0000)]
[EFL] Gardening of failing tests
https://bugs.webkit.org/show_bug.cgi?id=93098

Unreviewed EFL gardening. Add failing tests to the Test Expectations.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-03

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] LayerTreeCoordinator can disallow tile updates in forceRepaint
kbalazs@webkit.org [Fri, 3 Aug 2012 13:06:16 +0000 (13:06 +0000)]
[WK2] LayerTreeCoordinator can disallow tile updates in forceRepaint
https://bugs.webkit.org/show_bug.cgi?id=93077

Reviewed by Jocelyn Turcotte.

Force tile updates when doing a forced repaint.

* WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::forceRepaint):
(WebKit::LayerTreeCoordinator::layerTreeTileUpdatesAllowed):
* WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.h:
(LayerTreeCoordinator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix for GTK after r124581.
mario@webkit.org [Fri, 3 Aug 2012 12:56:21 +0000 (12:56 +0000)]
Unreviewed build fix for GTK after r124581.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(runTest): Fix wrong variable name in ASSERT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Always save CONFIG & DEFINES in default_pre
vestbo@webkit.org [Fri, 3 Aug 2012 12:54:23 +0000 (12:54 +0000)]
[Qt] Always save CONFIG & DEFINES in default_pre

Always doing it is cheaper than checking whether it needs to be done.
apart from that, it would break configuration initiated from another
project.

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-08-03
Reviewed by Tor Arne Vestbø.

* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WTR] process unresponsiveness is reported to the wrong test
kbalazs@webkit.org [Fri, 3 Aug 2012 12:25:16 +0000 (12:25 +0000)]
[WTR] process unresponsiveness is reported to the wrong test
https://bugs.webkit.org/show_bug.cgi?id=88404

2nd unreviewed buildfix.

* WebKitTestRunner/TestInvocation.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] fast/loader/stop-provisional-loads.html fails
commit-queue@webkit.org [Fri, 3 Aug 2012 12:16:30 +0000 (12:16 +0000)]
[EFL][DRT] fast/loader/stop-provisional-loads.html fails
https://bugs.webkit.org/show_bug.cgi?id=92219

Patch by Joone Hur <joone.hur@intel.com> on 2012-08-03
Reviewed by Kenneth Rohde Christiansen.

This patch adds the ability to tell DRT to call ewk_frame_stop
inside of a didStartProvisionalLoadForFrame signal handler.
It allows to pass fast/loader/stop-provisional-loads.html.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onFrameProvisionalLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WTR] process unresponsiveness is reported to the wrong test
kbalazs@webkit.org [Fri, 3 Aug 2012 12:08:33 +0000 (12:08 +0000)]
[WTR] process unresponsiveness is reported to the wrong test
https://bugs.webkit.org/show_bug.cgi?id=88404

Unreviewed buildfix. Also made the change on the array size
suggested on review because I forgot it when landed.

* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd missing include to build on Mac OS 10.8
vestbo@webkit.org [Fri, 3 Aug 2012 11:53:53 +0000 (11:53 +0000)]
Add missing include to build on Mac OS 10.8

Reviewed by Ossy.

* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WTR] process unresponsiveness is reported to the wrong test
kbalazs@webkit.org [Fri, 3 Aug 2012 11:51:58 +0000 (11:51 +0000)]
[WTR] process unresponsiveness is reported to the wrong test
https://bugs.webkit.org/show_bug.cgi?id=88404

Reviewed by Zoltan Herczeg.

Do resetting to consistent state after the finished test,
not before the next. This way we can report unresponsiveness
to the test that triggered it, and we do a restart before the
next test so it will start in a functional state.

* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver._check_for_driver_crash):
Print the error line for unresponsive web process, otherwise
it's hard to tell what happened.
* WebKitTestRunner/TestController.cpp:
(WTR):
Decreased the default short timeout so we can detect unresponsiveness
before the timer of the test harness times out. It was unnecessarily
high anyway, we should get answer from the web process in those cases
when the short timeout is used in less than a second.
(WTR::TestController::runTest):
(WTR::TestController::run):
* WebKitTestRunner/TestController.h:
(TestController):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::dump):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
* WebKitTestRunner/TestInvocation.h:
(TestInvocation): Make the dump function static as it doesn't need an object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] (REGRESSION 124581) : EFL 64-bit Debug bot is red and build is exiting early...
kbalazs@webkit.org [Fri, 3 Aug 2012 11:23:08 +0000 (11:23 +0000)]
[EFL] (REGRESSION 124581) : EFL 64-bit Debug bot is red and build is exiting early after 20 test crashes
https://bugs.webkit.org/show_bug.cgi?id=93084

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-03
Reviewed by Csaba Osztrogonác.

Fix regression introduced in r124581.

* DumpRenderTree/efl/DumpRenderTree.cpp:
(getFinalTestURL): Convert the path into a full file URL.
(runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Re-wire "target" half of the same-origin security check through Document rather...
abarth@webkit.org [Fri, 3 Aug 2012 11:17:47 +0000 (11:17 +0000)]
[V8] Re-wire "target" half of the same-origin security check through Document rather than DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=93079

Reviewed by Eric Seidel.

Before this patch, we were traversing from Nodes to Frames to
DOMWindows to SecurityOrigins when determing the "target" of an
operation for the same-origin policy security check. Rather than
detouring through DOMWindow, these security checks should operate in
terms of ScriptExecutionContexts (aka Documents) because that's the
canonical place we store SecurityOrigin objects.

A future patch will re-wire the "active" part of the security check to
use ScriptExecutionContexts as well and we'll be able to remove the
extra copy of SecurityOrigin that we keep in DOMWindow.

* bindings/generic/BindingSecurity.cpp:
(WebCore::canAccessDocument):
(WebCore::BindingSecurity::canAccessFrame):
(WebCore::BindingSecurity::shouldAllowAccessToNode):
* bindings/v8/BindingState.cpp:
(WebCore::immediatelyReportUnsafeAccessTo):
* bindings/v8/BindingState.h:
(WebCore):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::reportUnsafeJavaScriptAccess):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::reportUnsafeAccessTo):
* bindings/v8/V8Proxy.h:
(V8Proxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoColorSuggestionPicker popup's height doesn't get smaller than 100 px
keishi@webkit.org [Fri, 3 Aug 2012 10:49:35 +0000 (10:49 +0000)]
ColorSuggestionPicker popup's height doesn't get smaller than 100 px
https://bugs.webkit.org/show_bug.cgi?id=92945

Reviewed by Kent Tamura.

Source/WebCore:

A window cannot be resized to be smaller than 100x100 pixels so this
adjust the color suggestion popup UI to look better when there are only
a few suggestions.

Tests: platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance.html
       platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance.html

* Resources/colorSuggestionPicker.css:
(.color-swatch-container): Vertically center the swatches.

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.txt: Added.
* platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance.html: Added.
* platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.txt: Added.
* platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Remove InspectorCSSAgent from InstrumentingAgents on clearFrontend()
apavlov@chromium.org [Fri, 3 Aug 2012 10:45:00 +0000 (10:45 +0000)]
Web Inspector: Remove InspectorCSSAgent from InstrumentingAgents on clearFrontend()
https://bugs.webkit.org/show_bug.cgi?id=93082

Reviewed by Yury Semikhatsky.

* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::~InspectorCSSAgent):
(WebCore::InspectorCSSAgent::setFrontend):
(WebCore::InspectorCSSAgent::clearFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Profiles: extract save to file / load from code
commit-queue@webkit.org [Fri, 3 Aug 2012 10:28:23 +0000 (10:28 +0000)]
Web Inspector: Profiles: extract save to file / load from code
https://bugs.webkit.org/show_bug.cgi?id=92348

Patch by Eugene Klyuchnikov <eustas.big@gmail.com> on 2012-08-03
Reviewed by Yury Semikhatsky.

Source/WebCore:

Motivation: extract reusable code for timeline load/save.
FileUtils.js will contain common code. Not all code moved to FileUtils
to make review easier. This code will be moved in next patch.

Core abstractions: OutputStream and OutputStreamDelegate.

OutputStream is interface that is used to transfer entity divded
to chunks. Transfer process is explicitly initialized (startTransfer)
and finalized (finishTrnsfer).

OutputStreamDelegate is interface to receive notifications about
transfer process: onTransferStarted, onChunkTransferred, onTransferFinished.

ChunkedFileReader: utility class that loads file by chunks of specified
size and notifies given delegate. OutputStream is supplied as a
parameter of method "start".

ChunkedFileWriter: implementation of OutputStream that saves data
to file specified by file name and notifies given delegate.

* WebCore.gypi: Added 'FileUtils.js'.
* WebCore.vcproj/WebCore.vcproj: Added 'FileUtils.js'.
* inspector/compile-front-end.py: Added 'FileUtils.js'.
* inspector/front-end/FileUtils.js: Added.
(WebInspector.OutputStreamDelegate): Added.
(WebInspector.ChunkedFileReader): Added.
(WebInspector.createFileSelectorElement): Added utility method to construct
hidden input element to select file.
* inspector/front-end/HeapSnapshotLoader.js: Adopted new API.
* inspector/front-end/HeapSnapshotProxy.js: Adopted new API.
* inspector/front-end/HeapSnapshotView.js: Adopted new API.
(WebInspector.HeapSnapshotLoadFromFileDelegate):
Extracted from existing code.
(WebInspector.ChunkedFileWriter): Renamed and refactored.
(WebInspector.HeapSnapshotSaveToFileDelegate):
Extracted from existing code.
* inspector/front-end/ProfilesPanel.js: Adopted new API.

LayoutTests:

Changed test to adopt new API. Replaced FS mock with
reader mock.

* inspector/profiler/heap-snapshot-loader.html:
Adopted new API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Incorrect blob url href when inspecting
apavlov@chromium.org [Fri, 3 Aug 2012 10:25:20 +0000 (10:25 +0000)]
Web Inspector: Incorrect blob url href when inspecting
https://bugs.webkit.org/show_bug.cgi?id=93076

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Special-cased the "blob" scheme to return the original URL intact on completion.

* inspector/front-end/ResourceUtils.js:
(WebInspector.completeURL):

LayoutTests:

* inspector/styles/styles-url-linkify-expected.txt:
* inspector/styles/styles-url-linkify.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: add CSSRule memory instrumentation
yurys@chromium.org [Fri, 3 Aug 2012 10:18:31 +0000 (10:18 +0000)]
Web Inspector: add CSSRule memory instrumentation
https://bugs.webkit.org/show_bug.cgi?id=92962

Reviewed by Pavel Feldman.

Added memory footprint reporting method to CSSRule and its descendants.

* css/CSSCharsetRule.cpp:
(WebCore::CSSCharsetRule::reportDescendantMemoryUsage):
(WebCore):
* css/CSSCharsetRule.h:
(CSSCharsetRule):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::reportMemoryUsage):
(WebCore):
* css/CSSComputedStyleDeclaration.h:
(CSSComputedStyleDeclaration):
* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::reportDescendantMemoryUsage):
(WebCore):
* css/CSSFontFaceRule.h:
(CSSFontFaceRule):
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::reportDescendantMemoryUsage):
(WebCore):
* css/CSSImportRule.h:
(CSSImportRule):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::reportDescendantMemoryUsage):
(WebCore):
* css/CSSMediaRule.h:
(CSSMediaRule):
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::reportDescendantMemoryUsage):
(WebCore):
* css/CSSPageRule.h:
(CSSPageRule):
* css/CSSRule.cpp:
(WebCore::CSSRule::reportMemoryUsage): we manually implement polymorphic
call here to avoid adding vtable pointer to all CSSRule objects. Descendants
are expected to report their memory via reportDescendantMemoryUsage. The name
is intentionally different from reportMemoryUsage to avoid accidential infitite
recursion: if the descendants overrode non-virtual CSSRule::reportMemoryUsage,
it would be easy to add a new descendant type to the switch in
CSSRule::reportMemoryUsage without providing proper override for reportMemoryUsage
and CSSRule::reportMemoryUsage would end up calling itself.
(WebCore):
(WebCore::CSSRule::reportBaseClassMemoryUsage): again we cannot use
MemoryClassInfo::visitBaseClass like we do for virtual methods because it would
lead to a recursive call of CSSRule::reportMemoryUsage. This is why we use
reportBaseClassMemoryUsage to allow descendants to report objects referenced
from their base class.
* css/CSSRule.h:
(WebCore):
(CSSRule):
* css/CSSRuleList.cpp:
(WebCore::StaticCSSRuleList::reportMemoryUsage):
(WebCore):
* css/CSSRuleList.h:
(WebCore):
(CSSRuleList):
(StaticCSSRuleList):
(LiveCSSRuleList):
* css/CSSStyleDeclaration.h:
(WebCore):
(CSSStyleDeclaration):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::reportDescendantMemoryUsage):
(WebCore):
* css/CSSStyleRule.h:
(CSSStyleRule):
* css/CSSStyleSheet.cpp:
(StyleSheetCSSRuleList):
(WebCore::CSSStyleSheet::reportMemoryUsage):
* css/CSSUnknownRule.h:
(CSSUnknownRule):
(WebCore::CSSUnknownRule::reportDescendantMemoryUsage):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::reportMemoryUsage):
(WebCore):
(WebCore::StyleRuleCSSStyleDeclaration::reportMemoryUsage):
(WebCore::InlineCSSStyleDeclaration::reportMemoryUsage):
* css/PropertySetCSSStyleDeclaration.h:
(PropertySetCSSStyleDeclaration):
(StyleRuleCSSStyleDeclaration):
(InlineCSSStyleDeclaration):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::WebKitCSSKeyframeRule::reportDescendantMemoryUsage):
(WebCore):
* css/WebKitCSSKeyframeRule.h:
(WebKitCSSKeyframeRule):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::reportDescendantMemoryUsage):
(WebCore):
* css/WebKitCSSKeyframesRule.h:
(WebKitCSSKeyframesRule):
* css/WebKitCSSRegionRule.cpp:
(WebCore::WebKitCSSRegionRule::reportDescendantMemoryUsage):
(WebCore):
* css/WebKitCSSRegionRule.h:
(WebKitCSSRegionRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebCore::DragController::cleanupAfterSystemDrag should null-check page
abarth@webkit.org [Fri, 3 Aug 2012 10:14:44 +0000 (10:14 +0000)]
WebCore::DragController::cleanupAfterSystemDrag should null-check page
https://bugs.webkit.org/show_bug.cgi?id=61815

Reviewed by Eric Seidel.

* page/DragController.cpp:
(WebCore::DragController::dragEnteredOrUpdated):
(WebCore::DragController::doSystemDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[cmake] Cleanup FindHarfBuzz.cmake
commit-queue@webkit.org [Fri, 3 Aug 2012 10:02:37 +0000 (10:02 +0000)]
[cmake] Cleanup FindHarfBuzz.cmake
https://bugs.webkit.org/show_bug.cgi?id=92984

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-08-03
Reviewed by Hajime Morita.

Cleanup which didn't make it into my previous ptch.

* Source/cmake/FindHarfBuzz.cmake: Remove duplicate line, add a bit of documentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDelete text from password does nothing.
commit-queue@webkit.org [Fri, 3 Aug 2012 09:35:24 +0000 (09:35 +0000)]
Delete text from password does nothing.
https://bugs.webkit.org/show_bug.cgi?id=92040

Patch by Sergio Carlos Morales Angeles <carloschilazo@gmail.com> on 2012-08-03
Reviewed by Ryosuke Niwa.

Source/WebCore:

Use Editor::canDelete() to determine if field is editable or not.
Added password-delete-contents test.

Test: editing/deleting/password-delete-contents.html

* editing/EditorCommand.cpp:
(WebCore::enabledDelete):

LayoutTests:

Added regression test for password field content delete.

* editing/deleting/password-delete-contents-expected.txt: Added.
* editing/deleting/password-delete-contents.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124586 268f45cc-cd09-0410-ab3c-d52691b4dbfc