WebKit-https.git
8 years agoDFG JIT does not implement prototype chain or list caching for get_by_id.
commit-queue@webkit.org [Wed, 13 Jul 2011 21:44:42 +0000 (21:44 +0000)]
DFG JIT does not implement prototype chain or list caching for get_by_id.
https://bugs.webkit.org/show_bug.cgi?id=64147

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-13
Reviewed by Gavin Barraclough.

This implements unified support for prototype caching, prototype chain
caching, and polymorphic (i.e. list) prototype and prototype chain
caching.  This is done by creating common code for emitting prototype
or chain access stubs, and having it factored out into
generateProtoChainAccessStub().  This function is called by
tryCacheGetByID once the latter determines that some form of prototype
access caching is necessary (i.e. the slot being accessed is not on the
base value but on some other object).

Direct prototype list, and prototype chain list, caching is implemented by
linking the slow path to operationGetByIdProtoBuildList(), which uses the
same helper function (generateProtoChainAccessStub()) as tryCacheGetByID.

This change required ensuring that the value in the scratchGPR field in
StructureStubInfo is preserved even after the stub info is in the
chain, or proto_list, states.  Hence scratchGPR was moved out of the union
and into the top-level of StructureStubInfo.

* bytecode/StructureStubInfo.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::emitRestoreScratch):
(JSC::DFG::linkRestoreScratch):
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::dfgBuildGetByIDProtoList):
(JSC::DFG::tryCachePutByID):
* dfg/DFGRepatch.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-07-13 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Wed, 13 Jul 2011 21:44:29 +0000 (21:44 +0000)]
2011-07-13  Vitaly Repeshko  <vitalyr@chromium.org>

        [V8] Avoid memory leaks with hidden references.
        https://bugs.webkit.org/show_bug.cgi?id=64467

        Reviewed by Adam Barth.

        We used to have growing arrays of hidden references associated
        with objects. The entries in this array had no keys and were never
        removed. This patch changes the interface to require a reference
        name. This way it's harder to leak an unbounded number of
        objects. Also it makes our wrapper objects one machine word
        smaller.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImprove names of some ApplicationCacheStorage accessor methods
joepeck@webkit.org [Wed, 13 Jul 2011 21:40:54 +0000 (21:40 +0000)]
Improve names of some ApplicationCacheStorage accessor methods
https://bugs.webkit.org/show_bug.cgi?id=64433

Reviewed by Alexey Proskuryakov.

2011-07-13  Joseph Pecoraro  <joepeck@webkit.org>

        Some methods returned a bool for success/failure and
        actually returned a value as an out parameter so their
        name was confusing. Rename these methods to make them
        more clear.

        (WebCore::ApplicationCache::diskUsageForOrigin):
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::recalculateAvailableSpaceInQuota):
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::calculateQuotaForOrigin):
        (WebCore::ApplicationCacheStorage::calculateUsageForOrigin):
        (WebCore::ApplicationCacheStorage::calculateRemainingSizeForOriginExcludingCache):
        (WebCore::ApplicationCacheStorage::checkOriginQuota):
        * loader/appcache/ApplicationCacheStorage.h:
        * loader/appcache/ApplicationCache.cpp:
        Rename the methods.

        * WebCore.exp.in:
        Replaced old versions. Also, calculateRemaining wasn't needed
        outside WebCore, so no longer export it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSome ApplicationCache Origin Cleanup
joepeck@webkit.org [Wed, 13 Jul 2011 21:40:40 +0000 (21:40 +0000)]
Some ApplicationCache Origin Cleanup
https://bugs.webkit.org/show_bug.cgi?id=64431

Reviewed by Alexey Proskuryakov.

2011-07-13  Joseph Pecoraro  <joepeck@webkit.org>

        - m_loadedSize is inaccurate. This just replaces it with
        calls to ApplicationCache::estimatedSizeInStorage.

        - m_availableSpaceInQuota can get out of date, so we just
        recalculate it at the start of appcache downloads.

        * loader/appcache/ApplicationCacheGroup.h:
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::ApplicationCacheGroup):
        (WebCore::ApplicationCacheGroup::didReceiveData):
        Remove references to m_loadedSize.

        (WebCore::ApplicationCacheGroup::didFinishLoading):
        Replace m_loadedSize with estimatedSizeInStorage after we
        add the new cached resource to the cache. The calculation
        already happened so this check is fast.

        (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
        When we start the Downloading phase, recalculate the quota
        so that we have an up to date quota value so that we can
        break early if needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoApplicationCache Quota Output is Flakey
joepeck@webkit.org [Wed, 13 Jul 2011 21:40:27 +0000 (21:40 +0000)]
ApplicationCache Quota Output is Flakey
https://bugs.webkit.org/show_bug.cgi?id=64410

Reviewed by Alexey Proskuryakov.

2011-07-13  Joseph Pecoraro  <joepeck@webkit.org>

        Have the tests truncate the number of bytes needed in
        the delegate callback to get an approximation of how
        much space was needed.

        * http/tests/appcache/origin-quota-continued-download-expected.txt:
        * http/tests/appcache/origin-quota-continued-download-multiple-manifests-expected.txt:
        * http/tests/appcache/origin-quota-continued-download-multiple-manifests.html:
        * http/tests/appcache/origin-quota-expected.txt:
        Update the output and clarify what the multiple-manifests test
        is looking for in the space needed output.

        * platform/mac/Skipped:
        * platform/qt/Skipped:
        Unskip the tests.

2011-07-13  Joseph Pecoraro  <joepeck@webkit.org>

        Unify the delegate logging for reaching application cache
        quotas. Truncate the space needed to the nearest 10000
        for less flakey test output. This also better supports
        printing NSUInteger on non-64 bit systems by casting to
        an unsigned long.

        * DumpRenderTree/mac/UIDelegate.mm:
        (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:totalSpaceNeeded:]):
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::dumpApplicationCacheQuota):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update chromium gpu expectations.
jamesr@google.com [Wed, 13 Jul 2011 20:55:54 +0000 (20:55 +0000)]
[chromium] Update chromium gpu expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Prettify spacing in test_expectations.txt
dglazkov@chromium.org [Wed, 13 Jul 2011 19:52:49 +0000 (19:52 +0000)]
[Chromium] Prettify spacing in test_expectations.txt

* platform/chromium/test_expectations.txt: Ran through the new parser/serializer code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused TestExpectations._overrides.
dglazkov@chromium.org [Wed, 13 Jul 2011 19:41:02 +0000 (19:41 +0000)]
Remove unused TestExpectations._overrides.
https://bugs.webkit.org/show_bug.cgi?id=64470

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed unused member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIntroduce TestExpectationSerializer.list_to_string.
dglazkov@chromium.org [Wed, 13 Jul 2011 19:40:09 +0000 (19:40 +0000)]
Introduce TestExpectationSerializer.list_to_string.
https://bugs.webkit.org/show_bug.cgi?id=64462

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Added list_to_string and change the relevant callsite to use it.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests for it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConsolidate expectations parsing code.
dglazkov@chromium.org [Wed, 13 Jul 2011 19:36:47 +0000 (19:36 +0000)]
Consolidate expectations parsing code.
https://bugs.webkit.org/show_bug.cgi?id=64460

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Folded TestExpectationParser._split_expectation_string into TestExpectationParser.parse.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStandardize WinCairo conditionalized code under PLATFORM macro.
bfulgham@webkit.org [Wed, 13 Jul 2011 19:31:52 +0000 (19:31 +0000)]
Standardize WinCairo conditionalized code under PLATFORM macro.
https://bugs.webkit.org/show_bug.cgi?id=64377

Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

* wtf/Platform.h: Update to use PLATFORM(WIN_CAIRO) for tests.

Source/WebCore:

Update compile-time conditions that had previously used #ifdef
of WIN_CAIRO to consistently use PLATFORM(WIN_CAIRO).

* WebCore.vcproj/WebCoreCairo.vsprops: Remove redundant declaration
  of WIN_CAIRO.
* WebCore.vcproj/WebCoreDebugCairoCFLite.vsprops: Update to use
  the existing WinCairo.vsprops file.
* WebCorePrefix.h: Update for new WTF_PLATFORM_WIN_CAIRO define.
* config.h: Update to use PLATFORM(WIN_CAIRO).

Tools:

Update compile-time conditions that had previously used #ifdef
of WIN_CAIRO to consistently use PLATFORM(WIN_CAIRO).

* DumpRenderTree/config.h: Switch to PLATFORM(WIN_CAIRO)
* DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Remove redundant
  define of WIN_CAIRO=1.
* DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Add
  WinCairo.vsprops to set (to match Release build).

WebKitLibraries:

* win/tools/vsprops/WinCairo.vsprops: Update to comply with PLATFORM
  macro definition (WTF_PLATFORM_WIN_CAIRO)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPossible race condition in ThreadIdentifierData::initializeKeyOnce and shouldCallReal...
levin@chromium.org [Wed, 13 Jul 2011 19:19:23 +0000 (19:19 +0000)]
Possible race condition in ThreadIdentifierData::initializeKeyOnce and shouldCallRealDebugger.
https://bugs.webkit.org/show_bug.cgi?id=64465

Reviewed by Dmitry Titov.

There isn't a good way to test this as it is very highly unlikely to occur.

Source/JavaScriptCore:

* wtf/ThreadIdentifierDataPthreads.cpp:
(WTF::ThreadIdentifierData::initializeKeyOnce): Since scoped static initialization
isn't thread-safe, change the initialization to be global.

Source/WebKit2:

* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::shouldCallRealDebugger): :Since scoped static initialization
isn't thread-safe, change the initialization to be global.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=64424
barraclough@apple.com [Wed, 13 Jul 2011 18:59:34 +0000 (18:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=64424
Our direct eval behaviour deviates slightly from the spec.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

The ES5 spec defines a concept of 'Direct Call to Eval' (see section 15.1.2.1.1), where
behaviour will differ from that of an indirect call (e.g. " { eval: window.eval }.eval();"
or "var a = eval; a();" are indirect calls), particularly in non-strict scopes variables
may be introduced into the caller's environment.

ES5 direct calls are any call where the callee function is provided by a reference, a base
of that Reference is an EnvironmentRecord (this corresponds to all productions
"PrimaryExpression: Identifier", see 10.2.2.1 GetIdentifierReference), and where the name
of the reference is "eval". This means any expression of the form "eval(...)", and that
calls the standard built in eval method from on the Global Object, is considered to be
direct.

In JavaScriptCore we are currently overly restrictive. We also check that the
EnvironmentRecord that is the base of the reference is the Declaractive Environment Record
at the root of the scope chain, corresponding to the Global Object - an "eval(..)" statement
that hits a var eval in a nested scope is not considered to be direct. This behaviour does
not emanate from the spec, and is incorrect.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
    - Fixed direct eval check in op_call_eval.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
    - Fixed direct eval check in op_call_eval.
* runtime/Executable.h:
(JSC::isHostFunction):
    - Added check for host function with specific NativeFunction.

LayoutTests:

Correct expected results.

* fast/js/eval-keyword-vs-function-expected.txt:
* fast/js/eval-keyword-vs-function.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Exclusions] Fix for comment #23 on wrap-shape parsing bug 61726
commit-queue@webkit.org [Wed, 13 Jul 2011 18:56:37 +0000 (18:56 +0000)]
[CSS Exclusions] Fix for comment #23 on wrap-shape parsing bug 61726
https://bugs.webkit.org/show_bug.cgi?id=64464

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-13
Reviewed by Tony Chang.

No new tests needed.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseWrapShapeRect): Removed the "valid" local.
(WebCore::CSSParser::parseWrapShapeCircle): Removed the "valid" local.
(WebCore::CSSParser::parseWrapShapeEllipse): Removed the "valid" local.
* css/CSSPrimitiveValue.cpp:
* css/CSSWrapShapes.h:
(WebCore::CSSWrapShapePolygon::getXAt): Replaced bit shift with multiplication.
(WebCore::CSSWrapShapePolygon::getYAt): Replaced bit shift with multiplication.
* rendering/style/RenderStyle.cpp:
* rendering/style/StyleRareNonInheritedData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Patch by Abhishek Arya <inferno@chromium.org> on 2011-07-13
inferno@chromium.org [Wed, 13 Jul 2011 18:51:44 +0000 (18:51 +0000)]
Source/WebCore: Patch by Abhishek Arya <inferno@chromium.org> on 2011-07-13
Reviewed by Adam Barth.

Issue with Frame lifetime due to deletion in beforeload event.
https://bugs.webkit.org/show_bug.cgi?id=64457

Copy the Frame protector higher in the stack from loadWithDocumentLoader
to loadFrameRequest since any of loadPostRequest or loadURL can call
loadWithDocumentLoader, thereby dispatching the beforeload event and
blowing away the frame. This deleted frame will be later accessed in
the loadFrameRequest function causing a crash.

Test: fast/events/form-iframe-target-before-load-crash2.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadWithDocumentLoader):

LayoutTests: Tests that we do not crash when frame is blown away in a beforeload
event.
https://bugs.webkit.org/show_bug.cgi?id=64457

Reviewed by Adam Barth.

* fast/events/form-iframe-target-before-load-crash.html:
* fast/events/form-iframe-target-before-load-crash2-expected.txt: Added.
* fast/events/form-iframe-target-before-load-crash2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSSRegions]content:-webkit-from-flow not applied correctly
commit-queue@webkit.org [Wed, 13 Jul 2011 18:49:16 +0000 (18:49 +0000)]
[CSSRegions]content:-webkit-from-flow not applied correctly
https://bugs.webkit.org/show_bug.cgi?id=64438

Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-13
Reviewed by Tony Chang.

Source/WebCore:

Forgot to modify getStringValue(), i was modifying only getStringValue(ExceptionCode&).

Test: fast/regions/content-webkit-from-flow-parsing.html (existing).

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::getStringValue):

LayoutTests:

Correct the layout test for content:-webkit-from-flow parsing. Testing getComputedStyle values for content property
was not done properly, as "flow-name" was passed instead of "-webkit-from-flow:'flow-name'".

* fast/regions/content-webkit-from-flow-parsing-expected.txt:
* fast/regions/script-tests/content-webkit-from-flow-parsing.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEliminate TestExpectationsFile.
dglazkov@chromium.org [Wed, 13 Jul 2011 18:40:12 +0000 (18:40 +0000)]
Eliminate TestExpectationsFile.
https://bugs.webkit.org/show_bug.cgi?id=64458

Turns out, we can just use a Python list.

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Folded TestExpectationsFile.append into TestExpectationParser.parse_list,
    removed TestExpectationsFile.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Moved tests to better reflect new names, removed iterator test,
    since there's no more custom iterator machinery.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't reuse the last InsertTextCommand
rniwa@webkit.org [Wed, 13 Jul 2011 17:55:20 +0000 (17:55 +0000)]
Don't reuse the last InsertTextCommand
https://bugs.webkit.org/show_bug.cgi?id=64416

Reviewed by Justin Garcia.

This patch makes the interface of InsertTextCommand less foreign. It now takes arguments in
its constructor and executes the command in doApply like other edit commands.

* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::applyCommandToComposite): Added.
* editing/CompositeEditCommand.h:
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::InsertTextCommand): Takes arguments input used to take.
(WebCore::InsertTextCommand::doApply): Renamed from input.
* editing/InsertTextCommand.h:
(WebCore::InsertTextCommand::create): Takes arguments input used to take.
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::insertTextRunWithoutNewlines): Creates InsertTextCommand.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-07-13 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 13 Jul 2011 17:50:18 +0000 (17:50 +0000)]
2011-07-13  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, added my other email addresses.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-07-12 Dmitry Lomov <dslomov@google.com>
dslomov@google.com [Wed, 13 Jul 2011 17:49:11 +0000 (17:49 +0000)]
2011-07-12  Dmitry Lomov  <dslomov@google.com>

        https://bugs.webkit.org/show_bug.cgi?id=63041
        [Chromium][V8] Make DOMDataStore per-isolate
        This patch:
         - makes DOMData class an utility class with static members only
         - adds an isolate-specific DOMDataStore in V8BindingPerIsolateData.
        Dromaeo benchmarks are not affected.

        Reviewed by Adam Barth.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFolks should only be listed once.
abarth@webkit.org [Wed, 13 Jul 2011 17:36:43 +0000 (17:36 +0000)]
Folks should only be listed once.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-07-13 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 13 Jul 2011 17:10:21 +0000 (17:10 +0000)]
2011-07-13  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, adding myself as Reviewer.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix flickering bug introduced by my previous patch. I forgot to change
abarth@webkit.org [Wed, 13 Jul 2011 17:09:04 +0000 (17:09 +0000)]
Fix flickering bug introduced by my previous patch.  I forgot to change
the name of the class everywhere.

* Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago [GTK] media/media-blocked-by-willsendrequest.html fails
philn@webkit.org [Wed, 13 Jul 2011 17:04:28 +0000 (17:04 +0000)]
    [GTK] media/media-blocked-by-willsendrequest.html fails
        https://bugs.webkit.org/show_bug.cgi?id=63699

        Reviewed by Martin Robinson.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (willSendRequestCallback): Abort the request if explicitely asked
        by the LayoutTestController's willSendRequestReturnsNull() function.

LayoutTests:

        [GTK] media/media-blocked-by-willsendrequest.html fails
        https://bugs.webkit.org/show_bug.cgi?id=63699

        Reviewed by Martin Robinson.

        * platform/gtk/Skipped: Unskip fixed test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove "Dismiss" button from garden-o-matic butterbar
abarth@webkit.org [Wed, 13 Jul 2011 17:02:57 +0000 (17:02 +0000)]
Remove "Dismiss" button from garden-o-matic butterbar
https://bugs.webkit.org/show_bug.cgi?id=64443

Reviewed by Dimitri Glazkov.

We don't have any persistent butter bar messages yet, so the dismiss
button is premature (and fairly heavy, visually).

* Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-07-12 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 13 Jul 2011 17:02:48 +0000 (17:02 +0000)]
2011-07-12  Simon Fraser  <simon.fraser@apple.com>

        Rename compositing-related updateContentsScale() methods
        https://bugs.webkit.org/show_bug.cgi?id=64430

        Reviewed by Joseph Pecoraro.

        Rename updateContentsScale() to something less presumptuous; layers may choose
        to do something other than update their contents scale when the page scale factor
        changes. pageScaleFactorChanged() is a better name.

        * page/Frame.cpp:
        (WebCore::Frame::pageScaleFactorChanged):
        (WebCore::Frame::scalePage):
        * page/Frame.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::pageScaleFactorChanged):
        * rendering/RenderLayer.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::pageScaleFactorChanged):
        * rendering/RenderLayerBacking.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::pageScaleFactorChanged):
        * rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefine garden-o-matic status pane
abarth@webkit.org [Wed, 13 Jul 2011 17:01:38 +0000 (17:01 +0000)]
Refine garden-o-matic status pane
https://bugs.webkit.org/show_bug.cgi?id=64442

Reviewed by Dimitri Glazkov.

This patch makes two improvements to the status pane:

1) We only query the server for failure types that we're expecting.
   This dramatically reduces the number of HTTP requests, making
   loading the status pane faster.

2) The status pane now displays which test and which builder it is
   showing results for.

* Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic should show test results
abarth@webkit.org [Wed, 13 Jul 2011 16:57:14 +0000 (16:57 +0000)]
garden-o-matic should show test results
https://bugs.webkit.org/show_bug.cgi?id=64440

Reviewed by Adam Roben.

This patch introduces the results detail pane, which appears at the
bottom of the window and contains test results from the bots.
Currently, you can activate the pane by mousing over one of the builder
names associated with a failing test.

This is just a first iteration of the UI.  There's no way to resize or
zoom in on elements of the details pane, and images likely aren't sized
correctly, but it's a place to start.

* Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
    - Add constants for our data attributes so we don't typo them!
* Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
    - Add DOM structure for the details pane.
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
    - Bind events for showing and hiding the details pane.
* Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
    - Reduce the number of result types that we query for to avoid
      overfilling the details pane.  We'll probably need another
      solution here in the long-term.  For example, we could use tabs
      to pack more results into the pane.
* Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
    - Now that we're using the config package during testing, we need
      to include it in the testing HTML.
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
    - Change the DOM structure of the results detail to make it fit
      nicely in the details pane (rather than flowing freely in the
      body, as it did before).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake TestFailures show every time a possibly-flaky test failed, but hide it by default
aroben@apple.com [Wed, 13 Jul 2011 16:30:22 +0000 (16:30 +0000)]
Make TestFailures show every time a possibly-flaky test failed, but hide it by default

It's useful to be able to see every time a flaky test failed to see whether it failed the
same way every time. But doing so takes a lot of space, so the list of failures is now
collapsed by default and can be revealed using a disclosure triangle.

Fixes <http://webkit.org/b/64455> TestFailures page doesn't show as much information for
flaky tests as I would like, even though the page is already so long

Reviewed by Dimitri Glazkov.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
(FlakyLayoutTestDetector.prototype.allFailures): Replaced flakinessExamples with this
function. Now returns all failures for the given test.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
Added. This just contains some simple tests of the FlakyLayoutTestDetector class. We'll add
more over time.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
(LayoutTestHistoryAnalyzer.prototype.start): Updated the documentation comment to reflect
that we no longer return passing builds for possibly-flaky tests.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
(.existing-bugs-list, .suspect-revisions-list, .flakiness-examples-list): Make the list of
flakiness examples small, too, since it can get quite long.

(.disclosure-triangle):
(.expanded > .disclosure-triangle):
Simple styles for the disclosure triangle.

(.flakiness-examples-list): Collapse the list by default.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._displayBuilder): Pass the total number of builds analyzed to
_domForPossiblyFlakyTests.
(ViewController.prototype._domForPossiblyFlakyTests): Put a disclosure triangle to the left
of each test name, and the number of failures to the right. When the disclosure triangle is
clicked for the first time, we build up the list of failures and expand the element. After
that we just collapse or expand the element on subsequent clicks.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
Pulled in new tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTeach TestFailures to understand NRWT's output when it exits early due to too many...
aroben@apple.com [Wed, 13 Jul 2011 16:06:52 +0000 (16:06 +0000)]
Teach TestFailures to understand NRWT's output when it exits early due to too many failures

Fixes <http://webkit.org/b/64456> TestFailures page reports way too many failures when NRWT
exits early

Reviewed by Dimitri Glazkov.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Relaxed the "Exiting early" test not to require
it to be at the beginning of the line, since NRWT prints a bunch of junk earlier in the
line. Tightened up the regex that's used to parse the number of failing tests to require the
leading number to be followed by whitespace so that we won't parse the "2011" in
"2011-07-13" as a number of failures.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
Added a test for the above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExtract model-like TestExpectationLine and TestExpectationFile from TestExpectations.
dglazkov@chromium.org [Wed, 13 Jul 2011 15:49:08 +0000 (15:49 +0000)]
Extract model-like TestExpectationLine and TestExpectationFile from TestExpectations.
https://bugs.webkit.org/show_bug.cgi?id=64386

This is the first step in converting TestExpectations to a real model.
* TestExpectationsLine represents a line in the test_expectations.txt file, and
* TestExpectationsFile represents the file, which is a collection of lines.

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix compile for QRawFont.
commit-queue@webkit.org [Wed, 13 Jul 2011 15:43:43 +0000 (15:43 +0000)]
Fix compile for QRawFont.

https://bugs.webkit.org/show_bug.cgi?id=64453

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-07-13
Reviewed by Andreas Kling.

* platform/graphics/GraphicsContext.h:
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::drawGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-07-13 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 13 Jul 2011 14:52:07 +0000 (14:52 +0000)]
2011-07-13  Xan Lopez  <xlopez@igalia.com>

        [GTK] Do not grab focus too early in DRT.

        Reviewed by Gustavo Noronha.

        It causes a layout to happen and a progress signal to be emitted
        since r90900, but at this point we don't have a
        LayoutTestController object and we'll eventually crash. Since we
        already grab focus at the beginning of runTest() this is
        redundant, so get rid of it to fix the crash.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (main): remove call to grab_focus

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-07-13 Gabor Loki <loki@webkit.org>
loki@webkit.org [Wed, 13 Jul 2011 14:31:45 +0000 (14:31 +0000)]
2011-07-13  Gabor Loki  <loki@webkit.org>

        [Qt] Flakey test: xmlhttprequest-50ms-download-dispatch.html on ARM
        https://bugs.webkit.org/show_bug.cgi?id=64452

        Rubber-stamped by Csaba Osztrogonác

        * platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReviewed by Andreas Kling.
ademar.reis@openbossa.org [Wed, 13 Jul 2011 14:25:23 +0000 (14:25 +0000)]
Reviewed by Andreas Kling.

Broken build on QNX
https://bugs.webkit.org/show_bug.cgi?id=63717

QNX doesn't support pthread's SA_RESTART (required by
JSC_MULTIPLE_THREADS), JIT is broken at runtime and there a
few minor compilation errors here and there.

Original patch by Ritt Konstantin <ritt.ks@gmail.com>, also
tested by him on QNX v6.5 (x86)

* wtf/DateMath.cpp: fix usage of abs/labs
* wtf/Platform.h: Disable JIT and JSC_MULTIPLE_THREADS
* wtf/StackBounds.cpp: Add a couple of missing includes (and sort them)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIf a compiler has nullptr support, include <cstddef> to get the nullptr_t definition
andersca@apple.com [Wed, 13 Jul 2011 14:11:49 +0000 (14:11 +0000)]
If a compiler has nullptr support, include <cstddef> to get the nullptr_t definition
https://bugs.webkit.org/show_bug.cgi?id=64429

Include the cstddef which has the nullptr_t typedef according to the C++0x standard.

* wtf/NullPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReference Geolocation object from GeoNotifier and Geolocation::setIsAllowed.
jknotten@chromium.org [Wed, 13 Jul 2011 14:11:14 +0000 (14:11 +0000)]
Reference Geolocation object from GeoNotifier and Geolocation::setIsAllowed.
https://bugs.webkit.org/show_bug.cgi?id=64363

Reviewed by Tony Gentilcore.

Source/WebCore:

Test: fast/dom/Geolocation/remove-remote-context-in-error-callback-crash.html

* page/Geolocation.cpp:
(WebCore::Geolocation::setIsAllowed):
* page/Geolocation.h:

LayoutTests:

* fast/dom/Geolocation/remove-remote-context-in-error-callback-crash.html: Added.
* fast/dom/Geolocation/resources/remove-remote-context-in-error-callback-crash-inner.html: Added.
* fast/dom/Geolocation/script-tests/remove-remote-context-in-error-callback-crash.js: Added.
* fast/dom/Geolocation/remove-remote-context-in-error-callback-crash-expected.txt: Added.
(gc):
(onIframeReady):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Network panel search needs each resource to have unique identifier.
vsevik@chromium.org [Wed, 13 Jul 2011 14:02:25 +0000 (14:02 +0000)]
Web Inspector: Network panel search needs each resource to have unique identifier.
https://bugs.webkit.org/show_bug.cgi?id=64287

Reviewed by Pavel Feldman.

* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkDispatcher):
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._appendResource):
(WebInspector.NetworkPanel.prototype._frameNavigated):
(WebInspector.NetworkPanel.prototype._updateSearchMatchedListAfterResourceIdentifierChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBridge RenderBoxModelObject::calculateBackgroundImageGeometry parameters into a class
commit-queue@webkit.org [Wed, 13 Jul 2011 13:45:24 +0000 (13:45 +0000)]
Bridge RenderBoxModelObject::calculateBackgroundImageGeometry parameters into a class
https://bugs.webkit.org/show_bug.cgi?id=63987

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-13
Reviewed by Hajime Morita.

Change doesn't add new functionality. No test needed.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::maskClipRect):
(WebCore::RenderBox::repaintLayerRectsForImage):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatX):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatY):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::clip):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::relativePhase):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::destOrigin):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestOrigin):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::destRect):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestRect):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::phase):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhase):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::tileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setTileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhaseX):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhaseY):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactoring: Ignored ExceptionCode value should be less annoying.
morrita@google.com [Wed, 13 Jul 2011 13:31:23 +0000 (13:31 +0000)]
Refactoring: Ignored ExceptionCode value should be less annoying.
https://bugs.webkit.org/show_bug.cgi?id=63688

Source/JavaScriptCore:

Added ASSERT_AT macro.

Reviewed by Darin Adler.

* wtf/Assertions.h:

Source/WebCore:

- Introduced ExceptionCodePlaceholder class for the default parameter of ExceptionCode.
- Introduced ASSERT_NO_EXCEPTION to check ExceptionCode not set to non-zero after the call.
- Adopted ASSERT_NO_EXCEPTION in Range.cpp

No new tests. No behaviour change.

Reviewed by Darin Adler.

* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/ExceptionCodePlaceholder.h: Added.
(WebCore::ExceptionCodePlaceholder::ExceptionCodePlaceholder):
(WebCore::ExceptionCodePlaceholder::operator ExceptionCode& ):
(WebCore::IgnorableExceptionCode::IgnorableExceptionCode):
(WebCore::CheckedExceptionCode::CheckedExceptionCode):
(WebCore::CheckedExceptionCode::~CheckedExceptionCode):
* dom/Range.cpp:
(WebCore::Range::Range):
(WebCore::Range::editingStartPosition):
* dom/Range.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Wed, 13 Jul 2011 13:02:54 +0000 (13:02 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-mac/Skipped: Skip failing tests.
* platform/qt/Skipped: Skip svg/text/small-fonts-2.svg because of the 32/64 bit bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Remove invalid signal/slot connection in QTouchWebView.
andreas.kling@nokia.com [Wed, 13 Jul 2011 13:01:44 +0000 (13:01 +0000)]
[Qt][WK2] Remove invalid signal/slot connection in QTouchWebView.
https://bugs.webkit.org/show_bug.cgi?id=64450

Reviewed by Benjamin Poulain.

The focusNextPrevChild() signal was removed, so we shouldn't try to
connect to it.

* UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPagePrivate::setPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-07-13 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 13 Jul 2011 12:54:52 +0000 (12:54 +0000)]
2011-07-13  Nikolas Zimmermann  <nzimmermann@rim.com>

        Regression: OOB read in svg text run
        https://bugs.webkit.org/show_bug.cgi?id=63627

        Not reviewed.

        Fixed last minute typo leading to assertions.

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Undelayed WorkItems are leaked after execution.
andreas.kling@nokia.com [Wed, 13 Jul 2011 12:32:30 +0000 (12:32 +0000)]
[Qt][WK2] Undelayed WorkItems are leaked after execution.
https://bugs.webkit.org/show_bug.cgi?id=64447

Reviewed by Benjamin Poulain.

* Platform/qt/WorkQueueQt.cpp:
(WorkQueue::WorkItemQt::executeAndDelete):
(WorkQueue::WorkItemQt::timerEvent):
(WorkQueue::scheduleWork):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] REGRESSION(r90634): It made http/tests/misc/script-async.html fail with Qt 4.8.x
benjamin.poulain@nokia.com [Wed, 13 Jul 2011 12:13:10 +0000 (12:13 +0000)]
[Qt] REGRESSION(r90634): It made http/tests/misc/script-async.html fail with Qt 4.8.x
https://bugs.webkit.org/show_bug.cgi?id=64352

Reviewed by Andreas Kling.

Unskip http/tests/misc/script-async.html since the original change has been reverted.

* platform/qt-4.8/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium DevTools: Enable clear cache and cookies from network panel in chromium.
vsevik@chromium.org [Wed, 13 Jul 2011 12:02:03 +0000 (12:02 +0000)]
Chromium DevTools: Enable clear cache and cookies from network panel in chromium.
https://bugs.webkit.org/show_bug.cgi?id=64095

Reviewed by Pavel Feldman.

* src/js/DevTools.js:
():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-07-12 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 13 Jul 2011 11:51:53 +0000 (11:51 +0000)]
2011-07-12  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: factor NetworkLogView out of Network panel
        https://bugs.webkit.org/show_bug.cgi?id=64366

        Reviewed by Pavel Feldman.

        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkLogView):
        (WebInspector.NetworkLogView.prototype.get useLargeRows):
        (WebInspector.NetworkLogView.prototype.set allowPopover):
        (WebInspector.NetworkLogView.prototype.elementsToRestoreScrollPositionsFor):
        (WebInspector.NetworkLogView.prototype.resize):
        (WebInspector.NetworkLogView.prototype._createTable):
        (WebInspector.NetworkLogView.prototype.show):
        (WebInspector.NetworkLogView.prototype.hide):
        (WebInspector.NetworkLogView.prototype._reset):
        (WebInspector.NetworkLogView.prototype.switchToDetailedView):
        (WebInspector.NetworkLogView.prototype.switchToBriefView):
        (WebInspector.NetworkLogView.prototype.get _setLargerResources):
        (WebInspector.NetworkLogView.prototype._getPopoverAnchor):
        (WebInspector.NetworkPanel):
        (WebInspector.NetworkPanel.prototype.get toolbarItemLabel):
        (WebInspector.NetworkPanel.prototype.get statusBarItems):
        (WebInspector.NetworkPanel.prototype.elementsToRestoreScrollPositionsFor):
        (WebInspector.NetworkPanel.prototype.resize):
        (WebInspector.NetworkPanel.prototype._reset):
        (WebInspector.NetworkPanel.prototype.updateSidebarWidth):
        (WebInspector.NetworkPanel.prototype.updateMainViewWidth):
        (WebInspector.NetworkPanel.prototype.handleShortcut):
        (WebInspector.NetworkPanel.prototype.show):
        (WebInspector.NetworkPanel.prototype.hide):
        (WebInspector.NetworkPanel.prototype.get resources):
        (WebInspector.NetworkPanel.prototype.resourceById):
        (WebInspector.NetworkPanel.prototype.canShowAnchorLocation):
        (WebInspector.NetworkPanel.prototype.showAnchorLocation):
        (WebInspector.NetworkPanel.prototype._onViewCleared):
        (WebInspector.NetworkPanel.prototype._onRowSizeChanged):
        (WebInspector.NetworkPanel.prototype._onResourceSelected):
        (WebInspector.NetworkPanel.prototype._showResource):
        (WebInspector.NetworkPanel.prototype._closeVisibleResource):
        (WebInspector.NetworkPanel.prototype._toggleGridMode):
        (WebInspector.NetworkPanel.prototype._toggleViewingResourceMode):
        (WebInspector.NetworkPanel.prototype.performSearch):
        (WebInspector.NetworkPanel.prototype.jumpToPreviousSearchResult):
        (WebInspector.NetworkPanel.prototype.jumpToNextSearchResult):
        (WebInspector.NetworkPanel.prototype.searchCanceled):
        (WebInspector.NetworkDataGridNode):
        (WebInspector.NetworkDataGridNode.prototype.isFilteredOut):
        (WebInspector.NetworkDataGridNode.prototype.select):
        (WebInspector.NetworkDataGridNode.prototype.get selectable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r90634.
commit-queue@webkit.org [Wed, 13 Jul 2011 11:47:35 +0000 (11:47 +0000)]
Unreviewed, rolling out r90634.
http://trac.webkit.org/changeset/90634
https://bugs.webkit.org/show_bug.cgi?id=64448

Qt HTTP Pipelining is not robust enough to be used in that
generic way. (Requested by benjaminp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-13

* platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Add expected results for the new passing tests and unskip them.
ossy@webkit.org [Wed, 13 Jul 2011 11:35:40 +0000 (11:35 +0000)]
[Qt] Add expected results for the new passing tests and unskip them.

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-07-13
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:
* platform/qt/fast/[...]: Added.
* platform/qt/svg/[...]: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-07-13 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 13 Jul 2011 11:33:53 +0000 (11:33 +0000)]
2011-07-13  Nikolas Zimmermann  <nzimmermann@rim.com>

        Regression: OOB read in svg text run
        https://bugs.webkit.org/show_bug.cgi?id=63627

        Reviewed by Zoltan Herczeg.

        A TextRun is constructed for a portion of a string [a,b] whose original length is c (0 < a < b < c).
        The TextRun charactersLength variable stores the length of the remaining text from (b..c) in order
        to support ligatures in SVG Fonts. Example: <text>ffl</text>. When measuring the advance from char 0
        to char 1 the whole 'ffl' text must be passed to the SVG glyph selection code, as the SVG Font may
        define a single glyph for the characters 'ffl' thus leading to a single character long text
        pointing to the ffl ligature, not three individual 'f' / 'f' / 'l' characters anymore.

        constructTextRun(..const UChar*, int length, ..) did not correctly calculate the maximum length (b..c).
        The passed in UChar buffer starts at eg. textRenderer->characters() + start(), and following condition
        holds true for 'length': start() + length <= textRenderer->textLength() (which denotes the maximum length
        of the textRenderer->characters() buffer). We have to keep track of the start() offset, so that we
        can calculate the charactersLength for the TextRun correctly: textRenderer->textLength() - start().

        There are also other cases like RenderCombinedText and/or the presence of hyphens that were incorrectly
        tracked. Only InlineTextBox had to be fixed, the other callsites in eg. RenderBlockLineLayout already
        computed the maximum length correctly - I assured this by valgrind runs on all SVG Font tests.

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        (WebCore::InlineTextBox::paintSelection):
        (WebCore::InlineTextBox::constructTextRun): Add maximumLength parameter to constructTextRun.
        * rendering/InlineTextBox.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agodidFirstVisuallyNonEmptyLayout dispatched too early
antti@apple.com [Wed, 13 Jul 2011 10:23:54 +0000 (10:23 +0000)]
didFirstVisuallyNonEmptyLayout dispatched too early
https://bugs.webkit.org/show_bug.cgi?id=64412

Reviewed by Darin Adler and Sam Weinig.

Improve the mechanism that dispatches didFirstVisuallyNonEmptyLayout

- Wait until a threshold of characters and pixels has been exceeded before dispatching.
- Wait until stylesheets are loaded (painting is disabled in this case).

* page/FrameView.cpp:
(WebCore::FrameView::reset):
(WebCore::FrameView::performPostLayoutTasks):
* page/FrameView.h:
(WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount):
(WebCore::FrameView::incrementVisuallyNonEmptyPixelCount):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::RenderImage):
(WebCore::RenderImage::imageChanged):
* rendering/RenderImage.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::RenderText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Also stop the scale commit timer when commitScaleChange is called explicitly.
jocelyn.turcotte@nokia.com [Wed, 13 Jul 2011 09:50:10 +0000 (09:50 +0000)]
[Qt] Also stop the scale commit timer when commitScaleChange is called explicitly.
https://bugs.webkit.org/show_bug.cgi?id=64357

Reviewed by Benjamin Poulain.

* UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::timerEvent):
(QTouchWebPagePrivate::commitScaleChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r90893 and r90894.
commit-queue@webkit.org [Wed, 13 Jul 2011 09:40:51 +0000 (09:40 +0000)]
Unreviewed, rolling out r90893 and r90894.
http://trac.webkit.org/changeset/90893
http://trac.webkit.org/changeset/90894
https://bugs.webkit.org/show_bug.cgi?id=64441

NRWT still doesn't work on qt-mac platform (Requested by Ossy
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-13

Tools:

* Scripts/run-webkit-tests:
(useNewRunWebKitTests):

LayoutTests:

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add chromium mac gpu baseline for webgl-background-color.html
jamesr@google.com [Wed, 13 Jul 2011 09:09:53 +0000 (09:09 +0000)]
[chromium] Add chromium mac gpu baseline for webgl-background-color.html

* platform/chromium-gpu-mac/compositing/webgl/webgl-background-color-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add two chromium gpu linux baselines.
jamesr@google.com [Wed, 13 Jul 2011 08:47:33 +0000 (08:47 +0000)]
[chromium] Add two chromium gpu linux baselines.

* platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-gpu-linux/platform/chromium/compositing/tiny-layer-rotated-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Assorted chromium gpu rebaselines and expectation cleanups.
jamesr@google.com [Wed, 13 Jul 2011 08:06:00 +0000 (08:06 +0000)]
[chromium] Assorted chromium gpu rebaselines and expectation cleanups.

* platform/chromium-gpu-linux/compositing/geometry/ancestor-overflow-change-expected.png: Added.
* platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png: Added.
* platform/chromium-gpu-linux/fast/canvas/arc360-expected.png:
* platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png:
* platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png:
* platform/chromium-gpu-linux/fast/canvas/canvas-transforms-during-path-expected.png:
* platform/chromium-gpu-linux/fast/canvas/drawImage-with-globalAlpha-expected.png: Removed.
* platform/chromium-gpu-linux/fast/canvas/fillrect-gradient-zero-stops-expected.png:
* platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-gpu-linux/fast/canvas/image-pattern-rotate-expected.png:
* platform/chromium-gpu-linux/fast/canvas/patternfill-repeat-expected.png:
* platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium-gpu-mac/compositing/geometry/ancestor-overflow-change-expected.png: Added.
* platform/chromium-gpu-mac/compositing/geometry/composited-html-size-expected.png: Added.
* platform/chromium-gpu-mac/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
* platform/chromium-gpu-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
* platform/chromium-gpu-win/compositing/geometry/ancestor-overflow-change-expected.png: Added.
* platform/chromium-gpu-win/compositing/geometry/ancestor-overflow-change-expected.txt: Added.
* platform/chromium-gpu-win/compositing/webgl/webgl-background-color-expected.png: Added.
* platform/chromium-gpu-win/compositing/webgl/webgl-background-color-expected.txt: Added.
* platform/chromium-gpu-win/fast/canvas/arc360-expected.png:
* platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png:
* platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png:
* platform/chromium-gpu-win/fast/canvas/canvas-transforms-during-path-expected.png:
* platform/chromium-gpu-win/fast/canvas/drawImage-with-globalAlpha-expected.png: Removed.
* platform/chromium-gpu-win/fast/canvas/fillrect-gradient-zero-stops-expected.png:
* platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-gpu-win/fast/canvas/image-pattern-rotate-expected.png:
* platform/chromium-gpu-win/fast/canvas/patternfill-repeat-expected.png:
* platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium-linux/fast/canvas/canvas-composite-expected.png:
* platform/chromium-mac/fast/canvas/canvas-composite-expected.png: Added.
* platform/chromium-win/fast/canvas/canvas-composite-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][Mac] Unreviewed gardening.
ossy@webkit.org [Wed, 13 Jul 2011 07:52:49 +0000 (07:52 +0000)]
[Qt][Mac] Unreviewed gardening.

* platform/qt-mac/Skipped: Remove 2 tests, because they are in test_expectations.txt too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] NRWT should pick up the right httpd config file
ossy@webkit.org [Wed, 13 Jul 2011 07:44:59 +0000 (07:44 +0000)]
[Qt] NRWT should pick up the right httpd config file
https://bugs.webkit.org/show_bug.cgi?id=64086

* Scripts/run-webkit-tests: Enable NRWT on qt-mac platform after r90810.
(useNewRunWebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] More edge AA and misc chromium gpu baselines and expectations updates.
jamesr@google.com [Wed, 13 Jul 2011 07:18:31 +0000 (07:18 +0000)]
[chromium] More edge AA and misc chromium gpu baselines and expectations updates.

* platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
* platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transition-expected.png:
* platform/chromium-gpu-linux/compositing/reflections/transform-inside-reflection-expected.png:
* platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-gpu-linux/compositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png:
* platform/chromium-gpu-linux/media/video-transformed-expected.png:
* platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
* platform/chromium-gpu-linux/platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
* platform/chromium-gpu-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
* platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-gpu-mac/compositing/framesets/composited-frame-alignment-expected.png: Added.
* platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png:
* platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-expected.png:
* platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
* platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transition-expected.png:
* platform/chromium-gpu-mac/compositing/reflections/transform-inside-reflection-expected.png:
* platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-gpu-mac/media/video-transformed-expected.png:
* platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
* platform/chromium-gpu-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
* platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
* platform/chromium-gpu-mac/platform/chromium/compositing/tiny-layer-rotated-expected.png: Added.
* platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-gpu-win/compositing/framesets/composited-frame-alignment-expected.png: Added.
* platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
* platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.png:
* platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
* platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.png:
* platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.png:
* platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
* platform/chromium-gpu-win/media/video-transformed-expected.png:
* platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
* platform/chromium-gpu-win/platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
* platform/chromium-gpu-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
* platform/chromium-gpu-win/platform/chromium/compositing/tiny-layer-rotated-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Wed, 13 Jul 2011 07:06:30 +0000 (07:06 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-4.8/Skipped: Skip http/tests/misc/script-async.html until fix.
* platform/qt-mac/Skipped: Skip new failing tests.
* platform/qt/test_expectations.txt: Mark slow tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update expectations+baselines for edge AA changes.
jamesr@google.com [Wed, 13 Jul 2011 06:47:53 +0000 (06:47 +0000)]
[chromium] Update expectations+baselines for edge AA changes.

* platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
* platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
* platform/chromium-gpu-linux/media/video-zoom-expected.png:
* platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium-gpu-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
* platform/chromium-gpu-mac/compositing/direct-image-compositing-expected.png:
* platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
* platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
* platform/chromium-gpu-win/compositing/direct-image-compositing-expected.png:
* platform/chromium-gpu-win/compositing/geometry/fixed-in-composited-expected.png:
* platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
* platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.png:
* platform/chromium-gpu-win/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Added.
* platform/chromium-gpu-win/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Added.
* platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium-gpu-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
* platform/chromium-gpu-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the 32-bit build.
mrowe@apple.com [Wed, 13 Jul 2011 06:03:04 +0000 (06:03 +0000)]
Fix the 32-bit build.

* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:totalSpaceNeeded:]):
Cast the NSUInteger value to unsigned long to match the format specifier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Refactoring][ShadowContentElement] Forwarded node list should be a linked-list.
morrita@google.com [Wed, 13 Jul 2011 05:43:08 +0000 (05:43 +0000)]
[Refactoring][ShadowContentElement] Forwarded node list should be a linked-list.
https://bugs.webkit.org/show_bug.cgi?id=64252

Reviewed by Dimitri Glazkov.

Introduced ShadowInclusionList and ShadowInclusion for maintaining
forwarded content children. ShadowInclusion is doubly-linked list.
ShadowContentElement::m_inclusions is replaced by ShadowInclusionList.

This change is a prepration for bug 64251, which will introduce
forwarded-children to content-element table.

No new tests. No behavioral change.

* dom/NodeRenderingContext.cpp:
(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
* dom/ShadowContentElement.cpp:
(WebCore::ShadowInclusion::append):
(WebCore::ShadowInclusion::unlink):
(WebCore::ShadowInclusionList::ShadowInclusionList):
(WebCore::ShadowInclusionList::~ShadowInclusionList):
(WebCore::ShadowInclusionList::find):
(WebCore::ShadowInclusionList::clear):
(WebCore::ShadowInclusionList::append):
(WebCore::ShadowContentElement::attach):
* dom/ShadowContentElement.h:
(WebCore::ShadowInclusion::includer):
(WebCore::ShadowInclusion::content):
(WebCore::ShadowInclusion::next):
(WebCore::ShadowInclusion::previous):
(WebCore::ShadowInclusion::ShadowInclusion):
(WebCore::ShadowInclusion::create):
(WebCore::ShadowInclusionList::first):
(WebCore::ShadowInclusionList::last):
(WebCore::ShadowInclusionList::isEmpty):
(WebCore::ShadowInclusionList::append):
(WebCore::ShadowContentElement::inclusions):
* dom/ShadowContentSelector.cpp:
(WebCore::ShadowContentSelector::selectInclusion):
* dom/ShadowContentSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Use nearest filter method with pixel aligned transforms.
commit-queue@webkit.org [Wed, 13 Jul 2011 05:35:15 +0000 (05:35 +0000)]
[Chromium] Use nearest filter method with pixel aligned transforms.
https://bugs.webkit.org/show_bug.cgi?id=64338

Patch by David Reveman <reveman@chromium.org> on 2011-07-12
Reviewed by James Robinson.

Source/WebCore:

Check for integer translation and use nearest texture filter when
possible to avoid filter precisions problems at the layer edges.

Test: compositing/iframes/nested-iframe-scrolling.html (existing)

* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::drawTiles):
* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::isIntegerTranslation):
* platform/graphics/transforms/TransformationMatrix.h:

LayoutTests:

Update expected results.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemoved unnecessary function parameters from TilingData::textureOffset.
commit-queue@webkit.org [Wed, 13 Jul 2011 05:12:57 +0000 (05:12 +0000)]
Removed unnecessary function parameters from TilingData::textureOffset.
https://bugs.webkit.org/show_bug.cgi?id=64245

Patch by David Reveman <reveman@chromium.org> on 2011-07-12
Reviewed by Brent Fulgham.

No new tests, no functionality changes.

* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::drawTiles):
* platform/graphics/gpu/TilingData.cpp:
(WebCore::TilingData::textureOffset):
* platform/graphics/gpu/TilingData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove RenderTextControl::indexForVisiblePosition to HTMLTextFormControlElement
rniwa@webkit.org [Wed, 13 Jul 2011 04:23:03 +0000 (04:23 +0000)]
Move RenderTextControl::indexForVisiblePosition to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=64403

Reviewed by Hajime Morita.

Moved indexForVisiblePosition from RenderTextControl to HTMLTextFormControlElement.

Also replaced the call to RenderTextControl::isSelectableElement by a call to enclosingTextFormControl
(moved from htmlediting to HTMLTextFormControlElement) because we are only interested in checking
whether the given position is inside the current text form control or not.

In addition, modernized the code in indexForVisiblePosition by calling parentAnchoredEquivalent on the
given position and replacing calls to deprecateNode and deprecatedEditingOffset by calls to containerNode
and offsetInContainer.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::indexForVisiblePosition): Calls indexForVisiblePosition.
* editing/htmlediting.cpp: Removed enclosingTextFromControl.
* editing/htmlediting.h: Removed enclosingTextFromControl.
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::indexForVisiblePosition): Moved from RenderTextControl.
(WebCore::HTMLTextFormControlElement::computeSelectionStart): Calls indexForVisiblePosition.
(WebCore::HTMLTextFormControlElement::computeSelectionEnd): Calls indexForVisiblePosition.
(WebCore::enclosingTextFormControl): Moved from htmlediting.cpp
* html/HTMLTextFormControlElement.h:
* rendering/RenderTextControl.cpp:
* rendering/RenderTextControl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImprove garden-o-matic UI when the bots fail to report revision numbers
abarth@webkit.org [Wed, 13 Jul 2011 04:05:51 +0000 (04:05 +0000)]
Improve garden-o-matic UI when the bots fail to report revision numbers
https://bugs.webkit.org/show_bug.cgi?id=64427

Reviewed by Dimitri Glazkov.

At least Win (dbg)(2) seems to fail to report the SVN revision number
in full_results.json.  This patch makes garden-o-matic more robust to
missing revision numbers.

* Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Skipping a few tests which fail due to differing output in recent Applica...
joepeck@webkit.org [Wed, 13 Jul 2011 03:52:07 +0000 (03:52 +0000)]
Unreviewed. Skipping a few tests which fail due to differing output in recent ApplicationCache quota tests.

Reenabling the tests is tracked by <http://webkit.org/b/64410>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake RenderObject::containingBlock virtual for better speed and clarity
jchaffraix@webkit.org [Wed, 13 Jul 2011 03:30:36 +0000 (03:30 +0000)]
Make RenderObject::containingBlock virtual for better speed and clarity
https://bugs.webkit.org/show_bug.cgi?id=64318

Reviewed by Darin Adler.

No new tests, performance refactoring.

On some of my test cases, this method takes between 3 and 5% of the time spend.
The method makes 2 calls to virtual methods which could be moved to their overriden
version of containingBlock if we made it virtual.

That's what this patch does. It saves between 1 and 2% on some synthetic test cases
as well as made the current method shorter.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock): Removed code for RenderView and RenderTableCell,
replaced by ASSERTs.

* rendering/RenderObject.h: Made containingBlock virtual.

* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::containingBlock):
* rendering/RenderView.h:
(WebCore::RenderView::containingBlock):
The code moved from RenderObject is inlined in those 2 methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdjust garden-o-matic layout to use fewer lines
abarth@webkit.org [Wed, 13 Jul 2011 02:41:21 +0000 (02:41 +0000)]
Adjust garden-o-matic layout to use fewer lines
https://bugs.webkit.org/show_bug.cgi?id=64422

Reviewed by Ojan Vafai.

This patch effectively merges the test name line with the list of
builders on which the test fails.  Each test failure now occupies two
lines instead of three.

* Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic should label tests failures of new tests as such
abarth@webkit.org [Wed, 13 Jul 2011 02:39:16 +0000 (02:39 +0000)]
garden-o-matic should label tests failures of new tests as such
https://bugs.webkit.org/show_bug.cgi?id=64421

Reviewed by Ojan Vafai.

Also, we shouldn't dim failures of new tests, even if we've only seen
them once because they're likely to be real problems that need
attention.

* Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js: Added.
* Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js: Added.
* Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
* Scripts/webkitpy/tool/servers/gardeningserver.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic should display how many times we've seen a failure
abarth@webkit.org [Wed, 13 Jul 2011 02:34:54 +0000 (02:34 +0000)]
garden-o-matic should display how many times we've seen a failure
https://bugs.webkit.org/show_bug.cgi?id=64417

Reviewed by Ojan Vafai.

This patch adds some UI to display how many times we've seen a given
failure, which can be helpful for determining whether that failure is a
real failure or a flaky test.

When a failure has only been seen once (i.e., only a single run on a
single bot), we set the opacity of to 50% to avoid distracting the
gardener.

This patch also refactors the failure walker to have a simpler API
internally by moving from an object-oriented paradigm to a functional
paradigm.

* Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded the ability to dynamically change the parent context of a WebGraphicsContext3D.
commit-queue@webkit.org [Wed, 13 Jul 2011 02:28:17 +0000 (02:28 +0000)]
Added the ability to dynamically change the parent context of a WebGraphicsContext3D.
GraphicsContext3DInternal::platformTexture uses this to set the parent as appropriate.
https://bugs.webkit.org/show_bug.cgi?id=64397

Patch by Al Patrick <apatrick@chromium.org> on 2011-07-12
Reviewed by Kenneth Russell.

* public/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::setParentContext):
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DInternal::platformTexture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG JIT does not implement op_construct.
commit-queue@webkit.org [Wed, 13 Jul 2011 01:46:09 +0000 (01:46 +0000)]
DFG JIT does not implement op_construct.
https://bugs.webkit.org/show_bug.cgi?id=64066

Source/JavaScriptCore:

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-12
Reviewed by Gavin Barraclough.

This is a fixed implementation of op_construct.  Constructor calls are implemented
by reusing almost all of the code for Call, with care taken to make sure that
where the are differences (like selecting different code blocks), those differences
are respected.  The two fixes over the last patch are: (1) make sure the
CodeBlock::unlinkCalls respects differences between Call and Construct, and (2)
make sure that virtualFor() in DFGOperations respects the CodeSpecializationKind
(either CodeForCall or CodeForConstruct) when invoking the compiler.

* dfg/DFGAliasTracker.h:
(JSC::DFG::AliasTracker::recordConstruct):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgLinkFor):
* dfg/DFGRepatch.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/CodeBlock.cpp:
(JSC::CodeBlock::unlinkCalls):

LayoutTests:

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-12
Reviewed by Gavin Barraclough.

Added a test for the DFG op_construct regression, where polymorphic constructor
calls will result in the code being compiled for call but then invoked as a
constructor.  This test will fail if that part of the patch is omitted.

* fast/js/polymorphic-construct-expected.txt: Added.
* fast/js/polymorphic-construct.html: Added.
* fast/js/script-tests/polymorphic-construct.js: Added.
(Foo):
():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable Web Audio for chromium DRT
crogers@google.com [Wed, 13 Jul 2011 01:33:50 +0000 (01:33 +0000)]
Enable Web Audio for chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=64409

Reviewed by James Robinson.

Tools:

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

LayoutTests:

* platform/chromium/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOverzealous type validation in method_check
oliver@apple.com [Wed, 13 Jul 2011 00:53:17 +0000 (00:53 +0000)]
Overzealous type validation in method_check
https://bugs.webkit.org/show_bug.cgi?id=64415

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/LayoutTests:

Make sure we don't trip any assertions when caching access
to an InternalFunction

* fast/js/script-tests/method-check.js:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

method_check is essentially just a value look up
optimisation, but it internally stores the value
as a JSFunction, even though it never relies on
this fact.  Under GC validation however we end up
trying to enforce that assumption.  The fix is
simply to store the value as a correct supertype.

* bytecode/CodeBlock.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchGetMethodFast):
(JSC::DFG::tryCacheGetMethod):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Chromium win build fix.
jamesr@google.com [Wed, 13 Jul 2011 00:52:11 +0000 (00:52 +0000)]
[chromium] Chromium win build fix.

* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::drawGlyphsWin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGet webkit to compile with USE(CFNETWORK) enabled on Mac
psolanki@apple.com [Wed, 13 Jul 2011 00:24:03 +0000 (00:24 +0000)]
Get webkit to compile with USE(CFNETWORK) enabled on Mac
https://bugs.webkit.org/show_bug.cgi?id=63674

Reviewed by David Kilzer.

Changes to ResourceHandle class to get it to compile with USE(CFNETWORK).

No new tests because no change in functionality and option is not enabled on Mac.

* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleInternal.h:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::didReceiveResponse):
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandle::start):
(WebCore::WebCoreSynchronousLoaderClient::willSendRequest): Call adjustMIMETypeIfNecessary
on Mac. Also port over fix for <rdar://problem/6901522> added in r43993 which forces the
MIME type to text/html if the request is annotated with a "ForceHTMLMIMEType" property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Delete the unused legacy accelerated canvas 2d code
jamesr@google.com [Wed, 13 Jul 2011 00:20:04 +0000 (00:20 +0000)]
[chromium] Delete the unused legacy accelerated canvas 2d code
https://bugs.webkit.org/show_bug.cgi?id=64214

Reviewed by Stephen White.

Source/WebCore:

This removes the legacy accelerated canvas 2d path and support logic since we (chromium) are no longer using
this codepath and it seems clear that no other port is interested.

Refactoring and removing unused code, so no new tests.

* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
(WebCore::CanvasRenderingContext2D::didDraw):
* html/canvas/CanvasRenderingContext2D.h:
* loader/EmptyClients.h:
* page/ChromeClient.h:
* page/Page.cpp:
(WebCore::Page::sharedGraphicsContext3D):
* page/Page.h:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setSharedGraphicsContext3D):
(WebCore::GraphicsContext::syncSoftwareCanvas):
* platform/graphics/GraphicsContext.h:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::setGrContext):
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/chromium/cc/CCLayerSorter.cpp:
(WebCore::pointInTriangle):
* platform/graphics/gpu/BicubicShader.cpp: Removed.
* platform/graphics/gpu/BicubicShader.h: Removed.
* platform/graphics/gpu/ConvolutionShader.cpp: Removed.
* platform/graphics/gpu/ConvolutionShader.h: Removed.
* platform/graphics/gpu/GraphicsContextGPU.cpp: Removed.
* platform/graphics/gpu/GraphicsContextGPU.h: Removed.
* platform/graphics/gpu/SharedGraphicsContext3D.cpp: Removed.
* platform/graphics/gpu/SharedGraphicsContext3D.h: Removed.
* platform/graphics/gpu/SolidFillShader.cpp: Removed.
* platform/graphics/gpu/SolidFillShader.h: Removed.
* platform/graphics/gpu/TexShader.cpp: Removed.
* platform/graphics/gpu/TexShader.h: Removed.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawLineForTextChecking):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::setAlpha):
(WebCore::GraphicsContext::setPlatformCompositeOperation):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::setSharedGraphicsContext3D):
(WebCore::GraphicsContext::syncSoftwareCanvas):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):
* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::~NativeImageSkia):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::~PlatformContextSkia):
(WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
(WebCore::PlatformContextSkia::makeGrContextCurrent):
* platform/graphics/skia/PlatformContextSkia.h:

Source/WebKit/chromium:

Adds a way to stash a GrContext* on a GraphicsContext3D. Previously, this was handled by
SharedGraphicsContext3D, but we don't need that class any more.  This is used only for the shared
GraphicsContext3D stashed on the Page and shared by all accelerated canvases within the Page, for WebGL and
compositor contexts the GrContext is never set.

* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::grContext):
(WebCore::GraphicsContext3D::grContext):
* src/GraphicsContext3DInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTweak some UI in garden-o-matic now that the tree actually has a
abarth@webkit.org [Wed, 13 Jul 2011 00:13:37 +0000 (00:13 +0000)]
Tweak some UI in garden-o-matic now that the tree actually has a
failure and I can see what this all looks like.

* Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Skipping a few tests which fail due to differing output
joepeck@webkit.org [Wed, 13 Jul 2011 00:05:52 +0000 (00:05 +0000)]
Unreviewed. Skipping a few tests which fail due to differing output
in recent ApplicationCache quota tests.

Reenabling the tests is tracked by <http://webkit.org/b/64410>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSwitch InlineFlowBox to to new layout types
eae@chromium.org [Wed, 13 Jul 2011 00:04:01 +0000 (00:04 +0000)]
Switch InlineFlowBox to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=64399

Reviewed by Eric Seidel.

First step in moving floats over to the new layout abstraction.

No new tests, no new functionality.

* rendering/InlineBox.cpp:
(WebCore::InlineBox::logicalHeight):
* rendering/InlineBox.h:
(WebCore::InlineBox::logicalTop):
(WebCore::InlineBox::logicalBottom):
(WebCore::InlineBox::setLogicalTop):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::addReplacedChildOverflow):
(WebCore::InlineFlowBox::constrainToLineTopAndBottomIfNeeded):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):
* rendering/InlineFlowBox.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::logicalRightSelectionGap):
* rendering/RenderBlock.h:
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::lineSelectionGap):
(WebCore::RootInlineBox::ascentAndDescentForBox):
(WebCore::RootInlineBox::verticalPositionForBox):
* rendering/RootInlineBox.h:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getShadowExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::getTextShadowExtent):
(WebCore::InheritedFlags::getTextShadowHorizontalExtent):
(WebCore::InheritedFlags::getTextShadowVerticalExtent):
(WebCore::InheritedFlags::getTextShadowInlineDirectionExtent):
(WebCore::InheritedFlags::getTextShadowBlockDirectionExtent):
(WebCore::InheritedFlags::getBoxShadowExtent):
(WebCore::InheritedFlags::getBoxShadowHorizontalExtent):
(WebCore::InheritedFlags::getBoxShadowVerticalExtent):
(WebCore::InheritedFlags::getBoxShadowInlineDirectionExtent):
(WebCore::InheritedFlags::getBoxShadowBlockDirectionExtent):
(WebCore::InheritedFlags::getShadowInlineDirectionExtent):
(WebCore::InheritedFlags::getShadowBlockDirectionExtent):
* rendering/style/ShadowData.cpp:
(WebCore::calculateShadowExtent):
(WebCore::ShadowData::adjustRectForShadow):
* rendering/style/ShadowData.h:
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::x):
(WebCore::ShadowData::y):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] SVG text is not rendered sometimes with geometricPrecision
bashi@chromium.org [Tue, 12 Jul 2011 23:37:58 +0000 (23:37 +0000)]
[Chromium] SVG text is not rendered sometimes with geometricPrecision
https://bugs.webkit.org/show_bug.cgi?id=64341

Source/WebCore:

Changing the type of x and y offsets of ComplexTextControllerLinux to make it possible to treat negative offsets.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-07-12
Reviewed by Tony Chang.

Test: platform/chromium-linux/svg/text/text-with-geometric-precision.svg

* platform/graphics/chromium/ComplexTextControllerLinux.cpp: Changed the type of m_offsetX and m_startingY from unsigned to int.
(WebCore::ComplexTextController::ComplexTextController): Changed the type of the argument.
(WebCore::ComplexTextController::reset): Ditto.
* platform/graphics/chromium/ComplexTextControllerLinux.h:

LayoutTests:

Add a test for the regression that the text is not rendered with geometricPrecision.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-07-12
Reviewed by Tony Chang.

* platform/chromium-linux/svg/text/text-with-geometric-precision-expected.png: Added.
* platform/chromium-linux/svg/text/text-with-geometric-precision-expected.txt: Added.
* platform/chromium-linux/svg/text/text-with-geometric-precision.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic should display regression ranges
abarth@webkit.org [Tue, 12 Jul 2011 23:31:05 +0000 (23:31 +0000)]
garden-o-matic should display regression ranges
https://bugs.webkit.org/show_bug.cgi?id=64407

Reviewed by Dimitri Glazkov.

This patch computes a regression range for a failure by intersecting
the regression ranges seen by the various bots.  We make the underlying
assumption that a test is only failing due to one revision at any given
moment.  If that's not true, this code probably explodes.

The regression ranges appear asynchronously, which might be a jarring
UI.  We'll have to experiment to see.

* Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCOLLECT_ON_EVERY_ALLOCATION no longer works.
commit-queue@webkit.org [Tue, 12 Jul 2011 22:35:39 +0000 (22:35 +0000)]
COLLECT_ON_EVERY_ALLOCATION no longer works.
https://bugs.webkit.org/show_bug.cgi?id=64388

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-12
Reviewed by Oliver Hunt.

Added a flag to Heap that determines if it's safe to collect (which for now means that
JSGlobalObject has actually been initialized, but it should work for other things, too).
This allows JSGlobalObject to allocate even if the allocator wants to GC; instead of
GCing it just grows the heap, if necessary.

Then changed Heap::allocate() to not recurse ad infinitum when
COLLECT_ON_EVERY_ALLOCATION is set.  This also makes the allocator generally more
resilient against bugs; this change allowed me to put in handy assertions, such as that
an allocation must succeed after either a collection or after a new block was added.

* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::tryAllocate):
(JSC::Heap::allocate):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::collect):
* heap/Heap.h:
(JSC::Heap::notifyIsSafeToCollect):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocr-linux-ews should run pixel tests
abarth@webkit.org [Tue, 12 Jul 2011 22:35:28 +0000 (22:35 +0000)]
cr-linux-ews should run pixel tests
https://bugs.webkit.org/show_bug.cgi?id=64394

Reviewed by Ojan Vafai.

This patch enabled pixel test on the cr-linux-ews.  Running a quick
test on the bots, it looks like we have five pixel failures, related to
some missing fonts.  I've also made the bots skip failing tests to
avoid uploading huge zip files to bugs.webkit.org (with all the exected
IMAGE failures).

* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/common/config/ports_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPatch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-12
commit-queue@webkit.org [Tue, 12 Jul 2011 22:34:04 +0000 (22:34 +0000)]
Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-12
Reviewed by David Hyatt.

[CSS Exclusions] Parse wrap-shape property
https://bugs.webkit.org/show_bug.cgi?id=61726

Source/WebCore:

Parsing wrap-shape: rect, circle, ellipse and polygon.
Moved WindRule from Path.h to it's own file.

Test: fast/exclusions/parsing-wrap-shape.html

* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseWrapShapeRect):
(WebCore::CSSParser::parseWrapShapeCircle):
(WebCore::CSSParser::parseWrapShapeEllipse):
(WebCore::CSSParser::parseWrapShapePolygon):
(WebCore::CSSParser::parseWrapShape):
* css/CSSParser.h:
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::cssText):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::getShapeValue):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSValueKeywords.in:
* css/CSSWrapShapes.cpp: Added.
(WebCore::CSSWrapShapeRect::cssText):
(WebCore::CSSWrapShapeCircle::cssText):
(WebCore::CSSWrapShapeEllipse::cssText):
(WebCore::CSSWrapShapePolygon::cssText):
* css/CSSWrapShapes.h: Added.
(WebCore::CSSWrapShape::~CSSWrapShape):
(WebCore::CSSWrapShape::CSSWrapShape):
(WebCore::CSSWrapShapeRect::create):
(WebCore::CSSWrapShapeRect::left):
(WebCore::CSSWrapShapeRect::top):
(WebCore::CSSWrapShapeRect::width):
(WebCore::CSSWrapShapeRect::height):
(WebCore::CSSWrapShapeRect::radiusX):
(WebCore::CSSWrapShapeRect::radiusY):
(WebCore::CSSWrapShapeRect::setLeft):
(WebCore::CSSWrapShapeRect::setTop):
(WebCore::CSSWrapShapeRect::setWidth):
(WebCore::CSSWrapShapeRect::setHeight):
(WebCore::CSSWrapShapeRect::setRadiusX):
(WebCore::CSSWrapShapeRect::setRadiusY):
(WebCore::CSSWrapShapeRect::type):
(WebCore::CSSWrapShapeRect::CSSWrapShapeRect):
(WebCore::CSSWrapShapeCircle::create):
(WebCore::CSSWrapShapeCircle::left):
(WebCore::CSSWrapShapeCircle::top):
(WebCore::CSSWrapShapeCircle::radius):
(WebCore::CSSWrapShapeCircle::setLeft):
(WebCore::CSSWrapShapeCircle::setTop):
(WebCore::CSSWrapShapeCircle::setRadius):
(WebCore::CSSWrapShapeCircle::type):
(WebCore::CSSWrapShapeCircle::CSSWrapShapeCircle):
(WebCore::CSSWrapShapeEllipse::create):
(WebCore::CSSWrapShapeEllipse::left):
(WebCore::CSSWrapShapeEllipse::top):
(WebCore::CSSWrapShapeEllipse::radiusX):
(WebCore::CSSWrapShapeEllipse::radiusY):
(WebCore::CSSWrapShapeEllipse::setLeft):
(WebCore::CSSWrapShapeEllipse::setTop):
(WebCore::CSSWrapShapeEllipse::setRadiusX):
(WebCore::CSSWrapShapeEllipse::setRadiusY):
(WebCore::CSSWrapShapeEllipse::type):
(WebCore::CSSWrapShapeEllipse::CSSWrapShapeEllipse):
(WebCore::CSSWrapShapePolygon::create):
(WebCore::CSSWrapShapePolygon::appendPoint):
(WebCore::CSSWrapShapePolygon::getXAt):
(WebCore::CSSWrapShapePolygon::getYAt):
(WebCore::CSSWrapShapePolygon::setWindRule):
(WebCore::CSSWrapShapePolygon::windRule):
(WebCore::CSSWrapShapePolygon::type):
(WebCore::CSSWrapShapePolygon::CSSWrapShapePolygon):
* css/SVGCSSValueKeywords.in:
* platform/graphics/Path.h:
* platform/graphics/WindRule.h: Added.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setWrapShape):
(WebCore::InheritedFlags::wrapShape):
(WebCore::InheritedFlags::initialWrapShape):
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

* fast/exclusions/parsing-wrap-shape-expected.txt: Added.
* fast/exclusions/parsing-wrap-shape.html: Added.
* fast/exclusions/script-tests/parsing-wrap-shape.js: Added.
(testCSSText):
(testComputedStyle):
(testNotInherited):
(test):
(negative_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-07-12 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 12 Jul 2011 22:21:29 +0000 (22:21 +0000)]
2011-07-12  Simon Fraser  <simon.fraser@apple.com>

        Clean up some RenderLayerCompositor code relating to scroll and root layers
        https://bugs.webkit.org/show_bug.cgi?id=64400

        Reviewed by James Robinson.

        There was no need for FrameView::syncCompositingStateForThisFrame()
        to call syncCompositingStateForThisLayerOnly() on the various
        scrollbar-related layers, because the subsequent call to
        compositor()->flushPendingLayerChanges() starts to flush at
        m_overflowControlsHostLayer if one exists, and its an ancestor
        of the scrollbar layers.

        Also clean up terminology in RenderLayerCompositor.
            m_rootPlatformLayer -> m_rootContentLayer
            rootPlatformLayer() -> rootGraphicsLayer()

        No behavior change, so no new tests.

        * page/FrameView.cpp:
        (WebCore::FrameView::syncCompositingStateForThisFrame):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::enableCompositingMode):
        (WebCore::RenderLayerCompositor::flushPendingLayerChanges):
        (WebCore::RenderLayerCompositor::updateCompositingLayers):
        (WebCore::RenderLayerCompositor::layerTreeAsText):
        (WebCore::RenderLayerCompositor::parentFrameContentLayers):
        (WebCore::RenderLayerCompositor::rootGraphicsLayer):
        (WebCore::RenderLayerCompositor::didMoveOnscreen):
        (WebCore::RenderLayerCompositor::willMoveOffscreen):
        (WebCore::RenderLayerCompositor::updateRootLayerPosition):
        (WebCore::RenderLayerCompositor::ensureRootLayer):
        (WebCore::RenderLayerCompositor::destroyRootLayer):
        (WebCore::RenderLayerCompositor::attachRootLayer):
        (WebCore::RenderLayerCompositor::detachRootLayer):
        (WebCore::RenderLayerCompositor::updateRootLayerAttachment):
        * rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r90842.
commit-queue@webkit.org [Tue, 12 Jul 2011 22:17:19 +0000 (22:17 +0000)]
Unreviewed, rolling out r90842.
http://trac.webkit.org/changeset/90842
https://bugs.webkit.org/show_bug.cgi?id=64401

Causes crash in debug on compositing/overflow/content-gains-
scrollbars.html (Requested by jamesr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-12

* WebCore.gypi:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::ContentLayerChromium):
(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::cleanupResources):
(WebCore::ContentLayerChromium::setLayerRenderer):
(WebCore::ContentLayerChromium::tilingTransform):
(WebCore::ContentLayerChromium::contentBounds):
(WebCore::ContentLayerChromium::updateLayerSize):
(WebCore::ContentLayerChromium::draw):
(WebCore::ContentLayerChromium::drawsContent):
(WebCore::ContentLayerChromium::createTilerIfNeeded):
(WebCore::ContentLayerChromium::updateCompositorResources):
(WebCore::ContentLayerChromium::setTilingOption):
(WebCore::ContentLayerChromium::bindContentsTexture):
(WebCore::ContentLayerChromium::setIsMask):
(WebCore::writeIndent):
(WebCore::ContentLayerChromium::dumpLayerProperties):
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::ImageLayerChromium):
(WebCore::ImageLayerChromium::paintContentsIfDirty):
(WebCore::ImageLayerChromium::updateCompositorResources):
(WebCore::ImageLayerChromium::contentBounds):
* platform/graphics/chromium/ImageLayerChromium.h:
(WebCore::ImageLayerChromium::drawsContent):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::ccLayerImpl):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::draw):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawRootLayer):
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::updateRect):
(WebCore::LayerTilerChromium::draw):
(WebCore::LayerTilerChromium::drawTiles):
* platform/graphics/chromium/LayerTilerChromium.h:
* platform/graphics/chromium/TiledLayerChromium.cpp: Removed.
* platform/graphics/chromium/TiledLayerChromium.h: Removed.
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::drawsContent):
(WebCore::CCLayerImpl::draw):
* platform/graphics/chromium/cc/CCLayerImpl.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp: Removed.
* platform/graphics/chromium/cc/CCTiledLayerImpl.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoApplicationCache update should not immediately fail when reaching per-origin quota
joepeck@webkit.org [Tue, 12 Jul 2011 22:00:45 +0000 (22:00 +0000)]
ApplicationCache update should not immediately fail when reaching per-origin quota
https://bugs.webkit.org/show_bug.cgi?id=64177

Reviewed by Alexey Proskuryakov.

2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>

        Include spaceNeeded information in the output dumped for appcache quota delegates.
        Add and update tests related to handling of per-origin quotas.

        * http/tests/appcache/origin-quota-continued-download-expected.txt: Added.
        * http/tests/appcache/origin-quota-continued-download.html: Added.
        * http/tests/appcache/resources/quota-origin-continued-download.html: Added.
        * http/tests/appcache/resources/quota-origin-continued-download.manifest: Added.
        New test which checks that there will still be a successful cache
        when the per-origin quota is reached and increased at the end of downloading.

        * http/tests/appcache/origin-quota-continued-download-multiple-manifests-expected.txt: Added.
        * http/tests/appcache/origin-quota-continued-download-multiple-manifests.html: Added.
        * http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-1.html: Added.
        * http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-1.manifest: Added.
        * http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-2.html: Added.
        * http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-2.manifest: Added.
        * http/tests/appcache/resources/quota-origin-continued-download.html: Added.
        * http/tests/appcache/resources/quota-origin-continued-download.manifest: Added.
        New test which checks that the spaceNeeded appropriately lists enough space for
        multiple manifests across multiple frames for the same origin.

        * http/tests/appcache/resources/quota-origin-iframe-3.manifest: Fix a typo.
        * http/tests/appcache/origin-quota.html:
        Update the old test to disallow automatic increase of the quota,
        which is the default handling of DRT when reaching the quota.

        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
        * platform/wk2/Skipped:
        Skip the test on ports that don't implement ApplicationCache per-origin quotas.

2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>

        New behavior of handling ApplicationCache per-origin quotas. Previously,
        if the quota was reached while downloading we would fail the download
        and then prompt the user for a storage increase. This required a refresh,
        a redownload of resources, and the total storage was not known so the
        process could be repeated multiple times before an acceptable quota
        was found or the user disallowed an increase.

        The new behavior is to complete the download of the entire appcache.
        When the cache completes downloading and it is greater than the origin
        quota, prompt the user to allow a quota increase with the known space
        needed. If the quota is increased, the cache will succeed, otherwise
        it will fail with the normal failure steps.

        An alternative behavior is prompting while downloading immediately
        when the origin quota is reached, however at that point the entire
        space needed is unknown and so quota increases might not be enough
        and could result in multiple prompts to the user.

        Tests: http/tests/appcache/origin-quota-continued-download-multiple-manifests.html
               http/tests/appcache/origin-quota-continued-download.html

        * loader/appcache/ApplicationCacheGroup.h:
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::ApplicationCacheGroup):
        Rename instance variable to be more clear on its intent.

        (WebCore::ApplicationCacheGroup::didFinishLoading):
        Check the quota limit while downloading so we can fail early
        if the user already denied a quota increase.

        (WebCore::ApplicationCacheGroup::didReachOriginQuota):
        Pass the space needed information to the chrome client.

        (WebCore::ApplicationCacheGroup::cacheUpdateFailedDueToOriginQuota):
        Removed. Instead convert the callers to update state and console
        log when the per-origin quota is reached. This allows us to follow
        the normal failure steps if the quota is reached at the end of a
        download, and the alternative short path when we fail during downloading.

        (WebCore::ApplicationCacheGroup::recalculateAvailableSpaceInQuota):
        Extract to a helper function.

        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
        Allow for a quota increase at the end of the download now that
        we know the space needed. Then proceed to fail or succeed
        as we normally would.

        * loader/appcache/ApplicationCacheStorage.h:
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::checkOriginQuota):
        (WebCore::ApplicationCacheStorage::storeNewestCache):
        Extract checking the origin quota for when an ApplicationCacheGroup
        will be replacing an ApplicationCacheGroup into a helper function.
        The helper also provides an out parameter for the space needed
        to properly fit the new cache group if it wouldn't fit.

        * page/ChromeClient.h:
        * loader/EmptyClients.h:
        (WebCore::EmptyChromeClient::reachedApplicationCacheOriginQuota):
        Add a space needed parameter when reaching the per-origin quota.

2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>

        * WebView/WebUIDelegatePrivate.h:
        * DefaultDelegates/WebDefaultUIDelegate.m:
        (-[WebDefaultUIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:spaceNeeded:]):
        Update the delegate to include a space needed parameter.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::reachedApplicationCacheOriginQuota):
        Call the delegate with the new space needed information.

2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>

        * Api/qwebpage.cpp:
        * Api/qwebpage.h:
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):
        * WebCoreSupport/ChromeClientQt.h:
        Pass the spaceNeeded value through to the applicationCacheQuotaExceeded signal.

2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>

        Add layoutTestController.disallowIncreaseForApplicationCacheQuota()
        to disable the default behavior of raising the default per-origin
        quota to 5MB when reached. This allows us to test what happens
        when the quota is reached and not increased.

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (disallowIncreaseForApplicationCacheQuotaCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        (LayoutTestController::disallowIncreaseForApplicationCacheQuota):
        (LayoutTestController::setDisallowIncreaseForApplicationCacheQuota):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::reset):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        (LayoutTestController::disallowIncreaseForApplicationCacheQuota):
        (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
        Expose a function to prevent automatically increasing the per-origin
        quota when the quota is reached. This allows us to test what happens
        when a user would "disallow" a quota increase.

        * DumpRenderTree/mac/UIDelegate.mm:
        (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:spaceNeeded:]):
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
        Respect the new disallowIncrease flag and dump the spaceNeeded values
        for ports that implement application cache quotas.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDelete some redundant code in WebHTMLView
aroben@apple.com [Tue, 12 Jul 2011 21:56:25 +0000 (21:56 +0000)]
Delete some redundant code in WebHTMLView

This code had no user-visible effect, as we were just duplicating work that AppKit would do
for us at a slightly different time.

Fixes <http://webkit.org/b/64390> WebHTMLView sets its root layer's transform unnecessarily

Reviewed by Simon Fraser.

* WebView/WebHTMLView.mm:
(-[WebHTMLView viewDidMoveToWindow]):
(-[WebHTMLView attachRootLayer:]):
Don't bother setting the root layer's transform to account for the scale factor. AppKit
takes care of this for us nowadays.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG JIT put_by_id transition caching does not inform the GC about the structure and
commit-queue@webkit.org [Tue, 12 Jul 2011 21:51:52 +0000 (21:51 +0000)]
DFG JIT put_by_id transition caching does not inform the GC about the structure and
prototype chain that it is referencing.
https://bugs.webkit.org/show_bug.cgi?id=64387

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-12
Reviewed by Gavin Barraclough.

Fixed the relevant code in DFGRepatch to call StructureStubInfo::initPutByIdTransition().

* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCachePutByID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAudioDevice::Stop can close NULL handle.
crogers@google.com [Tue, 12 Jul 2011 21:46:35 +0000 (21:46 +0000)]
AudioDevice::Stop can close NULL handle.
https://bugs.webkit.org/show_bug.cgi?id=64157

Reviewed by Kenneth Russell.

No new tests since audio API is not yet implemented.

* bindings/js/JSAudioContextCustom.cpp:
(WebCore::JSAudioContextConstructor::constructJSAudioContext):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback):
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::create):
(WebCore::AudioContext::uninitialize):
* webaudio/AudioContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofix flakiness dashboard to work with new crash log filenames
ojan@chromium.org [Tue, 12 Jul 2011 21:38:21 +0000 (21:38 +0000)]
fix flakiness dashboard to work with new crash log filenames
https://bugs.webkit.org/show_bug.cgi?id=64393

Reviewed by Adam Barth.

* TestResultServer/static-dashboards/flakiness_dashboard.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFull-screen: Don't change the collectionBehavior of the WebView's NSWindow if not...
jer.noble@apple.com [Tue, 12 Jul 2011 21:38:05 +0000 (21:38 +0000)]
Full-screen: Don't change the collectionBehavior of the WebView's NSWindow if not necessary
https://bugs.webkit.org/show_bug.cgi?id=63217
<rdar://problem/9660291>

Reviewed by Darin Adler.

Check to see if the NSWindow hosting the WebView is not on the active space before changing the window's
collectionBehavior.

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController beganExitFullScreenAnimation]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove call to syncCompositingLayers so that we do not trigger redundant draws.
commit-queue@webkit.org [Tue, 12 Jul 2011 21:22:45 +0000 (21:22 +0000)]
Move call to syncCompositingLayers so that we do not trigger redundant draws.
https://bugs.webkit.org/show_bug.cgi?id=64224

Source/WebCore:

doComposite was triggering two composites every time a canvas was dirtied.
By moving syncCompositingLayers call to layout, the client code can draw without triggering
a redundant frame. Also renamed WebViewImpl::updateLayers to
syncCompositingLayers, because it was confusing. CCLayerTreeHostImplProxy::updateLayers was
no longer needed, because animateAndLayout calls WebViewImpl::layout.

Patch by John Bates <jbates@google.com> on 2011-07-12
Reviewed by James Robinson.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::syncCompositingLayers):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:
(WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommit):

Source/WebKit/chromium:

doComposite was triggering two composites every time a canvas was dirtied.
By moving syncCompositingLayers call to layout, the client code can draw without triggering
a redundant frame. Also renamed WebViewImpl::updateLayers to
syncCompositingLayers, because it was confusing.

Patch by John Bates <jbates@google.com> on 2011-07-12
Reviewed by James Robinson.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::layout):
(WebKit::WebViewImpl::syncCompositingLayers):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIsolate HTMLTextFormControlElement into a separate file
rniwa@webkit.org [Tue, 12 Jul 2011 21:20:35 +0000 (21:20 +0000)]
Isolate HTMLTextFormControlElement into a separate file
https://bugs.webkit.org/show_bug.cgi?id=64381

Reviewed by Dimitri Glazkov.

Extracted HTMLTextFormControlElement.h and HTMLTextFormControlElement.cpp out of
HTMLFormControlElement.h and HTMLFormControlElement.cpp.

Also moved defaultEventHandler from HTMLFormControlElementWithState to HTMLTextFormControlElement
because it was specific to HTMLTextFormControlElement, and replaced all references to
HTMLFormControlElementWithState in HTMLInputElement and HTMLTextAreaElement by ones to
HTMLTextFormControlElement.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* editing/TextIterator.cpp:
* editing/htmlediting.cpp:
* html/HTMLElementsAllInOne.cpp:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::isFocusable):
* html/HTMLFormControlElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isKeyboardFocusable):
(WebCore::HTMLInputElement::isMouseFocusable):
(WebCore::HTMLInputElement::updateFocusAppearance):
(WebCore::HTMLInputElement::canStartSelection):
(WebCore::HTMLInputElement::parseMappedAttribute):
(WebCore::HTMLInputElement::finishParsingChildren):
(WebCore::HTMLInputElement::rendererIsNeeded):
(WebCore::HTMLInputElement::attach):
(WebCore::HTMLInputElement::detach):
(WebCore::HTMLInputElement::copyNonAttributeProperties):
(WebCore::HTMLInputElement::defaultEventHandler):
(WebCore::HTMLInputElement::willMoveToNewOwnerDocument):
(WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
(WebCore::HTMLInputElement::addSubresourceAttributeURLs):
(WebCore::HTMLInputElement::recalcWillValidate):
* html/HTMLInputElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::defaultEventHandler):
* html/HTMLTextAreaElement.h:
* html/HTMLTextFormControlElement.cpp: Copied from Source/WebCore/html/HTMLFormControlElement.cpp.
(WebCore::HTMLTextFormControlElement::defaultEventHandler):
* html/HTMLTextFormControlElement.h: Copied from Source/WebCore/html/HTMLFormControlElement.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r90831.
commit-queue@webkit.org [Tue, 12 Jul 2011 21:08:27 +0000 (21:08 +0000)]
Unreviewed, rolling out r90831.
http://trac.webkit.org/changeset/90831
https://bugs.webkit.org/show_bug.cgi?id=64389

Likely caused fast/canvas/DrawImageSinglePixelStretch.html to
start timing out on the chromium GPU bots (Requested by ojan
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-12

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::putImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a happy animation to garden-o-matic when there are no failures
abarth@webkit.org [Tue, 12 Jul 2011 20:58:03 +0000 (20:58 +0000)]
Add a happy animation to garden-o-matic when there are no failures
https://bugs.webkit.org/show_bug.cgi?id=64382

Reviewed by Ojan Vafai.

As requested by Ojan.

* Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif: Added.
* Scripts/webkitpy/tool/servers/gardeningserver.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Navigation actions in incorrect state when loadStarted() is emitted.
andreas.kling@nokia.com [Tue, 12 Jul 2011 20:25:22 +0000 (20:25 +0000)]
[Qt][WK2] Navigation actions in incorrect state when loadStarted() is emitted.
https://bugs.webkit.org/show_bug.cgi?id=64383

Reviewed by Kenneth Rohde Christiansen.

Update the navigation actions before emitting loadStarted().

* UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:
(LoadStartedCatcher::LoadStartedCatcher):
(LoadStartedCatcher::onLoadStarted):
(tst_QDesktopWebView::stopActionEnabledAfterLoadStarted):
* UIProcess/qt/ClientImpl.cpp:
(qt_wk_didStartProvisionalLoadForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90844 268f45cc-cd09-0410-ab3c-d52691b4dbfc