WebKit-https.git
13 years agoLayoutTests:
justing [Tue, 7 Nov 2006 03:32:31 +0000 (03:32 +0000)]
LayoutTests:

        Reviewed by harrison

        * editing/execCommand/4641880-1-expected.checksum: Added.
        * editing/execCommand/4641880-1-expected.png: Added.
        * editing/execCommand/4641880-1-expected.txt: Added.
        * editing/execCommand/4641880-1.html: Added.
        * editing/execCommand/4641880-2-expected.checksum: Added.
        * editing/execCommand/4641880-2-expected.png: Added.
        * editing/execCommand/4641880-2-expected.txt: Added.
        * editing/execCommand/4641880-2.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/4641880>
        Setting bullets to existing text grabs subsequent paragraph

        When a selection ends at the start of a paragraph, we rarely paint
        the selection gap before that paragraph, because there often is no gap.
        In a case like this, it's not obvious to the user that the selection
        ends "inside" that paragraph, so it would be confusing if
        InsertUn{Ordered}List and Indent/Outdent operated on that paragraph.

        * editing/FormatBlockCommand.cpp:
        (WebCore::FormatBlockCommand::doApply): Moved the check for editability of
        the selection to a more appropriate place.  Change the endingSelection
        if it ends at the start of a paragraph.
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::doApply): Ditto.
        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::doApply): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sarge
beidson [Tue, 7 Nov 2006 03:25:16 +0000 (03:25 +0000)]
    Reviewed by Sarge

        <rdar://problem/4822911> - ASSERTION was a little overzealous.
        Toned it down a bit.

        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::didFinishLoading):  Toned down assertion

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-06 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
bdash [Tue, 7 Nov 2006 01:09:19 +0000 (01:09 +0000)]
2006-11-06  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>

        Reviewed by Maciej.

        Remove warning about garbage after #else. #else clause applies for all
        non-mac platforms, not only win.

        * kjs/date_object.cpp:
2006-11-06  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>

        Reviewed by Maciej.

        Linux\Gdk build fixes.

        * loader/icon/IconDatabase.cpp:
        * loader/icon/SQLStatement.h:
        * platform/gdk/ChromeClientGdk.h: Added.
        (WebCore::ChromeClientGdk::~ChromeClientGdk):
        * platform/gdk/CursorGdk.cpp:
        (WebCore::pointerCursor):
        * platform/gdk/FrameGdk.cpp:
        (WebCore::doScroll):
        (WebCore::FrameGdk::FrameGdk):
        (WebCore::FrameGdk::submitForm):
        (WebCore::FrameGdk::urlSelected):
        (WebCore::FrameGdk::openURL):
        (WebCore::FrameGdk::handleGdkEvent):
        * platform/gdk/FrameGdk.h:
        (WebCore::FrameGdk::client):
        * platform/gdk/RenderPopupMenuGdk.cpp:
        (WebCore::PopupMenu::updateFromElement):
        * platform/gdk/ScreenGdk.cpp:
        * platform/gdk/TemporaryLinkStubs.cpp:
        (Slider::focusPolicy):
        (WebCore::ServeSynchronousRequest):
        (FrameGdk::goBackOrForward):
        (FrameGdk::getHistoryLength):
        (FrameGdk::historyURL):
        (ChromeClientGdk::canRunModal):
        (ChromeClientGdk::runModal):
        (WebCore::systemBeep):
        (WebCore::CachedResource::setPlatformResponse):
        (Path::transform):
        (ResourceLoader::loadsBlocked):
        (IconLoader::notifyIconChanged):
        * platform/network/gdk/ResourceHandleManager.cpp:
        (WebCore::writeCallback):
        (WebCore::ResourceHandleManager::downloadTimerCallback):
        (WebCore::ResourceHandleManager::remove):
        (WebCore::ResourceHandleManager::add):
2006-11-06  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>

        Reviewed by Maciej.

        Linux\gdk build fixes.

        * GdkLauncher/main.cpp:
        (LauncherFrameGdk::LauncherFrameGdk):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago64-bit build fix, take two.
thatcher [Tue, 7 Nov 2006 01:08:37 +0000 (01:08 +0000)]
64-bit build fix, take two.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix for 64-bit.
thatcher [Tue, 7 Nov 2006 01:04:05 +0000 (01:04 +0000)]
Build fix for 64-bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ggaren [Tue, 7 Nov 2006 00:56:34 +0000 (00:56 +0000)]
    Reviewed by Darin.

        Accidentally rolled out this change when removing the WebPageBridge. Now
        putting it back.

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago build fix.
ggaren [Tue, 7 Nov 2006 00:30:15 +0000 (00:30 +0000)]
    build fix.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
ggaren [Mon, 6 Nov 2006 23:56:59 +0000 (23:56 +0000)]
WebCore:

        Reviewed by Maciej, Anders, Darin.

        Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.
        Fixed a minor where WebCore would always assume it was displayed on the
        monitor containing the menubar. window.open and window.showModalDialog
        are now cross-platform.

        Layout tests, manual-tests/show-modal-dialog, and manual-tests/
        window-open-features-parsing all pass. I verified the new screen functionality
        by running in DRT, and checking whether WebCore knew it was off-screen.

        Some refactoring remains, as all were not pleased by this design. I see
        in my future another patch.

        * bindings/js/kjs_window.cpp: Screen is now a stand-alone object with a
        client, to encapsulate asking the platform questions about the screen occupied by
        the page. (Previously, we always assumed we were on screen 0, which was a bug.)
        * bridge/mac/WebCoreFrameBridge.mm:
        (createMouseEventFromDraggingInfo): Reversed argument order, to match other
        functions.
        (-[WebCoreFrameBridge dragSourceMovedTo:]): ditto
        (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): ditto
        * bridge/mac/WebCoreFrameNamespaces.h: Removed. Dead Code.
        * bridge/mac/WebCoreFrameNamespaces.mm: Removed. Dead Code.
        * bridge/mac/WebCorePageBridge.h: Removed. Dead Code.
        * bridge/mac/WebCorePageBridge.mm: Removed. Dead Code.
        * manual-tests/window-open-features-parsing.html: Updated for accuracy.
        (In this case, neither size nor position is specified, so you should
        get the default window size and position.)
        * page/Screen.cpp: Added. Includes screen-related helper functions used
        in WebCore and WebKit.
        * platform/PlatformMouseEvent.h: Exported common code so it doesn't have
        to be duplicated. Renamed "position" to "point" since both were used,
        and "point" seemed clearer.
        * platform/Screen.h: Removed. Dead Code.
        * platform/mac/LoggingMac.mm: Added. Moved code here from WebCorePageBridge
        initialization.

WebKit:

        Reviewed by Maciej, Darin, Anders.

        Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.

        (WebChromeClient::pageRect): It may seem weird for the page to ask the Chrome/ChromeClient
        about its own dimensions. The idea here is that we're asking the Chrome how
        much space it has devoted to the page. We have API for this (-webViewContentRect), but
        it was documented incorrectly (even Safari used it wrong), so we don't use
        it anymore. Once we fix our API/documentation, we can return to making a
        delegate callback to ask for the page's size.
        (WebChromeClient::createWindow): Changed to take a FrameLoadRequest with
        an appropriate referrer, instead of making up its own.
        (WebChromeClient::createModalDialog): Changed to take a FrameLoadRequest with
        an appropriate referrer, instead of broken out parcels.
        * WebCoreSupport/WebPageBridge.h: Removed. Dead Code.
        * WebCoreSupport/WebPageBridge.mm: Removed. Dead Code.
        * WebCoreSupport/WebScreenClient.h: Added.
        * WebCoreSupport/WebScreenClient.mm: Added.
        * WebView/WebView.mm: Added NULL checks for new _private->page, since
        it's not NULL-safe like the bridge was, and it gets cleared before
        dealloc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
gdennis [Mon, 6 Nov 2006 22:44:23 +0000 (22:44 +0000)]
WebCore:

        Reviewed by Tim Hatcher.

        Part of patch for http://bugs.webkit.org/show_bug.cgi?id=11323
        Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref

        No layout tests added as this must be tested manually by the test
        WebCore/manual-tests/contenteditable-link.html

        * WebCore.exp: Exported HitTestResult::isLiveLink().
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::HTMLAnchorElement):
        (WebCore::HTMLAnchorElement::defaultEventHandler):
        (WebCore::HTMLAnchorElement::isLiveLink):
        * html/HTMLAnchorElement.h: added m_wasShiftKeyDownOnMouseDown variable
        to track shift key status.
        * manual-tests/contenteditable-link.html: Added description about link
        dragging behaviour.
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::isLiveLink): Added.
        * rendering/HitTestResult.h:

WebKit:

        Reviewed by Tim Hatcher.

        Part of patch for http://bugs.webkit.org/show_bug.cgi?id=11323
        Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref

        * DefaultDelegates/WebDefaultUIDelegate.m:
        (-[NSApplication webView:dragSourceActionMaskForPoint:]): Logic moved to
        WebHTMLView's _mayStartDragAtEventLocation
        * Misc/WebElementDictionary.m: added isLiveLink
        (+[WebElementDictionary initializeLookupTable]):
        (-[WebElementDictionary _isLiveLink]):
        * WebView/WebHTMLView.m:
        (-[WebHTMLView _mayStartDragAtEventLocation:]): Editable links should
        only be followed if isLiveLink is true
        (-[WebHTMLView _isMoveDrag:]): A drag of a live editable link is not
        a move
        (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]):
        (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
        * WebView/WebView.mm: added WebElementLinkIsLiveKey
        * WebView/WebViewPrivate.h: ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
thatcher [Mon, 6 Nov 2006 21:23:27 +0000 (21:23 +0000)]
    Reviewed by Anders.

        Update the site with new wiki and Trac links.

        * blog/wp-content/themes/webkit/sidebar.php:
        * building/build.html:
        * index.html:
        * nav.inc:
        * projects/svg/index.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver
beidson [Mon, 6 Nov 2006 21:03:30 +0000 (21:03 +0000)]
    Reviewed by Oliver

        Fixes <rdar://problem/4812674> and http://bugs.webkit.org/show_bug.cgi?id=11530
        For now, we have to not load favicons when we have no Document - linking directly
        to PDFs being the common case

        * loader/icon/IconLoader.cpp:
        (WebCore::IconLoader::startLoading): Check for the document and return if none

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-06 Oliver Hunt <oliver@apple.com>
oliver [Mon, 6 Nov 2006 19:27:10 +0000 (19:27 +0000)]
2006-11-06  Oliver Hunt  <oliver@apple.com>

        Reviewed by Mitz.

        * svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
        * svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
        * svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
        * svg/W3C-SVG-1.1/text-intro-01-t.svg-disabled: Removed.
        * svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added.
        * svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
        * svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
        * svg/W3C-SVG-1.1/text-intro-02-b.svg-disabled: Removed.
        * svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
        * svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
        * svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
        * svg/W3C-SVG-1.1/text-intro-03-b.svg-disabled: Removed.
        * svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added.
        * svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
        * svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
        * svg/W3C-SVG-1.1/text-intro-04-t.svg-disabled: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Dave Harrison
beidson [Mon, 6 Nov 2006 19:05:10 +0000 (19:05 +0000)]
    Reviewed by Dave Harrison

        <rdar://problem/4801066>
        Added a critical null frameLoader() check

        * loader/mac/MainResourceLoaderMac.mm:
        (WebCore::MainResourceLoader::loadNow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
harrison [Mon, 6 Nov 2006 18:08:52 +0000 (18:08 +0000)]
LayoutTests:

        Reviewed by Darin.

        <rdar://problem/4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned

        * editing/deleting/delete-br-012-expected.checksum: Added.
        * editing/deleting/delete-br-012-expected.png: Added.
        * editing/deleting/delete-br-012-expected.txt: Added.
        * editing/deleting/delete-br-012.html: Added.

WebCore:

        Reviewed by Darin.

        <rdar://problem/4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned

        Test:
        * editing/deleting/delete-br-012.html

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):
        Update m_endingPosition when preventing merge.
        Also removed setting of m_mergeBlocksAfterDelete when this function returns true, because is is not checked in this case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix, approved in principle by Tim H.
ap [Mon, 6 Nov 2006 17:47:10 +0000 (17:47 +0000)]
    Build fix, approved in principle by Tim H.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        Disable deprecated warnings for main.c (TestNetscapePlugin),
        as it now uses QuickDraw to convert mouse event coordinates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
thatcher [Mon, 6 Nov 2006 17:08:16 +0000 (17:08 +0000)]
    Reviewed by Maciej.

        Bug 11525: [Drosera] function menu doesn't understand object.method = function() {} syntax
        http://bugs.webkit.org/show_bug.cgi?id=11525

        * Drosera/debugger.js: imporved the function name code

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam Weinig.
ap [Mon, 6 Nov 2006 14:19:49 +0000 (14:19 +0000)]
    Reviewed by Sam Weinig.

        Fix a layout test failure that happened with additional fonts installed - replace a fancy
        Unicode character with a plain asterisk.

        * css2.1/t0905-c414-flt-00-d-expected.checksum:
        * css2.1/t0905-c414-flt-00-d-expected.png:
        * css2.1/t0905-c414-flt-00-d-expected.txt:
        * css2.1/t0905-c414-flt-00-d.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
ap [Mon, 6 Nov 2006 13:08:47 +0000 (13:08 +0000)]
    Reviewed by Maciej.

        Make sure that alerts and delegate output made after notifyDone() are ignored, rather than
        being attributed to the next test.

WebKitTools:
        * DumpRenderTree/EditingDelegate.m:
        (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
        (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
        (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
        (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
        (-[EditingDelegate webView:shouldDeleteDOMRange:]):
        (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
        (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
        (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
        (-[EditingDelegate webViewDidBeginEditing:]):
        (-[EditingDelegate webViewDidChange:]):
        (-[EditingDelegate webViewDidEndEditing:]):
        (-[EditingDelegate webViewDidChangeTypingStyle:]):
        (-[EditingDelegate webViewDidChangeSelection:]):
        * DumpRenderTree/UIDelegate.m:
        (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:]):

LayoutTests:
        Removed leftover results from the previous test.

        * editing/selection/drag-to-contenteditable-iframe-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-07 Mark Rowe <bdash@webkit.org>
bdash [Mon, 6 Nov 2006 13:03:25 +0000 (13:03 +0000)]
2006-11-07  Mark Rowe  <bdash@webkit.org>

        http://bugs.webkit.org/show_bug.cgi?id=11526
        Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg

        Correctly updated tests results.

        * fast/dom/HTMLMetaElement/meta-attributes-expected.txt:
        * fast/dom/HTMLMetaElement/meta-attributes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-06 Mark Rowe <bdash@webkit.org>
bdash [Mon, 6 Nov 2006 12:54:30 +0000 (12:54 +0000)]
2006-11-06  Mark Rowe  <bdash@webkit.org>

        Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=11526
        Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg

        Update DOMNode::toString to always use className rather than preferring nodeName.

        * bindings/js/kjs_dom.cpp:
        (KJS::DOMNode::toString): Match the format returned by valueOf.
2006-11-06  Mark Rowe  <bdash@webkit.org>

        Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=11526
        Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg

        Updated test results for change from nodeName to className in DOMNode::toString.

        * fast/dom/HTMLMetaElement/meta-attributes-expected.txt:
        * fast/dom/prototype-chain-expected.txt:
        * fast/dom/replace-first-child-expected.txt:
        * fast/events/mouseclick-target-and-positioning-expected.txt:
        * fast/forms/input-appearance-preventDefault-expected.checksum:
        * fast/forms/input-appearance-preventDefault-expected.png:
        * fast/forms/input-appearance-preventDefault-expected.txt:
        * fast/loader/loadInProgress-expected.txt:
        * fast/tokenizer/external-script-document-write-expected.checksum:
        * fast/tokenizer/external-script-document-write-expected.png:
        * fast/tokenizer/external-script-document-write-expected.txt:
        * traversal/stay-within-root-expected.checksum:
        * traversal/stay-within-root-expected.png:
        * traversal/stay-within-root-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-06 Mark Rowe <bdash@webkit.org>
bdash [Mon, 6 Nov 2006 11:08:35 +0000 (11:08 +0000)]
2006-11-06  Mark Rowe  <bdash@webkit.org>

        Reviewed by Alexey.

        Fix "Undefined subroutine &main::WEXITSTATUS" when build-dumprendertree fails.

        * Scripts/run-webkit-tests: import the POSIX module.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoClean build fix after r17607: removed obselete header include.
bdash [Mon, 6 Nov 2006 10:57:28 +0000 (10:57 +0000)]
Clean build fix after r17607: removed obselete header include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-06 Oliver Hunt <oliver@apple.com>
oliver [Mon, 6 Nov 2006 09:16:32 +0000 (09:16 +0000)]
2006-11-06  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej.

        Fix RTL text in SVG to have correct positioning

        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::placeBoxesHorizontally):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
ap [Mon, 6 Nov 2006 08:43:00 +0000 (08:43 +0000)]
    Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=11517
        REGRESSION: Flash clicks/interactivity not working properly

WebCore:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::handleMouseMoveEvent):
        (WebCore::FrameMac::handleMouseReleaseEvent):
        Restore parts of event dispatching that were removed when fixing
        bug 7323 - just bypass those for subframes.

WebKitTools:
        Teach TestNetscapePlugin to log events passed to it. To enable, set eventLoggingEnabled to true:

        <embed name="plg" type="application/x-webkit-test-netscape" width=100 height=100></embed>
        <script>
            plg.eventLoggingEnabled = true;
            // use eventSender to simulate events...
        </script>

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
        (pluginGetProperty):
        (pluginSetProperty):
        (pluginAllocate):
        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
        * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
        (NPP_HandleEvent):

LayoutTests:
        * plugins/mouse-events-expected.txt: Added.
        * plugins/mouse-events.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-06 Mark Rowe <bdash@webkit.org>
bdash [Mon, 6 Nov 2006 08:30:01 +0000 (08:30 +0000)]
2006-11-06  Mark Rowe  <bdash@webkit.org>

        Reviewed by the wonderful Mitz Pettel.

        http://bugs.webkit.org/show_bug.cgi?id=11524
        Bug 11524: REGRESSION(r9842): Array.prototype.join should use ToString operator rather than calling toString on each element

        * kjs/array_object.cpp:
        (ArrayProtoFunc::callAsFunction): Use ToString operator on each element rather than calling their toString method.
2006-11-06  Mark Rowe  <bdash@webkit.org>

        Reviewed by the wonderful Mitz Pettel.

        Test for http://bugs.webkit.org/show_bug.cgi?id=11524
        Bug 11524: REGRESSION(r9842): Array.prototype.join should use ToString operator rather than calling toString on each element

        * fast/js/array-join-bug-11524-expected.txt: Added.
        * fast/js/array-join-bug-11524.html: Added.
        * fast/js/resources/array-join-bug-11524.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - quick attempt to fix the no-SVG build
darin [Mon, 6 Nov 2006 06:05:51 +0000 (06:05 +0000)]
    - quick attempt to fix the no-SVG build

        * platform/graphics/svg/SVGResource.cpp:
        * platform/graphics/svg/SVGResource.h:
        * platform/graphics/svg/SVGResourceClipper.cpp:
        * platform/graphics/svg/SVGResourceClipper.h:
        * platform/graphics/svg/SVGResourceImage.h:
        * platform/graphics/svg/SVGResourceMarker.cpp:
        * platform/graphics/svg/SVGResourceMarker.h:
        * platform/graphics/svg/SVGResourceMasker.cpp:
        * platform/graphics/svg/SVGResourceMasker.h:
        * platform/graphics/svg/cg/SVGResourceMaskerCg.h:
        * platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
        * platform/graphics/svg/qt/SVGResourceImageQt.cpp:
        * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
        Added #ifdef SVG_SUPPORT to these files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed & landed by Maciej.
mjs [Mon, 6 Nov 2006 03:15:17 +0000 (03:15 +0000)]
    Reviewed & landed by Maciej.

        Fixes http://bugs.webkit.org/show_bug.cgi?id=11265

        * platform/win/ResourceLoaderWin.cpp:
        (WebCore::transferJobStatusCallback):
        (WebCore::ResourceLoader::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mjs [Mon, 6 Nov 2006 02:55:59 +0000 (02:55 +0000)]
WebCore:

        Reviewed by Oliver.

        - moved FormData and FormDataStream to platform/network directory

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/WebCoreFrameBridge.mm:
        * loader/FormData.cpp: Removed.
        * loader/FormData.h: Removed.
        * loader/mac/FormDataStream.h: Removed.
        * loader/mac/FormDataStream.m: Removed.
        * loader/mac/FrameLoaderMac.mm:
        * loader/mac/SubresourceLoaderMac.mm:
        * platform/network/mac/FormDataStreamMac.h: Added.
        * platform/network/mac/FormDataStreamMac.mm: Added.
        * platform/network/mac/ResourceRequestMac.mm:

WebKit:

        Reviewed by Oliver.

        - removed unneeded (and obsolete) header includes

        * WebCoreSupport/WebFrameBridge.mm:
        * WebView/WebFrame.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-05 Steve Falkenburg <sfalken@apple.com>
sfalken [Sun, 5 Nov 2006 23:52:09 +0000 (23:52 +0000)]
2006-11-05  Steve Falkenburg  <sfalken@apple.com>

        Fix build breaks

        * loader/DocumentLoader.h:
        * platform/win/ScreenWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - WebKit part of Frame.h check-in (forgot to land it)
darin [Sun, 5 Nov 2006 23:14:12 +0000 (23:14 +0000)]
    - WebKit part of Frame.h check-in (forgot to land it)

        * WebCoreSupport/WebFrameBridge.h:
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge textViewWasFirstResponderAtMouseDownTime:]):
        (-[WebFrameBridge shouldInterruptJavaScript]):
        (-[WebFrameBridge saveDocumentState:]):
        (-[WebFrameBridge previousKeyViewOutsideWebFrameViews]):
        (-[WebFrameBridge valueForKey:keys:values:]):
        (-[WebFrameBridge getObjectCacheSize]):
        (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
        (-[WebFrameBridge mayStartDragAtEventLocation:]):
        (-[WebFrameBridge canGoBackOrForward:]):
        (-[WebFrameBridge goBackOrForward:]):
        (-[WebFrameBridge print]):
        (-[WebFrameBridge getAppletInView:]):
        (-[WebFrameBridge pollForAppletInView:]):
        (-[WebFrameBridge respondToChangedContents]):
        (-[WebFrameBridge respondToChangedSelection]):
        (-[WebFrameBridge setIsSelected:forView:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
darin [Sun, 5 Nov 2006 22:02:23 +0000 (22:02 +0000)]
    Reviewed by Geoff.

        - more preparation for splitting up Frame into sub-pieces
        - removed unnecessary includes from Frame.h

        * page/Frame.h: Removed unneeded includes and forward declarations.
        Added additional forward declarations. Removed the constant
        NoXPosForVerticalArrowNavigation, now moved inside SelectionController.
        Created sections of functions to be moved into Chrome, Editor,
        EventHandler, FrameLoader, SelectionController, and the Platform
        directory, as well as marking one function for deletion.

        * page/FramePrivate.h: Removed the definition of the constructor and
        destructor and removed unnecessary includes.

        * page/FrameView.h: Removed unneeded forward declarations and friend
        declarations. Created a section of functions and data to be moved into
        EventHandler.

        * bridge/mac/FrameMac.h: Removed unneeded forward declarations.
        Created sections of functions and data to be moved into Chrome,
        Editor, EventHandler, FrameLoader, and the Platform directory.

        * bridge/mac/WebCoreFrameBridge.h: Removed obsolete comment.
        Removed unused methods areScrollbarsVisible,
        nextValidKeyViewOutsideWebFrameViews, and fileWrapperForURL:.

        * page/Frame.cpp:
        (WebCore::Frame::begin): Added an overload, so Frame.h doesn't have
        to include KURL.h just for the KURL default constructor.
        (WebCore::FramePrivate::FramePrivate): Moved here from FramePrivate.h.
        (WebCore::FramePrivate::~FramePrivate): Ditto.

        * page/FrameView.cpp: Removed unused scrollbarMoved and scrollingSelf
        booleans, scrollbarMoved and cleared funcitons.
        (WebCore::FrameView::clear): Moved the code from the cleared
        function in here.
        (WebCore::FrameView::scrollTo): Removed code to set scrollingSelf.

        * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Updated
        for changes to header.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelection):
        (WebCore::SelectionController::xPosForVerticalArrowNavigation):
        Moved NoXPosForVerticalArrowNavigation into this file.

        * bindings/js/kjs_events.cpp:
        * bindings/js/kjs_html.cpp:
        * bindings/js/kjs_window.cpp:
        * bridge/mac/WebCoreAXObject.mm:
        * bridge/mac/WebCoreFrameBridge.mm:
        * css/cssstyleselector.cpp:
        * dom/Document.cpp:
        * dom/Element.cpp:
        * dom/EventTargetNode.cpp:
        * dom/MouseRelatedEvent.cpp:
        * dom/XMLTokenizer.cpp:
        * html/HTMLBaseElement.cpp:
        * html/HTMLDocument.cpp:
        * html/HTMLEmbedElement.cpp:
        * html/HTMLFrameElementBase.cpp:
        * html/HTMLGenericFormElement.cpp:
        * html/HTMLObjectElement.cpp:
        * html/HTMLTokenizer.cpp:
        * loader/mac/FrameLoaderMac.mm:
        * page/PageState.cpp:
        * rendering/RenderApplet.cpp:
        * rendering/RenderBlock.cpp:
        * rendering/RenderLayer.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderPartObject.cpp:
        * rendering/RenderTreeAsText.cpp:
        * xml/XSLTProcessor.cpp:
        Added includes as needed to keep compiling, since there are fewer
        includes in Frame.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Dave Harrison.
ap [Sun, 5 Nov 2006 08:36:54 +0000 (08:36 +0000)]
    Reviewed by Dave Harrison.

        http://bugs.webkit.org/show_bug.cgi?id=11402
        REGRESSION: onChange does not work anymore for 1st item in popup

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::HTMLSelectElement):
        (WebCore::HTMLSelectElement::reset):
        Set m_lastOnChangeIndex to -1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-04 David Smith <catfish.man@gmail.com>
bdash [Sun, 5 Nov 2006 06:16:36 +0000 (06:16 +0000)]
2006-11-04  David Smith  <catfish.man@gmail.com>

        Reviewed by Tim H.

        Fixes: http://bugs.webkit.org/show_bug.cgi?id=11521
        Bug 11521: [Drosera] Breakpoint editor UI behaves incorrectly when multiple editors are open

        * Drosera/debugger.js: Use .// instead of // so that it doesn't root the search at the document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-04 David Smith <catfish.man@gmail.com>
bdash [Sun, 5 Nov 2006 06:14:48 +0000 (06:14 +0000)]
2006-11-04  David Smith  <catfish.man@gmail.com>

        Reviewed by Tim H.

        Fixes: http://bugs.webkit.org/show_bug.cgi?id=11513
        Bug 11513: [Drosera] Function popup fails to appear when clicking supposedly valid areas.

        * Drosera/debugger.css: Stick a min-width on the menu to keep it from becoming smaller than the control.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-04 David Smith <catfish.man@gmail.com>
bdash [Sun, 5 Nov 2006 06:12:21 +0000 (06:12 +0000)]
2006-11-04  David Smith  <catfish.man@gmail.com>

        Reviewed by Tim H.

        Fixes: http://bugs.webkit.org/show_bug.cgi?id=11512
        Bug 11512: [Drosera] Scrolling via keyboard breaks after clicking in function popup.

        * Drosera/debugger.js: blur() the function popup when we're done with it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agos
darin [Sun, 5 Nov 2006 01:16:31 +0000 (01:16 +0000)]
s

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Ander.
darin [Sun, 5 Nov 2006 01:16:10 +0000 (01:16 +0000)]
    Reviewed by Ander.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11453
          REGRESSION: Status bar always shows cancelled opening the page

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::~ResourceHandle): Removed call to cancel.
        Since the subresource owns the resource handle, there's no need to cancel.
        This arrangement is only temporary, anyway, since Maciej will soon change
        things so that the subresource loader uses the resource handle and the
        resource handle doesn't know anything about the subresource loader.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin [Sun, 5 Nov 2006 01:06:47 +0000 (01:06 +0000)]
WebCore:

        Reviewed by Maciej.

        - converted more of the loader machinery to work with cross-platform
          data structures instead of Macintosh-specific ones

          converted most uses of NSURL to KURL and NSEvent to DOM Event in
          loader classes

          moved download function out of FrameLoader.h to avoid reference to
          NSURLConnection

          added DOM Event parameters to various functions so that the handlers
          can use the DOM Event instead of the global "current NSEvent";
          includes Frame::submitForm, HTMLFormElement::prepareSubmit,
          HTMLFormElement::submit, FrameLoader::load

          moved the setMainFrame call that hands ownership to the Page
          into one of the Frame constructors, and removed it from all
          the clients

          removed const from Event parameter to the urlSelected function
          (we rarely use const with DOM elements)

          removed some redundant includes and declarations from various
          header files

          removed NSURL parameter from userAgent function -- if we need it we
          can add it back, but converting from NSURL to KURL and back is
          inefficient enough that it's best to have it out for now (since it's
          been unused for years) -- if we add it back, we can choose an
          appropriate parameter type that's always inexpensive to pass

          did some basic cleanup in the IconLoader class, including removing
          an unnecessary loop that added icon data a byte at a time

          renamed safeLoad to load, since it's no different from the other
          FrameLoader load functions, safety-wise

          fixed some code that was trying to distinguish null frame name from
          empty string frame name -- both should be handled the same, but callers
          were doing it by checking for empty and turning it into null (in a way
          that was causing extra round trips between NSString and WebCore::String)

          corrected all uses of "get" and "post" to be uppercase "GET" and "POST"
          and got rid of case-insensitive compares of methods

        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/kjs_navigator.cpp:
        (KJS::Navigator::getValueProperty):
        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::submitForm):
        (WebCore::FrameMac::urlSelected):
        (WebCore::FrameMac::userAgent):
        * bridge/mac/FrameViewMac.mm:
        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject rendererForView:]):
        * bridge/mac/WebCorePageBridge.h:
        * bridge/mac/WebCorePageBridge.mm:
        * bridge/mac/WebCoreSettings.mm:
        * bridge/win/FrameWin.cpp:
        (WebCore::FrameWin::urlSelected):
        (WebCore::FrameWin::submitForm):
        * bridge/win/FrameWin.h:
        * dom/MouseRelatedEvent.cpp:
        * dom/MouseRelatedEvent.h:
        * dom/UIEvent.cpp:
        (WebCore::UIEvent::~UIEvent):
        * dom/UIEvent.h:
        * dom/UIEventWithKeyState.h:
        * dom/XMLTokenizer.cpp:
        (WebCore::openFunc):
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::defaultEventHandler):
        * html/HTMLButtonElement.cpp:
        (WebCore::HTMLButtonElement::defaultEventHandler):
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::submitClick):
        (WebCore::HTMLFormElement::prepareSubmit):
        (WebCore::HTMLFormElement::submit):
        * html/HTMLFormElement.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::defaultEventHandler):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
        * loader/DocumentLoader.h:
        * loader/FrameLoader.h:
        * loader/FrameLoaderClient.h:
        * loader/NavigationAction.h:
        (WebCore::NavigationAction::event):
        * loader/icon/IconLoader.cpp:
        (WebCore::IconLoader::create):
        (WebCore::IconLoader::startLoading):
        (WebCore::IconLoader::didReceiveData):
        (WebCore::IconLoader::didFinishLoading):
        * loader/icon/IconLoader.h:
        * loader/loader.cpp:
        * loader/mac/DocumentLoaderMac.mm:
        (WebCore::DocumentLoader::URL):
        (WebCore::DocumentLoader::unreachableURL):
        (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
        (WebCore::DocumentLoader::URLForHistory):
        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::willSendRequest):
        (WebCore::FrameLoader::clientRedirected):
        (WebCore::FrameLoader::shouldReload):
        (WebCore::FrameLoader::notifyIconChanged):
        (WebCore::FrameLoader::URL):
        (WebCore::FrameLoader::reloadAllowingStaleData):
        (WebCore::FrameLoader::reload):
        (WebCore::FrameLoader::didChangeTitle):
        (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
        (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
        (WebCore::FrameLoader::post):
        (WebCore::FrameLoader::addExtraFieldsToRequest):
        (WebCore::FrameLoader::loadResourceSynchronously):
        * loader/mac/IconLoaderMac.mm:
        (WebCore::IconLoader::notifyIconChanged):
        * loader/mac/LoaderFunctionsMac.mm:
        * loader/mac/MainResourceLoaderMac.mm:
        (WebCore::shouldLoadAsEmptyDocument):
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        * loader/mac/NavigationActionMac.mm:
        (WebCore::navigationType):
        (WebCore::NavigationAction::NavigationAction):
        * loader/mac/ResourceLoaderMac.mm:
        * loader/mac/SubresourceLoaderMac.mm:
        * page/Frame.cpp:
        (WebCore::Frame::Frame):
        (WebCore::Frame::urlSelected):
        (WebCore::Frame::submitFormAgain):
        (WebCore::Frame::submitForm):
        (WebCore::Frame::endIfNotLoading):
        (WebCore::Frame::hitTestResultAtPoint):
        * page/Frame.h:
        * page/FramePrivate.h:
        * platform/gdk/FrameGdk.cpp:
        (WebCore::FrameGdk::FrameGdk):
        (WebCore::FrameGdk::submitForm):
        (WebCore::FrameGdk::urlSelected):
        * platform/gdk/FrameGdk.h:
        * platform/mac/TextFieldMac.mm:
        * platform/network/HTTPHeaderMap.h:
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleClient.h:
        * platform/network/ResourceHandleInternal.h:
        * platform/network/mac/ResourceHandleMac.mm:
        * platform/network/mac/ResourceResponseMac.h:
        * platform/network/mac/ResourceResponseMac.mm:
        (-[NSURLResponse WebCore]):
        * platform/network/win/ResourceHandleWin.cpp:
        * platform/qt/FrameQt.cpp:
        (WebCore::FrameQt::submitForm):
        (WebCore::FrameQt::urlSelected):
        * platform/qt/FrameQt.h:
        * rendering/RenderLineEdit.cpp:
        (WebCore::RenderLineEdit::returnPressed):
        * xml/XSLTProcessor.cpp:
        (WebCore::docLoaderFunc):
        * xml/xmlhttprequest.cpp:

WebKit:

        Reviewed by Maciej.

        - converted more of the loader machinery to work with cross-platform
          data structures instead of Macintosh-specific ones

          store the computed user agent string as a WebCore::String instead
          of an NSString to avoid overhead converting it every time we get it

        * COM/WebFrame.cpp:
        (WebFrame::initWithName):
        * ChangeLog:
        * Misc/WebElementDictionary.m:
        (-[WebElementDictionary _image]):
        (-[WebElementDictionary _targetWebFrame]):
        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
        (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
        (WebFrameLoaderClient::setTitle):
        (WebFrameLoaderClient::userAgent):
        (WebFrameLoaderClient::actionDictionary):
        * WebCoreSupport/WebPageBridge.mm:
        (WebCore::if):
        * WebView/WebDataSource.mm:
        (-[WebDataSource _URL]):
        (-[WebDataSource _URLForHistory]):
        (-[WebDataSource unreachableURL]):
        * WebView/WebHTMLView.m:
        (-[WebHTMLView elementAtPoint:allowShadowContent:]):
        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
        (-[WebPDFView _path]):
        * WebView/WebView.mm:
        (-[WebViewPrivate init]):
        (-[WebViewPrivate dealloc]):
        (-[WebViewPrivate finalize]):
        (-[WebView _preferencesChangedNotification:]):
        (-[WebView _cachedResponseForURL:]):
        (-[WebView setApplicationNameForUserAgent:]):
        (-[WebView setCustomUserAgent:]):
        (-[WebView customUserAgent]):
        (-[WebView userAgentForURL:]):
        (-[WebView _computeUserAgent]):
        (-[WebView WebCore::]):
        * WebView/WebViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-04 Mark Rowe <bdash@webkit.org>
bdash [Sun, 5 Nov 2006 01:02:03 +0000 (01:02 +0000)]
2006-11-04  Mark Rowe  <bdash@webkit.org>

        Reviewed by Darin.

        Fix use of uninitialized value in pattern match.

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
mjs [Sun, 5 Nov 2006 00:15:59 +0000 (00:15 +0000)]
    Reviewed by Adele.

        - replaced receivedRedirect with new willSendRequest delegate
        - removed most mac-specific loader functions
        - use ResourceResponse more in loader code

        * WebCore.xcodeproj/project.pbxproj: Add new files.
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge getData:andResponse:forURL:]): Adapted
        for CachedResource method renames.
        (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
        Ditto.
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::checkNotify): simplified
        based on ResourceResponse
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::createImage): adapt for ResourceResponse
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::CachedResource): store a ResourceResponse;
        platform response is now called platformResponse and expiration date
        is removed.
        (WebCore::CachedResource::~CachedResource): ditto
        (WebCore::CachedResource::isExpired): ditto
        * loader/CachedResource.h:
        (WebCore::CachedResource::platformResponse): ditto
        (WebCore::CachedResource::setResponse): ditto
        (WebCore::CachedResource::canDelete): ditto
        * loader/LoaderFunctions.h:
        * loader/loader.cpp:
        (WebCore::Loader::receivedResponse): Adjusted for renames.
        (WebCore::Loader::didReceiveResponse): Store whole ResourceResponse
        in the CachedResource.
        * loader/loader.h:
        * loader/mac/FormDataStream.h:
        * loader/mac/FormDataStream.m:
        (WebCore::getStreamFormDatas): Rearranged things so it's
        possible to get a FormData back out of a form data stream.
        (WebCore::formCreate): ditto
        (WebCore::formFinalize): ditto
        (WebCore::httpBodyFromStream): ditto
        * loader/mac/ImageDocumentMac.mm:
        (WebCore::finishImageLoad): s/response/platformResponse/
        * loader/mac/LoaderFunctionsMac.mm:
        (WebCore::CheckCacheObjectStatus): ditto
        (WebCore::CachedResource::setPlatformResponse): ditto
        * loader/mac/SubresourceLoaderMac.mm:
        (WebCore::SubresourceLoader::willSendRequest): send redirect
        to client appropriately
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleClient.h:
        (WebCore::ResourceHandleClient::willSendRequest): new entry
        point for SubresourceLoader, dispatch to client.
        * platform/network/ResourceRequest.h:
        (WebCore::ResourceRequest::allowHTTPCookies): implemented
        (WebCore::ResourceRequest::setAllowHTTPCookies): ditto
        * platform/network/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse): initialize expiration
        date(!)
        * platform/network/cf/FormDataStreamCFNet.cpp: Added.
        (WebCore::getStreamFormDatas): Added this, ported from NSURL version.
        (WebCore::openNextStream): ditto
        (WebCore::formCreate): ditto
        (WebCore::formFinalize): ditto
        (WebCore::formCanRead): ditto
        (WebCore::formEventCallback): ditto
        (WebCore::setHTTPBody): ditto
        (WebCore::httpBodyFromStream): ditto
        * platform/network/cf/FormDataStreamCFNet.h: Added.
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::willSendRequest): implemented
        (WebCore::ResourceHandle::start): use new ResourceRequest stuff
        * platform/network/cf/ResourceResponseCFNet.cpp:
        (WebCore::getResourceResponse): do nothing for a null response
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::willSendRequest): Implemented; dispatch to client.
        * platform/network/mac/ResourceRequestMac.h: Added.
        * platform/network/mac/ResourceRequestMac.mm: Added.
        (WebCore::getResourceRequest): Added way to convert an NSURLRequest
        to a ResourceRequest.
        (WebCore::nsURLRequest): Opposite of the above.
        * platform/network/cf/ResourceRequestCFNet.h: Added.
        * platform/network/cf/ResourceRequestCFNet.cpp: Added.
        (WebCore::getResourceRequest): Added way to convert an CFURLRequest
        to a ResourceRequest.
        (WebCore::cfURLRequest): Opposite of the above.
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::willSendRequest): Renamed from receivedRedirect,
        adjusted.
        * xml/xmlhttprequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Change suggested by Mitz.
darin [Sat, 4 Nov 2006 17:54:30 +0000 (17:54 +0000)]
    Change suggested by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11514
          REGRESSION (r17438): Repro crash when opening a web archive

        * bridge/mac/WebCorePageState.mm:
        (-[WebCorePageState dealloc]): Add null check.
        (-[WebCorePageState finalize]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher.
darin [Sat, 4 Nov 2006 17:53:32 +0000 (17:53 +0000)]
    Reviewed by Tim Hatcher.

        * Scripts/webkitdirs.pm: Don't try to use the Xcode build setting if it's project-relative.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-04 Bertrand Guiheneuf <guiheneuf@gmail.com>
ap [Sat, 4 Nov 2006 15:51:53 +0000 (15:51 +0000)]
2006-11-04  Bertrand Guiheneuf <guiheneuf@gmail.com>

        Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson).

        http://bugs.webkit.org/show_bug.cgi?id=11433
        Fixes to get WebKit to run on Windows; implemented AffineTransformCairo.

WebCore:
        * WebCore.vcproj/WebCore/WebCore.vcproj:
        Added platform/graphics platform/network and platform/network/win to headers search paths
        Created platform/graphics and platform/network filters in hierarchy
        Moved GraphicsContext and GraphicsTypes to their respective filters
        Added EditorClient.h
        Added FrameLoader* files in loader/
        Added HitTest* files in rendering/
        Added Editor.* files in editing/
        Added DeleteButton.* and DeleteButtonController.* in editing/

        * bridge/win/ChromeClientWin.h: Added.
        (WebCore::ChromeClientWin::~ChromeClientWin):
        * bridge/win/EditorClientWin.h: Added.
        (WebCore::EditorClientWin::~EditorClientWin):

        * bridge/win/FrameWin.cpp:
        (WebCore::FrameWin::FrameWin):
        (WebCore::FrameWin::urlSelected):
        (WebCore::FrameWin::submitForm):
        (WebCore::FrameWin::createNewWindow):
        * bridge/win/FrameWin.h:
        Added EditorClient parameter to constructor
        Replace usage of FrameLoadRequest::m_request with FrameLoadRequest::resourceRequest()
        Removed openURL() and openURLRequest from class definition

        * bridge/win/PageWin.cpp:
        * platform/AffineTransform.h:
        * platform/cairo/AffineTransformCairo.cpp: Added.
        (WebCore::AffineTransform::AffineTransform):
        (WebCore::AffineTransform::setMatrix):
        (WebCore::AffineTransform::map):
        (WebCore::AffineTransform::mapRect):
        (WebCore::AffineTransform::isIdentity):
        (WebCore::AffineTransform::m11):
        (WebCore::AffineTransform::m12):
        (WebCore::AffineTransform::m21):
        (WebCore::AffineTransform::m22):
        (WebCore::AffineTransform::dx):
        (WebCore::AffineTransform::dy):
        (WebCore::AffineTransform::reset):
        (WebCore::AffineTransform::scale):
        (WebCore::AffineTransform::rotate):
        (WebCore::AffineTransform::translate):
        (WebCore::AffineTransform::shear):
        (WebCore::AffineTransform::det):
        (WebCore::AffineTransform::invert):
        (WebCore::AffineTransform::operator cairo_matrix_t):
        (WebCore::AffineTransform::operator== ):
        (WebCore::AffineTransform::operator*= ):
        (WebCore::AffineTransform::operator* ):
        * platform/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
        * platform/network/win/ResourceHandleWin.cpp:
        (WebCore::ResourceHandle::onHandleCreated):
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::fileLoadTimer):
        (WebCore::ResourceHandle::cancel):
        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::FrameWin::goBackOrForward):
        (WebCore::FrameWin::getHistoryLength):
        (WebCore::FrameWin::historyURL):
        (WebCore::ServeSynchronousRequest):
        (WebCore::ChromeClientWin::canRunModal):
        (WebCore::ChromeClientWin::runModal):
        (WebCore::EditorClientWin::shouldDeleteRange):
        (WebCore::EditorClientWin::shouldShowDeleteInterface):
        (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled):
        (WebCore::EditorClientWin::isGrammarCheckingEnabled):
        (WebCore::EditorClientWin::spellCheckerDocumentTag):
        (WebCore::Path::transform):
        (WebCore::PopupMenu::updateFromElement):
        (WebCore::ResourceLoader::loadsBlocked):
        (WebCore::systemBeep):
        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::paintButton):
        (WebCore::RenderThemeWin::paintTextField):

WebKit:
        * COM/WebFrame.cpp:
        (WebFrame::initWithName):
        (WebFrame::loadDataSource):
        (WebFrame::receivedRedirect):
        (WebFrame::receivedResponse):
        (WebFrame::didReceiveData):
        (WebFrame::receivedAllData):
        Use resource handles now. Do not start doc loader by hand anymore.
        Handle didReceiveData() callback instead of receivedData() which
        is deprecated in implementation of ResourceHandleClient

        * COM/WebFrame.h:
        * COM/WebView.cpp:
        Applied ResourceLoader --> ResourceHandle renaming

        * WebKit.vcproj/WebKit.rc:
        Got rid of MFC dependencies (build fix for VCExpress).

        * WebKit.vcproj/WebKit.vcproj:
        Added platform/graphics platform/network and platform/network/win
        to headers search paths

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
ap [Sat, 4 Nov 2006 07:53:19 +0000 (07:53 +0000)]
    Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=11448
        &lang; and &rang; entities are mapped to the incorrect Unicode codepoint

WebCore:
        * html/HTMLEntityNames.gperf: Use canonical Unicode equivalents for these characters.

LayoutTests:
        * fast/parser/entities-in-xhtml-expected.checksum: Removed.
        * fast/parser/entities-in-xhtml-expected.png: Removed.
        Converted to plain text, the large table in the test didn't nearly fit anyway.

        * fast/parser/entities-in-xhtml-expected.txt:
        * fast/parser/entities-in-xhtml.xhtml:
        Made the test self-consistent again by using actual numeric values for &lang; and &rang;.

        * fast/parser/entities-in-html-expected.txt: Added.
        * fast/parser/entities-in-html.html: Added.
        An HTML copy of the same test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-03 David Smith <catfish.man@gmail.com>
bdash [Sat, 4 Nov 2006 06:14:57 +0000 (06:14 +0000)]
2006-11-03  David Smith  <catfish.man@gmail.com>

        Reviewed by Tim H.

        Fixes: http://bugs.webkit.org/show_bug.cgi?id=11510
        Bug 11510: [Drosera] Doubleclicking the attach table should attach to the clicked item.

        * Drosera/DebuggerApplication.m:
        (-[DebuggerApplication showAttachPanel:]): Set the doubleAction for the table view

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-03 Mark Rowe <bdash@webkit.org>
bdash [Sat, 4 Nov 2006 05:33:45 +0000 (05:33 +0000)]
2006-11-03  Mark Rowe  <bdash@webkit.org>

        Reviewed by Oliver.

        Update Windows and Qt project files for file removals in r17585.

        * CMakeLists.txt:
        * WebCore.vcproj/WebCore/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-03 Zack Rusin <zack@kde.org>
bdash [Sat, 4 Nov 2006 05:10:46 +0000 (05:10 +0000)]
2006-11-03  Zack Rusin  <zack@kde.org>

        Reviewed by Maciej.

        The patch fixes text field drawing on the Qt platform.

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::paintTextField): Use the style to correctly
        render the text field

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-03 Steve Falkenburg <sfalken@apple.com>
sfalken [Sat, 4 Nov 2006 04:20:39 +0000 (04:20 +0000)]
2006-11-03  Steve Falkenburg  <sfalken@apple.com>

        Fix build

        * kjs/JSImmediate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-03 Oliver Hunt <oliver@apple.com>
oliver [Sat, 4 Nov 2006 00:41:22 +0000 (00:41 +0000)]
2006-11-03  Oliver Hunt  <oliver@apple.com>

        Reviewed by Tim.

        Correct incorrect call to SetCursor

        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::userResize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
adele [Sat, 4 Nov 2006 00:35:26 +0000 (00:35 +0000)]
    Reviewed by Oliver.

        Removed DeprecatedRenderSelect and ListBox classes.

        * WebCore.xcodeproj/project.pbxproj:
        * css/html4.css:
        * html/HTMLOptionElement.h:
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::recalcStyle):
        (WebCore::HTMLSelectElement::isKeyboardFocusable):
        (WebCore::HTMLSelectElement::isMouseFocusable):
        (WebCore::HTMLSelectElement::createRenderer):
        (WebCore::HTMLSelectElement::setRecalcListItems):
        (WebCore::HTMLSelectElement::notifyOptionSelected):
        (WebCore::HTMLSelectElement::defaultEventHandler):
        (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
        (WebCore::HTMLSelectElement::updateListBoxSelection):
        * html/HTMLSelectElement.h:
        * platform/ListBox.h: Removed.
        * platform/mac/FontCacheMac.mm:
        * platform/mac/ListBoxMac.mm: Removed.
        * platform/win/TemporaryLinkStubs.cpp:
        * rendering/DeprecatedRenderSelect.cpp: Removed.
        * rendering/DeprecatedRenderSelect.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Not reviewed, fix for accidental commit.
mjs [Sat, 4 Nov 2006 00:20:12 +0000 (00:20 +0000)]
    Not reviewed, fix for accidental commit.

        - rolled back more of the accidentall commit that I forgot.

        * platform/network/mac/ResourceRequestMac.h: Removed.
        * platform/network/mac/ResourceRequestMac.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
thatcher [Sat, 4 Nov 2006 00:09:46 +0000 (00:09 +0000)]
    Reviewed by Tim H.

        Fixes: http://bugs.webkit.org/show_bug.cgi?id=9596
        Bug 9596: [Drosera] add a function popup to the source pane

        * Drosera/debugger.css: Added styles for function popup
        * Drosera/debugger.html: Added function popup button and select
        * Drosera/debugger.js: Added function popup functionality

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Not reviewed, fix for accidental commit.
mjs [Fri, 3 Nov 2006 22:28:20 +0000 (22:28 +0000)]
    Not reviewed, fix for accidental commit.

        - roll back some network changes accidentally committed with a previous patch.

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge getData:andResponse:forURL:]):
        (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::checkNotify):
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::createImage):
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::CachedResource):
        (WebCore::CachedResource::~CachedResource):
        (WebCore::CachedResource::setExpireDate):
        (WebCore::CachedResource::isExpired):
        * loader/CachedResource.h:
        (WebCore::CachedResource::response):
        * loader/LoaderFunctions.h:
        * loader/loader.cpp:
        (WebCore::Loader::receivedResponse):
        (WebCore::Loader::didReceivedResponse):
        * loader/loader.h:
        * loader/mac/FormDataStream.h:
        * loader/mac/FormDataStream.m:
        (WebCore::formCreate):
        (WebCore::formFinalize):
        * loader/mac/ImageDocumentMac.mm:
        (WebCore::finishImageLoad):
        * loader/mac/LoaderFunctionsMac.mm:
        (WebCore::CheckCacheObjectStatus):
        (WebCore::CachedResource::setResponse):
        * loader/mac/SubresourceLoaderMac.mm:
        (WebCore::SubresourceLoader::willSendRequest):
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleClient.h:
        (WebCore::ResourceHandleClient::receivedRedirect):
        * platform/network/ResourceRequest.h:
        * platform/network/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::redirectedToURL):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::receivedRedirect):
        * xml/xmlhttprequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-03 Anders Carlsson <acarlsson@apple.com>
andersca [Fri, 3 Nov 2006 22:15:21 +0000 (22:15 +0000)]
2006-11-03  Anders Carlsson  <acarlsson@apple.com>

        Rubber-stamped by Oliver.

        Remove these, they have been merged with SVGRenderTreeAsText.

        * rendering/SVGRenderAsText.cpp: Removed.
        * rendering/SVGRenderAsText.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap [Fri, 3 Nov 2006 22:12:18 +0000 (22:12 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=11504
        Fix warnings on non 32 bit platforms

        * kjs/JSImmediate.h:
        (KJS::JSImmediate::NanAsBits):
        (KJS::JSImmediate::oneAsBits):
        Rewrite in a way that moves runtime checks to compile-time.

        (KJS::):
        (KJS::JSImmediate::fromDouble):
        (KJS::JSImmediate::toDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-03 Anders Carlsson <acarlsson@apple.com>
andersca [Fri, 3 Nov 2006 21:53:47 +0000 (21:53 +0000)]
2006-11-03  Anders Carlsson  <acarlsson@apple.com>

        Build fix.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::willSendRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Forgot to add these two files. Oops.
ggaren [Fri, 3 Nov 2006 21:05:42 +0000 (21:05 +0000)]
    Forgot to add these two files. Oops.

        * WebCoreSupport/WebChromeClient.h: Added.
        * WebCoreSupport/WebChromeClient.mm: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
ggaren [Fri, 3 Nov 2006 20:56:29 +0000 (20:56 +0000)]
WebCore:

        Reviewed by Darin, Beth.

        First cut at factoring Page's UIDelegate-related functions into Chrome
        and ChromeClient.

        Layout tests pass.

        * bridge/mac/PageMac.mm: Removed platform-specific constructor, added
        setBridge method to replace it.
        (WebCore::Page::setBridge):

        * bridge/mac/WebCorePageBridge.h: Simplified some things based on the fact
        that WebCorePageBridge.h doesn't need to be included by ObjC-only files,
        and, now that it uses PassRefPtr, can't be.

        * page/Chrome.cpp: Added. Code copied and converted to c++ from WebCorePageBridge.mm.

        * page/Page.h:
        (WebCore::Page::dragCaretController): Made this function non-const so that
        m_dragCaretController doesn't have to be mutable.

WebKit:

        Reviewed by Darin, Beth.

        First cut at factoring Page's UIDelegate-related functions into Chrome
        and ChromeClient.

        Layout tests pass.

        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebPageBridge.mm:
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-03 Michael Emmel <mike.emmel@gmail.com>
ap [Fri, 3 Nov 2006 18:58:13 +0000 (18:58 +0000)]
2006-11-03  Michael Emmel  <mike.emmel@gmail.com>

        Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=9671

        * Scripts/wkstyle:
        Adds astyle sed script formats according to most of the style guidelines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
ap [Fri, 3 Nov 2006 18:36:56 +0000 (18:36 +0000)]
    Reviewed by Adele.

        http://bugs.webkit.org/show_bug.cgi?id=7323
        REGRESSION (10.4.4): ondrag* events don't fire on page in a frame

WebCore:
        * bridge/mac/FrameMac.h: Moved drag source information to a static variable
        in FrameMac.mm. There can be only one drag active at any moment, and having
        this information here was making sharing this information between
        subframes hard.

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::FrameMac): Initialize sharedDragInfo.
        (WebCore::FrameMac::freeClipboard):
        (WebCore::FrameMac::dragHysteresisExceeded):
        (WebCore::FrameMac::handleMouseMoveEvent):
        (WebCore::FrameMac::handleMouseReleaseEvent):
        (WebCore::FrameMac::mouseDown):
        (WebCore::FrameMac::dragSourceMovedTo):
        (WebCore::FrameMac::dragSourceEndedAt):
        (WebCore::FrameMac::dispatchDragSrcEvent):
        Access drag source info via sharedDragInfo - this fixes drag source even dispatching.
        Also removed some old code that was forwarding mouse events to subviews to make
        HTML editing work in subframes.

        * page/FrameView.cpp:
        (WebCore::FrameView::updateDragAndDrop):
        (WebCore::FrameView::cancelDragAndDrop):
        (WebCore::FrameView::performDragAndDrop):
        Forward events to subframes for dispatching - this fixes drag target events.

WebKitTools:
        When dragging, do not send EventSendingController's events immediately. Dragging
        is supposed to be modal, so we need to perform it from within the delegate, without
        returning to JS to make the next mouse movement.

        When the mouse is down, mouse events are now recorded, and executed when mouseUp is sent.

        * DumpRenderTree/EventSendingController.h:
        * DumpRenderTree/EventSendingController.m:
        (-[EventSendingController dealloc]):
        (-[EventSendingController leapForward:]):
        (-[EventSendingController mouseDown]):
        (-[EventSendingController mouseUp]):
        (-[EventSendingController mouseMoveToX:Y:]):
        (+[EventSendingController saveEvent:]):
        (+[EventSendingController replaySavedEvents]):
        * DumpRenderTree/UIDelegate.m:
        (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):

LayoutTests:
        * fast/events/drag-in-frames-expected.txt: Added.
        * fast/events/drag-in-frames.html: Added.
        * fast/events/resources/drag-in-frames-console.html: Added.
        * fast/events/resources/drag-in-frames-left.html: Added.
        * fast/events/resources/drag-in-frames-right.html: Added.

        * editing/selection/expanding-selections.html:
        * editing/selection/expanding-selections2.html:
        * fast/dynamic/layer-hit-test-crash.html:
        * fast/events/event-view-toString.html:
        * fast/events/resources/drag-outside-window-frame.html:
        * svg/custom/hover-default-fill.svg:
        Added missing calls to mouseUp().

        * svg/custom/stroke-width-click-expected.txt:
        * svg/custom/stroke-width-click.svg:
        Don't attempt to click outside the page, this was confusing DRT.

        * editing/selection/select-from-textfield-outwards-expected.txt:
        * editing/selection/select-from-textfield-outwards.html:
        Removed alerts between dragging steps - they are now useless,
        as the dragging events are stored and executed at once.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-03 Zack Rusin <zack@kde.org>
staikos [Fri, 3 Nov 2006 16:52:22 +0000 (16:52 +0000)]
2006-11-03  Zack Rusin  <zack@kde.org>

        Reviewed by Tim, landed by George.

        Fixing compile.

        * platform/qt/LoaderFunctionsQt.cpp:
        (WebCore::CachedResource::setPlatformResponse): Renamed from setResponse

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Missed a few tests in my last check-in, and checked in old results for
ggaren [Fri, 3 Nov 2006 16:51:39 +0000 (16:51 +0000)]
    Missed a few tests in my last check-in, and checked in old results for
        others. Oops.

        * editing/inserting/before-after-input-element-expected.txt:
        * editing/inserting/before-after-input-element.html:
        * editing/pasteboard/4641033-expected.txt:
        * editing/pasteboard/input-field-1-expected.txt:
        * editing/pasteboard/input-field-1.html:
        * editing/pasteboard/select-element-1-expected.txt:
        * editing/pasteboard/select-element-1.html:
        * editing/selection/select-element-paragraph-boundary-expected.txt:
        * editing/selection/select-element-paragraph-boundary.html:
        * fast/forms/textarea-no-scroll-on-blur-expected.txt:
        * fast/forms/textarea-scrollbar-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-01 Zack Rusin <zack@kde.org>
staikos [Fri, 3 Nov 2006 16:20:55 +0000 (16:20 +0000)]
2006-11-01  Zack Rusin  <zack@kde.org>

        Reviewed by Maciej, landed by George.

        Moving the word/sentence seperators into a file of their own
        and implementing findWordBoundary.

        * CMakeLists.txt:
        * platform/qt/TemporaryLinkStubs.cpp:
        * platform/qt/TextBoundaries.cpp: Added.
        (WebCore::findNextSentenceFromIndex):
        (WebCore::findSentenceBoundary):
        (WebCore::findNextWordFromIndex):
        (WebCore::findWordBoundary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-03 Zack Rusin <zack@kde.org>
staikos [Fri, 3 Nov 2006 10:48:15 +0000 (10:48 +0000)]
2006-11-03  Zack Rusin  <zack@kde.org>

        Reviewed by Maciej, landed by George.

Compile on both KDE and Qt platforms

* CMakeLists.txt: add zlib explicitly
* platform/network/qt/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::self):
(WebCore::QtJob::QtJob):
(WebCore::QtJob::timerEvent): Integrate both implementations
      so that moc can parse it
(WebCore::ResourceHandleManager::deliverJobData):
(WebCore::ResourceHandleManager::remove):
* platform/network/qt/ResourceHandleManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-02 George Staikos <staikos@kde.org>
staikos [Fri, 3 Nov 2006 10:01:09 +0000 (10:01 +0000)]
2006-11-02  George Staikos <staikos@kde.org>

        Reviewed by Maciej.

        * collector.cpp:
        Remove a deprecated pthreads call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago No review, suggested by Mitz.
mjs [Fri, 3 Nov 2006 09:40:10 +0000 (09:40 +0000)]
    No review, suggested by Mitz.

        - fix a #if to be #ifdef

        * platform/graphics/svg/cg/SVGResourceImageCg.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed and landed by Maciej.
mjs [Fri, 3 Nov 2006 09:33:19 +0000 (09:33 +0000)]
    Reviewed and landed by Maciej.

        Compile on the Qt platform.

        * ksvg2/misc/KCanvasRenderingStyle.h:
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::getStylePainterAndWidgetFromPaintInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt. Landed by Maciej.
mjs [Fri, 3 Nov 2006 09:28:25 +0000 (09:28 +0000)]
    Reviewed by Hyatt. Landed by Maciej.

        Adding setPlatformPen/setPlatformFont/setPlatformFillColor
        to graphics context to be able to set consistant state
        on the platform specific painter without having to change
        fill/stroke/font on every operation. This fixes color/stroke/fill
        and font handling in the Qt port.

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::setFont):
        (WebCore::GraphicsContext::setPen):
        (WebCore::GraphicsContext::setFillColor):
        (WebCore::GraphicsContext::setPlatformPen):
        (WebCore::GraphicsContext::setPlatformFillColor):
        (WebCore::GraphicsContext::setPlatformFont):
        * platform/graphics/GraphicsContext.h:
        * platform/qt/GraphicsContextQt.cpp:
        (WebCore::toQtCompositionMode):
        (WebCore::toQtLineCap):
        (WebCore::toQtLineJoin):
        (WebCore::toQPenStyle):
        (WebCore::penToQPen):
        (WebCore::TransparencyLayer::TransparencyLayer):
        (WebCore::GraphicsContext::addRoundedRectClip):
        (WebCore::GraphicsContext::setPlatformFont):
        (WebCore::GraphicsContext::setPlatformPen):
        (WebCore::GraphicsContext::setPlatformFillColor):
        * platform/qt/ScrollViewCanvasQt.cpp:
        (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
        (WebCore::ScrollViewCanvasQt::paintEvent):
        (WebCore::ScrollViewCanvasQt::handleKeyEvent):
        * platform/qt/ScrollViewCanvasQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ggaren [Fri, 3 Nov 2006 06:41:47 +0000 (06:41 +0000)]
LayoutTests:

        Reviewed by Justin Garcia.

        Used a PERL script to add calls to opt into dumping of editing callbacks
        in all editing tests that didn't do so already. This is required now that
        dumping of editing callbacks is opt-in.

        Updated editing.js so that any test that calls runEditingTest() opt into
        dumping of editing callbacks.

        Updated results in all non-editing tests to remove dumping of editing callbacks.

        Updated results in all editing tests to reflect minor DOM changes due to new
        <script> elements.

        [ many tests and results modified ]

WebKitTools:

        Reviewed by Justin Garcia.

        Made dumping of editing callbacks opt-in, so that editing spew doesn't
        cloud non-editing tests.

        * DumpRenderTree/DumpRenderTree.m:
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (-[LayoutTestController shouldDumpEditingCallbacks]):
        (runTest):
        * DumpRenderTree/EditingDelegate.m:
        (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
        (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
        (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
        (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
        (-[EditingDelegate webView:shouldDeleteDOMRange:]):
        (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
        (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
        (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
        (-[EditingDelegate webViewDidBeginEditing:]):
        (-[EditingDelegate webViewDidChange:]):
        (-[EditingDelegate webViewDidEndEditing:]):
        (-[EditingDelegate webViewDidChangeTypingStyle:]):
        (-[EditingDelegate webViewDidChangeSelection:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Updated results because they were incorrect when checked in. (We never
ggaren [Fri, 3 Nov 2006 06:02:08 +0000 (06:02 +0000)]
    Updated results because they were incorrect when checked in. (We never
        passed this test.)

        * fast/js/regexp-unicode-handling-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Fri, 3 Nov 2006 04:29:00 +0000 (04:29 +0000)]
LayoutTests:

        Reviewed by Anders.

        Test for http://bugs.webkit.org/show_bug.cgi?id=9581
        REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.

        * fast/forms/textarea-no-scroll-on-blur-expected.txt: Added.
        * fast/forms/textarea-no-scroll-on-blur.html: Added.

WebCore:

        Reviewed by Anders.

        - Fix for http://bugs.webkit.org/show_bug.cgi?id=9581
        REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.

        Test: fast/forms/textarea-no-scroll-on-blur.html

        * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::forwardEvent):
          On blur, only scroll back to the start for text fields.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Another build fix.
andersca [Fri, 3 Nov 2006 03:37:29 +0000 (03:37 +0000)]
    Another build fix.

        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::paintObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
andersca [Fri, 3 Nov 2006 03:33:17 +0000 (03:33 +0000)]
    Build fix.

        * page/FramePrivate.h:
        (WebCore::FramePrivate::FramePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff, landed by Anders.
andersca [Fri, 3 Nov 2006 03:27:31 +0000 (03:27 +0000)]
    Reviewed by Geoff, landed by Anders.

        Fix dependency problems caused when running move-js-headers.sh

        * move-js-headers.sh:
        Use cp -p instead of just cp so that the modification time
        of the original files are used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-02 W. Andy Carrel <wac@google.com>
andersca [Fri, 3 Nov 2006 03:23:02 +0000 (03:23 +0000)]
2006-11-02  W. Andy Carrel  <wac@google.com>

        Reviewed by Maciej, landed by Anders.

        Adding tests for Unicode RegExp behavior to match IE and Firefox.
        * fast/js/regexp-unicode-handling-expected.txt: Added.
        * fast/js/regexp-unicode-handling.html: Added.
        * fast/js/resources/regexp-unicode-handling.js: Added.

2006-11-02  Alexey Proskuryakov  <ap@nypop.com>

        Reviewed by Maciej, landed by Anders.

        Test for bugs 7253 and 7445, based on reductions made by Parag Shah and W. Andy Carrel.

        * fast/js/gmail-re-re-expected.txt: Added.
        * fast/js/gmail-re-re.html: Added.
        * fast/js/resources/gmail-re-re.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H, landed by Anders.
andersca [Fri, 3 Nov 2006 03:17:44 +0000 (03:17 +0000)]
    Reviewed by Tim H, landed by Anders.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10840
        REGRESSION: Shadow of file upload button is clipped

        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip
        height to keep from clipping in the shadow

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej, landed by Anders.
andersca [Fri, 3 Nov 2006 03:16:38 +0000 (03:16 +0000)]
    Reviewed by Maciej, landed by Anders.

        * platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between
        content and window. ScrollViewQt already receives correct content
        coordinates from QScrollArea.
        (WebCore::ScrollView::contentsToWindow):
        (WebCore::ScrollView::windowToContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
andersca [Fri, 3 Nov 2006 03:14:50 +0000 (03:14 +0000)]
JavaScriptCore:

        Reviewed by Maciej, landed by Anders.

        * CMakeLists.txt:
        Make KDE support optional.

WebKitQt:

        Reviewed by Maciej, landed by Anders.

        * QtLauncher/CMakeLists.txt: Make linkage against kde libraries
          optional
        * QtLauncher/main.cpp: Make it compile without KDE.
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej, landed by Anders
andersca [Fri, 3 Nov 2006 03:11:52 +0000 (03:11 +0000)]
    Reviewed by Maciej, landed by Anders

        * CMakeLists.txt: Make linkage against KDE libraries conditional
        * platform/network/qt/ResourceHandleManager.cpp: Added a simple
          Qt base resource handler that supports only requests to the
          local filesystem. Used when compiling without KDE support.
          ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE
          and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h.
        (WebCore::QtJob::QtJob):
        (WebCore::QtJob::timerEvent):
        (WebCore::ResourceHandleManager::ResourceHandleManager):
        (WebCore::ResourceHandleManager::~ResourceHandleManager):
        (WebCore::ResourceHandleManager::self):
        (WebCore::ResourceHandleManager::remove):
        (WebCore::ResourceHandleManager::add):
        (WebCore::ResourceHandleManager::cancel):
        (WebCore::ResourceHandleManager::deliverJobData):
        * platform/network/qt/ResourceHandleManager.h:
        * platform/qt/FrameQtClient.cpp:
        (WebCore::FrameQtClientDefault::runJavaScriptAlert):
        (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
        (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
        * platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and
          input dialog functions when compiling without KDE support
        (WebCore::ServeSynchronousRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-02 Alexey Proskuryakov <ap@nypop.com>
andersca [Fri, 3 Nov 2006 03:09:04 +0000 (03:09 +0000)]
2006-11-02  Alexey Proskuryakov  <ap@nypop.com>

        Reviewed by Maciej, landed by Anders.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=7802
          devenv.com not available in VC++ Express installations

        * Scripts/webkitdirs.pm: Make Windows build work with Visual C++ Express.
        * Scripts/install-win-extras: Make setx.exe actually run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-02 David Carson <dacarson@gmail.com>
andersca [Fri, 3 Nov 2006 03:06:40 +0000 (03:06 +0000)]
2006-11-02  David Carson  <dacarson@gmail.com>

        Reviewed by Geoff, landed by Anders.

        Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
        Initializing variable in constructor.

        * page/FramePrivate.h:
        (WebCore::FramePrivate::FramePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-02 Anders Carlsson <acarlsson@apple.com>
andersca [Fri, 3 Nov 2006 01:30:24 +0000 (01:30 +0000)]
2006-11-02  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::addHeadersFromHashMap):
        Don't set all headers at once since that clears any previous headers set.

        (WebCore::ResourceHandle::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix.
thatcher [Fri, 3 Nov 2006 00:27:52 +0000 (00:27 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
thatcher [Fri, 3 Nov 2006 00:12:45 +0000 (00:12 +0000)]
    Reviewed by Brady.

        Adding outdent to the WebView responder forwarding list.
        Also add outdent to WebHTMLView.h and WebViewPrivate.h.

        * WebView/WebHTMLView.h:
        * WebView/WebViewPrivate.h:
        * WebView/WebView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Updated results to fix failure seen when running layout tests. Justin
ggaren [Thu, 2 Nov 2006 22:08:31 +0000 (22:08 +0000)]
    Updated results to fix failure seen when running layout tests. Justin
        Garcia says the new results look more correct.

        * editing/selection/drag-to-contenteditable-iframe-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Thu, 2 Nov 2006 21:37:46 +0000 (21:37 +0000)]
LayoutTests:

        Reviewed by Mitz and Geoff.

        Test for <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)

        * fast/forms/textarea-scrollbar-expected.checksum: Added.
        * fast/forms/textarea-scrollbar-expected.png: Added.
        * fast/forms/textarea-scrollbar-expected.txt: Added.
        * fast/forms/textarea-scrollbar.html: Added.

WebCore:

        Reviewed by Mitz and Geoff.

        - Fix for:
        <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
        <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
        <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages

        Test: fast/forms/textarea-scrollbar.html

        To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
        a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.

        * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::RenderTextControl):
        (WebCore::RenderTextControl::setStyle):
        (WebCore::RenderTextControl::createDivStyle):
        (WebCore::RenderTextControl::updateFromElement):
        (WebCore::RenderTextControl::calcHeight):
        (WebCore::RenderTextControl::baselinePosition):
        (WebCore::RenderTextControl::nodeAtPoint):
        (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
        (WebCore::RenderTextControl::scrollWidth):
        (WebCore::RenderTextControl::scrollHeight):
        (WebCore::RenderTextControl::scrollLeft):
        (WebCore::RenderTextControl::scrollTop):

        * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff Garen
sullivan [Thu, 2 Nov 2006 18:12:53 +0000 (18:12 +0000)]
    Reviewed by Geoff Garen

        * editing/Selection.cpp:
        (WebCore::Selection::showTreeForThis):
        this debugging method now displays start offset and end offset, at Darin's suggestion

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
kmccullo [Thu, 2 Nov 2006 17:44:13 +0000 (17:44 +0000)]
    Reviewed by Maciej.

        - Changed the test to take into account the JavaScript standard's interesting take on DST.  According to the standard DST should not reflect historically accurate information but should rather interpolate from a comparable year.  This test used to show historically accurate information but now reflects the results of interpolating.

        * fast/js/date-big-setdate-expected.txt:
        * fast/js/resources/date-big-setdate.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-01 Stephanie Lewis <slewis@apple.com>
slewis [Thu, 2 Nov 2006 03:59:39 +0000 (03:59 +0000)]
2006-11-01  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Kevin.

        Fixed bug where additional arguments got fed to xcode and jsdriver.pl
        Since testkjs is being built before the tests are run, we don't need
        to build it with webkit.

        Fixes bugs
        http://bugs.webkit.org/show_bug.cgi?id=11462
        http://bugs.webkit.org/show_bug.cgi?id=6168

        * Scripts/build-webkit:
        * Scripts/run-javascriptcore-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Thu, 2 Nov 2006 03:52:33 +0000 (03:52 +0000)]
LayoutTests:

        Reviewed by darin

        <rdar://problem/4062865>
        Copy/paste of a select element fails to include the options

        Updated to reflect fix:
        * editing/pasteboard/4641033-expected.checksum:
        * editing/pasteboard/4641033-expected.png:
        * editing/pasteboard/4641033-expected.txt:
        * editing/pasteboard/4641033.html:

        Added:
        * editing/inserting/before-after-input-element-expected.checksum: Added.
        * editing/inserting/before-after-input-element-expected.png: Added.
        * editing/inserting/before-after-input-element-expected.txt: Added.
        * editing/inserting/before-after-input-element.html: Added.
        * editing/pasteboard/input-field-1-expected.checksum: Added.
        * editing/pasteboard/input-field-1-expected.png: Added.
        * editing/pasteboard/input-field-1-expected.txt: Added.
        * editing/pasteboard/input-field-1.html: Added.
        * editing/pasteboard/select-element-1-expected.checksum: Added.
        * editing/pasteboard/select-element-1-expected.png: Added.
        * editing/pasteboard/select-element-1-expected.txt: Added.
        * editing/pasteboard/select-element-1.html: Added.
        * editing/selection/select-element-paragraph-boundary-expected.checksum: Added.
        * editing/selection/select-element-paragraph-boundary-expected.png: Added.
        * editing/selection/select-element-paragraph-boundary-expected.txt: Added.
        * editing/selection/select-element-paragraph-boundary.html: Added.

WebCore:

        Reviewed by darin

        <rdar://problem/4062865>
        Copy/paste of a select element fails to include the options

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modify): Added paragraphBoundary.
        * editing/htmlediting.cpp:
        (WebCore::canHaveChildrenForEditing): Added checks for input elements
        and textareas.  Insertion operations would fail when performed just
        before/after one of these elements b/c the content would be put inside
        the element.
        (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non
        editable content, and made the code to stop at an root faster (don't check
        isDescendantOf on every iteration).
        (WebCore::enclosingNodeOfType): Ditto.
        (WebCore::enclosingList): Ditto.
        (WebCore::enclosingListChild): Ditto.  Added a FIXME, this function seems
        inappropriately named.
        * editing/markup.cpp:
        (WebCore::startMarkup): Use the text node's value instead of its rendered
        content for text nodes inside select elements.  One might also turn off
        annotation when createMarkup enters a select element, but createMarkup
        is iterative, not recursive, so doing so would be complicated.
        (WebCore::createMarkup): Add markup for unrendered nodes if they are
        descendants of a select element.
        * editing/visible_units.cpp:
        (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock.  Fixes bug
        where various replaced elements can't be copied when they are the only
        thing selected.
        (WebCore::endOfParagraph): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-01 Oliver Hunt <oliver@apple.com>
oliver [Thu, 2 Nov 2006 01:41:28 +0000 (01:41 +0000)]
2006-11-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Converting more or kcanvas/quartz from Obj-C to C++
        Minor SVG updates
        compatibility fixes

        * WebCore.xcodeproj/project.pbxproj:
        * kcanvas/device/KRenderingPaintServer.h:
        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added.
        (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
        * kcanvas/device/quartz/QuartzSupport.h:
        * ksvg2/css/SVGCSSStyleSelector.cpp:
        * ksvg2/misc/KCanvasRenderingStyle.h:
        * ksvg2/scripts/cssmakeprops:
        * ksvg2/scripts/cssmakevalues:
        * ksvg2/scripts/make_names.pl:
        * ksvg2/svg/SVGAnimateColorElement.cpp:
        * ksvg2/svg/SVGAnimateTransformElement.cpp:
        * ksvg2/svg/SVGAnimationElement.cpp:
        * ksvg2/svg/SVGMaskElement.cpp:
        * ksvg2/svg/SVGPatternElement.cpp:
        * ksvg2/svg/svgpathparser.cpp:
        * platform/Path.cpp:
        * platform/graphics/svg/SVGResourceImage.h:
        * rendering/RenderPath.cpp:
        * rendering/SVGRenderAsText.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - temporarily passing a test so that it does not interfere with others testing.
kmccullo [Thu, 2 Nov 2006 01:02:42 +0000 (01:02 +0000)]
    - temporarily passing a test so that it does not interfere with others testing.

        * fast/js/date-big-setdate-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher
beidson [Thu, 2 Nov 2006 00:56:56 +0000 (00:56 +0000)]
    Reviewed by Tim Hatcher

        Added accessor to get the source directory for use in client scripts

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
adele [Thu, 2 Nov 2006 00:43:07 +0000 (00:43 +0000)]
    Reviewed by Adele.

        - Fix a regression from r17521: painting of and crash caused by tables
          with collapsed borders

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to
        r17521, 'paintInfo' was the local variable. Now 'info' is the local variable
        and 'paintInfo' is the parameter, which we were accidently modifying.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fixing typo. Changed repaintTest to runRepaintTest.
adele [Wed, 1 Nov 2006 23:34:17 +0000 (23:34 +0000)]
    Fixing typo.  Changed repaintTest to runRepaintTest.

        * fast/repaint/overflow-outline-repaint-expected.checksum:
        * fast/repaint/overflow-outline-repaint-expected.png:
        * fast/repaint/overflow-outline-repaint.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Wed, 1 Nov 2006 23:28:57 +0000 (23:28 +0000)]
LayoutTests:

        Reviewed by Mitz.

        Tests for http://bugs.webkit.org/show_bug.cgi?id=11277
        REGRESSION: Incomplete repaint of overflow areas when deleting

        * fast/repaint/overflow-delete-line-expected.checksum: Added.
        * fast/repaint/overflow-delete-line-expected.png: Added.
        * fast/repaint/overflow-delete-line-expected.txt: Added.
        * fast/repaint/overflow-delete-line.html: Added.
        * fast/repaint/overflow-scroll-delete-expected.checksum: Added.
        * fast/repaint/overflow-scroll-delete-expected.png: Added.
        * fast/repaint/overflow-scroll-delete-expected.txt: Added.
        * fast/repaint/overflow-scroll-delete.html: Added.
        * fast/repaint/overflow-outline-repaint-expected.checksum: Added.
        * fast/repaint/overflow-outline-repaint-expected.png: Added.
        * fast/repaint/overflow-outline-repaint-expected.txt: Added.
        * fast/repaint/overflow-outline-repaint.html: Added.

WebCore:

        Reviewed by Mitz.

        - Fix for http://bugs.webkit.org/show_bug.cgi?id=11277
        REGRESSION: Incomplete repaint of overflow areas when deleting

        Restrict the repaint rect for overflow blocks after the height has been fully computed.
        Also, adjust the repaint rect coordinates for the scroll offset.

        * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
        * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben
sullivan [Wed, 1 Nov 2006 23:22:33 +0000 (23:22 +0000)]
    Reviewed by Adam Roben

        - fixed <rdar://problem/4801351> Crash reloading PDF file in new Safari (or closing a window containing a PDF file)

        * WebView/WebPDFView.mm:
        (-[WebPDFView initWithFrame:]):
        Retain the PDFSubview in the code path where we just obtain it by asking the PDFPreviewView for it. We were
        unconditionally releasing it in dealloc, but only retaining it in one of the two code paths.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
weinig [Wed, 1 Nov 2006 21:49:13 +0000 (21:49 +0000)]
    Reviewed by Mitz.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
        Rename the "p" member variable of the PaintInfo struct to "context"

        - Renames the 'p' and 'r' member variables of the PaintInfo struct to
          'context' and 'rect' respectively.

        - Assorted surrounding cleanups.

        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::paint):
        * rendering/EllipsisBox.h:
        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::paint):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paint):
        (WebCore::InlineFlowBox::paintBackground):
        (WebCore::InlineFlowBox::paintBackgroundAndBorder):
        (WebCore::InlineFlowBox::paintDecorations):
        * rendering/InlineFlowBox.h:
        * rendering/InlineRunBox.h:
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        * rendering/InlineTextBox.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paint):
        (WebCore::RenderBlock::paintChildren):
        (WebCore::RenderBlock::paintCaret):
        (WebCore::RenderBlock::paintObject):
        (WebCore::RenderBlock::paintFloats):
        (WebCore::RenderBlock::paintEllipsisBoxes):
        (WebCore::RenderBlock::paintSelection):
        (WebCore::RenderBlock::fillSelectionGaps):
        (WebCore::RenderBlock::fillInlineSelectionGaps):
        (WebCore::RenderBlock::fillBlockSelectionGaps):
        (WebCore::RenderBlock::fillHorizontalSelectionGap):
        (WebCore::RenderBlock::fillVerticalSelectionGap):
        (WebCore::RenderBlock::fillLeftSelectionGap):
        (WebCore::RenderBlock::fillRightSelectionGap):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paint):
        (WebCore::RenderBox::paintRootBoxDecorations):
        (WebCore::RenderBox::paintBoxDecorations):
        * rendering/RenderBox.h:
        * rendering/RenderButton.cpp:
        (WebCore::RenderButton::paintObject):
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::paintBoxDecorations):
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::paintObject):
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::continuationBefore):
        (WebCore::RenderFlow::addChildWithContinuation):
        (WebCore::RenderFlow::addChild):
        (WebCore::RenderFlow::attachLineBox):
        (WebCore::RenderFlow::destroy):
        (WebCore::RenderFlow::dirtyLinesFromChangedChild):
        (WebCore::RenderFlow::dirtyLineBoxes):
        (WebCore::RenderFlow::createInlineBox):
        (WebCore::RenderFlow::paintLines):
        (WebCore::RenderFlow::getAbsoluteRepaintRect):
        (WebCore::RenderFlow::lowestPosition):
        (WebCore::RenderFlow::rightmostPosition):
        (WebCore::RenderFlow::leftmostPosition):
        (WebCore::RenderFlow::caretRect):
        (WebCore::RenderFlow::addFocusRingRects):
        (WebCore::RenderFlow::paintOutline):
        (WebCore::RenderFlow::paintOutlineForLine):
        * rendering/RenderForeignObject.cpp:
        (WebCore::RenderForeignObject::paint):
        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::paint):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paint):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintLayer):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::paintObject):
        (WebCore::RenderListBox::paintScrollbar):
        (WebCore::RenderListBox::paintItemForeground):
        (WebCore::RenderListBox::paintItemBackground):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::paintObject):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::paint):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::PaintInfo::PaintInfo):
        (WebCore::RenderObject::paintBoxDecorations):
        (WebCore::RenderObject::paintingRootForChildren):
        (WebCore::RenderObject::shouldPaintWithinRoot):
        (WebCore::RenderObject::printBoxDecorations):
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::paint):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::shouldPaint):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::paint):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::paint):
        * rendering/RenderSVGText.h:
        (WebCore::RenderSVGText::renderName):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paint):
        (WebCore::RenderTable::paintBoxDecorations):
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paint):
        (WebCore::RenderTableCell::paintBackgroundsBehindCell):
        (WebCore::RenderTableCell::paintBoxDecorations):
        * rendering/RenderTableCell.h:
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::paint):
        * rendering/RenderTableRow.h:
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::paint):
        * rendering/RenderTableSection.h:
        (WebCore::RenderTableSection::getBaseline):
        (WebCore::RenderTableSection::setNeedCellRecalc):
        * rendering/RenderText.h:
        (WebCore::RenderText::renderName):
        (WebCore::RenderText::paint):
        (WebCore::RenderText::element):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::paint):
        (WebCore::RenderTheme::paintBorderOnly):
        (WebCore::RenderTheme::paintDecorations):
        * rendering/RenderTheme.h:
        (WebCore::RenderTheme::RenderTheme):
        (WebCore::RenderTheme::~RenderTheme):
        (WebCore::RenderTheme::controlSupportsTints):
        (WebCore::RenderTheme::adjustRepaintRect):
        (WebCore::RenderTheme::themeChanged):
        (WebCore::RenderTheme::supportsHover):
        (WebCore::RenderTheme::paintCheckbox):
        (WebCore::RenderTheme::setCheckboxSize):
        (WebCore::RenderTheme::paintRadio):
        (WebCore::RenderTheme::setRadioSize):
        (WebCore::RenderTheme::paintButton):
        (WebCore::RenderTheme::setButtonSize):
        (WebCore::RenderTheme::paintTextField):
        (WebCore::RenderTheme::paintTextArea):
        (WebCore::RenderTheme::paintMenuList):
        (WebCore::RenderTheme::paintMenuListButton):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintCheckbox):
        (WebCore::RenderThemeMac::paintRadio):
        (WebCore::RenderThemeMac::paintButton):
        (WebCore::RenderThemeMac::paintTextField):
        (WebCore::RenderThemeMac::paintTextArea):
        (WebCore::RenderThemeMac::paintMenuList):
        (WebCore::RenderThemeMac::paintMenuListButtonGradients):
        (WebCore::RenderThemeMac::paintMenuListButton):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::paint):
        (WebCore::RenderView::paintBoxDecorations):
        * rendering/RenderView.h:
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):
        * rendering/RenderWidget.h:
        (WebCore::RenderWidget::isWidget):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::paintEllipsisBox):
        (WebCore::RootInlineBox::paintCustomHighlight):
        (WebCore::RootInlineBox::paint):
        (WebCore::RootInlineBox::fillLineSelectionGap):
        * rendering/RootInlineBox.h:
        * rendering/SVGInlineFlowBox.cpp:
        (WebCore::paintSVGInlineFlow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
kmccullo [Wed, 1 Nov 2006 20:34:23 +0000 (20:34 +0000)]
    Reviewed by Brady.

        - Fixes many JavaScriptCore tests in other timezones.  The root problem is that on mac localtime() returns historically accurate information for DST, but the JavaScript spec explicitly states to not take into account historical information but rather to interpolate from valid years.

        * kjs/DateMath.cpp:
        (KJS::equivalentYearForDST):
        (KJS::getDSTOffsetSimple):
        (KJS::getDSTOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-11-01 Anders Carlsson <acarlsson@apple.com>
andersca [Wed, 1 Nov 2006 19:43:21 +0000 (19:43 +0000)]
2006-11-01  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Oliver, Brady.

        * platform/network/ResourceResponse.h:
        (WebCore::ResourceResponse::setLastModifiedDate):
        (WebCore::ResourceResponse::lastModifiedDate):
        Add getters and setters for last modified dadte.

        * platform/network/cf/ResourceResponseCFNet.cpp:
        (WebCore::getResourceResponse):
        Fetch the last modified date. Add correct offset to expired date.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17519 268f45cc-cd09-0410-ab3c-d52691b4dbfc