WebKit-https.git
3 months ago[iOS] Implement idempotent mode for text autosizing
mmaxfield@apple.com [Fri, 26 Apr 2019 06:33:56 +0000 (06:33 +0000)]
[iOS] Implement idempotent mode for text autosizing
https://bugs.webkit.org/show_bug.cgi?id=197250
<rdar://problem/50211034>

Reviewed by Jon Lee.

Source/WebCore:

Our text autosizing code has this interesting behavior where it is sensitive to the width of the text's container
and the number of lines of text inside the element. Not only is it sensitive to those things, but as those things
change, their values are stored inside the RenderObject itself and then never recomputed. This means that the text
autosizing parameters are sensitive to the entire history of an element. So, a newly created element with the same
style as an existing element can have dramatically different results.

This patch adds a new mode for text autosizing, which isn't sensitive to either of those things, and therefore
maintains the invariant that a newly created element will behave the same as an existing element with the same style.
Instead of using container size, it instead uses the viewport's initial scale. As the viewport's initial scale
changes, new layouts will be triggered, which will cause the autosizing code to use the new value.

Tests: fast/text-autosizing/ios/idempotentmode/idempotent-autosizing-identity.html
       fast/text-autosizing/ios/idempotentmode/idempotent-autosizing.html

* page/FrameViewLayoutContext.cpp:
(WebCore::FrameViewLayoutContext::applyTextSizingIfNeeded):
* page/Page.cpp:
(WebCore::Page::setInitialScale): WebKit will push the initial scale down into the page.
* page/Page.h:
(WebCore::Page::initialScale const):
* page/SettingsBase.h:
* page/cocoa/SettingsBaseCocoa.mm:
(WebCore::SettingsBase::textAutosizingUsesIdempotentMode):
(WebCore::SettingsBase::defaultTextAutosizingEnabled):
* rendering/RenderBlockFlow.cpp:
(WebCore::idempotentTextSize): Describe a piecewise-linear curve for the text size to follow. The curve scales
depending on the viewport's initial scale.
(WebCore::RenderBlockFlow::adjustComputedFontSizes):
* rendering/RenderBlockFlow.h:
* rendering/RenderElement.cpp:
(WebCore::includeNonFixedHeight): This new mode should consider max-height as well as height when determining if
content overflows.
(WebCore::RenderElement::adjustComputedFontSizesOnBlocks):
(WebCore::RenderElement::resetTextAutosizing):
* rendering/RenderElement.h:
* rendering/RenderObject.h:

Source/WebKit:

Push the initial scale down into the page.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::WebPage::viewportConfigurationChanged):

LayoutTests:

Add two simple tests that make sure that fonts get autosized > 1x when the layout viewport is wide,
and that fonts don't get autosized when the layout viewport isn't wide.

We don't want to add tons of tests to test exact values because the curve will likely be tweaked
in the future.

* fast/text-autosizing/ios/idempotentmode/idempotent-autosizing-expected.txt: Added.
* fast/text-autosizing/ios/idempotentmode/idempotent-autosizing-identity-expected.txt: Added.
* fast/text-autosizing/ios/idempotentmode/idempotent-autosizing-identity.html: Added.
* fast/text-autosizing/ios/idempotentmode/idempotent-autosizing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoMake NetworkCache blobs safe for mmap instead of not using blobs
commit-queue@webkit.org [Fri, 26 Apr 2019 06:06:10 +0000 (06:06 +0000)]
Make NetworkCache blobs safe for mmap instead of not using blobs
https://bugs.webkit.org/show_bug.cgi?id=197264
<rdar://problem/49564348>

Patch by Alex Christensen <achristensen@webkit.org> on 2019-04-25
Reviewed by Antti Koivisto.

This does what r244597 did for WKContentRuleLists but for the NetworkCache's blobs.
Those are the two cases where we were calling mmap and seeing crashes in apps with
default file protection of NSFileProtectionComplete.

* NetworkProcess/cache/NetworkCacheBlobStorage.cpp:
(WebKit::NetworkCache::BlobStorage::add):
* NetworkProcess/cache/NetworkCacheFileSystem.cpp:
(WebKit::NetworkCache::isSafeToUseMemoryMapForPath): Deleted.
* NetworkProcess/cache/NetworkCacheFileSystem.h:
* NetworkProcess/cache/NetworkCacheFileSystemCocoa.mm:
(WebKit::NetworkCache::isSafeToUseMemoryMapForPath):
* NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::Storage):
(WebKit::NetworkCache::Storage::synchronize):
(WebKit::NetworkCache::Storage::mayContainBlob const):
(WebKit::NetworkCache::Storage::shouldStoreBodyAsBlob):
(WebKit::NetworkCache::estimateRecordsSize): Deleted.
* NetworkProcess/cache/NetworkCacheStorage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoUnreviewed, rolling out r244669.
Hironori.Fujii@sony.com [Fri, 26 Apr 2019 03:46:43 +0000 (03:46 +0000)]
Unreviewed, rolling out r244669.

Windows ports can't clean build.

Reverted changeset:

"[Win] Add flag to enable version information stamping and
disable by default."
https://bugs.webkit.org/show_bug.cgi?id=197249
https://trac.webkit.org/changeset/244669

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoREGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
simon.fraser@apple.com [Fri, 26 Apr 2019 02:55:36 +0000 (02:55 +0000)]
REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
https://bugs.webkit.org/show_bug.cgi?id=188357
<rdar://problem/42986633>

Reviewed by Dean Jackson.
Source/WebCore:

DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
tests would fall into low memory mode and have different behavior.

Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
to Internals, so it's shared by DRT and WTR.

We no longer need the WK2 C SPI glue.

* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):

Source/WebKit:

DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
tests would fall into low memory mode and have different behavior.

Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
to Internals, so it's shared by DRT and WTR.

We no longer need the WK2 C SPI glue.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetEventThrottlingBehaviorOverride):
(WKBundlePageSetCompositingPolicyOverride): Deleted.
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

Tools:

DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
tests would fall into low memory mode and have different behavior.

Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
to Internals, so it's shared by DRT and WTR.

We no longer need the WK2 C SPI glue.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::prepare):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago[ iOS Sim ] REGRESSION (r242986) Layout Test storage/indexeddb/modern/idbtransaction...
sihui_liu@apple.com [Fri, 26 Apr 2019 01:58:33 +0000 (01:58 +0000)]
[ iOS Sim ] REGRESSION (r242986) Layout Test storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196357
<rdar://problem/49386836>

Reviewed by Geoffrey Garen.

Source/WebCore:

Dispatch IDBRequest event to IDBTransaction if event of IDBTransaction has not been dispatched.

Covered by existing tests.

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::dispatchEvent):
* Modules/indexeddb/IDBTransaction.h:

LayoutTests:

* platform/ios-simulator-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoASSERT(scriptExecutionContext()) in Performance::resourceTimingBufferFullTimerFired()
cdumez@apple.com [Fri, 26 Apr 2019 01:28:39 +0000 (01:28 +0000)]
ASSERT(scriptExecutionContext()) in Performance::resourceTimingBufferFullTimerFired()
https://bugs.webkit.org/show_bug.cgi?id=197300
<rdar://problem/49965990>

Reviewed by Youenn Fablet.

We crash because the scriptExecutionContext has been destroyed by the time the m_resourceTimingBufferFullTimer
timer fires. However, r241598 already makes sure that we stop the timer when the script execution context
is destroyed. This makes me think that somebody restarts the timer *after* the script execution context has
been destroyed. The thing is that we only start the timer in Performance::addResourceTiming() and there are
only 2 call sites for this method. Both call sites get the Performance object from the Window object, which
they get from the Document object. As a result, I would believe that the Window's document is alive, even
though the Performance object's scriptExecutionContext is not. This could indicate that the Performance
object's scriptExecutionContext gets out of sync with its Window's document. I have found one place where
it could happen in theory (DOMWindow::didSecureTransitionTo()). I have not been able to write a test
confirming my theory though so this is a speculative fix. I have also added a few assertions to help us
track down the issue if my speculative fix turns out to be ineffective.

No new tests, we do not know how to reproduce.

* page/DOMWindow.cpp:
(WebCore::DOMWindow::didSecureTransitionTo):
This is a speculative fix for the crash. When a DOMWindow transitions from one document to
another, reset its data members which store the DOMWindow's document to make sure that they
do not get out of sync.

(WebCore::DOMWindow::crypto const):
(WebCore::DOMWindow::navigator):
(WebCore::DOMWindow::performance const):
Add assertions to make sure that the member's scriptExecutionContext is in sync with
the window's.

* page/Performance.cpp:
(WebCore::Performance::addResourceTiming):
Add assertion to make sure that the scriptExecutionContext() is non-null when calling this
as this may start the m_resourceTimingBufferFullTimer timer. If my speculative fix above
does not work, we should hit this and this should tell us which call site is causing this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoMake sure sockets file descriptors are in the correct range
youenn@apple.com [Fri, 26 Apr 2019 00:23:55 +0000 (00:23 +0000)]
Make sure sockets file descriptors are in the correct range
https://bugs.webkit.org/show_bug.cgi?id=197301
<rdar://problem/48389381>

Reviewed by Chris Dumez.

* Source/webrtc/rtc_base/physicalsocketserver.cc:
* WebKit/0001-fix-197301.patch: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agowebkitpy: Including skipped tests in the final count
jbedard@apple.com [Fri, 26 Apr 2019 00:17:34 +0000 (00:17 +0000)]
webkitpy: Including skipped tests in the final count
https://bugs.webkit.org/show_bug.cgi?id=197298
<rdar://problem/49705424>

Reviewed by Lucas Forschler.

* Scripts/webkitpy/layout_tests/views/buildbot_results.py:
(BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoTrying to load a main resource outside the sandbox should not crash the WebContent...
cdumez@apple.com [Fri, 26 Apr 2019 00:17:23 +0000 (00:17 +0000)]
Trying to load a main resource outside the sandbox should not crash the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=197299
<rdar://problem/49808042>

Reviewed by Geoffrey Garen.

Trying to load a main resource outside the sandbox should not crash the WebContent process. We should
simply ignore the load and log an error message.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago[Win] Add flag to enable version information stamping and disable by default.
Basuke.Suzuki@sony.com [Thu, 25 Apr 2019 23:08:09 +0000 (23:08 +0000)]
[Win] Add flag to enable version information stamping and disable by default.
https://bugs.webkit.org/show_bug.cgi?id=197249

Reviewed by Ross Kirsling.

This feature is only used in AppleWin port. Add flag for this task and make it OFF by default.
Then enable it by default on AppleWin.

.:

* Source/cmake/OptionsWin.cmake:

Source/JavaScriptCore:

* CMakeLists.txt:

Source/WebKitLegacy:

* PlatformWin.cmake:

Source/WTF:

* wtf/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoDumpRenderTree doesn't call Internals::resetToConsistentState() before the first...
simon.fraser@apple.com [Thu, 25 Apr 2019 22:41:59 +0000 (22:41 +0000)]
DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
https://bugs.webkit.org/show_bug.cgi?id=197273

Reviewed by Dean Jackson.

Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
so that WebCoreTestSupport::resetInternalsObject() is always run.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
(runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoOnly send a synthetic mouse out event if synthetic mouse move events were sent.
timothy@apple.com [Thu, 25 Apr 2019 22:09:27 +0000 (22:09 +0000)]
Only send a synthetic mouse out event if synthetic mouse move events were sent.
https://bugs.webkit.org/show_bug.cgi?id=197295
rdar://problem/49040233

Reviewed by Zalan Bujtas.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::completeSyntheticClick):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago[bmalloc] Follow-up and fixing bug after r244481
ysuzuki@apple.com [Thu, 25 Apr 2019 21:52:59 +0000 (21:52 +0000)]
[bmalloc] Follow-up and fixing bug after r244481
https://bugs.webkit.org/show_bug.cgi?id=197294

Reviewed by Saam Barati.

This patch includes follow-up after r244481 and bug fixes which is introduced in the refactoring.

* bmalloc/IsoAllocator.h: Remove unused function.
* bmalloc/IsoAllocatorInlines.h:
(bmalloc::IsoAllocator<Config>::allocateSlow):
* bmalloc/IsoDeallocatorInlines.h:
(bmalloc::IsoDeallocator<Config>::deallocate):
* bmalloc/IsoHeapImpl.h: Rename m_usableBits to m_availableShared and add static_assert.
* bmalloc/IsoHeapImplInlines.h: Do not clear m_numberOfAllocationsFromSharedInOneCycle etc. in scavenge since IsoHeapImpl::scavenge
is not related to thread-local IsoAllocator's status.
(bmalloc::IsoHeapImpl<Config>::scavenge):
(bmalloc::IsoHeapImpl<Config>::forEachLiveObject):
(bmalloc::IsoHeapImpl<Config>::updateAllocationMode): Update m_allocationMode correctly.
(bmalloc::IsoHeapImpl<Config>::allocateFromShared):
* bmalloc/IsoSharedHeapInlines.h:
(bmalloc::computeObjectSizeForSharedCell):
(bmalloc::IsoSharedHeap::allocateNew):
(bmalloc::IsoSharedHeap::allocateSlow): Add computeObjectSizeForSharedCell.
* bmalloc/IsoSharedPage.h:
* bmalloc/IsoSharedPageInlines.h:
(bmalloc::IsoSharedPage::free): Pass `const std::lock_guard<Mutex>&` in its parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoDisable ContentChangeObserver on iOSMac.
timothy@apple.com [Thu, 25 Apr 2019 21:42:50 +0000 (21:42 +0000)]
Disable ContentChangeObserver on iOSMac.
https://bugs.webkit.org/show_bug.cgi?id=197292
rdar://problem/49039957

Reviewed by Zalan Bujtas.

We don’t need to run any of ContentChangeObserver, because we have hover events on iOSMac.
Disabling it skips the synthetic mouse move events and speeds up clicks.

* page/SettingsBase.cpp:
(WebCore::SettingsBase::defaultContentChangeObserverEnabled): Return false for PLATFORM(IOSMAC).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoDisable date and time inputs on iOSMac.
timothy@apple.com [Thu, 25 Apr 2019 21:38:34 +0000 (21:38 +0000)]
Disable date and time inputs on iOSMac.
https://bugs.webkit.org/show_bug.cgi?id=197287
rdar://problem/46794376

Reviewed by Wenson Hsieh.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* platform/text/mac/LocaleMac.h:
* platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::formatDateTime):

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/FeatureDefines.h:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoFix more Windows builds after r244653
achristensen@apple.com [Thu, 25 Apr 2019 21:27:10 +0000 (21:27 +0000)]
Fix more Windows builds after r244653
https://bugs.webkit.org/show_bug.cgi?id=197131

* svg/properties/SVGAnimatedPropertyList.h:
* svg/properties/SVGProperty.h:
* svg/properties/SVGPropertyList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoFix test-webkitpy after r244653
achristensen@apple.com [Thu, 25 Apr 2019 20:08:06 +0000 (20:08 +0000)]
Fix test-webkitpy after r244653
https://bugs.webkit.org/show_bug.cgi?id=197131

* lldb/lldbWebKitTester/Configurations/Base.xcconfig:
Also use C++17.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agofast/harness/render-tree-as-text-options.html Rebaselined test for windows
sroberts@apple.com [Thu, 25 Apr 2019 19:43:06 +0000 (19:43 +0000)]
fast/harness/render-tree-as-text-options.html Rebaselined test for windows
https://bugs.webkit.org/show_bug.cgi?id=197290

Unreviewed test gardening.

* platform/win/fast/render-tree-as-text-options-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoFix more builds after r244653
achristensen@apple.com [Thu, 25 Apr 2019 19:11:59 +0000 (19:11 +0000)]
Fix more builds after r244653
https://bugs.webkit.org/show_bug.cgi?id=197131

Source/JavaScriptCore:

* b3/B3Value.h:
There is an older system with libc++ headers that don't have std::conjunction.  Just use constexpr and && instead for the one use of it in WebKit.

Source/WebCore:

* svg/properties/SVGValuePropertyList.h:
Something is preventing MSVC from seeing protected constructors from subclasses.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago-[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWeb...
pvollan@apple.com [Thu, 25 Apr 2019 19:04:46 +0000 (19:04 +0000)]
-[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
https://bugs.webkit.org/show_bug.cgi?id=196991
<rdar://problem/45507423>

Reviewed by Alex Christensen.

Source/WebCore:

Add method to get all origins with persistent credentials from credential storage.

API tests: WKWebsiteDataStore.FetchNonPersistentCredentials
           WKWebsiteDataStore.FetchPersistentCredentials

* platform/network/CredentialStorage.h:
* platform/network/mac/CredentialStorageMac.mm:
(WebCore::CredentialStorage::originsWithPersistentCredentials):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
(-[NavigationTestDelegate init]):
(-[NavigationTestDelegate waitForDidFinishNavigation]):
(-[NavigationTestDelegate webView:didFinishNavigation:]):
(-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
(TestWebKitAPI::TEST):
(TEST): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoAdd more tests for ios programmatic iframe scrolling with fixed/sticky layers
commit-queue@webkit.org [Thu, 25 Apr 2019 18:59:51 +0000 (18:59 +0000)]
Add more tests for ios programmatic iframe scrolling with fixed/sticky layers
https://bugs.webkit.org/show_bug.cgi?id=197280

This commit adds iOS tests for scrolling iframes containing fixed/sticky layers. They are
extracted from earlier experimental patches for iOS frame scrolling but failed with the
alternative patches initially landed in bug 193539 and follow-up bugs. They now pass again
on trunk, so we can finally import them.

Patch by Frederic Wang <fwang@igalia.com> on 2019-04-25
Reviewed by Darin Adler.

* fast/scrolling/ios/programmatic-scroll-iframe-010-expected.html: Added.
* fast/scrolling/ios/programmatic-scroll-iframe-010.html: Added.
* fast/scrolling/ios/programmatic-scroll-iframe-011-expected.html: Added.
* fast/scrolling/ios/programmatic-scroll-iframe-011.html: Added.
* fast/scrolling/ios/programmatic-scroll-iframe-012-expected.html: Added.
* fast/scrolling/ios/programmatic-scroll-iframe-012.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago[RemoteInspector] Fix connection and target identifier types.
Basuke.Suzuki@sony.com [Thu, 25 Apr 2019 18:54:17 +0000 (18:54 +0000)]
[RemoteInspector] Fix connection and target identifier types.
https://bugs.webkit.org/show_bug.cgi?id=197243

Reviewed by Ross Kirsling.

Give dedicated type for RemoteControllableTarget's identifier as Inspector::TargetID.

Also rename ClientID type used in Socket backend to ConnectionID because this is the identifier
socket endpoint assign to the newly created connection. The size was changed to uint32_t.
Enough size for managing connections.

* inspector/remote/RemoteConnectionToTarget.cpp:
(Inspector::RemoteConnectionToTarget::setup):
(Inspector::RemoteConnectionToTarget::close):
(Inspector::RemoteConnectionToTarget::targetIdentifier const):
* inspector/remote/RemoteConnectionToTarget.h:
* inspector/remote/RemoteControllableTarget.h:
* inspector/remote/RemoteInspector.cpp:
(Inspector::RemoteInspector::nextAvailableTargetIdentifier):
(Inspector::RemoteInspector::registerTarget):
(Inspector::RemoteInspector::unregisterTarget):
(Inspector::RemoteInspector::updateTarget):
(Inspector::RemoteInspector::setupFailed):
(Inspector::RemoteInspector::setupCompleted):
(Inspector::RemoteInspector::waitingForAutomaticInspection):
(Inspector::RemoteInspector::updateTargetListing):
* inspector/remote/RemoteInspector.h:
* inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:
(Inspector::RemoteConnectionToTarget::targetIdentifier const):
(Inspector::RemoteConnectionToTarget::setup):
(Inspector::RemoteConnectionToTarget::close):
* inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::updateAutomaticInspectionCandidate):
(Inspector::RemoteInspector::sendMessageToRemote):
(Inspector::RemoteInspector::receivedSetupMessage):
(Inspector::RemoteInspector::receivedDataMessage):
(Inspector::RemoteInspector::receivedDidCloseMessage):
(Inspector::RemoteInspector::receivedIndicateMessage):
(Inspector::RemoteInspector::receivedAutomaticInspectionRejectMessage):
* inspector/remote/glib/RemoteInspectorGlib.cpp:
(Inspector::RemoteInspector::updateAutomaticInspectionCandidate):
(Inspector::RemoteInspector::sendMessageToRemote):
(Inspector::RemoteInspector::receivedSetupMessage):
(Inspector::RemoteInspector::receivedDataMessage):
(Inspector::RemoteInspector::receivedCloseMessage):
(Inspector::RemoteInspector::setup):
(Inspector::RemoteInspector::sendMessageToTarget):
* inspector/remote/socket/RemoteInspectorConnectionClient.cpp:
(Inspector::RemoteInspectorConnectionClient::didReceiveWebInspectorEvent):
* inspector/remote/socket/RemoteInspectorConnectionClient.h:
(Inspector::RemoteInspectorConnectionClient::didAccept):
* inspector/remote/socket/RemoteInspectorMessageParser.cpp:
(Inspector::MessageParser::MessageParser):
(Inspector::MessageParser::parse):
* inspector/remote/socket/RemoteInspectorMessageParser.h:
(Inspector::MessageParser::setDidParseMessageListener):
* inspector/remote/socket/RemoteInspectorServer.cpp:
(Inspector::RemoteInspectorServer::didAccept):
(Inspector::RemoteInspectorServer::didClose):
(Inspector::RemoteInspectorServer::dispatchMap):
(Inspector::RemoteInspectorServer::sendWebInspectorEvent):
(Inspector::RemoteInspectorServer::sendCloseEvent):
(Inspector::RemoteInspectorServer::connectionClosed):
* inspector/remote/socket/RemoteInspectorServer.h:
* inspector/remote/socket/RemoteInspectorSocket.cpp:
(Inspector::RemoteInspector::didClose):
(Inspector::RemoteInspector::sendMessageToRemote):
(Inspector::RemoteInspector::setup):
(Inspector::RemoteInspector::sendMessageToTarget):
* inspector/remote/socket/RemoteInspectorSocket.h:
* inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:
(Inspector::RemoteInspectorSocketEndpoint::connectInet):
(Inspector::RemoteInspectorSocketEndpoint::isListening):
(Inspector::RemoteInspectorSocketEndpoint::workerThread):
(Inspector::RemoteInspectorSocketEndpoint::createClient):
(Inspector::RemoteInspectorSocketEndpoint::recvIfEnabled):
(Inspector::RemoteInspectorSocketEndpoint::sendIfEnabled):
(Inspector::RemoteInspectorSocketEndpoint::send):
(Inspector::RemoteInspectorSocketEndpoint::acceptInetSocketIfEnabled):
* inspector/remote/socket/RemoteInspectorSocketEndpoint.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoSource/WebCore:
achristensen@apple.com [Thu, 25 Apr 2019 18:49:20 +0000 (18:49 +0000)]
Source/WebCore:
Fix MSVC build after r244653
https://bugs.webkit.org/show_bug.cgi?id=197131

* svg/properties/SVGValueProperty.h:
MSVC doesn't think it can access these protected constructors from subclasses.
Make the build work and investigate this later.

Source/WTF:
Fix High Sierra build after r244653
https://bugs.webkit.org/show_bug.cgi?id=197131

* wtf/StdLibExtras.h:
High Sierra thinks __cplusplus is 201406 even when using C++17.
Removing the __cplusplus check resolves the build failure on High Sierra.
We can clean up StdLibExtras more later.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoREGRESSION (243388): WebProcess::shouldFreezeOnSuspension() decision is flipped
beidson@apple.com [Thu, 25 Apr 2019 18:49:00 +0000 (18:49 +0000)]
REGRESSION (243388): WebProcess::shouldFreezeOnSuspension() decision is flipped
<rdar://problem/49755494> and https://bugs.webkit.org/show_bug.cgi?id=197284

Reviewed by Chris Dumez.

* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::shouldFreezeOnSuspension const): If any non-suspended pages are in the process it should
  be eligible. Only if all pages are suspended should it be jetsam-able.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoRevert some code accidentally committed with r244653
achristensen@apple.com [Thu, 25 Apr 2019 18:15:47 +0000 (18:15 +0000)]
Revert some code accidentally committed with r244653
https://bugs.webkit.org/show_bug.cgi?id=197131

* TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoStart using C++17
achristensen@apple.com [Thu, 25 Apr 2019 17:41:29 +0000 (17:41 +0000)]
Start using C++17
https://bugs.webkit.org/show_bug.cgi?id=197131

.:

Reviewed by Darin Adler.

* Source/cmake/OptionsMSVC.cmake:
* Source/cmake/WebKitCompilerFlags.cmake:

Source/bmalloc:

Reviewed by Darin Adler.

* Configurations/Base.xcconfig:

Source/JavaScriptCore:

Reviewed by Darin Alder.

* Configurations/Base.xcconfig:

Source/ThirdParty:

Reviewed by Darin Adler.

* gtest/xcode/Config/General.xcconfig:

Source/ThirdParty/ANGLE:

Reviewed by Darin Adler.

* Configurations/Base.xcconfig:

Source/ThirdParty/libwebrtc:

Reviewed by Darin Adler.

* Configurations/Base.xcconfig:

Source/WebCore:

Reviewed by Darin Adler.

* Configurations/Base.xcconfig:
* DerivedSources.make:

Source/WebCore/PAL:

Reviewed by Darin Adler.

* Configurations/Base.xcconfig:

Source/WebInspectorUI:

Reviewed by Darin Adler.

* Configurations/Base.xcconfig:

Source/WebKit:

Reviewed by Darin Adler.

* Configurations/Base.xcconfig:
* DerivedSources.make:

Source/WebKitLegacy/mac:

Reviewed by Darin Adler.

* Configurations/Base.xcconfig:

Source/WTF:

Reviewed by Darin Adler.

* Configurations/Base.xcconfig:
* wtf/CMakeLists.txt:
* wtf/Variant.h:
(WTF::switchOn):

Tools:

Reviewed by Darin Adler.

* DumpRenderTree/mac/Configurations/Base.xcconfig:
* MiniBrowser/Configurations/Base.xcconfig:
* MobileMiniBrowser/Configurations/Base.xcconfig:
* TestWebKitAPI/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoRemove DeprecatedOptional
achristensen@apple.com [Thu, 25 Apr 2019 17:36:58 +0000 (17:36 +0000)]
Remove DeprecatedOptional
https://bugs.webkit.org/show_bug.cgi?id=197161

Reviewed by Darin Adler.

Source/JavaScriptCore:

We need to keep a symbol exported from JavaScriptCore for binary compatibility with iOS12.
We need this symbol to be in a file that doesn't include anything because libcxx's implementation of
std::optional is actually std::__1::optional, which has a different mangled name.  This change will
prevent protocol errors from being reported if you are running the iOS12 simulator with a custom build of WebKit
and using the web inspector with it, but it's necessary to allow us to start using C++17 in WebKit.

* JavaScriptCore.xcodeproj/project.pbxproj:
* inspector/InspectorBackendDispatcher.cpp:
* inspector/InspectorBackendDispatcher.h:
* inspector/InspectorBackendDispatcherCompatibility.cpp: Added.
(Inspector::BackendDispatcher::reportProtocolError):
* inspector/InspectorBackendDispatcherCompatibility.h: Added.

Source/WTF:

* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/DeprecatedOptional.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoimported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflo...
sroberts@apple.com [Thu, 25 Apr 2019 17:24:34 +0000 (17:24 +0000)]
imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=197286

Unreviewed test gardening

* platform/mac-wk2/TestExpectations: Updating test expectations for flaky failure

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agohttp/wpt/resource-timing/rt-resources-per-frame.html is a flaky failure
sroberts@apple.com [Thu, 25 Apr 2019 17:06:02 +0000 (17:06 +0000)]
http/wpt/resource-timing/rt-resources-per-frame.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=197207

Unreviewed test gardening.

* platform/ios-simulator-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations: Updating test expectations for flaky failure

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago[GTK] Back/Forward gesture interferes with scrolling
commit-queue@webkit.org [Thu, 25 Apr 2019 16:59:04 +0000 (16:59 +0000)]
[GTK] Back/Forward gesture interferes with scrolling
https://bugs.webkit.org/show_bug.cgi?id=197168

Patch by Alexander Mikhaylenko <exalm7659@gmail.com> on 2019-04-25
Reviewed by Michael Catanzaro.

When the gesture is released with 0 velocity close to an edge of the webview,
the finishing animation is way too long, and in some cases it can look like the
gesture is already over, when it's still animating. By scrolling vertically while
that happens, it's possible to reset animation over and over again.

To reduce the duration in this case, instead of using maximum possible duration
(400ms), introduce a base velocity and use it for calculating the duration if
the actual velocity, relative to the end point, is equal to or less than 0.

* UIProcess/gtk/ViewGestureControllerGtk.cpp:
(WebKit::ViewGestureController::SwipeProgressTracker::startAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago[GTK] Back/forward gesture snapshot always times out
commit-queue@webkit.org [Thu, 25 Apr 2019 16:58:09 +0000 (16:58 +0000)]
[GTK] Back/forward gesture snapshot always times out
https://bugs.webkit.org/show_bug.cgi?id=197233

Patch by Alexander Mikhaylenko <exalm7659@gmail.com> on 2019-04-25
Reviewed by Michael Catanzaro.

Delaying web process launch caused a regression where we create ViewGestureController when the
web process doesn't yet exist. The controller immediately tries to connect to it and fails,
and because of that never receives DidHitRenderTreeSizeThreshold() message, so navigation
snapshot always stays until timeout after performing the gesture.

To prevent this, create the controller in webkitWebViewBaseDidRelaunchWebProcess() instead of
webkitWebViewBaseCreateWebPage(). Additionally, since settings are now created earlier than
ViewGestureController, store the value of whether swipe gesture is enabled in WebKitWebViewBase
and immediately apply it when creating the controller.

* UIProcess/API/glib/WebKitWebView.cpp:
(enableBackForwardNavigationGesturesChanged):
Move the logic into webkitWebViewBaseSetEnableBackForwardNavigationGesture().
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseSetEnableBackForwardNavigationGesture): Added. In addition to what was in
WebKitWebViewBase::enableBackForwardNavigationGesturesChanged(), store the value in a field
for the case ViewGestureController doesn't exist yet.
(webkitWebViewBaseCreateWebPage): Stop creating ViewGestureController.
(webkitWebViewBaseDidRelaunchWebProcess): Move creating ViewGestureController here. Also
immediately call setSwipeGestureEnabled() with the stored value.
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agohttp/tests/resourceLoadStatistics/prune-statistics.html is a flaky failure on Debug...
sroberts@apple.com [Thu, 25 Apr 2019 16:48:39 +0000 (16:48 +0000)]
http/tests/resourceLoadStatistics/prune-statistics.html is a flaky failure on Debug testers
https://bugs.webkit.org/show_bug.cgi?id=197285#add_comment

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations: Updating expectations for flaky failure

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agofast/css-custom-paint/animate-repaint.html is a flaky failure
sroberts@apple.com [Thu, 25 Apr 2019 16:29:02 +0000 (16:29 +0000)]
fast/css-custom-paint/animate-repaint.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=197283

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations: Updating expectations for flaky failure

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago[Mac iOS WK2] Layout Test http/wpt/cache-storage/cache-quota-after-restart.any.html...
youenn@apple.com [Thu, 25 Apr 2019 15:50:18 +0000 (15:50 +0000)]
[Mac iOS WK2] Layout Test http/wpt/cache-storage/cache-quota-after-restart.any.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=197040
<rdar://problem/49997641>

Reviewed by Antti Koivisto.

Delay write operations in case synchronize is ongoing.
This is restricted to AvoidRandomness mode which is always used by CacheAPI
and is also used by network cache for layout tests.

Tested by cache-quota-after-restart.any.html no longer exhibiting write disk errors.

* NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::synchronize):
(WebKit::NetworkCache::Storage::store):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoUnreviewed, rolling out r244627.
commit-queue@webkit.org [Thu, 25 Apr 2019 15:43:22 +0000 (15:43 +0000)]
Unreviewed, rolling out r244627.
https://bugs.webkit.org/show_bug.cgi?id=197282

Causing internal build failures (Requested by ShawnRoberts on
#webkit).

Reverted changeset:

"Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
https://bugs.webkit.org/show_bug.cgi?id=197171
https://trac.webkit.org/changeset/244627

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoredefinition of enumerator 'NSAttachmentCharacter' with Apple internal build
antti@apple.com [Thu, 25 Apr 2019 11:29:14 +0000 (11:29 +0000)]
redefinition of enumerator 'NSAttachmentCharacter' with Apple internal build
https://bugs.webkit.org/show_bug.cgi?id=197279

Reviewed by Antoine Quint.

Try to fix the build.

* platform/mac/WebNSAttributedStringExtras.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoVisited link hash should be computed only once
antti@apple.com [Thu, 25 Apr 2019 09:55:38 +0000 (09:55 +0000)]
Visited link hash should be computed only once
https://bugs.webkit.org/show_bug.cgi?id=197229
<rdar://problem/48438924>

Reviewed by Alex Christensen.

Source/WebCore:

Test: fast/history/visited-href-mutation.html

Visited link style is now based on the first target URL of the link element. Further href mutations don't affect styling.

* dom/Document.cpp:
(WebCore::Document::updateBaseURL):
* dom/VisitedLinkState.cpp:
(WebCore::linkAttribute):
(WebCore::linkHashForElement):

Visited link support is now limited to HTML and SVG <a> elements.

(WebCore::VisitedLinkState::invalidateStyleForLink):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::HTMLAnchorElement):
(WebCore::HTMLAnchorElement::parseAttribute):
* html/HTMLAnchorElement.h:
(WebCore::HTMLAnchorElement::visitedLinkHash const):
(WebCore::HTMLAnchorElement::invalidateCachedVisitedLinkHash): Deleted.
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::visitedLinkHash const):
* svg/SVGAElement.h:

LayoutTests:

* fast/history/visited-href-mutation-expected.html: Added.
* fast/history/visited-href-mutation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago[GStreamer] gst_element_get_state: assertion 'GST_IS_ELEMENT (element)' failed in...
philn@webkit.org [Thu, 25 Apr 2019 07:52:36 +0000 (07:52 +0000)]
[GStreamer] gst_element_get_state: assertion 'GST_IS_ELEMENT (element)' failed in WebCore::MediaPlayerPrivateGStreamer::paused
https://bugs.webkit.org/show_bug.cgi?id=196691

Reviewed by Eric Carlson.

Source/WebCore:

For gif assets, fail media loading early and notify the
MediaPlayer by setting both network and ready states, so that the
MediaPlayer will try with with the next media engine or pass the
error to HTMLMediaElement if there are none.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::loadFull):
(WebCore::MediaPlayerPrivateGStreamer::loadingFailed):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

LayoutTests:

Unflag test no longer crashing.

* platform/gtk/TestExpectations:
* platform/gtk/fast/replaced/border-radius-clip-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago[REGRESSION(r243197)][GStreamer] http/tests/media/clearkey/collect-webkit-media-sessi...
philn@webkit.org [Thu, 25 Apr 2019 07:47:25 +0000 (07:47 +0000)]
[REGRESSION(r243197)][GStreamer] http/tests/media/clearkey/collect-webkit-media-session.html hits an ASSERT
https://bugs.webkit.org/show_bug.cgi?id=197230

Reviewed by Xabier Rodriguez-Calvar.

Perform the resource loader disposal and destruction from the main
thread. Also ensure there's no circular reference between the
CachedResourceStreamingClient and WebKitWebSrc when disposing of
the private WebKitWebSrc storage.

* platform/graphics/gstreamer/MainThreadNotifier.h:
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(_WebKitWebSrcPrivate::~_WebKitWebSrcPrivate):
(webkit_web_src_class_init):
(webKitWebSrcDispose):
(webKitWebSrcCloseSession):
(webKitWebSrcFinalize): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago[GTK] Hardcoded text color in input fields
carlosgc@webkit.org [Thu, 25 Apr 2019 05:51:01 +0000 (05:51 +0000)]
[GTK] Hardcoded text color in input fields
https://bugs.webkit.org/show_bug.cgi?id=126907

Reviewed by Michael Catanzaro.

.:

Set and expose to build HAVE_OS_DARK_MODE_SUPPORT=1.

* Source/cmake/OptionsGTK.cmake:

Source/WebCore:

Enable HAVE_OS_DARK_MODE_SUPPORT for GTK port to ensure that dark mode is used when Page::useDarkAppearance()
returns true. This patch reverts r232913, I'll reopen the bug, I think we need to find a better solution for
that.

* CMakeLists.txt: Add HAVE_OS_DARK_MODE_SUPPORT to FEATURE_DEFINES_WITH_SPACE_SEPARATOR if enabled.
* css/CSSDefaultStyleSheets.cpp: Ensure html{color:text} is used in simple style sheet when
HAVE_OS_DARK_MODE_SUPPORT is enabled.
* page/FrameView.cpp:
(WebCore::FrameView::updateBackgroundRecursively): Use CSSValueWindowframe to get the frame view background
color when HAVE_OS_DARK_MODE_SUPPORT is enabled for non-mac ports.
* platform/gtk/RenderThemeWidget.cpp:
(WebCore::RenderThemeWidget::getOrCreate): Create window widget.
(WebCore::RenderThemeWindow::RenderThemeWindow): Add window widget.
* platform/gtk/RenderThemeWidget.h:
* rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::disabledTextColor const): Always use the color from the theme for consistency with
other form controls.
(WebCore::RenderThemeGtk::systemColor const): Get the color from the theme for CSSValueText, CSSValueGraytext
and CSSValueWindowframe.
* rendering/RenderThemeGtk.h:

Source/WebKit:

Implement PageClient::effectiveAppearanceIsDark() for GTK port.

* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::effectiveAppearanceIsDark const): Check if gtk-application-prefer-dark-theme setting is
enabled, or the theme name contains the -dark suffix or the GTK_THEME environment variable contains the :dark suffix.
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(themeChanged): Notify the WebPageProxy that the theme has changed.
(webkitWebViewBaseSetToplevelOnScreenWindow): Connect to notify::gtk-application-prefer-dark-theme and notify::gtk-theme-name.
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::setUseDarkAppearance): Set gtk-application-prefer-dark-theme setting accordingly.

Source/WTF:

Define HAVE_OS_DARK_MODE_SUPPORT for GTK port.

* wtf/Platform.h:

Tools:

Add dark-mode command line option to MiniBrowser.

* MiniBrowser/gtk/main.c:
(main):

LayoutTests:

Remove expectations for tests that are passing again.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoUnreviewed, fix typo in r244481
ysuzuki@apple.com [Thu, 25 Apr 2019 05:09:59 +0000 (05:09 +0000)]
Unreviewed, fix typo in r244481
https://bugs.webkit.org/show_bug.cgi?id=196837

* bmalloc/IsoHeapImplInlines.h:
(bmalloc::IsoHeapImpl<Config>::allocateFromShared):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoRegression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
zalan@apple.com [Thu, 25 Apr 2019 02:17:50 +0000 (02:17 +0000)]
Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
https://bugs.webkit.org/show_bug.cgi?id=196948
<rdar://problem/49927131>

Reviewed by Tim Horton.

Source/WebCore:

Covered by existing tests.

* loader/EmptyClients.h:
* page/ChromeClient.h:
* page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):
(WebCore::FrameView::enableAutoSizeMode):
* page/FrameView.h:

Source/WebKit:

Move intrinsicContentSizeDidChange out of DrawingArea. Intrinsic content size is a layout concept and
after r244291 there's no reason to have it in DrawingArea.

* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::didUpdateGeometry):
(WebKit::DrawingAreaProxy::intrinsicContentSizeDidChange): Deleted.
* UIProcess/DrawingAreaProxy.messages.in:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeIntrinsicContentSize):
(WebKit::WebPageProxy::setViewLayoutSize):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::intrinsicContentSizeDidChange): Deleted.
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::intrinsicContentSizeDidChange): Deleted.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::intrinsicContentsSizeChanged const):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updateIntrinsicContentSizeIfNeeded):
(WebKit::WebPage::dispatchDidReachLayoutMilestone):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::updateIntrinsicContentSizeIfNeeded): Deleted.

Source/WebKitLegacy/mac:

* WebCoreSupport/WebChromeClient.h:

Source/WebKitLegacy/win:

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::intrinsicContentsSizeChanged const):
* WebCoreSupport/WebChromeClient.h:

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
(TEST):
The expected order of incoming events is
1. didInvalidateIntrinsicContentSize
2. didFirstLayout
At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
(and remember, all we care about is ordering).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoDo not restart WebRTC stats timer if backend is stopped
youenn@apple.com [Thu, 25 Apr 2019 01:11:00 +0000 (01:11 +0000)]
Do not restart WebRTC stats timer if backend is stopped
https://bugs.webkit.org/show_bug.cgi?id=197257
<rdar://problem/50095879>

Reviewed by Eric Carlson.

We used to stop and reschedule the stat gathering timer in case the
gathering delay is changing. Timer should not be rescheduled if the backend is stopped.

* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoFlaky crash under WebCore::AXObjectCache::stopCachingComputedObjectAttributes()
commit-queue@webkit.org [Thu, 25 Apr 2019 00:49:08 +0000 (00:49 +0000)]
Flaky crash under WebCore::AXObjectCache::stopCachingComputedObjectAttributes()
https://bugs.webkit.org/show_bug.cgi?id=187391
<rdar://problem/40681396

Check for null value returned by AccessibilityObject::axObjectCache.

Patch by Andres Gonzalez <andresg_22@apple.com> on 2019-04-24
Reviewed by Chris Fleizach.

No need for new test since existing tests caught this problem.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::firstChild const):
(WebCore::AccessibilityNodeObject::lastChild const):
(WebCore::AccessibilityNodeObject::previousSibling const):
(WebCore::AccessibilityNodeObject::nextSibling const):
(WebCore::AccessibilityNodeObject::addChildren):
(WebCore::AccessibilityNodeObject::anchorElement const):
(WebCore::AccessibilityNodeObject::changeValueByStep):
(WebCore::AccessibilityNodeObject::changeValueByPercent):
(WebCore::AccessibilityNodeObject::textForLabelElement const):
(WebCore::AccessibilityNodeObject::titleElementText const):
(WebCore::AccessibilityNodeObject::alternativeText const):
(WebCore::AccessibilityNodeObject::ariaLabeledByText const):
(WebCore::AccessibilityNodeObject::helpText const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoREGRESSION (r242132): Nested position:sticky elements move incorrectly
simon.fraser@apple.com [Thu, 25 Apr 2019 00:46:23 +0000 (00:46 +0000)]
REGRESSION (r242132): Nested position:sticky elements move incorrectly
https://bugs.webkit.org/show_bug.cgi?id=197255
rdar://problem/50137744

Reviewed by Zalan Bujtas.
Source/WebCore:

Revert to the behavior of the code before r242132, where we looked at the direct parent
scrolling tree node instead of walking up the ancestor chain to find an enclosing scrolling node.
This fixes nested sticky behavior.

Test: scrollingcoordinator/mac/nested-sticky.html

* page/scrolling/cocoa/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::applyLayerPositions):

LayoutTests:

* scrollingcoordinator/mac/nested-sticky-expected.html: Added.
* scrollingcoordinator/mac/nested-sticky.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoUnreviewed GTK test gardening
aboya@igalia.com [Thu, 25 Apr 2019 00:14:51 +0000 (00:14 +0000)]
Unreviewed GTK test gardening
https://bugs.webkit.org/show_bug.cgi?id=197261

* platform/gtk/TestExpectations:
* platform/gtk/http/tests/inspector/network/har/har-page-expected.txt:
* platform/gtk/imported/blink/media/track/media-element-move-to-new-document-assert-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoUnreviewed, rolling out r244228.
commit-queue@webkit.org [Thu, 25 Apr 2019 00:03:10 +0000 (00:03 +0000)]
Unreviewed, rolling out r244228.
https://bugs.webkit.org/show_bug.cgi?id=197262

Causes compat issues (Requested by smfr on #webkit).

Reverted changeset:

"Unreviewed test gardening for Windows."
https://trac.webkit.org/changeset/244228

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoCreate AVFoundationSoftLink.{h,mm} to reduce duplicate code
eric.carlson@apple.com [Wed, 24 Apr 2019 23:56:07 +0000 (23:56 +0000)]
Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
https://bugs.webkit.org/show_bug.cgi?id=197171
<rdar://problem/47454979>

Reviewed by Youenn Fablet.

Source/WebCore:

Tests: TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm

* Modules/plugins/QuickTimePluginReplacement.mm:
(WebCore::jsValueWithValueInContext):
(WebCore::jsValueWithAVMetadataItemInContext):
* WebCore.xcodeproj/project.pbxproj:
* platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::setCategory):
(WebCore::AudioSession::category const):
(WebCore::AudioSession::routeSharingPolicy const):
(WebCore::AudioSession::routingContextUID const):
(WebCore::AudioSession::sampleRate const):
(WebCore::AudioSession::bufferSize const):
(WebCore::AudioSession::numberOfOutputChannels const):
(WebCore::AudioSession::tryToSetActiveInternal):
(WebCore::AudioSession::preferredBufferSize const):
(WebCore::AudioSession::setPreferredBufferSize):
* platform/audio/ios/MediaSessionManagerIOS.mm:
(-[WebMediaSessionHelper initWithCallback:]):
(-[WebMediaSessionHelper startMonitoringAirPlayRoutes]):
* platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
(WebCore::AVTrackPrivateAVFObjCImpl::audioKind const):
(WebCore::AVTrackPrivateAVFObjCImpl::videoKind const):
(WebCore::AVTrackPrivateAVFObjCImpl::label const):
* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::createMix):
* platform/graphics/avfoundation/MediaPlaybackTargetMac.mm:
* platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
(WebCore::MediaSelectionGroupAVFObjC::updateOptions):
* platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:
(WebCore::AVFoundationMIMETypeCache::canDecodeType):
(WebCore::AVFoundationMIMETypeCache::loadMIMETypes):
* platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsPersistableState):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsPersistentKeys):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsMediaCapability):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::initializeWithConfiguration):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::loadSession):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::ensureSession):
* platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
(WebCore::CDMSessionAVContentKeySession::isAvailable):
(WebCore::CDMSessionAVContentKeySession::releaseKeys):
(WebCore::CDMSessionAVContentKeySession::update):
(WebCore::CDMSessionAVContentKeySession::generateKeyReleaseMessage):
(WebCore::CDMSessionAVContentKeySession::contentKeySession):
* platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:
* platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
(WebCore::CDMSessionAVStreamSession::releaseKeys):
(WebCore::CDMSessionAVStreamSession::update):
(WebCore::CDMSessionAVStreamSession::setStreamSession):
(WebCore::CDMSessionAVStreamSession::generateKeyReleaseMessage):
* platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
(WebCore::imageDecoderAssetOptions):
(WebCore::ImageDecoderAVFObjC::ImageDecoderAVFObjC):
(WebCore::ImageDecoderAVFObjC::firstEnabledTrack):
(WebCore::ImageDecoderAVFObjC::readSamples):
(SOFT_LINK_CONSTANT_MAY_FAIL): Deleted.
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
(WebCore::InbandTextTrackPrivateAVFObjC::label const):
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::label const):
* platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
(WebCore::MediaPlaybackTargetPickerMac::devicePicker):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::assetCacheForPath):
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCache):
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCacheForOrigins):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageGenerator):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::synchronizeTextTrackState):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::isAvailable):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
(WebCore::determineChangedTracksFromNewTracksAndOldItems):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::outputMediaDataWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForLegibleMedia):
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForAudibleMedia):
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForVisualMedia):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTextTrack):
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::wirelessPlaybackTargetType const):
(WebCore::exernalDeviceDisplayNameForPlayer):
(WebCore::metadataType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
(-[WebCoreAVFPullDelegate outputMediaDataWillChange:]):
(-[WebCoreAVFPullDelegate outputSequenceWasFlushed:]):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks): Deleted.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isAvailable):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsType):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::streamSession):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(-[WebAVSampleBufferStatusChangeListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::isAvailable):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayers):
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::enqueueSample):
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayerCocoa::layerTypeForPlatformLayer):
(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
(WebCore::PlatformCALayerCocoa::clone const):
(WebCore::PlatformCALayerCocoa::avPlayerLayer const):
* platform/graphics/cocoa/HEVCUtilitiesCocoa.mm:
(WebCore::validateHEVCParameters):
* platform/ios/PlatformSpeechSynthesizerIOS.mm:
(getAVSpeechUtteranceDefaultSpeechRate):
(getAVSpeechUtteranceMaximumSpeechRate):
(-[WebSpeechSynthesisWrapper speakUtterance:]):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(SOFT_LINK_CONSTANT): Deleted.
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerLayer init]):
(-[WebAVPlayerLayer layoutSublayers]):
(-[WebAVPlayerLayer setVideoGravity:]):
(-[WebAVPlayerLayer videoRect]):
(WebAVPlayerLayerView_startRoutingVideoToPictureInPicturePlayerLayerView):
* platform/mac/SerializedPlatformRepresentationMac.mm:
(WebCore::jsValueWithValueInContext):
(WebCore::jsValueWithAVMetadataItemInContext):
* platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
(WebCore::getAVFormatIDKeyWithFallback):
(WebCore::getAVNumberOfChannelsKeyWithFallback):
(WebCore::getAVSampleRateKeyWithFallback):
(WebCore::getAVEncoderBitRateKeyWithFallback):
(WebCore::MediaRecorderPrivateWriter::create):
(WebCore::MediaRecorderPrivateWriter::setVideoInput):
(WebCore::MediaRecorderPrivateWriter::setAudioInput):
* platform/mediastream/RealtimeVideoSource.h:
* platform/mediastream/VideoPreset.h:
* platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:
(WebCore::AVAudioSessionCaptureDeviceManager::refreshAudioCaptureDevices):
* platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm:
(-[WebCoreAudioCaptureSourceIOSListener initWithCallback:]):
(-[WebCoreAudioCaptureSourceIOSListener handleInterruption:]):
* platform/mediastream/mac/AVCaptureDeviceManager.mm:
(WebCore::deviceIsAvailable):
(WebCore::AVCaptureDeviceManager::updateCachedAVCaptureDevices):
(WebCore::AVCaptureDeviceManager::refreshCaptureDevices):
(WebCore::AVCaptureDeviceManager::isAvailable):
(WebCore::AVCaptureDeviceManager::~AVCaptureDeviceManager):
* platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoPreset::create):
(WebCore::AVVideoPreset::AVVideoPreset):
(WebCore::AVVideoCaptureSource::create):
(WebCore::AVVideoCaptureSource::AVVideoCaptureSource):
(WebCore::AVVideoCaptureSource::capabilities):
(WebCore::sensorOrientationFromVideoOutput):
(WebCore::AVVideoCaptureSource::setupSession):
(WebCore::AVVideoCaptureSource::frameDurationForFrameRate):
(WebCore::AVVideoCaptureSource::setupCaptureSession):
(WebCore::AVVideoCaptureSource::captureOutputDidOutputSampleBufferFromConnection):
(WebCore::AVVideoCaptureSource::generatePresets):
(-[WebCoreAVVideoCaptureSourceObserver addNotificationObservers]):
(-[WebCoreAVVideoCaptureSourceObserver captureOutput:didOutputSampleBuffer:fromConnection:]):

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/cocoa/AVFoundationSoftLink.h: Added.
* pal/cocoa/AVFoundationSoftLink.mm: Added.

Source/WebKit:

* Shared/ios/WebIconUtilities.mm:
(WebKit::iconForVideoFile):
* Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder<WebCore::MediaPlaybackTargetContext>::encodePlatformData):
(IPC::ArgumentCoder<WebCore::MediaPlaybackTargetContext>::decodePlatformData):
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest):
* WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:
(WebKit::PlatformCALayerRemoteCustom::clone const):

Source/WebKitLegacy/mac:

* WebView/WebVideoFullscreenController.mm:
(-[WebVideoFullscreenController setVideoElement:]):
(-[WebVideoFullscreenController windowDidExitFullscreen]):
(SOFT_LINK_CLASS): Deleted.

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoAdd SPI callbacks for before and after module execution
sbarati@apple.com [Wed, 24 Apr 2019 22:42:38 +0000 (22:42 +0000)]
Add SPI callbacks for before and after module execution
https://bugs.webkit.org/show_bug.cgi?id=197244
<rdar://problem/50180511>

Reviewed by Yusuke Suzuki.

This is helpful for clients that want to profile execution of modules
in some way. E.g, if they want to time module execution time.

* API/JSAPIGlobalObject.h:
* API/JSAPIGlobalObject.mm:
(JSC::JSAPIGlobalObject::moduleLoaderEvaluate):
* API/JSContextPrivate.h:
* API/tests/testapi.mm:
(+[JSContextFetchDelegate contextWithBlockForFetch:]):
(-[JSContextFetchDelegate willEvaluateModule:]):
(-[JSContextFetchDelegate didEvaluateModule:]):
(testFetch):
(testFetchWithTwoCycle):
(testFetchWithThreeCycle):
(testLoaderResolvesAbsoluteScriptURL):
(testLoaderRejectsNilScriptURL):
* runtime/JSModuleLoader.cpp:
(JSC::JSModuleLoader::evaluate):
(JSC::JSModuleLoader::evaluateNonVirtual):
* runtime/JSModuleLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago[macOS] Fix syscall sandbox violation
pvollan@apple.com [Wed, 24 Apr 2019 22:26:45 +0000 (22:26 +0000)]
[macOS] Fix syscall sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=197247
<rdar://problem/50026580>

Reviewed by Brent Fulgham.

A missing syscall in the sandbox of the WebContent process is causing a crash.

* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoXMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP...
beidson@apple.com [Wed, 24 Apr 2019 22:03:04 +0000 (22:03 +0000)]
XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
https://bugs.webkit.org/show_bug.cgi?id=191362

Reviewed by Alex Christensen.

Source/WebCore:

Covered by new API tests.

In 2008 some refactoring added an HTTP(S)-only restriction to copying the form body for
XHRs that POST, and it added that restriction with no explanation.

We definitely want to allow that.

Blobs are broken at this time (covered by bug 197237)

* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::sendBytesData):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
  from an XHR to a custom protocol.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoWeb Inspector: Styles: don't start property selection when pressing right mouse button
nvasilyev@apple.com [Wed, 24 Apr 2019 21:41:42 +0000 (21:41 +0000)]
Web Inspector: Styles: don't start property selection when pressing right mouse button
https://bugs.webkit.org/show_bug.cgi?id=197242
<rdar://problem/50180380>

Reviewed by Timothy Hatcher.

* UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleMouseDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoWeb Inspector: Network: importing a HAR with an active detail view shows no content
drousso@apple.com [Wed, 24 Apr 2019 21:30:51 +0000 (21:30 +0000)]
Web Inspector: Network: importing a HAR with an active detail view shows no content
https://bugs.webkit.org/show_bug.cgi?id=197223

Reviewed by Timothy Hatcher.

When hiding the detail view, we force a `layout` of the Network table, which causes the
cached row count to be set to `0`, which prevents the `reloadDataAddedToEndOnly` from
rendering anything since the `WI.Table` thinks it has no rows.

Given that all of the users of `WI.Table` are backed by an array, we don't need to cache the
number of rows since `.length` is an extremely cheap operation. In turn, this guarantees
that we are always rendering with an accurate value.

* UserInterface/Views/Table.js:
(WI.Table):
(WI.Table.prototype.get numberOfRows):
(WI.Table.prototype.reloadData):
(WI.Table.prototype._removeRows):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoAge out unconverted Ad Click Attributions after one week.
wilander@apple.com [Wed, 24 Apr 2019 21:28:42 +0000 (21:28 +0000)]
Age out unconverted Ad Click Attributions after one week.
https://bugs.webkit.org/show_bug.cgi?id=197238
<rdar://problem/50177349>

Reviewed by Chris Dumez.

Source/WebCore:

This patch adds the two functions AdClickAttribution::markAsExpired()
and AdClickAttribution::hasExpired() which make use of the existing
m_timeOfAdClick member.

Test: http/tests/adClickAttribution/expired-attributions-removed.html

* loader/AdClickAttribution.cpp:
(WebCore::AdClickAttribution::markAsExpired):
(WebCore::AdClickAttribution::hasExpired const):
* loader/AdClickAttribution.h:

Source/WebKit:

AdClickAttributionManager::storeUnconverted() and
AdClickAttributionManager::convert() now start by calling the new
AdClickAttributionManager::clearExpired() function to remove any
expired, unconverted attributions before continuing.

The rest of the patch is infrastructure to allow tests to expire
all unconverted attributions early.

* NetworkProcess/AdClickAttributionManager.cpp:
(WebKit::AdClickAttributionManager::storeUnconverted):
(WebKit::AdClickAttributionManager::convert):
(WebKit::AdClickAttributionManager::clearExpired):
(WebKit::AdClickAttributionManager::markAllUnconvertedAsExpiredForTesting):
* NetworkProcess/AdClickAttributionManager.h:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::markAdClickAttributionsAsExpiredForTesting):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::markAdClickAttributionsAsExpiredForTesting):
* NetworkProcess/NetworkSession.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageSetAdClickAttributionConversionURLForTesting):
(WKPageMarkAdClickAttributionsAsExpiredForTesting):
* UIProcess/API/C/WKPagePrivate.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::markAdClickAttributionsAsExpiredForTesting):
* UIProcess/WebPageProxy.h:

Tools:

This patch adds infrastructure to allow tests to expire all unconverted
attributions early.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

* http/tests/adClickAttribution/expired-attributions-removed-expected.txt: Added.
* http/tests/adClickAttribution/expired-attributions-removed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoFix flaky crashes in a couple of PSON API tests
cdumez@apple.com [Wed, 24 Apr 2019 21:27:46 +0000 (21:27 +0000)]
Fix flaky crashes in a couple of PSON API tests
https://bugs.webkit.org/show_bug.cgi?id=197239

Reviewed by Tim Horton.

Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].

* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoREGRESSION (iOS 12.2): CSS perspective property value can only be set correctly once
simon.fraser@apple.com [Wed, 24 Apr 2019 21:26:52 +0000 (21:26 +0000)]
REGRESSION (iOS 12.2): CSS perspective property value can only be set correctly once
https://bugs.webkit.org/show_bug.cgi?id=197105
Source/WebCore:

rdar://problem/50068230

Reviewed by Zalan Bujtas.

Make sure we trigger a geometry update when style properties change that
result in a StyleDifference::RecompositeLayer, and which are updated on layers
via RenderLayerBacking::updateGeometry().

Tests: compositing/style-change/backface-visibility-change.html
       compositing/style-change/perspective-change.html
       compositing/style-change/perspective-origin-change.html
       compositing/style-change/transform-origin-change.html
       compositing/style-change/transform-style-change.html

* rendering/RenderLayerCompositor.cpp:
(WebCore::recompositeChangeRequiresGeometryUpdate):
(WebCore::RenderLayerCompositor::layerStyleChanged):

LayoutTests:

Reviewed by Zalan Bujtas.

* compositing/style-change/backface-visibility-change-expected.html: Added.
* compositing/style-change/backface-visibility-change.html: Added.
* compositing/style-change/perspective-change-expected.html: Added.
* compositing/style-change/perspective-change.html: Added.
* compositing/style-change/perspective-origin-change-expected.html: Added.
* compositing/style-change/perspective-origin-change.html: Added.
* compositing/style-change/transform-origin-change-expected.html: Added.
* compositing/style-change/transform-origin-change.html: Added.
* compositing/style-change/transform-style-change-expected.html: Added.
* compositing/style-change/transform-style-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoVersioning.
kocsen_chung@apple.com [Wed, 24 Apr 2019 19:22:49 +0000 (19:22 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoPlumb the navigation's request when determining recommended compatibility mode
wenson_hsieh@apple.com [Wed, 24 Apr 2019 19:10:50 +0000 (19:10 +0000)]
Plumb the navigation's request when determining recommended compatibility mode
https://bugs.webkit.org/show_bug.cgi?id=197225
<rdar://problem/48389965>

Reviewed by Alex Christensen.

Adds a new argument to effectiveCompatibilityModeAfterAdjustingPolicies.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::effectiveCompatibilityModeAfterAdjustingPolicies):
* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoClean up WKActionSheetAssistant's use of LaunchServices
timothy_horton@apple.com [Wed, 24 Apr 2019 19:07:38 +0000 (19:07 +0000)]
Clean up WKActionSheetAssistant's use of LaunchServices
https://bugs.webkit.org/show_bug.cgi?id=194645
<rdar://problem/47707952>

Reviewed by Andy Estes.

Source/WebCore/PAL:

* pal/spi/cocoa/LaunchServicesSPI.h:

Source/WebKit:

* UIProcess/ios/WKActionSheetAssistant.mm:
(applicationHasAppLinkEntitlements):
(-[WKActionSheetAssistant _appendAppLinkOpenActionsForURL:actions:elementInfo:]):
(-[WKActionSheetAssistant _appendOpenActionsForURL:actions:elementInfo:]):
(appLinkForURL): Deleted.
Make this function much more early-returny and flat.
Adopt LS sync SPI instead of using a semaphore ourselves.
Adopt modern open SPI.

Source/WTF:

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoMake it possible to control the renderTreeAsText output by setting options on testRunner
simon.fraser@apple.com [Wed, 24 Apr 2019 18:25:26 +0000 (18:25 +0000)]
Make it possible to control the renderTreeAsText output by setting options on testRunner
https://bugs.webkit.org/show_bug.cgi?id=197133

Reviewed by Sam Weinig.

Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
that make sense in testing (those that don't dump unstable data like addresses), and plumb
these flags through the various framework layers.

Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.

Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
and hand-code DumpRenderTree bindings.

Some cleanup of the TestRunners, using member initializers.

Source/WebCore:

Test: fast/harness/render-tree-as-text-options.html

* rendering/RenderLayer.cpp:
(WebCore::showLayerTree):
* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeDebugInfo):
(WebCore::write):
(WebCore::writeLayer):
(WebCore::writeLayerRenderers):
(WebCore::writeLayers):
(WebCore::externalRepresentation):
* rendering/RenderTreeAsText.h:
(WebCore::externalRepresentation):
(WebCore::write):
(WebCore::writeDebugInfo):
(): Deleted.
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writePositionAndStyle):
(WebCore::writeStandardPrefix):
(WebCore::writeChildren):
(WebCore::writeSVGResourceContainer):
(WebCore::writeSVGContainer):
(WebCore::write):
(WebCore::writeSVGText):
(WebCore::writeSVGInlineText):
(WebCore::writeSVGImage):
(WebCore::writeSVGGradientStop):
(WebCore::writeResources):
* rendering/svg/SVGRenderTreeAsText.h:

Source/WebKit:

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCopyRenderTreeExternalRepresentation):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::toRenderAsTextFlags):
(WebKit::WebPage::renderTreeExternalRepresentation const):
(WebKit::WebPage::renderTreeExternalRepresentationForPrinting const):
* WebProcess/WebPage/WebPage.h:

Source/WebKitLegacy/mac:

* Misc/WebCoreStatistics.h:
* Misc/WebCoreStatistics.mm:
(-[WebFrame renderTreeAsExternalRepresentationForPrinting]):
(toRenderAsTextFlags):
(-[WebFrame renderTreeAsExternalRepresentationWithOptions:]):
(-[WebFrame renderTreeAsExternalRepresentationForPrinting:]): Deleted.

Source/WebKitLegacy/win:

* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:
(toRenderAsTextFlags):
(WebFrame::renderTreeAsExternalRepresentation):
(WebFrame::renderTreeAsExternalRepresentationForPrinting):
* WebFrame.h:

Tools:

* DumpRenderTree/TestRunner.cpp:
(TestRunner::TestRunner):
(setRenderTreeDumpOptionsCallback):
(TestRunner::staticFunctions):
(TestRunner::setRenderTreeDumpOptions):
* DumpRenderTree/TestRunner.h:
(TestRunner::renderTreeDumpOptions const):
* DumpRenderTree/mac/DumpRenderTree.mm:
(dump):
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::TestRunner):
(WTR::TestRunner::setRenderTreeDumpOptions):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(WTR::TestRunner::renderTreeDumpOptions const):

LayoutTests:

* fast/harness/render-tree-as-text-options-expected.txt: Added.
* fast/harness/render-tree-as-text-options.html: Added.
* resources/testrunner-constants.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago[iOS] Calling preventDefault() when handling a pointerdown event should not prevent...
graouts@webkit.org [Wed, 24 Apr 2019 18:00:11 +0000 (18:00 +0000)]
[iOS] Calling preventDefault() when handling a pointerdown event should not prevent panning, zooming or click event dispatch
https://bugs.webkit.org/show_bug.cgi?id=195839
<rdar://problem/48946154>

Reviewed by Brent Fulgham.

Source/WebCore:

Tests: pointerevents/ios/pointer-events-prevent-default-allows-click-event.html
       pointerevents/ios/pointer-events-prevent-default-allows-scrolling.html

The Pointer Events specification defines that the default action of any and all pointer events MUST NOT
be a manipulation of the viewport (e.g. panning or zooming). In practice, this means that calling
preventDefault() while handling a Pointer Event has no effect on the inner workings of the user agent,
so we change the method signature of PointerCaptureController::dispatchEventForTouchAtIndex() to return
void since we don't need to know whether preventDefault() was called.

https://www.w3.org/TR/pointerevents/#declaring-candidate-regions-for-default-touch-behaviors

* page/PointerCaptureController.cpp:
(WebCore::PointerCaptureController::dispatchEventForTouchAtIndex):
* page/PointerCaptureController.h:

LayoutTests:

Modify the existing test to check that we *have* scrolled after performing a swipe gesture and calling
preventDefault() while handling the pointerdown handling. We also add a new test that checks that the
click event is indeed dispatched when tapping on an element and calling preventDefault() while handling
the pointerdown event.

* pointerevents/ios/pointer-events-prevent-default-allows-click-event-expected.txt: Added.
* pointerevents/ios/pointer-events-prevent-default-allows-click-event.html: Added.
* pointerevents/ios/pointer-events-prevent-default-allows-scrolling-expected.txt: Added.
* pointerevents/ios/pointer-events-prevent-default-allows-scrolling.html: Renamed from LayoutTests/pointerevents/ios/pointer-events-prevent-default.html.
* pointerevents/ios/pointer-events-prevent-default-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoWKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
achristensen@apple.com [Wed, 24 Apr 2019 17:46:28 +0000 (17:46 +0000)]
WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
https://bugs.webkit.org/show_bug.cgi?id=197078
<rdar://problem/49564348>

Reviewed by Geoff Garen.

Source/WebKit:

r242735 was a fix for crashes when using mmap'd memory in apps with default FileProtection of NSFileProtectionComplete.
It is more memory efficient and just as secure to reduce the FileProtection of these files to NSFileProtectionCompleteUnlessOpen.

* NetworkProcess/cache/NetworkCacheFileSystem.cpp:
(WebKit::NetworkCache::isSafeToUseMemoryMapForPath):
(WebKit::NetworkCache::makeSafeToUseMemoryMapForPath):
(WebKit::NetworkCache::pathRegisteredAsUnsafeToMemoryMapForTesting): Deleted.
(WebKit::NetworkCache::registerPathAsUnsafeToMemoryMapForTesting): Deleted.
* NetworkProcess/cache/NetworkCacheFileSystem.h:
* NetworkProcess/cache/NetworkCacheFileSystemCocoa.mm: Added.
(WebKit::NetworkCache::isSafeToUseMemoryMapForPath):
(WebKit::NetworkCache::makeSafeToUseMemoryMapForPath):
* Shared/WebCompiledContentRuleList.cpp:
(WebKit::WebCompiledContentRuleList::conditionsApplyOnlyToDomain const):
(WebKit::WebCompiledContentRuleList::filtersWithoutConditionsBytecode const):
(WebKit::WebCompiledContentRuleList::filtersWithConditionsBytecode const):
(WebKit::WebCompiledContentRuleList::topURLFiltersBytecode const):
(WebKit::WebCompiledContentRuleList::actions const):
(WebKit::WebCompiledContentRuleList::usesCopiedMemory const): Deleted.
* Shared/WebCompiledContentRuleList.h:
* Shared/WebCompiledContentRuleListData.cpp:
(WebKit::WebCompiledContentRuleListData::encode const):
(WebKit::WebCompiledContentRuleListData::decode):
(WebKit::WebCompiledContentRuleListData::size const): Deleted.
(WebKit::WebCompiledContentRuleListData::dataPointer const): Deleted.
* Shared/WebCompiledContentRuleListData.h:
(WebKit::WebCompiledContentRuleListData::WebCompiledContentRuleListData):
* SourcesCocoa.txt:
* UIProcess/API/APIContentRuleList.cpp:
(API::ContentRuleList::usesCopiedMemory const): Deleted.
* UIProcess/API/APIContentRuleList.h:
* UIProcess/API/APIContentRuleListStore.cpp:
(API::openAndMapOrCopyContentRuleList):
(API::compiledToFile):
(API::createExtension):
(API::ContentRuleListStore::getContentRuleListSource):
(API::ContentRuleListStore::readContentsOfFile): Deleted.
(API::MappedOrCopiedData::dataPointer const): Deleted.
* UIProcess/API/APIContentRuleListStore.h:
* UIProcess/API/Cocoa/APIContentRuleListStoreCocoa.mm:
(API::ContentRuleListStore::readContentsOfFile): Deleted.
* UIProcess/API/Cocoa/WKContentRuleListStore.mm:
(+[WKContentRuleListStore _registerPathAsUnsafeToMemoryMapForTesting:]): Deleted.
* UIProcess/API/Cocoa/WKContentRuleListStorePrivate.h:
* UIProcess/API/Cocoa/_WKUserContentFilter.mm:
(-[_WKUserContentFilter usesCopiedMemory]): Deleted.
* UIProcess/API/Cocoa/_WKUserContentFilterPrivate.h:
* WebKit.xcodeproj/project.pbxproj:

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
(TEST_F):
(-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
(-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoFix build due to missing SPI declaration of kAXSFullKeyboardAccessEnabledNotification
ddkilzer@apple.com [Wed, 24 Apr 2019 17:23:33 +0000 (17:23 +0000)]
Fix build due to missing SPI declaration of kAXSFullKeyboardAccessEnabledNotification

* UIProcess/Cocoa/WKFullKeyboardAccessWatcher.mm: Import
AccessibilitySupportSPI.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoWith async scrolling enabled, this MathML test asserts
commit-queue@webkit.org [Wed, 24 Apr 2019 17:19:18 +0000 (17:19 +0000)]
With async scrolling enabled, this MathML test asserts
https://bugs.webkit.org/show_bug.cgi?id=196123

Source/WebCore:

This patch ensures that updateScrollInfoAfterLayout() is called during MathML layout. This
fixes assertions when async scrolling is enabled and MathML elements have non-visible overflow.

Patch by Frederic Wang <fwang@igalia.com> on 2019-04-24
Reviewed by Rob Buis.

Test: mathml/mathml-overflow-crash.html

* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::layoutBlock):
(WebCore::RenderMathMLBlock::layoutInvalidMarkup):
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::layoutBlock):
* rendering/mathml/RenderMathMLMath.cpp:
(WebCore::RenderMathMLMath::layoutBlock):
* rendering/mathml/RenderMathMLMenclose.cpp:
(WebCore::RenderMathMLMenclose::layoutBlock):
* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::layoutBlock):
* rendering/mathml/RenderMathMLPadded.cpp:
(WebCore::RenderMathMLPadded::layoutBlock):
* rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::layoutBlock):
* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::layoutBlock):
* rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::layoutBlock):
* rendering/mathml/RenderMathMLSpace.cpp:
(WebCore::RenderMathMLSpace::layoutBlock):
* rendering/mathml/RenderMathMLToken.cpp:
(WebCore::RenderMathMLToken::layoutBlock):
* rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::layoutBlock):

LayoutTests:

Patch by Frederic Wang <fwang@igalia.com> on 2019-04-24
Reviewed by Rob Buis.

Add a test for each MathML layoutBlock functions/classes.

* mathml/mathml-overflow-crash-expected.txt: Added.
* mathml/mathml-overflow-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoAdd unit test for r239322
achristensen@apple.com [Wed, 24 Apr 2019 17:14:47 +0000 (17:14 +0000)]
Add unit test for r239322
https://bugs.webkit.org/show_bug.cgi?id=197236

Reviewed by Chris Dumez.

I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
May as well add the test infrastructure which was needed before and will be needed in the future.

* TestWebKitAPI/TCPServer.cpp:
(TestWebKitAPI::TCPServer::TCPServer):
* TestWebKitAPI/TCPServer.h:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
(TestWebKitAPI::downloadAtRate):
* TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
(TEST):
* TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
(-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago[Mac Debug] Layout Test resize-observer/observe-element-from-other-frame.html is...
commit-queue@webkit.org [Wed, 24 Apr 2019 16:21:31 +0000 (16:21 +0000)]
[Mac Debug] Layout Test resize-observer/observe-element-from-other-frame.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=197063

Patch by Cathie Chen <cathiechen@igalia.com> on 2019-04-24
Reviewed by Ryosuke Niwa.

RenderingUpdate timer might be fired after ResizeTestHelper's. This would produce a flaky failure.
In order to reduce this failure, extend ResizeTestHelper.TIMEOUT like in bug 177484.

* resize-observer/resources/resizeTestHelper.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoRebaseline js/dom/dom-static-property-for-in-iteration.html after r244581
tsavell@apple.com [Wed, 24 Apr 2019 15:52:19 +0000 (15:52 +0000)]
Rebaseline js/dom/dom-static-property-for-in-iteration.html after r244581
https://bugs.webkit.org/show_bug.cgi?id=197218

Unreviewed test gardening.

* platform/mac-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoFix -Wc++11-narrowing on unsigned char platforms like FreeBSD/aarch64
commit-queue@webkit.org [Wed, 24 Apr 2019 15:51:39 +0000 (15:51 +0000)]
Fix -Wc++11-narrowing on unsigned char platforms like FreeBSD/aarch64
https://bugs.webkit.org/show_bug.cgi?id=197148

Patch by Greg V <greg@unrelenting.technology> on 2019-04-24
Reviewed by Alex Christensen.

* contentextensions/DFACombiner.cpp:
* contentextensions/NFAToDFA.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoURL set by document.open() is communicated with the WebPageProxy but not the WebFrame...
cdumez@apple.com [Wed, 24 Apr 2019 15:44:28 +0000 (15:44 +0000)]
URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
https://bugs.webkit.org/show_bug.cgi?id=197214
<rdar://problem/49237544>

Reviewed by Alex Christensen.

Source/WebKit:

URL set by document.open() is communicated with the WebPageProxy (since r244361) but not the
WebFrameProxy. This patch fixes this.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _mainFrameURL]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* UIProcess/FrameLoadState.cpp:
(WebKit::FrameLoadState::didExplicitOpen):
* UIProcess/FrameLoadState.h:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didExplicitOpen):
* UIProcess/WebFrameProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didExplicitOpenForFrame):

Tools:

Extend API test coverage.

* TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoX-Frame-Options header should be ignored when frame-ancestors CSP directive is present
cdumez@apple.com [Wed, 24 Apr 2019 15:43:09 +0000 (15:43 +0000)]
X-Frame-Options header should be ignored when frame-ancestors CSP directive is present
https://bugs.webkit.org/show_bug.cgi?id=197226
<rdar://problem/50155649>

Reviewed by Alex Christensen.

Source/WebCore:

X-Frame-Options header should be ignored when frame-ancestors CSP directive is present:
- https://www.w3.org/TR/CSP3/#frame-ancestors-and-frame-options

Specification says:
"""
In order to allow backwards-compatible deployment, the frame-ancestors directive _obsoletes_ the
X-Frame-Options header. If a resource is delivered with an policy that includes a directive named
frame-ancestors and whose disposition is "enforce", then the X-Frame-Options header MUST be ignored.
"""

Gecko and Blink follow the specification, WebKit does not. As a result, page [1] is broken with
WebKit-only on Schwab.com. The page height is wrong and you cannot see all the ETFs as a result.

[1] https://www.schwab.com/public/schwab/investing/investment_help/investment_research/etf_research/etfs.html?&path=/Prospect/Research/etfs/overview/oneSourceETFs.asp

Test: http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-overrides-X-Frames-Options.html

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
* page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::overridesXFrameOptions const):
* page/csp/ContentSecurityPolicy.h:
* page/csp/ContentSecurityPolicyDirectiveList.h:
(WebCore::ContentSecurityPolicyDirectiveList::hasFrameAncestorsDirective const):

Source/WebKit:

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::shouldInterruptLoadForCSPFrameAncestorsOrXFrameOptions):

LayoutTests:

Add layout test coverage.

* http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-overrides-X-Frames-Options-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-overrides-X-Frames-Options.html: Added.
* http/tests/security/contentSecurityPolicy/resources/frame-ancestors-self-x-frame-options-deny.pl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago[ContentChangeObserver] Do not use the global _WKContentChange in WebKitLegacy
zalan@apple.com [Wed, 24 Apr 2019 15:38:23 +0000 (15:38 +0000)]
[ContentChangeObserver] Do not use the global _WKContentChange in WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=196286
<rdar://problem/49364417>

Reviewed by Simon Fraser.

By reporting WKContentIndeterminateChange in sendMouseMoveEvent enables us to remove the global _WKContentChange state.
Using _WKContentChange is fine as long as only the observed frame reports content change during the synthetic click event.
In case of multiple frames, we should really consult the local state instead.
Unfortunately sendMouseMoveEvent has no access to the observed Document object so we can't really identify the observed content change.
WKContentIndeterminateChange triggers asynchronous decision making at the callsite and in the callback we have access
to the active Document/ContentChangeObverver object and can report the correct state.
This is inline with current WebKit(WK2) behaviour.

Manually tested with a WebKitLegacy test app.

* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:
* page/ios/ContentChangeObserver.h:
(WebCore::ContentChangeObserver::setHasNoChangeState):
(WebCore::ContentChangeObserver::setHasIndeterminateState):
(WebCore::ContentChangeObserver::setHasVisibleChangeState):
(WebCore::ContentChangeObserver::setObservedContentState): Deleted.
* page/ios/EventHandlerIOS.mm:
(WebCore::EventHandler::mouseMoved):
* platform/ios/wak/WAKWindow.mm:
(-[WAKWindow sendMouseMoveEvent:contentChange:]):
* platform/ios/wak/WKContentObservation.cpp: Removed.
* platform/ios/wak/WKContentObservation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago[GTK][GStreamer] Flaky ASSERTION FAILED: m_lock.isHeld() in TextureMapperPlatformLaye...
philn@webkit.org [Wed, 24 Apr 2019 14:47:33 +0000 (14:47 +0000)]
[GTK][GStreamer] Flaky ASSERTION FAILED: m_lock.isHeld() in TextureMapperPlatformLayerProxy
https://bugs.webkit.org/show_bug.cgi?id=196739

Reviewed by Xabier Rodriguez-Calvar.

The crash was triggered because m_videoDecoderPlatform not being
explicitely set, its value would be inferred as one of the enum
class values. Making it Optional avoids this issue.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoRename _highlightLongPressCanClick and only add gesture recognizer when necessary
dino@apple.com [Wed, 24 Apr 2019 12:23:20 +0000 (12:23 +0000)]
Rename _highlightLongPressCanClick and only add gesture recognizer when necessary
https://bugs.webkit.org/show_bug.cgi?id=197231
<rdar://problem/50164234>

Reviewed by Antoine Quint.

Rename _highlightLongPressCanClick to _longPressCanClick since it will be
used in other places.

Only attach the _highlightLongPressGestureRecognizer when we're not
using long presses for preview. This might revert in the future, if we
can set up an appropriate gesture resolution between the two.

* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView _webTouchEvent:preventsNativeGestures:]):
(-[WKContentView _highlightLongPressRecognized:]):
(-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]):
(-[WKContentView _presentedViewControllerForPreviewItemController:]):
(-[WKContentView _previewItemControllerDidCancelPreview:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago[Build][GStreamer] Update to 1.16.0
philn@webkit.org [Wed, 24 Apr 2019 12:18:16 +0000 (12:18 +0000)]
[Build][GStreamer] Update to 1.16.0
https://bugs.webkit.org/show_bug.cgi?id=197157

Reviewed by Xabier Rodriguez-Calvar.

The upstreamed patches were removed and a new one was added for a
regression detected in the scaletempo GStreamer element. The GNOME
Flatpak was migrated to 3.32 and I switched a few modules to Meson
on the way, as it is the preferred build system now in GStreamer
1.16.

* flatpak/files/httpd-autogen.sh:
* flatpak/flatpakutils.py:
(FlatpakPackage.install):
(WebkitFlatpak.run_in_sandbox):
* flatpak/org.webkit.CommonModules.yaml:
* flatpak/org.webkit.WebKit.yaml:
* gstreamer/jhbuild.modules:
* gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
* gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
* gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
* gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
* gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
* gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
* gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
* gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
* gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
* gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
* gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
* gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
* gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
* gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
* gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
* gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
* gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
* gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
* gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
* gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
* gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
* gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago[GStreamer] Crash in AudioTrackPrivate with playbin3 enabled
philn@webkit.org [Wed, 24 Apr 2019 12:11:50 +0000 (12:11 +0000)]
[GStreamer] Crash in AudioTrackPrivate with playbin3 enabled
https://bugs.webkit.org/show_bug.cgi?id=196913

Reviewed by Xabier Rodriguez-Calvar.

The crash was due to a playbin3 code path being triggered during
MSE playback, which is not supposed to work in playbin3 anyway.
The problem is that setting the USE_PLAYBIN3 environment variable
to "1" makes the GStreamer playback plugin register the playbin3
element under the playbin name. So that leads to playbin3 being
used everywhere in WebKit where we assume the playbin element is
used. So the proposed solution is to:

- use a WebKit-specific environment variable instead of the
GStreamer USE_PLAYBIN3 variable.
- emit a warning if the USE_PLAYBIN3 environment variable is
detected. We can't unset it ourselves for security reasons.

The patch also includes a code cleanup of the player method
handling the pipeline creation. The previous code had a bug
leading to playbin3 being used for MSE.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago[GTK] MiniBrowser: also set the passed bg-color when receiving arguments
carlosgc@webkit.org [Wed, 24 Apr 2019 07:53:58 +0000 (07:53 +0000)]
[GTK] MiniBrowser: also set the passed bg-color when receiving arguments
https://bugs.webkit.org/show_bug.cgi?id=197156

Reviewed by Michael Catanzaro.

The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
support was added.

* MiniBrowser/gtk/BrowserTab.c:
(browser_tab_set_background_color): Set the passed in color as web view background color.
* MiniBrowser/gtk/BrowserTab.h:
* MiniBrowser/gtk/BrowserWindow.c:
(browser_window_init): Initialize backgroundColor.
(browser_window_append_view): Call browser_tab_set_background_color().
(browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
are added.
* MiniBrowser/gtk/main.c:
(main): Call browser_window_set_background_color() before creating the tabs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoAX: Remove deprecated Accessibility Object Model events
cfleizach@apple.com [Wed, 24 Apr 2019 07:46:08 +0000 (07:46 +0000)]
AX: Remove deprecated Accessibility Object Model events
https://bugs.webkit.org/show_bug.cgi?id=197073
<rdar://problem/50027819>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: accessibility/mac/replace-text-with-range.html

* DerivedSources.make:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::setSelected):
* accessibility/AccessibilityMediaObject.cpp:
(WebCore::AccessibilityMediaObject::increment):
(WebCore::AccessibilityMediaObject::decrement):
* accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::setSelected):
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::increment):
(WebCore::AccessibilityNodeObject::decrement):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::press):
(WebCore::AccessibilityObject::replaceTextInRange):
(WebCore::AccessibilityObject::scrollToMakeVisible const):
(WebCore::AccessibilityObject::shouldDispatchAccessibilityEvent const): Deleted.
(WebCore::AccessibilityObject::dispatchAccessibilityEvent const): Deleted.
(WebCore::AccessibilityObject::dispatchAccessibilityEventWithType const): Deleted.
(WebCore::AccessibilityObject::dispatchAccessibleSetValueEvent const): Deleted.
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setFocused):
(WebCore::AccessibilityRenderObject::setValue):
* accessibility/AccessibilityScrollbar.cpp:
(WebCore::AccessibilityScrollbar::setValue):
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::setValue):
* accessibility/ios/AccessibilityObjectIOS.mm:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject const):
(WebCore::AccessibilityObject::hasAccessibleDismissEventListener const): Deleted.
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityPerformEscape]): Deleted.
(-[WebAccessibilityObjectWrapper accessibilityElementDidBecomeFocused]): Deleted.
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
* dom/Element.idl:
* dom/EventNames.h:
* dom/EventNames.in:
* html/HTMLAttributeNames.in:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::createEventHandlerNameMap):
* page/Settings.yaml:
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setAccessibilityEventsEnabled): Deleted.
* testing/InternalSettings.h:
* testing/InternalSettings.idl:

Source/WebKit:

* Platform/spi/ios/AccessibilitySupportSPI.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView dealloc]):
(accessibilityEventsEnabledChangedCallback): Deleted.
(-[WKWebView _updateAccessibilityEventsEnabled]): Deleted.
* UIProcess/API/Cocoa/WKWebViewInternal.h:
* UIProcess/Cocoa/WKFullKeyboardAccessWatcher.mm:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateAccessibilityEventsEnabled): Deleted.
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updateAccessibilityEventsEnabled): Deleted.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

Source/WTF:

* wtf/Platform.h:

LayoutTests:

* accessibility/mac/AOM-event-accessiblesetvalue-expected.txt: Removed.
* accessibility/mac/AOM-event-accessiblesetvalue.html: Removed.
* accessibility/mac/AOM-events-all-expected.txt: Removed.
* accessibility/mac/AOM-events-all.html: Removed.
* accessibility/mac/AOM-events-expected.txt: Removed.
* accessibility/mac/AOM-events-webarea-crash-expected.txt: Removed.
* accessibility/mac/AOM-events-webarea-crash.html: Removed.
* accessibility/mac/AOM-events.html: Removed.
* accessibility/mac/replace-text-with-range-expected.txt: Replaced.
* accessibility/mac/replace-text-with-range.html: Replaced.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoMove Ad Click Attribution from internal feature to experimental feature
wilander@apple.com [Wed, 24 Apr 2019 04:16:30 +0000 (04:16 +0000)]
Move Ad Click Attribution from internal feature to experimental feature
https://bugs.webkit.org/show_bug.cgi?id=197218
<rdar://problem/47651691>

Reviewed by Brent Fulgham.

Source/WebKit:

* Shared/WebPreferences.yaml:

Tools:

* DumpRenderTree/TestOptions.cpp:
(TestOptions::TestOptions):

LayoutTests:

This patch removes the TestRunner instruction for turning on the internal
feature.

* http/tests/adClickAttribution/anchor-tag-attributes-validation.html:
* http/tests/adClickAttribution/attribution-conversion-through-image-redirect-without-priority.html:
* http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html:
* http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html:
* http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html:
* http/tests/adClickAttribution/second-conversion-with-higher-priority.html:
* http/tests/adClickAttribution/second-conversion-with-lower-priority.html:
* http/tests/adClickAttribution/send-attribution-conversion-request.html:
* http/tests/adClickAttribution/store-ad-click-attribution.html:
* http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html:
* http/tests/contentextensions/block-ad-click-attribution.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months ago[JSC] Shrink DFG::MinifiedNode
ysuzuki@apple.com [Wed, 24 Apr 2019 04:06:08 +0000 (04:06 +0000)]
[JSC] Shrink DFG::MinifiedNode
https://bugs.webkit.org/show_bug.cgi?id=197224

Reviewed by Filip Pizlo.

Since it is kept alive with compiled DFG code, we should shrink it to save memory.
If it is effective, we should consider minimizing these OSR exit data more aggressively.

* dfg/DFGMinifiedNode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 months agoLICM incorrectly assumes it'll never insert a node which provably OSR exits
sbarati@apple.com [Wed, 24 Apr 2019 02:14:23 +0000 (02:14 +0000)]
LICM incorrectly assumes it'll never insert a node which provably OSR exits
https://bugs.webkit.org/show_bug.cgi?id=196721
<rdar://problem/49556479>

Reviewed by Filip Pizlo.

JSTests:

* stress/licm-should-handle-if-a-hoist-causes-a-provable-osr-exit.js: Added.
(foo):

Source/JavaScriptCore:

Previously, we assumed LICM could never hoist code that caused us
to provably OSR exit. This is a bad assumption, as we may very well
hoist such code. Obviously hoisting such code is not ideal. We shouldn't
hoist something we provably know will OSR exit. However, this is super rare,
and the phase is written in such a way where it's easier to gracefully
handle this case than to prevent us from hoisting such code.

If we wanted to ensure we never hoisted code that would provably exit, we'd
have to teach the phase to know when it inserted code that provably exits. I
saw two ways to do that:
1: Save and restore the AI state before actually hoisting.
2: Write an analysis that can determine if such a node would exit.

(1) is bad because it costs in memory and compile time. (2) will inevitably
have bugs as running into this condition is rare.

So instead of (1) or (2), I opted to have LICM gracefully handle when
it causes a provable exit. When we encounter this, we mark all blocks
in the loop as !cfaHasVisited and !cfaDidFinish.

* dfg/DFGLICMPhase.cpp:
(JSC::DFG::LICMPhase::attemptHoist):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[JSC] Use node index as DFG::MinifiedID
ysuzuki@apple.com [Wed, 24 Apr 2019 01:50:50 +0000 (01:50 +0000)]
[JSC] Use node index as DFG::MinifiedID
https://bugs.webkit.org/show_bug.cgi?id=197186

Reviewed by Saam Barati.

DFG Nodes can be identified with index if the graph is given. We should use unsigned index as a DFG::MinifiedID's underlying
source instead of Node* to reduce the size of VariableEvent from 16 to 12. Vector<VariableEvent> is the main data in DFG's OSR
tracking. It is kept after DFG compilation is done to make OSR work. We saw that this is allocated with large size in GMail.

* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/DataFormat.h:
* bytecode/ValueRecovery.h:
* dfg/DFGGenerationInfo.h:
* dfg/DFGMinifiedID.h:
(JSC::DFG::MinifiedID::MinifiedID):
(JSC::DFG::MinifiedID::operator! const):
(JSC::DFG::MinifiedID::operator== const):
(JSC::DFG::MinifiedID::operator!= const):
(JSC::DFG::MinifiedID::operator< const):
(JSC::DFG::MinifiedID::operator> const):
(JSC::DFG::MinifiedID::operator<= const):
(JSC::DFG::MinifiedID::operator>= const):
(JSC::DFG::MinifiedID::hash const):
(JSC::DFG::MinifiedID::dump const):
(JSC::DFG::MinifiedID::isHashTableDeletedValue const):
(JSC::DFG::MinifiedID::fromBits):
(JSC::DFG::MinifiedID::bits const):
(JSC::DFG::MinifiedID::invalidIndex):
(JSC::DFG::MinifiedID::otherInvalidIndex):
(JSC::DFG::MinifiedID::node const): Deleted.
(JSC::DFG::MinifiedID::invalidID): Deleted.
(JSC::DFG::MinifiedID::otherInvalidID): Deleted.
* dfg/DFGMinifiedIDInlines.h: Copied from Source/JavaScriptCore/dfg/DFGMinifiedNode.cpp.
(JSC::DFG::MinifiedID::MinifiedID):
* dfg/DFGMinifiedNode.cpp:
* dfg/DFGValueSource.h:
(JSC::DFG::ValueSource::ValueSource):
* dfg/DFGVariableEvent.h:
(JSC::DFG::VariableEvent::dataFormat const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoWeb Inspector: REGRESSION(r238168): Network: preserve log doesn't show main frame...
drousso@apple.com [Wed, 24 Apr 2019 01:28:49 +0000 (01:28 +0000)]
Web Inspector: REGRESSION(r238168): Network: preserve log doesn't show main frame main resource changes
https://bugs.webkit.org/show_bug.cgi?id=197220
<rdar://problem/49960464>

Reviewed by Timothy Hatcher.

* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype.reset):
(WI.NetworkTableContentView.prototype._addCollection):
(WI.NetworkTableContentView.prototype._resetCollection): Added.
(WI.NetworkTableContentView.prototype._changeCollection):
(WI.NetworkTableContentView.prototype._mainResourceDidChange):
We want to add the frame's main resource in the case that it's the main frame, but we also
want to clear the main collection of data (e.g. if viewing an imported HAR).
Drive-by: `_groupByDOMNodeNavigationItem` was renamed in a previous patch.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoWeb Inspector: Network: support drag/drop for importing
drousso@apple.com [Wed, 24 Apr 2019 01:20:32 +0000 (01:20 +0000)]
Web Inspector: Network: support drag/drop for importing
https://bugs.webkit.org/show_bug.cgi?id=197221

Reviewed by Timothy Hatcher.

* UserInterface/Views/NetworkTabContentView.js:
(WI.NetworkTabContentView.prototype.async.handleFileDrop): Added.
* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype.processHAR): Added.
(WI.NetworkTableContentView.prototype._importHAR):

* UserInterface/Base/FileUtilities.js:
(WI.FileUtilities.async readText):
Only `await` if the result is a `Promise`.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoAdd Xcode version check for Header post-processing scripts
krollin@apple.com [Wed, 24 Apr 2019 00:52:41 +0000 (00:52 +0000)]
Add Xcode version check for Header post-processing scripts
https://bugs.webkit.org/show_bug.cgi?id=197116
<rdar://problem/50058968>

Reviewed by Brent Fulgham.

There are several places in our Xcode projects that post-process
header files after they've been exported. Because of XCBuild, we're
moving to a model where the post-processing is performed at the same
time the header files are exported, rather than as a distinct
post-processing step. This patch disables the distinct step when the
inline processing is available.

In practice, this means prefixing appropriate post-processing Custom
Build phases with:

if [ "${XCODE_VERSION_MAJOR}" -ge "1100" -a "${USE_NEW_BUILD_SYSTEM}" = "YES" ]; then
    # In this configuration, post-processing is performed at the same time as copying in the postprocess-header-rule script, so there's no need for this separate step.
    exit 0
fi

Source/JavaScriptCore:

* JavaScriptCore.xcodeproj/project.pbxproj:

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:

Source/WebKitLegacy:

* WebKitLegacy.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUnreviewed, rolling out r244558.
commit-queue@webkit.org [Wed, 24 Apr 2019 00:29:55 +0000 (00:29 +0000)]
Unreviewed, rolling out r244558.
https://bugs.webkit.org/show_bug.cgi?id=197219

Causing crashes on iOS Sim Release and Debug (Requested by
ShawnRoberts on #webkit).

Reverted changeset:

"Remove DeprecatedOptional"
https://bugs.webkit.org/show_bug.cgi?id=197161
https://trac.webkit.org/changeset/244558

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[iOS] QuickLook documents loaded from file: URLs should be allowed to perform same...
aestes@apple.com [Wed, 24 Apr 2019 00:24:27 +0000 (00:24 +0000)]
[iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
https://bugs.webkit.org/show_bug.cgi?id=196749
<rdar://problem/35773454>

Reviewed by Daniel Bates.

Source/WebCore:

QuickLook previews are in a non-local origin defined by a unique x-apple-ql-id: URL, which
isolates the origin that hosted the document from the document preview itself. When a
QuickLook document is loaded as a file: URL, SecurityOrigin's protections against loading
local resources from non-local origins prevented navigations like location.reload() and
fragment navigations.

To allow reloads and same-document navigations in QuickLook documents loaded from file: URLs,
we should grant the QuickLook document's SecurityOrigin access to the file path that loaded
the preview.

Added a new API test.

* dom/Document.cpp:
(WebCore::Document::applyQuickLookSandbox):
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::createNonLocalWithAllowedFilePath):
(WebCore::SecurityOrigin::canDisplay const):
* page/SecurityOrigin.h:

Tools:

Added a new QuickLook API test and added new expectations to existing QuickLook tests.

* TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
(-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
(-[QuickLookDelegate webView:didFinishNavigation:]):
(-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
(-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
(runTest):
(runTestDecideBeforeLoading):
(runTestDecideAfterLoading):
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoRemove Ad Click Attribution data when removing website data
wilander@apple.com [Wed, 24 Apr 2019 00:13:00 +0000 (00:13 +0000)]
Remove Ad Click Attribution data when removing website data
https://bugs.webkit.org/show_bug.cgi?id=197215
<rdar://problem/47668988>

Reviewed by Chris Dumez.

Source/WebKit:

This patch adds a new WebsiteDataType called AdClickAttributions and flags
it as owned by the network process.

The new website data type is added to the Cocoa API layer for
website data records management.

When either of the two WebsiteDataStore::removeData() functions calls
NetworkProcess::deleteWebsiteData() or
NetworkProcess::deleteWebsiteDataForOrigins() over IPC, the network
process now calls into AdClickAttributionManager::clear() and
AdClickAttributionManager::clearForRegistrableDomain() respectively,
if the website datatypes include WebsiteDataType::AdClickAttributions.

The patch removes a couple of completion handlers in NetworkSession function
calls are because those are not asynchronous.

* NetworkProcess/AdClickAttributionManager.cpp:
(WebKit::AdClickAttributionManager::clear):
(WebKit::AdClickAttributionManager::clearForRegistrableDomain):
(WebKit::AdClickAttributionManager::toString const):
* NetworkProcess/AdClickAttributionManager.h:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::clearAdClickAttribution):
* NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::clearAdClickAttribution):
(WebKit::NetworkSession::clearAdClickAttributionForRegistrableDomain):
* NetworkProcess/NetworkSession.h:
* Shared/WebsiteData/WebsiteData.cpp:
(WebKit::WebsiteData::ownerProcess):
* Shared/WebsiteData/WebsiteDataType.h:
* UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreClearAdClickAttributionsThroughWebsiteDataRemoval):
* UIProcess/API/C/WKWebsiteDataStoreRef.h:
* UIProcess/API/Cocoa/WKWebsiteDataRecord.mm:
(dataTypesToString):
* UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h:
(WebKit::toWebsiteDataType):
(WebKit::toWKWebsiteDataTypes):
* UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h:
* UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(+[WKWebsiteDataStore _allWebsiteDataTypesIncludingPrivate]):

Tools:

This patch adds test infrastructure to delete Ad Click Attribution data
through WebsiteDataStore::removeData().

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::clearAdClickAttribution):
(WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

* http/tests/adClickAttribution/clear-through-website-data-removal-expected.txt: Added.
* http/tests/adClickAttribution/clear-through-website-data-removal.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agowebkitpy: Kill unresponsive worker processes
jbedard@apple.com [Tue, 23 Apr 2019 23:52:43 +0000 (23:52 +0000)]
webkitpy: Kill unresponsive worker processes
https://bugs.webkit.org/show_bug.cgi?id=197205
<rdar://problem/50104388>

Reviewed by Lucas Forschler.

* Scripts/webkitpy/common/message_pool.py:
(_MessagePool.__init__): Add close timeout.
(_MessagePool._close): Send termination before joining workers, kill unresponsive workers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoReturn annotated text checking strings via UIWKDocumentContext
timothy_horton@apple.com [Tue, 23 Apr 2019 23:46:46 +0000 (23:46 +0000)]
Return annotated text checking strings via UIWKDocumentContext
https://bugs.webkit.org/show_bug.cgi?id=197177
<rdar://problem/49064839>

Reviewed by Ryosuke Niwa.

* WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.h:
* WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:
(WebKit::TextCheckingControllerProxy::annotatedSubstringBetweenPositions):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::requestDocumentEditingContext):
Respect the UIWKDocumentRequestAnnotation flag, returning an attributed
string containing the platform text checking annotations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoWeb Inspector: Debugger: remove ASSERT_NOT_REACHED where it's possible to reach
drousso@apple.com [Tue, 23 Apr 2019 22:30:06 +0000 (22:30 +0000)]
Web Inspector: Debugger: remove ASSERT_NOT_REACHED where it's possible to reach
https://bugs.webkit.org/show_bug.cgi?id=197210
<rdar://problem/48462912>

Reviewed by Joseph Pecoraro.

* inspector/agents/page/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::didAddEventListener):
(WebCore::PageDebuggerAgent::didPostMessage):

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::consoleAgentEnabled):
(WebCore::InspectorInstrumentation::timelineAgentEnabled):
Drive-by: add additional `FAST_RETURN_IF_NO_FRONTENDS`.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoAdd unit tests for WKWebView.serverTrust
achristensen@apple.com [Tue, 23 Apr 2019 21:46:46 +0000 (21:46 +0000)]
Add unit tests for WKWebView.serverTrust
https://bugs.webkit.org/show_bug.cgi?id=197202

Source/ThirdParty/libwebrtc:

Reviewed by Youenn Fablet.

* libwebrtc.xcodeproj/project.pbxproj:
Move boringssl files from libwebrtc target to boringssl target.
Also, add pkcs7 files to boringssl static library.

Tools:

Reviewed by Youenn Fablet

* TestWebKitAPI/TCPServer.cpp:
(TestWebKitAPI::deleter<BIO>::operator()):
(TestWebKitAPI::deleter<SSL>::operator()):
(TestWebKitAPI::deleter<X509>::operator()):
(TestWebKitAPI::deleter<SSL_CTX>::operator()):
(TestWebKitAPI::deleter<EVP_PKEY>::operator()):
(TestWebKitAPI::TCPServer::TCPServer):
(TestWebKitAPI::TCPServer::listenForConnections):
* TestWebKitAPI/TCPServer.h:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
(TestWebKitAPI::TEST):
(verifyCertificateAndPublicKey):
(-[ServerTrustDelegate webView:didFinishNavigation:]):
(-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
* TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
(TestWebKitAPI::downloadAtRate):
* TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
(TEST):
* TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoUnreviewed, rolling out r244556.
commit-queue@webkit.org [Tue, 23 Apr 2019 21:38:10 +0000 (21:38 +0000)]
Unreviewed, rolling out r244556.
https://bugs.webkit.org/show_bug.cgi?id=197212

Causing build failures on multiple builders (Requested by
ShawnRoberts on #webkit).

Reverted changeset:

"Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
https://bugs.webkit.org/show_bug.cgi?id=197171
https://trac.webkit.org/changeset/244556

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoWeb Inspector: Uncaught Exception: null is not an object (evaluating 'this.ownerDocum...
drousso@apple.com [Tue, 23 Apr 2019 21:06:43 +0000 (21:06 +0000)]
Web Inspector: Uncaught Exception: null is not an object (evaluating 'this.ownerDocument.frameIdentifier')
https://bugs.webkit.org/show_bug.cgi?id=196420
<rdar://problem/49444205>

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

* inspector/protocol/DOM.json:
Modify the existing `frameId` to represent the owner frame of the node, rather than the
frame it holds (in the case of an `<iframe>`).

Source/WebCore:

Modify the existing `frameId` to represent the owner frame of the node, rather than the
frame it holds (in the case of an `<iframe>`).

* inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForNode):

Source/WebInspectorUI:

* UserInterface/Models/DOMNode.js:
(WI.DOMNode):
(WI.DOMNode.prototype.get frame): Added.
(WI.DOMNode.prototype.get frameIdentifier): Deleted.
Modify the existing `frameId` to represent the owner frame of the node, rather than the
frame it holds (in the case of an `<iframe>`).

* UserInterface/Controllers/DOMDebuggerManager.js:
(WI.DOMDebuggerManager.prototype.domBreakpointsForNode):
(WI.DOMDebuggerManager.prototype._detachDOMBreakpoint):
(WI.DOMDebuggerManager.prototype._resolveDOMBreakpoint):
(WI.DOMDebuggerManager.prototype._nodeInserted):
(WI.DOMDebuggerManager.prototype._nodeRemoved):
* UserInterface/Views/DOMTreeElement.js:
(WI.DOMTreeElement.prototype._populateTagContextMenu):
(WI.DOMTreeElement.prototype._buildAttributeDOM):
* UserInterface/Views/QuickConsole.js:
(WI.QuickConsole.prototype._selectExecutionContext):
* UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._highlightNodesWithSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoFix iOS build.
achristensen@apple.com [Tue, 23 Apr 2019 20:52:31 +0000 (20:52 +0000)]
Fix iOS build.
https://bugs.webkit.org/show_bug.cgi?id=195537

* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setOpenPanelFilesMediaIcon):
AdoptWK constructor is private now.  Use adoptWK instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoBuild fix after r244545.
commit-queue@webkit.org [Tue, 23 Apr 2019 20:47:43 +0000 (20:47 +0000)]
Build fix after r244545.

Patch by Remy Demarest <rdemarest@apple.com> on 2019-04-23
Reviewed by Tim Horton.

* Platform/spi/mac/AppKitSPI.h:
The SPI was an IPI in High Sierra.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoContentSecurityPolicy::logToConsole should include line/column number and source...
drousso@apple.com [Tue, 23 Apr 2019 20:40:58 +0000 (20:40 +0000)]
ContentSecurityPolicy::logToConsole should include line/column number and source location
https://bugs.webkit.org/show_bug.cgi?id=114317
<rdar://problem/13614617>

Reviewed by Timothy Hatcher.

Source/WebCore:

No change in functionality.

* page/csp/ContentSecurityPolicy.h:
* page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation const):
(WebCore::ContentSecurityPolicy::logToConsole const):

LayoutTests:

* inspector/debugger/csp-exceptions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoWeb Inspector: Canvas: support recording TypedOMCSSImageValue
drousso@apple.com [Tue, 23 Apr 2019 20:32:39 +0000 (20:32 +0000)]
Web Inspector: Canvas: support recording TypedOMCSSImageValue
https://bugs.webkit.org/show_bug.cgi?id=192609

Reviewed by Timothy Hatcher.

* inspector/InspectorCanvas.h:
* inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::indexForData):
(WebCore::InspectorCanvas::buildAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoAccessibility text search and selection API enhancements.
commit-queue@webkit.org [Tue, 23 Apr 2019 20:31:51 +0000 (20:31 +0000)]
Accessibility text search and selection API enhancements.
https://bugs.webkit.org/show_bug.cgi?id=197095
<rdar://problem/48181791>

Patch by Andres Gonzalez <andresg_22@apple.com> on 2019-04-23
Reviewed by Chris Fleizach.

Source/WebCore:

- Split the existing SelectTextWithCriteria API into two: search text API (SearchTextWithCriteria) and a text operation API (TextOperation: select, replace, capitalize...).
- This allows for more flexibility and extensibility.
- Added the ability to retrieve text markers for multiple search hits.
- Various code clean up and consolidation.
- Added LayoutTest for search API.
- Previous API is marked with "To be deprecated", and is implemented with new implementation. May be removed in a future change.

Test: accessibility/mac/search-text/search-text.html

* accessibility/AccessibilityObject.cpp:
(WebCore::rangeClosestToRange):
(WebCore::AccessibilityObject::rangeOfStringClosestToRangeInDirection const):
(WebCore::AccessibilityObject::findTextRange const):
(WebCore::AccessibilityObject::findTextRanges const):
(WebCore::AccessibilityObject::performTextOperation):
(WebCore::AccessibilityObject::frame const):
(WebCore::AccessibilityObject::selectText): Deleted.
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilitySearchTextCriteria::AccessibilitySearchTextCriteria):
(WebCore::AccessibilityTextOperation::AccessibilityTextOperation):
(WebCore::AccessibilitySelectTextCriteria::AccessibilitySelectTextCriteria): Deleted.
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(accessibilityTextCriteriaForParameterizedAttribute):
(accessibilitySearchTextCriteriaForParameterizedAttribute):
(accessibilityTextOperationForParameterizedAttribute):
(-[WebAccessibilityObjectWrapper IGNORE_WARNINGS_END]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(accessibilitySelectTextCriteriaForCriteriaParameterizedAttribute): Deleted.

Tools:

Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.

* DumpRenderTree/AccessibilityTextMarker.h:
* DumpRenderTree/AccessibilityUIElement.cpp:
(searchTextWithCriteriaCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(convertVectorToObjectArray):
(convertNSArrayToVector):
(searchTextParameterizedAttributeForCriteria):
(AccessibilityUIElement::getLinkedUIElements):
(AccessibilityUIElement::getDocumentLinks):
(AccessibilityUIElement::getChildren):
(AccessibilityUIElement::getChildrenWithRange):
(AccessibilityUIElement::rowHeaders const):
(AccessibilityUIElement::columnHeaders const):
(AccessibilityUIElement::uiElementArrayAttributeValue const):
(AccessibilityUIElement::searchTextWithCriteria):
(AccessibilityUIElement::attributesOfColumnHeaders):
(AccessibilityUIElement::attributesOfRowHeaders):
(AccessibilityUIElement::attributesOfColumns):
(AccessibilityUIElement::attributesOfRows):
(AccessibilityUIElement::attributesOfVisibleCells):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::convertVectorToObjectArray):
(WTR::convertNSArrayToVector):
(WTR::searchTextParameterizedAttributeForCriteria):
(WTR::AccessibilityUIElement::getLinkedUIElements):
(WTR::AccessibilityUIElement::getDocumentLinks):
(WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
(WTR::AccessibilityUIElement::getChildren):
(WTR::AccessibilityUIElement::getChildrenWithRange):
(WTR::AccessibilityUIElement::rowHeaders const):
(WTR::AccessibilityUIElement::columnHeaders const):
(WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
(WTR::AccessibilityUIElement::searchTextWithCriteria):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::convertElementsToObjectArray): Deleted.

LayoutTests:

- Added new test for AccessibilitySearchTextWithCriteria API.
- Updated bounds-for-range expected file that includes a list of available APIs.

* accessibility/mac/bounds-for-range-expected.txt:
* accessibility/mac/search-text/search-text-expected.txt: Added.
* accessibility/mac/search-text/search-text.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months agoWeb Inspector: Canvas: no obvious way of switching to the overview when viewing an...
drousso@apple.com [Tue, 23 Apr 2019 20:31:02 +0000 (20:31 +0000)]
Web Inspector: Canvas: no obvious way of switching to the overview when viewing an imported recording
https://bugs.webkit.org/show_bug.cgi?id=197178
<rdar://problem/50106641>

Reviewed by Timothy Hatcher.

Expand the idea of "imported" recordings to include "saved" recordings, ones whose
underlying <canvas> was destroyed.

* UserInterface/Views/CanvasTabContentView.js:
(WI.CanvasTabContentView):
(WI.CanvasTabContentView.prototype.attached):
(WI.CanvasTabContentView.prototype._removeCanvas):
(WI.CanvasTabContentView.prototype._addRecording):
(WI.CanvasTabContentView.prototype._handleRecordingSavedOrStopped): Added.
(WI.CanvasTabContentView.prototype.initialLayout): Deleted.
(WI.CanvasTabContentView.prototype._recordingImportedOrStopped): Deleted.
Make the "Saved Recordings" folder a child of the "Overview" so that the "Overview" path
component is always visible/clickable.

* UserInterface/Views/CanvasOverviewContentView.js:
(WI.CanvasOverviewContentView):
(WI.CanvasOverviewContentView.prototype.contentViewAdded):
(WI.CanvasOverviewContentView.prototype.attached):
(WI.CanvasOverviewContentView.prototype.detached):
(WI.CanvasOverviewContentView.prototype._addSavedRecording): Added.
(WI.CanvasOverviewContentView.prototype._handleRecordingSaved): Added.
(WI.CanvasOverviewContentView.prototype._handleSavedRecordingClicked): Added.
* UserInterface/Views/CanvasOverviewContentView.css:
(.content-view.canvas-overview .content-view.canvas.saved-recordings): Added.
(.content-view.canvas-overview .content-view.canvas.saved-recordings .tree-outline): Added.
(.content-view.canvas-overview .content-view.canvas.saved-recordings .tree-outline > .item.recording > .icon): Added.
Add a card for "Saved Recordings" that mimics the style of regular canvas cards.

* UserInterface/Controllers/CanvasManager.js:
(WI.CanvasManager):
(WI.CanvasManager.prototype.get savedRecordings): Added.
(WI.CanvasManager.prototype.async processJSON):
(WI.CanvasManager.prototype.disable):
(WI.CanvasManager.prototype._removeCanvas):
(WI.CanvasManager.prototype.get importedRecordings): Deleted.

* Localizations/en.lproj/localizedStrings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 months ago[iOS] Input field on ddg.gg is auto focused when url is entered with the software...
pvollan@apple.com [Tue, 23 Apr 2019 20:27:24 +0000 (20:27 +0000)]
[iOS] Input field on ddg.gg is auto focused when url is entered with the software keyboard
https://bugs.webkit.org/show_bug.cgi?id=196740

Reviewed by Megan Gardner.

When an url for a page with an autofocused input field  is entered with the software keyboard,
the input field is auto selected, and the software keyboard reappears. This does not happen
when picking the url from favorites. After using the software keyboard to enter the url, the
activity state is being changed to focused. The method '_elementDidFocus' checks whether the
activity state changed, and allows the software keyboard to be shown in this case. To avoid
showing the software keyboard in this case, send the changing activity state bitfield to the
UI process, and check if the focus flag is the only flag set.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244559 268f45cc-cd09-0410-ab3c-d52691b4dbfc