WebKit-https.git
7 years agoRespect system setting for rubber-banding in ScrollAnimatorMac.
commit-queue@webkit.org [Wed, 22 Aug 2012 17:59:26 +0000 (17:59 +0000)]
Respect system setting for rubber-banding in ScrollAnimatorMac.
https://bugs.webkit.org/show_bug.cgi?id=94356

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-08-22
Reviewed by James Robinson.

Respects user defaults setting of NSScrollViewRubberbanding,
which controls rubber-banding in other Mac OS X applications.

If NSScrollViewRubberbanding is not set, defaults to enabling
rubber banding. Otherwise, rubber banding is disabled if the
value is 0 and enabled otherwise.

No new tests since the behavior depends on system settings.

* platform/mac/ScrollAnimatorMac.mm:
(WebCore):
(WebCore::rubberBandingEnabledForSystem):
(WebCore::ScrollAnimatorMac::handleWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium/mac] Remove unnecessary checks for OS version <= 10.5. We don't support...
commit-queue@webkit.org [Wed, 22 Aug 2012 17:56:48 +0000 (17:56 +0000)]
[chromium/mac] Remove unnecessary checks for OS version <= 10.5. We don't support those
https://bugs.webkit.org/show_bug.cgi?id=94658

Patch by James Robinson <jamesr@chromium.org> on 2012-08-22
Reviewed by Tony Chang.

The chromium mac port hasn't supported Leopard for a while now, so remove chromium-specific code that checks
for OS X version <= Leopard.

* platform/graphics/chromium/CrossProcessFontLoading.mm:
(WebCore::FontPlatformData::loadFont):
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::canSetCascadeListForCustomFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add touch link highlight animation layers.
wjmaclean@chromium.org [Wed, 22 Aug 2012 17:51:44 +0000 (17:51 +0000)]
[chromium] Add touch link highlight animation layers.
https://bugs.webkit.org/show_bug.cgi?id=84487

Reviewed by James Robinson.

Adds support for creating composited touch link highlights in renderer thread. Clipping not yet
implemented for non-composited frames/overflow divs, but scrolling and layout changes are supported.
Transform support currently limited to translation.

Source/WebCore:

Unit tests for LinkHighlight revised.

Tests: platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-clipped.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scroll-clip.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-clipped.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-clipped.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll.html
       platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple.html

* WebCore.gypi:
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::willBeDestroyed): Adds notification to LinkHighlight when layer goes away.
(WebCore::GraphicsLayerChromium::updateNames): Now sets debug name for LinkHighlight layer.
(WebCore::GraphicsLayerChromium::setSize): Invalidates LinkHighlight if present.
(WebCore::GraphicsLayerChromium::setNeedsDisplay): Invalidates LinkHighlight if present.
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect): Invalidates LinkHighlight if present.
(WebCore::GraphicsLayerChromium::setLinkHighlight): Registers LinkHighlightClient* with GraphicsLayerChromium.
(WebCore::GraphicsLayerChromium::updateChildList): Now adds LinkHighlight WebLayer if highlight active.
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable): Invalidates LinkHighlight if present.
* platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore):
(LinkHighlightClient): Abstract interface seen by GraphicsLayerChromium.
(WebCore::LinkHighlightClient::~LinkHighlightClient):
(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::linkHighlight):
* platform/graphics/chromium/LinkHighlight.cpp: Removed.

Source/WebKit/chromium:

Unit tests for LinkHighlight revised.

* WebKit.gyp:
* src/LinkHighlight.cpp: Added.
(WebKit):
(WebKit::LinkHighlight::create):
(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::~LinkHighlight):
(WebKit::LinkHighlight::contentLayer): Accessor for layer containing highlight.
(WebKit::LinkHighlight::clipLayer): Accessor for layer that provides clipping for highlight.
(WebKit::LinkHighlight::releaseResources): Releases Node* for highlight target, clears client/delegate pointers.
(WebKit::LinkHighlight::computeEnclosingCompositingLayer): Determines which GraphicsLayerChromium to attach highlight to.
(WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Determines coordinates of highlight in owning GraphicsLayerChromium's coordinates.
(WebKit::LinkHighlight::paintContents): If highlight active, paints highlight.
(WebKit::LinkHighlight::startHighlightAnimation): Called to start highlight animation.
(WebKit::LinkHighlight::clearGraphicsLayerLinkHighlightPointer): Removes this LinkHighlight's pointer from owning GraphicsLayerChromium.
(WebKit::LinkHighlight::notifyAnimationStarted): Implements WebAnimationDelegate.
(WebKit::LinkHighlight::notifyAnimationFinished): Implements WebAnimationDelegate, releases resources when animation completes.
(WebKit::LinkHighlight::updateGeometry): Invokes computation of which GraphicsLayerChromium to attach to, and highlight shape & position.
    Computations proceed only if preceded by call to invalidate().
(WebKit::LinkHighlight::clearCurrentGraphicsLayer): Handles notification that current GraphicsLayerChromium* is no longer valid.
(WebKit::LinkHighlight::invalidate): Sets flag to allow geometry update on next call from WebViewImpl::layout().
(WebKit::LinkHighlight::layer): Exports WebLayer* for use in GraphicsLayerChromium.
* src/LinkHighlight.h: Renamed from Source/WebCore/platform/graphics/chromium/LinkHighlight.h.
(WebCore):
(WebKit):
(LinkHighlight):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit):
(WebKit::highlightConditions):
(WebKit::WebViewImpl::bestTouchLinkNode): Find highlight target node for touch event location.
(WebKit::WebViewImpl::enableTouchHighlight): Invokes highlight for node at current touch event location.
(WebKit::WebViewImpl::layout): Adds call to LinkHighlight::updateGeometry().
* src/WebViewImpl.h:
(WebKit):
(WebViewImpl):
(WebKit::WebViewImpl::linkHighlight):
* tests/LinkHighlightTest.cpp:
(WebCore):
(WebCore::TEST):
* tests/data/test_touch_link_highlight.html: Added.

LayoutTests:

* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll.html: Added.
* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple.html: Added.
* platform/chromium-linux/compositing/gestures/resources/1-frame-composited.html: Added.
* platform/chromium-linux/compositing/gestures/resources/1-frame-noncomposited.html: Added.
* platform/chromium-linux/compositing/gestures/resources/1-nested-frame-composited.html: Added.
* platform/chromium-linux/compositing/gestures/resources/1-nested-frame-noncomposited.html: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-composite-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-iframe-scrolled-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-2-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-layout-change-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-composite-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-outer-late-composite-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-inner-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-2-overflow-div-scrolled-outer-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-expected.txt: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-window-scroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBrowser menu visible when calling webkitRequestFullscreen after user manually enters...
jer.noble@apple.com [Wed, 22 Aug 2012 17:50:22 +0000 (17:50 +0000)]
Browser menu visible when calling webkitRequestFullscreen after user manually enters full screen mode
https://bugs.webkit.org/show_bug.cgi?id=93892

Reviewed by Eric Carlson.

Allow the full screen window to "Join All Spaces", so that once it's original full screen space is destroyed,
it can join the new one.

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardening. Copy old Mac test expectations
kbr@google.com [Wed, 22 Aug 2012 17:41:40 +0000 (17:41 +0000)]
Unreviewed Chromium gardening. Copy old Mac test expectations
(ignored anyway) for this Mac-specific test after r126219.

* platform/chromium/platform/mac/fast/text/vertical-surrogate-pair-expected.png: Added.
* platform/chromium/platform/mac/fast/text/vertical-surrogate-pair-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnskip http/tests/inspector/console-resource-errors.html.
commit-queue@webkit.org [Wed, 22 Aug 2012 17:33:16 +0000 (17:33 +0000)]
Unskip http/tests/inspector/console-resource-errors.html.
https://bugs.webkit.org/show_bug.cgi?id=94640.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-22
Reviewed by Jessie Berlin.

The test has been rebaseline'd in r126281 and no longer fails.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix. Missing PANGO_CFLAGS.
kov@webkit.org [Wed, 22 Aug 2012 17:19:53 +0000 (17:19 +0000)]
Unreviewed build fix. Missing PANGO_CFLAGS.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: make "sdk" component compile independently from the rest of the front...
pfeldman@chromium.org [Wed, 22 Aug 2012 17:10:21 +0000 (17:10 +0000)]
Web Inspector: make "sdk" component compile independently from the rest of the front-end.
https://bugs.webkit.org/show_bug.cgi?id=94705

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change refactors the way we compile. Running "compile-front-end.py sdk" will compile sdk only.
It also introduces DOMStorageModel and DatabaseModel that are used to split model / UI layers.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/InjectedScriptExterns.js:
(InjectedScriptHost.prototype.evaluate):
* inspector/Inspector.json:
* inspector/compile-front-end.py:
(dump_module):
* inspector/front-end/CompilerScriptMapping.js:
* inspector/front-end/ConsoleModel.js:
(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.prototype.clone):
(WebInspector.ConsoleMessage.prototype.location):
* inspector/front-end/DOMAgent.js:
* inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorageModel):
(WebInspector.DOMStorageModel.prototype._addDOMStorage):
(WebInspector.DOMStorageModel.prototype._domStorageUpdated):
(WebInspector.DOMStorageModel.prototype.storageForId):
(WebInspector.DOMStorageModel.prototype.storages):
(WebInspector.DOMStorageDispatcher):
(WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
(WebInspector.DOMStorageDispatcher.prototype.domStorageUpdated):
* inspector/front-end/Database.js:
(WebInspector.Database):
(WebInspector.Database.prototype.executeSql):
(WebInspector.DatabaseModel):
(WebInspector.DatabaseModel.prototype.databases):
(WebInspector.DatabaseModel.prototype.databaseForId):
(WebInspector.DatabaseModel.prototype._addDatabase):
(WebInspector.DatabaseModel.prototype._sqlTransactionSucceeded):
(WebInspector.DatabaseModel.prototype._sqlTransactionFailed):
(WebInspector.DatabaseDispatcher):
(WebInspector.DatabaseDispatcher.prototype.addDatabase):
(WebInspector.DatabaseDispatcher.prototype.sqlTransactionSucceeded):
(WebInspector.DatabaseDispatcher.prototype.sqlTransactionFailed):
* inspector/front-end/DebuggerModel.js:
* inspector/front-end/FileUtils.js:
(WebInspector.OutputStreamDelegate.prototype.onTransferStarted):
(WebInspector.OutputStreamDelegate.prototype.onChunkTransferred):
(WebInspector.OutputStreamDelegate.prototype.onTransferFinished):
(WebInspector.OutputStreamDelegate.prototype.onError):
(WebInspector.OutputStream):
(WebInspector.OutputStream.prototype.startTransfer):
(WebInspector.OutputStream.prototype.transferChunk):
(WebInspector.OutputStream.prototype.finishTransfer):
(WebInspector.OutputStream.prototype.dispose):
* inspector/front-end/HandlerRegistry.js:
* inspector/front-end/HeapSnapshotView.js:
* inspector/front-end/InspectorFrontendHostStub.js:
* inspector/front-end/PresentationConsoleMessageHelper.js:
(WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._reset):
(WebInspector.ResourcesPanel.prototype._databaseAdded):
(WebInspector.ResourcesPanel.prototype._addDatabase):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.ResourcesPanel.prototype._addDOMStorage):
(WebInspector.ResourcesPanel.prototype._showDatabase.get if):
(WebInspector.ResourcesPanel.prototype._showDatabase.else.get if):
(WebInspector.ResourcesPanel.prototype._showDatabase):
(WebInspector.ResourcesPanel.prototype._showDOMStorage.get if):
(WebInspector.ResourcesPanel.prototype._showDOMStorage):
(WebInspector.ResourcesPanel.prototype._updateDatabaseTables.get if):
(WebInspector.ResourcesPanel.prototype._updateDatabaseTables.tableNamesCallback):
(WebInspector.DatabaseTreeElement.prototype.onselect):
(WebInspector.DatabaseTableTreeElement.prototype.onselect):
(WebInspector.DOMStorageTreeElement.prototype.onselect):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.showFunctionDefinition):
* inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype.disableSearchUntilExplicitAction):
* inspector/front-end/Settings.js:
* inspector/front-end/Spectrum.js:
* inspector/front-end/TextEditorModel.js:
* inspector/front-end/UIString.js: Added.
(WebInspector.UIString):
* inspector/front-end/UIUtils.js:
* inspector/front-end/WebKit.qrc:
* inspector/front-end/externs.js:
(InspectorFrontendHostAPI.prototype.platform):
(InspectorFrontendHostAPI.prototype.port):
(InspectorFrontendHostAPI.prototype.bringToFront):
(InspectorFrontendHostAPI.prototype.closeWindow):
(InspectorFrontendHostAPI.prototype.requestAttachWindow):
(InspectorFrontendHostAPI.prototype.requestDetachWindow):
(InspectorFrontendHostAPI.prototype.requestSetDockSide):
(InspectorFrontendHostAPI.prototype.setAttachedWindowHeight):
(InspectorFrontendHostAPI.prototype.moveWindowBy):
(InspectorFrontendHostAPI.prototype.setInjectedScriptForOrigin):
(InspectorFrontendHostAPI.prototype.loaded):
(InspectorFrontendHostAPI.prototype.localizedStringsURL):
(InspectorFrontendHostAPI.prototype.hiddenPanels):
(InspectorFrontendHostAPI.prototype.inspectedURLChanged):
(InspectorFrontendHostAPI.prototype.documentCopy):
(InspectorFrontendHostAPI.prototype.copyText):
(InspectorFrontendHostAPI.prototype.openInNewTab):
(InspectorFrontendHostAPI.prototype.canSave):
(InspectorFrontendHostAPI.prototype.save):
(InspectorFrontendHostAPI.prototype.canAppend):
(InspectorFrontendHostAPI.prototype.append):
(InspectorFrontendHostAPI.prototype.sendMessageToBackend):
(InspectorFrontendHostAPI.prototype.recordActionTaken):
(InspectorFrontendHostAPI.prototype.recordPanelShown):
(InspectorFrontendHostAPI.prototype.recordSettingChanged):
(InspectorFrontendHostAPI.prototype.loadResourceSynchronously):
(InspectorFrontendHostAPI.prototype.setZoomFactor):
(InspectorFrontendHostAPI.prototype.canInspectWorkers):
(SourceMapV3):
(SourceMapV3.Section):
(SourceMapV3.Offset):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.inspect):

LayoutTests:

* http/tests/inspector-enabled/database-open.html:
* http/tests/inspector-enabled/dom-storage-open.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix. libWebCore needs include paths
kov@webkit.org [Wed, 22 Aug 2012 17:05:33 +0000 (17:05 +0000)]
Unreviewed build fix. libWebCore needs include paths
for some bits of WebCoreGtk.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFontMetrics.unitsPerEm(), FontPlatformData.orientation(), SimpleFontData::platformBou...
commit-queue@webkit.org [Wed, 22 Aug 2012 16:53:51 +0000 (16:53 +0000)]
FontMetrics.unitsPerEm(), FontPlatformData.orientation(), SimpleFontData::platformBoundsForGlyph are not implemented on Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=83512

Patch by Koji Ishii <kojiishi@gmail.com> on 2012-08-22
Reviewed by Tony Chang.

Source/WebCore:

Chromium Windows does not implement following 3 functions that are required for bug 51450.
1. FontMetrics.unitsPerEm() always returns the default value (gDefaultUnitsPerEm = 1000).
2. FontPlatformData.orientation() always returns Horizontal.
3. SimpleFontData::platformBoundsForGlyph() always returns FloatRect().
Tony suggested in bug 51450 review to split code that is not behind
#if ENABLE(OPENTYPE_VERTICAL) to a separate patch.

Test: Following 3 existing but skipped tests are now enabled and pass.
      fast/text/emphasis-overlap.html
      fast/text/emphasis-avoid-ruby.html
      fast/repaint/text-emphasis-v.html

* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::FontCache::createFontPlatformData): Add orientation.
* platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Add orientation.
(WebCore::FontPlatformData::operator=): Add orientation.
* platform/graphics/chromium/FontPlatformDataChromiumWin.h:
(FontPlatformData):
(WebCore::FontPlatformData::orientation): Add orientation.
(WebCore::FontPlatformData::setOrientation): Add orientation.
(WebCore::FontPlatformData::operator==): Add orientation.
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformInit): Set FontMetrics.unitsPerEm.
(WebCore::SimpleFontData::createScaledFontData): Add orientation.
(WebCore::SimpleFontData::platformBoundsForGlyph): Implemented.
* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Add orientation.

LayoutTests:

Chromium Windows does not implement following 3 functions that are required for bug 51450.
1. FontMetrics.unitsPerEm() always returns the default value (gDefaultUnitsPerEm = 1000).
   This change requires rebaseline of fast/repaint/stacked-diacritics and fast/text/emphasis-overlap.
2. FontPlatformData.orientation() always returns Horizontal. This has no effect as of this patch.
3. SimpleFontData::platformBoundsForGlyph() always returns FloatRect().
   This change improves rendering of text-emphasis and 3 existing tests pass now.
Tony suggested in bug 51450 review to split code that is not behind
#if ENABLE(OPENTYPE_VERTICAL) to a separate patch.

* platform/chromium-win/fast/repaint/stacked-diacritics-expected.png:
* platform/chromium-win/fast/text/emphasis-overlap-expected.txt: Added due to metrics change.
* platform/chromium/TestExpectations: Enabled 3 tests for Chromium Win.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] Support posting injected bundle messages to a page
ap@apple.com [Wed, 22 Aug 2012 16:36:47 +0000 (16:36 +0000)]
    [WK2] Support posting injected bundle messages to a page
        https://bugs.webkit.org/show_bug.cgi?id=94630

        Reviewed by Sam Weinig.

        * Shared/APIClientTraits.cpp:
        * Shared/APIClientTraits.h:
        * Shared/CoreIPCSupport/InjectedBundleMessageKinds.h:
        * UIProcess/API/C/WKPage.cpp:
        (WKPagePostMessageToInjectedBundle):
        * UIProcess/API/C/WKPage.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::postMessageToInjectedBundle):
        * UIProcess/WebPageProxy.h:
        * WebProcess/InjectedBundle/API/c/WKBundle.h:
        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::InjectedBundle::didReceiveMessageToPage):
        (WebKit::InjectedBundle::didReceiveMessage):
        * WebProcess/InjectedBundle/InjectedBundle.h:
        * WebProcess/InjectedBundle/InjectedBundleClient.cpp:
        (WebKit::InjectedBundleClient::didReceiveMessageToPage):
        * WebProcess/InjectedBundle/InjectedBundleClient.h:
        (InjectedBundleClient):
        Added a PostMessageToPage injected bundle message type, with all associated
        machinery. API is WKPagePostMessageToInjectedBundle(), and an associated
        didReceiveMessageToPage() injected bundle client function.

        * WebProcess/qt/QtBuiltinBundle.cpp: (WebKit::QtBuiltinBundle::initialize):
        Updated for new client API.

        * UIProcess/WebContext.cpp: (WebKit::WebContext::postMessageToInjectedBundle):
        Implemented multiple process model case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r125578): fast/regex/unicodeCaseInsensitive.html crash on Linux Debug...
robert@webkit.org [Wed, 22 Aug 2012 16:07:44 +0000 (16:07 +0000)]
REGRESSION(r125578): fast/regex/unicodeCaseInsensitive.html crash on Linux Debug Chromium
https://bugs.webkit.org/show_bug.cgi?id=94010

Reviewed by Tony Chang.

r125578 inspected the raw text run for word-end but the index it used to do so was for a normalized
version of the run that could be longer than the raw text run. So to allow proper detection of word-end
in complex text (i) do not normalize tabs to plain white-space and (ii) go back to using the normalized version
of the run for detecting word-end. There is a risk that some fonts may create glyphs for the '\t' character
but this does not turn up in any of our regression tests and the more common risk appears to be the new-line.

Test: fast/regex/unicodeCaseInsensitive.html

* platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:
(WebCore::normalizeSpacesAndMirrorChars):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r125710): accessibility/accessibility-node-reparent.html, accessibility...
dmazzoni@google.com [Wed, 22 Aug 2012 16:01:10 +0000 (16:01 +0000)]
REGRESSION (r125710): accessibility/accessibility-node-reparent.html, accessibility/accessibility-node-memory-management.html failing on GTK Linux
https://bugs.webkit.org/show_bug.cgi?id=94200

Reviewed by Chris Fleizach.

Tools:

Adds reference counting for AtkObjects referenced by
AccessibilityUIElementGtk. This prevents bogus results and
assertion failures on AccessibilityUIElements whose underlying
object has been deleted (as opposed to just made defunct).

This fixes two tests that were previously failing because of this bug.

* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):

LayoutTests:

This patch fixes two tests and removes them from gtk expectations.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [WebGL] Support the communication protocol from the injected script
commit-queue@webkit.org [Wed, 22 Aug 2012 15:54:59 +0000 (15:54 +0000)]
Web Inspector: [WebGL] Support the communication protocol from the injected script
https://bugs.webkit.org/show_bug.cgi?id=94689

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-22
Reviewed by Pavel Feldman.

Support the WebGL communication protocol from the injected script module.

* inspector/InjectedScriptWebGLModuleSource.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Crash when finalizing WebKitWebView
carlosgc@webkit.org [Wed, 22 Aug 2012 15:53:21 +0000 (15:53 +0000)]
[GTK] Crash when finalizing WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=94699

Reviewed by Martin Robinson.

Create the offscreen window the first time accelerated compositing
is enabled, so that if it's never enabled the window won't be
created.

* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::initialize):
(WebKit::AcceleratedCompositingContext::setRootCompositingLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Split WebCore/platform into a separate library
kov@webkit.org [Wed, 22 Aug 2012 15:47:53 +0000 (15:47 +0000)]
[GTK] Split WebCore/platform into a separate library
https://bugs.webkit.org/show_bug.cgi?id=94435

Reviewed by Martin Robinson.

More people have been reporting problems when linking WebCore because
the command line limit is being exceeded. Splitting WebCore a bit more
is in order.

.:

* GNUmakefile.am: add variable that will hold the list of source files
for libWebCorePlatform .

Source/WebCore:

* GNUmakefile.am: add new libWebCorePlatform convenience library.
* GNUmakefile.list.am: move list of platform/* files to its own variable.

Source/WebKit/gtk:

* GNUmakefile.am: link libWebCorePlatform into libwebkitgtk

Source/WebKit2:

* GNUmakefile.am: link libWebCorePlatform into libwebkit2gtk

Tools:

* GNUmakefile.am: link libWebCorePlatform into DRT

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Build failures with harfbuzz outside standard locations
rakuco@webkit.org [Wed, 22 Aug 2012 15:46:01 +0000 (15:46 +0000)]
[EFL] Build failures with harfbuzz outside standard locations
https://bugs.webkit.org/show_bug.cgi?id=93030

Reviewed by Rob Buis.

Add ${HARFBUZZ_INCLUDE_DIRS} to the list of included paths: so far
it was being implicitly pulled from evas's pkg-config file, and
used to work when WebKit-EFL's dependencies were built with
jhbuild -- in this case, harfbuzz is built before evas, which is
then built with harfbuzz support and adds the required paths to
its .pc file.

We need to include things directly to account for the case of
people not using jhbuild and thus not necessarily having harfbuzz
as an evas dependency.

* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in WebCore::RenderBlock::removeChild
commit-queue@webkit.org [Wed, 22 Aug 2012 15:34:57 +0000 (15:34 +0000)]
Crash in WebCore::RenderBlock::removeChild
https://bugs.webkit.org/show_bug.cgi?id=93879

Patch by Raul Hudea <rhudea@adobe.com> on 2012-08-22
Reviewed by Abhishek Arya.

Source/WebCore:

By adding the lifetime state to the RenderNamedFlowThread (r122556), it become possible for the a RenderRegion object to delete its sibling,
the RenderNamedFlowThread. This is unexpected in the rendering world and cause problems in RenderBlock::removeChild where we retain previous
and next sibling pointers.
So, all the RenderNamedFlowThread are created under a RenderFlowThreadContainer object insted of the RenderView. The new object is created only
when the first named flow is created.

Test: fast/regions/remove-flow-thread-crash.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::FlowThreadController): Added initialization for the new RenderFlowThreadContainer member
(WebCore::FlowThreadController::ensureRenderFlowThreadWithName): Added the creation of the RenderFlowThreadContainer object and use it as a parent for all RenderNamedFlowThreads
(WebCore::FlowThreadController::styleDidChange): Inform all the RenderNamedFlowThreads that the style changed in regions (initially this code was in RenderView, but now all RenderNamedFlowThreads are children of RenderFlowThreadContainer)
(WebCore):
* rendering/FlowThreadController.h:
(WebCore):
(FlowThreadController):
* rendering/RenderFlowThreadContainer.cpp: Added.
(WebCore):
(WebCore::RenderFlowThreadContainer::RenderFlowThreadContainer):
(WebCore::RenderFlowThreadContainer::layout):
* rendering/RenderFlowThreadContainer.h: Added.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::markContainingBlocksForLayout): Skip to RenderView if the current object is an RenderFlowThreadContainer.
* rendering/RenderObject.h:
(WebCore::RenderObject::isRenderFlowThreadContainer):
* rendering/RenderView.cpp:
(WebCore::RenderView::styleDidChange): Moved the code associated to RenderNamedFlowThreads to FlowThreadController:styleDidChange and call it instead.

LayoutTests:

Test the region-flow_thread sibling case

* fast/regions/remove-flow-thread-crash-expected.txt: Added.
* fast/regions/remove-flow-thread-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Add RSS content handling support
rwlbuis@webkit.org [Wed, 22 Aug 2012 15:28:37 +0000 (15:28 +0000)]
[BlackBerry] Add RSS content handling support
https://bugs.webkit.org/show_bug.cgi?id=93496

Reviewed by Yong Li.

Cleanup some more.

* platform/network/blackberry/rss/RSSFilterStream.cpp:
(WebCore):
(WebCore::createParser):
(WebCore::defaultEncodingForLanguage):
(WebCore::isTranscodingNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unused TextDrawingMode flags from GraphicsContext
caio.oliveira@openbossa.org [Wed, 22 Aug 2012 14:51:56 +0000 (14:51 +0000)]
Remove unused TextDrawingMode flags from GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=21898

Reviewed by Benjamin Poulain.

Remove TextModeClip and TextModeInvisible. These are not used by any port, and
according to https://bugs.webkit.org/show_bug.cgi?id=42110#c2 these were added
just to map CG existing flags, but are not used.

* platform/graphics/GraphicsContext.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setPlatformTextDrawingMode):
* platform/graphics/openvg/PainterOpenVG.cpp:
(WebCore::PainterOpenVG::drawText):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::setTextDrawingMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r126287.
ossy@webkit.org [Wed, 22 Aug 2012 14:13:19 +0000 (14:13 +0000)]
Unreviewed, rolling out r126287.
http://trac.webkit.org/changeset/126287
https://bugs.webkit.org/show_bug.cgi?id=94708

It made WK1 layout testing 3.7x slower (>1hours) (Requested by
ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-22

Source/WebCore:

* bridge/qt/qt_instance.cpp:
(JSC::Bindings::unusedWeakObjectMapCallback):
(Bindings):
(JSC::Bindings::WeakMapImpl::WeakMapImpl):
(JSC::Bindings::WeakMapImpl::~WeakMapImpl):
(JSC::Bindings::WeakMap::~WeakMap):
(JSC::Bindings::WeakMap::set):
(JSC::Bindings::WeakMap::get):
(JSC::Bindings::WeakMap::remove):
* bridge/qt/qt_instance.h:
(QtInstance):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::prototypeForSignalsAndSlots):
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::call):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
(JSC::Bindings::QtRuntimeMethod::connectOrDisconnect):
* bridge/qt/qt_runtime.h:
(QtRuntimeMethod):

Source/WebKit/qt:

* tests/qobjectbridge/tst_qobjectbridge.cpp:
(tst_QObjectBridge::objectDeleted):
(tst_QObjectBridge::introspectQtMethods_data):
(tst_QObjectBridge::introspectQtMethods):

LayoutTests:

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed: follow up to r126297, fixing WebCore.gypi.
pfeldman@chromium.org [Wed, 22 Aug 2012 14:11:30 +0000 (14:11 +0000)]
Not reviewed: follow up to r126297, fixing WebCore.gypi.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed buildfix for Qt-minimal after r126291
allan.jensen@nokia.com [Wed, 22 Aug 2012 14:00:57 +0000 (14:00 +0000)]
Unreviewed buildfix for Qt-minimal after r126291

Disable smooth scrolling when request-animation-frame has been disabled either
explicitly or as part of --minimal.

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Preferred languages and spellchecker APIs are not consistent in WebKit2
carlosgc@webkit.org [Wed, 22 Aug 2012 13:34:13 +0000 (13:34 +0000)]
[GTK] Preferred languages and spellchecker APIs are not consistent in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=94683

Reviewed by Alejandro G. Castro.

Source/WebCore:

Use a Vector<String> instead of a comma-separated string to
get/set languages.

* platform/text/gtk/TextCheckerEnchant.cpp:
(TextCheckerEnchant::updateSpellCheckingLanguages):
(TextCheckerEnchant::getSpellCheckingLanguages):
* platform/text/gtk/TextCheckerEnchant.h:
(TextCheckerEnchant):

Source/WebKit/gtk:

* webkit/webkitspellcheckerenchant.cpp:
(updateSpellCheckingLanguages): Split the languages string to pass a
Vector to updateSpellCheckingLanguages().

Source/WebKit2:

Change spell-checker and preferred languages API to use a GStrv
instead of a comma-separated string and GList. This makes the API
more consistent and convenient to use.

* UIProcess/API/gtk/WebKitTextChecker.cpp:
(WebKitTextChecker::getSpellCheckingLanguages): Return a
Vector<String> instead of a String.
(WebKitTextChecker::setSpellCheckingLanguages): Receive a
Vector<String> instead of a String.
* UIProcess/API/gtk/WebKitTextChecker.h:
(WebKitTextChecker): Use a GPtrArray to cache languages.
* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_get_spell_checking_languages):
(webkit_web_context_set_spell_checking_languages):
(webkit_web_context_set_preferred_languages):
* UIProcess/API/gtk/WebKitWebContext.h:
* UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextSpellChecker):
(testWebContextLanguages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: move NavigatorView and NavigatorOverlayController to ScriptsPanel...
pfeldman@chromium.org [Wed, 22 Aug 2012 13:22:51 +0000 (13:22 +0000)]
Web Inspector: move NavigatorView and NavigatorOverlayController to ScriptsPanel module
https://bugs.webkit.org/show_bug.cgi?id=94693

Reviewed by Vsevolod Vlasov.

Loading them via importScript now.

* inspector/compile-front-end.py:
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Enable runtime enabled features: DeviceMotion and DeviceOrientation
ossy@webkit.org [Wed, 22 Aug 2012 13:21:59 +0000 (13:21 +0000)]
[Qt][WK2] Enable runtime enabled features: DeviceMotion and DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=94692

Reviewed by Kenneth Rohde Christiansen.

* WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWrong default for new ScrollAnimatorEnabled preference.
allan.jensen@nokia.com [Wed, 22 Aug 2012 13:12:26 +0000 (13:12 +0000)]
Wrong default for new ScrollAnimatorEnabled preference.

Reviewed by Simon Hausmann.

ScrollAnimatorEnabled introduced in r126291, should default to 'true'
to preserve existing behaviour on WK2 platforms that already enabled
SMOOTH_SCROLLING unconditionally.

* Shared/WebPreferencesStore.h:
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix JSC build when DFG-JIT is disabled
commit-queue@webkit.org [Wed, 22 Aug 2012 13:12:17 +0000 (13:12 +0000)]
Fix JSC build when DFG-JIT is disabled
https://bugs.webkit.org/show_bug.cgi?id=94694

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-08-22
Reviewed by Csaba Osztrogon√°c.

Adding an appropriate guard for fixing the build.

* bytecode/ResolveGlobalStatus.cpp:
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, build fixup for r126291.
allan.jensen@nokia.com [Wed, 22 Aug 2012 12:50:08 +0000 (12:50 +0000)]
Unreviewed, build fixup for r126291.

* Shared/WebPreferencesStore.h:
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Support slider tick mark snapping
commit-queue@webkit.org [Wed, 22 Aug 2012 12:48:46 +0000 (12:48 +0000)]
[EFL] Support slider tick mark snapping
https://bugs.webkit.org/show_bug.cgi?id=94560

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-22
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Increased the threshold for the EFL port. The value is snapped
when it clicked near tick mark.

No new tests. Covered by fast/forms/datalist/range-snap-to-datalist.html.

* platform/efl/RenderThemeEfl.cpp:
(WebCore):
(WebCore::RenderThemeEfl::sliderTickSnappingThreshold):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):

LayoutTests:

The expected result of fast/forms/datalist/range-snap-to-datalist.html
is updated because slider tick mark snapping threshold is changed.

* platform/efl/fast/forms/datalist/range-snap-to-datalist-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Optionally support smooth-scrolling on all platforms
allan.jensen@nokia.com [Wed, 22 Aug 2012 12:46:06 +0000 (12:46 +0000)]
[Qt] Optionally support smooth-scrolling on all platforms
https://bugs.webkit.org/show_bug.cgi?id=74926

Reviewed by Simon Hausmann.

Source/WebCore:

Make GestureAnimations depend on the GESTURE_ANIMATION feature flag,
since GestureAnimations are unused on some platforms.

* Target.pri:
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::fireUpAnAnimation):
(WebCore::ScrollAnimatorNone::cancelAnimations):
(WebCore::ScrollAnimatorNone::animationTimerFired):
* platform/ScrollAnimatorNone.h:
(ScrollAnimatorNone):

Source/WebKit/qt:

Expose the enable scroll animator setting.

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):
* Api/qwebsettings.h:

Source/WebKit2:

Expose scroll-animator preference, but ensure animated smooth scrolling
on the web process side is disabled when scrolling has been delegated
to the UI process.

* Shared/WebPreferencesStore.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setResizesToContentsUsingLayoutSize):
(WebKit::WebPage::updatePreferences):

Source/WTF:

Initialize GESTURE_ANIMATION feature flag.

* wtf/Platform.h:

Tools:

Enabled SMOOTH_SCROLLING on Qt, and expose the enable scroll animator
setting in QtTestBrowser so it can be tested.

* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::createChrome):
(LauncherWindow::toggleScrollAnimator):
* QtTestBrowser/launcherwindow.h:
(WindowOptions::WindowOptions):
(WindowOptions):
(LauncherWindow):
* qmake/mkspecs/features/features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Port convertQVariantToValue to use the JSC C API
hausmann@webkit.org [Wed, 22 Aug 2012 12:26:18 +0000 (12:26 +0000)]
[Qt] Port convertQVariantToValue to use the JSC C API
https://bugs.webkit.org/show_bug.cgi?id=93889

Reviewed by Kenneth Rohde Christiansen.

Based on patch by Noam Rosenthal.

This patch is another step towards reducing the use of internal JSC API
in the Qt bridge. Most of the conversion from QVariant to JS values is
straight-forward. The biggest behavioural change is that QVariant lists
are converted on-the-spot instead of lazily. Bug #94691 tracks fixing
that.

* bridge/qt/qt_instance.cpp:
(Bindings):
(JSC::Bindings::QtField::valueFromInstance):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertQVariantToValue):
(JSC::Bindings::QtRuntimeMethod::call):
(JSC::Bindings::QtConnectionObject::execute):
(JSC::Bindings::::valueAt):
* bridge/qt/qt_runtime.h:
(Bindings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 22 Aug 2012 11:21:39 +0000 (11:21 +0000)]
[EFL] Unreviewed gardening.

Gardening after r126025 & r126275.

* platform/efl/TestExpectations: Unskipping one, skipping another.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTest and test expectation of Shadow DOM for button should be fixed.
shinyak@chromium.org [Wed, 22 Aug 2012 10:59:39 +0000 (10:59 +0000)]
Test and test expectation of Shadow DOM for button should be fixed.
https://bugs.webkit.org/show_bug.cgi?id=94674

Reviewed by Hajime Morita.

Now that the HTMLButtonElement was AuthroShadowDOM-ready, it's time to update the previous
failing tests for AuthroShadowDOM for button elements.

I've updated the failing tests to follow the current implementation and updated the test expectations.

* fast/dom/shadow/shadowdom-for-button-complex-shadow-expected.html:
* fast/dom/shadow/shadowdom-for-button-complex-shadow.html:
* fast/dom/shadow/shadowdom-for-button-only-shadow-expected.html:
* fast/dom/shadow/shadowdom-for-button-only-shadow.html:
* fast/dom/shadow/shadowdom-for-button-without-shadow-expected.html:
* fast/dom/shadow/shadowdom-for-button-without-shadow.html:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] REGRESSION(r125428): fast/profiler/nested-start-and-stop-profiler.html fails
hausmann@webkit.org [Wed, 22 Aug 2012 10:42:10 +0000 (10:42 +0000)]
[Qt] REGRESSION(r125428): fast/profiler/nested-start-and-stop-profiler.html fails
https://bugs.webkit.org/show_bug.cgi?id=93897

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Before r125428 run-time methods (wrapped signals, slots or invokable
functions) were subclasses of JSInternalFunction and therefore real
function objects in the JavaScript sense. r125428 changed them to be
just callable objects, but they did not have Function.prototype as
prototype anymore for example nor was their name correct (resulting in
a layout test failure).

This patch changes run-time methods back to being real function objects
that have a correct name and have Function.prototype in their prototype
change

The objects returned by JSObjectMakeFunctionWithCallbackInjected are
light-weight internal function objects that do not support
JSObject{Set/Get}Private. Therefore we inject our own prototype right
before the Function.prototype prototype, which uses private data to
store a pointer to our C++ QtRuntimeMethod object.  This complicates
the retrieval of the pointer to that instance slightly, which is why
this patch introduces the toRuntimeMethod convenience function that
looks up our prototype first and does a check for type-safety.

At the same time the patch removes the length properties from the
run-time method itself as well as connect/disconnect.  The length
property on a function signifies the number of arguments, but in all
three cases that number is actually variable, because of overloading.
That is why we choose not to expose it in the first place.

In QtInstance we cache the JS wrapper objects for QtRuntimeMethod in a
JSWeakObjectMap. JSWeakObjectMap requires the stored objects to be
either the result of JSObjectMake or the global object of a context ref
(AFAICS), which is ensured using an ASSERT. Objects created via
JSObjectMakeFunctionWithCalllback do not fall into the required
category, cause a failing assertion and can therefore not be stored in
the weak object map.

Consequently this patch removes the use of JSWeakObjectMap again and
goes back to the old way of using the internal Weak<> API, for the time
being. In a future patch the storage will be simplified to not require
the use of a weak object map cache for the run-time methods anymore.

* bridge/qt/qt_instance.cpp: Remove unused WeakMap code.
* bridge/qt/qt_instance.h: Remove method cache.
(QtInstance):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::prototypeForSignalsAndSlots):
(JSC::Bindings::QtRuntimeMethod::call):
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
(JSC::Bindings::QtRuntimeMethod::toRuntimeMethod):
(Bindings):
(JSC::Bindings::QtRuntimeMethod::connectOrDisconnect):
* bridge/qt/qt_runtime.h:
(QtRuntimeMethod): Remove unused member variables.

Source/WebKit/qt:

Fixed some test expectations.

* tests/qobjectbridge/tst_qobjectbridge.cpp:
(tst_QObjectBridge::objectDeleted): Since runtime methods are real function objects again, we
can go back to testing Function.prototype.call, as it was done before r125428.
(tst_QObjectBridge::introspectQtMethods_data): Removed tests for the length property.
(tst_QObjectBridge::introspectQtMethods): Changed test expectation of the properties of
run-time methods back to being non-configurable, as before r125428.

LayoutTests:

* platform/qt/Skipped: Unskip test that is now passing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowindow.postMessage() / MessagePort.postMessage() throw wrong exception for invalid...
commit-queue@webkit.org [Wed, 22 Aug 2012 10:37:10 +0000 (10:37 +0000)]
window.postMessage() / MessagePort.postMessage() throw wrong exception for invalid ports argument
https://bugs.webkit.org/show_bug.cgi?id=94581

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-22
Reviewed by Kentaro Hara.

Source/WebCore:

Update JSC and V8 implementations of window.postMessage() and
MessagePort.postMessage() in order to throw an
INVALID_STATE_ERR instead of a DATA_CLONE_ERR when values
in the "ports" argument are invalid. Additionally, we now
check for duplicate ports and throw an exception for this
case as well.

This change was made to comply with the latest HTML5
specification at:
http://www.w3.org/TR/html5/comms.html

No new tests, already tested by:
fast/events/constructors/message-event-constructor.html
fast/events/message-port-clone.html
fast/events/message-port-multi.html
fast/workers/worker-context-multi-port.html
fast/workers/worker-multi-port.html

* bindings/js/JSMessagePortCustom.cpp:
(WebCore::fillMessagePortArray):
* bindings/v8/V8Utilities.cpp:
(WebCore::extractTransferables):
* dom/MessagePort.cpp:
(WebCore::MessagePort::postMessage):

LayoutTests:

Update several tests and their expected results now that an
INVALID_STATE_ERR is thrown instead of a DATA_CLONE_ERROR
when window.postMessage() / MessagePort.postMessage() are
called with invalid values in their 'ports' argument.

* fast/events/constructors/message-event-constructor-expected.txt:
* fast/events/constructors/message-event-constructor.html: Stop using duplicate
ports in the test since it throws an exception now.
* fast/events/message-port-clone-expected.txt:
* fast/events/message-port-multi-expected.txt:
* fast/events/resources/message-port-multi.js: Add check for duplicate port case.
* fast/workers/worker-context-multi-port-expected.txt:
* fast/workers/worker-multi-port-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove chromium/fast/js/array-functions-non-arrays-expected.txt and add WebKit bug...
commit-queue@webkit.org [Wed, 22 Aug 2012 10:30:35 +0000 (10:30 +0000)]
Remove chromium/fast/js/array-functions-non-arrays-expected.txt and add WebKit bug id to chromium/TestExpectation.
https://bugs.webkit.org/show_bug.cgi?id=94682

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-08-22
Reviewed by Kentaro Hara.

Only one failing test case remains in array-functions-non-arrays and it is being tracked by Bug 94681.

* platform/chromium/TestExpectations:
* platform/chromium/fast/js/array-functions-non-arrays-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[TouchAdjustment] Adjust to word or selection
allan.jensen@nokia.com [Wed, 22 Aug 2012 10:23:55 +0000 (10:23 +0000)]
[TouchAdjustment] Adjust to word or selection
https://bugs.webkit.org/show_bug.cgi?id=94449

Reviewed by Antonio Gomes.

Source/WebCore:

Makes each separate word a separate subtarget when context menu triggers
selections, and only the selected part of a partial selected node a
target when selections are not overridden.

Fix of reverted commit r126026, fix misplaced ASSERT.

Test: touchadjustment/context-menu-text-subtargets.html

* page/TouchAdjustment.cpp:
(TouchAdjustment):
(WebCore::TouchAdjustment::providesContextMenuItems):
(WebCore::TouchAdjustment::appendQuadsToSubtargetList):
(WebCore::TouchAdjustment::appendBasicSubtargetsForNode):
(WebCore::TouchAdjustment::appendContextSubtargetsForNode):
(WebCore::TouchAdjustment::compileSubtargetList):
(WebCore::findBestClickableCandidate):
(WebCore::findBestContextMenuCandidate):

LayoutTests:

Tests that touch-adjustment can adjust to the right subtargets within text-nodes.

* touchadjustment/context-menu-select-text.html:
* touchadjustment/context-menu-text-subtargets-expected.txt: Added.
* touchadjustment/context-menu-text-subtargets.html: Added.
* touchadjustment/resources/touchadjustment.js:
(pointToString):
(shouldBeWithin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [WebGL] Generic framework draft for tracking WebGL resources
caseq@chromium.org [Wed, 22 Aug 2012 09:19:06 +0000 (09:19 +0000)]
Web Inspector: [WebGL] Generic framework draft for tracking WebGL resources
https://bugs.webkit.org/show_bug.cgi?id=90597

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-22
Reviewed by Pavel Feldman.

Wrap WebGL rendering context methods and collect a trace log if we are in capturing mode.
Stubbed code for collecting calls contributing to a WebGL resource state so that we could replay them later.

Typical scenario:
- we wrap a GL context with InjectedScript.wrapWebGLContext() and return a proxy to the inspected page
- the proxy saves all calls necessary to do a replay later - only those that modify a resource's state
- when we turn on capturing mode (InjectedScript.captureFrame), we save all WebGL calls to a trace log

* inspector/InjectedScriptSource.js:
(.):
* inspector/InjectedScriptWebGLModuleSource.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][GTK] REGRESSION(r126194): http/tests/security/contentSecurityPolicy/register...
ossy@webkit.org [Wed, 22 Aug 2012 09:10:23 +0000 (09:10 +0000)]
[Qt][GTK] REGRESSION(r126194): http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html fails
https://bugs.webkit.org/show_bug.cgi?id=94677

Unreviewed gardening.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-08-22

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Wed, 22 Aug 2012 09:09:54 +0000 (09:09 +0000)]
[Qt] Unreviewed gardening.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-08-22

* http/tests/inspector/console-resource-errors-expected.txt: Rebaseline after r126168.
* platform/qt/Skipped: Skip tests using disabled SHADOW_DOM feature.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [WebGL] Add minimum transport protocol from backend to frontend
caseq@chromium.org [Wed, 22 Aug 2012 08:50:22 +0000 (08:50 +0000)]
Web Inspector: [WebGL] Add minimum transport protocol from backend to frontend
https://bugs.webkit.org/show_bug.cgi?id=88973

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-22
Reviewed by Pavel Feldman.

Added the following protocol methods to communicate with the WebGL injected
module: captureFrame, getTraceLog, dropTraceLog, replayTraceLog.

* inspector/CodeGeneratorInspector.py:
* inspector/InjectedScriptWebGLModule.cpp:
(WebCore::InjectedScriptWebGLModule::captureFrame):
(WebCore):
(WebCore::InjectedScriptWebGLModule::dropTraceLog):
(WebCore::InjectedScriptWebGLModule::getTraceLog):
(WebCore::InjectedScriptWebGLModule::replayTraceLog):
* inspector/InjectedScriptWebGLModule.h:
(InjectedScriptWebGLModule):
* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorWebGLAgent.cpp:
(WebCore::InspectorWebGLAgent::InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::dropTraceLog):
(WebCore):
(WebCore::InspectorWebGLAgent::captureFrame):
(WebCore::InspectorWebGLAgent::getTraceLog):
(WebCore::InspectorWebGLAgent::replayTraceLog):
* inspector/InspectorWebGLAgent.h:
(WebCore):
(WebCore::InspectorWebGLAgent::create):
(InspectorWebGLAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unused field DeleteEntryRequest::m_type
hans@chromium.org [Wed, 22 Aug 2012 08:47:53 +0000 (08:47 +0000)]
Remove unused field DeleteEntryRequest::m_type
https://bugs.webkit.org/show_bug.cgi?id=94680

Unreviewed build fix.

Remove this unused field. Clang warns about it and it breaks the
Chromium build.

No change in functionality, no new tests.

* inspector/InspectorFileSystemAgent.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 22 Aug 2012 08:45:17 +0000 (08:45 +0000)]
[Chromium] Unreviewed gardening.

Rebaseline tests after http://trac.webkit.org/changeset/126219 .

These are the same results as platform/mac-lion, which until
r126219 were the results of platform/mac. So this is "reverting"
r126219 in terms of Chromium expectations.

* platform/chromium/fast/text/hyphenate-locale-expected.png: Added.
* platform/chromium/fast/text/hyphenate-locale-expected.txt: Added.
* platform/chromium/fast/text/justify-ideograph-vertical-expected.png: Added.
* platform/chromium/fast/text/justify-ideograph-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Avoid using WebKit macros in qrawwebview_p.h
commit-queue@webkit.org [Wed, 22 Aug 2012 08:44:21 +0000 (08:44 +0000)]
[Qt] Avoid using WebKit macros in qrawwebview_p.h
https://bugs.webkit.org/show_bug.cgi?id=94648

Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2012-08-22
Reviewed by Noam Rosenthal.

ENABLE(FEATURE) should not be used in qrawwebview_p.h because it is an API header file.

* UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebView::sendTouchEvent):
* UIProcess/API/qt/raw/qrawwebview_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: console.time() should use performance.now()
caseq@chromium.org [Wed, 22 Aug 2012 08:42:57 +0000 (08:42 +0000)]
Web Inspector: console.time() should use performance.now()
https://bugs.webkit.org/show_bug.cgi?id=94263

Reviewed by Pavel Feldman.

- use monotonicallyIncreasingTime() instead of currentTime() for measuring time intervals
    with console.time()/console.timeEnd()
- adjust precision to 3 digits after decimal point (i.e. microseconds) when formatting intervals;

* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::stopTiming):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDynamically styling ShadowDom content on a node distributed to another shadow inserti...
commit-queue@webkit.org [Wed, 22 Aug 2012 08:20:40 +0000 (08:20 +0000)]
Dynamically styling ShadowDom content on a node distributed to another shadow insertion point fails.
https://bugs.webkit.org/show_bug.cgi?id=92899

Patch by Takashi Sakamoto <tasak@google.com> on 2012-08-22
Reviewed by Hajime Morita.

Source/WebCore:

Since childNeedsStyleRecalc is not cleared when parent nodes are
attached, setNeedsStyleRecalc flag is not reached Document. So,
document() doesn't run re-layout.

Test: fast/dom/shadow/shadowdom-dynamic-styling.html

* dom/ContainerNode.h:
(ContainerNode):
(WebCore::ContainerNode::detachAsNode):
Removed detachAsNode, because the below change made the method
not-used.
* dom/Element.cpp:
(WebCore::Element::detach):
Modify to invoke ContainerNode::detach when any shadow subtree is
attached. ContainerNode::detach takes care of childNeedsStyleRecalc
flag.
* dom/ElementShadow.cpp:
(WebCore::ElementShadow::invalidateDistribution):
Use SetAttached for lazyAttach instead of DoNotSetAttached, because
it is reuired to invoke ContainerNode::detach. If not, attached() is
false and reattach() invokes only attach(). This causes to leave
shadow host's childNeedsStyleRecalc flag true after
Element::recalcStyle.

LayoutTests:

* fast/dom/shadow/shadowdom-dynamic-styling-expected.txt: Added.
* fast/dom/shadow/shadowdom-dynamic-styling.html: Added.
* editing/shadow/delete-characters-in-distributed-node-crash.html:
Made the layout test robust. This patch causes commit-queue- and the
failed test is delete-characters-in-distributed-node-crash.html.
However the layout test passes when locally running run_webkit_test
i.e. no difference between actual and expected texts. And looking at
the commit-queue's report, the actual text has "PASS" message (no
crash messages).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Wed, 22 Aug 2012 08:11:52 +0000 (08:11 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-22

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Add deleteEntry command and deletionCompleted event to FileSystemAgent
commit-queue@webkit.org [Wed, 22 Aug 2012 07:50:35 +0000 (07:50 +0000)]
Web Inspector: Add deleteEntry command and deletionCompleted event to FileSystemAgent
https://bugs.webkit.org/show_bug.cgi?id=91831

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-22
Reviewed by Vsevolod Vlasov.

InspectorAgent-side implementation of deleteEntry command.

Test will be added after JS-side implementation landed.

* inspector/Inspector.json:
* inspector/InspectorFileSystemAgent.cpp:
(WebCore):
(WebCore::InspectorFileSystemAgent::requestFileSystemRoot):
(WebCore::InspectorFileSystemAgent::requestDirectoryContent):
(WebCore::InspectorFileSystemAgent::requestMetadata):
(WebCore::InspectorFileSystemAgent::requestFileContent):
(WebCore::InspectorFileSystemAgent::deleteEntry):
(WebCore::InspectorFileSystemAgent::assertFrontend):
* inspector/InspectorFileSystemAgent.h:
(InspectorFileSystemAgent):
* inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemDispatcher.prototype.fileContentReceived):
(WebInspector.FileSystemDispatcher.prototype.deletionCompleted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, adding myself to committers.py.
dominik.rottsches@intel.com [Wed, 22 Aug 2012 07:49:36 +0000 (07:49 +0000)]
Unreviewed, adding myself to committers.py.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 22 Aug 2012 07:42:19 +0000 (07:42 +0000)]
[Chromium] Unreviewed gardening.

Rebaseline tests after http://trac.webkit.org/changeset/126187 .
These are the same results as platform/mac-lion, which until
r126187 were the results of platform/mac. So this is "reverting"
r126187 in terms of Chromium expectations.
https://bugs.webkit.org/show_bug.cgi?id=94665 was filed
to track optimization of these baselines.

* platform/chromium-mac-snowleopard/fast/writing-mode/text-orientation-basic-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/writing-mode/vertical-align-table-baseline-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/writing-mode/vertical-align-table-baseline-expected.txt: Added.
* platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.txt: Added.
* platform/chromium-mac/fast/writing-mode/vertical-align-table-baseline-expected.png:
* platform/chromium-mac/fast/writing-mode/vertical-align-table-baseline-expected.txt: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 22 Aug 2012 07:31:42 +0000 (07:31 +0000)]
[Chromium] Unreviewed gardening.

Update image expectations for these tests. The 'x' to clear out a
text field is slightly brighter on chromium-mac; this is not
material to the intent of the tests.

* platform/chromium-mac/fast/css/text-overflow-input-expected.png:
* platform/chromium-mac/fast/forms/box-shadow-override-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 22 Aug 2012 07:24:58 +0000 (07:24 +0000)]
[Chromium] Unreviewed gardening.

Add failure expectations for a regression in r126257. See
https://bugs.webkit.org/show_bug.cgi?id=94675

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: TabbedPane: measure tab widths in batches.
pfeldman@chromium.org [Wed, 22 Aug 2012 06:58:30 +0000 (06:58 +0000)]
Web Inspector: TabbedPane: measure tab widths in batches.
https://bugs.webkit.org/show_bug.cgi?id=94484

Reviewed by Vsevolod Vlasov.

Source/WebCore:

- Introduces global batch update schema
- Migrates Toolbar and TabbedPane to the new schema

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype.appendTab):
(WebInspector.TabbedPane.prototype._updateTabElements):
(WebInspector.TabbedPane.prototype._innerUpdateTabElements):
(WebInspector.TabbedPane.prototype._updateWidths):
(WebInspector.TabbedPane.prototype._measureWidths):
(WebInspector.TabbedPaneTab):
(WebInspector.TabbedPaneTab.prototype.width):
(WebInspector.TabbedPaneTab.prototype.setWidth):
* inspector/front-end/Toolbar.js:
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype._updateDropdownButtonAndHideDropdown):
(WebInspector.Toolbar.prototype._innerUpdateDropdownButtonAndHideDropdown):
* inspector/front-end/UIUtils.js:
(WebInspector.startBatchUpdate):
(WebInspector.invokeOnceAfterBatchUpdate.get if):
(WebInspector.invokeOnceAfterBatchUpdate):
* inspector/front-end/inspector.js:
* inspector/front-end/utilities.js:

LayoutTests:

* inspector/start-end-batch-update-expected.txt: Added.
* inspector/start-end-batch-update.html: Added.
* inspector/tabbed-pane-tabs-to-show.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] contextClick and getMenuItemTitle callbacks are leaky in DRT's EventSender
commit-queue@webkit.org [Wed, 22 Aug 2012 06:47:38 +0000 (06:47 +0000)]
[GTK] contextClick and getMenuItemTitle callbacks are leaky in DRT's EventSender
https://bugs.webkit.org/show_bug.cgi?id=94669

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-21
Reviewed by Carlos Garcia Campos.

Fix memory leaks in DRT's EventSender code.

* DumpRenderTree/gtk/EventSender.cpp:
(getMenuItemTitleCallback): Use JSRetainPtr and don't leak.
(contextClickCallback): Use GOwnPtr to manage memory of a
newly-allocated list automatically.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 22 Aug 2012 06:43:53 +0000 (06:43 +0000)]
[Chromium] Unreviewed gardening.

Restore expected results for Chromium after r126219. See
https://bugs.webkit.org/show_bug.cgi?id=94672 .

* platform/chromium/fast/text/emphasis-combined-text-expected.png: Added.
* platform/chromium/fast/text/emphasis-combined-text-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 22 Aug 2012 05:46:33 +0000 (05:46 +0000)]
[Chromium] Unreviewed gardening.

Rebaseline tests after http://trac.webkit.org/changeset/126183 .
These are the same results as platform/mac-lion, which until
r126183 where the results of platform/mac. So this is "reverting"
r126183 in terms of Chromium expectations.
https://bugs.webkit.org/show_bug.cgi?id=94665 was filed
to track optimization of these baselines.

* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Added.
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Added.
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Added.
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 22 Aug 2012 05:19:09 +0000 (05:19 +0000)]
[Chromium] Unreviewed gardening.

Fix TestExpectations syntax error WIN WIN7 => WIN.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 22 Aug 2012 05:04:18 +0000 (05:04 +0000)]
[Chromium] Unreviewed gardening.

Rebaseline tests after http://trac.webkit.org/changeset/126225 .
These are the same results as platform/mac-lion, which until
r126225 where the results of platform/mac. So this is "reverting"
r126225 in terms of Chromium expectations.
https://bugs.webkit.org/show_bug.cgi?id=94665 was filed
to track optimization of these baselines.

* platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.txt: Added.
* platform/chromium-mac/css2.1/t1202-counter-04-b-expected.txt: Added.
* platform/chromium-mac/css2.1/t1202-counters-04-b-expected.txt: Added.
* platform/chromium-mac/fast/text/fallback-traits-fixup-expected.txt: Added.
* platform/chromium-mac/fast/text/international/text-combine-image-test-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Move String related code in V8Binding to a separate file
haraken@chromium.org [Wed, 22 Aug 2012 04:42:25 +0000 (04:42 +0000)]
[V8] Move String related code in V8Binding to a separate file
https://bugs.webkit.org/show_bug.cgi?id=94571

Reviewed by Adam Barth.

This patch moves V8Parameter, V8ParameterBase and String related code
in V8Binding to a separate file.

No tests. No change in behavior.

* UseV8.cmake:
* WebCore.gypi:
* bindings/v8/V8Binding.cpp:
* bindings/v8/V8Binding.h:
* bindings/v8/V8StringResource.cpp: Added.
* bindings/v8/V8StringResource.h: Added.
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 22 Aug 2012 04:36:37 +0000 (04:36 +0000)]
[Chromium] Unreviewed gardening.

Rebaseline tests after http://trac.webkit.org/changeset/126225 .
https://bugs.webkit.org/show_bug.cgi?id=94665 filed to track
optimization of these baselines.

* platform/chromium-linux-x86/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
* platform/chromium-linux/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
* platform/chromium-mac-snowleopard/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
* platform/chromium-mac/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
* platform/chromium-win-xp/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
* platform/chromium-win/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Added file somehow missed by garden-o-matic in last rebaseline.
kbr@google.com [Wed, 22 Aug 2012 04:19:59 +0000 (04:19 +0000)]
Unreviewed gardening. Added file somehow missed by garden-o-matic in last rebaseline.

* platform/chromium/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 22 Aug 2012 03:58:46 +0000 (03:58 +0000)]
[Chromium] Unreviewed gardening.

Add test expectations for regression in r126250. See bug 94667.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement UndoManager's automatic DOM transactions
commit-queue@webkit.org [Wed, 22 Aug 2012 03:56:30 +0000 (03:56 +0000)]
Implement UndoManager's automatic DOM transactions
https://bugs.webkit.org/show_bug.cgi?id=91812

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-08-21
Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch implements automatic DOM transactions in UndoManager
by recording changes in tree structure, attributes, and character data
of nodes under undo scope host.

Tests: editing/undomanager/automatic-transaction-attribute.html
       editing/undomanager/automatic-transaction-data.html
       editing/undomanager/automatic-transaction-node.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/DOMTransaction.h:
(WebCore::DOMTransaction::addTransactionStep):
(DOMTransaction):
* bindings/v8/DOMTransaction.cpp:
(DOMTransactionScope):
(WebCore::DOMTransactionScope::DOMTransactionScope):
(WebCore::DOMTransactionScope::~DOMTransactionScope):
(WebCore):
(WebCore::DOMTransaction::apply):
(WebCore::DOMTransaction::unapply):
(WebCore::DOMTransaction::reapply):
* bindings/v8/DOMTransaction.h:
(WebCore::DOMTransaction::addTransactionStep):
(DOMTransaction):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
* dom/CharacterData.cpp:
(WebCore::CharacterData::setDataAndUpdate):
* dom/ContainerNode.cpp:
(WebCore::willRemoveChild):
(WebCore::willRemoveChildren):
(WebCore::updateTreeAfterInsertion):
* dom/Element.cpp:
(WebCore::Element::willModifyAttribute):
* editing/DOMTransactionStep.cpp: Added.
(WebCore):
(WebCore::NodeInsertingDOMTransactionStep::NodeInsertingDOMTransactionStep):
(WebCore::NodeInsertingDOMTransactionStep::create):
(WebCore::NodeInsertingDOMTransactionStep::unapply):
(WebCore::NodeInsertingDOMTransactionStep::reapply):
(WebCore::NodeRemovingDOMTransactionStep::NodeRemovingDOMTransactionStep):
(WebCore::NodeRemovingDOMTransactionStep::create):
(WebCore::NodeRemovingDOMTransactionStep::unapply):
(WebCore::NodeRemovingDOMTransactionStep::reapply):
(WebCore::DataReplacingDOMTransactionStep::DataReplacingDOMTransactionStep):
(WebCore::DataReplacingDOMTransactionStep::create):
(WebCore::DataReplacingDOMTransactionStep::unapply):
(WebCore::DataReplacingDOMTransactionStep::reapply):
(WebCore::AttrChangingDOMTransactionStep::AttrChangingDOMTransactionStep):
(WebCore::AttrChangingDOMTransactionStep::create):
(WebCore::AttrChangingDOMTransactionStep::unapply):
(WebCore::AttrChangingDOMTransactionStep::reapply):
* editing/DOMTransactionStep.h: Added.
(WebCore):
(DOMTransactionStep):
(WebCore::DOMTransactionStep::~DOMTransactionStep):
(NodeInsertingDOMTransactionStep):
(NodeRemovingDOMTransactionStep):
(DataReplacingDOMTransactionStep):
(AttrChangingDOMTransactionStep):
* editing/UndoManager.cpp:
(WebCore):
(WebCore::UndoManager::isRecordingAutomaticTransaction):
(WebCore::UndoManager::addTransactionStep):
* editing/UndoManager.h:
(WebCore):
(WebCore::UndoManager::setRecordingDOMTransaction):
(UndoManager):

LayoutTests:

* editing/undomanager/automatic-transaction-attribute-expected.txt: Added.
* editing/undomanager/automatic-transaction-attribute.html: Added.
* editing/undomanager/automatic-transaction-data-expected.txt: Added.
* editing/undomanager/automatic-transaction-data.html: Added.
* editing/undomanager/automatic-transaction-node-expected.txt: Added.
* editing/undomanager/automatic-transaction-node.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix cross-direction stretch for replaced elements in row flexbox
commit-queue@webkit.org [Wed, 22 Aug 2012 03:35:38 +0000 (03:35 +0000)]
Fix cross-direction stretch for replaced elements in row flexbox
https://bugs.webkit.org/show_bug.cgi?id=94237

Patch by Shezan Baig <sbaig1@bloomberg.net> on 2012-08-21
Reviewed by Ojan Vafai.

Source/WebCore:

When stretching, don't take into account the instrinsic size of child
replaced elements. Only the fixed size, min size, and max size of the
child should be taken into account. The logic that computed this was
moved from RenderBox::computeLogicalHeight to a new helper method
called logicalHeightConstrainedByMinMax.  This helper method is now
used from RenderFlexibleBox::applyStretchAlignmentToChild, instead of
using RenderBox::computeLogicalHeight.

A similar change will need to be made for column-flowing flexboxes.
This will be addressed in https://webkit.org/b/94604.

No new tests.  The existing css3/flexbox/flexitem.html test was
extended to cover this case.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::logicalHeightConstrainedByMinMax): New helper
method that is used by RenderBox::computeLogicalHeight and also by
RenderFlexibleBox::applyStretchAlignmentToChild.
(WebCore):
(WebCore::RenderBox::computeLogicalHeight): Updated to use the new
logicalHeightConstrainedByMinMax helper method.
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild): Use
logicalHeightConstrainedByMinMax instead of computeLogicalHeight.

LayoutTests:

Fix test cases for images stretching in the cross direction. Also,
added test cases for stretching/shrinking iframes, seamless iframes,
and also tests for vertically flowing flexboxes.

* css3/flexbox/flexitem-expected.txt:
* css3/flexbox/flexitem.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake an event object clonable to support an event propagation across seamless iframes.
hayato@chromium.org [Wed, 22 Aug 2012 03:11:50 +0000 (03:11 +0000)]
Make an event object clonable to support an event propagation across seamless iframes.
https://bugs.webkit.org/show_bug.cgi?id=93678

Reviewed by Dimitri Glazkov.

We should clone an event object when a event propagates across
seamless iframes.  Currently Event and MouseEvent are
supported. Support for other kinds of events will be addressed
later.

This is one of the pre-requirements to support an event
propagation across seamless iframes.

No new tests, no behavior change.

* dom/Event.cpp:
(WebCore::Event::cloneFor):
(WebCore):
* dom/Event.h:
(WebCore):
(Event):
* dom/MouseEvent.cpp:
(WebCore::adjustedClinetX):
(WebCore):
(WebCore::adjustedClinetY):
(WebCore::MouseEvent::cloneFor):
* dom/MouseEvent.h:
(MouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardening. Rebaseline tests after http://trac.webkit.org/changese...
kbr@google.com [Wed, 22 Aug 2012 03:10:55 +0000 (03:10 +0000)]
Unreviewed Chromium gardening. Rebaseline tests after trac.webkit.org/changeset/126225 .
https://bugs.webkit.org/show_bug.cgi?id=94665 filed to track optimization of these baselines.

* platform/chromium-linux-x86/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
* platform/chromium-linux-x86/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
* platform/chromium-linux-x86/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
* platform/chromium-linux-x86/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
* platform/chromium-linux/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
* platform/chromium-linux/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
* platform/chromium-linux/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
* platform/chromium-linux/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
* platform/chromium-mac/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
* platform/chromium-mac/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
* platform/chromium-mac/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
* platform/chromium-mac/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
* platform/chromium-win-xp/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
* platform/chromium-win-xp/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
* platform/chromium-win-xp/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
* platform/chromium-win-xp/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
* platform/chromium-win/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
* platform/chromium-win/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
* platform/chromium-win/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
* platform/chromium-win/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
* platform/chromium/platform/chromium/virtual/gpu/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
* platform/chromium/platform/chromium/virtual/gpu/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
* platform/chromium/platform/chromium/virtual/gpu/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Added.
* platform/chromium/platform/chromium/virtual/gpu/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: IDBRequest can be GCd during event dispatch
jsbell@chromium.org [Wed, 22 Aug 2012 02:43:47 +0000 (02:43 +0000)]
IndexedDB: IDBRequest can be GCd during event dispatch
https://bugs.webkit.org/show_bug.cgi?id=94235

Reviewed by Ojan Vafai.

Source/WebCore:

Avoid a "race" where GC may attempt to reclaim IDB objects that are marked
"done" prior to the completion of the event dispatch. The script runtime
may decide to do a GC pass before calling the event handler, releasing the
object and turning the dispatch into a no-op.

This is a partial reversion (with renames, etc) of r123275, r124842,
and r121492. Added a new test, although it does not exercise the "race"
condition directly.

Test: storage/indexeddb/pending-activity.html
      storage/indexeddb/pending-activity-workers.html

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::close): Let the IDBRequest know it this cursor won't
make it fire again.
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest): Reintroduce "am I done?" flag.
(WebCore::IDBRequest::finishCursor): Cursors may fire events at the same
IDBRequest repeatedly, so we need to know when they're are really done.
(WebCore):
(WebCore::IDBRequest::hasPendingActivity): Test the flag.
(WebCore::IDBRequest::dispatchEvent): Set the flag.
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::IDBTransaction): Reintroduce "am I done?" flag.
(WebCore::IDBTransaction::hasPendingActivity): Test the flag.
(WebCore::IDBTransaction::dispatchEvent): Set the flag.
* Modules/indexeddb/IDBTransaction.h:

LayoutTests:

Release references to IDBRequest and IDBTransaction objects and force GC,
to ensure that pending events are still fired. (Doesn't exercise race
condition where GC is triggered by script during dispatch itself, though.)

* storage/indexeddb/pending-activity-expected.txt: Added.
* storage/indexeddb/pending-activity-workers-expected.txt: Added.
* storage/indexeddb/pending-activity-workers.html: Added.
* storage/indexeddb/pending-activity.html: Added.
* storage/indexeddb/resources/pending-activity.js: Added.
(test):
(prepareDatabase.request.onsuccess.request.onsuccess.request.onsuccess):
(prepareDatabase.request.onsuccess.request.onsuccess):
(prepareDatabase.request.onsuccess):
(prepareDatabase):
(testTransaction):
(transactionOnComplete):
(testRequest):
(requestOnSuccess):
(testCursorRequest):
(cursorRequestOnFirstSuccess):
(cursorRequestOnSecondSuccess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [regression] Settings panel fails to open.
pfeldman@chromium.org [Wed, 22 Aug 2012 02:39:50 +0000 (02:39 +0000)]
Web Inspector: [regression] Settings panel fails to open.
https://bugs.webkit.org/show_bug.cgi?id=94647

Unreviewed: one line JS front-end fix.

* inspector/front-end/ScriptsSearchScope.js:
* inspector/front-end/Settings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorange-hit-test-with-padding.html fails unless subpixel layout is on
keishi@webkit.org [Wed, 22 Aug 2012 02:17:33 +0000 (02:17 +0000)]
range-hit-test-with-padding.html fails unless subpixel layout is on
https://bugs.webkit.org/show_bug.cgi?id=94585

Reviewed by Kent Tamura.

Ports without subpixel layout didn't exactly match the result, because slider thumb width is an odd number and we are dividing it by two.

* fast/forms/range/range-hit-test-with-padding-expected.txt:
* fast/forms/range/range-hit-test-with-padding.html: Adjust the max so it snaps to the step in the middle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in RenderTableSection::setCellLogicalWidths
jchaffraix@webkit.org [Wed, 22 Aug 2012 02:16:02 +0000 (02:16 +0000)]
Crash in RenderTableSection::setCellLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=94291

Reviewed by Abhishek Arya.

Source/WebCore:

This issue was that splitAnonymousBoxesAroundChild would move a table section
into a newly created table *without* marking it as needing cell recalc. The table
would thus never build its structure to match its sections. The fix is to hop on
the new willBeRemovedFromTree signal so that the section invalidates itself properly.

Test: fast/table/crash-split-table-section-no-cell-recalc.html

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::willBeRemovedFromTree):
* rendering/RenderTableSection.h:
Replaced willBeDestroyed by willBeRemovedFromTree in RenderTableSection. This ensures that it is called
when moving sections in the tree to mark them as needing cell recalc.

LayoutTests:

* fast/table/crash-split-table-section-no-cell-recalc-expected.txt: Added.
* fast/table/crash-split-table-section-no-cell-recalc.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms] multiple fields time input UI should not have two focus ring.
yosin@chromium.org [Wed, 22 Aug 2012 02:05:51 +0000 (02:05 +0000)]
[Forms] multiple fields time input UI should not have two focus ring.
https://bugs.webkit.org/show_bug.cgi?id=94579

Reviewed by Hajime Morita.

Source/WebCore:

This patch adds CSS selectors to override focus style for multiple
fields time input UI.

No new tests. fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html
is updated for including focus state appearance.

* css/html.css:
(input::-webkit-datetime-edit-ampm-field:focus): Override default focus appearance.
(input::-webkit-datetime-edit-hour-field:focus): ditto
(input::-webkit-datetime-edit-millisecond-field:focus): ditto
(input::-webkit-datetime-edit-minute-field:focus): ditto
(input::-webkit-datetime-edit-second-field:focus): ditto

LayoutTests:

This patch adds a test case of focus appearance multiple fields time
input UI.

* fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.html: Added script to make focus appearance.
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html: Added script to set focus to input element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoV8 shouldn't have its own way of printing cross-origin error messages
abarth@webkit.org [Wed, 22 Aug 2012 01:50:40 +0000 (01:50 +0000)]
V8 shouldn't have its own way of printing cross-origin error messages
https://bugs.webkit.org/show_bug.cgi?id=94641

Reviewed by Eric Seidel.

Source/WebCore:

V8 used to re-implement (poorly) the code for printing out an error
message when a same-origin check failed. This patch deletes that code
in favor of just calling the WebCore version of the code. There more to
clean up here, but I had to stop before spidering over the whole
codebase.

* bindings/generic/BindingSecurity.cpp:
(WebCore::canAccessDocument):
* bindings/js/BindingState.cpp:
* bindings/js/BindingState.h:
* bindings/v8/BindingState.cpp:
(WebCore::printErrorMessageForFrame):
* bindings/v8/BindingState.h:
(WebCore):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::reportUnsafeJavaScriptAccess):
* bindings/v8/V8Proxy.cpp:
* bindings/v8/V8Proxy.h:
(V8Proxy):

LayoutTests:

Update these results to reflect the new error messages. These error
messages are both more correct and more like JavaScriptCore.

* platform/chromium/http/tests/security/cross-frame-access-private-browsing-expected.txt: Added.
    - We don't use the private browsing setting to implement private browsing.
* platform/chromium/http/tests/security/cross-frame-access-document-direct-expected.txt:
* platform/chromium/http/tests/security/inactive-document-with-empty-security-origin-expected.txt:
* platform/chromium/http/tests/security/listener/xss-inactive-closure-expected.txt:
* platform/chromium/http/tests/security/xss-eval-expected.txt:
    - Previously, we were incorrectly using the first script rather
      than the active script when printing the error message.
* platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt: Removed.
* platform/chromium/http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt: Removed.
* platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Removed.
* platform/chromium/http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Removed.
* platform/chromium/http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt: Removed.
* platform/chromium/http/tests/security/listener/xss-window-onclick-shortcut-expected.txt: Removed.
    - These results are now identical to JSC.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoA shadow element in ShadowDOM of a button element does not work.
shinyak@chromium.org [Wed, 22 Aug 2012 01:47:20 +0000 (01:47 +0000)]
A shadow element in ShadowDOM of a button element does not work.
https://bugs.webkit.org/show_bug.cgi?id=91486

Reviewed by Dimitri Glazkov.

Source/WebCore:

Since a button element is extended from an HTMLFormControlElement, it creates a UserAgentShadowDOM
just before adding an AuthorShadowDOM. However, actually a button element does not need any UserAgentShadowDOM.
So we have to prevent it from creating UserAgentShadowDOM.

Test: fast/dom/shadow/shadowdom-for-button.html

* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::willAddAuthorShadowRoot):
(WebCore):
* html/HTMLButtonElement.h:

LayoutTests:

* fast/dom/shadow/shadowdom-for-button-expected.html: Added.
* fast/dom/shadow/shadowdom-for-button.html: Added.
* fast/dom/shadow/shadowdom-for-form-associated-element-useragent-expected.txt:
* fast/dom/shadow/shadowdom-for-form-associated-element-useragent.html: a button element
does not have user agent shadow dom anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd mountain lion to perf-tests, layout tests
dpranke@chromium.org [Wed, 22 Aug 2012 01:45:48 +0000 (01:45 +0000)]
Add mountain lion to perf-tests, layout tests
https://bugs.webkit.org/show_bug.cgi?id=94553

Reviewed by Adam Barth.

This patch adds support for the 'mac-mountainlion' platform and
stamps out the last references to 'mac-leopard' as a supported
name.

This patch does a small amount of refactoring to try and make
things a little clearer how we treat the "most recent version"
specially for baselines and skipped files, and so you only
should have to touch the VERSION_FALLBACK_ORDER constants on the
ports, but unfortunately changing this list changes a bunch of
the unit tests which are doing exact matches for correctness, so
you have to touch more than a couple files :(. There's probably
still more refactoring that can be done so that we don't have to
do all of this functional testing to feel completely correct.

* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo._determine_mac_version):
* Scripts/webkitpy/common/system/platforminfo_unittest.py:
(TestPlatformInfo.test_os_version):
* Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort.__init__):
(ApplePort):
(ApplePort._skipped_file_search_paths):
(ApplePort._generate_all_test_configurations):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort):
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.test_mac):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort):
(MacPort._build_driver_flags):
(MacPort.should_retry_crashes):
(MacPort.default_baseline_search_path):
(MacPort.operating_system):
(MacPort.default_child_processes):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(MacTest):
(MacTest.test_skipped_file_search_paths):
(test_versions):
(test_baseline_search_path):
* Scripts/webkitpy/layout_tests/port/win.py:
(WinPort):
(WinPort.default_baseline_search_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardening. Suppress crashes of new test.
kbr@google.com [Wed, 22 Aug 2012 01:45:26 +0000 (01:45 +0000)]
Unreviewed Chromium gardening. Suppress crashes of new test.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove UndoManager's undoscope content attribute
commit-queue@webkit.org [Wed, 22 Aug 2012 01:42:43 +0000 (01:42 +0000)]
Remove UndoManager's undoscope content attribute
https://bugs.webkit.org/show_bug.cgi?id=94637

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-08-21
Reviewed by Ryosuke Niwa.

Source/WebCore:

No new tests. Covered by existing tests.

* bindings/v8/DOMTransaction.cpp:
(WebCore::DOMTransaction::callFunction):
* dom/Document.cpp:
(WebCore::Document::undoManager):
* dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore):
* dom/Element.h:
(Element):
* dom/Element.idl:
* dom/ElementRareData.h:
(ElementRareData):
* editing/UndoManager.cpp:
(WebCore::UndoManager::create):
(WebCore::UndoManager::UndoManager):
(WebCore::UndoManager::disconnect):
(WebCore::UndoManager::transact):
(WebCore::UndoManager::undo):
(WebCore::UndoManager::redo):
(WebCore::UndoManager::clearUndo):
(WebCore::UndoManager::clearRedo):
(WebCore):
* editing/UndoManager.h:
(WebCore):
(UndoManager):
(WebCore::UndoManager::document):
(WebCore::UndoManager::ownerNode):
* html/HTMLAttributeNames.in:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseAttribute):
(WebCore::HTMLElement::setContentEditable):

LayoutTests:

* editing/undomanager/undomanager-reenter-expected.txt: Copied from LayoutTests/editing/undomanager/undomanager-use-after-free-expected.txt.
* editing/undomanager/undomanager-reenter.html: Copied from LayoutTests/editing/undomanager/undomanager-use-after-free.html.
* editing/undomanager/undomanager-use-after-free-expected.txt: Removed.
* editing/undomanager/undomanager-use-after-free.html: Removed.
* editing/undomanager/undoscope-attribute-expected.txt: Removed.
* editing/undomanager/undoscope-attribute.html: Removed.
* editing/undomanager/undoscopehost-use-after-free.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSkipping http/tests/inspector/console-resource-errors.html.
commit-queue@webkit.org [Wed, 22 Aug 2012 01:40:27 +0000 (01:40 +0000)]
Skipping http/tests/inspector/console-resource-errors.html.
https://bugs.webkit.org/show_bug.cgi?id=94646.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-21
Reviewed by Brady Eidson.

Need to revert after https://bugs.webkit.org/show_bug.cgi?id=94640 is fixed.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] No accessible caret-moved events found in certain content
commit-queue@webkit.org [Wed, 22 Aug 2012 01:37:04 +0000 (01:37 +0000)]
[Gtk] No accessible caret-moved events found in certain content
https://bugs.webkit.org/show_bug.cgi?id=72811

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-08-21
Reviewed by Chris Fleizach.

Part of the bug is due to objects which should claim to implement AtkText
failed to do so as a result of containing a mixture of inline and block
spans.

An updated unit test was provided.

Source/WebCore:

* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(roleIsTextType): New method to check if a role is one expected to have
implemented the AtkText interface. Currently that is defined as:
 - ParagraphRole
 - HeadingRole
 - DivRole
 - CellRole
(getInterfaceMaskFromObject): If a role is one of the text type roles,
automatically add WAI_TEXT to the accessible object's interface mask.

Source/WebKit/gtk:

* tests/testatk.c:
(testWebkitAtkCaretOffsets): Added instances of objects containing a
mixture of inline and block spans and tested that they implement AtkText
and contain the right textual contents.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r126216.
commit-queue@webkit.org [Wed, 22 Aug 2012 01:29:22 +0000 (01:29 +0000)]
Unreviewed, rolling out r126216.
http://trac.webkit.org/changeset/126216
https://bugs.webkit.org/show_bug.cgi?id=94661

"Broke many Mac-WK2 tests" (Requested by bradee-oh on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-21

* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoForce XML comments to maintain whitespace
tony@chromium.org [Wed, 22 Aug 2012 01:26:49 +0000 (01:26 +0000)]
Force XML comments to maintain whitespace
https://bugs.webkit.org/show_bug.cgi?id=94620

Reviewed by Pavel Feldman.

Source/WebCore:

Fix a typo in XMLViewer.css for white-space formatting. This seems
like the desired behavior so you can see, e.g., code formatted in an
XML comment.

Covered by existing xmlviewer tests in http/tests/xmlviewer/dumpAsText

* xml/XMLViewer.css:
(.comment): Fix typo.
* xml/XMLViewer.js:
(createComment): Add style to comment nodes.

LayoutTests:

Update comments to include whitespace formatting.

* http/tests/xmlviewer/dumpAsText/xlink-expected.txt:
* http/tests/xmlviewer/dumpAsText/xmlviewer-expected.txt:
* http/tests/xmlviewer/dumpAsText/xul-expected.txt:
* platform/chromium/http/tests/xmlviewer/dumpAsText/mathml-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r126202.
commit-queue@webkit.org [Wed, 22 Aug 2012 01:11:05 +0000 (01:11 +0000)]
Unreviewed, rolling out r126202.
http://trac.webkit.org/changeset/126202
https://bugs.webkit.org/show_bug.cgi?id=94657

Causes assertion failures on Chromium Linux dbg compositing
layout tests (Requested by dominicc on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-21

Source/WebCore:

* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::applyFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCResourceProvider.cpp:
(WebCore::CCResourceProvider::createResource):
(WebCore::CCResourceProvider::createResourceFromExternalTexture):
(WebCore::CCResourceProvider::deleteResource):
(WebCore::CCResourceProvider::upload):
(WebCore::CCResourceProvider::lockForWrite):
(WebCore::CCResourceProvider::unlockForWrite):
(WebCore::CCResourceProvider::flush):
(WebCore::CCResourceProvider::shallowFlushIfSupported):
(WebCore::CCResourceProvider::lockForRead):
(WebCore::CCResourceProvider::unlockForRead):
(WebCore::CCResourceProvider::CCResourceProvider):
* platform/graphics/chromium/cc/CCResourceProvider.h:
(WebCore):
(CCResourceProvider):
(WebCore::CCResourceProvider::Resource::Resource):
(Resource):
(CCScopedLockResourceForRead):
(WebCore::CCScopedLockResourceForRead::CCScopedLockResourceForRead):
(WebCore::CCScopedLockResourceForRead::~CCScopedLockResourceForRead):
(WebCore::CCScopedLockResourceForRead::textureId):
(CCScopedLockResourceForWrite):
(WebCore::CCScopedLockResourceForWrite::CCScopedLockResourceForWrite):
(WebCore::CCScopedLockResourceForWrite::~CCScopedLockResourceForWrite):
(WebCore::CCScopedLockResourceForWrite::textureId):

Source/WebKit/chromium:

* tests/CCResourceProviderTest.cpp:
(WebKit::CCResourceProviderTest::CCResourceProviderTest):
(WebKit::CCResourceProviderTest::getResourcePixels):
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Fire error at request when abort is called in upgradeneeded
dgrogan@chromium.org [Wed, 22 Aug 2012 01:08:45 +0000 (01:08 +0000)]
IndexedDB: Fire error at request when abort is called in upgradeneeded
https://bugs.webkit.org/show_bug.cgi?id=94402

Reviewed by Tony Chang.

Source/WebCore:

Tests - updated intversion-abort-in-initial-upgradeneeded-expected.txt

* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndAbortFired):
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndCompleteFired):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
Now that second-half open calls don't get abandoned on the queue, we
can ASSERT that there's at most one of them at any time.

* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
Move setting m_didFireUpgradeNeededEvent before dispatching the event.
If abort is called in the event handler an error event will be
enqueued and ASSERT_WITH_MESSAGE(m_readyState == PENDING ||
m_didFireUpgradeNeededEvent, ...) needs to pass.

* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):

LayoutTests:

* storage/indexeddb/intversion-abort-in-initial-upgradeneeded-expected.txt:
Only remaining error in this test is versions not being reset in
memory.

* storage/indexeddb/resources/intversion-abort-in-initial-upgradeneeded.js:
(deleteSuccess):
(upgradeNeeded):
(onAbort):
(onError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r126233.
commit-queue@webkit.org [Wed, 22 Aug 2012 01:05:09 +0000 (01:05 +0000)]
Unreviewed, rolling out r126233.
http://trac.webkit.org/changeset/126233
https://bugs.webkit.org/show_bug.cgi?id=94656

Broke Chromium Mac build (Requested by dominicc on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-21

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/mediaControls.css:
(video::-webkit-media-text-track-display):
* html/shadow/MediaControlElements.cpp:
(RenderTextTrackContainerElement):
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
* html/track/TextTrack.cpp:
* html/track/TextTrack.h:
(TextTrack):
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::calculateComputedLinePosition):
(WebCore::TextTrackCue::calculateDisplayParameters):
(WebCore::TextTrackCue::getDisplayTree):
(WebCore::TextTrackCue::getPositionCoordinates):
* html/track/TextTrackCue.h:
(WebCore):
(TextTrackCue):
* rendering/RenderTextTrackCue.cpp: Removed.
* rendering/RenderTextTrackCue.h: Removed.

LayoutTests:

* media/track/captions-webvtt/captions-snap-to-lines-set.vtt: Removed.
* media/track/track-cue-rendering-horizontal.html: Removed.
* media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt:
* media/track/track-cue-rendering-vertical.html: Removed.
* media/video-test.js:
* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png: Removed.
* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png: Removed.
* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt: Removed.
* platform/chromium/TestExpectations:
* platform/mac/media/track/track-cue-rendering-horizontal-expected.png: Removed.
* platform/mac/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
* platform/mac/media/track/track-cue-rendering-vertical-expected.png: Removed.
* platform/mac/media/track/track-cue-rendering-vertical-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove getToStringName() and getToStringTemplate() from V8Binding
haraken@chromium.org [Wed, 22 Aug 2012 00:32:46 +0000 (00:32 +0000)]
[V8] Remove getToStringName() and getToStringTemplate() from V8Binding
https://bugs.webkit.org/show_bug.cgi?id=94573

Reviewed by Adam Barth.

- Remove V8Binding::getToStringName() and V8Binding::getToStringTemplate().

- Replace getToStringName() with String::NewSymbol("toString").

- Fix V8PerIsolateData::getToStringTemplate() so that it caches a persistent
handle of a created FunctionTemplate. Before this patch, a FunctionTemplate
had been created for each toString().

No tests. No change in behavior.

* bindings/v8/V8Binding.cpp:
(WebCore::constructorToString):
* bindings/v8/V8Binding.h:
(WebCore):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::ConfigureV8TestEventConstructorTemplate):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::ConfigureV8TestEventTargetTemplate):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::ConfigureV8TestExceptionTemplate):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::ConfigureV8TestInterfaceTemplate):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::ConfigureV8TestNamedConstructorTemplate):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::ConfigureV8TestNodeTemplate):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
* bindings/v8/V8PerIsolateData.h:
(V8PerIsolateData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] WebGL Aquarium fails to render
anilsson@rim.com [Wed, 22 Aug 2012 00:25:52 +0000 (00:25 +0000)]
[BlackBerry] WebGL Aquarium fails to render
https://bugs.webkit.org/show_bug.cgi?id=94634

The aquarium leaves with a glColorMask(false, false, false, true) which
caused us to fail to blit the color components of the aquarium to the
EGLImage.

Fixed by setting an appropriate color mask for a blit operation.

Reviewed by Yong Li.

No new tests, tested manually.

* platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:
(WebCore::EGLImageLayerWebKitThread::blitToFrontBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisplay a TextTrackCue when snap-to-lines flag is set
victor@rosedu.org [Wed, 22 Aug 2012 00:19:48 +0000 (00:19 +0000)]
Display a TextTrackCue when snap-to-lines flag is set
https://bugs.webkit.org/show_bug.cgi?id=79751

Reviewed by Tony Chang.

Source/WebCore:

This patch implements rendering functionality for a given text track,
following closer the exact WebVTT specification. There are two new classes
which have been added in order to succesfully cover rendering when of a text
track cue.

RenderTextTrackCue handles the specific rendering algorithm required,
by checking for overlaps with other boxes that are in the same
container (these can be any other boxes, not necessarily other cues,
the video controls, for example).

TextTrackCueBox extends HTMLDivElement and is an intermediate layer
between the renderer class and the actual cue object. Its purpose is
to instantiate the particular renderer and cover all the default CSS
styling that needs to be applied to the cue.

The layout is done in two steps:
  - Step 1: Layout the TextTrackCue with default CSS properties set (this is
the TextTrackCueBox decorated with the respective CSS elements)
  - Step 2: RenderTextTrackCue adjusts the box position depending on the
parameters of the TextTrackCue object and the overlaps that may occur with
previously positioned cues.

Tests: media/track/track-cue-rendering-horizontal.html
       media/track/track-cue-rendering-vertical.html

* CMakeLists.txt: Updated to include RenderTextTrackCue.
* GNUmakefile.list.am: Updated to include RenderTextTrackCue.
* Target.pri: Updated to include RenderTextTrackCue.
* WebCore.gypi: Updated to include RenderTextTrackCue.
* WebCore.vcproj/WebCore.vcproj: Updated to include RenderTextTrackCue.
* WebCore.xcodeproj/project.pbxproj: Updated to include RenderTextTrackCue.
* css/mediaControls.css: Removed unreliable CSS.
(video::-webkit-media-text-track-display): Removed properties.
* html/shadow/MediaControlElements.cpp: Updated to not use the new class.
(RenderTextTrackContainerElement):
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Simplified
the function by moving the check if track is rendered in TextTrack and used
the TextTrackCueBox for cues.
* html/track/TextTrack.cpp: Added a new method.
(WebCore::TextTrack::isRendered): Method that returns whether the track should
be rendered or not.
(WebCore):
* html/track/TextTrack.h: Added the isRendered method.
(TextTrack):
* html/track/TextTrackCue.cpp: Added several helper methods and
the TextTrackCueBox.
(WebCore):
(WebCore::TextTrackCueBox::TextTrackCueBox): The TextTrackCueBox extends
the HTMLDivElement and represents a bridge class between RenderTextTrackCue
and TextTrackCue. This is required as the layout is done in two steps, as
explained on top of the ChangeLog entry.
(WebCore::TextTrackCueBox::getCue): Returns the associated TextTrackCue object.
(WebCore::TextTrackCueBox::applyCSSProperties): Applies a part of the default CSS
properties, as defined by section 3.5.1 of the WebVTT specification.
(WebCore::TextTrackCueBox::shadowPseudoId): Moved the shadow pseudo id.
(WebCore::TextTrackCueBox::createRenderer): Creates the particular renderer.
(WebCore::TextTrackCue::TextTrackCue): Corrected the internal writing mode map.
(WebCore::TextTrackCue::calculateComputedLinePosition): Updated the compute line
position algorithm. This requires, however, a method to consider only rendered
tracks (and therefore will be addressed completely in subsequent changeset).
(WebCore::TextTrackCue::calculateDisplayParameters): Updated and corrected the
computed display parameters to match the current specification.
(WebCore::TextTrackCue::getDisplayTree): Update to use the TextTrackCueBox class
and moved CSS application to the respective class.
(WebCore::TextTrackCue::getPositionCoordinates): Added comment to specify in which
situation this method is used and change visibility to private.
(WebCore::TextTrackCue::getCSSWritingMode): Returns the CSS writing mode corresponding
to the cue writing mode.
(WebCore::TextTrackCue::getCSSSize): Returns the cue width / height (depending on the
writing direction.
(WebCore::TextTrackCue::getCSSPosition): Returns the default display position, that is
used in the first layout step.
* html/track/TextTrackCue.h:
(WebCore):
(TextTrackCueBox):
(WebCore::TextTrackCueBox::create): Initialization method.
(TextTrackCue):
(WebCore::TextTrackCue::getWritingDirection): Helper method to return the internal
values used to represent the writing direction.
* rendering/RenderTextTrackCue.cpp: Added.
(WebCore):
(WebCore::RenderTextTrackCue::RenderTextTrackCue):
(WebCore::RenderTextTrackCue::layout): The rendering steps, as mentioned in
the WebVTT rendering rules. Currently, this treats only the snap-to-lines set
case. It is implemented following closely the spec, and might be subject to
change as discussions on various bugs evolve.
(WebCore::RenderTextTrackCue::initializeLayoutParameters): Steps 1 - 7.
(WebCore::RenderTextTrackCue::placeBoxInDefaultPosition): Steps 8 - 10.
(WebCore::RenderTextTrackCue::isOutside): Inline method to check if the cue is outside.
(WebCore::RenderTextTrackCue::isOverlapping): Inline method to check if the cue overlaps other boxes.
(WebCore::RenderTextTrackCue::shouldSwitchDirection): Step 12.
(WebCore::RenderTextTrackCue::moveBoxesByStep): Step 13.
(WebCore::RenderTextTrackCue::switchDirection): Steps 15 - 18.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet): Cue repositioning
for text track cue when the snap to lines flag is set.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesNotSet): Cue repositioning
for text track cue when the snap to lines flag is not set. Not implemented yet.
* rendering/RenderTextTrackCue.h: Added.
(WebCore):
(RenderTextTrackCue): Rendering class, handling the display of cues.

LayoutTests:

Test cases covering snap-to-lines horizontal and vertical positioning of cues.

* media/track/captions-webvtt/captions-snap-to-lines-set.vtt: Added.
* media/track/track-cue-rendering-horizontal.html: Added.
* media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Updated.
* media/track/track-cue-rendering-vertical.html: Added.
* media/video-test.js: Updated to support pixel test dumps.
* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png: Added.
* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Added.
* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png: Added.
* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt: Added.
* platform/chromium/TestExpectations: Marking these temporarily as IMAGE fail, as they will
anyway require new baselines.
* platform/mac/media/track/track-cue-rendering-horizontal-expected.png: Added.
* platform/mac/media/track/track-cue-rendering-horizontal-expected.txt: Added.
* platform/mac/media/track/track-cue-rendering-vertical-expected.png: Added.
* platform/mac/media/track/track-cue-rendering-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Add option to only add JavaScript object 'qnx' to private webviews
commit-queue@webkit.org [Wed, 22 Aug 2012 00:18:43 +0000 (00:18 +0000)]
[BlackBerry] Add option to only add JavaScript object 'qnx' to private webviews
https://bugs.webkit.org/show_bug.cgi?id=94621

Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-08-21
Reviewed by Yong Li.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::enableQnxJavaScriptObject):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] [WK2] Memory leaks in TestWebKitFindController
commit-queue@webkit.org [Wed, 22 Aug 2012 00:18:39 +0000 (00:18 +0000)]
[GTK] [WK2] Memory leaks in TestWebKitFindController
https://bugs.webkit.org/show_bug.cgi?id=94627

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-21
Reviewed by Martin Robinson.

Fix memory leaks in TestWebKitFindController by using adoptGRef
instead of just getting new reference of GdkPixbuf.

* UIProcess/API/gtk/tests/TestWebKitFindController.cpp:
(testFindControllerHide):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Add RSS content handling support
commit-queue@webkit.org [Wed, 22 Aug 2012 00:14:41 +0000 (00:14 +0000)]
[BlackBerry] Add RSS content handling support
https://bugs.webkit.org/show_bug.cgi?id=93496

Patch by Lianghui Chen <liachen@rim.com> on 2012-08-21
Reviewed by Rob Buis.

Add code to filter RSS content, and properly convert them to HTML
content so they can display nicely, instead of as plain text.

Following modules are included:

RSSFilterStream: the code for detecting RSS content, and controlling
the handling of these content.

RSSParserBase: the base class for the following 3 RSS parser.
RSS10Parser: the code for decoding RSS 1.0 content.
RSS20Parser: the code for decoding RSS 2.0 content.
RSSAtomParser: the code for decoding Atom format RSS content.
RSSGenerator: the code for generating HTML content based on RSS feed.

No new tests as it's not changing how HTML content is handled.

* PlatformBlackBerry.cmake:
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::initialize):
* platform/network/blackberry/rss/RSS10Parser.cpp: Added.
(WebCore):
(WebCore::RSS10Parser::RSS10Parser):
(WebCore::RSS10Parser::parseBuffer):
(WebCore::RSS10Parser::parseXmlDoc):
(WebCore::RSS10Parser::parseItemBaseAttribute):
(WebCore::RSS10Parser::parseItem):
(WebCore::RSS10Parser::parseFeed):
* platform/network/blackberry/rss/RSS10Parser.h: Added.
(WebCore):
(RSS10Parser):
* platform/network/blackberry/rss/RSS20Parser.cpp: Added.
(WebCore):
(WebCore::RSS20Parser::RSS20Parser):
(WebCore::RSS20Parser::parseBuffer):
(WebCore::RSS20Parser::parseXmlDoc):
(WebCore::RSS20Parser::parseItemBaseAttribute):
(WebCore::RSS20Parser::parseItem):
(WebCore::RSS20Parser::parseFeed):
(WebCore::RSS20Parser::parseEnclosure):
* platform/network/blackberry/rss/RSS20Parser.h: Added.
(WebCore):
(RSS20Parser):
* platform/network/blackberry/rss/RSSAtomParser.cpp: Added.
(WebCore):
(WebCore::isRelativePath):
(WebCore::RSSAtomLink::relType):
(WebCore::RSSAtomParser::RSSAtomParser):
(WebCore::RSSAtomParser::parseBuffer):
(WebCore::RSSAtomParser::parseXmlDoc):
(WebCore::RSSAtomParser::parseItemBaseAttribute):
(WebCore::RSSAtomParser::parseItem):
(WebCore::RSSAtomParser::parseFeed):
(WebCore::RSSAtomParser::parseLink):
(WebCore::RSSAtomParser::enclosureFromLink):
(WebCore::RSSAtomParser::parseContent):
(WebCore::RSSAtomParser::parseAuthor):
(WebCore::RSSAtomParser::parseCategory):
* platform/network/blackberry/rss/RSSAtomParser.h: Added.
(WebCore):
(RSSAtomLink):
(WebCore::RSSAtomLink::RSSAtomLink):
(RSSAtomParser):
* platform/network/blackberry/rss/RSSFilterStream.cpp: Added.
(WebCore):
(WebCore::isASCIISpaceLowerByte):
(WebCore::stripWhiteSpace):
(WebCore::equalIgnoringCase):
(WebCore::isAtomMIMEType):
(WebCore::isRSSMIMEType):
(WebCore::isPotentialRSSMIMEType):
(WebCore::isRSSContent):
(WebCore::RSSTypeFromContentType):
(WebCore::RSSTypeFromContent):
(WebCore::createParser):
(WebCore::findXMLEncodingPosition):
(WebCore::findXMLLanguagePosition):
(WebCore::defaultEncodingForLanguage):
(WebCore::isTranscodingNeeded):
(WebCore::transcode):
(WebCore::transcodeContent):
(WebCore::RSSFilterStream::RSSFilterStream):
(WebCore::RSSFilterStream::notifyStatusReceived):
(WebCore::RSSFilterStream::notifyHeadersReceived):
(WebCore::RSSFilterStream::notifyDataReceived):
(WebCore::RSSFilterStream::notifyClose):
(WebCore::RSSFilterStream::convertContentToHtml):
(WebCore::RSSFilterStream::handleRSSContent):
(WebCore::RSSFilterStream::charset):
(WebCore::RSSFilterStream::encoding):
(WebCore::RSSFilterStream::saveHeaders):
(WebCore::RSSFilterStream::removeHeader):
(WebCore::RSSFilterStream::updateHeader):
(WebCore::RSSFilterStream::updateRSSHeaders):
(WebCore::RSSFilterStream::sendSavedHeaders):
(WebCore::RSSFilterStream::appendData):
* platform/network/blackberry/rss/RSSFilterStream.h: Added.
(WebCore):
(RSSFilterStream):
* platform/network/blackberry/rss/RSSGenerator.cpp: Added.
(WebCore):
(WebCore::RSSGenerator::RSSGenerator):
(WebCore::RSSGenerator::~RSSGenerator):
(WebCore::RSSGenerator::generateHtml):
* platform/network/blackberry/rss/RSSGenerator.h: Added.
(WebCore):
(RSSGenerator):
* platform/network/blackberry/rss/RSSParserBase.cpp: Added.
(WebCore):
(WebCore::RSSEnclosure::RSSEnclosure):
(WebCore::RSSEnclosure::typeInEnum):
(WebCore::RSSEnclosure::suggestedName):
(WebCore::RSSFeed::RSSFeed):
(WebCore::RSSFeed::~RSSFeed):
(WebCore::RSSFeed::clear):
(WebCore::RSSItem::RSSItem):
(WebCore::RSSItem::~RSSItem):
(WebCore::RSSItem::clear):
(WebCore::RSSParserBase::RSSParserBase):
(WebCore::RSSParserBase::~RSSParserBase):
(WebCore::textFromXMLAttr):
(WebCore::textFromXMLNode):
* platform/network/blackberry/rss/RSSParserBase.h: Added.
(WebCore):
(RSSEnclosure):
(RSSItemBase):
(RSSParserBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html is failing
zandobersek@gmail.com [Wed, 22 Aug 2012 00:14:20 +0000 (00:14 +0000)]
[GTK] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html is failing
https://bugs.webkit.org/show_bug.cgi?id=94617

Reviewed by Martin Robinson.

Tools:

Set the 'enable-file-access-from-file-uris' setting to true when
resetting default values. The other ports do this as well, giving
documents with local security origin permission to load other
local resources.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):

LayoutTests:

Remove failure expectation for fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html
test as it now passes.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntroducing the VMInspector for VM debugging use.
commit-queue@webkit.org [Wed, 22 Aug 2012 00:11:20 +0000 (00:11 +0000)]
Introducing the VMInspector for VM debugging use.
https://bugs.webkit.org/show_bug.cgi?id=94613.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-21
Reviewed by Filip Pizlo.

Adding some utility functions for debugging the VM. This code is
presently #ifdef'd out by default.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* interpreter/CallFrame.h:
(ExecState):
* interpreter/VMInspector.cpp: Added.
(JSC):
(JSC::VMInspector::getTypeName):
(JSC::VMInspector::dumpFrame0):
(JSC::VMInspector::dumpFrame):
(JSC::VMInspector::countFrames):
* interpreter/VMInspector.h: Added.
(JSC):
(VMInspector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] requestAnimationFrame: Unscheduled display link frames need to be sent...
commit-queue@webkit.org [Wed, 22 Aug 2012 00:07:56 +0000 (00:07 +0000)]
[BlackBerry] requestAnimationFrame: Unscheduled display link frames need to be sent to main thread
https://bugs.webkit.org/show_bug.cgi?id=94600

Patch by Andrew Lo <anlo@rim.com> on 2012-08-21
Reviewed by Rob Buis.

http://trac.webkit.org/changeset/116792 implements destroying
DisplayRefreshMonitor after the number of unscheduled frames exceeds 10.

Part of that change involves dispatching to the main thread whether
the frame was scheduled or not.

Make the corresponding change for the BlackBerry port that was made for
DisplayRefreshMonitorMac.cpp.

Tests covered by http://trac.webkit.org/changeset/116792

* platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:
(WebCore::DisplayRefreshMonitor::displayLinkFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium/Skia] Filters should flush the SkCanvas
commit-queue@webkit.org [Wed, 22 Aug 2012 00:06:23 +0000 (00:06 +0000)]
[Chromium/Skia] Filters should flush the SkCanvas
https://bugs.webkit.org/show_bug.cgi?id=94602

Patch by Brian Salomon <bsalomon@google.com> on 2012-08-21
Reviewed by Stephen White.

Adds a SkCanvas::flush call to FilterBufferState::swap() to ensure the textures are updated before they are consumed by the compositor.

Covered by existing css3/filters layout tests.

* platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline various tests for Mountain Lion that differ from the generic results.
beidson@apple.com [Tue, 21 Aug 2012 23:56:49 +0000 (23:56 +0000)]
Rebaseline various tests for Mountain Lion that differ from the generic results.

Unreviewed (Bot gardening).

* platform/mac-lion/fast/css/pseudo-any-expected.txt: Added.
* platform/mac-lion/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
* platform/mac-lion/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
* platform/mac-lion/sputnik/Unicode/Unicode_320/S7.6_A2.2_T2-expected.txt: Added.
* platform/mac-lion/sputnik/Unicode/Unicode_320/S7.6_A5.2_T8-expected.txt: Added.
* platform/mac/fast/css/pseudo-any-expected.txt: Added.
* platform/mac/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
* platform/mac/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
* platform/mac/sputnik/Unicode/Unicode_320/S7.6_A2.2_T2-expected.txt: Added.
* platform/mac/sputnik/Unicode/Unicode_320/S7.6_A5.2_T8-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[css3-text] Add repaint tests for -webkit-text-decoration-line
commit-queue@webkit.org [Tue, 21 Aug 2012 23:55:27 +0000 (23:55 +0000)]
[css3-text] Add repaint tests for -webkit-text-decoration-line
https://bugs.webkit.org/show_bug.cgi?id=94480

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-08-21
Reviewed by Julien Chaffraix.

Changeset r125205 introduced new CSS3 property "-webkit-text-decoration-line".
This patch adds repaint layout tests for this property.

* fast/css3-text-decoration/repaint/repaint-text-decoration-line-expected.png: Added.
* fast/css3-text-decoration/repaint/repaint-text-decoration-line-expected.txt: Added.
* fast/css3-text-decoration/repaint/repaint-text-decoration-line.html: Added.
Expected results generated from Chromium Linux build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Use new method to create socket handle
commit-queue@webkit.org [Tue, 21 Aug 2012 23:53:21 +0000 (23:53 +0000)]
[BlackBerry] Use new method to create socket handle
https://bugs.webkit.org/show_bug.cgi?id=89991

Patch by Lianghui Chen <liachen@rim.com> on 2012-08-21
Reviewed by Rob Buis.

Update the way to create SocketStream as the platform API has changed.

No new tests as no change of behaviour, just API change adaptation.

* platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Move compileScript() from V8Proxy to ScriptSourceCode
haraken@chromium.org [Tue, 21 Aug 2012 23:51:39 +0000 (23:51 +0000)]
[V8] Move compileScript() from V8Proxy to ScriptSourceCode
https://bugs.webkit.org/show_bug.cgi?id=94561

Reviewed by Adam Barth.

To kill V8Proxy, this patch moves compileScript() from V8Proxy
to ScriptSourceCode. This patch also removes fromWebCoreString().

No tests. No change in behavior.

* UseV8.cmake:
* WebCore.gypi:
* bindings/v8/ScriptController.h:
(ScriptController):
* bindings/v8/ScriptSourceCode.cpp: Added.
(WebCore):
(WebCore::ScriptSourceCode::compileScript):
* bindings/v8/ScriptSourceCode.h:
(ScriptSourceCode):
* bindings/v8/V8Binding.h:
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluate):
* bindings/v8/V8Proxy.h:
(V8Proxy):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::evaluate):
(WebCore::WorkerContextExecutionProxy::runScript):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::getEventListenersCallback):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline various tests for Mountain Lion where Mountain Lion specific results overr...
beidson@apple.com [Tue, 21 Aug 2012 23:45:23 +0000 (23:45 +0000)]
Rebaseline various tests for Mountain Lion where Mountain Lion specific results override current Lion specific results,
or in some cases match the generic results.

Unreviewed (Bot gardening).

* platform/mac-lion/canvas/philip/tests/2d.strokeRect.zero.5-expected.txt: Renamed from LayoutTests/platform/mac/canvas/philip/tests/2d.strokeRect.zero.5-expected.txt.
* platform/mac-lion/css2.1/t1202-counter-04-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t1202-counter-04-b-expected.png.
* platform/mac-lion/css2.1/t1202-counter-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counter-04-b-expected.txt.
* platform/mac-lion/css2.1/t1202-counters-04-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t1202-counters-04-b-expected.png.
* platform/mac-lion/css2.1/t1202-counters-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counters-04-b-expected.txt.
* platform/mac-lion/fast/text/emphasis-combined-text-expected.png: Renamed from LayoutTests/platform/mac/fast/text/emphasis-combined-text-expected.png.
* platform/mac-lion/fast/text/emphasis-combined-text-expected.txt: Copied from LayoutTests/platform/mac/fast/text/emphasis-combined-text-expected.txt.
* platform/mac-lion/fast/text/fallback-traits-fixup-expected.png: Copied from LayoutTests/platform/mac/fast/text/fallback-traits-fixup-expected.png.
* platform/mac-lion/fast/text/fallback-traits-fixup-expected.txt: Copied from LayoutTests/platform/mac/fast/text/fallback-traits-fixup-expected.txt.
* platform/mac-lion/fast/text/hyphenate-locale-expected.png: Renamed from LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.png.
* platform/mac-lion/fast/text/hyphenate-locale-expected.txt: Copied from LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt.
* platform/mac-lion/fast/text/international/hindi-spacing-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/hindi-spacing-expected.png.
* platform/mac-lion/fast/text/international/hindi-spacing-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/hindi-spacing-expected.txt.
* platform/mac-lion/fast/text/international/text-combine-image-test-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/text-combine-image-test-expected.png.
* platform/mac-lion/fast/text/international/text-combine-image-test-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/text-combine-image-test-expected.txt.
* platform/mac-lion/fast/text/international/vertical-text-glyph-test-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/vertical-text-glyph-test-expected.png.
* platform/mac-lion/fast/text/international/vertical-text-glyph-test-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt.
* platform/mac-lion/fast/text/justify-ideograph-vertical-expected.png: Renamed from LayoutTests/platform/mac/fast/text/justify-ideograph-vertical-expected.png.
* platform/mac-lion/fast/text/justify-ideograph-vertical-expected.txt: Copied from LayoutTests/platform/mac/fast/text/justify-ideograph-vertical-expected.txt.
* platform/mac-lion/http/tests/xmlhttprequest/web-apps/012-expected.txt: Renamed from LayoutTests/platform/mac/http/tests/xmlhttprequest/web-apps/012-expected.txt.
* platform/mac-lion/http/tests/xmlhttprequest/web-apps/013-expected.txt: Renamed from LayoutTests/platform/mac/http/tests/xmlhttprequest/web-apps/013-expected.txt.
* platform/mac-lion/media/audio-repaint-expected.png: Renamed from LayoutTests/platform/mac/media/audio-repaint-expected.png.
* platform/mac-lion/media/audio-repaint-expected.txt: Added.
* platform/mac-lion/media/video-size-intrinsic-scale-expected.txt: Renamed from LayoutTests/platform/mac/media/video-size-intrinsic-scale-expected.txt.
* platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.png: Renamed from LayoutTests/platform/mac/platform/mac/fast/text/vertical-surrogate-pair-expected.png.
* platform/mac-lion/platform/mac/fast/text/vertical-surrogate-pair-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/text/vertical-surrogate-pair-expected.txt.
* platform/mac/css2.1/t1202-counter-04-b-expected.png:
* platform/mac/css2.1/t1202-counter-04-b-expected.txt:
* platform/mac/css2.1/t1202-counters-04-b-expected.png:
* platform/mac/css2.1/t1202-counters-04-b-expected.txt:
* platform/mac/fast/text/emphasis-combined-text-expected.txt:
* platform/mac/fast/text/fallback-traits-fixup-expected.png:
* platform/mac/fast/text/fallback-traits-fixup-expected.txt:
* platform/mac/fast/text/hyphenate-locale-expected.txt:
* platform/mac/fast/text/international/hindi-spacing-expected.png:
* platform/mac/fast/text/international/hindi-spacing-expected.txt:
* platform/mac/fast/text/international/text-combine-image-test-expected.txt:
* platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
* platform/mac/fast/text/justify-ideograph-vertical-expected.txt:
* platform/mac/platform/mac/fast/text/vertical-surrogate-pair-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Move toV8Context() from V8Proxy to V8Binding
haraken@chromium.org [Tue, 21 Aug 2012 23:38:35 +0000 (23:38 +0000)]
[V8] Move toV8Context() from V8Proxy to V8Binding
https://bugs.webkit.org/show_bug.cgi?id=94597

Reviewed by Adam Barth.

To kill V8Proxy, we can move toV8Context() from V8Proxy to V8Binding.

No tests. No change in behavior.

* bindings/v8/V8Binding.cpp:
(WebCore::toV8Context):
(WebCore):
* bindings/v8/V8Binding.h:
(WebCore):
* bindings/v8/V8Proxy.cpp:
* bindings/v8/V8Proxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126218 268f45cc-cd09-0410-ab3c-d52691b4dbfc