WebKit-https.git
9 years agoREGRESSION (r83928 or before): Some tests failing assertions in MarkStack::internalAppend
jberlin@webkit.org [Mon, 2 May 2011 16:09:16 +0000 (16:09 +0000)]
REGRESSION (r83928 or before): Some tests failing assertions in MarkStack::internalAppend
/ MarkStack::drain.
https://bugs.webkit.org/show_bug.cgi?id=58657

Add inspector/styles/styles-cancel-editing.html to the Windows XP Skipped list because it
has been crashing under MarkStack::drain on the Windows XP bots.

* platform/win-xp/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 2 May 2011 16:04:26 +0000 (16:04 +0000)]
2011-05-02  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Brady Eidson.

        The preload attribute of the video tag is not completely implemented
        https://bugs.webkit.org/show_bug.cgi?id=43673
        <rdar://problem/7508322>

        Test manually with manual-tests/media-elements/video-preload.html.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes): Add new "limit read-ahead"
            attribute when preload is not "auto".
        (WebCore::MediaPlayerPrivateQTKit::resumeLoad): Remove m_delayingLoad, we don't need it.
        (WebCore::MediaPlayerPrivateQTKit::load): Correct comment.
        (WebCore::MediaPlayerPrivateQTKit::prepareToPlay): Call setPreload('auto').
        (WebCore::MediaPlayerPrivateQTKit::setPreload): Set new attribue if we already have
            a QTMovie.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Update an exptected file after r85474.
ossy@webkit.org [Mon, 2 May 2011 15:59:13 +0000 (15:59 +0000)]
[Qt] Update an exptected file after r85474.

* platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png:
* platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-30 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 2 May 2011 15:55:37 +0000 (15:55 +0000)]
2011-04-30  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Brady Eidson.

        The preload attribute of the video tag is not completely implemented
        https://bugs.webkit.org/show_bug.cgi?id=43673
        <rdar://problem/7508322>

        Manual test manual-tests/media-elements/video-preload.html added.

        * manual-tests/media-elements/video-preload.html: Added. New manual test for media element
            'preload' attribute because it is not possible to detect if a media engine supports
            "preload=metadata" in a way that lets us have per-platform layout test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 2 May 2011 14:29:51 +0000 (14:29 +0000)]
2011-05-02  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        [GTK] Media tests relying on video-paint-test.js are still flaky
        https://bugs.webkit.org/show_bug.cgi?id=59934

        Dump the render tree after the video completed the seek. This is
        to avoid flake happening in the control slider not always being at
        beginning of the timeline.

        * media/video-paint-test.js:
        (init.document.addEventListener.):
        (init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Zsolt Fehér <h490267@stud.u-szeged.hu>
commit-queue@webkit.org [Mon, 2 May 2011 14:27:31 +0000 (14:27 +0000)]
2011-05-02  Zsolt Fehér  <h490267@stud.u-szeged.hu>

        Reviewed by Csaba Osztrogonác.

        DRT sideeffect revealed by r71268
        https://bugs.webkit.org/show_bug.cgi?id=48958

        * platform/qt/Skipped: Unskip svg/custom/text-zoom.xhtml
2011-05-02  Zsolt Fehér  <h490267@stud.u-szeged.hu>

        Reviewed by Csaba Osztrogonác.

        DRT sideeffect revealed by r71268.
        https://bugs.webkit.org/show_bug.cgi?id=48958

        Reset QWebSettings::ZoomTextOnly attribute before all tests.

        Call setTextSizeMultiplier(1.0) to reset TextZoomFactor and
        PageZoomFactor too. It should be done before resetsettings()
        to guarantee resetting QWebSettings::ZoomTextOnly correctly.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::resetSettings):
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 2 May 2011 14:24:05 +0000 (14:24 +0000)]
2011-05-02  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip flaky test on GTK.

        * platform/gtk/Skipped: Skip tables/mozilla_expected_failures/bugs/bug85016.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Mon, 2 May 2011 12:13:00 +0000 (12:13 +0000)]
2011-05-02  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r85469.
        http://trac.webkit.org/changeset/85469
        https://bugs.webkit.org/show_bug.cgi?id=59928

        Broke  webkitpy-tests on Windows 7, GTK and Qt. (Requested by
        bbandix on #webkit).

        * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Removed.
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Tomasz Morawski <t.morawski@samsung.com>
commit-queue@webkit.org [Mon, 2 May 2011 11:03:27 +0000 (11:03 +0000)]
2011-05-02  Tomasz Morawski  <t.morawski@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        Cleanup EFL initialization/shutdown in the EWebLauncher
        https://bugs.webkit.org/show_bug.cgi?id=59922

        Removed ecore_evas_init and edje_init form main function due to they
        are also called in the ewk_init. Moved ewk_shutdown to quit function.

        * EWebLauncher/main.c:
        (quit):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 2 May 2011 10:54:08 +0000 (10:54 +0000)]
2011-05-02  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, re-enable websocket tests on GTK. they moved over to a
        real http server and most of the flakiness went away.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 10:51:50 +0000 (10:51 +0000)]
2011-05-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add base case for a test-running EWS
        https://bugs.webkit.org/show_bug.cgi?id=59920

        Later I will subclass this to run the Chromium Linux EWS.

        * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 2 May 2011 10:02:13 +0000 (10:02 +0000)]
2011-05-02  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK baselines for new tests.

        * platform/gtk/fast/backgrounds/gradient-background-leakage-expected.png: Added.
        * platform/gtk/fast/backgrounds/gradient-background-leakage-expected.txt: Added.
        * platform/gtk/fast/block/float/float-overhangs-root-expected.png: Added.
        * platform/gtk/fast/block/float/float-overhangs-root-expected.txt: Added.
        * platform/gtk/fast/block/float/overhanging-tall-block-expected.png: Added.
        * platform/gtk/fast/block/float/overhanging-tall-block-expected.txt: Added.
        * platform/gtk/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
        * platform/gtk/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added.
        * platform/gtk/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
        * platform/gtk/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
        * platform/gtk/fast/box-shadow/single-pixel-shadow-expected.png: Added.
        * platform/gtk/fast/box-shadow/single-pixel-shadow-expected.txt: Added.
        * platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
        * platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Added.
        * platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Added.
        * platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
        * platform/gtk/fast/forms/date-input-visible-strings-expected.png: Added.
        * platform/gtk/fast/forms/date-input-visible-strings-expected.txt: Added.
        * platform/gtk/fast/html/details-add-child-1-expected.png: Added.
        * platform/gtk/fast/html/details-add-child-1-expected.txt: Added.
        * platform/gtk/fast/html/details-add-child-2-expected.png: Added.
        * platform/gtk/fast/html/details-add-child-2-expected.txt: Added.
        * platform/gtk/fast/html/details-add-summary-child-1-expected.png: Added.
        * platform/gtk/fast/html/details-add-summary-child-1-expected.txt: Added.
        * platform/gtk/fast/html/details-add-summary-child-2-expected.png: Added.
        * platform/gtk/fast/html/details-add-summary-child-2-expected.txt: Added.
        * platform/gtk/fast/html/details-remove-child-1-expected.png: Added.
        * platform/gtk/fast/html/details-remove-child-1-expected.txt: Added.
        * platform/gtk/fast/html/details-remove-child-2-expected.png: Added.
        * platform/gtk/fast/html/details-remove-child-2-expected.txt: Added.
        * platform/gtk/fast/html/details-remove-summary-child-1-expected.png: Added.
        * platform/gtk/fast/html/details-remove-summary-child-1-expected.txt: Added.
        * platform/gtk/fast/html/details-remove-summary-child-2-expected.png: Added.
        * platform/gtk/fast/html/details-remove-summary-child-2-expected.txt: Added.
        * platform/gtk/fast/table/auto-100-percent-width-expected.png: Added.
        * platform/gtk/fast/table/auto-100-percent-width-expected.txt: Added.
        * platform/gtk/fast/table/dynamic-caption-add-before-child-expected.png: Added.
        * platform/gtk/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
        * platform/gtk/fast/table/dynamic-caption-add-remove-before-child-expected.png: Added.
        * platform/gtk/fast/table/dynamic-caption-add-remove-before-child-expected.txt: Added.
        * platform/gtk/fast/table/multiple-captions-display-expected.png: Added.
        * platform/gtk/fast/table/multiple-captions-display-expected.txt: Added.
        * platform/gtk/fast/text/selection-rect-rounding-expected.png: Added.
        * platform/gtk/fast/text/selection-rect-rounding-expected.txt: Added.
        * platform/gtk/svg/filters/feDropShadow-expected.png: Added.
        * platform/gtk/svg/filters/feDropShadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuildfix for ARM after r85448
loki@webkit.org [Mon, 2 May 2011 09:37:09 +0000 (09:37 +0000)]
Buildfix for ARM after r85448

* assembler/ARMAssembler.h:
(JSC::ARMAssembler::loadBranchTarget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 2 May 2011 09:09:04 +0000 (09:09 +0000)]
2011-05-02  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK rebaseline after r85355.

        * platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt:
        * platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 08:11:02 +0000 (08:11 +0000)]
2011-05-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add the ability to skip python and perl unit tests on EC2
        https://bugs.webkit.org/show_bug.cgi?id=59918

        * Scripts/webkitpy/common/config/ports.py:
            - This is slightly ugly, but it's useful...
        * Scripts/webkitpy/common/config/ports_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/runtests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 07:56:44 +0000 (07:56 +0000)]
2011-05-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        webkit-patch --non-interactive is incompatible with new-run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=59919

        new-run-webkit-tests doesn't support --wait-for-httpd (because it
        always waits for HTTPD, as I understand things).  It turns out we're
        not really using this flag for anything, so we should just remove it.

        * Scripts/webkitpy/tool/steps/runtests.py:
        * Scripts/webkitpy/tool/steps/steps_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 2 May 2011 07:53:08 +0000 (07:53 +0000)]
2011-05-01  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        The bots should learn from expected failures without having to retry
        https://bugs.webkit.org/show_bug.cgi?id=59279

        Rather than re-trying the whole patch, we can just check whether we now
        expect the failures we see with the patch applied, saving a lot of time.

        This patch also teaches the CommitQueue how to reject patches even
        when the tree is red using the new unexpected_failures() method on
        ExpectedFailures.

        Finally in testing we found a bug in ExpectedFailures where it would
        "trust" results which had many many failures, due to using an
        equal sign instead of a less-than sign.

        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py
        * Scripts/webkitpy/tool/bot/expectedfailures.py
        * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py
        * Scripts/webkitpy/tool/bot/patchanalysistask.py

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 07:17:32 +0000 (07:17 +0000)]
2011-05-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        workspace.py fails to import ScriptError
        https://bugs.webkit.org/show_bug.cgi?id=59915

        If the workspace fails to create a zip, webkitpy crashes instead of
        handling the error as expected.

        * Scripts/webkitpy/common/system/workspace.py:
        * Scripts/webkitpy/common/system/workspace_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 06:29:40 +0000 (06:29 +0000)]
2011-05-01  Adam Barth  <abarth@webkit.org>

        Remove unadvertantly added file.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 06:18:46 +0000 (06:18 +0000)]
2011-05-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        expectedfailures.py should report the unexpected failures when asked
        https://bugs.webkit.org/show_bug.cgi?id=59916

        This information is useful when the EWS runs tests.

        * Scripts/webkitpy/tool/bot/expectedfailures.py:
        * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 06:14:56 +0000 (06:14 +0000)]
2011-05-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        JSONTestResult needs to handle multiple results
        https://bugs.webkit.org/show_bug.cgi?id=59269

        This case occurs when a test is flaky because NRWT will run the test
        twice and report both results as "actual."

        * Scripts/webkitpy/common/net/resultsjsonparser.py:
        * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Mon, 2 May 2011 05:59:46 +0000 (05:59 +0000)]
2011-05-01  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Carlson.

        Regression(r74787): Media document mouse click and double-click
        events should be checked on target node only and not its descendants.
        https://bugs.webkit.org/show_bug.cgi?id=59886

        * html/MediaDocument.cpp:
        (WebCore::MediaDocument::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Crash closing tab with docked Web Inspector
bweinstein@apple.com [Mon, 2 May 2011 05:44:32 +0000 (05:44 +0000)]
WebKit2: Crash closing tab with docked Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=59914
<rdar://problem/9359672>

Reviewed by Dan Bernstein.

When a tab is closed with a docked inspector, invalidate called platformClose, which
didn't do the tear down that is needed, but is called when we close the web inspector explcitly.
One part of tear down we weren't doing is removing ourselves as a WindowMessageBrodcaster listener
on the inspected web view, and this can cause crashes.

This patch also renames platformClose to platformDidClose, to be clearer about when the function
is called.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::invalidate): Call didClose instead of platformClose.
(WebKit::WebInspectorProxy::didClose): Call platformDidClose instead of platformClose.
* UIProcess/WebInspectorProxy.h:
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformDidClose): Renamed from platformClose.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformDidClose): Ditto.
* UIProcess/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspectorProxy::platformDidClose): Ditto.
* UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::platformDidClose): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 2 May 2011 05:21:50 +0000 (05:21 +0000)]
2011-05-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Strict-mode only reserved words not reserved
        https://bugs.webkit.org/show_bug.cgi?id=55342

        Fix line number tracking when we rollback the lexer.

        * parser/JSParser.cpp:
        (JSC::JSParser::parseSourceElements):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 2 May 2011 04:51:40 +0000 (04:51 +0000)]
2011-05-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        ES5 Strict mode does not allow getter and setter for same propId
        https://bugs.webkit.org/show_bug.cgi?id=57295

        Update for correct results

        * fast/js/mozilla/strict/11.1.5-expected.txt:
2011-05-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        ES5 Strict mode does not allow getter and setter for same propId
        https://bugs.webkit.org/show_bug.cgi?id=57295

        Simplify and correct the logic for strict mode object literals.

        * parser/JSParser.cpp:
        (JSC::JSParser::parseStrictObjectLiteral):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 2 May 2011 02:57:40 +0000 (02:57 +0000)]
2011-05-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Assigning to function identifier under strict should throw
        https://bugs.webkit.org/show_bug.cgi?id=59289

        Add test case for correct behaviour, and update mozilla test results to reflect
        the correct result.

        * fast/js/basic-strict-mode-expected.txt:
        * fast/js/mozilla/strict/assign-to-callee-name-expected.txt:
        * fast/js/script-tests/basic-strict-mode.js:
2011-05-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Assigning to function identifier under strict should throw
        https://bugs.webkit.org/show_bug.cgi?id=59289

        Add logic to StaticScopeObject to ensure we don't silently consume
        writes to constant properties.

        * runtime/JSStaticScopeObject.cpp:
        (JSC::JSStaticScopeObject::put):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 01:55:17 +0000 (01:55 +0000)]
2011-05-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Polish CSP host and port matching
        https://bugs.webkit.org/show_bug.cgi?id=59899

        Test two host wildcard cases.

        * http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed.html: Added.
        * http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed.html: Added.
2011-05-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Polish CSP host and port matching
        https://bugs.webkit.org/show_bug.cgi?id=59899

        Finish last two details of host and port matching.  I don't think the
        default port handling is testable with our current testing
        infrastructure.

        Tests: http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed.html
               http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed.html

        * page/ContentSecurityPolicy.cpp:
        (WebCore::CSPSource::hostMatches):
        (WebCore::CSPSource::portMatches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 01:46:45 +0000 (01:46 +0000)]
2011-05-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move checkout/api.py to checkout/checkout.py
        https://bugs.webkit.org/show_bug.cgi?id=59906

        This is more consistent with Python style.

        * Scripts/webkitpy/common/checkout/__init__.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:
        * Scripts/webkitpy/common/host.py:
        * Scripts/webkitpy/tool/main.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 01:44:27 +0000 (01:44 +0000)]
2011-05-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP default-src is missing
        https://bugs.webkit.org/show_bug.cgi?id=58641

        Test that default-src controls some scripting policy and that
        script-src, if present, overrides default-src.  In principle, we could
        test the interaction of default-src with every other directive, but
        that seems like overkill.

        * http/tests/security/contentSecurityPolicy/default-src-inline-allowed-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/default-src-inline-allowed.html: Added.
        * http/tests/security/contentSecurityPolicy/default-src-inline-blocked-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/default-src-inline-blocked.html: Added.
        * http/tests/security/contentSecurityPolicy/script-src-overrides-default-src-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/script-src-overrides-default-src.html: Added.
2011-05-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP default-src is missing
        https://bugs.webkit.org/show_bug.cgi?id=58641

        Add support for default-src.  The default-src provides a default policy
        for every directive that sends in "-src".  If the more-specific
        directive is present, it takes precedence.  I also took this
        opportunity to refactor the internals of ContentSecurityPolicy a bit to
        reduce duplicate code.

        Tests: http/tests/security/contentSecurityPolicy/default-src-inline-allowed.html
               http/tests/security/contentSecurityPolicy/default-src-inline-blocked.html
               http/tests/security/contentSecurityPolicy/script-src-overrides-default-src.html

        * page/ContentSecurityPolicy.cpp:
        (WebCore::ContentSecurityPolicy::didReceiveHeader):
        (WebCore::ContentSecurityPolicy::checkEval):
        (WebCore::ContentSecurityPolicy::operativeDirective):
        (WebCore::ContentSecurityPolicy::checkInlineAndReportViolation):
        (WebCore::ContentSecurityPolicy::checkEvalAndReportViolation):
        (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation):
        (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
        (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
        (WebCore::ContentSecurityPolicy::allowInlineScript):
        (WebCore::ContentSecurityPolicy::allowInlineStyle):
        (WebCore::ContentSecurityPolicy::allowEval):
        (WebCore::ContentSecurityPolicy::allowScriptFromSource):
        (WebCore::ContentSecurityPolicy::allowObjectFromSource):
        (WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
        (WebCore::ContentSecurityPolicy::allowImageFromSource):
        (WebCore::ContentSecurityPolicy::allowStyleFromSource):
        (WebCore::ContentSecurityPolicy::allowFontFromSource):
        (WebCore::ContentSecurityPolicy::allowMediaFromSource):
        (WebCore::ContentSecurityPolicy::addDirective):
        * page/ContentSecurityPolicy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 2 May 2011 01:34:15 +0000 (01:34 +0000)]
2011-05-01  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        scm.py should be split into many pieces
        https://bugs.webkit.org/show_bug.cgi?id=59908

        Forgot an AuthenticationError import.

        * Scripts/webkitpy/common/checkout/scm/git.py:
        * Scripts/webkitpy/common/checkout/scm/svn.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Arno Renevier <arno@renevier.net>
commit-queue@webkit.org [Mon, 2 May 2011 01:27:17 +0000 (01:27 +0000)]
2011-05-01  Arno Renevier  <arno@renevier.net>

        Reviewed by Eric Seidel.

        wrong exception raised in Lighttpd start method
        https://bugs.webkit.org/show_bug.cgi?id=59283

        raise standard Exception instead of non existent
        google.httpd_utils.HttpdNotStarted

        * Scripts/webkitpy/layout_tests/port/http_server.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=59903
barraclough@apple.com [Mon, 2 May 2011 01:04:17 +0000 (01:04 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=59903
Use AssemblerLabel throughout Assembler classes, AssemblerBuffer

Reviewed by Sam Weinig.

Creating a lable() into the AssemblerBuffer should return an AssemblerLabel,
not an unsigned int.

* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::loadBranchTarget):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::ARMInstructionFormatter::label):
* assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::label):
* assembler/AssemblerBufferWithConstantPool.h:
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::relocateJumps):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::loadConstant):
(JSC::SH4Assembler::loadConstantUnReusable):
(JSC::SH4Assembler::call):
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::label):
(JSC::SH4Assembler::oneShortOp):
* assembler/X86Assembler.h:
(JSC::X86Assembler::call):
(JSC::X86Assembler::jmp_r):
(JSC::X86Assembler::label):
(JSC::X86Assembler::X86InstructionFormatter::immediateRel32):
(JSC::X86Assembler::X86InstructionFormatter::label):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Arno Renevier <arno@renevier.net>
commit-queue@webkit.org [Mon, 2 May 2011 01:03:15 +0000 (01:03 +0000)]
2011-05-01  Arno Renevier  <arno@renevier.net>

        Reviewed by Eric Seidel.

        wrong exception raised in Lighttpd start method
        https://bugs.webkit.org/show_bug.cgi?id=59283

        raise standard Exception instead of non existent
        google.httpd_utils.HttpdNotStarted

        * Scripts/webkitpy/layout_tests/port/http_server.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 2 May 2011 00:58:23 +0000 (00:58 +0000)]
2011-05-01  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Make most scm.py tests pass in preparation for splitting them up
        https://bugs.webkit.org/show_bug.cgi?id=59904

        There is one remaining failure:
        webkitpy.common.checkout.scm.scm_unittest.GitTestWithMock.test_create_patch
        which identifies a difference between the SVN and Git versions of the
        SCM api.  I'm not going to bother fixing that until we split out all
        the tests.

        * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 00:33:43 +0000 (00:33 +0000)]
2011-05-01  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Enable strict mode for OwnPtr and PassOwnPtr
        https://bugs.webkit.org/show_bug.cgi?id=59428

        * wtf/OwnPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix windows build.
weinig@apple.com [Mon, 2 May 2011 00:19:55 +0000 (00:19 +0000)]
Fix windows build.

* WebFrame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Mon, 2 May 2011 00:15:11 +0000 (00:15 +0000)]
2011-05-01  Patrick Gansterer  <paroga@webkit.org>

        [WIN] Unreviewed buildfix after r85440.

        * DumpRenderTree/win/UIDelegate.cpp:
        (UIDelegate::UIDelegate): Removed accidental added adoptPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 1 May 2011 23:56:41 +0000 (23:56 +0000)]
2011-05-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Prune some unnecessary #includes
        https://bugs.webkit.org/show_bug.cgi?id=59895

        Start getting rid of unnecessary #includes and forward declares.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2011-05-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Prune some unnecessary #includes
        https://bugs.webkit.org/show_bug.cgi?id=59895

        Start getting rid of unnecessary #includes and forward declares.

        * bindings/js/JSDOMBinding.h:
        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSDOMWindowShell.h:
        * bindings/js/ScheduledAction.cpp:
        * bindings/js/ScriptController.cpp:
        * bindings/js/ScriptController.h:
        * bindings/js/ScriptDebugServer.cpp:
        * editing/Editor.h:
        * inspector/InspectorClient.cpp:
        * loader/FrameLoader.h:
        * loader/NavigationScheduler.h:
        * page/Console.cpp:
        * xml/XMLTreeViewer.cpp:
        * xml/XMLTreeViewer.h:
2011-05-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Prune some unnecessary #includes
        https://bugs.webkit.org/show_bug.cgi?id=59895

        Start getting rid of unnecessary #includes and forward declares.

        * WebProcess/Plugins/PluginView.cpp:
        * WebProcess/WebPage/WebPage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 1 May 2011 23:53:43 +0000 (23:53 +0000)]
2011-05-01  Patrick Gansterer  <paroga@webkit.org>

        [WIN] Unreviewed buildfix after r85434.

        * DumpRenderTree/win/FrameLoadDelegate.cpp: Added missing header.
        * DumpRenderTree/win/UIDelegate.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 1 May 2011 23:44:28 +0000 (23:44 +0000)]
2011-05-01  Patrick Gansterer  <paroga@webkit.org>

        [WIN] Unreviewed buildfix after r85434.

        * WebView.cpp:
        (WebView::paint):
2011-05-01  Patrick Gansterer  <paroga@webkit.org>

        [WIN] Unreviewed buildfix after r85434.

        * DumpRenderTree/win/FrameLoadDelegate.cpp:
        (FrameLoadDelegate::FrameLoadDelegate):
        * DumpRenderTree/win/UIDelegate.cpp:
        (DRTUndoManager::DRTUndoManager):
        (UIDelegate::UIDelegate):
        (UIDelegate::resetUndoManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 1 May 2011 23:29:30 +0000 (23:29 +0000)]
2011-05-01  Patrick Gansterer  <paroga@webkit.org>

        [WIN] Unreviewed buildfix after r85434.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::startDragDrop):
        * UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp:
        (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore):
        (WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
        * WebProcess/WebCoreSupport/win/WebDragClientWin.cpp:
        (WebKit::WebDragClient::startDrag):
        * WebProcess/WebPage/win/ChunkedUpdateDrawingAreaWin.cpp:
        (WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 1 May 2011 23:09:06 +0000 (23:09 +0000)]
2011-05-01  Patrick Gansterer  <paroga@webkit.org>

        [WIN] Unreviewed buildfix after r85434.

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::createLayerForMovie):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 1 May 2011 22:53:54 +0000 (22:53 +0000)]
2011-05-01  Patrick Gansterer  <paroga@webkit.org>

        [WIN] Unreviewed buildfix after r85434.

        * platform/graphics/win/QTMovieVisualContext.cpp:
        (QTMovieVisualContext::QTMovieVisualContext): Added missing header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Sun, 1 May 2011 22:45:10 +0000 (22:45 +0000)]
2011-05-01  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Adam Barth.

        History::stateObjectAdded should check origin via SecurityOrigin::canRequest
        https://bugs.webkit.org/show_bug.cgi?id=59840

        * fast/loader/stateobjects/pushstate-in-data-url-denied-expected.txt: Added.
        * fast/loader/stateobjects/pushstate-in-data-url-denied.html: Added.
        * fast/loader/stateobjects/replacestate-base-illegal-expected.txt: Removed.
        * fast/loader/stateobjects/replacestate-base-illegal.html: Removed.
        * fast/loader/stateobjects/replacestate-base-legal-expected.txt: Removed.
        * fast/loader/stateobjects/replacestate-base-legal.html: Removed.
        * fast/loader/stateobjects/resources/replacestate-base-pass.html: Removed.
        * http/tests/navigation/replacestate-base-illegal-expected.txt: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-illegal-expected.txt.
        * http/tests/navigation/replacestate-base-illegal.html: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-illegal.html.
        * http/tests/navigation/replacestate-base-legal-expected.txt: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-legal-expected.txt.
        * http/tests/navigation/replacestate-base-legal.html: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-legal.html.
        * http/tests/navigation/resources/replacestate-base-pass.html: Copied from LayoutTests/fast/loader/stateobjects/resources/replacestate-base-pass.html.
2011-05-01  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Adam Barth.

        History::stateObjectAdded should check origin via SecurityOrigin::canRequest
        https://bugs.webkit.org/show_bug.cgi?id=59840

        Tests: fast/loader/stateobjects/pushstate-in-data-url-denied.html
               http/tests/navigation/replacestate-base-illegal.html
               http/tests/navigation/replacestate-base-legal.html

        * page/History.cpp:
        (WebCore::History::stateObjectAdded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 1 May 2011 22:42:32 +0000 (22:42 +0000)]
2011-05-01  Patrick Gansterer  <paroga@webkit.org>

        [WIN] Unreviewed buildfix after r85434.

        * platform/graphics/win/QTMovieVisualContext.cpp:
        (QTMovieVisualContext::QTMovieVisualContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 1 May 2011 22:30:43 +0000 (22:30 +0000)]
2011-05-01  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Enable strict OwnPtr for PLATFORM(WIN)
        https://bugs.webkit.org/show_bug.cgi?id=59881

        * wtf/OwnPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 1 May 2011 22:28:12 +0000 (22:28 +0000)]
2011-05-01  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        [WINCE] Fix OwnPtr strict issues
        https://bugs.webkit.org/show_bug.cgi?id=59898

        * page/wince/FrameWinCE.cpp:
        (WebCore::imageFromSelection):
        * platform/graphics/wince/FontPlatformData.cpp:
        (WebCore::FixedSizeFontData::create):
        (WebCore::FontPlatformPrivateData::FontPlatformData::hfont):
        (WebCore::FontPlatformPrivateData::FontPlatformData::getScaledFontHandle):
        (WebCore::FontPlatformPrivateData::FontPlatformData::discardFontHandle):
        * platform/graphics/wince/GraphicsContextWinCE.cpp:
        (WebCore::GraphicsContext::strokeArc):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::clip):
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::drawRoundCorner):
        (WebCore::GraphicsContext::drawText):
        * platform/graphics/wince/ImageBufferWinCE.cpp:
        (WebCore::ImageBuffer::ImageBuffer):
        * platform/graphics/wince/ImageWinCE.cpp:
        (WebCore::BitmapImage::getHBITMAPOfSize):
        * platform/graphics/wince/SharedBitmap.cpp:
        (WebCore::SharedBitmap::SharedBitmap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=59896
barraclough@apple.com [Sun, 1 May 2011 22:20:59 +0000 (22:20 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=59896
Remove JmpSrc/JmpDst types.

Reviewed by Sam Weinig.

The JmpSrc/JmpDst classes predate the MacroAssembler interface. Having these
object be per-assembler in unhelpful, causes unnecessary code duplication,
and prevents the AssemblerBuffer from providing a richer type for labels.
The limited semantic meaning that they did convey is undermined by the manner
in which their meanings have been overloaded (use of JmpSrc for Call, JmpDst
for data labels).

Jumps on ARMv7 have had additional information added to the object via the
ARMv7 JmpSrc. This data should probably be in the instruction stream. This
patch does not fix the problem, and moves the data (ifdefed) to
AbstractMacroAssembler::Jump (which is effectively where it was before!).
This at least closes the hole such that no further data may be added to JmpSrc,
but this is unfortunate, and should be cleaned up.

* assembler/ARMAssembler.h:
(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::align):
(JSC::ARMAssembler::loadBranchTarget):
(JSC::ARMAssembler::jmp):
(JSC::ARMAssembler::linkPointer):
(JSC::ARMAssembler::linkJump):
(JSC::ARMAssembler::linkCall):
(JSC::ARMAssembler::getRelocatedAddress):
(JSC::ARMAssembler::getDifferenceBetweenLabels):
(JSC::ARMAssembler::getCallReturnOffset):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::align):
(JSC::ARMv7Assembler::getRelocatedAddress):
(JSC::ARMv7Assembler::getDifferenceBetweenLabels):
(JSC::ARMv7Assembler::getCallReturnOffset):
(JSC::ARMv7Assembler::linkJump):
(JSC::ARMv7Assembler::linkCall):
(JSC::ARMv7Assembler::linkPointer):
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Label::isSet):
(JSC::AbstractMacroAssembler::Call::Call):
(JSC::AbstractMacroAssembler::Jump::Jump):
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
(JSC::AbstractMacroAssembler::linkPointer):
(JSC::AbstractMacroAssembler::getLinkerAddress):
* assembler/AssemblerBuffer.h:
(JSC::AssemblerLabel::AssemblerLabel):
(JSC::AssemblerLabel::isSet):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::patch):
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::align):
(JSC::MIPSAssembler::getRelocatedAddress):
(JSC::MIPSAssembler::getDifferenceBetweenLabels):
(JSC::MIPSAssembler::getCallReturnOffset):
(JSC::MIPSAssembler::linkJump):
(JSC::MIPSAssembler::linkCall):
(JSC::MIPSAssembler::linkPointer):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchDouble):
(JSC::MacroAssemblerARMv7::branchDoubleZeroOrNaN):
(JSC::MacroAssemblerARMv7::jump):
(JSC::MacroAssemblerARMv7::nearCall):
(JSC::MacroAssemblerARMv7::call):
(JSC::MacroAssemblerARMv7::ret):
(JSC::MacroAssemblerARMv7::tailRecursiveCall):
(JSC::MacroAssemblerARMv7::makeBranch):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::nearCall):
(JSC::MacroAssemblerMIPS::call):
(JSC::MacroAssemblerMIPS::tailRecursiveCall):
(JSC::MacroAssemblerMIPS::branchTrue):
(JSC::MacroAssemblerMIPS::branchFalse):
(JSC::MacroAssemblerMIPS::branchEqual):
(JSC::MacroAssemblerMIPS::branchNotEqual):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::call):
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::label):
(JSC::SH4Assembler::align):
(JSC::SH4Assembler::linkJump):
(JSC::SH4Assembler::linkCall):
(JSC::SH4Assembler::linkPointer):
(JSC::SH4Assembler::getCallReturnOffset):
(JSC::SH4Assembler::getRelocatedAddress):
(JSC::SH4Assembler::getDifferenceBetweenLabels):
(JSC::SH4Assembler::patchPointer):
* assembler/X86Assembler.h:
(JSC::X86Assembler::call):
(JSC::X86Assembler::jmp):
(JSC::X86Assembler::jmp_r):
(JSC::X86Assembler::jne):
(JSC::X86Assembler::jnz):
(JSC::X86Assembler::je):
(JSC::X86Assembler::jz):
(JSC::X86Assembler::jl):
(JSC::X86Assembler::jb):
(JSC::X86Assembler::jle):
(JSC::X86Assembler::jbe):
(JSC::X86Assembler::jge):
(JSC::X86Assembler::jg):
(JSC::X86Assembler::ja):
(JSC::X86Assembler::jae):
(JSC::X86Assembler::jo):
(JSC::X86Assembler::jp):
(JSC::X86Assembler::js):
(JSC::X86Assembler::jCC):
(JSC::X86Assembler::label):
(JSC::X86Assembler::labelFor):
(JSC::X86Assembler::align):
(JSC::X86Assembler::linkJump):
(JSC::X86Assembler::linkCall):
(JSC::X86Assembler::linkPointer):
(JSC::X86Assembler::getCallReturnOffset):
(JSC::X86Assembler::getRelocatedAddress):
(JSC::X86Assembler::getDifferenceBetweenLabels):
(JSC::X86Assembler::rewindToLabel):
(JSC::X86Assembler::X86InstructionFormatter::immediateRel32):
(JSC::X86Assembler::X86InstructionFormatter::rewindToLabel):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::atJumpTarget):
(JSC::JIT::emitGetVirtualRegister):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_jsr):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_jmp_scopes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sun, 1 May 2011 21:15:59 +0000 (21:15 +0000)]
2011-05-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Can't open document from skydrive.com in Microsoft Word
        https://bugs.webkit.org/show_bug.cgi?id=59891
        <rdar://problem/9354285>

        Add the AllowHalfBakedQuickDrawSupport quirk for the SharePoint plug-in.

        * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
        (WebKit::NetscapePluginModule::determineQuirks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sun, 1 May 2011 20:47:03 +0000 (20:47 +0000)]
2011-05-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Don't try to create a backing store for a 0x0 plug-in
        https://bugs.webkit.org/show_bug.cgi?id=59887

        * WebProcess/Plugins/PluginProxy.cpp:
        (WebKit::PluginProxy::geometryDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Chao-ying Fu <fu@mips.com>
commit-queue@webkit.org [Sun, 1 May 2011 20:26:42 +0000 (20:26 +0000)]
2011-05-01  Chao-ying Fu  <fu@mips.com>

        Reviewed by Eric Seidel.

        Fix MIPS build due to the split of "Condition" enum
        https://bugs.webkit.org/show_bug.cgi?id=59407

        * assembler/MIPSAssembler.h:
        (JSC::MIPSAssembler::debugOffset):
        * assembler/MacroAssemblerMIPS.h:
        (JSC::MacroAssemblerMIPS::branch32):
        (JSC::MacroAssemblerMIPS::compare32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sun, 1 May 2011 19:46:01 +0000 (19:46 +0000)]
2011-05-01  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
        https://bugs.webkit.org/show_bug.cgi?id=59837

        Removed EventHandler::sendContextMenuEvent(NSEvent*) and EventHandler::eventMayStartDrag(NSEvent*)

        * WebCore.exp.in:
        * page/EventHandler.h:
        * page/mac/EventHandlerMac.mm:
2011-05-01  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
        https://bugs.webkit.org/show_bug.cgi?id=59837

        Call sendContextMenuEvent and eventMayStartDrag with PlatformMouseEvent instead of NSEvent.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView menuForEvent:]):
        (-[WebHTMLView acceptsFirstMouse:]):
        (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 1 May 2011 19:20:45 +0000 (19:20 +0000)]
2011-05-01  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Move scm.py into its own module in preparation for splitting it up
        https://bugs.webkit.org/show_bug.cgi?id=59884

        * Scripts/webkitpy/common/checkout/scm/__init__.py: Added.
        * Scripts/webkitpy/common/checkout/scm/scm.py: Moved.
        * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Moved.
        * Scripts/webkitpy/test/main.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 ojab <ojab@ojab.ru>
commit-queue@webkit.org [Sun, 1 May 2011 19:15:41 +0000 (19:15 +0000)]
2011-05-01  ojab  <ojab@ojab.ru>

        Reviewed by Eric Seidel.

        --disable-video-track if --disable-video
        https://bugs.webkit.org/show_bug.cgi?id=59605

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sun, 1 May 2011 19:10:34 +0000 (19:10 +0000)]
2011-05-01  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
        https://bugs.webkit.org/show_bug.cgi?id=59835

        Moved currentKeyboardEvent.

        * WebCore.exp.in:
        * page/EventHandler.h:
        * page/mac/EventHandlerMac.mm:
2011-05-01  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
        https://bugs.webkit.org/show_bug.cgi?id=59835

        Moved currentKeyboardEvent.

        * WebView/WebHTMLView.mm:
        (currentKeyboardEvent):
        (-[WebHTMLView becomeFirstResponder]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 1 May 2011 18:58:08 +0000 (18:58 +0000)]
2011-05-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        webkit-patch fails when not run from root
        https://bugs.webkit.org/show_bug.cgi?id=59882

        We need to set the CWD when running svn so that svn interprets file
        paths relative to the root of the working copy.

        * Scripts/webkitpy/common/checkout/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 ojab <ojab@ojab.ru>
commit-queue@webkit.org [Sun, 1 May 2011 18:42:08 +0000 (18:42 +0000)]
2011-05-01  ojab  <ojab@ojab.ru>

        Reviewed by Eric Seidel.

        Fix build with --disable-video --enable-fullscreen-api
        https://bugs.webkit.org/show_bug.cgi?id=59698

        * rendering/RenderTheme.h:
        (WebCore::RenderTheme::extraFullScreenStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Jeff Timanus <twiz@chromium.org>
commit-queue@webkit.org [Sun, 1 May 2011 18:35:08 +0000 (18:35 +0000)]
2011-05-01  Jeff Timanus  <twiz@chromium.org>

        Reviewed by Eric Seidel.

        Add solid-color checking to BitmapImage::checkForSolidColour in the skia port.
        https://bugs.webkit.org/show_bug.cgi?id=59041

        Test:css2.1/t140201-c533-bgimage-00-a.html

        * platform/graphics/Image.cpp:
        (WebCore::Image::drawTiled): Removal of macro exclusion of assert for Skia path.
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::BitmapImage::checkForSolidColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sun, 1 May 2011 18:02:52 +0000 (18:02 +0000)]
2011-05-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Sandbox violation by WebProcess for DownloadAssessment.plist
        https://bugs.webkit.org/show_bug.cgi?id=59879
        <rdar://problem/9326041>

        * WebProcess/com.apple.WebProcess.sb:
        Allow reading ~/Library/Preferences/com.apple.DownloadAssessment.plist

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 1 May 2011 17:47:30 +0000 (17:47 +0000)]
2011-05-01  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Fix OwnPtr strict issues in windows build
        https://bugs.webkit.org/show_bug.cgi?id=59878

        * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
        (WebCore::getDirtyRects):
        * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
        (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
        * platform/graphics/win/WKCAImageQueue.cpp:
        (WebCore::WKCAImageQueue::WKCAImageQueue):
        * platform/win/CursorWin.cpp:
        (WebCore::createSharedCursor):
        * platform/win/PasteboardWin.cpp:
        (WebCore::Pasteboard::writeImage):
2011-05-01  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Fix OwnPtr strict issues in windows build
        https://bugs.webkit.org/show_bug.cgi?id=59878

        * FullscreenVideoController.cpp:
        (FullscreenVideoController::FullscreenVideoController):
        (FullscreenVideoController::createHUDWindow):
        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::highlight):
        * WebElementPropertyBag.cpp:
        (WebElementPropertyBag::WebElementPropertyBag):
        * WebNodeHighlight.cpp:
        (WebNodeHighlight::update):
        * WebNotificationCenter.cpp:
        (WebNotificationCenter::WebNotificationCenter):
        * WebView.cpp:
        (WebView::close):
        (WebView::paint):
        (WebView::handleMouseEvent):
        (WebView::registerEmbeddedViewMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 1 May 2011 17:43:13 +0000 (17:43 +0000)]
2011-05-01  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        Use PassOwnPtr as return value of GraphicsContext::createWindowsBitmap
        https://bugs.webkit.org/show_bug.cgi?id=59876

        Also pass the size "as reference" instead of "as value".

        * platform/graphics/GraphicsContext.h:
        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::drawGDIGlyphs):
        * platform/graphics/win/GraphicsContextWin.cpp:
        (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap):
        (WebCore::GraphicsContext::createWindowsBitmap):
        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Sun, 1 May 2011 17:30:33 +0000 (17:30 +0000)]
2011-05-01  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        getComputedStyle() returns unitless values for some properties that require units
        https://bugs.webkit.org/show_bug.cgi?id=55111

        Add test to verify that getComputedStyle returns length properties with a unit.

        * fast/css/getComputedStyle/getComputedStyle-length-unit-expected.txt: Added.
        * fast/css/getComputedStyle/getComputedStyle-length-unit.html: Added.
2011-05-01  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        getComputedStyle() returns unitless values for some properties that require units
        https://bugs.webkit.org/show_bug.cgi?id=55111

        Change getComputedStyle to return value with unit for -webkit-column-width, -webkit-column-gap and -webkit-perspective

        Test: fast/css/getComputedStyle/getComputedStyle-length-unit.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Young Han Lee <joybro@company100.net>
commit-queue@webkit.org [Sun, 1 May 2011 17:25:32 +0000 (17:25 +0000)]
2011-05-01  Young Han Lee  <joybro@company100.net>

        Reviewed by Eric Seidel.

        Change TEXMAP_OPENGL_ES2 to TEXMAP_OPENGL_ES_2
        https://bugs.webkit.org/show_bug.cgi?id=59608

        TEXMAP_OPENGL_ES2 is a wrong name. TEXMAP_OPENGL_ES_2 is already defined in TextureMapper.h

        No new functionality, no new tests.

        * platform/graphics/opengl/TextureMapperGL.cpp:
        (WebCore::TextureMapperGL::TextureMapperGL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Sun, 1 May 2011 17:08:25 +0000 (17:08 +0000)]
2011-05-01  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Eric Seidel.

        CSS3 nth-child(n) selector fails
        https://bugs.webkit.org/show_bug.cgi?id=56943

        * fast/css/nth-child-n-expected.txt: Added.
        * fast/css/nth-child-n.html: Added.
2011-05-01  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Eric Seidel.

        CSS3 nth-child(n) selector fails
        https://bugs.webkit.org/show_bug.cgi?id=56943

        Regression from r75158.
        "n" is a valid parameter to nth() and should be allowed.

        Test: fast/css/nth-child-n.html

        * css/CSSParser.cpp:
        (WebCore::isValidNthToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sun, 1 May 2011 16:09:51 +0000 (16:09 +0000)]
2011-05-01  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: address stack frame scriptName -> url rename in timeline panel.

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
        (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com [Sun, 1 May 2011 16:07:19 +0000 (16:07 +0000)]
2011-05-01  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Maciej Stachowiak.

        Crash in AccessibilityRenderObject while viewing PDFs in iframes
        https://bugs.webkit.org/show_bug.cgi?id=59629

        Could not reproduce this crash, but it's quite clear how it could happen.

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::accessibilityHitTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sun, 1 May 2011 14:38:44 +0000 (14:38 +0000)]
2011-05-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        LEAK: SVGElement leaks when detaching it in a pending resource state
        https://bugs.webkit.org/show_bug.cgi?id=59072

        Add testcase that used to leak, the leaks bot will assure they won't in future.

        * svg/custom/pending-resource-leak-2-expected.txt: Added.
        * svg/custom/pending-resource-leak-2.svg: Added.
        * svg/custom/pending-resource-leak-3-expected.txt: Added.
        * svg/custom/pending-resource-leak-3.svg: Added.
        * svg/custom/pending-resource-leak-expected.txt: Added.
        * svg/custom/pending-resource-leak.svg: Added.

2011-05-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        LEAK: SVGElement leaks when detaching it in a pending resource state
        https://bugs.webkit.org/show_bug.cgi?id=59072

        Make the pending resources set non-refcounted again. We made it refcounted a while ago
        to fix a security bug, as we had dangling pointers in the set in SVGDocumentExtensions.
        Fix the underlying problem, by removing all pending resources referencing to a particular
        SVGElement, upon its destruction or upon removing it from the document.

        Example: <rect fill="url(#foo)" id="rect">
        When we try to render the rect, the foo paint server can't be found and thus "foo" will be
        added to the pending resource set, with "rect" as client. When "foo" appears, it would remove
        itself from the pending resource set, and a ref count to the "rect" would be released.
        If "foo" never appears, SVGDocumentExtensions still holds a ref to the <rect>, thus keeping
        it and the associated document alive.

        Tests: svg/custom/pending-resource-leak-2.svg
               svg/custom/pending-resource-leak-3.svg
               svg/custom/pending-resource-leak.svg

        These tests cover several scenarios where we used to leak. Should fix several SVG*Element leaks on the bots.
        I manually tested reloading above testcases dozens of times, before the leak count was incremented by 2 nodes on every reload, that's gone now.

        * rendering/svg/RenderSVGResourceContainer.cpp:
        (WebCore::RenderSVGResourceContainer::registerResource):
        * rendering/svg/RenderSVGShadowTreeRootContainer.cpp:
        (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
        * rendering/svg/SVGResources.cpp:
        (WebCore::registerPendingResource):
        * svg/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::addPendingResource):
        (WebCore::SVGDocumentExtensions::hasPendingResources):
        (WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
        (WebCore::SVGDocumentExtensions::removePendingResource):
        * svg/SVGDocumentExtensions.h:
        * svg/SVGElement.cpp:
        * svg/SVGElement.h:
        * svg/SVGElementRareData.h:
        (WebCore::SVGElementRareData::SVGElementRareData):
        (WebCore::SVGElementRareData::hasPendingResources):
        (WebCore::SVGElementRareData::setHasPendingResources):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::~SVGStyledElement):
        (WebCore::SVGStyledElement::insertedIntoDocument):
        (WebCore::SVGStyledElement::removedFromDocument):
        (WebCore::SVGStyledElement::hasPendingResources):
        (WebCore::SVGStyledElement::setHasPendingResources):
        * svg/SVGStyledElement.h:
        (WebCore::SVGStyledElement::needsPendingResourceHandling):
        (WebCore::SVGStyledElement::buildPendingResource):
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::SVGUseElement):
        (WebCore::SVGUseElement::insertedIntoDocument):
        (WebCore::SVGUseElement::svgAttributeChanged):
        (WebCore::SVGUseElement::buildPendingResource):
        * svg/SVGUseElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Rafael Brandao <rafael.lobo@openbossa.org>
commit-queue@webkit.org [Sun, 1 May 2011 14:12:09 +0000 (14:12 +0000)]
2011-05-01  Rafael Brandao  <rafael.lobo@openbossa.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] build-webkit warning Inspector.idl is missing
        https://bugs.webkit.org/show_bug.cgi?id=59047

        Added variable_out to pipe output from one compiler to another,
        and then forced the output to be added to the sources.

        * CodeGenerators.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9155067> REGRESSION (float-based line boxes): Gaps and overlaps in...
mitz@apple.com [Sun, 1 May 2011 09:19:17 +0000 (09:19 +0000)]
<rdar://problem/9155067> REGRESSION (float-based line boxes): Gaps and overlaps in selection highlight
https://bugs.webkit.org/show_bug.cgi?id=56658

Reviewed by Anders Carlsson.

Source/WebCore:

Test: fast/text/selection-rect-rounding.html

* platform/graphics/FontFastPath.cpp:
(WebCore::Font::selectionRectForSimpleText): Account for non-integral anchor point coordinates.
* platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::selectionRectForComplexText): Ditto.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect): Floor the horizontal sides of the clip rect.
(WebCore::InlineTextBox::paintSelection): Pass the logical left location to Font::selectionRectForText(),
since it affects rounding.

LayoutTests:

* fast/text/selection-rect-rounding.html: Added.
* platform/mac/fast/text/selection-rect-rounding-expected.png: Added.
* platform/mac/fast/text/selection-rect-rounding-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Ivan Krstić <ike@apple.com>
ike@apple.com [Sun, 1 May 2011 08:09:39 +0000 (08:09 +0000)]
2011-05-01  Ivan Krstić  <ike@apple.com>

        Reviewed by Maciej Stachowiak.

        Remove unnecessary keychain and CoreAudio debris from WebProcess sandbox
        https://bugs.webkit.org/show_bug.cgi?id=59873

        These rules have been obsoleted by <rdar://problem/9301520> and
        <rdar://problem/9181468>.

        * WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Ivan Krstić <ike@apple.com>
ike@apple.com [Sun, 1 May 2011 07:45:22 +0000 (07:45 +0000)]
2011-05-01  Ivan Krstić  <ike@apple.com>

        Reviewed by Maciej Stachowiak.

        Simplify WebProcess sandbox with homedir-relative path filters.
        https://bugs.webkit.org/show_bug.cgi?id=59872

        * WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Ivan Krstić <ike@apple.com>
ike@apple.com [Sun, 1 May 2011 07:28:59 +0000 (07:28 +0000)]
2011-05-01  Ivan Krstić  <ike@apple.com>

        Reviewed by Maciej Stachowiak.

        On-demand VPN support for sandboxed WebProcess.
        <rdar://problem/8994181>

        * WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-30 Ivan Krstić <ike@apple.com>
ike@apple.com [Sun, 1 May 2011 07:10:39 +0000 (07:10 +0000)]
2011-04-30  Ivan Krstić  <ike@apple.com>

        Reviewed by Sam Weinig.

        Reindent WebProcess sandbox to standard scheme style
        https://bugs.webkit.org/show_bug.cgi?id=59870

        * WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-30 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Sun, 1 May 2011 04:17:32 +0000 (04:17 +0000)]
2011-04-30  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Dirk Schulze.

        Make RenderSVGResourceFilter take ownership of filter data when painting
        https://bugs.webkit.org/show_bug.cgi?id=51524

        * svg/custom/filter-on-svgimage-expected.txt: Added.
        * svg/custom/filter-on-svgimage.svg: Added.
2011-04-30  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Dirk Schulze.

        Make RenderSVGResourceFilter take ownership of filter data when painting
        https://bugs.webkit.org/show_bug.cgi?id=51524

        Test: svg/custom/filter-on-svgimage.svg

        * rendering/svg/RenderSVGResourceFilter.cpp:
        (WebCore::RenderSVGResourceFilter::removeClientFromCache):
        (WebCore::RenderSVGResourceFilter::postApplyResource):
        * rendering/svg/RenderSVGResourceFilter.h:
        (WebCore::FilterData::FilterData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 1 May 2011 04:16:34 +0000 (04:16 +0000)]
2011-04-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Adam Barth.

        Enable strict OwnPtr for GTK
        https://bugs.webkit.org/show_bug.cgi?id=59861

        * wtf/OwnPtr.h:
2011-04-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Adam Barth.

        Enable strict mode for OwnPtr and PassOwnPtr
        https://bugs.webkit.org/show_bug.cgi?id=59428

        Fix assignments and .set() calls with OwnPtr to use adoptPtr. Have GeolocationService
        factory methods return a PassOwnPtr.

        No new tests. This should not change functionality.

        * platform/GeolocationService.cpp:
        (WebCore::createGeolocationServiceNull):
        (WebCore::GeolocationService::create):
        * platform/GeolocationService.h:
        * platform/android/GeolocationServiceAndroid.cpp:
        (WebCore::GeolocationServiceAndroid::create):
        * platform/android/GeolocationServiceAndroid.h:
        * platform/efl/GeolocationServiceEfl.cpp:
        (WebCore::GeolocationServiceEfl::create):
        * platform/efl/GeolocationServiceEfl.h:
        * platform/graphics/cairo/CairoUtilities.cpp:
        (WebCore::appendPathToCairoContext):
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::drawPathShadow):
        (WebCore::GraphicsContext::clip):
        * platform/graphics/cairo/ImageBufferCairo.cpp:
        (WebCore::ImageBuffer::ImageBuffer):
        * platform/graphics/cairo/OwnPtrCairo.h:
        * platform/graphics/cairo/PathCairo.cpp:
        (WebCore::Path::Path):
        (WebCore::Path::operator=):
        (WebCore::Path::apply):
        * platform/gtk/GeolocationServiceGtk.cpp:
        (WebCore::GeolocationServiceGtk::create):
        * platform/gtk/GeolocationServiceGtk.h:
        * platform/mock/GeolocationServiceMock.cpp:
        (WebCore::GeolocationServiceMock::create):
        * platform/mock/GeolocationServiceMock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoARMv7 build fix.
barraclough@apple.com [Sun, 1 May 2011 01:05:44 +0000 (01:05 +0000)]
ARMv7 build fix.

* assembler/AssemblerBufferWithConstantPool.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 59869 - AssemblerBuffer cleanup - disambiguate size()
barraclough@apple.com [Sat, 30 Apr 2011 23:59:17 +0000 (23:59 +0000)]
Bug 59869 - AssemblerBuffer cleanup - disambiguate size()

Reviewed by Oliver Hunt.

The method size() is called on the AssemblerBuffer both to acquire
the complete size of the code, and to get a position to use as a
label into the code. Instead, add an explicit 'label' method.

* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::codeSize):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::loadBranchTarget):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::codeSize):
(JSC::ARMv7Assembler::ARMInstructionFormatter::codeSize):
(JSC::ARMv7Assembler::ARMInstructionFormatter::data):
* assembler/AbstractMacroAssembler.h:
* assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::codeSize):
(JSC::AssemblerBuffer::label):
* assembler/AssemblerBufferWithConstantPool.h:
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::newJmpSrc):
(JSC::MIPSAssembler::appendJump):
(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::codeSize):
(JSC::MIPSAssembler::relocateJumps):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::loadConstant):
(JSC::SH4Assembler::loadConstantUnReusable):
(JSC::SH4Assembler::call):
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::label):
(JSC::SH4Assembler::executableCopy):
(JSC::SH4Assembler::oneShortOp):
(JSC::SH4Assembler::codeSize):
* assembler/X86Assembler.h:
(JSC::X86Assembler::call):
(JSC::X86Assembler::jmp_r):
(JSC::X86Assembler::codeSize):
(JSC::X86Assembler::label):
(JSC::X86Assembler::executableCopy):
(JSC::X86Assembler::X86InstructionFormatter::immediateRel32):
(JSC::X86Assembler::X86InstructionFormatter::codeSize):
(JSC::X86Assembler::X86InstructionFormatter::label):
(JSC::X86Assembler::X86InstructionFormatter::executableCopy):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-30 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sat, 30 Apr 2011 15:29:35 +0000 (15:29 +0000)]
2011-04-30  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: inspector toolbar titles were 2px off.

        * inspector/front-end/inspector.css:
        (#toolbar-dropdown .toolbar-label):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip another test that requires layoutTestController.setAlwaysAcceptCookies on mac-wk2
aroben@apple.com [Sat, 30 Apr 2011 12:18:32 +0000 (12:18 +0000)]
Skip another test that requires layoutTestController.setAlwaysAcceptCookies on mac-wk2

<http://webkit.org/b/42778> tracks implementing this feature.

* platform/mac-wk2/Skipped: Added
http/tests/xmlhttprequest/cross-origin-cookie-storage.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip another test that requires eventSender.keyDown on mac-wk2
aroben@apple.com [Sat, 30 Apr 2011 12:16:28 +0000 (12:16 +0000)]
Skip another test that requires eventSender.keyDown on mac-wk2

<http://webkit.org/b/42194> tracks implementing this feature.

* platform/mac-wk2/Skipped: Added plugins/keyboard-events.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip another test that requires layoutTestController.overridePreference on mac-wk2
aroben@apple.com [Sat, 30 Apr 2011 12:14:53 +0000 (12:14 +0000)]
Skip another test that requires layoutTestController.overridePreference on mac-wk2

<http://webkit.org/b/42197> tracks implementing this feature.

* platform/mac-wk2/Skipped: Added fast/canvas/webgl/framebuffer-object-attachment.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip a failing test on mac-wk2
aroben@apple.com [Sat, 30 Apr 2011 12:01:51 +0000 (12:01 +0000)]
Skip a failing test on mac-wk2

I can't check in expected failure results because the results are slightly different each
time.

<http://webkit.org/b/59865> tracks the failure.

* platform/mac-wk2/Skipped: Added transitions/transition-timing-function.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip a flaky test on mac-wk2
aroben@apple.com [Sat, 30 Apr 2011 12:01:34 +0000 (12:01 +0000)]
Skip a flaky test on mac-wk2

<http://webkit.org/b/58990> tracks the failure.

* platform/mac-wk2/Skipped: Added editing/undo/undo-iframe-location-change.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove mac-wk2 expected failure results for an animation test
aroben@apple.com [Sat, 30 Apr 2011 12:01:18 +0000 (12:01 +0000)]
Remove mac-wk2 expected failure results for an animation test

Looks like this started passing in r85340. (I hope it wasn't because animation-api-1.html,
which is now skipped, was causing this one to fail!)

Fixes <http://webkit.org/b/56528> <rdar://problem/9147568> REGRESSION (r80846):
animations/animation-controller-drt-api.html failing in WebKit2

* platform/mac-wk2/animations/animation-controller-drt-api-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-30 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Sat, 30 Apr 2011 09:24:57 +0000 (09:24 +0000)]
2011-04-30  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Eric Seidel.

        V8Proxy.h shouldn't include SecurityOrigin.h
        https://bugs.webkit.org/show_bug.cgi?id=59859

        Remove SecurityOrigin.h #include from V8Proxy.h. Touching
        SecurityOrigin.h now rebuilds 234 targets instead of 638 (when building
        chromium's DumpRenderTree).

        * bindings/v8/NPV8Object.cpp:
        * bindings/v8/V8Proxy.cpp:
        * bindings/v8/V8Proxy.h:
        * css/CSSStyleSelector.cpp:
        * dom/XMLDocumentParserLibxml2.cpp:
        * html/HTMLLinkElement.cpp:
        * loader/SubframeLoader.cpp:
        * page/History.cpp:
        * storage/IDBFactory.cpp:
        * storage/StorageAreaImpl.cpp:
2011-04-30  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Eric Seidel.

        V8Proxy.h shouldn't include SecurityOrigin.h
        https://bugs.webkit.org/show_bug.cgi?id=59859

        Add SecurityOrigin.h includes to places that were relying on transitive
        includes.

        * src/ApplicationCacheHost.cpp:
        * src/WebGeolocationPermissionRequest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add one more flakey test to the Skipped list.
ossy@webkit.org [Sat, 30 Apr 2011 08:13:50 +0000 (08:13 +0000)]
[Qt] Add one more flakey test to the Skipped list.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-29 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Sat, 30 Apr 2011 08:11:57 +0000 (08:11 +0000)]
2011-04-29  Jer Noble  <jer.noble@apple.com>

        Reviewed by Adam Roben.

        Implement FULLSCREEN_API on Windows, Part 2: WebKit
        https://bugs.webkit.org/show_bug.cgi?id=59785

        Initial implementation of full screen API on windows.  No animation
        occurs when entering or exiting full screen.  Re-use existing window
        classes (MediaPlayerPrivateFullscreenWindow) to host the webView.

        * WebCoreSupport/WebChromeClient.cpp:
        (WebChromeClient::supportsFullScreenForElement): Call into WebView.
        (WebChromeClient::enterFullScreenForElement): Call into WebFullScreenController.
        (WebChromeClient::exitFullScreenForElement): Ditto.
        * WebFullScreenController.cpp: Added.
        (WebFullScreenController::Private::Private): Private data storage class.
        (WebFullScreenController::Private::~Private):
        (WebFullScreenController::Private::fullscreenClientWndProc): Handle window
            message for full screen window.
        (WebFullScreenController::WebFullScreenController):
        (WebFullScreenController::~WebFullScreenController):
        (WebFullScreenController::setElement): Added.
        (WebFullScreenController::element): Added.
        (WebFullScreenController::isFullScreen): Added.
        (WebFullScreenController::enterFullScreen): Create and display full screen
            window, moving webView as child window.
        (WebFullScreenController::exitFullScreen): Destroy full screen window and
            move webView back where we found it.
        * WebFullScreenController.h: Added.
        * WebKit.vcproj/WebKit.vcproj:
        * WebView.cpp:
        (WebView::keyDown): Handle the ESC key.
        (WebView::notifyPreferencesChanged):
        (WebView::supportsFullScreenForElement): Do not support full screen if
            full screen preference is disabled, or if keyboard access is requested.
        (WebView::isFullScreen): Added.
        (WebView::fullScreenController): Added.
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Update Qt specific expected files after r85355.
ossy@webkit.org [Sat, 30 Apr 2011 06:56:38 +0000 (06:56 +0000)]
Unreviewed. Update Qt specific expected files after r85355.
https://bugs.webkit.org/show_bug.cgi?id=59833

* platform/qt/fast/table/prepend-in-anonymous-table-expected.txt:
* platform/qt/tables/mozilla_expected_failures/other/test4-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 30 Apr 2011 05:48:18 +0000 (05:48 +0000)]
2011-04-29  Adam Barth  <abarth@webkit.org>

        Attempt to fix the Windows build.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 30 Apr 2011 05:20:07 +0000 (05:20 +0000)]
2011-04-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk+] Crash when navigating back
        https://bugs.webkit.org/show_bug.cgi?id=59799

        The innerNode management in WebKitHitTestResult was relying on the
        old DOM bindings behavior where every DOM objects had to be
        disposed by the caller. Now the objects are garbage collected by
        WebKit when either the parent frame or document dies, so this is
        not needed anymore. Update the code to simply take ownership of
        the node, which effectively correctly balances the reference
        count.

        * webkit/webkithittestresult.cpp:
        (webkit_hit_test_result_dispose): call C++ dtors in private data.
        (webkit_hit_test_result_get_property): adatp to GRefPtr API.
        (webkit_hit_test_result_init): call C++ ctors in private data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Sat, 30 Apr 2011 04:30:09 +0000 (04:30 +0000)]
2011-04-28  Jer Noble  <jer.noble@apple.com>

        Reviewed by Jon Honeycutt.

        Implement FULLSCREEN_API on Windows, Part 1: Stubs
        https://bugs.webkit.org/show_bug.cgi?id=59778

        Create all the stubs necessary to for enabling FULLSCREEN_API
        on Windows. This includes the COM interfaces for preferences and
        for overriding full screen behavior in a UI Delegate.

        * Interfaces/IWebPreferencesPrivate.idl: Add functions for enabling
            full screen preference.
        * Interfaces/IWebUIDelegatePrivate.idl: Add functions for overriding
            full screen behavior.
        * WebCoreSupport/WebChromeClient.cpp:
        (WebChromeClient::supportsFullScreenForElement): Added.
        (WebChromeClient::enterFullScreenForElement): Added.
        (WebChromeClient::exitFullScreenForElement): Added.
        * WebCoreSupport/WebChromeClient.h:
        * WebPreferenceKeysPrivate.h: Added WebKitFullScreenEnable key.
        * WebPreferences.cpp:
        (WebPreferences::isFullScreenEnabled): Added. Implements function
           defined in IWebUIDelegatePrivate.
        (WebPreferences::setFullScreenEnabled): Ditto.
        * WebPreferences.h:
2011-04-28  Jer Noble  <jer.noble@apple.com>

        Reviewed by Jon Honeycutt.

        Implement FULLSCREEN_API on Windows, Part 1: Stubs
        https://bugs.webkit.org/show_bug.cgi?id=59778

        Add Windows specific stubs for WebKit2 full screen APIs.

        * UIProcess/win/WebFullScreenManagerProxyWin.cpp: Added.
        (WebKit::WebFullScreenManagerProxy::enterFullScreen): Added stub.
        (WebKit::WebFullScreenManagerProxy::exitFullScreen): Added stub.
        (WebKit::WebFullScreenManagerProxy::beganEnterFullScreenAnimation): Added stub.
        (WebKit::WebFullScreenManagerProxy::finishedEnterFullScreenAnimation): Added stub.
        (WebKit::WebFullScreenManagerProxy::beganExitFullScreenAnimation): Added stub.
        (WebKit::WebFullScreenManagerProxy::finishedExitFullScreenAnimation): Added stub.
        (WebKit::WebFullScreenManagerProxy::enterAcceleratedCompositingMode): Added stub.
        (WebKit::WebFullScreenManagerProxy::exitAcceleratedCompositingMode): Added stub.
        (WebKit::WebFullScreenManagerProxy::getFullScreenRect): Added stub.
        * WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp: Added.
        (WebKit::WebFullScreenManager::create): Added. Returns a WebFullScreenManagerWin.
        (WebKit::WebFullScreenManagerWin::create): Added.
        (WebKit::WebFullScreenManagerWin::WebFullScreenManagerWin): Added.
        (WebKit::WebFullScreenManagerWin::~WebFullScreenManagerWin): Added.
        (WebKit::WebFullScreenManagerWin::setRootFullScreenLayer): Added stub.
        (WebKit::WebFullScreenManagerWin::beginEnterFullScreenAnimation): Added stub.
        (WebKit::WebFullScreenManagerWin::beginExitFullScreenAnimation): Added stub.
        * WebProcess/FullScreen/win/WebFullScreenManagerWin.h: Added.
        * win/WebKit2.vcproj: Added new classes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 30 Apr 2011 04:30:03 +0000 (04:30 +0000)]
2011-04-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP script-src should block eval
        https://bugs.webkit.org/show_bug.cgi?id=59850

        Test that both function-eval and operator-eval are correctly blocked
        and allowed according to the policy.

        * http/tests/security/contentSecurityPolicy/eval-allowed-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/eval-allowed.html: Added.
        * http/tests/security/contentSecurityPolicy/eval-blocked-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/eval-blocked.html: Added.
2011-04-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP script-src should block eval
        https://bugs.webkit.org/show_bug.cgi?id=59850

        ggaren recommend a different approach to this patch, essentially
        installing a new function for function-eval and changing the AST
        representation of operator-eval to call function-eval.  However, I'm
        not sure that approach is workable because the ASTBuilder doesn't know
        about global objects, and there is added complication due to the cache.

        This approach is more dynamic, adding a branch in EvalExecutable to
        detect whether eval is current disabled in the lexical scope.  The spec
        is slightly unclear about whether we should return undefined or throw
        an exception.  I've asked Brandon to clarify the spec, but throwing an
        exception seems natural.

        * JavaScriptCore.exp:
        * runtime/Executable.cpp:
        (JSC::EvalExecutable::compileInternal):
        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::disableEval):
        * runtime/JSGlobalObject.h:
        (JSC::JSGlobalObject::JSGlobalObject):
        (JSC::JSGlobalObject::isEvalEnabled):
2011-04-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP script-src should block eval
        https://bugs.webkit.org/show_bug.cgi?id=59850

        Rather than have JavaScriptCore call back into WebCore to learn whether
        eval is enabled, we push that bit of the policy into JavaScriptCore.

        Tests: http/tests/security/contentSecurityPolicy/eval-allowed.html
               http/tests/security/contentSecurityPolicy/eval-blocked.html

        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::disableEval):
        * bindings/js/ScriptController.h:
        * page/ContentSecurityPolicy.cpp:
        (WebCore::ContentSecurityPolicy::didReceiveHeader):
        (WebCore::ContentSecurityPolicy::internalAllowEval):
        (WebCore::ContentSecurityPolicy::allowEval):
        * page/ContentSecurityPolicy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-29 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sat, 30 Apr 2011 04:18:08 +0000 (04:18 +0000)]
2011-04-29  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed. Add windows expected results for a new test.

        * platform/win/fast/forms/date-input-visible-strings-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Simon Fraser and Dan Bernstein.
ap@apple.com [Sat, 30 Apr 2011 03:47:28 +0000 (03:47 +0000)]
    Reviewed by Simon Fraser and Dan Bernstein.

        WebKit2: WebPluginTypeEnabled key is ignored when enumerating plug-ins
        https://bugs.webkit.org/show_bug.cgi?id=59852
        <rdar://problem/9314011>

        * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
        (WebKit::getPluginInfoFromPropertyLists): Do what WebKit1 does (but in CF dialect). And yes,
        I've seen plists with both numbers and booleans used .

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-29 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sat, 30 Apr 2011 03:26:47 +0000 (03:26 +0000)]
2011-04-29  Joseph Pecoraro  <joepeck@webkit.org>

        GTK build fix. Missed moving DateComponents and
        adding LocalizedDate files for their build file.

        * GNUmakefile.list.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 30 Apr 2011 02:56:23 +0000 (02:56 +0000)]
2011-04-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        style-src should block @style
        https://bugs.webkit.org/show_bug.cgi?id=59293

        Testing makes perfect.

        * http/tests/security/contentSecurityPolicy/inline-style-attribute-allowed-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/inline-style-attribute-allowed.html: Added.
        * http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked.html: Added.
        * http/tests/security/contentSecurityPolicy/inline-style-attribute-on-html-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/inline-style-attribute-on-html.html: Added.
2011-04-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        style-src should block @style
        https://bugs.webkit.org/show_bug.cgi?id=59293

        This patch blocks @style when style-src doesn't have the
        'unsafe-inline' token.  This patch blocks the parsing of the attribute
        itself.  That feels vaguely like too low a level to interpose the
        policy, but there didn't seem to be anywhere else natural to enforce
        the policy.

        Tests: http/tests/security/contentSecurityPolicy/inline-style-attribute-allowed.html
               http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked.html
               http/tests/security/contentSecurityPolicy/inline-style-on-html.html

        * dom/StyledElement.cpp:
        (WebCore::StyledElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 30 Apr 2011 02:50:58 +0000 (02:50 +0000)]
2011-04-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        land-safely patches should show show their place in the commit-queue
        https://bugs.webkit.org/show_bug.cgi?id=59853

        This complicated the "should we show the bubbles or the submit-to-ews button"
        logic substantially. :(  But now we'll show both the commit-queue position
        as well as the submit-to-ews button for land-safely (cq+ only) patches.
        Previously we would only show the submit-to-ews button.

        * QueueStatusServer/handlers/statusbubble.py:
        * QueueStatusServer/templates/statusbubble.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-29 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sat, 30 Apr 2011 02:41:34 +0000 (02:41 +0000)]
2011-04-29  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Kent Tamura.

        Allow Localized Date Strings for Date Input Fields
        https://bugs.webkit.org/show_bug.cgi?id=59752

        The render tree dump prints out the visible string
        inside the <input> field.

        * fast/forms/date-input-visible-strings.html: Added.
        * platform/mac/fast/forms/date-input-visible-strings-expected.txt: Added.

2011-04-29  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Kent Tamura.

        Allow Localized Date Strings for Date Input Fields
        https://bugs.webkit.org/show_bug.cgi?id=59752

        Test: fast/forms/date-input-visible-strings.html

        * CMakeLists.txt:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj: update build files for
        moving DateComponents from WebCore/html to WebCore/platform
        and adding the LocalizedDate files.

        * html/BaseDateAndTimeInputType.cpp:
        (WebCore::BaseDateAndTimeInputType::serialize):
        (WebCore::BaseDateAndTimeInputType::serializeWithComponents):
        (WebCore::BaseDateAndTimeInputType::serializeWithMilliseconds):
        InputType::serialize for a double value with date types is
        different for the month type because it assumes the incoming
        value is months instead of msecs (matching valueAsNumber in
        HTML5).  So provide a more general serialization function,
        serializeWithComponents, that will always serialize a string
        correctly for the current type but taking in a DateComponents
        object. The default serialize, and new serializeWithMilliseconds,
        can fall back to this and allows an override point for
        the month type.

        * html/MonthInputType.cpp:
        (WebCore::MonthInputType::serializeWithMilliseconds): the month
        type is a case where the default serialize does not take msec,
        so provide an implementation for month which handles msec input.

        * html/BaseDateAndTimeInputType.cpp:
        (WebCore::BaseDateAndTimeInputType::setValueAsDate): switch
        to serializeWithMilliseconds as the incoming date value is msec.
        * html/MonthInputType.cpp:
        (WebCore::MonthInputType::setValueAsDate): removed.

        * html/BaseDateAndTimeInputType.cpp:
        (WebCore::BaseDateAndTimeInputType::visibleValue): allow
        localized formatting of a date value.
        (WebCore::BaseDateAndTimeInputType::convertFromVisibleValue):
        allow parsing for a formatted date value.

        * html/BaseDateAndTimeInputType.h:
        * platform/DateComponents.cpp: Renamed from Source/WebCore/html/DateComponents.cpp.
        Expose the Type enum so it can be used outside of the DateComponents class.
        * platform/text/LocalizedDate.h: Added.
        * platform/text/LocalizedDateNone.cpp: Added.
        (WebCore::formatLocalizedDate): Default implementation falls back to
        existing HTML5 date input value formatting.

        * html/BaseDateAndTimeInputType.h:
        * html/DateInputType.cpp:
        (WebCore::DateInputType::dateType):
        * html/DateInputType.h:
        * html/DateTimeInputType.cpp:
        (WebCore::DateTimeInputType::dateType):
        * html/DateTimeInputType.h:
        * html/DateTimeLocalInputType.cpp:
        (WebCore::DateTimeLocalInputType::dateType):
        * html/DateTimeLocalInputType.h:
        * html/MonthInputType.cpp:
        (WebCore::MonthInputType::dateType):
        * html/MonthInputType.h:
        * html/TimeInputType.cpp:
        (WebCore::TimeInputType::dateType):
        * html/TimeInputType.h:
        * html/WeekInputType.cpp:
        (WebCore::WeekInputType::dateType):
        * html/WeekInputType.h: Accessors for the desired date
        type of a date input type. This allows the base class
        to write a generic algorithm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 30 Apr 2011 02:22:35 +0000 (02:22 +0000)]
2011-04-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        style-src should block inline style from <style>
        https://bugs.webkit.org/show_bug.cgi?id=59292

        Testing makes perfect.

        * http/tests/security/contentSecurityPolicy/inline-style-allowed-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/inline-style-allowed.html: Added.
        * http/tests/security/contentSecurityPolicy/inline-style-blocked-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/inline-style-blocked.html: Added.
2011-04-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        style-src should block inline style from <style>
        https://bugs.webkit.org/show_bug.cgi?id=59292

        The spec has been updated to allow blocking of inline styles with
        style-src.  This will help folks defend against tricky CSS3 injections.

        This patch covers the <style> case.  The next patch will cover the
        @style case.

        Tests: http/tests/security/contentSecurityPolicy/inline-style-allowed.html
               http/tests/security/contentSecurityPolicy/inline-style-blocked.html

        * dom/StyleElement.cpp:
        (WebCore::StyleElement::createSheet):
        * page/ContentSecurityPolicy.cpp:
        (WebCore::ContentSecurityPolicy::allowInlineStyle):
        * page/ContentSecurityPolicy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-29 Naoki Takano <takano.naoki@gmail.com>
commit-queue@webkit.org [Sat, 30 Apr 2011 02:17:28 +0000 (02:17 +0000)]
2011-04-29  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Adam Barth.

        Add my name to contributers.
        https://bugs.webkit.org/show_bug.cgi?id=59854

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85380 268f45cc-cd09-0410-ab3c-d52691b4dbfc