jianli@chromium.org [Tue, 16 Jun 2009 21:00:29 +0000 (21:00 +0000)]
2009-06-16 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
Bug 26450: Rename values of enum RedirectOriginCheck to make them
clearer.
https://bugs.webkit.org/show_bug.cgi?id=26450
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::create):
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::willSendRequest):
* loader/DocumentThreadableLoader.h:
* loader/ThreadableLoader.cpp:
(WebCore::ThreadableLoader::create):
(WebCore::ThreadableLoader::loadResourceSynchronously):
* loader/ThreadableLoader.h:
* workers/Worker.cpp:
(WebCore::Worker::Worker):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::importScripts):
* loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
(WebCore::WorkerThreadableLoader::loadResourceSynchronously):
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
* loader/WorkerThreadableLoader.h:
(WebCore::WorkerThreadableLoader::create):
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadSynchronously):
(WebCore::WorkerScriptLoader::loadAsynchronously):
* workers/WorkerScriptLoader.h:
(WebCore::WorkerContext::importScripts):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::loadRequestAsynchronously):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 16 Jun 2009 20:31:45 +0000 (20:31 +0000)]
2009-06-16 Tony Chang <tony@chromium.org>
Reviewed by Darin Fisher.
Fix a UMR in WebCore::BitStack by initializing new memory to 0.
https://bugs.webkit.org/show_bug.cgi?id=26449
No new tests, covered by purify.
* editing/TextIterator.cpp:
(WebCore::BitStack::push):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 16 Jun 2009 20:27:16 +0000 (20:27 +0000)]
009-06-16 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Xan Lopez.
Fixes https://bugs.webkit.org/show_bug.cgi?id=26453.
Null Cairo contextwill crash Windows Cairo build.
Test: fast/multicol/columns-shorthand-parsing.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Tue, 16 Jun 2009 19:27:42 +0000 (19:27 +0000)]
2009-06-16 Peter Kasting <pkasting@google.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=26447
Fix animated GIF breakage in Cairo/wx ports.
* platform/image-decoders/cairo/ImageDecoderCairo.cpp:
(WebCore::RGBA32Buffer::copyBitmapData):
(WebCore::RGBA32Buffer::operator=):
* platform/image-decoders/wx/ImageDecoderWx.cpp:
(WebCore::RGBA32Buffer::copyBitmapData):
(WebCore::RGBA32Buffer::operator=):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 16 Jun 2009 19:26:55 +0000 (19:26 +0000)]
2009-06-16 Simon Fraser <simon.fraser@apple.com>
Rubber-stamped by Anders Carlsson.
Update WebKitSystemInterface for <rdar://problem/6937882>.
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* libWebKitSystemInterfaceTiger.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 16 Jun 2009 18:51:16 +0000 (18:51 +0000)]
2009-06-16 Xan Lopez <xlopez@igalia.com>
Disable another new test.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 16 Jun 2009 18:36:14 +0000 (18:36 +0000)]
2009-06-16 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by John Sullivan
<rdar://problem/6937882>
Tweak "time remaining" and "time elapsed" fields in the overlay video controller.
* css/mediaControlsQT.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 16 Jun 2009 18:36:04 +0000 (18:36 +0000)]
2009-06-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Do not use g_assert_cmpint to test for NULL pointer, just
g_assert.
* tests/testnetworkrequest.c:
(test_network_request_create_destroy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 16 Jun 2009 18:27:32 +0000 (18:27 +0000)]
2009-06-16 Xan Lopez <xlopez@igalia.com>
editing/deleting/4875189.html was changed from pixel to
dumpAsText, so remove it from Skipped list.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 16 Jun 2009 18:19:14 +0000 (18:19 +0000)]
2009-06-16 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26437
Make the commit-log-editor match the ambient line endings in commit
messages.
* Scripts/commit-log-editor:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Tue, 16 Jun 2009 18:12:46 +0000 (18:12 +0000)]
WebCore:
2009-06-16 Jian Li <jianli@chromium.org>
Reviewed by Adam Barth and David Levin.
Bug 26146: Change to use ThreadableLoader to load the worker script
in order to check URL origin for redirection.
https://bugs.webkit.org/show_bug.cgi?id=26146
Test: http/tests/workers/worker-redirect.html
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* workers/Worker.cpp:
(WebCore::Worker::Worker):
(WebCore::Worker::notifyFinished):
* workers/Worker.h:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::importScripts):
* workers/WorkerImportScriptsClient.cpp: Removed.
* workers/WorkerImportScriptsClient.h: Removed.
* workers/WorkerScriptLoader.cpp: Renamed from workers/WorkerImportScriptsClient.cpp.
This to make it more generic so worker script loading could use it.
(WebCore::WorkerScriptLoader::loadSynchronously):
(WebCore::WorkerScriptLoader::loadAsynchronously):
(WebCore::WorkerScriptLoader::didFinishLoading):
(WebCore::WorkerScriptLoader::didFail):
(WebCore::WorkerScriptLoader::didFailRedirectCheck):
(WebCore::WorkerScriptLoader::didReceiveAuthenticationCancellation):
(WebCore::WorkerScriptLoader::notifyFinished):
* workers/WorkerScriptLoader.h: Renamed from workers/WorkerImportScriptsClient.h.
This to make it more generic so worker script loading could use it.
* workers/WorkerScriptLoaderClient.h: Added.
LayoutTests:
2009-06-16 Jian Li <jianli@chromium.org>
Reviewed by Adam Barth and David Levin.
Bug 26146: Change to use ThreadableLoader to load the worker script
in order to check URL origin for redirection.
https://bugs.webkit.org/show_bug.cgi?id=26146
Add a layout test to cover the scenario that the worker script is
loaded from different redirect origin.
* http/tests/workers/resources/worker-redirect-target.js: Added.
* http/tests/workers/worker-redirect-expected.txt: Added.
* http/tests/workers/worker-redirect.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 16 Jun 2009 17:59:54 +0000 (17:59 +0000)]
2009-06-16 Xan Lopez <xlopez@igalia.com>
Fix typo in test name.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 16 Jun 2009 17:48:53 +0000 (17:48 +0000)]
2009-06-16 Xan Lopez <xlopez@igalia.com>
Disable new tests.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 16 Jun 2009 16:44:25 +0000 (16:44 +0000)]
009-06-16 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Darin Adler.
Use consistent GUID comparison functions.
https://bugs.webkit.org/show_bug.cgi?id=26427
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 16 Jun 2009 14:09:39 +0000 (14:09 +0000)]
2009-06-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Fix compiler warning.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_class_init):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 16 Jun 2009 14:09:28 +0000 (14:09 +0000)]
2009-06-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Remove dummy AtkStreamableContent implementation.
It's completely empty, we'll add it back (and conditionally
instead of unconditionally) when it does something.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(GetAtkInterfaceTypeFromWAIType):
(getInterfaceMaskFromObject):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 16 Jun 2009 13:32:35 +0000 (13:32 +0000)]
2009-06-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update GtkLauncher to recent API changes in the progress property,
which now goes from 0.0 to 1.0.
* GtkLauncher/main.c:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 16 Jun 2009 08:40:46 +0000 (08:40 +0000)]
2009-06-16 David Boddie <dboddie@trolltech.com>
Reviewed by Simon Hausmann.
Doc: Fixed QWebPage::forwardUnsupportedContent documentation and added
more information about Web plugins.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 16 Jun 2009 08:40:35 +0000 (08:40 +0000)]
2009-06-16 Morten Engvoldsen <morten.engvoldsen@nokia.com>
Reviewed by Ariya Hidayat.
Clearifying QWebFrame docs
Adding docs to toHtml() and toPlainText()
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 16 Jun 2009 08:10:24 +0000 (08:10 +0000)]
Fix ChangeLog typo.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 16 Jun 2009 08:06:58 +0000 (08:06 +0000)]
2009-06-16 Adam Barth <abarth@webkit.org>
Reviewed by Darin Alder.
https://bugs.webkit.org/show_bug.cgi?id=26000
Teach prepare-ChangeLog to match the line ends that are already present
in ChangeLog files. This helps folks whose use cygwin perl with CR LF
line endings on Windows.
Also, teach prepare-ChangeLog to normalize backslashes in paths. This
helps folks who use Windows SVN prepare correct ChangeLogs.
* Scripts/prepare-ChangeLog:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Tue, 16 Jun 2009 07:35:30 +0000 (07:35 +0000)]
Roll over some ChangeLog files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Tue, 16 Jun 2009 07:35:13 +0000 (07:35 +0000)]
Add a script to automate the rolling over of ChangeLog files when they grow too large.
Reviewed by Oliver Hunt.
* Scripts/roll-over-ChangeLogs: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Tue, 16 Jun 2009 06:52:49 +0000 (06:52 +0000)]
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Sam Weinig.
Rename PatchBuffer to LinkBuffer. Previously our terminology has been a little
mixed up, but we have decided to fix on refering to the process that takes place
at the end of code generation as 'linking', and on any modifications that take
place later (and once the code has potentially already been executed) as 'patching'.
However, the term 'PatchBuffer' is already in use, and needs to be repurposed.
To try to minimize confusion, we're going to switch the terminology over in stages,
so for now we'll refer to later modifications as 'repatching'. This means that the
new 'PatchBuffer' has been introduced with the name 'RepatchBuffer' instead.
This patch renames the old 'PatchBuffer' to 'LinkBuffer'. We'll leave ToT in this
state for a week or so to try to avoid to much overlap of the meaning of the term
'PatchBuffer', then will come back and rename 'RepatchBuffer'.
* assembler/ARMv7Assembler.h:
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::LinkBuffer::LinkBuffer):
(JSC::AbstractMacroAssembler::LinkBuffer::~LinkBuffer):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::compile):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Tue, 16 Jun 2009 06:17:08 +0000 (06:17 +0000)]
WebCore:
2009-06-15 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/6907228> Pasting a paragraph as quotation leaves you typing in blue instead of black; repros
* editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
When inserting a newline after the blockquote, we don't want to apply the original style after the insertion.
LayoutTests:
2009-06-15 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Updating test for:
<rdar://problem/6907228> Pasting a paragraph as quotation leaves you typing in blue instead of black; repros
This test case covered inserting a newline after a blockquote, but outside of the blockquote. I added some
text insertion to verify that the newline doesn't get any old styles copied from the blockquote.
* editing/pasteboard/5368833.html:
* platform/mac/editing/pasteboard/5368833-expected.checksum:
* platform/mac/editing/pasteboard/5368833-expected.png:
* platform/mac/editing/pasteboard/5368833-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Tue, 16 Jun 2009 05:35:32 +0000 (05:35 +0000)]
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Having moved most of their functionality into the RepatchBuffer class,
we can simplify the CodeLocation* classes.
The CodeLocation* classes are currently a tangle of templatey and friendly
badness, burried in the middle of AbstractMacroAssembler. Having moved
the ability to repatch out into RepatchBufer they are now do-nothing wrappers
on CodePtr (MacroAssemblerCodePtr), that only exist to provide type-safety.
Simplify the code, and move them off into their own header.
* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::PatchBuffer::patch):
* assembler/CodeLocation.h: Copied from assembler/AbstractMacroAssembler.h.
(JSC::CodeLocationCommon::CodeLocationCommon):
(JSC::CodeLocationInstruction::CodeLocationInstruction):
(JSC::CodeLocationLabel::CodeLocationLabel):
(JSC::CodeLocationJump::CodeLocationJump):
(JSC::CodeLocationCall::CodeLocationCall):
(JSC::CodeLocationNearCall::CodeLocationNearCall):
(JSC::CodeLocationDataLabel32::CodeLocationDataLabel32):
(JSC::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr):
(JSC::CodeLocationCommon::instructionAtOffset):
(JSC::CodeLocationCommon::labelAtOffset):
(JSC::CodeLocationCommon::jumpAtOffset):
(JSC::CodeLocationCommon::callAtOffset):
(JSC::CodeLocationCommon::nearCallAtOffset):
(JSC::CodeLocationCommon::dataLabelPtrAtOffset):
(JSC::CodeLocationCommon::dataLabel32AtOffset):
* assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodePtr::operator!):
* bytecode/CodeBlock.h:
(JSC::getStructureStubInfoReturnLocation):
(JSC::getCallLinkInfoReturnLocation):
(JSC::getMethodCallLinkInfoReturnLocation):
* bytecode/Instruction.h:
* bytecode/JumpTable.h:
(JSC::StringJumpTable::ctiForValue):
(JSC::SimpleJumpTable::ctiForValue):
* bytecode/StructureStubInfo.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCatch):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITStubs.cpp:
(JSC::JITStubs::DEFINE_STUB_FUNCTION):
(JSC::JITStubs::getPolymorphicAccessStructureListSlot):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 16 Jun 2009 05:03:17 +0000 (05:03 +0000)]
2009-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove outdated comment.
* bindings/js/JSDOMWindowBase.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 16 Jun 2009 04:58:25 +0000 (04:58 +0000)]
2009-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Bring CustomGetPropertyNames more inline with the other
extended attributes prefixed with Custom, by making it
require a complete implementation.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getPropertyNames):
* bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::getPropertyNames):
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::getPropertyNames):
* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::getPropertyNames):
* bindings/scripts/CodeGeneratorJS.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 16 Jun 2009 04:04:19 +0000 (04:04 +0000)]
2009-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove commented out ondataunavailable attribute event listener which
has now been removed from HTML 5.
* page/DOMWindow.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 16 Jun 2009 04:02:00 +0000 (04:02 +0000)]
2009-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Move entire custom implementation of getOwnPropertySlot and put
for JSDOMWindow into JSDOMWindowCustom, eliminating the bit in
JSDOMWindowBase.
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::nonCachingStaticFunctionGetter):
(WebCore::childFrameGetter):
(WebCore::indexGetter):
(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::getPropertyAttributes):
* bindings/js/JSDOMWindowCustom.h:
* page/DOMWindow.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 16 Jun 2009 04:00:18 +0000 (04:00 +0000)]
2009-06-15 Jeremy Orlow (jorlow@chromium.org)
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26356
Define the functions in V8CustomBindings.h. "Forgot" this in my
earlier patch since it wasn't fully upstreamed when I wrote the
patch.
* bindings/v8/custom/V8CustomBinding.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Tue, 16 Jun 2009 03:01:12 +0000 (03:01 +0000)]
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Having introduced the RepatchBuffer, ProcessorReturnAddress is now a do-nothing
wrapper around ReturnAddressPtr. Remove it. In tugging on this piece of string
it made sense to roll out the use of ReturnAddressPtr a little further into
JITStubs (which had always been the intention).
No performance impact.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToTrampoline):
(JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToFunction):
(JSC::AbstractMacroAssembler::RepatchBuffer::relinkNearCallerToTrampoline):
* assembler/MacroAssemblerCodeRef.h:
(JSC::ReturnAddressPtr::ReturnAddressPtr):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::getStubInfo):
(JSC::CodeBlock::getCallLinkInfo):
(JSC::CodeBlock::getMethodCallLinkInfo):
(JSC::CodeBlock::getBytecodeIndex):
* interpreter/Interpreter.cpp:
(JSC::bytecodeOffsetForPC):
* jit/JIT.cpp:
(JSC::ctiPatchNearCallByReturnAddress):
(JSC::ctiPatchCallByReturnAddress):
* jit/JIT.h:
(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):
(JSC::JIT::compilePatchGetArrayLength):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::StackHack::StackHack):
(JSC::returnToThrowTrampoline):
(JSC::throwStackOverflowError):
(JSC::JITStubs::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC::):
(JSC::JITStackFrame::returnAddressSlot):
* runtime/JSGlobalData.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 16 Jun 2009 02:13:41 +0000 (02:13 +0000)]
2009-06-15 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Adam Treat.
Support the back/forward/stop/refresh multimedia keys and accept the
event when handling backspace and shift backspace as we should.
* Api/qwebpage.cpp:
(QWebPagePrivate::keyPressEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 16 Jun 2009 01:36:30 +0000 (01:36 +0000)]
2009-06-15 Andre Boule <aboule@apple.com>
Reviewed by Cameron Zwarich and Dan Bernstein.
- fix <rdar://problem/6967975> crash with NSString drawAtPoint
No test possible because this crash can only occur if the client uses
WebKit text drawing without ever using WebCore text, and DumpRenderTree
cannot do either.
* platform/graphics/FontCache.cpp:
(WebCore::FontCache::purgeInactiveFontData): Null-check
gFontPlatformDataCache.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 16 Jun 2009 01:27:57 +0000 (01:27 +0000)]
2009-06-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Mark Rowe.
<rdar://problem/6974857>
Define ENABLE_3D_RENDERING and WTF_USE_ACCELERATED_COMPOSITING when building on 10.6.
Move the ENABLE_3D_RENDERING switch from config.h and WebKitPrefix.h to wtf/Platform.h
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 16 Jun 2009 01:12:46 +0000 (01:12 +0000)]
2009-06-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Make WebInspector's console evaluation/completion asynchronous.
This way of evaluation allows serializing calls between
InspectorController and its frontend.
https://bugs.webkit.org/show_bug.cgi?id=26350
* inspector/front-end/Console.js:
(WebInspector.Console.prototype.completions):
(WebInspector.Console.prototype._reportCompletions):
(WebInspector.Console.prototype._evalInInspectedWindow):
(WebInspector.Console.prototype._enterKeyPressed.printResult):
(WebInspector.Console.prototype._enterKeyPressed):
* inspector/front-end/DatabaseQueryView.js:
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.evaluateExpression):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Tue, 16 Jun 2009 00:26:53 +0000 (00:26 +0000)]
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Move repatching methods into a set of methods on a class. This will allow us to
coallesce memory reprotection calls. Really, we want this class to be called
PatchBuffer, we want the class PatchBuffer to be called LinkBuffer, we want both
to be memblers of MacroAssembler rather then AbstractMacroAssembler, we don't
want the CodeLocationFoo types anymore (they are now only really there to provide
type safety, and that is completely undermined by the way we use offsets). Then
the link & patch buffers should delegate the actual patching calls to the
architecture-specific layer of the MacroAssembler. Landing all these changes as a
sequence of patches.
No performance impact.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::CodeLocationCall::CodeLocationCall):
(JSC::AbstractMacroAssembler::CodeLocationNearCall::CodeLocationNearCall):
(JSC::AbstractMacroAssembler::CodeLocationNearCall::calleeReturnAddressValue):
(JSC::AbstractMacroAssembler::RepatchBuffer::RepatchBuffer):
(JSC::AbstractMacroAssembler::RepatchBuffer::relink):
(JSC::AbstractMacroAssembler::RepatchBuffer::repatch):
(JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToTrampoline):
(JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToFunction):
(JSC::AbstractMacroAssembler::RepatchBuffer::relinkNearCallerToTrampoline):
(JSC::AbstractMacroAssembler::RepatchBuffer::repatchLoadPtrToLEA):
* jit/JIT.cpp:
(JSC::ctiPatchNearCallByReturnAddress):
(JSC::ctiPatchCallByReturnAddress):
(JSC::JIT::unlinkCall):
(JSC::JIT::linkCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchMethodCallProto):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 15 Jun 2009 23:16:24 +0000 (23:16 +0000)]
2009-06-15 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6967569>
CrashTracer: 15 crashes in Safari at com.apple.WebKit • WebKit::NetscapePluginHostManager::didCreateWindow + 85
Make sure to remove the entry from the plug-in host map so we won't end up with an entry that has a null value.
* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::hostForPackage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Mon, 15 Jun 2009 23:10:57 +0000 (23:10 +0000)]
2009-06-15 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher.
Reverted previous change as the old behavior was correct for heavy view.
* inspector/front-end/BottomUpProfileDataGridTree.js:
(WebInspector.BottomUpProfileDataGridNode.prototype._populate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Mon, 15 Jun 2009 22:39:26 +0000 (22:39 +0000)]
2009-06-15 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher.
<rdar://problem/6968125> Profiler 'Call' count is incorrect in Heavy
view (26418)
- Removed code that copied call and time data from it's ancestor.
* inspector/front-end/BottomUpProfileDataGridTree.js:
(WebInspector.BottomUpProfileDataGridNode.prototype._populate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Mon, 15 Jun 2009 22:21:54 +0000 (22:21 +0000)]
Reviewed by Simon Fraser <simon.fraser@apple.com>.
https://bugs.webkit.org/show_bug.cgi?id=26163
Added logic to updateTransitions similar to that in updateKeyframeAnimations
which detects and removes stale transitions.
Test: transitions/cancel-transition.html
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::ImplicitAnimation):
* page/animation/ImplicitAnimation.h:
(WebCore::ImplicitAnimation::active):
(WebCore::ImplicitAnimation::setActive):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 15 Jun 2009 21:18:17 +0000 (21:18 +0000)]
WebCore:
Reviewed by Tim Hatcher.
- allow the source code font in the Web Inspector to be customized
* css/view-source.css: Use the default monospace font family and size
for source code.
* inspector/front-end/inspector.css: Use the default monospace font
family and size for console I/O.
WebKit/mac:
Reviewed by Tim Hatcher.
- make the source code font in the Web Inspector match Mac defaults
* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController init]): Set the default monospace font
to 11px Menlo, except on Leopard and Tiger where it is 10px Monaco.
WebKit/win:
Reviewed by Tim Hatcher.
- use a nice source code font in the Web Inspector
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::createPage): Set the default monospace font to
13px Courier New, which is the default source code font in Visual
Studio.
LayoutTests:
Reviewed by Tim Hatcher.
- updated results after changing source view to use the default
monospace font family and size
* platform/mac/fast/frames/viewsource-attribute-expected.checksum:
* platform/mac/fast/frames/viewsource-attribute-expected.png:
* platform/mac/fast/frames/viewsource-attribute-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Mon, 15 Jun 2009 20:25:19 +0000 (20:25 +0000)]
2009-06-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=26377
[GTK] Confusion about range of 'progress' property
Range for the progress property is 0.0 .. 1.0, don't multiply it
by 100 to make it a percentage.
* webkit/webkitwebview.cpp:
(webkit_web_view_get_progress):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Mon, 15 Jun 2009 20:17:50 +0000 (20:17 +0000)]
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Hunt & Oliver Garen.
We are currently generating two copies of the slow path for op_call for no reason. Stop that.
Originally op_call used two slow paths since the first set up the pointer to the CallLinkInfo
for use when linking. However this is now looked up using the return address (as we do for
property accesses) so the two paths are now identical.
No performance impact, reduces memory footprint.
* bytecode/CodeBlock.h:
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
(JSC::JIT::linkCall):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallSlowCase):
* jit/JITStubs.cpp:
(JSC::JITStubs::DEFINE_STUB_FUNCTION):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Mon, 15 Jun 2009 18:39:58 +0000 (18:39 +0000)]
2009-06-15 Andre Pedralho <andre.pedralho@openbossa.org>
Reviewed by Adam Treat
https://bugs.webkit.org/show_bug.cgi?id=26351
Remove bool QWebHitTestResult::isScrollBar() const and make sure a null QWebHitTestResult is returned instead.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 15 Jun 2009 18:39:36 +0000 (18:39 +0000)]
2009-06-15 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Add Core Animation movie plug-in example.
* NetscapeCoreAnimationMoviePlugin: Added.
* NetscapeCoreAnimationMoviePlugin/English.lproj: Added.
* NetscapeCoreAnimationMoviePlugin/English.lproj/InfoPlist.strings: Added.
* NetscapeCoreAnimationMoviePlugin/Info.plist: Added.
* NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.h: Added.
* NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.m: Added.
(createImageNamed):
(-[MovieControllerLayer init]):
(-[MovieControllerLayer dealloc]):
(-[MovieControllerLayer _playPauseButtonRect]):
(-[MovieControllerLayer _sliderRect]):
(-[MovieControllerLayer _sliderThumbRect]):
(-[MovieControllerLayer _innerSliderRect]):
(-[MovieControllerLayer _drawPlayPauseButtonInContext:]):
(-[MovieControllerLayer _drawSliderInContext:]):
(-[MovieControllerLayer drawInContext:]):
(-[MovieControllerLayer _currentTime]):
(-[MovieControllerLayer _duration]):
(-[MovieControllerLayer _isPlaying]):
(-[MovieControllerLayer _updateTime:]):
(-[MovieControllerLayer _rateDidChange:]):
(-[MovieControllerLayer _timeDidChange:]):
(-[MovieControllerLayer actionForKey:]):
(-[MovieControllerLayer setMovie:]):
(-[MovieControllerLayer _setNewTimeForThumbCenterX:]):
(-[MovieControllerLayer handleMouseDown:]):
(-[MovieControllerLayer handleMouseUp:]):
(-[MovieControllerLayer handleMouseDragged:]):
* NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Added.
* NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj/project.pbxproj: Added.
* NetscapeCoreAnimationMoviePlugin/Pause.tiff: Added.
* NetscapeCoreAnimationMoviePlugin/Play.tiff: Added.
* NetscapeCoreAnimationMoviePlugin/SliderTrackCenter.tiff: Added.
* NetscapeCoreAnimationMoviePlugin/SliderTrackLeft.tiff: Added.
* NetscapeCoreAnimationMoviePlugin/SliderTrackRight.tiff: Added.
* NetscapeCoreAnimationMoviePlugin/Thumb.tiff: Added.
* NetscapeCoreAnimationMoviePlugin/main.m: Added.
(NP_Initialize):
(NP_GetEntryPoints):
(NP_Shutdown):
(NPP_New):
(NPP_Destroy):
(NPP_SetWindow):
(NPP_NewStream):
(NPP_DestroyStream):
(NPP_WriteReady):
(NPP_Write):
(NPP_StreamAsFile):
(NPP_Print):
(handleMouseDown):
(togglePlayPause):
(handleMouseUp):
(handleMouseDragged):
(handleMouseEntered):
(handleMouseExited):
(handleKeyDown):
(handleScrollEvent):
(NPP_HandleEvent):
(NPP_URLNotify):
(NPP_GetValue):
(NPP_SetValue):
* NetscapeCoreAnimationMoviePlugin/test.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Mon, 15 Jun 2009 15:40:04 +0000 (15:40 +0000)]
2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Add new symbols list for 1.1.10 release.
* docs/webkitgtk-docs.sgml:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Mon, 15 Jun 2009 15:39:39 +0000 (15:39 +0000)]
2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Fix Since tags for the new uri and message properties.
* webkit/webkitnetworkrequest.cpp:
(webkit_network_request_class_init):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 15 Jun 2009 15:38:14 +0000 (15:38 +0000)]
2009-06-15 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by and done with Tor Arne Vestbø.
Fix initialization of uninitialized members in FontFallbackListQt, leading
to random crashes when rendering text.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Mon, 15 Jun 2009 15:30:41 +0000 (15:30 +0000)]
2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Adding new documented API to the generated
documentation.
* docs/webkitgtk-sections.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 15 Jun 2009 14:38:22 +0000 (14:38 +0000)]
2009-06-15 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Adam Treat.
Fix the logic for disabling the fixed layout feature, when an invalid
QSize is set.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Mon, 15 Jun 2009 14:31:33 +0000 (14:31 +0000)]
2009-06-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Version bump in preparation for 1.1.10 release.
* configure.ac:
WebKit/gtk:
2009-06-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update NEWS for 1.1.10 release.
* NEWS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Mon, 15 Jun 2009 14:17:15 +0000 (14:17 +0000)]
2009-06-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25895
[Gtk] Segfault when deleting the last/only character in an entry if a11y is enabled
Use computeOffsetInContainerNode instead of the inline
offsetInContainerNode to return the caret offset, since the former
can handle all types of anchoring. Otherwise we'll hit an ASSERT
in some situations in debug builds, and crash.
* editing/gtk/SelectionControllerGtk.cpp:
(WebCore::SelectionController::notifyAccessibilityForSelectionChange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 15 Jun 2009 11:53:05 +0000 (11:53 +0000)]
2009-06-15 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix build break
Rename JSONObject to InspectorJSONObject
https://bugs.webkit.org/show_bug.cgi?id=26340
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Mon, 15 Jun 2009 08:39:27 +0000 (08:39 +0000)]
2009-06-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Mark Rowe.
Reviewed by Simon Hausmann.
Reviewed by Xan Lopez.
Refactor handling of options in the build-webkit script
Options are now defined in one place, and then reused when creating
the usage help text, the arguments to GetOptions(), and when passing
the options on to the underlying port-dependent build systems.
This allows the Qt port to read the defaults for the options from the
pro file (dynamically), and to pass the options on to qmake at build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 15 Jun 2009 07:37:38 +0000 (07:37 +0000)]
Fix <https://bugs.webkit.org/show_bug.cgi?id=26312>.
Bug 26312: Multiple copies of Safari opened with WebKit nightly and Safari 3.2.3
Reviewed by Cameron Zwarich.
Skip the trampoline detection for versions of Safari < 4.0 as they don't play these
tricks, and having WebKitNightlyEnabler assume that we were in the trampoline was
preventing our LaunchServices trickery from being run. This led to fresh copies of
WebKit.app being launched when a URL or file was opened from an external application
rather than the existing instance being reused.
* WebKitLauncher/WebKitNightlyEnabler.m:
(insideSafari4OnTigerTrampoline):
(enableWebKitNightlyBehaviour):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Mon, 15 Jun 2009 07:02:23 +0000 (07:02 +0000)]
Fix Qt build break after r44672
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Mon, 15 Jun 2009 06:11:33 +0000 (06:11 +0000)]
Bug 26399: REGRESSION: java applet accessibility broken
https://bugs.webkit.org/show_bug.cgi?id=26399
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 15 Jun 2009 04:46:23 +0000 (04:46 +0000)]
2009-06-14 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Rename the CustomGetOwnPropertySlot and CustomPutFunction extended attributes
to DelegatingGetOwnPropertySlot and DelegatingPutFunction to more clearly describe
their functionality (customGetOwnPropertySlot and customPut member functions have
been renamed getOwnPropertySlotDelegate and putDelegate). CustomGetOwnPropertySlot
and CustomPutFunction have been repurposed to mean a complete custom implementation
of the function which is inline with other extended attributes prefixed with Custom.
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::putDelegate):
* bindings/js/JSDOMWindowCustom.h:
(WebCore::JSDOMWindow::getOwnPropertySlotDelegate):
(WebCore::JSDOMWindow::putDelegate):
* bindings/js/JSHTMLAppletElementCustom.cpp:
(WebCore::JSHTMLAppletElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLAppletElement::putDelegate):
* bindings/js/JSHTMLEmbedElementCustom.cpp:
(WebCore::JSHTMLEmbedElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLEmbedElement::putDelegate):
* bindings/js/JSHTMLObjectElementCustom.cpp:
(WebCore::JSHTMLObjectElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLObjectElement::putDelegate):
* bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::getOwnPropertySlotDelegate):
(WebCore::JSHistory::putDelegate):
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::getOwnPropertySlotDelegate):
(WebCore::JSLocation::putDelegate):
(WebCore::JSLocationPrototype::putDelegate):
* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::putDelegate):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::getOwnPropertySlotDelegate):
* bindings/scripts/CodeGeneratorJS.pm:
* css/CSSStyleDeclaration.idl:
* html/HTMLAppletElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLObjectElement.idl:
* page/DOMWindow.idl:
* page/History.idl:
* page/Location.idl:
* storage/Storage.idl:
* workers/WorkerContext.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 15 Jun 2009 04:36:59 +0000 (04:36 +0000)]
Reviewed by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=26395
<rdar://problem/6971333> REGRESSION (r40813-r40884): No caret after
going back/forward to page with focused text field
No test, since the back/forward cache is disabled in DumpRenderTree
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::open): Added a call to CachedPage::restore(),
which was removed in r40870.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 15 Jun 2009 03:07:51 +0000 (03:07 +0000)]
2009-06-14 Darin Adler <darin@apple.com>
* editing/TextIterator.cpp:
(WebCore::BitStack::push): Use named constant instead of hardcoded numbers.
(WebCore::BitStack::top): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 15 Jun 2009 02:39:09 +0000 (02:39 +0000)]
WebCore:
2009-06-14 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
Bug 26364: Search can find text that's hidden by overflow:hidden
https://bugs.webkit.org/show_bug.cgi?id=26364
<rdar://problem/6952081>
Test: fast/text/find-hidden-text.html
* editing/TextIterator.cpp:
(WebCore::BitStack::BitStack): Added.
(WebCore::BitStack::push): Added.
(WebCore::BitStack::pop): Added.
(WebCore::BitStack::top): Added.
(WebCore::BitStack::size): Added.
(WebCore::parentOrShadowParent): Added. Helper function for walking up
the parent node chain, crossing shadow tree boundaries.
(WebCore::depthCrossingShadowBoundaries): Added for use in assertions.
Counts the depth of a node using the parentOrShadowParent function.
(WebCore::fullyClipsContents): Added. Returns true for an element that
fully clips its contents, currently defined as a box that has zero width
or height and hides overflow. We can add other cases here later.
(WebCore::ignoresContainerClip): Added. Returns true for an element that
ignores its container clip, currently defined as an element with absolute
or fixed positioning.
(WebCore::pushFullyClippedState): Added. Pushes a bit on the stack indicating
if the node in question fully clips its contents.
(WebCore::setUpFullyClippedStack): Added. Pushes a bit for each ancestor of
a node. Used when creating an iterator.
(WebCore::TextIterator::TextIterator): Removed code to initialize
m_inShadowContent. Call setUpFullyClippedStack.
(WebCore::TextIterator::advance): Use parentOrShadowParent. Call pop when moving
up to a parent node, and also one extra time when moving to a sibling node.
Call pushFullyClippedState when moving to a child node, or when moving to a
sibling node after the aforementioned call to pop.
(WebCore::TextIterator::handleTextNode): Return early if the node is fully clipped.
(WebCore::TextIterator::handleReplacedElement): Ditto.
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
Call setUpFullyClippedStack.
(WebCore::SimplifiedBackwardsTextIterator::advance): Same changes as
TextIterator::advance above.
* editing/TextIterator.h: Added BitStack class and added m_fullyClippedStack to both
TextIterator and SimplifiedBackwardsTextIterator. Removed unneeded m_inShadowContent.
LayoutTests:
2009-06-14 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
Bug 26364: Search can find text that's hidden by overflow:hidden
https://bugs.webkit.org/show_bug.cgi?id=26364
<rdar://problem/6952081>
* fast/text/find-hidden-text-expected.txt: Added.
* fast/text/find-hidden-text.html: Added.
* fast/block/float/crash-replaced-display-block-expected.txt: Removed a space.
* fast/dom/Range/acid3-surround-contents-expected.txt: Removed a blank line.
* fast/dom/object-embed-plugin-scripting-expected.txt: Removed four spaces.
* fast/parser/badentity-expected.txt: Removed a blank line.
* http/tests/security/local-video-poster-from-remote-expected.txt: Removed a blank line.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sun, 14 Jun 2009 23:52:38 +0000 (23:52 +0000)]
2009-06-14 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=26362
Back out Simon's fix and replace it with a better one that doesn't needlessly destroy RenderObjects.
Use NoInherit rather than Detach for child index changes, and don't worry about other pseudo-class state
changes, since they were handled already with setNeedsStyleRecalcs on the affected objects themselves.
* dom/Element.cpp:
(WebCore::Element::recalcStyle):
* dom/Node.cpp:
(WebCore::Node::diff):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setChildIndex):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sun, 14 Jun 2009 21:57:49 +0000 (21:57 +0000)]
2009-06-14 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
Move all of the mutable member variables from Font into the refcounted FontFallbackList. This makes
copying of Fonts more efficient and also effectively makes all of the mutations of a Font object happen
inside the FontFallbackList.
* WebCore.base.exp:
* platform/graphics/Font.cpp:
(WebCore::Font::Font):
(WebCore::Font::operator=):
(WebCore::Font::primaryFont):
(WebCore::Font::update):
* platform/graphics/Font.h:
(WebCore::Font::setWordSpacing):
(WebCore::Font::setLetterSpacing):
* platform/graphics/FontFallbackList.cpp:
(WebCore::FontFallbackList::FontFallbackList):
(WebCore::FontFallbackList::invalidate):
(WebCore::FontFallbackList::determinePitch):
* platform/graphics/FontFallbackList.h:
(WebCore::FontFallbackList::primarySimpleFontData):
(WebCore::FontFallbackList::primaryFontData):
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataForCharacter):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Sun, 14 Jun 2009 21:27:10 +0000 (21:27 +0000)]
2009-06-14 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler
https://bugs.webkit.org/show_bug.cgi?id=26362
Fix an issue noted on quirksmode.com where dynamically adding siblings does not
update :nth-child style correctly.
Test: fast/css/nth-child-dynamic.html
* dom/Node.h:
Change diff() to take const RenderStyle*
* dom/Node.cpp:
(WebCore::Node::diff):
When comparing styles to decide whether to detach and reattach, we
need to look at whether the pseudoclass-related data in the style
changed (since RenderStyle::diff doesn't check this).
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getCachedPseudoStyle):
(WebCore::RenderStyle::inheritedNotEqual):
Make these methods const.
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::styleType):
(WebCore::InheritedFlags::pseudoClassStateEquivalent):
Make methods const.
Add new method that compares the pseudoclass-related members.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Sun, 14 Jun 2009 07:03:12 +0000 (07:03 +0000)]
Update V8 benchmark to version 4.
Reviewed by Cameron Zwarich.
* tests/LIST-V8:
* tests/v8-crypto.js:
* tests/v8-deltablue.js:
* tests/v8-earley-boyer.js:
* tests/v8-raytrace.js:
* tests/v8-regexp.js: Added.
* tests/v8-richards.js:
* tests/v8-splay.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Sun, 14 Jun 2009 06:44:08 +0000 (06:44 +0000)]
2009-06-13 Peter Kasting <pkasting@google.com>
Reviewed by Kevin Ollivier.
https://bugs.webkit.org/show_bug.cgi?id=25709 part eleven
Write a wx implementation so the wx port can compile. For now this is
mostly a copy of the Cairo port, but in the future it can be changed to
use a wxBitmap as the storage type everywhere (just as Cairo can
probably be changed).
Also ASSERT for any other ports who call getAddr() (I don't think there
are any, and besides, they probably won't link, but this doesn't hurt).
Also fixes a dumb Cairo build bustage typo introduced in part ten.
* platform/graphics/wx/ImageSourceWx.cpp:
(WebCore::ImageSource::createFrameAtIndex):
* platform/image-decoders/ImageDecoder.h:
(WebCore::RGBA32Buffer::getAddr):
* platform/image-decoders/cairo/ImageDecoderCairo.cpp:
(WebCore::RGBA32Buffer::setStatus):
* platform/image-decoders/wx: Added.
* platform/image-decoders/wx/ImageDecoderWx.cpp: Added.
(WebCore::RGBA32Buffer::RGBA32Buffer):
(WebCore::RGBA32Buffer::clear):
(WebCore::RGBA32Buffer::zeroFill):
(WebCore::RGBA32Buffer::copyBitmapData):
(WebCore::RGBA32Buffer::setSize):
(WebCore::RGBA32Buffer::asNewNativeImage):
(WebCore::RGBA32Buffer::hasAlpha):
(WebCore::RGBA32Buffer::setHasAlpha):
(WebCore::RGBA32Buffer::setStatus):
(WebCore::RGBA32Buffer::operator=):
(WebCore::RGBA32Buffer::width):
(WebCore::RGBA32Buffer::height):
* webcore-wx.bkl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 14 Jun 2009 05:06:17 +0000 (05:06 +0000)]
2009-06-09 Justin Garcia <justin.garcia@apple.com>
Reviewed by Eric Seidel. Landed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=26281
REGRESSION: Copying from TextEdit/OmniGraffle and pasting into editable
region loses images
Prefer RTFD (RTF with inline images) over RTF. In
http://trac.webkit.org/changeset/19745 I accidently reversed their
order.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 14 Jun 2009 04:53:09 +0000 (04:53 +0000)]
2009-06-13 Stephen White <senorblanco@chromium.org>
Reviewed by Dimitri Glazkov. Landed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=26320
Some minor code cleanup for chromium/skia port. Removed #ifdef's
around skia API changes, since the new version seems solid and we
don't need to go back. Added some comments to
TransparencyWin.h, as requested by Brett in
https://bugs.webkit.org/show_bug.cgi?id=24584.
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/chromium/TransparencyWin.h:
* platform/graphics/skia/PathSkia.cpp:
(WebCore::Path::boundingRect):
(WebCore::boundingBoxForCurrentStroke):
* platform/graphics/skia/SkiaUtils.cpp:
(WebCore::SkPathContainsPoint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 14 Jun 2009 04:29:52 +0000 (04:29 +0000)]
Build fix: Another missing header. Arg.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 14 Jun 2009 04:24:28 +0000 (04:24 +0000)]
Build fix: add missing header.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 14 Jun 2009 04:14:47 +0000 (04:14 +0000)]
WebCore:
2009-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=24492
Moved registerURLSchemeAsLocal and registerURLSchemeAsNoAccess from
FrameLoader to SecurityOrigin.
* WebCore.base.exp:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::canLoad):
* loader/FrameLoader.h:
* page/SecurityOrigin.cpp:
(WebCore::localSchemes):
(WebCore::noAccessSchemes):
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::isLocal):
(WebCore::SecurityOrigin::registerURLSchemeAsLocal):
(WebCore::SecurityOrigin::shouldTreatURLAsLocal):
(WebCore::SecurityOrigin::shouldTreatURLSchemeAsLocal):
(WebCore::SecurityOrigin::registerURLSchemeAsNoAccess):
(WebCore::SecurityOrigin::shouldTreatURLSchemeAsNoAccess):
* page/SecurityOrigin.h:
WebKit/mac:
2009-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=24492
Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin
* WebView/WebView.mm:
(+[WebView registerURLSchemeAsLocal:]):
WebKit/qt:
2009-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=24492
Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin.
* Api/qwebpage.cpp:
(QWebPage::acceptNavigationRequest):
WebKit/win:
2009-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=24492
Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin.
* WebView.cpp:
(WebView::registerURLSchemeAsLocal):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 14 Jun 2009 03:47:32 +0000 (03:47 +0000)]
2009-06-13 Ben Murdoch <benm@google.com>
Reviewed by David Kilzer. Landed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=26189
This patch changes the way PageGroups create their localStorage
objects. Rather than creating a local storage object for the page group
when a page is added to the group, the local storage object is now
created lazily when the local storage object is requested by the
DOMWindow.
* page/PageGroup.cpp:
(WebCore::PageGroup::closeLocalStorage): Before attempting to close a local storage object for a page group, ensure one has been created.
(WebCore::PageGroup::addPage): Do not automatically try to create a local storage object when a page is added to the group.
(WebCore::PageGroup::localStorage): Create a local storage object if one does not exist and return it.
* page/PageGroup.h: Add private hasLocalStorage method to PageGroup.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 14 Jun 2009 03:44:36 +0000 (03:44 +0000)]
2009-06-13 Ben Murdoch <benm@google.com>
Reviewed by Eric Seidel. Landed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=26189
Add ENABLE(DOM_STORAGE) guards to the dom storage source files.
* storage/LocalStorage.cpp: Add ENABLE(DOM_STORAGE) guards to the file.
* storage/LocalStorage.h: Ditto
* storage/LocalStorageArea.cpp: Ditto
* storage/LocalStorageArea.h: Ditto
* storage/LocalStorageTask.cpp: Ditto
* storage/LocalStorageTask.h: Ditto
* storage/LocalStorageThread.cpp: Ditto
* storage/LocalStorageThread.h: Ditto
* storage/SessionStorage.cpp: Ditto
* storage/SessionStorage.h: Ditto
* storage/SessionStorageArea.cpp: Ditto
* storage/SessionStorageArea.h: Ditto
* storage/Storage.cpp: Ditto
* storage/Storage.h: Ditto
* storage/StorageArea.cpp: Ditto
* storage/StorageArea.h: Ditto
* storage/StorageEvent.cpp: Ditto
* storage/StorageEvent.h: Ditto
* storage/StorageMap.cpp: Ditto
* storage/StorageMap.h: Ditto
* storage/StorageEvent.idl: Add Conditional=DOM_STORAGE attribute.
* storage/Storage.idl: Ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Sun, 14 Jun 2009 01:00:20 +0000 (01:00 +0000)]
2009-06-13 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25709 part ten
Make Skia use the root directory ImageDecoder.h and factor out most
Skia-specific bits into skia/ImageDecoderSkia.cpp. Also fix a pair of
style violations in ImageDecoderCairo.cpp. This is the last patch for
this bug, everything beyond this is an enhancement rather than
unforking.
* platform/image-decoders/ImageDecoder.h:
(WebCore::RGBA32Buffer::getAddr):
* platform/image-decoders/cairo/ImageDecoderCairo.cpp:
(WebCore::RGBA32Buffer::hasAlpha):
(WebCore::RGBA32Buffer::setHasAlpha):
(WebCore::setStatus):
* platform/image-decoders/skia/ImageDecoder.h: Removed.
* platform/image-decoders/skia/ImageDecoderSkia.cpp: Added.
(WebCore::RGBA32Buffer::RGBA32Buffer):
(WebCore::RGBA32Buffer::clear):
(WebCore::RGBA32Buffer::zeroFill):
(WebCore::RGBA32Buffer::copyBitmapData):
(WebCore::RGBA32Buffer::setSize):
(WebCore::RGBA32Buffer::asNewNativeImage):
(WebCore::RGBA32Buffer::hasAlpha):
(WebCore::RGBA32Buffer::setHasAlpha):
(WebCore::RGBA32Buffer::setStatus):
(WebCore::RGBA32Buffer::operator=):
(WebCore::RGBA32Buffer::width):
(WebCore::RGBA32Buffer::height):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 13 Jun 2009 23:11:32 +0000 (23:11 +0000)]
2009-06-13 Sam Weinig <sam@webkit.org>
Rubber-stamped by Mark "Snowy" Rowe.
Update iExploder/htdocs/cssproperties.in by running update-iexploder-cssproperties.
* iExploder/htdocs/cssproperties.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 13 Jun 2009 21:35:02 +0000 (21:35 +0000)]
2009-06-13 Victor Wang <victorw@chromium.org>
Reviewed by Eric Seidel. Landed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=26333
Alert during a dragenter event handler will crash the renderer
This crash is casued by calling NULL pointer m_documentUnderMouse in
DragController::tryDocumentDrag()
tryDHTMLDrag fires dragenter event. The event listener that listens
to this event may create a nested message loop (open a modal dialog),
which could process dragleave event and reset m_documentUnderMouse in
dragExited.
Fix the crash by checking m_documentUnderMouse after tryDHTMLDrag and
do not continue if the pointer has been set to NULL.
Test: DRT does not show alerts so add a manual test:
manual-tests/drag-enter-alert.html
* manual-tests/drag-enter-alert.html: Added.
* manual-tests/resources/drag-image.png: Added.
* page/DragController.cpp:
(WebCore::DragController::tryDocumentDrag):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 13 Jun 2009 21:27:56 +0000 (21:27 +0000)]
2009-06-13 Nate Chapin <japhet@google.com>
Reviewed by Dimitri Glazkov. Landed by Adam Barth.
Moved V8 Bindings for V8CustomXPathNSResolver to svn.webkit.org.
https://bugs.webkit.org/show_bug.cgi?id=26227
* bindings/v8/custom/V8CustomXPathNSResolver.cpp: Added.
(WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver): Moved from src.chromium.org.
(WebCore::V8CustomXPathNSResolver::~V8CustomXPathNSResolver): Moved from src.chromium.org.
(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI): Moved from src.chromium.org.
* bindings/v8/custom/V8CustomXPathNSResolver.h: Added.
* bindings/v8/custom/V8DocumentCustom.cpp: Updated includes.
(WebCore::CALLBACK_FUNC_DECL): Updated class name.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44658
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 13 Jun 2009 21:23:46 +0000 (21:23 +0000)]
2009-06-13 John Abd-El-Malek <jam@chromium.org>
Reviewed by Eric Seidel. Landed by Adam Barth.
Removed dead file.
https://bugs.webkit.org/show_bug.cgi?id=26308
* DumpRenderTree/win/TestNetscapePlugin/main.c: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 13 Jun 2009 21:19:18 +0000 (21:19 +0000)]
2009-06-13 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Mark Rowe. Landed by Adam Barth.
Remove obsolete declarations for old Symbian port
https://bugs.webkit.org/show_bug.cgi?id=26339
* platform/graphics/FloatPoint.h: Remove declarations for native SYMBIAN adaptation.
* platform/graphics/FloatRect.h: Ditto.
* platform/graphics/IntPoint.h: Ditto.
* platform/graphics/IntRect.h: Ditto.
* platform/graphics/IntSize.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Sat, 13 Jun 2009 19:54:11 +0000 (19:54 +0000)]
2009-06-13 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
Added subRegion calculation to SVG filter. Every filter effect is
clipped to the filter region (according to the spec). This makes
ImageBuffers for filter effects smaller and we just need to take
care about big filter regions.
SVGFEImage needed a correction, to avoid an ASSERT. The two filter
effects feOffset and feFlood help to test the new subRegion code.
Tests: svg/filters/subRegion-one-effect.svg
svg/filters/subRegion-two-effects.svg
Added tests for the new subRgion-code on SVG filters.
* platform/mac/svg/filters: Added.
* platform/mac/svg/filters/subRegion-one-effect-expected.checksum: Added.
* platform/mac/svg/filters/subRegion-one-effect-expected.png: Added.
* platform/mac/svg/filters/subRegion-one-effect-expected.txt: Added.
* platform/mac/svg/filters/subRegion-two-effects-expected.checksum: Added.
* platform/mac/svg/filters/subRegion-two-effects-expected.png: Added.
* platform/mac/svg/filters/subRegion-two-effects-expected.txt: Added.
* svg/filters: Added.
* svg/filters/subRegion-one-effect.svg: Added.
* svg/filters/subRegion-two-effects.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Sat, 13 Jun 2009 19:36:30 +0000 (19:36 +0000)]
2009-06-13 Peter Kasting <pkasting@google.com>
Bustage: Fix broken GIFs on Cairo due to subtle typo. Fix a warning.
* platform/image-decoders/ImageDecoder.h:
(WebCore::RGBA32Buffer::copyRowNTimes):
* platform/image-decoders/bmp/BMPImageReader.cpp:
(WebCore::BMPImageReader::processBitmasks):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Sat, 13 Jun 2009 19:10:07 +0000 (19:10 +0000)]
2009-06-13 Peter Kasting <pkasting@google.com>
GTK bustage fix. "inline" is handled differently by different compilers.
* platform/image-decoders/ImageDecoder.h:
(WebCore::RGBA32Buffer::getAddr):
* platform/image-decoders/cairo/ImageDecoderCairo.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Sat, 13 Jun 2009 18:55:41 +0000 (18:55 +0000)]
2009-06-13 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25709 part nine
Factor Cairo-specific implementation out of ImageDecoder.h into
ImageDecoderCairo.cpp. Add some comments to functions declared
in ImageDecoder.h.
* GNUmakefile.am:
* WebCore.vcproj/WebCore.vcproj:
* platform/image-decoders/ImageDecoder.h:
* platform/image-decoders/cairo: Added.
* platform/image-decoders/cairo/ImageDecoderCairo.cpp: Added.
(WebCore::RGBA32Buffer::RGBA32Buffer):
(WebCore::RGBA32Buffer::clear):
(WebCore::RGBA32Buffer::zeroFill):
(WebCore::RGBA32Buffer::copyBitmapData):
(WebCore::RGBA32Buffer::setSize):
(WebCore::RGBA32Buffer::asNewNativeImage):
(WebCore::RGBA32Buffer::hasAlpha):
(WebCore::RGBA32Buffer::setHasAlpha):
(WebCore::RGBA32Buffer::operator=):
(WebCore::RGBA32Buffer::width):
(WebCore::RGBA32Buffer::height):
(WebCore::RGBA32Buffer::getAddr):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Jun 2009 17:52:44 +0000 (17:52 +0000)]
2009-06-12 Dave Hyatt <hyatt@apple.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=26373
Add a new class to Threading in wtf called ReadWriteLock that handles single writer/multiple reader locking.
Provide a pthreads-only implementation of the lock for now, as this class is only going to be used
on Snow Leopard at first.
* wtf/Threading.h:
(WTF::ReadWriteLock::impl):
* wtf/ThreadingPthreads.cpp:
(WTF::ReadWriteLock::ReadWriteLock):
(WTF::ReadWriteLock::~ReadWriteLock):
(WTF::ReadWriteLock::readLock):
(WTF::ReadWriteLock::tryReadLock):
(WTF::ReadWriteLock::writeLock):
(WTF::ReadWriteLock::tryWriteLock):
(WTF::ReadWriteLock::unlock):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Jun 2009 17:20:30 +0000 (17:20 +0000)]
2009-06-13 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
Cleanup of the new MidpointState class. Turn it into a struct instead. Fix a mistaken
assertion removal and some unintentional whitespace changes.
* platform/text/BidiResolver.h:
(WebCore::MidpointState::reset):
* rendering/RenderBlock.h:
* rendering/bidi.cpp:
(WebCore::BidiRun::operator delete):
(WebCore::chopMidpointsAt):
(WebCore::checkMidpoints):
(WebCore::addMidpoint):
(WebCore::appendRunsForObject):
(WebCore::RenderBlock::findNextLineBreak):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Jun 2009 06:04:40 +0000 (06:04 +0000)]
2009-06-12 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=26367
Remove the global variables in bidi.cpp. Make a new struct, MidpointState, that holds all of the
midpoint information. Add the remaining global variables as arguments passed down through functions
as needed.
* platform/text/BidiResolver.h:
(WebCore::MidpointState::MidpointState):
(WebCore::MidpointState::reset):
(WebCore::BidiResolver::midpointState):
* rendering/RenderBlock.h:
* rendering/bidi.cpp:
(WebCore::BidiRun::operator delete):
(WebCore::chopMidpointsAt):
(WebCore::checkMidpoints):
(WebCore::addMidpoint):
(WebCore::appendRunsForObject):
(WebCore::RenderBlock::bidiReorderLine):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::skipNonBreakingSpace):
(WebCore::shouldCollapseWhiteSpace):
(WebCore::requiresLineBox):
(WebCore::RenderBlock::generatesLineBoxesForInlineChild):
(WebCore::RenderBlock::skipTrailingWhitespace):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::shouldSkipWhitespaceAfterStartObject):
(WebCore::RenderBlock::findNextLineBreak):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Sat, 13 Jun 2009 05:03:16 +0000 (05:03 +0000)]
Build fix for Qt. After recent ImageDeocder.h changes.
I want the original change to be backed out as the whole
Skia merging is going in the wrong direction. The discussion
will happen in the bugtracker.
https://bugs.webkit.org/show_bug.cgi?id=25709.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44648
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jmalonzo@webkit.org [Sat, 13 Jun 2009 02:41:47 +0000 (02:41 +0000)]
2009-06-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[Gtk] Enable more http/tests/navigation tests
* platform/gtk/Skipped:
[Gtk] use strlen instead of g_utf8_strlen so we can enable more tests.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dumpHistoryItem):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jmalonzo@webkit.org [Sat, 13 Jun 2009 02:31:14 +0000 (02:31 +0000)]
2009-06-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix: include cstdio so we can use sscanf
Gtk/Win Cairo build fix: use isASCIISpace instead of isspace
Suggested by Brent Fulgham
* platform/image-decoders/xbm/XBMImageDecoder.cpp:
(WebCore::XBMImageDecoder::decodeDatum):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Sat, 13 Jun 2009 01:23:48 +0000 (01:23 +0000)]
2009-06-12 Peter Kasting <pkasting@google.com>
Yet another Skia bustage fix.
* platform/image-decoders/skia/ImageDecoder.h:
(WebCore::RGBA32Buffer::setSize): Avoid symbol name clash. The better fix is to take an IntSize(); I'll do that later.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 13 Jun 2009 01:18:57 +0000 (01:18 +0000)]
Make LiteralParser non-recursive
Reviewed by Geoff Garen.
Convert LiteralParser from using a simple recursive descent parser
to a hand rolled PDA. Relatively simple conversion, but required
modifications to MarkedArgumentBuffer to make it more suitable as
a generic marked vector. I'll refactor and rename MarkedArgumentBuffer
in future as there are many other cases where it will be useful to
have such a class.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Sat, 13 Jun 2009 00:56:11 +0000 (00:56 +0000)]
2009-06-12 Peter Kasting <pkasting@google.com>
Fix remaining Cairo build bustage from
https://bugs.webkit.org/show_bug.cgi?id=25709 changes. Use
Vector<char> in place of std::string.
* platform/image-decoders/xbm/XBMImageDecoder.cpp:
(WebCore::XBMImageDecoder::setData):
(WebCore::XBMImageDecoder::decodeHeader):
(WebCore::XBMImageDecoder::decodeDatum):
* platform/image-decoders/xbm/XBMImageDecoder.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sat, 13 Jun 2009 00:47:49 +0000 (00:47 +0000)]
2009-06-12 David Levin <levin@chromium.org>
Reviewed by NOBODY (build fix for windows).
Adjust the exports for JSC on Windows like what was done for OSX in
the previous commit.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sat, 13 Jun 2009 00:41:03 +0000 (00:41 +0000)]
JavaScriptCore:
2009-06-12 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
UString shouldn't create sharedBuffer for SmallStrings.
https://bugs.webkit.org/show_bug.cgi?id=26360
The methods changed are not used by JSC, so there is no JS perf impact. However,
there is a potential DOM perf impact, so I re-ran several of the tests that
I ran previously and ensured that the perf stay the same which caused me to
adjust the minLengthToShare.
* JavaScriptCore.exp:
* runtime/UString.cpp:
(JSC::UString::Rep::sharedBuffer):
Determines if the buffer being shared is big enough before doing so.
Previously, BaseString::sharedBuffer was called but it would only know
the length of the base string (BaseString::len) which may not be the same
as the string being shared (Rep::len).
(JSC::UString::BaseString::sharedBuffer):
This is now only be used by Rep::sharedBuffer. which does the length check.
* runtime/UString.h:
WebCore:
2009-06-12 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
UString shouldn't create sharedBuffer for SmallStrings.
https://bugs.webkit.org/show_bug.cgi?id=26347
Change the call to use the method UString::Rep::sharedBuffer due
to changes in UString.
No noticable change in behavior, so no test.
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::create):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Sat, 13 Jun 2009 00:11:38 +0000 (00:11 +0000)]
2009-06-12 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein
https://bugs.webkit.org/show_bug.cgi?id=26095
Fix crash when a renderer for an anonymous node is composited
by null-checking renderer()->node().
Test: compositing/generated-content.html
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createGraphicsLayer):
(WebCore::RenderLayerBacking::rendererHasBackground):
(WebCore::RenderLayerBacking::rendererBackgroundColor):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::RenderLayerBacking::paintIntoLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Sat, 13 Jun 2009 00:04:13 +0000 (00:04 +0000)]
2009-06-12 Peter Kasting <pkasting@google.com>
Fix Chromium and some of Cairo build bustage, fallout from
https://bugs.webkit.org/show_bug.cgi?id=25709 changes.
* WebCore.vcproj/WebCore.vcproj: Add missing XBM decoder files.
* platform/image-decoders/skia/ImageDecoder.h:
(WebCore::RGBA32Buffer::copyRowNTimes): Fix typo that broke Skia GIF decoding.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 12 Jun 2009 23:39:04 +0000 (23:39 +0000)]
2009-06-12 Brady Eidson <beidson@apple.com>
Reviewed by Oliver Hunt
Add a page indexing the various demo applications we have posted.
* demos/index.html: Added.
* nav.inc: Add a link to the demos page on the side bar
* css/main.css: Add a style for date stamps based on the blog.
* demos/calendar/index.html: Added to redirect to Calendar.html. I'm not moving Calendar.html to
index.html as the Calendar.html url has already been published and we should keep it working.
Move the drosera test code to /misc, as it is no longer a meaningful demo:
* demos/drosera: Removed.
* demos/drosera/demo.js: Removed.
* demos/drosera/drosera.png: Removed.
* demos/drosera/index.html: Removed.
* misc/drosera: Copied from demos/drosera.
Move the sticky notes example into /demos:
* demos/sticky-notes: Added.
* demos/sticky-notes/StickyNotes.manifest: Copied from misc/DatabaseExample.manifest.
* demos/sticky-notes/deleteButton.png: Copied from misc/deleteButton.png.
* demos/sticky-notes/deleteButtonPressed.png: Copied from misc/deleteButtonPressed.png.
* demos/sticky-notes/index.html: Copied from misc/DatabaseExample.html.
* misc/DatabaseExample.html: Changed to redirect to demos/sticky-notes/index.html. I'm not removing
it altogether as the misc/DatabaseExample.html url has already been published and we should keep it working.
* misc/DatabaseExample.manifest: Removed.
* misc/deleteButton.png: Removed.
* misc/deleteButtonPressed.png: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 12 Jun 2009 23:38:39 +0000 (23:38 +0000)]
2009-06-12 Simon Fraser <simon.fraser@apple.com>
Fix build when ACCELERATED_COMPOSITING is defined.
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::attachRootGraphicsLayer):
(WebCore::EmptyChromeClient::setNeedsOneShotDrawingSynchronization):
(WebCore::EmptyChromeClient::scheduleViewUpdate):
Add stubs for the compositing-related ChromeClient methods.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
docWidth()/docHeight() became private. Use overflowWidth()/overflowHeight() instead, which
matches what is used to size the WebHTMLView.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Fri, 12 Jun 2009 23:20:35 +0000 (23:20 +0000)]
2009-06-12 jorlow <jorlow@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=26356
http://crbug.com/14006
Create custom bindings for v8. The rest of these files are still
forked (so the review is happening on the chromium review site).
These bindings have been tested on a hacked up Chromium instance
(also running --single-process) and Android.
* bindings/v8/custom/V8StorageCustom.cpp: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc