WebKit-https.git
8 years ago[Chromium] IndexedDB: Assertion failure when storing File objects
jsbell@chromium.org [Fri, 16 Mar 2012 19:26:00 +0000 (19:26 +0000)]
[Chromium] IndexedDB: Assertion failure when storing File objects
https://bugs.webkit.org/show_bug.cgi?id=76746

Source/WebCore:

The blob data in Blob/File/FileList objects is serialized "by reference" (the
internal URL) rather than "by value" (the actual data); this is sufficient for
postMessage() but not for IndexedDB since the referenced data is not retained
Expose a mechanism to enumerate the URLs so that SSVs can be rejected by IDB
until blob data serialization can is implemented (outside the SSV mechanism, and
potentially asynchronously).

Also, correct issue in V8DOMWrapper::instantiateV8Object where context is assumed
to be a Worker context if it's not a Window, which is incorrect for the
Chromium utility process; this is hit if Blobs are not blocked.

Reviewed by Tony Chang.

Test: storage/indexeddb/noblobs.html

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::update): Reject SSVs that contain blob references.
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::add): Reject SSVs that contain blob references.
(WebCore::IDBObjectStore::put): Reject SSVs that contain blob references.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::CloneSerializer):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::write):
(CloneSerializer):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):
* bindings/js/SerializedScriptValue.h: New API to enable the clients to be picky.
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::SerializedScriptValue):
* bindings/v8/SerializedScriptValue.h: New API to enable the clients to be picky.
(WebCore::SerializedScriptValue::blobURLs):
(SerializedScriptValue):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::instantiateV8Object):  Ensure context is a worker context before treating it as such.

LayoutTests:

Ensure that Blob/File/FileList types are rejected in IDB values, to detect regressions.

Reviewed by Tony Chang.

* storage/indexeddb/noblobs-expected.txt: Added.
* storage/indexeddb/noblobs.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Ensure that invalid syntax in inline event handlers does not cause a crash
arv@chromium.org [Fri, 16 Mar 2012 19:23:14 +0000 (19:23 +0000)]
[V8] Ensure that invalid syntax in inline event handlers does not cause a crash
https://bugs.webkit.org/show_bug.cgi?id=81385

Reviewed by Nate Chapin.

Source/WebCore:

The way that V8 does its inline event handler involves concatting strings and
if the attribute value is crafted in a special way this could cause a crash.

Test: fast/dom/inline-event-attributes-crash.html

* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):

LayoutTests:

* fast/dom/inline-event-attributes-crash-expected.txt: Added.
* fast/dom/inline-event-attributes-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium rebaselines for expected failures on garden-o-matic.
ojan@chromium.org [Fri, 16 Mar 2012 19:22:31 +0000 (19:22 +0000)]
Chromium rebaselines for expected failures on garden-o-matic.

* platform/chromium-linux-x86/compositing/reflections/animation-inside-reflection-expected.png: Added.
* platform/chromium-linux-x86/compositing/reflections/nested-reflection-animated-expected.png: Added.
* platform/chromium-linux/compositing/color-matching/pdf-image-match-expected.png: Added.
* platform/chromium-linux/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-linux/compositing/reflections/nested-reflection-animated-expected.png:
* platform/chromium-mac-leopard/compositing/reflections/animation-inside-reflection-expected.png: Added.
* platform/chromium-mac-leopard/compositing/reflections/nested-reflection-animated-expected.png: Added.
* platform/chromium-mac-snowleopard/animations/cross-fade-border-image-source-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.txt: Added.
* platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac/compositing/reflections/nested-reflection-animated-expected.png:
* platform/chromium-mac/compositing/reflections/nested-reflection-transition-expected.png: Added.
* platform/chromium-win-vista/compositing/reflections/animation-inside-reflection-expected.png: Added.
* platform/chromium-win-vista/compositing/reflections/nested-reflection-animated-expected.png: Added.
* platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png: Removed.
* platform/chromium-win-xp/compositing/reflections/animation-inside-reflection-expected.txt: Added.
* platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.png: Added.
* platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Copied from LayoutTests/platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.txt.
* platform/chromium-win/compositing/absolute-position-changed-with-composited-parent-layer-expected.png:
* platform/chromium-win/compositing/color-matching/pdf-image-match-expected.png: Added.
* platform/chromium-win/compositing/color-matching/pdf-image-match-expected.txt: Added.
* platform/chromium-win/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.png:
* platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWrong icon to restore to windowed mode in full screen video panel
jer.noble@apple.com [Fri, 16 Mar 2012 19:21:31 +0000 (19:21 +0000)]
Wrong icon to restore to windowed mode in full screen video panel
https://bugs.webkit.org/show_bug.cgi?id=70437

Reviewed by Eric Carlson.

Source/WebCore:

No new tests. Updated platform/mac/accessibility/media-element-expected.txt.

Renamed MediaFullscreenButton to MediaEnterFullscreenButton and added MediaExitFullscreenButton:
* accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::controlTypeName):
(WebCore::AccessibilityMediaControl::roleValue):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* platform/ThemeTypes.h:

Added setIsFullscreen which controls the display of the enter/exit fullscreen button:
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlFullscreenButtonElement::setIsFullscreen): Added.
* html/shadow/MediaControlElements.h:
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::enteredFullscreen):
(WebCore::MediaControlRootElement::exitedFullscreen):

Paint the enter/exit fullscreen button accordingly:
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
* rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::paintMediaFullscreenButton):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaFullscreenButton):
* rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::paintMediaControlsPart):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintMediaFullscreenButton):

Update the localized strings for the exit and enter fullscreen buttons:
* English.lproj/Localizable.strings:
* platform/LocalizedStrings.cpp:
(WebCore::localizedMediaControlElementString):
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
* platform/qt/LocalizedStringsQt.cpp:
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):

WebKitLibraries:

* WebKitSystemInterface.h: Added WKMediaUIPartExitFullscreenButton.
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:

LayoutTests:

* platform/mac/accessibility/media-element-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate LayoutUnit usage in RenderListBox
leviw@chromium.org [Fri, 16 Mar 2012 19:07:24 +0000 (19:07 +0000)]
Update LayoutUnit usage in RenderListBox
https://bugs.webkit.org/show_bug.cgi?id=81038

Reviewed by Julien Chaffraix.

Bringing RenderListBox in line with the rules listed in
https://trac.webkit.org/wiki/LayoutUnit

No new tests. No change in behavior.

* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintScrollbar): Pixel snapping before handing off scrollbar
painting to the platform.
(WebCore::RenderListBox::paintItemForeground): Rounding the offset for text painting.
(WebCore::RenderListBox::paintItemBackground): Pixel snapping the background rect.
(WebCore::RenderListBox::panScroll): EventHandler::currentMousePosition is an IntPoint,
so it doesn't require additional rounding in RenderListBox.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHave webkit-patch rebaseline-test update test_expectations.txt
ojan@chromium.org [Fri, 16 Mar 2012 19:02:52 +0000 (19:02 +0000)]
Have webkit-patch rebaseline-test update test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=81054

Recommit http://trac.webkit.org/changeset/110783 now that
http://trac.webkit.org/changeset/111034 has landed.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.remove_configuration_from_test):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(RemoveConfigurationsTest):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._update_expectations_file):
(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest):
(RebaselineTest.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline window-properties-expected on GTK; add two new tests
jer.noble@apple.com [Fri, 16 Mar 2012 18:57:10 +0000 (18:57 +0000)]
Rebaseline window-properties-expected on GTK; add two new tests
to the GTK Skipped list associated with existing bug:
https://bugs.webkit.org/show_bug.cgi?id=61118

* platform/gtk/Skipped:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Input fields with id of e-mail and url should be styled as such.
commit-queue@webkit.org [Fri, 16 Mar 2012 18:39:09 +0000 (18:39 +0000)]
[BlackBerry] Input fields with id of e-mail and url should be styled as such.
https://bugs.webkit.org/show_bug.cgi?id=81364

Patch by Mike Fenton <mifenton@rim.com> on 2012-03-16
Reviewed by Rob Buis.

Treat fields that have name/id's that match url or
email as url or email fields providing the appropriate
keyboard.

PR 137259.

Reviewed Internally by Gen Mak and Nima Ghanavatian.

* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::matchesReservedStringEmail):
(DOMSupport):
(BlackBerry::WebKit::DOMSupport::matchesReservedStringUrl):
(BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesEmail):
(BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesUrl):
(BlackBerry::WebKit::DOMSupport::matchesReservedStringPreventingAutocomplete):
* WebKitSupport/DOMSupport.h:
(WebCore):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::convertInputType):
(BlackBerry::WebKit::inputStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMark form-associated-element-crash3.html as flakily timing out, since it often passes.
adamk@chromium.org [Fri, 16 Mar 2012 18:33:30 +0000 (18:33 +0000)]
Mark form-associated-element-crash3.html as flakily timing out, since it often passes.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r111020.
pkasting@chromium.org [Fri, 16 Mar 2012 18:33:25 +0000 (18:33 +0000)]
Unreviewed, rolling out r111020.
http://trac.webkit.org/changeset/111020
https://bugs.webkit.org/show_bug.cgi?id=81377

Broke Chromium Win compile (Requested by pkasting on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-16

* GNUmakefile.list.am:
* WebCore.gypi:
* platform/mediastream/PeerConnection00Handler.cpp: Removed.
* platform/mediastream/PeerConnection00Handler.h: Removed.
* platform/mediastream/PeerConnection00HandlerClient.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpecifier collapsing when writing test expectations lines gets a number of cases...
ojan@chromium.org [Fri, 16 Mar 2012 18:31:33 +0000 (18:31 +0000)]
Specifier collapsing when writing test expectations lines gets a number of cases wrong
https://bugs.webkit.org/show_bug.cgi?id=81309

Reviewed by Dimitri Glazkov.

I've run this over all the lines in the current Chromium test_expectations.txt file,
so I'm relatively confident we now cover all the cases.

* Scripts/webkitpy/layout_tests/models/test_configuration.py:
(TestConfigurationConverter.__init__):
(TestConfigurationConverter.collapse_macros):
(TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set):
(TestConfigurationConverter):
(TestConfigurationConverter.intersect_combination):
(TestConfigurationConverter.symmetric_difference):
(TestConfigurationConverter.to_specifiers_list):
(TestConfigurationConverter.to_specifiers_list.try_collapsing):
(TestConfigurationConverter.to_specifiers_list.try_abbreviating):
* Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
(make_mock_all_test_configurations_set):
(TestConfigurationConverterTest.test_symmetric_difference):
(TestConfigurationConverterTest.test_to_config_set):
(TestConfigurationConverterTest.test_macro_expansion):
(TestConfigurationConverterTest.test_to_specifier_lists):
(TestConfigurationConverterTest.test_converter_macro_collapsing):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.__init__):
The android port uses "arm" as it's architecture, which is technically correct,
but considerably complicates making collapsing work. We probably should kill
the concept of architecture entirely. The benefits are not worth the code
complexity.

* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumPortTest.test_all_test_configurations):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago6 platform/mac/editing/spelling autocorrect-related tests failing on Lion Intel Debug...
jberlin@webkit.org [Fri, 16 Mar 2012 18:27:21 +0000 (18:27 +0000)]
6 platform/mac/editing/spelling autocorrect-related tests failing on Lion Intel Debug WebKit2
testers
https://bugs.webkit.org/show_bug.cgi?id=81375

Add expected failing results to get the bots green.

* platform/mac-wk2/platform/mac/editing/spelling/autocorrection-contraction-expected.png: Added.
* platform/mac-wk2/platform/mac/editing/spelling/autocorrection-contraction-expected.txt: Added.
* platform/mac-wk2/platform/mac/editing/spelling/click-autocorrected-word-expected.png: Added.
* platform/mac-wk2/platform/mac/editing/spelling/click-autocorrected-word-expected.txt: Added.
* platform/mac-wk2/platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png: Added.
* platform/mac-wk2/platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt: Added.
* platform/mac-wk2/platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png: Added.
* platform/mac-wk2/platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt: Added.
* platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png: Added.
* platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt: Added.
* platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png: Added.
* platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoplatform/mac/editing/spelling/editing-word-with-marker-1.html failing on Lion Intel...
jberlin@webkit.org [Fri, 16 Mar 2012 18:27:15 +0000 (18:27 +0000)]
platform/mac/editing/spelling/editing-word-with-marker-1.html failing on Lion Intel Debug
testers
https://bugs.webkit.org/show_bug.cgi?id=81372

Add expected failing results to get the bots green.

* platform/mac/editing/spelling/editing-word-with-marker-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoplatform/mac/editing/spelling/autocorrection-contraction.html fails on Lion Intel...
jberlin@webkit.org [Fri, 16 Mar 2012 18:27:10 +0000 (18:27 +0000)]
platform/mac/editing/spelling/autocorrection-contraction.html fails on Lion Intel Debug testers.
https://bugs.webkit.org/show_bug.cgi?id=81369

Add expected failing results to get the bots green.

* platform/mac/editing/spelling/autocorrection-contraction-expected.png:
* platform/mac/editing/spelling/autocorrection-contraction-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFile input control accessibility can cause a crash
dmazzoni@google.com [Fri, 16 Mar 2012 18:23:25 +0000 (18:23 +0000)]
File input control accessibility can cause a crash
https://bugs.webkit.org/show_bug.cgi?id=80896

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/input-file-causes-crash.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement):

LayoutTests:

* accessibility/input-file-causes-crash-expected.txt: Added.
* accessibility/input-file-causes-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] compositing tests with videos fail in chromium DumpRenderTree, seeking...
commit-queue@webkit.org [Fri, 16 Mar 2012 18:21:16 +0000 (18:21 +0000)]
[chromium] compositing tests with videos fail in chromium DumpRenderTree, seeking doesn't appear to work
https://bugs.webkit.org/show_bug.cgi?id=76511

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-03-16
Reviewed by Eric Carlson.

* compositing/resources/media-testing.js:
(ensureFrameVisible.playingHandler):
(ensureFrameVisible.seekedHandler):
(ensureFrameVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport W3C Full Screen API proposal
jer.noble@apple.com [Fri, 16 Mar 2012 18:12:14 +0000 (18:12 +0000)]
Support W3C Full Screen API proposal
https://bugs.webkit.org/show_bug.cgi?id=80660

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Tests: fullscreen/full-screen-element-stack.html
       fullscreen/full-screen-enabled.html
       fullscreen/full-screen-restrictions.html

The W3C proposal for taking arbitrary elements into full-screen mode is significantly
different than the Mozilla proposal. For example, the W3C has proposed a lower-case "s"
in "Fullscreen", which means the W3C and Mozilla "requestFullscreen" APIs differ only by
in that lower-case "s". Annoying as this is, it does allow us to retain the semantics for
the Mozilla case (har!).

A significant difficulty is obeying the new W3C spec rules is that we would like to apply the
fullscreen CSS rules while exiting fullscreen mode, though the W3C spec insists that the
webkitFullscreenElement returns the new value immediately.  As such, we retain the m_fullScreenElement
variable (distinct from the top of the m_fullScreenElements stack) which is controlled by the
webkit{Will,Did}{Enter,Exit}FullScreen functions.

New APIs for the W3C Fullscreen spec:
* dom/Document.h:
(WebCore::Document::webkitFullscreenElement):
(WebCore::Document::webkitFullscreenEnabled):
* dom/Document.idl:
* dom/Element.cpp:
(WebCore::Element::webkitRequestFullscreen):
* dom/Element.h:
* dom/Element.idl:

* dom/Document.cpp:
(WebCore::Document::removedLastRef): Clear m_fullScreenElementStack.
(WebCore::Document::requestFullScreenForElement): Implement the W3C requirements.
(WebCore::Document::webkitExitFullscreen): Ditto.
(WebCore::Document::webkitCancelFullScreen): Implement in terms of webkitCancelFullscreen.
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::fullScreenChangeDelayTimerFired): Protect against items being
    added to the event and error queue by swapping out empty queues before starting.
(WebCore::Document::clearFullscreenElementStack): Simple accessor.
(WebCore::Document::popFullscreenElementStack): Ditto.
(WebCore::Document::pushFullscreenElementStack): Ditto.
* dom/Element.cpp:
(WebCore::Element::webkitRequestFullScreen):

Add new RuntimeEnabledFeatures functions for the added Document and Element functions.
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenEnabledEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitExitFullscreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullscreenEnabled):

Source/WebKit/mac:

Allow full screen elements to access the keyboard.

* WebView/WebView.mm:
(-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):

Source/WebKit2:

Allow full screen elements to access the keyboard.

* UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::supportsFullScreen):
* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::exitFullScreenForElement):

LayoutTests:

* fullscreen/full-screen-element-stack-expected.txt: Added.
* fullscreen/full-screen-element-stack.html: Added.
* fullscreen/full-screen-enabled-expected.txt: Added.
* fullscreen/full-screen-enabled.html: Added.
* fullscreen/full-screen-request-rejected.html:
* fullscreen/full-screen-request-removed.html:
* fullscreen/full-screen-restrictions-expected.txt: Added.
* fullscreen/full-screen-restrictions.html: Added.
* fullscreen/full-screen-test.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] WebKitWebResource::load-failed uses the wrong marshaller
commit-queue@webkit.org [Fri, 16 Mar 2012 18:00:10 +0000 (18:00 +0000)]
[GTK] WebKitWebResource::load-failed uses the wrong marshaller
https://bugs.webkit.org/show_bug.cgi?id=81229

Patch by Victor Lucero <victor.lucero@ipartner.cl> on 2012-03-16
Reviewed by Philippe Normand.

* webkit/webkitwebresource.cpp:
(webkit_web_resource_class_init): load-failed signal in WebkitWebResource was using the wrong marshaller

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake HTMLInputElement::isRadioButton non-virtual and remove unused HTMLFormControlEle...
adamk@chromium.org [Fri, 16 Mar 2012 17:58:13 +0000 (17:58 +0000)]
Make HTMLInputElement::isRadioButton non-virtual and remove unused HTMLFormControlElement::isRadioButton method
https://bugs.webkit.org/show_bug.cgi?id=81255

Reviewed by Kent Tamura.

No new tests, no change in behavior.

* html/HTMLFormControlElement.h:
* html/HTMLInputElement.h:
(HTMLInputElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Update NetworkJob to accept batched headers
commit-queue@webkit.org [Fri, 16 Mar 2012 17:43:56 +0000 (17:43 +0000)]
[BlackBerry] Update NetworkJob to accept batched headers
https://bugs.webkit.org/show_bug.cgi?id=81273

Batch up the headers into a vector before they come into
webkit to increase performance, and simplify the API.

Patch by Tay Grigg <tgrigg@rim.com> on 2012-03-16
Reviewed by George Staikos.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyHeadersReceived):
* platform/network/blackberry/NetworkJob.h:
(NetworkJob):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Syncing up left over bits in Api from our local branch to upstream
commit-queue@webkit.org [Fri, 16 Mar 2012 17:17:03 +0000 (17:17 +0000)]
[BlackBerry] Syncing up left over bits in Api from our local branch to upstream
https://bugs.webkit.org/show_bug.cgi?id=81105

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-03-16
Reviewed by Rob Buis.

This patches fixes up a previous sync done in this directory and adds some new bits
as well.  This is accurate as of ddea1528b37b29925638fe1183318b3c3994f1f8 in our
local repo.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::drawLayersOnCommitIfNeeded):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::webContext):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add overdraw metrics for texture uploads
commit-queue@webkit.org [Fri, 16 Mar 2012 17:14:30 +0000 (17:14 +0000)]
[chromium] Add overdraw metrics for texture uploads
https://bugs.webkit.org/show_bug.cgi?id=81175

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Record texture upload metrics during paint. To properly record
the amount of pixels culled, we must compute the amount of pixels we
would have uploaded for a tile. This requires knowing the dirty rect of
the tile, but the dirty rect can be changed by WebKit during a paint, so
we always store the dirtyRect in the tile's updateRect. We add an
m_updateCulled bool to the UpdatableTile structure, to identify tiles
that were not updated, and know a tile was updated if updateRect is not
empty and updateCulled is false.

Tested by all TiledLayerChromiumTests that use occlusion tracker.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(UpdatableTile):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):

Source/WebKit/chromium:

* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow AudioContext::create() to emit an ExceptionCode.
jer.noble@apple.com [Fri, 16 Mar 2012 17:07:41 +0000 (17:07 +0000)]
Allow AudioContext::create() to emit an ExceptionCode.
https://bugs.webkit.org/show_bug.cgi?id=81049

Reviewed by Kentaro Hara.

No new tests; no change in functionality.

Pass through an ExceptionCode parameter to AudioContext::create().  It is currently
never modified, but exceptions will be added in the future.

* bindings/js/JSAudioContextCustom.cpp:
(WebCore::JSAudioContextConstructor::constructJSAudioContext):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback):
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::create):
* webaudio/AudioContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove surface damage client from occlusion tracker
commit-queue@webkit.org [Fri, 16 Mar 2012 16:59:43 +0000 (16:59 +0000)]
[chromium] Remove surface damage client from occlusion tracker
https://bugs.webkit.org/show_bug.cgi?id=81242

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Code was not used yet, so no new tests. Removing tests instead!

* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::CCOcclusionTrackerBase):
(WebCore::::layerScissorRectInTargetSurface):
(WebCore):
* platform/graphics/chromium/cc/CCOcclusionTracker.h:
(WebCore):
(CCOcclusionTrackerBase):

Source/WebKit/chromium:

* tests/CCOcclusionTrackerTest.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API (JSEP): Introducing PeerConnection00Handler
tommyw@google.com [Fri, 16 Mar 2012 16:56:57 +0000 (16:56 +0000)]
MediaStream API (JSEP): Introducing PeerConnection00Handler
https://bugs.webkit.org/show_bug.cgi?id=81333

Reviewed by Adam Barth.

In preparation of the last WebCore patch that will introduce PeerConnection00 here's its platform representation.

Not possible to test until the entire JSEP feature is commited.

* GNUmakefile.list.am:
* WebCore.gypi:
* platform/mediastream/PeerConnection00Handler.cpp: Added.
(WebCore):
(WebCore::PeerConnection00Handler::create):
(WebCore::PeerConnection00Handler::PeerConnection00Handler):
(WebCore::PeerConnection00Handler::~PeerConnection00Handler):
(WebCore::PeerConnection00Handler::createOffer):
(WebCore::PeerConnection00Handler::createAnswer):
(WebCore::PeerConnection00Handler::setLocalDescription):
(WebCore::PeerConnection00Handler::setRemoteDescription):
(WebCore::PeerConnection00Handler::localDescription):
(WebCore::PeerConnection00Handler::remoteDescription):
(WebCore::PeerConnection00Handler::startIce):
(WebCore::PeerConnection00Handler::processIceMessage):
(WebCore::PeerConnection00Handler::addStream):
(WebCore::PeerConnection00Handler::removeStream):
(WebCore::PeerConnection00Handler::stop):
* platform/mediastream/PeerConnection00Handler.h: Added.
(WebCore):
(PeerConnection00Handler):
* platform/mediastream/PeerConnection00HandlerClient.h: Added.
(WebCore):
(PeerConnection00HandlerClient):
(WebCore::PeerConnection00HandlerClient::~PeerConnection00HandlerClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Input processing mode should be cancelled when processing hot keys
commit-queue@webkit.org [Fri, 16 Mar 2012 16:56:57 +0000 (16:56 +0000)]
[BlackBerry] Input processing mode should be cancelled when processing hot keys
https://bugs.webkit.org/show_bug.cgi?id=81348

Patch by Mike Fenton <mifenton@rim.com> on 2012-03-16
Reviewed by Rob Buis.

Don't suppress IMF notifications if we are handling
the event as a hotkey.

Reviewed Internally by Nima Ghanavatian.

* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::handleKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: fix exception when hovering over bound function in heap profiler.
podivilov@chromium.org [Fri, 16 Mar 2012 16:49:45 +0000 (16:49 +0000)]
Web Inspector: fix exception when hovering over bound function in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=81362

Reviewed by Yury Semikhatsky.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWindows build fix.
sfalken@apple.com [Fri, 16 Mar 2012 16:49:32 +0000 (16:49 +0000)]
Windows build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip visual word movement tests in gtk and qt after r110965 since isWordTextBreak...
xji@chromium.org [Fri, 16 Mar 2012 16:49:09 +0000 (16:49 +0000)]
Skip visual word movement tests in gtk and qt after r110965 since isWordTextBreak is not implemented.

* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Fix bounce-back behaviour for panning
abecsi@webkit.org [Fri, 16 Mar 2012 16:43:31 +0000 (16:43 +0000)]
[Qt][WK2] Fix bounce-back behaviour for panning
https://bugs.webkit.org/show_bug.cgi?id=81144

Reviewed by Kenneth Rohde Christiansen.

If the pan gesture recognizer receives a touch begin event
during an ongoing kinetic scroll animation of a previous
pan gesture, the animation is stopped and the content is
immediately positioned back to valid boundaries.

* UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::recognize):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::cancelScrollAnimation):
(WebKit):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit/gtk/resources/error.html font-size error
mrobinson@webkit.org [Fri, 16 Mar 2012 16:40:54 +0000 (16:40 +0000)]
WebKit/gtk/resources/error.html font-size error
https://bugs.webkit.org/show_bug.cgi?id=39232

Patch by Landry Breuil <landry@openbsd.org> on 2012-03-14
Reviewed by Martin Robinson.

Fix font-size in the 404 error page. Apparently the % is filtered out,
so 120% becomes 120 and the error message is huge. Experienced in epiphany.

* resources/error.html: Double the % so it doesn't get filtered

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImprove diagnostic benefit of JSGlobalData::m_isInitializingObject
msaboff@apple.com [Fri, 16 Mar 2012 16:26:26 +0000 (16:26 +0000)]
Improve diagnostic benefit of JSGlobalData::m_isInitializingObject
https://bugs.webkit.org/show_bug.cgi?id=81244

Rubber stamped by Filip Pizlo.

Changed type and name of JSGlobalData::m_isInitializingObject to
ClassInfo* and m_initializingObjectClass.
Changed JSGlobalData::setInitializingObject to
JSGlobalData::setInitializingObjectClass.  This pointer can be used within
the debugger to determine what type of object is being initialized.

* runtime/JSCell.h:
(JSC::JSCell::finishCreation):
(JSC::allocateCell):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSGlobalData):
(JSC::JSGlobalData::isInitializingObject):
(JSC::JSGlobalData::setInitializingObjectClass):
* runtime/Structure.h:
(JSC::JSCell::finishCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][Wk2] Assertion Failure and crash on file upload
commit-queue@webkit.org [Fri, 16 Mar 2012 16:16:25 +0000 (16:16 +0000)]
[Qt][Wk2] Assertion Failure and crash on file upload
https://bugs.webkit.org/show_bug.cgi?id=80854

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-03-16
Reviewed by Simon Hausmann.

Source/WebKit2:

Crash resulted from attempting to create QFileDialog, a QtWidget based dialog from a
QGuiApplication. Replace QFileDialog with a QML implementable component.
Added a new property 'filePicker' to WebView experimental to set the QML component for
file upload triggered by an input file element.

Co-authored with Kasthuri Nallappasoundararajan <kasthuri.n-s@nokia.com>

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::chooseFiles):
(QQuickWebViewExperimental::filePicker):
(QQuickWebViewExperimental::setFilePicker):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_singleFileUpload.qml: Added.
* UIProcess/API/qt/tests/qmltests/common/singlefileupload.html: Added.
* UIProcess/qt/QtDialogRunner.cpp:
(FilePickerContextObject):
(FilePickerContextObject::FilePickerContextObject):
(FilePickerContextObject::fileList):
(FilePickerContextObject::reject):
(FilePickerContextObject::accept):
(QtDialogRunner::initForFilePicker):
* UIProcess/qt/QtDialogRunner.h:
(QtDialogRunner):
(QtDialogRunner::filePaths):
(QtDialogRunner::onFileSelected):

Tools:

Added filePicker to WebView using experimental API.

* MiniBrowser/qt/MiniBrowser.qrc:
* MiniBrowser/qt/icons/folder.png: Added.
* MiniBrowser/qt/icons/titlebar.png: Added.
* MiniBrowser/qt/icons/up.png: Added.
* MiniBrowser/qt/qml/BrowserWindow.qml:
* MiniBrowser/qt/qml/FilePicker.qml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdating email for committer.py script.
mahesh.kulkarni@nokia.com [Fri, 16 Mar 2012 16:04:44 +0000 (16:04 +0000)]
Updating email for committer.py script.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Build failure when using --no-touch-events
commit-queue@webkit.org [Fri, 16 Mar 2012 15:51:07 +0000 (15:51 +0000)]
[Qt][WK2] Build failure when using --no-touch-events
https://bugs.webkit.org/show_bug.cgi?id=81241

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-03-16
Reviewed by Simon Hausmann.

Fixed inconsistency in the use of ENABLE_TOUCH_EVENTS flag that caused build
failure when using --no-touch-events option

* UIProcess/qt/QtPageClient.h:
(QtPageClient):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handlePotentialSingleTapEvent):
* UIProcess/qt/QtWebPageEventHandler.h:
(QtWebPageEventHandler):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
* WebProcess/WebPage/WebPage.h:
(WebPage):
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] The "progress" element should not be a form-associated element.
commit-queue@webkit.org [Fri, 16 Mar 2012 15:01:16 +0000 (15:01 +0000)]
[Forms] The "progress" element should not be a form-associated element.
https://bugs.webkit.org/show_bug.cgi?id=80240

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-16
Reviewed by Kent Tamura.

Source/WebCore:

This patch changes base class of HTMLProgressElement to LabelableElement from
HTMLFormControlElement for saving memory space and iteration time of
extra "progress" elements in HTMLFormElement::m_formAssociatedElements
and matching the HTML5 specification for ease of maintenance.

Changes of TextIterator is lead by usage of isFormControlElement. This
changes will be replaced with more meaningful predicate as part of
https://bugs.webkit.org/show_bug.cgi?id=80381

No new tests. Update existing tests to cover this change.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement): Moved the "progress" element support code from canShareStyleWithControl.
(WebCore::CSSStyleSelector::canShareStyleWithControl):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): Remove isFormControlElement check for PseudoIndeterminate.
* editing/TextIterator.cpp:
(WebCore::TextIterator::advance): Check HTMLProgressElement in addition to isFormControlElement. This change is for text dump in LayoutTests implemented by document.innerText attribute.
* html/HTMLProgressElement.cpp: Remove unused include file.
(WebCore::HTMLProgressElement::HTMLProgressElement): Changed base class to LabelableElement.
(WebCore::HTMLProgressElement::create): Remove form paraprogress.
(WebCore::HTMLProgressElement::parseAttribute): Replace HTMLFormControlElement to LabelableElement.
(WebCore::HTMLProgressElement::attach): Replace HTMLFormControlElement to LabelableElement.
* html/HTMLProgressElement.h:
(HTMLProgressElement):
* html/HTMLProgressElement.idl: Remove the "form" attribute which isn't listed in the HTML5 specification.
* html/HTMLTagNames.in: Remove "constructorNeedsFormElement" for not passing "form" parameter in HTMLElementFactory.

LayoutTests:

This patch changes tests for non-existent "form" attribute of the
"progress" element. The "form" attribute is available only for
form-associate elements. However, the "progress" element isn't.

* fast/dom/HTMLProgressElement/progress-element-form-expected.txt: Update expectation for test output changes.
* fast/dom/HTMLProgressElement/progress-element-form.html: Changed for the "progress" element doesn't have IDL attribute "form".
* fast/forms/form-attribute-expected.txt: Update expectation for test output changes.
* fast/forms/form-attribute.html: Removed lines for the "progress" element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Heap Snapshot: Unreviewed single line fix for isWindow getter.
loislo@chromium.org [Fri, 16 Mar 2012 14:54:09 +0000 (14:54 +0000)]
Web Inspector: Heap Snapshot: Unreviewed single line fix for isWindow getter.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get isWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API (JSEP): Fixing a few nits
tommyw@google.com [Fri, 16 Mar 2012 14:53:01 +0000 (14:53 +0000)]
MediaStream API (JSEP): Fixing a few nits
https://bugs.webkit.org/show_bug.cgi?id=81322

Reviewed by Adam Barth.

Addressing the nits from bugs 81206 and 81207.

Nothing to test.

* Modules/mediastream/SessionDescription.idl:
* platform/mediastream/IceOptions.h:
(WebCore::IceOptions::IceOptions):
* platform/mediastream/SessionDescriptionDescriptor.h:
(SessionDescriptionDescriptor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] DRT: Add support for sending gesture scrolls without a begin
commit-queue@webkit.org [Fri, 16 Mar 2012 14:48:05 +0000 (14:48 +0000)]
[chromium] DRT: Add support for sending gesture scrolls without a begin
https://bugs.webkit.org/show_bug.cgi?id=81292

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-16
Reviewed by Kent Tamura.

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::gestureScrollFirstPoint):
* DumpRenderTree/chromium/EventSender.h:
(EventSender):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: TypeBuilder: Introduce OptOutput class for optional output parameters
yurys@chromium.org [Fri, 16 Mar 2012 14:43:13 +0000 (14:43 +0000)]
Web Inspector: TypeBuilder: Introduce OptOutput class for optional output parameters
https://bugs.webkit.org/show_bug.cgi?id=80789

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-03-16
Reviewed by Yury Semikhatsky.

OptOutput class is added for optional return parameters.

Strict mode added to Generator that makes all parameter types strict
and drop pre-set default values for return parameters.

Debugger and Page domain is switched to strict mode.

* inspector/CodeGeneratorInspector.py:
(CommandReturnPassModel.OptOutput):
(CommandReturnPassModel.OptOutput.__init__):
(CommandReturnPassModel.OptOutput.get_return_var_type):
(CommandReturnPassModel.OptOutput.get_output_argument_prefix):
(CommandReturnPassModel.OptOutput.get_output_to_raw_expression):
(CommandReturnPassModel.OptOutput.get_output_parameter_type):
(CommandReturnPassModel):
(CommandReturnPassModel.OptOutput.get_set_return_condition):
(TypeModel.Enum.get_optional.EnumOptional.get_command_return_pass_model):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(OptOutput):
(Generator.process_event):
(Generator.process_command):
* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::buildObjectForSearchMatch):
(WebCore::ContentSearchUtils::searchInTextByLines):
* inspector/ContentSearchUtils.h:
(ContentSearchUtils):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::makeEvalCall):
* inspector/InjectedScript.h:
(InjectedScript):
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/InspectorPageAgent.cpp:
(WebCore::buildObjectForCookie):
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
* inspector/InspectorPageAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe IDL parser should support sequence<T> type
haraken@chromium.org [Fri, 16 Mar 2012 14:01:09 +0000 (14:01 +0000)]
The IDL parser should support sequence<T> type
https://bugs.webkit.org/show_bug.cgi?id=81345

Reviewed by Adam Barth.

This patch makes the IDL parser support sequence<T> type.
This patch just makes sequence<T> parseable, and the generated code
for sequence<T> is wrong. This issue will be soon fixed in bug 80696.
This is a preparing patch for bug 80696.

Test: bindings/scripts/test/TestObj.idl

* bindings/scripts/test/TestObj.idl: Added tests for sequence<T>.

* bindings/scripts/IDLStructure.pm: Updated the regular expressions to support sequence<T>.

* bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
(WebDOMTestObj::sequenceAttr):
(WebDOMTestObj::setSequenceAttr):
(WebDOMTestObj::methodWithSequenceArg):
(WebDOMTestObj::methodReturningSequence):
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_method_with_sequence_arg):
(webkit_dom_test_obj_method_returning_sequence):
(webkit_dom_test_obj_get_sequence_attr):
(webkit_dom_test_obj_set_sequence_attr):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjSequenceAttr):
(WebCore::setJSTestObjSequenceAttr):
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj sequenceAttr]):
(-[DOMTestObj setSequenceAttr:]):
(-[DOMTestObj methodWithSequenceArg:]):
(-[DOMTestObj methodReturningSequence:]):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::sequenceAttrAttrGetter):
(TestObjInternal):
(WebCore::TestObjInternal::sequenceAttrAttrSetter):
(WebCore::TestObjInternal::methodWithSequenceArgCallback):
(WebCore::TestObjInternal::methodReturningSequenceCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: HeapSnapshot: merge two long operations into one.
loislo@chromium.org [Fri, 16 Mar 2012 13:50:33 +0000 (13:50 +0000)]
Web Inspector: HeapSnapshot: merge two long operations into one.
https://bugs.webkit.org/show_bug.cgi?id=81347

Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype.aggregates):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildAggregates.forDominatedNodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] QtWebKit documentation missing a few since 4.6 information
commit-queue@webkit.org [Fri, 16 Mar 2012 13:45:40 +0000 (13:45 +0000)]
[Qt] QtWebKit documentation missing a few since 4.6 information
https://bugs.webkit.org/show_bug.cgi?id=81328

Patch by Teemu Katajisto <teemu.katajisto@digia.com> on 2012-03-16
Reviewed by Simon Hausmann.

* Api/qwebpage.cpp:
* Api/qwebsettings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMerge setVisibleContentsForScaling with setVisibleContentsRectForPanning
kenneth@webkit.org [Fri, 16 Mar 2012 13:42:18 +0000 (13:42 +0000)]
Merge setVisibleContentsForScaling with setVisibleContentsRectForPanning
https://bugs.webkit.org/show_bug.cgi?id=81346

Reviewed by Simon Hausmann.

This cleans up the code path and is one step on the way to avoid
calling both methods in succession, for instance after ending pinch
zoom.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewLegacyPrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_commitScaleChange):
(QQuickWebViewPrivate::_q_commitPositionChange):
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::setVisibleContentsRect):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRect):
* UIProcess/DrawingAreaProxyImpl.h:
(DrawingAreaProxyImpl):
* UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::setVisibleContentsRect):
* UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::setVisibleContentsRect):
* UIProcess/WebLayerTreeRenderer.h:
(WebLayerTreeRenderer):
* WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::setVisibleContentsRect):
* WebProcess/WebPage/LayerTreeHost.messages.in:
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::setVisibleContentsRect):
* WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Can not open certain links from bridge applications
commit-queue@webkit.org [Fri, 16 Mar 2012 13:35:37 +0000 (13:35 +0000)]
[BlackBerry] Can not open certain links from bridge applications
https://bugs.webkit.org/show_bug.cgi?id=81197

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-16
Reviewed by Rob Buis.

Currently, the engine asks the client to handle some type of requests externally.
But WebPageClient::handleStringPattern is not yet implemented and exposed to
the client. Before that, we still need to give the client a chance to decide
how to handle requests such as 'mailto:'.

To address this problem, r108763 introduced a change that ask the client to
decide how to handle the navigation in dispatchDecidePolicyForNewWindowAction().
This is not intuitive and will bring troubles, because this navigation will
happen in the new page. So the new page client is to decide how to handle
the navigation, not the old one.

This patch reverts r108763 and skips calling WebPageClient::handleStringPattern
since it's not implemented.

This way the new window action will continue, and the logic in
dispatchDecidePolicyForNavigationAction() will handle the navigation correctly.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] WebKitIconDatabase doesn't keep icons cached
sergio@webkit.org [Fri, 16 Mar 2012 13:34:46 +0000 (13:34 +0000)]
[GTK] WebKitIconDatabase doesn't keep icons cached
https://bugs.webkit.org/show_bug.cgi?id=56200

Reviewed by Martin Robinson.

Source/WebKit/gtk:

* GNUmakefile.am: Added new files to compilation.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::registerForIconNotification): instruct
the WebView to listen to IconDatabase's notifications.
(WebKit::FrameLoaderClient::dispatchDidReceiveIcon): ask both
WebView and IconDatabase to issue notifications for a new icon.
* docs/webkitgtk-docs.sgml: updated docs.
* docs/webkitgtk-sections.txt: ditto.
* docs/webkitgtk.types: ditto.
* tests/testicondatabase.c: Added.
(server_callback):
(deleteDatabaseFileIfExists):
(testWebkitIconDatabaseSetPath):
(iconDatabaseGetIconValidCallback):
(iconDatabaseGetIconInvalidCallback):
(iconDatabaseGetIconCancelledCallback):
(mainLoopQuitIfLoadCompleted):
(idleQuitLoopCallback):
(webkitWebViewIconLoaded):
(loadURI):
(faviconDatabaseGetFaviconValidIdle):
(faviconDatabaseGetFaviconInvalidIdle):
(faviconDatabaseGetFaviconCancelledIdle):
(testWebKitFaviconDatabaseGetFavicon):
(testWebKitFaviconDatabaseGetFaviconURI):
(testWebKitFaviconDatabaseRemoveAll):
(testWebKitFaviconDatabaseCloseDatabase):
(main):
* webkit/webkit.h: added new API.
* webkit/webkitdefines.h: added WebKitFaviconDatabase.
* webkit/webkitfavicondatabase.cpp:
(IconDatabaseClientGtk): IconDatabaseClient implementation.
(IconDatabaseClientGtk::performImport):
(IconDatabaseClientGtk::didRemoveAllIcons):
(IconDatabaseClientGtk::didImportIconURLForPageURL):
(IconDatabaseClientGtk::didImportIconDataForPageURL):
(IconDatabaseClientGtk::didChangeIconForPageURL):
(IconDatabaseClientGtk::didFinishURLImport):
(PendingIconRequest): machinery for asynchronous calls.
(PendingIconRequest::PendingIconRequest):
(PendingIconRequest::~PendingIconRequest):
(PendingIconRequest::pageURI):
(PendingIconRequest::asyncResult):
(PendingIconRequest::asyncResultCancel):
(PendingIconRequest::asyncResultCompleteInIdle):
(PendingIconRequest::asyncResultComplete):
(_WebKitIconDatabasePrivate):
(webkit_favicon_database_dispose): GObject stuff.
(webkit_favicon_database_set_property): ditto.
(webkit_favicon_database_get_property): ditto.
(webkit_favicon_database_class_init): ditto.
(webkit_favicon_database_init): ditto.
(webkitFaviconDatabaseNotifyAndUpdateExpiration): notify about new
icons and update expiration times.
(webkitFaviconDatabaseDispatchDidReceiveIcon): "protected" method
called by the FrameLoaderClient to inform about new icons.
(webkit_favicon_database_get_path): retrieves database path.
(selectQueryCallback): releases expired icons to let IconDatabase
prune them.
(webkitFaviconDatabasePruneExpiredIcons): selects the icons to be
pruned by the IconDatabase.
(webkitFaviconDatabaseClose): close the database.
(createExpirationTimesDatabaseTableIfNotExists): creates the
database used to control expiration times.
(webkit_favicon_database_set_path): opens the database delaying the
cleanup of icons until the import is complete.
(webkit_favicon_database_get_favicon_uri): returns the uri of the
favicon.
(getIconPixbufSynchronously): helper function to call
IconDatabase::synchronousIconURLForPageURL().
(webkit_favicon_database_try_get_favicon_pixbuf): returns the
favicon if exists and is loaded from disk.
(webkitFaviconDatabaseGetOrCreateRequests): helper function to get
the vector of pending requests for the given uri.
(webkitfavicondatabaseDeleteRequests): helper function to remove the
vector of pending requests for the given uri.
(getIconPixbufCancelled):
(webkitFaviconDatabaseGetIconPixbufCancelled):
(webkit_favicon_database_get_favicon_pixbuf): asynchronously
retrieve icons from the database.
(webkit_favicon_database_get_favicon_pixbuf_finish): finishes an
operation started with webkit_icon_database_get_icon_pixbuf().
(webkitFaviconDatabaseProcessPendingIconsForURI): process pending
requests once the import is finished.
(webkitFaviconDatabaseImportFinished): check pending requests and
delete those that ask for icons that do not exist in the database.
(webkit_favicon_database_clear): clears the database.
* webkit/webkitfavicondatabase.h: added.
(_WebKitFaviconDatabase):
(_WebKitFaviconDatabaseClass):
* webkit/webkitfavicondatabaseprivate.h: Added.
* webkit/webkitglobals.cpp:
(webkit_get_favicon_database): retrieves the new
WebKitFaviconDatabase.
(webkitExit): unref icon database on exit.
* webkit/webkitglobals.h: added new API.
* webkit/webkiticondatabase.cpp: added deprecation documentation.
(webkit_icon_database_class_init):
* webkit/webkitwebview.cpp:
(webkit_web_view_try_get_icon_pixbuf): new API that uses the new
WebKitFaviconDatabase API.
(webkitWebViewIconLoaded): dispatch the icon-loaded signal when
requested by the FrameLoaderClient.
(webkitWebViewRegisterForIconNotification): starts/stops listening
to icon database notifications.
* webkit/webkitwebview.h: added new API.
* webkit/webkitwebviewprivate.h: added some protected methods.

Tools:

Add support for favicons in GtkLauncher.

* GtkLauncher/main.c:
(activateUriEntryCb):
(iconLoadedCb):
(createBrowser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd asserts and improve logging in PageCache.
gavinp@chromium.org [Fri, 16 Mar 2012 13:25:31 +0000 (13:25 +0000)]
Add asserts and improve logging in PageCache.
https://bugs.webkit.org/show_bug.cgi?id=81179

Reviewed by Brady Eidson.

The early exits from logCanCacheFrameDecision had the potential to skew histogram data.  Moving
the DocumentLoader check to the top, but eliminating the early exits is a compromise that keeps
the logged data mostly accurate.

* history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove sheriff-bot's last-green-revision command
abarth@webkit.org [Fri, 16 Mar 2012 13:13:14 +0000 (13:13 +0000)]
Remove sheriff-bot's last-green-revision command
https://bugs.webkit.org/show_bug.cgi?id=81314

Reviewed by Eric Seidel.

This command is a cruel joke.  WebKit doesn't really ever have a
last-green-revision.

* Scripts/webkitpy/common/net/buildbot/buildbot.py:
(BuildBot._find_green_revision):
* Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
(MockBuildBot.builder_statuses):
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
(test_find_green_revision):
* Scripts/webkitpy/tool/bot/irc_command.py:
(IRCCommand.execute):
* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
(SheriffIRCBotTest.test_help):
* Scripts/webkitpy/tool/commands/queries.py:
(PatchesToReview.execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] label.form attribute doesn't work
commit-queue@webkit.org [Fri, 16 Mar 2012 13:05:35 +0000 (13:05 +0000)]
[Forms] label.form attribute doesn't work
https://bugs.webkit.org/show_bug.cgi?id=80499

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-16
Reviewed by Kent Tamura.

Source/WebCore:

This patch changes implementation of label.form of IDL attribute to
compute it to the form element specified by the "form" HTML attribute
or form ancestor when the "form" HTML attribute isn't in HTML.

This patch introduces new function FormAssociatedElement::findAssociatedForm
for sharing code among FormAssociateElement::insertedIntoTree, resetFormOwner
and HTMLLabelElement::form.

No new tests. Update existing tests.

* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::findAssociatedForm): Added.
(WebCore):
(WebCore::FormAssociatedElement::insertedIntoTree):
(WebCore::FormAssociatedElement::resetFormOwner):
* html/FormAssociatedElement.h:
(FormAssociatedElement):
* html/HTMLLabelElement.cpp: Remove unused include files
(WebCore::HTMLLabelElement::form): Added.

LayoutTests:

This patch updates test cases and expectation for functional
"form" attribute of the "label" element.

* fast/forms/form-attribute-expected.txt:
* fast/forms/form-attribute-nonexistence-form-id-expected.txt:
* fast/forms/form-attribute-nonexistence-form-id.html:
* fast/forms/form-attribute.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse the normalize method of FloatPoint instead of normalizing manually
kenneth@webkit.org [Fri, 16 Mar 2012 13:00:57 +0000 (13:00 +0000)]
Use the normalize method of FloatPoint instead of normalizing manually
https://bugs.webkit.org/show_bug.cgi?id=81343

Reviewed by Simon Hausmann.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::coverWithTilesIfNeeded):
(WebCore::TiledBackingStore::computeCoverAndKeepRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl
haraken@chromium.org [Fri, 16 Mar 2012 12:50:01 +0000 (12:50 +0000)]
Move Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl
https://bugs.webkit.org/show_bug.cgi?id=79636

Reviewed by Adam Barth.

For WebKit modularization, this patch moves Notifications-related APIs
from DOMWindow.idl to DOMWindowNotifications.idl.

Tests: fast/notifications/* (No change in test results)

* CMakeLists.txt: Added DOMWindowNotifications.{h,cpp,idl}.
* DerivedSources.make: Ditto.
* DerivedSources.pri: Ditto.
* GNUmakefile.list.am: Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.

* WebCore.exp.in: Added mangled signatures of webkitNotifications().

* notifications/DOMWindowNotifications.cpp: Added.
(WebCore):
(WebCore::DOMWindowNotifications::DOMWindowNotifications):
(WebCore::DOMWindowNotifications::~DOMWindowNotifications):
(WebCore::DOMWindowNotifications::from):
(WebCore::DOMWindowNotifications::webkitNotifications):
(WebCore::DOMWindowNotifications::ensureWebkitNotifications):
(WebCore::DOMWindowNotifications::disconnectFrame):
* notifications/DOMWindowNotifications.h: Added.
(WebCore):
(DOMWindowNotifications):
* notifications/DOMWindowNotifications.idl: Added.

* page/DOMWindow.cpp: Removed ENABLE(NOTIFICATIONS).
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::willDetachPage):
(WebCore::DOMWindow::clear):
* page/DOMWindow.h: Ditto.
(WebCore):
(DOMWindow):
* page/DOMWindow.idl: Ditto.
* page/Frame.cpp: Ditto.
(WebCore::Frame::willDetachPage):
(WebCore::Frame::transferChildFrameToNewDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Make gccdepends test aware of broken icecream deps generation
vestbo@webkit.org [Fri, 16 Mar 2012 12:46:40 +0000 (12:46 +0000)]
[Qt] Make gccdepends test aware of broken icecream deps generation

Icecream seems to build the files without passing -o to gcc with
the original destination path, which means the target name in the
dependency file is wrong.

Also, echo something to the final file instead of just touching it,
so it's not deleted on every build.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Performance] Optimize innerHTML and outerHTML
haraken@chromium.org [Fri, 16 Mar 2012 12:31:57 +0000 (12:31 +0000)]
[Performance] Optimize innerHTML and outerHTML
https://bugs.webkit.org/show_bug.cgi?id=81214

Reviewed by Adam Barth.

This patch makes innerHTML and outerHTML 2.4 times faster.

Performance test: https://bugs.webkit.org/attachment.cgi?id=132034
The performance test measures body.innerHTML for 3000 lines of HTML,
which is copied from the HTML spec.

- Chromium/Mac without the patch
div.innerHTML: 1658.6 ms
div.outerHTML: 4859.6 ms
body.innerHTML: 640.2 ms
body.outerHTML: 641.8 ms

- Chromium/Mac with the patch
div.innerHTML:  751.0 ms
div.outerHTML: 2096.0 ms
body.innerHTML: 271.2 ms
body.outerHTML: 271.2 ms

- Chromium/Linux without the patch
div.innerHTML:  950.4 ms
div.outerHTML: 2257.8 ms
body.innerHTML: 452.8 ms
body.outerHTML: 457.6 ms

- Chromium/Linux with the patch
div.innerHTML:  582.4 ms
div.outerHTML: 1283.0 ms
body.innerHTML: 233.0 ms
body.outerHTML: 233.4 ms

- AppleWebKit/Mac without the patch
div.innerHTML:  900.6 ms
div.outerHTML: 2245.2 ms
body.innerHTML: 462.6 ms
body.outerHTML: 468.0 ms

- AppleWebKit/Mac with the patch
div.innerHTML:  529.8  ms
div.outerHTML: 1090.2 ms
body.innerHTML: 239.2 ms
body.outerHTML: 239.2 ms

This patch applies the following two optimizations:

(a) Remove redundant copies between Vector<String> and StringBuilders
in MarkupAccumulator::serializeNodes(), MarkupAccumulator::appendStartTag(),
and MarkupAccumulator::appendEndTag().

    (Previous behavior)
    - Create a StringBuilder for each tag.
    - Append a created string in each StringBuilder to Vector<String>,
      parsing the DOM tree.
    - After the parsing, allocate a StringBuilder whose size is the sum
      of all Strings in Vector<String>.
    - Append all Strings in Vector<String> to the StringBuilder.
    (New behavior)
    - Allocate a StringBuilder with a default buffer size.
    - Append created strings to the StringBuilder, incrementally parsing
      the DOM tree.

(b) Optimize stringBuilder.append().
    (b-1) Replace stringBuilder.append("A") with stringBuilder.append('A').
          stringBuilder.append("A") requires to cast the characters to LChar*,
          and then call strlen("A"). stringBuilder.append('A') is faster.
    (b-2) Replace stringBuilder.append("AB") with stringBuilder.append('A')
          and stringBuilder.append('B'). In my experiment, appending characters
          one by one is faster than appending the characters at a breath if the
          number of characters is less than 3.
    (b-3) Hard-code a string length; i.e. replace stringBuilder.append("ABCDE")
          with stringBuilder.append("ABCDE", 5). While the former requires to call
          strlen("ABCDE"), the latter does not.

(a) improves performance by 170% ~ 200%. (b) improves performance by 30 ~ 40%.

Tests: fast/dom/Range/range-extract-contents.html
       fast/dom/serialize-nodes.xhtml
       fast/dom/XMLSerializer.html
       and all other tests that use innerHTML or outerHTML.
       No change in the test results.

* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::serializeNodes):
(WebCore::MarkupAccumulator::appendString):
(WebCore::MarkupAccumulator::appendStartTag):
(WebCore::MarkupAccumulator::appendEndTag):
(WebCore::MarkupAccumulator::concatenateMarkup):
(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):
(WebCore::MarkupAccumulator::appendComment):
(WebCore::MarkupAccumulator::appendDocumentType):
(WebCore::MarkupAccumulator::appendProcessingInstruction):
(WebCore::MarkupAccumulator::appendOpenTag):
(WebCore::MarkupAccumulator::appendAttribute):
(WebCore::MarkupAccumulator::appendCDATASection):
* editing/MarkupAccumulator.h:
(MarkupAccumulator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago.: Support for Battery Status API.
commit-queue@webkit.org [Fri, 16 Mar 2012 12:23:07 +0000 (12:23 +0000)]
.: Support for Battery Status API.
https://bugs.webkit.org/show_bug.cgi?id=62698

Enable BATTERY_STATUS for WebKit-Efl.
http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

* Source/cmake/OptionsEfl.cmake:
* Source/cmakeconfig.h.cmake:

Source/WebCore: Support for Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=62698

Battery Status API is implemented under the Navigator class.
Battery Status API has four types of events, and all events are operated based on a callback mechanism.
 : onchargingchange, onchargingtimechange, ondischargingtimechange, onlevelchange.
The battery status can be accessed using BatteryManager(navigator.webkitBattery), and battery status is controlled by BatteryController which manages instances of BatteryManager.
When battery status event is raised, BatteryController calls all registered BatteryManager's event dispatcher.
http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

Tests: batterystatus/add-listener-from-callback.html
       batterystatus/basic-all-types-of-events.html
       batterystatus/basic-operation.html
       batterystatus/event-after-navigation.html
       batterystatus/multiple-frames.html
       batterystatus/updates.html
       batterystatus/window-property.html

* CMakeLists.txt:
* Modules/battery/BatteryClient.h: Added.
(WebCore):
(BatteryClient):
(WebCore::BatteryClient::~BatteryClient):
* Modules/battery/BatteryController.cpp: Added.
(WebCore):
(WebCore::BatteryController::BatteryController):
(WebCore::BatteryController::~BatteryController):
(WebCore::BatteryController::create):
(WebCore::BatteryController::addListener):
(WebCore::BatteryController::removeListener):
(WebCore::BatteryController::didChangeBatteryStatus):
(WebCore::BatteryController::supplementName):
(WebCore::BatteryController::isActive):
(WebCore::provideBatteryTo):
* Modules/battery/BatteryController.h: Added.
(WebCore):
(BatteryController):
(WebCore::BatteryController::client):
(WebCore::BatteryController::from):
* Modules/battery/BatteryManager.cpp: Added.
(WebCore):
(WebCore::BatteryManager::create):
(WebCore::BatteryManager::~BatteryManager):
(WebCore::BatteryManager::BatteryManager):
(WebCore::BatteryManager::charging):
(WebCore::BatteryManager::chargingTime):
(WebCore::BatteryManager::dischargingTime):
(WebCore::BatteryManager::level):
(WebCore::BatteryManager::didChangeBatteryStatus):
(WebCore::BatteryManager::suspend):
(WebCore::BatteryManager::resume):
(WebCore::BatteryManager::stop):
* Modules/battery/BatteryManager.h: Added.
(WebCore):
(BatteryManager):
(WebCore::BatteryManager::interfaceName):
(WebCore::BatteryManager::scriptExecutionContext):
(WebCore::BatteryManager::batteryControllerDestroyed):
(WebCore::BatteryManager::canSuspend):
(WebCore::BatteryManager::eventTargetData):
(WebCore::BatteryManager::ensureEventTargetData):
(WebCore::BatteryManager::refEventTarget):
(WebCore::BatteryManager::derefEventTarget):
* Modules/battery/BatteryManager.idl: Added.
* Modules/battery/BatteryStatus.cpp: Added.
(WebCore):
(WebCore::BatteryStatus::create):
(WebCore::BatteryStatus::BatteryStatus):
* Modules/battery/BatteryStatus.h: Added.
(WebCore):
(BatteryStatus):
(WebCore::BatteryStatus::charging):
(WebCore::BatteryStatus::chargingTime):
(WebCore::BatteryStatus::dischargingTime):
(WebCore::BatteryStatus::level):
* Modules/battery/NavigatorBattery.cpp: Added.
(WebCore):
(WebCore::NavigatorBattery::NavigatorBattery):
(WebCore::NavigatorBattery::~NavigatorBattery):
(WebCore::NavigatorBattery::webkitBattery):
(WebCore::NavigatorBattery::from):
(WebCore::NavigatorBattery::batteryManager):
* Modules/battery/NavigatorBattery.h: Added.
(WebCore):
(NavigatorBattery):
* Modules/battery/NavigatorBattery.idl: Added.
* dom/EventNames.h:
(WebCore):
* dom/EventTargetFactory.in:
* testing/Internals.cpp:
(WebCore::Internals::setBatteryStatus):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit: Support for Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=62698

Add include directory and file.
http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

* PlatformEfl.cmake:

Source/WebKit/efl: Support for Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=62698

Add BatteryClientEfl class implementation for the layout tests now.
BatteryClientEfl class is not fully implemented in this patch.
(It will be completed by other patch as necessary in the Efl port.)
http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

* WebCoreSupport/BatteryClientEfl.cpp: Added.
(WebCore):
(WebCore::BatteryClientEfl::BatteryClientEfl):
(WebCore::BatteryClientEfl::setController):
(WebCore::BatteryClientEfl::startUpdating):
(WebCore::BatteryClientEfl::stopUpdating):
(WebCore::BatteryClientEfl::batteryControllerDestroyed):
(WebCore::BatteryClientEfl::setBatteryStatus):
* WebCoreSupport/BatteryClientEfl.h: Added.
(WebCore):
(BatteryClientEfl):
(WebCore::BatteryClientEfl::~BatteryClientEfl):
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

Tools: Support for Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=62698

Add include directory and file.
http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

* Scripts/build-webkit:

LayoutTests: Support for Battery Status API.
https://bugs.webkit.org/show_bug.cgi?id=62698

Add new test cases for Battery Status API.
http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

* batterystatus/add-listener-from-callback-expected.txt: Added.
* batterystatus/add-listener-from-callback.html: Added.
* batterystatus/basic-all-types-of-events-expected.txt: Added.
* batterystatus/basic-all-types-of-events.html: Added.
* batterystatus/basic-operation-expected.txt: Added.
* batterystatus/basic-operation.html: Added.
* batterystatus/event-after-navigation-expected.txt: Added.
* batterystatus/event-after-navigation.html: Added.
* batterystatus/multiple-frames-expected.txt: Added.
* batterystatus/multiple-frames.html: Added.
* batterystatus/resources/event-after-navigation-new.html: Added.
* batterystatus/script-tests/add-listener-from-callback.js: Added.
(checkBatteryStatus):
(firstListener):
(secondListener):
(maybeFinishTest):
* batterystatus/script-tests/basic-all-types-of-events.js: Added.
(checkBatteryStatus):
(battery):
* batterystatus/script-tests/basic-operation.js: Added.
* batterystatus/script-tests/event-after-navigation.js: Added.
* batterystatus/script-tests/multiple-frames.js: Added.
(checkBatteryStatus):
(checkChildBatteryStatus):
(mainFrameListener):
(childFrameListener):
(maybeFinishTest):
* batterystatus/script-tests/updates.js: Added.
(checkBatteryStatus):
(setBatteryStatus):
(firstListener):
(updateListener):
* batterystatus/script-tests/window-property.js: Added.
(hasOnBatteryProperty):
* batterystatus/updates-expected.txt: Added.
* batterystatus/updates.html: Added.
* batterystatus/window-property-expected.txt: Added.
* batterystatus/window-property.html: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocheck-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt
commit-queue@webkit.org [Fri, 16 Mar 2012 12:14:31 +0000 (12:14 +0000)]
check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=81007

Patch by Kishore Bolisetty <kbolisetty@innominds.com> on 2012-03-16
Reviewed by Adam Barth.

A dedidcated build slave is available for efl on build.webkit.org.
This change add's an entry for the elf port in list of available port builders.
This is required because test_expectations.py when triggered, looks for a valid port object for the specified port.

* Scripts/webkitpy/layout_tests/port/builders.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: HeapSnapshot: speedup buildReverseIndex.
loislo@chromium.org [Fri, 16 Mar 2012 11:55:32 +0000 (11:55 +0000)]
Web Inspector: HeapSnapshot: speedup buildReverseIndex.
https://bugs.webkit.org/show_bug.cgi?id=81327

Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype.get maxNodeId):
(WebInspector.HeapSnapshot.prototype._buildNodeIndex):
(WebInspector.HeapSnapshot.prototype._findNearestNodeIndex):
(WebInspector.HeapSnapshot.prototype._getRetainerIndex):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
(WebInspector.HeapSnapshot.prototype):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Add ProcessLauncherEfl.cpp
commit-queue@webkit.org [Fri, 16 Mar 2012 11:41:06 +0000 (11:41 +0000)]
[EFL][WK2] Add ProcessLauncherEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=75464

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-03-16
Reviewed by Hajime Morita.

Add first version of ProcessLauncherEfl.cpp including launchProcess() and terminateProcess().

* UIProcess/Launcher/efl/ProcessLauncherEfl.cpp: Added.
(WebKit::ProcessLauncher::launchProcess):
(WebKit::ProcessLauncher::terminateProcess):
(WebKit::ProcessLauncher::platformInvalidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[webkitpy] StatusServer.next_work_item has an incorrectly named local variable
abarth@webkit.org [Fri, 16 Mar 2012 11:37:47 +0000 (11:37 +0000)]
[webkitpy] StatusServer.next_work_item has an incorrectly named local variable
https://bugs.webkit.org/show_bug.cgi?id=81302

Reviewed by Eric Seidel.

This is a trivial patch, but the variable name turned up in a grep of
webkitpy and looks like copy pasta.

* Scripts/webkitpy/common/net/statusserver.py:
(StatusServer.next_work_item):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r110976.
commit-queue@webkit.org [Fri, 16 Mar 2012 11:29:15 +0000 (11:29 +0000)]
Unreviewed, rolling out r110976.
http://trac.webkit.org/changeset/110976
https://bugs.webkit.org/show_bug.cgi?id=81330

webkit_unit_tests crashes. (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-16

* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::error):
(WebCore):
* loader/cache/CachedCSSStyleSheet.h:
(CachedCSSStyleSheet):
* loader/cache/CachedFont.cpp:
(WebCore):
(WebCore::CachedFont::error):
* loader/cache/CachedFont.h:
(CachedFont):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::error):
* loader/cache/CachedResource.h:
(CachedResource):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::error):
(WebCore):
* loader/cache/CachedScript.h:
(CachedScript):
* loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::error):
(WebCore):
* loader/cache/CachedXSLStyleSheet.h:
(CachedXSLStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement cast between CSSPrimitiveValue and LineClampValue.
macpherson@chromium.org [Fri, 16 Mar 2012 11:25:54 +0000 (11:25 +0000)]
Implement cast between CSSPrimitiveValue and LineClampValue.
https://bugs.webkit.org/show_bug.cgi?id=76806

Reviewed by Andreas Kling.

Covered by many existing LayoutTests.

This simplifies code in CSSStyleSelector and future mapping to CSSStyleApplyProperty.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LineClampValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Bump textureUpdatesPerFrame to 32 to favor updating the screen over jank...
nduca@chromium.org [Fri, 16 Mar 2012 11:03:23 +0000 (11:03 +0000)]
[chromium] Bump textureUpdatesPerFrame to 32 to favor updating the screen over jank prevention
https://bugs.webkit.org/show_bug.cgi?id=81298

Reviewed by James Robinson.

* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate usage of LayoutUnits in RenderBlock*
leviw@chromium.org [Fri, 16 Mar 2012 10:52:56 +0000 (10:52 +0000)]
Update usage of LayoutUnits in RenderBlock*
https://bugs.webkit.org/show_bug.cgi?id=80437

Reviewed by Julien Chaffraix.

Updating LayoutUnit usage in RenderBlock and RenderBlockLineLayout. This better readies trunk for
the transition to subpixel layout.

See https://trac.webkit.org/wiki/LayoutUnit for more details.

No new tests. No changed behavior.

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint): Adding the paint offset rounding previously in RenderBlock::paint.
* rendering/LayoutTypes.h:
(WebCore::floorToInt): Will floor a LayoutUnit to an integer once we switch to
FractionalLayoutUnits.
(WebCore::boundedMultiply): Method that will return the multiplied result of two LayoutUnits
or the max/min LayoutUnit if the result overflows. Only does a regular multiply while
LayoutUnits are integers instead of FractionalLayoutUnits.
(WebCore):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintContents): Rounding the paintOffset here didn't work for all
inline blocks. This rounding is actually only needed for InlineTextBoxes, so the logic has
been moved there.
(WebCore::RenderBlock::newLine): Use a LayoutUnit for the y position.
(WebCore::RenderBlock::isPointInOverflowControl): Points for hit testing need to be rounded.
(WebCore::RenderBlock::layoutColumns): Using boundedMultiply for a calculation prone to overflow.
(WebCore::updatePreferredWidth): Reverting back to using ceilf. ceiledLayoutUnit was to be ultimately
converted to just a straight LayoutUnit constructor to preserve precision. This precision doesn't work
for us here as we still paint Boxes/Blocks on pixel boundaries, so we need to expand to a pixel size
that encloses the contained text.
(WebCore::RenderBlock::setPageLogicalOffset): LogicalOffset should be a LayoutUnit.
(WebCore::RenderBlock::marginValuesForChild): Margins should have subpixel resolution.
(WebCore::RenderBlock::FloatingObjects::intervalForFloatingObject): Intervals for floating objects
need to use pixel snapped values to give the proper results.
* rendering/RenderBlock.h:
(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine): Only moved.
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine): While we can round the left offset,
columns add an extra offset at paint that can't currently be planned for at line-layout time. To
avoid laying out lines that run off the end of columns, we floor the right offset. The resulting
lines will be up to 1 pixel shorter than they potentially could be.
(RenderBlock):
(WebCore::RenderBlock::FloatingObject::pixelSnappedX): Using corresponding pixelSnappedX value from
LayoutRects.
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxX): Ditto.
(WebCore::RenderBlock::FloatingObject::pixelSnappedY): Ditto.
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxY): Ditto.
(WebCore::RenderBlock::FloatingObject::pixelSnappedWidth): Ditto.
(WebCore::RenderBlock::FloatingObject::pixelSnappedHeight): Ditto.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): LogicalHeight is a LayoutUnit. Also
flooring textIndentOffset to an integer to match old behavior.
(WebCore::LineWidth::fitBelowFloats): Using LayoutUnits for float logical top and bottoms.
(WebCore::LineLayoutState::endLineLogicalTop): Changing to a LayoutUnit.
(WebCore::LineLayoutState::setEndLineLogicalTop): Ditto.
(LineLayoutState): Ditto.
(WebCore::RenderBlock::linkToEndLineIfNeeded): Calculating overflow with LayoutUnits.
(WebCore::RenderBlock::layoutInlineChildren): LowestAllowedPosition should be subpixel.
(WebCore::RenderBlock::checkLinesForTextOverflow): Reverting ellipsis width calculation to integers
as this value can be seen as representing pixels on screen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Crash when going back from an xhtml document containing <img>
leo.yang@torchmobile.com.cn [Fri, 16 Mar 2012 10:39:51 +0000 (10:39 +0000)]
[BlackBerry] Crash when going back from an xhtml document containing <img>
https://bugs.webkit.org/show_bug.cgi?id=81297

Reviewed by Rob Buis.

This is manually reverting the offending internal commit which checked-in before upstreaming.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::canCachePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFollow up to: window.innerWidth/Height should not include page scale https://bugs...
kenneth@webkit.org [Fri, 16 Mar 2012 10:34:23 +0000 (10:34 +0000)]
Follow up to: window.innerWidth/Height should not include page scale https://bugs.webkit.org/show_bug.cgi?id=76555

Reviewed by Simon Hausmann.

Introduce mapping methods for converting between CSS and layout units.

* page/DOMWindow.cpp:
(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):
(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
(WebCore::DOMWindow::scrollTo):
* page/FrameView.h:
(FrameView):
(WebCore::FrameView::mapFromLayoutToCSSUnits):
(WebCore):
(WebCore::FrameView::mapFromCSSToLayoutUnits):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Threaded opacity animation jump to opacity of 0
commit-queue@webkit.org [Fri, 16 Mar 2012 10:29:34 +0000 (10:29 +0000)]
[chromium] Threaded opacity animation jump to opacity of 0
https://bugs.webkit.org/show_bug.cgi?id=80744

Patch by Ian Vollick <vollick@chromium.org> on 2012-03-16
Reviewed by James Robinson.

Source/WebCore:

Tested in CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::opacityIsAnimating):
(WebCore):
(WebCore::LayerChromium::transformIsAnimating):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
(WebCore::LayerChromium::drawOpacityIsAnimating):
(WebCore::LayerChromium::setDrawOpacityIsAnimating):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::drawOpacityIsAnimating):
(WebCore::RenderSurfaceChromium::setDrawOpacityIsAnimating):
(RenderSurfaceChromium):
* platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::isAnimatingProperty):
(WebCore):
* platform/graphics/chromium/cc/CCLayerAnimationController.h:
(CCLayerAnimationController):
* platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp:
(WebCore::CCLayerAnimationControllerImpl::isAnimatingProperty):
(WebCore):
* platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h:
(CCLayerAnimationControllerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::opacityIsAnimating):
(WebCore):
(WebCore::CCLayerImpl::transformIsAnimating):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
(WebCore::CCLayerImpl::drawOpacityIsAnimating):
(WebCore::CCLayerImpl::setDrawOpacityIsAnimating):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::layerShouldBeSkipped):
(WebCore::subtreeShouldBeSkipped):
(WebCore):
(WebCore::LayerChromium):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::CCRenderSurface):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore::CCRenderSurface::drawOpacityIsAnimating):
(WebCore::CCRenderSurface::setDrawOpacityIsAnimating):
(CCRenderSurface):

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(WTF):
(CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::beginTest):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::animateLayers):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::afterTest):
(WTF::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[TexMap] Reuse textures following the same rules as they do internally.
jocelyn.turcotte@nokia.com [Fri, 16 Mar 2012 10:21:49 +0000 (10:21 +0000)]
[TexMap] Reuse textures following the same rules as they do internally.
https://bugs.webkit.org/show_bug.cgi?id=80843

Reviewed by Noam Rosenthal.

BitmapTextures were recently changed to be the same size as their contents.
This would obsolete the logic in acquireTextureFromPool which would
assume that a BitmapTexture has good chances of being reused if its
size is bigger or equal to the new size.

This asks the texture instead if it can be reused which now simply
check for an exact size match.

* platform/graphics/texmap/TextureMapper.cpp:
(WebCore::TextureMapper::acquireTextureFromPool):
* platform/graphics/texmap/TextureMapper.h:
(WebCore::BitmapTexture::canReuseWith):
(WebCore::BitmapTexture::reset):
(WebCore::BitmapTexture::didReset):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::canReuseWith):
(WebCore):
* platform/graphics/texmap/TextureMapperGL.h:
(BitmapTextureGL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConnect up fling event delivery to gesture curve animation framework
commit-queue@webkit.org [Fri, 16 Mar 2012 10:20:02 +0000 (10:20 +0000)]
Connect up fling event delivery to gesture curve animation framework
https://bugs.webkit.org/show_bug.cgi?id=80858

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::fireUpAnAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, marking a failing test.
morrita@google.com [Fri, 16 Mar 2012 09:48:25 +0000 (09:48 +0000)]
Unreviewed gardening, marking a failing test.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove duplicate error() impls in CachedResource subclasses
japhet@chromium.org [Fri, 16 Mar 2012 09:40:53 +0000 (09:40 +0000)]
Remove duplicate error() impls in CachedResource subclasses
https://bugs.webkit.org/show_bug.cgi?id=81161

Reviewed by Alexey Proskuryakov.

No new tests, refactor only.

* loader/cache/CachedCSSStyleSheet.cpp:
* loader/cache/CachedCSSStyleSheet.h:
* loader/cache/CachedFont.cpp:
* loader/cache/CachedFont.h:
* loader/cache/CachedImage.cpp:
* loader/cache/CachedResource.h: Make checkNotify()
     virtual, so the right checkNotify() gets called in error().
* loader/cache/CachedScript.cpp:
* loader/cache/CachedScript.h:
* loader/cache/CachedXSLStyleSheet.cpp:
* loader/cache/CachedXSLStyleSheet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK baselines for new tests.
philn@webkit.org [Fri, 16 Mar 2012 09:28:13 +0000 (09:28 +0000)]
Unreviewed, GTK baselines for new tests.

* platform/gtk/compositing/overflow/ancestor-overflow-expected.txt: Added.
* platform/gtk/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
* platform/gtk/fast/line-grid/line-align-left-edges-expected.txt: Added.
* platform/gtk/fast/line-grid/line-align-right-edges-expected.txt: Added.
* platform/gtk/fast/repaint/transform-rotate-and-remove-expected.txt: Added.
* platform/gtk/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
* platform/gtk/fast/speech/input-appearance-speechbutton-expected.txt: Added.
* platform/gtk/fast/speech/speech-bidi-rendering-expected.txt: Added.
* platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
* platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
* platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
* platform/gtk/svg/custom/use-extern-href-expected.txt: Added.
* platform/gtk/svg/repaint/repainting-after-animation-element-removal-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK gardening.
philn@webkit.org [Fri, 16 Mar 2012 09:20:38 +0000 (09:20 +0000)]
Unreviewed, GTK gardening.

* platform/gtk/Skipped: Skip a new failing editing test
* platform/gtk/fast/events/resize-events-expected.txt: Added.
* platform/gtk/test_expectations.txt: Mark
inspector/styles/svg-style.xhtml as flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Changes to overdraw metrics to allow upload tracking
commit-queue@webkit.org [Fri, 16 Mar 2012 09:20:30 +0000 (09:20 +0000)]
[chromium] Changes to overdraw metrics to allow upload tracking
https://bugs.webkit.org/show_bug.cgi?id=81222

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Stick CCOverdrawMetrics into CCOcclusionTracker, so that it is available
everywhere that culling/drawing/painting is going on. Then we can stop
plumbing a metrics object through CCQuadCuller.

Rename the CCOverdrawMetrics "painting" stuff to "uploading" as this will
measure texture uploads rather than pixels painted in main memory.

Covered by existing tests.

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::CCOcclusionTrackerBase):
* platform/graphics/chromium/cc/CCOcclusionTracker.h:
(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::overdrawMetrics):
* platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:
(WebCore::CCOverdrawMetrics::didCull):
(WebCore):
(WebCore::CCOverdrawMetrics::didDraw):
(WebCore::CCOverdrawMetrics::recordMetrics):
(WebCore::CCOverdrawMetrics::recordMetricsInternal):
* platform/graphics/chromium/cc/CCOverdrawMetrics.h:
(WebCore):
(WebCore::CCOverdrawMetrics::create):
(CCOverdrawMetrics):
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::CCQuadCuller::append):
* platform/graphics/chromium/cc/CCQuadCuller.h:
(CCQuadCuller):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForLayer):
* platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore):
(CCRenderPass):

Source/WebKit/chromium:

* tests/CCQuadCullerTest.cpp:
(WebCore::appendQuads):
(WebCore):
(WebCore::TEST):
* tests/MockCCQuadCuller.h:
(WebCore::MockCCQuadCuller::MockCCQuadCuller):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd TransferList IDL modifier, with support in V8 code gen.
commit-queue@webkit.org [Fri, 16 Mar 2012 08:56:16 +0000 (08:56 +0000)]
Add TransferList IDL modifier, with support in V8 code gen.
https://bugs.webkit.org/show_bug.cgi?id=81127

Patch by Greg Billock <gbillock@google.com> on 2012-03-16
Reviewed by Adam Barth.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):
(GetIndexOf):
(GenerateParametersCheck):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateFunctionCallString):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
(WebDOMTestSerializedScriptValueInterface::acceptTransferList):
* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:
(WebDOMTestSerializedScriptValueInterface):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(webkit_dom_test_serialized_script_value_interface_accept_transfer_list):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::getOwnPropertyDescriptor):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(JSTestSerializedScriptValueInterfacePrototype):
(WebCore):
* bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
(-[DOMTestSerializedScriptValueInterface acceptTransferList:transferList:]):
* bindings/scripts/test/TestSerializedScriptValueInterface.idl:
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceInternal::acceptTransferListCallback):
(TestSerializedScriptValueInterfaceInternal):
(WebCore):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix. Do not preserve owner and group information when installing the WTF headers.
mrowe@apple.com [Fri, 16 Mar 2012 08:41:18 +0000 (08:41 +0000)]
Build fix. Do not preserve owner and group information when installing the WTF headers.

Source/JavaScriptCore:

* JavaScriptCore.xcodeproj/project.pbxproj:

Source/WTF:

* WTF.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Quads that become fully opaque after culling should not use blending
commit-queue@webkit.org [Fri, 16 Mar 2012 08:39:41 +0000 (08:39 +0000)]
[chromium] Quads that become fully opaque after culling should not use blending
https://bugs.webkit.org/show_bug.cgi?id=81235

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Unit test: CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers

* platform/graphics/chromium/cc/CCDrawQuad.h:
(WebCore::CCDrawQuad::needsBlending):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::BlendStateCheckLayer::appendQuads):
(WebKit::BlendStateCheckLayer::setQuadRect):
(WebKit::BlendStateCheckLayer::setQuadVisibleRect):
(WebKit::BlendStateCheckLayer::setOpaqueContents):
(WebKit::BlendStateCheckLayer::setOpaqueContentRect):
(WebKit::BlendStateCheckLayer::BlendStateCheckLayer):
(BlendStateCheckLayer):
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] viewportRect has changed to viewportSize
commit-queue@webkit.org [Fri, 16 Mar 2012 08:33:45 +0000 (08:33 +0000)]
[BlackBerry] viewportRect has changed to viewportSize
https://bugs.webkit.org/show_bug.cgi?id=81262

Patch by Genevieve Mak <gmak@rim.com> on 2012-03-16
Reviewed by Antonio Gomes.

Set size instead of rect in constructor.
* WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUsing ICU break iterator to simplify visual word movement implementation.
xji@chromium.org [Fri, 16 Mar 2012 08:27:28 +0000 (08:27 +0000)]
Using ICU break iterator to simplify visual word movement implementation.
https://bugs.webkit.org/show_bug.cgi?id=78856

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch relies on ICU word break iterator and cursor visual movement by character to get the word break
position in visual order. It reduces the complexity of old implementation.

Test: editing/selection/move-by-word-visually-wrong-left-right.html

* editing/FrameSelection.cpp: Exclude WinCE from visual word movement since isWordTextBreak is not implemented.
(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingLeft):
* editing/visible_units.cpp:
(WebCore):
(WebCore::previousLeafWithSameEditability): Just moving to the top without functionality change.
(WebCore::enclosingNodeWithNonInlineRenderer): ditto.
(WebCore::nextLeafWithSameEditability): ditto.
(WebCore::previousRootInlineBox): return previous RootInlineBox which is in different renderer.
(WebCore::nextRootInlineBox): return next RootInlineBox which is in different renderer.
(WebCore::boxIndexInVector):
(WebCore::previousBoxInLine): returns logically previous box in one line.
(WebCore::logicallyPreviousBox): returns logically previous box.
(WebCore::nextBoxInLine): returns logically next box in one line.
(WebCore::logicallyNextBox): returns logically next box.
(WebCore::wordBreakIteratorForMinOffsetBoundary): create word break iterator for position that is a box's min offset.
(WebCore::wordBreakIteratorForMaxOffsetBoundary): create word break iterator for position that is a box's max offset.
(WebCore::isLogicalStartOfWord): return whether a position is logically start of word.
(WebCore::islogicalEndOfWord): return whether a position is logically end of word.
(WebCore::visualWordPosition): returns the visual left or right word position.
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):
* platform/text/TextBreakIterator.h: Add isWordTextBreak().
(WebCore):
* platform/text/TextBreakIteratorICU.cpp:
(WebCore::isWordTextBreak):
(WebCore):
* platform/text/gtk/TextBreakIteratorGtk.cpp:
(WebCore::isWordTextBreak):
(WebCore):
* platform/text/qt/TextBreakIteratorQt.cpp:
(WebCore::isWordTextBreak):
(WebCore):
* platform/text/wince/TextBreakIteratorWinCE.cpp:
(WebCore::isWordTextBreak):
(WebCore):

LayoutTests:

* editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt:
* editing/selection/move-by-word-visually-inline-block-positioned-element.html:
  The word break stops at the beginning of fixed positioned element, which is correct and consistent behavior.

* editing/selection/move-by-word-visually-multi-line-expected.txt:
* editing/selection/move-by-word-visually-multi-line.html:
  The word break does not stop at the end of a text if there is next line of text available under the same
  editable root, which is a consistent behavior cross the board.
  Add more test cases, including one with non InlineTextBox.

* editing/selection/move-by-word-visually-single-space-inline-element-expected.txt:
  Fixing of previously missing or extra word break positions.

* editing/selection/move-by-word-visually-single-space-one-element-expected.txt:
* editing/selection/move-by-word-visually-single-space-one-element.html:
  Add a test case including bidi control character which renders wrong result since right-arrow could not reach
  a position which is the word break position.
  Add another test case containing non InlineTextBox.

* editing/selection/move-by-word-visually-wrong-left-right-expected.txt: Added.
* editing/selection/move-by-word-visually-wrong-left-right.html: Added.
  Add a test case which renders wrong result due to left/right-arrow returns wrong result.

* editing/selection/resources/move-by-word-visually.js:
(moveByWordOnEveryChar): Handle a special case when left/right arrow missing certain position.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Don't create a quad for video layers without a frame (avoid use of uniniti...
commit-queue@webkit.org [Fri, 16 Mar 2012 08:20:04 +0000 (08:20 +0000)]
[chromium] Don't create a quad for video layers without a frame (avoid use of uninitialized m_format)
https://bugs.webkit.org/show_bug.cgi?id=81250

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-16
Reviewed by James Robinson.

* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Enable PAGE_VISIBILITY_API
commit-queue@webkit.org [Fri, 16 Mar 2012 08:19:28 +0000 (08:19 +0000)]
[BlackBerry] Enable PAGE_VISIBILITY_API
https://bugs.webkit.org/show_bug.cgi?id=81257

Source/WebKit/blackberry:

Set Page visibility state for BlackBerry port.

Patch by Andrew Lo <anlo@rim.com> on 2012-03-16
Reviewed by Rob Buis.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::setPageVisibilityState):
(BlackBerry::WebKit::WebPagePrivate::setVisible):
(BlackBerry::WebKit::WebPage::setVisible):
(BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
(BlackBerry::WebKit::WebPage::notifyAppActivationStateChange):
* Api/WebPage_p.h:
(WebPagePrivate):

Tools:

Enable Page Visibility API for BlackBerry.

Patch by Andrew Lo <anlo@rim.com> on 2012-03-16
Reviewed by Rob Buis.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed attempt to fix Chromium windows build.
morrita@google.com [Fri, 16 Mar 2012 08:12:44 +0000 (08:12 +0000)]
Unreviewed attempt to fix Chromium windows build.

* Modules/speech/SpeechRecognition.h:
(SpeechRecognition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agomake test for rebaselining after skia 3398 lands
reed@google.com [Fri, 16 Mar 2012 08:11:10 +0000 (08:11 +0000)]
make test for rebaselining after skia 3398 lands
https://bugs.webkit.org/show_bug.cgi?id=81246

Unreviewed. expectations only

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
commit-queue@webkit.org [Fri, 16 Mar 2012 08:00:22 +0000 (08:00 +0000)]
[Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
https://bugs.webkit.org/show_bug.cgi?id=81232

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-03-16
Reviewed by Philippe Normand.

Source/WebKit/gtk:

Add computedStyleIncludingVisitedInfo helper method to
DumpRenderTreeSupportGtk.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::computedStyleIncludingVisitedInfo):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Tools:

Use the newly-added helper method in DumpRenderTreeSupportGtk.

* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::computedStyleIncludingVisitedInfo):

LayoutTests:

Unskip now-passing tests.

* platform/gtk/Skipped:
* platform/gtk/fast/history/nested-visited-test-expected.txt: Removed.
* platform/gtk/fast/history/self-is-visited-expected.txt: Removed.
* platform/gtk/fast/history/sibling-visited-test-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Gtk] Properly set forms tests-specific settings
commit-queue@webkit.org [Fri, 16 Mar 2012 07:57:34 +0000 (07:57 +0000)]
[Gtk] Properly set forms tests-specific settings
https://bugs.webkit.org/show_bug.cgi?id=81237

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-03-16
Reviewed by Philippe Normand.

Source/WebKit/gtk:

Call Settings::setInteractiveFormValidationEnabled and
Settings::setValidationMessageTimerMagnification with
proper values when in testing mode.

* webkit/webkitwebview.cpp:
(webkit_web_view_init):

LayoutTests:

Unskip newly-passing tests.

* platform/gtk/Skipped:
* platform/gtk/fast/forms/validation-message-appearance-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed expectations update.
morrita@google.com [Fri, 16 Mar 2012 07:44:22 +0000 (07:44 +0000)]
Unreviewed expectations update.

* platform/chromium-linux/fast/events/resize-events-expected.png: Added.
* platform/chromium-mac-leopard/fast/events/resize-events-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/events/resize-events-expected.png: Added.
* platform/chromium-mac/fast/events/resize-events-expected.png: Added.
* platform/chromium-mac/fast/events/resize-events-expected.txt: Added.
* platform/chromium-win/fast/events/resize-events-expected.png: Added.
* platform/chromium-win/fast/events/resize-events-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove DOMWindowFileSystem to Modules/filesystem/
commit-queue@webkit.org [Fri, 16 Mar 2012 07:44:10 +0000 (07:44 +0000)]
Move DOMWindowFileSystem to Modules/filesystem/
https://bugs.webkit.org/show_bug.cgi?id=81030

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Modules/filesystem/DOMWindowFileSystem.cpp: Copied from Source/WebCore/fileapi/DOMWindowFileSystem.cpp.
* Modules/filesystem/DOMWindowFileSystem.h: Copied from Source/WebCore/fileapi/DOMWindowFileSystem.h.
* Modules/filesystem/DOMWindowFileSystem.idl: Copied from Source/WebCore/fileapi/DOMWindowFileSystem.idl.
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreCommon.vsprops:
* WebCore.vcproj/copyForwardingHeaders.cmd:
* fileapi/DOMWindowFileSystem.cpp: Removed.
* fileapi/DOMWindowFileSystem.h: Removed.
* fileapi/DOMWindowFileSystem.idl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r110951.
commit-queue@webkit.org [Fri, 16 Mar 2012 07:34:51 +0000 (07:34 +0000)]
Unreviewed, rolling out r110951.
http://trac.webkit.org/changeset/110951
https://bugs.webkit.org/show_bug.cgi?id=81316

Does not build on apple-mac (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-16

Source/WebCore:

* platform/audio/DynamicsCompressor.h:
(DynamicsCompressor):
* webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::process):
* webaudio/DynamicsCompressorNode.h:
(DynamicsCompressorNode):
* webaudio/DynamicsCompressorNode.idl:

LayoutTests:

* webaudio/dynamicscompressor-basic-expected.txt:
* webaudio/dynamicscompressor-basic.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoto be rebaselined after hairline clipping fix in skia lands
reed@google.com [Fri, 16 Mar 2012 07:31:44 +0000 (07:31 +0000)]
to be rebaselined after hairline clipping fix in skia lands
https://bugs.webkit.org/show_bug.cgi?id=81233

Unreviewed. expectations change only

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCleanup empty attribute list in IDLs
commit-queue@webkit.org [Fri, 16 Mar 2012 07:17:06 +0000 (07:17 +0000)]
Cleanup empty attribute list in IDLs
https://bugs.webkit.org/show_bug.cgi?id=81228

Patch by Seo Sanghyeon <sh4.seo@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

No tests. No change in behavior.

* css/WebKitCSSRegionRule.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoonorientationchange event should have JSWindowEventListener attribute
psolanki@apple.com [Fri, 16 Mar 2012 07:05:14 +0000 (07:05 +0000)]
onorientationchange event should have JSWindowEventListener attribute
https://bugs.webkit.org/show_bug.cgi?id=79513

Reviewed by Kentaro Hara.

* html/HTMLFrameSetElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExpose attack, release as DynamicsCompressorNode's attributes.
commit-queue@webkit.org [Fri, 16 Mar 2012 06:56:11 +0000 (06:56 +0000)]
Expose attack, release as DynamicsCompressorNode's attributes.
https://bugs.webkit.org/show_bug.cgi?id=81221

Patch by Gao Chun <chun.gao@intel.com> on 2012-03-15
Reviewed by Chris Rogers.

Source/WebCore:

Test: webaudio/dynamicscompressor-basic.html

* platform/audio/DynamicsCompressor.h:
(DynamicsCompressor):
* webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::process):
* webaudio/DynamicsCompressorNode.h:
(WebCore::DynamicsCompressorNode::attack):
(WebCore::DynamicsCompressorNode::release):
(DynamicsCompressorNode):
* webaudio/DynamicsCompressorNode.idl:

LayoutTests:

* webaudio/dynamicscompressor-basic-expected.txt:
* webaudio/dynamicscompressor-basic.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpeech JavaScript API: SpeechRecognition, Controller and Client
hans@chromium.org [Fri, 16 Mar 2012 06:35:17 +0000 (06:35 +0000)]
Speech JavaScript API: SpeechRecognition, Controller and Client
https://bugs.webkit.org/show_bug.cgi?id=81096

Reviewed by Adam Barth.

Source/WebCore:

Add implementation stub for SpeechRecognition. Add the
SpeechRecognitionController class and SpeechRecognitionClient
interface.

Test: fast/speech/scripted/basics.html

* Modules/speech/DOMWindowSpeech.idl:
* Modules/speech/SpeechRecognition.cpp: Added.
(WebCore):
(WebCore::SpeechRecognition::create):
(WebCore::SpeechRecognition::start):
(WebCore::SpeechRecognition::stopFunction):
(WebCore::SpeechRecognition::abort):
(WebCore::SpeechRecognition::audioStartCallback):
(WebCore::SpeechRecognition::soundStartCallback):
(WebCore::SpeechRecognition::speechStartCallback):
(WebCore::SpeechRecognition::speechEndCallback):
(WebCore::SpeechRecognition::audioEndCallback):
(WebCore::SpeechRecognition::resultCallback):
(WebCore::SpeechRecognition::noMatchCallback):
(WebCore::SpeechRecognition::resultDeletedCallback):
(WebCore::SpeechRecognition::errorCallback):
(WebCore::SpeechRecognition::startCallback):
(WebCore::SpeechRecognition::endCallback):
(WebCore::SpeechRecognition::interfaceName):
(WebCore::SpeechRecognition::scriptExecutionContext):
(WebCore::SpeechRecognition::SpeechRecognition):
(WebCore::SpeechRecognition::~SpeechRecognition):
* Modules/speech/SpeechRecognition.h: Added.
(WebCore):
(SpeechRecognition):
(WebCore::SpeechRecognition::grammars):
(WebCore::SpeechRecognition::setGrammars):
(WebCore::SpeechRecognition::lang):
(WebCore::SpeechRecognition::setLang):
(WebCore::SpeechRecognition::continuous):
(WebCore::SpeechRecognition::setContinuous):
* Modules/speech/SpeechRecognition.idl:
* Modules/speech/SpeechRecognitionClient.h:
(WebCore):
(SpeechRecognitionClient):
(WebCore::SpeechRecognitionClient::~SpeechRecognitionClient):
* Modules/speech/SpeechRecognitionController.cpp:
(WebCore):
(WebCore::SpeechRecognitionController::supplementName):
(WebCore::SpeechRecognitionController::SpeechRecognitionController):
(WebCore::SpeechRecognitionController::~SpeechRecognitionController):
(WebCore::SpeechRecognitionController::create):
(WebCore::provideSpeechRecognitionTo):
* Modules/speech/SpeechRecognitionController.h: Added.
(WebCore):
(SpeechRecognitionController):
(WebCore::SpeechRecognitionController::start):
(WebCore::SpeechRecognitionController::stop):
(WebCore::SpeechRecognitionController::abort):
(WebCore::SpeechRecognitionController::visibilityHidden):
(WebCore::SpeechRecognitionController::unregisterSpeechRecognition):
(WebCore::SpeechRecognitionController::from):
* WebCore.gypi:
* dom/EventTargetFactory.in:

Source/WebKit/chromium:

Provide a SpeechRecognitionController to Page, with a NULL client for
now.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):

LayoutTests:

Add tests for the basics of the SpeechRecognition interface.

* fast/speech/scripted/basics-expected.txt: Added.
* fast/speech/scripted/basics.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Fix some assertions in occlusion tracker unit tests
morrita@google.com [Fri, 16 Mar 2012 06:18:45 +0000 (06:18 +0000)]
[chromium] Fix some assertions in occlusion tracker unit tests
https://bugs.webkit.org/show_bug.cgi?id=81308

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-15
Reviewed by James Robinson.

* tests/CCOcclusionTrackerTest.cpp:
(WebCore::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(WebCore::CCOcclusionTrackerTestDamageRectOutsideChild::runMyTest):
(WebCore::CCOcclusionTrackerTest3dTransform::runMyTest):
(WebCore::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove parse_bug_id into config/urls in preparation for re-use elsewhere.
eric@webkit.org [Fri, 16 Mar 2012 06:18:37 +0000 (06:18 +0000)]
Move parse_bug_id into config/urls in preparation for re-use elsewhere.
https://bugs.webkit.org/show_bug.cgi?id=81313

Reviewed by Adam Barth.

* Scripts/webkitpy/common/checkout/changelog.py:
(parse_bug_id_from_changelog):
* Scripts/webkitpy/common/config/urls.py:
(parse_bug_id):
* Scripts/webkitpy/common/config/urls_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/urls.py.
(URLsTest):
(URLsTest.test_parse_bug_id):
* Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
(test_parse_bug_id):
* Scripts/webkitpy/tool/bot/irc_command.py:
(_post_error_and_check_for_bug_url):
* Scripts/webkitpy/tool/bot/sheriff.py:
(Sheriff.post_rollout_patch):
(Sheriff.post_chromium_deps_roll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate the expectation of labelable-elements.html.
tkent@chromium.org [Fri, 16 Mar 2012 06:09:18 +0000 (06:09 +0000)]
Update the expectation of labelable-elements.html.

The expectation in the common place should be one for platforms with
ENABLE_DATALIST, was for platform without ENABLE_DATALIST.
https://bugs.webkit.org/show_bug.cgi?id=80985

* fast/forms/label/labelable-elements-expected.txt:
* platform/gtk/Skipped:
* platform/mac/fast/forms/label/labelable-elements-expected.txt: Removed.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Sets alpha channel for new buffers.
commit-queue@webkit.org [Fri, 16 Mar 2012 05:50:50 +0000 (05:50 +0000)]
[EFL] Sets alpha channel for new buffers.
https://bugs.webkit.org/show_bug.cgi?id=77101

Patch by Michal Ciepielski <m.ciepielski@samsung.com> on 2012-03-15
Reviewed by Hajime Morita.

No new tests.

By default EFL creates buffers without alpha channel.
This causes improper rendering of HTML controls (i.e. radio buttons, checkboxes).
This commits sets alpha channel for all newly created buffers by EFL.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::cacheThemePartNew):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r110941.
commit-queue@webkit.org [Fri, 16 Mar 2012 05:47:44 +0000 (05:47 +0000)]
Unreviewed, rolling out r110941.
http://trac.webkit.org/changeset/110941
https://bugs.webkit.org/show_bug.cgi?id=81307

the revert looks innocent. (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-15

Source/WebCore:

* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::idlePaintContentsIfDirty):
* platform/graphics/chromium/ContentLayerChromium.h:
(WebCore):
(ContentLayerChromium):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/ImageLayerChromium.h:
(WebCore):
(ImageLayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::paintContentsIfDirty):
(WebCore::LayerChromium::idlePaintContentsIfDirty):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):
* platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/WebGLLayerChromium.h:
(WebGLLayerChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
(WTF::ContentLayerChromiumWithUpdateTracking::idlePaintContentsIfDirty):
(WTF::TestLayerChromium::paintContentsIfDirty):
* tests/Canvas2DLayerChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:
(TestCCOcclusionTracker):
(WTF::TestCCOcclusionTracker::TestCCOcclusionTracker):
(WTF::TestCCOcclusionTracker::setOcclusion):
(WTF::TestCCOcclusionTracker::layerScissorRectInTargetSurface):
(WTF):
(WTF::FakeTiledLayerChromium::prepareToUpdate):
(WTF::FakeTiledLayerChromium::prepareToUpdateIdle):
(WTF::FakeTiledLayerChromium::paintContentsIfDirty):
(WTF::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe commit-queue should fast-track patches that have already passed the testing EWS...
abarth@webkit.org [Fri, 16 Mar 2012 04:20:07 +0000 (04:20 +0000)]
The commit-queue should fast-track patches that have already passed the testing EWS bots
https://bugs.webkit.org/show_bug.cgi?id=81305

Reviewed by Eric Seidel.

If a patch has already passed the testing EWS bots (currently only the
chromium-ews bot), we should be able to land the patch without running
the tests again.  This patch is somewhat risky in that the tests might
have been broken between when the EWS bots ran and when the
commit-queue is processing the patch.  If that turns out to be a
problem in practice, we'll tighten up this fast-track in some way,
likely by making sure that the pass status is recent.

* Scripts/webkitpy/tool/bot/commitqueuetask.py:
(CommitQueueTaskDelegate.did_pass_testing_ews):
(CommitQueueTask._did_pass_tests_recently):
(CommitQueueTask.run):
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(MockCommitQueue.did_pass_testing_ews):
(test_fast_success_case):
* Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue.did_pass_testing_ews):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(test_did_pass_testing_ews):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API (JSEP): Introducing SessionDescription
tommyw@google.com [Fri, 16 Mar 2012 04:19:05 +0000 (04:19 +0000)]
MediaStream API (JSEP): Introducing SessionDescription
https://bugs.webkit.org/show_bug.cgi?id=81206

Reviewed by Adam Barth.

Patch #3 in a series of patches to change the PeerConnection from ROAP to JSEP,
see bug 80589 for more information.
Adding the SessionDescription JS object and its platform counterpart SessionDescriptionDescriptor.

Not possible to test until the entire JSEP feature is commited.

* GNUmakefile.list.am:
* Modules/mediastream/SessionDescription.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.
(WebCore):
(WebCore::SessionDescription::create):
(WebCore::SessionDescription::SessionDescription):
(WebCore::SessionDescription::~SessionDescription):
(WebCore::SessionDescription::addCandidate):
(WebCore::SessionDescription::toSdp):
(WebCore::SessionDescription::descriptor):
* Modules/mediastream/SessionDescription.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.
(WebCore):
(SessionDescription):
* Modules/mediastream/SessionDescription.idl: Added.
* WebCore.gypi:
* platform/mediastream/MediaStreamCenter.cpp:
(WebCore::MediaStreamCenter::constructSdp):
(WebCore):
* platform/mediastream/MediaStreamCenter.h:
(WebCore):
(MediaStreamCenter):
* platform/mediastream/SessionDescriptionDescriptor.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.
(WebCore):
(WebCore::SessionDescriptionDescriptor::create):
(WebCore::SessionDescriptionDescriptor::SessionDescriptionDescriptor):
(WebCore::SessionDescriptionDescriptor::~SessionDescriptionDescriptor):
(WebCore::SessionDescriptionDescriptor::addCandidate):
(WebCore::SessionDescriptionDescriptor::toSdp):
(WebCore::SessionDescriptionDescriptor::numberOfAddedCandidates):
(WebCore::SessionDescriptionDescriptor::candidate):
(WebCore::SessionDescriptionDescriptor::initialSdp):
* platform/mediastream/SessionDescriptionDescriptor.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.
(WebCore):
(SessionDescriptionDescriptor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVersioning.
lforschler@apple.com [Fri, 16 Mar 2012 04:13:56 +0000 (04:13 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r110929.
commit-queue@webkit.org [Fri, 16 Mar 2012 04:07:16 +0000 (04:07 +0000)]
Unreviewed, rolling out r110929.
http://trac.webkit.org/changeset/110929
https://bugs.webkit.org/show_bug.cgi?id=81306

breaking webkit_unit_tests (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-15

Source/WebCore:

* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::idlePaintContentsIfDirty):
* platform/graphics/chromium/ContentLayerChromium.h:
(WebCore):
(ContentLayerChromium):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/ImageLayerChromium.h:
(WebCore):
(ImageLayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::paintContentsIfDirty):
(WebCore::LayerChromium::idlePaintContentsIfDirty):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore):
(WebCore::contentToLayerTransform):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):
* platform/graphics/chromium/TiledLayerChromium.h:
(WebCore):
(TiledLayerChromium):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/WebGLLayerChromium.h:
(WebGLLayerChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
(WTF::ContentLayerChromiumWithUpdateTracking::idlePaintContentsIfDirty):
(WTF::TestLayerChromium::paintContentsIfDirty):
* tests/Canvas2DLayerChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:
(WTF::FakeTiledLayerChromium::prepareToUpdate):
(WTF::FakeTiledLayerChromium::prepareToUpdateIdle):
(WTF::FakeTiledLayerChromium::paintContentsIfDirty):
(WTF::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110941 268f45cc-cd09-0410-ab3c-d52691b4dbfc