WebKit-https.git
7 years agorun-perf-tests should generate a results page
rniwa@webkit.org [Sun, 29 Jul 2012 22:03:35 +0000 (22:03 +0000)]
run-perf-tests should generate a results page
https://bugs.webkit.org/show_bug.cgi?id=92575

Reviewed by Eric Seidel.

PerformanceTests:

Add a results page template. This page includes flot and flot.fillbetween.
jQuery and the json that contains test results are injected by run-perf-tests.

* resources/results-template.html: Added.

Tools:

Added the ability to generate a results page that summarizes performance test results from
multiple runs of run-perf-tests when --output-json-path is specified and --test-results-server
is not specified. We cannot generate a results page when --test-results-server is specified
because perf-o-matic cannot parse the new JSON format.

The new JSON format is simply an array of the old JSON output. This JSON is then merged into
results-template.html along with jQuery and copied as a HTML file of the same filename as
the output JSON file with a .html extension.

We merge all scripts and the JSON output into the results page as opposed to including them
with the src content attribute to make it standalone so that we may post it on Bugzilla or
e-mail it to someone else without breaking it.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.run):
(PerfTestsRunner._generate_json): Merge "contents" with the existing JSON file when generating
a results page, and generate the results page from results-template.html merged with jQuery and
the generated JSON output.
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(_test_run_with_json_output): Extracted from test_run_with_upload_json to be shared with
several test cases.
(_test_run_with_json_output.mock_upload_json): Ditto.
(test_run_with_json_output): Refactored to use _test_run_with_json_output.
(test_run_generates_results_page): Added. Tests the new feature.
(test_run_with_json_source): Refactored to use _test_run_with_json_output.
(test_run_with_multiple_repositories): Ditto.
(test_run_with_upload_json): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago.: Add ENABLE_CSS_COMPOSITING flag
commit-queue@webkit.org [Sun, 29 Jul 2012 21:59:53 +0000 (21:59 +0000)]
.: Add ENABLE_CSS_COMPOSITING flag
https://bugs.webkit.org/show_bug.cgi?id=92553

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-07-29
Reviewed by Dirk Schulze.

Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:
* configure.ac:

Source/JavaScriptCore: Add ENABLE_CSS_COMPOSITING flag
https://bugs.webkit.org/show_bug.cgi?id=92553

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-07-29
Reviewed by Dirk Schulze.

Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html

* Configurations/FeatureDefines.xcconfig:

Source/WebCore: ENABLE_CSS_COMPOSITING flag
https://bugs.webkit.org/show_bug.cgi?id=92553

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-07-29
Reviewed by Dirk Schulze.

Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html

* GNUmakefile.am:
* Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium: Add ENABLE_CSS_COMPOSITING flag
https://bugs.webkit.org/show_bug.cgi?id=92553

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-07-29
Reviewed by Dirk Schulze.

Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html

* features.gypi:

Source/WebKit/mac: Add ENABLE_CSS_COMPOSITING flag
https://bugs.webkit.org/show_bug.cgi?id=92553

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-07-29
Reviewed by Dirk Schulze.

Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html

* Configurations/FeatureDefines.xcconfig:

Tools: Add ENABLE_CSS_COMPOSITING flag
https://bugs.webkit.org/show_bug.cgi?id=92553

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-07-29
Reviewed by Dirk Schulze.

Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html

* Scripts/webkitperl/FeatureList.pm:

WebKitLibraries: Add ENABLE_CSS_COMPOSITING flag
https://bugs.webkit.org/show_bug.cgi?id=92553

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-07-29
Reviewed by Dirk Schulze.

Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake] Use WEBKIT_CREATE_FORWARDING_HEADERS to generate WK2 forwarding headers
paroga@webkit.org [Sun, 29 Jul 2012 21:46:26 +0000 (21:46 +0000)]
[CMake] Use WEBKIT_CREATE_FORWARDING_HEADERS to generate WK2 forwarding headers
https://bugs.webkit.org/show_bug.cgi?id=83579

Reviewed by Daniel Bates.

Using a list of directories in combination with the WEBKIT_CREATE_FORWARDING_HEADERS
macro allows us to share the common generation of forwarding headers across ports.

* CMakeLists.txt:
* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WIN] Add missing export macro to friend decleration.
paroga@webkit.org [Sun, 29 Jul 2012 21:02:59 +0000 (21:02 +0000)]
[WIN] Add missing export macro to friend decleration.

Since the __declspec is part of the function signature
on windows, we need it at all friend declerations too.

* wtf/MediaTime.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake] Add missing MediaTime files after r123878.
paroga@webkit.org [Sun, 29 Jul 2012 21:02:18 +0000 (21:02 +0000)]
[CMake] Add missing MediaTime files after r123878.

* wtf/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIn flipped blocks, a point on the top edge of a box is considered outside the box...
mitz@apple.com [Sun, 29 Jul 2012 17:27:35 +0000 (17:27 +0000)]
In flipped blocks, a point on the top edge of a box is considered outside the box (and vice versa)
https://bugs.webkit.org/show_bug.cgi?id=92593

Reviewed by Simon Fraser.

Source/WebCore:

With respect to hit testing, boxes should always behave as half-open intervals which include
the physical top and left edges and not the bottom and right edges.
RenderBlock::positionForPoint was not adhering to this, since it was comparing flipped
coordinates.

Tests: fast/writing-mode/flipped-blocks-hit-test-box-edges.html
       fast/writing-mode/flipped-blocks-hit-test-line-edges.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren): When blocks are flipped, changed
strict inequalities of y coordinates into non-strict ones and non-strict inequalities into
strict ones.
(WebCore::RenderBlock::positionForPoint): Ditto, except for the test for being under the top
of the last candidate box, which was made non-strict in the unflipped case and remained
strict.

LayoutTests:

* fast/writing-mode/flipped-blocks-hit-test-box-edges-expected.txt: Added.
* fast/writing-mode/flipped-blocks-hit-test-box-edges.html: Added.
* fast/writing-mode/flipped-blocks-hit-test-line-edges-expected.txt: Added.
* fast/writing-mode/flipped-blocks-hit-test-line-edges.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReviewed by Martin Robinson.
kov@webkit.org [Sun, 29 Jul 2012 14:49:07 +0000 (14:49 +0000)]
Reviewed by Martin Robinson.

Make the jhbuild wrapper scripts become the jhbuild process
instead of starting it as a child. This should make it possible to
interrupt execution of jhbuild cleanly.

* gtk/run-with-jhbuild:
* jhbuild/jhbuild-wrapper:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExtend `application/x-webkit-test-netscape` plugins to better support multiple frames.
commit-queue@webkit.org [Sun, 29 Jul 2012 09:49:14 +0000 (09:49 +0000)]
Extend `application/x-webkit-test-netscape` plugins to better support multiple frames.
https://bugs.webkit.org/show_bug.cgi?id=92478

Patch by Mike West <mkwst@chromium.org> on 2012-07-29
Reviewed by Adam Barth.

Tools:

DumpRenderTree currently understands
`<object src="data:application/x-webkit-test-netscape,alertwhenloaded">`.
It would be useful if it understood `logifloaded`, which could give
more context regarding test expectations, and can be written in such
as way as to support plugins loaded into multiple iframes in a single
test.

* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New):
    Adding support for `logifloaded`.

LayoutTests:

* http/tests/plugins/resources/mock-plugin-logger.js:
    Exciting JS "framework" for use when logging via `logifloaded`.
* http/tests/security/contentSecurityPolicy/object-src-none-allowed.html:
* http/tests/security/contentSecurityPolicy/object-src-none-allowed-expected.html:
* http/tests/security/contentSecurityPolicy/object-src-none-blocked.html:
* http/tests/security/contentSecurityPolicy/object-src-none-blocked-expected.html:
    Adjusting these tests to use the newly created `logifloaded` plugin mock.
* http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl:
    Loading `mock-plugin-logger.js`, and adding a `log` attribute for `logifloaded`.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: RenderBlock::offsetForContents() is wrong in flipped blocks writing...
mitz@apple.com [Sun, 29 Jul 2012 04:59:30 +0000 (04:59 +0000)]
Source/WebCore: RenderBlock::offsetForContents() is wrong in flipped blocks writing modes
https://bugs.webkit.org/show_bug.cgi?id=92588

Reviewed by Sam Weinig.

Tests: fast/multicol/hit-test-block-axis-flipped.html
       fast/writing-mode/flipped-blocks-hit-test-overflow-scroll.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::offsetForContents): Flip the point, which puts it back in unflipped
coordinates, before adding the scroll offset and adjusting for columns, then flip it back.
(WebCore::RenderBlock::adjustPointToColumnContents): Changed the inline-axis cases to
work with an unflipped point.

LayoutTests: Hit test results are wrong in flipped blocks writing modes with block column axis
https://bugs.webkit.org/show_bug.cgi?id=92588

Reviewed by Sam Weinig.

* fast/multicol/hit-test-block-axis-flipped-expected.txt: Added.
* fast/multicol/hit-test-block-axis-flipped.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStop copying unnecessary files in WebKit2 build
weinig@apple.com [Sun, 29 Jul 2012 03:38:11 +0000 (03:38 +0000)]
Stop copying unnecessary files in WebKit2 build
https://bugs.webkit.org/show_bug.cgi?id=92587

Reviewed by Dan Bernstein.

* WebKit2.xcodeproj/project.pbxproj:
We were accidentally copying ColorSpaceData.h and EventDispatcher.messages.in into the
build products. Stop this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] New baselines and test expectations update.
pkasting@chromium.org [Sun, 29 Jul 2012 01:35:02 +0000 (01:35 +0000)]
[Chromium] New baselines and test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=72039
https://bugs.webkit.org/show_bug.cgi?id=92569
https://bugs.webkit.org/show_bug.cgi?id=92583

Unreviewed, test expectations update.

* platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Added.
* platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Added.
* platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Added.
* platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Added.
* platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Added.
* platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Added.
* platform/chromium-mac-snowleopard/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Added.
* platform/chromium-mac/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Added.
* platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Added.
* platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Added.
* platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Added.
* platform/chromium-win/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Added.
* platform/chromium-win/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Added.
* platform/chromium-win/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][EFL] Add ewk_view_scale_{get|set} to EwkView.
ryuan.choi@samsung.com [Sat, 28 Jul 2012 23:28:17 +0000 (23:28 +0000)]
[WK2][EFL] Add ewk_view_scale_{get|set} to EwkView.
https://bugs.webkit.org/show_bug.cgi?id=92446

Reviewed by Kenneth Rohde Christiansen.

Add methods to Ewk_View to get or set the scale factor of page.

* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_scale_set):
(ewk_view_scale_get):
* UIProcess/API/efl/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIn flipped lines writing modes, hit testing at the beginning of a column may return...
mitz@apple.com [Sat, 28 Jul 2012 21:40:48 +0000 (21:40 +0000)]
In flipped lines writing modes, hit testing at the beginning of a column may return a result from the previous column
https://bugs.webkit.org/show_bug.cgi?id=92566

Reviewed by Simon Fraser.

Source/WebCore:

Enhanced the fix for <http://webkit.org/b/92524> to work with flipped lines.

Extended fast/multicol/hit-test-end-of-column-with-line-height.html.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren): For flipped lines, check if the
hit line is the last one before a page break, and in that case, check if the hit point was
after the break.

LayoutTests:

* fast/multicol/hit-test-end-of-column-with-line-height-expected.txt: Updated.
* fast/multicol/hit-test-end-of-column-with-line-height.html: Extended with tests for
horizontal-bt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSize changes on a layer with negative z-index children don't repaint correctly
simon.fraser@apple.com [Sat, 28 Jul 2012 21:32:02 +0000 (21:32 +0000)]
Size changes on a layer with negative z-index children don't repaint correctly
https://bugs.webkit.org/show_bug.cgi?id=92583

Reviewed by Dean Jackson.

Source/WebCore:

Negative z-index descendants cause a composited layer to have a separate
layer for foreground content. If something caused that foreground layer
to change size (like toggling visibility on a descendant), we failed to
repaint the foreground layer, resulting in stretched content.

Test: compositing/geometry/bounds-ignores-hidden-dynamic-negzindex.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Repaint the foreground
layer if its size changes, like we do for the main layer.

LayoutTests:

Test that causes a composited layer with a foreground layer (by virtue of having
negative z-index children) to resize.

Add missing pixel result for bounds-ignores-hidden-dynamic.html too.

* compositing/geometry/bounds-ignores-hidden-dynamic-expected.png: Added.
* compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Added.
* compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Added.
* compositing/geometry/bounds-ignores-hidden-dynamic-negzindex.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIgnore visibility:hidden elements when computing compositing layer bounds
simon.fraser@apple.com [Sat, 28 Jul 2012 19:44:23 +0000 (19:44 +0000)]
Ignore visibility:hidden elements when computing compositing layer bounds
https://bugs.webkit.org/show_bug.cgi?id=92569

Reviewed by Dan Bernstein.

Source/WebCore:

When computing the bounds of compositing layers, we would take into account
layers with no visible content (visibility:hidden, and no non-hidden descendants).
This caused some huge layers in mobile Google maps.

Tests: compositing/geometry/bounds-ignores-hidden-composited-descendant.html
       compositing/geometry/bounds-ignores-hidden-dynamic.html
       compositing/geometry/bounds-ignores-hidden.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateLayerBounds): If the ExcludeHiddenDescendants flag is set, return
the empty rect for layers with no visible content or descendants, as long as the layer is not
the root of the subtree whose bounds are being computed.
calculateLayerBounds() currently (I think incorrectly) passes the default flags to the recursive calls.
It should probably just pass 'flags', but to make this change safe, OR in the ExcludeHiddenDescendants
flag.
* rendering/RenderLayer.h: Add an ExcludeHiddenDescendants flag to the CalculateLayerBoundsFlags.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds): Pass the ExcludeHiddenDescendants
flag.

LayoutTests:

Tests related to visibility:hidden's affect on composited layer bounds.

* compositing/geometry/bounds-ignores-hidden-composited-expected.txt: Added.
* compositing/geometry/bounds-ignores-hidden-composited-descendant.html: Added.
Test with visibility:visible descendants of a visibility:hidden element in a
compositing layer.

* compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt: Added.
* compositing/geometry/bounds-ignores-hidden-dynamic.html: Added.
Test that changes visibility on descendants of a compositing layer, to test dynamic changes.

* compositing/geometry/bounds-ignores-hidden-expected.txt: Added.
* compositing/geometry/bounds-ignores-hidden.html: Added.
Test with a compositing layer having visibility:hidden descendants, which dumps
layer tree information.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Widen expectation for crashing test.
pkasting@chromium.org [Sat, 28 Jul 2012 19:35:27 +0000 (19:35 +0000)]
[Chromium] Widen expectation for crashing test.
http://crbug.com/139493

Unreviewed, test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd an overlay play button to media controls on android
commit-queue@webkit.org [Sat, 28 Jul 2012 19:23:50 +0000 (19:23 +0000)]
Add an overlay play button to media controls on android
https://bugs.webkit.org/show_bug.cgi?id=92132

Patch by Min Qin <qinmin@chromium.org> on 2012-07-28
Reviewed by Adam Barth.

This change adds an overlay play button to the media controls for android.
No tests for now as this setting is not being used by other port.
Will add a test and adjust all the test expectations when we upstream the layout tests for android.

* WebCore.gypi:
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* css/mediaControls.css:
(audio::-webkit-media-controls-overlay-play-button, video::-webkit-media-controls-overlay-play-button):
* css/mediaControlsChromiumAndroid.css:
(audio::-webkit-media-controls-overlay-enclosure):
(video::-webkit-media-controls-overlay-enclosure):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(video::-webkit-media-controls-overlay-play-button):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlOverlayPlayButtonElement::MediaControlOverlayPlayButtonElement):
(WebCore):
(WebCore::MediaControlOverlayPlayButtonElement::create):
(WebCore::MediaControlOverlayPlayButtonElement::defaultEventHandler):
(WebCore::MediaControlOverlayPlayButtonElement::updateDisplayType):
(WebCore::MediaControlOverlayPlayButtonElement::shadowPseudoId):
* html/shadow/MediaControlElements.h:
(MediaControlOverlayPlayButtonElement):
(WebCore):
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlPanelEnclosureElement::MediaControlPanelEnclosureElement):
(WebCore::MediaControlPanelEnclosureElement::create):
(WebCore):
(WebCore::MediaControlPanelEnclosureElement::shadowPseudoId):
(WebCore::MediaControlRootElementChromium::create):
(WebCore::MediaControlRootElementChromium::initializeControls):
* html/shadow/MediaControlRootElementChromium.h:
(MediaControlChromiumEnclosureElement):
(WebCore):
(MediaControlPanelEnclosureElement):
(MediaControlRootElementChromium):
* html/shadow/MediaControlRootElementChromiumAndroid.cpp: Added.
(WebCore):
(WebCore::MediaControlOverlayEnclosureElement::MediaControlOverlayEnclosureElement):
(WebCore::MediaControlOverlayEnclosureElement::create):
(WebCore::MediaControlOverlayEnclosureElement::shadowPseudoId):
(WebCore::MediaControlRootElementChromiumAndroid::MediaControlRootElementChromiumAndroid):
(WebCore::MediaControls::create):
(WebCore::MediaControlRootElementChromiumAndroid::create):
(WebCore::MediaControlRootElementChromiumAndroid::setMediaController):
(WebCore::MediaControlRootElementChromiumAndroid::playbackStarted):
(WebCore::MediaControlRootElementChromiumAndroid::playbackStopped):
* html/shadow/MediaControlRootElementChromiumAndroid.h: Added.
(WebCore):
(MediaControlOverlayEnclosureElement):
(MediaControlRootElementChromiumAndroid):
* platform/ThemeTypes.h:
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaOverlayPlayButton):
(WebCore):
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
* rendering/RenderTheme.h:
(WebCore::RenderTheme::paintMediaOverlayPlayButton):
* rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::paintMediaOverlayPlayButton):
(WebCore):
* rendering/RenderThemeChromiumAndroid.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix Chromium/Win compile.
pkasting@chromium.org [Sat, 28 Jul 2012 19:22:46 +0000 (19:22 +0000)]
Fix Chromium/Win compile.
https://bugs.webkit.org/show_bug.cgi?id=88787

Unreviewed, build fix.

Chromium/Win needs _USE_MATH_DEFINES but doesn't define PLATFORM(WIN).
The other files in WebKit that define this macro (both in
WebCore/platform/graphics/cg) do it by unconditionally #defining it to 1
above the #include of "config.h", so copy that pattern here.

* TestWebKitAPI/Tests/WTF/MediaTime.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][GTK] Implement a new spell checker API for WebKit2GTK+
mario@webkit.org [Sat, 28 Jul 2012 18:45:12 +0000 (18:45 +0000)]
[WK2][GTK] Implement a new spell checker API for WebKit2GTK+
https://bugs.webkit.org/show_bug.cgi?id=90268

Reviewed by Martin Robinson.

Source/WebKit2:

Add a simple spell checking API to WK2, allowing to enable/disable
this feature and to define a list of languages associated to it.

* GNUmakefile.am: Add flags to handle the SPELLCHECK feature.
* GNUmakefile.list.am: Added new files

Added new internal class that will act both as the implementation
of TextCheckerClient and as the object WebKitWebContext will
depend on to implement the newly added API.

* UIProcess/API/gtk/WebKitTextChecker.cpp: Added.
(toTextChecker):
(continuousSpellCheckingEnabledCallback):
(setContinuousSpellCheckingEnabledCallback):
(checkSpellingOfStringCallback):
(guessesForWordCallback):
(learnWordCallback):
(ignoreWordCallback):
(WebKitTextChecker::~WebKitTextChecker):
(WebKitTextChecker::create):
(WebKitTextChecker::WebKitTextChecker):
(WebKitTextChecker::checkSpellingOfString):
(WebKitTextChecker::getGuessesForWord):
(WebKitTextChecker::learnWord):
(WebKitTextChecker::ignoreWord):
(WebKitTextChecker::setSpellCheckingEnabled):
(WebKitTextChecker::setSpellCheckingLanguages):
* UIProcess/API/gtk/WebKitTextChecker.h: Added.
(WebKitTextChecker):
(WebKitTextChecker::isSpellCheckingEnabled):
(WebKitTextChecker::getSpellCheckingLanguages):

Added WKTextChecker to WebKitPrivate.h, needed in WebKitTextChecker.

* UIProcess/API/gtk/WebKitPrivate.h:

Add new API to WebKitWebContext to allow enabling/disabling this
spell checking feature, and to set/get the list of languages used
to decide which dictionaries will be consulted.

* UIProcess/API/gtk/WebKitWebContext.cpp:
(_WebKitWebContextPrivate):
(createDefaultWebContext):
(webkit_web_context_get_spell_checking_enabled): New API.
(webkit_web_context_set_spell_checking_enabled): Ditto.
(webkit_web_context_get_spell_checking_languages): Ditto.
(webkit_web_context_set_spell_checking_languages): Ditto.
* UIProcess/API/gtk/WebKitWebContext.h:

New tests for checking the new API added to WebKitWebContext.

* UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextSpellChecker):
(beforeAll):

Update documentation with new sections and symbols.

* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:

Tools:

Ignore WebKitTextChecker.* private files for gtk-doc.

* gtk/generate-gtkdoc:
(get_webkit2_options):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add a new and reusable enchant-based spellchecker in WebCore
mario@webkit.org [Sat, 28 Jul 2012 18:28:26 +0000 (18:28 +0000)]
[GTK] Add a new and reusable enchant-based spellchecker in WebCore
https://bugs.webkit.org/show_bug.cgi?id=90269

Reviewed by Martin Robinson.

Source/WebCore:

Move enchant specific code down to WebCore, into a new class
TextCheckerEnchant, that we can use from WK1 and WK2.

* GNUmakefile.am: Add flags to handle the SPELLCHECK feature.
* GNUmakefile.list.am: Added new files.
* platform/text/gtk/TextCheckerEnchant.cpp: Added.
(getAvailableDictionariesCallback):
(TextCheckerEnchant::TextCheckerEnchant):
(TextCheckerEnchant::~TextCheckerEnchant):
(TextCheckerEnchant::ignoreWord):
(TextCheckerEnchant::learnWord):
(TextCheckerEnchant::checkSpellingOfString):
(TextCheckerEnchant::getGuessesForWord):
(TextCheckerEnchant::updateSpellCheckingLanguages):
(TextCheckerEnchant::freeEnchantBrokerDictionaries):
* platform/text/gtk/TextCheckerEnchant.h: Added.
(WebCore):
(TextCheckerEnchant):
(WebCore::TextCheckerEnchant::create):

Source/WebKit/gtk:

Remove enchant specific code from WebKitSpellCheckerEnchant and
implement it relying in the new TextCheckerEnchant class in WebCore.

* webkit/webkitspellcheckerenchant.cpp:
(_WebKitSpellCheckerEnchantPrivate):
(webkit_spell_checker_enchant_finalize):
(webkit_spell_checker_enchant_class_init):
(webkit_spell_checker_enchant_init):
(checkSpellingOfString):
(getGuessesForWord):
(updateSpellCheckingLanguages):
(learnWord):
(ignoreWord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSigh. Just disable all the AutoResize tests after the first three.
pkasting@chromium.org [Sat, 28 Jul 2012 18:05:51 +0000 (18:05 +0000)]
Sigh.  Just disable all the AutoResize tests after the first three.
https://bugs.webkit.org/show_bug.cgi?id=92318

Unreviewed, making bots happier.

* tests/WebViewTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaselining and test expectations update.
pkasting@chromium.org [Sat, 28 Jul 2012 17:36:24 +0000 (17:36 +0000)]
[Chromium] Rebaselining and test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=77188
https://bugs.webkit.org/show_bug.cgi?id=85856
https://bugs.webkit.org/show_bug.cgi?id=87844
https://bugs.webkit.org/show_bug.cgi?id=91756
http://crbug.com/10364
http://crbug.com/138159
http://crbug.com/139162
http://crbug.com/139493

Unreviewed, test expectations update.

* fast/overflow/unreachable-overflow-rtl-bug-expected.txt: Added.
* platform/chromium-linux-x86/platform/chromium: Added.
* platform/chromium-linux-x86/platform/chromium/virtual: Added.
* platform/chromium-linux-x86/platform/chromium/virtual/gpu: Added.
* platform/chromium-linux-x86/platform/chromium/virtual/gpu/fast: Added.
* platform/chromium-linux-x86/platform/chromium/virtual/gpu/fast/canvas: Added.
* platform/chromium-linux-x86/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png: Added.
* platform/chromium-linux-x86/platform/chromium/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
* platform/chromium-mac-snowleopard/fast/block/float/026-expected.png:
* platform/chromium-mac-snowleopard/fast/block/float/028-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/datalist: Added.
* platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-mac/fast/block/float/026-expected.png:
* platform/chromium-mac/fast/block/float/028-expected.png:
* platform/chromium-mac/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
* platform/chromium-mac/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
* platform/chromium-win/fast/forms/box-shadow-override-expected.png:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png:
* platform/chromium/TestExpectations:
* platform/efl/fast/overflow/unreachable-overflow-rtl-bug-expected.txt: Removed.
* platform/gtk/fast/overflow/unreachable-overflow-rtl-bug-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry disabling different test in hopes of tracking down the real problem.
pkasting@chromium.org [Sat, 28 Jul 2012 16:19:41 +0000 (16:19 +0000)]
Try disabling different test in hopes of tracking down the real problem.
https://bugs.webkit.org/show_bug.cgi?id=92318

Unreviewed, making bots happier.

* tests/WebViewTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Clamp] support in binding generator.
commit-queue@webkit.org [Sat, 28 Jul 2012 16:11:42 +0000 (16:11 +0000)]
[Clamp] support in binding generator.
https://bugs.webkit.org/show_bug.cgi?id=77605

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-07-28
Reviewed by Kentaro Hara.

Currently [Clamp] extended attribute in IDL files.
Spec: http://www.w3.org/TR/2012/CR-WebIDL-20120419/#Clamp

Tests: TestObj.idl

* bindings/scripts/CodeGeneratorCPP.pm:
(SkipFunction): Skips methods with [Clamp] parameters.
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Skips methods with [Clamp] parameters.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck): Support [Clamp] for JSBindings.
* bindings/scripts/CodeGeneratorObjC.pm:
(SkipFunction): Skips methods with [Clamp] parameters.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck): Support [Clamp] for V8Bindings.
* bindings/scripts/IDLAttributes.txt: Added [Clamp] to attributes list.
* bindings/scripts/test/JS/JSTestObj.cpp: Test.
(WebCore::jsTestObjPrototypeFunctionClassMethodWithClamp):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::classMethodWithClampCallback):
(TestObjV8Internal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Sat, 28 Jul 2012 15:18:00 +0000 (15:18 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-4.8/Skipped: Unskip now passing tests. (bug85203)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK rebaseline after r123937.
philn@webkit.org [Sat, 28 Jul 2012 13:54:21 +0000 (13:54 +0000)]
Unreviewed, GTK rebaseline after r123937.

* platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Transparent Media controls timeline and panel
philn@webkit.org [Sat, 28 Jul 2012 13:09:08 +0000 (13:09 +0000)]
[GTK] Transparent Media controls timeline and panel
https://bugs.webkit.org/show_bug.cgi?id=85279

Reviewed by Martin Robinson.

* gtk/jhbuild.modules: Provide gnome-themes-standard build
support, this is necessary so the media controls panel colors are
properly initialized from the GTK+ theme.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove obsolete functions from WTF::Unicode
commit-queue@webkit.org [Sat, 28 Jul 2012 12:34:18 +0000 (12:34 +0000)]
Remove obsolete functions from WTF::Unicode
https://bugs.webkit.org/show_bug.cgi?id=92571

Patch by Patrick Gansterer <paroga@webkit.org> on 2012-07-28
Reviewed by Kentaro Hara.

Remove hasLineBreakingPropertyComplexContextOrIdeographic() and digitValue(),
since they are never used and defined for a few Unicode backends only.

* wtf/unicode/glib/UnicodeGLib.h:
* wtf/unicode/icu/UnicodeIcu.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisable failing test.
pkasting@chromium.org [Sat, 28 Jul 2012 06:55:58 +0000 (06:55 +0000)]
Disable failing test.
https://bugs.webkit.org/show_bug.cgi?id=92318

Unreviewed, making bots happier.

* tests/WebViewTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WebGL] Align contents of drawbuffer-test.html layout test with the one in the WebGL...
commit-queue@webkit.org [Sat, 28 Jul 2012 06:55:50 +0000 (06:55 +0000)]
[WebGL] Align contents of drawbuffer-test.html layout test with the one in the WebGL conformance suite.
https://bugs.webkit.org/show_bug.cgi?id=92375

Patch by Nayan Kumar K <nayankk@motorola.com> on 2012-07-27
Reviewed by Kenneth Russell.

* fast/canvas/webgl/drawingbuffer-test-expected.txt:
* fast/canvas/webgl/drawingbuffer-test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium rebaseline after r123285.
pkasting@chromium.org [Sat, 28 Jul 2012 06:16:47 +0000 (06:16 +0000)]
Chromium rebaseline after r123285.
https://bugs.webkit.org/show_bug.cgi?id=90624

Unreviewed, rebaselining.

* platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=92573
msaboff@apple.com [Sat, 28 Jul 2012 06:11:15 +0000 (06:11 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=92573
Mac Lion: http/tests/misc/submit-post-keygen.html fails on buildbots

* platform/mac-lion/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Support for HTML media capture
commit-queue@webkit.org [Sat, 28 Jul 2012 06:00:39 +0000 (06:00 +0000)]
[EFL] Support for HTML media capture
https://bugs.webkit.org/show_bug.cgi?id=91842

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-27
Reviewed by Ryosuke Niwa.

.:

Add HTML media capture feature, and enable that on the Efl port.

* Source/cmake/OptionsEfl.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Tools:

Add HTML media capture feature to the feature list.
In addition, enable that on the Efl port.

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Remove file-input-capture.html from skipped list.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r123908.
commit-queue@webkit.org [Sat, 28 Jul 2012 05:48:46 +0000 (05:48 +0000)]
Unreviewed, rolling out r123908.
http://trac.webkit.org/changeset/123908
https://bugs.webkit.org/show_bug.cgi?id=92572

Broke Chromium Linux compile (Requested by pkasting on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-27

* WebCore.gypi:
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* css/mediaControls.css:
* css/mediaControlsChromiumAndroid.css:
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
* html/shadow/MediaControlElements.cpp:
(WebCore):
* html/shadow/MediaControlElements.h:
(WebCore):
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlChromiumEnclosureElement::create):
(WebCore):
(WebCore::MediaControlChromiumEnclosureElement::shadowPseudoId):
(WebCore::MediaControls::create):
(WebCore::MediaControlRootElementChromium::create):
* html/shadow/MediaControlRootElementChromium.h:
(MediaControlChromiumEnclosureElement):
(MediaControlRootElementChromium):
* html/shadow/MediaControlRootElementChromiumAndroid.cpp: Removed.
* html/shadow/MediaControlRootElementChromiumAndroid.h: Removed.
* platform/ThemeTypes.h:
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
* rendering/RenderTheme.h:
* rendering/RenderThemeChromiumAndroid.cpp:
* rendering/RenderThemeChromiumAndroid.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark three tests as flakily timing out.
pkasting@chromium.org [Sat, 28 Jul 2012 05:12:56 +0000 (05:12 +0000)]
Mark three tests as flakily timing out.
https://bugs.webkit.org/show_bug.cgi?id=92570

Unreviewed, Chromium test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Use new LocaleHandler.
commit-queue@webkit.org [Sat, 28 Jul 2012 04:30:06 +0000 (04:30 +0000)]
[BlackBerry] Use new LocaleHandler.
https://bugs.webkit.org/show_bug.cgi?id=92548

Patch by Eli Fidler <efidler@rim.com> on 2012-07-27
Reviewed by Yong Li.

RIM PR 128381

* platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::platformLanguage):
* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):
* platform/text/blackberry/TextBreakIteratorInternalICUBlackBerry.cpp:
(WebCore::currentSearchLocaleID):
(WebCore::currentTextBreakLocaleID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix broken script reference after test move.
pkasting@chromium.org [Sat, 28 Jul 2012 04:29:53 +0000 (04:29 +0000)]
Fix broken script reference after test move.
https://bugs.webkit.org/show_bug.cgi?id=92111

Unreviewed, fixing bad test move.

* platform/win/fast/events/panScroll-click-hyperlink.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium rebaselines after r123912.
pkasting@chromium.org [Sat, 28 Jul 2012 04:20:15 +0000 (04:20 +0000)]
Chromium rebaselines after r123912.
https://bugs.webkit.org/show_bug.cgi?id=92327

Unreviewed, rebaselining.

* platform/chromium-linux-x86/fast/hidpi: Added.
* platform/chromium-linux-x86/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
* platform/chromium-linux/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
* platform/chromium-mac/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
* platform/chromium-win-xp/fast/hidpi: Added.
* platform/chromium-win-xp/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
* platform/chromium-win/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium rebaseline after r123706.
pkasting@chromium.org [Sat, 28 Jul 2012 04:12:23 +0000 (04:12 +0000)]
Chromium rebaseline after r123706.
https://bugs.webkit.org/show_bug.cgi?id=92236

Unreviewed, rebaselining.

* platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium rebaselines after r123790.
pkasting@chromium.org [Sat, 28 Jul 2012 03:19:15 +0000 (03:19 +0000)]
Chromium rebaselines after r123790.
​https://bugs.webkit.org/show_bug.cgi?id=92059

Unreviewed, rebaselining.

* platform/chromium-linux-x86/css3/filters/effect-brightness-clamping-expected.txt: Added.
* platform/chromium-linux-x86/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
* platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.txt: Added.
* platform/chromium-linux/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
* platform/chromium-win-xp/css3: Added.
* platform/chromium-win-xp/css3/filters: Added.
* platform/chromium-win-xp/css3/filters/effect-brightness-clamping-expected.txt: Added.
* platform/chromium-win-xp/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-brightness-clamping-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange constructor with explicit constructor in WebCore/Modules
commit-queue@webkit.org [Sat, 28 Jul 2012 01:23:58 +0000 (01:23 +0000)]
Change constructor with explicit constructor in WebCore/Modules
https://bugs.webkit.org/show_bug.cgi?id=92529

Patch by Gyuyoung Kim <gyuyoung.kim@samsung.com> on 2012-07-27
Reviewed by Kentaro Hara.

As a step to let *explicit* keyword add to constructors which have a parameter,
*explicit* keyword is added to Source/WebCore/Modules in order to avoid implicit
type conversion.

No new tests. Covered by existing tests.

* Modules/filesystem/LocalFileSystem.h:
(WebCore::LocalFileSystem::LocalFileSystem):
* Modules/filesystem/Metadata.h:
(WebCore::Metadata::Metadata):
* Modules/filesystem/SyncCallbackHelper.h:
(WebCore::SyncCallbackHelper::SuccessCallbackImpl::SuccessCallbackImpl):
(WebCore::SyncCallbackHelper::ErrorCallbackImpl::ErrorCallbackImpl):
* Modules/mediastream/IceCandidate.h:
(IceCandidate):
* Modules/mediastream/NavigatorUserMediaError.h:
(WebCore::NavigatorUserMediaError::NavigatorUserMediaError):
* Modules/mediastream/SessionDescription.h:
(SessionDescription):
* Modules/mediastream/UserMediaController.h:
(UserMediaController):
* Modules/notifications/NotificationController.h:
(NotificationController):
* Modules/speech/SpeechRecognition.h:
(SpeechRecognition):
* Modules/speech/SpeechRecognitionController.h:
(SpeechRecognitionController):
* Modules/speech/SpeechRecognitionEvent.h:
(SpeechRecognitionEvent):
* Modules/speech/SpeechRecognitionResultList.h:
(SpeechRecognitionResultList):
* Modules/vibration/Vibration.h:
(Vibration):
* Modules/webaudio/AudioBuffer.h:
(AudioBuffer):
* Modules/webaudio/AudioContext.h:
(AudioContext):
* Modules/webaudio/AudioNodeInput.h:
(AudioNodeInput):
* Modules/webaudio/AudioSummingJunction.h:
(AudioSummingJunction):
* Modules/webaudio/BiquadDSPKernel.h:
(WebCore::BiquadDSPKernel::BiquadDSPKernel):
* Modules/webaudio/DefaultAudioDestinationNode.h:
(DefaultAudioDestinationNode):
* Modules/webaudio/DelayDSPKernel.h:
(DelayDSPKernel):
* Modules/webaudio/OfflineAudioCompletionEvent.h:
(OfflineAudioCompletionEvent):
* Modules/webaudio/WaveShaperDSPKernel.h:
(WebCore::WaveShaperDSPKernel::WaveShaperDSPKernel):
* Modules/webaudio/WaveShaperNode.h:
(WaveShaperNode):
* Modules/webaudio/WaveTable.h:
(WaveTable):
* Modules/webdatabase/DatabaseAuthorizer.h:
(DatabaseAuthorizer):
* Modules/webdatabase/DatabaseTask.h:
(Database::DatabaseTransactionTask):
* Modules/webdatabase/DatabaseTracker.h:
(DatabaseTracker):
* Modules/webdatabase/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):
* Modules/webdatabase/SQLException.h:
(WebCore::SQLException::SQLException):
* Modules/websockets/WebSocket.h:
* Modules/websockets/WebSocketExtensionProcessor.h:
(WebCore::WebSocketExtensionProcessor::WebSocketExtensionProcessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Optimize Element::getAttributeNS() by replacing String with AtomicString
commit-queue@webkit.org [Sat, 28 Jul 2012 01:21:15 +0000 (01:21 +0000)]
[V8] Optimize Element::getAttributeNS() by replacing String with AtomicString
https://bugs.webkit.org/show_bug.cgi?id=90276

Patch by Kentaro Hara <haraken@chromium.org> on 2012-07-27
Reviewed by Adam Barth.

In r121439, we changed the argument type of Element::getAttribute()
from String to AtomicString for optimization. This patch changes the
argument type of Element::getAttributeNS() from String to AtomicString.

Actually this change affects V8 performance only.

[JSC without the patch]
The binding code converts a given JavaScript string to a String
-> the String is passed to getAttributeNS()
-> the String is converted to an AtomicString when it is passed to
QualifiedName() constructor.

[JSC with the patch]
The binding code converts a given JavaScript string to a String
-> the String is converted to an AtomicString when it is passed to
getAttributeNS()
-> the AtomicString is passed to QualifiedName() constructor.

[V8 without the patch]
The binding code retrieves a cached external String for a given
JavaScript string
-> the String is passed to getAttributeNS()
-> the String is converted to AtomicString when it is passed to
QualifiedName() constructor.

[V8 with the patch]
The binding code retrieves a cached external AtomicString for a given
JavaScript string
-> the AtomicString is passed to getAttributeNS()
-> the AtomicString is passed to QualifiedName() constructor.

In this way, in JSC, the change affects where a String is converted to
an AtomicString. On the other hand, in V8, (since the AtomicString is already
cached,) we can skip the conversion step.

Performance test: https://bugs.webkit.org/attachment.cgi?id=150158

getAttributeNS (Chromium/Linux):
577.80ms => 454.60ms

* dom/Element.cpp:
(WebCore::Element::getAttributeNS):
* dom/Element.h:
(Element):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r123679.
commit-queue@webkit.org [Sat, 28 Jul 2012 01:02:33 +0000 (01:02 +0000)]
Unreviewed, rolling out r123679.
http://trac.webkit.org/changeset/123679
https://bugs.webkit.org/show_bug.cgi?id=92565

Slowed down HTML parsing by 3.6% (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-27

Source/WebCore:

* html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::append):
* html/parser/HTMLEntityParser.cpp:
(WebCore::HTMLEntityParser::consumeNamedEntity):
* html/parser/HTMLParserIdioms.cpp:
(WebCore::stripLeadingAndTrailingHTMLSpaces):
* html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::sourceForToken):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::script):
* platform/text/SegmentedString.cpp:
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::operator=):
(WebCore::SegmentedString::clear):
(WebCore::SegmentedString::append):
(WebCore::SegmentedString::prepend):
(WebCore::SegmentedString::advanceSubstring):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::advanceSlowCase):
(WebCore::SegmentedString::advanceAndUpdateLineNumberSlowCase):
* platform/text/SegmentedString.h:
(WebCore::SegmentedSubstring::SegmentedSubstring):
(WebCore::SegmentedSubstring::clear):
(WebCore::SegmentedSubstring::appendTo):
(SegmentedSubstring):
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::push):
(WebCore::SegmentedString::isEmpty):
(WebCore::SegmentedString::lookAhead):
(WebCore::SegmentedString::lookAheadIgnoringCase):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::advanceAndASSERT):
(WebCore::SegmentedString::advanceAndASSERTIgnoringCase):
(WebCore::SegmentedString::advancePastNewlineAndUpdateLineNumber):
(SegmentedString):
(WebCore::SegmentedString::advancePastNonNewline):
(WebCore::SegmentedString::advanceAndUpdateLineNumber):
(WebCore::SegmentedString::operator*):
(WebCore::SegmentedString::operator->):
(WebCore::SegmentedString::current):
(WebCore::SegmentedString::equalsLiterally):
(WebCore::SegmentedString::equalsIgnoringCase):
(WebCore::SegmentedString::lookAheadInline):
(WebCore::SegmentedString::lookAheadSlowCase):
* xml/parser/CharacterReferenceParserInlineMethods.h:
(WebCore::consumeCharacterReference):
* xml/parser/MarkupTokenizerBase.h:
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::nextInputCharacter):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance):

Source/WTF:

* wtf/text/WTFString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReset the set of "seen" plugins when the main frame load is committed.
jer.noble@apple.com [Sat, 28 Jul 2012 00:41:18 +0000 (00:41 +0000)]
Reset the set of "seen" plugins when the main frame load is committed.
https://bugs.webkit.org/show_bug.cgi?id=92564

Reviewed by Anders Carlsson.

Because the Page object is re-used across navigation and reload, reset the list
of seen plugins when the main frame load commits. This gives a good baseline to
compare against the number of pages loaded.

No new tests; the "seen" plugin list is for diagnostic purposes only.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchDidCommitLoad):
* page/Page.cpp:
(WebCore::Page::resetSeenPlugins):
* page/Page.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago"webkit-patch rebaseline <test>" fails with exit_code 1
dpranke@chromium.org [Sat, 28 Jul 2012 00:34:51 +0000 (00:34 +0000)]
"webkit-patch rebaseline <test>" fails with exit_code 1
https://bugs.webkit.org/show_bug.cgi?id=91560

Reviewed by Adam Barth.

webkit-patch rebaseline-json crashes in an svn checkout if it
tries to add files and there are no files to add; arguably
svn.add() should be robust against this, but rebaseline-json
shouldn't be calling it, either. This patch fixes the latter and
adds better debugging info to garden-o-matic so we can see what
caused the crash.

* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand._rebaseline):
* Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler.rebaselineall):
(GardeningHTTPRequestHandler.rebaselineall.error_handler):
(GardeningHTTPRequestHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoexecCommand copies the backgroung-color of the enclosing element to the element being...
commit-queue@webkit.org [Sat, 28 Jul 2012 00:32:15 +0000 (00:32 +0000)]
execCommand copies the backgroung-color of the enclosing element to the element being edited.
https://bugs.webkit.org/show_bug.cgi?id=91783

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-07-27
Reviewed by Ryosuke Niwa.

Source/WebCore:

InsertListCommand and some other edit commands remove redundant
style properties after their DOM modification by using
StylePropertySet::removeEquivalentProperties.  However, this method
does not remove redundant background-color properties such as
"background-color: white" and "background-color: #fff" because
it compares them using cssText and thus treats them as different.
Add code to convert background colors to RGBA and then compare them.

Test: editing/style/redundant-background-color.html

* editing/EditingStyle.cpp:
(WebCore::getRGBABackgroundColor):
(WebCore):
(WebCore::getPropertiesNotIn):

LayoutTests:

This tests to make sure that WebKit removes redundant "background-color"
property after execCommand.

* editing/style/redundant-background-color-expected.txt: Added.
* editing/style/redundant-background-color.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Return 0 when network is offline
commit-queue@webkit.org [Sat, 28 Jul 2012 00:30:31 +0000 (00:30 +0000)]
[EFL] Return 0 when network is offline
https://bugs.webkit.org/show_bug.cgi?id=92454

Patch by Gyuyoung Kim <gyuyoung.kim@samsung.com> on 2012-07-27
Reviewed by Kenneth Rohde Christiansen.

Network Info latest spec says 0 is returned when network is offline.
r123769 modified to return infinity value when network is offiline.

* platform/efl/NetworkInfoProviderEfl.cpp:
(WebCore::NetworkInfoProviderEfl::bandwidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed perf-o-matic build fix for dashboard image generation.
rniwa@webkit.org [Sat, 28 Jul 2012 00:08:44 +0000 (00:08 +0000)]
Unreviewed perf-o-matic build fix for dashboard image generation.
Also, only show Parser/html5-full-render on the dashboard by default
so that it won't take forever to load it.

* Websites/webkit-perf.appspot.com/controller.py:
(schedule_runs_update):
(RunsChartHandler.post):
* Websites/webkit-perf.appspot.com/models.py:
(Runs.chart_params):
(DashboardImage.get_image):
* Websites/webkit-perf.appspot.com/models_unittest.py:
(RunsTest.test_chart_params_with_value):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange navigator.webkitGamepads[] to navigator.webkitGetGamepads()
commit-queue@webkit.org [Fri, 27 Jul 2012 23:51:48 +0000 (23:51 +0000)]
Change navigator.webkitGamepads[] to navigator.webkitGetGamepads()
https://bugs.webkit.org/show_bug.cgi?id=92533

Patch by Scott Graham <scottmg@chromium.org> on 2012-07-27
Reviewed by Adam Barth.

Source/WebCore:

Per discussion on public-webapps. Pages that enumerate navigator were
causing background resources to be created to poll hardware
unintentionally. By changing to an explicit function call, this is
avoided (and the API becomes more clear too). This change updates the
implementation to match the current ED spec.

* Modules/gamepad/NavigatorGamepad.cpp:
(WebCore::NavigatorGamepad::webkitGetGamepads):
* Modules/gamepad/NavigatorGamepad.h:
(NavigatorGamepad):
* Modules/gamepad/NavigatorGamepad.idl:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setWebkitGetGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGetGamepadsEnabled):

Source/WebKit/chromium:

Renames for updated access point.

* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableGamepad):
(WebKit::WebRuntimeFeatures::isGamepadEnabled):

LayoutTests:

Updates for renamed access point.

* gamepad/gamepad-api-expected.txt:
* gamepad/gamepad-api.html:
* gamepad/gamepad-polling-access-expected.txt:
* gamepad/gamepad-polling-access.html:
* platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPlugins should not be allowed to override standard properties/attributes in non-stand...
beidson@apple.com [Fri, 27 Jul 2012 23:44:27 +0000 (23:44 +0000)]
Plugins should not be allowed to override standard properties/attributes in non-standard worlds
<rdar://problem/11975252> and https://bugs.webkit.org/show_bug.cgi?id=92519

Reviewed by Anders Carlsson.

Source/WebCore:

Change the 3 plugin-owning element's custom bindings to prefer built-in properties if they exist.
When they do they don't give the plugin a chance to override.

Test: plugins/npruntime/overrides-all-properties.html

Add plugin custom functions to prefer built-in properties over plugin scriptable object properties:
* bindings/js/JSPluginElementFunctions.h:
(WebCore::pluginElementCustomGetOwnPropertySlot):
(WebCore::pluginElementCustomGetOwnPropertyDescriptor):

Use those new custom functions for getting properties:
* bindings/js/JSHTMLAppletElementCustom.cpp:
(WebCore::JSHTMLAppletElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLAppletElement::getOwnPropertyDescriptorDelegate):
* bindings/js/JSHTMLEmbedElementCustom.cpp:
(WebCore::JSHTMLEmbedElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLEmbedElement::getOwnPropertyDescriptorDelegate):
* bindings/js/JSHTMLObjectElementCustom.cpp:
(WebCore::JSHTMLObjectElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLObjectElement::getOwnPropertyDescriptorDelegate):

Tools:

Add a test plugin which overrides all properties it is asked about:
* DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableObjectOverridesAllProperties.cpp: Added.
(PluginScriptableObjectOverridesAllProperties):
(PluginScriptableObjectOverridesAllProperties::PluginScriptableObjectOverridesAllProperties):
(PluginObject):
(PluginScriptableObjectOverridesAllProperties::PluginObject::PluginObject):
(PluginScriptableObjectOverridesAllProperties::PluginObject::~PluginObject):
(PluginScriptableObjectOverridesAllProperties::PluginObject::hasProperty):
(PluginScriptableObjectOverridesAllProperties::PluginObject::getProperty):
(PluginScriptableObjectOverridesAllProperties::NPP_GetValue):

Expose NPN_MemAlloc to the test plugin:
* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPN_MemAlloc):
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
(PluginTest):

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

LayoutTests:

* plugins/npruntime/overrides-all-properties-expected.txt: Added.
* plugins/npruntime/overrides-all-properties.html: Added.
* platform/chromium/TestExpectations: Test behaves different in V8, so skip on chromium

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agouse createUninitialized when creating TypedArray from another array
commit-queue@webkit.org [Fri, 27 Jul 2012 23:32:19 +0000 (23:32 +0000)]
use createUninitialized when creating TypedArray from another array
https://bugs.webkit.org/show_bug.cgi?id=92518

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-07-27
Reviewed by Kenneth Russell.

PerformanceTests:

* Bindings/typed-array-construct-from-array.html: Added.

Source/WebCore:

When creating a Typed Array from another array, we fill it with values
from the source array. So, we can create it uninitialized. This is
make constructor about 35% faster when constructed with another typed
array.

Test: fast/canvas/webgl/array-constructor.html

* bindings/js/JSArrayBufferViewHelper.h:
(WebCore::constructArrayBufferViewWithTypedArrayArgument):
(WebCore::constructArrayBufferView):

Source/WTF:

Expose a createUninitialized static method on TypedArray classes.

* wtf/Float32Array.h:
(Float32Array):
(WTF::Float32Array::createUninitialized):
(WTF):
* wtf/Float64Array.h:
(Float64Array):
(WTF::Float64Array::createUninitialized):
(WTF):
* wtf/Int16Array.h:
(Int16Array):
(WTF::Int16Array::createUninitialized):
(WTF):
* wtf/Int32Array.h:
(Int32Array):
(WTF::Int32Array::createUninitialized):
(WTF):
* wtf/Int8Array.h:
(Int8Array):
(WTF::Int8Array::createUninitialized):
(WTF):
* wtf/Uint16Array.h:
(Uint16Array):
(WTF::Uint16Array::createUninitialized):
(WTF):
* wtf/Uint32Array.h:
(Uint32Array):
(WTF::Uint32Array::createUninitialized):
(WTF):
* wtf/Uint8Array.h:
(Uint8Array):
(WTF::Uint8Array::createUninitialized):
(WTF):
* wtf/Uint8ClampedArray.h:
(Uint8ClampedArray):

LayoutTests:

Add test to check that constructing a Typed Array with nan values does
not result in random values.

* fast/canvas/webgl/array-constructor-expected.txt: Added.
* fast/canvas/webgl/array-constructor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Adapt to change in the FontInfo platform API.
commit-queue@webkit.org [Fri, 27 Jul 2012 23:29:20 +0000 (23:29 +0000)]
[BlackBerry] Adapt to change in the FontInfo platform API.
https://bugs.webkit.org/show_bug.cgi?id=92547

Patch by Eli Fidler <efidler@rim.com> on 2012-07-27
Reviewed by Yong Li

RIM PR 161263

Source/WebCore:

* page/blackberry/SettingsBlackBerry.cpp:
(WebCore::Settings::initializeDefaultFontFamilies):

Source/WebKit/blackberry:

* Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::standardSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Assertion hit in ewk_cookie_manager.cpp
commit-queue@webkit.org [Fri, 27 Jul 2012 23:12:33 +0000 (23:12 +0000)]
[EFL][WK2] Assertion hit in ewk_cookie_manager.cpp
https://bugs.webkit.org/show_bug.cgi?id=92544

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-27
Reviewed by Kenneth Rohde Christiansen.

Removed wrong assertion in ewk_cookie_manager.cpp
and replace it by an if check. The assertion was
sometimes hit by our unit tests.

* UIProcess/API/efl/ewk_cookie_manager.cpp:
(cookiesDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix color matrix filter computation so that filters that don't need clampi...
commit-queue@webkit.org [Fri, 27 Jul 2012 23:02:03 +0000 (23:02 +0000)]
[chromium] Fix color matrix filter computation so that filters that don't need clamping are correctly detected as such
https://bugs.webkit.org/show_bug.cgi?id=92452

Patch by Antoine Labour <piman@chromium.org> on 2012-07-27
Reviewed by Stephen White.

Because of precision issues, some filters were returning true to
matrixNeedsClamping when they can return false. This fixes it.

No new tests in this CL, a follow-up change refactors the code to add
several tests.

* platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSplit functionality of MarkedAllocator::m_currentBlock
mhahnenberg@apple.com [Fri, 27 Jul 2012 22:59:14 +0000 (22:59 +0000)]
Split functionality of MarkedAllocator::m_currentBlock
https://bugs.webkit.org/show_bug.cgi?id=92550

Reviewed by Filip Pizlo.

MarkedAllocator::m_currentBlock serves two purposes right now; it indicates the block that is currently
being used for allocation and the beginning of the list of blocks that need to be swept. We should split
these two functionalities into two separate fields.

* heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper): Use m_blocksToSweep instead of m_currentBlock as the
initializer/reference of the loop. Only change m_currentBlock when we know what the result will be.
(JSC::MarkedAllocator::addBlock): When we add a new block we know that both m_blocksToSweep and
m_currentBlock are null. In order to preserve the invariant that m_currentBlock <= m_blocksToSweep,
we assign both of them to point to the new block.
(JSC::MarkedAllocator::removeBlock): We need a separate check to see if the block we're removing is
m_blocksToSweep and if so, advance it to the next block in the list.
* heap/MarkedAllocator.h:
(MarkedAllocator): Initialize m_blocksToSweep.
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::reset): We set m_blocksToSweep to be the head of our list. This function is called
at the end of a collection, so all of the blocks in our allocator need to be swept. We need to sweep a
block before we can start allocating, so m_currentBlock is set to null. We also set the freeList to
the empty FreeList to emphasize the fact that we can't start allocating until we do some sweeping.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd diagnostic logging for plugins-per-page.
jer.noble@apple.com [Fri, 27 Jul 2012 22:58:02 +0000 (22:58 +0000)]
Add diagnostic logging for plugins-per-page.
https://bugs.webkit.org/show_bug.cgi?id=92538

Reviewed by Anders Carlsson.

Add some diagnostic logging for whether a page has seen a plugin, and
whether a page has seen a plugin of a specific type.

Move the diagnostic logging out of the elemements themselves:
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget):

Instead, log when the plugin is requested, thereby catching plugins which are
rejected because, e.g., Java is disabled or not installed:
* loader/SubframeLoader.cpp:
(WebCore::logPluginRequest):
(WebCore::SubframeLoader::requestObject):
(WebCore::SubframeLoader::createJavaAppletWidget):

Add new diagnostic key values:
* page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):
* page/DiagnosticLoggingKeys.h:

Add a map of plugin types seen per-page for diagnostic purposes:
* page/Page.cpp:
(WebCore::Page::hasSeenAnyPlugin):
(WebCore::Page::hasSeenPlugin):
(WebCore::Page::sawPlugin):
* page/Page.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WINCE] Use macros from ICU instead of defining the same functionality again
commit-queue@webkit.org [Fri, 27 Jul 2012 22:46:12 +0000 (22:46 +0000)]
[WINCE] Use macros from ICU instead of defining the same functionality again
https://bugs.webkit.org/show_bug.cgi?id=92530

Patch by Patrick Gansterer <paroga@webkit.org> on 2012-07-27
Reviewed by Ryosuke Niwa.

Replace isHighSurrogate() with U16_IS_LEAD(), isLowSurrogate() with
U16_IS_TRAIL() and surrogateToUcs4() with U16_GET_SUPPLEMENTARY().

Source/WebCore:

* html/FTPDirectoryDocument.cpp:
(WebCore::processFileDateString):
* loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::generateMHTMLData):
* platform/graphics/wince/FontWinCE.cpp:
(WebCore::generateComponents):

Source/WTF:

* wtf/unicode/wince/UnicodeWinCE.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild warning in CSSPrimitiveValueMappings.h when CSS_STICKY_POSITION is disabled
commit-queue@webkit.org [Fri, 27 Jul 2012 22:41:12 +0000 (22:41 +0000)]
Build warning in CSSPrimitiveValueMappings.h when CSS_STICKY_POSITION is disabled
https://bugs.webkit.org/show_bug.cgi?id=92523

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-27
Reviewed by Simon Fraser.

Move #ifdef in CSSPrimitiveValueMappings.h to silent compilation warning
when CSS_STICKY_POSITION is disabled.

No new tests, no behavior change.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDragController should ascertain dragClient to be non-null
commit-queue@webkit.org [Fri, 27 Jul 2012 22:37:44 +0000 (22:37 +0000)]
DragController should ascertain dragClient to be non-null
https://bugs.webkit.org/show_bug.cgi?id=92474

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-27
Reviewed by Tony Chang.

The DragController must always ensure a valid dragClient object. Hence
adding the ASSERT to assure that.

No new tests. Added assertion for PageClient.dragClient.

* page/DragController.cpp:
(WebCore::DragController::DragController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Clean up LayerRendererChromium::drawTexturedQuad
commit-queue@webkit.org [Fri, 27 Jul 2012 22:30:50 +0000 (22:30 +0000)]
[chromium] Clean up LayerRendererChromium::drawTexturedQuad
https://bugs.webkit.org/show_bug.cgi?id=91823

Patch by Adrienne Walker <enne@google.com> on 2012-07-27
Reviewed by James Robinson.

LayerRendererChromium::drawTexturedQuad has been around forever and
over time has developed several problems:
 - Confusingly named relative to drawTextureQuad
 - All but one callers identically manipulate the transform matrix
 - Lots of optional parameters that only few functions use

This patch breaks up drawTexturedQuad into setShaderOpacity (for
optional opacity values sent to the shader), setShaderFloatQuad (the
full FloatQuad used by AA shaders), and drawQuadGeometry (actually
draw the geometry, and wrap the transform logic that was duplicated
everywhere).

No new tests; no change in functionality.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawCheckerboardQuad):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawSolidColorQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
(WebCore::LayerRendererChromium::drawStreamVideoQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::drawIOSurfaceQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::setShaderFloatQuad):
(WebCore::LayerRendererChromium::setShaderOpacity):
(WebCore::LayerRendererChromium::drawQuadGeometry):
(WebCore::LayerRendererChromium::copyTextureToFramebuffer):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix build after r123917
caio.oliveira@openbossa.org [Fri, 27 Jul 2012 22:20:59 +0000 (22:20 +0000)]
[Qt] Fix build after r123917
https://bugs.webkit.org/show_bug.cgi?id=92555

Unreviewed.

* wtf/GregorianDateTime.h: Needs string.h for memset().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago"webkit-patch upload" should strip colors from patch if necessary
commit-queue@webkit.org [Fri, 27 Jul 2012 22:10:30 +0000 (22:10 +0000)]
"webkit-patch upload" should strip colors from patch if necessary
https://bugs.webkit.org/show_bug.cgi?id=92306

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-07-27
Reviewed by Adam Barth.

* Scripts/webkitpy/common/checkout/scm/git.py: Explicity remove colors from diff.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remaining rebaselines after new test fonts
caio.oliveira@openbossa.org [Fri, 27 Jul 2012 22:07:17 +0000 (22:07 +0000)]
[Qt] Remaining rebaselines after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92552

Unreviewed.

Unskip a bunch of tests, organize the remaining skips. The mentions to bug 85203 were
removed now. A last batch of WK1 results were associated with the bug 91610.

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/fullscreen/full-screen-placeholder-expected.txt:
* platform/qt-5.0/Skipped:
* platform/qt/editing/input/caret-at-the-edge-of-input-expected.txt:
* platform/qt/editing/input/reveal-caret-of-multiline-input-expected.txt:
* platform/qt/http/tests/cache/cancel-during-revalidation-succeeded-expected.txt: Removed.
* platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
* platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Removed.
* platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.txt:
* platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.txt:
* platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
* platform/qt/svg/text/select-x-list-1-expected.txt:
* platform/qt/svg/text/select-x-list-2-expected.txt:
* platform/qt/svg/text/select-x-list-3-expected.txt:
* platform/qt/svg/text/select-x-list-4-expected.txt:
* platform/qt/svg/text/select-x-list-with-tspans-1-expected.txt:
* platform/qt/svg/text/select-x-list-with-tspans-2-expected.txt:
* platform/qt/svg/text/select-x-list-with-tspans-3-expected.txt:
* platform/qt/svg/text/select-x-list-with-tspans-4-expected.txt:
* platform/qt/svg/text/selection-doubleclick-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] CCLayerTreeHost placeholder scissor should be deviceViewportSize instead...
commit-queue@webkit.org [Fri, 27 Jul 2012 22:04:15 +0000 (22:04 +0000)]
[chromium] CCLayerTreeHost placeholder scissor should be deviceViewportSize instead of viewportSize
https://bugs.webkit.org/show_bug.cgi?id=92469

Patch by Shawn Singh <shawnsingh@chromium.org> on 2012-07-27
Reviewed by Adrienne Walker.

We were accidentally using viewportSize instead of
deviceViewportSize in a particular place in code. Recent
refactoring to use tighter scissor rects exposed this problem.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoclean-pending-commit throws exception when encountering Ossy
commit-queue@webkit.org [Fri, 27 Jul 2012 21:56:13 +0000 (21:56 +0000)]
clean-pending-commit throws exception when encountering Ossy
https://bugs.webkit.org/show_bug.cgi?id=92534

Patch by Eric Seidel <eric@webkit.org> on 2012-07-27
Reviewed by Adam Barth.

Mark a couple strings as unicode so that reviewers with unicode names do not cause
clean-pending-commit to barf.

* Scripts/webkitpy/tool/commands/upload.py:
(CleanPendingCommit._flags_to_clear_on_patch):
(CleanPendingCommit.execute):
(AssignToCommitter._assign_bug_to_last_patch_attacher):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSearch cancel button is hard to activate with a tap gesture even if touch adjustment...
commit-queue@webkit.org [Fri, 27 Jul 2012 21:49:36 +0000 (21:49 +0000)]
Search cancel button is hard to activate with a tap gesture even if touch adjustment is enabled.
https://bugs.webkit.org/show_bug.cgi?id=91894

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-27
Reviewed by Antonio Gomes.

Source/WebCore:

Update check for determining if a node responds to tap gestures.
Previously, the cancel button was being discarded as a candidate for
touch adjustment if the touch area clipped the text input region
because the candidate pruning process failed to account for the cancel
button having a default mouse handler.  Possibly an interim fix,
depending on resolution to 92093.

Test: touchadjustment/search-cancel.html

* page/TouchAdjustment.cpp:
(TouchAdjustment):
(WebCore::TouchAdjustment::nodeRespondsToTapGesture):

LayoutTests:

Add test for touch adjustment in the vicinity of a search cancel button.
Prior to the patch, the cancel button was pruned as a candidate if the
touch area clipped the input field.

* touchadjustment/search-cancel-expected.txt: Added.
* touchadjustment/search-cancel.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agochromium win compile broken after removing webkit.py
dpranke@chromium.org [Fri, 27 Jul 2012 21:48:42 +0000 (21:48 +0000)]
chromium win compile broken after removing webkit.py
https://bugs.webkit.org/show_bug.cgi?id=92549

Unreviewed, build fix.

It turns out that this file is listed in the chromium downstream
'browser_tests.isolate' file, and so deleting it broke gyp.
Adding a stub file back in until we can remove the entry from
the file.

* Scripts/webkitpy/layout_tests/port/webkit.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMinGW build fails because of missing header in GregorianDateTime.h
paroga@webkit.org [Fri, 27 Jul 2012 21:40:44 +0000 (21:40 +0000)]
MinGW build fails because of missing header in GregorianDateTime.h
https://bugs.webkit.org/show_bug.cgi?id=92531

Patch by Paweł Forysiuk <tuxator@o2.pl> on 2012-07-27

* wtf/GregorianDateTime.h: Include time.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: remove 'webkit.py' and the 'WebKitPort'
dpranke@chromium.org [Fri, 27 Jul 2012 21:04:16 +0000 (21:04 +0000)]
nrwt: remove 'webkit.py' and the 'WebKitPort'
https://bugs.webkit.org/show_bug.cgi?id=92450

Reviewed by Ryosuke Niwa.

This patch finishes the work of merging WebKitPort into Port.
Now Port is way too big :).

This is all cutting and pasting; no new functionality and
no changes in the tests.

* Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort):
(ApplePort.__init__):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.skipped_layout_tests):
(Port):
(Port._port_flag_for_scripts):
(Port._arguments_for_configuration):
(Port._run_script):
(Port._build_driver):
(Port._build_driver_flags):
(Port._tests_for_other_platforms):
(Port._runtime_feature_list):
(Port.nm_command):
(Port._modules_to_search_for_symbols):
(Port._symbols_string):
(Port._missing_feature_to_skipped_tests):
(Port._missing_symbol_to_skipped_tests):
(Port._has_test_in_directories):
(Port._skipped_tests_for_unsupported_features):
(Port._wk2_port_name):
(Port._skipped_file_search_paths):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
* Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_check_build):
* Scripts/webkitpy/layout_tests/port/driver_unittest.py:
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort):
(EflPort.__init__):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort):
(GtkPort.setup_environ_for_server):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(TestWebKitPort):
(TestWebKitPort.__init__):
(TestWebKitPort.all_test_configurations):
(TestWebKitPort._symbols_string):
(TestWebKitPort._tests_for_other_platforms):
(TestWebKitPort._tests_for_disabled_features):
(PortTestCase):
(PortTestCase.test_diff_image):
(PortTestCase.test_path_to_test_expectations_file):
(PortTestCase.test_skipped_directories_for_symbols):
(test_skipped_directories_for_features):
(test_skipped_directories_for_features_no_matching_tests_in_test_list):
(test_skipped_tests_for_unsupported_features_empty_test_list):
(test_skipped_layout_tests):
(test_skipped_file_search_paths):
(test_root_option):
(test_test_expectations):
(test_build_driver):
(_assert_config_file_for_platform):
(test_linux_distro_detection):
(test_apache_config_file_name_for_platform):
(test_path_to_apache_config_file):
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort):
(QtPort.__init__):
(QtPort.setup_environ_for_server):
* Scripts/webkitpy/layout_tests/port/webkit.py: Removed.
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Removed.
* Scripts/webkitpy/tool/servers/rebaselineserver.py:
(get_test_baselines.AllPlatformsPort):
(get_test_baselines.AllPlatformsPort.__init__):
* Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
(get_test_config.TestMacPort):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't use an NSUserDefault for disabling the web process sandbox
andersca@apple.com [Fri, 27 Jul 2012 20:48:18 +0000 (20:48 +0000)]
Don't use an NSUserDefault for disabling the web process sandbox
https://bugs.webkit.org/show_bug.cgi?id=92542
<rdar://problem/11976060>

Reviewed by Mark Rowe.

The user default was really helpful during WebKit2 bringup, but we no longer need to pay the IPC cost of initializing NSUserDefaults at startup,
so get rid of the preference and use a good old #ifdef instead.

* WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnimated SVGs do not clear previous frame completely in hidpi mode.
commit-queue@webkit.org [Fri, 27 Jul 2012 20:43:32 +0000 (20:43 +0000)]
Animated SVGs do not clear previous frame completely in hidpi mode.
https://bugs.webkit.org/show_bug.cgi?id=92395

Patch by Varun Jain <varunjain@chromium.org> on 2012-07-27
Reviewed by Darin Adler.

Source/WebCore:

The rect thats is cleared in subsequent frames needed to be scaled with device scale.

Test: svg/as-image/animated-svg-repaints-completely-in-hidpi.html

* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawSVGToImageBuffer):

LayoutTests:

* platform/chromium/TestExpectations:
* platform/mac/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.png: Added.
* platform/mac/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.txt: Added.
* svg/as-image/animated-svg-repaints-completely-in-hidpi.html: Added.
* svg/as-image/resources/animated-rect-fixed-size-3.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix COMPILE_ASSERT for InlineFlowBox growing
mitz@apple.com [Fri, 27 Jul 2012 20:41:40 +0000 (20:41 +0000)]
Fix COMPILE_ASSERT for InlineFlowBox growing
https://bugs.webkit.org/show_bug.cgi?id=92541

Patch by Scott Graham <scottmg@chromium.org> on 2012-07-27
Reviewed by Dan Bernstein.

Use unsigned instead of bool to keep size small on Windows.

No new tests.

* rendering/InlineFlowBox.h:
(InlineFlowBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=92327
bdakin@apple.com [Fri, 27 Jul 2012 20:33:56 +0000 (20:33 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=92327
-webkit-background-clip:text is blurry in WebKit 1 apps when
deviceScaleFactor > 1
-and corresponding-
<rdar://problem/11683788>

Reviewed by Simon Fraser.

Source/WebCore:

The bug here is that the code to make createCompatibleBuffer() HiDPI-savvy
assumed that the deviceScaleFactor would always be baked into the CTM of the
GraphicsContext. But that is NOT the case in WebKit 1.

createCompatibleBuffer() is used for clip text and gradients.

Now getCTM() takes a parameter indicating whether the result should definitely
include the device scale, or if it should possibly included the device scale,
which is the option that matches old behavior.
* platform/graphics/GraphicsContext.h:
(GraphicsContext):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::getCTM):
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::getCTM):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::getCTM):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::getCTM):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::getCTM):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::getCTM):

Actually use the new parameter in the CG implementation. Use CG API to get a
matrix that definitely includes the device scale when that is required.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::getCTM):

Remove some symbol cruft that doesn't seem to require a replacement.
* WebCore.exp.in:

Use DefinitelyIncludeDeviceScale when getting the CTM in the buggy spot.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::createCompatibleBuffer):

The ImageBuffer for gradients is created using createCompatibleBuffer(), and since
createCompatibleBuffer() now uses getCTM(DefinitelyIncludeDeviceScale) to
determine appropriate sizing, drawPattern() should use that same matrix to
determine pattern sizing.
* platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::drawPattern):

LayoutTests:

* fast/hidpi/gradient-with-scaled-ancestor.html: Added.
* platform/mac/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
* platform/mac/fast/hidpi/gradient-with-scaled-ancestor-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][WTR] LayoutTestController.deliverWebIntent() needs to be implemented
commit-queue@webkit.org [Fri, 27 Jul 2012 20:10:19 +0000 (20:10 +0000)]
[WK2][WTR] LayoutTestController.deliverWebIntent() needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=92228

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-27
Reviewed by Anders Carlsson.

Source/WebKit2:

Add C API to create a WKIntentData and to deliver
it to a frame. This is needed by WebKitTestRunner
to implement LayoutTestController.deliverWebIntent().

* UIProcess/API/C/WKIntentData.cpp:
(WKIntentDataCreate):
* UIProcess/API/C/WKIntentData.h:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageDeliverIntentToFrame):
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/WebPage/WebPage.h:
(WebPage): Make deliverIntentToFrame() public so that it can
be used by WKBundlePage.

Tools:

Implement LayoutTestController.deliverWebIntent() to
allow test cases to deliver a Web intent and test this
functionality.

This functionality is needed by:
- webintents/web-intents-delivery.html

* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::deliverWebIntent):
(WTR):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd Mac results for fast/table/table-row-outline-paint.html.
bweinstein@apple.com [Fri, 27 Jul 2012 19:49:28 +0000 (19:49 +0000)]
Add Mac results for fast/table/table-row-outline-paint.html.

* platform/mac/fast/table/table-row-outline-paint-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: flex-wrap: wrap not wrapping for % sized items in column flow
commit-queue@webkit.org [Fri, 27 Jul 2012 19:46:13 +0000 (19:46 +0000)]
Source/WebCore: flex-wrap: wrap not wrapping for % sized items in column flow
https://bugs.webkit.org/show_bug.cgi?id=92324

Patch by Tony Chang <tony@chromium.org> on 2012-07-27
Reviewed by Ojan Vafai.

We were using trying to use the value of contentLogicalHeight() before having called computeLogicalHeight()
in a few places. Fix this in mainAxisContentExtent() rather than at the callers.

Test: css3/flexbox/percentage-heights.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::mainAxisContentExtent):
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): If we haven't called computeLogicalHeight, we try to compute
the height based on the fixed flexbox value. min/max don't matter here since percent values are only based on height/width.
* rendering/RenderFlexibleBox.h: Drop const because computeContentLogicalHeightUsing is not const. I can
try making computeContentLogicalHeightUsing const in a follow up change (might be non-trivial).

Source/WebKit2: Show the unavailable plug-in indicator for Java applets as well
https://bugs.webkit.org/show_bug.cgi?id=92521

Patch by Anders Carlsson <andersca@apple.com> on 2012-07-27
Reviewed by Sam Weinig.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
This can now be called on applet elements as well.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createJavaAppletWidget):
Get the MIME type from the applet element.

LayoutTests: flex-wrap: wrap not wrapping for % sized items in column flow
https://bugs.webkit.org/show_bug.cgi?id=92324

Patch by Tony Chang <tony@chromium.org> on 2012-07-27
Reviewed by Ojan Vafai.

Test cases for column flow with percentage heights. There are three
test cases for the three callers of mainAxisContentExtent() that were
broken by this.

* css3/flexbox/percentage-heights-expected.txt: Added.
* css3/flexbox/percentage-heights.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd an overlay play button to media controls on android
commit-queue@webkit.org [Fri, 27 Jul 2012 19:38:36 +0000 (19:38 +0000)]
Add an overlay play button to media controls on android
https://bugs.webkit.org/show_bug.cgi?id=92132

Patch by Min Qin <qinmin@chromium.org> on 2012-07-27
Reviewed by Adam Barth.

This change adds an overlay play button to the media controls for android.
No tests for now as this setting is not being used by other port.
Will add a test and adjust all the test expectations when we upstream the layout tests for android.

* WebCore.gypi:
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* css/mediaControls.css:
(audio::-webkit-media-controls-overlay-play-button, video::-webkit-media-controls-overlay-play-button):
* css/mediaControlsChromiumAndroid.css:
(audio::-webkit-media-controls-overlay-enclosure):
(video::-webkit-media-controls-overlay-enclosure):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(video::-webkit-media-controls-overlay-play-button):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlOverlayPlayButtonElement::MediaControlOverlayPlayButtonElement):
(WebCore):
(WebCore::MediaControlOverlayPlayButtonElement::create):
(WebCore::MediaControlOverlayPlayButtonElement::defaultEventHandler):
(WebCore::MediaControlOverlayPlayButtonElement::updateDisplayType):
(WebCore::MediaControlOverlayPlayButtonElement::shadowPseudoId):
* html/shadow/MediaControlElements.h:
(MediaControlOverlayPlayButtonElement):
(WebCore):
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlPanelEnclosureElement::MediaControlPanelEnclosureElement):
(WebCore::MediaControlPanelEnclosureElement::create):
(WebCore):
(WebCore::MediaControlPanelEnclosureElement::shadowPseudoId):
(WebCore::MediaControlRootElementChromium::create):
(WebCore::MediaControlRootElementChromium::initializeControls):
* html/shadow/MediaControlRootElementChromium.h:
(MediaControlChromiumEnclosureElement):
(WebCore):
(MediaControlPanelEnclosureElement):
(MediaControlRootElementChromium):
* html/shadow/MediaControlRootElementChromiumAndroid.cpp: Added.
(WebCore):
(WebCore::MediaControlOverlayEnclosureElement::MediaControlOverlayEnclosureElement):
(WebCore::MediaControlOverlayEnclosureElement::create):
(WebCore::MediaControlOverlayEnclosureElement::shadowPseudoId):
(WebCore::MediaControlRootElementChromiumAndroid::MediaControlRootElementChromiumAndroid):
(WebCore::MediaControls::create):
(WebCore::MediaControlRootElementChromiumAndroid::create):
(WebCore::MediaControlRootElementChromiumAndroid::setMediaController):
(WebCore::MediaControlRootElementChromiumAndroid::playbackStarted):
(WebCore::MediaControlRootElementChromiumAndroid::playbackStopped):
* html/shadow/MediaControlRootElementChromiumAndroid.h: Added.
(WebCore):
(MediaControlOverlayEnclosureElement):
(MediaControlRootElementChromiumAndroid):
* platform/ThemeTypes.h:
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaOverlayPlayButton):
(WebCore):
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
* rendering/RenderTheme.h:
(WebCore::RenderTheme::paintMediaOverlayPlayButton):
* rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::paintMediaOverlayPlayButton):
(WebCore):
* rendering/RenderThemeChromiumAndroid.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShow the unavailable plug-in indicator for Java applets as well
andersca@apple.com [Fri, 27 Jul 2012 19:30:18 +0000 (19:30 +0000)]
Show the unavailable plug-in indicator for Java applets as well
https://bugs.webkit.org/show_bug.cgi?id=92521

Reviewed by Sam Weinig.

Source/WebCore:

Now that <applet> behaves more like <embed> and <object>, make sure that we show the unavailable plug-in indicator
and call the correct error callbacks if we fail to instantiate the plug-in.

* WebCore.exp.in:
Export a symbol needed by WebKit2.

* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::HTMLAppletElement):
Set the correct service type.

* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::createJavaAppletWidget):
Enable the unavailable plug-in indicator if we fail to create the java applet widget.

Source/WebKit/mac:

Check if the Java plug-in is blocked before trying to instantiate it.

* WebCoreSupport/WebFrameLoaderClient.mm:

Source/WebKit2:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
This can now be called on applet elements as well.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createJavaAppletWidget):
Get the MIME type from the applet element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix.
jer.noble@apple.com [Fri, 27 Jul 2012 19:30:11 +0000 (19:30 +0000)]
Unreviewed build fix.

Source/WTF:

Use MathExtras.h and the non std:: versions of isnan and signbit.

* wtf/MediaTime.cpp:
(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):

Tools:

Wrap MSVC-specific fixes is a COMPILER() check, not a PLATFORM() check.

* TestWebKitAPI/Tests/WTF/MediaTime.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIncrease inline storage for JSFinalObjects by one
mhahnenberg@apple.com [Fri, 27 Jul 2012 19:29:03 +0000 (19:29 +0000)]
Increase inline storage for JSFinalObjects by one
https://bugs.webkit.org/show_bug.cgi?id=92526

Reviewed by Geoffrey Garen.

Now that we've removed the inheritorID from objects, we can increase our inline storage for JSFinalObjects on
64-bit platforms by 1.

* llint/LowLevelInterpreter.asm: Change the constant.
* runtime/PropertyOffset.h: Change the constant.
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHit testing near a column break can return a result from an adjacent column when...
mitz@apple.com [Fri, 27 Jul 2012 19:25:43 +0000 (19:25 +0000)]
Hit testing near a column break can return a result from an adjacent column when there is leading
https://bugs.webkit.org/show_bug.cgi?id=92524

Reviewed by Anders Carlsson.

Source/WebCore:

The fix for <http://webkit.org/b/92311> relied on the existence of a pagination strut for
detecting that a line was at the beginning of a new column. However, when a line naturally
falls at the beginning of a column, there is no pagination strut, and the check failed.

Test: fast/multicol/hit-test-end-of-column-with-line-height.html

* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox): Added initializer for new member variable.
(InlineFlowBox): Added m_isFirstAfterPageBreak member variable.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren): Changed the test for whether a
line was at the beginning of a column from relying on a pagination strut to checking
isFirstAfterPageBreak(). Also refined the hit test itself to include the leading above such
a line.
(WebCore::RenderBlock::adjustLinePositionForPagination): Added calls to
setIsFirstAfterPageBreak() to first reset this flag, then set it to true if necessary.
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::isFirstAfterPageBreak): Added this accessor.
(WebCore::RootInlineBox::setIsFirstAfterPageBreak): Ditto.

LayoutTests:

* fast/multicol/hit-test-end-of-column-with-line-height-expected.txt: Added.
* fast/multicol/hit-test-end-of-column-with-line-height.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Fix build warning in WebEventConversion.cpp
commit-queue@webkit.org [Fri, 27 Jul 2012 19:03:07 +0000 (19:03 +0000)]
[WK2] Fix build warning in WebEventConversion.cpp
https://bugs.webkit.org/show_bug.cgi?id=92517

Patch by Gyuyoung Kim <gyuyoung.kim@samsung.com> on 2012-07-27
Reviewed by Darin Adler.

There is a build warning related to comparison between signed and unsigned integer expressions.

* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Allow front_end to be loaded into an iframe
commit-queue@webkit.org [Fri, 27 Jul 2012 19:02:47 +0000 (19:02 +0000)]
Web Inspector: Allow front_end to be loaded into an iframe
https://bugs.webkit.org/show_bug.cgi?id=92437

Patch by John J. Barton <johnjbarton@johnjbarton.com> on 2012-07-27
Reviewed by Pavel Feldman.

This change only affects 'embedders' of the inspector/front_end. No change of function for WebKit ports.

* inspector/front-end/ExtensionAPI.js:
Replace window.top with window.parent two places. When WebInspector is loaded as the main window content,
then extension iframes have window.top === window.parent; when WebInspector is loaded as an iframe, then
extensions are iframes in iframes and we need to use a relative address window.parent.
(injectedExtensionAPI.ExtensionViewImpl.dispatchShowEvent):
(injectedExtensionAPI.ExtensionViewImpl):
(injectedExtensionAPI.ExtensionServerClient):
WebKit/chromium/scripts/generate_devtools_extension_api.py:
The current number of frames is used in a dynamically created identifier. Again we replace 'top' by
window.parent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: InspectorPageAgent should ascertain document to be non-null in updateV...
commit-queue@webkit.org [Fri, 27 Jul 2012 18:54:55 +0000 (18:54 +0000)]
Web Inspector: InspectorPageAgent should ascertain document to be non-null in updateViewMetrics()
https://bugs.webkit.org/show_bug.cgi?id=92476

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-27
Reviewed by Pavel Feldman.

InspectorPageAgent should check for document object being null. As pages created with blank URL might
not have the document object, this causes a crash.

No new tests as added null check.

* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::updateViewMetrics):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium-Android] NRWT better handling of DRT deadlocks and crashes
commit-queue@webkit.org [Fri, 27 Jul 2012 18:42:38 +0000 (18:42 +0000)]
[Chromium-Android] NRWT better handling of DRT deadlocks and crashes
https://bugs.webkit.org/show_bug.cgi?id=92299

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2012-07-27
Reviewed by Dirk Pranke.

1. Changed the deadlock detector thread target from a method of driver to a function to avoid its reference to the
   current driver (see the bug for the problem of the reference.
2. Let the deadlock detector thread exit early when the normal_startup_event is set to avoid it from blocking the main thread when the main thread is exiting.
3. Extracted common loop until timeout logic into ChromiumAndroidDriver._loop_with_timeout().
4. Use the "for i in range(n)" style suggested by dpranke in https://bugs.webkit.org/show_bug.cgi?id=89124 in several functions.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.__init__):
(ChromiumAndroidPort._run_adb_command): Reduced the verbose output.
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._loop_with_timeout): Extracted common loop until timeout logic here.
(ChromiumAndroidDriver._all_pipes_created):
(ChromiumAndroidDriver._remove_all_pipes):
(ChromiumAndroidDriver._start): Changed the retry loop style.
(ChromiumAndroidDriver._start_once): Changed the loop style and code related to deadlock detector.
(ChromiumAndroidDriver._start_once.deadlock_detector): Moved the original ChromiumAndroidDriver._deadlock_detector() here.
(ChromiumAndroidDriver.stop): Changed the loop style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSP directives containing invalid characters should log an error.
commit-queue@webkit.org [Fri, 27 Jul 2012 18:38:25 +0000 (18:38 +0000)]
CSP directives containing invalid characters should log an error.
https://bugs.webkit.org/show_bug.cgi?id=92487

Patch by Mike West <mkwst@chromium.org> on 2012-07-27
Reviewed by Adam Barth.

Source/WebCore:

Unknown directive names are currently logged, but we exit the directive
parser early without logging if we hit an invalid character inside a
directive. `script-src: ...`, for example, was ignored without letting
the developer know what happened. This patch changes that behavior,
logging the whole name (in this case `script-src:`) as an unknown
directive.

Test: http/tests/security/contentSecurityPolicy/directive-parsing-04.html

* page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::parseDirective):

LayoutTests:

* http/tests/security/contentSecurityPolicy/directive-parsing-03-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/directive-parsing-04-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/directive-parsing-04.html: Added.
    Adding a test specifically for `script-src: ...` which bit me, and
    updating test #3, which now has a better error message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: move collect_tests(), parse_expectations() into manager
dpranke@chromium.org [Fri, 27 Jul 2012 18:26:03 +0000 (18:26 +0000)]
nrwt: move collect_tests(), parse_expectations() into manager
https://bugs.webkit.org/show_bug.cgi?id=92423

Reviewed by Ojan Vafai.

This is the first in a series of patches refactoring
run_webkit_tests.py and manager.py to make them more
maintainable; all this patch does is move a couple of functions
into manager.run_tests() so manager's public interface is
simple.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._collect_tests):
(Manager._parse_expectations):
(Manager._split_into_chunks_if_necessary):
(Manager.run):
(read_test_files):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_http_locking):
(ManagerTest.test_perf_locking):
(ManagerTest.integration_test_needs_servers.get_manager_with_tests):
(ManagerTest.test_look_for_new_crash_logs.get_manager_with_tests):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd more Russian replay performance tests
commit-queue@webkit.org [Fri, 27 Jul 2012 18:25:53 +0000 (18:25 +0000)]
Add more Russian replay performance tests
https://bugs.webkit.org/show_bug.cgi?id=92462

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2012-07-27
Reviewed by Tony Chang.

Add more Russian sites as suggested by loislo.

* Replay/Russian/lenta.ru.replay: Added.
* Replay/Russian/www.ixbt.com.replay: Added.
* Replay/Russian/www.kp.ru.replay: Added.
* Replay/Russian/www.liveinternet.ru.replay: Added.
* Replay/Russian/www.pravda.ru.replay: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] platform/qt/svg/custom tests needs update after font change.
commit-queue@webkit.org [Fri, 27 Jul 2012 18:25:02 +0000 (18:25 +0000)]
[Qt] platform/qt/svg/custom tests needs update after font change.
https://bugs.webkit.org/show_bug.cgi?id=91090.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-27
Reviewed by Zoltan Herczeg.

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/svg/custom/altglyph-expected.png: Removed.
* platform/qt-5.0-wk2/svg/custom/altglyph-expected.txt: Removed.
* platform/qt-5.0-wk2/svg/custom/font-face-simple-expected.png: Removed.
* platform/qt-5.0-wk2/svg/custom/font-face-simple-expected.txt: Removed.
* platform/qt-5.0-wk2/svg/custom/inline-svg-in-xhtml-expected.png: Added.
* platform/qt-5.0-wk2/svg/custom/inline-svg-in-xhtml-expected.txt: Copied from LayoutTests/platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt.
* platform/qt-5.0/Skipped:
* platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.png: Removed.
* platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
* platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.png: Removed.
* platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.txt: Removed.
* platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.txt: Removed.
* platform/qt-5.0/svg/custom/glyph-transformation-with-hkern-expected.png: Removed.
* platform/qt-5.0/svg/custom/glyph-transformation-with-hkern-expected.txt: Removed.
* platform/qt-5.0/svg/custom/preserve-aspect-ratio-syntax-expected.png: Removed.
* platform/qt-5.0/svg/custom/preserve-aspect-ratio-syntax-expected.txt: Removed.
* platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Removed.
* platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
* platform/qt-5.0/svg/custom/svg-features-expected.txt: Removed.
* platform/qt-5.0/svg/custom/svg-fonts-in-html-expected.png: Removed.
* platform/qt-5.0/svg/custom/svg-fonts-in-html-expected.txt: Removed.
* platform/qt-5.0/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
* platform/qt-5.0/svg/custom/svg-fonts-segmented-expected.png: Removed.
* platform/qt-5.0/svg/custom/svg-fonts-segmented-expected.txt: Removed.
* platform/qt-5.0/svg/custom/text-linking-expected.png: Removed.
* platform/qt-5.0/svg/custom/text-linking-expected.txt: Removed.
* platform/qt/svg/custom/SVGMatrix-interface-expected.png:
* platform/qt/svg/custom/SVGMatrix-interface-expected.txt:
* platform/qt/svg/custom/SVGPoint-matrixTransform-expected.png:
* platform/qt/svg/custom/SVGPoint-matrixTransform-expected.txt:
* platform/qt/svg/custom/absolute-sized-content-with-resources-expected.png:
* platform/qt/svg/custom/absolute-sized-content-with-resources-expected.txt:
* platform/qt/svg/custom/absolute-sized-svg-in-xhtml-expected.png:
* platform/qt/svg/custom/absolute-sized-svg-in-xhtml-expected.txt:
* platform/qt/svg/custom/alignment-baseline-modes-expected.png:
* platform/qt/svg/custom/alignment-baseline-modes-expected.txt:
* platform/qt/svg/custom/altglyph-expected.png:
* platform/qt/svg/custom/altglyph-expected.txt:
* platform/qt/svg/custom/baseval-animval-equality-expected.png:
* platform/qt/svg/custom/baseval-animval-equality-expected.txt:
* platform/qt/svg/custom/broken-internal-references-expected.txt:
* platform/qt/svg/custom/bug45331-expected.png: Added.
* platform/qt/svg/custom/bug45331-expected.txt: Added.
* platform/qt/svg/custom/bug86119-expected.txt:
* platform/qt/svg/custom/circle-move-invalidation-expected.png:
* platform/qt/svg/custom/circle-move-invalidation-expected.txt:
* platform/qt/svg/custom/clip-path-referencing-use-expected.png:
* platform/qt/svg/custom/clip-path-referencing-use-expected.txt:
* platform/qt/svg/custom/clip-path-referencing-use2-expected.png:
* platform/qt/svg/custom/clip-path-referencing-use2-expected.txt:
* platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.png:
* platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.txt:
* platform/qt/svg/custom/container-opacity-clip-viewBox-expected.png:
* platform/qt/svg/custom/container-opacity-clip-viewBox-expected.txt:
* platform/qt/svg/custom/coords-relative-units-transforms-expected.png:
* platform/qt/svg/custom/coords-relative-units-transforms-expected.txt:
* platform/qt/svg/custom/createImageElement2-expected.png: Added.
* platform/qt/svg/custom/createImageElement2-expected.txt:
* platform/qt/svg/custom/dominant-baseline-hanging-expected.png:
* platform/qt/svg/custom/dominant-baseline-hanging-expected.txt:
* platform/qt/svg/custom/dominant-baseline-modes-expected.png:
* platform/qt/svg/custom/dominant-baseline-modes-expected.txt:
* platform/qt/svg/custom/dynamic-svg-document-creation-expected.png:
* platform/qt/svg/custom/dynamic-svg-document-creation-expected.txt:
* platform/qt/svg/custom/embedding-external-svgs-expected.png:
* platform/qt/svg/custom/embedding-external-svgs-expected.txt:
* platform/qt/svg/custom/empty-clip-path-expected.png:
* platform/qt/svg/custom/empty-clip-path-expected.txt:
* platform/qt/svg/custom/empty-mask-expected.png: Added.
* platform/qt/svg/custom/empty-mask-expected.txt:
* platform/qt/svg/custom/external-paintserver-reference-expected.png:
* platform/qt/svg/custom/external-paintserver-reference-expected.txt:
* platform/qt/svg/custom/fill-SVGPaint-interface-expected.png:
* platform/qt/svg/custom/fill-SVGPaint-interface-expected.txt:
* platform/qt/svg/custom/fill-fallback-expected.png:
* platform/qt/svg/custom/fill-fallback-expected.txt:
* platform/qt/svg/custom/focus-ring-expected.png:
* platform/qt/svg/custom/focus-ring-expected.txt:
* platform/qt/svg/custom/font-face-cascade-order-expected.png:
* platform/qt/svg/custom/font-face-cascade-order-expected.txt:
* platform/qt/svg/custom/font-face-simple-expected.png:
* platform/qt/svg/custom/font-face-simple-expected.txt:
* platform/qt/svg/custom/foreign-object-skew-expected.png:
* platform/qt/svg/custom/foreign-object-skew-expected.txt:
* platform/qt/svg/custom/foreignObject-crash-on-hover-expected.png:
* platform/qt/svg/custom/foreignObject-crash-on-hover-expected.txt:
* platform/qt/svg/custom/getPresentationAttribute-expected.png:
* platform/qt/svg/custom/getPresentationAttribute-expected.txt:
* platform/qt/svg/custom/getTransformToElement-expected.png:
* platform/qt/svg/custom/getTransformToElement-expected.txt:
* platform/qt/svg/custom/getscreenctm-in-mixed-content-expected.png:
* platform/qt/svg/custom/getscreenctm-in-mixed-content-expected.txt:
* platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
* platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
* platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
* platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
* platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
* platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
* platform/qt/svg/custom/getsvgdocument-expected.png:
* platform/qt/svg/custom/getsvgdocument-expected.txt:
* platform/qt/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
* platform/qt/svg/custom/glyph-selection-arabic-forms-expected.txt:
* platform/qt/svg/custom/glyph-selection-bidi-mirror-expected.png: Copied from LayoutTests/platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.png.
* platform/qt/svg/custom/glyph-selection-bidi-mirror-expected.txt:
* platform/qt/svg/custom/glyph-selection-non-bmp-expected.png: Renamed from LayoutTests/platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.png.
* platform/qt/svg/custom/glyph-selection-non-bmp-expected.txt:
* platform/qt/svg/custom/glyph-transformation-with-hkern-expected.png:
* platform/qt/svg/custom/glyph-transformation-with-hkern-expected.txt:
* platform/qt/svg/custom/gradient-cycle-detection-expected.png:
* platform/qt/svg/custom/gradient-cycle-detection-expected.txt:
* platform/qt/svg/custom/gradient-deep-referencing-expected.png:
* platform/qt/svg/custom/gradient-deep-referencing-expected.txt:
* platform/qt/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
* platform/qt/svg/custom/gradient-with-1d-boundingbox-expected.txt:
* platform/qt/svg/custom/hit-test-path-expected.png:
* platform/qt/svg/custom/hit-test-path-expected.txt:
* platform/qt/svg/custom/hit-test-path-stroke-expected.png:
* platform/qt/svg/custom/hit-test-path-stroke-expected.txt:
* platform/qt/svg/custom/hit-test-unclosed-subpaths-expected.png:
* platform/qt/svg/custom/hit-test-unclosed-subpaths-expected.txt:
* platform/qt/svg/custom/image-parent-translation-expected.png:
* platform/qt/svg/custom/image-parent-translation-expected.txt:
* platform/qt/svg/custom/image-rescale-clip-expected.png:
* platform/qt/svg/custom/image-rescale-clip-expected.txt:
* platform/qt/svg/custom/image-rescale-scroll-expected.png:
* platform/qt/svg/custom/image-rescale-scroll-expected.txt:
* platform/qt/svg/custom/image-small-width-height-expected.png:
* platform/qt/svg/custom/image-small-width-height-expected.txt:
* platform/qt/svg/custom/image-with-transform-clip-filter-expected.png:
* platform/qt/svg/custom/image-with-transform-clip-filter-expected.txt:
* platform/qt/svg/custom/inline-svg-in-xhtml-expected.png:
* platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/qt/svg/custom/invalid-css-expected.png:
* platform/qt/svg/custom/invalid-css-expected.txt:
* platform/qt/svg/custom/invalid-fill-expected.png:
* platform/qt/svg/custom/invalid-fill-expected.txt:
* platform/qt/svg/custom/invalid-fill-hex-expected.png:
* platform/qt/svg/custom/invalid-fill-hex-expected.txt:
* platform/qt/svg/custom/invalid-lengthlist-expected.png:
* platform/qt/svg/custom/invalid-lengthlist-expected.txt:
* platform/qt/svg/custom/invalid-stroke-hex-expected.png: Added.
* platform/qt/svg/custom/invalid-stroke-hex-expected.txt:
* platform/qt/svg/custom/invalid-uri-stroke-expected.png: Added.
* platform/qt/svg/custom/invalid-uri-stroke-expected.txt:
* platform/qt/svg/custom/invisible-text-after-scrolling-expected.png:
* platform/qt/svg/custom/invisible-text-after-scrolling-expected.txt:
* platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.png:
* platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
* platform/qt/svg/custom/js-late-clipPath-creation-expected.png:
* platform/qt/svg/custom/js-late-clipPath-creation-expected.txt:
* platform/qt/svg/custom/js-late-gradient-and-object-creation-expected.png:
* platform/qt/svg/custom/js-late-gradient-and-object-creation-expected.txt:
* platform/qt/svg/custom/js-late-gradient-creation-expected.png:
* platform/qt/svg/custom/js-late-gradient-creation-expected.txt:
* platform/qt/svg/custom/js-update-stop-linked-gradient-expected.png:
* platform/qt/svg/custom/js-update-stop-linked-gradient-expected.txt:
* platform/qt/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
* platform/qt/svg/custom/linking-a-03-b-preserveAspectRatio-expected.txt:
* platform/qt/svg/custom/linking-a-03-b-transform-expected.png:
* platform/qt/svg/custom/linking-a-03-b-transform-expected.txt:
* platform/qt/svg/custom/linking-a-03-b-viewBox-expected.png:
* platform/qt/svg/custom/linking-a-03-b-viewBox-expected.txt:
* platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
* platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
* platform/qt/svg/custom/linking-a-03-b-viewTarget-expected.png:
* platform/qt/svg/custom/linking-a-03-b-viewTarget-expected.txt:
* platform/qt/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
* platform/qt/svg/custom/linking-a-03-b-zoomAndPan-expected.txt:
* platform/qt/svg/custom/linking-base-external-reference-expected.png:
* platform/qt/svg/custom/linking-base-external-reference-expected.txt:
* platform/qt/svg/custom/linking-uri-01-b-expected.png:
* platform/qt/svg/custom/linking-uri-01-b-expected.txt:
* platform/qt/svg/custom/marker-default-width-height-expected.png:
* platform/qt/svg/custom/marker-default-width-height-expected.txt:
* platform/qt/svg/custom/marker-overflow-clip-expected.png:
* platform/qt/svg/custom/marker-overflow-clip-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-container-expected.png:
* platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
* platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-root-expected.png:
* platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
* platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
* platform/qt/svg/custom/no-inherited-dashed-stroke-expected.png:
* platform/qt/svg/custom/no-inherited-dashed-stroke-expected.txt:
* platform/qt/svg/custom/non-opaque-filters-expected.png:
* platform/qt/svg/custom/non-opaque-filters-expected.txt:
* platform/qt/svg/custom/object-no-size-attributes-expected.png:
* platform/qt/svg/custom/object-no-size-attributes-expected.txt:
* platform/qt/svg/custom/object-sizing-expected.png:
* platform/qt/svg/custom/object-sizing-expected.txt:
* platform/qt/svg/custom/object-sizing-explicit-height-expected.png:
* platform/qt/svg/custom/object-sizing-explicit-height-expected.txt:
* platform/qt/svg/custom/object-sizing-explicit-width-expected.png:
* platform/qt/svg/custom/object-sizing-explicit-width-expected.txt:
* platform/qt/svg/custom/object-sizing-explicit-width-height-expected.png:
* platform/qt/svg/custom/object-sizing-explicit-width-height-expected.txt:
* platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png:
* platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt:
* platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.png:
* platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt:
* platform/qt/svg/custom/object-sizing-no-width-height-expected.png:
* platform/qt/svg/custom/object-sizing-no-width-height-expected.txt:
* platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png:
* platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt:
* platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png:
* platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt:
* platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
* platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
* platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png:
* platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt:
* platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.png:
* platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt:
* platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt:
* platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png:
* platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
* platform/qt/svg/custom/path-textPath-simulation-expected.png:
* platform/qt/svg/custom/path-textPath-simulation-expected.txt:
* platform/qt/svg/custom/pattern-cycle-detection-expected.png:
* platform/qt/svg/custom/pattern-cycle-detection-expected.txt:
* platform/qt/svg/custom/pattern-deep-referencing-expected.png:
* platform/qt/svg/custom/pattern-deep-referencing-expected.txt:
* platform/qt/svg/custom/pattern-incorrect-tiling-expected.png:
* platform/qt/svg/custom/pattern-incorrect-tiling-expected.txt:
* platform/qt/svg/custom/pattern-rotate-expected.png:
* platform/qt/svg/custom/pattern-rotate-expected.txt:
* platform/qt/svg/custom/pattern-rotate-gaps-expected.png:
* platform/qt/svg/custom/pattern-rotate-gaps-expected.txt:
* platform/qt/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png:
* platform/qt/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt:
* platform/qt/svg/custom/pattern-with-transformation-expected.png:
* platform/qt/svg/custom/pattern-with-transformation-expected.txt:
* platform/qt/svg/custom/percentage-of-html-parent-expected.png:
* platform/qt/svg/custom/percentage-of-html-parent-expected.txt:
* platform/qt/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/qt/svg/custom/pointer-events-image-css-transform-expected.txt:
* platform/qt/svg/custom/pointer-events-image-expected.png:
* platform/qt/svg/custom/pointer-events-image-expected.txt:
* platform/qt/svg/custom/pointer-events-path-expected.png:
* platform/qt/svg/custom/pointer-events-path-expected.txt:
* platform/qt/svg/custom/pointer-events-text-css-transform-expected.png:
* platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt:
* platform/qt/svg/custom/pointer-events-text-expected.png:
* platform/qt/svg/custom/pointer-events-text-expected.txt:
* platform/qt/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/qt/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
* platform/qt/svg/custom/recursive-clippath-expected.png:
* platform/qt/svg/custom/recursive-clippath-expected.txt:
* platform/qt/svg/custom/recursive-filter-expected.png:
* platform/qt/svg/custom/recursive-filter-expected.txt:
* platform/qt/svg/custom/recursive-gradient-expected.png:
* platform/qt/svg/custom/recursive-gradient-expected.txt:
* platform/qt/svg/custom/recursive-mask-expected.png:
* platform/qt/svg/custom/recursive-mask-expected.txt:
* platform/qt/svg/custom/recursive-pattern-expected.png:
* platform/qt/svg/custom/recursive-pattern-expected.txt:
* platform/qt/svg/custom/relative-sized-content-expected.png: Added.
* platform/qt/svg/custom/relative-sized-content-expected.txt:
* platform/qt/svg/custom/relative-sized-content-with-resources-expected.png:
* platform/qt/svg/custom/relative-sized-content-with-resources-expected.txt:
* platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.png:
* platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
* platform/qt/svg/custom/relative-sized-image-expected.png:
* platform/qt/svg/custom/relative-sized-image-expected.txt:
* platform/qt/svg/custom/relative-sized-inner-svg-expected.png:
* platform/qt/svg/custom/relative-sized-inner-svg-expected.txt:
* platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.png:
* platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.txt:
* platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
* platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
* platform/qt/svg/custom/relative-sized-use-on-symbol-expected.png:
* platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
* platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
* platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
* platform/qt/svg/custom/rootmost-svg-xy-attrs-expected.png:
* platform/qt/svg/custom/rootmost-svg-xy-attrs-expected.txt:
* platform/qt/svg/custom/scroll-hit-test-expected.png:
* platform/qt/svg/custom/scroll-hit-test-expected.txt:
* platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
* platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/qt/svg/custom/second-inline-text-expected.png:
* platform/qt/svg/custom/second-inline-text-expected.txt:
* platform/qt/svg/custom/shape-rendering-expected.png:
* platform/qt/svg/custom/shape-rendering-expected.txt:
* platform/qt/svg/custom/shapes-supporting-markers-expected.png:
* platform/qt/svg/custom/shapes-supporting-markers-expected.txt:
* platform/qt/svg/custom/simple-text-double-shadow-expected.png:
* platform/qt/svg/custom/simple-text-double-shadow-expected.txt:
* platform/qt/svg/custom/simpleCDF-expected.png:
* platform/qt/svg/custom/simpleCDF-expected.txt:
* platform/qt/svg/custom/stroke-fallback-expected.png:
* platform/qt/svg/custom/stroke-fallback-expected.txt:
* platform/qt/svg/custom/stroke-width-large-expected.png:
* platform/qt/svg/custom/stroke-width-large-expected.txt:
* platform/qt/svg/custom/stroked-pattern-expected.png:
* platform/qt/svg/custom/stroked-pattern-expected.txt:
* platform/qt/svg/custom/style-attribute-font-size-expected.png:
* platform/qt/svg/custom/style-attribute-font-size-expected.txt:
* platform/qt/svg/custom/svg-curve-with-relative-cordinates-expected.png:
* platform/qt/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
* platform/qt/svg/custom/svg-features-expected.txt:
* platform/qt/svg/custom/svg-float-border-padding-expected.png:
* platform/qt/svg/custom/svg-float-border-padding-expected.txt:
* platform/qt/svg/custom/svg-fonts-in-html-expected.png:
* platform/qt/svg/custom/svg-fonts-in-html-expected.txt:
* platform/qt/svg/custom/svg-fonts-in-text-controls-expected.txt:
* platform/qt/svg/custom/svg-fonts-segmented-expected.png:
* platform/qt/svg/custom/svg-fonts-segmented-expected.txt:
* platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.png:
* platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
* platform/qt/svg/custom/svg-fonts-word-spacing-expected.png:
* platform/qt/svg/custom/svg-fonts-word-spacing-expected.txt:
* platform/qt/svg/custom/svg-overflow-types-expected.png:
* platform/qt/svg/custom/svg-overflow-types-expected.txt:
* platform/qt/svg/custom/text-clip-expected.png:
* platform/qt/svg/custom/text-clip-expected.txt:
* platform/qt/svg/custom/text-ctm-expected.png:
* platform/qt/svg/custom/text-ctm-expected.txt:
* platform/qt/svg/custom/text-decoration-visibility-expected.png:
* platform/qt/svg/custom/text-decoration-visibility-expected.txt:
* platform/qt/svg/custom/text-dom-01-f-expected.png:
* platform/qt/svg/custom/text-dom-01-f-expected.txt:
* platform/qt/svg/custom/text-filter-expected.png:
* platform/qt/svg/custom/text-filter-expected.txt:
* platform/qt/svg/custom/text-hit-test-expected.png:
* platform/qt/svg/custom/text-hit-test-expected.txt:
* platform/qt/svg/custom/text-image-opacity-expected.png:
* platform/qt/svg/custom/text-image-opacity-expected.txt:
* platform/qt/svg/custom/text-letter-spacing-expected.png:
* platform/qt/svg/custom/text-letter-spacing-expected.txt:
* platform/qt/svg/custom/text-linking-expected.png:
* platform/qt/svg/custom/text-linking-expected.txt:
* platform/qt/svg/custom/text-repaint-including-stroke-expected.png:
* platform/qt/svg/custom/text-repaint-including-stroke-expected.txt:
* platform/qt/svg/custom/text-rotated-gradient-expected.png:
* platform/qt/svg/custom/text-rotated-gradient-expected.txt:
* platform/qt/svg/custom/text-rotation-expected.png:
* platform/qt/svg/custom/text-rotation-expected.txt:
* platform/qt/svg/custom/text-tref-03-b-change-href-dom-expected.png:
* platform/qt/svg/custom/text-tref-03-b-change-href-dom-expected.txt:
* platform/qt/svg/custom/text-tref-03-b-change-href-expected.png:
* platform/qt/svg/custom/text-tref-03-b-change-href-expected.txt:
* platform/qt/svg/custom/text-tref-03-b-referenced-element-removal-expected.png:
* platform/qt/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt:
* platform/qt/svg/custom/text-tref-03-b-tref-removal-expected.png:
* platform/qt/svg/custom/text-tref-03-b-tref-removal-expected.txt:
* platform/qt/svg/custom/text-whitespace-handling-expected.png:
* platform/qt/svg/custom/text-whitespace-handling-expected.txt:
* platform/qt/svg/custom/text-x-dx-lists-expected.png:
* platform/qt/svg/custom/text-x-dx-lists-expected.txt:
* platform/qt/svg/custom/text-x-dy-lists-expected.png:
* platform/qt/svg/custom/text-x-dy-lists-expected.txt:
* platform/qt/svg/custom/text-x-override-in-tspan-child-expected.png:
* platform/qt/svg/custom/text-x-override-in-tspan-child-expected.txt:
* platform/qt/svg/custom/text-xy-updates-SVGList-expected.png:
* platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
* platform/qt/svg/custom/text-xy-updates-expected.png:
* platform/qt/svg/custom/text-xy-updates-expected.txt:
* platform/qt/svg/custom/tref-own-content-removal-expected.png:
* platform/qt/svg/custom/tref-own-content-removal-expected.txt:
* platform/qt/svg/custom/tref-update-expected.png:
* platform/qt/svg/custom/tref-update-expected.txt:
* platform/qt/svg/custom/use-clipped-hit-expected.png:
* platform/qt/svg/custom/use-clipped-hit-expected.txt:
* platform/qt/svg/custom/use-detach-expected.png:
* platform/qt/svg/custom/use-detach-expected.txt:
* platform/qt/svg/custom/use-dynamic-append-expected.png:
* platform/qt/svg/custom/use-dynamic-append-expected.txt:
* platform/qt/svg/custom/use-elementInstance-event-target-expected.png:
* platform/qt/svg/custom/use-elementInstance-event-target-expected.txt:
* platform/qt/svg/custom/use-elementInstance-methods-expected.png:
* platform/qt/svg/custom/use-elementInstance-methods-expected.txt:
* platform/qt/svg/custom/use-event-handler-on-referenced-element-expected.png:
* platform/qt/svg/custom/use-event-handler-on-referenced-element-expected.txt:
* platform/qt/svg/custom/use-event-handler-on-use-element-expected.png:
* platform/qt/svg/custom/use-event-handler-on-use-element-expected.txt:
* platform/qt/svg/custom/use-events-crash-expected.png:
* platform/qt/svg/custom/use-events-crash-expected.txt:
* platform/qt/svg/custom/use-instanceRoot-modifications-expected.png:
* platform/qt/svg/custom/use-instanceRoot-modifications-expected.txt:
* platform/qt/svg/custom/use-modify-container-in-target-expected.png:
* platform/qt/svg/custom/use-modify-container-in-target-expected.txt:
* platform/qt/svg/custom/use-modify-target-container-expected.png:
* platform/qt/svg/custom/use-modify-target-container-expected.txt:
* platform/qt/svg/custom/use-modify-target-symbol-expected.png:
* platform/qt/svg/custom/use-modify-target-symbol-expected.txt:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-1-expected.png:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-2-expected.png:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-3-expected.png:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-4-expected.png:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.png:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-6-expected.png:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
* platform/qt/svg/custom/use-on-g-containing-symbol-expected.png:
* platform/qt/svg/custom/use-on-g-containing-symbol-expected.txt:
* platform/qt/svg/custom/use-on-g-containing-use-expected.png:
* platform/qt/svg/custom/use-on-g-containing-use-expected.txt:
* platform/qt/svg/custom/use-on-g-expected.png:
* platform/qt/svg/custom/use-on-g-expected.txt:
* platform/qt/svg/custom/use-on-non-svg-namespaced-element-expected.png:
* platform/qt/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
* platform/qt/svg/custom/use-on-rect-expected.png:
* platform/qt/svg/custom/use-on-rect-expected.txt:
* platform/qt/svg/custom/use-on-symbol-expected.png:
* platform/qt/svg/custom/use-on-symbol-expected.txt:
* platform/qt/svg/custom/use-on-text-expected.png:
* platform/qt/svg/custom/use-on-text-expected.txt:
* platform/qt/svg/custom/use-on-use-expected.png:
* platform/qt/svg/custom/use-on-use-expected.txt:
* platform/qt/svg/custom/use-property-changes-through-dom-expected.png:
* platform/qt/svg/custom/use-property-changes-through-dom-expected.txt:
* platform/qt/svg/custom/use-property-changes-through-svg-dom-expected.png:
* platform/qt/svg/custom/use-property-changes-through-svg-dom-expected.txt:
* platform/qt/svg/custom/use-recursion-1-expected.png:
* platform/qt/svg/custom/use-recursion-1-expected.txt:
* platform/qt/svg/custom/use-recursion-2-expected.png:
* platform/qt/svg/custom/use-recursion-2-expected.txt:
* platform/qt/svg/custom/use-recursion-3-expected.png:
* platform/qt/svg/custom/use-recursion-3-expected.txt:
* platform/qt/svg/custom/use-recursion-4-expected.png:
* platform/qt/svg/custom/use-recursion-4-expected.txt:
* platform/qt/svg/custom/use-referencing-nonexisting-symbol-expected.png:
* platform/qt/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
* platform/qt/svg/custom/use-setAttribute-crash-expected.png:
* platform/qt/svg/custom/use-setAttribute-crash-expected.txt:
* platform/qt/svg/custom/use-transform-expected.png:
* platform/qt/svg/custom/use-transform-expected.txt:
* platform/qt/svg/custom/viewbox-syntax-expected.png:
* platform/qt/svg/custom/viewbox-syntax-expected.txt:
* platform/qt/svg/custom/viewport-em-expected.png:
* platform/qt/svg/custom/viewport-em-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: print filtered stderr after a crash correctly
dpranke@chromium.org [Fri, 27 Jul 2012 18:23:18 +0000 (18:23 +0000)]
nrwt: print filtered stderr after a crash correctly
https://bugs.webkit.org/show_bug.cgi?id=92428

Reviewed by Adam Barth.

Some ports will run the stderr output from DRT/WTR through a
filter after a crash in order to print a more useful stack
trace; while that gets written to the crash log correctly, we
don't log it to the debug output properly. This change fixes
that and makes it clearer that we're logging stderr, not the
crash log.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._handle_error):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port._get_crash_log):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._get_crash_log):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest.test_get_crash_log):
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.run_test):
* Scripts/webkitpy/layout_tests/port/gtk.py:
* Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._get_crash_log):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_get_crash_log):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Texmap] Performance regression in texture uploads after r121223
noam.rosenthal@nokia.com [Fri, 27 Jul 2012 18:22:23 +0000 (18:22 +0000)]
[Texmap] Performance regression in texture uploads after r121223
https://bugs.webkit.org/show_bug.cgi?id=91897

Reviewed by Jocelyn Turcotte.

Rolling out r121223, with some conflict fixes.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::swizzleBGRAToRGBA):
(WebCore):
(WebCore::driverSupportsBGRASwizzling):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: move image diffing code to a separate module
dpranke@chromium.org [Fri, 27 Jul 2012 18:21:08 +0000 (18:21 +0000)]
nrwt: move image diffing code to a separate module
https://bugs.webkit.org/show_bug.cgi?id=92447

Reviewed by Ryosuke Niwa.

This patch moves the code to talk to ImageDiff into its own
module, and adds more tests for it. In addition, the patch
modifies diff_image() so that we don't automatically stop
ImageDiff after a single invocation, and thus subsequent
diffs may be slightly faster. (Note that the chromium ports
don't use any of this code; that is not changed by this patch).

The main motivation for this change is to move more "generic"
code out of the port/* classes, and in particular to move more
code out of webkit.py so that we can eventually eliminate it by
merging it into base.py.

This patch also splits MockServerProcess out from driver_unittest.py
so that it can be re-used.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.__init__):
(Port.diff_image):
(Port.clean_up_test_run):
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.__init__):
(Driver._start):
* Scripts/webkitpy/layout_tests/port/driver_unittest.py:
(DriverTest.test_stop_cleans_up_properly):
(DriverTest.test_two_starts_cleans_up_properly):
(DriverTest.test_start_actually_starts):
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.clean_up_test_run):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.clean_up_test_run):
* Scripts/webkitpy/layout_tests/port/image_diff.py: Added.
(ImageDiffer):
(ImageDiffer.__init__):
(ImageDiffer.diff_image):
(ImageDiffer._start):
(ImageDiffer._read):
(ImageDiffer.stop):
* Scripts/webkitpy/layout_tests/port/image_diff_unittest.py: Added.
(for):
(FakePort):
(FakePort.__init__):
(FakePort._path_to_image_diff):
(FakePort.setup_environ_for_server):
(TestImageDiffer):
(TestImageDiffer.test_diff_image):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTPortTest.test_diff_image):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_diff_image__missing_both):
(PortTestCase.test_diff_image):
(PortTestCase.test_diff_image.make_proc):
* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._start):
* Scripts/webkitpy/layout_tests/port/server_process_mock.py: Added.
(MockServerProcess):
(MockServerProcess.__init__):
(MockServerProcess.write):
(MockServerProcess.has_crashed):
(MockServerProcess.read_stdout_line):
(MockServerProcess.read_stdout):
(MockServerProcess.pop_all_buffered_stderr):
(MockServerProcess.read_either_stdout_or_stderr_line):
(MockServerProcess.start):
(MockServerProcess.stop):
(MockServerProcess.kill):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._build_driver_flags):
(WebKitPort._symbols_string):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoActivate committer bit granted April 6th so I can garden.
commit-queue@webkit.org [Fri, 27 Jul 2012 18:17:27 +0000 (18:17 +0000)]
Activate committer bit granted April 6th so I can garden.
https://bugs.webkit.org/show_bug.cgi?id=92500

Patch by Tom Hudson <hudson@google.com> on 2012-07-27
Reviewed by Jochen Eisinger.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Should support onbeforeunload event and show confirmation dialog
commit-queue@webkit.org [Fri, 27 Jul 2012 18:13:01 +0000 (18:13 +0000)]
[BlackBerry] Should support onbeforeunload event and show confirmation dialog
https://bugs.webkit.org/show_bug.cgi?id=92510

Patch by Yong Li <yoli@rim.com> on 2012-07-27
Reviewed by Antonio Gomes.

RIM PR# 155878.
1. Export dispatchBeforeUnloadEvent() so client can call it before going to close the page.
2. Forward runBeforeUnloadConfirmPanel() call to client so it can show a dialog.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::dispatchBeforeUnloadEvent):
(WebKit):
* Api/WebPage.h:
* Api/WebPageClient.h:
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::canRunBeforeUnloadConfirmPanel):
(WebCore::ChromeClientBlackBerry::runBeforeUnloadConfirmPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Update NetworkJob::sendRequestWithCredentials to use new getProxyAddress API
commit-queue@webkit.org [Fri, 27 Jul 2012 18:04:45 +0000 (18:04 +0000)]
[BlackBerry] Update NetworkJob::sendRequestWithCredentials to use new getProxyAddress API
https://bugs.webkit.org/show_bug.cgi?id=92457

Patch by Joe Mason <jmason@rim.com> on 2012-07-27
Reviewed by Yong Li.

getProxyAddress now returns "host:port", and getProxyPort is gone. Update NetworkJob to use
the new interface.

RIM PR: 176166
Internally reviewed by Jonathan Dong <jonathan.dong@torchmobile.com.cn>

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImprove touch adjustment for targetting small controls.
commit-queue@webkit.org [Fri, 27 Jul 2012 17:59:36 +0000 (17:59 +0000)]
Improve touch adjustment for targetting small controls.
https://bugs.webkit.org/show_bug.cgi?id=92293

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-27
Reviewed by Antonio Gomes.

Source/WebCore:

Modifies the touch adjustment algorithm to better discriminate small targets without introducing
a bias towards shorter links.  The revised scoring algorihtm uses a normalized distance to
center-line score and a normalized overlap score.  The better of the two scores is used for
determining the best candidate for target adjustment.  The center-line score works well
for discriminating elements with partial overlaps, where relying solely on percent overlap
could bias towards the smaller element.  Conversely, a high percentage in overlap provides a
strong measure of confidence in a candidate target.  An additonal tie-break algorithm is
introduced to minimize the adjustment distance if two equally suitable candidates are found.

Test: touchadjustment/small-target-test.html

* page/TouchAdjustment.cpp:
(TouchAdjustment):
(WebCore::TouchAdjustment::nodeRespondsToTapGesture):
(WebCore::TouchAdjustment::hybridDistanceFunction):
(WebCore::TouchAdjustment::findNodeWithLowestDistanceMetric):
(WebCore::findBestClickableCandidate):

LayoutTests:

Adds a test for cases that were problematic for the touch adjustment algorithm.  Each example
in the test involves a small control immediately adjacent to a larger control.  When the touch
area is significantly larger than the small control, it was possible for the touch element to
completely overlap the control yet select an adjacent element with a partial overlap.

* touchadjustment/small-target-test-expected.txt: Added.
* touchadjustment/small-target-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Calendar for input type=date should be larger on devices that support...
commit-queue@webkit.org [Fri, 27 Jul 2012 17:56:49 +0000 (17:56 +0000)]
[chromium] Calendar for input type=date should be larger on devices that support touch input.
https://bugs.webkit.org/show_bug.cgi?id=92424

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-27
Reviewed by Kent Tamura.

Source/WebCore:

Adds touch specific CSS rules to enlarge entries in the calendar on
screens that support touch input.

Manually tested with touch support enabled/disabled.

* Resources/calendarPicker.css:
(@media (pointer:coarse)):
* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::contentSize):

Source/WebKit/chromium:

Plumbs the deviceSupportsTouch setting through to the popup page so
that the Calendar popup can be enlarged on screens that support touch
input.

* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::initPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add missing baselines for fast/table/table-row-outline-paint.html
commit-queue@webkit.org [Fri, 27 Jul 2012 17:50:52 +0000 (17:50 +0000)]
[EFL] Add missing baselines for fast/table/table-row-outline-paint.html
https://bugs.webkit.org/show_bug.cgi?id=92509

Unreviewed EFL gardening, add missing results for
fast/table/table-row-outline-paint.html after r123793.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-27

* platform/efl/fast/table/table-row-outline-paint-expected.png: Added.
* platform/efl/fast/table/table-row-outline-paint-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLose a timer in prerender-remove-after-stop.html
commit-queue@webkit.org [Fri, 27 Jul 2012 17:48:46 +0000 (17:48 +0000)]
Lose a timer in prerender-remove-after-stop.html
https://bugs.webkit.org/show_bug.cgi?id=92425

Patch by Gavin Peters <gavinp@chromium.org> on 2012-07-27
Reviewed by Nate Chapin.

japhet suggested that the timer wasn't needed, and testing revealed that the test works without it. I've tested that if the bug is reintroduced
that it crashes, and of course it doesn't crash with the fix. So bye-bye setTimeout!

* fast/dom/HTMLLinkElement/prerender-remove-after-stop.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Switch InputHandler malloc use to fastMalloc for cases that should never...
commit-queue@webkit.org [Fri, 27 Jul 2012 17:39:54 +0000 (17:39 +0000)]
[BlackBerry] Switch InputHandler malloc use to fastMalloc for cases that should never fail
https://bugs.webkit.org/show_bug.cgi?id=92508

Patch by Mike Fenton <mifenton@rim.com> on 2012-07-27
Reviewed by Yong Li.

Replace common uses of malloc with fastMalloc rather
than trying to recover gracefully.  If we are truly
out of memory, crash before corruption occurs.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::spannableTextInRange):
(BlackBerry::WebKit::InputHandler::extractedTextRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123885 268f45cc-cd09-0410-ab3c-d52691b4dbfc