WebKit-https.git
3 years agoRefactor helper methods for getting random values for a stage.
jonlee@apple.com [Sat, 6 Feb 2016 23:31:51 +0000 (23:31 +0000)]
Refactor helper methods for getting random values for a stage.

Instead of requiring a Stage instance, just attach it to the Stage object.

* Animometer/tests/bouncing-particles/resources/bouncing-canvas-shapes.js:
* Animometer/tests/bouncing-particles/resources/bouncing-css-shapes.js:
* Animometer/tests/bouncing-particles/resources/bouncing-particles.js:
* Animometer/tests/bouncing-particles/resources/bouncing-svg-shapes.js:
* Animometer/tests/master/resources/canvas-tests.js:
* Animometer/tests/master/resources/particles.js:
* Animometer/tests/misc/resources/canvas-electrons.js:
* Animometer/tests/misc/resources/canvas-stars.js:
* Animometer/tests/misc/resources/compositing-transforms.js:
* Animometer/tests/resources/main.js:
* Animometer/tests/simple/resources/simple-canvas-paths.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFinish auditing call sites of upper() and lower(), eliminate many, and rename the...
darin@apple.com [Sat, 6 Feb 2016 23:18:47 +0000 (23:18 +0000)]
Finish auditing call sites of upper() and lower(), eliminate many, and rename the functions
https://bugs.webkit.org/show_bug.cgi?id=153905

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* runtime/IntlObject.cpp:
(JSC::canonicalLangTag): Use converToASCIIUppercase on the language tag.

* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncToLowerCase): Tweak style and update for name change.
(JSC::stringProtoFuncToUpperCase): Ditto.

Source/WebCore:

* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::isTypeSupported): Use convertToASCIILowercase on MIME type.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::selectText): Use new names for lower and upper. Also
tweaked style a tiny bit and used u_toupper rather than converting an entire
string to uppercase.

* dom/Document.cpp:
(WebCore::Document::addImageElementByCaseFoldedUsemap): Renamed to reflect the use
of case folding rather than lowercasing.
(WebCore::Document::removeImageElementByCaseFoldedUsemap): Ditto.
(WebCore::Document::imageElementByCaseFoldedUsemap): Ditto.
* dom/Document.h: Ditto.
* dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::getElementByCaseFoldedMapName): Ditto.
(WebCore::DocumentOrderedMap::getElementByCaseFoldedUsemap): Ditto.
* dom/DocumentOrderedMap.h: Ditto.

* dom/TreeScope.cpp:
(WebCore::TreeScope::getImageMap): Removed unneeded special case for null string.
Simplified logic for cases where the URL does not have a "#" character in it.
Use case folding instead of lowercase.

* editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_processText): Removed unneded special case for the empty string.
Use makCapitalized instead of Cocoa function for "capitalize". Use upper and lower
functions by their new names.

* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute): Use case folding instead of
lowerasing for the usemap attribute.
(WebCore::HTMLImageElement::insertedInto): Ditto.
(WebCore::HTMLImageElement::removedFrom): Ditto.
(WebCore::HTMLImageElement::matchesCaseFoldedUsemap): Ditto.
* html/HTMLImageElement.h: Rename since usemap is case folded now, not lowercased.

* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement): Use case folding instead of lowercasing
for usemap.
(WebCore::HTMLMapElement::parseAttribute): Ditto.

* platform/Language.cpp:
(WebCore::canonicalLanguageIdentifier): Use convertToASCIILowercase for language code.
(WebCore::indexOfBestMatchingLanguageInList): Ditto.

* platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Use new name for the upper function.

* platform/network/HTTPParsers.cpp:
(WebCore::parseContentTypeOptionsHeader): Use equalLettersIgnoringASCIICase instead
of lowercasing to check for a specific header value.

* platform/network/MIMEHeader.cpp:
(WebCore::retrieveKeyValuePairs): Use convertToASCIILowercase for MIME header name.
(WebCore::MIMEHeader::parseContentTransferEncoding): Use equalLettersIgnoringASCIICase
instead of lowercasing.

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::allowsAnyHTTPSCertificateHosts): Make this hash ASCII case-insensitive.
(WebCore::clientCertificates): Ditto.
(WebCore::ResourceHandle::createCFURLConnection): Remove call to lower since the
set is now ASCII case-insensitive.
(WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate): Ditto.
(WebCore::ResourceHandle::setClientCertificate): Ditto.

* platform/network/curl/CookieJarCurl.cpp:
(WebCore::getNetscapeCookieFormat): Use equalLettersIgnoringASCIICase instead of
lowercasing.

* platform/network/curl/MultipartHandle.cpp:
(WebCore::MultipartHandle::didReceiveResponse): Use convertToASCIILowercase to
make a MIME type lowercase.

* platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate): Removed unneeded
conversion to lowercase now that the set is ASCII case-insensitive.
(WebCore::ResourceHandle::setClientCertificate): Removed code that populates a map
that is then never used for anything.

* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::headerCallback): Use convertToASCIILowercase for MIME type.

* platform/network/curl/SSLHandle.cpp: Made hash maps keyed by host names
ASCII case-insensitive.
(WebCore::addAllowedClientCertificate): Removed lowercasing since the map itself
is now ASCII case insensitve.
(WebCore::setSSLClientCertificate): Ditto. Also use auto for iterator type so we
don't have to write out the map type.
(WebCore::sslIgnoreHTTPSCertificate): Ditto.
(WebCore::certVerifyCallback): Ditto.

* platform/network/soup/ResourceHandleSoup.cpp: Made hash maps keyed by host names
ASCII case-insensitive.
(WebCore::allowsAnyHTTPSCertificateHosts): Ditto.
(WebCore::handleUnignoredTLSErrors): Ditto.
(WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate): Ditto.
(WebCore::ResourceHandle::setClientCertificate): Ditto.

* platform/text/LocaleToScriptMappingDefault.cpp: Made hash maps keyed by script
names ASCII case-insensitive. USE WTF_ARRAY_LENGTH as appropriate.
(WebCore::scriptNameToCode): Use modern style to initialize the map. Removed
unnecessary lowercasing of the script name before looking at the map.
(WebCore::localeToScriptCodeForFontSelection): Ditto.

* platform/text/win/LocaleWin.cpp:
(WebCore::convertLocaleNameToLCID): Made map ASCII case-insensitive and removed
unneeded lowercasing.

* platform/win/PasteboardWin.cpp:
(WebCore::clipboardTypeFromMIMEType): Use equalLettersIgnoringASCIICase instead
of lowercasing.

* rendering/RenderText.cpp:
(WebCore::applyTextTransform): Use new names for the upper and lower functions.

* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseIsXML): Remove unneeded lowercasing, since
DOMImplementation now has ASCII case-insensitive handling of MIME types.

Source/WebKit/mac:

* Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage getPluginInfoFromPLists]): Use modern for loops.
(-[WebBasePluginPackage supportsExtension:]): Use convertToASCIILowercase for extension assert.
Also use modern for loop.
(-[WebBasePluginPackage supportsMIMEType:]): Ditto.
(-[WebBasePluginPackage MIMETypeForExtension:]): Ditto.

Source/WebKit/win:

* Plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::pluginForMIMEType): Use ASCII case-insensitive map rather
than lowercasing the MIME type.
(WebCore::PluginDatabase::setPreferredPluginForMIMEType): Ditto.

* Plugins/PluginDatabase.h: Make m_preferredPlugins use an ASCII case-insensitive hash.

* Plugins/PluginPackage.h: Use ASCII case-insensitive hash for maps keyed by MIME type.

* Plugins/PluginPackageWin.cpp:
(WebCore::PluginPackage::fetchInfo): Use convertToASCIILowercase to lowercase a MIME type.

Source/WebKit2:

* NetworkProcess/CustomProtocols/CustomProtocolManager.h: Use ASCII case-insensitive hash
for set of registered schemes.

* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getPluginInfoFromPropertyLists): Use convertToASCIILowercase for MIME type and
for file extensions.

* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::NetscapePluginModule::parseMIMEDescription): Use convertToASCIILowercase for
MIME description.

* UIProcess/API/efl/ewk_context.cpp:
(ewk_context_preferred_languages_set): Use convertToASCIILowercase for language.

* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_set_preferred_languages): Use convertToASCIILowercase for language.

* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::findPluginForExtension): Use Vector::contains instead of
writing it out using std::find.
(WebKit::pathExtension): Lowercase the result with convertToASCIILowercase instead of
leaving that to the caller.
(WebKit::PluginInfoStore::findPlugin): Removed call to lower since pathExtension
handles that now.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin): Use convertToASCIILowercase for MIME type.

* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::globalURLSchemesWithCustomProtocolHandlers): Use
an ASCII case-insensitive hash.
(WebKit::WebProcessPool::registerGlobalURLSchemeAsHavingCustomProtocolHandlers):
Remove lowercasing, since the hash is now ASCII case-insensitive.
(WebKit::WebProcessPool::unregisterGlobalURLSchemeAsHavingCustomProtocolHandlers):
Ditto.

* UIProcess/WebProcessPool.h: Use an ASCII case-insensitive hash.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::initialize): Use convertToASCIILowercase on parameter names
and values.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::pluginSupportsExtension): Use convertToASCIILowercase for extension assertion.
Also use a modern for loop.
(WebKit::WebFrameLoaderClient::objectContentType): Make the checks for empty MIME types
a little less redundant. Reordered logic to avoid checking the list of supported MIME
types extra times, and to eliminate the need for a boolean. Use convertToASCIILowercase
on the extension.

Source/WTF:

* wtf/text/AtomicString.cpp:
(WTF::AtomicString::lower): Deleted.
* wtf/text/AtomicString.h: Deleted the lower function.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::convertToLowercaseWithoutLocale): Renamed from lower.
(WTF::StringImpl::convertToUppercaseWithoutLocale): Renamed from upper.
(WTF::StringImpl::convertToLowercaseWithLocale): Renamed from lower.
(WTF::StringImpl::convertToUppercaseWithLocale): Renamed from upper.
(WTF::StringImpl::foldCase): Added fast cases for ASCII since this is
now used in some more-performance-critical code.
* wtf/text/StringImpl.h: Renamed lower and upper.

* wtf/text/WTFString.cpp:
(WTF::String::convertToLowercaseWithoutLocale): Renamed from lower.
(WTF::String::convertToUppercaseWithoutLocale): Renamed from upper.
(WTF::String::convertToLowercaseWithLocale): Renamed from lower.
(WTF::String::convertToUppercaseWithLocale): Renamed from upper.
* wtf/text/WTFString.h: Renamed lower and upper. Removed unneeded comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoOutline should contribute to visual overflow.
zalan@apple.com [Sat, 6 Feb 2016 23:07:54 +0000 (23:07 +0000)]
Outline should contribute to visual overflow.
https://bugs.webkit.org/show_bug.cgi?id=153299

This patch eliminates the special outline handling (RenderView::setMaximalOutlineSize).
Now that outline is part of visual overflow, we don't have to inflate the layers to accomodate
outline borders.
This patch fixes several focusring related repaint issues. However when both the outline: auto
and the descendant renderer are composited, we still don't paint properly in certain cases. -not a regression.
(Also when parent renderer has overflow: hidden repaint does not take outline into account. -regression.)
It changes column behavior (see TestExpectations) since outline behaves now like any other visual overflow properties.

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/repaint/focus-ring-repaint.html
      fast/repaint/focus-ring-repaint-with-negative-offset.html

* css/html.css: resetting to old behavior.
(:focus):
(input:focus, textarea:focus, isindex:focus, keygen:focus, select:focus):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::addOutlineVisualOverflow):
(WebCore::InlineFlowBox::computeOverflow):
(WebCore::InlineFlowBox::paint): Deleted.
* rendering/InlineFlowBox.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::outlineStyleForRepaint):
(WebCore::RenderBlock::paint): Deleted.
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlock): Deleted.
(WebCore::RenderBlockFlow::addFocusRingRectsForInlineChildren): Deleted.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::addOverflowFromInlineChildren):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::addVisualEffectOverflow):
(WebCore::RenderBox::applyVisualEffectOverflow):
(WebCore::RenderBox::clippedOverflowRectForRepaint): Deleted.
* rendering/RenderBoxModelObject.h:
* rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::paint): Deleted.
* rendering/RenderElement.cpp:
(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::styleDidChange):
(WebCore::RenderElement::repaintAfterLayoutIfNeeded):
(WebCore::RenderElement::issueRepaintForOutlineAuto):
(WebCore::RenderElement::updateOutlineAutoAncestor):
(WebCore::RenderElement::computeMaxOutlineSize): Deleted.
(WebCore::RenderElement::styleWillChange): Deleted.
* rendering/RenderElement.h:
(WebCore::RenderElement::hasContinuation):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutlineForLine): Deleted.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::isOutlinePhase): Deleted.
* rendering/RenderLineBoxList.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::computePreferredLogicalWidths):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint): Deleted.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::propagateRepaintToParentWithOutlineAutoIfNeeded): The renderer with outline: auto is responsible for
painting focusring around the descendants. If we issued repaint only on the descendant when it changes,
the focusring would not refresh properly. We have to find the ancestor with outline: auto, inflate the repaint rect and
issue the repaint on the ancestor if we crossed repaint container.

(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::adjustRectForOutlineAndShadow):
(WebCore::RenderObject::setHasOutlineAutoAncestor):
(WebCore::RenderObject::adjustRectWithMaximumOutline): Deleted.

* rendering/RenderObject.h: We mark the descendants of outline: auto so that
when a child renderer changes we can propagate the repaint to the ancestor with outline.

(WebCore::RenderObject::hasOutlineAutoAncestor):
(WebCore::RenderObject::RenderObjectRareData::RenderObjectRareData):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint): Deleted.
(WebCore::RenderReplaced::clippedOverflowRectForRepaint): Deleted.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paint): Deleted.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint): Deleted.
(WebCore::RenderTableCell::paintCollapsedBorders): Deleted.
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::layout):
(WebCore::RenderTableRow::clippedOverflowRectForRepaint): Deleted.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::computeOverflowFromCells): Deleted.
(WebCore::RenderTableSection::paintObject): Deleted.
* rendering/RenderTheme.h:
(WebCore::RenderTheme::platformFocusRingWidth):
* rendering/RenderView.cpp:
(WebCore::RenderView::setMaximalOutlineSize): Deleted.
* rendering/RenderView.h:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeAffectsVisualOverflow):
(WebCore::RenderStyle::outlineWidth):
* rendering/style/RenderStyle.h:

LayoutTests:

* fast/repaint/focus-ring-repaint-expected.txt: Added.
* fast/repaint/focus-ring-repaint.html: Added.
* fast/repaint/focus-ring-repaint-expected-with-negative-offset.txt: Added.
* fast/repaint/focus-ring-repaint-with-negative-offset.html: Added.
* TestExpectations:
* platform/mac/TestExpectations:
* platform/mac/compositing/geometry/ancestor-overflow-change-expected.txt:
* platform/mac/compositing/geometry/composited-in-columns-expected.txt:
* platform/mac/compositing/layer-creation/overlap-animation-container-expected.txt:
* platform/mac/compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
* platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
* platform/mac/fast/clip/outline-overflowClip-expected.txt:
* platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt:
* platform/mac/fast/repaint/4776765-expected.txt: Added.
* platform/mac/fast/repaint/focus-ring-expected.txt: Added.
* platform/mac/fast/repaint/layer-outline-expected.txt:
* platform/mac/fast/repaint/layer-outline-horizontal-expected.txt:
* platform/mac/svg/custom/focus-ring-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] Various tests are flaky
mcatanzaro@igalia.com [Sat, 6 Feb 2016 18:14:51 +0000 (18:14 +0000)]
[GTK] Various tests are flaky

More unreviewed test gardening.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoObject.getOwnPropertyDescriptor() does not work on sub-frame's window
cdumez@apple.com [Sat, 6 Feb 2016 18:12:18 +0000 (18:12 +0000)]
Object.getOwnPropertyDescriptor() does not work on sub-frame's window
https://bugs.webkit.org/show_bug.cgi?id=153925

Reviewed by Darin Adler.

Source/JavaScriptCore:

Calling Object.getOwnPropertyDescriptor() on a sub-frame's window was
returning undefined for that window's own properties. The reason was
that the check getOwnPropertySlot() is using to make sure the
PropertySlot is not for a property coming from the prototype was wrong.

The check was checking that 'this != slotBase' which works fine unless
this is a JSProxy (e.g. JSDOMWindowShell). To handle proxies, the code
was also checking that 'slotBase.toThis() != this', attempting to
get the slotBase/Window's proxy. However, due to the implementation of
toThis(), we were getting the lexical global object's proxy instead of
slotBase's proxy. To avoid this issue, the new code explicitly checks
if 'this' is a JSProxy and makes sure 'JSProxy::target() != slotBase',
instead of using toThis().

* runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertyDescriptor):

LayoutTests:

* fast/dom/Window/getOwnPropertyDescriptor-other-window-expected.txt: Added.
* fast/dom/Window/getOwnPropertyDescriptor-other-window.html: Added.
Add test case to test calling Object.getOwnPropertyDescriptor() on a
sub-frame's window.

* http/tests/security/cross-origin-window-property-access-expected.txt:
* http/tests/security/cross-origin-window-property-access.html:
- Update test use use an iframe instead of opening a Window for convenience.
- Use an actual cross-origin URL. The previous URL was same-origin and therefore
  the test would have failed if window.location was a proper getter/setter
  instead of a 'value' descriptor.
- Add more tests to cover other Window properties (such as 'name') which are
  actual getter / setters to make sure using the current window's getter on
  a cross origin window does not bypass the security origin checks.

* http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt:
* http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html:
- Drop checks for properties for which cross-origin access via
getOwnPropertyDescriptor() now works. They used to not work because of the bug
this patch fixes, and not due to security checks.
- Most of these properties are part of the properties that the specification
states can be accessed cross-origin:
  https://html.spec.whatwg.org/multipage/browsers.html#security-window
- ALL of these properties could already be accessed cross origin via regular
property getters (e.g. crossOriginWindow.blur) in Safari 9 so there should not
be any reason for getOwnPropertyDescriptor() not to work.
- I have also verified that Firefox allows cross-origin access for all these
  properties (via regular getters or getOwnPropertyDescriptor), except for
  the 'history' property. We may want to align our behavior here and prevent
  cross-origin access to 'window.history' but this is not a regression in this
  patch. You could already access crossOriginWindow.history in Safari 9.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] Various tests are flaky
mcatanzaro@igalia.com [Sat, 6 Feb 2016 17:26:55 +0000 (17:26 +0000)]
[GTK] Various tests are flaky

Unreviewed test gardening.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] Gardening for unexpected passes
mcatanzaro@igalia.com [Sat, 6 Feb 2016 17:01:31 +0000 (17:01 +0000)]
[GTK] Gardening for unexpected passes

Unreviewed test gardening.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[iOS] Throw away linked code when navigating to a new page.
akling@apple.com [Sat, 6 Feb 2016 17:00:30 +0000 (17:00 +0000)]
[iOS] Throw away linked code when navigating to a new page.
<https://webkit.org/b/153851>

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Add a VM API for throwing away linked code only.

* runtime/VM.cpp:
(JSC::VM::deleteAllLinkedCode):
* runtime/VM.h:

Source/WebCore:

When navigating to a new page, tell JSC to throw out any linked code it has lying around.
Linked code is tied to a specific global object, and as we're creating a new one for the
new page, none of it is useful to us here.

In the event that the user navigates back, the cost of relinking some code will be far
lower than the memory cost of keeping all of it around.

This landed previously but was rolled out due to a Speedometer regression. I've made one
minor but important change here: only throw away code if we're navigating away from an
existing history item. Or in other words, don't throw away code for "force peeks" or any
other navigations that are not traditional top-level main frame navigations.

* bindings/js/GCController.cpp:
(WebCore::GCController::deleteAllLinkedCode):
* bindings/js/GCController.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdded implementations of AXObjectCache methods for !HAVE(ACCESSIBILITY).
commit-queue@webkit.org [Sat, 6 Feb 2016 13:44:34 +0000 (13:44 +0000)]
Added implementations of AXObjectCache methods for !HAVE(ACCESSIBILITY).
https://bugs.webkit.org/show_bug.cgi?id=153924

Patch by Konstantin Tokarev <annulen@yandex.ru> on 2016-02-06
Reviewed by Andreas Kling.

No new tests needed.

* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::ariaModalNode): Added stub implementation.
(WebCore::AXObjectCache::postLiveRegionChangeNotification): Ditto.
(WebCore::AXObjectCache::rangeForNodeContents): Ditto.
(WebCore::AXObjectCache::setIsSynchronizingSelection): Ditto.
(WebCore::AXObjectCache::setTextSelectionIntent): Ditto.
(WebCore::AXAttributeCacheEnabler::AXAttributeCacheEnabler): Ditto.
(WebCore::AXAttributeCacheEnabler::~AXAttributeCacheEnabler): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUse scope stack instead of nested TreeResolvers for shadow trees
antti@apple.com [Sat, 6 Feb 2016 12:51:06 +0000 (12:51 +0000)]
Use scope stack instead of nested TreeResolvers for shadow trees
https://bugs.webkit.org/show_bug.cgi?id=153893

Reviewed by Andreas Kling.

Make TreeResolver per-document. This is a step towards iterative style resolve.

This is done replacing use of nested TreeResolvers with a scope stack that maintains
the style resolver and the selector filter for the current tree scope.

* style/StyleTreeResolver.cpp:
(WebCore::Style::ensurePlaceholderStyle):
(WebCore::Style::TreeResolver::Scope::Scope):
(WebCore::Style::TreeResolver::TreeResolver):
(WebCore::Style::shouldCreateRenderer):
(WebCore::Style::TreeResolver::styleForElement):
(WebCore::Style::TreeResolver::createRenderTreeForShadowRoot):
(WebCore::Style::TreeResolver::createRenderTreeForSlotAssignees):
(WebCore::Style::TreeResolver::createRenderTreeRecursively):
(WebCore::Style::TreeResolver::resolveLocally):
(WebCore::Style::TreeResolver::resolveShadowTree):
(WebCore::Style::TreeResolver::resolveBeforeOrAfterPseudoElement):
(WebCore::Style::TreeResolver::resolveChildren):
(WebCore::Style::TreeResolver::resolveSlotAssignees):
(WebCore::Style::TreeResolver::resolveRecursively):
(WebCore::Style::TreeResolver::resolve):
(WebCore::Style::detachRenderTree):
* style/StyleTreeResolver.h:
(WebCore::Style::TreeResolver::scope):
(WebCore::Style::TreeResolver::pushScope):
(WebCore::Style::TreeResolver::pushEnclosingScope):
(WebCore::Style::TreeResolver::popScope):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed. Fix more incorrect ASSERT introduced in r196053.
carlosgc@webkit.org [Sat, 6 Feb 2016 11:29:44 +0000 (11:29 +0000)]
Unreviewed. Fix more incorrect ASSERT introduced in r196053.

* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePluginX11::handleMouseEvent):
(WebKit::NetscapePluginX11::handleWheelEvent):
(WebKit::NetscapePluginX11::setFocus):
(WebKit::NetscapePluginX11::handleMouseEnterEvent):
(WebKit::NetscapePluginX11::handleMouseLeaveEvent):
(WebKit::NetscapePluginX11::handleKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, rolling out r196104.
commit-queue@webkit.org [Sat, 6 Feb 2016 10:12:30 +0000 (10:12 +0000)]
Unreviewed, rolling out r196104.
https://bugs.webkit.org/show_bug.cgi?id=153940

Regressed Speedometer on iOS (Requested by kling on #webkit).

Reverted changeset:

"[iOS] Throw away linked code when navigating to a new page."
https://bugs.webkit.org/show_bug.cgi?id=153851
http://trac.webkit.org/changeset/196104

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agotests fail if display sleeps while run-webkit-tests is running
aakash_jain@apple.com [Sat, 6 Feb 2016 07:00:56 +0000 (07:00 +0000)]
tests fail if display sleeps while run-webkit-tests is running
https://bugs.webkit.org/show_bug.cgi?id=153919

Reviewed by Alexey Proskuryakov.

* DumpRenderTree/mac/LayoutTestHelper.m:
(addDisplaySleepAssertion): Add the assertion so that the display doesn't turn off.
(releaseDisplaySleepAssertion): Release the DisplaySleep Assertion.
(simpleSignalHandler): Release the DisplaySleepAssertion in case of any iterrupt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd a new graphics test for CanvasRenderingContext2D functions: getImageData and...
commit-queue@webkit.org [Sat, 6 Feb 2016 06:21:37 +0000 (06:21 +0000)]
Add a new graphics test for CanvasRenderingContext2D functions: getImageData and putImageData
https://bugs.webkit.org/show_bug.cgi?id=151716

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-02-05
Reviewed by Darin Adler.

The purpose of this test is to measure the performance of getImageData
and putImageData functions. This test draws a background on the canvas
and then gets some random tiles from this background and draw them in
destinations different from their original sources.

* Animometer/resources/debug-runner/tests.js: Adding the new test to the canvas simple tests suite.

* Animometer/resources/extensions.js:
(Array.prototype.shuffle): Shuffles the elements of an array.

(Point.zero): Returns a new Point object whose x and y are equal zero.
(Point.prototype.str): Used for debugging the Point object.

* Animometer/tests/simple/resources/tiled-canvas-image.js: Added.
(CanvasImageTile):
(CanvasImageTile.prototype.getImageData):
(CanvasImageTile.prototype.putImageData):
(Stage.call.initialize):
(Stage.call._createTiles):
(Stage.call._nextTilePosition):
(Stage.call.tune):
(Stage.call._drawBackground):
(Stage.call.animate):
(Stage.call.complexity):
(Stage.call):
* Animometer/tests/simple/tiled-canvas-image.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] Unreviewed test expectations gardening.
mcatanzaro@igalia.com [Sat, 6 Feb 2016 04:53:22 +0000 (04:53 +0000)]
[GTK] Unreviewed test expectations gardening.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoScrollbarPainters needs to be deallocated on the main thread
bdakin@apple.com [Sat, 6 Feb 2016 01:24:32 +0000 (01:24 +0000)]
ScrollbarPainters needs to be deallocated on the main thread
https://bugs.webkit.org/show_bug.cgi?id=153932
-and corresponding-
rdar://problem/24015483

Reviewed by Geoff Garen.

Follow-up fix since the first one was still race-y.
* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::~ScrollingTreeFrameScrollingNodeMac):
(WebCore::ScrollingTreeFrameScrollingNodeMac::updateBeforeChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Visual Styles sidebar should be more forgiving to long labels
commit-queue@webkit.org [Sat, 6 Feb 2016 01:15:13 +0000 (01:15 +0000)]
Web Inspector: Visual Styles sidebar should be more forgiving to long labels
https://bugs.webkit.org/show_bug.cgi?id=153927
<rdar://problem/24343897>

Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2016-02-05
Reviewed by Timothy Hatcher.

If a label is too long for it's container, it overflows and is visible
above the rest of the elements nearby.

* UserInterface/Views/VisualStylePropertyEditor.css:
(.visual-style-property-container > .visual-style-property-title):
Adds text overflow to properties that extend beyond the container's width.

* UserInterface/Views/VisualStylePropertyEditor.js:
(WebInspector.VisualStylePropertyEditor):
Now also adds the label value as a title attribute to the element, just in
case the content overflows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoScrollbarPainters needs to be deallocated on the main thread
bdakin@apple.com [Sat, 6 Feb 2016 01:08:43 +0000 (01:08 +0000)]
ScrollbarPainters needs to be deallocated on the main thread
https://bugs.webkit.org/show_bug.cgi?id=153932
-and corresponding-
rdar://problem/24015483

Reviewed by Tim Horton.

Ensure the the destructor of ScrollingTreeFrameScrollingNodeMac and the
assignments done in this class are not responsible for deallocating the
ScrollbarPainter.
* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::~ScrollingTreeFrameScrollingNodeMac):
(WebCore::ScrollingTreeFrameScrollingNodeMac::updateBeforeChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMark css3/filters/multiple-filters-invalidation.html as flaky on ios-simulator
ryanhaddad@apple.com [Sat, 6 Feb 2016 01:08:25 +0000 (01:08 +0000)]
Mark css3/filters/multiple-filters-invalidation.html  as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153933

Unreviewed test gardening.

* platform/ios-simulator/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMarking pageoverlay/overlay-small-frame-paints.html as flaky on ios-simulator
ryanhaddad@apple.com [Sat, 6 Feb 2016 00:49:40 +0000 (00:49 +0000)]
Marking pageoverlay/overlay-small-frame-paints.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153898

Unreviewed test gardening.

* platform/ios-simulator/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMarking css3-text-decoration/text-underline-position/underline-visual-overflow-with...
ryanhaddad@apple.com [Sat, 6 Feb 2016 00:20:02 +0000 (00:20 +0000)]
Marking css3-text-decoration/text-underline-position/underline-visual-overflow-with-subpixel-position.html as failing on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153315

Unreviewed test gardening.

* platform/ios-simulator/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoInstance property getters / setters cannot be called on another instance of the same...
cdumez@apple.com [Sat, 6 Feb 2016 00:18:41 +0000 (00:18 +0000)]
Instance property getters / setters cannot be called on another instance of the same type
https://bugs.webkit.org/show_bug.cgi?id=153895

Reviewed by Gavin Barraclough.

Source/WebCore:

It should be possible to call instance property getters / setters on
other instances of the same type, as per the WEB IDL specification:
- http://heycam.github.io/webidl/#dfn-attribute-getter
- http://heycam.github.io/webidl/#dfn-attribute-setter

This matches the behavior of Firefox.

The issue without our bindings was that the getters / setters were
using |slotBase| instead of |thisValue| and therefore ended up using
the instance the getter was taken from instead of the actual target
object.

Test:
js/instance-property-getter-other-instance.html
js/instance-property-setter-other-instance.html

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- Have instance getters / setters use thisValue instead of slotBase.
- In the case of interfaces that have attributes on the instance for
  compatibility reasons, try the prototype object if |thisValue| does
  does have the right type, instead of using slotBase like previously.
  I believe this maintains the original compatibility intention while
  also behaving correctly when called on another instance.

* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
* bindings/scripts/test/JS/JSTestException.cpp:
* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
* bindings/scripts/test/JS/JSTestNode.cpp:
* bindings/scripts/test/JS/JSTestNondeterministic.cpp:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
* bindings/scripts/test/JS/JSattribute.cpp:
Rebaseline bindings tests.

LayoutTests:

* js/dom/script-tests/shadow-navigator-geolocation-in-strict-mode-does-not-throw.js:
* js/dom/shadow-navigator-geolocation-in-strict-mode-does-not-throw-expected.txt:
Extend this layout test coverage to cover the getter case in addition to the
setter case. This test covers the compatibility mode where we don't throw.
I made sure to maintain this behavior when refactoring the bindings to avoid
breakage.

* js/instance-property-getter-other-instance-expected.txt:
Rebaseline now that this test passes.

* js/instance-property-setter-other-instance-expected.txt: Added.
* js/instance-property-setter-other-instance.html: Added.
Add test to cover the setter case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMark http/tests/security/cross-frame-access-custom.html as flaky on ios-simulator-wk2
ryanhaddad@apple.com [Sat, 6 Feb 2016 00:13:21 +0000 (00:13 +0000)]
Mark http/tests/security/cross-frame-access-custom.html as flaky on ios-simulator-wk2
https://bugs.webkit.org/show_bug.cgi?id=153050

Unreviewed test gardening.

* platform/ios-simulator-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix internal Windows build
achristensen@apple.com [Sat, 6 Feb 2016 00:07:26 +0000 (00:07 +0000)]
Fix internal Windows build
https://bugs.webkit.org/show_bug.cgi?id=153930
<rdar://problem/24534864>

Reviewed by Mark Lam.

* JavaScriptCore.vcxproj/JavaScriptCore.proj:
I made a typo in r196144.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoSkipping js/basic-set.html on Mac since it is already runs as a part of run-jsc-stres...
ryanhaddad@apple.com [Sat, 6 Feb 2016 00:06:17 +0000 (00:06 +0000)]
Skipping js/basic-set.html on Mac since it is already runs as a part of run-jsc-stress-tests
https://bugs.webkit.org/show_bug.cgi?id=153879

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoTesting with remote server cache is unusably slow
rniwa@webkit.org [Fri, 5 Feb 2016 23:55:58 +0000 (23:55 +0000)]
Testing with remote server cache is unusably slow
https://bugs.webkit.org/show_bug.cgi?id=153928

Reviewed by Chris Dumez.

Don't use the single process mode of httpd as it's way too slow even for testing.
Also we'll hit a null pointer crash (http://svn.apache.org/viewvc?view=revision&revision=1711479)

Since httpd exits immediately when launched in multi-process mode, remote-cache-server.py (renamed from
run-with-remote-server.py) now has "start" and "stop" commands to start/stop the Apache. Also added
"reset" command to reset the cache for convenience.

* Install.md: Updated the instruction.
* config.json: Fixed a typo: httpdErro*r*Log.
* tools/remote-cache-server.py: Copied from Websites/perf.webkit.org/tools/run-with-remote-server.py.
Now takes one of the following commands: "start", "stop", and "reset".
(main):
(start_httpd): Extracted from main.
(stop_httpd): Added.
* tools/remote-server-relay.conf: Removed redundant (duplicate) LoadModule's.
* tools/run-with-remote-server.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMarking imported/w3c/web-platform-tests/html/semantics/document-metadata/styling...
ryanhaddad@apple.com [Fri, 5 Feb 2016 23:32:54 +0000 (23:32 +0000)]
Marking imported/w3c/web-platform-tests/html/semantics/document-metadata/styling/LinkStyle.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153929

Unreviewed test gardening.

* platform/ios-simulator/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Include SamplingProfiler's expression-level data for stack frames...
sbarati@apple.com [Fri, 5 Feb 2016 23:25:23 +0000 (23:25 +0000)]
Web Inspector: Include SamplingProfiler's expression-level data for stack frames in the protocol
https://bugs.webkit.org/show_bug.cgi?id=153455
<rdar://problem/24335884>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

We now send the sampling profiler's expression-level
line/column info in the inspector protocol.

* inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::buildSamples):
* inspector/protocol/ScriptProfiler.json:
* runtime/SamplingProfiler.h:
(JSC::SamplingProfiler::StackFrame::hasExpressionInfo):

Source/WebInspectorUI:

JSC has been collecting expression-level data in the sampling
profiler, and with this patch, we now get that information
in the inspector. With this information, we probably have
all the data we need to make real heat maps.

* UserInterface/Models/CallingContextTree.js:
(WebInspector.CallingContextTree.prototype.updateTreeWithStackTrace):
(WebInspector.CCTNode):
(WebInspector.CCTNode.prototype.findOrMakeChild):
(WebInspector.CCTNode.prototype.addTimestampAndExpressionLocation):
(WebInspector.CCTNode.prototype.addTimestamp): Deleted.

LayoutTests:

* inspector/sampling-profiler/expression-location-info-expected.txt: Added.
* inspector/sampling-profiler/expression-location-info.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoModern IDB: UniqueIDBDatabase's m_databaseInfo is unsafely used from multiple threads.
beidson@apple.com [Fri, 5 Feb 2016 22:30:04 +0000 (22:30 +0000)]
Modern IDB: UniqueIDBDatabase's m_databaseInfo is unsafely used from multiple threads.
https://bugs.webkit.org/show_bug.cgi?id=153912

Reviewed by Alex Christensen.

No new tests (Anything testable about this patch is already covered by existing tests).

* Modules/indexeddb/server/IDBBackingStore.h:

* Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::infoForObjectStore):
* Modules/indexeddb/server/MemoryIDBBackingStore.h:

Teach the SQLiteIDBBackingStore to actually keep its m_databaseInfo up to date as it changes,
and to revert it when version change transactions abort:
* Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::beginTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::abortTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::commitTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::infoForObjectStore):
* Modules/indexeddb/server/SQLiteIDBBackingStore.h:

* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd): Use the IDBBackingStore's copy of the
  IDBObjectStoreInfo, meant only for the database thread, instead of the UniqueIDBDatabase's copy,
  which is meant only for the main thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoPerf dashboard should have a script to setup database
rniwa@webkit.org [Fri, 5 Feb 2016 22:28:20 +0000 (22:28 +0000)]
Perf dashboard should have a script to setup database
https://bugs.webkit.org/show_bug.cgi?id=153906

Reviewed by Chris Dumez.

Added tools/setup-database.py to setup the database. It retrieves the database name, username, password
and initializes a database at the specified location.

* Install.md: Updated instruction to setup postgres to use setup-database.py.
* tools/setup-database.py: Added.
(main):
(load_database_config):
(determine_psql_dir):
(start_or_stop_database):
(execute_psql_command):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix iOS API tests after r196082
commit-queue@webkit.org [Fri, 5 Feb 2016 21:53:00 +0000 (21:53 +0000)]
Fix iOS API tests after r196082
https://bugs.webkit.org/show_bug.cgi?id=153900

Patch by Alex Christensen <achristensen@webkit.org> on 2016-02-05
Reviewed by Jer Noble.

* TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
(TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
[WebView initialize] doesn't call JSC::initializeThreading on iOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agofollow-up to: JSC Sampling Profiler: (host) is confusing in cases where I would expec...
sbarati@apple.com [Fri, 5 Feb 2016 21:41:24 +0000 (21:41 +0000)]
follow-up to: JSC Sampling Profiler: (host) is confusing in cases where I would expect to see JS name
https://bugs.webkit.org/show_bug.cgi?id=153663
<rdar://problem/24415092>

Rubber stamped by Joseph Pecoraro.

We were performing operations that required us to
hold the VM lock even when we might not have been holding it.
We now ensure we're holding it.

* inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::InspectorScriptProfilerAgent::trackingComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Navigation bar in sidebars should always fit on a single line
commit-queue@webkit.org [Fri, 5 Feb 2016 21:38:44 +0000 (21:38 +0000)]
Web Inspector: Navigation bar in sidebars should always fit on a single line
https://bugs.webkit.org/show_bug.cgi?id=153412
<rdar://problem/24318706>

Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2016-02-05
Reviewed by Timothy Hatcher.

This happened because the allowed maximum width of the sidebar was greater
than the minimum width derived from the currently visible sidebar.

* UserInterface/Base/Utilities.js:
(Number.constrain):
Added logic to reverse the values of min and max if max is less than min.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agobmalloc: largeMax calculation is wrong on iOS
sbarati@apple.com [Fri, 5 Feb 2016 21:34:27 +0000 (21:34 +0000)]
bmalloc: largeMax calculation is wrong on iOS
https://bugs.webkit.org/show_bug.cgi?id=153923

Reviewed by Mark Lam.

Our number for largeMax was larger than what we had
space to actually allocate inside the LargeChunk. This made
it so that we would allocate a large object for something
that really should be extra large. Previously:
largeMax + sizeof(LargeChunk) > 1MB
which meant that when we would grow() to accommodate an allocation
of a particular size inside a LargeObject despite the fact that
the allocation size would be too large to actually fit in the LargeObject.
This would manifest when we had an allocation size in the range:
1MB - sizeof(LargeChunk) < allocation size < largeMax

We fix this bug by being precise in our calculation of largeMax
instead of just assuming largeChunkSize * 99/100 is enough
space for the metadata.

* bmalloc/LargeChunk.h:
(bmalloc::LargeChunk::get):
* bmalloc/Sizes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Don't wrap labels in Breakpoint Editor popover
timothy@apple.com [Fri, 5 Feb 2016 21:22:39 +0000 (21:22 +0000)]
Web Inspector: Don't wrap labels in Breakpoint Editor popover
https://bugs.webkit.org/show_bug.cgi?id=153926
rdar://problem/24149542

Reviewed by Brian Burg.

* UserInterface/Views/BreakpointPopoverController.css:
(.popover .edit-breakpoint-popover-content > table > tr > th): Added white-space: nowrap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Replace all instances of '%s' with “%s“
commit-queue@webkit.org [Fri, 5 Feb 2016 21:20:52 +0000 (21:20 +0000)]
Web Inspector: Replace all instances of '%s' with “%s“
https://bugs.webkit.org/show_bug.cgi?id=153891
<rdar://problem/24510236>

Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2016-02-05
Reviewed by Timothy Hatcher.

Switched all WebInspector.UIString() from using '' to ““.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/CSSStyleDeclarationSection.js:
(WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste):
* UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded):
* UserInterface/Views/VisualStylePropertyEditor.js:
(WebInspector.VisualStylePropertyEditor.prototype.update):
* UserInterface/Views/VisualStyleSelectorTreeItem.js:
(WebInspector.VisualStyleSelectorTreeItem.prototype._updateSelectorIcon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Error when closing page with WebInspector open
timothy@apple.com [Fri, 5 Feb 2016 21:19:04 +0000 (21:19 +0000)]
Web Inspector: Error when closing page with WebInspector open
https://bugs.webkit.org/show_bug.cgi?id=152867
rdar://problem/24099423

Reviewed by Brian Burg.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::didClose): Null out m_inspectorPage after platformDetach(),
so the views can be cleaned up correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoArrayify for a typed array shouldn't create a monster
fpizlo@apple.com [Fri, 5 Feb 2016 19:52:19 +0000 (19:52 +0000)]
Arrayify for a typed array shouldn't create a monster
https://bugs.webkit.org/show_bug.cgi?id=153908
rdar://problem/24290639

Reviewed by Mark Lam.

Previously if you convinced the DFG to emit an Arrayify to ArrayStorage and then gave it a
typed array, you'd corrupt the object.

* runtime/JSArrayBufferView.cpp:
(WTF::printInternal):
* runtime/JSArrayBufferView.h:
* runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren):
(JSC::JSGenericTypedArrayView<Adaptor>::slowDownAndWasteMemory):
* runtime/JSObject.cpp:
(JSC::JSObject::copyButterfly):
(JSC::JSObject::enterDictionaryIndexingMode):
(JSC::JSObject::ensureInt32Slow):
(JSC::JSObject::ensureDoubleSlow):
(JSC::JSObject::ensureContiguousSlow):
(JSC::JSObject::ensureArrayStorageSlow):
(JSC::JSObject::growOutOfLineStorage):
(JSC::getBoundSlotBaseFunctionForGetterSetter):
* runtime/Structure.h:
* tests/stress/arrayify-array-storage-typed-array.js: Added. This test failed.
* tests/stress/arrayify-int32-typed-array.js: Added. This test case already had other protections, but we beefed them up.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMove NetworkDataTask to its own header and source files
achristensen@apple.com [Fri, 5 Feb 2016 19:51:54 +0000 (19:51 +0000)]
Move NetworkDataTask to its own header and source files
https://bugs.webkit.org/show_bug.cgi?id=153922

Reviewed by Tim Horton.

Also renamed NetworkSessionTaskClient to NetworkDataTaskClient.

* NetworkProcess/NetworkDataTask.h: Added.
(WebKit::NetworkDataTaskClient::~NetworkDataTaskClient):
(WebKit::NetworkDataTask::create):
(WebKit::NetworkDataTask::client):
(WebKit::NetworkDataTask::pendingDownloadID):
(WebKit::NetworkDataTask::pendingDownload):
(WebKit::NetworkDataTask::setPendingDownloadID):
(WebKit::NetworkDataTask::setPendingDownload):
* NetworkProcess/NetworkLoad.h:
* NetworkProcess/NetworkSession.h:
(WebKit::NetworkSessionTaskClient::~NetworkSessionTaskClient): Deleted.
(WebKit::NetworkDataTask::create): Deleted.
(WebKit::NetworkDataTask::client): Deleted.
(WebKit::NetworkDataTask::pendingDownloadID): Deleted.
(WebKit::NetworkDataTask::pendingDownload): Deleted.
(WebKit::NetworkDataTask::setPendingDownloadID): Deleted.
(WebKit::NetworkDataTask::setPendingDownload): Deleted.
* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: Added.
(WebKit::NetworkDataTask::NetworkDataTask):
(WebKit::NetworkDataTask::~NetworkDataTask):
(WebKit::NetworkDataTask::scheduleFailure):
(WebKit::NetworkDataTask::failureTimerFired):
(WebKit::NetworkDataTask::tryPasswordBasedAuthentication):
(WebKit::NetworkDataTask::cancel):
(WebKit::NetworkDataTask::resume):
(WebKit::NetworkDataTask::suspend):
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSession::takeDownloadID):
(WebKit::NetworkDataTask::NetworkDataTask): Deleted.
(WebKit::NetworkDataTask::~NetworkDataTask): Deleted.
(WebKit::NetworkDataTask::scheduleFailure): Deleted.
(WebKit::NetworkDataTask::failureTimerFired): Deleted.
(WebKit::NetworkDataTask::tryPasswordBasedAuthentication): Deleted.
(WebKit::NetworkDataTask::cancel): Deleted.
(WebKit::NetworkDataTask::resume): Deleted.
(WebKit::NetworkDataTask::suspend): Deleted.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoClean up Blob code
achristensen@apple.com [Fri, 5 Feb 2016 16:57:08 +0000 (16:57 +0000)]
Clean up Blob code
https://bugs.webkit.org/show_bug.cgi?id=153910

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests, no change in behavior.

* css/StyleSheet.h:
* fileapi/Blob.cpp:
(WebCore::Blob::Blob):
(WebCore::Blob::normalizedContentType):
(WebCore::Blob::isNormalizedContentType):
(WebCore::Blob::registry):
* fileapi/Blob.h:
* fileapi/BlobURL.cpp:
(WebCore::BlobURL::createPublicURL):
* fileapi/BlobURL.h:
(WebCore::BlobURL::BlobURL):
(WebCore::BlobURL::blobProtocol): Deleted.
* platform/PlatformStrategies.cpp:
(WebCore::setPlatformStrategies):
(WebCore::hasPlatformStrategies): Deleted.
* platform/PlatformStrategies.h:
* platform/network/BlobRegistry.cpp:
(WebCore::blobRegistry):
* platform/network/BlobRegistry.h:
* platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::~BlobRegistryImpl):
(WebCore::createResourceHandle):
(WebCore::registerBlobResourceHandleConstructor):
(WebCore::BlobRegistryImpl::createResourceHandle):
(WebCore::BlobRegistryImpl::appendStorageItems):
(WebCore::BlobRegistryImpl::registerFileBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURL):
* platform/network/BlobRegistryImpl.h:
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::loadResourceSynchronously):
(WebCore::BlobResourceHandle::BlobResourceHandle):
* platform/network/ResourceHandle.h:

Source/WebKit2:

* NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::NetworkBlobRegistry):
(WebKit::NetworkBlobRegistry::registerFileBlobURL):
* NetworkProcess/FileAPI/NetworkBlobRegistry.h:
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::registerFileBlobURL):
(WebKit::NetworkConnectionToWebProcess::registerBlobURL):
* WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::registerFileBlobURL):
* WebProcess/FileAPI/BlobRegistryProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Cocoa] Get rid of unused SPI declarations
mitz@apple.com [Fri, 5 Feb 2016 15:38:00 +0000 (15:38 +0000)]
[Cocoa] Get rid of unused SPI declarations
https://bugs.webkit.org/show_bug.cgi?id=153915

Reviewed by Tim Horton.

* Platform/spi/Cocoa/NSInvocationSPI.h: Removed NSInvocation SPI method declaration.

* Platform/spi/ios/SafariServicesSPI.h: Removed.

* UIProcess/API/Cocoa/WKSecurityOrigin.mm:
(-[WKSecurityOrigin methodSignatureForSelector:]): Deleted.
(-[WKSecurityOrigin forwardInvocation:]): Deleted.

* UIProcess/ios/WKContentViewInteraction.mm: Removed unused #import.

* WebKit2.xcodeproj/project.pbxproj: Removed reference to deleted header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] Scrollbars incorrectly rendered with older versions of GTK+
carlosgc@webkit.org [Fri, 5 Feb 2016 14:04:27 +0000 (14:04 +0000)]
[GTK] Scrollbars incorrectly rendered with older versions of GTK+
https://bugs.webkit.org/show_bug.cgi?id=153861

Reviewed by Michael Catanzaro.

The theme doesn't really know it's a scrollbar. Older versions of
GTK+ require to explicitly add the scrollbar style class to the
child GtkStyleContext.

* platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::createChildStyleContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] Scrollbars not correctly rendered in non GNOME environments
carlosgc@webkit.org [Fri, 5 Feb 2016 13:58:20 +0000 (13:58 +0000)]
[GTK] Scrollbars not correctly rendered in non GNOME environments
https://bugs.webkit.org/show_bug.cgi?id=153860

Reviewed by Michael Catanzaro.

I noticed this in a matchbox environment, where there's no
gnome-setting-daemon running. The problem is only with the
scrollbars, because we initialize the GtkSettings in
RenderThemeGtk and notify the ScrollbarTheme when it changes, but
ScrollbarTheme is created before RenderThemeGtk so we initialize
the theme properties before the GtkSettings have been
initialized. We can just let the ScrollbarTheme monitor the
theme itself instead of relying on being notified by the WebCore
layer.

* platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::themeChangedCallback):
(WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk):
* rendering/RenderThemeGtk.cpp:
(WebCore::gtkStyleChangedCallback): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRemove DOMWrapped parameter from JSKeyValueIterator
youenn.fablet@crf.canon.fr [Fri, 5 Feb 2016 09:59:15 +0000 (09:59 +0000)]
Remove DOMWrapped parameter from JSKeyValueIterator
https://bugs.webkit.org/show_bug.cgi?id=153859

Reviewed by Sam Weinig.

No change in behavior.

Using std::declval to infer DOMWrapped from JSWrapper::wrapped.

* bindings/js/JSFetchHeadersCustom.cpp:
(WebCore::JSFetchHeaders::entries):
(WebCore::JSFetchHeaders::keys):
(WebCore::JSFetchHeaders::values):
* bindings/js/JSKeyValueIterator.h:
(WebCore::createIterator):
(WebCore::JSKeyValueIterator<JSWrapper>::destroy):
(WebCore::JSKeyValueIterator<JSWrapper>::next):
(WebCore::JSKeyValueIteratorPrototypeFunctionNext):
(WebCore::JSKeyValueIteratorPrototype<JSWrapper>::finishCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoREGRESSION (r193913): Web Inspector: Wrong z-index of inner sections
nvasilyev@apple.com [Fri, 5 Feb 2016 09:03:28 +0000 (09:03 +0000)]
REGRESSION (r193913): Web Inspector: Wrong z-index of inner sections
https://bugs.webkit.org/show_bug.cgi?id=153914

Reviewed by Timothy Hatcher.

* UserInterface/Views/DetailsSection.css:
(.details-section .details-section > .header):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Decrease font-weight of inner sections
nvasilyev@apple.com [Fri, 5 Feb 2016 09:01:44 +0000 (09:01 +0000)]
Web Inspector: Decrease font-weight of inner sections
https://bugs.webkit.org/show_bug.cgi?id=153913
<rdar://problem/24520326>

Reviewed by Timothy Hatcher.

* UserInterface/Views/DetailsSection.css:
(.details-section .details-section > .header):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAX: WebKit hanging when VoiceOver attempts to focus in on page
n_wang@apple.com [Fri, 5 Feb 2016 08:53:51 +0000 (08:53 +0000)]
AX: WebKit hanging when VoiceOver attempts to focus in on page
https://bugs.webkit.org/show_bug.cgi?id=153899
<rdar://problem/24506603>

Reviewed by Chris Fleizach.

Source/WebCore:

The VisiblePosition to CharacterOffset conversion will lead to an infinite loop if the
nextVisiblePostion call is returning the original VisiblePosition. Fixed it by breaking out
of the loop early in that situation.

Test: accessibility/text-marker/character-offset-visible-position-conversion-hang.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::characterOffsetFromVisiblePosition):

LayoutTests:

* accessibility/text-marker/character-offset-visible-position-conversion-hang-expected.txt: Added.
* accessibility/text-marker/character-offset-visible-position-conversion-hang.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: console.table background stripes are misaligned
nvasilyev@apple.com [Fri, 5 Feb 2016 05:57:37 +0000 (05:57 +0000)]
Web Inspector: console.table background stripes are misaligned
https://bugs.webkit.org/show_bug.cgi?id=152954
<rdar://problem/24197735>

Reviewed by Timothy Hatcher.

* UserInterface/Views/LogContentView.css:
(.console-item .data-grid table.data):
(.console-item .data-grid table.data tr:nth-child(even)):
Replace CSS gradient that produces fixed height stripes with
a rule that sets background only on even table rows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: InspectorTimelineAgent doesn't need to recompile functions because...
commit-queue@webkit.org [Fri, 5 Feb 2016 05:24:43 +0000 (05:24 +0000)]
Web Inspector: InspectorTimelineAgent doesn't need to recompile functions because it now uses the sampling profiler
https://bugs.webkit.org/show_bug.cgi?id=153500
<rdar://problem/24352458>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-02-04
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Be more explicit about enabling legacy profiling.

* jsc.cpp:
* runtime/Executable.cpp:
(JSC::ScriptExecutable::newCodeBlockFor):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::hasLegacyProfiler):
(JSC::JSGlobalObject::createProgramCodeBlock):
(JSC::JSGlobalObject::createEvalCodeBlock):
(JSC::JSGlobalObject::createModuleProgramCodeBlock):
(JSC::JSGlobalObject::hasProfiler): Deleted.
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::supportsLegacyProfiling):
(JSC::JSGlobalObject::supportsProfiling): Deleted.

Source/WebCore:

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsLegacyProfiling):
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):
(WebCore::JSDOMWindowBase::supportsProfiling): Deleted.
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::supportsLegacyProfiling):
(WebCore::JSWorkerGlobalScopeBase::supportsProfiling): Deleted.
* bindings/js/JSWorkerGlobalScopeBase.h:
* inspector/InspectorController.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::legacyProfilerEnabled):
(WebCore::InspectorController::setLegacyProfilerEnabled):
Be more explicit about enabling legacy profiling.

* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend): Deleted.
TimelineAgent doesn't need to recompile if using the sampling profiler.
This breaks console.profile, but console.profile should move to using
the sampling profiler as well.

(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):
(WebCore::startProfiling): Deleted.
(WebCore::stopProfiling): Deleted.
Inlined the use once static functions.

* page/PageConsoleClient.cpp:
(WebCore::PageConsoleClient::profile):
(WebCore::PageConsoleClient::profileEnd):
Added FIXMEs for improving console.profile and profileEnd.

* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setLegacyJavaScriptProfilingEnabled):
(WebCore::Internals::setJavaScriptProfilingEnabled): Deleted.
* testing/Internals.h:
* testing/Internals.idl:
Be more explicit about enabling legacy profiling.

Source/WebKit/win:

* WebInspector.cpp:
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
Switch to the new API names.

LayoutTests:

* fast/profiler/*.html
Be more explicit about enabling legacy profiling.

* inspector/sampling-profiler/eval-source-url.html
Remove an inner loop that was causing tail call optimizations
to eliminate the sourceURL we were expecting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFollow-up: Add "WebKit built-in PDF" Plugin to set of publicly visible plugins
bfulgham@apple.com [Fri, 5 Feb 2016 02:01:09 +0000 (02:01 +0000)]
Follow-up: Add "WebKit built-in PDF" Plugin to set of publicly visible plugins
https://bugs.webkit.org/show_bug.cgi?id=153657
<rdar://problem/24413107>

Reviewed by Darin Adler.

* plugins/PluginData.cpp:
(WebCore::shouldBePubliclyVisible): Revise comments to provide a
better explanation of the function and why it exists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, follow-up fix to r196151 that removes some more images.
joepeck@webkit.org [Fri, 5 Feb 2016 01:31:27 +0000 (01:31 +0000)]
Unreviewed, follow-up fix to r196151 that removes some more images.

* UserInterface/Images/Colors.png: Removed.
* UserInterface/Images/Colors@2x.png: Removed.
* UserInterface/Images/Network.png: Removed.
* UserInterface/Images/Network@2x.png: Removed.
* UserInterface/Images/Script.png: Removed.
* UserInterface/Images/Script@2x.png: Removed.
These images were supposed to also be removed.

* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
Also remove references to now removed images.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoThe status message for passing combined builder queues should say "all builds succeed...
jmarcell@apple.com [Fri, 5 Feb 2016 00:51:50 +0000 (00:51 +0000)]
The status message for passing combined builder queues should say "all builds succeeded" when expanded. https://bugs.webkit.org/show_bug.cgi?id=153882

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
(BuildbotCombinedQueueView.prototype.update): Set status to "all builds succeeded" for combined builder queues
when expanded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed. EFL gardening. Mark some video tests to failure.
hs85.jeong@samsung.com [Fri, 5 Feb 2016 00:46:36 +0000 (00:46 +0000)]
Unreviewed. EFL gardening. Mark some video tests to failure.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRemove ios-simulator-wk2 specific expectation for imported/w3c/web-platform-tests...
ryanhaddad@apple.com [Fri, 5 Feb 2016 00:42:14 +0000 (00:42 +0000)]
Remove ios-simulator-wk2 specific expectation for imported/w3c/web-platform-tests/html/dom/interfaces.html
https://bugs.webkit.org/show_bug.cgi?id=153844

Unreviewed test gardening.

* platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoArrayPrototype should have a destroy function
keith_miller@apple.com [Fri, 5 Feb 2016 00:36:20 +0000 (00:36 +0000)]
ArrayPrototype should have a destroy function
https://bugs.webkit.org/show_bug.cgi?id=153847

Reviewed by Filip Pizlo.

ArrayPrototype should have an destroy function as it now has a unique_ptr member that
needs to be freed at the end of the object's life cycle. Also, this patch adds an
option, gcAtEnd, that will cause jsc.cpp to do a garbage collection before exiting.

* jsc.cpp:
(runJSC):
(jscmain):
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::create):
(JSC::ArrayPrototype::destroy):
* runtime/ArrayPrototype.h:
* runtime/Options.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd Fetch API and CSS Variables to feature status
jond@apple.com [Thu, 4 Feb 2016 23:54:33 +0000 (23:54 +0000)]
Add Fetch API and CSS Variables to feature status
https://bugs.webkit.org/show_bug.cgi?id=153896

Reviewed by Timothy Hatcher.

* features.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator
ryanhaddad@apple.com [Thu, 4 Feb 2016 23:47:06 +0000 (23:47 +0000)]
Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153844

Reviewed by Chris Dumez.

* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoREGRESSION(192409): Cannot rely on add32() to zero-extend
fpizlo@apple.com [Thu, 4 Feb 2016 23:23:31 +0000 (23:23 +0000)]
REGRESSION(192409): Cannot rely on add32() to zero-extend
https://bugs.webkit.org/show_bug.cgi?id=153897

Unreviewed rollout of r192409.

* assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::add32):
(JSC::MacroAssemblerARM64::add64):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::add32):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::add32):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::add8):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::generateTest32):
(JSC::MacroAssemblerX86Common::clz32AfterBsr):
(JSC::MacroAssemblerX86Common::add32AndSetFlags): Deleted.
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::add32):
(JSC::MacroAssemblerX86_64::add64):
(JSC::MacroAssemblerX86_64::branchAdd64):
(JSC::MacroAssemblerX86_64::repatchCall):
(JSC::MacroAssemblerX86_64::clz64AfterBsr):
(JSC::MacroAssemblerX86_64::add64AndSetFlags): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: New timeline images for instruments
commit-queue@webkit.org [Thu, 4 Feb 2016 23:13:46 +0000 (23:13 +0000)]
Web Inspector: New timeline images for instruments
https://bugs.webkit.org/show_bug.cgi?id=153884
<rdar://problem/24509429>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-02-04
Reviewed by Timothy Hatcher.

* UserInterface/Views/TimelineTabContentView.js:
(WebInspector.TimelineTabContentView.iconClassNameForTimeline):
Better names and give Memory timeline a name for an icon.

* UserInterface/Views/TreeOutline.css:
(.tree-outline.large .item .icon):
Add more padding next to large icons.

* UserInterface/Images/ColorsLarge.png: Removed.
* UserInterface/Images/ColorsLarge@2x.png: Removed.
* UserInterface/Images/Frames.png: Removed.
* UserInterface/Images/Frames@2x.png: Removed.
* UserInterface/Images/LayoutInstrument.svg: Added.
* UserInterface/Images/MemoryInstrument.svg: Added.
* UserInterface/Images/NetworkInstrument.svg: Added.
* UserInterface/Images/NetworkLarge.png: Removed.
* UserInterface/Images/NetworkLarge@2x.png: Removed.
* UserInterface/Images/RenderingFramesInstrument.svg: Added.
* UserInterface/Images/ScriptLarge.png: Removed.
* UserInterface/Images/ScriptLarge@2x.png: Removed.
Remove old timeline pngs.

* UserInterface/Images/ScriptsInstrument.svg: Added.
* UserInterface/Views/TimelineIcons.css:
(.network-icon .icon):
(.script-icon .icon):
(.memory-icon .icon):
(.layout-icon .icon):
(.rendering-frame-icon .icon):
Use the new SVGs.

(body:not(.mac-platform, .windows-platform) .network-icon .icon):
(body:not(.mac-platform, .windows-platform) .network-icon.large .icon):
(body:not(.mac-platform, .windows-platform) .layout-icon .icon):
(body:not(.mac-platform, .windows-platform) .layout-icon.large .icon):
(body:not(.mac-platform, .windows-platform) .script-icon .icon):
(body:not(.mac-platform, .windows-platform) .script-icon.large .icon):
(body:not(.mac-platform, .windows-platform) .rendering-frame-icon .icon):
Fallback to old icons for non-Mac/Windows ports using Images/gtk images.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agomedia/video-size.html is flaky
eric.carlson@apple.com [Thu, 4 Feb 2016 22:54:02 +0000 (22:54 +0000)]
media/video-size.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=124932
<rdar://problem/23336430>

Reviewed by Jer Noble.

* media/video-size.html: Add logic to retry each stage silently twice before logging
  failure because we can't predict how long it will take to load the poster frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRemove dead ENABLE(BYTECODE_COMMENTS) cruft.
akling@apple.com [Thu, 4 Feb 2016 22:07:45 +0000 (22:07 +0000)]
Remove dead ENABLE(BYTECODE_COMMENTS) cruft.
<https://webkit.org/b/153888>

Reviewed by Antti Koivisto.

* bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock): Deleted.
* bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::shrinkToFit): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWebKit for iOS Simulator fails to build with public iOS SDK
dbates@webkit.org [Thu, 4 Feb 2016 21:52:42 +0000 (21:52 +0000)]
WebKit for iOS Simulator fails to build with public iOS SDK
https://bugs.webkit.org/show_bug.cgi?id=153881

Reviewed by Alex Christensen.

Source/WebCore:

Make constants have internal linkage to match the Apple Internal SDK.

* platform/spi/ios/MobileGestaltSPI.h:

Source/WebKit2:

Add version guards around SPI that is now API as of iOS SDK 9.2. Until we upgrade the iOS EWS
and iOS buildbots to use the 9.2 SDK we need to keep these SPI declarations to avoid breaking
the build.

* Platform/spi/ios/UIKitSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoJSC Sampling Profiler: (host) is confusing in cases where I would expect to see JS...
sbarati@apple.com [Thu, 4 Feb 2016 21:51:40 +0000 (21:51 +0000)]
JSC Sampling Profiler: (host) is confusing in cases where I would expect to see JS name
https://bugs.webkit.org/show_bug.cgi?id=153663
<rdar://problem/24415092>

Reviewed by Geoffrey Garen.

We now collect the Callee in the processed StackFrame
when the Callee is a valid GC object. We later ask
the Callee for it's .displayName or .name property.
When we don't have a valid callee, we will still
use the Executable for this information.

This helps us come up with good names for frames where
the Callee object is a bound function or an InternalFunction.

* inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::InspectorScriptProfilerAgent::addEvent):
(Inspector::buildSamples):
(Inspector::InspectorScriptProfilerAgent::trackingComplete):
* runtime/SamplingProfiler.cpp:
(JSC::reportStats):
(JSC::FrameWalker::walk):
(JSC::SamplingProfiler::processUnverifiedStackTraces):
(JSC::SamplingProfiler::visit):
(JSC::SamplingProfiler::shutdown):
(JSC::SamplingProfiler::clearData):
(JSC::SamplingProfiler::StackFrame::nameFromCallee):
(JSC::SamplingProfiler::StackFrame::displayName):
(JSC::SamplingProfiler::StackFrame::displayNameForJSONTests):
(JSC::SamplingProfiler::stackTracesAsJSON):
* runtime/SamplingProfiler.h:
(JSC::SamplingProfiler::UnprocessedStackFrame::UnprocessedStackFrame):
(JSC::SamplingProfiler::StackFrame::StackFrame):
* tests/stress/sampling-profiler-basic.js:
(platformSupportsSamplingProfiler.nothing):
(platformSupportsSamplingProfiler.top):
* tests/stress/sampling-profiler-bound-function-name.js: Added.
(platformSupportsSamplingProfiler.foo):
(platformSupportsSamplingProfiler.bar):
(platformSupportsSamplingProfiler.let.baz):
(platformSupportsSamplingProfiler):
* tests/stress/sampling-profiler-display-name.js: Added.
(platformSupportsSamplingProfiler.foo):
(platformSupportsSamplingProfiler.baz):
(platformSupportsSamplingProfiler.):
(platformSupportsSamplingProfiler.bar):
(platformSupportsSamplingProfiler.jaz):
(platformSupportsSamplingProfiler.makeFunction.let.result):
(platformSupportsSamplingProfiler.makeFunction):
* tests/stress/sampling-profiler-internal-function-name.js: Added.
(platformSupportsSamplingProfiler.foo):
(platformSupportsSamplingProfiler.bar):
(platformSupportsSamplingProfiler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Show error icons if invalid values already exist for properties in...
commit-queue@webkit.org [Thu, 4 Feb 2016 21:51:26 +0000 (21:51 +0000)]
Web Inspector: Show error icons if invalid values already exist for properties in the Visual sidebar
https://bugs.webkit.org/show_bug.cgi?id=153702
<rdar://problem/24424025>

Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2016-02-04
Reviewed by Timothy Hatcher.

When CSS properties have invalid values, instead of displaying the computed
value for that property in the Visual sidebar, show an error icon with the
the invalid value.

* Localizations/en.lproj/localizedStrings.js:

* UserInterface/Views/VisualStyleNumberInputBox.css:
(.visual-style-property-container > .visual-style-property-value-container > .number-input-container > .number-input-value):
(.visual-style-property-container > .visual-style-property-value-container > .visual-style-special-property-placeholder[hidden] ~ .number-input-container > .number-input-value):
By default, do not allow any pointer events to interact with the input element.
Instead, only allow interaction when the placeholder element is hidden to ensure
that the user cannot add a value when the computed value is displayed.

* UserInterface/Views/VisualStyleNumberInputBox.js:
(WebInspector.VisualStyleNumberInputBox.prototype.set specialPropertyPlaceholderElementText):
Reset the selected keyword to "Unchanged" since this is either a warning
message or the computed value.

* UserInterface/Views/VisualStylePropertyEditor.css:
(.visual-style-property-container > .visual-style-property-editor-warning.missing-dependency):
(.visual-style-property-container > .visual-style-property-editor-warning.invalid-value):
(.visual-style-property-container > .visual-style-property-editor-warning):

* UserInterface/Views/VisualStylePropertyEditor.js:
(WebInspector.VisualStylePropertyEditor):
Replaced document.createElement with [element].createChild for simplicity.

(WebInspector.VisualStylePropertyEditor.prototype.update):
Before assigning the value of the property to the editor, check to see if
the property is valid. If not, display an Error icon and message stating
that the current value is invalid.

(WebInspector.VisualStylePropertyEditor.prototype.updateEditorValues):
(WebInspector.VisualStylePropertyEditor.prototype.set specialPropertyPlaceholderElementText):
Unhides the special placeholder element with the given text as its content.

(WebInspector.VisualStylePropertyEditor.prototype._valueDidChange):
(WebInspector.VisualStylePropertyEditor.prototype._checkDependencies):
(WebInspector.VisualStylePropertyEditor.prototype.addDependency):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoObject.getOwnPropertyDescriptor() returns incomplete descriptor for instance properties
cdumez@apple.com [Thu, 4 Feb 2016 21:36:04 +0000 (21:36 +0000)]
Object.getOwnPropertyDescriptor() returns incomplete descriptor for instance properties
https://bugs.webkit.org/show_bug.cgi?id=153817

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline W3C HTML test now that more checks are passing. Some checks are still
failing because getter.call(undefined) / getter.call() currently throws an exception
for Window properties but shouldn't. Global object property getters should not require
an explicit |this|.

* web-platform-tests/html/dom/interfaces-expected.txt:

Source/JavaScriptCore:

Extend support for Object.getOwnPropertyDescriptor() on native bindings
to instance properties (e.g. Unforgeable properties or Global object
properties) so that the returned descriptor has getter / setter
functions, as expected.

* runtime/JSObject.cpp:
(JSC::JSObject::reifyAllStaticProperties):
Add method that reifies all static properties, including the custom
accessors. This is similar to what is done eagerly on the prototype
objects in the bindings code.

(JSC::JSObject::getOwnPropertyDescriptor):
getOwnPropertyDescriptor() would previously fails for custom accessors
that are on the instance because getDirect() does not check the static
property table and those custom accessors were not reified (We only
reified all properties eagerly - including custom accessors - on
prototype objects. To address this issue, we now call
reifyAllStaticProperties() if the call to getDirect() fails and then
call getDirect() again. This fix is however insufficient for Window
properties because |this| is a JSDOMWindowShell / JSProxy in this case
and getDirect() / reifyAllStaticProperties() would fail as the proxy
does not actually have the properties. This issue was addressed by
checking if |this| is a JSProxy and then using JSProxy::target() instead
of |this| for the calls to getDirect() and for the reification.

* runtime/JSObject.h:
* runtime/Lookup.h:
(JSC::reifyStaticProperty):
(JSC::reifyStaticProperties):
Move most code in reifyStaticProperties() to a separate function so the
code can be shared with JSObject::reifyAllStaticProperties().
reifyStaticProperties() is currently called by the bindings on the
prototype objects.

Source/WebCore:

Update the bindings generator so that property getters / setters now
make sure |this| has the right type and throw a TypeError if it does
not, as per:
- http://heycam.github.io/webidl/#dfn-attribute-getter (step 2.4.2)
- http://heycam.github.io/webidl/#dfn-attribute-setter (step 3.5)

This was an issue when doing something like:
Object.getOwnPropertyDescriptor(window, "location").get.call(nonWindow)

We would call toJSDOMWindow(thisValue), which would return null as
thisValue is not a JSDOMWindow. We would then dereference this null
pointer and crash. We now do a null check and throw a TypeError in
this case, as per the Web IDL specification.

The generated bindings still have some non-spec compliant behavior
though:
1. The getters / setters of instance properties use slotBase instead
   of thisValue, which means that calling instanceA's getter on
   instanceB returns instanceA's property insteas of instanceB's.
2. Global object property getters should not require an explicit
   |this| so calling the following should work:
   - Object.getOwnPropertyDescriptor(window, "location").get.call()
   We currently throw in this case.

These issues will be addressed in follow-up patches.

Tests: js/getOwnPropertyDescriptor-unforgeable-attributes.html
       js/getOwnPropertyDescriptor-window-attributes.html
       js/instance-property-getter-other-instance.html

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectExcitingAttr):
* bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::jsTestExceptionName):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjConstructorTestSubObj):
(WebCore::jsTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::jsTestObjConditionalAttr4Constructor):
(WebCore::jsTestObjConditionalAttr5Constructor):
(WebCore::jsTestObjConditionalAttr6Constructor):
(WebCore::jsTestObjContentDocument):
(WebCore::setJSTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::setJSTestObjConditionalAttr4Constructor):
(WebCore::setJSTestObjConditionalAttr5Constructor):
(WebCore::setJSTestObjConditionalAttr6Constructor):
(WebCore::setJSTestObjConstructor): Deleted.
(WebCore::setJSTestObjConstructorStaticStringAttr): Deleted.
(WebCore::setJSTestObjConditionalAttr3): Deleted.
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsConstructorTestSubObj):

LayoutTests:

Add layout test coverage for calling Object.getOwnPropertyDescriptor()
on instance properties (e.g. Unforgeable properties and Window properties).

* http/tests/security/cross-origin-window-property-access-expected.txt:
* http/tests/security/cross-origin-window-property-access.html:
- Fix bug causing the onload function to not find the crossOriginWindow variable.
- Update the case for accessing crossOriginWindow.location property as this is
  actually expected to work as per the specification:
  https://html.spec.whatwg.org/multipage/browsers.html#security-window

* js/dom/dom-as-prototype-assignment-exception-expected.txt:
* js/dom/getOwnPropertyDescriptor-expected.txt:
* js/dom/script-tests/dom-as-prototype-assignment-exception.js:
* js/getOwnPropertyDescriptor-unforgeable-attributes-expected.txt: Added.
* js/getOwnPropertyDescriptor-unforgeable-attributes.html: Added.
* js/getOwnPropertyDescriptor-window-attributes-expected.txt: Added.
* js/getOwnPropertyDescriptor-window-attributes.html: Added.
* js/instance-property-getter-other-instance-expected.txt: Added.
* js/instance-property-getter-other-instance.html: Added.
* js/resources/getOwnPropertyDescriptor.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix internal Windows build
achristensen@apple.com [Thu, 4 Feb 2016 21:20:10 +0000 (21:20 +0000)]
Fix internal Windows build
https://bugs.webkit.org/show_bug.cgi?id=153886
<rdar://problem/24499887>

Reviewed by Mark Lam.

* JavaScriptCore.vcxproj/JavaScriptCore.proj:
In r190253 I changed the directory of the headers from AppleInternal/include/JavaScriptCore
to AppleInternal/include/private/JavaScriptCore.  This is ok for WebCore and WebKit, but not
other projects, such as CFNetwork, which expect the public API headers to be in the old location.
This used to be done by a combination of copy-files.cmd and the old JavaScriptCore.proj.
This change copies all the API headers, which copies everything in copy-files.cmd except APIShims.h
which does not exist any more.  It copies additional headers that were not copied before, but
I think this is beneficial so we do not forget to add new public headers to a list of public headers
to be copied in the internal build.  Having extra public headers in the internal Windows build is
not a problem because only internal clients use the internal Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agorun-jsc-stress-tests should be better at telling you details about test failures
fpizlo@apple.com [Thu, 4 Feb 2016 21:14:54 +0000 (21:14 +0000)]
run-jsc-stress-tests should be better at telling you details about test failures
https://bugs.webkit.org/show_bug.cgi?id=153845

Reviewed by Geoffrey Garen.

Here's an example of the contents of results/resultsByFamily, one of the new files that this
generates, for some local testing I'm doing.  Notice how it groups families of tests together.

You won't see this unless you cat results/resultsByFamily.

regress.yaml/Regress/radar-24289839.js:
    regress.yaml/Regress/radar-24289839.js.default: PASS
    regress.yaml/Regress/radar-24289839.js.ftl: PASS
    regress.yaml/Regress/radar-24289839.js.ftl-no-cjit: FAIL
    regress.yaml/Regress/radar-24289839.js.ftl-eager-no-cjit: FAIL

regress.yaml/Regress/radar-24290639.js:
    regress.yaml/Regress/radar-24290639.js.default: PASS
    regress.yaml/Regress/radar-24290639.js.ftl: PASS
    regress.yaml/Regress/radar-24290639.js.ftl-no-cjit: PASS
    regress.yaml/Regress/radar-24290639.js.ftl-eager-no-cjit: FAIL

regress.yaml/Regress/radar-24290670.js: FAILED

* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Give nested inspectors their own process pool
commit-queue@webkit.org [Thu, 4 Feb 2016 21:02:26 +0000 (21:02 +0000)]
Web Inspector: Give nested inspectors their own process pool
https://bugs.webkit.org/show_bug.cgi?id=153880
<rdar://problem/24508310>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-02-04
Reviewed by Timothy Hatcher.

When inspecting the inspector both inspectors were using the same
Inspector process and sharing the same VM. This meant that profiling
information was confusing (memory and JavaScript sampling) because
it was showing data about both inspectors sharing the same process.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::inspectorProcessPool):
(WebKit::WebInspectorProxy::isInspectorProcessPool):
Have two process pools. The main inspector process pool (1st level inspectors)
and a nested inspector process pool (inspecting the inspector, only expected
by WebKit developers).

* UIProcess/WebInspectorProxy.h:
* UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Pass the inspectionLevel to determine the appropriate pool to use.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMarking imported/w3c/web-platform-tests/html/semantics/document-metadata/styling...
ryanhaddad@apple.com [Thu, 4 Feb 2016 20:38:23 +0000 (20:38 +0000)]
Marking imported/w3c/web-platform-tests/html/semantics/document-metadata/styling/LinkStyle.html as flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=153871

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMarking webgl/1.0.3/conformance/extensions/oes-texture-half-float-linear.html as...
ryanhaddad@apple.com [Thu, 4 Feb 2016 20:26:52 +0000 (20:26 +0000)]
Marking webgl/1.0.3/conformance/extensions/oes-texture-half-float-linear.html as flaky on mac
https://bugs.webkit.org/show_bug.cgi?id=153883

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix bad link on the Feature Status page.
jond@apple.com [Thu, 4 Feb 2016 20:23:50 +0000 (20:23 +0000)]
Fix bad link on the Feature Status page.
https://bugs.webkit.org/show_bug.cgi?id=152086

Reviewed by Timothy Hatcher.

* wp-content/themes/webkit/status.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix the !ENABLE(NETSCAPE_PLUGIN_API) build after r196053
ossy@webkit.org [Thu, 4 Feb 2016 20:06:24 +0000 (20:06 +0000)]
Fix the !ENABLE(NETSCAPE_PLUGIN_API) build after r196053
https://bugs.webkit.org/show_bug.cgi?id=153878

Unreviewed buildfix.

* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoModern IDB: LayoutTest imported/w3c/indexeddb/keyorder-private.html is flaky.
beidson@apple.com [Thu, 4 Feb 2016 19:46:47 +0000 (19:46 +0000)]
Modern IDB: LayoutTest imported/w3c/indexeddb/keyorder-private.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=153438.

Reviewed by Alex Christensen.

Source/WebCore:

Tests: storage/indexeddb/modern/idbkey-array-equality-private.html
       storage/indexeddb/modern/idbkey-array-equality.html

* Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::loggingString):
(WebCore::IDBKeyData::operator==): Fix obvious bug.

LayoutTests:

* platform/mac-wk1/TestExpectations: Re-enable the flaky test.
* resources/js-test.js:
* storage/indexeddb/modern/idbkey-array-equality-expected.txt: Added.
* storage/indexeddb/modern/idbkey-array-equality-private-expected.txt: Added.
* storage/indexeddb/modern/idbkey-array-equality-private.html: Added.
* storage/indexeddb/modern/idbkey-array-equality.html: Added.
* storage/indexeddb/modern/resources/idbkey-array-equality.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, fix the EFL clean build after r196123
cdumez@apple.com [Thu, 4 Feb 2016 19:38:12 +0000 (19:38 +0000)]
Unreviewed, fix the EFL clean build after r196123
https://bugs.webkit.org/show_bug.cgi?id=153875

* CMakeLists.txt:
* PlatformGTK.cmake:
* PlatformMac.cmake:
* html/DOMSettableTokenList.h:
* html/DOMSettableTokenList.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoPageGroup::captionPreferences should return a reference
eric.carlson@apple.com [Thu, 4 Feb 2016 19:27:11 +0000 (19:27 +0000)]
PageGroup::captionPreferences should return a reference
https://bugs.webkit.org/show_bug.cgi?id=153877
<rdar://problem/24506917>

Reviewed by Jer Noble.

No new tests, no functional change.

* Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::sortedTrackListForMenu):
(WebCore::MediaControlsHost::displayNameForTrack):
(WebCore::MediaControlsHost::captionMenuOffItem):
(WebCore::MediaControlsHost::captionDisplayMode):
* dom/Document.cpp:
(WebCore::Document::registerForCaptionPreferencesChangedCallbacks):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::addTextTrack):
(WebCore::HTMLMediaElement::configureTextTrackGroup):
(WebCore::HTMLMediaElement::setSelectedTextTrack):
(WebCore::HTMLMediaElement::configureTextTracks):
(WebCore::HTMLMediaElement::captionPreferencesChanged):
(WebCore::HTMLMediaElement::mediaPlayerPreferredAudioCharacteristics):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay):
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu):
(WebCore::MediaControlTextTrackContainerElement::updateActiveCuesFontSize):
* page/PageGroup.cpp:
(WebCore::PageGroup::captionPreferencesChanged):
(WebCore::PageGroup::captionPreferences):
* page/PageGroup.h:
* platform/cocoa/WebVideoFullscreenModelVideoElement.mm:
(WebVideoFullscreenModelVideoElement::updateLegibleOptions):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::setShouldDisplayTrackKind):
(WebCore::InternalSettings::shouldDisplayTrackKind):
* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::Internals):
(WebCore::Internals::userPreferredAudioCharacteristics):
(WebCore::Internals::setUserPreferredAudioCharacteristic):
(WebCore::Internals::captionsStyleSheetOverride):
(WebCore::Internals::setCaptionsStyleSheetOverride):
(WebCore::Internals::setPrimaryAudioTrackLanguageOverride):
(WebCore::Internals::setCaptionDisplayMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRemoved unused Settings::setPrivateBrowsingEnabled.
commit-queue@webkit.org [Thu, 4 Feb 2016 19:20:46 +0000 (19:20 +0000)]
Removed unused Settings::setPrivateBrowsingEnabled.
https://bugs.webkit.org/show_bug.cgi?id=153869

Patch by Konstantin Tokarev <annulen@yandex.ru> on 2016-02-04
Reviewed by Alexey Proskuryakov.

Implementation of Settings::setPrivateBrowsingEnabled was removed
in r166661, but declaration is still here.

No new tests needed.

* page/Settings.h:
(WebCore::Settings::setPrivateBrowsingEnabled): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoSkip two flaky indexeddb tests on Yosemite Release WK2
ryanhaddad@apple.com [Thu, 4 Feb 2016 19:12:11 +0000 (19:12 +0000)]
Skip two flaky indexeddb tests on Yosemite Release WK2

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoDon't discard in-band cues with negative start times
eric.carlson@apple.com [Thu, 4 Feb 2016 18:20:21 +0000 (18:20 +0000)]
Don't discard in-band cues with negative start times
https://bugs.webkit.org/show_bug.cgi?id=153867
<rdar://problem/19588632>

Reviewed by Jer Noble.

Source/WebCore:

No new tests, updated and un-skipped http/tests/media/track-in-band-hls-metadata.html.

* platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.cpp:
(WebCore::InbandMetadataTextTrackPrivateAVF::addDataCue):  ASSERT if passed negative time value.
(WebCore::InbandMetadataTextTrackPrivateAVF::updatePendingCueEndTimes): Ditto. Correct logging.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::processCue): ASSERT if passed negative time value.
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive): Convert negative cue times to zero.
(-[WebCoreAVFMovieObserver legibleOutput:didOutputAttributedStrings:nativeSampleBuffers:forItemTime:]):
  Ditto.

LayoutTests:

* http/tests/media/track-in-band-hls-metadata-expected.txt:
* http/tests/media/track-in-band-hls-metadata.html: Test more attributes for correctness,
  fail test immediately if cue.value is undefined so the test doesn't generate an exception
  and exit without any results.
* platform/mac/TestExpectations: Unskip test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoSpecify an exception for createChannelMerger, createChannelSplitter and createPeriodi...
commit-queue@webkit.org [Thu, 4 Feb 2016 18:03:34 +0000 (18:03 +0000)]
Specify an exception for createChannelMerger, createChannelSplitter and createPeriodicWave
https://bugs.webkit.org/show_bug.cgi?id=150925

Patch by Hyemi Shin <hyemi.sin@samsung.com> on 2016-02-04
Reviewed by Darin Adler.

createChannelMerger and createChannelSplitter should throw INDEX_SIZE_ERR
for invalid numberOfInputs value.
createPeriodicWave should throw INDEX_SIZE_ERR for invalid lengths of parameters.

Source/WebCore:

Tests: webaudio/audiochannelmerger-basic.html
       webaudio/audiochannelsplitter.html
       webaudio/periodicwave-lengths.html

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createChannelSplitter):
(WebCore::AudioContext::createChannelMerger):
(WebCore::AudioContext::createPeriodicWave):

LayoutTests:

* webaudio/audiochannelmerger-basic-expected.txt: numberOfInputs could be 32.
* webaudio/audiochannelmerger-basic.html: Ditto.
* webaudio/audiochannelsplitter-expected.txt: Ditto.
* webaudio/audiochannelsplitter.html: Ditto.
* webaudio/periodicwave-lengths-expected.txt: Added.
* webaudio/periodicwave-lengths.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Fetch API] Add support for iterating over Headers
youenn.fablet@crf.canon.fr [Thu, 4 Feb 2016 17:43:05 +0000 (17:43 +0000)]
[Fetch API] Add support for iterating over Headers
https://bugs.webkit.org/show_bug.cgi?id=153787

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Relanding.

* web-platform-tests/fetch/api/headers/headers-basic-expected.txt:
* web-platform-tests/fetch/api/headers/headers-basic.html:
* web-platform-tests/fetch/api/headers/headers-structure-expected.txt:
* web-platform-tests/fetch/api/request/request-clone.sub-expected.txt:
* web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt:
* web-platform-tests/fetch/api/resources/utils.js:
(checkRequest):
(readTextStream):

Source/WebCore:

Relanding, updating bindings/js/JSKeyValueIterator.h for Windows bots.

Covered by updated tests.
Introducing template class (JSKeyValueIterator) to support key-value iterators in DOM classes.
Using JSKeyValueIterator to implement Headers entries(), keys() and values() as custom methods.
Binding generator should be updated to generate directly these custom methods and handle iterator Symbol.

* CMakeLists.txt:
* Modules/fetch/FetchHeaders.cpp:
(WebCore::FetchHeaders::Iterator::next):
(WebCore::FetchHeaders::Iterator::Iterator):
* Modules/fetch/FetchHeaders.h:
(WebCore::FetchHeaders::createIterator):
* Modules/fetch/FetchHeaders.idl:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDOMBinding.h:
(WebCore::jsPair):
* bindings/js/JSFetchHeadersCustom.cpp: Added.
(WebCore::JSFetchHeaders::entries):
(WebCore::JSFetchHeaders::keys):
(WebCore::JSFetchHeaders::values):
* bindings/js/JSKeyValueIterator.h: Added.
(WebCore::JSKeyValueIteratorPrototype::create):
(WebCore::JSKeyValueIteratorPrototype::createStructure):
(WebCore::JSKeyValueIteratorPrototype::JSKeyValueIteratorPrototype):
(WebCore::createIterator):
(WebCore::DOMWrapped>::destroy):
(WebCore::DOMWrapped>::next):
(WebCore::DOMWrapped>::finishCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRebaseline imported/w3c/web-platform-tests/html/semantics/forms/the-select-element...
ryanhaddad@apple.com [Thu, 4 Feb 2016 17:34:26 +0000 (17:34 +0000)]
Rebaseline imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/select-ask-for-reset.html for ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153850

Unreviewed test gardening.

* platform/ios-simulator/TestExpectations:
* platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/select-ask-for-reset-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, rolling out r196067.
cdumez@apple.com [Thu, 4 Feb 2016 17:12:43 +0000 (17:12 +0000)]
Unreviewed, rolling out r196067.

Re-enable speculative revalidation now that we have measured
the impact on the perf bots

Reverted changeset:

"Unreviewed, rolling out r195555."
https://bugs.webkit.org/show_bug.cgi?id=153443
http://trac.webkit.org/changeset/196067

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMerge DOMTokenList and DOMSettableTokenList
cdumez@apple.com [Thu, 4 Feb 2016 16:57:44 +0000 (16:57 +0000)]
Merge DOMTokenList and DOMSettableTokenList
https://bugs.webkit.org/show_bug.cgi?id=153677
<rdar://problem/24419675>

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing.

* web-platform-tests/dom/historical-expected.txt:
* web-platform-tests/dom/interfaces-expected.txt:
* web-platform-tests/dom/nodes/Element-classlist-expected.txt:
* web-platform-tests/html/dom/interfaces-expected.txt:

* web-platform-tests/html/dom/interfaces.html:
Update HTMLAreaElement.relList to match the specification.

Source/WebCore:

Merge DOMTokenList and DOMSettableTokenList, as per a recent
specification change:
- https://github.com/whatwg/dom/pull/120
- https://github.com/whatwg/html/issues/361

No new tests, already covered by existing tests.

* CMakeLists.txt:
* DerivedSources.cpp:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* dom/Element.idl:
* dom/Node.h:
* dom/NodeRareData.h:
* html/AttributeDOMTokenList.h:
* html/DOMSettableTokenList.cpp: Removed.
* html/DOMSettableTokenList.h:
* html/DOMSettableTokenList.idl:
* html/DOMTokenList.cpp:
(WebCore::DOMTokenList::setValue):
* html/DOMTokenList.h:
* html/DOMTokenList.idl:
* html/HTMLAnchorElement.idl:
* html/HTMLAreaElement.idl:
* html/HTMLElement.cpp:
* html/HTMLElement.idl:
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::sandbox):
* html/HTMLIFrameElement.h:
* html/HTMLIFrameElement.idl:
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::sizes):
* html/HTMLLinkElement.h:
* html/HTMLLinkElement.idl:
* html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::htmlFor):
* html/HTMLOutputElement.h:
* html/HTMLOutputElement.idl:
* html/HTMLTableCellElement.idl:
* page/DOMWindow.cpp:
* page/DOMWindow.idl:

LayoutTests:

Update / rebaseline several tests now that relList attributes
use [PutForward=value].

* fast/dom/HTMLElement/class-list-expected.txt:
* fast/dom/HTMLElement/class-list-quirks-expected.txt:
* fast/dom/HTMLElement/script-tests/class-list.js:
* fast/dom/rel-list-expected.txt:
* fast/dom/rel-list.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed. Reverting r196115 and r19116, related tohttps://bugs.webkit.org/show_bug...
youenn.fablet@crf.canon.fr [Thu, 4 Feb 2016 12:46:12 +0000 (12:46 +0000)]
Unreviewed. Reverting r196115 and r19116, related tohttps://bugs.webkit.org/show_bug.cgi?id=153787.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] Implement mediastream mediaplayer
alex@webkit.org [Thu, 4 Feb 2016 11:39:31 +0000 (11:39 +0000)]
[GTK] Implement mediastream mediaplayer
https://bugs.webkit.org/show_bug.cgi?id=153541

Reviewed by Martin Robinson.

Added the implementation of the mediaplayer for the
mediastream. The code was implemented by Philippe Normand and
Alessandro Decina.

* PlatformGTK.cmake: Added the file to the compilation.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setSrcObject): Set the src of the
media element to the mediastream.
* platform/graphics/MediaPlayer.cpp:
(WebCore::buildMediaEnginesVector): Register the mediastream
mediaplayer as an option in the media engines vector.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp: Added.
(WebCore::MediaPlayerPrivateGStreamerOwr::MediaPlayerPrivateGStreamerOwr):
(WebCore::MediaPlayerPrivateGStreamerOwr::~MediaPlayerPrivateGStreamerOwr):
(WebCore::MediaPlayerPrivateGStreamerOwr::play):
(WebCore::MediaPlayerPrivateGStreamerOwr::pause):
(WebCore::MediaPlayerPrivateGStreamerOwr::hasVideo):
(WebCore::MediaPlayerPrivateGStreamerOwr::hasAudio):
(WebCore::MediaPlayerPrivateGStreamerOwr::currentTime):
(WebCore::MediaPlayerPrivateGStreamerOwr::load):
(WebCore::MediaPlayerPrivateGStreamerOwr::loadingFailed):
(WebCore::MediaPlayerPrivateGStreamerOwr::didLoadingProgress):
(WebCore::MediaPlayerPrivateGStreamerOwr::internalLoad):
(WebCore::MediaPlayerPrivateGStreamerOwr::stop):
(WebCore::MediaPlayerPrivateGStreamerOwr::registerMediaEngine):
(WebCore::MediaPlayerPrivateGStreamerOwr::getSupportedTypes):
(WebCore::MediaPlayerPrivateGStreamerOwr::supportsType):
(WebCore::MediaPlayerPrivateGStreamerOwr::isAvailable):
(WebCore::MediaPlayerPrivateGStreamerOwr::createGSTAudioSinkBin):
(WebCore::MediaPlayerPrivateGStreamerOwr::sourceStopped):
(WebCore::MediaPlayerPrivateGStreamerOwr::sourceMutedChanged):
(WebCore::MediaPlayerPrivateGStreamerOwr::sourceSettingsChanged):
(WebCore::MediaPlayerPrivateGStreamerOwr::preventSourceFromStopping):
(WebCore::MediaPlayerPrivateGStreamerOwr::createVideoSink):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.h: Added.
(WebCore::MediaPlayerPrivateGStreamerOwr::engineDescription):
(WebCore::MediaPlayerPrivateGStreamerOwr::load):
(WebCore::MediaPlayerPrivateGStreamerOwr::cancelLoad):
(WebCore::MediaPlayerPrivateGStreamerOwr::prepareToPlay):
(WebCore::MediaPlayerPrivateGStreamerOwr::duration):
(WebCore::MediaPlayerPrivateGStreamerOwr::seek):
(WebCore::MediaPlayerPrivateGStreamerOwr::seeking):
(WebCore::MediaPlayerPrivateGStreamerOwr::setRate):
(WebCore::MediaPlayerPrivateGStreamerOwr::setPreservesPitch):
(WebCore::MediaPlayerPrivateGStreamerOwr::paused):
(WebCore::MediaPlayerPrivateGStreamerOwr::hasClosedCaptions):
(WebCore::MediaPlayerPrivateGStreamerOwr::setClosedCaptionsVisible):
(WebCore::MediaPlayerPrivateGStreamerOwr::maxTimeSeekable):
(WebCore::MediaPlayerPrivateGStreamerOwr::buffered):
(WebCore::MediaPlayerPrivateGStreamerOwr::totalBytes):
(WebCore::MediaPlayerPrivateGStreamerOwr::bytesLoaded):
(WebCore::MediaPlayerPrivateGStreamerOwr::canLoadPoster):
(WebCore::MediaPlayerPrivateGStreamerOwr::setPoster):
(WebCore::MediaPlayerPrivateGStreamerOwr::isLiveStream):
(WebCore::MediaPlayerPrivateGStreamerOwr::audioSink):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed. Speculative Win Build fix
youenn.fablet@crf.canon.fr [Thu, 4 Feb 2016 11:14:04 +0000 (11:14 +0000)]
Unreviewed. Speculative Win Build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Fetch API] Add support for iterating over Headers
youenn.fablet@crf.canon.fr [Thu, 4 Feb 2016 10:39:37 +0000 (10:39 +0000)]
[Fetch API] Add support for iterating over Headers
https://bugs.webkit.org/show_bug.cgi?id=153787

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

* web-platform-tests/fetch/api/headers/headers-basic-expected.txt:
* web-platform-tests/fetch/api/headers/headers-basic.html:
* web-platform-tests/fetch/api/headers/headers-structure-expected.txt:
* web-platform-tests/fetch/api/request/request-clone.sub-expected.txt:
* web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt:
* web-platform-tests/fetch/api/resources/utils.js: fixed typo in test.

Source/WebCore:

Covered by updated tests.
Introducing template class (JSKeyValueIterator) to support key-value iterators in DOM classes.
Using JSKeyValueIterator to implement Headers entries(), keys() and values() as custom methods.
Binding generator should be updated to generate directly these custom methods and handle iterator Symbol.

* CMakeLists.txt:
* Modules/fetch/FetchHeaders.cpp:
(WebCore::FetchHeaders::Iterator::next):
(WebCore::FetchHeaders::Iterator::Iterator):
* Modules/fetch/FetchHeaders.h:
(WebCore::FetchHeaders::createIterator):
* Modules/fetch/FetchHeaders.idl:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMBinding.h:
(WebCore::jsPair):
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSFetchHeadersCustom.cpp: Added.
(WebCore::JSFetchHeaders::entries):
(WebCore::JSFetchHeaders::keys):
(WebCore::JSFetchHeaders::values):
* bindings/js/JSKeyValueIterator.h: Added.
(WebCore::JSKeyValueIteratorPrototype::create):
(WebCore::JSKeyValueIteratorPrototype::createStructure):
(WebCore::JSKeyValueIteratorPrototype::JSKeyValueIteratorPrototype):
(WebCore::JSKeyValueIteratorPrototypeFuncNext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed. EFL gardening after r195740.
hs85.jeong@samsung.com [Thu, 4 Feb 2016 10:10:01 +0000 (10:10 +0000)]
Unreviewed. EFL gardening after r195740.

* platform/efl/accessibility/table-attributes-expected.txt:
* platform/efl/accessibility/table-cell-spans-expected.txt:
* platform/efl/accessibility/table-cells-expected.txt:
* platform/efl/accessibility/table-sections-expected.txt:
* platform/efl/accessibility/table-with-rules-expected.txt:
* platform/efl/css2.1/20110323/table-height-algorithm-023-expected.txt:
* platform/efl/css2.1/20110323/table-height-algorithm-024-expected.txt:
* platform/efl/css3/selectors3/xml/css3-modsel-43b-expected.txt:
* platform/efl/editing/deleting/5099303-expected.txt:
* platform/efl/editing/deleting/5144139-2-expected.txt:
* platform/efl/editing/deleting/5483370-expected.txt:
* platform/efl/editing/deleting/delete-to-select-table-expected.txt:
* platform/efl/editing/deleting/table-cells-expected.txt:
* platform/efl/fast/text/atsui-multiple-renderers-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed non X86_64 buildfix after r196077.
ossy@webkit.org [Thu, 4 Feb 2016 10:05:09 +0000 (10:05 +0000)]
Unreviewed non X86_64 buildfix after r196077.

* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsGTK.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoDo not show context menu when right clicking on a scrollbar
carlosgc@webkit.org [Thu, 4 Feb 2016 08:25:28 +0000 (08:25 +0000)]
Do not show context menu when right clicking on a scrollbar
https://bugs.webkit.org/show_bug.cgi?id=153493

Reviewed by Michael Catanzaro.

Source/WebCore:

Scrollbars don't currently handle right clicks, but we are showing
the context menu when they are right clicked. This is not desired
at least in GTK+ and I've checked that it isn't consistent with
other applications in Mac either.

Test: fast/events/contextmenu-on-scrollbars.html

* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEvent):

LayoutTests:

Add a test to check that context menu event is not sent when right
clicking on a scrollbar.

* fast/events/contextmenu-on-scrollbars-expected.txt: Added.
* fast/events/contextmenu-on-scrollbars.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix a typo in Tools/ChangeLog
carlosgc@webkit.org [Thu, 4 Feb 2016 07:37:52 +0000 (07:37 +0000)]
Fix a typo in Tools/ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[WTR] Crash in EventSendingController::contextClick() when context menu event is...
carlosgc@webkit.org [Thu, 4 Feb 2016 07:34:55 +0000 (07:34 +0000)]
[WTR] Crash in EventSendingController::contextClick() when context menu event is not handled
https://bugs.webkit.org/show_bug.cgi?id=153835

Reviewed by Martin Robinson.

WKBundlePageCopyContextMenuAtPointInWindow() returns nullptr when
the context menu event is not hanlded, but we are using the
returned value without null checking it.

* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::contextClick):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFormat revisions for display according to repository type https://bugs.webkit.org...
jmarcell@apple.com [Thu, 4 Feb 2016 06:07:21 +0000 (06:07 +0000)]
Format revisions for display according to repository type https://bugs.webkit.org/show_bug.cgi?id=153818

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._popoverLinesForCommitRange): Use new _formatRevisionForDisplay to display revisions according
to repository type.
(BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
(BuildbotQueueView.prototype._formatRevisionForDisplay): Formats revisions for display according to repository type.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test new
_formatRevisionForDisplay function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[JSC] Make some classes non JSDestructibleObject
utatane.tea@gmail.com [Thu, 4 Feb 2016 05:41:03 +0000 (05:41 +0000)]
[JSC] Make some classes non JSDestructibleObject
https://bugs.webkit.org/show_bug.cgi?id=153838

Reviewed by Geoffrey Garen.

SymbolPrototype, JSMapIterator and JSSetIterator are trivially destructible.
So there is no need to inherit JSDestructibleObject.

* runtime/JSMapIterator.cpp:
(JSC::JSMapIterator::destroy): Deleted.
* runtime/JSMapIterator.h:
* runtime/JSSetIterator.cpp:
(JSC::JSSetIterator::destroy): Deleted.
* runtime/JSSetIterator.h:
* runtime/MapData.h:
* runtime/SymbolPrototype.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[JSC] Symbol structure has unnecessary flags
utatane.tea@gmail.com [Thu, 4 Feb 2016 05:38:33 +0000 (05:38 +0000)]
[JSC] Symbol structure has unnecessary flags
https://bugs.webkit.org/show_bug.cgi?id=153840

Reviewed by Saam Barati.

* runtime/Symbol.h:
* tests/stress/symbol-get-own-property.js: Added.
(shouldBe):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoLogs/CoreSimulator filling up OS disk on WebKit testers
aakash_jain@apple.com [Thu, 4 Feb 2016 05:16:16 +0000 (05:16 +0000)]
Logs/CoreSimulator filling up OS disk on WebKit testers
https://bugs.webkit.org/show_bug.cgi?id=153853
<rdar://problem/24496003>

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.clean_up_test_run): Delete Logs during cleanup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAccepted candidates should not be autocorrected
bdakin@apple.com [Thu, 4 Feb 2016 03:36:32 +0000 (03:36 +0000)]
Accepted candidates should not be autocorrected
https://bugs.webkit.org/show_bug.cgi?id=153813
-and corresponding-
rdar://problem/24066924

Reviewed by Darin Adler.

* editing/mac/spelling/accept-misspelled-candidate-expected.txt: Added.
* editing/mac/spelling/accept-misspelled-candidate.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[iOS] Throw away linked code when navigating to a new page.
akling@apple.com [Thu, 4 Feb 2016 03:12:23 +0000 (03:12 +0000)]
[iOS] Throw away linked code when navigating to a new page.
<https://webkit.org/b/153851>

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Add a VM API for throwing away linked code only.

* runtime/VM.cpp:
(JSC::VM::deleteAllLinkedCode):
* runtime/VM.h:

Source/WebCore:

When navigating to a new page, tell JSC to throw out any linked code it has lying around.
Linked code is tied to a specific global object, and as we're creating a new one for the
new page, none of it is useful to us here.
In the event that the user navigates back, the cost of relinking some code will be far
lower than the memory cost of keeping all of it around.

* bindings/js/GCController.cpp:
(WebCore::GCController::deleteAllLinkedCode):
* bindings/js/GCController.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMarking http/tests/history/back-to-post.php as flaky on ios-simulator
ryanhaddad@apple.com [Thu, 4 Feb 2016 01:48:22 +0000 (01:48 +0000)]
Marking http/tests/history/back-to-post.php as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153314

Unreviewed test gardening.

* platform/ios-simulator/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoSkip imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/select...
ryanhaddad@apple.com [Thu, 4 Feb 2016 01:41:21 +0000 (01:41 +0000)]
Skip imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/select-ask-for-reset.html on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153850

Unreviewed test gardening.

* platform/ios-simulator/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196102 268f45cc-cd09-0410-ab3c-d52691b4dbfc