WebKit-https.git
9 years ago2010-11-17 Peter Varga <pvarga@inf.u-szeged.hu>
commit-queue@webkit.org [Wed, 17 Nov 2010 09:42:41 +0000 (09:42 +0000)]
2010-11-17  Peter Varga  <pvarga@inf.u-szeged.hu>

        Reviewed by Gavin Barraclough.

        Collect the beginning characters in a RegExp pattern for look-up
        optimization
        https://bugs.webkit.org/show_bug.cgi?id=45748

        Extend the YARR's parser with an algorithm which collects the potential
        beginning characters from a RegExp pattern for later look-up optimization.

        * yarr/RegexCompiler.cpp:
        (JSC::Yarr::BeginCharHelper::BeginCharHelper):
        (JSC::Yarr::BeginCharHelper::addBeginChar):
        (JSC::Yarr::BeginCharHelper::merge):
        (JSC::Yarr::BeginCharHelper::addCharacter):
        (JSC::Yarr::BeginCharHelper::linkHotTerms):
        (JSC::Yarr::RegexPatternConstructor::RegexPatternConstructor):
        (JSC::Yarr::RegexPatternConstructor::addBeginTerm):
        (JSC::Yarr::RegexPatternConstructor::setupDisjunctionBeginTerms):
        (JSC::Yarr::RegexPatternConstructor::setupAlternativeBeginTerms):
        (JSC::Yarr::RegexPatternConstructor::setupBeginChars):
        (JSC::Yarr::compileRegex):
        * yarr/RegexPattern.h:
        (JSC::Yarr::TermChain::TermChain):
        (JSC::Yarr::BeginChar::BeginChar):
        (JSC::Yarr::RegexPattern::RegexPattern):
        (JSC::Yarr::RegexPattern::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTwo more tests needing new results after r72173.
aestes@apple.com [Wed, 17 Nov 2010 09:24:35 +0000 (09:24 +0000)]
Two more tests needing new results after r72173.

* platform/mac/editing/selection/caret-rtl-expected.txt:
* platform/mac/transforms/2d/hindi-rotated-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore results needing new results after r72173.
aestes@apple.com [Wed, 17 Nov 2010 08:45:12 +0000 (08:45 +0000)]
More results needing new results after r72173.

* platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt:
* platform/mac/fast/text/backslash-to-yen-sign-expected.txt:
* platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
* platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe following results needed new results after r72173.
aestes@apple.com [Wed, 17 Nov 2010 08:37:00 +0000 (08:37 +0000)]
The following results needed new results after r72173.

* editing/selection/extend-selection-bidi-expected.txt:
* platform/mac/editing/deleting/5144139-2-expected.checksum:
* platform/mac/editing/deleting/5144139-2-expected.png:
* platform/mac/editing/deleting/5144139-2-expected.txt:
* platform/mac/editing/selection/caret-rtl-2-expected.checksum:
* platform/mac/editing/selection/caret-rtl-2-expected.png:
* platform/mac/editing/selection/caret-rtl-2-expected.txt:
* platform/mac/editing/selection/extend-selection-bidi-expected.checksum:
* platform/mac/editing/selection/extend-selection-bidi-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-17 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 17 Nov 2010 08:05:39 +0000 (08:05 +0000)]
2010-11-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72160.
        http://trac.webkit.org/changeset/72160
        https://bugs.webkit.org/show_bug.cgi?id=49646

        Broke lots of fast/profiler tests, among others (Requested by
        aroben on #webkit).

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        (JSC::CodeBlock::functionRegisterForBytecodeOffset):
        (JSC::CodeBlock::shrinkToFit):
        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::addFunctionRegisterInfo):
        * bytecode/Opcode.h:
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::BytecodeGenerator):
        (JSC::BytecodeGenerator::emitCall):
        (JSC::BytecodeGenerator::emitCallVarargs):
        (JSC::BytecodeGenerator::emitReturn):
        (JSC::BytecodeGenerator::emitConstruct):
        * bytecompiler/BytecodeGenerator.h:
        (JSC::CallArguments::profileHookRegister):
        * bytecompiler/NodesCodegen.cpp:
        (JSC::CallArguments::CallArguments):
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::unwindCallFrame):
        (JSC::Interpreter::throwException):
        (JSC::Interpreter::execute):
        (JSC::Interpreter::executeCall):
        (JSC::Interpreter::executeConstruct):
        (JSC::Interpreter::privateExecute):
        * jit/JIT.cpp:
        (JSC::JIT::privateCompileMainPass):
        * jit/JIT.h:
        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_profile_will_call):
        (JSC::JIT::emit_op_profile_did_call):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::emit_op_profile_will_call):
        (JSC::JIT::emit_op_profile_did_call):
        * jit/JITStubs.cpp:
        (JSC::DEFINE_STUB_FUNCTION):
        * jit/JITStubs.h:
        * profiler/Profile.cpp:
        (JSC::Profile::Profile):
        * profiler/ProfileGenerator.cpp:
        (JSC::ProfileGenerator::addParentForConsoleStart):
        (JSC::ProfileGenerator::willExecute):
        (JSC::ProfileGenerator::didExecute):
        (JSC::ProfileGenerator::stopProfiling):
        * profiler/ProfileGenerator.h:
        * profiler/ProfileNode.cpp:
        (JSC::ProfileNode::ProfileNode):
        (JSC::ProfileNode::willExecute):
        * profiler/ProfileNode.h:
        (JSC::ProfileNode::create):
        (JSC::ProfileNode::operator==):
        * profiler/Profiler.cpp:
        (JSC::dispatchFunctionToProfiles):
        (JSC::Profiler::willExecute):
        (JSC::Profiler::didExecute):
        * profiler/Profiler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIgnore files from libdispatch/zlib
aroben@apple.com [Wed, 17 Nov 2010 07:43:57 +0000 (07:43 +0000)]
Ignore files from libdispatch/zlib

Rubber-stamped by Eric Seidel.

* win/include: Modified property svn:ignore.
* win/lib: Modified property svn:ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove QTMovieWin's settings into a vsprops file
aroben@apple.com [Wed, 17 Nov 2010 07:24:08 +0000 (07:24 +0000)]
Move QTMovieWin's settings into a vsprops file

Fixes <http://webkit.org/b/49644> QTMovieWin should use a vsprops file

Reviewed by Steve Falkenburg.

* WebCore.vcproj/QTMovieWin.vcproj:
* WebCore.vcproj/QTMovieWinCommon.vsprops: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit mishandles line boxes where the content height exceeds the
aestes@apple.com [Wed, 17 Nov 2010 06:45:50 +0000 (06:45 +0000)]
WebKit mishandles line boxes where the content height exceeds the
specified line-height.
https://bugs.webkit.org/show_bug.cgi?id=49410

Reviewed by Dave Hyatt.

WebCore:

If a line height is explicitly specified on a text box and fallback
fonts are in use, only the primary font should be considered when
computing the box's ascent and descent. This prevents the inline box
from being sized larger than the specified line height.

This patch also fixes a math error when computing a used font's descent
in the case where line height isn't explicitly set. This change results
in a number of layout tests needing re-baselining.

Test: fast/css/line-height-determined-by-primary-font.html

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights):

LayoutTests:

* fast/css/line-height-determined-by-primary-font.html: Added.
* platform/mac/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
* platform/mac/fast/css/line-height-determined-by-primary-font-expected.png: Added.
* platform/mac/fast/css/line-height-determined-by-primary-font-expected.txt: Added.

The following test results were re-baselined:

* platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
* platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
* platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
* platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum:
* platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.png:
* platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
* platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
* platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
* platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
* platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum:
* platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.png:
* platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
* platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum:
* platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.png:
* platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
* platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum:
* platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png:
* platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
* platform/mac/css2.1/t0905-c414-flt-02-c-expected.checksum:
* platform/mac/css2.1/t0905-c414-flt-02-c-expected.png:
* platform/mac/css2.1/t0905-c414-flt-02-c-expected.txt:
* platform/mac/css2.1/t0905-c414-flt-03-c-expected.checksum:
* platform/mac/css2.1/t0905-c414-flt-03-c-expected.png:
* platform/mac/css2.1/t0905-c414-flt-03-c-expected.txt:
* platform/mac/css2.1/t0905-c414-flt-04-c-expected.checksum:
* platform/mac/css2.1/t0905-c414-flt-04-c-expected.png:
* platform/mac/css2.1/t0905-c414-flt-04-c-expected.txt:
* platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum:
* platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.png:
* platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt:
* platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.checksum:
* platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.png:
* platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.txt:
* platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
* platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
* platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
* platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
* platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
* platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
* platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.checksum:
* platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png:
* platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
* platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum:
* platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png:
* platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
* platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.checksum:
* platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.png:
* platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.txt:
* platform/mac/css2.1/t090501-c414-flt-01-b-expected.checksum:
* platform/mac/css2.1/t090501-c414-flt-01-b-expected.png:
* platform/mac/css2.1/t090501-c414-flt-01-b-expected.txt:
* platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
* platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
* platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
* platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
* platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
* platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt:
* platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
* platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
* platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt:
* platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
* platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
* platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt:
* platform/mac/css2.1/t1202-counter-03-b-expected.checksum:
* platform/mac/css2.1/t1202-counter-03-b-expected.png:
* platform/mac/css2.1/t1202-counter-03-b-expected.txt:
* platform/mac/css2.1/t1202-counter-04-b-expected.checksum:
* platform/mac/css2.1/t1202-counter-04-b-expected.png:
* platform/mac/css2.1/t1202-counter-04-b-expected.txt:
* platform/mac/css2.1/t1202-counter-09-b-expected.checksum:
* platform/mac/css2.1/t1202-counter-09-b-expected.png:
* platform/mac/css2.1/t1202-counter-09-b-expected.txt:
* platform/mac/css2.1/t1202-counters-03-b-expected.checksum:
* platform/mac/css2.1/t1202-counters-03-b-expected.png:
* platform/mac/css2.1/t1202-counters-03-b-expected.txt:
* platform/mac/css2.1/t1202-counters-04-b-expected.checksum:
* platform/mac/css2.1/t1202-counters-04-b-expected.png:
* platform/mac/css2.1/t1202-counters-04-b-expected.txt:
* platform/mac/css2.1/t1202-counters-09-b-expected.checksum:
* platform/mac/css2.1/t1202-counters-09-b-expected.png:
* platform/mac/css2.1/t1202-counters-09-b-expected.txt:
* platform/mac/fast/blockflow/vertical-font-fallback-expected.checksum:
* platform/mac/fast/blockflow/vertical-font-fallback-expected.png:
* platform/mac/fast/blockflow/vertical-font-fallback-expected.txt:
* platform/mac/fast/css/beforeSelectorOnCodeElement-expected.checksum:
* platform/mac/fast/css/beforeSelectorOnCodeElement-expected.png:
* platform/mac/fast/css/beforeSelectorOnCodeElement-expected.txt:
* platform/mac/fast/css/font-face-opentype-expected.checksum:
* platform/mac/fast/css/font-face-opentype-expected.png:
* platform/mac/fast/css/font-face-opentype-expected.txt:
* platform/mac/fast/css/rtl-ordering-expected.checksum:
* platform/mac/fast/css/rtl-ordering-expected.png:
* platform/mac/fast/css/rtl-ordering-expected.txt:
* platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.checksum:
* platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.png:
* platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt:
* platform/mac/fast/css/text-overflow-ellipsis-expected.checksum:
* platform/mac/fast/css/text-overflow-ellipsis-expected.png:
* platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
* platform/mac/fast/css/text-overflow-ellipsis-strict-expected.checksum:
* platform/mac/fast/css/text-overflow-ellipsis-strict-expected.png:
* platform/mac/fast/css/text-overflow-ellipsis-strict-expected.txt:
* platform/mac/fast/css/text-security-expected.checksum:
* platform/mac/fast/css/text-security-expected.png:
* platform/mac/fast/css/text-security-expected.txt:
* platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum:
* platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
* platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
* platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
* platform/mac/fast/encoding/invalid-UTF-8-expected.png:
* platform/mac/fast/encoding/invalid-UTF-8-expected.txt:
* platform/mac/fast/events/updateLayoutForHitTest-expected.checksum:
* platform/mac/fast/events/updateLayoutForHitTest-expected.png:
* platform/mac/fast/events/updateLayoutForHitTest-expected.txt:
* platform/mac/fast/forms/select-visual-hebrew-expected.checksum:
* platform/mac/fast/forms/select-visual-hebrew-expected.png:
* platform/mac/fast/forms/select-visual-hebrew-expected.txt:
* platform/mac/fast/forms/select-writing-direction-natural-expected.checksum:
* platform/mac/fast/forms/select-writing-direction-natural-expected.png:
* platform/mac/fast/forms/select-writing-direction-natural-expected.txt:
* platform/mac/fast/forms/visual-hebrew-text-field-expected.checksum:
* platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
* platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
* platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
* platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
* platform/mac/fast/text/atsui-multiple-renderers-expected.checksum:
* platform/mac/fast/text/atsui-multiple-renderers-expected.png:
* platform/mac/fast/text/atsui-multiple-renderers-expected.txt:
* platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum:
* platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png:
* platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
* platform/mac/fast/text/capitalize-boundaries-expected.checksum:
* platform/mac/fast/text/capitalize-boundaries-expected.png:
* platform/mac/fast/text/capitalize-boundaries-expected.txt:
* platform/mac/fast/text/cg-fallback-bolding-expected.checksum:
* platform/mac/fast/text/cg-fallback-bolding-expected.png:
* platform/mac/fast/text/cg-fallback-bolding-expected.txt:
* platform/mac/fast/text/complex-text-opacity-expected.checksum:
* platform/mac/fast/text/complex-text-opacity-expected.png:
* platform/mac/fast/text/complex-text-opacity-expected.txt:
* platform/mac/fast/text/in-rendered-text-rtl-expected.checksum:
* platform/mac/fast/text/in-rendered-text-rtl-expected.png:
* platform/mac/fast/text/in-rendered-text-rtl-expected.txt:
* platform/mac/fast/text/international/001-expected.checksum:
* platform/mac/fast/text/international/001-expected.png:
* platform/mac/fast/text/international/001-expected.txt:
* platform/mac/fast/text/international/002-expected.checksum:
* platform/mac/fast/text/international/002-expected.png:
* platform/mac/fast/text/international/002-expected.txt:
* platform/mac/fast/text/international/003-expected.checksum:
* platform/mac/fast/text/international/003-expected.png:
* platform/mac/fast/text/international/003-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
* platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum:
* platform/mac/fast/text/international/bidi-CS-after-AN-expected.png:
* platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
* platform/mac/fast/text/international/bidi-L2-run-reordering-expected.checksum:
* platform/mac/fast/text/international/bidi-L2-run-reordering-expected.png:
* platform/mac/fast/text/international/bidi-L2-run-reordering-expected.txt:
* platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum:
* platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
* platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
* platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum:
* platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
* platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
* platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
* platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
* platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
* platform/mac/fast/text/international/bidi-european-terminators-expected.checksum:
* platform/mac/fast/text/international/bidi-european-terminators-expected.png:
* platform/mac/fast/text/international/bidi-european-terminators-expected.txt:
* platform/mac/fast/text/international/bidi-fallback-font-weight-expected.checksum:
* platform/mac/fast/text/international/bidi-fallback-font-weight-expected.png:
* platform/mac/fast/text/international/bidi-fallback-font-weight-expected.txt:
* platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
* platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
* platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
* platform/mac/fast/text/international/bidi-innertext-expected.checksum:
* platform/mac/fast/text/international/bidi-innertext-expected.png:
* platform/mac/fast/text/international/bidi-innertext-expected.txt:
* platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum:
* platform/mac/fast/text/international/bidi-linebreak-001-expected.png:
* platform/mac/fast/text/international/bidi-linebreak-001-expected.txt:
* platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum:
* platform/mac/fast/text/international/bidi-linebreak-002-expected.png:
* platform/mac/fast/text/international/bidi-linebreak-002-expected.txt:
* platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum:
* platform/mac/fast/text/international/bidi-linebreak-003-expected.png:
* platform/mac/fast/text/international/bidi-linebreak-003-expected.txt:
* platform/mac/fast/text/international/bidi-listbox-atsui-expected.checksum:
* platform/mac/fast/text/international/bidi-listbox-atsui-expected.png:
* platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt:
* platform/mac/fast/text/international/bidi-listbox-expected.checksum:
* platform/mac/fast/text/international/bidi-listbox-expected.png:
* platform/mac/fast/text/international/bidi-listbox-expected.txt:
* platform/mac/fast/text/international/bidi-menulist-expected.checksum:
* platform/mac/fast/text/international/bidi-menulist-expected.png:
* platform/mac/fast/text/international/bidi-menulist-expected.txt:
* platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
* platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
* platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
* platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
* platform/mac/fast/text/international/bidi-neutral-run-expected.png:
* platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
* platform/mac/fast/text/international/bidi-override-expected.checksum:
* platform/mac/fast/text/international/bidi-override-expected.png:
* platform/mac/fast/text/international/bidi-override-expected.txt:
* platform/mac/fast/text/international/danda-space-expected.checksum:
* platform/mac/fast/text/international/danda-space-expected.png:
* platform/mac/fast/text/international/danda-space-expected.txt:
* platform/mac/fast/text/international/hebrew-vowels-expected.checksum:
* platform/mac/fast/text/international/hebrew-vowels-expected.png:
* platform/mac/fast/text/international/hebrew-vowels-expected.txt:
* platform/mac/fast/text/international/hindi-spacing-expected.checksum:
* platform/mac/fast/text/international/hindi-spacing-expected.png:
* platform/mac/fast/text/international/hindi-spacing-expected.txt:
* platform/mac/fast/text/international/hindi-whitespace-expected.checksum:
* platform/mac/fast/text/international/hindi-whitespace-expected.png:
* platform/mac/fast/text/international/hindi-whitespace-expected.txt:
* platform/mac/fast/text/international/plane2-expected.checksum:
* platform/mac/fast/text/international/plane2-expected.png:
* platform/mac/fast/text/international/plane2-expected.txt:
* platform/mac/fast/text/international/rtl-caret-expected.checksum:
* platform/mac/fast/text/international/rtl-caret-expected.png:
* platform/mac/fast/text/international/rtl-caret-expected.txt:
* platform/mac/fast/text/international/thai-baht-space-expected.checksum:
* platform/mac/fast/text/international/thai-baht-space-expected.png:
* platform/mac/fast/text/international/thai-baht-space-expected.txt:
* platform/mac/fast/text/international/thai-line-breaks-expected.checksum:
* platform/mac/fast/text/international/thai-line-breaks-expected.png:
* platform/mac/fast/text/international/thai-line-breaks-expected.txt:
* platform/mac/fast/text/international/wrap-CJK-001-expected.checksum:
* platform/mac/fast/text/international/wrap-CJK-001-expected.png:
* platform/mac/fast/text/international/wrap-CJK-001-expected.txt:
* platform/mac/mathml/presentation/attributes-expected.checksum:
* platform/mac/mathml/presentation/attributes-expected.png:
* platform/mac/mathml/presentation/attributes-expected.txt:
* platform/mac/mathml/presentation/fractions-expected.checksum:
* platform/mac/mathml/presentation/fractions-expected.png:
* platform/mac/mathml/presentation/fractions-expected.txt:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/mac/mathml/presentation/mo-expected.checksum:
* platform/mac/mathml/presentation/mo-expected.png:
* platform/mac/mathml/presentation/mo-expected.txt:
* platform/mac/mathml/presentation/over-expected.checksum:
* platform/mac/mathml/presentation/over-expected.png:
* platform/mac/mathml/presentation/over-expected.txt:
* platform/mac/mathml/presentation/roots-expected.checksum:
* platform/mac/mathml/presentation/roots-expected.png:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/row-alignment-expected.checksum:
* platform/mac/mathml/presentation/row-alignment-expected.png:
* platform/mac/mathml/presentation/row-alignment-expected.txt:
* platform/mac/mathml/presentation/row-expected.txt:
* platform/mac/mathml/presentation/style-expected.txt:
* platform/mac/mathml/presentation/sub-expected.txt:
* platform/mac/mathml/presentation/subsup-expected.txt:
* platform/mac/mathml/presentation/sup-expected.checksum:
* platform/mac/mathml/presentation/sup-expected.png:
* platform/mac/mathml/presentation/sup-expected.txt:
* platform/mac/mathml/presentation/tables-expected.checksum:
* platform/mac/mathml/presentation/tables-expected.png:
* platform/mac/mathml/presentation/tables-expected.txt:
* platform/mac/mathml/presentation/tokenElements-expected.txt:
* platform/mac/mathml/presentation/under-expected.checksum:
* platform/mac/mathml/presentation/under-expected.png:
* platform/mac/mathml/presentation/under-expected.txt:
* platform/mac/mathml/presentation/underover-expected.checksum:
* platform/mac/mathml/presentation/underover-expected.png:
* platform/mac/mathml/presentation/underover-expected.txt:
* platform/mac/mathml/xHeight-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-15 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 17 Nov 2010 05:56:42 +0000 (05:56 +0000)]
2010-11-15  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        ScriptElementData should be a private member of ScriptElement
        https://bugs.webkit.org/show_bug.cgi?id=49578

        Privatized m_data of ScriptElement. Added haveFiredLoadEvent, setHaveFiredLoadEvent, createdByParser,
        and isEvaluated to ScriptElement to proxy calls from HTMLScriptElement and SVGScriptElement to ScriptElementData.

        No tests are added since this is a cleanup.

        * dom/ScriptElement.h:
        (WebCore::ScriptElement::haveFiredLoadEvent): Added.
        (WebCore::ScriptElement::setHaveFiredLoadEvent): Added.
        (WebCore::ScriptElement::createdByParser): Added.
        (WebCore::ScriptElement::isEvaluated): Added.
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::dispatchLoadEvent): Calls haveFiredLoadEvent and setHaveFiredLoadEvent.
        (WebCore::HTMLScriptElement::cloneElementWithoutAttributesAndChildren): Calls isEvaluated.
        * html/HTMLScriptElement.h:
        (WebCore::HTMLScriptElement::text): Calls scriptContent.
        (WebCore::HTMLScriptElement::haveFiredLoadEvent): Calls haveFiredLoadEvent.
        * svg/SVGScriptElement.cpp:
        (WebCore::SVGScriptElement::svgAttributeChanged): Calls haveFiredLoadEvent and createdByParser.
        (WebCore::SVGScriptElement::insertedIntoDocument): Calls createdByParser.
        (WebCore::SVGScriptElement::finishParsingChildren): Calls setHaveFiredLoadEvent.
        (WebCore::SVGScriptElement::haveLoadedRequiredResources): Ditto.
        (WebCore::SVGScriptElement::dispatchLoadEvent): Calls haveFiredLoadEvent.
        (WebCore::SVGScriptElement::cloneElementWithoutAttributesAndChildren): Calls createdByParser,
        haveFiredLoadEvent, and setHaveFiredLoadEvent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=49320
antti@apple.com [Wed, 17 Nov 2010 04:52:02 +0000 (04:52 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=49320
Minor ResourceLoadScheduler cleanups

Reviewed by Darin Adler.

* loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::scheduleLoad):
(WebCore::ResourceLoadScheduler::servePendingRequests):
(WebCore::ResourceLoadScheduler::HostInformation::~HostInformation):
(WebCore::ResourceLoadScheduler::HostInformation::remove):
(WebCore::ResourceLoadScheduler::HostInformation::hasRequests):
* loader/ResourceLoadScheduler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a baselineType member to RootInlineBox that caches whether the default baseline...
hyatt@apple.com [Wed, 17 Nov 2010 04:13:06 +0000 (04:13 +0000)]
Add a baselineType member to RootInlineBox that caches whether the default baseline behavior for that
line should be ideographic or alphabetic.  Add a requiresIdeographicsBaseline recursive function to
InlineFlowBox that scans for the use of any vertical fonts.

Reviewed by Sam Weinig.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::requiresIdeographicBaseline):
* rendering/InlineFlowBox.h:
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::baselineType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate WebKit2 skipped list.
weinig@apple.com [Wed, 17 Nov 2010 03:35:01 +0000 (03:35 +0000)]
Update WebKit2 skipped list.

Rubber-stamped by Jon Honeycutt.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=31223
antti@apple.com [Wed, 17 Nov 2010 03:24:52 +0000 (03:24 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=31223
Make primitive values immutable.

Patch by Antti Koivisto <koivisto@iki.fi> on 2010-11-16
Reviewed by Adam Barth.

Update test cases for behavior change and test computed style too. Note that there are some
failures in the results demonstrating unrelated bugs in CSSPrimitiveValues.

* fast/dom/script-tests/setPrimitiveValue-exceptions.js:
(checkThrows):
* fast/dom/setPrimitiveValue.html:
* fast/dom/setPrimitiveValue-exceptions-expected.txt
* fast/dom/setPrimitiveValue-expected.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd FontBaseline.h and make ascent and descent take a baseline parameter so that...
hyatt@apple.com [Wed, 17 Nov 2010 03:24:39 +0000 (03:24 +0000)]
Add FontBaseline.h and make ascent and descent take a baseline parameter so that both an
alphabetic and ideographic baseline can be requested.

Reviewed by Sam Weinig.

* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/Font.h:
(WebCore::Font::ascent):
(WebCore::Font::descent):
* platform/graphics/FontBaseline.h: Added.
* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::ascent):
(WebCore::SimpleFontData::descent):
(WebCore::SimpleFontData::height):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake sure the pref for minimum font size is just explicitly set to 0 every time,
hyatt@apple.com [Wed, 17 Nov 2010 03:20:32 +0000 (03:20 +0000)]
Make sure the pref for minimum font size is just explicitly set to 0 every time,
since the bots have 1 stuck in their plist otherwise.

Reviewed by Sam Weinig.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=31223
antti@apple.com [Wed, 17 Nov 2010 03:15:47 +0000 (03:15 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=31223
Make primitive values immutable.

Patch by Antti Koivisto <koivisto@iki.fi> on 2010-11-16
Reviewed by Adam Barth.

Make CSSPrimitiveValue setFloatValue and setStringValue always throw NO_MODIFICATION_ALLOWED exception.

Reasoning:
- these setters never worked correctly, style was not invalidated so changing values would have no effect on rendering
- computed style is immutable in all cases, and it wasn't
- no other engine seems to support mutable primitives, as a result there is no content using these APIs
- mutable primitive values are pointless, the usual way to change the value of a propertly is to replace it with a new value
- allowing mutation of primitive values makes optimizations harder

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::setFloatValue):
(WebCore::CSSPrimitiveValue::setStringValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Support enabling site-specific quirks
weinig@apple.com [Wed, 17 Nov 2010 03:13:27 +0000 (03:13 +0000)]
WebKit2: Support enabling site-specific quirks
<rdar://problem/8451371>
https://bugs.webkit.org/show_bug.cgi?id=46076

Reviewed by Adam Roben.

* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):
* Shared/WebPreferencesStore.h:
Add needsSiteSpecificQuirks;

* UIProcess/API/C/WKAPICast.h:
(WebKit::toFontSmoothingLevel):
(WebKit::toAPI):
Move FontSmoothing conversion functions here.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetFontSmoothingLevel):
(WKPreferencesGetFontSmoothingLevel):
(WKPreferencesSetAcceleratedCompositingEnabled):
(WKPreferencesGetAcceleratedCompositingEnabled):
(WKPreferencesSetCompositingBordersVisible):
(WKPreferencesGetCompositingBordersVisible):
(WKPreferencesSetCompositingRepaintCountersVisible):
(WKPreferencesGetCompositingRepaintCountersVisible):
(WKPreferencesSetNeedsSiteSpecificQuirks):
(WKPreferencesGetNeedsSiteSpecificQuirks):
Add WKPreferencesSetNeedsSiteSpecificQuirks/WKPreferencesGetNeedsSiteSpecificQuirks
and move implementations from WKPreferencesPrivate.cpp here.

* UIProcess/API/C/WKPreferencesPrivate.cpp: Removed.

* UIProcess/API/C/WKPreferencesPrivate.h:
Add Add WKPreferencesSetNeedsSiteSpecificQuirks/WKPreferencesGetNeedsSiteSpecificQuirks.

* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::setNeedsSiteSpecificQuirks):
(WebKit::WebPreferences::needsSiteSpecificQuirks):
* UIProcess/WebPreferences.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Pipe through needsSiteSpecificQuirks.

* WebKit2.xcodeproj/project.pbxproj:
* WebKit2.pro:
* win/WebKit2.vcproj:
Update for removed files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate SVG layout test.
hyatt@apple.com [Wed, 17 Nov 2010 03:11:17 +0000 (03:11 +0000)]
Update SVG layout test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 49635 - Profiler implementation is fragile
barraclough@apple.com [Wed, 17 Nov 2010 03:03:34 +0000 (03:03 +0000)]
Bug 49635 - Profiler implementation is fragile

Reviewed by Sam Weinig.

The profile presently requires the exception handling mechanism to explicitly
remove all stack frames that are exited during the exception unwind mechanism.
This is fragile in a number of ways:
  * We have to change bytecode register allocation when compiling code to run
    when profiling, to preserve the callee function (this is also required to
    call did_call after the call has returned).
  * In the JIT we have to maintain additional data structures
    (CodeBlock::RareData::m_functionRegisterInfos) to map back to the register
    containing the callee.
  * In the interpreter we use 'magic values' to offset into the instruction
    stream to rediscover the register containing the function.

Instead, move profiling into the head and tail of functions.
  * This correctly accounts the cost of the call itself to the caller.
  * This allows us to access the callee function object from the callframe.
  * This means that at the point a call is made we can track the stack depth
    on the ProfileNode.
  * When unwinding we can simply report the depth at which the exception is
    being handled - all call frames above this level are freed.

* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::methodCallLinkInfo):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitReturn):
(JSC::BytecodeGenerator::emitConstruct):
* bytecompiler/BytecodeGenerator.h:
(JSC::CallArguments::count):
* bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):
* interpreter/Interpreter.cpp:
(JSC::ProfileHostCall::ProfileHostCall):
(JSC::ProfileHostCall::~ProfileHostCall):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_profile_has_called):
(JSC::JIT::emit_op_profile_will_return):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_profile_has_called):
(JSC::JIT::emit_op_profile_will_return):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
* profiler/Profile.cpp:
(JSC::Profile::Profile):
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::addParentForConsoleStart):
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):
(JSC::ProfileGenerator::exceptionUnwind):
(JSC::ProfileGenerator::stopProfiling):
* profiler/ProfileGenerator.h:
* profiler/ProfileNode.cpp:
(JSC::ProfileNode::ProfileNode):
(JSC::ProfileNode::willExecute):
* profiler/ProfileNode.h:
(JSC::ProfileNode::create):
(JSC::ProfileNode::operator==):
(JSC::ProfileNode::exec):
* profiler/Profiler.cpp:
(JSC::dispatchFunctionToProfiles):
(JSC::Profiler::hasCalled):
(JSC::Profiler::willEvaluate):
(JSC::Profiler::willReturn):
(JSC::Profiler::didEvaluate):
(JSC::Profiler::exceptionUnwind):
* profiler/Profiler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTouch Platform.h to force a rebuild for Windows.
bweinstein@apple.com [Wed, 17 Nov 2010 02:58:01 +0000 (02:58 +0000)]
Touch Platform.h to force a rebuild for Windows.

Reviewed by Adam Roben and Steve Falkenburg.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoForce a clean build for Windows projects using precompiled headers. Unreviewed.
sfalken@apple.com [Wed, 17 Nov 2010 02:39:32 +0000 (02:39 +0000)]
Force a clean build for Windows projects using precompiled headers. Unreviewed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 17 Nov 2010 02:37:28 +0000 (02:37 +0000)]
2010-11-16  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        Rebaseline server: display test results
        https://bugs.webkit.org/show_bug.cgi?id=49626

        Adds basic result display to the rebaseline server. On the Python side
        this involves:
        - Parsing the unexpected_results.json into a dictionary.
        - Serving it as JSON under /results.json.
        (the JSON -> dict -> JSON transform isn't strictly necessary right now,
        but I'll need to have access to the parsed results on the Python side
        for follow-up changes).

        On the web UI side this adds:
        - Markup for display image and text results (expected, actual, diff),
          and JS for populating it.
        - Markup for breaking down test results by failure type and directory,
          and JS for populating it.

        * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
        * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
        * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
        * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
        * Scripts/webkitpy/tool/commands/rebaselineserver.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 17 Nov 2010 02:24:42 +0000 (02:24 +0000)]
2010-11-16  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        See Chromium issue http://codereview.chromium.org/5133001/ - we
        are modifying the build bots to pass in the builder name with
        the "GPU" string appended instead of appending it in the code.

        https://bugs.webkit.org/show_bug.cgi?id=49636

        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix horizontal scrolling via the mousewheel/trackpad on Windows
aroben@apple.com [Wed, 17 Nov 2010 02:21:51 +0000 (02:21 +0000)]
Fix horizontal scrolling via the mousewheel/trackpad on Windows

Reviewed by Mark Rowe.

* Shared/win/WebEventFactory.cpp: Fixed typo in the
WM_VISTA_MOUSEHWHEEL constant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 17 Nov 2010 02:20:10 +0000 (02:20 +0000)]
2010-11-16  Mihai Parparita  <mihaip@chromium.org>

        Update the pixel expectations for fast/reflections, fast/replaced, fast/ruby, fast/runin, and fast/text for the Mac port.

        For the tests that currently fail on Snow Leopard with --pixel-tests
        --tolerance 0, this moves the current pixel results to mac-leopard and
        adds new Snow Leopard-specific results to platform/mac.

        List of files omitted due to length but composed entirely of moves from
        platform/mac to platform/mac-leopard and newly added files in
        platform/mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 17 Nov 2010 01:49:24 +0000 (01:49 +0000)]
2010-11-16  Mihai Parparita  <mihaip@chromium.org>

        Update the pixel expectations for fast/html, fast/images, fast/innerHTML, fast/inspector-support, fast/loader, fast/media, fast/multicol, and fast/parser for the Mac port.

        For the tests that currently fail on Snow Leopard with --pixel-tests
        --tolerance 0, this moves the current pixel results to mac-leopard and
        adds new Snow Leopard-specific results to platform/mac.

        List of files omitted due to length but composed entirely of moves from
        platform/mac to platform/mac-leopard and newly added files in
        platform/mac.

        Also includes updated baselines for fast/forms after r72052 changed how
        placeholders are rendered.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Wed, 17 Nov 2010 01:03:34 +0000 (01:03 +0000)]
2010-11-16  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
        https://bugs.webkit.org/show_bug.cgi?id=49632

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.vcproj/jsc/jsc.vcproj:
        * JavaScriptCore.vcproj/testapi/testapi.vcproj:
2010-11-16  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
        https://bugs.webkit.org/show_bug.cgi?id=49632

        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/WebKit.make:
        * WebKit.vcproj/WebKit.sln:
        * WebKit.vcproj/WebKit.submit.sln:
        * WebKit.vcproj/WebKit.vcproj:
        * WebKit.vcproj/WebKitGUID.vcproj:
2010-11-16  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
        https://bugs.webkit.org/show_bug.cgi?id=49632

        * WebCore.vcproj/QTMovieWin.vcproj:
        * WebCore.vcproj/WebCore.make:
        * WebCore.vcproj/WebCore.sln:
        * WebCore.vcproj/WebCore.vcproj:
2010-11-16  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
        https://bugs.webkit.org/show_bug.cgi?id=49632

        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/ImageDiff.vcproj:
        * MiniBrowser/MiniBrowser.vcproj:
        * TestWebKitAPI/win/TestWebKitAPI.vcproj:
        * WebKitLauncherWin/WebKitLauncherWin.vcproj:
        * WebKitTestRunner/win/InjectedBundle.vcproj:
        * WebKitTestRunner/win/WebKitTestRunner.vcproj:
        * WinLauncher/WinLauncher.vcproj:
        * record-memory-win/record-memory-win.vcproj:
2010-11-16  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
        https://bugs.webkit.org/show_bug.cgi?id=49632

        * win/WebKit2.make:
        * win/WebKit2.submit.sln:
        * win/WebKit2.vcproj:
        * win/WebKit2WebProcess.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
mrowe@apple.com [Wed, 17 Nov 2010 01:02:40 +0000 (01:02 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 17 Nov 2010 00:36:06 +0000 (00:36 +0000)]
2010-11-16  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread

        Rename the TestInfo class to TestInput to be clearer about its
        function, and move the checksum-reading code into dump_render_tree_thread
        to avoid cross-thread access.

        https://bugs.webkit.org/show_bug.cgi?id=49573

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHandle converting a ResourceHandle to a download
andersca@apple.com [Wed, 17 Nov 2010 00:19:25 +0000 (00:19 +0000)]
Handle converting a ResourceHandle to a download
https://bugs.webkit.org/show_bug.cgi?id=49631

Reviewed by Sam Weinig.

* WebProcess/Downloads/Download.h:
Add startWithHandle.

* WebProcess/Downloads/DownloadManager.h:
* WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::convertHandleToDownload):
Create a new Download object and call startWithHandle on it.

* WebProcess/Downloads/cf/DownloadCFNet.cpp:
(WebKit::Download::startWithHandle):
Add stub.

* WebProcess/Downloads/mac/DownloadMac.mm:
(WebKit::Download::startWithHandle):
Create an NSURLDownload object from passed in ResourceHandle.

* WebProcess/Downloads/qt/DownloadQt.cpp:
(WebKit::Download::startWithHandle):
Add stub.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::download):
Call WebFrame::convertHandleToDownload.

* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::convertHandleToDownload):
Call DownloadManager::convertHandleToDownload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix bustage. Remove the minimum font size pref setting in DumpRenderTree.
hyatt@apple.com [Wed, 17 Nov 2010 00:18:04 +0000 (00:18 +0000)]
Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
slewis@apple.com [Tue, 16 Nov 2010 23:54:36 +0000 (23:54 +0000)]
<rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests

Reviewed by Geoff Garen.

WebKit/mac:

Make a static provider for WebDeviceOrientationProviderMock.  The old code allocated a new WebDeviceOrientationProviderMock for
every WebView, and the WebKit API doesn't support that ownership model.

* WebView/WebDeviceOrientationProviderMock.h:
* WebView/WebDeviceOrientationProviderMock.mm:
(+[WebDeviceOrientationProviderMock shared]):

WebKitTools:

Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock
for every WebView, and the WebKit API doesn't support that ownership model.

I also fixed a leak in setMockDeviceOrientation by adding a missing release.

* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setMockDeviceOrientation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSet the original URL for downloads
andersca@apple.com [Tue, 16 Nov 2010 23:52:41 +0000 (23:52 +0000)]
Set the original URL for downloads
https://bugs.webkit.org/show_bug.cgi?id=49628

Reviewed by John Sullivan.

WebCore:

Export symbols needed by WebKit2.

* WebCore.exp.in:

WebKit2:

* WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
* WebProcess/Downloads/DownloadManager.h:
startDownload now takes the originating web page.

* WebProcess/Downloads/cf/DownloadCFNet.cpp:
(WebKit::Download::start):
start now takes the originating web page.

* WebProcess/Downloads/mac/DownloadMac.mm:
(WebKit::originatingURL):
(WebKit::setOriginalURLForDownload):
Port code over from WebKit1 that sets the download URL.

(WebKit::Download::start):
Call setOriginalURLForDownload.

* WebProcess/Downloads/qt/DownloadQt.cpp:
(WebKit::Download::start):
start now takes the originating web page.

* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::startDownload):
Pass the web page to DownloadManager::startDownload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 16 Nov 2010 23:32:21 +0000 (23:32 +0000)]
2010-11-16  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: log the process id in --verbose mode

        As part of the switch to multi-process mode, we should log the
        process id when running w/ --verbose.

        https://bugs.webkit.org/show_bug.cgi?id=49571

        * Scripts/webkitpy/layout_tests/layout_package/printing.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=11004
hyatt@apple.com [Tue, 16 Nov 2010 23:28:53 +0000 (23:28 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=11004

Reviewed by Dan Bernstein.

font-size:0 is ignored.  Remove the minimum font size of 1 in CSSStyleSelector.
Change the pref value for minimum font size from 1 to 0.  Make sure to never use the NSFont's size,
since it doesn't honor a size of 0.  Instead pass the size in to the FontPlatformData(NSFont*) version
of the constructor rather than using [NSFont pointSize].

https://bugs.webkit.org/show_bug.cgi?id=49582

Negative leading is not handled correctly.  There are two bugs here.  The first is that
maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
set them before so that we can allow them to be < 0.

The second issue is that we should understand where fonts will end up relative to
our baseline (excluding line height), and only allow those boxes to impact ascent and
descent if the actual font box (without factoring in line height) is above or below the
root line box baseline.

Added fast/css/negative-leading.html

These two bug fixes have to land together to keep the Acid 3 test rendering correctly.

WebCore:

* WebCore.exp.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
* platform/graphics/cocoa/FontPlatformData.h:
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::smallCapsFontData):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
* rendering/InlineFlowBox.h:
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection):

WebKit/mac:

* Misc/WebKitNSStringExtras.mm:
(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
(-[NSString _web_widthWithFont:]):
* Misc/WebStringTruncator.mm:
(fontFromNSFont):
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):

WebKit/win:

* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):

WebKit2:

* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):

LayoutTests:

* fast/css/negative-leading.html: Added.
* platform/mac/fast/compact/001-expected.checksum:
* platform/mac/fast/compact/001-expected.png:
* platform/mac/fast/compact/001-expected.txt:
* platform/mac/fast/css/negative-leading-expected.checksum: Added.
* platform/mac/fast/css/negative-leading-expected.png: Added.
* platform/mac/fast/css/negative-leading-expected.txt: Added.
* platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
* platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
* platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
* platform/mac/fast/parser/style-script-head-test-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Peter Varga <pvarga@inf.u-szeged.hu>
commit-queue@webkit.org [Tue, 16 Nov 2010 23:27:13 +0000 (23:27 +0000)]
2010-11-16  Peter Varga  <pvarga@inf.u-szeged.hu>

        Reviewed by Gavin Barraclough.

        The number of recursive match calls isn't limited in YARR Interpreter
        https://bugs.webkit.org/show_bug.cgi?id=47906

        Check the number of the matchDisjunction recursive calls to avoid unbounded
        recursion.
        Now the matchDisjunction function returns JSRegExpResult instead of bool.
        The JSRegExpResult enum contains the result of matching or the error code
        of the failure (like HitLimit) which terminates the matching.
        The error codes are based on pcre's jsRegExpExecute error codes.

        * yarr/RegexInterpreter.cpp:
        (JSC::Yarr::Interpreter::parenthesesDoBacktrack):
        (JSC::Yarr::Interpreter::matchParentheses):
        (JSC::Yarr::Interpreter::backtrackParentheses):
        (JSC::Yarr::Interpreter::matchDisjunction):
        (JSC::Yarr::Interpreter::matchNonZeroDisjunction):
        (JSC::Yarr::Interpreter::interpret):
        (JSC::Yarr::Interpreter::Interpreter):
        * yarr/RegexInterpreter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoved lines for tests that are now passing after r72137.
levin@chromium.org [Tue, 16 Nov 2010 22:55:17 +0000 (22:55 +0000)]
Removed lines for tests that are now passing after r72137.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=49611
darin@apple.com [Tue, 16 Nov 2010 22:51:22 +0000 (22:51 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=49611
REGRESSION (r72115): 5 layout tests are broken

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadFrameRequest): Roll change from
https://bugs.webkit.org/show_bug.cgi?id=48603 out. I'll roll
it back in after fixing the failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Tue, 16 Nov 2010 22:43:06 +0000 (22:43 +0000)]
2010-11-16  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Use vsprops files for common settings in Windows WebKit
        https://bugs.webkit.org/show_bug.cgi?id=49622

        * WebKit.vcproj/WebKit.vcproj:
        * WebKit.vcproj/WebKitCommon.vsprops: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8672000> REGRESSION (r72040): Error image with alt text can cause...
mitz@apple.com [Tue, 16 Nov 2010 22:08:26 +0000 (22:08 +0000)]
<rdar://problem/8672000> REGRESSION (r72040): Error image with alt text can cause style to be frozen in a subtree
https://bugs.webkit.org/show_bug.cgi?id=49579

Reviewed by Simon Fraser.

WebCore:

r72040 introduced a call to setNeedsStyleRecalc() from RenderImage::imageChanged(). When imageChanged()
got called beneath recalcStyle() on some ancestor element, the result was that the ancestor’s
childNeedsStyleRecalc flag got cleared, but its descendants all the way down to the image did not.
Thereafter, setNeedsStyleRecalc() would fail to propagate from that subtree up to the root. The fix
is to avoid the newly-added setNeedsStyleRecalc() in most cases, including during reclacStyle(), and
just keep it for when it is needed.

Tests: fast/block/float/015.html
       fast/images/style-access-during-imageChanged-style-freeze.html

* dom/Document.cpp:
(WebCore::Document::isPendingStyleRecalc): Added.
* dom/Document.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged): Only defer intrinsic size compoutation if a style recalc
is coming (indicating that current style() is stale).

LayoutTests:

* fast/block/float/015.html: Copied from LayoutTests/fast/block/float/015.html-disabled.
* fast/block/float/015.html-disabled: Removed.
* fast/images/style-access-during-imageChanged-style-freeze-expected.txt: Added.
* fast/images/style-access-during-imageChanged-style-freeze.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRest of the Windows build fix.
bweinstein@apple.com [Tue, 16 Nov 2010 21:56:46 +0000 (21:56 +0000)]
Rest of the Windows build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Chromium expectations update.
levin@chromium.org [Tue, 16 Nov 2010 21:44:22 +0000 (21:44 +0000)]
Unreviewed Chromium expectations update.

* platform/chromium/test_expectations.txt: Added
  the failure expectations for 5 tests which are failing
  due to r72115 (and filed bug 49620 about the issue).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix pt 1.
barraclough@apple.com [Tue, 16 Nov 2010 21:41:52 +0000 (21:41 +0000)]
Windows build fix pt 1.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix clang++ build.
andersca@apple.com [Tue, 16 Nov 2010 21:30:32 +0000 (21:30 +0000)]
Fix clang++ build.

* Scripts/webkit2/messages.py:
* WebProcess/WebPage/WebInspector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-11 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 16 Nov 2010 21:23:41 +0000 (21:23 +0000)]
2010-11-11  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
        https://bugs.webkit.org/show_bug.cgi?id=47196

        * src/WebImageDecoder.cpp:
        (WebKit::WebImageDecoder::init): Add ignoreGammaAndColorProfile parameter.
2010-11-11  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
        https://bugs.webkit.org/show_bug.cgi?id=47196

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::texImage2DImpl): Apply UNPACK_COLORSPACE_CONVERSION settings to image uploading.
        (WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto.
        * platform/graphics/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3D::extractImageData): Ditto.
        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/ImageSource.cpp:
        (WebCore::ImageSource::ImageSource): Add ignoreGammaColorProfile parameter.
        (WebCore::ImageSource::setData): Ditto.
        * platform/graphics/ImageSource.h:
        * platform/graphics/cg/GraphicsContext3DCG.cpp:
        (WebCore::GraphicsContext3D::getImageData): Ditto.
        * platform/graphics/cg/ImageSourceCG.cpp:
        (WebCore::ImageSource::ImageSource): Ditto.
        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::getImageData): Ditto.
        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoder::create): Ditto.
        (WebCore::ImageDecoderQt::ImageDecoderQt): Ditto.
        * platform/graphics/qt/ImageDecoderQt.h:
        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        (WebCore::GraphicsContext3D::getImageData): Ditto.
        * platform/image-decoders/ImageDecoder.cpp:
        (WebCore::ImageDecoder::create): Ditto.
        * platform/image-decoders/ImageDecoder.h:
        (WebCore::ImageDecoder::ImageDecoder): Ditto.
        * platform/image-decoders/bmp/BMPImageDecoder.cpp:
        (WebCore::BMPImageDecoder::BMPImageDecoder):
        * platform/image-decoders/bmp/BMPImageDecoder.h:
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::GIFImageDecoder): Ditto.
        * platform/image-decoders/gif/GIFImageDecoder.h:
        * platform/image-decoders/ico/ICOImageDecoder.cpp:
        (WebCore::ICOImageDecoder::ICOImageDecoder): Ditto.
        (WebCore::ICOImageDecoder::decodeAtIndex): Ditto.
        * platform/image-decoders/ico/ICOImageDecoder.h:
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageDecoder::JPEGImageDecoder): Ditto.
        * platform/image-decoders/jpeg/JPEGImageDecoder.h:
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::PNGImageDecoder): Ditto.
        (WebCore::PNGImageDecoder::headerAvailable): Ignore gamma settings if ignoreGammaAndColorProfile is true.
        * platform/image-decoders/png/PNGImageDecoder.h:
        * platform/image-decoders/webp/WEBPImageDecoder.cpp:
        (WebCore::WEBPImageDecoder::WEBPImageDecoder): Add ignoreGammaAndColorProfile parameter.
        * platform/image-decoders/webp/WEBPImageDecoder.h:
2010-11-11  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
        https://bugs.webkit.org/show_bug.cgi?id=47196

        * fast/canvas/webgl/gl-teximage-expected.txt:
        * fast/canvas/webgl/gl-teximage.html: Testing that if UNPACK_COLORSPACE_CONVERSION is NONE, gamma settings are not applied to images.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix clang++ build.
andersca@apple.com [Tue, 16 Nov 2010 21:15:28 +0000 (21:15 +0000)]
Fix clang++ build.

* WebCoreSupport/WebFrameLoaderClient.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 16 Nov 2010 21:12:58 +0000 (21:12 +0000)]
2010-11-16  Eric Carlson  <eric.carlson@apple.com>

        Unreviewed attempt to fix GTK build after http://trac.webkit.org/changeset/72117

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::installedMediaEngines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=49606
barraclough@apple.com [Tue, 16 Nov 2010 21:11:26 +0000 (21:11 +0000)]
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=49606

Reviewed by Oliver Hunt.

The bug here is that we read the prototype from the RHS argument using a regular
op_get_by_id before op_instanceof has checked that this is an object implementing
HasInstance. This incorrect behaviour gives rise to further unnecessary complexity
in the code base, since we have additional logic (implemented using the
GetByIdExceptionInfo data structures on CodeBlock) to convert not an object errors
from the get_by_id into invalid parameter errors. Having fixed this bug this code
is all redundant, since in these cases the get_by_id will never have been reached.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addExpressionInfo):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCheckHasInstance):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::InstanceOfNode::emitBytecode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_check_has_instance):
(JSC::JIT::emitSlow_op_instanceof):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_check_has_instance):
(JSC::JIT::emitSlow_op_instanceof):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
* runtime/ExceptionHelpers.cpp:
(JSC::createInterruptedExecutionException):
(JSC::createTerminatedExecutionException):
(JSC::createUndefinedVariableError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):
* runtime/ExceptionHelpers.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::toPrimitive):
(JSC::JSNotAnObject::getPrimitiveNumber):
(JSC::JSNotAnObject::toBoolean):
(JSC::JSNotAnObject::toNumber):
(JSC::JSNotAnObject::toString):
(JSC::JSNotAnObject::toObject):
(JSC::JSNotAnObject::getOwnPropertySlot):
(JSC::JSNotAnObject::getOwnPropertyDescriptor):
(JSC::JSNotAnObject::put):
(JSC::JSNotAnObject::deleteProperty):
(JSC::JSNotAnObject::getOwnPropertyNames):
* runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::JSNotAnObject):
* runtime/JSObject.h:
(JSC::JSObject::isActivationObject):
* runtime/JSValue.cpp:
(JSC::JSValue::toObjectSlowCase):
(JSC::JSValue::synthesizeObject):
(JSC::JSValue::synthesizePrototype):

LayoutTests: Bug 49606 - instanceof should only get the prototype property if the RHS operand implements HasInstance

Reviewed by Oliver Hunt.

* fast/js/instanceof-XMLHttpRequest-expected.txt: Copied from LayoutTests/fast/js/instanceof-operator-expected.txt.
* fast/js/instanceof-XMLHttpRequest.html: Copied from LayoutTests/fast/js/instanceof-operator.html.
* fast/js/script-tests/instanceof-XMLHttpRequest.js: Copied from LayoutTests/fast/js/script-tests/instanceof-operator.js.
    - renamed existing testcase; these really test XMLHttpRequest objects, rather than the instanceof operator.

* fast/js/instanceof-operator-expected.txt:
* fast/js/script-tests/instanceof-operator.js:
    - added test case for: javascript: ({} instanceof { get prototype(){ alert("Error!"); } })

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd WKPageCanShowMIMEType
andersca@apple.com [Tue, 16 Nov 2010 20:49:36 +0000 (20:49 +0000)]
Add WKPageCanShowMIMEType
https://bugs.webkit.org/show_bug.cgi?id=49612

Reviewed by Sam Weinig.

* UIProcess/API/C/WKPage.cpp:
(WKPageCanShowMIMEType):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::canShowMIMEType):
* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Update Qt specific expected results after r72116.
ossy@webkit.org [Tue, 16 Nov 2010 19:39:53 +0000 (19:39 +0000)]
Unreviewed. Update Qt specific expected results after r72116.

Remove CSS Variable support
https://bugs.webkit.org/show_bug.cgi?id=49483

* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-12 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 16 Nov 2010 19:30:32 +0000 (19:30 +0000)]
2010-11-12  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Refactor GL backend flags
        https://bugs.webkit.org/show_bug.cgi?id=49460

        * public/WebGraphicsContext3D.h: Remove GL flag queries at this level.
        * src/GraphicsContext3DChromium.cpp: Ditto.
        * src/GraphicsContext3DInternal.h: Ditto.
        * src/WebGraphicsContext3DDefaultImpl.cpp: Ditto.
        * src/WebGraphicsContext3DDefaultImpl.h: Ditto.
2010-11-12  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Refactor GL backend flags
        https://bugs.webkit.org/show_bug.cgi?id=49460

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::WebGLRenderingContext): Call setupFlags().
        (WebCore::WebGLRenderingContext::initializeNewContext): Remove flag initialization to setupFlags().
        (WebCore::WebGLRenderingContext::setupFlags): Initialize GL flags.
        (WebCore::WebGLRenderingContext::getRenderbufferParameter): Use accessor function instead of member.
        (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto.
        * html/canvas/WebGLRenderingContext.h: Use flags set in setupFlags instead of querying underlying GL implementation.
        (WebCore::WebGLRenderingContext::isGLES2Compliant):
        (WebCore::WebGLRenderingContext::isGLES2NPOTStrict):
        (WebCore::WebGLRenderingContext::isErrorGeneratedOnOutOfBoundsAccesses):
        (WebCore::WebGLRenderingContext::isResourceSafe):
        (WebCore::WebGLRenderingContext::isDepthStencilSupported):
        * platform/graphics/Extensions3D.h: Add NPOT extension.
        * platform/graphics/GraphicsContext3D.h: Remove GL flag queries at this level.
        * platform/graphics/chromium/Extensions3DChromium.h: Add resource_safe and strict_attribs extensions.
        * platform/graphics/mac/GraphicsContext3DMac.mm: Remove GL flag queries at this level.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 16 Nov 2010 19:19:17 +0000 (19:19 +0000)]
2010-11-16  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        WebIDL conversions from string to number and array to number should not generate TypeError
        https://bugs.webkit.org/show_bug.cgi?id=49218

        Recent SVG-related changes to the StrictTypeChecking extended attribute in
        CodeGeneratorJS.pm and CodeGeneratorV8.pm were not correct according to the Web IDL and
        ECMA-262 specifications. In particular, when an attribute or function argument is specified
        as a number type (floating-point or integer), passing in a String or object is not supposed
        to raise an exception.

        The original intent of the StrictTypeChecking extended attribute was to properly raise
        TypeError when an interface type is required, but the supplied object does not implement the
        interface type (http://dev.w3.org/2006/webapi/WebIDL/#es-interface). Historically WebKit has
        silently passed null to the C++ bindings in this case. The handling of strings in the
        original StrictTypeChecking implementation was also incorrect, raising exceptions when it
        should not.

        The semantics of StrictTypeChecking have been changed to enforce only the restrictions on
        interface types. The V8 custom bindings for WebGL have been updated to match the behavior of
        the autogenerated code.

        Test: fast/canvas/webgl/type-conversion-test.html

        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
        (WebCore::getObjectParameter):
        (WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
        (WebCore::V8WebGLRenderingContext::getParameterCallback):
        (WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
        (WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
        (WebCore::vertexAttribAndUniformHelperf):
2010-11-16  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        WebIDL conversions from string to number and array to number should not generate TypeError
        https://bugs.webkit.org/show_bug.cgi?id=49218

        Updated SVG tests which were incorrectly expecting exceptions to be raised when the Web IDL
        and ECMA-262 specifications state that none should be. Incorporated WebGL test from Khronos
        repository verifying the passing objects of various types to APIs.

        Ran all layout tests in Safari on Mac OS X.

        * fast/canvas/webgl/type-conversion-test-expected.txt: Added.
        * fast/canvas/webgl/type-conversion-test.html: Added.
        * svg/dom/SVGAngle-expected.txt:
        * svg/dom/SVGAnimatedBoolean-expected.txt:
        * svg/dom/SVGAnimatedEnumeration-expected.txt:
        * svg/dom/SVGAnimatedInteger-expected.txt:
        * svg/dom/SVGAnimatedNumber-expected.txt:
        * svg/dom/SVGLength-expected.txt:
        * svg/dom/SVGMatrix-expected.txt:
        * svg/dom/SVGNumber-expected.txt:
        * svg/dom/SVGPoint-expected.txt:
        * svg/dom/SVGPreserveAspectRatio-expected.txt:
        * svg/dom/SVGRect-expected.txt:
        * svg/dom/SVGTransform-expected.txt:
        * svg/dom/script-tests/SVGAngle.js:
        * svg/dom/script-tests/SVGAnimatedBoolean.js:
        * svg/dom/script-tests/SVGAnimatedEnumeration.js:
        * svg/dom/script-tests/SVGAnimatedInteger.js:
        * svg/dom/script-tests/SVGAnimatedNumber.js:
        * svg/dom/script-tests/SVGLength.js:
        * svg/dom/script-tests/SVGMatrix.js:
        * svg/dom/script-tests/SVGNumber.js:
        * svg/dom/script-tests/SVGPoint.js:
        * svg/dom/script-tests/SVGPreserveAspectRatio.js:
        * svg/dom/script-tests/SVGRect.js:
        * svg/dom/script-tests/SVGTransform.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake WebPageProxy::decidePolicyForMIMEType a tad synchronous
andersca@apple.com [Tue, 16 Nov 2010 19:00:58 +0000 (19:00 +0000)]
Make WebPageProxy::decidePolicyForMIMEType a tad synchronous
https://bugs.webkit.org/show_bug.cgi?id=49605

Reviewed by Sam Weinig.

Change the DecidePolicyForMIMEType message to be synchronous, and if the policy listener is
invoked from within the decidePolicyForMIMEType callback return the policy information as out
parameters. This is needed in order to convert a loading connection to a download.

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForMIMEType):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Windows build fix.
ap@apple.com [Tue, 16 Nov 2010 18:58:05 +0000 (18:58 +0000)]
    Windows build fix.

        * DerivedSources.cpp: Removing CSS Variables generated files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unnecessary def file, remove outdated def files from vcproj.
sfalken@apple.com [Tue, 16 Nov 2010 18:50:55 +0000 (18:50 +0000)]
Remove unnecessary def file, remove outdated def files from vcproj.

Rubber stamped by Adam Roben.

* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKit_debug.def: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 16 Nov 2010 18:44:46 +0000 (18:44 +0000)]
2010-11-16  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by John Sullivan.

        getMIMEType(s)ForExtension should consult system mapping
        https://bugs.webkit.org/show_bug.cgi?id=49497

        No new tests possible.

        * platform/MIMETypeRegistry.cpp:
        (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): Add the type returned by getMIMETypeForExtension.
        Put the result of mediaMIMETypeMap().get() in a local variable and test instead of calling
        constains() and then get().
        (WebCore::MIMETypeRegistry::getMediaMIMETypesForExtension): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed baseline update for Windows.
sfalken@apple.com [Tue, 16 Nov 2010 18:35:47 +0000 (18:35 +0000)]
Unreviewed baseline update for Windows.
Update test expectations following r72052.

* platform/win/fast/blockflow/vertical-font-fallback-expected.txt: Added.
* platform/win/fast/forms/search-placeholder-value-changed-expected.txt:
* platform/win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/win/fast/forms/textarea-placeholder-set-attribute-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 16 Nov 2010 18:28:22 +0000 (18:28 +0000)]
2010-11-16  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        Rename QTKit based media engine class name
        https://bugs.webkit.org/show_bug.cgi?id=36663

        No new tests as this just renames a class and restructures existing code.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::installedMediaEngines): Use a macro with the platform media player class name to reduce the
        number of #ifs in the code.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h: Rename MediaPlayerPrivate to MediaPlayerPrivateQTKit.
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivateQTKit::create):
        (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine):
        (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
        (WebCore::MediaPlayerPrivateQTKit::~MediaPlayerPrivateQTKit):
        (WebCore::MediaPlayerPrivateQTKit::createQTMovie):
        (WebCore::MediaPlayerPrivateQTKit::createQTMovieView):
        (WebCore::MediaPlayerPrivateQTKit::detachQTMovieView):
        (WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer):
        (WebCore::MediaPlayerPrivateQTKit::destroyQTVideoRenderer):
        (WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
        (WebCore::MediaPlayerPrivateQTKit::destroyQTMovieLayer):
        (WebCore::MediaPlayerPrivateQTKit::currentRenderingMode):
        (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
        (WebCore::MediaPlayerPrivateQTKit::setUpVideoRendering):
        (WebCore::MediaPlayerPrivateQTKit::tearDownVideoRendering):
        (WebCore::MediaPlayerPrivateQTKit::hasSetUpVideoRendering):
        (WebCore::MediaPlayerPrivateQTKit::createQTTime):
        (WebCore::MediaPlayerPrivateQTKit::resumeLoad):
        (WebCore::MediaPlayerPrivateQTKit::load):
        (WebCore::MediaPlayerPrivateQTKit::loadInternal):
        (WebCore::MediaPlayerPrivateQTKit::prepareToPlay):
        (WebCore::MediaPlayerPrivateQTKit::platformMedia):
        (WebCore::MediaPlayerPrivateQTKit::platformLayer):
        (WebCore::MediaPlayerPrivateQTKit::play):
        (WebCore::MediaPlayerPrivateQTKit::pause):
        (WebCore::MediaPlayerPrivateQTKit::duration):
        (WebCore::MediaPlayerPrivateQTKit::currentTime):
        (WebCore::MediaPlayerPrivateQTKit::seek):
        (WebCore::MediaPlayerPrivateQTKit::doSeek):
        (WebCore::MediaPlayerPrivateQTKit::cancelSeek):
        (WebCore::MediaPlayerPrivateQTKit::seekTimerFired):
        (WebCore::MediaPlayerPrivateQTKit::paused):
        (WebCore::MediaPlayerPrivateQTKit::seeking):
        (WebCore::MediaPlayerPrivateQTKit::naturalSize):
        (WebCore::MediaPlayerPrivateQTKit::hasVideo):
        (WebCore::MediaPlayerPrivateQTKit::hasAudio):
        (WebCore::MediaPlayerPrivateQTKit::supportsFullscreen):
        (WebCore::MediaPlayerPrivateQTKit::setVolume):
        (WebCore::MediaPlayerPrivateQTKit::hasClosedCaptions):
        (WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible):
        (WebCore::MediaPlayerPrivateQTKit::setRate):
        (WebCore::MediaPlayerPrivateQTKit::setPreservesPitch):
        (WebCore::MediaPlayerPrivateQTKit::buffered):
        (WebCore::MediaPlayerPrivateQTKit::maxTimeSeekable):
        (WebCore::MediaPlayerPrivateQTKit::maxTimeLoaded):
        (WebCore::MediaPlayerPrivateQTKit::bytesLoaded):
        (WebCore::MediaPlayerPrivateQTKit::totalBytes):
        (WebCore::MediaPlayerPrivateQTKit::cancelLoad):
        (WebCore::MediaPlayerPrivateQTKit::cacheMovieScale):
        (WebCore::MediaPlayerPrivateQTKit::isReadyForVideoSetup):
        (WebCore::MediaPlayerPrivateQTKit::prepareForRendering):
        (WebCore::MediaPlayerPrivateQTKit::updateStates):
        (WebCore::MediaPlayerPrivateQTKit::loadStateChanged):
        (WebCore::MediaPlayerPrivateQTKit::rateChanged):
        (WebCore::MediaPlayerPrivateQTKit::sizeChanged):
        (WebCore::MediaPlayerPrivateQTKit::timeChanged):
        (WebCore::MediaPlayerPrivateQTKit::didEnd):
        (WebCore::MediaPlayerPrivateQTKit::setSize):
        (WebCore::MediaPlayerPrivateQTKit::setVisible):
        (WebCore::MediaPlayerPrivateQTKit::hasAvailableVideoFrame):
        (WebCore::MediaPlayerPrivateQTKit::repaint):
        (WebCore::MediaPlayerPrivateQTKit::paintCurrentFrameInContext):
        (WebCore::MediaPlayerPrivateQTKit::paint):
        (WebCore::MediaPlayerPrivateQTKit::getSupportedTypes):
        (WebCore::MediaPlayerPrivateQTKit::supportsType):
        (WebCore::MediaPlayerPrivateQTKit::isAvailable):
        (WebCore::MediaPlayerPrivateQTKit::disableUnsupportedTracks):
        (WebCore::MediaPlayerPrivateQTKit::sawUnsupportedTracks):
        (WebCore::MediaPlayerPrivateQTKit::supportsAcceleratedRendering):
        (WebCore::MediaPlayerPrivateQTKit::acceleratedRenderingStateChanged):
        (WebCore::MediaPlayerPrivateQTKit::hasSingleSecurityOrigin):
        (WebCore::MediaPlayerPrivateQTKit::movieLoadType):
        (WebCore::MediaPlayerPrivateQTKit::setPreload):
        (WebCore::MediaPlayerPrivateQTKit::mediaTimeForTimeValue):
        (-[WebCoreMovieObserver initWithCallback:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Dave Hyatt.
ap@apple.com [Tue, 16 Nov 2010 18:25:46 +0000 (18:25 +0000)]
    Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=49483
        Remove CSS Variable support

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 16 Nov 2010 18:15:19 +0000 (18:15 +0000)]
2010-11-16  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=48603
        Boolean logic mistake in local file check

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadFrameRequest): Fix logic so that both checks have to pass
        before accepting a local file load.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-15 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 16 Nov 2010 18:04:52 +0000 (18:04 +0000)]
2010-11-15  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Harden additional string functions against large lengths
        https://bugs.webkit.org/show_bug.cgi?id=49574

        * wtf/text/CString.cpp:
        (WTF::CString::init): Check for length that is too large for CString.
        (WTF::CString::newUninitialized): Ditto.
        (WTF::CString::copyBufferIfNeeded): Fix types so the length stays
        in a size_t.

        * wtf/text/WTFString.cpp:
        (WTF::String::append): Check for length that is too large.
2010-11-15  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Harden additional string functions against large lengths
        https://bugs.webkit.org/show_bug.cgi?id=49574

        * platform/text/TextCodecUTF16.cpp:
        (WebCore::TextCodecUTF16::encode): Check for length that is
        too large for size_t.

        * platform/text/TextStream.cpp:
        (WebCore::TextStream::operator<<): Check for length that is
        too large for size_t.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Carlos Garcia Campos <cgarcia@igalia.com>
mrobinson@webkit.org [Tue, 16 Nov 2010 17:56:23 +0000 (17:56 +0000)]
2010-11-16  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Some key-press events can't be handled by WebView
        https://bugs.webkit.org/show_bug.cgi?id=48986

        The problem is that "popup-menu" and "show-help" signals are
        handled by GtkTextView, as they are added to the key bindings set
        of every widget in gtk_widget_class_init(). For all other bindings
        handled by GtkTextView we are stopping the signal emission in
        their callbacks, so we only need to do the same for "popup-menu"
        and "show-help" signals.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::toggleOverwriteCallback):
        (WebKit::popupMenuCallback):
        (WebKit::showHelpCallback):
        (WebKit::EditorClient::EditorClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 16 Nov 2010 17:50:37 +0000 (17:50 +0000)]
2010-11-16  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Chromium build fix.

        * WebKit.gyp:
        * scripts/concatenate_css_files.py: Renamed from WebKit/chromium/Build/concatenate_css_files.py.
        * scripts/concatenate_js_files.py: Renamed from WebKit/chromium/Build/concatenate_js_files.py.
        * scripts/generate_devtools_html.py: Renamed from WebKit/chromium/Build/generate_devtools_html.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOnly trigger Windows builds when files that we actually use on Windows are changed
aroben@apple.com [Tue, 16 Nov 2010 17:41:25 +0000 (17:41 +0000)]
Only trigger Windows builds when files that we actually use on Windows are changed

A new Scheduler subclass, PlatformSpecificScheduler, has been added.
It uses the new webkitpy.common.config.build module to determine
whether a particular change should trigger a build on a particular
platform. The Windows builders have been switched to use a
PlatformSpecificScheduler.

The logic to determine whether or not a particular change should
trigger a build on a given platform has only been implemented/tested
for Windows. I tried to make it easy to add more platforms in the
future, but I don't have enough familiarity with all platforms to be
able to implement it for them.

Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
lots irrelevant changes (e.g., rebaselining Chromium test results)

Reviewed by Eric Seidel.

* BuildSlaveSupport/build.webkit.org-config/config.json: Use a
PlatformSpecificScheduler for the Windows builders.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
up a ChangeFilter that filters to our branch and will call through to
our filter method, and calls up to our base class.
(PlatformSpecificScheduler.filter): Calls through to
build.should_build to find out whether we should trigger a build for
this change.

* Scripts/webkitpy/common/net/build.py: Added.
(_should_file_trigger_build): Uses a set of directories and regexp
patterns to determine whether the given file should trigger a build on
the given platform. As mentioned earlier, this has only been
implemented for Windows, though I did try to make some guesses about
other platforms.
(should_build): Returns true if any of the files should trigger a
build on the given platform.

* Scripts/webkitpy/common/net/build_unittest.py: Added.
(ShouldBuildTest.test_should_build): Does some basic testing to make
sure we're triggering builds for the right files. It only tests
Windows for now, though I tried to make some guesses about other
platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 16 Nov 2010 17:32:41 +0000 (17:32 +0000)]
2010-11-16  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Touching inspector controller to make gtk / qt happier.

        * inspector/InspectorController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Carlos Garcia Campos <cgarcia@igalia.com>
commit-queue@webkit.org [Tue, 16 Nov 2010 17:31:30 +0000 (17:31 +0000)]
2010-11-16  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Show default context menu for the currently focused element when activated with keyboard
        https://bugs.webkit.org/show_bug.cgi?id=49376

        * webkit/webkitwebview.cpp:
        (webkit_web_view_popup_menu_handler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 16 Nov 2010 17:19:45 +0000 (17:19 +0000)]
2010-11-16  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        A couple of SVG tests don't time out on the Mac.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 16 Nov 2010 17:16:44 +0000 (17:16 +0000)]
2010-11-16  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed baseline update.

        Add pixel baselines for fast/images/gray-scale-png-with-color-profile.html,
        originally added by r71461.

        * platform/chromium-mac/fast/images/gray-scale-png-with-color-profile-expected.checksum: Added.
        * platform/chromium-mac/fast/images/gray-scale-png-with-color-profile-expected.png: Added.
        * platform/chromium-win/fast/images/gray-scale-png-with-color-profile-expected.checksum: Added.
        * platform/chromium-win/fast/images/gray-scale-png-with-color-profile-expected.png: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/images/gray-scale-png-with-color-profile-expected.checksum: Added.
        * platform/mac/fast/images/gray-scale-png-with-color-profile-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Carlos Garcia Campos <cgarcia@igalia.com>
commit-queue@webkit.org [Tue, 16 Nov 2010 17:14:42 +0000 (17:14 +0000)]
2010-11-16  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Use gdk_pixbuf_get_from_surface() when available
        https://bugs.webkit.org/show_bug.cgi?id=49532

        * platform/graphics/gtk/GdkCairoUtilities.cpp:
        (cairoImageSurfaceToGdkPixbuf):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Tue, 16 Nov 2010 17:13:14 +0000 (17:13 +0000)]
2010-11-16  Marcus Bulach  <bulach@chromium.org>

        Not reviewed, chromium test expectation and baselines update.

        Re-adds a couple of tests_expectations wrongly excluded by r72099
        https://bugs.webkit.org/show_bug.cgi?id=49599

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 16 Nov 2010 17:06:59 +0000 (17:06 +0000)]
2010-11-16  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        Remove expectations for tests that now pass:
        - r71993 made svg/W3C-SVG-1.1/fonts-desc-02-t.svg passes again (with the
          current baselines)
        - fast/forms/search-styled.html and
          fast/forms/search-placeholder-value-changed.html were rebaselined by
          r72073

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 16 Nov 2010 16:44:21 +0000 (16:44 +0000)]
2010-11-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Chrome DevTools: concatenate CSS files, do not link
        missing JS files in release mode.
        https://bugs.webkit.org/show_bug.cgi?id=49586

        * Build/concatenate_css_files.py: Added.
        * Build/concatenate_js_files.py: Added.
        * Build/generate_devtools_html.py: Added.
        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 16 Nov 2010 16:42:51 +0000 (16:42 +0000)]
2010-11-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: init front-end UI upon DOMContentLoaded, not load event.
        https://bugs.webkit.org/show_bug.cgi?id=49596

        * inspector/front-end/inspector.js:
        (windowLoaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Remove synchronous QWebPage::checkPermissions signal
hausmann@webkit.org [Tue, 16 Nov 2010 16:28:14 +0000 (16:28 +0000)]
[Qt] Remove synchronous QWebPage::checkPermissions signal
https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Andreas Kling.

WebKit/qt:

As decided in the API review, we remove this signal and replace its only use currently
with cached credentials.

* Api/qwebpage.cpp:
(QWebPage::setUserPermission): Pass the WebCore frame instead of the QWebFrame.
* Api/qwebpage.h:
* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::checkPermission): Replaced explicit
signal emission with hash lookup of previously granted permission (or not).
(WebCore::NotificationPresenterClientQt::cancelRequestsForPermission): Remove
any previously cached/granted permission for the given script execution context.
(WebCore::NotificationPresenterClientQt::allowNotificationForFrame): Do not
only serve pending permission requests but before calling the JS callbacks, remember
the permission for subsequent synchronous checkPermission() calls.
* WebCoreSupport/NotificationPresenterClientQt.h: Add cache for permissions.

WebKitTools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::grantDesktopNotificationPermission): When granting
permission, grant it directly on the QWebPage/Frame, that will remember it.
* QtTestBrowser/webpage.cpp:
(WebPage::WebPage):
* QtTestBrowser/webpage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Kenneth Rohde Christiansen <kenneth@webkit.org>, Zalan Bujtas <zbujtas...
andreas.kling@nokia.com [Tue, 16 Nov 2010 16:14:22 +0000 (16:14 +0000)]
2010-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>, Zalan Bujtas  <zbujtas@gmail.com>

        Reviewed by Andreas Kling.

        [WK2][Qt] Add API for finding a zoomable area for a given point

        This is useful for implementing e.g "double tap zoom"

        Only enabled for Qt.

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::findZoomableAreaForPoint):
        (QWKPagePrivate::didFindZoomableArea):
        * UIProcess/API/qt/qwkpage.h:
        * UIProcess/API/qt/qwkpage_p.h:
        * UIProcess/PageClient.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didFindZoomableArea):
        (WebKit::WebPageProxy::findZoomableAreaForPoint):
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPageProxy.messages.in:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::findZoomableAreaForPoint):
        * WebProcess/WebPage/WebPage.h:
        * WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Tue, 16 Nov 2010 16:03:37 +0000 (16:03 +0000)]
2010-11-16  Marcus Bulach  <bulach@chromium.org>

        Not reviewed, chromium test expectation and baselines update.

        Update chromium baselines following r72092
        https://bugs.webkit.org/show_bug.cgi?id=49595

        * platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.txt: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.txt: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Andras Becsi <abecsi@inf.u-szeged.hu>
abecsi@webkit.org [Tue, 16 Nov 2010 15:52:25 +0000 (15:52 +0000)]
2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>

        Reviewed by Csaba Osztrogonác.

        [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
        Add previously removed expected file, png and checksum.

        * platform/qt/Skipped:
        * platform/qt/printing/page-rule-in-media-query-expected.checksum: Added.
        * platform/qt/printing/page-rule-in-media-query-expected.png: Added.
        * platform/qt/printing/page-rule-in-media-query-expected.txt: Added.
2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>

        Reviewed by Csaba Osztrogonác.

        [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::reset):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        (LayoutTestController::isPrinting):
        (LayoutTestController::setPrinting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Leandro Pereira <leandro@profusion.mobi>
leandro@webkit.org [Tue, 16 Nov 2010 15:45:46 +0000 (15:45 +0000)]
2010-11-16  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Unreviewed. Build fix.

        * WebCoreSupport/FrameLoaderClientEfl.h: Also include
        ResourceError.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-15 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Tue, 16 Nov 2010 15:25:39 +0000 (15:25 +0000)]
2010-11-15  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Migrate frontend to the new CSS editing/retrieval API
        https://bugs.webkit.org/show_bug.cgi?id=49492

        Test: inspector/styles-new-API.html

        WebCore:
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.routine):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedImages):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel.prototype.getStylesAsync):
        (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
        (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync):
        (WebInspector.CSSStyleModel.prototype.setRuleSelector):
        (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
        (WebInspector.CSSStyleModel.prototype.addRule):
        (WebInspector.CSSStyleModel.prototype.addRule.callback):
        (WebInspector.CSSStyleDeclaration):
        (WebInspector.CSSStyleDeclaration.prototype.propertyAt):
        (WebInspector.CSSStyleDeclaration.prototype.pastLastSourcePropertyIndex):
        (WebInspector.CSSStyleDeclaration.prototype.newBlankProperty):
        (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
        (WebInspector.CSSStyleDeclaration.prototype.appendProperty):
        (WebInspector.CSSRule):
        (WebInspector.CSSProperty.prototype.get propertyText):
        (WebInspector.CSSProperty.prototype.setText):
        (WebInspector.CSSProperty.prototype.setDisabled):
        (WebInspector.CSSStyleSheet):
        (WebInspector.CSSStyleSheet.createForId):
        (WebInspector.CSSStyleSheet.prototype.getText):
        (WebInspector.CSSStyleSheet.prototype.setText):
        * inspector/front-end/Settings.js:
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertiesSection.prototype.onpopulate):
        (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
        (WebInspector.StylePropertiesSection.prototype._debugShowStyle.removeStyleBox):
        (WebInspector.StylePropertiesSection.prototype._debugShowStyle):
        (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
        (WebInspector.StylePropertyTreeElement.prototype):
        (WebInspector.StylePropertyTreeElement.prototype.):
        * inspector/front-end/inspector.css:
        (.styles-section .properties li.not-parsed-ok):
        (.styles-section .properties li.not-parsed-ok::before):
        (.styles-section .properties .inactive):

        LayoutTests:
        * inspector/audits-panel-functional-expected.txt:
        * inspector/elements-panel-styles-expected.txt:
        * inspector/resources/styles-new-API.css: Added.
        (html):
        (body):
        (/* comment before selector */body.main1/* comment after selector */):
        (body.main2):
        (body::after):
        (h1):
        * inspector/styles-new-API-expected.txt: Added.
        * inspector/styles-new-API.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Sheriff Bot <webkit.review.bot@gmail.com>
apavlov@chromium.org [Tue, 16 Nov 2010 14:40:01 +0000 (14:40 +0000)]
2010-11-16  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72082.
        http://trac.webkit.org/changeset/72082
        https://bugs.webkit.org/show_bug.cgi?id=49594

        "broken SnowLeopard build" (Requested by apavlov on #webkit).

        * fast/css/CSSPrimitiveValue-exceptions-expected.txt:
        * fast/css/getFloatValueForUnit-expected.txt: Removed.
        * fast/css/getFloatValueForUnit.html:
        * fast/css/resources/CSSPrimitiveValue-exceptions.js:
        * platform/chromium-linux/fast/css/getFloatValueForUnit-expected.checksum: Added.
        * platform/chromium-linux/fast/css/getFloatValueForUnit-expected.png: Added.
        * platform/chromium-win/fast/css/getFloatValueForUnit-expected.checksum: Added.
        * platform/chromium-win/fast/css/getFloatValueForUnit-expected.png: Added.
        * platform/chromium-win/fast/css/getFloatValueForUnit-expected.txt: Added.
        * platform/mac-leopard/fast/css/getFloatValueForUnit-expected.checksum: Added.
        * platform/mac-leopard/fast/css/getFloatValueForUnit-expected.png: Added.
        * platform/mac/fast/css/getFloatValueForUnit-expected.checksum: Added.
        * platform/mac/fast/css/getFloatValueForUnit-expected.png: Added.
        * platform/mac/fast/css/getFloatValueForUnit-expected.txt: Added.
        * platform/qt/fast/css/getFloatValueForUnit-expected.txt: Added.
2010-11-16  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72082.
        http://trac.webkit.org/changeset/72082
        https://bugs.webkit.org/show_bug.cgi?id=49594

        "broken SnowLeopard build" (Requested by apavlov on #webkit).

        * css/CSSPrimitiveValue.cpp:
        (WebCore::scaleFactorForConversion):
        (WebCore::CSSPrimitiveValue::getDoubleValue):
        (WebCore::CSSPrimitiveValue::getIdent):
        * css/CSSPrimitiveValue.h:
        (WebCore::CSSPrimitiveValue::getFloatValue):
        (WebCore::CSSPrimitiveValue::getIntValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Sheriff Bot <webkit.review.bot@gmail.com>
apavlov@chromium.org [Tue, 16 Nov 2010 14:23:56 +0000 (14:23 +0000)]
2010-11-16  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72087.
        http://trac.webkit.org/changeset/72087
        https://bugs.webkit.org/show_bug.cgi?id=49593

        "broken build" (Requested by apavlov on #webkit).

        * css/CSSPrimitiveValue.cpp:
        (WebCore::unitCategory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 16 Nov 2010 14:23:39 +0000 (14:23 +0000)]
2010-11-16  Andreas Kling  <kling@webkit.org>

        Rubber-stamped by Simon Hausmann.

        Revert !ENABLE(INSPECTOR) fix- we don't need it right now,
        and it was less maintainable than I had though.

        * Shared/API/c/WKSharedAPICast.h:
        (WebKit::toAPI):
        (WebKit::toImpl):
        * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
        * WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
        * WebProcess/WebPage/WebInspector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 16 Nov 2010 14:14:09 +0000 (14:14 +0000)]
2010-11-16  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        Add missing pixel test results that Rob forgot to add.

        * platform/mac/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 16 Nov 2010 13:44:43 +0000 (13:44 +0000)]
2010-11-16  Andreas Kling  <kling@webkit.org>

        Reviewed by Simon Hausmann.

        Fix compilation with !ENABLE(INSPECTOR)

        * Shared/API/c/WKSharedAPICast.h:
        (WebKit::toAPI):
        (WebKit::toImpl):
        * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
        * WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
        * WebProcess/WebPage/WebInspector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 16 Nov 2010 13:42:51 +0000 (13:42 +0000)]
2010-11-15  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: rename StoragePanel to ResourcesPanel.
        https://bugs.webkit.org/show_bug.cgi?id=49534

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/DatabaseQueryView.js:
        (WebInspector.DatabaseQueryView.prototype._queryFinished):
        * inspector/front-end/DatabaseTableView.js:
        (WebInspector.DatabaseTableView.prototype._queryFinished):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
        * inspector/front-end/Images/storageIcon.png: Removed.
        * inspector/front-end/ResourceManager.js:
        (WebInspector.ResourceManager.prototype.setOverrideContent):
        (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame):
        (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
        (WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent):
        (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
        (WebInspector.ResourceTreeModel.prototype.addResourceToFrame):
        * inspector/front-end/StoragePanel.js: Removed.
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        (.resources.panel .sidebar):
        (.resources.panel .sidebar li):
        (.resources.panel .sidebar li.parent):
        (.resources.panel .sidebar li.selected):
        (.resources.panel .sidebar li.selected .selection):
        (.resources.panel .sidebar :focus li.selected .selection):
        (body.inactive .resources.panel .sidebar li.selected .selection):
        (.resources.panel .sidebar .icon):
        (.resources.panel .base-storage-tree-element-title):
        (.resources.panel .status):
        (.resources.panel li .status .bubble):
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector._createPanels):
        (WebInspector.openResource):
        (WebInspector.showPanel):
        (WebInspector.selectDatabase):
        (WebInspector.selectDOMStorage):
        (WebInspector.addDatabase):
        (WebInspector.addDOMStorage):
        (WebInspector.updateDOMStorage):
        (WebInspector.updateApplicationCacheStatus):
        (WebInspector.didGetFileSystemPath):
        (WebInspector.didGetFileSystemError):
        (WebInspector.didGetFileSystemDisabled):
        (WebInspector.updateNetworkState):
        (WebInspector._choosePanelToShowSourceLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Tue, 16 Nov 2010 13:23:35 +0000 (13:23 +0000)]
2010-11-16  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Andreas Kling.

        [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
        https://bugs.webkit.org/show_bug.cgi?id=49587

        * MiniBrowser/qt/BrowserView.cpp:
        (BrowserView::BrowserView): Added BackingStoreType
        argument to ctor. Propagating it to the QGraphicsWKView.
        * MiniBrowser/qt/BrowserView.h:
        * MiniBrowser/qt/BrowserWindow.cpp:
        (BrowserWindow::BrowserWindow):
        (BrowserWindow::newWindow): Create the new BrowserWindow
        with the same BackingStoreType that this instance has.
        * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
        * MiniBrowser/qt/main.cpp:
        (main): Use tiled backing store if got -tiled command line argument.
        Avoid redundant copy of command line args.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Tue, 16 Nov 2010 13:10:31 +0000 (13:10 +0000)]
2010-11-16  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Use SIGINT instead of SIGKILL to let the web process clean up after itself.

        * UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
        (WebKit::QtWebProcess::setupChildProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Tue, 16 Nov 2010 13:06:28 +0000 (13:06 +0000)]
2010-11-16  Alexander Pavlov  <apavlov@chromium.org>

        Unreviewed SnowLeopard build fix.

        * css/CSSPrimitiveValue.cpp:
        (WebCore::unitCategory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Kenneth Rohde Christiansen <kenneth@webkit.org>
andreas.kling@nokia.com [Tue, 16 Nov 2010 12:55:02 +0000 (12:55 +0000)]
2010-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        [WK2][Qt] Expose resizes-to-contents mode in WebKit2

        Only available with ENABLE(TILED_BACKING_STORE)

        Based on a patch by Antti Koivisto.

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::setResizesToContentsUsingLayoutSize):
        * UIProcess/API/qt/qwkpage.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::setResizesToContentsUsingLayoutSize):
        * UIProcess/WebPageProxy.h:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::contentsSizeChanged):
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::setSize):
        (WebKit::WebPage::setResizesToContentsUsingLayoutSize):
        (WebKit::WebPage::resizeToContentsIfNeeded):
        * WebProcess/WebPage/WebPage.h:
        (WebKit::WebPage::resizesToContentsEnabled):
        (WebKit::WebPage::resizesToContentsLayoutSize):
        * WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 16 Nov 2010 12:46:07 +0000 (12:46 +0000)]
2010-11-16  Andreas Kling  <kling@webkit.org>

        Unreviewed typo fix for previous commit.

        * common.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Kenneth Rohde Christiansen <kenneth@webkit.org>
andreas.kling@nokia.com [Tue, 16 Nov 2010 12:26:27 +0000 (12:26 +0000)]
2010-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        Viewport meta tag: Fix geometry computation

        Available width and height should also be divided by the device pixel ratio.

        * dom/ViewportArguments.cpp:
        (WebCore::computeViewportAttributes):
        * platform/network/qt/DnsPrefetchHelper.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Tue, 16 Nov 2010 12:22:56 +0000 (12:22 +0000)]
Unreviewed.

[Qt] Add printing/page-rule-in-media-query.html to the skipped
list because of missing layoutTestController.setPrinting().

And remove incorrect Qt specific expected result.

* platform/qt/Skipped: printing/page-rule-in-media-query.html added until fix.
* platform/qt/printing: Removed.
* platform/qt/printing/page-rule-in-media-query-expected.checksum: Removed.
* platform/qt/printing/page-rule-in-media-query-expected.png: Removed.
* platform/qt/printing/page-rule-in-media-query-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-12 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Tue, 16 Nov 2010 12:12:00 +0000 (12:12 +0000)]
2010-11-12  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Simon Fraser.

        CSSPrimitiveValue.getFloatValue does not convert sizes

        Extended getFloatValueForUnit and CSSPrimitiveValue tests. The former has been made text-only,
        which allowed to get rid of a number of unnecessary baselines.
        https://bugs.webkit.org/show_bug.cgi?id=35770

        * fast/css/CSSPrimitiveValue-exceptions-expected.txt:
        * fast/css/getFloatValueForUnit-expected.txt: Added.
        * fast/css/getFloatValueForUnit.html:
        * fast/css/resources/CSSPrimitiveValue-exceptions.js:
        * platform/chromium-linux/fast/css/getFloatValueForUnit-expected.checksum: Removed.
        * platform/chromium-linux/fast/css/getFloatValueForUnit-expected.png: Removed.
        * platform/chromium-win/fast/css/getFloatValueForUnit-expected.checksum: Removed.
        * platform/chromium-win/fast/css/getFloatValueForUnit-expected.png: Removed.
        * platform/chromium-win/fast/css/getFloatValueForUnit-expected.txt: Removed.
        * platform/mac-leopard/fast/css/getFloatValueForUnit-expected.checksum: Removed.
        * platform/mac-leopard/fast/css/getFloatValueForUnit-expected.png: Removed.
        * platform/mac/fast/css/getFloatValueForUnit-expected.checksum: Removed.
        * platform/mac/fast/css/getFloatValueForUnit-expected.png: Removed.
        * platform/mac/fast/css/getFloatValueForUnit-expected.txt: Removed.
        * platform/qt/fast/css/getFloatValueForUnit-expected.txt: Removed.
2010-11-12  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Simon Fraser.

        CSSPrimitiveValue.getFloatValue does not convert sizes
        https://bugs.webkit.org/show_bug.cgi?id=35770

        Implemented all same-category unit conversions (length, angle, time, frequency) and retained
        absolute-relative (cm, mm, in, pt, pc) length conversions intact.
        Illegal unit conversion attempts will throw an INVALID_ACCESS_ERR DOMException.

        * css/CSSPrimitiveValue.cpp:
        (WebCore::unitCategory):
        (WebCore::scaleFactorForConversion):
        (WebCore::CSSPrimitiveValue::getDoubleValue):
        (WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
        (WebCore::CSSPrimitiveValue::getDoubleValueInternal):
        * css/CSSPrimitiveValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 16 Nov 2010 12:11:08 +0000 (12:11 +0000)]
2010-11-16  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][Scratchbox] Use gold linker explicitly when available

        gold is faster at linking QtWebKit than binutils ld, but it cannot be
        enabled by default on a system that compiles other Qt projects.
        This is due to gold not supporting the --add-needed flag.

        Original patch by Kimmo Kinnunen.

        * common.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 16 Nov 2010 12:06:18 +0000 (12:06 +0000)]
2010-11-16  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Get proxy settings from environment (http[s]_proxy)

        If http_proxy and/or https_proxy are set in the environment,
        pass those in to QNetworkAccessManager.

        * WebProcess/qt/WebProcessMainQt.cpp:
        (WebKit::EnvHttpProxyFactory::EnvHttpProxyFactory):
        (WebKit::EnvHttpProxyFactory::initializeFromEnvironment):
        (WebKit::EnvHttpProxyFactory::queryProxy):
        (WebKit::initializeProxy):
        (WebKit::WebProcessMainQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 16 Nov 2010 11:56:18 +0000 (11:56 +0000)]
2010-11-16  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Add 'valgrind' build mode

        Passing CONFIG+=valgrind to qmake will now build WebKit in a way
        suitable for debugging with Valgrind.

        Original patch by Christian Sejersen.

        * WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 16 Nov 2010 11:53:48 +0000 (11:53 +0000)]
2010-11-16  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Emit windowCloseRequested signal on window.close()

        Original patch by Zalan Bujtas.

        * UIProcess/API/qt/ClientImpl.cpp:
        (qt_wk_close):
        * UIProcess/API/qt/qwkpage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-15 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 16 Nov 2010 11:50:02 +0000 (11:50 +0000)]
2010-11-15  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Kill the web process if the UI process dies

        Connect UI (parent) process death signal to SIGKILL of the web
        process (child). This ensures that there's no stale web processes
        after the UI process has crashed.

        Original patch by Kimmo Kinnunen.

        * UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
        (WebKit::QtWebProcess::QtWebProcess):
        (WebKit::QtWebProcess::setupChildProcess):
        (WebKit::ProcessLauncherHelper::launch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Tue, 16 Nov 2010 11:45:57 +0000 (11:45 +0000)]
2010-11-16  Marcus Bulach  <bulach@chromium.org>

        Not reviewed, chromium test expectation update.

        Update chromium baselines following r72063
        https://bugs.webkit.org/show_bug.cgi?id=49591

        * platform/chromium-mac/fast/js/function-prototype-descriptor-expected.txt: Added.
        * platform/chromium-win/fast/js/function-prototype-descriptor-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-16 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Tue, 16 Nov 2010 11:34:36 +0000 (11:34 +0000)]
2010-11-16  Marcus Bulach  <bulach@chromium.org>

        Not reviewed, chromium test expectation update.

        Update chromium baselines following r72050
        https://bugs.webkit.org/show_bug.cgi?id=49590

        * platform/chromium-mac/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt:
        * platform/chromium-mac/fast/js/exception-thrown-from-new-expected.txt:
        * platform/chromium-win/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt:
        * platform/chromium-win/fast/js/exception-thrown-from-new-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72075 268f45cc-cd09-0410-ab3c-d52691b4dbfc