jianli@chromium.org [Fri, 29 May 2009 21:58:50 +0000 (21:58 +0000)]
WebCore:
2009-05-29 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26069
Fix a crash in custom V8 bindings code for XMLHttpRequest.
Test: fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-29 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26069
Test for the above bug.
* fast/xmlhttprequest/resources/xmlhttprequest-open-after-iframe-onload-remove-self-child.html: Added.
* fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self-expected.txt: Added.
* fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Fri, 29 May 2009 21:38:07 +0000 (21:38 +0000)]
2009-05-29 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Bug 26074: SQLTransaction::executeSQL does an unnecessary call to String::copy.
https://bugs.webkit.org/show_bug.cgi?id=26074
The constructor for SQLStatement already does a copy for this string.
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::executeSQL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44274
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 29 May 2009 20:53:50 +0000 (20:53 +0000)]
Implement WebFrame::startDownload
Fixes the WebKit side of Bug 25729: Alt-clicking a link doesn't start
a download <https://bugs.webkit.org/show_bug.cgi?id=25729>. Fixing
this all the way will require a change in Safari.
Reviewed by Darin Adler.
* WebFrame.cpp:
(WebFrame::startDownload): Call through to WebView::downloadURL.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 29 May 2009 20:51:06 +0000 (20:51 +0000)]
2009-05-29 Darin Adler <darin@apple.com>
Fix build; the new Cairo code compiled on Windows only.
* platform/graphics/gtk/FontPlatformData.h: Added syntheticBold
and syntheticOblique functions as in the Windows version to make it
easier to use this cross-platform. Later we can make data members
private as in the Windows version.
* platform/graphics/mac/FontPlatformData.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 29 May 2009 20:48:53 +0000 (20:48 +0000)]
Move WebContextMenuClient's downloading code to WebView
This will allow other code to trigger downloads using this code, and
matches Mac.
Reviewed by Darin Adler.
* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::downloadURL): Moved code from here...
* WebView.cpp:
(WebView::downloadURL): ...to here. Also tightened up the code a
little bit and removed an unnecessary LOG_ERROR.
* WebView.h: Added downloadURL.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44271
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 29 May 2009 20:41:08 +0000 (20:41 +0000)]
Roll out r44269
It contained some changes I didn't mean to have landed, and squashed
some distinct patches into a single commit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44270
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Fri, 29 May 2009 20:33:46 +0000 (20:33 +0000)]
WebCore:
2009-05-29 Adam Roben <aroben@apple.com>
Make sure PlatformMouseEvent::modifierFlags contains MK_ALT when the
Alt key is pressed
First part of fixing Bug 25729: Alt-clicking a link doesn't start a
download
<https://bugs.webkit.org/show_bug.cgi?id=25729>
Reviewed by Darin Adler.
No test possible.
* platform/win/PlatformMouseEventWin.cpp:
(WebCore::PlatformMouseEvent::PlatformMouseEvent): Add MK_ALT to the
modifier flags when the Alt key is pressed.
WebKit/win:
2009-05-29 Adam Roben <aroben@apple.com>
Implement WebFrame::startDownload
Fixes Bug 25729: Alt-clicking a link doesn't start a download
<https://bugs.webkit.org/show_bug.cgi?id=25729>
Reviewed by Darin Adler.
* WebFrame.cpp:
(WebFrame::startDownload): Call through to WebView::downloadURL.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Fri, 29 May 2009 19:53:41 +0000 (19:53 +0000)]
2009-05-29 Alexander Macdonald <alexmac@adobe.com>
Reviewed by Darin Adler.
Added support for synthetic bold/oblique font rendering
on platforms that use cairo.
* platform/graphics/SimpleFontData.h:
* platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/gtk/SimpleFontDataGtk.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/gtk/SimpleFontDataPango.cpp:
(WebCore::SimpleFontData::platformInit):
* platform/graphics/win/SimpleFontDataCairoWin.cpp:
(WebCore::SimpleFontData::platformInit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44268
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Fri, 29 May 2009 18:49:25 +0000 (18:49 +0000)]
2009-05-29 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Darin Adler.
Correct Windows Cairo build error caused by @r42767.
http://bugs.webkit.org/show_bug.cgi?id=26082.
* WebError.cpp:
(WebError::localizedDescription):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Fri, 29 May 2009 18:32:41 +0000 (18:32 +0000)]
Bug 26024: AX: possible to fail assertion because AXPostNotification calls accessibilityIsIgnored
https://bugs.webkit.org/show_bug.cgi?id=26024
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Fri, 29 May 2009 16:55:13 +0000 (16:55 +0000)]
2009-05-29 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Build fix for Windows Cairo target.
https://bugs.webkit.org/show_bug.cgi?id=25972
Compiler mistakenly selects SMILTime min/max instead of STL version,
resulting in a build error. This change makes the meaning of the
min/max explicit and avoids the problem.
* html/TimeRanges.h:
(WebCore::TimeRanges::Range::unionWithOverlappingOrContiguousRange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44265
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Fri, 29 May 2009 15:56:32 +0000 (15:56 +0000)]
2009-05-29 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=26075
[GTK] Refactor key scrolling code
After the scrolling changes in r44177 we can now use the
FrameView::scroll method like the other ports, keeping the magic
constants for the scrolling amounts inside WebCore proper.
* webkit/webkitwebview.cpp:
(webkit_web_view_real_move_cursor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Fri, 29 May 2009 14:48:33 +0000 (14:48 +0000)]
2009-05-29 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Jan Alonzo.
Add a test-case for our HTTP backend, currently checking the
ref-counting of the SoupMessage.
* GNUmakefile.am:
WebCore:
2009-05-29 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Jan Alonzo.
Make SoupMessage a member of ResourceRequest, instead of creating
it in startHttp. Implement updating of ResourceRequest from
SoupMessage, and vice versa.
* GNUmakefile.am:
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::~ResourceHandle):
(WebCore::gotHeadersCallback):
(WebCore::ResourceHandle::startHttp):
* platform/network/soup/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::~ResourceRequest):
* platform/network/soup/ResourceRequestSoup.cpp: Added.
(WTF::SoupURI):
(WebCore::ResourceRequest::soupMessage):
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
WebKit/gtk:
2009-05-29 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Jan Alonzo.
Make NetworkRequest carry a reference of the SoupMessage used by
ResourceRequest, and use that to create new ResourceRequests where
needed, so that no information is lost while passing around
NetworkRequest objects.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebKit::FrameLoaderClient::startDownload):
* webkit/webkitdownload.cpp:
(webkit_download_start):
* webkit/webkitnetworkrequest.cpp:
(webkit_network_request_finalize):
(webkit_network_request_new_with_core_request):
(webkit_network_request_new):
(webkit_network_request_get_message):
* webkit/webkitprivate.h:
* webkit/webkitwebframe.cpp:
(webkit_web_frame_load_request):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 29 May 2009 11:10:42 +0000 (11:10 +0000)]
Fix error in test case i accidentally introduced.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Thu, 28 May 2009 23:44:31 +0000 (23:44 +0000)]
2009-05-28 Dmitry Titov <dimich@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26068
V8: Remove the remaining b8::Locker usage in worker code.
This completes the fix for https://bugs.webkit.org/show_bug.cgi?id=25944,
since the patches for enabling timers and that bug have "crossed in the queue".
Existing LayoutTests/fast/workers/worker-timeout.html covers this fix (will start work in Chromium).
* bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 28 May 2009 22:38:44 +0000 (22:38 +0000)]
Build fix. Move off a deprecated NSFileManager method.
Rubber-stamped by Dan Bernstein.
* Misc/WebNSFileManagerExtras.h:
* Misc/WebNSFileManagerExtras.m:
(-[NSFileManager destinationOfSymbolicLinkAtPath:error:]): Implement a new-in-Leopard method for Tiger to use.
(-[NSFileManager attributesOfItemAtPath:error:]): Ditto.
* Plugins/WebNetscapePluginPackage.mm:
(-[WebNetscapePluginPackage _initWithPath:]): Use the new non-deprecated methods.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 28 May 2009 22:18:01 +0000 (22:18 +0000)]
2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Simplify the Accept-Encoding header we are sending out, for it
seems some servers do not enjoy parsing the full, explicit
version.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::startHttp):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Thu, 28 May 2009 22:10:29 +0000 (22:10 +0000)]
2009-05-28 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Added a new build flag --filters. This replaces the old --svg-filters and enables
other parts of WebKit to use some basic filters of platform/graphics/filters if needed.
This patch also fixes a bug in dom/DOMImplementation.cpp where we used SVG_FILTER. This flag
doesn't exist and was replaced by FILTERS as well as all SVG_FILTERS occurrences.
Filters are not working yet. This patch is just a preperation. Filters are deactivated by
default.
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.pro:
* bindings/objc/DOM.mm:
(WebCore::createElementClassMap):
* dom/DOMImplementation.cpp:
(WebCore::isSVG10Feature):
(WebCore::isSVG11Feature):
* page/DOMWindow.idl:
* platform/graphics/filters/FEBlend.cpp:
* platform/graphics/filters/FEBlend.h:
* platform/graphics/filters/FEColorMatrix.cpp:
* platform/graphics/filters/FEColorMatrix.h:
* platform/graphics/filters/FEComponentTransfer.cpp:
* platform/graphics/filters/FEComponentTransfer.h:
* platform/graphics/filters/FEComposite.cpp:
* platform/graphics/filters/FEComposite.h:
* platform/graphics/filters/FilterEffect.cpp:
* platform/graphics/filters/FilterEffect.h:
* platform/graphics/filters/SourceAlpha.cpp:
* platform/graphics/filters/SourceAlpha.h:
* platform/graphics/filters/SourceGraphic.cpp:
* platform/graphics/filters/SourceGraphic.h:
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::selfWillPaint):
* rendering/RenderSVGModelObject.cpp:
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::selfWillPaint):
* rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent):
(WebCore::SVGRenderBase::finishRenderSVGContent):
(WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
* svg/Filter.cpp:
* svg/Filter.h:
* svg/FilterBuilder.cpp:
* svg/FilterBuilder.h:
* svg/SVGComponentTransferFunctionElement.cpp:
* svg/SVGComponentTransferFunctionElement.h:
* svg/SVGComponentTransferFunctionElement.idl:
* svg/SVGFEBlendElement.cpp:
* svg/SVGFEBlendElement.h:
* svg/SVGFEBlendElement.idl:
* svg/SVGFEColorMatrixElement.cpp:
* svg/SVGFEColorMatrixElement.h:
* svg/SVGFEColorMatrixElement.idl:
* svg/SVGFEComponentTransferElement.cpp:
* svg/SVGFEComponentTransferElement.h:
* svg/SVGFEComponentTransferElement.idl:
* svg/SVGFECompositeElement.cpp:
* svg/SVGFECompositeElement.h:
* svg/SVGFECompositeElement.idl:
* svg/SVGFEDiffuseLightingElement.cpp:
* svg/SVGFEDiffuseLightingElement.h:
* svg/SVGFEDiffuseLightingElement.idl:
* svg/SVGFEDisplacementMapElement.cpp:
* svg/SVGFEDisplacementMapElement.h:
* svg/SVGFEDisplacementMapElement.idl:
* svg/SVGFEDistantLightElement.cpp:
* svg/SVGFEDistantLightElement.h:
* svg/SVGFEDistantLightElement.idl:
* svg/SVGFEFloodElement.cpp:
* svg/SVGFEFloodElement.h:
* svg/SVGFEFloodElement.idl:
* svg/SVGFEFuncAElement.cpp:
* svg/SVGFEFuncAElement.h:
* svg/SVGFEFuncAElement.idl:
* svg/SVGFEFuncBElement.cpp:
* svg/SVGFEFuncBElement.h:
* svg/SVGFEFuncBElement.idl:
* svg/SVGFEFuncGElement.cpp:
* svg/SVGFEFuncGElement.h:
* svg/SVGFEFuncGElement.idl:
* svg/SVGFEFuncRElement.cpp:
* svg/SVGFEFuncRElement.h:
* svg/SVGFEFuncRElement.idl:
* svg/SVGFEGaussianBlurElement.cpp:
* svg/SVGFEGaussianBlurElement.h:
* svg/SVGFEGaussianBlurElement.idl:
* svg/SVGFEImageElement.cpp:
* svg/SVGFEImageElement.h:
* svg/SVGFEImageElement.idl:
* svg/SVGFELightElement.cpp:
* svg/SVGFELightElement.h:
* svg/SVGFEMergeElement.cpp:
* svg/SVGFEMergeElement.h:
* svg/SVGFEMergeElement.idl:
* svg/SVGFEMergeNodeElement.cpp:
* svg/SVGFEMergeNodeElement.h:
* svg/SVGFEMergeNodeElement.idl:
* svg/SVGFEOffsetElement.cpp:
* svg/SVGFEOffsetElement.h:
* svg/SVGFEOffsetElement.idl:
* svg/SVGFEPointLightElement.cpp:
* svg/SVGFEPointLightElement.h:
* svg/SVGFEPointLightElement.idl:
* svg/SVGFESpecularLightingElement.cpp:
* svg/SVGFESpecularLightingElement.h:
* svg/SVGFESpecularLightingElement.idl:
* svg/SVGFESpotLightElement.cpp:
* svg/SVGFESpotLightElement.h:
* svg/SVGFESpotLightElement.idl:
* svg/SVGFETileElement.cpp:
* svg/SVGFETileElement.h:
* svg/SVGFETileElement.idl:
* svg/SVGFETurbulenceElement.cpp:
* svg/SVGFETurbulenceElement.h:
* svg/SVGFETurbulenceElement.idl:
* svg/SVGFilterElement.cpp:
* svg/SVGFilterElement.h:
* svg/SVGFilterElement.idl:
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
* svg/SVGFilterPrimitiveStandardAttributes.h:
* svg/graphics/SVGResourceFilter.cpp:
* svg/graphics/SVGResourceFilter.h:
* svg/graphics/cairo/SVGResourceFilterCairo.cpp:
* svg/graphics/cg/SVGResourceFilterCg.cpp:
* svg/graphics/cg/SVGResourceFilterCg.mm:
* svg/graphics/filters/SVGDistantLightSource.h:
* svg/graphics/filters/SVGFEConvolveMatrix.cpp:
* svg/graphics/filters/SVGFEConvolveMatrix.h:
* svg/graphics/filters/SVGFEDiffuseLighting.cpp:
* svg/graphics/filters/SVGFEDiffuseLighting.h:
* svg/graphics/filters/SVGFEDisplacementMap.cpp:
* svg/graphics/filters/SVGFEDisplacementMap.h:
* svg/graphics/filters/SVGFEFlood.cpp:
* svg/graphics/filters/SVGFEFlood.h:
* svg/graphics/filters/SVGFEGaussianBlur.cpp:
* svg/graphics/filters/SVGFEGaussianBlur.h:
* svg/graphics/filters/SVGFEImage.cpp:
* svg/graphics/filters/SVGFEImage.h:
* svg/graphics/filters/SVGFEMerge.cpp:
* svg/graphics/filters/SVGFEMerge.h:
* svg/graphics/filters/SVGFEMorphology.cpp:
* svg/graphics/filters/SVGFEMorphology.h:
* svg/graphics/filters/SVGFEOffset.cpp:
* svg/graphics/filters/SVGFEOffset.h:
* svg/graphics/filters/SVGFESpecularLighting.cpp:
* svg/graphics/filters/SVGFESpecularLighting.h:
* svg/graphics/filters/SVGFETile.cpp:
* svg/graphics/filters/SVGFETile.h:
* svg/graphics/filters/SVGFETurbulence.cpp:
* svg/graphics/filters/SVGFETurbulence.h:
* svg/graphics/filters/SVGFilterEffect.cpp:
* svg/graphics/filters/SVGFilterEffect.h:
* svg/graphics/filters/SVGLightSource.cpp:
* svg/graphics/filters/SVGLightSource.h:
* svg/graphics/filters/SVGPointLightSource.h:
* svg/graphics/filters/SVGSpotLightSource.h:
* svg/graphics/filters/cg/SVGFEHelpersCg.h:
* svg/graphics/filters/cg/SVGFEHelpersCg.mm:
* svg/graphics/filters/cg/SVGFilterEffectCg.mm:
* svg/graphics/filters/cg/WKArithmeticFilter.h:
* svg/graphics/filters/cg/WKArithmeticFilter.m:
* svg/graphics/filters/cg/WKComponentMergeFilter.h:
* svg/graphics/filters/cg/WKComponentMergeFilter.m:
* svg/graphics/filters/cg/WKDiffuseLightingFilter.h:
* svg/graphics/filters/cg/WKDiffuseLightingFilter.m:
* svg/graphics/filters/cg/WKDiscreteTransferFilter.h:
* svg/graphics/filters/cg/WKDiscreteTransferFilter.m:
* svg/graphics/filters/cg/WKDisplacementMapFilter.h
* svg/graphics/filters/cg/WKDisplacementMapFilter.m:
* svg/graphics/filters/cg/WKDistantLightFilter.h:
* svg/graphics/filters/cg/WKDistantLightFilter.m:
* svg/graphics/filters/cg/WKGammaTransferFilter.h:
* svg/graphics/filters/cg/WKGammaTransferFilter.m:
* svg/graphics/filters/cg/WKIdentityTransferFilter.h:
* svg/graphics/filters/cg/WKIdentityTransferFilter.m:
* svg/graphics/filters/cg/WKLinearTransferFilter.h:
* svg/graphics/filters/cg/WKLinearTransferFilter.m:
* svg/graphics/filters/cg/WKNormalMapFilter.h:
* svg/graphics/filters/cg/WKNormalMapFilter.m:
* svg/graphics/filters/cg/WKPointLightFilter.h:
* svg/graphics/filters/cg/WKPointLightFilter.m:
* svg/graphics/filters/cg/WKSpecularLightingFilter.h:
* svg/graphics/filters/cg/WKSpecularLightingFilter.m:
* svg/graphics/filters/cg/WKSpotLightFilter.h:
* svg/graphics/filters/cg/WKSpotLightFilter.m:
* svg/graphics/filters/cg/WKTableTransferFilter.h:
* svg/graphics/filters/cg/WKTableTransferFilter.m:
* svg/graphics/mac/SVGResourceFilterPlatformDataMac.h:
* svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm:
* svg/graphics/qt/SVGResourceFilterQt.cpp:
* svg/graphics/skia/SVGResourceFilterSkia.cpp:
* svg/svgtags.in:
*WebKit/mac/
2009-05-28 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Added new build flag --filters. More details in WebCore/ChangeLog.
* Configurations/FeatureDefines.xcconfig:
*.
2009-05-28 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Enable the new build flag --filters for Gtk. More details in WebCore/ChangeLog.
* configure.ac:
*JavaScriptCore/
2009-05-28 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Added new build flag --filters for Mac. More details in WebCore/ChangeLog.
* Configurations/FeatureDefines.xcconfig:
*WebKitTools
2009-05-28 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Added new build flag --filters. More details in WebCore/ChangeLog.
* Scripts/build-webkit:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
brettw@chromium.org [Thu, 28 May 2009 21:05:51 +0000 (21:05 +0000)]
2009-05-28 Brett Wilson <brettw@chromium.org>
Unreviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=26067
Add casts for scale function to make more explicit what is happening
and fix a compiler warning.
* platform/graphics/IntSize.h:
(WebCore::IntSize::scale):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 28 May 2009 20:56:37 +0000 (20:56 +0000)]
Symlink WebKitPluginHost.app in to place if needed.
Rubber-stamped by Anders Carlsson.
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44251
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 28 May 2009 19:27:57 +0000 (19:27 +0000)]
2009-05-28 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Remove the returnValueSlot concept from JSDOMWindowBase. Now that windows
are not cleared on navigation it is no longer necessary.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
(WebCore::JSDOMWindowBase::willRemoveFromWindowShell):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::showModalDialog):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 28 May 2009 18:35:48 +0000 (18:35 +0000)]
2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=26048
navigation-policy-decision-requested documentation incomplete
Fix documentation for all policy decision request signals, to
mention that an actual decision is expected when you return TRUE,
meaning that you handled the signal.
* webkit/webkitwebview.cpp:
(webkit_web_view_class_init):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Thu, 28 May 2009 18:33:24 +0000 (18:33 +0000)]
2009-05-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Mention the implementation of the new AtkText methods.
* NEWS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44247
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Thu, 28 May 2009 18:20:01 +0000 (18:20 +0000)]
2009-05-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo and Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset
Add new test file for ATK.
* GNUmakefile.am:
WebCore:
2009-05-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo and Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset
Implement atk_text_get_text_{at,after,before}_offset.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
WebKit/gtk:
2009-05-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo and Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset
New test file for ATK functionality.
* tests/testatk.c: Added.
(bail_out):
(test_get_text_function):
(test_webkit_atk_get_text_at_offset):
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 28 May 2009 18:04:23 +0000 (18:04 +0000)]
Rubber-stamped by Darin Adler.
Remove unnecessary destructor from InputElementData/OptionElementData.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 28 May 2009 17:49:09 +0000 (17:49 +0000)]
Reviewed by Darin Adler.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=26062
Refactor code from all virtual methods in HTMLSelectElement (that are also needed for WMLSelectElement)
in the recently introduced SelectElement abstract base class. Follow the same design sheme that InputElement uses.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 28 May 2009 17:48:25 +0000 (17:48 +0000)]
2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Fix webkitgtk_cleanfiles to clean gtk-doc-related files in the
correct directory, so that we pass make distcheck.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 28 May 2009 17:46:22 +0000 (17:46 +0000)]
Don't try to use the new combobox parts on Vista in Classic mode
Fixes:
<rdar://problem/6929277> REGRESSION (r42289+r42350): Windows Classic
theme: drop down lists in Preferences get a line/square
<rdar://problem/6929298> REGRESSION (r42289): Windows Classic: drop
down lists are black with a circle on many sites
Reviewed by Steve Falkenburg.
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::paintMenuList): Only use the new combobox
parts when we have a theme (i.e., when we're not in Classic mode).
When we don't have a theme, fall back to the pre-r42289 code.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Thu, 28 May 2009 17:29:04 +0000 (17:29 +0000)]
2009-05-27 Peter Kasting <pkasting@google.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=25659
Avoid calling frameCount() unnecessarily (which could lead to extra
GIF decoding).
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyDecodedDataIfNecessary):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 28 May 2009 16:58:50 +0000 (16:58 +0000)]
2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Document changes worth noting for 1.1.8.
* NEWS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Thu, 28 May 2009 16:55:04 +0000 (16:55 +0000)]
WebCore:
2009-05-28 Simon Fraser <simon.fraser@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=8736
Tests: fast/borders/border-radius-constraints.html
fast/borders/border-radius-split-inline.html
When the sum of the corner radii on a side exceed the length of the side,
reduce the radii according to CSS 3 rules.
Add RenderStyle::getBorderRadiiForRect() to fetch corner radii, applying
the constraints. Use that for painting borders, box-shadow, clipping replaced
elements
* platform/graphics/IntSize.h:
(WebCore::IntSize::scale):
Add a scale method that scales by a float (using C rounding rules, like IntRect::scale()).
* platform/graphics/Path.cpp:
Make the QUARTER const static.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::pushContentsClip):
Use getBorderRadiiForRect to fetch border radii.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Use getBorderRadiiForRect to fetch border radii.
(WebCore::RenderBoxModelObject::paintBorder):
Use getBorderRadiiForRect to fetch border radii, and fix a bug when drawing
borders for split inlines, which used to apply the radii for each segment,
and no longer does.
(WebCore::RenderBoxModelObject::paintBoxShadow):
Use getBorderRadiiForRect to fetch border radii.
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
Use getBorderRadiiForRect to fetch border radii for clipping.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
Use getBorderRadiiForRect to fetch border radii for clipping.
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getBorderRadiiForRect):
New bottleneck method to fetch corner radiil given a rect, applying the constraint
rules.
LayoutTests:
2009-05-28 Simon Fraser <simon.fraser@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=8736
* fast/borders/border-radius-constraints.html: Added.
* platform/mac/fast/borders/border-radius-constraints-expected.checksum: Added.
* platform/mac/fast/borders/border-radius-constraints-expected.png: Added.
* platform/mac/fast/borders/border-radius-constraints-expected.txt: Added.
Test that corner radii are constrained according to CSS3 rules.
* fast/borders/border-radius-huge-assert.html:
* platform/mac/fast/borders/border-radius-huge-assert-expected.checksum:
* platform/mac/fast/borders/border-radius-huge-assert-expected.png:
* platform/mac/fast/borders/border-radius-huge-assert-expected.txt:
Now that we constrain border-radius, update the text of the test, and the
expected result.
* fast/borders/border-radius-split-inline.html: Added.
* platform/mac/fast/borders/border-radius-split-inline-expected.checksum: Added.
* platform/mac/fast/borders/border-radius-split-inline-expected.png: Added.
* platform/mac/fast/borders/border-radius-split-inline-expected.txt: Added.
New test for border-radius on a split inline.
* fast/box-shadow/border-radius-big.html:
* platform/mac/fast/box-shadow/border-radius-big-expected.checksum:
* platform/mac/fast/box-shadow/border-radius-big-expected.png:
* platform/mac/fast/box-shadow/border-radius-big-expected.txt:
Now that we constrain border-radius, update the text of the test, and the
expected result.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Thu, 28 May 2009 16:50:00 +0000 (16:50 +0000)]
2009-05-28 Olivier DOLE <odole@pleyo.com>
Reviewed by Maciej.
Add options to sunspider-compare-results to know which test suite to
compare (see bug #15941).
* Scripts/sunspider-compare-results:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Thu, 28 May 2009 16:23:32 +0000 (16:23 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26005
Optimization for XPath //* does not preserve context size
Test: fast/xpath/position.html
Fixed the bug by removing the incorrect optimization, and made enough micro-optimizations to
get a performance progression on my tests.
* xml/XPathPath.h: Removed broken optimizeStepPair().
* xml/XPathPath.cpp:
(WebCore::XPath::LocationPath::evaluate): Style fix.
(WebCore::XPath::LocationPath::appendStep): Don't call optimizeStepPair().
(WebCore::XPath::LocationPath::insertFirstStep): Ditto.
(WebCore::XPath::Path::Path): Style fix.
* xml/XPathStep.cpp:
(WebCore::XPath::primaryNodeType): Turned this member function into a static inline helper.
(WebCore::XPath::nodeMatches): Ditto. Don't check for namespace axis, which is unsupported
(and might never be).
(WebCore::XPath::Step::nodesInAxis): Updated for the new nodeMatches() signature.
* xml/XPathStep.h:
(WebCore::XPath::Step::NodeTest::data):
(WebCore::XPath::Step::NodeTest::namespaceURI):
Made these data members AtomicString to avoid repeated conversions. This is the biggest
performance win here.
* xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Reserve some capacity upfront.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 28 May 2009 16:20:20 +0000 (16:20 +0000)]
2009-05-28 Stephen White <senorblanco@chromium.org>
Reviewed by Dimitri Glazkov.
When creating a linear or radial gradient with a single stop
at offset 1.0, the Skia layer was allocating 3 stops, but only
filling 2, leaving one uninitialized. Only 2 stops are necessary
in this case, at offsets (0.0, 1.0).
http://bugs.webkit.org/show_bug.cgi?id=26063
Covered by: LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b.svg
LayoutTests/svg/custom/gradient-stop-corner-cases.svg
LayoutTests/svg/custom/js-late-gradient-and-object-creation.svg
* platform/graphics/skia/GradientSkia.cpp:
(WebCore::totalStopsNeeded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44231
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 28 May 2009 16:14:29 +0000 (16:14 +0000)]
2009-05-28 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=26041
Allow adding resource source to WebInspector.SourceFrame asynchronously.
Provide common implementation for InspectorController::addResourceSourceToFrame and
InspectorController::addSourceToFrame methods.
* bindings/js/JSInspectorControllerCustom.cpp:
* bindings/v8/custom/V8InspectorControllerCustom.cpp:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::addResourceSourceToFrame):
* inspector/InspectorController.h:
* inspector/InspectorController.idl:
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.revealLine):
(WebInspector.SourceFrame.prototype.highlightLine):
(WebInspector.SourceFrame.prototype._loaded):
(WebInspector.SourceFrame.prototype._isContentLoaded):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
(WebInspector.SourceView.prototype._contentLoaded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44230
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Thu, 28 May 2009 15:45:59 +0000 (15:45 +0000)]
2009-05-28 Xan Lopez <xlopez@igalia.com>
Bump version numbers in preparation for 1.1.8 release.
* configure.ac:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Thu, 28 May 2009 14:52:53 +0000 (14:52 +0000)]
2009-05-27 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=26039
[GTK] WebKitWebHistoryItem lifetime fixes
Modify the management of history items by the BackForward list.
Having the objects add themselves to a hash table with an extra
reference made impossible for the cleanup code in the dispose
method to be ever called in normal conditions, since dispose is
called before getting rid of the last reference, which the objects
were making to themselves. Get rid of this extra reference and
move the responsibility of the cleanup to the BackForward list
itself, which effectively owns the WebKitWebHistoryItems now.
Also, update the tests to reflect this change.
* tests/testwebbackforwardlist.c:
(test_webkit_web_history_item_lifetime):
(test_webkit_web_back_forward_list_order):
(test_webkit_web_back_forward_list_add_item):
* tests/testwebhistoryitem.c:
(web_history_item_fixture_setup):
(web_history_item_fixture_teardown):
* webkit/webkitprivate.h:
* webkit/webkitwebbackforwardlist.cpp:
(webkit_web_back_forward_list_dispose):
(webkit_web_back_forward_list_class_init):
* webkit/webkitwebhistoryitem.cpp:
(webkit_history_items):
(webkit_history_item_add):
(webkit_web_history_item_dispose):
(WebKit::kit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Thu, 28 May 2009 14:52:34 +0000 (14:52 +0000)]
2009-05-26 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=26039
[GTK] WebKitWebHistoryItem lifetime fixes
Delete the BackForwardList before the Page, otherwise the references
to the WebKitWebHistoryItems will be gone.
* webkit/webkitwebview.cpp:
(webkit_web_view_dispose):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Thu, 28 May 2009 12:04:07 +0000 (12:04 +0000)]
2009-05-28 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Xan Lopez.
After r44177 we had a problem when increasing the size
of the window the scrollbars stayed and were not hidden.
This was due WebCore giving up on the Scrollbar as it became
unnecessary but the GtkAdjustment remained unchanged.
So from the point of view of the GtkScrolledWindow scrolling
was still necessary and the GtkScrollbar kept being displayed.
Solve the issue by resetting the GtkAdjustment in the
destructor of ScrollbarGtk.
* platform/gtk/ScrollbarGtk.cpp:
(ScrollbarGtk::~ScrollbarGtk):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 28 May 2009 08:04:09 +0000 (08:04 +0000)]
WebCore:
2009-05-28 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Clean up window.open()'s use of lexical and dynamic scope.
(Added one unreviewed tweak: use dynamicFrame instead of lexicalFrame
for DOMWindow::allowPopUp.)
Test: http/tests/security/frameNavigation/context-for-window-open.html
* bindings/js/JSDOMBinding.cpp:
(WebCore::toDynamicFrame):
(WebCore::processingUserGesture):
(WebCore::completeURL):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::createWindow):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::showModalDialog):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
(WebCore::createWindow):
LayoutTests:
2009-05-28 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Test whether lexical or dynamic scope is used for window.open().
* http/tests/security/frameNavigation/context-for-window-open-expected.txt: Added.
* http/tests/security/frameNavigation/context-for-window-open.html: Added.
* http/tests/security/frameNavigation/resources/middle-frame-for-location.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 28 May 2009 07:31:23 +0000 (07:31 +0000)]
Revert 44221.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44224
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 28 May 2009 06:36:20 +0000 (06:36 +0000)]
Fix MIME type.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 28 May 2009 06:31:53 +0000 (06:31 +0000)]
Update build-webkit to handle a new version of WebKitSystemInterface.
Rubber-stamped by Dan Bernstein.
* Scripts/build-webkit:
Update WebKitSystemInterface.
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a: Added.
* libWebKitSystemInterfaceTiger.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 28 May 2009 06:25:02 +0000 (06:25 +0000)]
WebCore:
2009-05-27 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Clean up window.open()'s use of lexical and dynamic scope.
Test: http/tests/security/frameNavigation/context-for-window-open.html
* bindings/js/JSDOMBinding.cpp:
(WebCore::toDynamicFrame):
(WebCore::processingUserGesture):
(WebCore::completeURL):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::createWindow):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::showModalDialog):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
(WebCore::createWindow):
LayoutTests:
2009-05-27 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Test whether lexical or dynamic scope is used for window.open().
* http/tests/security/frameNavigation/context-for-window-open-expected.txt: Added.
* http/tests/security/frameNavigation/context-for-window-open.html: Added.
* http/tests/security/frameNavigation/resources/middle-frame-for-location.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44221
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Thu, 28 May 2009 06:02:24 +0000 (06:02 +0000)]
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=26056
XPath string() function can be very slow
* xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Use an intermediate Vector when appending.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44220
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Thu, 28 May 2009 05:30:46 +0000 (05:30 +0000)]
2009-05-27 Maciej Stachowiak <mjs@apple.com>
Not reviewed, demo content.
- Add doctype to Calendar demo.
* demos/calendar/Calendar.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44219
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 28 May 2009 05:25:53 +0000 (05:25 +0000)]
WebCore:
Reviewed by Sam Weinig.
- fix <rdar://problem/6927761> <isindex> placeholder text is unstylable
and initially not visible
Test: fast/forms/isindex-placeholder.html
* css/html4.css: Added a default style for <isindex> placeholder text.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMappedAttribute): Changed to call
the new protected function updatePlaceholderVisibility().
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::updatePlaceholderVisibility): Added this
protected function to allow HTMLIsIndexElement::parseMappedAttribute()
to invoke InputElement::updatePlaceholderVisibility().
* html/HTMLIsIndexElement.cpp:
(WebCore::HTMLIsIndexElement::parseMappedAttribute): Call
updatePlaceholderVisibility() when parsing the placeholder attribute.
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createInnerTextStyle): If there
is no placeholder pseudo-element style, use the normal style.
LayoutTests:
Reviewed by Sam Weinig.
- test for <rdar://problem/6927761> <isindex> placeholder text is
unstylable and initially not visible
* fast/forms/isindex-placeholder.html: Added.
* platform/mac/fast/forms/isindex-placeholder-expected.checksum: Added.
* platform/mac/fast/forms/isindex-placeholder-expected.png: Added.
* platform/mac/fast/forms/isindex-placeholder-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44218
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 28 May 2009 05:06:10 +0000 (05:06 +0000)]
2009-05-27 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
More cleanup of DOMWindow related functions.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::willRemoveFromWindowShell): Renamed from JSDOMWindowBase::clear()
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::showModalDialog): Update Comment.
* bindings/js/JSDOMWindowShell.cpp:
* bindings/js/JSDOMWindowShell.h:
Remove JSDOMWindowShell::clear(). It was unused.
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::clearWindowShell):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44217
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 28 May 2009 03:36:03 +0000 (03:36 +0000)]
<rdar://problem/6928025> Stack overflow in JSC::stringProtoFuncReplace() running jsFunFuzz
Reviewed by Mark Rowe
Add an additional exception check for stack overflow in String.replace
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 28 May 2009 03:17:30 +0000 (03:17 +0000)]
2009-05-27 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Miscellaneous cleanup of DOMWindow related functions.
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::~JSDOMGlobalObject): Fix poorly named variables.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsProfiling): Don't jump through hoops
checking for null frames if the build does not support profiling.
(WebCore::JSDOMWindowBase::clear): Use setCurrentEvent(0) instead of calling
clearHelperObjectProperties(). It is clearer.
* bindings/js/JSDOMWindowBase.h:
Removed now unused clearHelperObjectProperties() function, empty disconnectFrame()
function, and the empty destructor.
* bindings/js/JSDOMWindowShell.cpp:
* bindings/js/JSDOMWindowShell.h:
Remove disconnectFrame() which only called JSDOMWindowBase::disconnectFrame(), which
is a no-op.
* page/Frame.cpp:
(WebCore::Frame::~Frame):
(WebCore::Frame::pageDestroyed):
Remove calls to JSDOMWindowShell::disconnectFrame() which only called
JSDOMWindowBase::disconnectFrame(), which is a no-op.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 28 May 2009 00:13:22 +0000 (00:13 +0000)]
2009-05-27 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Xan Lopez.
Add comment to clarify why scrolling is done as it is and not with
gdk_window_scroll.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::scroll):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 27 May 2009 22:16:23 +0000 (22:16 +0000)]
2009-05-27 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=25974
Remove extra qualifiers from the ScheduledAction decl.
* bindings/v8/ScheduledAction.h: Removed extraneous class qualifiers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Wed, 27 May 2009 21:23:30 +0000 (21:23 +0000)]
2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed make distcheck fix. One more missing file.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44201
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 27 May 2009 21:09:55 +0000 (21:09 +0000)]
2009-05-27 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] Fixed trunk build on Linux after r44126.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44200
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Wed, 27 May 2009 20:46:54 +0000 (20:46 +0000)]
2009-05-27 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6926046> REGRESSION (r43972): http://www.youtube.com/html5 crashes on open
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::load): Don't look for a media engine based on an empty MIME type.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44199
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Wed, 27 May 2009 20:04:40 +0000 (20:04 +0000)]
2009-05-27 Maciej Stachowiak <mjs@apple.com>
Not reviewed, demo content.
- add Calendar demo.
* demos/calendar: Added.
* demos/calendar/Boom.aiff: Added.
* demos/calendar/Calendar.css: Added.
* demos/calendar/Calendar.html: Added.
* demos/calendar/Calendar.js: Added.
* demos/calendar/Calendar.manifest: Added.
* demos/calendar/CalendarApp.icns: Added.
* demos/calendar/Images: Added.
* demos/calendar/Images/AirPort4.png: Added.
* demos/calendar/Images/AirPortError.png: Added.
* demos/calendar/Images/disclosureTriangleSmallDown.png: Added.
* demos/calendar/Images/disclosureTriangleSmallRight.png: Added.
* demos/calendar/Images/statusbarBackground.png: Added.
* demos/calendar/Images/statusbarResizerVertical.png: Added.
* demos/calendar/LocationImage.js: Added.
* demos/calendar/Utilities.js: Added.
* demos/calendar/favicon.ico: Added.
* demos/calendar/mime.types: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44198
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Wed, 27 May 2009 19:20:42 +0000 (19:20 +0000)]
2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed (make distcheck) build fix; adding missing headers.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44197
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@apple.com [Wed, 27 May 2009 19:14:12 +0000 (19:14 +0000)]
2009-05-27 Jessie Berlin <jberlin@apple.com>
Reviewed by aroben
Fix the Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44196
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Wed, 27 May 2009 19:03:30 +0000 (19:03 +0000)]
2009-05-27 David Levin <levin@chromium.org>
Reviewed by Maciej Stachowiak.
Bug 26029: FrameLoader::canLoad should allow calls with just a security origin
https://bugs.webkit.org/show_bug.cgi?id=26029
No functional changes, so no tests.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::canLoad):
* loader/FrameLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44195
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Wed, 27 May 2009 18:01:34 +0000 (18:01 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26009
<rdar://problem/6925656> REGRESSION (r43973): Problems While Working With OpenVanilla
* WebView/WebHTMLView.mm:
(-[WebHTMLView _updateSelectionForInputManager]): Don't call updateWindows if the selection
is None. This routinely happens during editing, and it doesn't mean that we left an editable
area (in which case the selection changes to a non-editable one).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44194
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Wed, 27 May 2009 17:57:25 +0000 (17:57 +0000)]
2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed build fix.
Remove file that does not exist from the build.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44193
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 27 May 2009 17:33:09 +0000 (17:33 +0000)]
Reviewed by Darin Adler.
Remove two unneeded protected constructors, these classes have pure-virtual functions, and can't be constructed anyway.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44192
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Wed, 27 May 2009 17:27:37 +0000 (17:27 +0000)]
2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Adding new symbols index for 1.1.8.
* docs/webkitgtk-docs.sgml:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44191
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Wed, 27 May 2009 17:21:02 +0000 (17:21 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=17725
XPath should be case insensitive for HTML
Test: fast/xpath/node-name-case-sensitivity.html
* xml/XPathStep.cpp: (WebCore::XPath::Step::nodeMatches): Made node name check case insensitive
for HTML elements in HTML documents.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44190
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Wed, 27 May 2009 17:00:40 +0000 (17:00 +0000)]
2009-05-27 John Sullivan <sullivan@apple.com>
fixed <rdar://problem/6925482> repro crash in WebCore::DragController::dragExited dropping
bookmarks (at least) over Top Sites (at least)
Reviewed by Kevin Decker
* page/DragController.cpp:
(WebCore::DragController::dragExited):
nil check m_documentUnderMouse and take the "local file" case if it's nil
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44189
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Wed, 27 May 2009 14:02:31 +0000 (14:02 +0000)]
WebCore and JavaScriptCore
2009-05-27 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Gustavo Noronha.
When building on Windows, consider Windows specific files.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44188
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 27 May 2009 12:25:19 +0000 (12:25 +0000)]
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=26031
InputElementData is too heavy, save storing two pointers by passing them
directly to the static helper functions (the only place which needs them).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 27 May 2009 12:23:54 +0000 (12:23 +0000)]
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=26033
OptionElementData saves an Element pointer, which is unnessary.
Just pass it to the static function calls directly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Wed, 27 May 2009 12:17:00 +0000 (12:17 +0000)]
2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Disabling new tests to make the bot green.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44185
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Wed, 27 May 2009 12:04:33 +0000 (12:04 +0000)]
2009-05-27 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Maciej Stachowiak.
When building with MinGW, don't use the __declspec(dl{import,export})
decorations and rely on the linker to use its nifty auto-import feature.
It is extremely hard to get the decorations right with MinGW in general
and impossible in WebKit, where the resulting shared library is linking
together some static libraries.
* JavaScriptCore/config.h
* WebCore/config.h
* DumpRenderTree/config.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Wed, 27 May 2009 10:21:49 +0000 (10:21 +0000)]
JavaScripCore:
2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25613
Be able to use GOwnPtr for GHashTable as well. The assumption
is that the hash table has been created with g_hash_table_new_full
and has proper destruction functions.
* wtf/GOwnPtr.cpp:
(WTF::GHashTable):
* wtf/GOwnPtr.h:
WebCore:
2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25613
Add a WebCore::Widget that can embed GtkWidget with and
without a GdkWindow. This can be used to embed any GtkWidget.
Some bits are directly copied from the Scrollbar implementation
but can not be easily shared here.
* GNUmakefile.am:
* platform/gtk/GtkPluginWidget.cpp: Added.
(WebCore::GtkPluginWidget::GtkPluginWidget):
(WebCore::GtkPluginWidget::invalidateRect):
(WebCore::GtkPluginWidget::frameRectsChanged):
(WebCore::GtkPluginWidget::paint):
* platform/gtk/GtkPluginWidget.h: Added.
WebKit:
2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25613
Add a new signal called "create-plugin-widget" and emit it from
within the FrameLoaderClientGtk::createPlugin method. If a
GtkWidget gets returned it will be embedded as a WebCore::Widget
using the new GtkPluginWidget.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::createPlugin):
* webkit/webkitwebview.cpp:
(webkit_signal_accumulator_object_handled):
(webkit_web_view_class_init):
* webkitmarshal.list:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44183
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Wed, 27 May 2009 10:21:10 +0000 (10:21 +0000)]
2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25613
Implement Widget::setIsSelected for Gtk+ by searching
for a property of the name "webkit-widget-is-selected" and if
such property exists we are going to set it. We expect
the property to take a boolean.
* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::setIsSelected):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44182
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 27 May 2009 06:53:38 +0000 (06:53 +0000)]
WebCore:
2009-05-26 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson.
Fix for <rdar://problem/6916371>
iWeb 'Announce' button does nothing after publishing to MobileMe
Add ability to force content sniffing for all urls (including file: urls)
* WebCore.base.exp:
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::shouldContentSniffURL):
(WebCore::ResourceHandle::forceContentSniffing):
* platform/network/ResourceHandle.h:
WebKit/mac:
2009-05-26 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson.
Fix for <rdar://problem/6916371>
iWeb 'Announce' button does nothing after publishing to MobileMe
Add linked-on-or-after check to allow older WebKit apps to use the
old behavior of sniffing everything (including file: urls)
* Misc/WebKitVersionChecks.h:
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44181
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Wed, 27 May 2009 06:35:59 +0000 (06:35 +0000)]
2009-05-26 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25823
Add an API to generate a QUrl out of a string correcting for errors and missing information.
See the API documentation for more details about the function.
Autotests: included
* Api/qwebview.cpp:
(QWebView::guessUrlFromString):
* Api/qwebview.h:
* QtLauncher/main.cpp:
(MainWindow::MainWindow):
(MainWindow::changeLocation):
* tests/qwebview/.gitignore: Added.
* tests/qwebview/qwebview.pro:
* tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::initTestCase):
(tst_QWebView::cleanupTestCase):
(tst_QWebView::init):
(tst_QWebView::cleanup):
(tst_QWebView::guessUrlFromString_data):
(tst_QWebView::guessUrlFromString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44180
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Wed, 27 May 2009 06:35:45 +0000 (06:35 +0000)]
2009-05-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25996
[Qt] Dead-code stripping for unix
* WebCore.pro: Turn on GCC dead-code stripping flags for Unix
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44179
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Wed, 27 May 2009 05:25:48 +0000 (05:25 +0000)]
[GTK] Send onscroll events for the main FrameView
2009-05-10 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=25646
[GTK] Send onscroll events for the main FrameView
WebKit/GTK+ is currently not sending any onscroll
events for a frame with external adjustments. This is
due the fact that the value-changed signal of the GtkAdjustment
is handled by WebCore::ScrollView directly and is not going through
the WebCore::Scrollbar -> WebCore::ScrollbarClient ->
WebCore::FrameView::valueChanged -> WebCore::ScrollView::valueChanged
path.
Fix the above problem by wrapping the GtkAdjustment we get
assigned from GTK+ in a ScrollbarGtk that will not have any
visual appearance. Remove code from ScrollView that knows
about adjustments and create a special case for
WebCore::ScrollView::createScrollbar that will create such
a special WebCore::ScrollbarGtk.
* platform/ScrollView.cpp: Remove adjustment code
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h: Remove adjustment code
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::platformDestroy):
(WebCore::ScrollView::createScrollbar):
(WebCore::ScrollView::setGtkAdjustments):
* platform/gtk/ScrollbarGtk.cpp:
(ScrollbarGtk::createScrollbar): Special case.
(ScrollbarGtk::ScrollbarGtk): New ctor and work on the adjustment
(ScrollbarGtk::~ScrollbarGtk): Disconnect signal
(ScrollbarGtk::frameRectsChanged): Do nothing when we lack a platformWidget
* platform/gtk/ScrollbarGtk.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44177
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Wed, 27 May 2009 05:20:08 +0000 (05:20 +0000)]
2009-05-26 Cameron Zwarich <zwarich@apple.com>
Reviewed by Maciej Stachowiak.
Bug 26035: Make ImageSource::frameHasAlphaAtIndex() return false for JPEGs with CG
<https://bugs.webkit.org/show_bug.cgi?id=26035>
<rdar://problem/6924087>
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameHasAlphaAtIndex): return false if the image
is JPEG, there is no image type, or m_decoder is null.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44176
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Wed, 27 May 2009 04:30:32 +0000 (04:30 +0000)]
Fix build breakage of JPEGImageDecoder.cpp by including stdio.h again.
2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
Unreviewed build fix for the JPEGImageDecoder.
Revision 44167 removed stdio.h from the included headers and
this will lead to an error that FILE is not known inside the
jpeglib.h Put back the stdio.h include.
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44175
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 27 May 2009 03:22:47 +0000 (03:22 +0000)]
<rdar://problem/6924033> REGRESSION: Assertion failure due to forward references
Reviewed by Gavin Barraclough.
Add a pattern type for forward references to ensure that we don't confuse the
quantifier alternatives assertion.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44174
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos@webkit.org [Wed, 27 May 2009 02:54:09 +0000 (02:54 +0000)]
2009-05-26 Yichao Yin <yichao.yin@torchmobile.com.cn>
Reviewed by Maciej Stachowiak.
Fix the crash issue while running layout tests after enabled XHTMLMP
https://bugs.webkit.org/show_bug.cgi?id=26017
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44173
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Wed, 27 May 2009 02:47:40 +0000 (02:47 +0000)]
2009-05-26 Stephanie Lewis <slewis@apple.com>
Reviewed by Ada Chan and Oliver Hunt.
Remove WebView observers in during fast teardown.
<rdar://problem/6922619> REGRESSION (Tiger-only?): After restoring windows from the previous session, a crash occurs while attempting to quit Safari
* WebView/WebView.mm:
(-[WebView _closeWithFastTeardown]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44172
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 27 May 2009 02:47:35 +0000 (02:47 +0000)]
2009-05-26 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Fix for: <rdar://problem/6918095> REGRESSION: jQuery load() issue (25981),
and also an ASSERT failure on http://ihasahotdog.com/.
When overwriting a property on a dictionary with a cached specific value,
clear the cache if new value being written is different.
* JavaScriptCore.exp:
Export the new symbols.
* jit/JITStubs.cpp:
(JSC::JITStubs::cti_op_get_by_id_method_check_second):
Close dictionary prototypes upon caching a method access, as would happen when caching
a regular get_by_id.
* runtime/JSObject.h:
(JSC::JSObject::propertyStorage):
(JSC::JSObject::locationForOffset):
Make these methods private.
(JSC::JSObject::putDirectInternal):
When overwriting a property on a dictionary with a cached specific value,
clear the cache if new value being written is different.
* runtime/Structure.cpp:
(JSC::Structure::despecifyDictionaryFunction):
Reset the specific value field for a given property in a dictionary.
(JSC::Structure::despecifyFunctionTransition):
Rename of 'changeFunctionTransition' (this was already internally refered to as a despecification).
* runtime/Structure.h:
Declare new method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44171
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 27 May 2009 00:45:06 +0000 (00:45 +0000)]
WebCore:
2009-05-26 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6901751>
REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
Don't use the WKCGContextIsSafeToClip function; it wasn't working correctly. Instead, just disable
the improved selection drawing on Tiger.
* WebCore.Tiger.exp:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipOutEllipseInRect):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::strokeRect):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::fillSelectionGaps):
WebKit/mac:
2009-05-26 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6901751>
REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
Remove WKCGContextIsSafeToClip.
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
WebKitLibraries:
2009-05-26 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6901751>
REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
Remove WKCGContextIsSafeToClip.
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceTiger.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44170
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 27 May 2009 00:33:13 +0000 (00:33 +0000)]
2009-05-26 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver "pieces of eight" Hunt.
When reseting RegexPattern class, should fully reset the class, not just bits of it.
In particular, we delete the cached character classes (for wordchars, etc), but do
not reset the set of pointers to the cached classes. In the case of a repeated parse
due to an illegal back-reference we will continue to use the deleted character class.
* yarr/RegexPattern.h:
(JSC::Yarr::RegexPattern::reset):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44169
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 27 May 2009 00:29:29 +0000 (00:29 +0000)]
2009-05-26 Olivier DOLE <odole@pleyo.com>
Reviewed by Maciej.
Store sunspider test suite results in a specific directory for each
different type of benchmark (sunspider, V8 or ubench).
* sunspider:
* sunspider-compare-results:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44168
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 27 May 2009 00:20:04 +0000 (00:20 +0000)]
2009-05-26 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25709 part two
Mostly cosmetic changes, mainly to get image decoders for Cairo build to
comply with WebKit style guidelines:
* Fix header guard names
* Fix initializer list wrapping
* Fix class/function "{" wrapping
* Fix wrapping of long boolean expressions
* Fix whitespace around operators
* Eliminate whitespace on otherwise-blank lines
* No {} on single-line conditional arms
* Use 0 instead of NULL
* Don't #include "config.h" in headers
Also a few non-cosmetic changes:
* Remove unneeded #ifdef protecting the contents of these files. The
platforms listed don't match who uses these files anymore (even
without considering Skia), and platforms which don't use them at all
(like CG) aren't harmed by the files, since they don't have
equivalently-named classes. It's simpler to just ditch these.
* Convert a use of Vector<>& into SharedBuffer*, since that's how the
data is really stored anyway.
* Use size() instead of m_size, for consistency with Skia code, and
future-proofing (if a particular decoder wants to specialize this).
* Move an ASSERT that was slightly more aggressive than necessary.
* Change variable names/types for clarity/accuracy and to match Skia.
* Remove unnecessary macro magic to work around a problem which no
longer exists in the third-party JPEG headers.
* Stop silencing a portability warning about setjmp (the vcproj/vsprops
are the right place for this)
* In Skia code, don't explicitly check |m_failed| before calling
isSizeAvailable(), which itself checks |m_failed|.
* platform/image-decoders/ImageDecoder.h: Fix header guards, "{" wrapping.
(WebCore::RGBA32Buffer::):
(WebCore::RGBA32Buffer::RGBA32Buffer): Fix initializer list wrapping.
(WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
* platform/image-decoders/bmp/BMPImageDecoder.cpp: Remove unneeded #ifdef.
* platform/image-decoders/bmp/BMPImageDecoder.h: Fix header guards, "{" wrapping.
* platform/image-decoders/gif/GIFImageDecoder.cpp: Remove unneeded #ifdef, fix "{" wrapping.
(WebCore::GIFImageDecoderPrivate::GIFImageDecoderPrivate): Use an initializer instead of a block-level statement.
(WebCore::GIFImageDecoderPrivate::decode): Expect a SharedBuffer.
(WebCore::GIFImageDecoderPrivate::getColorMap):
(WebCore::GIFImageDecoder::GIFImageDecoder): Fix initializer list wrapping.
(WebCore::GIFImageDecoder::frameCount): Add comment.
(WebCore::GIFImageDecoder::frameBufferAtIndex): Explicitly cast, fix whitespace around operators.
(WebCore::GIFImageDecoder::decode): Pass a SharedBuffer.
(WebCore::GIFImageDecoder::initFrameBuffer): Use size() instead of m_size, move ASSERT, fix boolean wrapping, fix indenting.
(WebCore::GIFImageDecoder::prepEmptyFrameBuffer): Use size() instead of m_size.
(WebCore::GIFImageDecoder::haveDecodedRow): Use size() instead of m_size, eliminate unneeded whitespace, change variable name.
(WebCore::GIFImageDecoder::frameComplete): Use size() instead of m_size, no {} on single-line conditional arms, fix boolean wrapping.
* platform/image-decoders/gif/GIFImageDecoder.h: Fix header guards, "{" wrapping.
* platform/image-decoders/gif/GIFImageReader.cpp: Remove unneeded #ifdef.
(GIFImageReader::read):
* platform/image-decoders/gif/GIFImageReader.h: Fix header guards, change variable type.
* platform/image-decoders/ico/ICOImageDecoder.cpp: Remove unneeded #ifdef.
* platform/image-decoders/ico/ICOImageDecoder.h: Fix header guards, "{" wrapping.
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Remove unneeded #ifdef, macro magic, silencing of warning.
(WebCore::JPEGImageDecoder::outputScanlines): Use size() instead of m_size, change variable name.
* platform/image-decoders/jpeg/JPEGImageDecoder.h: Fix header guards, "{" wrapping.
* platform/image-decoders/png/PNGImageDecoder.cpp: Remove unneeded #ifdef, silencing of warning, change variable type.
(WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping.
(WebCore::PNGImageReader::close): Add comment, zero another member for consistency.
(WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting.
(WebCore::PNGImageDecoder::decodingFailed): Define in .cpp, not .h.
(WebCore::PNGImageDecoder::rowAvailable):
* platform/image-decoders/png/PNGImageDecoder.h: Fix header guards, "{" wrapping.
* platform/image-decoders/skia/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
(WebCore::GIFImageDecoder::frameBufferAtIndex): Fix whitespace around operators.
* platform/image-decoders/skia/GIFImageReader.h: "unsigned" is sufficient to convey "unsigned int".
* platform/image-decoders/skia/ImageDecoder.h: Remove unnecessary #includes.
(WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
* platform/image-decoders/skia/JPEGImageDecoder.cpp:
(WebCore::JPEGImageReader::JPEGImageReader): Use 0 instead of NULL.
(WebCore::JPEGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
* platform/image-decoders/skia/PNGImageDecoder.cpp:
(WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping.
(WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting.
(WebCore::PNGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
(WebCore::rowAvailable):
* platform/image-decoders/skia/XBMImageDecoder.h: Don't #include config.h.
* platform/image-decoders/xbm/XBMImageDecoder.cpp: Remove unneeded #ifdef.
* platform/image-decoders/xbm/XBMImageDecoder.h: Fix header guards, "{" wrapping.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44167
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 27 May 2009 00:13:32 +0000 (00:13 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44166
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 26 May 2009 23:57:23 +0000 (23:57 +0000)]
Reviewed by Darin Adler.
- fix <rdar://problem/6922371> REGRESSION (r43973): Can't type first
character with an umlaut, circumflex, or accent in Mail or in a wiki
* WebView/WebHTMLView.mm:
(isTextInput): Moved here.
(isInPasswordField): Moved here.
(-[WebHTMLView becomeFirstResponder]): Update the exposeInputContext
flag and let NSApplication update the input manager with the new input
context if necessary.
(-[WebHTMLView _updateSelectionForInputManager]): Changed to use the
NSApp global instead of +[NSApplication sharedApplication].
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44164
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 26 May 2009 23:06:42 +0000 (23:06 +0000)]
2009-05-26 Brent Fulgham <bfulgham@webkit.org>
Build fix to correct r44161.
* wtf/FastAllocBase.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44163
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Tue, 26 May 2009 22:58:23 +0000 (22:58 +0000)]
2009-05-26 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25944
Remove the uses of V8 Locker in worker execution code. No additional test is needed.
The normal WebKit layout tests should cover it. However, layout tests that start
multiple workers will fail to pass due to test shell limitation in Chromium. To cover
this, UI tests will be added (http://code.google.com/p/chromium/issues/detail?id=12554).
* bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::handleEvent):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::dispose):
(WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
(WebCore::WorkerContextExecutionProxy::evaluate):
(WebCore::WorkerContextExecutionProxy::findOrCreateEventListenerHelper):
(WebCore::WorkerContextExecutionProxy::RemoveEventListener):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44162
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 26 May 2009 22:25:56 +0000 (22:25 +0000)]
2009-05-26 Zoltan Horvath <horvath.zoltan.6@stud.u-szeged.hu>
Reviewed by Maciej Stachowiak.
Inherite HashTable from FastAllocBase, because it has been instantiated by
'new' in JavaScriptCore/runtime/JSGlobalData.cpp.
* wtf/HashTable.h:
* wtf/FastAllocBase.h: Remove 'wtf' path from TypeTraits.h to allow use outside of wtf.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44161
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Tue, 26 May 2009 21:41:34 +0000 (21:41 +0000)]
2009-05-26 Dmitry Titov <dimich@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25974
Enable timers in Chromuim workers.
* bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute): Added function which can execute a callback using WorkerContext.
* bindings/v8/ScheduledAction.h:
(WebCore::ScheduledAction::ScheduledAction): added url parameter to capture the worker's location.
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::SetTimeoutOrInterval): replaced NotImplemented with code to create ScheduledAction and DOMTimer.
Also, removed declarations for clearTimeout/clearInterval callbacks since they are now directly generated from IDL.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44160
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 26 May 2009 21:19:06 +0000 (21:19 +0000)]
2009-05-26 Adam Barth <abarth@webkit.org>
https://bugs.webkit.org/show_bug.cgi?id=26011
Unreviewed change to disable flaky test as requested by Sam Weinig.
* http/tests/security/postMessage/origin-follows-lexical-scope-expected.txt: Removed.
* http/tests/security/postMessage/origin-follows-lexical-scope.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44159
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Tue, 26 May 2009 20:43:23 +0000 (20:43 +0000)]
Fix the Tiger build.
* Misc/WebNSObjectExtras.mm:
(-[NSInvocation _webkit_invokeAndHandleException:]): Rename the local variable so that
it doesn't conflict with a member variable on Tiger.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44158
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 26 May 2009 20:28:48 +0000 (20:28 +0000)]
2009-05-26 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=23649
Update V8 bindings to match SQLTransactionErrorCallback change.
* bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
(WebCore::V8CustomSQLTransactionErrorCallback::handleEvent): Changed to return void.
* bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44157
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Tue, 26 May 2009 20:05:35 +0000 (20:05 +0000)]
2009-05-26 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Move FilterEffect to platform/graphics/filters. First step to get an
SVG independent filter system.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/filters/FilterEffect.cpp: Added.
(WebCore::FilterEffect::FilterEffect):
(WebCore::FilterEffect::~FilterEffect):
(WebCore::FilterEffect::externalRepresentation):
* platform/graphics/filters/FilterEffect.h: Added.
(WebCore::FilterEffect::xBoundingBoxMode):
(WebCore::FilterEffect::setXBoundingBoxMode):
(WebCore::FilterEffect::yBoundingBoxMode):
(WebCore::FilterEffect::setYBoundingBoxMode):
(WebCore::FilterEffect::widthBoundingBoxMode):
(WebCore::FilterEffect::setWidthBoundingBoxMode):
(WebCore::FilterEffect::heightBoundingBoxMode):
(WebCore::FilterEffect::setHeightBoundingBoxMode):
(WebCore::FilterEffect::subRegion):
(WebCore::FilterEffect::setSubRegion):
(WebCore::FilterEffect::resultImage):
(WebCore::FilterEffect::setEffectBuffer):
* svg/FilterEffect.cpp: Removed.
* svg/FilterEffect.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44156
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 26 May 2009 19:37:14 +0000 (19:37 +0000)]
WebCore:
2009-05-26 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=23649
Update SQLTransactionErrorCallback to not return a value per changes in
HTML5 spec.
Test: storage/transaction-error-callback.html
* bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
(WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
* bindings/js/JSCustomSQLTransactionErrorCallback.h:
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::postflightAndCommit):
(WebCore::SQLTransaction::handleTransactionError):
(WebCore::SQLTransaction::deliverTransactionErrorCallback):
(WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
* storage/SQLTransaction.h:
* storage/SQLTransactionErrorCallback.h:
LayouTests:
2009-05-26 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=23649
Add layout test for various cases of SQLTransactionErrorCallback
invocation.
* storage/transaction-error-callback-expected.txt: Added.
* storage/transaction-error-callback.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44155
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 26 May 2009 18:29:06 +0000 (18:29 +0000)]
2009-05-26 Darin Adler <darin@apple.com>
Reviewed by Mark Rowe.
<rdar://problem/6921835> REGRESSION (r44115): Crash in Leopard Mail viewing message
Fix case where we autorelease an object on the main thread that we are returning
to another thread when using our _webkit_invokeOnMainThread method.
* Misc/WebNSObjectExtras.mm:
(returnTypeIsObject): Added.
(-[WebMainThreadInvoker forwardInvocation:]): Autorelease the object on the calling
thread, balancing a retain done on the main thread.
(-[NSInvocation _webkit_invokeAndHandleException:]): Retain the object on the main
thread.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44154
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 26 May 2009 18:26:16 +0000 (18:26 +0000)]
2009-05-26 David Hyatt <hyatt@apple.com>
Back out the workaround for Mail crashing. Darin is working on the real fix.
* Misc/WebNSObjectExtras.mm:
(-[WebMainThreadInvoker forwardInvocation:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44153
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 26 May 2009 18:16:58 +0000 (18:16 +0000)]
WebCore:
2009-05-26 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=25969
Detect the case where we can fit without scrollbars when the view shrinks, so that we don't mistakenly
continue to show scrollbars.
Added two tests in fast/dynamic.
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
WebKit/mac:
2009-05-26 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=25969.
Stop using notifications for boundsChanged, since the notifications are being sent too late.
Since subviews get resized before parents do, the notification comes in telling the WebHTMLView
that its size has changed *before* we've done setNeedsLayout in the WebView size change callback.
Become more like the Windows platform and just do the bounds changed immediately as our size is
being altered by subclassing setFrameSize in WebView.
Also patch WebDynamicScrollbarsView to detect the case where neither axis is really spilling out
past the viewport, so that in shrinking situations we figure out that we don't need scrollbars
any more.
* WebView/WebDynamicScrollBarsView.m:
(-[WebDynamicScrollBarsView updateScrollers]):
* WebView/WebView.mm:
(-[WebView _boundsChangedToNewSize:]):
(-[WebView setFrameSize:]):
(-[WebView viewWillMoveToWindow:]):
(-[WebView viewDidMoveToWindow]):
LayoutTests:
2009-05-26 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
Fix for bug 25969, scrollbars remain after document shrinks. Add a couple of layout tests
written by Dan that show various problems with scrollbars following resizes.
* fast/dynamic/window-resize-scrollbars-test.html: Added.
* fast/dynamic/window-scrollbars-test.html: Added.
* platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.checksum: Added.
* platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.png: Added.
* platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.txt: Added.
* platform/mac/fast/dynamic/window-scrollbars-test-expected.checksum: Added.
* platform/mac/fast/dynamic/window-scrollbars-test-expected.png: Added.
* platform/mac/fast/dynamic/window-scrollbars-test-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44152
268f45cc-cd09-0410-ab3c-
d52691b4dbfc