WebKit-https.git
10 years ago2010-07-26 Victor Wang <victorw@chromium.org>
victorw@chromium.org [Mon, 26 Jul 2010 22:23:37 +0000 (22:23 +0000)]
2010-07-26  Victor Wang  <victorw@chromium.org>

        Unreviewed. Update chromium test expectations for flaky test on linux:
        tables/mozilla_expected_failures/bugs/bug89315.html

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 26 Jul 2010 22:11:13 +0000 (22:11 +0000)]
2010-07-26  Simon Fraser  <simon.fraser@apple.com>

        Fix tests on Leopard.

        No need for these Leopard-specific results any more.

        * platform/mac-leopard/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Removed.
        * platform/mac-leopard/compositing/iframes/connect-compositing-iframe3-expected.txt: Removed.
        * platform/mac-leopard/compositing/iframes/iframe-resize-expected.txt: Removed.
        * platform/mac-leopard/compositing/iframes/iframe-size-from-zero-expected.txt: Removed.
        * platform/mac-leopard/compositing/iframes/overlapped-iframe-expected.txt: Removed.
        * platform/mac-leopard/compositing/iframes/scrolling-iframe-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Fix Windows build.
adachan@apple.com [Mon, 26 Jul 2010 22:03:31 +0000 (22:03 +0000)]
    Fix Windows build.

        * win/WebKit2Generated.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 26 Jul 2010 21:41:41 +0000 (21:41 +0000)]
2010-07-26  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson.

        Gmail compose is upside-down after r64054
        https://bugs.webkit.org/show_bug.cgi?id=43000

        We need to call setGeometryOrientation() whenever the iframe compositing layer attachment changes,
        not just when requiresScrollLayer() returns false. This ensures that the orientation is updated
        correctly.

        Test: compositing/iframes/iframe-content-flipping.html

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Mon, 26 Jul 2010 21:36:47 +0000 (21:36 +0000)]
2010-07-26  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Fisher.

        Check history state against origin before setting
        https://bugs.webkit.org/show_bug.cgi?id=42858

        Tests: fast/loader/stateobjects/replacestate-base-illegal.html
               fast/loader/stateobjects/replacestate-base-legal.html

        * page/History.cpp:
        (WebCore::History::urlForState):
        (WebCore::History::stateObjectAdded):
2010-07-26  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Fisher.

        Check history state when base URL is changed
        https://bugs.webkit.org/show_bug.cgi?id=42858

        * fast/loader/stateobjects/replacestate-base-illegal-expected.txt: Added.
        * fast/loader/stateobjects/replacestate-base-illegal.html: Added.
        * fast/loader/stateobjects/replacestate-base-legal-expected.txt: Added.
        * fast/loader/stateobjects/replacestate-base-legal.html: Added.
        * fast/loader/stateobjects/resources/replacestate-base-pass.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Windows build.
andersca@apple.com [Mon, 26 Jul 2010 21:33:28 +0000 (21:33 +0000)]
Fix Windows build.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 26 Jul 2010 21:32:18 +0000 (21:32 +0000)]
2010-07-26  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Get rid of libgdom
        https://bugs.webkit.org/show_bug.cgi?id=42378

        Remove the need to build the libgdom intermediate library.

        * GNUmakefile.am: Move the source list for the GObject DOM bindings to
        the top-level GNUmakefile.am, since they are logically part of WebKit, instead
        of WebCore. List all auto-generated files statically and remove no-longer-
        used variables. Fix an issue where some places expected webkitenumtypes.cpp
        to be generated in different directories.
2010-07-26  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Get rid of libgdom
        https://bugs.webkit.org/show_bug.cgi?id=42378

        Remove all build steps for building GObject DOM bindings.

        * GNUmakefile.am: Remove GObject DOM bindings build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDisable a test that was added to verify the vendor prefix change that I rolled out...
mrowe@apple.com [Mon, 26 Jul 2010 21:20:47 +0000 (21:20 +0000)]
Disable a test that was added to verify the vendor prefix change that I rolled out in r64071.
It can be reenabled when the vendor prefix change is reintroduced in a more limited fashion.

* fast/css/limited-vendor-prefix-behavior.html-disabled: Renamed from LayoutTests/fast/css/limited-vendor-prefix-behavior.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoHandle mouseenter/mouseleave + focus events
andersca@apple.com [Mon, 26 Jul 2010 21:15:27 +0000 (21:15 +0000)]
Handle mouseenter/mouseleave + focus events
https://bugs.webkit.org/show_bug.cgi?id=42997

Reviewed by Sam Weinig.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::handleMouseEnterEvent):
Call platformHandleMouseEnterEvent.

(WebKit::NetscapePlugin::handleMouseLeaveEvent):
Call platformHandleMouseExitEvent.

(WebKit::NetscapePlugin::setFocus):
Call platformSetFocus.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::fillInCocoaEventFromMouseEvent):
Factor out code that fills in an NPCocoaEvent from a WebMouseEvent.

(WebKit::initializeMouseEvent):
Call fillInCocoaEventFromMouseEvent.

(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
Send an NPCocoaEventMouseEntered event.

(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
Send an NPCocoaEventMouseExited event.

(WebKit::NetscapePlugin::platformSetFocus):
Send an NPCocoaEventFocusChanged.

* WebProcess/Plugins/Plugin.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::handleEvent):
Dispatch mouse enter and mouse leave events. Call focusPluginElement on mousedown.

(WebKit::PluginView::focusPluginElement):
Focus the plug-in's containing frame and its element.

(WebKit::PluginView::setFocus):
Call Plugin::setFocus.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Mon, 26 Jul 2010 20:58:03 +0000 (20:58 +0000)]
2010-07-26  Daniel Bates  <dbates@rim.com>

        Reviewed by Darin Adler.

        svn-unapply warns of uninitialized variable when unapplying
        a patch that describes an svn move operation
        https://bugs.webkit.org/show_bug.cgi?id=42036

        Fixes Perl uninitialized variable warnings when un-applying
        a patch that moves a file.

        * Scripts/svn-unapply:
          - Modified patch() so that it initializes $patch to the empty
            string when we don't have svnConvertedText (such as when
            reversing a diff that represents a svn copy/move operation).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/42990> REGRESSION (r63854): Safari RSS layout is broken due...
mrowe@apple.com [Mon, 26 Jul 2010 20:53:02 +0000 (20:53 +0000)]
<webkit.org/b/42990> REGRESSION (r63854): Safari RSS layout is broken due to changes in vendor prefix handling

Reviewed by Dan Bernstein.

In r63854 support for properties with the -khtml vendor prefix was removed. This breaks the layout of
Safari's RSS interface, several Dashboard widgets that are included with Mac OS X, and at least one
popular third-party Mac OS X application. This change will need to be revisited in a manner that has
a clearer backwards-compatibility strategy. <http://webkit.org/b/42093> will be reopened to track that.

* css/CSSParser.cpp:
(WebCore::cssPropertyID): Revert the WebCore change from r63854.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 26 Jul 2010 20:37:56 +0000 (20:37 +0000)]
2010-07-26  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig.

        Add ability for WK2 to register a scheme to always be displayed as an empty document
        https://bugs.webkit.org/show_bug.cgi?id=42995

        No new tests. (Currently not possible to test in WebKit1 DRT, can be testing in future WK2 tester)

        * WebCore.exp.in:

        * loader/MainResourceLoader.cpp:
        (WebCore::shouldLoadAsEmptyDocument):

        * platform/SchemeRegistry.cpp:
        (WebCore::emptyDocumentSchemes):
        (WebCore::SchemeRegistry::registerURLSchemeAsEmptyDocument):
        (WebCore::SchemeRegistry::shouldLoadURLSchemeAsEmptyDocument):
        * platform/SchemeRegistry.h:
2010-07-26  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig.

        Add ability for WK2 to register a scheme to always be displayed as an empty document
        https://bugs.webkit.org/show_bug.cgi?id=42995

        * Shared/CoreIPCSupport/WebProcessMessageKinds.h:
        (WebProcessMessage::):

        * UIProcess/API/C/WKContext.cpp:
        (_WKContextRegisterURLSchemeAsEmptyDocument):
        * UIProcess/API/C/WKContextPrivate.h:

        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::registerURLSchemeAsEmptyDocument):
        * UIProcess/WebContext.h:

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::registerURLSchemeAsEmptyDocument):
        (WebKit::WebProcess::didReceiveMessage):
        * WebProcess/WebProcess.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Simon Fraser <simon.fraser@apple.com>
victorw@chromium.org [Mon, 26 Jul 2010 20:16:44 +0000 (20:16 +0000)]
2010-07-26  Simon Fraser  <simon.fraser@apple.com>

        Fix compositing iframe tests on Leopard.

        Add Leopard-specific results where geometry flipping causes a different test output.

        * platform/mac-leopard/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/iframe-resize-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/overlapped-iframe-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/scrolling-iframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGet rid of the dummy plug-in.
andersca@apple.com [Mon, 26 Jul 2010 20:16:09 +0000 (20:16 +0000)]
Get rid of the dummy plug-in.

Reviewed by Adam Roben.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/Plugins/DummyPlugin.cpp: Removed.
* WebProcess/Plugins/DummyPlugin.h: Removed.
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove some non-APIish functions into private headers.
weinig@apple.com [Mon, 26 Jul 2010 20:09:20 +0000 (20:09 +0000)]
Move some non-APIish functions into private headers.

Reviewed by Anders Carlsson.

WebKit2:

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
* WebProcess/InjectedBundle/API/c/WKBundle.h:
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h: Copied from WebProcess/InjectedBundle/API/c/WKBundleFrame.h.
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Copied from WebProcess/InjectedBundle/API/c/WKBundle.h.
* win/WebKit2.vcproj:

WebKitTools:

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 26 Jul 2010 19:57:18 +0000 (19:57 +0000)]
2010-07-26  Simon Fraser  <simon.fraser@apple.com>

        Fix compositing iframe tests on Leopard.

        Add Leopard-specific results where geometry flipping causes a different test output.

        * platform/mac-leopard/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/iframe-resize-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/overlapped-iframe-expected.txt: Added.
        * platform/mac-leopard/compositing/iframes/scrolling-iframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=42986
weinig@apple.com [Mon, 26 Jul 2010 19:57:04 +0000 (19:57 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=42986
Add prompt and confirm client functions to WebKit2

Reviewed by Anders Carlsson.

WebKit2:

* Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
(WebPageProxyMessage::):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveSyncMessage):
(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::runJavaScriptConfirm):
(WebKit::WebPageProxy::runJavaScriptPrompt):
* UIProcess/WebPageProxy.h:
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::runJavaScriptAlert):
(WebKit::WebUIClient::runJavaScriptConfirm):
(WebKit::WebUIClient::runJavaScriptPrompt):
* UIProcess/WebUIClient.h:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):

WebKitTools:

* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDeliver mouse and wheel events to plug-ins
andersca@apple.com [Mon, 26 Jul 2010 19:41:59 +0000 (19:41 +0000)]
Deliver mouse and wheel events to plug-ins
https://bugs.webkit.org/show_bug.cgi?id=42988

Reviewed by Sam Weinig.

* Shared/WebEvent.h:
(WebKit::WebMouseEvent::WebMouseEvent):
(WebKit::WebMouseEvent::deltaX):
(WebKit::WebMouseEvent::deltaY):
(WebKit::WebMouseEvent::deltaZ):
* Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebMouseEvent):
Add deltaX, deltaY and deltaZ member variables to WebMosueEvent.

* WebKit2.xcodeproj/project.pbxproj:
Rename NetscapePluginMac.cpp to NetscapePluginMac.mm.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NPP_HandleEvent):
Add NPP_ wrapper.

(WebKit::NetscapePlugin::handleMouseEvent):
(WebKit::NetscapePlugin::handleWheelEvent):
Call the platform variants.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: Added.
(WebKit::modifierFlags):
(WebKit::buttonNumber):
(WebKit::initializeMouseEvent):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
Create an NPCocoaEvent and send it to the plug-in.

(WebKit::NetscapePlugin::platformHandleWheelEvent):
Ditto.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::handleEvent):
Get the current WebEvent and send it to the plug-in if necessary.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::currentEvent):
(WebKit::CurrentEvent::CurrentEvent):
(WebKit::CurrentEvent::~CurrentEvent):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::keyEvent):
* WebProcess/WebPage/WebPage.h:
Add RAII object for keeping track of the current event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Mon, 26 Jul 2010 19:30:38 +0000 (19:30 +0000)]
2010-07-26  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kent Tamura.

        [WINCE] Port ClipboardUtilities to WinCE
        https://bugs.webkit.org/show_bug.cgi?id=42929

        Make ClipboardUtilitiesWin more portable and remove the global namespace prefix
        from GlobalLock/GlobalUnlock, since they are only macros on WinCE.

        * platform/win/ClipboardUtilitiesWin.cpp:
        (WebCore::urlFromPath):
        (WebCore::getWebLocData):
        (WebCore::createGlobalData):
        (WebCore::getURL):
        (WebCore::getPlainText):
        (WebCore::fragmentFromHTML):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Victor Wang <victorw@chromium.org>
victorw@chromium.org [Mon, 26 Jul 2010 19:22:07 +0000 (19:22 +0000)]
2010-07-26  Victor Wang  <victorw@chromium.org>

        Unreviewed. Update chromium test expectations fro flaky test.

        https://bugs.webkit.org/show_bug.cgi?id=42989

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Mon, 26 Jul 2010 19:10:59 +0000 (19:10 +0000)]
2010-07-26  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        [WINCE] Buildfix for BitmapImage.h
        https://bugs.webkit.org/show_bug.cgi?id=42931

        Use AffineTransform insted of TransformationMatrix.

        * platform/graphics/BitmapImage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix
aroben@apple.com [Mon, 26 Jul 2010 18:57:13 +0000 (18:57 +0000)]
Windows build fix

WebKit2:

* win/WebKit2.vcproj:
* win/WebKit2WebProcess.vcproj:
Removed empty attributes so the values will be picked up from the
vsprops files. (Also removed a couple of attributes that accidentally
duplicated values from the vsprops files.)

WebKitTools:

* MiniBrowser/MiniBrowser.vcproj:
* WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
Removed empty attributes so the values will be picked up from the
vsprops files. (Also removed a couple of attributes that accidentally
duplicated values from the vsprops files.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 26 Jul 2010 18:41:24 +0000 (18:41 +0000)]
2010-07-26  Dirk Schulze  <krit@webkit.org>

        Unreviewed sort of XCode project file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/42982> Streamline Inspector Source build phase script should...
ddkilzer@apple.com [Mon, 26 Jul 2010 18:32:01 +0000 (18:32 +0000)]
<webkit.org/b/42982> Streamline Inspector Source build phase script should use CONFIGURATION not BUILD_STYLE
<rdar://problem/6341764>

Reviewed by Mark Rowe.

* WebCore.xcodeproj/project.pbxproj: Switched Streamline
Inspector Source build phase script to use CONFIGURATION instead
of BUILD_STYLE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 26 Jul 2010 18:28:41 +0000 (18:28 +0000)]
2010-07-23  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Darin Adler.

        crash in insertParagraph in a contentEditable list
        https://bugs.webkit.org/show_bug.cgi?id=42919

        * editing/execCommand/crash-on-enter-in-contentEditable-list-expected.txt: Added.
        * editing/execCommand/crash-on-enter-in-contentEditable-list.html: Added.
2010-07-23  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Darin Adler.

        crash in insertParagraph in a contentEditable list
        https://bugs.webkit.org/show_bug.cgi?id=42919

        Don't try to break out of a list item if the list it's in
        is the rootEditableElement.

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Mon, 26 Jul 2010 18:15:05 +0000 (18:15 +0000)]
2010-07-26  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Moves IDBKeyRange to use IDBKey rather than SerializedScriptValue / IDBAny.
        https://bugs.webkit.org/show_bug.cgi?id=42583

        Tests: existing storage/indexeddb/idb-keyrange.html must pass.

        * storage/IDBKeyRange.cpp:
        (WebCore::IDBKeyRange::IDBKeyRange):
        * storage/IDBKeyRange.h:
        (WebCore::IDBKeyRange::create):
        (WebCore::IDBKeyRange::left):
        (WebCore::IDBKeyRange::right):
        * storage/IDBKeyRange.idl:
        * storage/IndexedDatabaseRequest.cpp:
        (WebCore::IndexedDatabaseRequest::makeSingleKeyRange):
        (WebCore::IndexedDatabaseRequest::makeLeftBoundKeyRange):
        (WebCore::IndexedDatabaseRequest::makeRightBoundKeyRange):
        (WebCore::IndexedDatabaseRequest::makeBoundKeyRange):
        * storage/IndexedDatabaseRequest.h:
        * storage/IndexedDatabaseRequest.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 26 Jul 2010 17:48:13 +0000 (17:48 +0000)]
2010-07-26  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson.

        Composited layers don't scroll in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=42771

        Rename two methods on RenderLayerCompositor to make their use more clear, and call them
        when the FrameView gets resized and scrolled.

        * page/FrameView.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::setFrameRect): override so we know when the size of the FrameView changes, so that the
        RenderLayerCompositor can update its clipping layer.
        (WebCore::FrameView::scrollPositionChanged): Call compositor()->frameViewDidScroll().

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateAfterWidgetResize): updateContentLayerOffset() was renamed.

        * rendering/RenderLayerCompositor.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::frameViewDidChangeSize): Renamed from updateContentLayerOffset().
        (WebCore::RenderLayerCompositor::frameViewDidScroll): Renamed from updateContentLayerScrollPosition().
        (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Propagate compositing on Mac
        for any FrameView that doesn't have a native widget, which is the case with WebKit2.
        (WebCore::RenderLayerCompositor::requiresScrollLayer): New method to tell us whether we need to handle
        scrolling (and clipping) ourselves.
        (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Do geometry flipping on the root platform
        layer only if we're not doing our own scrolling, and use the new requiresScrollLayer() method.
        (WebCore::RenderLayerCompositor::attachRootPlatformLayer): Send out the rootPlatformLayer(),
        so that it returns the clipping layer if we have one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Mon, 26 Jul 2010 17:37:50 +0000 (17:37 +0000)]
2010-07-26  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Ojan Vafai.

        Rename indexedDB tests to match new scheme
        https://bugs.webkit.org/show_bug.cgi?id=42375

        No changes to the tests themselves.

        * storage/indexeddb/script-tests/basics.js: Added.
        (openCallback):
        (test):
        * storage/indexeddb/script-tests/database-basics.js: Added.
        (openSuccess):
        (test):
        * storage/indexeddb/script-tests/idb-database-request.js: Removed.
        * storage/indexeddb/script-tests/idb-objectstore-request.js: Removed.
        * storage/indexeddb/script-tests/indexed-database-request.js: Removed.
        * storage/indexeddb/script-tests/keyrange.js: Renamed from LayoutTests/storage/indexeddb/script-tests/idb-keyrange.js.
        (checkSingleKeyRange):
        (checkLeftBoundKeyRange):
        ():
        * storage/indexeddb/script-tests/objectstore-basics.js: Added.
        (test):
        (openSuccess):
        (createSuccess):
        (addSuccess):
        (getSuccess):
        (removeSuccess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTouch MiniBrowser's stdafx to fix the build.
bweinstein@apple.com [Mon, 26 Jul 2010 17:11:18 +0000 (17:11 +0000)]
Touch MiniBrowser's stdafx to fix the build.

Rubber-stamped by Adam Roben.

* MiniBrowser/win/stdafx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Mon, 26 Jul 2010 17:03:35 +0000 (17:03 +0000)]
2010-07-26  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Darin Fisher.

        Move DocumentLoadTiming struct to a new file
        https://bugs.webkit.org/show_bug.cgi?id=42917

        Also makes DocumentLoadTiming Noncopyable.

        No new tests because no new functionality.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * loader/DocumentLoadTiming.h: Added.
        (WebCore::DocumentLoadTiming::DocumentLoadTiming):
        * loader/DocumentLoader.h:
        * loader/FrameLoader.cpp:
        * loader/FrameLoaderTypes.h:
        * loader/MainResourceLoader.cpp:
        * page/Timing.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClean up event handling functions
andersca@apple.com [Mon, 26 Jul 2010 17:03:31 +0000 (17:03 +0000)]
Clean up event handling functions
https://bugs.webkit.org/show_bug.cgi?id=42977

Reviewed by Sam Weinig.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::keyEvent):
(WebKit::WebPage::didReceiveMessage):
* WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix an #if in WebCore.exp.in to correctly detect whether SVG filters are enabled.
mrowe@apple.com [Mon, 26 Jul 2010 16:24:18 +0000 (16:24 +0000)]
Fix an #if in WebCore.exp.in to correctly detect whether SVG filters are enabled.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Steve Block <steveblock@google.com>
steveblock@google.com [Mon, 26 Jul 2010 16:01:30 +0000 (16:01 +0000)]
2010-07-26  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        DeviceOrientation event listeners should never be called synchronously from addEventListener()
        https://bugs.webkit.org/show_bug.cgi?id=42304

        No new tests as there are currently no implementations to test. Tests will be
        added once LayoutTestController methods for providing a mock implementation are
        in place, see Bug 39589.

        * dom/DeviceOrientationController.cpp:
        (WebCore::DeviceOrientationController::DeviceOrientationController):
        (WebCore::DeviceOrientationController::timerFired):
        (WebCore::DeviceOrientationController::addListener):
        (WebCore::DeviceOrientationController::removeListener):
        (WebCore::DeviceOrientationController::removeAllListeners):
        * dom/DeviceOrientationController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Mon, 26 Jul 2010 15:56:50 +0000 (15:56 +0000)]
2010-07-26  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Canvas: Optimize GraphicsContext::addPath()

        Avoid "deep concatenating" the canvas path onto the GC path
        if the GC path has no elements.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::addPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Mon, 26 Jul 2010 15:43:55 +0000 (15:43 +0000)]
2010-07-23  Stephen White  <senorblanco@chromium.org>

        Reviewed by Darin Fisher.

        Implement OpenGLES2 helper classes.
        https://bugs.webkit.org/show_bug.cgi?id=42905

        GLES2Canvas and GLES2Texture are some simple OpenGLES2 helper classes
        for managing state, samplers and textures.

        When this is hooked up, it will be covered by many layout tests.

        * WebCore.gypi:
        Add new files to chromium build (contents are protected by #if's for now).
        * platform/graphics/chromium/GLES2Canvas.cpp: Added.
        (WebCore::affineTo3x3):
        (WebCore::GLES2Canvas::State::State):
        (WebCore::GLES2Canvas::GLES2Canvas):
        (WebCore::GLES2Canvas::~GLES2Canvas):
        (WebCore::GLES2Canvas::clearRect):
        (WebCore::GLES2Canvas::fillRect):
        (WebCore::GLES2Canvas::setFillColor):
        (WebCore::GLES2Canvas::setAlpha):
        (WebCore::GLES2Canvas::translate):
        (WebCore::GLES2Canvas::rotate):
        (WebCore::GLES2Canvas::scale):
        (WebCore::GLES2Canvas::concatCTM):
        (WebCore::GLES2Canvas::save):
        (WebCore::GLES2Canvas::restore):
        (WebCore::GLES2Canvas::drawTexturedRect):
        (WebCore::GLES2Canvas::setCompositeOperation):
        (WebCore::GLES2Canvas::applyCompositeOperator):
        (WebCore::GLES2Canvas::getQuadVertices):
        (WebCore::GLES2Canvas::getQuadIndices):
        (WebCore::loadShader):
        (WebCore::GLES2Canvas::getSimpleProgram):
        (WebCore::GLES2Canvas::getTexProgram):
        (WebCore::GLES2Canvas::createTexture):
        (WebCore::GLES2Canvas::getTexture):
        (WebCore::GLES2Canvas::checkGLError):
        * platform/graphics/chromium/GLES2Canvas.h: Added.
        (WebCore::GLES2Canvas::gles2Context):
        * platform/graphics/chromium/GLES2Texture.cpp: Added.
        (WebCore::GLES2Texture::GLES2Texture):
        (WebCore::GLES2Texture::~GLES2Texture):
        (WebCore::GLES2Texture::create):
        (WebCore::convertFormat):
        (WebCore::GLES2Texture::load):
        (WebCore::GLES2Texture::bind):
        * platform/graphics/chromium/GLES2Texture.h: Added.
        (WebCore::GLES2Texture::):
        (WebCore::GLES2Texture::format):
        (WebCore::GLES2Texture::width):
        (WebCore::GLES2Texture::height):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Mon, 26 Jul 2010 14:49:37 +0000 (14:49 +0000)]
2010-07-26  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Fix IndexedDB release build on mac
        https://bugs.webkit.org/show_bug.cgi?id=42377

        * storage/IDBDatabaseImpl.cpp:
        (WebCore::IDBDatabaseImpl::objectStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Hayato Ito <hayato@chromium.org>
commit-queue@webkit.org [Mon, 26 Jul 2010 13:47:05 +0000 (13:47 +0000)]
2010-07-26  Hayato Ito  <hayato@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Add pretty printer of WTF::Vector for GDB 7.

        https://bugs.webkit.org/show_bug.cgi?id=40909

        * gdb/wtf.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Mon, 26 Jul 2010 12:04:13 +0000 (12:04 +0000)]
2010-07-26  Marcus Bulach  <bulach@chromium.org>

        Unreviewed.  Add chromium expectations for failing tests.

        tables/mozilla/other/slashlogo.html fails after r63994
        https://bugs.webkit.org/show_bug.cgi?id=42964

        Adds a suppression for chromium.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Satish Sampath <satish@chromium.org>
commit-queue@webkit.org [Mon, 26 Jul 2010 11:52:50 +0000 (11:52 +0000)]
2010-07-26  Satish Sampath  <satish@chromium.org>

        Reviewed by Steve Block.

        Add WebKit plumbing to connect speech requests and callbacks between WebCore and the embedder.
        https://bugs.webkit.org/show_bug.cgi?id=42367

        No new tests, the relevant LayoutTestController bindings will be added in the next patch.

        * page/SpeechInput.cpp: renamed a method.
        * page/SpeechInput.h: renamed a method.
        * page/SpeechInputClient.h: added an extra method to optionally let users stop recording once they have spoken.
        * page/SpeechInputClientListener.h: renamed a method.
        * page/SpeechInputListener.h: renamed a method.
2010-07-26  Satish Sampath  <satish@chromium.org>

        Reviewed by Steve Block.

        Add WebKit plumbing to connect speech requests and callbacks between WebCore and the embedder.
        https://bugs.webkit.org/show_bug.cgi?id=42367

        No new tests, the relevant LayoutTestController bindings and tests will be added in the next patch.

        * public/WebSpeechInputController.h: Added new interface, implemented by embedder and called by WebKit
        (WebKit::WebSpeechInputController::~WebSpeechInputController):
        * public/WebSpeechInputListener.h: Added new interface, implemented by WebKit and called by embedder.
        (WebKit::WebSpeechInputListener::~WebSpeechInputListener):
        * public/WebViewClient.h:
        (WebKit::WebViewClient::createSpeechInputClient): New method to get the embedder's speech input client interface.
        * src/SpeechInputClientImpl.cpp: Added new class, implementation of a two way connector between WebCore
        and the embedder for requests and responses.
        (WebKit::SpeechInputClientImpl::SpeechInputClientImpl):
        (WebKit::SpeechInputClientImpl::~SpeechInputClientImpl):
        (WebKit::SpeechInputClientImpl::startRecognition):
        (WebKit::SpeechInputClientImpl::stopRecording):
        (WebKit::SpeechInputClientImpl::didCompleteRecording):
        (WebKit::SpeechInputClientImpl::setRecognitionResult):
        (WebKit::SpeechInputClientImpl::didCompleteRecognition):
        * src/SpeechInputClientImpl.h: Added.
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl): Pass on the above mentioned speech input connector to WebCore.
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Mon, 26 Jul 2010 11:51:45 +0000 (11:51 +0000)]
2010-07-26  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] getImageData(): Single-pass RGB->BGR and un-premultiplication
        https://bugs.webkit.org/show_bug.cgi?id=42945

        Combine the two operations into a single loop over the pixel data.
        Yields a considerable FPS gain on http://www.semantix.gr/statue.html

        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::getImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 26 Jul 2010 11:21:47 +0000 (11:21 +0000)]
2010-07-26  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Web Inspector: make sure proxy objects are JSON-stringifiable.

        https://bugs.webkit.org/show_bug.cgi?id=42961

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix feature detection regexp
vestbo@webkit.org [Mon, 26 Jul 2010 11:12:43 +0000 (11:12 +0000)]
[Qt] Fix feature detection regexp

Reviewed by Simon Hausmann.

We were missing the last feature

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Mon, 26 Jul 2010 09:52:10 +0000 (09:52 +0000)]
Unreviewed.

[Qt] DRT sideeffect revealed by r63657
https://bugs.webkit.org/show_bug.cgi?id=42578

* platform/qt/Skipped: Add tests to the Skipped list until fix.
 - http/tests/xmlhttprequest/authorization-header.html
 - http/tests/xmlhttprequest/null-auth.php

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 26 Jul 2010 09:37:38 +0000 (09:37 +0000)]
2010-07-26  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Joseph Pecoraro.

        Inspector should remember resources sorting set by the user
        https://bugs.webkit.org/show_bug.cgi?id=19208

        Sorting options both for time and size graphs are memorized in a single property,
        which makes them possible to retrieve in a single message (e.g. useful for remote debugging).

        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.populateSidebar):
        (WebInspector.ResourcesPanel.prototype._settingsLoaded):
        (WebInspector.ResourcesPanel.prototype._loadSortOptions):
        (WebInspector.ResourcesPanel.prototype._loadSortOptionForGraph):
        (WebInspector.ResourcesPanel.prototype._graphSelected):
        (WebInspector.ResourcesPanel.prototype._changeSortingFunction):
        (WebInspector.ResourcesPanel.prototype._selectedOptionNameForGraph):
        (WebInspector.ResourcesPanel.prototype._doChangeSortingFunction):
        * inspector/front-end/Settings.js:
        (WebInspector.populateApplicationSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Use the default timeout interval for JS as the HTML tokenizer delay for setHtml()
hausmann@webkit.org [Mon, 26 Jul 2010 08:53:50 +0000 (08:53 +0000)]
[Qt] Use the default timeout interval for JS as the HTML tokenizer delay for setHtml()

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2009-10-30
Reviewed by Kenneth Rohde Christiansen.

This ensures that long-running JavaScript (for example due to a modal alert() dialog),
will not trigger a deferred load after only 500ms (the default tokenizer delay) while
still giving a reasonable timeout (10 seconds) to prevent deadlock.

https://bugs.webkit.org/show_bug.cgi?id=29381

JavaScriptCore:

* runtime/TimeoutChecker.h: Add getter for the timeout interval

WebKit/qt:

* Api/qwebframe.cpp: Document the behaviour
* WebCoreSupport/FrameLoaderClientQt.cpp: set the custom tokenizer delay for substitute loads
* tests/qwebframe/tst_qwebframe.cpp: Add test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-26 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 26 Jul 2010 08:29:21 +0000 (08:29 +0000)]
2010-07-26  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Chromium DevTools: refactor query params, add basic
        support for WebSocket-based backend.

        https://bugs.webkit.org/show_bug.cgi?id=42893

        * src/js/DevTools.js:
        (devtools.ToolsAgent.prototype.dispatchOnClient_):
        (WebInspector.loaded):
        (WebInspector.doLoadedDone):
        (devtools.domContentLoaded):
        * src/js/InspectorControllerImpl.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Redo fails after text node is split by SplitTextNodeCommand
rniwa@webkit.org [Mon, 26 Jul 2010 08:19:12 +0000 (08:19 +0000)]
WebCore: Redo fails after text node is split by SplitTextNodeCommand
https://bugs.webkit.org/show_bug.cgi?id=42941

Reviewed by Darin Adler.

The bug was caused by SplitTextNodeCommand not implementing doReapply.
Implemented doReapply and added insertText1AndTrimText2 to share the code between doApply and doReapply.

Test: editing/undo/redo-split-text-node.html
      editing/undo/redo-split-text-node-with-removal.html

* editing/SplitTextNodeCommand.cpp:
(WebCore::SplitTextNodeCommand::doApply): Calls executeApply.
(WebCore::SplitTextNodeCommand::doUnapply): Don't delete m_text1, which is later used in doReapply.
(WebCore::SplitTextNodeCommand::doReapply): Added.
(WebCore::SplitTextNodeCommand::insertText1AndTrimText2): Added.
* editing/SplitTextNodeCommand.h:

LayoutTests: Added a test that splits a text node by inserting a paragraph and applies inline style.
The test then ensures that the style is preserved after undos and redos.

Reviewed by Darin Adler.

Also added a test in which the text node is removed by the script after undo.

Redo fails after text node is split by SplitTextNodeCommand
https://bugs.webkit.org/show_bug.cgi?id=42941

* editing/undo/redo-split-text-node-expected.txt: Added.
* editing/undo/redo-split-text-node.html: Added.
* editing/undo/redo-split-text-with-removal-expected.txt: Added.
* editing/undo/redo-split-text-with-removal.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-25 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 26 Jul 2010 06:57:55 +0000 (06:57 +0000)]
2010-07-25  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
        https://bugs.webkit.org/show_bug.cgi?id=42326

        * platform/mac-wk2/Skipped: Removed all the tests from the list
        that were there only because they called dumpSelectionRect. Most of
        them pass now.
2010-07-25  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
        https://bugs.webkit.org/show_bug.cgi?id=42326

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        Added dumpSelectionRect.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
        (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this
        does nothing because its purpose is to change pixel test output and
        we do not have pixel tests implemented yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 26 Jul 2010 06:40:39 +0000 (06:40 +0000)]
2010-07-23  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        [GTK] media/media-can-play-mpeg-audio.html fails
        https://bugs.webkit.org/show_bug.cgi?id=42895

        Fixed advertizing of mp3, mpeg and mp4 mime-types in the player.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mimeTypeCache):

LayoutTests:

2010-07-23  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        [GTK] media/media-can-play-mpeg-audio.html fails
        https://bugs.webkit.org/show_bug.cgi?id=42895

        * platform/gtk/Skipped: Unskip fixed test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 26 Jul 2010 06:35:44 +0000 (06:35 +0000)]
2010-07-23  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        LayoutTests/media/media-document-audio-size.html failure
        https://bugs.webkit.org/show_bug.cgi?id=38376

        Advertize audio/x-wav along with audio/wav when appropriate,
        otherwise WebKit attempts to use a plugin to play the media.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mimeTypeCache):

LayoutTests:

2010-07-23  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        LayoutTests/media/media-document-audio-size.html failure
        https://bugs.webkit.org/show_bug.cgi?id=38376

        * platform/gtk/Skipped: Unskip fixed test on GTK port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-25 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 26 Jul 2010 06:13:56 +0000 (06:13 +0000)]
2010-07-25  Darin Adler  <darin@apple.com>

        Reviewed by Maciej Stachowiak.

        Need to support unsafe access console messages in WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=42320

        * platform/mac-wk2/Skipped: Since unsafe access console messages are
        working properly, moved the failing tests listed under this bug to
        other sections in the file based on the reason they are failing.
        Removed the tests that are passing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-25 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 26 Jul 2010 06:03:36 +0000 (06:03 +0000)]
2010-07-25  Darin Adler  <darin@apple.com>

        Reviewed by Maciej Stachowiak.

        WebKitTestRunner needs to support layoutTestController.keepWebHistory
        https://bugs.webkit.org/show_bug.cgi?id=42323

        * platform/mac-wk2/Skipped: Removed the tests that needed only keepWebHistory
        and computedStyleIncludingVisitedInfo. Moved the other tests in the
        keepWebHistory section of the file into the other appropriate lists.
2010-07-25  Darin Adler  <darin@apple.com>

        Reviewed by Maciej Stachowiak.

        WebKitTestRunner needs to support layoutTestController.keepWebHistory
        https://bugs.webkit.org/show_bug.cgi?id=42323

        Added keepWebHistory and computedStyleIncludingVisitedInfo.

        Also fixed misspellings of the word "receive".

        Also tweaked the names of some of the LayoutTestController members.

        * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
        Added support for a type named "object" that is passed and returns as
        a JSValueRef.

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        Added keepWebHistory and computedStyleIncludingVisitedInfo. Also
        put setAcceptsEditing up nearer the top.

        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::_didReceiveMessage): Fixed mispellings of receive.
        (WTR::InjectedBundle::initialize): Ditto.
        (WTR::InjectedBundle::didReceiveMessage): Ditto.
        (WTR::InjectedBundle::reset): Reset the state of visited links between
        tests. Also eliminated the unused argument to the LayoutTestController
        create function.
        (WTR::InjectedBundle::setShouldTrackVisitedLinks): Added.
        * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::shouldBeginEditing): Call shouldAllowEditing
        instead of acceptsEditing.
        (WTR::InjectedBundlePage::shouldEndEditing): Ditto.
        (WTR::InjectedBundlePage::shouldInsertNode): Ditto.
        (WTR::InjectedBundlePage::shouldInsertText): Ditto.
        (WTR::InjectedBundlePage::shouldDeleteRange): Ditto.
        (WTR::InjectedBundlePage::shouldChangeSelectedRange): Ditto.
        (WTR::InjectedBundlePage::shouldApplyStyle): Ditto.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::create): Removed uneeded argument.
        (WTR::LayoutTestController::LayoutTestController): Removed unneeded
        argument. Updated for rename of m_acceptsEditing to m_shouldAllowEditing.
        (WTR::LayoutTestController::numberOfActiveAnimations): Added some FIXMEs
        about the fact that this works on the main frame.
        (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
        (WTR::LayoutTestController::keepWebHistory): Added.
        (WTR::LayoutTestController::computedStyleIncludingVisitedInfo): Added.
        (WTR::JSObjectSetProperty): Added. Helper to make the function below
        cleaner.
        (WTR::LayoutTestController::makeWindowObject): Changed to use the
        overload of JSObjectSetProperty above.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Changes to
        match above.

        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::initialize): Fixed mispellings of receive.
        (WTR::TestController::_didReceiveMessageFromInjectedBundle): Ditto.
        (WTR::TestController::didReceiveMessageFromInjectedBundle): Ditto.
        * WebKitTestRunner/TestController.h: Ditto.
        * WebKitTestRunner/TestInvocation.cpp:
        (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Ditto.
        * WebKitTestRunner/TestInvocation.h: Ditto.
2010-07-25  Darin Adler  <darin@apple.com>

        Reviewed by Maciej Stachowiak.

        WebKitTestRunner needs to support layoutTestController.keepWebHistory
        https://bugs.webkit.org/show_bug.cgi?id=42323

        Added WKBundleSetShouldTrackVisitedLinks, WKBundleRemoveAllVisitedLinks,
        and WKBundleFrameGetComputedStyleIncludingVisitedInfo.

        Also fixed misspellings of the word "receive".

        * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
        (WKBundleSetShouldTrackVisitedLinks): Added.
        (WKBundleRemoveAllVisitedLinks): Added.
        * WebProcess/InjectedBundle/API/c/WKBundle.h: Added functions and
        fixed mispellings of receive.

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        (WKBundleFrameGetJavaScriptContext): Moved the code from here into WebFrame,
        to be consistent with the rest of the functions in this file.
        (WKBundleFrameGetComputedStyleIncludingVisitedInfo): Added.
        * WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Added
        WKBundleFrameGetComputedStyleIncludingVisitedInfo and tried to rearrange the
        file to be more logically ordered and grouped.

        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::InjectedBundle::setShouldTrackVisitedLinks): Added.
        (WebKit::InjectedBundle::removeAllVisitedLinks): Added.
        (WebKit::InjectedBundle::didReceiveMessage): Fixed mispellings of receive.
        * WebProcess/InjectedBundle/InjectedBundle.h: Ditto.

        * WebProcess/WebPage/WebFrame.cpp:
        (WebKit::WebFrame::jsContext): Added. Contains the code that used to be in
        WKBundleFrameGetJavaScriptContext.
        (WebKit::WebFrame::computedStyleIncludingVisitedInfo): Added.
        * WebProcess/WebPage/WebFrame.h: Ditto.

        * UIProcess/API/C/WKContext.h: Fixed misspellings of receive.
        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::didReceiveMessageFromInjectedBundle): Ditto.
        * UIProcess/WebContext.h: Ditto.
        * UIProcess/WebContextInjectedBundleClient.cpp:
        (WebKit::WebContextInjectedBundleClient::didReceiveMessageFromInjectedBundle): Ditto.
        * UIProcess/WebContextInjectedBundleClient.h: Ditto.
        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::forwardMessageToWebContext): Ditto.
        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::forwardMessageToInjectedBundle): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agosplitTextAt*IfNeed and splitTextElementAt*IfNeed need to be cleaned up
rniwa@webkit.org [Mon, 26 Jul 2010 04:10:14 +0000 (04:10 +0000)]
splitTextAt*IfNeed and splitTextElementAt*IfNeed need to be cleaned up
https://bugs.webkit.org/show_bug.cgi?id=42937

Reviewed by Kent Tamura.

Isolated the code to decide whether or not text node should be split into isValidCaretPositionInTextNode.
Moved the condition check out of *IfNeeded methods to applyRelativeFontStyleChange and applyInlineStyle.

No new tests added since this is a clean up.

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Uses isValidCaretPositionInTextNode.
(WebCore::ApplyStyleCommand::applyInlineStyle): Uses isValidCaretPositionInTextNode.
(WebCore::ApplyStyleCommand::splitTextAtStart): Renamed from splitTextAtStartIfNeeded.
(WebCore::ApplyStyleCommand::splitTextAtEnd): Renamed from splitTextAtEndIfNeeded.
(WebCore::ApplyStyleCommand::splitTextElementAtStart): Renamed from splitTextElementAtStartIfNeeded.
(WebCore::ApplyStyleCommand::splitTextElementAtEnd): Renamed from splitTextElementAtEndIfNeeded.
(WebCore::ApplyStyleCommand::isValidCaretPositionInTextNode): Returns true if the position lies within a text node.
* editing/ApplyStyleCommand.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-25 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Mon, 26 Jul 2010 04:01:03 +0000 (04:01 +0000)]
2010-07-25  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kent Tamura.

        [WINCE] Buildfix for JSC in release mode
        https://bugs.webkit.org/show_bug.cgi?id=42934

        * jsc.cpp: Don't use __try on WinCE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-25 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Mon, 26 Jul 2010 03:48:44 +0000 (03:48 +0000)]
2010-07-25  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kent Tamura.

        [WINCE] Buildfix for ImageBufferWince
        https://bugs.webkit.org/show_bug.cgi?id=42928

        * platform/graphics/wince/ImageBufferWince.cpp:
        (WebCore::):
        (WebCore::BufferedImage::draw): Pass through ColorSpace parameter.
        (WebCore::BufferedImage::drawPattern): Ditto.
        (WebCore::ImageBuffer::platformTransformColorSpace): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-25 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Mon, 26 Jul 2010 03:33:33 +0000 (03:33 +0000)]
2010-07-25  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kent Tamura.

        [WINCE] Buildfix for PopupMenuWin.cpp
        https://bugs.webkit.org/show_bug.cgi?id=42932

        Add #if !OS(WINCE) around unsupported window messages.

        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::show):
        (WebCore::PopupMenu::wndProc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 25 Jul 2010 21:51:04 +0000 (21:51 +0000)]
2010-07-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement adjustMathMLAttributes
        https://bugs.webkit.org/show_bug.cgi?id=42952

        Yay test progression.

        * html5lib/runner-expected-html5.txt:
2010-07-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement adjustMathMLAttributes
        https://bugs.webkit.org/show_bug.cgi?id=42952

        This is kind of mechanical overkill for adjusting one attribute name,
        but it's nice to use the same machinery as SVG.

        * html/HTMLTreeBuilder.cpp:
        * mathml/mathattrs.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 25 Jul 2010 21:36:32 +0000 (21:36 +0000)]
2010-07-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Functions supporting the legacy tree builder are confusing
        https://bugs.webkit.org/show_bug.cgi?id=42951

        This patch just inlines these functions into their one call site and
        removes the notImplemented() calls.  We thought we were going to grow
        these to support the new tree builder, but we took a different path.
        Previous to this patch, these functions were confusing because they
        looked like part of the new tree builder.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
        * html/HTMLTreeBuilder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 25 Jul 2010 20:05:54 +0000 (20:05 +0000)]
2010-07-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Recent HTML5 TreeBuilder Regression?  All canvas tests ASSERT
        https://bugs.webkit.org/show_bug.cgi?id=42948

        Remove ASSERT and replace with correct branch.  I put this ASSERT in
        to make sure we had test coverage for this branch.  I guess we do.  :)

        * html/HTMLConstructionSite.cpp:
        (WebCore::HTMLConstructionSite::attach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-25 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sun, 25 Jul 2010 15:46:53 +0000 (15:46 +0000)]
2010-07-25  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: check of jQuery object type prior to treating it as an array.

        https://bugs.webkit.org/show_bug.cgi?id=42946

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-25 Alexey Proskuryakov <ap@apple.com>
ap@apple.com [Sun, 25 Jul 2010 07:56:34 +0000 (07:56 +0000)]
2010-07-25  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=42193
        Support layoutTestController.dumpEditingDelegates in WebKitTestRunner

        Step 2 - add the rest of editing delegates.

        * platform/mac-wk2/Skipped: Changed the bug tracking why the tests are skipped - the delegates
        are now implemented, but one of them isn't called for some reason.
2010-07-25  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=42193
        Support layoutTestController.dumpEditingDelegates in WebKitTestRunner

        Step 2 - add the rest of editing delegates.

        * WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
        * WebProcess/InjectedBundle/API/c/WKBundleBase.h:
        Added enums for EditorInsertAction and EAffinity. Also added a dummy type for
        CSSStyleDeclaration - neither DumpRenderTree not WebKitTestRunner actually use that.

        * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
        * WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
        (WebKit::InjectedBundlePageEditorClient::shouldBeginEditing):
        (WebKit::InjectedBundlePageEditorClient::shouldEndEditing):
        (WebKit::InjectedBundlePageEditorClient::shouldInsertNode):
        (WebKit::InjectedBundlePageEditorClient::shouldInsertText):
        (WebKit::InjectedBundlePageEditorClient::shouldDeleteRange):
        (WebKit::InjectedBundlePageEditorClient::shouldChangeSelectedRange):
        (WebKit::InjectedBundlePageEditorClient::shouldApplyStyle):
        (WebKit::InjectedBundlePageEditorClient::didBeginEditing):
        (WebKit::InjectedBundlePageEditorClient::didEndEditing):
        (WebKit::InjectedBundlePageEditorClient::didChange):
        (WebKit::InjectedBundlePageEditorClient::didChangeSelection):
        * WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
        (WebKit::WebEditorClient::shouldDeleteRange):
        (WebKit::WebEditorClient::shouldEndEditing):
        (WebKit::WebEditorClient::shouldInsertNode):
        (WebKit::WebEditorClient::shouldInsertText):
        (WebKit::WebEditorClient::shouldChangeSelectedRange):
        (WebKit::WebEditorClient::shouldApplyStyle):
        (WebKit::WebEditorClient::didBeginEditing):
        (WebKit::WebEditorClient::respondToChangedContents):
        (WebKit::WebEditorClient::respondToChangedSelection):
        (WebKit::WebEditorClient::didEndEditing):
        Added remaining delagates that are needed for WebKitTestRunner.
2010-07-25  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=42193
        Support layoutTestController.dumpEditingDelegates in WebKitTestRunner

        Step 2 - add the rest of editing delegates.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::operator<<): Fixed to not crash when range is null.
        (WTR::InjectedBundlePage::InjectedBundlePage):
        (WTR::InjectedBundlePage::_shouldEndEditing):
        (WTR::InjectedBundlePage::_shouldInsertNode):
        (WTR::InjectedBundlePage::_shouldInsertText):
        (WTR::InjectedBundlePage::_shouldDeleteRange):
        (WTR::InjectedBundlePage::_shouldChangeSelectedRange):
        (WTR::InjectedBundlePage::_shouldApplyStyle):
        (WTR::InjectedBundlePage::_didBeginEditing):
        (WTR::InjectedBundlePage::_didEndEditing):
        (WTR::InjectedBundlePage::_didChange):
        (WTR::InjectedBundlePage::_didChangeSelection):
        (WTR::InjectedBundlePage::shouldEndEditing):
        (WTR::InjectedBundlePage::shouldInsertNode):
        (WTR::InjectedBundlePage::shouldInsertText):
        (WTR::InjectedBundlePage::shouldDeleteRange):
        (WTR::InjectedBundlePage::shouldChangeSelectedRange):
        (WTR::InjectedBundlePage::shouldApplyStyle):
        (WTR::InjectedBundlePage::didBeginEditing):
        (WTR::InjectedBundlePage::didEndEditing):
        (WTR::InjectedBundlePage::didChange):
        (WTR::InjectedBundlePage::didChangeSelection):
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-24 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Sun, 25 Jul 2010 05:24:22 +0000 (05:24 +0000)]
2010-07-24  Daniel Bates  <dbates@rim.com>

        Unreviewed, build fix when building with WML support.

        PageCache.cpp compile error when WML is enabled
        https://bugs.webkit.org/show_bug.cgi?id=40765

        Remove extraneous semicolon.

        Note, building with WML support enabled is broken
        even with this fix. See Bug #42943 for more details.

        * history/PageCache.cpp:
        (WebCore::PageCache::canCachePageContainingThisFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 25 Jul 2010 01:03:15 +0000 (01:03 +0000)]
2010-07-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Atomize strings used by the HTML5 tree builder
        https://bugs.webkit.org/show_bug.cgi?id=42875

        This is about a 1% improvement to the parsing benchmark.

        * html/HTMLTagNames.in:
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTagForInBody):
        (WebCore::HTMLTreeBuilder::processStartTag):
        (WebCore::HTMLTreeBuilder::processEndTagForInBody):
        (WebCore::HTMLTreeBuilder::processStartTagForInHead):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-24 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Sun, 25 Jul 2010 00:40:30 +0000 (00:40 +0000)]
2010-07-24  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Darin Adler.

        [MSVC] Ensure 4 byte alignment on ARM
        https://bugs.webkit.org/show_bug.cgi?id=42935

        * jit/JITStubs.h: Added #pragma pack(4) around JITStackFrame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-24 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Sun, 25 Jul 2010 00:08:56 +0000 (00:08 +0000)]
2010-07-24  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Darin Adler.

        [WINCE] Cleanup defines in Platform.h
        https://bugs.webkit.org/show_bug.cgi?id=42933

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-24 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Sat, 24 Jul 2010 23:33:20 +0000 (23:33 +0000)]
2010-07-24  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Darin Adler.

        Buildfix for !ENABLE(INSPECTOR) after r63891.
        https://bugs.webkit.org/show_bug.cgi?id=42925

        * bindings/js/ScriptValue.cpp: Added property svn:eol-style.
        * bindings/js/ScriptValue.h: Added property svn:eol-style.
        * inspector/ConsoleMessage.cpp: Added property svn:eol-style.
        * inspector/ConsoleMessage.h: Added property svn:eol-style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: need a layout test testing misspelled words in attributed strings
cfleizach@apple.com [Sat, 24 Jul 2010 22:36:25 +0000 (22:36 +0000)]
AX: need a layout test testing misspelled words in attributed strings
https://bugs.webkit.org/show_bug.cgi?id=42899

Reviewed by David Kilzer.

WebKitTools:

* DumpRenderTree/AccessibilityUIElement.cpp:
(attributedStringForRangeCallback):
(attributedStringRangeIsMisspelledCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):

LayoutTests:

* platform/mac/accessibility/misspelled-attributed-string-expected.txt: Added.
* platform/mac/accessibility/misspelled-attributed-string.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoediting/execCommand/hilitecolor.html and editing/style/remove-underline-from-styleshe...
rniwa@webkit.org [Sat, 24 Jul 2010 22:17:51 +0000 (22:17 +0000)]
editing/execCommand/hilitecolor.html and editing/style/remove-underline-from-stylesheet.html should be dumpAsMarkup tests
https://bugs.webkit.org/show_bug.cgi?id=42793

Reviewed by Darin Adler.

Converted the tests and removed the platform specific expected results.

* editing/execCommand/hilitecolor-expected.txt: Added.
* editing/execCommand/hilitecolor.html: Converted.
* editing/style/remove-underline-from-stylesheet-expected.txt: Converted.
* editing/style/remove-underline-from-stylesheet.html: Converted.
* platform/chromium-linux/editing/execCommand/hilitecolor-expected.checksum: Removed.
* platform/chromium-win/editing/execCommand/hilitecolor-expected.checksum: Removed.
* platform/chromium-win/editing/execCommand/hilitecolor-expected.png: Removed.
* platform/chromium-win/editing/execCommand/hilitecolor-expected.txt: Removed.
* platform/mac/editing/execCommand/hilitecolor-expected.checksum: Removed.
* platform/mac/editing/execCommand/hilitecolor-expected.png: Removed.
* platform/mac/editing/execCommand/hilitecolor-expected.txt: Removed.
* platform/qt/editing/execCommand/hilitecolor-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 24 Jul 2010 20:02:36 +0000 (20:02 +0000)]
2010-07-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Re-order whitespace checks in the tokenizer
        https://bugs.webkit.org/show_bug.cgi?id=42923

        This saves about 0.5% on the parsing benchmark.

        * html/HTMLTokenizer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-24 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Sat, 24 Jul 2010 18:48:42 +0000 (18:48 +0000)]
2010-07-24  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] tst_QWebFrame::callQtInvokable() fails
        https://bugs.webkit.org/show_bug.cgi?id=41065

        Converting JS objects to QVariantMaps was broken.
        This is a partial revert of <http://trac.webkit.org/changeset/61478>

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::convertValueToQVariant): Remove erroneous crash guard
        around JSObject::getPropertyNames()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 24 Jul 2010 17:33:12 +0000 (17:33 +0000)]
2010-07-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Save a per-character branch in the HTML parser
        https://bugs.webkit.org/show_bug.cgi?id=42921

        The parsing benchmark claims this is a wash, but it makes me feel
        better.

        * html/HTMLToken.h:
        (WebCore::HTMLToken::clear):
        (WebCore::HTMLToken::beginStartTag):
        (WebCore::HTMLToken::beginEndTag):
        (WebCore::HTMLToken::ensureIsCharacterToken):
        (WebCore::HTMLToken::beginComment):
        (WebCore::HTMLToken::beginDOCTYPE):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::bufferCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-24 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sat, 24 Jul 2010 15:06:54 +0000 (15:06 +0000)]
2010-07-24  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: chromium build fix.

        * src/ApplicationCacheHost.cpp:
        (WebCore::ApplicationCacheHost::fillResourceList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-24 Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
commit-queue@webkit.org [Sat, 24 Jul 2010 12:54:38 +0000 (12:54 +0000)]
2010-07-24  Riccardo Magliocchetti  <riccardo.magliocchetti@gmail.com>

        Reviewed by Xan Lopez.

        [GTK] Enable jit compilation on arm
        https://bugs.webkit.org/show_bug.cgi?id=42856

        Add missing bits to configure.ac to build the arm jit.
        Compile and tested on debian sid armel on a qemu vm.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Sat, 24 Jul 2010 04:17:12 +0000 (04:17 +0000)]
2010-07-23  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Darin Adler.

        Buildfix for !ENABLE(FILTERS) after r63531.
        https://bugs.webkit.org/show_bug.cgi?id=42914

        * rendering/RenderSVGContainer.cpp: Add missing header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Kavita Kanetkar <kkanetkar@chromium.org>
commit-queue@webkit.org [Sat, 24 Jul 2010 03:35:26 +0000 (03:35 +0000)]
2010-07-23  Kavita Kanetkar  <kkanetkar@chromium.org>

        Reviewed by Joseph Pecoraro.

        Implement remaining Inspector support for chrome's appcache
        https://bugs.webkit.org/show_bug.cgi?id=42426

        * inspector/InspectorApplicationCacheAgent.cpp:
        (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
        (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache):
        (WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):
        (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):
        * inspector/InspectorApplicationCacheAgent.h:
        (WebCore::InspectorController::connectFrontend):
        * loader/appcache/ApplicationCacheHost.cpp:
        (WebCore::ApplicationCacheHost::fillResourceList):
        (WebCore::ApplicationCacheHost::applicationCacheInfo):
        * loader/appcache/ApplicationCacheHost.h: Changed creation + update times to double and moved appcache info here from InspectorApplicationCacheAgent.h
        (WebCore::ApplicationCacheHost::CacheInfo::CacheInfo):
        (WebCore::ApplicationCacheHost::ResourceInfo::ResourceInfo):
2010-07-23  Kavita Kanetkar  <kkanetkar@chromium.org>

        Reviewed by Joseph Pecoraro.

        Implement remaining Inspector support for chrome's appcache
        https://bugs.webkit.org/show_bug.cgi?id=42426

        * src/ApplicationCacheHost.cpp: Plugging in chrome's appcache info.
        (WebCore::ApplicationCacheHost::applicationCacheInfo):
        (WebCore::ApplicationCacheHost::fillResourceList):
        * src/js/InspectorControllerImpl.js:
        (devtools.InspectorBackendImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Rafael Antognolli <antognolli@profusion.mobi>
commit-queue@webkit.org [Sat, 24 Jul 2010 01:48:39 +0000 (01:48 +0000)]
2010-07-23  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Cleanup glib support (make it optional)
        https://bugs.webkit.org/show_bug.cgi?id=42480

        Fixing support for compiling EFL port without glib.

        * cmake/FindGthread.cmake: Added.
        * cmake/OptionsEfl.cmake:
2010-07-23  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Cleanup glib support (make it optional)
        https://bugs.webkit.org/show_bug.cgi?id=42480

        Remove gobject/GRefPtr.cpp if not using soup/glib.

        * wtf/CMakeListsEfl.txt:
2010-07-23  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Cleanup glib support (make it optional)
        https://bugs.webkit.org/show_bug.cgi?id=42480

        No new tests, no new features added.
        Just add flags and directories for glib if necessary.
        Put some ifdefs on glib calls.

        * CMakeListsEfl.txt:
        * platform/graphics/cairo/FontPlatformDataCairo.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
2010-07-23  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Cleanup glib support (make it optional)
        https://bugs.webkit.org/show_bug.cgi?id=42480

        Just add glib flags and directories if necessary.

        * CMakeListsEfl.txt:
2010-07-23  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Cleanup glib support (make it optional)
        https://bugs.webkit.org/show_bug.cgi?id=42480

        Put some ifdefs on glib calls.

        * ewk/ewk_main.cpp:
        (ewk_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 James Robinson <jamesr@chromium.org>
jamesr@google.com [Sat, 24 Jul 2010 00:09:52 +0000 (00:09 +0000)]
2010-07-23  James Robinson  <jamesr@chromium.org>

        Reviewed by Dimitri Glazkov.

        CanvasRenderingContext2D has lots of style errors
        https://bugs.webkit.org/show_bug.cgi?id=42918

        CanvasRenderingContext2D.h and .cpp have lots of style errors.  I'm planning to post patches
        to both of these files soon, so to minimize merge conflicts and additional style violations
        it seems best to fix all of these errors in bulk before posting any functional changes.  In
        particular the header file is incorrectly indented so any correctly formatted addition will
        be out of place.

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
        (WebCore::CanvasRenderingContext2D::setFillStyle):
        (WebCore::CanvasRenderingContext2D::transform):
        (WebCore::CanvasRenderingContext2D::setTransform):
        (WebCore::CanvasRenderingContext2D::arcTo):
        (WebCore::CanvasRenderingContext2D::arc):
        (WebCore::validateRectForCanvas):
        (WebCore::CanvasRenderingContext2D::strokeRect):
        (WebCore::CanvasRenderingContext2D::drawImage):
        (WebCore::CanvasRenderingContext2D::createRadialGradient):
        (WebCore::CanvasRenderingContext2D::createPattern):
        (WebCore::CanvasRenderingContext2D::willDraw):
        (WebCore::CanvasRenderingContext2D::createImageData):
        (WebCore::CanvasRenderingContext2D::putImageData):
        (WebCore::CanvasRenderingContext2D::setFont):
        (WebCore::CanvasRenderingContext2D::drawTextInternal):
        * html/canvas/CanvasRenderingContext2D.h:
        (WebCore::CanvasRenderingContext2D::is2d):
        (WebCore::CanvasRenderingContext2D::getLineCap):
        (WebCore::CanvasRenderingContext2D::getLineJoin):
        (WebCore::CanvasRenderingContext2D::state):
        (WebCore::CanvasRenderingContext2D::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
mrowe@apple.com [Sat, 24 Jul 2010 00:07:49 +0000 (00:07 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 24 Jul 2010 00:03:53 +0000 (00:03 +0000)]
2010-07-23  Adam Barth  <abarth@webkit.org>

        Remove FIXME that we already fixed.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 23 Jul 2010 22:34:29 +0000 (22:34 +0000)]
2010-07-23  James Robinson  <jamesr@chromium.org>

        Unreviewed.  Add chromium expectations for new tests.

        * platform/chromium-mac/tables/layering/paint-test-layering-1-expected.checksum:
        * platform/chromium-mac/tables/layering/paint-test-layering-1-expected.png:
        * platform/chromium-mac/tables/layering/paint-test-layering-2-expected.checksum:
        * platform/chromium-mac/tables/layering/paint-test-layering-2-expected.png:
        * platform/chromium-win/tables/layering: Added.
        * platform/chromium-win/tables/layering/paint-test-layering-1-expected.checksum: Added.
        * platform/chromium-win/tables/layering/paint-test-layering-1-expected.png: Added.
        * platform/chromium-win/tables/layering/paint-test-layering-1-expected.txt: Added.
        * platform/chromium-win/tables/layering/paint-test-layering-2-expected.checksum: Added.
        * platform/chromium-win/tables/layering/paint-test-layering-2-expected.png: Added.
        * platform/chromium-win/tables/layering/paint-test-layering-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-24 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 23 Jul 2010 22:17:56 +0000 (22:17 +0000)]
2010-06-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        Move more form submission logic into FormSubmission.
        https://bugs.webkit.org/show_bug.cgi?id=41110

        Two major moves:
        * Fold HTMLFormElement::prepareFormSubmission into FormSubmission::create
        * Move non-static (non-FormData-building) methods of FormDataBuilder
            to FormSubmission::Attributes.

        Mechanical moving, no change in behavior, so no new tests.

        * WebCore.xcodeproj/project.pbxproj: Gave FormDataBuilder.h "project" and
            FormSubmission.h "private" visibility.
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::submit): Changed to use FormSubmission::create.
        (WebCore::HTMLFormElement::parseMappedAttribute): Changed to use m_attributes.
        * html/HTMLFormElement.h:
        (WebCore::HTMLFormElement::enctype): Ditto.
        (WebCore::HTMLFormElement::encoding): Ditto.
        (WebCore::HTMLFormElement::acceptCharset): Ditto.
        * loader/FormSubmission.cpp:
        (WebCore::generateFormDataIdentifier): Moved from HTMLFormElement.
        (WebCore::appendMailtoPostFormDataToURL): Ditto.
        (WebCore::FormSubmission::Attributes::parseAction): Moved from FormDataBuilder.
        (WebCore::FormSubmission::Attributes::parseEncodingType): Ditto.
        (WebCore::FormSubmission::Attributes::parseMethodType): Ditto.
        (WebCore::FormSubmission::FormSubmission): Made inline.
        (WebCore::FormSubmission::create): Added logic that used to be in
            HTMLFormElement::prepareFormSubmission.
        * loader/FormSubmission.h:
        (WebCore::FormSubmission::):
        (WebCore::FormSubmission::Attributes::Attributes): Added new class.
        (WebCore::FormSubmission::Attributes::method): Moved from FormDataBuilder.
        (WebCore::FormSubmission::Attributes::isMultiPartForm): Ditto.
        (WebCore::FormSubmission::Attributes::action): Ditto.
        (WebCore::FormSubmission::Attributes::target): Ditto.
        (WebCore::FormSubmission::Attributes::setTarget): Ditto.
        (WebCore::FormSubmission::Attributes::encodingType): Ditto.
        (WebCore::FormSubmission::Attributes::acceptCharset): Ditto.
        (WebCore::FormSubmission::Attributes::setAcceptCharset): Ditto.
        (WebCore::FormSubmission::target): Ditto.
        (WebCore::FormSubmission::contentType): Const-ified return type.
        (WebCore::FormSubmission::boundary): Ditto.
        * platform/network/FormDataBuilder.cpp:
        (WebCore::FormDataBuilder::encodingFromAcceptCharset): Renamed method for clarity,
            made it use param instead of a class member.
        * platform/network/FormDataBuilder.h:
        (WebCore::FormDataBuilder::FormDataBuilder): Made constructor private.
        * wml/WMLGoElement.cpp: Changed to use FormSubmision::Attributes.
        * wml/WMLGoElement.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 23 Jul 2010 22:14:02 +0000 (22:14 +0000)]
2010-07-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTML5 Parser: document.write in a asynchronous script which is specified to load before page finish blows away document
        https://bugs.webkit.org/show_bug.cgi?id=42365

        * http/tests/misc/write-from-dom-script-expected.txt: Added.
        * http/tests/misc/write-from-dom-script.html: Added.
          - Test the scenario where a script added to the DOM asynchronously
            while the nesting level is >0.  It's supposed to have its calls to
            document.write blocked.
        * http/tests/misc/write-while-waiting.html:
          - Writes are only prevented from scripts that are added to the DOM.
            Scripts that run via setTimeout do not have their writes blocked.
2010-07-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTML5 Parser: document.write in a asynchronous script which is specified to load before page finish blows away document
        https://bugs.webkit.org/show_bug.cgi?id=42365

        This patch implements the changes Ian made to HTML5 to address these
        issues.  Let's try it and see how well it works.

        Test: http/tests/misc/write-from-dom-script.html

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::write):
        * dom/Document.h:
        (WebCore::Document::writeDisabled):
        (WebCore::Document::setWriteDisabled):
        * dom/DocumentParser.h:
        (WebCore::DocumentParser::hasInsertionPoint):
        * dom/ScriptElement.cpp:
        (WebCore::ScriptElement::insertedIntoDocument):
        (WebCore::ScriptElementData::ScriptElementData):
        (WebCore::ScriptElementData::evaluateScript):
        * dom/ScriptElement.h:
        (WebCore::ScriptElementData::writeDisabled):
        (WebCore::ScriptElementData::setWriteDisabled):
        * html/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::hasInsertionPoint):
        (WebCore::HTMLDocumentParser::insert):
        * html/HTMLDocumentParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/42911> Update ruby tools to work with shallow framework bundles
ddkilzer@apple.com [Fri, 23 Jul 2010 21:59:13 +0000 (21:59 +0000)]
<webkit.org/b/42911> Update ruby tools to work with shallow framework bundles

Reviewed by Mark Rowe.

* Scripts/check-for-inappropriate-files-in-framework: Added
check for the SHALLOW_BUNDLE environment variable so that the
script will work with iOS WebKit builds.
* Scripts/check-for-webkit-framework-include-consistency: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Fri, 23 Jul 2010 21:46:54 +0000 (21:46 +0000)]
2010-07-23  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        [WINCE] Buildfix for PopupMenuWin.cpp
        https://bugs.webkit.org/show_bug.cgi?id=42906

        Use correct API for BitmapInfo landed in r63944.

        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 23 Jul 2010 20:29:36 +0000 (20:29 +0000)]
2010-07-23  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed. Land the expectation for win.

        Backslash isn't transcoded in <input>
        https://bugs.webkit.org/show_bug.cgi?id=42878

        * platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 fsamuel@chromium.org <fsamuel@chromium.org>
jamesr@google.com [Fri, 23 Jul 2010 20:22:29 +0000 (20:22 +0000)]
2010-07-23  fsamuel@chromium.org  <fsamuel@chromium.org>

        Reviewed by David Hyatt.

        Updated table painting to draw cell layers in the correct order.

        Table Cell Layering
        https://bugs.webkit.org/show_bug.cgi?id=40775

        Tests: tables/layering/paint-test-layering-1.html
               tables/layering/paint-test-layering-2.html

        * accessibility/AccessibilityTable.cpp:
        (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
        (WebCore::AccessibilityTable::addChildren):
        (WebCore::AccessibilityTable::cellForColumnAndRow):
        * accessibility/AccessibilityTableCell.cpp:
        (WebCore::AccessibilityTableCell::titleUIElement):
        * accessibility/AccessibilityTableColumn.cpp:
        (WebCore::AccessibilityTableColumn::headerObjectForSection):
        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::recalcColumn):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::splitColumn):
        (WebCore::RenderTable::calcBorderLeft):
        (WebCore::RenderTable::calcBorderRight):
        (WebCore::RenderTable::cellAbove):
        (WebCore::RenderTable::cellBelow):
        (WebCore::RenderTable::cellBefore):
        (WebCore::RenderTable::cellAfter):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::RenderTableSection):
        (WebCore::RenderTableSection::ensureRows):
        (WebCore::RenderTableSection::addCell):
        (WebCore::RenderTableSection::setCellWidths):
        (WebCore::RenderTableSection::calcRowHeight):
        (WebCore::RenderTableSection::layoutRows):
        (WebCore::RenderTableSection::calcOuterBorderTop):
        (WebCore::RenderTableSection::calcOuterBorderBottom):
        (WebCore::RenderTableSection::calcOuterBorderLeft):
        (WebCore::RenderTableSection::calcOuterBorderRight):
        (WebCore::RenderTableSection::firstLineBoxBaseline):
        (WebCore::compareCellPositions):
        (WebCore::RenderTableSection::paintCell):
        (WebCore::RenderTableSection::paintObject):
        (WebCore::RenderTableSection::numColumns):
        (WebCore::RenderTableSection::appendColumn):
        (WebCore::RenderTableSection::splitColumn):
        (WebCore::RenderTableSection::nodeAtPoint):
        * rendering/RenderTableSection.h:
        (WebCore::RenderTableSection::CellStruct::CellStruct):
        (WebCore::RenderTableSection::CellStruct::primaryCell):
        (WebCore::RenderTableSection::CellStruct::hasCells):
        (WebCore::RenderTableSection::primaryCellAt):
2010-07-23  fsamuel@chromium.org  <fsamuel@chromium.org>

        Reviewed by David Hyatt.

        Updated table painting to draw cell layers in the correct order.

        Table Cell Layering
        https://bugs.webkit.org/show_bug.cgi?id=40775

        * platform/chromium-linux/tables/layering/paint-test-layering-1-expected.checksum: Added.
        * platform/chromium-linux/tables/layering/paint-test-layering-1-expected.png: Added.
        * platform/chromium-linux/tables/layering/paint-test-layering-1-expected.txt: Added.
        * platform/chromium-linux/tables/layering/paint-test-layering-2-expected.checksum: Added.
        * platform/chromium-linux/tables/layering/paint-test-layering-2-expected.png: Added.
        * platform/chromium-linux/tables/layering/paint-test-layering-2-expected.txt: Added.
        * platform/chromium-mac/tables/layering/paint-test-layering-1-expected.checksum: Added.
        * platform/chromium-mac/tables/layering/paint-test-layering-1-expected.png: Added.
        * platform/chromium-mac/tables/layering/paint-test-layering-1-expected.txt: Added.
        * platform/chromium-mac/tables/layering/paint-test-layering-2-expected.checksum: Added.
        * platform/chromium-mac/tables/layering/paint-test-layering-2-expected.png: Added.
        * platform/chromium-mac/tables/layering/paint-test-layering-2-expected.txt: Added.
        * platform/gtk/tables/layering/paint-test-layering-1-expected.checksum: Added.
        * platform/gtk/tables/layering/paint-test-layering-1-expected.png: Added.
        * platform/gtk/tables/layering/paint-test-layering-1-expected.txt: Added.
        * platform/gtk/tables/layering/paint-test-layering-2-expected.checksum: Added.
        * platform/gtk/tables/layering/paint-test-layering-2-expected.png: Added.
        * platform/gtk/tables/layering/paint-test-layering-2-expected.txt: Added.
        * platform/mac/tables/layering/paint-test-layering-1-expected.checksum: Added.
        * platform/mac/tables/layering/paint-test-layering-1-expected.png: Added.
        * platform/mac/tables/layering/paint-test-layering-1-expected.txt: Added.
        * platform/mac/tables/layering/paint-test-layering-2-expected.checksum: Added.
        * platform/mac/tables/layering/paint-test-layering-2-expected.png: Added.
        * platform/mac/tables/layering/paint-test-layering-2-expected.txt: Added.
        * tables/layering/paint-test-layering-1.html: Added.
        * tables/layering/paint-test-layering-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Fri, 23 Jul 2010 20:16:58 +0000 (20:16 +0000)]
2010-07-23  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        [WINCE] Buildfix for Path.h
        https://bugs.webkit.org/show_bug.cgi?id=42904

        * platform/graphics/Path.h: Add missing typedef PlatformPath.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Fri, 23 Jul 2010 19:51:56 +0000 (19:51 +0000)]
2010-07-23  Stephen White  <senorblanco@chromium.org>

        Unreviewed; chromium test expectations fix.

        * platform/chromium-win/fast/borders/different-color-borders-expected.checksum: Added.
        * platform/chromium-win/fast/borders/different-color-borders-expected.png: Added.
        * platform/chromium-win/fast/borders/different-color-borders-expected.txt: Added.
        New baseline for new test.
        * platform/chromium/test_expectations.txt:
        Remove passing tests from expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 23 Jul 2010 19:08:42 +0000 (19:08 +0000)]
2010-07-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Reserve capacity for attributes
        https://bugs.webkit.org/show_bug.cgi?id=42877

        This is about a 1.7% improvement to the parsing benchmark.

        * html/HTMLToken.h:
        (WebCore::AtomicHTMLToken::AtomicHTMLToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 23 Jul 2010 18:54:03 +0000 (18:54 +0000)]
2010-07-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Inline HTMLElementStack::top
        https://bugs.webkit.org/show_bug.cgi?id=42879

        According to sampling, HTMLElementStack::top is the hotest function in
        the treebuilder.  Inlining it is about a 0.3% improvement to the
        parsing benchmark.  This squares with how often it occurs in samples.

        * html/HTMLElementStack.cpp:
        * html/HTMLElementStack.h:
        (WebCore::HTMLElementStack::top):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Fri, 23 Jul 2010 18:38:22 +0000 (18:38 +0000)]
2010-07-23  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        [WINCE] Buildfix for GraphicsContext
        https://bugs.webkit.org/show_bug.cgi?id=42888

        Use AffineTransform insted of TransformationMatrix and
        add ColorSpace parameter to the drawBitmap methods.

        * platform/graphics/GraphicsContext.h:
        * platform/graphics/wince/GraphicsContextWince.cpp:
        (WebCore::GraphicsContext::affineTransform):
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::drawBitmap):
        (WebCore::GraphicsContext::drawBitmapPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Rafael Antognolli <antognolli@profusion.mobi>
commit-queue@webkit.org [Fri, 23 Jul 2010 18:17:35 +0000 (18:17 +0000)]
2010-07-23  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Add support for using libcurl network backend.
        https://bugs.webkit.org/show_bug.cgi?id=42286

        Instead of just libsoup, the EFL port now can use libcurl backend.
        This is a step in the direction of removing dependency on glib. Just
        need to pass the option -DNETWORK_BACKEND=curl to cmake in order to
        enable it.

        * cmake/OptionsEfl.cmake:
2010-07-23  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Add support for using libcurl network backend.
        https://bugs.webkit.org/show_bug.cgi?id=42286

        Add files and flags for soup/curl specific backend being
        used.
        Put some ifdefs around soup/glib calls.

        No new tests, no new features implemented.

        * CMakeListsEfl.txt:
        * platform/efl/FileSystemEfl.cpp:
        (WebCore::fileSystemRepresentation):
2010-07-23  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Add support for using libcurl network backend.
        https://bugs.webkit.org/show_bug.cgi?id=42286

        Just add soup/curl directories and flags for the specific
        backend being used.

        * CMakeLists.txt:
        * CMakeListsEfl.txt:
2010-07-23  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Add support for using libcurl network backend.
        https://bugs.webkit.org/show_bug.cgi?id=42286

        Put some ifdefs around soup calls.

        * ewk/ewk_cookies.cpp:
        (ewk_cookies_file_set):
        (ewk_cookies_clear):
        (ewk_cookies_get_all):
        (ewk_cookies_cookie_del):
        (ewk_cookies_cookie_free):
        (ewk_cookies_policy_set):
        (ewk_cookies_policy_get):
        * ewk/ewk_main.cpp:
        (ewk_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 23 Jul 2010 17:47:54 +0000 (17:47 +0000)]
2010-07-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add fast-reject path for InputStreamPreprocessor::peek
        https://bugs.webkit.org/show_bug.cgi?id=42881

        This is about a 2.5% speedup on the parsing benchmark.

        * html/HTMLTokenizer.h:
        (WebCore::HTMLTokenizer::InputStreamPreprocessor::peek):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Hans Wennborg <hans@chromium.org>
commit-queue@webkit.org [Fri, 23 Jul 2010 17:27:39 +0000 (17:27 +0000)]
2010-07-23  Hans Wennborg  <hans@chromium.org>

        Reviewed by Ojan Vafai.

        Rebaseline fast/dom/prototype-inheritance.html for chromium
        https://bugs.webkit.org/show_bug.cgi?id=42824

        Since Chromium revision 53317, ENABLE_DEVICE_ORIENTATION is enabled,
        which means window.DeviceOrientationEvent will show up
        in this layout test.

        * platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt:
        * platform/chromium-win/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Fri, 23 Jul 2010 17:11:11 +0000 (17:11 +0000)]
2010-07-23  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        [WINCE] Merge PasteboardWince.cpp into PasteboardWin.cpp
        https://bugs.webkit.org/show_bug.cgi?id=42885

        Make PasteboardWin more portable and remove the global namespace prefix
        from GlobalLock/GlobalUnlock, since they are only macros on WinCE.

        * platform/win/PasteboardWin.cpp:
        (WebCore::PasteboardOwnerWndProc):
        (WebCore::Pasteboard::Pasteboard):
        (WebCore::Pasteboard::plainText):
        (WebCore::Pasteboard::documentFragment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Fri, 23 Jul 2010 16:41:58 +0000 (16:41 +0000)]
2010-07-23  Justin Schuh  <jschuh@chromium.org>

        Unreviewed, rolling out r63925.
        http://trac.webkit.org/changeset/63925
        https://bugs.webkit.org/show_bug.cgi?id=42858

        Introduced a regression in history state.

        * page/History.cpp:
        (WebCore::History::urlForState):
2010-07-23  Justin Schuh  <jschuh@chromium.org>

        Unreviewed, rolling out r63925.
        http://trac.webkit.org/changeset/63925
        https://bugs.webkit.org/show_bug.cgi?id=42858

        Introduced a regression in history state.

        * fast/history/history-replace-illegal-expected.txt: Removed.
        * fast/history/history-replace-illegal.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 23 Jul 2010 16:26:15 +0000 (16:26 +0000)]
2010-07-23  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed build fix.

        Fix make dist by aligning the source list with currently used headers.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Fri, 23 Jul 2010 16:25:30 +0000 (16:25 +0000)]
2010-07-23  Justin Schuh  <jschuh@chromium.org>

        Unreviewed, rolling out r63959.
        http://trac.webkit.org/changeset/63959
        https://bugs.webkit.org/show_bug.cgi?id=42884

        63925 introduced a regression and is being reverted.

        * platform/chromium-mac/fast/history/history-replace-illegal-expected.txt: Removed.
        * platform/chromium-win/fast/history/history-replace-illegal-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Fri, 23 Jul 2010 16:24:42 +0000 (16:24 +0000)]
2010-07-23  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        [WINCE] Implement TCSpinLock.
        https://bugs.webkit.org/show_bug.cgi?id=41792

        Implement the SpinLock with InterlockedExchange from the Windows API.

        * wtf/TCSpinLock.h:
        (TCMalloc_SpinLock::Lock):
        (TCMalloc_SpinLock::Unlock):
        (TCMalloc_SpinLock::IsHeld):
        (TCMalloc_SpinLock::Init):
        (TCMalloc_SlowLock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-23 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
commit-queue@webkit.org [Fri, 23 Jul 2010 16:10:51 +0000 (16:10 +0000)]
2010-07-23  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        QScriptValue::equals benchmark crash fix.

        Patch changes QScriptValue::equals implementation to cover
        more edge cases.

        Problem exposes an issue in our autotests (all values got
        bound to an engine too fast - bug 42366).

        [Qt] QScriptValue::equals asserts
        https://bugs.webkit.org/show_bug.cgi?id=42363

        * api/qscriptvalue_p.h:
        (QScriptValuePrivate::equals):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63980 268f45cc-cd09-0410-ab3c-d52691b4dbfc