WebKit-https.git
7 years ago[BlackBerry] JavaScriptVariant can crash when operator= is called with itself
commit-queue@webkit.org [Wed, 5 Sep 2012 20:58:54 +0000 (20:58 +0000)]
[BlackBerry] JavaScriptVariant can crash when operator= is called with itself
https://bugs.webkit.org/show_bug.cgi?id=95859

Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-09-05
Reviewed by George Staikos.

* Api/JavaScriptVariant.cpp:
(BlackBerry::WebKit::JavaScriptVariant::operator=):
When JavaScriptVariant contains a string and operator= is
called with itself the memory will be free'd in 'this' and
then a copy will be attempted from 'that' resulting in a crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactored callee access in the DFG to support it in the general case
ggaren@apple.com [Wed, 5 Sep 2012 20:50:22 +0000 (20:50 +0000)]
Refactored callee access in the DFG to support it in the general case
https://bugs.webkit.org/show_bug.cgi?id=95887

Reviewed by Phil Pizlo and Gavin Barraclough.

To support named function expressions, the DFG needs to understand the
callee register being used in arbitrary expressions, and not just
create_this.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::getCallee): Remap access to the callee register
into a GetCallee node. Otherwise, we get confused and think we have a
negatively indexed argument.

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand): Inlining also
needs to remap, but to the callee in the inline frame, and not the caller's
callee.

(JSC::DFG::ByteCodeParser::parseBlock): Since we support the callee in
the general case now, there's no need to handle it in a special way for
create_this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIgnore-metrics includes scroll offsets.
allan.jensen@nokia.com [Wed, 5 Sep 2012 20:48:23 +0000 (20:48 +0000)]
Ignore-metrics includes scroll offsets.
https://bugs.webkit.org/show_bug.cgi?id=95845

Reviewed by Dirk Pranke.

Strip scroll-offsets the same way scroll-height and scroll-width is stripped.

* Scripts/old-run-webkit-tests:
(stripMetrics):
* Scripts/webkitpy/layout_tests/port/driver.py:
(DriverOutput):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMore fixes for String::operator+=() on Mac
benjamin@webkit.org [Wed, 5 Sep 2012 20:31:57 +0000 (20:31 +0000)]
More fixes for String::operator+=() on Mac
https://bugs.webkit.org/show_bug.cgi?id=95880

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-05
Reviewed by Adam Barth.

Source/WebCore:

Followup for r127574, I forgot some use of strings.

* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getShorthandValue): Use String builder to construct the shorthand.

Source/WebKit/mac:

* WebView/WebRenderLayer.mm:
(+[WebRenderLayer nameForLayer:]): Use StringBuilder to concatenate the class names
efficiently.
* WebView/WebView.mm:
(+[WebView _decodeData:]): This is a legitimate use of String::append(), there
is no other concatenation done on that string.

Source/WebKit2:

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::createInspectorPage): This is a legitimate use of append(),
there is no other concatenation outside that branch.
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::parseRFC822HeaderFields): Use string operators instead of +=.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::userAgent): Another legitimate use of append().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Put webcore_platform_files in separate gyp target instead of relying on...
jamesr@google.com [Wed, 5 Sep 2012 19:46:55 +0000 (19:46 +0000)]
[chromium] Put webcore_platform_files in separate gyp target instead of relying on exclusion patterns
https://bugs.webkit.org/show_bug.cgi?id=95876

Reviewed by Tony Chang.

This puts the list of WebCore/platform files in a webcore_platform_files gyp variable instead of filtering by
path out of webcore_files. This simplifies the .gyp a bit and makes it possible to split this target up further.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r127629.
jamesr@google.com [Wed, 5 Sep 2012 19:35:43 +0000 (19:35 +0000)]
Unreviewed, rolling out r127629.
http://trac.webkit.org/changeset/127629
https://bugs.webkit.org/show_bug.cgi?id=95876

Broke build

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Put webcore_platform_files in separate gyp target instead of relying on...
jamesr@google.com [Wed, 5 Sep 2012 19:20:34 +0000 (19:20 +0000)]
[chromium] Put webcore_platform_files in separate gyp target instead of relying on exclusion patterns
https://bugs.webkit.org/show_bug.cgi?id=95876

Reviewed by Tony Chang.

This puts the list of WebCore/platform files in a webcore_platform_files gyp variable instead of filtering by
path out of webcore_files. This simplifies the .gyp a bit and makes it possible to split this target up further.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Rotation and then reload causes less sized webpage (PR 190469)
leoyang@rim.com [Wed, 5 Sep 2012 19:17:30 +0000 (19:17 +0000)]
[BlackBerry] Rotation and then reload causes less sized webpage (PR 190469)
https://bugs.webkit.org/show_bug.cgi?id=95870

Reviewed by George Staikos.
Reviewed internally by Jacky Jiang.

Use the new zoom to fit scale if the page was zoomed to fit initial scale
When a page is reloaded the layout size may be changed. So the contents
size on which the initial scale depends may be changed. Use the new initial
scale in this case to make sure the page will be zoomed to correct scale.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::restoreViewState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Slider progress bar goes crazy with negative ranges
commit-queue@webkit.org [Wed, 5 Sep 2012 19:14:48 +0000 (19:14 +0000)]
[EFL] Slider progress bar goes crazy with negative ranges
https://bugs.webkit.org/show_bug.cgi?id=95753

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Now the calculation of what the current value represents in terms
of progress (from 0 to 1) is correctly done.

Test: fast/forms/range/input-range-progress-indicator.html

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):

LayoutTests:

Added ref test to check if rendering results of sliders using
negative value ranges are coherent.

* fast/forms/range/input-range-progress-indicator-expected.html: Added.
* fast/forms/range/input-range-progress-indicator.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove use of JSCell::classInfoOffset() from virtualForThunkGenerator
mhahnenberg@apple.com [Wed, 5 Sep 2012 19:07:35 +0000 (19:07 +0000)]
Remove use of JSCell::classInfoOffset() from virtualForThunkGenerator
https://bugs.webkit.org/show_bug.cgi?id=95821

Reviewed by Oliver Hunt.

We can replace the load of the ClassInfo from the object with a load from the Structure.

* dfg/DFGThunks.cpp:
(JSC::DFG::virtualForThunkGenerator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove getRenderStyleForStrike from PlatformSupport
pilgrim@chromium.org [Wed, 5 Sep 2012 19:04:08 +0000 (19:04 +0000)]
[Chromium] Remove getRenderStyleForStrike from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=95363

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

* Platform.gypi:
* chromium/public/linux/WebFontInfo.h: Added.
(WebKit):
(WebFontInfo):
* chromium/public/linux/WebFontRenderStyle.h: Added.
(WebKit):

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::operator==):
(WebCore::FontPlatformData::getRenderStyleForStrike):
(WebCore):
(WebCore::FontPlatformData::querySystemForRenderStyle):
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(FontPlatformData):

Source/WebKit/chromium:

* public/linux/WebFontInfo.h:
* public/linux/WebFontRenderStyle.h:
* src/PlatformSupport.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable/disable composited scrolling based on overflow
commit-queue@webkit.org [Wed, 5 Sep 2012 18:53:29 +0000 (18:53 +0000)]
Enable/disable composited scrolling based on overflow
https://bugs.webkit.org/show_bug.cgi?id=95323

Patch by Sami Kyostila <skyostil@google.com> on 2012-09-05
Reviewed by Simon Fraser.

Source/WebCore:

When an overflow:{auto,overlay} and -webkit-overflow-scrolling:touch
element gains or loses overflow, we should correspondingly enable and
disable composited scrolling depending on whether the element can be
scrolled or not.

The previous logic in RenderLayer::usesCompositedScrolling() already
checked for actual overflow, but we also need to recompute the
compositing requirements when the amount of overflow changes during
layout. Additionally, layers using composited scrolling are marked as
self-painting to ensure they are always promoted to composited layers
when needed.

Test: compositing/overflow/overflow-auto-with-touch-toggle.html

Note that the behavior for maintaining a stacking context even without
the presense of overflow is covered by platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):

LayoutTests:

Added a new test for making sure composited scrolling is enabled when overflow
is introduced.

Note that this test will pass only if OVERFLOW_SCROLLING is enabled.

* compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Added.
* compositing/overflow/overflow-auto-with-touch-toggle.html: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed: WebInspector: remove accidentally committed speed test.
loislo@chromium.org [Wed, 5 Sep 2012 18:40:37 +0000 (18:40 +0000)]
Unreviewed: WebInspector: remove accidentally committed speed test.

* tests/MemoryInstrumentationTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed test fix.
zandobersek@gmail.com [Wed, 5 Sep 2012 18:33:47 +0000 (18:33 +0000)]
Unreviewed test fix.

Including a plugin source file into the build that was added in r127595.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shaders] Update custom filter tests to use the new security model
commit-queue@webkit.org [Wed, 5 Sep 2012 18:26:57 +0000 (18:26 +0000)]
[CSS Shaders] Update custom filter tests to use the new security model
https://bugs.webkit.org/show_bug.cgi?id=95760

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-09-05
Reviewed by Dirk Schulze.

This patch updates the custom filter tests to not sample u_texture and not write
to gl_FragColor. Now, the tests use the new security model by writing to
css_MixColor and indirectly blending with the DOM element texture.

This patch prepares us to remove direct DOM texture access via "u_texture":
https://bugs.webkit.org/show_bug.cgi?id=93871

* css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png:
* css3/filters/custom/custom-filter-shader-cache-expected.png:
* css3/filters/custom/custom-filter-shader-cache.html:
    Use the CSS mix function with the updated color-offset.fs.
* css3/filters/custom/effect-color-check-expected.png:
* css3/filters/custom/effect-color-check.html:
    Use the CSS mix function with the updated color-fill.fs.
* css3/filters/custom/effect-custom-combined-missing-expected.png:
* css3/filters/custom/effect-custom-combined-missing.html:
    Use the CSS mix function with the updated color-offset.fs.
* css3/filters/custom/effect-custom-expected.png:
* css3/filters/custom/effect-custom-parameters-expected.png:
* css3/filters/custom/effect-custom-parameters.html:
    Use the mix-color.fs shader instead of color-offset-parameters.fs.
* css3/filters/custom/effect-custom.html:
    Use the CSS mix function with the updated color-offset.fs.
* css3/filters/custom/filter-repaint-custom-clipped-expected.png:
* css3/filters/custom/filter-repaint-custom-clipped.html:
    Use the mix-color.fs shader instead of color-add.fs.
* css3/filters/custom/filter-repaint-custom-expected.png:
* css3/filters/custom/filter-repaint-custom-rotated-expected.png:
* css3/filters/custom/filter-repaint-custom-rotated.html:
    Use the mix-color.fs shader instead of color-add.fs. Fix a small typo in a comment.
* css3/filters/custom/filter-repaint-custom.html:
    Use the mix-color.fs shader instead of color-add.fs.
* css3/filters/custom/invalid-custom-filter-shader.html:
    Use the CSS mix function with the updated color-offset.fs.
* css3/filters/custom/missing-custom-filter-shader-expected.png:
* css3/filters/custom/missing-custom-filter-shader.html:
    Use the CSS mix function with the updated color-offset.fs.
* css3/filters/resources/color-add.fs:
    Removed. The mix-color.fs shader can perform this shader's function.
* css3/filters/resources/color-fill.fs:
    Rewrote this shader to write to css_MixColor instead of sampling u_texture and writing
    to gl_FragColor.
* css3/filters/resources/color-offset-parameters.fs:
    Removed. The mix-color.fs shader can perform this shader's function.
* css3/filters/resources/color-offset.fs:
    Rewrote this shader to write to css_MixColor instead of sampling u_texture and writing
    to gl_FragColor.
* platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-custom-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-custom-parameters-expected.png:
* platform/chromium-mac/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
* platform/chromium-mac/css3/filters/custom/filter-repaint-custom-expected.png:
* platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] Make visited link tracking work in multi-process mode
ap@apple.com [Wed, 5 Sep 2012 18:21:49 +0000 (18:21 +0000)]
    [WK2] Make visited link tracking work in multi-process mode
        https://bugs.webkit.org/show_bug.cgi?id=95869

        Reviewed by Dan Bernstein.

        * UIProcess/VisitedLinkProvider.h:
        * UIProcess/VisitedLinkProvider.cpp:
        (WebKit::VisitedLinkProvider::VisitedLinkProvider): m_webProcessHasVisitedLinkState
        was making no sense in multi-process world, so it was let go.
        (WebKit::VisitedLinkProvider::processDidFinishLaunching): Track new processes.
        (WebKit::VisitedLinkProvider::processDidClose): Clean up pointers that are going
        to become stale.
        (WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired): Added comments. Fixed
        a bug where we would churn table size in some cases. Added debug logging in failure
        case. Re-implemented messaging code to work with multiple web processes.

        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::processDidFinishLaunching): Pass process proxy pointer to
        m_visitedLinkProvider, as it now needs to track processes.
        (WebKit::WebContext::disconnectProcess): Ditto. Also re-enabled visited link provider
        cleanup in multi-process mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] PlatformKeyboardEvent::getCurrentModifierState should initialize values.
mifenton@rim.com [Wed, 5 Sep 2012 18:16:58 +0000 (18:16 +0000)]
[BlackBerry] PlatformKeyboardEvent::getCurrentModifierState should initialize values.
https://bugs.webkit.org/show_bug.cgi?id=95773

Reviewed by Rob Buis.

Properly initialize the passed variables even
though we haven't implemented the modifier state
to ensure the values are deterministic.

* platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:
(WebCore::PlatformKeyboardEvent::getCurrentModifierState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Add the local and remote description functionality to RTCPeerConnection
tommyw@google.com [Wed, 5 Sep 2012 18:01:12 +0000 (18:01 +0000)]
MediaStream API: Add the local and remote description functionality to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95839

Reviewed by Adam Barth.

Source/Platform:

* Platform.gypi:
* chromium/public/WebRTCPeerConnectionHandler.h:
(WebKit):
(WebRTCPeerConnectionHandler):
* chromium/public/WebRTCVoidRequest.h: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.
(WebCore):
(WebKit):
(WebRTCVoidRequest):
(ExtraData):
(WebKit::WebRTCVoidRequest::ExtraData::~ExtraData):
(WebKit::WebRTCVoidRequest::WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::~WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::operator=):
(WebKit::WebRTCVoidRequest::isNull):

Source/WebCore:

As well as adding the local/remote descriptions stuff, I removed the source attribute from
RTCSessionDescriptionCallback and RTCErrorCallback since it has been removed from the draft.

Tests: fast/mediastream/RTCPeerConnection-localDescription.html
       fast/mediastream/RTCPeerConnection-remoteDescription.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/mediastream/RTCErrorCallback.h:
(RTCErrorCallback):
* Modules/mediastream/RTCErrorCallback.idl:
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnection::localDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::remoteDescription):
* Modules/mediastream/RTCPeerConnection.h:
(WebCore):
(RTCPeerConnection):
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/mediastream/RTCSessionDescriptionCallback.h:
(RTCSessionDescriptionCallback):
* Modules/mediastream/RTCSessionDescriptionCallback.idl:
* Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:
(WebCore::RTCSessionDescriptionRequestImpl::create):
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
(WebCore::RTCSessionDescriptionRequestImpl::clear):
* Modules/mediastream/RTCSessionDescriptionRequestImpl.h:
(RTCSessionDescriptionRequestImpl):
* Modules/mediastream/RTCVoidRequestImpl.cpp: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp.
(WebCore):
(WebCore::RTCVoidRequestImpl::create):
(WebCore::RTCVoidRequestImpl::RTCVoidRequestImpl):
(WebCore::RTCVoidRequestImpl::~RTCVoidRequestImpl):
(WebCore::RTCVoidRequestImpl::requestSucceeded):
(WebCore::RTCVoidRequestImpl::requestFailed):
(WebCore::RTCVoidRequestImpl::stop):
(WebCore::RTCVoidRequestImpl::clear):
* Modules/mediastream/RTCVoidRequestImpl.h: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionCallback.h.
(WebCore):
(RTCVoidRequestImpl):
* WebCore.gypi:
* platform/chromium/support/WebRTCVoidRequest.cpp: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.
(WebKit):
(WebKit::WebRTCVoidRequest::WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::assign):
(WebKit::WebRTCVoidRequest::reset):
(WebKit::WebRTCVoidRequest::requestSucceeded):
(WebKit::WebRTCVoidRequest::requestFailed):
(ExtraDataContainer):
(WebKit::ExtraDataContainer::ExtraDataContainer):
(WebKit::ExtraDataContainer::extraData):
(WebKit::WebRTCVoidRequest::extraData):
(WebKit::WebRTCVoidRequest::setExtraData):
* platform/mediastream/RTCPeerConnectionHandler.cpp:
(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnectionHandlerDummy::setRemoteDescription):
(WebCore::RTCPeerConnectionHandlerDummy::localDescription):
(WebCore::RTCPeerConnectionHandlerDummy::remoteDescription):
* platform/mediastream/RTCPeerConnectionHandler.h:
(WebCore):
(RTCPeerConnectionHandler):
* platform/mediastream/RTCVoidRequest.h: Copied from Source/WebCore/Modules/mediastream/RTCErrorCallback.h.
(WebCore):
(RTCVoidRequest):
(ExtraData):
(WebCore::RTCVoidRequest::ExtraData::~ExtraData):
(WebCore::RTCVoidRequest::~RTCVoidRequest):
(WebCore::RTCVoidRequest::extraData):
(WebCore::RTCVoidRequest::setExtraData):
(WebCore::RTCVoidRequest::RTCVoidRequest):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::setRemoteDescription):
(WebCore::RTCPeerConnectionHandlerChromium::localDescription):
(WebCore::RTCPeerConnectionHandlerChromium::remoteDescription):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(RTCPeerConnectionHandlerChromium):

Tools:

In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
up the task definitions a bit. There was no need to have them in the header file.

* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestFailedTask):
(RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
(RTCVoidRequestTask):
(RTCVoidRequestTask::RTCVoidRequestTask):
(MockWebRTCPeerConnectionHandler::createOffer):
(MockWebRTCPeerConnectionHandler::setLocalDescription):
(MockWebRTCPeerConnectionHandler::setRemoteDescription):
(MockWebRTCPeerConnectionHandler::localDescription):
(MockWebRTCPeerConnectionHandler::remoteDescription):
* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
(MockWebRTCPeerConnectionHandler):

LayoutTests:

* fast/mediastream/RTCPeerConnection-createOffer.html:
* fast/mediastream/RTCPeerConnection-localDescription-expected.txt: Added.
* fast/mediastream/RTCPeerConnection-localDescription.html: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html.
* fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt: Added.
* fast/mediastream/RTCPeerConnection-remoteDescription.html: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse -webkit-clip-path shapes to clip HTML elements
krit@webkit.org [Wed, 5 Sep 2012 17:48:19 +0000 (17:48 +0000)]
Use -webkit-clip-path shapes to clip HTML elements
https://bugs.webkit.org/show_bug.cgi?id=95646

Reviewed by Dean Jackson.

Source/WebCore:

-webkit-clip-path creates a new layer for HTML elements now. The border,
background and content gets clipped by the clip path after any filter was
applied.

Tests: css3/masking/clip-path-circle-filter.html
       css3/masking/clip-path-circle-overflow.html
       css3/masking/clip-path-circle-overflow-hidden.html
       css3/masking/clip-path-circle-relative-overflow.html
       css3/masking/clip-path-circle.html
       css3/masking/clip-path-ellipse.html
       css3/masking/clip-path-polygon-evenodd.html
       css3/masking/clip-path-polygon-nonzero.html
       css3/masking/clip-path-polygon.html
       css3/masking/clip-path-rectangle.html

* rendering/RenderBox.h: Create new layer on clip-path.
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::requiresLayer): Create new layer on clip-path.
* rendering/RenderInline.h:
(WebCore::RenderInline::requiresLayer): Create new layer on clip-path.
* rendering/RenderLayer.cpp: Apply clip-path on context of object.
(WebCore::RenderLayer::paintLayerContents): Create new layer on clip-path.
* rendering/RenderObject.h:
(WebCore::RenderObject::hasClipPath): Indicates that renderer needs to be clipped by clip-path.
* rendering/RenderTableRow.h: Create new layer on clip-path.

LayoutTests:

Added new tests for the -webkit-clip-path property applied to HTML content.

* css3/masking/clip-path-circle-filter.html: Added.
* css3/masking/clip-path-circle-overflow.html: Added.
* css3/masking/clip-path-circle-relative-overflow.html: Added.
* css3/masking/clip-path-circle-overflow-hidden.html: Added.
* css3/masking/clip-path-circle.html: Added.
* css3/masking/clip-path-ellipse.html: Added.
* css3/masking/clip-path-polygon-evenodd.html: Added.
* css3/masking/clip-path-polygon-nonzero.html: Added.
* css3/masking/clip-path-polygon.html: Added.
* css3/masking/clip-path-rectangle.html: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/css3/masking/clip-path-circle-expected.png: Added.
* platform/mac/css3/masking/clip-path-circle-expected.txt: Added.
* platform/mac/css3/masking/clip-path-circle-filter-expected.png: Added.
* platform/mac/css3/masking/clip-path-circle-filter-expected.txt: Added.
* platform/mac/css3/masking/clip-path-circle-overflow-expected.png: Added.
* platform/mac/css3/masking/clip-path-circle-overflow-expected.txt: Added.
* platform/mac/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
* platform/mac/css3/masking/clip-path-circle-overflow-hidden-expected.txt: Added.
* platform/mac/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
* platform/mac/css3/masking/clip-path-circle-relative-overflow-expected.txt: Added.
* platform/mac/css3/masking/clip-path-ellipse-expected.png: Added.
* platform/mac/css3/masking/clip-path-ellipse-expected.txt: Added.
* platform/mac/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
* platform/mac/css3/masking/clip-path-polygon-evenodd-expected.txt: Added.
* platform/mac/css3/masking/clip-path-polygon-expected.png: Added.
* platform/mac/css3/masking/clip-path-polygon-expected.txt: Added.
* platform/mac/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
* platform/mac/css3/masking/clip-path-polygon-nonzero-expected.txt: Added.
* platform/mac/css3/masking/clip-path-rectangle-expected.png: Added.
* platform/mac/css3/masking/clip-path-rectangle-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Use explicit constructor in RenderThemeEfl.
commit-queue@webkit.org [Wed, 5 Sep 2012 17:33:55 +0000 (17:33 +0000)]
[EFL] Use explicit constructor in RenderThemeEfl.
https://bugs.webkit.org/show_bug.cgi?id=95853

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-05
Reviewed by Kentaro Hara.

Added explicit keyword in constructor of RenderThemeEfl in order to avoid implicit type conversion.

* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitPointerLockElement returns null when pointer lock request is pending.
scheib@chromium.org [Wed, 5 Sep 2012 17:31:32 +0000 (17:31 +0000)]
webkitPointerLockElement returns null when pointer lock request is pending.
https://bugs.webkit.org/show_bug.cgi?id=91186

Reviewed by Dimitri Glazkov.

Source/WebCore:

Script should wait for a pointerlockchange event before detecting
if it has acquired lock. However, if a script attempted to poll
pointerLockElement it could be confused when lock was still pending.
This change ensures that if lock is not yet acquired then
pointerLockElement will return null.

Test: pointer-lock/pointerlockelement-null-when-pending.html

* dom/Document.cpp:
(WebCore::Document::webkitPointerLockElement):
* page/PointerLockController.cpp:
(WebCore::PointerLockController::requestPointerLock):
(WebCore::PointerLockController::elementRemoved):
(WebCore::PointerLockController::documentDetached):
(WebCore::PointerLockController::lockPending):
(WebCore):
(WebCore::PointerLockController::didAcquirePointerLock):
(WebCore::PointerLockController::didNotAcquirePointerLock):
(WebCore::PointerLockController::didLosePointerLock):
(WebCore::PointerLockController::clearElement):
* page/PointerLockController.h:
(PointerLockController):

LayoutTests:

* pointer-lock/locked-element-iframe-removed-from-dom-expected.txt:
* pointer-lock/locked-element-iframe-removed-from-dom.html:
     Updated to reflect new behavior of null returned when lock is pending.
* pointer-lock/pointerlockelement-null-when-pending-expected.txt: Added.
* pointer-lock/pointerlockelement-null-when-pending.html: Added.
     New test specifically for testing null return when lock is pending.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Wire up scrollable sublayers in ScrollingCoordinatorChromium
commit-queue@webkit.org [Wed, 5 Sep 2012 17:25:42 +0000 (17:25 +0000)]
[chromium] Wire up scrollable sublayers in ScrollingCoordinatorChromium
https://bugs.webkit.org/show_bug.cgi?id=95679

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-09-05
Reviewed by James Robinson.

Source/Platform:

Introduce WebLayerScrollClient for getting notified about scroll events targeting a WebLayer.

* Platform.gypi:
* chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
* chromium/public/WebLayerScrollClient.h:

Source/WebCore:

Implement scrollable sublayers in ScrollingCoordinatorChromium and introduce a
WebLayerScrollClient which is notified of scroll events on its associated
scroll layer. GraphicsLayerChromium uses it to apply scroll events targeted to
its platform layer to a ScrollableArea, i.e., the RenderLayer corresponding to
the scrollable element.

Tests: GraphicsLayerChromiumTest.applyScrollToScrollableArea
       WebLayerTest.ScrollClient

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::didScroll):
(WebCore):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore):
(WebCore::GraphicsLayerChromium::setScrollableArea):
(WebCore::GraphicsLayerChromium::scrollableArea):
(GraphicsLayerChromium):
* platform/graphics/chromium/LayerChromium.cpp:
* platform/graphics/chromium/LayerChromium.h:
(WebKit):
(WebCore):
(WebCore::LayerChromium::setLayerScrollClient):
(LayerChromium):

Source/WebKit/chromium:

Introduce WebLayerScrollClient for getting notified about scroll events targeting a WebLayer.

* src/WebLayerImpl.cpp:
(WebKit::WebLayerImpl::setMaxScrollPosition):
(WebKit):
(WebKit::WebLayerImpl::setScrollClient):
(WebKit::WebLayerImpl::scrollBy):
* src/WebLayerImpl.h:
(WebLayerImpl):
* tests/CCLayerTreeHostTest.cpp:
* tests/GraphicsLayerChromiumTest.cpp:
(MockScrollableArea):
(WebKit):
(WebKit::TEST_F):
* tests/WebLayerTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Remove '+=' usage in String
commit-queue@webkit.org [Wed, 5 Sep 2012 17:05:40 +0000 (17:05 +0000)]
[EFL] Remove '+=' usage in String
https://bugs.webkit.org/show_bug.cgi?id=95808

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-05
Reviewed by Benjamin Poulain.

Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.

Source/WebKit/efl:

* ewk/ewk_frame.cpp:
(ewk_frame_source_get): Removed unnecessary strlen usage.

Tools:

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(descriptionSuitableForTestResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: CodeGeneratorInspector.py: support asynchronous command implementation
vsevik@chromium.org [Wed, 5 Sep 2012 16:44:31 +0000 (16:44 +0000)]
Web Inspector: CodeGeneratorInspector.py: support asynchronous command implementation
https://bugs.webkit.org/show_bug.cgi?id=95649

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-09-05
Reviewed by Yury Semikhatsky.

Generator is extended to generate callback object for each asynchronous command.

* inspector/CodeGeneratorInspector.py:
(Writer.append_multiline):
(Writer):
(Writer.get_indent):
(TypeBindings.create_type_declaration_.ClassBinding.resolve_inner.ResolveData):
(InspectorBackendDispatcherImpl):
(CallbackBase):
(Generator.process_event):
(Generator):
(Generator.EventMethodStructTemplate):
(Generator.EventMethodStructTemplate.append_prolog):
(Generator.EventMethodStructTemplate.append_epilog):
(Generator.process_command):
(Generator.CallbackMethodStructTemplate):
(Generator.CallbackMethodStructTemplate.append_prolog):
(Generator.CallbackMethodStructTemplate.append_epilog):
(Generator.generate_send_method):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
commit-queue@webkit.org [Wed, 5 Sep 2012 16:33:48 +0000 (16:33 +0000)]
[EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
https://bugs.webkit.org/show_bug.cgi?id=95842

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.

Tools:

Provide proper implementation for TestRunner::pathToLocalResource()
in EFL WKTR, identical to the one for DumpRenderTree.

Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
/tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
are found my WebKitTestRunner.

* WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
(WTR::TestRunner::pathToLocalResource):

LayoutTests:

Unskip fast/dom/frame-loading-via-document-write.html that
was failing due to incomplete implementation for
TestRunner::pathToLocalResource() in EFL WKTR.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Do not release shared backingstore memory prematurely
commit-queue@webkit.org [Wed, 5 Sep 2012 16:32:43 +0000 (16:32 +0000)]
[BlackBerry] Do not release shared backingstore memory prematurely
https://bugs.webkit.org/show_bug.cgi?id=95841
PR #202517

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-09-05
Reviewed by George Staikos.

The BackingStore memory is shared by all web pages. We should check if
the current backingStore is active before create/release this shared memory.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
(BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unify size of popup menu for touch and non-touch.
commit-queue@webkit.org [Wed, 5 Sep 2012 15:58:09 +0000 (15:58 +0000)]
[chromium] Unify size of popup menu for touch and non-touch.
https://bugs.webkit.org/show_bug.cgi?id=95606

Patch by Kevin Ellis <kevers@chromium.org> on 2012-09-05
Reviewed by Adam Barth.

Use minimum height for popup menus entries regardless of whether the
popup menu is displayed on a touch screen.  Replaces use of touch
padding.  Height meets minimum size requirement for a low error rate
while still looking aesthetic for non-touch.

Covered by existing tests.

* platform/chromium/PopupListBox.cpp:
(WebCore::PopupListBox::getRowHeight):
* platform/chromium/PopupMenuChromium.cpp:
(WebCore):
* platform/chromium/PopupMenuChromium.h:
(PopupMenuChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Auto width is not working for Regions
mihnea@adobe.com [Wed, 5 Sep 2012 15:56:48 +0000 (15:56 +0000)]
[CSS Regions] Auto width is not working for Regions
https://bugs.webkit.org/show_bug.cgi?id=74135

Reviewed by Julien Chaffraix.

Source/WebCore:

It was not possible to flow content into a region having { width: auto; } since in such case, the region width was computed to 0.
Now, a region having auto width, will have its width computed following the rules for calculation of widths and margins
(http://www.w3.org/TR/CSS2/visudet.html#Computing_widths_and_margins).
For those cases in which resolving the width requires measuring of content's min/max-content values, we use the associated named flow min/max-content
values (the same for all regions with width auto in a region chain).
When a region has width:auto, the computation of width should be done using normal block/box sizing code, instead of replaced element code.
Contains code contributed by Alexandru Chiculita(achicu@adobe.com).

Tests: fast/regions/autowidth-abspos-regionchain.html
       fast/regions/autowidth-abspos.html
       fast/regions/autowidth-float.html
       fast/regions/autowidth-inlineblock.html
       fast/regions/autowidth-nonreplaced-abspos.html
       fast/regions/autowidth-nonreplacedblock-normalflow.html
       fast/regions/autowidth-normalflow-maxwidth.html
       fast/regions/autowidth-normalflow-minmaxwidth.html
       fast/regions/autowidth-normalflow-minwidth.html
       fast/regions/autowidth-normalflow-vertrl.html
       fast/regions/autowidth-normalflow.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidth): For positioned auto-width regions, skip the code path for replaced elements.
* rendering/RenderRegion.cpp:
(WebCore): Override min/maxPreferredLogicalWidth as they are used in the process of computing width for regions with auto width.
As this moment, a region is still a RenderReplaced element, so this code needs to be revisited when the region will become a RenderBlock.
Also, for min/max-width, we support only <length> values. We will extend support for other values in a following patch.
(WebCore::RenderRegion::minPreferredLogicalWidth):
(WebCore::RenderRegion::maxPreferredLogicalWidth):
* rendering/RenderRegion.h:
(RenderRegion):
Override isInlineBlockOrInlineTable() and shouldComputeSizeAsReplaced() to ensure that computation for width auto follows the normal
block/box sizing code.

LayoutTests:

It was not possible to flow content into a region having { width: auto; } since in such case, the region width was computed to 0.
Now, a region having auto width, will have its width computed following the rules for calculation of widths and margins
(http://www.w3.org/TR/CSS2/visudet.html#Computing_widths_and_margins).
For those cases in which resolving the width requires measuring of content's min/max-content values, we use the associated named flow min/max-content
values (the same for all regions with width auto in a region chain).

Besides adding new tests, i have modified existing tests that were having regions with width:auto as they were failing after this patch.

* fast/regions/autowidth-abspos-expected.html: Added.
* fast/regions/autowidth-abspos-regionchain-expected.html: Added.
* fast/regions/autowidth-abspos-regionchain.html: Added.
* fast/regions/autowidth-abspos.html: Added.
* fast/regions/autowidth-float-expected.html: Added.
* fast/regions/autowidth-float.html: Added.
* fast/regions/autowidth-inlineblock-expected.html: Added.
* fast/regions/autowidth-inlineblock.html: Added.
* fast/regions/autowidth-nonreplaced-abspos-expected.html: Added.
* fast/regions/autowidth-nonreplaced-abspos.html: Added.
* fast/regions/autowidth-nonreplacedblock-normalflow-expected.html: Added.
* fast/regions/autowidth-nonreplacedblock-normalflow.html: Added.
* fast/regions/autowidth-normalflow-expected.html: Added.
* fast/regions/autowidth-normalflow-maxwidth-expected.html: Added.
* fast/regions/autowidth-normalflow-maxwidth.html: Added.
* fast/regions/autowidth-normalflow-minmaxwidth-expected.html: Added.
* fast/regions/autowidth-normalflow-minmaxwidth.html: Added.
* fast/regions/autowidth-normalflow-minwidth-expected.html: Added.
* fast/regions/autowidth-normalflow-minwidth.html: Added.
* fast/regions/autowidth-normalflow-vertrl-expected.html: Added.
* fast/regions/autowidth-normalflow-vertrl.html: Added.
* fast/regions/autowidth-normalflow.html: Added.
* fast/regions/bottom-overflow-out-of-first-region.html:
* fast/regions/flows-dependency-dynamic-remove.html:
* fast/regions/flows-dependency-same-flow.html:
* fast/regions/render-region-renderer-expected.html:
* fast/regions/top-overflow-out-of-second-region.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFrequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
beidson@apple.com [Wed, 5 Sep 2012 15:39:16 +0000 (15:39 +0000)]
Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
<rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026

Source/WebKit2:

Patch partially by Andras Becsi  <andras.becsi@nokia.com>

Reviewed by Andy Estes.

If a plug-in fails to initialize then the m_plugin pointer is cleared out.
When accessing the script object it is appropriate to unconditionally null check m_plugin.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::scriptObject): Null check m_plugin before trying to use it.

Tools:

Reviewed by Andy Estes.

Add a plug-in that always fails to initialize:
* DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
(NPPNewFails):
(NPPNewFails::NPPNewFails):
(NPPNewFails::NPP_New):

Add it to all the project files:
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

LayoutTests:

Reviewed by Andy Estes.

* plugins/npp-new-fails-expected.txt: Added.
* plugins/npp-new-fails.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Implement number of matches and current active match index for find...
commit-queue@webkit.org [Wed, 5 Sep 2012 15:38:09 +0000 (15:38 +0000)]
[BlackBerry] Implement number of matches and current active match index for find-on-page
https://bugs.webkit.org/show_bug.cgi?id=95801

Patch by Andy Chen <andchen@rim.com> on 2012-09-05
Reviewed by Antonio Gomes.

- Calculate current match index for find-on-page
- Notify client when number of matches and current match index update.
PR 162090 162091.
Internally reviewed by Mike Fenton and Joe Mason

* Api/WebPageClient.h:
* WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::DeferredScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::doTimeout):
(InPageSearchManager::DeferredScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatchesSoon):
(BlackBerry::WebKit::InPageSearchManager::callScopeStringMatches):
* WebKitSupport/InPageSearchManager.h:
(InPageSearchManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: NMI: extract MemoryObjectType constants from MemoryInstrumentation.
loislo@chromium.org [Wed, 5 Sep 2012 15:11:06 +0000 (15:11 +0000)]
Web Inspector: NMI: extract MemoryObjectType constants from MemoryInstrumentation.
https://bugs.webkit.org/show_bug.cgi?id=95850

Reviewed by Yury Semikhatsky.

I'd like to extract MemoryObjectTypes into separate classes.
After that we will be able to move core NMI instrumentation code to WTF.

Source/WebCore:

* bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::reportMemoryUsage):
* bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::ChunkedTable::reportMemoryUsage):
* bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
* bindings/v8/V8Binding.cpp:
(WebCore::StringCache::reportMemoryUsage):
* bindings/v8/V8DOMMap.h:
* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage):
* css/CSSAspectRatioValue.cpp:
(WebCore::CSSAspectRatioValue::reportDescendantMemoryUsage):
* css/CSSBorderImageSliceValue.cpp:
(WebCore::CSSBorderImageSliceValue::reportDescendantMemoryUsage):
* css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::reportDescendantMemoryUsage):
* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::reportDescendantMemoryUsage):
* css/CSSCharsetRule.cpp:
(WebCore::CSSCharsetRule::reportDescendantMemoryUsage):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::reportMemoryUsage):
* css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::reportDescendantMemoryUsage):
* css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):
* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::reportDescendantMemoryUsage):
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):
* css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::reportDescendantMemoryUsage):
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientColorStop::reportMemoryUsage):
(WebCore::CSSGradientValue::reportBaseClassMemoryUsage):
(WebCore::CSSLinearGradientValue::reportDescendantMemoryUsage):
(WebCore::CSSRadialGradientValue::reportDescendantMemoryUsage):
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::reportDescendantMemoryUsage):
(WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::reportDescendantMemoryUsage):
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::reportDescendantMemoryUsage):
* css/CSSInheritedValue.cpp:
(WebCore::CSSInheritedValue::reportDescendantMemoryUsage):
* css/CSSInitialValue.cpp:
(WebCore::CSSInitialValue::reportDescendantMemoryUsage):
* css/CSSLineBoxContainValue.cpp:
(WebCore::CSSLineBoxContainValue::reportDescendantMemoryUsage):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::reportDescendantMemoryUsage):
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::reportDescendantMemoryUsage):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::reportMemoryUsage):
* css/CSSReflectValue.cpp:
(WebCore::CSSReflectValue::reportDescendantMemoryUsage):
* css/CSSRule.cpp:
(WebCore::CSSRule::reportBaseClassMemoryUsage):
* css/CSSRuleList.cpp:
(WebCore::StaticCSSRuleList::reportMemoryUsage):
* css/CSSRuleList.h:
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::reportMemoryUsage):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::reportDescendantMemoryUsage):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::reportMemoryUsage):
* css/CSSTimingFunctionValue.cpp:
(WebCore::CSSLinearTimingFunctionValue::reportDescendantMemoryUsage):
(WebCore::CSSCubicBezierTimingFunctionValue::reportDescendantMemoryUsage):
(WebCore::CSSStepsTimingFunctionValue::reportDescendantMemoryUsage):
* css/CSSUnicodeRangeValue.cpp:
(WebCore::CSSUnicodeRangeValue::reportDescendantMemoryUsage):
* css/CSSUnknownRule.h:
(WebCore::CSSUnknownRule::reportDescendantMemoryUsage):
* css/CSSValue.cpp:
(WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::reportDescendantMemoryUsage):
* css/CSSVariableValue.h:
(WebCore::CSSVariableValue::reportDescendantMemoryUsage):
* css/FontFeatureValue.cpp:
(WebCore::FontFeatureValue::reportDescendantMemoryUsage):
* css/FontValue.cpp:
(WebCore::FontValue::reportDescendantMemoryUsage):
* css/MediaList.cpp:
(WebCore::MediaQuerySet::reportMemoryUsage):
(WebCore::MediaList::reportMemoryUsage):
* css/MediaQuery.cpp:
(WebCore::MediaQuery::reportMemoryUsage):
* css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::reportMemoryUsage):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::reportMemoryUsage):
(WebCore::StyleRuleCSSStyleDeclaration::reportMemoryUsage):
(WebCore::InlineCSSStyleDeclaration::reportMemoryUsage):
* css/ShadowValue.cpp:
(WebCore::ShadowValue::reportDescendantMemoryUsage):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::reportMemoryUsage):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::Features::reportMemoryUsage):
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleRule.cpp:
(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRule::reportDescendantMemoryUsage):
(WebCore::StyleRulePage::reportDescendantMemoryUsage):
(WebCore::StyleRuleFontFace::reportDescendantMemoryUsage):
(WebCore::StyleRuleBlock::reportDescendantMemoryUsage):
(WebCore::StyleRuleMedia::reportDescendantMemoryUsage):
(WebCore::StyleRuleRegion::reportDescendantMemoryUsage):
* css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::reportDescendantMemoryUsage):
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::reportMemoryUsage):
* css/WebKitCSSFilterValue.cpp:
(WebCore::WebKitCSSFilterValue::reportDescendantMemoryUsage):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::reportMemoryUsage):
(WebCore::WebKitCSSKeyframeRule::reportDescendantMemoryUsage):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
(WebCore::WebKitCSSKeyframesRule::reportDescendantMemoryUsage):
* css/WebKitCSSMixFunctionValue.cpp:
(WebCore::WebKitCSSMixFunctionValue::reportDescendantMemoryUsage):
* css/WebKitCSSRegionRule.cpp:
(WebCore::WebKitCSSRegionRule::reportDescendantMemoryUsage):
* css/WebKitCSSSVGDocumentValue.cpp:
(WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):
* css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):
* css/WebKitCSSTransformValue.cpp:
(WebCore::WebKitCSSTransformValue::reportDescendantMemoryUsage):
* dom/Attribute.h:
(WebCore::Attribute::reportMemoryUsage):
* dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
* dom/ContainerNode.h:
(WebCore::ContainerNode::reportMemoryUsage):
* dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
* dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::reportMemoryUsage):
* dom/Element.h:
(WebCore::Element::reportMemoryUsage):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::reportMemoryUsage):
* dom/Event.cpp:
(WebCore::Event::reportMemoryUsage):
* dom/MemoryInstrumentation.cpp:
(WebCore):
* dom/MemoryInstrumentation.h:
(WebCore):
(GenericMemoryTypes):
(WebCore::MemoryInstrumentation::addRootObject):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCoreMemoryTypes):
* dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
* dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
(WebCore::QualifiedName::reportMemoryUsage):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::reportMemoryUsage):
* inspector/InspectorMemoryAgent.cpp:
(WebCore):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportMemoryUsage):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::reportMemoryUsage):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::reportMemoryUsage):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::reportMemoryUsage):
* loader/SubstituteData.cpp:
(WebCore::SubstituteData::reportMemoryUsage):
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::reportMemoryUsage):
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::reportMemoryUsage):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::reportMemoryUsage):
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::reportMemoryUsage):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::reportMemoryUsage):
* loader/cache/CachedResourceHandle.cpp:
(WebCore::CachedResourceHandleBase::reportMemoryUsage):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::reportMemoryUsage):
* loader/cache/CachedSVGDocument.cpp:
(WebCore::CachedSVGDocument::reportMemoryUsage):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::reportMemoryUsage):
* loader/cache/CachedShader.cpp:
(WebCore::CachedShader::reportMemoryUsage):
* loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::reportMemoryUsage):
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::reportMemoryUsage):
* page/Frame.cpp:
(WebCore::Frame::reportMemoryUsage):
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::reportMemoryUsage):
* platform/TreeShared.h:
(WebCore::TreeShared::reportMemoryUsage):
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::reportMemoryUsage):
* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::reportMemoryUsage):
* platform/graphics/GeneratedImage.cpp:
(WebCore::GeneratedImage::reportMemoryUsage):
* platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::reportMemoryUsage):
* platform/graphics/Image.cpp:
(WebCore::Image::reportMemoryUsage):
* platform/network/FormData.cpp:
(WebCore::FormData::reportMemoryUsage):
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsage):
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::reportMemoryUsage):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::reportMemoryUsage):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::reportMemoryUsage):
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::reportMemoryUsage):
* svg/SVGColor.cpp:
(WebCore::SVGColor::reportDescendantMemoryUsage):
* svg/SVGPaint.cpp:
(WebCore::SVGPaint::reportDescendantMemoryUsage):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::reportMemoryUsage):

Source/WebKit/chromium:

* tests/MemoryInstrumentationTest.cpp:
(WebCore::Instrumented::reportMemoryUsage):
(WebCore::InstrumentedRefPtr::reportMemoryUsage):
(WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):
(WebCore::InstrumentedOther::reportMemoryUsage):
(WebCore::InstrumentedDOM::reportMemoryUsage):
(WebCore::TEST):
(WebCore::NonVirtualInstrumented::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: NMI: extract overloaded instrumentation members for WebCore classes...
loislo@chromium.org [Wed, 5 Sep 2012 14:52:44 +0000 (14:52 +0000)]
Web Inspector: NMI: extract overloaded instrumentation members for WebCore classes from core NMI code.
https://bugs.webkit.org/show_bug.cgi?id=95834

Reviewed by Yury Semikhatsky.

I'd like to remove custom instrumentation methods from MemoryInstrumentation class
before upstreaming it to WTF. I've done it with help of MemoryInstrumentationTraits template helper.

Unfortunately it is not possible to use template class because mac-ews bot reports warning: redundant redeclaration of 'something' in same scope.
I've found that it is an old problem in gcc that is forced by -Wredundant-decls flag on the bot. See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15867

* dom/MemoryInstrumentation.cpp:
(WebCore::::addInstrumentedObject):
(WebCore):
* dom/MemoryInstrumentation.h:
(WebCore):
(MemoryInstrumentationTraits):
(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::InstrumentedPointer::InstrumentedPointer):
(InstrumentedPointer):
(WebCore::MemoryInstrumentation::addObject):
(WebCore::MemoryInstrumentation::addInstrumentedObject):
(WebCore::MemoryInstrumentation::addRawBuffer):
(WebCore::MemoryInstrumentation::OwningTraits::addInstrumentedObject):
(WebCore::MemoryInstrumentation::OwningTraits::addObject):
(WebCore::::addInstrumentedObject):
(WebCore::::addObject):
(WebCore::MemoryObjectInfo::MemoryObjectInfo):
(WebCore::MemoryObjectInfo::objectType):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(MemoryObjectInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):
(MemoryClassInfo):
(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
(WebCore::MemoryInstrumentation::addObjectImpl):
(WebCore::MemoryInstrumentation::addHashMap):
(WebCore::MemoryInstrumentation::addHashSet):
(WebCore::MemoryInstrumentation::addInstrumentedCollection):
(WebCore::MemoryInstrumentation::addInstrumentedMapEntries):
(WebCore::MemoryInstrumentation::addInstrumentedMapValues):
(WebCore::MemoryInstrumentation::addListHashSet):
(WebCore::MemoryInstrumentation::addVector):
* inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationImpl::countObjectSize):
* inspector/MemoryInstrumentationImpl.h:
(WebCore::MemoryInstrumentationImpl::totalSize):
(MemoryInstrumentationImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r127590.
peter@chromium.org [Wed, 5 Sep 2012 14:36:47 +0000 (14:36 +0000)]
Unreviewed, rolling out r127590.
http://trac.webkit.org/changeset/127590

Broke the Chromium bots because of a compile error in the compositor.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
peter@chromium.org [Wed, 5 Sep 2012 14:23:54 +0000 (14:23 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Build fix on OS X
vestbo@webkit.org [Wed, 5 Sep 2012 14:04:50 +0000 (14:04 +0000)]
[Qt] Build fix on OS X

Copy/paste-error resulted in us compiling InspectorPageOverlay.h

Reviewed by Ossy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 5 Sep 2012 13:25:17 +0000 (13:25 +0000)]
[EFL] Unreviewed gardening.

Adding a platform specififc baseline after r127534.

* platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix makefile race condition between derived sources and target
vestbo@webkit.org [Wed, 5 Sep 2012 13:11:35 +0000 (13:11 +0000)]
[Qt] Fix makefile race condition between derived sources and target

r121966 removed too much of the old qmake logic, including the rule
that ensured that qmake_all would not trigger dual runs of qmake --
one of the derived sources -qmake-all rule, and one for making the
derived sources.

We now follow a similar pattern as before, by introducing a custom
target that explicitly depends on the derived sources' qmake-all before
doing a manual run of make. That ensures a single qmake run for the derived
sources.

https://bugs.webkit.org/show_bug.cgi?id=93847

Reviewed by Csaba Osztrogonác.

* qmake/mkspecs/features/functions.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Provide implementation for WebFrameNetworkingContext
commit-queue@webkit.org [Wed, 5 Sep 2012 13:06:01 +0000 (13:06 +0000)]
[EFL][WK2] Provide implementation for WebFrameNetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=95826

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Remove EFL-specific and empty implementation for WebFrameNetworkingContext
and use the existing soup implementation instead.

* PlatformEfl.cmake:
* WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h: Removed.

LayoutTests:

Unskip several cookie-related test cases for WK2 EFL
now that WebFrameNetworkingContext is implemented.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r127573.
dominik.rottsches@intel.com [Wed, 5 Sep 2012 12:34:58 +0000 (12:34 +0000)]
Unreviewed, rolling out r127573.
http://trac.webkit.org/changeset/127573
https://bugs.webkit.org/show_bug.cgi?id=95844

Breaks EFL Debug bot tests. (Requested by drott on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-05

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::themePartCacheEntryReset):
(WebCore::RenderThemeEfl::cacheThemePartNew):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::setThemePath):
(WebCore::RenderThemeEfl::createCanvas):
(WebCore::RenderThemeEfl::createEdje):
(WebCore::RenderThemeEfl::applyPartDescriptions):
(WebCore::RenderThemeEfl::themeChanged):
(WebCore):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShadowRoot.cloneNode() must always throw a DATA_CLONE_ERR exception.
morrita@google.com [Wed, 5 Sep 2012 12:09:07 +0000 (12:09 +0000)]
ShadowRoot.cloneNode() must always throw a DATA_CLONE_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=91704

Reviewed by Kentaro Hara.

Source/WebCore:

This change implement ShadowRoot::cloneNode() which throws an exception.
This also adds an overloaded version cloneNode() to ShadowRoot.idl
which is enabled only for JavaScript instead of changing the
signature of Node::cloneNode().

Note that changing the existing signature can break GObject bindings
compatibility.

Test: fast/dom/shadow/shadowroot-clonenode.html

* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::cloneNode):
(WebCore):
* dom/ShadowRoot.h:
(ShadowRoot):
* dom/ShadowRoot.idl:

LayoutTests:

* fast/dom/shadow/shadowroot-clonenode-expected.txt: Added.
* fast/dom/shadow/shadowroot-clonenode.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed trivial build fix: Use DOMAllInOne.cpp only if we have xslt available.
hausmann@webkit.org [Wed, 5 Sep 2012 11:53:40 +0000 (11:53 +0000)]
[Qt] Unreviewed trivial build fix: Use DOMAllInOne.cpp only if we have xslt available.

* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWKTR doesn't implement dumpWillCacheResponse()
commit-queue@webkit.org [Wed, 5 Sep 2012 11:44:04 +0000 (11:44 +0000)]
WKTR doesn't implement dumpWillCacheResponse()
https://bugs.webkit.org/show_bug.cgi?id=94607

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-05
Reviewed by Kenneth Rohde Christiansen.

Tools:

Define shouldCacheResponse() callback in resource
load client and provide implementation for
dumpWillCacheResponse() in WebKitTestRunner.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::shouldCacheResponse):
(WTR):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(InjectedBundlePage):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::TestRunner):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(WTR::TestRunner::dumpWillCacheResponse):
(WTR::TestRunner::shouldDumpWillCacheResponse):
(TestRunner):

LayoutTests:

Unskip http/tests/misc/willCacheResponse-delegate-callback.html
now that WebKitTestRunner implements dumpWillCacheResponse().

* platform/efl-wk2/TestExpectations:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
kaustubh@motorola.com [Wed, 5 Sep 2012 11:36:03 +0000 (11:36 +0000)]
[DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
https://bugs.webkit.org/show_bug.cgi?id=92735

Reviewed by Hajime Morita.

.:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Added symbols for GTK builds for corresponding APIs.

* Source/autotools/symbols.filter:

Source/WebCore:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.

Covered by existing test cases.

* testing/Internals.cpp:
(WebCore::Internals::numberOfPages):
(WebCore):
(WebCore::Internals::pageProperty):
(WebCore::Internals::pageSizeAndMarginsInPixels):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit/efl:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Source/WebKit/qt:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Kept the function defination and declaration to keep binary compatibility for IWebFramePrivate.idl

* WebFrame.cpp:
(WebFrame::numberOfPages):

Source/WebKit2:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Add symbols for Mac Win builds for corresponding newly added APIs.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

Tools:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.

* DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
* DumpRenderTree/TestRunner.h:
(TestRunner):
* DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
(TestRunner::addUserStyleSheet):
* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::hasCustomPageSizeStyle):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
* DumpRenderTree/efl/TestRunnerEfl.cpp:
* DumpRenderTree/gtk/TestRunnerGtk.cpp:
* DumpRenderTree/mac/TestRunnerMac.mm:
* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::evaluateScriptInIsolatedWorld):
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
* DumpRenderTree/win/TestRunnerWin.cpp:
* DumpRenderTree/wx/TestRunnerWx.cpp:
(TestRunner::abortModal):
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):

LayoutTests:

Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Fixed test cases to use internals API instead of testRunner.

* printing/numberOfPages-expected.txt:
* printing/page-count-layout-overflow.html:
* printing/page-count-relayout-shrink.html:
* printing/page-count-with-one-word.html:
* printing/page-format-data-display-none.html:
* printing/page-format-data-expected.txt:
* printing/page-format-data.html:
* printing/page-rule-selection-expected.txt:
* printing/page-rule-selection.html:
* printing/resources/paged-media-test-utils.js:
(numberOfPagesShouldBe):
* printing/script-tests/numberOfPages.js:
* printing/zoomed-document.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Automate the use of AllInOne files in the Qt build
hausmann@webkit.org [Wed, 5 Sep 2012 11:26:41 +0000 (11:26 +0000)]
[Qt] Automate the use of AllInOne files in the Qt build
https://bugs.webkit.org/show_bug.cgi?id=95837

Reviewed by Tor Arne Vestbø.

Source/WebCore:

Replace the manual use of SVGAllInOne.cpp with automated use through
the ALL_IN_ONE_SOURCES variable. This adds a few more all-in-one sources
to the build and leaves out some that do not compile yet due to various
platform-dependant pre-processor macro issues.

* Target.pri:

Tools:

New feature file that implements the all-in-one file automation by
adding the requested all-in-one files to SOURCES and removing the files
it includes from SOURCES.

* qmake/mkspecs/features/use_all_in_one_files.prf: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening after r127513
dominik.rottsches@intel.com [Wed, 5 Sep 2012 11:24:55 +0000 (11:24 +0000)]
[EFL] Unreviewed gardening after r127513

Marking plugin third-party storage tests as failing on EFL.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the uses of String::operator+=() for Mac
commit-queue@webkit.org [Wed, 5 Sep 2012 11:04:33 +0000 (11:04 +0000)]
Fix the uses of String::operator+=() for Mac
https://bugs.webkit.org/show_bug.cgi?id=95818

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-05
Reviewed by Dan Bernstein.

Source/JavaScriptCore:

* jsc.cpp:
(functionJSCStack): Use StringBuilder to create the stack dump, it is faster
and avoid String::operator+=().

* parser/Parser.h:
(JSC::Parser::updateErrorMessageSpecialCase):
(JSC::Parser::updateErrorMessage):
(JSC::Parser::updateErrorWithNameAndMessage):
Use the String operators (and makeString) to concatenate the strings.

Source/WebCore:

* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::putDelegate):
This is a legitimate use of String::append(), it is the only
concatenation in this function.

* loader/appcache/ManifestParser.cpp:
(WebCore::parseManifest): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Fuzzy load the Edje theme for HTML forms
kenneth@webkit.org [Wed, 5 Sep 2012 11:02:11 +0000 (11:02 +0000)]
[EFL] Fuzzy load the Edje theme for HTML forms
https://bugs.webkit.org/show_bug.cgi?id=95832

Reviewed by Gyuyoung Kim.

Change the theme so that it is first loaded when actually used.
This also fixed the case that it was impossible to change theme
a second time.

Tested by current tests. API unit test coming in separate patch.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::themePartCacheEntryReset):
(WebCore::RenderThemeEfl::cacheThemePartNew):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::setThemePath):
(WebCore::RenderThemeEfl::edje):
(WebCore::RenderThemeEfl::applyPartDescriptions):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Blackberry] Add document url and securityOrigin to platform request.
commit-queue@webkit.org [Wed, 5 Sep 2012 10:56:12 +0000 (10:56 +0000)]
[Blackberry] Add document url and securityOrigin to platform request.
https://bugs.webkit.org/show_bug.cgi?id=95822

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-09-05
Reviewed by George Staikos.
Internally Reviewed by Joe Mason.

It is a webworks requirement.

* platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: NMI: replace ObjectType enum with static const char* string identifiers.
loislo@chromium.org [Wed, 5 Sep 2012 09:19:46 +0000 (09:19 +0000)]
Web Inspector: NMI: replace ObjectType enum with static const char* string identifiers.
https://bugs.webkit.org/show_bug.cgi?id=95739

Reviewed by Yury Semikhatsky.

When we go deeper into different parts of browser like skia, chromium itself etc.
we can't use a single enum for all reported object types.
The current idea is to use plain simple strings as ObjectType identifiers.
In the future patches we will extract these identifiers into separate class or namespace
and and split it between components.

Source/WebCore:

* dom/MemoryInstrumentation.cpp:
(WebCore):
* dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
* inspector/InspectorMemoryAgent.cpp:
(WebCore::addMemoryBlockFor):
(WebCore):
* inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::countObjectSize):
* inspector/MemoryInstrumentationImpl.h:
(WebCore::MemoryInstrumentationImpl::totalSize):
(WebCore::MemoryInstrumentationImpl::reportedSizeForAllTypes):
(MemoryInstrumentationImpl):

Source/WebKit/chromium:

* tests/MemoryInstrumentationTest.cpp:
(WebCore::TEST):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r127525.
paroga@webkit.org [Wed, 5 Sep 2012 08:41:13 +0000 (08:41 +0000)]
Build fix for WinCE after r127525.

* platform/graphics/wince/FontCustomPlatformData.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
kkristof@inf.u-szeged.hu [Wed, 5 Sep 2012 08:41:08 +0000 (08:41 +0000)]
[Qt] Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=95827

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-09-05

* platform/qt/Skipped: skip failing test after r127534.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 5 Sep 2012 08:15:13 +0000 (08:15 +0000)]
Unreviewed GTK gardening.

Rebaselining after r126911, r127163 and r127534.

Adding a platform-specific baseline for accessibility/canvas-description-and-role.html
that's required after r127084. The baseline is currently the same as Chromium's,
expecting 'AXCanvas' as the AXRole for the canvas element. The GTK port currently
reports 'image' as the AXRole - this is probably not intended so the text failure
expectation is also added for this test.

* platform/gtk/TestExpectations:
* platform/gtk/accessibility/canvas-description-and-role-expected.txt: Added.
* platform/gtk/fast/block/float/024-expected.txt:
* platform/gtk/fast/block/margin-collapse/025-expected.txt:
* platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
* platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
* platform/gtk/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
* platform/gtk/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
* platform/gtk/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
* platform/gtk/fast/innerHTML/innerHTML-iframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Tests] We should have interactive validation of required value for the "input" element
yosin@chromium.org [Wed, 5 Sep 2012 08:05:02 +0000 (08:05 +0000)]
[Tests] We should have interactive validation of required value for the "input" element
https://bugs.webkit.org/show_bug.cgi?id=95817

Reviewed by Kent Tamura.

This patch adds tests for required attribute handling on form
submission of input types. The test script is parametrized for
input type and expected type. Each test file simply call one test
script in common-interactive-validation-required.js.

The test script checks:
  - Don't submit form when required value isn't presented.
  - Submit form when required value is presented.

* fast/forms/date/date-interactive-validation-required-expected.txt: Added.
* fast/forms/date/date-interactive-validation-required.html: Added.
* fast/forms/datetime/datetime-interactive-validation-required-expected.txt: Added.
* fast/forms/datetime/datetime-interactive-validation-required.html: Added.
* fast/forms/datetimelocal/datetimelocal-interactive-validation-required-expected.txt: Added.
* fast/forms/datetimelocal/datetimelocal-interactive-validation-required.html: Added.
* fast/forms/month/month-interactive-validation-required-expected.txt: Added.
* fast/forms/month/month-interactive-validation-required.html: Added.
* fast/forms/number/number-interactive-validation-required-expected.txt: Added.
* fast/forms/number/number-interactive-validation-required.html: Added.
* fast/forms/resources/common-interactive-validation-required.js: Added.
* fast/forms/time/time-interactive-validation-required-expected.txt: Added.
* fast/forms/time/time-interactive-validation-required.html: Added.
* fast/forms/week/week-interactive-validation-required-expected.txt: Added.
* fast/forms/week/week-interactive-validation-required.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMoved mac results to be the generic results, and the existing result to be the chromium
mikelawther@chromium.org [Wed, 5 Sep 2012 08:00:29 +0000 (08:00 +0000)]
Moved mac results to be the generic results, and the existing result to be the chromium
platform result. The current result uses subpixel layout, which is not the norm.

Original results were added in r127557. Mac results were added in r127560.

* css3/calc/zoom-with-em-expected.txt:
* platform/chromium/css3/calc/zoom-with-em-expected.txt: Copied from LayoutTests/css3/calc/zoom-with-em-expected.txt.
* platform/mac/css3/calc/zoom-with-em-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTest cases for Up/Down key behavior on field which has maximum/minimum in multiple...
yosin@chromium.org [Wed, 5 Sep 2012 07:56:10 +0000 (07:56 +0000)]
Test cases for Up/Down key behavior on field which has maximum/minimum in multiple fields time input UI
https://bugs.webkit.org/show_bug.cgi?id=95824

Reviewed by Kent Tamura.

This patch adds test cases for Up/Down key behavior on field which has
maximum/minimum value in multiple fields time input UI.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

* fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Updated expectation for new test cases.
* fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html: Changed to add test cases for Up key behavior for "23:59:59.999" (11:59:59.999PM in UI) and Down key behavior for "01:00:00.000" (01:00:00.000 AM in UI)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG JIT doesn't work properly on ARM hardfp
rgabor@webkit.org [Wed, 5 Sep 2012 07:51:46 +0000 (07:51 +0000)]
DFG JIT doesn't work properly on ARM hardfp
https://bugs.webkit.org/show_bug.cgi?id=95684

Reviewed by Filip Pizlo.

Add hardfp support to DFG JIT. The patch is created with the
help of Zoltan Herczeg.

Source/JavaScriptCore:

* dfg/DFGCCallHelpers.h:
(CCallHelpers):
(JSC::DFG::CCallHelpers::setupArguments):
* dfg/DFGFPRInfo.h:
(FPRInfo):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):

Source/WTF:

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdded Mac-specific expected results for a test added in r127557. The generic results are
mitz@apple.com [Wed, 5 Sep 2012 07:22:42 +0000 (07:22 +0000)]
Added Mac-specific expected results for a test added in r127557. The generic results are
probably from a build with subpixel layout.

* platform/mac/css3/calc: Added.
* platform/mac/css3/calc/zoom-with-em-expected.txt: Copied from LayoutTests/css3/calc/zoom-with-em-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] QRawWebViewPrivate does not initialize some members
kbalazs@webkit.org [Wed, 5 Sep 2012 07:16:31 +0000 (07:16 +0000)]
[Qt] QRawWebViewPrivate does not initialize some members
https://bugs.webkit.org/show_bug.cgi?id=95709

Reviewed by Luiz Agostini.

Don't miss initializing the bool flags.

* UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebViewPrivate::QRawWebViewPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove PagePopupClient implementation for input[type=date] to Chromium WebKit layer
keishi@webkit.org [Wed, 5 Sep 2012 06:35:41 +0000 (06:35 +0000)]
Move PagePopupClient implementation for input[type=date] to Chromium WebKit layer
https://bugs.webkit.org/show_bug.cgi?id=95681

Reviewed by Kent Tamura.

Source/WebCore:

We are moving calendar picker PagePopupClient to WebKit layer so ports
can use their platform native chooser UI if they have one.
DateTimeChooser, DateTimeChooserClient etc. will be reused when we
implement the week picker and month picker.

No new tests. No behavior change. Covered by existing calendar picker tests.

* WebCore.gypi:
* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::CalendarPickerElement):
(WebCore::CalendarPickerElement::~CalendarPickerElement):
(WebCore::CalendarPickerElement::didChooseValue): Called when user chose a value.
(WebCore):
(WebCore::CalendarPickerElement::didEndChooser): Called when chooser has ended.
(WebCore::CalendarPickerElement::openPopup):
(WebCore::CalendarPickerElement::closePopup):
* html/shadow/CalendarPickerElement.h:
(CalendarPickerElement):
* loader/EmptyClients.cpp:
(WebCore):
(WebCore::EmptyChromeClient::openDateTimeChooser):
* loader/EmptyClients.h:
(EmptyChromeClient):
* page/ChromeClient.h:
(WebCore):
(ChromeClient):
* platform/DateTimeChooser.h:
(WebCore):
(DateTimeChooserParameters): Contains information needed to open the DateTimeChooser.
(DateTimeChooser):
(WebCore::DateTimeChooser::~DateTimeChooser):
* platform/DateTimeChooserClient.h:
(WebCore):
(DateTimeChooserClient):
(WebCore::DateTimeChooserClient::~DateTimeChooserClient):

Source/WebKit/chromium:

* WebKit.gyp:
* src/ChromeClientImpl.cpp:
(WebKit):
(WebKit::ChromeClientImpl::openDateTimeChooser):
* src/ChromeClientImpl.h:
(WebCore):
(ChromeClientImpl):
* src/DateTimeChooserImpl.cpp: Added.
(WebKit):
(WebKit::DateTimeChooserImpl::DateTimeChooserImpl):
(WebKit::DateTimeChooserImpl::~DateTimeChooserImpl):
(WebKit::DateTimeChooserImpl::endChooser):
(WebKit::DateTimeChooserImpl::contentSize):
(WebKit::DateTimeChooserImpl::writeDocument):
(WebKit::DateTimeChooserImpl::setValueAndClosePopup):
(WebKit::DateTimeChooserImpl::didClosePopup):
* src/DateTimeChooserImpl.h:
(WebCore):
(WebKit):
(DateTimeChooserImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS3 calc: expressions with 'em' units do not zoom correctly.
mikelawther@chromium.org [Wed, 5 Sep 2012 06:28:26 +0000 (06:28 +0000)]
CSS3 calc: expressions with 'em' units do not zoom correctly.
https://bugs.webkit.org/show_bug.cgi?id=95705

Reviewed by Ojan Vafai.

Source/WebCore:

Each primitive value in a CSS calc expression now has (zoom) multiplier and scale factor applied
independently. Previously the multiplier and a single scale factor was applied to the expression
as a whole, but this failed to account for expressions involving font relative units. This is
because the multiplier should not be applied to font relative units.

Test: css3/calc/zoom-with-em.html

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthDouble):

LayoutTests:

* css3/calc/zoom-with-em-expected.txt: Added.
* css3/calc/zoom-with-em.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Prevent compositor ticking if it can't draw
commit-queue@webkit.org [Wed, 5 Sep 2012 06:07:18 +0000 (06:07 +0000)]
[chromium] Prevent compositor ticking if it can't draw
https://bugs.webkit.org/show_bug.cgi?id=95399

Patch by Brian Anderson <brianderson@chromium.org> on 2012-09-04
Reviewed by James Robinson.

Background extensions had an always ticking compositor even though
they couldn't draw. This patch disables the ticks when canDraw is false
and adds a notification mechanism for when canDraw changes states so
we can recover properly.

Tests updated for new interfaces.
Regression test added to make sure ticking stops when canDraw is false.
notifyIfCanDrawChanged test added to make sure notifications are sent
for any changes that might affect canDraw.

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::notifyIfCanDrawChanged):
(WebCore):
(WebCore::CCLayerTreeHostImpl::releaseContentsTextures):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::initializeRenderer):
(WebCore::CCLayerTreeHostImpl::setViewportSize):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImplClient):
(WebCore::CCLayerTreeHostImpl::resetContentsTexturesPurged):
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::setCanDraw):
(WebCore):
(WebCore::CCScheduler::processScheduledActions):
* platform/graphics/chromium/cc/CCScheduler.h:
(CCScheduler):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::toString):
(WebCore):
(WebCore::CCSchedulerStateMachine::vsyncCallbackNeeded):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
(CCSchedulerStateMachine):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::onCanDrawStateChanged):
(WebCore):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove WTF_DEPRECATED_STRING_OPERATORS from StylePropertySet.cpp
benjamin@webkit.org [Wed, 5 Sep 2012 05:33:59 +0000 (05:33 +0000)]
Remove WTF_DEPRECATED_STRING_OPERATORS from StylePropertySet.cpp
https://bugs.webkit.org/show_bug.cgi?id=95800

Patch by Adam Barth <abarth@chromium.org> on 2012-09-04
Reviewed by Benjamin Poulain.

This patch is a re-spin of part of the patch from
https://bugs.webkit.org/show_bug.cgi?id=95502, but with the tests
fixed.  :)

* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::getLayeredShorthandValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAllow the YarrJIT to use the assembler even when useJIT() is false.
commit-queue@webkit.org [Wed, 5 Sep 2012 05:12:26 +0000 (05:12 +0000)]
Allow the YarrJIT to use the assembler even when useJIT() is false.
Introduce the useYarrJIT() option.
https://bugs.webkit.org/show_bug.cgi?id=95809.

Patch by Mark Lam <mark.lam@apple.com> on 2012-09-04
Reviewed by Geoffrey Garen.

* runtime/JSGlobalData.cpp:
(JSC::enableAssembler):
* runtime/Options.cpp:
(JSC::Options::initialize):
* runtime/Options.h:
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r126132): MediaSlider and MediaVolumeSlider thumbs don't match mouse when...
keishi@webkit.org [Wed, 5 Sep 2012 04:53:35 +0000 (04:53 +0000)]
REGRESSION(r126132): MediaSlider and MediaVolumeSlider thumbs don't match mouse when dragged
https://bugs.webkit.org/show_bug.cgi?id=95701

Reviewed by Kent Tamura.

Source/WebCore:

MediaSlider and MediaVolumeSlider thumbs didn't match mouse when dragged because of the negative margin applied to the thumb.

Test: platform/chromium/media/media-volume-slider-hit-test.html

* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint): Account for margins when calculating the position.

LayoutTests:

* platform/chromium/media/media-volume-slider-hit-test-expected.txt: Added.
* platform/chromium/media/media-volume-slider-hit-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Use explicit constructor in InjectedBundle.
commit-queue@webkit.org [Wed, 5 Sep 2012 04:40:29 +0000 (04:40 +0000)]
[WK2] Use explicit constructor in InjectedBundle.
https://bugs.webkit.org/show_bug.cgi?id=95746

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-04
Reviewed by Sam Weinig.

Added explicit keyword in constructor of InjectedBundle in order to avoid implicit type conversion.

* WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Update test expectation
tkent@chromium.org [Wed, 5 Sep 2012 04:27:14 +0000 (04:27 +0000)]
[Chromium] Update test expectation
https://bugs.webkit.org/show_bug.cgi?id=95395

* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
* platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Test expectatino update.
tkent@chromium.org [Wed, 5 Sep 2012 04:16:11 +0000 (04:16 +0000)]
[Chromium] Test expectatino update.

* platform/chromium/TestExpectations:
japanese-ruby-vertical-*.html might be flaky on Windows too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a const version of RenderBox::computeLogicalHeight
tony@chromium.org [Wed, 5 Sep 2012 04:14:44 +0000 (04:14 +0000)]
Add a const version of RenderBox::computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=95787

Reviewed by Ojan Vafai.

After this, we can rename the old computeLogicalHeight to computeAndSetLogicalHeight
to make it clear that it is modifying values.

No new tests, this should just be a refactor.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::constrainLogicalHeightByMinMax): Make const.
(WebCore::RenderBox::computeLogicalHeight): Add a const version that takes a LogicalExtentComputedValues struct for out values.
(WebCore::RenderBox::computeLogicalHeightUsing): Make const.
(WebCore::RenderBox::computeContentLogicalHeightUsing): Make const.
(WebCore::RenderBox::computePercentageLogicalHeight): Add a const cast. I tried to
convert everything below to const, but that's not a simple task. Also, computeReplacedLogicalHeightUsing
is already using a const_cast.
* rendering/RenderBox.h:
(RenderBox): Add const to method signatures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago-webkit-clip-path does not apply origin for polygon()
krit@webkit.org [Wed, 5 Sep 2012 03:57:56 +0000 (03:57 +0000)]
-webkit-clip-path does not apply origin for polygon()
https://bugs.webkit.org/show_bug.cgi?id=95656

Reviewed by Tim Horton.

Source/WebCore:

The polygon() shape function did not apply origin of bouding box on created path. The shape was
not moved to the correct position.

Tests: svg/clip-path/clip-path-shape-polygon-relative-expected.svg
       svg/clip-path/clip-path-shape-polygon-relative.svg

* rendering/style/BasicShapes.cpp:
(WebCore::BasicShapePolygon::path): Apply origin of bounding box.

LayoutTests:

Check that the origin of the bounding box gets applied to the clip path.

* svg/clip-path/clip-path-shape-polygon-relative-expected.svg: Added.
* svg/clip-path/clip-path-shape-polygon-relative.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHave NRWT log more output when crash logs are missing
timothy_horton@apple.com [Wed, 5 Sep 2012 03:45:33 +0000 (03:45 +0000)]
Have NRWT log more output when crash logs are missing
https://bugs.webkit.org/show_bug.cgi?id=95814

Reviewed by Dan Bernstein.

Log the stderr and stdout of the test, in order to provide slightly more
context when the WebProcess times out while running tests.

* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.run_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update after r127534
bashi@chromium.org [Wed, 5 Sep 2012 03:33:40 +0000 (03:33 +0000)]
[Chromium] Unreviewed test expectations update after r127534

* platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoinc/dec behave incorrectly operating on a resolved const
barraclough@apple.com [Wed, 5 Sep 2012 02:36:45 +0000 (02:36 +0000)]
inc/dec behave incorrectly operating on a resolved const
https://bugs.webkit.org/show_bug.cgi?id=95815

Reviewed by Geoff Garen.

Source/JavaScriptCore:

There are two bugs here.

(1) When the value being incremented is const, and the result is ignored, we assume this cannot be observed, and emit no code.
    However if the value being incremented is not a primitive & has a valueOf conversion, then this should be being called.

(2) In the case of a pre-increment of a const value where the result is not ignored, we'll move +/-1 to the destination, then
    add the resolved const value being incremented to this. This is problematic if the destination is a local, and the const
    value being incremented has a valueOf conversion that throws - the destination will be modified erroneously. Instead, we
    need to use a temporary location.

* bytecompiler/NodesCodegen.cpp:
(JSC::PostfixResolveNode::emitBytecode):
(JSC::PrefixResolveNode::emitBytecode):
    - always at least perform a toNumber conversion, use tempDestination when reducing inc/dec to an add +/-1.

LayoutTests:

Added test cases.

* fast/js/inc-const-valueOf-expected.txt: Added.
* fast/js/inc-const-valueOf.html: Added.
* fast/js/script-tests/inc-const-valueOf.js: Added.
(testPostIncConstVarWithIgnoredResult.const.a.valueOf):
(testPostIncConstVarWithIgnoredResult):
    test that 'a++' results in a valueOf call, where 'a' is const.
(testPreIncConstVarWithIgnoredResult.const.a.valueOf):
(testPreIncConstVarWithIgnoredResult):
    test that '++a' results in a valueOf call, where 'a' is const.
(testPreIncConstVarWithAssign.const.a.valueOf):
(testPreIncConstVarWithAssign):
    test that 'b = ++a' does not erroneously update 'b', where 'a' is const.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Test expectation update
tkent@chromium.org [Wed, 5 Sep 2012 02:28:29 +0000 (02:28 +0000)]
[Chromium] Test expectation update

Rebaseline vertical-writing tests.

* platform/chromium-linux-x86/fast/writing-mode/border-vertical-lr-expected.txt: Added.
* platform/chromium-linux-x86/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
* platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-lr-expected.png: Added.
* platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Added.
* platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-rl-expected.png: Added.
* platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt: Added.
* platform/chromium-linux-x86/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt.
* platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
* platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
* platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.png: Added.
* platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.txt: Added.
* platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.png: Added.
* platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
* platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.png: Added.
* platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.txt: Added.
* platform/chromium-linux/fast/writing-mode/vertical-font-fallback-expected.png: Added.
* platform/chromium-linux/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt.
* platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt.
* platform/chromium-mac/fast/writing-mode/japanese-lr-selection-expected.png: Added.
* platform/chromium-mac/fast/writing-mode/japanese-rl-selection-expected.png: Added.
* platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
* platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
* platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
* platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
* platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
* platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
* platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
* platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
* platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
* platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt.
* platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
* platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
* platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
* platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt.
* platform/chromium-win-xp/fast/dynamic/text-combine-expected.png:
* platform/chromium-win-xp/fast/dynamic/text-combine-expected.txt: Added.
* platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.png:
* platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt.
* platform/chromium-win-xp/fast/text/international/text-spliced-font-expected.png:
* platform/chromium-win-xp/fast/text/international/text-spliced-font-expected.txt: Added.
* platform/chromium-win-xp/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
* platform/chromium-win-xp/fast/writing-mode/border-vertical-lr-expected.txt: Added.
* platform/chromium-win-xp/fast/writing-mode/broken-ideographic-font-expected.txt:
* platform/chromium-win-xp/fast/writing-mode/fallback-orientation-expected.png:
* platform/chromium-win-xp/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
* platform/chromium-win-xp/fast/writing-mode/japanese-lr-text-expected.png: Removed.
* platform/chromium-win-xp/fast/writing-mode/japanese-lr-text-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt.
* platform/chromium-win-xp/fast/writing-mode/japanese-rl-text-expected.png: Removed.
* platform/chromium-win-xp/fast/writing-mode/japanese-rl-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt.
* platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
* platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Added.
* platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
* platform/chromium-win-xp/fast/writing-mode/vertical-align-table-baseline-expected.png:
* platform/chromium-win-xp/fast/writing-mode/vertical-font-fallback-expected.png: Added.
* platform/chromium-win-xp/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/fast/writing-mode/broken-ideographic-font-expected.txt.
* platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
* platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
* platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
* platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
* platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
* platform/chromium-win/fast/dynamic/text-combine-expected.png:
* platform/chromium-win/fast/dynamic/text-combine-expected.txt:
* platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/chromium-win/fast/ruby/base-shorter-than-text-expected.png:
* platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt:
* platform/chromium-win/fast/text/international/text-spliced-font-expected.png:
* platform/chromium-win/fast/text/international/text-spliced-font-expected.txt:
* platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
* platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
* platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.png:
* platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.txt:
* platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.png:
* platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt:
* platform/chromium-win/fast/writing-mode/fallback-orientation-expected.png:
* platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.png:
* platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.txt:
* platform/chromium-win/fast/writing-mode/japanese-lr-text-expected.png:
* platform/chromium-win/fast/writing-mode/japanese-lr-text-expected.txt:
* platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.png:
* platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.txt:
* platform/chromium-win/fast/writing-mode/japanese-rl-text-expected.png:
* platform/chromium-win/fast/writing-mode/japanese-rl-text-expected.txt:
* platform/chromium-win/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png:
* platform/chromium-win/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Removed.
* platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
* platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
* platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
* platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
* platform/chromium-win/fast/writing-mode/vertical-align-table-baseline-expected.png:
* platform/chromium-win/fast/writing-mode/vertical-font-fallback-expected.png: Added.
* platform/chromium-win/fast/writing-mode/vertical-font-fallback-expected.txt:
* platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
* platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Some flaky media/video tests on Windows. Adding to skip list.
roger_fong@apple.com [Wed, 5 Sep 2012 01:55:39 +0000 (01:55 +0000)]
Unreviewed. Some flaky media/video tests on Windows. Adding to skip list.
https://bugs.webkit.org/show_bug.cgi?id=95806

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Some flaky http/tests/cookies tests on Windows. Adding to skip list.
roger_fong@apple.com [Wed, 5 Sep 2012 01:45:56 +0000 (01:45 +0000)]
Unreviewed. Some flaky http/tests/cookies tests on Windows. Adding to skip list.
https://bugs.webkit.org/show_bug.cgi?id=95805

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake chromium-linux build without WTF_DEPRECATED_STRING_OPERATORS
commit-queue@webkit.org [Wed, 5 Sep 2012 01:43:42 +0000 (01:43 +0000)]
Make chromium-linux build without WTF_DEPRECATED_STRING_OPERATORS
https://bugs.webkit.org/show_bug.cgi?id=95798

Patch by Adam Barth <abarth@chromium.org> on 2012-09-04
Reviewed by Eric Seidel.

Source/WebCore:

This patch makes the chromium-linux port build without
WTF::String::operator+=.  There are a couple places that require some
more careful study, and I've whitelisted those uses by defining
WTF_DEPRECATED_STRING_OPERATORS at the top of the files. (See
https://bugs.webkit.org/show_bug.cgi?id=95797 for an explanation of
WTF_DEPRECATED_STRING_OPERATORS.)

* css/StylePropertySet.cpp:
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::drawNodeHighlight):
* platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::rewriteMixVertexShader):

Source/WebKit/chromium:

* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::keyboardShortcut):
  - Remove use of WTF::String::operator+=
* src/WebPageSerializerImpl.cpp:
  - Whitelist use of WTF::String::operator+=. Remove this use will take
    some more careful thought.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Some flaky http/tests/security tests on Windows. Adding to skip list.
roger_fong@apple.com [Wed, 5 Sep 2012 01:38:29 +0000 (01:38 +0000)]
Unreviewed. Some flaky http/tests/security tests on Windows. Adding to skip list.
https://bugs.webkit.org/show_bug.cgi?id=95803

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse TrackedRendererListHashSet typedef for percentHeightDescendants()
tony@chromium.org [Wed, 5 Sep 2012 01:31:38 +0000 (01:31 +0000)]
Use TrackedRendererListHashSet typedef for percentHeightDescendants()
https://bugs.webkit.org/show_bug.cgi?id=95791

Reviewed by Ojan Vafai.

There were a couple callers that were using ListHashSet<RenderBox*> instead of the typedef.

No new tests, this is just a refactor.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
* rendering/RenderView.cpp:
(WebCore::RenderView::setFixedPositionedObjectsNeedLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Some flaky inspector tests on Windows. Adding to skip list.
roger_fong@apple.com [Wed, 5 Sep 2012 01:30:55 +0000 (01:30 +0000)]
Unreviewed. Some flaky inspector tests on Windows. Adding to skip list.
https://bugs.webkit.org/show_bug.cgi?id=95802

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG GetByVal for JSArrays shouldn't OSR exit every time that the index is out of...
fpizlo@apple.com [Wed, 5 Sep 2012 01:27:50 +0000 (01:27 +0000)]
DFG GetByVal for JSArrays shouldn't OSR exit every time that the index is out of bound
https://bugs.webkit.org/show_bug.cgi?id=95717

Reviewed by Oliver Hunt.

Rolling back in after fixing the negative index case.

Make GetByVal for JSArrayOutOfBounds do meaningful things. The profiling was already
there so we should just use it!

* bytecode/DFGExitProfile.h:
(JSC::DFG::exitKindToString):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: remove final createIndex backend glue
commit-queue@webkit.org [Wed, 5 Sep 2012 00:56:25 +0000 (00:56 +0000)]
IndexedDB: remove final createIndex backend glue
https://bugs.webkit.org/show_bug.cgi?id=95385

Patch by Alec Flett <alecflett@chromium.org> on 2012-09-04
Reviewed by Adam Barth.

Source/WebCore:

Remove all code that created index keys in the IndexedDB backend.

No new tests, this is just removal of dead code.

* Modules/indexeddb/IDBKeyPathBackendImpl.cpp: Removed.
* Modules/indexeddb/IDBKeyPathBackendImpl.h: Removed.
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore):
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* storage/chromium/IDBKeyPathBackendImpl.cpp: Removed.

Source/WebKit/chromium:

Remove chromium glue for old key-generation code.

* public/WebIDBKey.h:
(WebIDBKey):
* src/WebIDBKey.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFrame element doesn't always unload its child frame.
commit-queue@webkit.org [Wed, 5 Sep 2012 00:40:07 +0000 (00:40 +0000)]
Frame element doesn't always unload its child frame.
https://bugs.webkit.org/show_bug.cgi?id=94717

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2012-09-04
Reviewed by Hajime Morita.

Source/WebCore:

It's possible for a frame element that has been removed from the document
to retain an active child frame. This inconsistent state may become a source
of security vulnerabilities.

The patch adds a global HashSet to store the nodes currently processed by
ChildFrameDisconnector. Insertion into these nodes' subtrees is not allowed until
the processing is complete.

Also, the ChildFrameDisconnector call in removeChild(ren) is now immediately
followed by the actual removal.

Test: fast/frames/out-of-document-iframe-has-child-frame.html

* dom/ContainerNode.cpp:
(WebCore::willRemoveChildren): Move the ChildFrameDisconnector call out of a loop.
(WebCore::ContainerNode::removeChild): Rearrange some event firing code.
(WebCore::ContainerNode::removeChildren): Ditto.
* dom/ContainerNodeAlgorithms.cpp:
(WebCore::ChildFrameDisconnector::collectDescendant): Pass a new parameter to collectDescendant(Node*).
* dom/ContainerNodeAlgorithms.h:
(WebCore::ChildFrameDisconnector::ChildFrameDisconnector):
(ChildFrameDisconnector): Maintain a list of nodes that have an active ChildFrameDisconnector.
(WebCore::ChildFrameDisconnector::~ChildFrameDisconnector):
(WebCore::ChildFrameDisconnector::rootNodes):
(WebCore::ChildFrameDisconnector::collectDescendant): Add ShouldIncludeRoot parameter.
(WebCore::ChildFrameDisconnector::nodeHasDisconnector):
(WebCore):
* dom/Node.cpp:
(WebCore::checkAcceptChild): Reject a parent node if it or one of its parents has an active ChildFrameDisconnector.
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions): Check if an element is still in the document.

LayoutTests:

* fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added.
* fast/frames/out-of-document-iframe-has-child-frame.html: Added.
* fast/innerHTML/innerHTML-iframe-expected.txt:
* platform/chromium/fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added.
* platform/chromium/fast/innerHTML: Added.
* platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectation update after r127457
bashi@chromium.org [Wed, 5 Sep 2012 00:28:47 +0000 (00:28 +0000)]
[Chromium] Unreviewed test expectation update after r127457

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Adding test inspector/timeline/timeline-decode-resize.html to Windows...
roger_fong@apple.com [Wed, 5 Sep 2012 00:25:17 +0000 (00:25 +0000)]
Unreviewed. Adding test inspector/timeline/timeline-decode-resize.html to Windows skip list.
It fails on both Windows and Mac: https://bugs.webkit.org/show_bug.cgi?id=94374.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rebaseline tests after http://trac.webkit.org/changeset/127354.
roger_fong@apple.com [Wed, 5 Sep 2012 00:09:06 +0000 (00:09 +0000)]
Unreviewed. Rebaseline tests after trac.webkit.org/changeset/127354.

* platform/win/fast/text/international/text-spliced-font-expected.txt:
* platform/win/fast/writing-mode/border-vertical-lr-expected.txt:
* platform/win/fast/writing-mode/japanese-lr-selection-expected.txt:
* platform/win/fast/writing-mode/japanese-lr-text-expected.txt:
* platform/win/fast/writing-mode/japanese-rl-selection-expected.txt:
* platform/win/fast/writing-mode/japanese-rl-text-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Attempt to fix build failure on Win
bashi@chromium.org [Wed, 5 Sep 2012 00:07:58 +0000 (00:07 +0000)]
[Chromium] Attempt to fix build failure on Win

Remove chromium/public/WebOfferAnswerRequest.h from Platform.gypi,
which was added in r127501, but doesn't exist. Unreviewed.

* Platform.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPart 1 of removing PlatformString.h, move remaining functions to new homes
weinig@apple.com [Tue, 4 Sep 2012 23:58:01 +0000 (23:58 +0000)]
Part 1 of removing PlatformString.h, move remaining functions to new homes
https://bugs.webkit.org/show_bug.cgi?id=95702

Reviewed by Beth Dakin.

Source/WebCore:

Move utf8Buffer() to SharedBuffer.h/cpp
Move numGraphemeClusters() and numCharactersInGraphemeClusters() to TextBreakIterator.h/cpp

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Update projects.

* platform/text/TextAllInOne.cpp:
Add TextBreakIterator.cpp.

* editing/Editor.h:
Forward declare SharedBuffer, now that PlatformString.h doesn't.

* html/InputType.cpp:
#include TextBreakIterator.h.

* loader/appcache/ApplicationCacheStorage.h:
Replace inclusion of PlatformString.h with WTFString.h and forward declare SharedBuffer.

* platform/LocalizedStrings.cpp:
Replace inclusion of PlatformString.h with TextBreakIterator.h

* platform/SharedBuffer.cpp:
* platform/SharedBuffer.h:
Move utf8Buffer() here.

* platform/text/PlatformString.h:
Remove everything except the #include of WTFString.h.

* platform/text/TextBreakIterator.cpp: Renamed from Source/WebCore/platform/text/String.cpp.
(WebCore::numGraphemeClusters):
(WebCore::numCharactersInGraphemeClusters):
* platform/text/TextBreakIterator.h:
Move numGraphemeClusters() and numCharactersInGraphemeClusters() here.

Source/WebKit2:

* UIProcess/WebPageProxy.h:
Forward declare SharedBuffer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp
jchaffraix@webkit.org [Tue, 4 Sep 2012 23:39:00 +0000 (23:39 +0000)]
REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp
https://bugs.webkit.org/show_bug.cgi?id=95776

Reviewed by Simon Fraser.

.:

* ManualTests/select-menu-list-wrongly-positioned.html: Added.

Source/WebCore:

r120832 consolidated the clamping logic into RenderLayer::clampScrollOffset. The existing code wouldn't properly ensure that
the offset were positive which got exposed to other code paths, leading to the regression.

Tested by ManualTests/select-menu-list-wrongly-positioned.html as I didn't find a way to create a reliable layout test.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clampScrollOffset):
Fixed the clamping logic to ensure that the scroll offset's dimensions are positive.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. editing/style/apply-style-atomic.html fails on Windows since...
roger_fong@apple.com [Tue, 4 Sep 2012 23:34:22 +0000 (23:34 +0000)]
Unreviewed gardening. editing/style/apply-style-atomic.html fails on Windows since introduced in trac.webkit.org/changeset/126865.
Test added to skip list.

https://bugs.webkit.org/show_bug.cgi?id=95795

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: IDBRequest leaks if IDBCursor closes and no further events fired
jsbell@chromium.org [Tue, 4 Sep 2012 23:34:19 +0000 (23:34 +0000)]
IndexedDB: IDBRequest leaks if IDBCursor closes and no further events fired
https://bugs.webkit.org/show_bug.cgi?id=95777

Reviewed by Tony Chang.

IDBRequests are kept alive as long as they may fire events, which includes
if the associated IDBCursor object can be advanced. When the transaction
is finished the IDBCursor is notified which in turn tells the IDBRequest
that the cursor won't be the source of more events. However, if this occurs
and no further events fire the IDBRequest doesn't clear it's "has pending
activity flag". Clear the flag on the notification if the request is
otherwise complete.

No new tests - ActiveDOMObjects and leaks are persnickety.

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::finishCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shaders] Implement multiply, screen, darken, lighten, difference, exclusion...
commit-queue@webkit.org [Tue, 4 Sep 2012 22:53:25 +0000 (22:53 +0000)]
[CSS Shaders] Implement multiply, screen, darken, lighten, difference, exclusion blend modes.
https://bugs.webkit.org/show_bug.cgi?id=93870

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-09-04
Reviewed by Dirk Schulze.

Source/WebCore:

Add expressions for the aforementioned blend modes. The expressions are lifted directly
from the CSS Compositing and Blending spec [1]. WebKit adds these blending expressions to
the author's shader.

[1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blendingnormal

Test: css3/filters/custom/custom-filter-blend-modes.html

* platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::blendFunctionString):

LayoutTests:

Add test to check that the DOM element texture blends correctly with the css_MixColor
variable from the author's shader for each blend mode.

* css3/filters/custom/custom-filter-blend-modes-expected.html: Added.
* css3/filters/custom/custom-filter-blend-modes.html: Added.
* css3/filters/resources/mix-color.fs: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r127503.
commit-queue@webkit.org [Tue, 4 Sep 2012 22:34:03 +0000 (22:34 +0000)]
Unreviewed, rolling out r127503.
http://trac.webkit.org/changeset/127503
https://bugs.webkit.org/show_bug.cgi?id=95788

broke some tests (fast/js/dfg-negative-array-index, fast/js
/dfg-put-by-val-setter-then-get-by-val) (Requested by thorton
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-04

* bytecode/DFGExitProfile.h:
(JSC::DFG::exitKindToString):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] FatFingers::cachingStrategy uses incorrect enum value
rwlbuis@webkit.org [Tue, 4 Sep 2012 22:27:16 +0000 (22:27 +0000)]
[BlackBerry] FatFingers::cachingStrategy uses incorrect enum value
https://bugs.webkit.org/show_bug.cgi?id=95783

Reviewed by Antonio Gomes.

Use the correct enum values.

* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::cachingStrategy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix style for Event.h
commit-queue@webkit.org [Tue, 4 Sep 2012 22:22:40 +0000 (22:22 +0000)]
Fix style for Event.h
https://bugs.webkit.org/show_bug.cgi?id=95779

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-09-04
Reviewed by Eric Seidel.

Changes indenting for Event.h to match style guidelines for namespaces

* dom/Event.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake plugins respect third-party storage blocking setting
jpfau@apple.com [Tue, 4 Sep 2012 22:20:43 +0000 (22:20 +0000)]
Make plugins respect third-party storage blocking setting
https://bugs.webkit.org/show_bug.cgi?id=94888

Reviewed by Brady Eidson.

Source/WebCore:

Added functions for discerning if a plugin should be able to access its storage in its current origin.

Tests: http/tests/security/cross-origin-plugin-allowed.html
       http/tests/security/cross-origin-plugin.html

* WebCore.exp.in: Export FrameTree::top and SecurityOrigin::canAccessStorage
* page/SecurityOrigin.h: Added canAccessPluginStorage
(WebCore::SecurityOrigin::canAccessPluginStorage):

Source/WebKit2:

Plugins that are in a third-party context should be put into private browsing mode so their storage is temporary.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::isPrivateBrowsingEnabled): Put the plugin into private browsing mode if it is in a third-party context.
(WebKit::PluginView::privateBrowsingStateChanged): Make sure a plugin doesn't leave private browsing mode if it's in a third-party context.

LayoutTests:

Created tests for plugins in a third party and first party context when third-party blocking is on and off.

* http/tests/security/cross-origin-plugin-allowed-expected.txt: Added.
* http/tests/security/cross-origin-plugin-allowed.html: Added.
* http/tests/security/cross-origin-plugin-expected.txt: Added.
* http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed-expected.txt: Added.
* http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html: Added.
* http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt: Added.
* http/tests/security/cross-origin-plugin-private-browsing-toggled.html: Added.
* http/tests/security/cross-origin-plugin.html: Added.
* http/tests/security/resources/cross-origin-iframe-for-plugin.html: Added.
* http/tests/security/resources/cross-origin-iframe-for-plugin-async.html: Added.
* platform/mac-wk2/http/tests/security/cross-origin-plugin-expected.txt: Added.
* platform/mac-wk2/http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
wangxianzhu@chromium.org [Tue, 4 Sep 2012 22:14:36 +0000 (22:14 +0000)]
[Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
https://bugs.webkit.org/show_bug.cgi?id=95770

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._log_error): Added to replace original _log.error().
(ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
(ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
(ChromiumAndroidDriver._push_executable):
(ChromiumAndroidDriver._push_fonts):
(ChromiumAndroidDriver._push_test_resources):
(ChromiumAndroidDriver._run_adb_command):
(ChromiumAndroidDriver._get_last_stacktrace):
(ChromiumAndroidDriver._get_crash_log):
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver._start_once):
(ChromiumAndroidDriver._start_once.deadlock_detector):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidDriverTest.test_get_crash_log):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rebaseline Windows expected results for accessibility\canvas-description...
roger_fong@apple.com [Tue, 4 Sep 2012 22:14:20 +0000 (22:14 +0000)]
Unreviewed. Rebaseline Windows expected results for accessibility\canvas-description-and-role-expected.txt.
One of the results in the test now passes.

* platform/win/accessibility/canvas-description-and-role-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Update test expectations for Android.
wangxianzhu@chromium.org [Tue, 4 Sep 2012 21:48:47 +0000 (21:48 +0000)]
Unreviewed. Update test expectations for Android.

* platform/chromium-android/TestExpectations:
* platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression(r127163): Heap-use-after-free in WebCore::RenderBoxModelObject::hasSelfPai...
robert@webkit.org [Tue, 4 Sep 2012 21:35:11 +0000 (21:35 +0000)]
Regression(r127163): Heap-use-after-free in WebCore::RenderBoxModelObject::hasSelfPaintingLayer
https://bugs.webkit.org/show_bug.cgi?id=95632

Reviewed by Abhishek Arya.

Source/WebCore:

Don't add floats to the floating object set of blocks that avoid floats. There's no point in doing that
and they will never get cleared out during relayout.

Tests: fast/css/intruding-floats-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clearFloatsIfNeeded):

LayoutTests:

* fast/css/intruding-floats-crash-expected.txt: Added.
* fast/css/intruding-floats-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoequal() in CSSParser.cpp should check the length of characters
msaboff@apple.com [Tue, 4 Sep 2012 21:32:19 +0000 (21:32 +0000)]
equal() in CSSParser.cpp should check the length of characters
https://bugs.webkit.org/show_bug.cgi?id=95706

Source/WebCore:

Reviewed by Abhishek Arya.

Pass the length of string literals to CSSParser static functions equal() and
equalIgnoringCase() so that checks won't access out of bounds memory.

Added test fast/css/crash-comparing-equal.html.

* css/CSSParser.cpp:
(WebCore::equal): Use template to retrieve the length of string literal.
(WebCore::equalIgnoringCase): Ditto.
(WebCore::CSSParser::parseDashboardRegions): Use const char[] instead of const char*

LayoutTests:

Added test from duplicate defect https://bugs.webkit.org/show_bug.cgi?id=95634.

Reviewed by Abhishek Arya.

* fast/css/crash-comparing-equal-expected.txt: Added.
* fast/css/crash-comparing-equal.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127508 268f45cc-cd09-0410-ab3c-d52691b4dbfc