WebKit-https.git
7 years agoIndexedDB: simplify RecordIdentifier
alecflett@chromium.org [Mon, 19 Nov 2012 19:15:26 +0000 (19:15 +0000)]
IndexedDB: simplify RecordIdentifier
https://bugs.webkit.org/show_bug.cgi?id=102018

Reviewed by Tony Chang.

Source/WebCore:

Make IDBBackingStore's RecordIdentifier be a simple
class, existing only as an inline or stack-based instance.
This makes much of the copy semantics more explicit, and
removes refcounting from an object that only ever had a refcount
of 1 or 2.

No new tests, just a refactor.

* Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::putRecord):
(WebCore::IDBBackingStore::deleteRecord):
(WebCore::IDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBBackingStore::putIndexDataForRecord):
(WebCore::IDBBackingStore::deleteIndexDataForRecord):
(WebCore::ObjectStoreKeyCursorImpl::loadCurrentRow):
(ObjectStoreCursorImpl):
(WebCore::ObjectStoreCursorImpl::loadCurrentRow):
(WebCore::IndexKeyCursorImpl::recordIdentifier):
(WebCore::IndexCursorImpl::recordIdentifier):
* Modules/indexeddb/IDBBackingStore.h:
(WebCore::IDBBackingStore::RecordIdentifier::RecordIdentifier):
(WebCore::IDBBackingStore::RecordIdentifier::isValid):
(WebCore::IDBBackingStore::RecordIdentifier::reset):
(RecordIdentifier):
(IDBBackingStore):
(WebCore::IDBBackingStore::Cursor::recordIdentifier):
(WebCore::IDBBackingStore::Cursor::Cursor):
(Cursor):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):

Source/WebKit/chromium:

Update IDBFakeBackingStore to match its parent class.

* tests/IDBFakeBackingStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImprove ContentTypeParser, so that it could be used to validate mime type according...
commit-queue@webkit.org [Mon, 19 Nov 2012 18:57:38 +0000 (18:57 +0000)]
Improve ContentTypeParser, so that it could be used to validate mime type according to RFC
https://bugs.webkit.org/show_bug.cgi?id=100927

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-11-19
Reviewed by Alexey Proskuryakov.

This patch adds ParsedContentType class that represents contents of parsed
content type string. isValidContentType function could be used to check if
format of the content type string is acorrding to RFC 2616 section 4.2.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* platform/network/MIMEHeader.cpp:
(WebCore::MIMEHeader::parseHeader):
* platform/network/ParsedContentType.cpp: Renamed from Source/WebCore/platform/network/ContentTypeParser.cpp.
(WebCore):
(EmptyParsedContentType):
(WebCore::EmptyParsedContentType::setContentType):
(WebCore::EmptyParsedContentType::setContentTypeParameter):
(WebCore::skipSpaces):
(WebCore::isTokenCharacter):
(WebCore::parseToken):
(WebCore::parseQuotedString):
(WebCore::substringForRange):
(WebCore::parseContentType):
(WebCore::isValidContentType):
(WebCore::ParsedContentType::ParsedContentType):
(WebCore::ParsedContentType::charset):
(WebCore::ParsedContentType::parameterValueForName):
(WebCore::ParsedContentType::parameterCount):
(WebCore::ParsedContentType::setContentType):
(WebCore::ParsedContentType::setContentTypeParameter):
* platform/network/ParsedContentType.h: Renamed from Source/WebCore/platform/network/ContentTypeParser.h.
(WebCore):
(ParsedContentType):
(WebCore::ParsedContentType::mimeType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate DOMException name: InvalidNodeTypeError
arv@chromium.org [Mon, 19 Nov 2012 18:20:00 +0000 (18:20 +0000)]
Update DOMException name: InvalidNodeTypeError
https://bugs.webkit.org/show_bug.cgi?id=102519

Reviewed by Kentaro Hara.

Patch 24 of 25 to update DOMException name to match the spec and Firefox.

No code uses DOMException InvalidNodeTypeError. We do use INVALID_NODE_TYPE_ERR for RangeException. See bug 102515.

* dom/DOMCoreException.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChanging id, className, or attribute should invalidate distribution
shinyak@chromium.org [Mon, 19 Nov 2012 18:14:04 +0000 (18:14 +0000)]
Changing id, className, or attribute should invalidate distribution
https://bugs.webkit.org/show_bug.cgi?id=100738

Reviewed by Dimitri Glazkov.

PerformanceTests:

Added test code to modify id/class/attribute.

* DOM/ModifyAttribute.html: Added.
* DOM/resources/dom-perf/modify-attribute.js: Added.
(ModifyAttribute.CreateElementToSetUp):
(ModifyAttribute.ModifyId):
(ModifyAttribute.ModifyClass):
(ModifyAttribute.ModifyTitle):

Source/WebCore:

When id, className, or attribute is changed, we might have to invalidate distribution.
However, we don't want to do useless invalidation. So we consult with the RuleFeatureSet of ElementShadow
to invalidate distribution only if necessary.

For the code that className is changed, we can share a lot of code between invalidating distribution and
invalidating style. So we made checkNeedsStyleInvalidationForClassChange a template method, and share it.

Since attributeChanged() is a hot method, we don't want to make it slow. So we made one function to determine
whether we have to invalidate distribution, and make it called only if necessary. Also, we've optimized
shadowOfParentForDistribution() by making isInsertionPoint() de-virtualed. We consuded NodeFlags (IsInsertionPointFlag)
for this purpose.

We've measured how this patch makes changing attribute slow. I've measured each code 3 times.
DOM/ModifyAttribute.html is a micro benchmark which changes attribute a lot of times. The result of this benchmark
will be the most affected by this patch. However, it's only 2% performance regression.

DOM/ModifyAttribute.html
Before this patch:
        median  stdev    min    max    [ms]
  1st    494.0   3.36  490.0  502.0
  2nd    503.5   3.44  497.0  512.0
  3rd    494.0   3.48  488.0  499.0

After this patch:
        median  stdev  min      max    [ms]
  1st    504.0   2.00  501.0  509.0
  2nd    505.5   3.08  500.0  513.0
  3rd    507.0   2.32  502.0  510.0

Tests: fast/dom/shadow/distribution-attribute-modified.html
       fast/dom/shadow/distribution-className-modified.html
       fast/dom/shadow/distribution-id-modified.html
       fast/dom/shadow/reprojection-attribute-modified.html
       fast/dom/shadow/reprojection-className-modified.html
       fast/dom/shadow/reprojection-id-modified.html

* dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore::HasSelectorForClassStyleFunctor::HasSelectorForClassStyleFunctor):
(HasSelectorForClassStyleFunctor):
(WebCore::HasSelectorForClassStyleFunctor::operator()): Returns true if StyleResolver::hasSelectorForClass returns true.
(WebCore):
(WebCore::HasSelectorForClassDistributionFunctor::HasSelectorForClassDistributionFunctor):
(HasSelectorForClassDistributionFunctor):
(WebCore::HasSelectorForClassDistributionFunctor::operator()): Returns true if ElementShadow::hasSelectForClass returns true.
(WebCore::checkFunctorForClassChange):
(WebCore::checkNeedsStyleInvalidationForClassChange):
(WebCore::checkNeedsDistributionInvalidationForClassChange): Extracted the implementation to checkFunctorForClassChange.
(WebCore::Element::shouldInvalidateDistributionWhenAttributeChanged):
* dom/Element.h:
(Element):
* dom/Node.h:
(WebCore::Node::isInsertionPoint):
* html/HTMLElement.h:
(HTMLElement):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::InsertionPoint):
* html/shadow/InsertionPoint.h:
(InsertionPoint):
(WebCore::isInsertionPoint):
(WebCore::shadowOfParentForDistribution):
(WebCore::resolveReprojection):

LayoutTests:

We have test cases that id/class/attribute is changed, and thier reprojection cases.

* fast/dom/shadow/distribution-attribute-modified-expected.html: Added.
* fast/dom/shadow/distribution-attribute-modified.html: Added.
* fast/dom/shadow/distribution-className-modified-expected.html: Added.
* fast/dom/shadow/distribution-className-modified.html: Added.
* fast/dom/shadow/distribution-id-modified-expected.html: Added.
* fast/dom/shadow/distribution-id-modified.html: Added.
* fast/dom/shadow/reprojection-attribute-modified-expected.html: Added.
* fast/dom/shadow/reprojection-attribute-modified.html: Added.
* fast/dom/shadow/reprojection-className-modified-expected.html: Added.
* fast/dom/shadow/reprojection-className-modified.html: Added.
* fast/dom/shadow/reprojection-id-modified-expected.html: Added.
* fast/dom/shadow/reprojection-id-modified.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove empty loading to DocumentLoader, simplify FrameLoader::init()
japhet@chromium.org [Mon, 19 Nov 2012 18:00:55 +0000 (18:00 +0000)]
Move empty loading to DocumentLoader, simplify FrameLoader::init()
https://bugs.webkit.org/show_bug.cgi?id=101512

Reviewed by Adam Barth.

Source/WebCore:

No new tests, though several outputs changed because we no longer send resource
    load callbacks for empty loads.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::clearMainResourceLoader):
(WebCore::DocumentLoader::isLoadingInAPISense):
(WebCore::DocumentLoader::isLoadingMainResource):
(WebCore::DocumentLoader::maybeLoadEmpty):
(WebCore):
(WebCore::DocumentLoader::startLoadingMainResource): Handle empty main resource
     loads directly here.
* loader/DocumentLoader.h:
(DocumentLoader):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader): Initialize some variables whose values
    were previously being reset in init(). Given that the FrameLoader is in
    an inconsistent state before init() is called anyway, there doesn't seem
    to be a disadvantage to just initializing them to their post-init() values.
(WebCore::FrameLoader::init): Just call startLoadingMainResource(), instead of
    doing a bunch of direct calls to functions FrameLoader shouldn't know about.
* loader/FrameLoaderStateMachine.cpp:
(WebCore::FrameLoaderStateMachine::FrameLoaderStateMachine):
* loader/FrameLoaderStateMachine.h:
* loader/MainResourceLoader.cpp: Throughout, remove the concept of an empty load.
(WebCore::MainResourceLoader::loadNow): This only returned true when an empty
    load got deferred, which won't happen now. Return void and always treat
    as returning false.
* loader/MainResourceLoader.h:
(MainResourceLoader):

Tools:

Chromium DRT has some code that doesn't play nicely with empty urls and incorrectly
interprets them as a non-empty load. This ensures
http/tests/navigation/new-window-redirect-history.html continues to pass
in chromium.

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::updateForCommittedLoad):

LayoutTests:

Don't expect resource load callbacks for empty loads.

* http/tests/inspector/network/network-iframe-load-and-delete.html:
* http/tests/loading/redirect-methods-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r132907): It made animations/negative-delay.html flaky https://bugs.webkit...
kbalazs@webkit.org [Mon, 19 Nov 2012 17:58:48 +0000 (17:58 +0000)]
REGRESSION(r132907): It made animations/negative-delay.html flaky https://bugs.webkit.org/show_bug.cgi?id=100769

Unreviewed gardening (Qt).

These tests are rather flaky, mark them as so.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove WebKit::WebRuntimeFeatures::enablePointerLock.
scheib@chromium.org [Mon, 19 Nov 2012 17:51:10 +0000 (17:51 +0000)]
[Chromium] Remove WebKit::WebRuntimeFeatures::enablePointerLock.
https://bugs.webkit.org/show_bug.cgi?id=96946

Reviewed by Adam Barth.

The runtime flag functionality has already been removed.
Now that Chromium no longer has a compile dependency on this
API, it can be removed as well.

Source/WebKit/chromium:

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:

Tools:

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate DOMException name: TimeoutError
arv@chromium.org [Mon, 19 Nov 2012 17:36:40 +0000 (17:36 +0000)]
Update DOMException name: TimeoutError
https://bugs.webkit.org/show_bug.cgi?id=102513

Reviewed by Kentaro Hara.

Patch 23 of 25 to update DOMException name to match the spec and Firefox.

No code uses DOMException TimeoutError. We do use TIMEOUT_ERR for XMLHttpRequestException. See bug 102506.

* dom/DOMCoreException.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate DOMException name: DataCloneError
arv@chromium.org [Mon, 19 Nov 2012 17:10:23 +0000 (17:10 +0000)]
Update DOMException name: DataCloneError
https://bugs.webkit.org/show_bug.cgi?id=102521

Reviewed by Kentaro Hara.

Source/WebCore:

Patch 25 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

* dom/DOMCoreException.cpp:

LayoutTests:

Updated tests and expectations.

* fast/dom/Window/anonymous-slot-with-changes-expected.txt:
* fast/dom/Window/window-postmessage-clone-expected.txt:
* fast/dom/shadow/shadowroot-clonenode-expected.txt:
* fast/dom/shadow/shadowroot-clonenode.html:
* fast/events/message-port-multi-expected.txt:
* fast/filesystem/filesystem-unserializable-expected.txt:
* platform/chromium/fast/dom/Window/window-postmessage-clone-expected.txt:
* platform/chromium/fast/dom/Window/window-postmessage-clone-really-deep-array-expected.txt:
* platform/gtk/fast/dom/Window/window-postmessage-clone-expected.txt:
* webintents/web-intents-obj-constructor-expected.txt:
* webintents/web-intents-obj-constructor.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImprove performance of RenderBoxModelObject::paintTranslucentBorderSides()
commit-queue@webkit.org [Mon, 19 Nov 2012 16:56:46 +0000 (16:56 +0000)]
Improve performance of RenderBoxModelObject::paintTranslucentBorderSides()
https://bugs.webkit.org/show_bug.cgi?id=98660

Patch by Tom Hudson <tomhudson@chromium.org> on 2012-11-19
Reviewed by Simon Fraser.

Accumulate edges[i].shouldRender() in a flag field and pass that to paintBorderSides()
and paintTranslucentBorderSides() so that we don't do unnecessary work.

If we can avoid setting up and tearing down an unnecessary transparent layer we save
30ms on some mobile platforms.

* rendering/RenderBoxModelObject.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] remove null exclusion shape check from ExclusionShape::createExclusi...
commit-queue@webkit.org [Mon, 19 Nov 2012 16:54:54 +0000 (16:54 +0000)]
[CSS Exclusions] remove null exclusion shape check from ExclusionShape::createExclusionShape
https://bugs.webkit.org/show_bug.cgi?id=100765

Patch by Hans Muller <hmuller@adobe.com> on 2012-11-19
Reviewed by Dirk Schulze.

ExclusionShape::createExclusionShape now ASSERTs that its basicShape argument
isn't null, since the caller is expected to ensure as much.  No new tests were
needed since this is a near-trivial cleanup.

* rendering/ExclusionShape.cpp:
(WebCore::ExclusionShape::createExclusionShape): This method no longer defends against a null basicShape argument by returning null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse device scale factor instead of physical screen DPI for screen DPI
commit-queue@webkit.org [Mon, 19 Nov 2012 16:41:48 +0000 (16:41 +0000)]
Use device scale factor instead of physical screen DPI for screen DPI
https://bugs.webkit.org/show_bug.cgi?id=101769

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-11-19
Reviewed by Adam Barth.

Media queries call WebCore::Screen::{horizontal,vertical}DPI() to determine
the dots per CSS inch[1] value for the "screen" media type. On Chromium these
functions currently return the physical screen DPI, which is wrong. To fix
this, we remove both of these functions entirely and make media queries use
the device scale factor multiplied by 96 on all ports.

[1] http://www.w3.org/TR/css3-mediaqueries/#resolution0

* page/Screen.cpp:
(WebCore::Screen::horizontalDPI):
(WebCore::Screen::verticalDPI):
* platform/PlatformScreen.h:
(WebCore):
* platform/blackberry/PlatformScreenBlackBerry.cpp:
* platform/chromium/PlatformScreenChromium.cpp:
* platform/efl/PlatformScreenEfl.cpp:
* platform/gtk/PlatformScreenGtk.cpp:
* platform/mac/PlatformScreenMac.mm:
* platform/qt/PlatformScreenQt.cpp:
* platform/win/PlatformScreenWin.cpp:
* platform/wx/ScreenWx.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoComputed grid items' positions shouldn't be using Length
jchaffraix@webkit.org [Mon, 19 Nov 2012 16:39:38 +0000 (16:39 +0000)]
Computed grid items' positions shouldn't be using Length
https://bugs.webkit.org/show_bug.cgi?id=102537

Reviewed by Tony Chang.

This change refactors how we store the grid items' position to use
a new type GridPosition. Length was a temporary type as it supported
'auto' | <integer> but it was starting to get more and more confusing
as we were implementing the layout routines.

No change in behavior.

* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Added the new file to the build systems.

* rendering/style/RenderStyle.h:
Updated after the type change. Also made some getters
return a const reference instead of forcing a copy.

* rendering/style/StyleGridItemData.h:
(StyleGridItemData):
Ditto, also removed a comment about adding a new type.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForGridPosition):
* css/StyleResolver.cpp:
(WebCore::createGridPosition):
(WebCore::StyleResolver::applyProperty):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::resolveGridPosition):
Updated these sites after switching to GridPosition.

* rendering/RenderGrid.h:
Changed resolveGridPosition signature: it now takes a GridPosition.

* rendering/style/GridPosition.h: Added.
(WebCore::GridPosition::GridPosition):
Default constructor, creates an 'auto' position.

(WebCore::GridPosition::isPositive):
(WebCore::GridPosition::type):
(WebCore::GridPosition::isAuto):
(WebCore::GridPosition::setIntegerPosition):
(WebCore::GridPosition::integerPosition):
Helper functions.

(WebCore::GridPosition::operator==):
Required comparison operator for StyleGridItemData.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoApply the resolved viewport rules
commit-queue@webkit.org [Mon, 19 Nov 2012 16:37:01 +0000 (16:37 +0000)]
Apply the resolved viewport rules
https://bugs.webkit.org/show_bug.cgi?id=95964

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

This patch implements the CSS Device Adaptation specification. The
WebKit implementation relies on the already implemented Viewport Meta
infrastructure to notify the browser of viewport changes.

The implementation was tests with success on the Qt and EFL ports, but
basically every port supporting Viewport Meta should be fine.

The usage of @-webkit-viewport inside media queries (more tests coming
to map all the corner cases) is currently limited when the media query
depends on the viewport dimensions itself. Defining the width and height
based on screen size will fail on ports reporting the screen
size as the size of the browser window instead of the device screen.

Tests: css3/device-adapt/opera/cascading-001.xhtml
       css3/device-adapt/opera/cascading-002.xhtml
       css3/device-adapt/opera/cascading-003.xhtml
       css3/device-adapt/opera/cascading-004.xhtml
       css3/device-adapt/opera/constrain-001.xhtml
       css3/device-adapt/opera/constrain-002.xhtml
       css3/device-adapt/opera/constrain-003.xhtml
       css3/device-adapt/opera/constrain-004.xhtml
       css3/device-adapt/opera/constrain-005.xhtml
       css3/device-adapt/opera/constrain-006.xhtml
       css3/device-adapt/opera/constrain-007.xhtml
       css3/device-adapt/opera/constrain-008.xhtml
       css3/device-adapt/opera/constrain-009.xhtml
       css3/device-adapt/opera/constrain-010.xhtml
       css3/device-adapt/opera/constrain-011.xhtml
       css3/device-adapt/opera/constrain-012.xhtml
       css3/device-adapt/opera/constrain-013.xhtml
       css3/device-adapt/opera/constrain-014.xhtml
       css3/device-adapt/opera/constrain-015.xhtml
       css3/device-adapt/opera/constrain-016.xhtml
       css3/device-adapt/opera/constrain-017.xhtml
       css3/device-adapt/opera/constrain-020.xhtml
       css3/device-adapt/opera/syntax-001.xhtml
       css3/device-adapt/opera/syntax-002.xhtml
       css3/device-adapt/opera/syntax-003.xhtml

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSAllInOne.cpp:
* css/RuleSet.cpp:
(WebCore::RuleSet::addRulesFromSheet):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::~StyleResolver):
* css/StyleResolver.h:
(StyleResolver):
(WebCore::StyleResolver::viewportStyleResolver):
* css/ViewportStyleResolver.cpp: Added.
(WebCore):
(WebCore::ViewportStyleResolver::ViewportStyleResolver):
(WebCore::ViewportStyleResolver::addViewportRule):
(WebCore::ViewportStyleResolver::clearDocument):
(WebCore::ViewportStyleResolver::resolve):
(WebCore::ViewportStyleResolver::getViewportArgumentValue):
* css/ViewportStyleResolver.h: Added.
(WebCore):
(ViewportStyleResolver):
(WebCore::ViewportStyleResolver::create):
* dom/Document.h:
(WebCore::Document::setViewportArguments):
* dom/ViewportArguments.cpp:
(WebCore::compareIgnoringAuto):
(WebCore):
(WebCore::ViewportArguments::resolve):
* dom/ViewportArguments.h:
(ViewportAttributes):
(WebCore::ViewportArguments::ViewportArguments):
(ViewportArguments):
(WebCore::ViewportArguments::operator==):

LayoutTests:

Imported some of the CSS Device Adaptation tests submitted by
Opera to W3C CSS Test Suite. These tests are not yet approved but
they have a pretty good coverage of the specification.

Tests using Math.floor() where modified from the original version
using Math.round(), the reason being the round() version fails by
1px when the pixel ratio is different from 1.

Despite the fact they are all passing on the EFL MiniBrowser, I could
not enable them yet. WebKitTestRunner does not support fixed layout,
but that is the next goal.

* css3/device-adapt/opera/cascading-001-expected.txt: Added.
* css3/device-adapt/opera/cascading-001.xhtml: Added.
* css3/device-adapt/opera/cascading-002-expected.txt: Added.
* css3/device-adapt/opera/cascading-002.xhtml: Added.
* css3/device-adapt/opera/cascading-003-expected.txt: Added.
* css3/device-adapt/opera/cascading-003.xhtml: Added.
* css3/device-adapt/opera/cascading-004-expected.txt: Added.
* css3/device-adapt/opera/cascading-004.xhtml: Added.
* css3/device-adapt/opera/constrain-001-expected.txt: Added.
* css3/device-adapt/opera/constrain-001.xhtml: Added.
* css3/device-adapt/opera/constrain-002-expected.txt: Added.
* css3/device-adapt/opera/constrain-002.xhtml: Added.
* css3/device-adapt/opera/constrain-003-expected.txt: Added.
* css3/device-adapt/opera/constrain-003.xhtml: Added.
* css3/device-adapt/opera/constrain-004-expected.txt: Added.
* css3/device-adapt/opera/constrain-004.xhtml: Added.
* css3/device-adapt/opera/constrain-005-expected.txt: Added.
* css3/device-adapt/opera/constrain-005.xhtml: Added.
* css3/device-adapt/opera/constrain-006-expected.txt: Added.
* css3/device-adapt/opera/constrain-006.xhtml: Added.
* css3/device-adapt/opera/constrain-007-expected.txt: Added.
* css3/device-adapt/opera/constrain-007.xhtml: Added.
* css3/device-adapt/opera/constrain-008-expected.txt: Added.
* css3/device-adapt/opera/constrain-008.xhtml: Added.
* css3/device-adapt/opera/constrain-009-expected.txt: Added.
* css3/device-adapt/opera/constrain-009.xhtml: Added.
* css3/device-adapt/opera/constrain-010-expected.txt: Added.
* css3/device-adapt/opera/constrain-010.xhtml: Added.
* css3/device-adapt/opera/constrain-011-expected.txt: Added.
* css3/device-adapt/opera/constrain-011.xhtml: Added.
* css3/device-adapt/opera/constrain-012-expected.txt: Added.
* css3/device-adapt/opera/constrain-012.xhtml: Added.
* css3/device-adapt/opera/constrain-013-expected.txt: Added.
* css3/device-adapt/opera/constrain-013.xhtml: Added.
* css3/device-adapt/opera/constrain-014-expected.txt: Added.
* css3/device-adapt/opera/constrain-014.xhtml: Added.
* css3/device-adapt/opera/constrain-015-expected.txt: Added.
* css3/device-adapt/opera/constrain-015.xhtml: Added.
* css3/device-adapt/opera/constrain-016-expected.txt: Added.
* css3/device-adapt/opera/constrain-016.xhtml: Added.
* css3/device-adapt/opera/constrain-017-expected.txt: Added.
* css3/device-adapt/opera/constrain-017.xhtml: Added.
* css3/device-adapt/opera/constrain-020-expected.txt: Added.
* css3/device-adapt/opera/constrain-020.xhtml: Added.
* css3/device-adapt/opera/syntax-001-expected.txt: Added.
* css3/device-adapt/opera/syntax-001.xhtml: Added.
* css3/device-adapt/opera/syntax-002-expected.txt: Added.
* css3/device-adapt/opera/syntax-002.xhtml: Added.
* css3/device-adapt/opera/syntax-003-expected.txt: Added.
* css3/device-adapt/opera/syntax-003.xhtml: Added.
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate DOMException name: SecurityError
arv@chromium.org [Mon, 19 Nov 2012 16:26:43 +0000 (16:26 +0000)]
Update DOMException name: SecurityError
https://bugs.webkit.org/show_bug.cgi?id=102437

Reviewed by Kentaro Hara.

Source/WebCore:

Patch 18 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

* dom/DOMCoreException.cpp:

LayoutTests:

Updated tests and expectations.

* fast/canvas/svg-taint-expected.txt:
* fast/dom/Document/invalid-domain-change-throws-exception-expected.txt:
* fast/dom/Document/script-tests/invalid-domain-change-throws-exception.js:
* fast/dom/register-protocol-handler.html:
* fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
* fast/frames/sandboxed-iframe-storage-expected.txt:
* http/tests/loading/state-object-security-exception-expected.txt:
* http/tests/notifications/legacy/show-expected.txt:
* http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin-expected.txt:
* http/tests/security/canvas-remote-read-remote-image-expected.txt:
* http/tests/security/canvas-remote-read-remote-image-redirect-expected.txt:
* http/tests/security/contentSecurityPolicy/worker-script-src-expected.txt:
* http/tests/security/cross-origin-local-storage-expected.txt:
* http/tests/security/cross-origin-session-storage-expected.txt:
* http/tests/security/cross-origin-websql-expected.txt:
* http/tests/security/cross-origin-worker-websql-expected.txt:
* http/tests/security/resources/sandboxed-iframe-document-cookie-read-denied.html:
* http/tests/security/same-origin-storage-blocked-expected.txt:
* http/tests/security/same-origin-websql-blocked-expected.txt:
* http/tests/security/setDomainRelaxationForbiddenForURLScheme-expected.txt:
* http/tests/security/storage-blocking-loosened-local-storage-expected.txt:
* http/tests/security/storage-blocking-loosened-websql-expected.txt:
* http/tests/security/storage-blocking-strengthened-local-storage-expected.txt:
* http/tests/security/storage-blocking-strengthened-websql-expected.txt:
* http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin-expected.txt:
* http/tests/websocket/tests/hybi/url-parsing-expected.txt:
* http/tests/workers/shared-worker-redirect-expected.txt:
* http/tests/workers/worker-redirect-expected.txt:
* platform/chromium-win/websocket/tests/url-parsing-expected.txt:
* platform/chromium/fast/dom/register-protocol-handler-expected.txt:
* platform/chromium/http/tests/websocket/tests/hixie76/url-parsing-expected.txt:
* platform/chromium/http/tests/websocket/tests/hybi/url-parsing-expected.txt:
* platform/chromium/permissionclient/storage-permission-expected.txt:
* platform/win-wk2/http/tests/inspector-enabled/database-open-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening after r133898.
yael@webkit.org [Mon, 19 Nov 2012 16:00:35 +0000 (16:00 +0000)]
Unreviewed gardening after r133898.
Added expected results for animation tests that are now passing.

* platform/efl/TestExpectations:
* platform/efl/animations/3d: Added.
* platform/efl/animations/3d/change-transform-in-end-event-expected.png: Added.
* platform/efl/animations/3d/change-transform-in-end-event-expected.txt: Added.
* platform/efl/animations/3d/matrix-transform-type-animation-expected.png: Added.
* platform/efl/animations/3d/matrix-transform-type-animation-expected.txt: Added.
* platform/efl/animations/3d/state-at-end-event-transform-expected.png: Added.
* platform/efl/animations/3d/state-at-end-event-transform-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate DOMException name: URLMismatchError
arv@chromium.org [Mon, 19 Nov 2012 15:53:52 +0000 (15:53 +0000)]
Update DOMException name: URLMismatchError
https://bugs.webkit.org/show_bug.cgi?id=102511

Reviewed by Kentaro Hara.

Source/WebCore:

Patch 21 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

* dom/DOMCoreException.cpp:
(WebCore):

LayoutTests:

Updated tests and expectations.

* fast/workers/shared-worker-shared-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd PROXIMITY_EVENTS feature
kihong.kwon@samsung.com [Mon, 19 Nov 2012 15:42:53 +0000 (15:42 +0000)]
Add PROXIMITY_EVENTS feature
https://bugs.webkit.org/show_bug.cgi?id=102658

Reviewed by Kentaro Hara.

.:

Add PROXIMITY_EVENTS feature to cmake.

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Add PROXIMITY_EVENTS feature to xcode project for JavaScriptCore.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Add PROXIMITY_EVENTS feature to xcode project for WebCorei and GNU make.

No new tests. Just add a new feature.

* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.features.am:

Source/WebKit/chromium:

Add PROXIMITY_EVENTS feature to chromium port.

* features.gypi:

Source/WebKit/mac:

Add PROXIMITY_EVENTS feature to xcode project for WebKit.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Add PROXIMITY_EVENTS feature to xcode project for WebKit2.

* Configurations/FeatureDefines.xcconfig:

Tools:

Add PROXIMITY_EVENTS feature to FeatureList and qmake.

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

WebKitLibraries:

Add PROXIMITY_EVENTS feature to win and win-cairo prot.

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Dim a component's subitems' color in NMI snapshot
commit-queue@webkit.org [Mon, 19 Nov 2012 15:39:45 +0000 (15:39 +0000)]
Web Inspector: Dim a component's subitems' color in NMI snapshot
https://bugs.webkit.org/show_bug.cgi?id=102224

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-19
Reviewed by Yury Semikhatsky.

* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeSnapshotNode.prototype._createSizeCell):
* inspector/front-end/nativeMemoryProfiler.css:
(.native-snapshot-view .data-grid .dimmed div.size-bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate DOMException name: NetworkError
arv@chromium.org [Mon, 19 Nov 2012 15:35:13 +0000 (15:35 +0000)]
Update DOMException name: NetworkError
https://bugs.webkit.org/show_bug.cgi?id=102503

Reviewed by Kentaro Hara.

Patch 19 of 25 to update DOMException name to match the spec and Firefox.

No code uses DOMException NetworkError. We do use NETWORK_ERR for XMLHttpRequestException. See bug 102506.

* dom/DOMCoreException.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebaudio: clean-up. Replace AudioContext::m_document member with ContextDestructionOb...
loislo@chromium.org [Mon, 19 Nov 2012 15:26:04 +0000 (15:26 +0000)]
webaudio: clean-up. Replace AudioContext::m_document member with ContextDestructionObserver::scriptExecutionContext().
https://bugs.webkit.org/show_bug.cgi?id=102649

Reviewed by Adam Barth.

AudioContext uses m_document only as a pointer to ScriptExecutionContext.
It could be safely replaced with ContextDestructionObserver::m_scriptExecutionContext.
The lifetime of m_scriptExecutionContext is slightly different but it could be adjusted by m_isStopScheduled flag.

No new tests as there is no new functionality.

* Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::looping):
(WebCore::AudioBufferSourceNode::setLooping):
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::stop):
(WebCore::AudioContext::scriptExecutionContext):
(WebCore::AudioContext::fireCompletionEvent):
(WebCore::AudioContext::reportMemoryUsage):
* Modules/webaudio/AudioContext.h:
(AudioContext):
* Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::fireProcessEvent):
(WebCore::ScriptProcessorNode::scriptExecutionContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Unreviewed gardening, unskip a now passing test.
ossy@webkit.org [Mon, 19 Nov 2012 15:24:14 +0000 (15:24 +0000)]
[Qt][WK2] Unreviewed gardening, unskip a now passing test.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Fix possible crash in EwkViewImpl::displayTimerFired()
commit-queue@webkit.org [Mon, 19 Nov 2012 14:58:13 +0000 (14:58 +0000)]
[EFL][WK2] Fix possible crash in EwkViewImpl::displayTimerFired()
https://bugs.webkit.org/show_bug.cgi?id=102682

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-19
Reviewed by Kenneth Rohde Christiansen.

Add NULL check for DrawingAreaProxy and LayerTreeCoordinatorProxy
in displayTimerFired() to avoid crashing if those have already
been destroyed by the time to timer is fired.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::layerTreeRenderer):
(EwkViewImpl::displayTimerFired):
(EwkViewImpl::createGLSurface):
(EwkViewImpl::enterAcceleratedCompositingMode):
* UIProcess/API/efl/EwkViewImpl.h:
(WebKit):
(EwkViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip new failing tests.
ossy@webkit.org [Mon, 19 Nov 2012 14:55:12 +0000 (14:55 +0000)]
[Qt] Unreviewed gardening, skip new failing tests.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Removed, because it is unnecessary.
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebaudio: leak: AudioContext objects are leaking. They retain 36mb of shared data.
loislo@chromium.org [Mon, 19 Nov 2012 14:53:38 +0000 (14:53 +0000)]
webaudio: leak: AudioContext objects are leaking. They retain 36mb of shared data.
https://bugs.webkit.org/show_bug.cgi?id=102356

Reviewed by Adam Barth.

A clean-up code was moved from uninitialize to clear method.
AudioContext marks itself as hasPendingActivity in method constructCommon and unmarks itself in method clear.
m_isStopScheduled filters out second ActiveDOMObject::stop call.
markForDeletion appends AudioNode pointer to m_nodesToDelete array if there is no active audio thread.
adoptRef was added in createOfflineContext method.
A guard was added into deleteMarkedNodes.

Source/WebCore:

Test: inspector-protocol/nmi-webaudio-leak-test.html

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createOfflineContext):
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::constructCommon):
(WebCore::AudioContext::~AudioContext):
(WebCore::AudioContext::clear):
(WebCore::AudioContext::uninitialize):
(WebCore::AudioContext::stopDispatch):
(WebCore::AudioContext::stop):
(WebCore::AudioContext::markForDeletion):
(WebCore::AudioContext::scheduleNodeDeletion):
(WebCore::AudioContext::deleteMarkedNodes):
* Modules/webaudio/AudioContext.h:
(AudioContext):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback):
* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
* platform/PlatformMemoryInstrumentation.cpp:
(WebCore::PlatformMemoryInstrumentation::reportMemoryUsage):
(WebCore):
* platform/PlatformMemoryInstrumentation.h:
(PlatformMemoryInstrumentation):
(WebCore):

LayoutTests:

* inspector-protocol/nmi-webaudio-leak-test-expected.txt: Added.
* inspector-protocol/nmi-webaudio-leak-test.html: Added.
* platform/chromium-android/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][WTR] Memory leak in TestController::initialize()
commit-queue@webkit.org [Mon, 19 Nov 2012 14:50:40 +0000 (14:50 +0000)]
[WK2][WTR] Memory leak in TestController::initialize()
https://bugs.webkit.org/show_bug.cgi?id=102616

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Export a few additional WTF symbols for windows port.

* win/WebKit2.def:

Tools:

Remove call to WKStringCreateWithUTF8CString() to construct
the icon database path which was leaking memory since the
returned WKStringRef was not adopted. The code now uses
WTF::String instead of std::string and converts it to a
WKStringRef using toWK().

* WebKitTestRunner/StringFunctions.h:
(WTR::toWK): Overload toWK() to take a WTF::String in
argument.
(WTR):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Use devicePixelRatio instead of screen DPI for computing viewport attributes
commit-queue@webkit.org [Mon, 19 Nov 2012 14:43:34 +0000 (14:43 +0000)]
[chromium] Use devicePixelRatio instead of screen DPI for computing viewport attributes
https://bugs.webkit.org/show_bug.cgi?id=101767

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-11-19
Reviewed by Adam Barth.

Use the newly introduced device scale factor to calculate viewport properties
instead of using the screen DPI. No functional changes, because Chromium
platforms that have VIEWPORT enabled now also initialize the device scale
factor accordingly.

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
* tests/WebFrameTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate DOMException name: QuotaExceededError
arv@chromium.org [Mon, 19 Nov 2012 14:30:46 +0000 (14:30 +0000)]
Update DOMException name: QuotaExceededError
https://bugs.webkit.org/show_bug.cgi?id=102512

Reviewed by Kentaro Hara.

Source/WebCore:

Patch 22 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

* dom/DOMCoreException.cpp:

LayoutTests:

Updated tests and expectations.

* security/crypto-random-values-limits-expected.txt:
* storage/domstorage/localstorage/private-browsing-affects-storage-expected.txt:
* storage/domstorage/sessionstorage/private-browsing-affects-storage-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate DOMException name: AbortError
arv@chromium.org [Mon, 19 Nov 2012 14:25:05 +0000 (14:25 +0000)]
Update DOMException name: AbortError
https://bugs.webkit.org/show_bug.cgi?id=102508

Reviewed by Kentaro Hara.

Patch 20 of 25 to update DOMException name to match the spec and Firefox.

No code uses DOMException AbortError. We do use ABORT_ERR for XMLHttpRequestException. See bug 102506.

* dom/DOMCoreException.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
haraken@chromium.org [Mon, 19 Nov 2012 13:43:21 +0000 (13:43 +0000)]
Unreviewed gardening.

* platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
haraken@chromium.org [Mon, 19 Nov 2012 13:40:58 +0000 (13:40 +0000)]
Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r135111.
haraken@chromium.org [Mon, 19 Nov 2012 13:36:09 +0000 (13:36 +0000)]
Unreviewed, rolling out r135111.
http://trac.webkit.org/changeset/135111
https://bugs.webkit.org/show_bug.cgi?id=102356

The patch caused crashes in several layout tests

Source/WebCore:

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createOfflineContext):
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::constructCommon):
(WebCore::AudioContext::~AudioContext):
(WebCore::AudioContext::uninitialize):
(WebCore::AudioContext::uninitializeDispatch):
(WebCore::AudioContext::stop):
(WebCore::AudioContext::markForDeletion):
(WebCore::AudioContext::scheduleNodeDeletion):
(WebCore::AudioContext::deleteMarkedNodes):
* Modules/webaudio/AudioContext.h:
(AudioContext):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback):
* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
* platform/PlatformMemoryInstrumentation.cpp:
(WebCore):
* platform/PlatformMemoryInstrumentation.h:

LayoutTests:

* inspector-protocol/nmi-webaudio-leak-test-expected.txt: Removed.
* inspector-protocol/nmi-webaudio-leak-test.html: Removed.
* platform/chromium-android/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r135116.
haraken@chromium.org [Mon, 19 Nov 2012 13:34:41 +0000 (13:34 +0000)]
Unreviewed, rolling out r135116.
http://trac.webkit.org/changeset/135116
https://bugs.webkit.org/show_bug.cgi?id=102649

Revert this patch to revert r135111, which caused crashes in
several layout tests

* Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::looping):
(WebCore::AudioBufferSourceNode::setLooping):
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::stop):
(WebCore::AudioContext::document):
(WebCore):
(WebCore::AudioContext::hasDocument):
(WebCore::AudioContext::scriptExecutionContext):
(WebCore::AudioContext::fireCompletionEvent):
(WebCore::AudioContext::reportMemoryUsage):
* Modules/webaudio/AudioContext.h:
(AudioContext):
* Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::fireProcessEvent):
(WebCore::ScriptProcessorNode::scriptExecutionContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
haraken@chromium.org [Mon, 19 Nov 2012 13:24:42 +0000 (13:24 +0000)]
Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Refine JsDoc in DebuggerScriptMapping.js
commit-queue@webkit.org [Mon, 19 Nov 2012 13:23:02 +0000 (13:23 +0000)]
Web Inspector: Refine JsDoc in DebuggerScriptMapping.js
https://bugs.webkit.org/show_bug.cgi?id=102673

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-19
Reviewed by Vsevolod Vlasov.

DebuggerScriptMapping calls public method "addScript" not defined
in SourceMapping interface.

To make things clear I've added ScriptSourceMapping interface that
extends SourceMapping interface by adding "addScript" method.

* inspector/front-end/SourceMapping.js: Added "ScriptSourceMapping".
* inspector/front-end/CompilerScriptMapping.js:
Updated "@implements" to ScriptSourceMapping.
* inspector/front-end/ResourceScriptMapping.js: Ditto.
* inspector/front-end/ScriptSnippetModel.js: Ditto.
* inspector/front-end/DebuggerScriptMapping.js: Updated signatures.
Removed useless code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
haraken@chromium.org [Mon, 19 Nov 2012 13:18:45 +0000 (13:18 +0000)]
Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
haraken@chromium.org [Mon, 19 Nov 2012 13:07:45 +0000 (13:07 +0000)]
Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rebaselined a text dump.
haraken@chromium.org [Mon, 19 Nov 2012 13:02:39 +0000 (13:02 +0000)]
Unreviewed. Rebaselined a text dump.

* platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
kkristof@inf.u-szeged.hu [Mon, 19 Nov 2012 11:47:45 +0000 (11:47 +0000)]
[Qt] Unreviewed gardening.

Update test expectation and skip a new failing test.

* platform/qt-5.0/fast/js/global-constructors-expected.txt:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, untested build fix.
timothy_horton@apple.com [Mon, 19 Nov 2012 11:38:24 +0000 (11:38 +0000)]
Unreviewed, untested build fix.

* bindings/scripts/IDLParser.pm:
(parseModule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS3] Move CSSPropertyWebkitTextAlignLast into isValidKeywordPropertyAndValue function
commit-queue@webkit.org [Mon, 19 Nov 2012 11:29:19 +0000 (11:29 +0000)]
[CSS3] Move CSSPropertyWebkitTextAlignLast into isValidKeywordPropertyAndValue function
https://bugs.webkit.org/show_bug.cgi?id=102303

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-11-19
Reviewed by Alexis Menard.

Move the part which check whether CSSPropertyWebkitTextAlignLast has available value
into the isValidKeywordPropertyAndValue function, like the same kind of properties.
This will help speed wise in JS.

No new functionality, no new tests.

* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Test /webkit2/WebKitWebView/create-ready-close is failing after r134586
carlosgc@webkit.org [Mon, 19 Nov 2012 11:22:34 +0000 (11:22 +0000)]
[GTK] Test /webkit2/WebKitWebView/create-ready-close is failing after r134586
https://bugs.webkit.org/show_bug.cgi?id=102668

Reviewed by Philippe Normand.

Check only that window properties match when creating a new window
if the expected window properties has been set. Also remove a
FIXME and actually check that x and y are equal to the expected
one, now that the issue is fixed.

* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Enable media tests that pass after r135063
commit-queue@webkit.org [Mon, 19 Nov 2012 11:13:37 +0000 (11:13 +0000)]
[EFL][WK2] Enable media tests that pass after r135063
https://bugs.webkit.org/show_bug.cgi?id=102657

Unreviewed gardening, these test no longer crash after
https://bugs.webkit.org/show_bug.cgi?id=101428.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-19

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r133565): Calendar picker isn't animating when changing month by pressing 't'
keishi@webkit.org [Mon, 19 Nov 2012 11:13:08 +0000 (11:13 +0000)]
REGRESSION (r133565): Calendar picker isn't animating when changing month by pressing 't'
https://bugs.webkit.org/show_bug.cgi?id=102660

Reviewed by Kent Tamura.

The calendar picker used to animate when you press 't'.

No new tests.

* Resources/pagepopups/calendarPicker.js:
(DaysTable.prototype.selectRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening, rebaselining after r135093.
zandobersek@gmail.com [Mon, 19 Nov 2012 11:11:52 +0000 (11:11 +0000)]
Unreviewed GTK gardening, rebaselining after r135093.

* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoinput.value="" should clear date/time input elements with partial values
tkent@chromium.org [Mon, 19 Nov 2012 10:08:05 +0000 (10:08 +0000)]
input.value="" should clear date/time input elements with partial values
https://bugs.webkit.org/show_bug.cgi?id=102645

Reviewed by Kentaro Hara.

Source/WebCore:

Tests: fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html
       fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty.html
       fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html
       fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html
       fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html
       fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html

* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::setValue):
If the new value is an empty string and sub-fields has values, we should
update the UI value to the empty state.
* html/DateTimeFieldsState.h:
(WebCore::DateTimeFieldsState::hasAnyValue):
Added. It returns true if one or more sub-fields are not empty.

LayoutTests:

- Add tests for each of date/time input types.
- Add them to TextExpectations for platforms without ENABLE_INPUT_MULTIPLE_FIELDS_UI.

* fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty-expected.txt: Added.
* fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html: Added.
* fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty-expected.txt: Added.
* fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty.html: Added.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty-expected.txt: Added.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html: Added.
* fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty-expected.txt: Added.
* fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html: Added.
* fast/forms/resources/multiple-fields-value-set-empty.js: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html: Added.
* fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty-expected.txt: Added.
* fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html: Added.
* platform/chromium-android/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Canvas] if many canvases are being instrumented show the screenshot...
commit-queue@webkit.org [Mon, 19 Nov 2012 10:03:33 +0000 (10:03 +0000)]
Web Inspector: [Canvas] if many canvases are being instrumented show the screenshot of the first one
https://bugs.webkit.org/show_bug.cgi?id=102522

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-19
Reviewed by Yury Semikhatsky.

When many canvases are being instrumented we'll want to show replay screenshots for each canvas.
Meanwhile, show the screenshot of the first one (instead of the last one), as it's likely to be the "main" canvas.
Drive-by: add more typification for the JS compiler.
Drive-by: create a new canvas for WebGL replay every time (similar to 2D replay) to avoid problems with resetting the context state.
* inspector/InjectedScriptCanvasModuleSource.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove IDLStructure.pm
haraken@chromium.org [Mon, 19 Nov 2012 10:01:59 +0000 (10:01 +0000)]
Remove IDLStructure.pm
https://bugs.webkit.org/show_bug.cgi?id=102642

Reviewed by Adam Barth.

Previously IDLStructure.pm was full of regular expressions to
parse IDL files. Now a new IDL parser is implemented, IDLStructure.pm
just contains several data structures for the IDL parser. We can
move them to IDLParser.pm and thus remove IDLStructure.pm.

No tests. No change in generated code.

Source/WebCore:

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.vcproj/MigrateScripts:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/IDLParser.pm:
(Parse):
(parseInterface):
(parseException):
(parseConst):
(parseAttributeRest):
(parseOperationRest):
(parseOptionalOrRequiredArgument):
(parseExceptionField):
(parseInterfaceOld):
(parseExceptionOld):
(parseAttributeRestOld):
(applyExtendedAttributeList):
* bindings/scripts/IDLStructure.pm: Removed.

Tools:

* WebKitTestRunner/DerivedSources.make:
* WebKitTestRunner/GNUmakefile.am:
* WebKitTestRunner/InjectedBundle/DerivedSources.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: refine time and bytes output formatting
commit-queue@webkit.org [Mon, 19 Nov 2012 09:40:10 +0000 (09:40 +0000)]
Web Inspector: refine time and bytes output formatting
https://bugs.webkit.org/show_bug.cgi?id=102265

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-19
Reviewed by Yury Semikhatsky.

Add a space between number and unit, otherwise it's hard to read things like 88B.
Reduce a number of decimal digits in KB and MB formats. 1023.45KB seems to be too detailed.

Source/WebCore:

* English.lproj/localizedStrings.js:
* inspector/front-end/CookiesTable.js:
(WebInspector.CookiesTable.prototype._createGridNode):
* inspector/front-end/UIUtils.js:
(Number.secondsToString):
(Number.bytesToString):

LayoutTests:

* inspector/audits/audits-panel-functional-expected.txt:
* inspector/audits/audits-panel-noimages-functional-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Timeline: DomContentLoaded event labeled incorrectly
commit-queue@webkit.org [Mon, 19 Nov 2012 09:38:58 +0000 (09:38 +0000)]
Web Inspector: Timeline: DomContentLoaded event labeled incorrectly
https://bugs.webkit.org/show_bug.cgi?id=102383

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-19
Reviewed by Yury Semikhatsky.

Fixed string presentation of event.

* inspector/front-end/TimelinePresentationModel.js: Fixed string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed buildfix.
kbalazs@webkit.org [Mon, 19 Nov 2012 09:32:15 +0000 (09:32 +0000)]
Unreviewed buildfix.

Fix -Wdelete-non-virtual-destructor error with gcc 4.7 after r135056.

* Shared/CoordinatedGraphics/WebCustomFilterProgramProxy.h:
(WebCustomFilterProgramProxy): This is a polymorphic derived class
so the destructor should be virtual.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Update expectation for fast/js/global-constructors.html after r135093
dominik.rottsches@intel.com [Mon, 19 Nov 2012 09:19:02 +0000 (09:19 +0000)]
[EFL] Update expectation for fast/js/global-constructors.html after r135093
https://bugs.webkit.org/show_bug.cgi?id=102653

Unreviewed EFL gardening.

Update EFL baseline for fast/js/global-constructors.html after r135093.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-19

* platform/efl/fast/js/global-constructors-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CG][WK2] Assertion in CoordinatedGraphicsLayer::setContentsToImage(WebCore::Image*)
commit-queue@webkit.org [Mon, 19 Nov 2012 08:48:43 +0000 (08:48 +0000)]
[CG][WK2] Assertion in CoordinatedGraphicsLayer::setContentsToImage(WebCore::Image*)
https://bugs.webkit.org/show_bug.cgi?id=102652

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-19
Reviewed by Kenneth Rohde Christiansen.

Handle null return of nativeImageForCurrentFrame similarly to Chromium
port in r130610. This can happen if there is an error early in the
decoding of an image.

Test: Already covered by compositing/images/truncated-direct-png-image.html

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setContentsToImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r135114.
haraken@chromium.org [Mon, 19 Nov 2012 08:45:31 +0000 (08:45 +0000)]
Unreviewed, rolling out r135114.
http://trac.webkit.org/changeset/135114
https://bugs.webkit.org/show_bug.cgi?id=102642

it broke Qt build

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.vcproj/MigrateScripts:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/IDLParser.pm:
(Parse):
(parseInterface):
(parseException):
(parseConst):
(parseAttributeRest):
(parseOperationRest):
(parseOptionalOrRequiredArgument):
(parseExceptionField):
(parseInterfaceOld):
(parseExceptionOld):
(parseAttributeRestOld):
(applyExtendedAttributeList):
* bindings/scripts/IDLStructure.pm: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed inspector closure compilation fix.
vsevik@chromium.org [Mon, 19 Nov 2012 08:44:33 +0000 (08:44 +0000)]
Unreviewed inspector closure compilation fix.

* inspector/front-end/ObjectPropertiesSection.js:
* inspector/front-end/externs.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Add tests for week suggestion picker
keishi@webkit.org [Mon, 19 Nov 2012 08:02:15 +0000 (08:02 +0000)]
[Chromium] Add tests for week suggestion picker
https://bugs.webkit.org/show_bug.cgi?id=102039

Reviewed by Kent Tamura.

Adding tests for datalist UI for <input type=week>.

* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-key-operations-expected.txt: Added.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl.html: Added.
* platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar.html: Added.
* platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance.html: Added.
* platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-key-operations-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-key-operations.html: Added.
* platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-min-max-attribute-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-min-max-attribute.html: Added.
* platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-mouse-operations-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-mouse-operations.html: Added.
* platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-reset-value-after-reload-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-reset-value-after-reload.html: Added.
* platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-step-attribute-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-step-attribute.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Skip networkinformation tests wrongly unskipped in r135096
commit-queue@webkit.org [Mon, 19 Nov 2012 07:59:30 +0000 (07:59 +0000)]
[EFL][WK2] Skip networkinformation tests wrongly unskipped in r135096
https://bugs.webkit.org/show_bug.cgi?id=102650

Unreviewed EFL gardening.

Skip again for EFL Debug bots several networkinformation tests
that were wrongly unskipped in r135096 as they still hit an
assertion.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-18

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago.: Remove non-existent directories from the make system
commit-queue@webkit.org [Mon, 19 Nov 2012 07:55:51 +0000 (07:55 +0000)]
.: Remove non-existent directories from the make system
https://bugs.webkit.org/show_bug.cgi?id=102632

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-11-18
Reviewed by Kenneth Rohde Christiansen.

Remove (non-existent) symbian references from the exclude list for packaging.

* Source/cmake/WebKitPackaging.cmake:

Source/WebKit/qt: [Qt] Remove remaining traces of symbian
https://bugs.webkit.org/show_bug.cgi?id=102634

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-11-18
Reviewed by Kenneth Rohde Christiansen.

Remove symbian related part from the API documentation.

* Api/qgraphicswebview.cpp:
* Api/qwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Not to include "ewk_view_private.h" in Tools
commit-queue@webkit.org [Mon, 19 Nov 2012 07:52:54 +0000 (07:52 +0000)]
[EFL] Not to include "ewk_view_private.h" in Tools
https://bugs.webkit.org/show_bug.cgi?id=102644

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-18
Reviewed by Gyuyoung Kim.

Include ewk_view.h instead of ewk_view_private.h in Tools

* DumpRenderTree/efl/PixelDumpSupportEfl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Remove underscore characters in Ewk class names.
commit-queue@webkit.org [Mon, 19 Nov 2012 07:45:36 +0000 (07:45 +0000)]
[EFL][WK2] Remove underscore characters in Ewk class names.
https://bugs.webkit.org/show_bug.cgi?id=102641

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-11-18
Reviewed by Gyuyoung Kim.

WebKit EFL doesn't use '_' in C++ class names.

* UIProcess/API/efl/EwkViewCallbacks.h:
* UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl::settings):
(EwkViewImpl::backForwardList):
(EwkViewImpl):
* UIProcess/API/efl/ewk_auth_request.h:
* UIProcess/API/efl/ewk_auth_request_private.h:
* UIProcess/API/efl/ewk_back_forward_list.cpp:
(EwkBackForwardList::EwkBackForwardList):
(EwkBackForwardList::nextItem):
(EwkBackForwardList::previousItem):
(EwkBackForwardList::currentItem):
(EwkBackForwardList::itemAt):
(EwkBackForwardList::size):
(EwkBackForwardList::backList):
(EwkBackForwardList::forwardList):
(EwkBackForwardList::getFromCacheOrCreate):
(EwkBackForwardList::createEinaList):
(EwkBackForwardList::update):
* UIProcess/API/efl/ewk_back_forward_list.h:
* UIProcess/API/efl/ewk_back_forward_list_item.h:
* UIProcess/API/efl/ewk_back_forward_list_item_private.h:
* UIProcess/API/efl/ewk_back_forward_list_private.h:
(EwkBackForwardList::create):
(EwkBackForwardList):
* UIProcess/API/efl/ewk_color_picker.cpp:
(EwkColorPicker::EwkColorPicker):
(EwkColorPicker::setColor):
(EwkColorPicker::color):
* UIProcess/API/efl/ewk_color_picker.h:
* UIProcess/API/efl/ewk_color_picker_private.h:
(EwkColorPicker::create):
(EwkColorPicker):
* UIProcess/API/efl/ewk_context.h:
* UIProcess/API/efl/ewk_context_private.h:
* UIProcess/API/efl/ewk_cookie_manager.cpp:
(EwkCookieManager::EwkCookieManager):
(EwkCookieManager::~EwkCookieManager):
(EwkCookieManager::setPersistentStorage):
(EwkCookieManager::setHTTPAcceptPolicy):
(EwkCookieManager::clearHostnameCookies):
(EwkCookieManager::clearAllCookies):
(EwkCookieManager::watchChanges):
(EwkCookieManager::isWatchingForChanges):
(EwkCookieManager::getHostNamesWithCookies):
(EwkCookieManager::getHTTPAcceptPolicy):
(EwkCookieManager::cookiesDidChange):
* UIProcess/API/efl/ewk_cookie_manager.h:
* UIProcess/API/efl/ewk_cookie_manager_private.h:
(EwkCookieManager::create):
(EwkCookieManager):
* UIProcess/API/efl/ewk_database_manager.cpp:
(EwkDatabaseManager::EwkDatabaseManager):
(EwkDatabaseManager::getDatabaseOrigins):
(EwkDatabaseManager::createOriginList):
* UIProcess/API/efl/ewk_database_manager.h:
* UIProcess/API/efl/ewk_database_manager_private.h:
(EwkDatabaseManager::create):
(EwkDatabaseManager):
* UIProcess/API/efl/ewk_download_job.h:
* UIProcess/API/efl/ewk_download_job_private.h:
* UIProcess/API/efl/ewk_error.cpp:
(EwkError::EwkError):
(EwkError::url):
(EwkError::description):
(EwkError::domain):
(EwkError::errorCode):
(EwkError::isCancellation):
* UIProcess/API/efl/ewk_error.h:
* UIProcess/API/efl/ewk_error_private.h:
(EwkError::create):
(EwkError):
* UIProcess/API/efl/ewk_favicon_database.cpp:
(EwkFaviconDatabase::EwkFaviconDatabase):
(EwkFaviconDatabase::~EwkFaviconDatabase):
(EwkFaviconDatabase::iconURLForPageURL):
(EwkFaviconDatabase::watchChanges):
(EwkFaviconDatabase::unwatchChanges):
(EwkFaviconDatabase::iconForPageURL):
(EwkFaviconDatabase::didChangeIconForPageURL):
(EwkFaviconDatabase::getIconSurfaceSynchronously):
(EwkFaviconDatabase::iconDataReadyForPageURL):
* UIProcess/API/efl/ewk_favicon_database.h:
* UIProcess/API/efl/ewk_favicon_database_private.h:
(EwkFaviconDatabase::create):
(EwkFaviconDatabase):
* UIProcess/API/efl/ewk_file_chooser_request.h:
* UIProcess/API/efl/ewk_file_chooser_request_private.h:
* UIProcess/API/efl/ewk_form_submission_request.h:
* UIProcess/API/efl/ewk_form_submission_request_private.h:
* UIProcess/API/efl/ewk_intent.h:
* UIProcess/API/efl/ewk_intent_private.h:
* UIProcess/API/efl/ewk_intent_service.h:
* UIProcess/API/efl/ewk_intent_service_private.h:
* UIProcess/API/efl/ewk_navigation_data.h:
* UIProcess/API/efl/ewk_navigation_data_private.h:
* UIProcess/API/efl/ewk_navigation_policy_decision.h:
* UIProcess/API/efl/ewk_navigation_policy_decision_private.h:
* UIProcess/API/efl/ewk_object.h:
* UIProcess/API/efl/ewk_object_private.h:
(EwkObject::~EwkObject):
(ewk_object_is_of_type):
(ewk_object_cast_check):
(ewk_object_cast):
* UIProcess/API/efl/ewk_popup_menu.cpp:
(EwkPopupMenu::EwkPopupMenu):
(EwkPopupMenu::~EwkPopupMenu):
(EwkPopupMenu::close):
(EwkPopupMenu::items):
(EwkPopupMenu::selectedIndex):
(EwkPopupMenu::setSelectedIndex):
* UIProcess/API/efl/ewk_popup_menu.h:
* UIProcess/API/efl/ewk_popup_menu_item.cpp:
(EwkPopupMenuItem::EwkPopupMenuItem):
(EwkPopupMenuItem::type):
(EwkPopupMenuItem::textDirection):
(EwkPopupMenuItem::text):
(EwkPopupMenuItem::tooltipText):
(EwkPopupMenuItem::accessibilityText):
(EwkPopupMenuItem::hasTextDirectionOverride):
(EwkPopupMenuItem::isEnabled):
(EwkPopupMenuItem::isLabel):
(EwkPopupMenuItem::isSelected):
* UIProcess/API/efl/ewk_popup_menu_item.h:
* UIProcess/API/efl/ewk_popup_menu_item_private.h:
(EwkPopupMenuItem::create):
(EwkPopupMenuItem):
* UIProcess/API/efl/ewk_popup_menu_private.h:
(EwkPopupMenu::create):
(EwkPopupMenu):
* UIProcess/API/efl/ewk_resource.h:
* UIProcess/API/efl/ewk_resource_private.h:
* UIProcess/API/efl/ewk_security_origin.h:
* UIProcess/API/efl/ewk_security_origin_private.h:
* UIProcess/API/efl/ewk_settings.cpp:
(EwkSettings::preferences):
* UIProcess/API/efl/ewk_settings.h:
* UIProcess/API/efl/ewk_settings_private.h:
(EwkSettings::create):
(EwkSettings::EwkSettings):
* UIProcess/API/efl/ewk_storage_manager.cpp:
(EwkStorageManager::EwkStorageManager):
(EwkStorageManager::getStorageOrigins):
(EwkStorageManager::createOriginList):
* UIProcess/API/efl/ewk_storage_manager.h:
* UIProcess/API/efl/ewk_storage_manager_private.h:
(EwkStorageManager::create):
(EwkStorageManager):
* UIProcess/API/efl/ewk_url_request.h:
* UIProcess/API/efl/ewk_url_request_private.h:
* UIProcess/API/efl/ewk_url_response.h:
* UIProcess/API/efl/ewk_url_response_private.h:
* UIProcess/API/efl/ewk_url_scheme_request.h:
* UIProcess/API/efl/ewk_url_scheme_request_private.h:
* UIProcess/API/efl/tests/test_ewk2_object.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebaudio: clean-up. Replace AudioContext::m_document member with ContextDestructionOb...
loislo@chromium.org [Mon, 19 Nov 2012 07:42:36 +0000 (07:42 +0000)]
webaudio: clean-up. Replace AudioContext::m_document member with ContextDestructionObserver::scriptExecutionContext().
https://bugs.webkit.org/show_bug.cgi?id=102649

Reviewed by Adam Barth.

AudioContext uses m_document only as a pointer to ScriptExecutionContext.
It could be safely replaced with ContextDestructionObserver::m_scriptExecutionContext.
The lifetime of m_scriptExecutionContext is slightly different but it could be adjusted by m_isStopScheduled flag.

No new tests as there is no new functionality.

* Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::looping):
(WebCore::AudioBufferSourceNode::setLooping):
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::stop):
(WebCore::AudioContext::fireCompletionEvent):
(WebCore::AudioContext::reportMemoryUsage):
* Modules/webaudio/AudioContext.h:
(WebCore::AudioContext::scriptExecutionContext):
(AudioContext):
* Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::fireProcessEvent):
(WebCore::ScriptProcessorNode::scriptExecutionContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove unused variables from CodeGeneratorV8.pm
haraken@chromium.org [Mon, 19 Nov 2012 07:35:06 +0000 (07:35 +0000)]
[V8] Remove unused variables from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=102648

Reviewed by Adam Barth.

No tests. No change in generated code.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateInterface):
(GenerateHeader):
(GetInternalFields):
(GenerateNormalAttrGetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementationCustomCall):
(GenerateFunctionCallString):
(CreateCustomSignature):
(GetContextEnableFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove IDLStructure.pm
haraken@chromium.org [Mon, 19 Nov 2012 07:33:36 +0000 (07:33 +0000)]
Remove IDLStructure.pm
https://bugs.webkit.org/show_bug.cgi?id=102642

Reviewed by Adam Barth.

Previously IDLStructure.pm was full of regular expressions to
parse IDL files. Now a new IDL parser is implemented, IDLStructure.pm
just contains several data structures for the IDL parser. We can
move them to IDLParser.pm and thus remove IDLStructure.pm.

No tests. No change in generated code.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.vcproj/MigrateScripts:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/IDLParser.pm:
(Parse):
(parseInterface):
(parseException):
(parseConst):
(parseAttributeRest):
(parseOperationRest):
(parseOptionalOrRequiredArgument):
(parseExceptionField):
(parseInterfaceOld):
(parseExceptionOld):
(parseAttributeRestOld):
(applyExtendedAttributeList):
* bindings/scripts/IDLStructure.pm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Make more use of $v8Interface in CodeGeneratorV8.pm
haraken@chromium.org [Mon, 19 Nov 2012 07:26:35 +0000 (07:26 +0000)]
[V8] Make more use of $v8Interface in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=102639

Reviewed by Adam Barth.

We can replace hard-coded "V8${interfaceName}" with $v8Interface.

No tests. No change in generated code.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateFunctionCallback):
(GenerateNamedConstructorCallback):
(GenerateImplementationIndexer):
(GenerateImplementationNamedPropertyGetter):
(GenerateImplementation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed: add missed test files for r135111.
loislo@chromium.org [Mon, 19 Nov 2012 06:21:48 +0000 (06:21 +0000)]
Unreviewed: add missed test files for r135111.

* inspector-protocol/resources/audio-context.html: Added.
* inspector-protocol/resources/blank.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebaudio: leak: AudioContext objects are leaking. They retain 36mb of shared data.
loislo@chromium.org [Mon, 19 Nov 2012 06:10:35 +0000 (06:10 +0000)]
webaudio: leak: AudioContext objects are leaking. They retain 36mb of shared data.
https://bugs.webkit.org/show_bug.cgi?id=102356

Reviewed by Adam Barth.

A clean-up code was moved from uninitialize to clear method.
AudioContext marks itself as hasPendingActivity in method constructCommon and unmarks itself in method clear.
m_isStopScheduled filters out second ActiveDOMObject::stop call.
markForDeletion appends AudioNode pointer to m_nodesToDelete array if there is no active audio thread.
adoptRef was added in createOfflineContext method.

Source/WebCore:

Test: inspector-protocol/nmi-webaudio-leak-test.html

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createOfflineContext):
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::constructCommon):
(WebCore::AudioContext::~AudioContext):
(WebCore::AudioContext::clear):
(WebCore::AudioContext::uninitialize):
(WebCore::AudioContext::stopDispatch):
(WebCore::AudioContext::stop):
(WebCore::AudioContext::markForDeletion):
(WebCore::AudioContext::scheduleNodeDeletion):
(WebCore::AudioContext::deleteMarkedNodes):
* Modules/webaudio/AudioContext.h:
(AudioContext):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback):
* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
* platform/PlatformMemoryInstrumentation.cpp:
(WebCore::PlatformMemoryInstrumentation::reportMemoryUsage):
(WebCore):
* platform/PlatformMemoryInstrumentation.h:
(PlatformMemoryInstrumentation):
(WebCore):

LayoutTests:

* inspector-protocol/nmi-webaudio-leak-test-expected.txt: Added.
* inspector-protocol/nmi-webaudio-leak-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomin/max/step support for calendar picker on datetime/datetime-local
commit-queue@webkit.org [Mon, 19 Nov 2012 05:50:44 +0000 (05:50 +0000)]
min/max/step support for calendar picker on datetime/datetime-local
https://bugs.webkit.org/show_bug.cgi?id=102628

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-18
Reviewed by Kent Tamura.

Source/WebCore:

Gray out dates with no allowed values on calendar picker for datetime/datetime-local
when values are limited by min/max/step attributes.

Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html

* Resources/pagepopups/calendarPicker.js:
(CalendarPicker.prototype._stepMismatch):
Returns true iff there are any allowed values in the given day.

LayoutTests:

Verify that calendar picker has correct available dates when
min/max/step attributes are set in datetime input.

* platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove non-existent directories from the make system
commit-queue@webkit.org [Mon, 19 Nov 2012 05:46:55 +0000 (05:46 +0000)]
Remove non-existent directories from the make system
https://bugs.webkit.org/show_bug.cgi?id=102632

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-11-18
Reviewed by Adam Barth.

.:

Remove (non-existent) symbian references from the exclude list for packaging.

* Source/cmake/WebKitPackaging.cmake:

Source/WebCore:

Remove (non-existent) symbian references from the exclude list in gyp project files.

No new tests as there is no new functionality.

* WebCore.gyp/WebCore.gyp:

Source/WTF:

Remove (non-existent) symbian references from the exclude list in gyp project files.

* WTF.gyp/WTF.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WIN] Add a IMLangFontLinkType typedef
paroga@webkit.org [Mon, 19 Nov 2012 05:45:13 +0000 (05:45 +0000)]
[WIN] Add a IMLangFontLinkType typedef
https://bugs.webkit.org/show_bug.cgi?id=102584

Reviewed by Brent Fulgham.

Add a central typedef for IMLangFontLink(2) to get rid of a bunch of ifdefs.

* platform/graphics/FontCache.h:
(WebCore):
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getFontLinkInterface):
(WebCore::getCJKCodePageMasks):
(WebCore::createMLangFont):
(WebCore::FontCache::getFontDataForCharacters):
* platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::containsCharacters):
* platform/graphics/wince/FontCacheWinCE.cpp:
(WebCore):
(WebCore::FontCache::getFontLinkInterface):
(WebCore::getCJKCodePageMasks):
(WebCore::FontCache::getFontDataForCharacters):
* platform/graphics/wince/FontPlatformData.cpp:
(WebCore::FontFamilyCodePageInfo::codePages):
(WebCore::FixedSizeFontData::create):
* platform/graphics/wince/GlyphPageTreeNodeWinCE.cpp:
(WebCore::GlyphPage::fill):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Remove unused ConsoleMessage constructor.
mkwst@chromium.org [Mon, 19 Nov 2012 05:40:40 +0000 (05:40 +0000)]
Web Inspector: Remove unused ConsoleMessage constructor.
https://bugs.webkit.org/show_bug.cgi?id=102590

Reviewed by Brent Fulgham.

We currently have a ConsoleMessage constructor that's unused. Let's
kill it.

* inspector/ConsoleMessage.cpp:
* inspector/ConsoleMessage.h:
(ConsoleMessage):
    Removing an unused constructor variant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r135104.
commit-queue@webkit.org [Mon, 19 Nov 2012 05:19:34 +0000 (05:19 +0000)]
Unreviewed, rolling out r135104.
http://trac.webkit.org/changeset/135104
https://bugs.webkit.org/show_bug.cgi?id=102638

Should not use commit queue to add people to committer list.
(Requested by ap_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-18

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rebaselined images.
haraken@chromium.org [Mon, 19 Nov 2012 05:13:12 +0000 (05:13 +0000)]
Unreviewed. Rebaselined images.

* platform/chromium-linux-x86/fast/block/float/overhanging-tall-block-expected.txt: Added.
* platform/chromium-linux/fast/block/float/overhanging-tall-block-expected.png: Added.
* platform/chromium-linux/fast/block/float/overhanging-tall-block-expected.txt: Added.
* platform/chromium-mac-lion/fast/block/float/overhanging-tall-block-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/block/float/overhanging-tall-block-expected.txt: Added.
* platform/chromium-win-xp/fast/block/float/overhanging-tall-block-expected.png: Added.
* platform/chromium-win-xp/fast/block/float/overhanging-tall-block-expected.txt: Added.
* platform/efl-wk1/fast/block/float/overhanging-tall-block-expected.png: Renamed from LayoutTests/platform/efl/fast/block/float/overhanging-tall-block-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd myself to committers.py
commit-queue@webkit.org [Mon, 19 Nov 2012 05:11:13 +0000 (05:11 +0000)]
Add myself to committers.py
https://bugs.webkit.org/show_bug.cgi?id=102636

Patch by Vivek Galatage <vivek.vg@samsung.com> on 2012-11-18
Reviewed by Laszlo Gombos.

Add myself to committers.py

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to fix the DFG build after r135099.
mitz@apple.com [Mon, 19 Nov 2012 03:38:18 +0000 (03:38 +0000)]
Try to fix the DFG build after r135099.

* dfg/DFGCommon.h:
(JSC::DFG::shouldShowDisassembly):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium rebaseline after r135093.
rniwa@webkit.org [Mon, 19 Nov 2012 03:29:18 +0000 (03:29 +0000)]
Chromium rebaseline after r135093.

* platform/chromium-linux/inspector: Added.
* platform/chromium-linux/inspector/console: Added.
* platform/chromium-linux/inspector/console/console-format-collections-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStyledElement: Make handling the "style" attribute a litte faster.
akling@apple.com [Mon, 19 Nov 2012 03:16:54 +0000 (03:16 +0000)]
StyledElement: Make handling the "style" attribute a litte faster.
<http://webkit.org/b/102623>

Reviewed by Ojan Vafai.

We know that "style" is never a presentation attribute, so avoid the virtual call to isPresentationAttribute()
by hoisting the parseAttribute() logic up into attributeChanged().
Did the same thing with Element::parseAttribute() for consistency.

Knocks ~0.6% of samples off of the DOM/CreateNodes performance test.

* dom/Element.cpp:
(WebCore::Element::attributeChanged):
* dom/Element.h:
(WebCore::Element::parseAttribute):
* dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):
* dom/StyledElement.h:
(StyledElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake] Consolidate common input files
commit-queue@webkit.org [Mon, 19 Nov 2012 03:02:52 +0000 (03:02 +0000)]
[CMake] Consolidate common input files
https://bugs.webkit.org/show_bug.cgi?id=101632

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-11-18
Reviewed by Rob Buis.

Source/WebCore:

Consolidate and sort the list of files, move common source files
into CMakeLists.txt from the port specific files.

No new tests as there is no new functionality.

* CMakeLists.txt:
* PlatformBlackBerry.cmake:
* PlatformEfl.cmake:
* PlatformWinCE.cmake:

Source/WebKit:

Consolidate and sort the list of files.

* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, build fix for !ENABLE(DFG_JIT).
fpizlo@apple.com [Mon, 19 Nov 2012 02:58:46 +0000 (02:58 +0000)]
Unreviewed, build fix for !ENABLE(DFG_JIT).

* dfg/DFGCommon.h:
(JSC::DFG::shouldShowDisassembly):
(DFG):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTighten small SharedBuffers by reserving the exact amount of space needed.
akling@apple.com [Mon, 19 Nov 2012 02:56:08 +0000 (02:56 +0000)]
Tighten small SharedBuffers by reserving the exact amount of space needed.
<http://webkit.org/b/102625>

Reviewed by Anders Carlsson.

When adding the first chunk to a small (<4096 bytes) SharedBuffer, reserve the exact
amount of space needed instead of leaving it to Vector<char>::append().

1.86MB progression on Membuster3.

* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSC should have more logging in structure-related code
fpizlo@apple.com [Mon, 19 Nov 2012 02:55:14 +0000 (02:55 +0000)]
JSC should have more logging in structure-related code
https://bugs.webkit.org/show_bug.cgi?id=102630

Reviewed by Simon Fraser.

- JSValue::description() now tells you if something is a structure, and if so,
  what kind of structure it is.

- Jettisoning logic now tells you why things are being jettisoned.

- It's now possible to turn off GC-triggered jettisoning entirely.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::reoptimize):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::shouldImmediatelyAssumeLivenessDuringScan):
* runtime/JSValue.cpp:
(JSC::JSValue::description):
* runtime/Options.h:
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening, unskip passing tests
commit-queue@webkit.org [Mon, 19 Nov 2012 02:17:59 +0000 (02:17 +0000)]
[EFL] Gardening, unskip passing tests
https://bugs.webkit.org/show_bug.cgi?id=102460

Unreviewed EFL gardening.

The tests marked Crash by r132469 are passing now.

fast/dom/nested-script-exceptions.html, networkinformation/multiple-frames.html,
networkinformation/basic-all-types-of-events.html, networkinformation/updates.html,
networkinformation/add-listener-from-callback.html, networkinformation/basic-operation.html

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-11-18

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Removed a duplicated entry.
haraken@chromium.org [Mon, 19 Nov 2012 01:56:54 +0000 (01:56 +0000)]
Unreviewed. Removed a duplicated entry.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r135047.
haraken@chromium.org [Mon, 19 Nov 2012 01:49:52 +0000 (01:49 +0000)]
Unreviewed, rolling out r135047.
http://trac.webkit.org/changeset/135047
https://bugs.webkit.org/show_bug.cgi?id=102339

it broke Chromium Windows/Mac build

* WebKit.gyp:
* WebKit.gypi:
* public/WebNode.h:
(WebKit):
* public/WebPluginContainer.h:
(WebKit):
(WebPluginContainer):
* src/WebFrameImpl.cpp:
(WebKit::pluginContainerFromNode):
(WebKit):
(WebKit::WebFrameImpl::executeCommand):
(WebKit::WebFrameImpl::printBegin):
(WebKit::WebFrameImpl::isPrintScalingDisabledForPlugin):
* src/WebNode.cpp:
* src/WebPluginContainerImpl.cpp:
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
* tests/FakeWebPlugin.cpp: Removed.
* tests/FakeWebPlugin.h: Removed.
* tests/WebPluginContainerTest.cpp: Removed.
* tests/data/plugin_container.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake namedItem return a node list only in HTMLFormControlsCollection and HTMLOptionsC...
rniwa@webkit.org [Mon, 19 Nov 2012 01:28:39 +0000 (01:28 +0000)]
Make namedItem return a node list only in HTMLFormControlsCollection and HTMLOptionsCollection
https://bugs.webkit.org/show_bug.cgi?id=101311

Reviewed by Darin Adler.

Source/WebCore:

Introduce two new interfaces HTMLFormControlsCollection and HTMLOptionsCollection to be used by form.elements
and select.options. These two interfaces have the named getter and namedItem that returns a live NodeList when
there are multiple matches. Introducing these two interfaces allow us to make "regular" HTMLCollection's named
getter and namedItem return exactly one node or null as specified in HTML5:
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#collections-0

Unfortunately, HTMLOptionsCollection still has a bug that its named getter and namedItem returns
a static NodeList instead of a live NodeList (DynamicNodeList) at the moment.

Also got rid of Document::objects since it's not exposed in IDL or called anywhere.

Test: fast/dom/html-collections-namedItem.html

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* UseJSC.cmake:
* UseV8.cmake:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::getNamedItems):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::JSHTMLCollection::nameGetter): Now returns exactly one node or null.
(WebCore::toJS):
* bindings/js/JSHTMLFormControlsCollectionCustom.cpp: Added.
(WebCore::getNamedItems): Returns RadioNodeList when there are multiple matches.
(WebCore::JSHTMLFormControlsCollection::canGetItemsForName):
(WebCore::JSHTMLFormControlsCollection::nameGetter):
(WebCore::JSHTMLFormControlsCollection::namedItem):
* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::getNamedItems): Returns a static NodeList when there are multiple matches.
This is a bug. It should be a live NodeList instead.
(WebCore::JSHTMLOptionsCollection::canGetItemsForName):
(WebCore::JSHTMLOptionsCollection::nameGetter):
(WebCore::JSHTMLOptionsCollection::namedItem):
* bindings/js/CodeGeneratorJS.pm: Include JSNode.js for all HTML*Collection interfaces for simplicity.
* bindings/js/CodeGeneratorV8.pm: HTMLOptionsCollection now inherits from HTMLCollection. See
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#htmloptionscollection
* bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: Pass in isolate when we can.
(WebCore::getNamedItems): Added a comment about how we should be returning
a HTMLCollection when there are multiple matches.
(WebCore::getItem):
(WebCore::V8HTMLAllCollection::namedPropertyGetter):
(WebCore::V8HTMLAllCollection::namedItemCallback):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp: Now returns exactly one node or null.
(WebCore::V8HTMLCollection::namedPropertyGetter):
(WebCore::toV8):
* bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp: Added.
(WebCore::getNamedItems): Returns RadioNodeList when there are multiple matches.
(WebCore::V8HTMLFormControlsCollection::namedPropertyGetter):
(WebCore::V8HTMLFormControlsCollection::namedItemCallback):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::getNamedItems): Returns a static NodeList when there are multiple matches.
This is a bug. It should be a live NodeList instead.
(WebCore::V8HTMLOptionsCollection::namedPropertyGetter):
(WebCore::V8HTMLOptionsCollection::namedItemCallback):
* dom/Document.cpp: Removed Document::objects since it was not used anywhere.
* dom/Document.h:
(Document):
* dom/Element.cpp:
(WebCore::ElementRareData::ensureCachedHTMLCollection): form.elements should instantiate
a HTMLFormControlsCollection instead of a HTMLCollection.
* html/CollectionType.h:
* html/HTMLCollection.idl: Removed [Custom] since namedItem is a regular function call now.
* html/HTMLFieldSetElement.cpp:
* html/HTMLFieldSetElement.h:
* html/HTMLFormCollection.cpp: Removed.
* html/HTMLFormCollection.h: Removed.
* html/HTMLFormControlsCollection.cpp: Copied from Source/WebCore/html/HTMLFormCollection.cpp.
(WebCore::HTMLFormControlsCollection::HTMLFormControlsCollection):
(WebCore::HTMLFormControlsCollection::create):
(WebCore::HTMLFormControlsCollection::~HTMLFormControlsCollection):
(WebCore::HTMLFormControlsCollection::formControlElements):
(WebCore::HTMLFormControlsCollection::formImageElements):
(WebCore::HTMLFormControlsCollection::virtualItemAfter):
(WebCore::HTMLFormControlsCollection::namedItem):
(WebCore::HTMLFormControlsCollection::updateNameCache):
* html/HTMLFormControlsCollection.h: Copied from Source/WebCore/html/HTMLFormCollection.h.
(HTMLFormControlsCollection):
* html/HTMLFormControlsCollection.idl: Added.
* html/HTMLFormElement.cpp:
* html/HTMLFormElement.h:
* html/HTMLOptionsCollection.idl:

LayoutTests:

Added a regression test to ensure form.elements and select.options use correct interfaces,
and named getter for those two properties return a NodeList when there are multiple matches.

Also added appropriate IDL options to HTMLOptionsCollection.idl.

* fast/dom/collection-nameditem-move-between-documents-expected.txt: Rebaselined since namedItem
now correctly returns null when there is no match. This test result demonstrates a bug that
HTMLAllCollection doesn't inherit from HTMLCollection.
* fast/dom/collection-nameditem-move-between-documents.html: Ditto.
* fast/dom/dom-constructors-expected.txt: Rebaselined.
* fast/dom/html-collections-named-getter-expected.txt: Added.
* fast/dom/html-collections-named-getter.html: Added.
* fast/dom/wrapper-classes-expected.txt: Rebaselined. Since we're exposing HTMLOptionsCollection
on the window object, the constructor property of an instance of HTMLOptionsCollection object
shows up as a function. We should update the test to support this behavior in the future.
* inspector/console/console-format-collections-expected.txt: Rebaselined.
* platform/chromium/fast/dom/gc-9-expected.txt: Rebaselined since a test case for
HTMLOptionsCollection now passes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Rename $className to $v8InterfaceName
haraken@chromium.org [Mon, 19 Nov 2012 01:12:11 +0000 (01:12 +0000)]
[V8] Rename $className to $v8InterfaceName
https://bugs.webkit.org/show_bug.cgi?id=102487

Reviewed by Adam Barth.

In CodeGeneratorV8.pm, $className is always "V8$interfaceName".
We should rename $className to $v8InterfaceName. Also we can
remove GetCallbackClassName().

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GetHeaderClassInclude):
(GenerateDomainSafeFunctionGetter):
(GenerateDomainSafeFunctionSetter):
(GenerateParametersCheck):
(GenerateImplementation):
(GenerateHeaderContentHeader):
(GenerateImplementationContentHeader):
(GenerateCallbackHeader):
(GenerateCallbackImplementation):
(GenerateToV8Converters):
(GetPassRefPtrType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed.
haraken@chromium.org [Mon, 19 Nov 2012 01:05:43 +0000 (01:05 +0000)]
Unreviewed.
r135025 marked a couple of tests as SKIP in Mac.
This patch marks the tests as SKIP in Chormium.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Marked platform/chromium/virtual/deferred/fast/images/webgl-teximage2d...
haraken@chromium.org [Mon, 19 Nov 2012 00:56:54 +0000 (00:56 +0000)]
Unreviewed. Marked platform/chromium/virtual/deferred/fast/images/webgl-teximage2d.html as TIMEOUT.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Marked fast/images/webgl-teximage2d.html as TIMEOUT.
haraken@chromium.org [Mon, 19 Nov 2012 00:54:15 +0000 (00:54 +0000)]
Unreviewed. Marked fast/images/webgl-teximage2d.html as TIMEOUT.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago.: [BlackBerry] Enable Touch Sliders
commit-queue@webkit.org [Mon, 19 Nov 2012 00:41:02 +0000 (00:41 +0000)]
.:  [BlackBerry] Enable Touch Sliders
 https://bugs.webkit.org/show_bug.cgi?id=102516

 Reviewed by Rob Buis.

 Enabled for BlackBerry only
 PR #242781
 PR #176014

 * Source/cmake/OptionsBlackBerry.cmake:
 * Source/cmake/WebKitFeatures.cmake:
 * Source/cmakeconfig.h.cmake:

Patch by Genevieve Mak <gmak@rim.com> on 2012-11-18

Tools: [BlackBerry] Enable Touch Sliders
https://bugs.webkit.org/show_bug.cgi?id=102516

Patch by Genevieve Mak <gmak@rim.com> on 2012-11-18
Reviewed by Rob Buis.

Enabled for BlackBerry only
PR #242781
PR #176014

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove GetTypeFromSignature() from CodeGeneratorV8.pm
haraken@chromium.org [Sun, 18 Nov 2012 23:52:09 +0000 (23:52 +0000)]
[V8] Remove GetTypeFromSignature() from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=102499

Reviewed by Adam Barth.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateFunctionCallString):
(GetNativeTypeFromSignature):
(TranslateParameter):
(TypeCanFailConversion):
(JSValueToNative):
(NativeToJSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaselines.
simon.fraser@apple.com [Sun, 18 Nov 2012 23:49:37 +0000 (23:49 +0000)]
Rebaselines.

* platform/mac/fast/media/mq-js-media-except-02-expected.txt:
* platform/mac/fast/media/mq-js-media-except-03-expected.txt:
* platform/mac/svg/custom/baseval-animval-equality-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove GenerateModule() from all code generators
haraken@chromium.org [Sun, 18 Nov 2012 23:44:15 +0000 (23:44 +0000)]
Remove GenerateModule() from all code generators
https://bugs.webkit.org/show_bug.cgi?id=102490

Reviewed by Adam Barth.

WebKit IDL files no longer support modules. The Web IDL spec
no longer supports modules. We can remove it from code generators.

No tests. No change in behavior.

* bindings/scripts/CodeGenerator.pm:
(ProcessDocument):
* bindings/scripts/CodeGeneratorCPP.pm:
* bindings/scripts/CodeGeneratorGObject.pm:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Get rid of unused functions and inline redundant functions in CodeGeneratorV8.pm
haraken@chromium.org [Sun, 18 Nov 2012 23:42:24 +0000 (23:42 +0000)]
[V8] Get rid of unused functions and inline redundant functions in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=102497

Reviewed by Adam Barth.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateDomainSafeFunctionGetter):
(GenerateNormalAttrGetter):
(GenerateFunctionCallString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r135074.
rakuco@webkit.org [Sun, 18 Nov 2012 23:07:30 +0000 (23:07 +0000)]
Unreviewed, rolling out r135074.
http://trac.webkit.org/changeset/135074
https://bugs.webkit.org/show_bug.cgi?id=102619

Made most layout tests crash. (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-18

* PlatformEfl.cmake:
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::setContextLostCallback):
* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createSurface):
(WebCore::GraphicsContext3DPrivate::setCurrentGLContext):
(WebCore::GraphicsContext3DPrivate::platformGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurfaces):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
(WebCore::GraphicsContext3DPrivate::graphicsSurfaceToken):
* platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
* platform/graphics/opengl/GLDefs.h: Removed.
* platform/graphics/opengl/GLPlatformContext.cpp: Removed.
* platform/graphics/opengl/GLPlatformContext.h: Removed.
* platform/graphics/opengl/GLPlatformSurface.cpp: Removed.
* platform/graphics/opengl/GLPlatformSurface.h: Removed.
* platform/graphics/surfaces/glx/GLXContext.cpp: Removed.
* platform/graphics/surfaces/glx/GLXContext.h: Removed.
* platform/graphics/surfaces/glx/GLXSurface.cpp: Removed.
* platform/graphics/surfaces/glx/GLXSurface.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r129644): User StyleSheet not applying
antti@apple.com [Sun, 18 Nov 2012 22:38:53 +0000 (22:38 +0000)]
REGRESSION(r129644): User StyleSheet not applying
https://bugs.webkit.org/show_bug.cgi?id=102110

Reviewed by Andreas Kling.

Source/WebCore:

Injected stylesheets added as UserStyleAuthorLevel fail to apply. r129644 implicitly assumed that
such things don't exists but on Chromium addUserStyleSheet() confusingly uses them.

The patch adds injected author stylesheets to DocumentStyleSheetCollection::activeStyleSheets().
It also generally cleans up the code around injected and user stylesheets.

Tests: userscripts/user-script-and-stylesheet.html
       userscripts/user-stylesheet-invalidate.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectRulesFromUserStyleSheets):
(WebCore::collectCSSOMWrappers):
* css/StyleResolver.h:
(StyleResolver):
* dom/Document.cpp:
(WebCore::Document::setCompatibilityMode):
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::injectedUserStyleSheets):
(WebCore):
(WebCore::DocumentStyleSheetCollection::injectedAuthorStyleSheets):
(WebCore::DocumentStyleSheetCollection::updateInjectedStyleSheetCache):
(WebCore::DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache):
(WebCore::DocumentStyleSheetCollection::addUserSheet):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):
* dom/DocumentStyleSheetCollection.h:
(WebCore::DocumentStyleSheetCollection::documentUserStyleSheets):
(DocumentStyleSheetCollection):
* page/PageGroup.cpp:
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
(WebCore::PageGroup::removeAllUserContent):
(WebCore::PageGroup::invalidatedInjectedStyleSheetCacheInAllFrames):
* page/PageGroup.h:
(PageGroup):

LayoutTests:

* inspector/timeline/timeline-script-tag-1-expected.txt:

    Update the test result. The style invalidation log is slightly different.

* userscripts/user-stylesheet-invalidate-expected.txt: Added.
* userscripts/user-stylesheet-invalidate.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed.
abarth@webkit.org [Sun, 18 Nov 2012 21:55:52 +0000 (21:55 +0000)]
Unreviewed.

Update run-bindings-tests baselines after
http://trac.webkit.org/changeset/135063

* bindings/scripts/test/JS/JSTestActiveDOMObject.h:
(JSTestActiveDOMObjectOwner):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
(JSTestCustomNamedGetterOwner):
* bindings/scripts/test/JS/JSTestEventConstructor.h:
(JSTestEventConstructorOwner):
* bindings/scripts/test/JS/JSTestEventTarget.h:
(JSTestEventTargetOwner):
* bindings/scripts/test/JS/JSTestException.h:
(JSTestExceptionOwner):
* bindings/scripts/test/JS/JSTestInterface.h:
(JSTestInterfaceOwner):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(JSTestMediaQueryListListenerOwner):
* bindings/scripts/test/JS/JSTestNamedConstructor.h:
(JSTestNamedConstructorOwner):
* bindings/scripts/test/JS/JSTestObj.h:
(JSTestObjOwner):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
(JSTestOverloadedConstructorsOwner):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(JSTestSerializedScriptValueInterfaceOwner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake convertToLayerCoords iterative, rather than recursive
simon.fraser@apple.com [Sun, 18 Nov 2012 21:37:48 +0000 (21:37 +0000)]
Make convertToLayerCoords iterative, rather than recursive
https://bugs.webkit.org/show_bug.cgi?id=102618

Reviewed by Antti Koivisto.

RenderLayer::convertToLayerCoords() is a hot function on profiles.
Change it to be iterative, rather than recursive, so that the
bulk of the function can be inlined.

Was tested with assertions against the old code during development.

* rendering/RenderLayer.cpp:
(WebCore::accumulateOffsetTowardsAncestor):
(WebCore::RenderLayer::convertToLayerCoords):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG constant folding phase should say 'changed = true' whenever it changes the graph
fpizlo@apple.com [Sun, 18 Nov 2012 21:34:10 +0000 (21:34 +0000)]
DFG constant folding phase should say 'changed = true' whenever it changes the graph
https://bugs.webkit.org/show_bug.cgi?id=102550

Rubber stamped by Mark Hahnenberg.

* dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInline the StyledElement constructor.
akling@apple.com [Sun, 18 Nov 2012 20:25:01 +0000 (20:25 +0000)]
Inline the StyledElement constructor.
<http://webkit.org/b/102615>

Reviewed by Antti Koivisto.

StyledElement sits between Element and HTMLElement in the inheritance chain, and both of those are inline.
Knocks ~0.4% of samples off of the DOM/CreateNodes performance test.

* dom/StyledElement.cpp:
* dom/StyledElement.h:
(WebCore::StyledElement::StyledElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHTMLMediaElement: Skip unnecessary attribute lookup in parsing of "src" attribute.
akling@apple.com [Sun, 18 Nov 2012 18:54:15 +0000 (18:54 +0000)]
HTMLMediaElement: Skip unnecessary attribute lookup in parsing of "src" attribute.
<http://webkit.org/b/102614>

Reviewed by Anders Carlsson.

When parsing the "src" attribute, we don't need to look it up with fastHasAttribute()
to know if it's present. If it's not present, 'value' argument will be null.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@135077 268f45cc-cd09-0410-ab3c-d52691b4dbfc