WebKit-https.git
9 years ago2011-06-06 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Mon, 6 Jun 2011 21:30:42 +0000 (21:30 +0000)]
2011-06-06  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Convert RenderBox::popContentsClip to IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=62132

        Covered by existing tests.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paint):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::popContentsClip):
        * rendering/RenderBox.h:
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paint):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Mon, 6 Jun 2011 21:26:24 +0000 (21:26 +0000)]
2011-06-06  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Remove tx/ty offset from selectionRect
        https://bugs.webkit.org/show_bug.cgi?id=62146

        Removing unused offset parameters from selectionRect.

        No new tests since this is just cleanup.

        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::selectionRect):
        * rendering/EllipsisBox.h:
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::selectionRect):
        * rendering/InlineTextBox.h:
        * rendering/RenderText.cpp:
        (WebCore::RenderText::absoluteRectsForRange):
        (WebCore::ellipsisRectForBox):
        (WebCore::RenderText::absoluteQuadsForRange):
        (WebCore::RenderText::selectionRectForRepaint):
        * rendering/svg/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::localCaretRect):
        * rendering/svg/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::selectionRect):
        * rendering/svg/SVGInlineTextBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Paul Kinlan <paulkinlan@google.com>
commit-queue@webkit.org [Mon, 6 Jun 2011 21:15:45 +0000 (21:15 +0000)]
2011-06-06  Paul Kinlan  <paulkinlan@google.com>

        Reviewed by Jeremy Orlow.

        Adds a test for firing popstate, using window.dispatchEvent.
        https://bugs.webkit.org/show_bug.cgi?id=62099

        * fast/events/fire-popstate-event-expected.txt: Added.
        * fast/events/fire-popstate-event.html: Added.
2011-06-06  Paul Kinlan  <paulkinlan@google.com>

        Reviewed by Jeremy Orlow.

        Let developers call createEvent("PopStateEvent"), previously it wasn't
        exposed and threw an exeception.
        https://bugs.webkit.org/show_bug.cgi?id=62099

        * WebCore/dom/Document.cpp:
        * WebCore/dom/PopStateEvent.cpp:
        * WebCore/dom/PopStateEvent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Mon, 6 Jun 2011 20:42:09 +0000 (20:42 +0000)]
2011-06-03  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch paintSelection to use IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=62059

        Switching paintSelection to use an IntPoint to represent the paint offset
        instead of a pair of ints.

        No new tests since this is simple refactoring.

        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::paint):
        (WebCore::EllipsisBox::paintSelection):
        * rendering/EllipsisBox.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintObject):
        (WebCore::RenderBlock::paintSelection):
        * rendering/RenderBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 6 Jun 2011 20:18:58 +0000 (20:18 +0000)]
2011-06-06  Martin Robinson  <mrobinson@igalia.com>

        Fix the GTK+ build by ensuring that the autogenerated sources
        necessary for libWebCoreInternals are recorded in a predeclared
        variable before assigning to BUILT_SOURCES.

        * GNUmakefile.am: Assign libWebCoreInternals built sources to
        libwebcoreinternals_built_sources before adding to the source list
        and to BUILT_SOURCES.
2011-06-06  Martin Robinson  <mrobinson@igalia.com>

        Fix the GTK+ build by ensuring that the autogenerated sources
        necessary for libWebCoreInternals are recorded in a predeclared
        variable before assigning to BUILT_SOURCES.

        * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate the Windows-specific results after r88020 in order to get the bots green.
jberlin@webkit.org [Mon, 6 Jun 2011 20:14:35 +0000 (20:14 +0000)]
Update the Windows-specific results after r88020 in order to get the bots green.

* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/dom/prototype-inheritance-expected.txt:
* platform/win/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Mon, 6 Jun 2011 19:57:36 +0000 (19:57 +0000)]
2011-06-06  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Convert RenderBox::clipRect to IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=62045

        Covered by existing tests.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::clipRect):
        * rendering/RenderBox.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::calculateClipRects):
        (WebCore::RenderLayer::calculateRects):
        (WebCore::RenderLayer::repaintBlockSelectionGaps):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::clipBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows DRT needs an implementation of shadowRoot.
jberlin@webkit.org [Mon, 6 Jun 2011 19:57:32 +0000 (19:57 +0000)]
Windows DRT needs an implementation of shadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=59081

Skip more tests on Windows that use the Shadow DOM to get the bots green.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Anna Cavender <annacc@chromium.org>
commit-queue@webkit.org [Mon, 6 Jun 2011 19:42:54 +0000 (19:42 +0000)]
2011-06-06  Anna Cavender  <annacc@chromium.org>

        Reviewed by David Levin.

        Marking media/video-canvas-alpha.html as SKIP for GPU MAC.
        https://bugs.webkit.org/show_bug.cgi?id=62068

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Mon, 6 Jun 2011 19:40:10 +0000 (19:40 +0000)]
2011-06-06  Vangelis Kokkevis  <vangelis@chromium.org>

        Unreviewed. Layout test expectations fix.

        [chromium] Adjusting expectations for failing huge-layer-img.html

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Yong Li <yoli@rim.com>
commit-queue@webkit.org [Mon, 6 Jun 2011 19:36:08 +0000 (19:36 +0000)]
2011-06-06  Yong Li  <yoli@rim.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=62097
        Fix the problem that integral bitfield check incorrectly barked at ?: expressions.

        * Scripts/webkitpy/style/checkers/cpp.py:
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Peter Kasting <pkasting@google.com>
commit-queue@webkit.org [Mon, 6 Jun 2011 19:21:32 +0000 (19:21 +0000)]
2011-06-06  Peter Kasting  <pkasting@google.com>

        Reviewed by Antonio Gomes.

        Remove unnecessary args from scroll functions.
        https://bugs.webkit.org/show_bug.cgi?id=61648

        No behavior change, so no tests.

        * WebCore.exp.in:
        * WebCore.order:
        * dom/Element.cpp:
        (WebCore::Element::scrollIntoView):
        (WebCore::Element::scrollIntoViewIfNeeded):
        * editing/FrameSelection.cpp:
        (WebCore::FrameSelection::revealSelection):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEvent):
        * page/FrameView.cpp:
        (WebCore::FrameView::scrollToAnchor):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::canBeScrolledAndHasScrollableArea):
        (WebCore::RenderBox::canBeProgramaticallyScrolled):
        * rendering/RenderBox.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollRectToVisible):
        (WebCore::RenderLayer::autoscroll):
        * rendering/RenderLayer.h:
        * rendering/RenderListBox.h:
        (WebCore::RenderListBox::canBeProgramaticallyScrolled):
        * rendering/RenderTextControl.h:
        (WebCore::RenderTextControl::canBeProgramaticallyScrolled):
2011-06-06  Peter Kasting  <pkasting@google.com>

        Reviewed by Antonio Gomes.

        Remove unnecessary args from scroll functions.
        https://bugs.webkit.org/show_bug.cgi?id=61648

        * WebView/WebFrame.mm:
        (-[WebFrame _scrollDOMRangeToVisible:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 6 Jun 2011 18:51:32 +0000 (18:51 +0000)]
2011-06-06  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Enable feature/symbol detection in NWRT/GTK
        https://bugs.webkit.org/show_bug.cgi?id=62136

        Disable feature detection through DRT, since we don't support it,
        and set the libwebcore patch correctly so that symbol detection
        through 'nm' works.

        * Scripts/webkitpy/layout_tests/port/gtk.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Mon, 6 Jun 2011 18:43:40 +0000 (18:43 +0000)]
2011-06-06  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch paintContents, paintColumnContents, paintColumnRules, and paintSelection to use IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=62134

        Switching paintContents, paintColumnContents, paintColumnRules, and paintSelection to take an
        IntPoint representing the paint offset instead of a pair of ints.

        No new tests as this simple refactoring.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintColumnRules):
        (WebCore::RenderBlock::paintColumnContents):
        (WebCore::RenderBlock::paintContents):
        (WebCore::RenderBlock::paintObject):
        (WebCore::RenderBlock::paintSelection):
        * rendering/RenderBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Mon, 6 Jun 2011 18:32:54 +0000 (18:32 +0000)]
2011-06-06  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Eric Seidel.

        Inline elements are wrapped prematurely with non-zero border, margin or padding.
        https://bugs.webkit.org/show_bug.cgi?id=60459

        * fast/inline/inline-wrap-with-parent-padding.html: Added.
        * platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
        * platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.
2011-06-06  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Eric Seidel.

        Inline elements are wrapped prematurely with non-zero border, margin or padding.
        https://bugs.webkit.org/show_bug.cgi?id=60459

        When an inline element has a right border/margin/padding and it has more than one descendant with no siblings,
        the width of the right border/margin/padding should be included in line breaking calculation only once,
        and not for each descendant.

        Test: fast/inline/inline-wrap-with-parent-padding.html

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::LineBreaker::nextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Shishir Agrawal <shishir@chromium.org>
commit-queue@webkit.org [Mon, 6 Jun 2011 18:03:05 +0000 (18:03 +0000)]
2011-06-06  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by Tony Gentilcore.

        Add a "prerender" state for page visibility.
        https://bugs.webkit.org/show_bug.cgi?id=62062

        * fast/events/page-visibility-transition-test-expected.txt:
        * fast/events/page-visibility-transition-test.html:
2011-06-06  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by Tony Gentilcore.

        Add a "prerender" state for page visibility.
        https://bugs.webkit.org/show_bug.cgi?id=62062

        * page/PageVisibilityState.cpp:
        (WebCore::pageVisibilityStateString):
        * page/PageVisibilityState.h:
2011-06-06  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by Tony Gentilcore.

        Add a "prerender" state for page visibility.
        https://bugs.webkit.org/show_bug.cgi?id=62062

        * public/WebPageVisibilityState.h:
        * src/AssertMatchingEnums.cpp:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setVisibilityState):
2011-06-06  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by Tony Gentilcore.

        Add a "prerender" state for page visibility.
        https://bugs.webkit.org/show_bug.cgi?id=62062

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::setPageVisibility):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Cary Clark <caryclark@google.com>
commit-queue@webkit.org [Mon, 6 Jun 2011 18:01:15 +0000 (18:01 +0000)]
2011-06-06  Cary Clark  <caryclark@google.com>

        Reviewed by Eric Seidel.

        Fix typo in CachedFont.cpp #define
        https://bugs.webkit.org/show_bug.cgi?id=62127

        No new tests. The define typo in question is
        not yet enabled, so this change has no functional
        impact.

        * loader/cache/CachedFont.cpp:
        change SKIA_MAC_ON_CHROME to SKIA_ON_MAC_CHROME

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Mon, 6 Jun 2011 17:50:03 +0000 (17:50 +0000)]
2011-06-03  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch paintFloats, paintChildren, and paintEllipsisBoxes to use IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=62058

        Switching paintFloats, paintChildren, and paintEllipsisBoxes to take IntPoints representing
        their paint offsets instead of pairs of ints.

        No new tests since this is simple refactoring.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintColumnContents):
        (WebCore::RenderBlock::paintContents):
        (WebCore::RenderBlock::paintChildren):
        (WebCore::RenderBlock::paintObject):
        (WebCore::RenderBlock::paintFloats):
        (WebCore::RenderBlock::paintEllipsisBoxes):
        * rendering/RenderBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Mon, 6 Jun 2011 17:10:16 +0000 (17:10 +0000)]
2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Anders Carlsson.

        Do not use NPRuntimeObjectMap in NetscapePlugin::setException when plug-in is running out of process
        https://bugs.webkit.org/show_bug.cgi?id=62124

        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
        (WebKit::NetscapePlugin::setException):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Mon, 6 Jun 2011 16:48:07 +0000 (16:48 +0000)]
2011-06-06  Nico Weber  <thakis@chromium.org>

        Reviewed by Dimitri Glazkov.

        webkit/glue/webmediaplayer_impl.cc deletes an object of type
        WebVideoFrame, which means this patch fixes a real bug, not just
        a theoretical one.

        [chromium] Give WebVideoFrame a virtual destructor
        https://bugs.webkit.org/show_bug.cgi?id=61742

        * public/WebVideoFrame.h:
        (WebKit::WebVideoFrame::~WebVideoFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] 6 tests have different results on 64 bit compared to 32 bit
ossy@webkit.org [Mon, 6 Jun 2011 14:57:30 +0000 (14:57 +0000)]
[Qt] 6 tests have different results on 64 bit compared to 32 bit
https://bugs.webkit.org/show_bug.cgi?id=52812

* platform/qt/Skipped: Add svg/custom/embedding-external-svgs.xhtml.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Implement download feature for QtTestBrowser
ossy@webkit.org [Mon, 6 Jun 2011 14:52:19 +0000 (14:52 +0000)]
[Qt] Implement download feature for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=61865

Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.

* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::LauncherWindow):
* QtTestBrowser/launcherwindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Steve Block <steveblock@google.com>
steveblock@google.com [Mon, 6 Jun 2011 14:15:30 +0000 (14:15 +0000)]
2011-06-06  Steve Block  <steveblock@google.com>

        Reviewed by Yury Semikhatsky.

        Use of ENABLE(INSPECTOR) is inconsistent
        https://bugs.webkit.org/show_bug.cgi?id=62118

        Correctly guard implementation of ScriptProfiler.

        No new tests, build fix only.

        * bindings/v8/ScriptProfiler.cpp:
        (WebCore::ScriptProfiler::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed WinCairo build fix after r88159.
dominicc@chromium.org [Mon, 6 Jun 2011 14:12:11 +0000 (14:12 +0000)]
Unreviewed WinCairo build fix after r88159.

* win/WebKit2CFLite.def: Export symbols for WebCoreTestSupport.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac] Skip failing tests.
ossy@webkit.org [Mon, 6 Jun 2011 13:53:39 +0000 (13:53 +0000)]
[Qt][Mac] Skip failing tests.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add expected results for the new passing tests, and skip the new failing tests.
ossy@webkit.org [Mon, 6 Jun 2011 13:33:22 +0000 (13:33 +0000)]
[Qt] Add expected results for the new passing tests, and skip the new failing tests.

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-06-06
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped: Skip new failing tests.
* platform/qt/fast/frames/flattening/iframe-flattening-nested-expected.png: Added.
* platform/qt/fast/frames/flattening/iframe-flattening-nested-expected.txt: Added.
* platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
* platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
* platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
* platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
* platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
* platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.
* platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
* platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
* platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
* platform/qt/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
* platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.png: Added.
* platform/qt/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
* platform/qt/svg/custom/embedding-external-svgs-expected.png: Added.
* platform/qt/svg/custom/embedding-external-svgs-expected.txt: Added.
* platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
* platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
* platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
* platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
* platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
* platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
* platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
* platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
* platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
* platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
* platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
* platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
* platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
* platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
* platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
* platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
* platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
* platform/qt/svg/hixie/intrinsic/001-expected.png: Added.
* platform/qt/svg/hixie/intrinsic/001-expected.txt: Added.
* platform/qt/svg/hixie/intrinsic/002-expected.png: Added.
* platform/qt/svg/hixie/intrinsic/002-expected.txt: Added.
* platform/qt/svg/hixie/intrinsic/003-expected.png: Added.
* platform/qt/svg/hixie/intrinsic/003-expected.txt: Added.
* platform/qt/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
* platform/qt/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Mon, 6 Jun 2011 13:27:29 +0000 (13:27 +0000)]
2011-06-06  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Unreviewed rebaseline.

        [chromium] Unreviewed, new baseline for GPU test.
        https://bugs.webkit.org/show_bug.cgi?id=62123

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Barát Tibor <Barat.Tibor@stud.u-szeged.hu>
commit-queue@webkit.org [Mon, 6 Jun 2011 13:19:23 +0000 (13:19 +0000)]
2011-06-06  Barát Tibor  <Barat.Tibor@stud.u-szeged.hu>

        Reviewed by Csaba Osztrogonác.

        [Qt] Implement download feature for QtTestBrowser
        https://bugs.webkit.org/show_bug.cgi?id=61865

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::LauncherWindow):
        (LauncherWindow::downloadRequest):
        (LauncherWindow::fileDownloadFinished):
        * QtTestBrowser/launcherwindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Gabor Loki <loki@webkit.org>
loki@webkit.org [Mon, 6 Jun 2011 12:41:55 +0000 (12:41 +0000)]
2011-06-06  Gabor Loki  <loki@webkit.org>

        Rubber-stamped by Csaba Osztrogonác

        Skip a flakey test on ARM.

        * platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Dominic Cooney <dominicc@chromium.org>
dominicc@chromium.org [Mon, 6 Jun 2011 12:32:32 +0000 (12:32 +0000)]
2011-06-04  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Unskip window.internals test on Windows.
        https://bugs.webkit.org/show_bug.cgi?id=61076

        * platform/win/Skipped:
2011-06-04  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add WebCoreTestSupport project.
        https://bugs.webkit.org/show_bug.cgi?id=61076

        * WebCore.vcproj/WebCoreCommon.vsprops:
        * WebCore.vcproj/WebCoreTestSupport.vcproj: Added.
        * WebCore.vcproj/copyForwardingHeaders.cmd: Copy WebCoreTestSupport.h.
2011-06-04  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add WebCoreTestSupport project containing window.internals.
        https://bugs.webkit.org/show_bug.cgi?id=61076

        * WebKit.vcproj/WebKit.sln:
2011-06-04  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Re-export JSC and WebCore symbols required by WebCoreTestSupport.
        https://bugs.webkit.org/show_bug.cgi?id=61076

        * win/WebKit2.def:
2011-06-04  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Make DumpRenderTree initialize window.internals.
        https://bugs.webkit.org/show_bug.cgi?id=61076

        * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
        * DumpRenderTree/win/FrameLoadDelegate.cpp:
        (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] 6 tests have different results on 64 bit compared to 32 bit
ossy@webkit.org [Mon, 6 Jun 2011 12:23:09 +0000 (12:23 +0000)]
[Qt] 6 tests have different results on 64 bit compared to 32 bit
https://bugs.webkit.org/show_bug.cgi?id=52812

* platform/qt/Skipped: Add svg/custom/object-sizing-explicit-width-height.xhtml.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Csaba Osztrogonác <ossy@webkit.org>
bulach@chromium.org [Mon, 6 Jun 2011 12:16:33 +0000 (12:16 +0000)]
2011-06-06  Csaba Osztrogonác  <ossy@webkit.org>

        [Qt][WK2] Remove previously deleted tests from the Skipped list.

        * platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Remove previously deleted tests from the Skipped list.
ossy@webkit.org [Mon, 6 Jun 2011 11:58:43 +0000 (11:58 +0000)]
[Qt][WK2] Remove previously deleted tests from the Skipped list.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Skip failing tests.
ossy@webkit.org [Mon, 6 Jun 2011 11:53:18 +0000 (11:53 +0000)]
[Qt][WK2] Skip failing tests.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac] Skip failing tests.
ossy@webkit.org [Mon, 6 Jun 2011 11:37:08 +0000 (11:37 +0000)]
[Qt][Mac] Skip failing tests.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Mon, 6 Jun 2011 11:22:34 +0000 (11:22 +0000)]
2011-06-06  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Unreviewed rebaseline.

        [chromium] Unreviewed, further rebaseline for Chromium GPU media pixel tests following r88077
        https://bugs.webkit.org/show_bug.cgi?id=62115

        * platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.png:
        * platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
        * platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.png:
        * platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
        * platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
        * platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.png:
        * platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.png:
        * platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
        * platform/chromium-gpu-linux/media/video-controls-rendering-expected.png:
        * platform/chromium-gpu-linux/media/video-zoom-expected.png:
        * platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.png:
        * platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.png:
        * platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.png:
        * platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.png:
        * platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.png:
        * platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.png:
        * platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.png:
        * platform/chromium-gpu-mac/compositing/self-painting-layers-expected.png:
        * platform/chromium-gpu-mac/media/video-controls-rendering-expected.png:
        * platform/chromium-gpu-mac/media/video-zoom-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.png:
        * platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.png:
        * platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.png:
        * platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.png:
        * platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.png:
        * platform/chromium-gpu-win/compositing/self-painting-layers-expected.png:
        * platform/chromium-gpu-win/media/video-controls-rendering-expected.png:
        * platform/chromium-gpu-win/media/video-zoom-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add expected results for the new passing tests, and skip the new failing tests.
ossy@webkit.org [Mon, 6 Jun 2011 11:12:21 +0000 (11:12 +0000)]
[Qt] Add expected results for the new passing tests, and skip the new failing tests.

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-06-06
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped: Skip new failing tests.
* platform/qt/editing/selection/select-across-readonly-input-1-expected.png: Added.
* platform/qt/editing/selection/select-across-readonly-input-1-expected.txt: Added.
* platform/qt/editing/selection/select-across-readonly-input-2-expected.png: Added.
* platform/qt/editing/selection/select-across-readonly-input-2-expected.txt: Added.
* platform/qt/editing/selection/select-across-readonly-input-3-expected.png: Added.
* platform/qt/editing/selection/select-across-readonly-input-3-expected.txt: Added.
* platform/qt/editing/selection/select-across-readonly-input-4-expected.png: Added.
* platform/qt/editing/selection/select-across-readonly-input-4-expected.txt: Added.
* platform/qt/editing/selection/select-across-readonly-input-5-expected.png: Added.
* platform/qt/editing/selection/select-across-readonly-input-5-expected.txt: Added.
* platform/qt/fast/block/float/float-overhangs-root-expected.png: Added.
* platform/qt/fast/block/float/float-overhangs-root-expected.txt: Added.
* platform/qt/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
* platform/qt/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.
* platform/qt/fast/forms/date-input-visible-strings-expected.png: Added.
* platform/qt/fast/forms/input-placeholder-text-indent-expected.png: Added.
* platform/qt/fast/forms/input-placeholder-text-indent-expected.txt: Added.
* platform/qt/fast/html/details-add-details-child-1-expected.png: Added.
* platform/qt/fast/html/details-add-details-child-1-expected.txt: Added.
* platform/qt/fast/html/details-add-details-child-2-expected.png: Added.
* platform/qt/fast/html/details-add-details-child-2-expected.txt: Added.
* platform/qt/fast/html/details-nested-1-expected.png: Added.
* platform/qt/fast/html/details-nested-1-expected.txt: Added.
* platform/qt/fast/html/details-nested-2-expected.png: Added.
* platform/qt/fast/html/details-nested-2-expected.txt: Added.
* platform/qt/fast/html/details-replace-summary-child-expected.png: Added.
* platform/qt/fast/html/details-replace-summary-child-expected.txt: Added.
* platform/qt/fast/html/details-replace-text-expected.png: Added.
* platform/qt/fast/html/details-replace-text-expected.txt: Added.
* platform/qt/fast/inline/nested-top-alignment-expected.png: Added.
* platform/qt/fast/inline/nested-top-alignment-expected.txt: Added.
* platform/qt/fast/table/dynamic-caption-add-before-child-expected.png: Added.
* platform/qt/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
* platform/qt/fast/table/dynamic-caption-add-remove-before-child-expected.png: Added.
* platform/qt/fast/table/dynamic-caption-add-remove-before-child-expected.txt: Added.
* platform/qt/fast/table/multiple-captions-display-expected.png: Added.
* platform/qt/fast/table/multiple-captions-display-expected.txt: Added.
* platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
* platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
* platform/qt/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
* platform/qt/scrollbars/scrollbars-on-positioned-content-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
* platform/qt/svg/custom/fill-opacity-update-expected.png: Added.
* platform/qt/svg/custom/fill-opacity-update-expected.txt: Added.
* platform/qt/svg/custom/object-sizing-expected.png: Added.
* platform/qt/svg/custom/object-sizing-expected.txt: Added.
* platform/qt/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
* platform/qt/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
* platform/qt/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
* platform/qt/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Added.
* platform/qt/svg/custom/object-sizing-no-width-height-expected.png: Added.
* platform/qt/svg/custom/object-sizing-no-width-height-expected.txt: Added.
* platform/qt/svg/custom/stroke-opacity-update-expected.png: Added.
* platform/qt/svg/custom/stroke-opacity-update-expected.txt: Added.
* platform/qt/svg/wicd/rightsizing-grid-expected.png: Added.
* platform/qt/svg/wicd/rightsizing-grid-expected.txt: Added.
* platform/qt/svg/wicd/test-rightsizing-a-expected.png: Added.
* platform/qt/svg/wicd/test-rightsizing-a-expected.txt: Added.
* platform/qt/svg/wicd/test-rightsizing-b-expected.png: Added.
* platform/qt/svg/wicd/test-rightsizing-b-expected.txt: Added.
* platform/qt/svg/wicd/test-scalable-background-image1-expected.png: Added.
* platform/qt/svg/wicd/test-scalable-background-image1-expected.txt: Added.
* platform/qt/svg/wicd/test-scalable-background-image2-expected.png: Added.
* platform/qt/svg/wicd/test-scalable-background-image2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Alexandru Chiculita <achicu@adobe.com>
commit-queue@webkit.org [Mon, 6 Jun 2011 10:45:12 +0000 (10:45 +0000)]
2011-06-06  Alexandru Chiculita  <achicu@adobe.com>

        Reviewed by Kent Tamura.

        Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
        https://bugs.webkit.org/show_bug.cgi?id=61628

        * Configurations/FeatureDefines.xcconfig:
2011-06-06  Alexandru Chiculita  <achicu@adobe.com>

        Reviewed by Kent Tamura.

        Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
        https://bugs.webkit.org/show_bug.cgi?id=61628

        This patch modifies only the build system. Therefore,
        there are no new tests.

        * Configurations/FeatureDefines.xcconfig:
2011-06-06  Alexandru Chiculita  <achicu@adobe.com>

        Reviewed by Kent Tamura.

        Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
        https://bugs.webkit.org/show_bug.cgi?id=61628

        * Configurations/FeatureDefines.xcconfig:
2011-06-06  Alexandru Chiculita  <achicu@adobe.com>

        Reviewed by Kent Tamura.

        Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
        https://bugs.webkit.org/show_bug.cgi?id=61628

        * Configurations/FeatureDefines.xcconfig:
2011-06-06  Alexandru Chiculita  <achicu@adobe.com>

        Reviewed by Kent Tamura.

        Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
        https://bugs.webkit.org/show_bug.cgi?id=61628

        * Scripts/build-webkit:
2011-06-06  Alexandru Chiculita  <achicu@adobe.com>

        Reviewed by Kent Tamura.

        Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
        https://bugs.webkit.org/show_bug.cgi?id=61628

        * win/tools/vsprops/FeatureDefines.vsprops:
        * win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Mon, 6 Jun 2011 09:36:06 +0000 (09:36 +0000)]
2011-06-06  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, new baselines for GTK after r88029 and r80034.

        * platform/gtk/fast/forms/selectlist-minsize-expected.png: Added.
        * platform/gtk/fast/forms/selectlist-minsize-expected.txt: Added.
        * platform/gtk/fullscreen/full-screen-placeholder-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-02 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 6 Jun 2011 09:29:45 +0000 (09:29 +0000)]
2011-06-02  MORITA Hajime  <morrita@google.com>

        Verify cloning <meter> and <progress> works
        https://bugs.webkit.org/show_bug.cgi?id=61986

        Added test cases for cloning <meter> and <progress>

        * fast/dom/HTMLMeterElement/meter-clone-expected.txt: Added.
        * fast/dom/HTMLMeterElement/meter-clone.html: Added.
        * fast/dom/HTMLProgressElement/progress-clone-expected.txt: Added.
        * fast/dom/HTMLProgressElement/progress-clone.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>
commit-queue@webkit.org [Mon, 6 Jun 2011 08:46:21 +0000 (08:46 +0000)]
2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>

        Reviewed by Kent Tamura.

        Add ENABLE(CSS_REGIONS) guard for CSS Regions support
        https://bugs.webkit.org/show_bug.cgi?id=61631

        * Configurations/FeatureDefines.xcconfig:
2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>

        Reviewed by Kent Tamura.

        Add ENABLE(CSS_REGIONS) guard for CSS Regions support
        https://bugs.webkit.org/show_bug.cgi?id=61631

        This patch modifies only the build system. Therefore,
        there are no new tests.

        * Configurations/FeatureDefines.xcconfig:
2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>

        Reviewed by Kent Tamura.

        Add ENABLE(CSS_REGIONS) guard for CSS Regions support
        https://bugs.webkit.org/show_bug.cgi?id=61631

        * Configurations/FeatureDefines.xcconfig:
2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>

        Reviewed by Kent Tamura.

        Add ENABLE(CSS_REGIONS) guard for CSS Regions support
        https://bugs.webkit.org/show_bug.cgi?id=61631

        * Configurations/FeatureDefines.xcconfig:
2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>

        Reviewed by Kent Tamura.

        Add ENABLE(CSS_REGIONS) guard for CSS Regions support
        https://bugs.webkit.org/show_bug.cgi?id=61631

        * Scripts/build-webkit:
2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>

        Reviewed by Kent Tamura.

        Add ENABLE(CSS_REGIONS) guard for CSS Regions support
        https://bugs.webkit.org/show_bug.cgi?id=61631

        * win/tools/vsprops/FeatureDefines.vsprops:
        * win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Mon, 6 Jun 2011 08:35:50 +0000 (08:35 +0000)]
2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Anders Carlsson.

        [UNIX] SOCK_DGRAM sockets are not notified when the other end closes the connection
        https://bugs.webkit.org/show_bug.cgi?id=61538

        Use SOCK_STREAM instead of SOCK_DGRAM sockets. Rework the message
        receiver code to support stream sockets, since it requires to
        handle message boundaries. The same code works for DGRAM sockets,
        so this change shouldn't break other ports using DGRAM.

        * Platform/CoreIPC/Connection.h:
        * Platform/CoreIPC/unix/ConnectionUnix.cpp:
        (CoreIPC::Connection::platformInitialize):
        (CoreIPC::Connection::processMessage): Process messages from data
        already received.
        (CoreIPC::readBytesFromSocket): Read from socket using recvmsg().
        (CoreIPC::Connection::readyReadHandler):
        * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
        (WebKit::ProcessLauncher::launchProcess): Use SOCK_DGRAM in
        socketpair().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Mon, 6 Jun 2011 08:09:17 +0000 (08:09 +0000)]
2011-06-03  Hans Wennborg  <hans@chromium.org>

        Reviewed by Tony Gentilcore.

        IndexedDB: Clean-up function prototypes in IDBLevelDBBackingStore.cpp
        https://bugs.webkit.org/show_bug.cgi?id=62013

        Clean up the prototypes for cursor open functions by introducing the
        CursorOptions struct.

        Just clean-up, no new functionality so no new tests.

        * storage/IDBLevelDBBackingStore.cpp:
        (WebCore::CursorOptions::CursorImplCommon::CursorImplCommon):
        (WebCore::CursorOptions::CursorImplCommon::firstSeek):
        (WebCore::CursorOptions::CursorImplCommon::continueFunction):
        (WebCore::CursorOptions::ObjectStoreCursorImpl::create):
        (WebCore::CursorOptions::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
        (WebCore::CursorOptions::IndexKeyCursorImpl::create):
        (WebCore::CursorOptions::IndexKeyCursorImpl::IndexKeyCursorImpl):
        (WebCore::CursorOptions::IndexCursorImpl::create):
        (WebCore::CursorOptions::IndexCursorImpl::IndexCursorImpl):
        (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
        (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
        (WebCore::IDBLevelDBBackingStore::openIndexCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Mon, 6 Jun 2011 07:57:26 +0000 (07:57 +0000)]
2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix the GTK+ build.

        * GNUmakefile.am: Add javascriptcore_cflags variable.

2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix the GTK+ build.

        * GNUmakefile.am: Add javascriptcore_cflags variable.

2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix the GTK+ build.

        * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-06 Mustafizur Rahaman <mustaf.here@gmail.com>
commit-queue@webkit.org [Mon, 6 Jun 2011 07:27:29 +0000 (07:27 +0000)]
2011-06-06  Mustafizur Rahaman  <mustaf.here@gmail.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=48290
        Removed LayoutTests/canvas/philip/tests/2d.composite.operation.highlight.html
        from failed/skipped test list

        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
2011-06-06  Mustafizur Rahaman  <mustaf.here@gmail.com>

        Reviewed by Darin Adler.

        Fix LayoutTests/canvas/philip/tests/2d.composite.operation.highlight.html
        https://bugs.webkit.org/show_bug.cgi?id=48290

        "highlight" is not a valid globalComposite operation
        as per http://www.w3.org/TR/2011/WD-2dcontext-20110525/#compositing
        Therefore, removed the option from the source code.

        Tests: No new tests required.
        LayoutTests\canvas\philip\tests\2d.composite.operation.highlight.html can be used for testing.

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::operator CompositeOperator):
        * platform/graphics/GraphicsTypes.cpp:
        * platform/graphics/GraphicsTypes.h:
        * platform/graphics/cairo/CairoUtilities.cpp:
        (WebCore::toCairoOperator):
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::setPlatformCompositeOperation):
        * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
        (WebCore::SharedGraphicsContext3D::applyCompositeOperator):
        * platform/graphics/openvg/PainterOpenVG.cpp:
        (WebCore::PlatformPainterState::applyBlending):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::toQtCompositionMode):
        * platform/graphics/skia/SkiaUtils.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Unreviewed. Update platform specific expected files after r88020.
ossy@webkit.org [Mon, 6 Jun 2011 06:12:05 +0000 (06:12 +0000)]
[Qt][WK2] Unreviewed. Update platform specific expected files after r88020.

* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
* platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed trivial fix.
ossy@webkit.org [Mon, 6 Jun 2011 05:54:27 +0000 (05:54 +0000)]
[Qt] Unreviewed trivial fix.

* platform/qt/Skipped: Remove svg/hixie/links/003-broken.xml, because it was deleted by r87518.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac] Unreviewed. Skip new failing tests.
ossy@webkit.org [Mon, 6 Jun 2011 05:49:36 +0000 (05:49 +0000)]
[Qt][Mac] Unreviewed. Skip new failing tests.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed. Update platform specific expected files after r88020.
ossy@webkit.org [Mon, 6 Jun 2011 05:38:49 +0000 (05:38 +0000)]
[Qt] Unreviewed. Update platform specific expected files after r88020.

* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Mon, 6 Jun 2011 04:56:45 +0000 (04:56 +0000)]
2011-06-04  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Kent Tamura.

        Add some asserts for array boundary checks in TextRun. Fix
        an integer issue in linux text controller code.
        https://bugs.webkit.org/show_bug.cgi?id=62085

        Testing ComplexTextControllerLinux change requires a testcase
        > 32 kb which is not feasible. All other changes are tested by
        existing layouttests.

        * platform/graphics/TextRun.h:
        (WebCore::TextRun::operator[]): add assert.
        (WebCore::TextRun::data): add assert.
        * platform/graphics/WidthIterator.cpp:
        (WebCore::WidthIterator::advance): bail early and prevent access
        to one byte across the text run boundary.
        * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
        (WebCore::ComplexTextController::getNormalizedTextRun): wrong
        int16 vs int comparison.
        * rendering/svg/SVGTextRunRenderingContext.cpp:
        (WebCore::SVGTextRunWalker::walk): bail early when from and to
        is outside the text run boundary. this hit easily after adding
        the assert when from = to = end and read in run.data(from).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-05 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 6 Jun 2011 02:01:31 +0000 (02:01 +0000)]
2011-06-05  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Rolling out r84528.
        http://trac.webkit.org/changeset/84528
        https://bugs.webkit.org/show_bug.cgi?id=62100

        * fast/dom/shadow/import-shadowroot-expected.txt: Removed.
        * fast/dom/shadow/import-shadowroot.html: Removed.
2011-06-05  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Rolling out r84528.
        http://trac.webkit.org/changeset/84528
        https://bugs.webkit.org/show_bug.cgi?id=62100

        It made several problems on elements with new shadow DOM.

        * dom/Element.cpp:
        (WebCore::Element::copyNonAttributeProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Add an e-mail address for Cameron McCormack that matches Bugzilla (so that...
ap@apple.com [Sun, 5 Jun 2011 20:13:07 +0000 (20:13 +0000)]
    Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
        works properly).

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-05 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sun, 5 Jun 2011 20:12:33 +0000 (20:12 +0000)]
2011-06-05  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Fix and unskip acid2
        https://bugs.webkit.org/show_bug.cgi?id=62089

        We're unskipping acid2.html event though it's just a landing
        page for the acid2 test. Some elements of the test are loaded by
        the landing page so it is testing something, but acid2-pixel covers the same
        ground.

        * platform/qt/Skipped:
        * platform/qt/fast/css/acid2-expected.txt: Updated
        * platform/qt/fast/css/acid2-pixel-expected.png: Added.
        * platform/qt/fast/css/acid2-pixel-expected.txt: Added.
        * platform/qt/fast/overflow/overflow-height-float-not-removed-crash-expected.txt: Removed.
        * platform/qt/fast/overflow/overflow-height-float-not-removed-crash3-expected.txt: Removed.
        * platform/qt/http/tests/misc/acid2-expected.png: Added.
        * platform/qt/http/tests/misc/acid2-expected.txt: Added.
        * platform/qt/http/tests/misc/acid2-pixel-expected.png: Added.
        * platform/qt/http/tests/misc/acid2-pixel-expected.txt: Added
2011-06-04  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Fix and unskip acid2
        https://bugs.webkit.org/show_bug.cgi?id=62089

        shouldFallBack() tells the DOM if it should attempt to render
        the next nested <object> if its parent fails to load.

        This fix is only required for the fast/css version of the ACID2
        test, which loads a non-existent file:// url. The HTTP version of the
        test already passes because the loader will render fallback content
        on a failed HTTP load without delegating the decision to the client
        ( see MainResourceLoader::continueAfterContentPolicy).

        Some ports also check for WebKitErrorPluginWillHandleLoad when deciding
        what to return. This error isn't currently set by Qt so we don't check
        it. (Other ports set it when the erring document is a MediaDocument, maybe
        we should do that too at some point).

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::shouldFallBack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-05 Igor Oliveira <igor.oliveira@openbossa.org>
commit-queue@webkit.org [Sun, 5 Jun 2011 18:34:07 +0000 (18:34 +0000)]
2011-06-05  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        fast/viewport/viewport-45.html fails in GTK+/Qt
        https://bugs.webkit.org/show_bug.cgi?id=47481

        Rebaseline tests.

        * fast/viewport/viewport-45-expected.txt:
        * fast/viewport/viewport-86-expected.txt:
        * platform/qt/Skipped:
2011-06-05  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        fast/viewport/viewport-45.html fails in GTK+/Qt
        https://bugs.webkit.org/show_bug.cgi?id=47481

        computeViewportAttributes does many math operations with float point arithmetic
        and in some cases there is loss of precision making tests have incorrect values.

        * dom/ViewportArguments.cpp:
        (WebCore::computeViewportAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fix. Update git branch build dir handling to match what other...
kevino@webkit.org [Sun, 5 Jun 2011 05:28:39 +0000 (05:28 +0000)]
[wx] Unreviewed build fix. Update git branch build dir handling to match what other WebKit scripts expect, so other scripts work properly with wx.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fix. Restore the PPC build and allow users to specify architect...
kevino@webkit.org [Sun, 5 Jun 2011 05:07:04 +0000 (05:07 +0000)]
[wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures to build on Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fixes for recent trunk changes.
kevino@webkit.org [Sun, 5 Jun 2011 04:38:09 +0000 (04:38 +0000)]
[wx] Unreviewed build fixes for recent trunk changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRoll over some ChangeLogs.
mrowe@apple.com [Sun, 5 Jun 2011 03:21:09 +0000 (03:21 +0000)]
Roll over some ChangeLogs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 5 Jun 2011 02:08:54 +0000 (02:08 +0000)]
2011-06-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Disable WebProcess side display throttling when in a user scroll
        <rdar://problem/9517175>
        https://bugs.webkit.org/show_bug.cgi?id=62095

        Add the ability to disable WebProcess side display throttling that
        takes place in DrawingAreaImpl::displayTimerFired. Disable the throttling
        when in a user or animated scroll.

        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::didStartRubberBandForFrame):
        (WebKit::WebChromeClient::didCompleteRubberBandForFrame):
        (WebKit::WebChromeClient::didStartAnimatedScroll):
        (WebKit::WebChromeClient::didCompleteAnimatedScroll):
        * WebProcess/WebPage/DrawingArea.h:
        (WebKit::DrawingArea::enableDisplayThrottling):
        (WebKit::DrawingArea::disableDisplayThrottling):
        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::DrawingAreaImpl):
        (WebKit::DrawingAreaImpl::enableDisplayThrottling):
        (WebKit::DrawingAreaImpl::disableDisplayThrottling):
        (WebKit::DrawingAreaImpl::displayTimerFired):
        * WebProcess/WebPage/DrawingAreaImpl.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::wheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sun, 5 Jun 2011 00:09:09 +0000 (00:09 +0000)]
2011-06-04  Gustavo Noronha Silva  <gns@gnome.org>

        Unreviewed, MIPS build fix.

        WebKitGTK+ tarball fails to build on MIPS.
        https://buildd.debian.org/status/fetch.php?pkg=webkitgtk%2B&arch=mips&ver=1.4.0-1&stamp=1304786691

        * GNUmakefile.list.am: Add missing MIPS-related file to the list
        of files that are added to the tarball on make dist, and fix
        sorting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 4 Jun 2011 21:03:29 +0000 (21:03 +0000)]
2011-06-04  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        [Mac WebKit2] REGRESSION (r86692): Synchronous XMLHttpRequest hangs in credential shim (affects Netgear ReadyNAS admin page)
        https://bugs.webkit.org/show_bug.cgi?id=62094
        rdar://problem/9539204

        * WebCore.exp.in: Export ResourceHandle::synchronousLoadRunLoopMode.
        * platform/network/ResourceHandle.h: Add synchronousLoadRunLoopMode.
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::synchronousLoadRunLoopMode): Added.
        (WebCore::ResourceHandle::loadResourceSynchronously): Call synchronousLoadRunLoopMode.
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::synchronousLoadRunLoopMode): Added.
        (WebCore::ResourceHandle::loadResourceSynchronously): Call synchronousLoadRunLoopMode.
2011-06-04  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        [Mac WebKit2] REGRESSION (r86692): Synchronous XMLHttpRequest hangs in credential shim (affects Netgear ReadyNAS admin page)
        https://bugs.webkit.org/show_bug.cgi?id=62094
        rdar://problem/9539204

        * WebKit2.xcodeproj/project.pbxproj: Added new source files.
        * WebProcess/mac/CoreIPCClientRunLoop.h: Added.
        * WebProcess/mac/CoreIPCClientRunLoop.mm: Added.
        (-[WKFunctionAdapter perform]): Added.
        (WebKit::createCoreIPCRunLoopModesArray): Added.
        (WebKit::coreIPCRunLoopModesArray): Added.
        (WebKit::callOnCoreIPCClientRunLoopAndWait): Added.

        * WebProcess/mac/KeychainItemShimMethods.mm:
        (WebKit::webFreeAttributeListContent): Use callOnCoreIPCClientRunLoopAndWait.
        (WebKit::webFreeKeychainItemContent): Ditto.
        (WebKit::webSecKeychainItemCopyContent): Ditto.
        (WebKit::webSecKeychainItemCreateFromContent): Ditto.
        (WebKit::webSecKeychainItemModifyContent): Ditto.
        * WebProcess/mac/SecItemShimMethods.mm:
        (WebKit::webSecItemCopyMatching): Ditto.
        (WebKit::webSecItemAdd): Ditto.
        (WebKit::webSecItemUpdate): Ditto.
        (WebKit::webSecItemDelete): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 4 Jun 2011 19:34:29 +0000 (19:34 +0000)]
2011-06-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add InlineWalker class to hold state for repeated calls to bidiNext
        https://bugs.webkit.org/show_bug.cgi?id=60724

        This is one more little step towards removing (naked) bidiNext usage.
        More refactoring is required before all callers of bidiNext can move
        onto using an InlineWalker instead of bidiNext directly.

        No change in behavior, thus no tests.

        * rendering/InlineIterator.h:
        (WebCore::InlineWalker::InlineWalker):
        (WebCore::InlineWalker::root):
        (WebCore::InlineWalker::current):
        (WebCore::InlineWalker::atEndOfInline):
        (WebCore::InlineWalker::atEnd):
        (WebCore::InlineWalker::advance):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::simplifiedNormalFlowLayout):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 4 Jun 2011 19:20:00 +0000 (19:20 +0000)]
2011-06-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        WebKit2 needs to know when a scroll is happening due to the ScrollAnimator
        https://bugs.webkit.org/show_bug.cgi?id=62093

        Add additional ChromeClient functions to indicate the beginning and end of
        the various ScrollAnimator animations. Change existing notification that a
        rubber-band has completed for the main frame to be triggered for all frames.

        * page/ChromeClient.h:
        (WebCore::ChromeClient::didStartRubberBandForFrame):
        (WebCore::ChromeClient::didCompleteRubberBandForFrame):
        (WebCore::ChromeClient::didStartAnimatedScroll):
        (WebCore::ChromeClient::didCompleteAnimatedScroll):
        * page/FrameView.cpp:
        (WebCore::FrameView::didStartRubberBand):
        (WebCore::FrameView::didCompleteRubberBand):
        (WebCore::FrameView::didStartAnimatedScroll):
        (WebCore::FrameView::didCompleteAnimatedScroll):
        * page/FrameView.h:
        * platform/ScrollableArea.h:
        (WebCore::ScrollableArea::didStartRubberBand):
        (WebCore::ScrollableArea::didStartAnimatedScroll):
        (WebCore::ScrollableArea::didCompleteAnimatedScroll):
        * platform/mac/ScrollAnimatorMac.h:
        * platform/mac/ScrollAnimatorMac.mm:
        (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
        (WebCore::ScrollAnimatorMac::scroll):
        (WebCore::ScrollAnimatorMac::immediateScrollToPointForScrollAnimation):
        (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
2011-06-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        WebKit2 needs to know when a scroll is happening due to the ScrollAnimator
        https://bugs.webkit.org/show_bug.cgi?id=62093

        Stub out new ChromeClient functions regarding the start and end of ScrollAnimator
        animated scrolls, and update logic for rubber-band ending to check for main frame
        now that it is called for all frames.

        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::didStartRubberBandForFrame):
        (WebKit::WebChromeClient::didCompleteRubberBandForFrame):
        (WebKit::WebChromeClient::didStartAnimatedScroll):
        (WebKit::WebChromeClient::didCompleteAnimatedScroll):
        * WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Sat, 4 Jun 2011 18:59:11 +0000 (18:59 +0000)]
2011-06-04  Martin Robinson  <mrobinson@igalia.com>

        Touch a file to try to fix the GTK+ build on the 32-bit bot.

        * testing/Internals.idl: Touch this IDL file in an effort to fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 4 Jun 2011 18:55:17 +0000 (18:55 +0000)]
2011-06-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Fix formatting of the output generated by KeywordLookupGenerator.py
        https://bugs.webkit.org/show_bug.cgi?id=62083

        - Uses correct year for copyright.
        - Puts ending brace on same line as "else if"
        - Puts starting brace of function on its own line.
        - Adds some tasteful whitespace.
        - Adds comments to make clear that scopes are ending
        - Make macros actually split on two lines.

        * KeywordLookupGenerator.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Sat, 4 Jun 2011 17:23:32 +0000 (17:23 +0000)]
2011-06-04  Martin Robinson  <mrobinson@igalia.com>

        Fix the GTK+ build.

        * bindings/gobject/GNUmakefile.am: Make the GObject build less noisy.
2011-06-04  Martin Robinson  <mrobinson@igalia.com>

        Fix the GTK+ build.

        * GNUmakefile.am: Add some missing newline escape.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 4 Jun 2011 17:14:22 +0000 (17:14 +0000)]
2011-06-03  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Convert file <input> to use the new shadow DOM model
        https://bugs.webkit.org/show_bug.cgi?id=59005

        Refactoring, covered by existing tests.

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::pseudoId): Removed FILE_UPLOAD_BUTTON pseudoId and all references to it.
        (WebCore::nameToPseudoTypeMap): Ditto.
        (WebCore::CSSSelector::extractPseudoType): Ditto.
        * css/CSSSelector.h: Ditto.
        * css/html.css:
        (input[type="button"], input[type="submit"], input[type="reset"]): Moved -webkit-file-upload-button to its own rule.
        (input[type="file"]::-webkit-file-upload-button): Added and moved all previously hard-coded properties there.
        * html/FileInputType.cpp:
        (WebCore::UploadButtonElement::create): Added.
        (WebCore::UploadButtonElement::UploadButtonElement): Added.
        (WebCore::UploadButtonElement::shadowPseudoId): Added.
        (WebCore::FileInputType::createShadowSubtree): Added.
        * html/FileInputType.h: Added createShadowSubtree decl.
        * page/DragController.cpp:
        (WebCore::asFileInput): Changed the logic to use new shadow DOM.
        * rendering/RenderFileUploadControl.cpp: Removed UploadButton class.
        (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed initializer for m_button.
        (WebCore::RenderFileUploadControl::updateFromElement): Removed attachment logic that's no longer necessary.
        (WebCore::nodeWidth): Added a helper.
        (WebCore::RenderFileUploadControl::maxFilenameWidth): Changed to use uploadButton and nodeWidth.
        (WebCore::RenderFileUploadControl::paintObject): Ditto.
        (WebCore::RenderFileUploadControl::uploadButton): Added a helper to retrieve the button.
        (WebCore::RenderFileUploadControl::buttonValue): Changed to use uploadButton.
        * rendering/RenderFileUploadControl.h: Changed decls.
        * rendering/style/RenderStyleConstants.h: Removed FILE_UPLOAD_BUTTON decls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 4 Jun 2011 12:56:33 +0000 (12:56 +0000)]
2011-06-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        KeywordLookupGenerator.py spams stdout in Chromium Linux build
        https://bugs.webkit.org/show_bug.cgi?id=62087

        This action does not appear to be needed.

        * JavaScriptCore.gyp/JavaScriptCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Sat, 4 Jun 2011 12:06:49 +0000 (12:06 +0000)]
2011-06-04  Nico Weber  <thakis@chromium.org>

        Reviewed by James Robinson.

        [chromium] Make ResourceHandleInternal's destructor virtual
        https://bugs.webkit.org/show_bug.cgi?id=62073

        This is _not_ to fix a real bug, just to make clang's
        -Wdelete-non-virtual-dtor happy. As discussed at
        http://codereview.chromium.org/7094005/, we prefer making leaf class
        destructors virtual over making the leaf classes final.

        * src/ResourceHandle.cpp:
        (WebCore::ResourceHandleInternal::~ResourceHandleInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Sat, 4 Jun 2011 11:35:00 +0000 (11:35 +0000)]
2011-06-04  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Enable passing File API tests
        https://bugs.webkit.org/show_bug.cgi?id=62020

        File API has been enabled for QtWebKit in r74115,
        let's also enable the passing related tests.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Alexey Proskuryakov <ap@apple.com>
ap@apple.com [Sat, 4 Jun 2011 11:23:09 +0000 (11:23 +0000)]
2011-06-04  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        Input value sanitization for text fields is incorrect
        https://bugs.webkit.org/show_bug.cgi?id=62061
        <rdar://problem/9553273>

        * fast/forms/input-value-sanitization-expected.txt:
        * fast/forms/input-value-sanitization.html:
        * fast/forms/paste-multiline-text-input.html:
        * fast/forms/script-tests/input-value-sanitization.js: Removed.
2011-06-04  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        Input value sanitization for text fields is incorrect
        https://bugs.webkit.org/show_bug.cgi?id=62061
        <rdar://problem/9553273>

        Newline characters should be removed according to HTML5, not replaced with spaces.
        This also matches Safari 5 behavior.

        * html/TextFieldInputType.cpp:
        (WebCore::isASCIILineBreak): A functor for removeCharacters().
        (WebCore::limitLength): Do one thing at once.
        (WebCore::TextFieldInputType::sanitizeValue): Sanitization removes newlines.
        (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent): Moved (somewhat surprising)
        code that replaces newlines with spaces here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Sat, 4 Jun 2011 11:14:49 +0000 (11:14 +0000)]
2011-06-04  Nico Weber  <thakis@chromium.org>

        Reviewed by James Robinson.

        [chromium] Make ChromePrintContext's destructor virtual
        https://bugs.webkit.org/show_bug.cgi?id=62076

        Since WebFrameImpl's m_printContext is a OnwPtr<ChromePrintContext>
        that is dynamically set to either a ChromePrintContext or a
        ChromePluginPrintContext, this fixes an actual bug.

        * src/WebFrameImpl.cpp:
        (WebKit::ChromePrintContext::~ChromePrintContext):
        (WebKit::ChromePluginPrintContext::~ChromePluginPrintContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Sat, 4 Jun 2011 11:06:49 +0000 (11:06 +0000)]
2011-06-04  Nico Weber  <thakis@chromium.org>

        Reviewed by James Robinson.

        [chromium] Make WebTextCheckingCompletionImpl's destructor virtual
        https://bugs.webkit.org/show_bug.cgi?id=62074

        This is _not_ to fix a real bug, just to make clang's
        -Wdelete-non-virtual-dtor happy. As discussed at
        http://codereview.chromium.org/7094005/, we prefer making leaf class
        destructors virtual over making the leaf classes final.

        * src/WebTextCheckingCompletionImpl.h:
        (WebKit::WebTextCheckingCompletionImpl::~WebTextCheckingCompletionImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Sat, 4 Jun 2011 10:58:47 +0000 (10:58 +0000)]
2011-06-04  Nico Weber  <thakis@chromium.org>

        Reviewed by James Robinson.

        [chromium] Make PlatformMessagePortChannel's destructor virtual
        https://bugs.webkit.org/show_bug.cgi?id=62072

        This is _not_ to fix a real bug, just to make clang's
        -Wdelete-non-virtual-dtor happy. As discussed at
        http://codereview.chromium.org/7094005/, we prefer making leaf class
        destructors virtual over making the leaf classes final.

        * src/PlatformMessagePortChannel.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Sat, 4 Jun 2011 10:50:51 +0000 (10:50 +0000)]
2011-06-04  Nico Weber  <thakis@chromium.org>

        Reviewed by James Robinson.

        [chromium] Give VoidCallbackClient a virtual destructor
        https://bugs.webkit.org/show_bug.cgi?id=62067

        This is _not_ to fix a real bug, just to make clang's
        -Wdelete-non-virtual-dtor happy. As discussed at
        http://codereview.chromium.org/7094005/, we prefer making leaf class
        destructors virtual over making the leaf classes final.

        * src/NotificationPresenterImpl.cpp:
        (WebKit::VoidCallbackClient::~VoidCallbackClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Sat, 4 Jun 2011 10:42:18 +0000 (10:42 +0000)]
2011-06-04  Nico Weber  <thakis@chromium.org>

        Reviewed by James Robinson.

        [chromium] Make WebFrameImpl destructor virtual
        https://bugs.webkit.org/show_bug.cgi?id=62065

        This is _not_ to fix a real bug, just to make clang's
        -Wdelete-non-virtual-dtor happy. As discussed at
        http://codereview.chromium.org/7094005/, we prefer making leaf class
        destructors virtual over making the leaf classes final.

        * src/WebFrameImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Jeffrey Pfau <jpfau@apple.com>
commit-queue@webkit.org [Sat, 4 Jun 2011 10:32:26 +0000 (10:32 +0000)]
2011-06-04  Jeffrey Pfau  <jpfau@apple.com>

        Reviewed by Beth Dakin.

        Crash in WebCore::RenderMathMLSubSup::baselinePosition()
        https://bugs.webkit.org/show_bug.cgi?id=57897

        Added simple test that hits the relevant code.

        * mathml/msubsup-remove-children-expected.txt: Added.
        * mathml/msubsup-remove-children.xhtml: Added.
2011-06-04  Jeffrey Pfau  <jpfau@apple.com>

        Reviewed by Beth Dakin.

        Crash in WebCore::RenderMathMLSubSup::baselinePosition()
        https://bugs.webkit.org/show_bug.cgi?id=57897

        Simple patch adding NULL checks in each function.
        Test: mathml/msubsup-remove-children.xhtml

        * rendering/mathml/RenderMathMLSubSup.cpp:
        (WebCore::RenderMathMLSubSup::stretchToHeight):
        (WebCore::RenderMathMLSubSup::baselinePosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Sat, 4 Jun 2011 10:24:13 +0000 (10:24 +0000)]
2011-06-04  Nico Weber  <thakis@chromium.org>

        Reviewed by James Robinson.

        Give IDBBackingStore::Transaction a virtual destructor
        https://bugs.webkit.org/show_bug.cgi?id=62063

        IDBLevelDBBackingStore::createTransaction() hands out a
        PassRefPtr<IDBBackingStore::Transaction>, which means the missing
        virtual destructor is a real bug.

        * storage/IDBBackingStore.h:
        (WebCore::IDBBackingStore::Transaction::~Transaction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Sat, 4 Jun 2011 09:53:36 +0000 (09:53 +0000)]
2011-06-04  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Convert RenderBox::overflowClipRect to IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=62032

        Covered by existing tests.

        * editing/Editor.cpp:
        (WebCore::Editor::insideVisibleArea):
        * platform/graphics/IntRect.h:
        (WebCore::IntRect::contract):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::nodeAtPoint):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::pushContentsClip):
        (WebCore::RenderBox::overflowClipRect):
        * rendering/RenderBox.h:
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::calculateClipRects):
        (WebCore::RenderLayer::calculateRects):
        (WebCore::RenderLayer::repaintBlockSelectionGaps):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::clipBox):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::overflowClipRect):
        (WebCore::RenderTable::nodeAtPoint):
        * rendering/RenderTable.h:
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::nodeAtPoint):
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago* glu: Added property svn:ignore.
abarth@webkit.org [Sat, 4 Jun 2011 09:24:10 +0000 (09:24 +0000)]
* glu: Added property svn:ignore.
    - For glu.xcodeproj, which is generated from glu.gyp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 4 Jun 2011 09:22:28 +0000 (09:22 +0000)]
2011-06-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        V8Proxy::disconnectFrame doesn't do anything
        https://bugs.webkit.org/show_bug.cgi?id=62051

        Dead code should die.

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::~ScriptController):
        * bindings/v8/V8Proxy.cpp:
        * bindings/v8/V8Proxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Sat, 4 Jun 2011 09:05:38 +0000 (09:05 +0000)]
2011-06-04  Nico Weber  <thakis@chromium.org>

        Reviewed by James Robinson.

        Make the destructors of DataTransferItem and DataTransferItems virtual
        https://bugs.webkit.org/show_bug.cgi?id=62052

        Clang has grown a new warning that warns on |delete ptr| if ptr's
        class is non-final, has virtual methods, but no virtual destructor.
        This warning finds real bugs, so we want to keep it enabled. However,
        it also warns about DataTransferItem[s]. Since these are subclassed,
        they can't be made final, so make their destructors virtual. (Maybe
        clang's warning even points out an actual bug here.)

        * dom/DataTransferItem.h:
        (WebCore::DataTransferItem::~DataTransferItem):
        * dom/DataTransferItems.h:
        (WebCore::DataTransferItems::~DataTransferItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Sat, 4 Jun 2011 09:02:50 +0000 (09:02 +0000)]
2011-06-04  Nico Weber  <thakis@chromium.org>

        Reviewed by James Robinson.

        [chromium] Make LayerPainterChromium destructor virtual
        https://bugs.webkit.org/show_bug.cgi?id=62056

        LayerTextureUpdaterCanvas has an OwnPtr<LayerPainterChromium>, which
        means that without this patch, the destructor of classes implementing
        LayerPainterChromium wasn't called correctly in that case.

        * platform/graphics/chromium/LayerPainterChromium.h:
        (WebCore::LayerPainterChromium::~LayerPainterChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConfigure new commit-queue instance. (Please ignore.)
commit-queue@webkit.org [Sat, 4 Jun 2011 08:08:16 +0000 (08:08 +0000)]
Configure new commit-queue instance.  (Please ignore.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-04 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Sat, 4 Jun 2011 07:02:35 +0000 (07:02 +0000)]
2011-06-04  Emil A Eklund  <eae@chromium.org>

        Reviewed by Andreas Kling.

        Fix IntRect::expand(const IntSize& size)
        https://bugs.webkit.org/show_bug.cgi?id=62042

        No new tests.

        * platform/graphics/IntRect.h:
        (WebCore::IntRect::expand):
        Fix IntRect::expand to expand the size rather than move the location.
        Currently unused.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Sat, 4 Jun 2011 06:45:34 +0000 (06:45 +0000)]
2011-06-03  Vangelis Kokkevis  <vangelis@chromium.org>

        Unreviewed. Fixes test expectatations.

        [chromium] Fixing redefinitions of test_expectations entries
        for chrome gpu tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Sat, 4 Jun 2011 06:15:43 +0000 (06:15 +0000)]
2011-06-03  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        Lexer needs to provide Identifier for reserved words
        https://bugs.webkit.org/show_bug.cgi?id=62086

        Alas it is necessary to provide an Identifier reference for keywords
        so that we can do the right thing when they're used in object literals.
        We now keep Identifiers for all reserved words in the CommonIdentifiers
        structure so that we can access them without a hash lookup.

        * KeywordLookupGenerator.py:
        * parser/Lexer.cpp:
        (JSC::Lexer::parseIdentifier):
        * parser/Lexer.h:
        * runtime/CommonIdentifiers.cpp:
        (JSC::CommonIdentifiers::CommonIdentifiers):
        * runtime/CommonIdentifiers.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd debug code to break on speculation failures.
barraclough@apple.com [Sat, 4 Jun 2011 05:25:01 +0000 (05:25 +0000)]
Add debug code to break on speculation failures.

Reviewed by Sam Weinig.

* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGNode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=62082
barraclough@apple.com [Sat, 4 Jun 2011 05:13:44 +0000 (05:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=62082
DFG JIT - bug passing arguments that need swap

Reviewed by Sam Weinig.

This is really just a typo.
When setting up the arguments for a call out to a C operation, we'll
fail to swap arguments where this is necessary. For example, in the
case of 2 arg calls, where the first argument is in %rdx & the second
is in %rsi we should swap (exec will be passed in %rdi), but we don't.

This can also affect function calls passing three arguments.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::setupTwoStubArgs):
    - Call swap with the correct arguments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Alexey Proskuryakov <ap@apple.com>
ap@apple.com [Sat, 4 Jun 2011 04:59:11 +0000 (04:59 +0000)]
2011-06-03  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        ResourceHandleMac should always respond to an authentication challenge
        https://bugs.webkit.org/show_bug.cgi?id=61667

        I don't know if this can actually happen in practice, so no new tests.

        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
        Cancel authentication challenge if we don't have a client. We must always respond to the
        challenge to release the connection, and there is nothing else to do in this state anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the Apple LLVM Compiler build after r88087.
mitz@apple.com [Sat, 4 Jun 2011 04:35:59 +0000 (04:35 +0000)]
Try to fix the Apple LLVM Compiler build after r88087.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintMask):
* rendering/RenderTableCell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix clang build - take 2
crogers@google.com [Sat, 4 Jun 2011 03:06:32 +0000 (03:06 +0000)]
Fix clang build - take 2

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix clang build
crogers@google.com [Sat, 4 Jun 2011 02:57:47 +0000 (02:57 +0000)]
Fix clang build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Sat, 4 Jun 2011 02:25:54 +0000 (02:25 +0000)]
2011-06-03  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch paintMask and paintObject to use IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=62077

        Switching paintMask and paintObject to use IntPoint for their paint offset instead of
        a pair of ints. paintObject is still on tx/ty, but paintMask was converted to IntSize
        passed by value -- bringing it in-line with the agreed-upon convention of a const IntPoint&.

        No new tests since this is simple refactoring.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paint):
        (WebCore::RenderBlock::paintObject):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintMask):
        (WebCore::RenderBox::pushContentsClip):
        (WebCore::RenderBox::popContentsClip):
        * rendering/RenderBox.h:
        (WebCore::RenderBox::paintObject):
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::paintMask):
        * rendering/RenderFieldset.h:
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::paintObject):
        * rendering/RenderFileUploadControl.h:
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::paintObject):
        * rendering/RenderListBox.h:
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::paint):
        * rendering/RenderReplica.cpp:
        (WebCore::RenderReplica::paint):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paint):
        (WebCore::RenderTable::paintObject):
        (WebCore::RenderTable::paintMask):
        * rendering/RenderTable.h:
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::paint):
        (WebCore::RenderTableSection::paintObject):
        * rendering/RenderTableSection.h:
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::paintPlaceholder):
        (WebCore::RenderTextControl::paintObject):
        * rendering/RenderTextControl.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::paint):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Sat, 4 Jun 2011 01:34:57 +0000 (01:34 +0000)]
2011-06-03  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Force inlining of some hot lexer functions
        https://bugs.webkit.org/show_bug.cgi?id=62079

        Fix more GCC stupidity

        * parser/Lexer.h:
        (JSC::Lexer::isWhiteSpace):
        (JSC::Lexer::isLineTerminator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Sat, 4 Jun 2011 00:43:42 +0000 (00:43 +0000)]
2011-06-03  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        GCC not inlining some functions that it really should be
        https://bugs.webkit.org/show_bug.cgi?id=62075

        Add ALWAYS_INLINE to a number of parsing and lexing functions
        that should always be inlined.  This gets us ~1.4% on my ad hoc
        parser test.

        * KeywordLookupGenerator.py:
        * parser/JSParser.cpp:
        (JSC::JSParser::next):
        (JSC::JSParser::nextTokenIsColon):
        (JSC::JSParser::consume):
        (JSC::JSParser::match):
        (JSC::JSParser::tokenStart):
        (JSC::JSParser::tokenLine):
        (JSC::JSParser::tokenEnd):
        * parser/Lexer.cpp:
        (JSC::isIdentPart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWhoops, fix last minute bug.
oliver@apple.com [Sat, 4 Jun 2011 00:39:07 +0000 (00:39 +0000)]
Whoops, fix last minute bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Cary Clark <caryclark@google.com>
commit-queue@webkit.org [Sat, 4 Jun 2011 00:22:09 +0000 (00:22 +0000)]
2011-06-03  Cary Clark  <caryclark@google.com>

        Reviewed by Eric Seidel.

        Support FontCustomPlatformData on Skia-Mac-Chrome variant
        https://bugs.webkit.org/show_bug.cgi?id=62040

        Canvas text is only recognized by Skia if it is registered
        by creating a new SkTypeface. Skia uses CGFont to measure
        and render the glyphs, then takes care of managing the glyph
        cache.

        Skia on Mac Chrome is not yet enabled, so this change
        does not affect existing code, and requires no new tests.

        * platform/graphics/mac/FontCustomPlatformData.cpp:
        (WebCore::RemoteFontStream::RemoteFontStream):
        (WebCore::RemoteFontStream::~RemoteFontStream):
        (WebCore::RemoteFontStream::rewind):
        (WebCore::RemoteFontStream::read):
        Turn the buffer into a stream. This is identical to
        the implementation in skia/FontCustomPlatformData.cpp.
        While that file could be modified instead of this one,
        it was simpler to add SkTypeface streaming to this instead
        of adding all CGFont support to the skia platform file.

        (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
        Release the SkTypeface reference.

        (WebCore::createFontCustomPlatformData):
        Associate the buffer stream with a SkTypeface so Skia
        can find the custom font data.

        * platform/graphics/mac/FontCustomPlatformData.h:
        (WebCore::FontCustomPlatformData::FontCustomPlatformData):
        Add a slot to hold the SkTypeface.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Sat, 4 Jun 2011 00:16:04 +0000 (00:16 +0000)]
2011-06-03  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Brian Weinstein.

        HistoryItem children persist across page loads
        https://bugs.webkit.org/show_bug.cgi?id=62071
        <rdar://problem/9552129>

        Not testable since there's no way to check for the presence/absence
        of children for a HistoryItem.

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::reset): Call clearChildren when we're reusing a HistoryItem.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-03 James Robinson <jamesr@chromium.org>
jamesr@google.com [Sat, 4 Jun 2011 00:09:15 +0000 (00:09 +0000)]
2011-06-03  James Robinson  <jamesr@chromium.org>

        [chromium] Mark GPU-only expectations as GPU.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88079 268f45cc-cd09-0410-ab3c-d52691b4dbfc