WebKit-https.git
7 years ago[Qt] Unreviewed gardening. Add platform specific expected result for new tests.
rgabor@webkit.org [Wed, 19 Oct 2011 09:45:48 +0000 (09:45 +0000)]
[Qt] Unreviewed gardening. Add platform specific expected result for new tests.

* platform/qt/fast/multicol/vertical-rl/rule-style-expected.png: Added.
* platform/qt/fast/multicol/vertical-rl/rule-style-expected.txt: Added.
* platform/qt/fast/selectors/visited-descendant-expected.png: Added.
* platform/qt/fast/selectors/visited-descendant-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Added missing files to build WebKit2 EFL
commit-queue@webkit.org [Wed, 19 Oct 2011 08:32:30 +0000 (08:32 +0000)]
[EFL][WK2] Added missing files to build WebKit2 EFL
https://bugs.webkit.org/show_bug.cgi?id=70312

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-10-19
Reviewed by Ryosuke Niwa.

Added missing files to WebCore/CMakeListEfl.txt script:
- platform/network/soup/CredentialStorageSoup.cpp
- platform/network/soup/ProxyServerSoup.cpp
Fixes few linking time errors.

* CMakeListsEfl.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Added missing dummy interpretKeyEvent function
commit-queue@webkit.org [Wed, 19 Oct 2011 07:53:02 +0000 (07:53 +0000)]
[EFL][WK2] Added missing dummy interpretKeyEvent function
https://bugs.webkit.org/show_bug.cgi?id=70311

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-10-19
Reviewed by Ryosuke Niwa.

Added missing dummy interpretKeyEvent function needed to compile WK2.

* WebProcess/WebPage/efl/WebPageEfl.cpp:
(WebKit::WebPage::interpretKeyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename AllowAllocation to ConstructorMode
haraken@chromium.org [Wed, 19 Oct 2011 07:47:20 +0000 (07:47 +0000)]
Rename AllowAllocation to ConstructorMode
https://bugs.webkit.org/show_bug.cgi?id=70397

Reviewed by Adam Barth.

The name 'AllowAllocation' is confusing (See discussion here: bug 70015).
This patch renames 'AllowAllocation' to 'ConstructorMode' to clarify that
this class is for distinguishing the following two situations:
 1. A programmer allocates an object via "new X"; X is a function with a C++ constructCallback.
 2. C++ allocates an object via the function template and tries to wrap the object with a JS flavor.

Tests: fast/events/constructors/*

* bindings/scripts/CodeGeneratorV8.pm: Renamed AllowAllocation to ConstructorMode.
(GenerateConstructorCallback):
* bindings/scripts/test/V8/V8TestInterface.cpp: Updated a run-binding-tests result.
(WebCore::V8TestInterface::constructorCallback):
* bindings/v8/V8Binding.cpp: Renamed AllowAllocation to ConstructorMode.
(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):
* bindings/v8/V8Binding.h: Ditto.
(WebCore::ConstructorMode::ConstructorMode):
(WebCore::ConstructorMode::~ConstructorMode):
(WebCore::ConstructorMode::current):
(WebCore::SafeAllocation::newInstance):
* bindings/v8/V8Proxy.cpp: Ditto.
(WebCore::V8Proxy::checkNewLegal):
* bindings/v8/custom/V8EventConstructors.cpp: Ditto.
(WebCore::constructV8Event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Test expectation change.
yuzo@google.com [Wed, 19 Oct 2011 07:32:14 +0000 (07:32 +0000)]
[chromium] Test expectation change.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Added missing dummy platformDescription function
commit-queue@webkit.org [Wed, 19 Oct 2011 07:18:01 +0000 (07:18 +0000)]
[EFL] Added missing dummy platformDescription function
https://bugs.webkit.org/show_bug.cgi?id=70310

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-10-19
Reviewed by Ryosuke Niwa.

Added dummy platformDescription function needed to compile WK2.

* platform/efl/ContextMenuEfl.cpp:
(WebCore::ContextMenu::platformDescription):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGenerate a SharedWorker constructor of V8 using [Constructor] IDL
haraken@chromium.org [Wed, 19 Oct 2011 06:57:36 +0000 (06:57 +0000)]
Generate a SharedWorker constructor of V8 using [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=67879

Reviewed by Hajime Morita.

Source/WebCore:

Spec: http://dev.w3.org/html5/workers/#shared-workers-and-the-sharedworker-interface
This patch changed SharedWorker::create(..., context, ec) to
SharedWorker::create(context, ..., ec), since a parameter specified by [CallWith]
should come at the beginning (c.f. bug 69799).

Test: ui_tests:WorkerTest.FLAKY_SharedWorkerFastConstructor
      ui_tests:WorkerTest.FLAKY_SharedWorkerFastName

* WebCore.gypi: Removed bindings/v8/custom/V8SharedWorkerCustom.cpp
* WebCore.pro: Ditto.
* bindings/js/JSSharedWorkerCustom.cpp: Moved ScriptExecutionContext parameter to the beginning.
(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker):
* bindings/v8/custom/V8SharedWorkerCustom.cpp: Removed.
* workers/SharedWorker.cpp: Moved ScriptExecutionContext parameter to the beginning.
(WebCore::SharedWorker::create): Ditto.
* workers/SharedWorker.h: Ditto.
* workers/SharedWorker.idl: Added [Constructor] IDL.

LayoutTests:

Added test cases for an undefined name and a null name on SharedWorker constructor.

* fast/workers/resources/shared-worker-name.js:
(test7.try.worker.port.onmessage):
(test7): A test case for a null name.
(test8.worker.port.onmessage):
(test8): Ditto.
(test9.try.worker.port.onmessage):
(test9): A test case for an undefined name.
(test10.worker.port.onmessage):
(test10): Ditto.
* fast/workers/shared-worker-constructor-expected.txt:
* fast/workers/shared-worker-constructor.html:
* fast/workers/shared-worker-name-expected.txt:
* platform/chromium-win/fast/workers/shared-worker-constructor-expected.txt: Updated SyntaxError with TypeError. The reason why ui_tests has been so far working without updating this error type is that shared-worker-constructor.html is marked FLAKY in chromium.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Attempt to fix Linux Clang compilation error.
yuzo@google.com [Wed, 19 Oct 2011 06:42:29 +0000 (06:42 +0000)]
[chromium] Attempt to fix Linux Clang compilation error.

Unreviewed.

* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestThreadOnly::runTestThreaded):
(WTF::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRolled out last Windows build fix because it was wrong.
ggaren@apple.com [Wed, 19 Oct 2011 05:36:11 +0000 (05:36 +0000)]
Rolled out last Windows build fix because it was wrong.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Implement NSProcessInfo::systemUptime on Mac Leopard.
jnd@chromium.org [Wed, 19 Oct 2011 04:32:28 +0000 (04:32 +0000)]
Source/WebCore: Implement NSProcessInfo::systemUptime on Mac Leopard.
https://bugs.webkit.org/show_bug.cgi?id=66577

Reviewed by Tony Chang.

* WebCore.gyp/WebCore.gyp:
* platform/chromium/ScrollAnimatorChromiumMac.mm:
(-[NSProcessInfo systemUptime]):

LayoutTests: Enable touch tests on Mac Leopard.
https://bugs.webkit.org/show_bug.cgi?id=66577

Reviewed by Tony Chang.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRolled out last Windows build fix because it was wrong.
ggaren@apple.com [Wed, 19 Oct 2011 03:55:25 +0000 (03:55 +0000)]
Rolled out last Windows build fix because it was wrong.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to fix part of the Windows build.
ggaren@apple.com [Wed, 19 Oct 2011 03:47:12 +0000 (03:47 +0000)]
Try to fix part of the Windows build.

Export!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. New expected results after http://trac.webkit.org/changeset/97707.
ojan@chromium.org [Wed, 19 Oct 2011 03:10:12 +0000 (03:10 +0000)]
Unreviewed. New expected results after trac.webkit.org/changeset/97707.

* fast/table/height-percent-test-vertical-expected.txt: Renamed from LayoutTests/platform/gtk/fast/table/height-percent-test-vertical-expected.txt.
* platform/chromium-linux/fast/table/028-vertical-expected.png:
* platform/chromium-linux/fast/table/height-percent-test-vertical-expected.png:
* platform/chromium-mac-snowleopard/fast/writing-mode/fallback-orientation-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/writing-mode/fallback-orientation-expected.png.
* platform/chromium-win-vista/fast/writing-mode/fallback-orientation-expected.png: Removed.
* platform/chromium-win-xp/fast/writing-mode/fallback-orientation-expected.png:
* platform/chromium-win/fast/table/028-vertical-expected.png:
* platform/chromium-win/fast/table/028-vertical-expected.txt:
* platform/chromium-win/fast/table/height-percent-test-vertical-expected.png:
* platform/chromium-win/fast/writing-mode/fallback-orientation-expected.png:
* platform/chromium-win/fast/writing-mode/fallback-orientation-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/qt/fast/table/height-percent-test-vertical-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSwitched ropes from malloc memory to GC memory
ggaren@apple.com [Wed, 19 Oct 2011 02:54:29 +0000 (02:54 +0000)]
Switched ropes from malloc memory to GC memory
https://bugs.webkit.org/show_bug.cgi?id=70364

Reviewed by Gavin Barraclough.

~1% SunSpider speedup. Neutral elsewhere. Removes one cause for strings
having C++ destructors.

* heap/MarkStack.cpp:
(JSC::visitChildren): Call the JSString visitChildren function now,
since it's no longer a no-op.

* runtime/JSString.cpp:
(JSC::JSString::~JSString): Moved this destructor out of line because
it's called virtually, so there's no value to inlining.

(JSC::JSString::RopeBuilder::expand): Switched RopeBuilder to be a thin
initializing wrapper around JSString. JSString now represents ropes
directly, rather than relying on an underlying malloc object.

(JSC::JSString::visitChildren): Visit our rope fibers, since they're GC
objects now.

(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase):
(JSC::JSString::outOfMemory): Updated for operating on JSStrings instead
of malloc objects.

(JSC::JSString::replaceCharacter): Removed optimizations for substringing
ropes and replacing subsections of ropes. We want to reimplement versions
of these optimizations in the future, but this patch already has good
performance without them.

* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::finishCreation):
(JSC::RopeBuilder::createNull):
(JSC::RopeBuilder::create):
(JSC::RopeBuilder::createHasOtherOwner):
(JSC::jsSingleCharacterString):
(JSC::jsSingleCharacterSubstring):
(JSC::jsNontrivialString):
(JSC::jsString):
(JSC::jsSubstring):
(JSC::jsOwnedString): Lots of mechanical changes here. The two important
things are: (1) The fibers in JSString::m_fibers are JSStrings now, not
malloc objects; (2) I simplified the JSString constructor interface to
only accept PassRefPtr<StringImpl>, instead of variations on that like
UString, reducing refcount churn.

* runtime/JSValue.h:
* runtime/JSValue.cpp:
(JSC::JSValue::toPrimitiveString): Updated this function to return a
JSString instead of a UString, since that's what clients want now.

* runtime/Operations.cpp:
(JSC::jsAddSlowCase):
* runtime/Operations.h:
(JSC::jsString):
* runtime/SmallStrings.cpp:
(JSC::SmallStrings::createEmptyString): Updated for interface changes above.

* runtime/StringConstructor.cpp:
(JSC::constructWithStringConstructor):
* runtime/StringObject.h:
(JSC::StringObject::create): Don't create a new JSString if we already
have a JSString.

* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncConcat): Updated for interface changes above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoErrrk, fix partial commit of r97825!
barraclough@apple.com [Wed, 19 Oct 2011 01:50:14 +0000 (01:50 +0000)]
Errrk, fix partial commit of r97825!

* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToISOString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDate.prototype.toISOString fails to throw exception
barraclough@apple.com [Wed, 19 Oct 2011 01:49:13 +0000 (01:49 +0000)]
Date.prototype.toISOString fails to throw exception
https://bugs.webkit.org/show_bug.cgi?id=70394

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToISOString):
    - Should throw a range error if the internal value is not finite.

LayoutTests:

* fast/js/date-toisostring-expected.txt:
* fast/js/script-tests/date-toisostring.js:
(throwsRangeError):
    - fixed test case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofix baseline for fast/history/history-back-twice-with-subframes-assert.html
dpranke@chromium.org [Wed, 19 Oct 2011 01:37:31 +0000 (01:37 +0000)]
fix baseline for fast/history/history-back-twice-with-subframes-assert.html
https://bugs.webkit.org/show_bug.cgi?id=70393

Reviewed by James Robinson.

the baseline added in r97821 appears to have had a couple of
extra lines in it.

* fast/history/history-back-twice-with-subframes-assert-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to jostle the windows build back to life.
weinig@apple.com [Wed, 19 Oct 2011 01:37:04 +0000 (01:37 +0000)]
Try to jostle the windows build back to life.

* rendering/HitTestResult.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate chromium leopard cg baseline.
dpranke@chromium.org [Wed, 19 Oct 2011 01:16:28 +0000 (01:16 +0000)]
Update chromium leopard cg baseline.

Unreviewed, baseline update.

* platform/chromium-cg-mac-leopard/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAssertion failure when going back in page with navigated subframes
andersca@apple.com [Wed, 19 Oct 2011 00:52:24 +0000 (00:52 +0000)]
Assertion failure when going back in page with navigated subframes
https://bugs.webkit.org/show_bug.cgi?id=70389
<rdar://problem/8988444>

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/history/history-back-twice-with-subframes-assert.html

If a single navigation ends up loading multiple frame, the first committed frame will
end up calling recursiveUpdateForCommit on the main frame which will null out the provisional item
for all frames on the page. This means that it can null out the provisional item for any frames
that are still yet to be committed which causes the aforementioned assertion failure.

Fix this by only nulling out the provisional history item (and saving/restoring the scroll position and
some other things) for frames that already contain the URL that the item requested. If a frame is being loaded,
it will null out its provisional history item when it's committed.

* loader/HistoryController.cpp:
(WebCore::HistoryController::recursiveUpdateForCommit):

LayoutTests:

* fast/history/history-back-twice-with-subframes-assert-expected.txt: Added.
* fast/history/history-back-twice-with-subframes-assert.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowatchlist: Should try to run if it can and not throw on mistakes.
levin@chromium.org [Wed, 19 Oct 2011 00:47:26 +0000 (00:47 +0000)]
watchlist: Should try to run if it can and not throw on mistakes.
https://bugs.webkit.org/show_bug.cgi?id=70358

Reviewed by Adam Barth.

* Scripts/webkitpy/common/system/outputcapture.py: Add the ability to capture log output.
* Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adapt to the logging of errors.
* Scripts/webkitpy/common/watchlist/watchlistparser.py: Change to log problems and fix problems when found.
* Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Adapt to the logging of errors.
* Scripts/webkitpy/common/watchlist/watchlistrule.py: Expose a way to remove instructions.
* Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Test the new function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebKit2: Move uses of C SPI out of WKView.h and into WKViewPrivate.h
weinig@apple.com [Wed, 19 Oct 2011 00:40:30 +0000 (00:40 +0000)]
Source/WebKit2: Move uses of C SPI out of WKView.h and into WKViewPrivate.h
https://bugs.webkit.org/show_bug.cgi?id=70387

Reviewed by Dan Bernstein.

* UIProcess/API/mac/WKViewPrivate.h:
Move declarations here.

* UIProcess/API/mac/WKView.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView _updateRemoteAccessibilityRegistration:]):
(-[WKView initWithFrame:]):
(-[WKView initWithFrame:contextRef:]):
(-[WKView _registerDraggedTypes]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView pageRef]):
(-[WKView canChangeFrameLayout:]):
(-[WKView printOperationWithPrintInfo:forFrame:]):
(-[WKView setFrame:andScrollBy:]):
Move definitions to private category.

* UIProcess/API/mac/PDFViewController.mm:
* UIProcess/mac/WKFullScreenWindowController.mm:
* UIProcess/mac/WebInspectorProxyMac.mm:
Update to include WKViewPrivate.h where necessary.

Tools: Move uses of C-SPI out of WKView.h and into WKViewPrivate.h
https://bugs.webkit.org/show_bug.cgi?id=70387

Reviewed by Dan Bernstein.

* MiniBrowser/mac/BrowserWindowController.m:
* TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
* TestWebKitAPI/mac/JavaScriptTestMac.mm:
* TestWebKitAPI/mac/PlatformWebViewMac.mm:
* TestWebKitAPI/mac/WebKitAgnosticTest.mm:
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
Update to include WKViewPrivate.h where necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r97765.
dpranke@chromium.org [Wed, 19 Oct 2011 00:15:30 +0000 (00:15 +0000)]
Unreviewed, rolling out r97765.
http://trac.webkit.org/changeset/97765
https://bugs.webkit.org/show_bug.cgi?id=70388

"broke webkit_unit_tests, http/tests/xmlhttprequest
/xmlhttprequest-test-send-flag.html on linux debug" (Requested
by dpranke on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-18

Source/WebCore:

* WebCore.gypi:
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::create):
(WebCore::DocumentThreadableLoader::~DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::cancel):
(WebCore::DocumentThreadableLoader::setDefersLoading):
(WebCore::DocumentThreadableLoader::willSendRequest):
(WebCore::DocumentThreadableLoader::didSendData):
(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::didReceiveData):
(WebCore::DocumentThreadableLoader::didReceiveCachedMetadata):
(WebCore::DocumentThreadableLoader::didFinishLoading):
(WebCore::DocumentThreadableLoader::didFail):
(WebCore::DocumentThreadableLoader::preflightSuccess):
(WebCore::DocumentThreadableLoader::loadRequest):
* loader/DocumentThreadableLoader.h:
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::CachedRawResource):
(WebCore::CachedRawResource::data):
* loader/cache/CachedRawResource.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
* loader/cache/CachedResource.h:
(WebCore::CachedResource::setRequestedFromNetworkingLayer):
* loader/cache/CachedResourceClient.h:
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::~CachedResourceRequest):
(WebCore::CachedResourceRequest::willSendRequest):
(WebCore::CachedResourceRequest::didFinishLoading):
(WebCore::CachedResourceRequest::didReceiveResponse):
(WebCore::CachedResourceRequest::didReceiveData):
* loader/cache/CachedResourceRequest.h:
* loader/chromium/CachedRawResourceChromium.cpp: Removed.
* loader/chromium/CachedResourceRequestChromium.cpp: Removed.
* loader/chromium/DocumentThreadableLoaderChromium.cpp:
(WebCore::DocumentThreadableLoader::didDownloadData):
* loader/icon/IconLoader.h:
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::notifyResponse):

LayoutTests:

* http/tests/inspector/network/network-content-replacement-xhr-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename static put to putByIndex
mhahnenberg@apple.com [Tue, 18 Oct 2011 23:53:38 +0000 (23:53 +0000)]
Rename static put to putByIndex
https://bugs.webkit.org/show_bug.cgi?id=70281

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Renaming versions of deleteProperty that use an unsigned as the property
name to "deletePropertyByIndex" in preparation for adding them to the
MethodTable, which requires unique names for each method.

* dfg/DFGOperations.cpp:
(JSC::DFG::putByVal):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Arguments.cpp:
(JSC::Arguments::putVirtual):
(JSC::Arguments::putByIndex):
* runtime/Arguments.h:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncMap):
* runtime/JSArray.cpp:
(JSC::JSArray::put):
(JSC::JSArray::putVirtual):
(JSC::JSArray::putByIndex):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::putVirtual):
(JSC::JSByteArray::putByIndex):
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::putVirtual):
(JSC::JSCell::putByIndex):
* runtime/JSCell.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::putVirtual):
(JSC::JSNotAnObject::putByIndex):
* runtime/JSNotAnObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::putVirtual):
(JSC::JSObject::putByIndex):
* runtime/JSObject.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpMatchesArray::fillArrayInstance):
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::putVirtual):
(JSC::RegExpMatchesArray::putByIndex):

Source/WebCore:

No new tests.

Renaming versions of deleteProperty that use an unsigned as the property
name to "deletePropertyByIndex" in preparation for adding them to the
MethodTable, which requires unique names for each method.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::putVirtual):
(JSC::RuntimeArray::putByIndex):
* bridge/runtime_array.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark storage/domstorage/events/documentURI as a flaky crash
dpranke@chromium.org [Tue, 18 Oct 2011 23:53:33 +0000 (23:53 +0000)]
Mark storage/domstorage/events/documentURI as a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=70386

Unreviewed, expectations change.

on chromium snowleopard.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a new chromium baseline for fast/multicol/vertical-rl/rule-style.html.
dpranke@chromium.org [Tue, 18 Oct 2011 23:44:12 +0000 (23:44 +0000)]
Add a new chromium baseline for fast/multicol/vertical-rl/rule-style.html.

Unreviewed, baseline update.

* platform/chromium-cg-mac-snowleopard/fast/multicol/vertical-rl/rule-style-expected.png: Added.
* platform/chromium-win/fast/multicol/vertical-rl/rule-style-expected.png: Added.
* platform/chromium-win/fast/multicol/vertical-rl/rule-style-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, expectations update.
dpranke@chromium.org [Tue, 18 Oct 2011 23:40:11 +0000 (23:40 +0000)]
Unreviewed, expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the build.
weinig@apple.com [Tue, 18 Oct 2011 23:38:05 +0000 (23:38 +0000)]
Fix the build.

* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absolutePDFURL):
Fix typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed warning fix after https://bugs.webkit.org/show_bug.cgi?id=70269
alexis.menard@openbossa.org [Tue, 18 Oct 2011 23:36:36 +0000 (23:36 +0000)]
Unreviewed warning fix after https://bugs.webkit.org/show_bug.cgi?id=70269

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStop leaking internal names in WKView API header
weinig@apple.com [Tue, 18 Oct 2011 23:25:41 +0000 (23:25 +0000)]
Stop leaking internal names in WKView API header
https://bugs.webkit.org/show_bug.cgi?id=70380

Reviewed by Anders Carlsson.

Move _frameSizeUpdatesDisabledCount to WKViewData. Since we cannot change the size of
WKView due to the fragile Objective-C ABI, we must rename the existing variable unused. If
drop 32-bit support, we will be able to remove it.

* UIProcess/API/mac/WKView.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView disableFrameSizeUpdates]):
(-[WKView enableFrameSizeUpdates]):
(-[WKView frameSizeUpdatesDisabled]):
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Expose PDF information in hit test result
ap@apple.com [Tue, 18 Oct 2011 23:20:08 +0000 (23:20 +0000)]
    Expose PDF information in hit test result
        https://bugs.webkit.org/show_bug.cgi?id=70353

        Reviewed by Sam Weinig.

        * WebCore.exp.in:
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::absolutePDFURL):
        * rendering/HitTestResult.h:
        Added HitTestResult::absolutePDFURL(). It will contain a URL when over a PDF object or embed;
        not sure if we want this for PDFImageDocuments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Preserve offscreen tiles instead of immediately recycling them
enne@google.com [Tue, 18 Oct 2011 23:19:15 +0000 (23:19 +0000)]
[chromium] Preserve offscreen tiles instead of immediately recycling them
https://bugs.webkit.org/show_bug.cgi?id=70352

Reviewed by James Robinson.

Tested by existing layout tests.

Prior to having a TextureManager class, tiled layers recycled their
textures internally to avoid reallocation. Unfortunately, it recycled
these tiles as soon as they went offscreen, even if they were still
valid. Instead, keep tiles around forever, letting the TextureManager
decide (via LRU) when to reclaim the underlying textures. This will
improve scrolling performance due to not needing to repaint tiles.

This change does lead to more texture reallocation for any textures
that get reclaimed, but the command buffer implementation already
pools and reuses texture ids, so it should not introduce additional
flush syncs. If there's any performance penalty, it'll be at the
driver level, but I'd prefer to measure that there's a problem before
prematurely optimizing and adding complexity to the TextureManager.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::cleanupResources):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::prepareToUpdate):
* platform/graphics/chromium/TiledLayerChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in WebProcess at com.apple.AppKit: -[NSFilePromiseDragSource draggedImage:ended...
enrica@apple.com [Tue, 18 Oct 2011 23:17:26 +0000 (23:17 +0000)]
Crash in WebProcess at com.apple.AppKit: -[NSFilePromiseDragSource draggedImage:endedAt:operation:] + 101
https://bugs.webkit.org/show_bug.cgi?id=70340
<rdar://problem/9548174>

We have seen a number of crash reports for this issue that seem to occurr when
the user drags an image from a web page onto the desktop.
We have not been able to reproduce this crash, therefore this is a speculative fix,
but the theory is that the dragging source has been already released when draggedImage
is called.
This patch attempts a fix for the problem by retaining the dragging source when
NSFilePromiseDragSource is created.

Reviewed by Darin Adler.

* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(-[WKPasteboardFilePromiseOwner initWithSource:]):
(-[WKPasteboardFilePromiseOwner dealloc]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] Crash after storing credentials in Keychain
ap@apple.com [Tue, 18 Oct 2011 23:14:48 +0000 (23:14 +0000)]
    [WK2] Crash after storing credentials in Keychain
        https://bugs.webkit.org/show_bug.cgi?id=70376
        <rdar://problem/9647503>

        Reviewed by Dan Bernstein.

        * Shared/mac/SecKeychainItemResponseData.cpp:
        (WebKit::SecKeychainItemResponseData::encode):
        (WebKit::SecKeychainItemResponseData::decode):
        Actually send keychain item over, too. In shimSecKeychainItemCreateFromContent(), we are
        going to use it to override SecKeychainItemCreateFromContent(), and we cannot return noErr
        from this function without returning a non-null keychain item.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThis revised fix doesn't break SL build.
weinig@apple.com [Tue, 18 Oct 2011 23:08:56 +0000 (23:08 +0000)]
This revised fix doesn't break SL build.
https://bugs.webkit.org/show_bug.cgi?id=70345

Reviewed and landed by Sam Weinig.

Patch by Damian Kaleta <dkaleta@apple.com> on 2011-10-18

* UIProcess/API/mac/WKView.mm:
(+[WKView hideWordDefinitionWindow]): Hides the definition window.
* UIProcess/API/mac/WKViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[MutationObservers] Implement WebKitMutationObserver.observe for characterData changes
adamk@chromium.org [Tue, 18 Oct 2011 23:06:48 +0000 (23:06 +0000)]
[MutationObservers] Implement WebKitMutationObserver.observe for characterData changes
https://bugs.webkit.org/show_bug.cgi?id=68957

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/mutation/observe-characterdata.html

* dom/CharacterData.cpp:
(WebCore::CharacterData::dispatchModifiedEvent):

LayoutTests:

* fast/mutation/observe-characterdata-expected.txt: Added.
* fast/mutation/observe-characterdata.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove spellCheckerDocumentTag and handleCorrectionPanelResult from WKViewPrivate to...
weinig@apple.com [Tue, 18 Oct 2011 23:06:31 +0000 (23:06 +0000)]
Move spellCheckerDocumentTag and handleCorrectionPanelResult from WKViewPrivate to WKViewInternal
https://bugs.webkit.org/show_bug.cgi?id=70377

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView spellCheckerDocumentTag]):
(-[WKView handleCorrectionPanelResult:]):
Move definition of methods to (Internal) area.

* UIProcess/API/mac/WKViewInternal.h:
Add methods.

* UIProcess/API/mac/WKViewPrivate.h:
Remove methods.

* UIProcess/cf/WebBackForwardListCF.cpp:
Add missing newline.

* UIProcess/mac/CorrectionPanel.mm:
Change #include to WKViewInternal.h

* WebKit2.xcodeproj/project.pbxproj:
Sort some files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoScroll animator tracing
commit-queue@webkit.org [Tue, 18 Oct 2011 23:05:10 +0000 (23:05 +0000)]
Scroll animator tracing
https://bugs.webkit.org/show_bug.cgi?id=70280

Patch by Scott Byer <scottbyer@chromium.org> on 2011-10-18
Reviewed by James Robinson.

No functional difference, no test needed.

* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::animationTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove USE(THREADED_COMPOSITING) from the tree, this is controlled by...
jamesr@google.com [Tue, 18 Oct 2011 23:02:02 +0000 (23:02 +0000)]
[chromium] Remove USE(THREADED_COMPOSITING) from the tree, this is controlled by a runtime setting
https://bugs.webkit.org/show_bug.cgi?id=70356

Reviewed by Kenneth Russell.

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

* features.gypi:
* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::scheduleComposite):
* src/WebLayerTreeViewImpl.h:
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocleanup some FIXMEs in RenderFlexibleBox
ojan@chromium.org [Tue, 18 Oct 2011 22:58:38 +0000 (22:58 +0000)]
cleanup some FIXMEs in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=70374

Reviewed by Darin Adler.

No new tests. Existing tests cover all changes.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::flowAwareBorderAndPaddingLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareMarginLogicalHeightForChild):
* rendering/RenderFlexibleBox.h:
Removed the FIXME to implement computePreferredLogicalWidths. It doesn't
seem to be necessary, at least not with the current test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove WKView helper files into a sub-group
weinig@apple.com [Tue, 18 Oct 2011 22:57:03 +0000 (22:57 +0000)]
Move WKView helper files into a sub-group
https://bugs.webkit.org/show_bug.cgi?id=70375

Reviewed by Darin Adler.

* WebKit2.xcodeproj/project.pbxproj:
Move some files around.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove expectations for tests that are no longer failing.
dpranke@chromium.org [Tue, 18 Oct 2011 22:48:50 +0000 (22:48 +0000)]
Remove expectations for tests that are no longer failing.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<http://webkit.org/b/70365> Web Inspector: Some localizedStrings.js Updates
joepeck@webkit.org [Tue, 18 Oct 2011 22:47:21 +0000 (22:47 +0000)]
<webkit.org/b/70365> Web Inspector: Some localizedStrings.js Updates

Reviewed by Darin Adler.

Source/WebCore:

Fixed syntax issue, added missing strings, and removed a duplicate.

* English.lproj/localizedStrings.js:

Tools:

* Scripts/check-inspector-strings:
Updated to the new webkitpy way to determine checkout root.

* Scripts/webkitdirs.pm:
(copyInspectorFrontendFiles):
Made it so build-webkit --inspector-frontend copies over
the localizedStrings.js file as well as the frontend files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] DRT: Clear list of visited pages before each test.
commit-queue@webkit.org [Tue, 18 Oct 2011 22:45:35 +0000 (22:45 +0000)]
[EFL] DRT: Clear list of visited pages before each test.
https://bugs.webkit.org/show_bug.cgi?id=70355

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-18
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Add ewk_history_clear as a way to clear the list of visited pages in a
Ewk_History, in a similar fashion to Qt's QWebHistory::clear().

* ewk/ewk_history.cpp:
(ewk_history_clear):
* ewk/ewk_history.h:

Tools:

r97596 uncovered a bug in the implementation: the list of visited
links was not cleared between tests, which caused tests such as
fast/repaint/outline-repaint-glitch.html to be flaky (the link color
changed depending on whether fast/repaint/border-repaint-glitch.html
was visited before or not).

Call ewk_history_clear to make sure the visited links list does not
persist between tests.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofix unused-but-set-variable warnings in WebCore
tony@chromium.org [Tue, 18 Oct 2011 22:38:29 +0000 (22:38 +0000)]
fix unused-but-set-variable warnings in WebCore
https://bugs.webkit.org/show_bug.cgi?id=70344

Reviewed by Adam Barth.

This is a new compiler warning in gcc 4.6.

* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::isWrapperOfType):
* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::ComplexTextController::normalizeSpacesAndMirrorChars):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable out-of-thread compositing in WebKit compositor API
commit-queue@webkit.org [Tue, 18 Oct 2011 22:37:40 +0000 (22:37 +0000)]
Enable out-of-thread compositing in WebKit compositor API
https://bugs.webkit.org/show_bug.cgi?id=69850

Patch by Antoine Labour <piman@chromium.org> on 2011-10-18
Reviewed by James Robinson.

* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::composite):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCertain column-rule styles render incorrectly in vertical writing modes
mitz@apple.com [Tue, 18 Oct 2011 22:14:00 +0000 (22:14 +0000)]
Certain column-rule styles render incorrectly in vertical writing modes
https://bugs.webkit.org/show_bug.cgi?id=70362

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/multicol/vertical-rl/rule-style.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules): Use the correct border sides for vertical writing modes.

LayoutTests:

* fast/multicol/vertical-rl/rule-style-expected.png: Added.
* fast/multicol/vertical-rl/rule-style-expected.txt: Added.
* fast/multicol/vertical-rl/rule-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix broken binding tests by changing G_MAXUSHORT to G_MAXUINT in WebKitDOMTestObj...
annacc@chromium.org [Tue, 18 Oct 2011 22:07:23 +0000 (22:07 +0000)]
Fix broken binding tests by changing G_MAXUSHORT to G_MAXUINT in WebKitDOMTestObj.cpp.
https://bugs.webkit.org/show_bug.cgi?id=70267

Reviewed by Daniel Bates.

Tests: fixing WebKitDOMTestObj.cpp

* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_class_init): Change G_MAXUSHORT to G_MAXUINT

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r97788.
inferno@chromium.org [Tue, 18 Oct 2011 22:04:53 +0000 (22:04 +0000)]
Unreviewed, rolling out r97788.
http://trac.webkit.org/changeset/97788
https://bugs.webkit.org/show_bug.cgi?id=70366

broke compile (Requested by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-18

* UIProcess/API/mac/WKView.mm:
* UIProcess/API/mac/WKViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoArray.prototype methods missing exception checks
barraclough@apple.com [Tue, 18 Oct 2011 21:57:59 +0000 (21:57 +0000)]
Array.prototype methods missing exception checks
https://bugs.webkit.org/show_bug.cgi?id=70360

Reviewed by Geoff Garen.

Missing exception checks after calls to the static getProperty helper,
these may result in the wrong exception being thrown (or an ASSERT being hit,
as is currently the case running test-262).

Source/JavaScriptCore:

No performance impact.

* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

LayoutTests:

* fast/js/array-proto-func-property-getter-except-expected.txt:
* fast/js/script-tests/array-proto-func-property-getter-except.js:
    - The test results that change were only testing for an absence of a crash; the new results are correct
      (the first exception thrown should be the one returned).
* sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T4-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T6-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T7-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T8-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T9-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T11-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T12-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T4-expected.txt:
    - Check in passing results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd missing baselines for fast/selectors/visited-descendant.
dpranke@chromium.org [Tue, 18 Oct 2011 21:07:01 +0000 (21:07 +0000)]
Add missing baselines for fast/selectors/visited-descendant.

Unreviewed, expectations change.

* platform/chromium-cg-mac-leopard/fast/selectors/visited-descendant-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/selectors/visited-descendant-expected.png: Added.
* platform/chromium-linux/fast/selectors/visited-descendant-expected.png: Added.
* platform/chromium-mac-leopard/fast/selectors/visited-descendant-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/selectors/visited-descendant-expected.png: Added.
* platform/chromium-win/fast/selectors/visited-descendant-expected.png: Added.
* platform/chromium-win/fast/selectors/visited-descendant-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCorrected bad cut-and-paste in MutationObserver test description.
adamk@chromium.org [Tue, 18 Oct 2011 21:01:17 +0000 (21:01 +0000)]
Corrected bad cut-and-paste in MutationObserver test description.

Unreviewed.

* fast/mutation/observe-attributes-expected.txt:
* fast/mutation/observe-attributes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-18 Damian Kaleta <dkaleta@apple.com>
kdecker@apple.com [Tue, 18 Oct 2011 20:50:34 +0000 (20:50 +0000)]
2011-10-18  Damian Kaleta  <dkaleta@apple.com>

        Add WebKit API to hide the definition window
        https://bugs.webkit.org/show_bug.cgi?id=70345

        Reviewed by Anders Carlsson.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView hideWordDefinitionWindow]): Hides the definition window.
        * UIProcess/API/mac/WKViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in RenderDeprecatedFlexibleBox::layoutHorizontalBox
inferno@chromium.org [Tue, 18 Oct 2011 20:42:23 +0000 (20:42 +0000)]
Crash in RenderDeprecatedFlexibleBox::layoutHorizontalBox
https://bugs.webkit.org/show_bug.cgi?id=70183

Patch by Julien Chaffraix <jchaffraix@webkit.org> on 2011-10-18
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/flexbox/layoutHorizontal-crash.html

The deferred scroll information update logic was not updated when an object was destroy'ed.

The fix is very simple. As the deferred logic was only used with deprecated flexbox, it is a
pretty uncommon cases so let's optimize the new code for the common case.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed):

LayoutTests:

* fast/flexbox/layoutHorizontal-crash-expected.txt: Added.
* fast/flexbox/layoutHorizontal-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[MutationObservers] Clean up MutationObserver code in Node
adamk@chromium.org [Tue, 18 Oct 2011 20:09:02 +0000 (20:09 +0000)]
[MutationObservers] Clean up MutationObserver code in Node
https://bugs.webkit.org/show_bug.cgi?id=70349

Reviewed by Ryosuke Niwa.

Three small cleanups.

No new tests, no behavior change.

* dom/Node.cpp:
(WebCore::Node::clearRareData): Use indices instead of iterator in for loop; fix typo.
(WebCore::Node::registerMutationObserver): Inline single call to Node::ensureMutationObserverEntries.
* dom/Node.h: Make mutationObserverEntries private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix shutdown race when posting main thread task to CCThreadProxy and enabl...
jamesr@google.com [Tue, 18 Oct 2011 19:55:24 +0000 (19:55 +0000)]
[chromium] Fix shutdown race when posting main thread task to CCThreadProxy and enable tests
https://bugs.webkit.org/show_bug.cgi?id=70161

Reviewed by David Levin.

Source/WebCore:

Adds a weak pointer mechanism to cancel main thread tasks posted to CCThreadProxy instances from the compositor
thread. Previously there was a race condition where main thread tasks could run even after the CCThreadProxy was
destroyed.

This race does not exist in the other direction because when tearing down a CCThreadProxy we first post a quit
task to the compositor thread and then suspend execution of the main thread until all compositor tasks for the
CCThreadProxy have been drained.

Covered by the now-enabled CCLayerTreeHostTest* unit tests.

* WebCore.gypi:
* platform/graphics/chromium/cc/CCScopedMainThreadProxy.h: Added.
(WebCore::CCScopedMainThreadProxy::create):
(WebCore::CCScopedMainThreadProxy::postTask):
(WebCore::CCScopedMainThreadProxy::shutdown):
(WebCore::CCScopedMainThreadProxy::CCScopedMainThreadProxy):
(WebCore::CCScopedMainThreadProxy::runTaskIfNotShutdown):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

Enables the CCLayerTreeHostTest* tests by default. Most tests are run twice in a single thread and multiple
thread configuration. Some tests run only in the multiple thread configuration if they depend on the compositor
thread scheduling draws by itself.

* tests/CCLayerTreeHostTest.cpp:
(::CCLayerTreeHostTest::timeout):
(::CCLayerTreeHostTest::clearTimeout):
(::CCLayerTreeHostTest::CCLayerTreeHostTest):
(::CCLayerTreeHostTest::onEndTest):
(::CCLayerTreeHostTest::TimeoutTask::TimeoutTask):
(::CCLayerTreeHostTest::TimeoutTask::clearTest):
(::CCLayerTreeHostTest::TimeoutTask::~TimeoutTask):
(::CCLayerTreeHostTest::TimeoutTask::Run):
(::CCLayerTreeHostTest::runTest):
(::CCLayerTreeHostTest::doBeginTest):
(::CCLayerTreeHostTestThreadOnly::runTest):
(::CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoimplement flex-flow:column
ojan@chromium.org [Tue, 18 Oct 2011 19:35:14 +0000 (19:35 +0000)]
implement flex-flow:column
https://bugs.webkit.org/show_bug.cgi?id=70082

Reviewed by David Hyatt.

Source/WebCore:

There's still a bug with a FIXME where we don't compute the right
size for the container of the flexbox in the presence of
orthogonal flows. That's the cause of all the failing cases
in the tests.

Tests: css3/flexbox/flex-flow-border.html
       css3/flexbox/flex-flow-margins.html
       css3/flexbox/flex-flow-orientations.html
       css3/flexbox/flex-flow-overflow.html
       css3/flexbox/flex-flow-padding.html
       css3/flexbox/flex-flow.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::hasOrthogonalFlow):
(WebCore::RenderFlexibleBox::isColumnFlow):
(WebCore::RenderFlexibleBox::isHorizontalFlow):
(WebCore::RenderFlexibleBox::isLeftToRightFlow):
Use isHorizontalFlow and isLeftToRightFlow so that methods like
flowAwareBorderStart look exactly like borderStart with
isHorizontalWritingMode and isLeftToRightDirection replaced.

(WebCore::RenderFlexibleBox::setFlowAwareLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareLogicalHeightForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalWidthForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareLogicalWidth):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalWidth):
(WebCore::RenderFlexibleBox::transformedWritingMode):
Transform the writing-mode based of the flex-flow and direction
values. That methods like flowAwareBorderBefore look exactly like
borderBefore, except it switches over a different value.

(WebCore::RenderFlexibleBox::flowAwareBorderStart):
(WebCore::RenderFlexibleBox::flowAwareBorderBefore):
(WebCore::RenderFlexibleBox::flowAwareBorderAfter):
(WebCore::RenderFlexibleBox::flowAwarePaddingStart):
(WebCore::RenderFlexibleBox::flowAwarePaddingBefore):
(WebCore::RenderFlexibleBox::flowAwarePaddingAfter):
(WebCore::RenderFlexibleBox::flowAwareMarginStartForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginEndForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginBeforeForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginAfterForChild):
(WebCore::RenderFlexibleBox::setFlowAwareMarginStartForChild):
(WebCore::RenderFlexibleBox::setFlowAwareMarginEndForChild):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
(WebCore::RenderFlexibleBox::alignChildrenBlockDirection):
* rendering/RenderFlexibleBox.h:

LayoutTests:

* css3/flexbox/flex-flow-border-expected.txt: Added.
* css3/flexbox/flex-flow-border.html: Added.
Failures are due to not handling orthogonal flows correctly.
* css3/flexbox/flex-flow-expected.txt: Added.
* css3/flexbox/flex-flow-margins-expected.txt: Added.
* css3/flexbox/flex-flow-margins.html: Added.
* css3/flexbox/flex-flow-orientations-expected.txt: Added.
* css3/flexbox/flex-flow-orientations.html: Added.
* css3/flexbox/flex-flow-overflow-expected.txt: Added.
* css3/flexbox/flex-flow-overflow.html: Added.
* css3/flexbox/flex-flow-padding-expected.txt: Added.
* css3/flexbox/flex-flow-padding.html: Added.
Failures are due to not handling orthogonal flows correctly.
* css3/flexbox/flex-flow.html: Added.
* css3/flexbox/resources/flexbox.js:
Added the ability to check offsets that include clientLeft/clientTop
and for checking clientWidth/clientHeight. This is neede dfor the border tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSplit TestExpectationsEditor into its own file.
dglazkov@chromium.org [Tue, 18 Oct 2011 19:31:13 +0000 (19:31 +0000)]
Split TestExpectationsEditor into its own file.
https://bugs.webkit.org/show_bug.cgi?id=70348

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py.
* Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py.
* Scripts/webkitpy/layout_tests/models/test_expectations.py: Adjusted for change.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
* Scripts/webkitpy/tool/servers/gardeningserver.py: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] buildbot runs nrwt with --chromium instead of --chromium-cg-mac
rniwa@webkit.org [Tue, 18 Oct 2011 19:24:40 +0000 (19:24 +0000)]
[Chromium] buildbot runs nrwt with --chromium instead of --chromium-cg-mac
https://bugs.webkit.org/show_bug.cgi?id=70313

Reviewed by Adam Barth.

Fixed the bug by passing --platform --chromium-cg-mac in RunWebKitTests. We can't always add
this parameter because build-webkit and other scripts don't accept it.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Tracking update rects in LayerChromium and CCLayerImpl.
commit-queue@webkit.org [Tue, 18 Oct 2011 19:10:17 +0000 (19:10 +0000)]
[chromium] Tracking update rects in LayerChromium and CCLayerImpl.
https://bugs.webkit.org/show_bug.cgi?id=69441

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-10-18
Reviewed by James Robinson.

This patch does not do much on its own, but is just part 1 of a
string of other patches which will use these rects for
visualization and scissoring.  The appropriate testing will be
associated with those patches.

* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::cleanupResources):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdate):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateCompositorResources):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::updateRect):
(WebCore::CCLayerImpl::setUpdateRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange CodeGeneratorGObject.pm to use g_value_get_uint() instead of g_value_get_ushort()
annacc@chromium.org [Tue, 18 Oct 2011 18:18:36 +0000 (18:18 +0000)]
Change CodeGeneratorGObject.pm to use g_value_get_uint() instead of g_value_get_ushort()
for IDL attributes of type unsigned short.
https://bugs.webkit.org/show_bug.cgi?id=70267

Reviewed by Xan Lopez.

Tests: small change to WebKitDOMTestObj.cpp

* bindings/scripts/CodeGeneratorGObject.pm:
(GetGValueTypeName): convert unsigned short to uint instead of ushort
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_set_property): expect g_value_get_uint instead of g_value_get_ushort
(webkit_dom_test_obj_class_init): expect G_MAXUSHORT instead of G_MAXUINT16

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: ScriptsPanel's should use similar logic to decide whether it could...
vsevik@chromium.org [Tue, 18 Oct 2011 18:06:01 +0000 (18:06 +0000)]
Web Inspector: ScriptsPanel's should use similar logic to decide whether it could show an anchor location and actually showing it.
https://bugs.webkit.org/show_bug.cgi?id=70322

Reviewed by Pavel Feldman.

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._showSourceLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSubscribe myself to WebIDL changes
abarth@webkit.org [Tue, 18 Oct 2011 17:56:33 +0000 (17:56 +0000)]
Subscribe myself to WebIDL changes
https://bugs.webkit.org/show_bug.cgi?id=70341

Reviewed by David Levin.

I've also added some documentation and refactored my previous
subscriptions to make it eaiser for others to subscribe as well.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline most remaining IMAGE diffs for chromium-mac (Skia)
caryclark@google.com [Tue, 18 Oct 2011 17:39:50 +0000 (17:39 +0000)]
Rebaseline most remaining IMAGE diffs for chromium-mac (Skia)
on SnowLeopard (10.6).

Unreviewed gardening.

* platform/chromium-mac-snowleopard/editing/deleting/delete-3959464-fix-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-contents-003-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-contiguous-ws-001-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-tab-002-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-tab-003-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-to-select-table-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-trailing-ws-002-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-002-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/5569741-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/insert-list-and-stitch-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/insertHorizontalRule-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/5418891-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/editing-empty-divs-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-004-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-005-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-007-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-div-025-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-02-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-03-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-tab-002-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-tab-003-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-text-with-newlines-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-01-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-02-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-03-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-001-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-002-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-003-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/typing-002-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/typing-around-br-001-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/4242293-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/8145-2-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/cut-text-001-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-1-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-2-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-019-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/13804-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/5234383-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/5234383-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/extend-by-word-001-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/move-backwords-by-word-001-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/move-by-character-001-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/move-by-word-001-expected.png:
* platform/chromium-mac-snowleopard/editing/spelling/spelling-expected.png:
* platform/chromium-mac-snowleopard/editing/style/block-styles-007-expected.png:
* platform/chromium-mac/css2.1/20110323/block-replaced-width-001-expected.png:
* platform/chromium-mac/css2.1/t1602-c43-center-00-d-ag-expected.png:
* platform/chromium-mac/editing/deleting/delete-3959464-fix-expected.png: Added.
* platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.png:
* platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.png:
* platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.png:
* platform/chromium-mac/editing/deleting/delete-and-undo-expected.png: Added.
* platform/chromium-mac/editing/deleting/delete-block-contents-003-expected.png: Added.
* platform/chromium-mac/editing/deleting/delete-contiguous-ws-001-expected.png: Added.
* platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.png:
* platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.png:
* platform/chromium-mac/editing/deleting/delete-tab-002-expected.png: Added.
* platform/chromium-mac/editing/deleting/delete-tab-003-expected.png: Added.
* platform/chromium-mac/editing/deleting/delete-to-select-table-expected.png: Added.
* platform/chromium-mac/editing/deleting/delete-trailing-ws-002-expected.png: Added.
* platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.png: Added.
* platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.png: Added.
* platform/chromium-mac/editing/execCommand/5569741-expected.png: Added.
* platform/chromium-mac/editing/execCommand/insert-list-and-stitch-expected.png: Added.
* platform/chromium-mac/editing/execCommand/insertHorizontalRule-expected.png: Added.
* platform/chromium-mac/editing/inserting/5418891-expected.png: Added.
* platform/chromium-mac/editing/inserting/editable-inline-element-expected.png:
* platform/chromium-mac/editing/inserting/editing-empty-divs-expected.png: Added.
* platform/chromium-mac/editing/inserting/insert-br-004-expected.png: Added.
* platform/chromium-mac/editing/inserting/insert-br-005-expected.png: Added.
* platform/chromium-mac/editing/inserting/insert-br-007-expected.png: Added.
* platform/chromium-mac/editing/inserting/insert-div-025-expected.png: Added.
* platform/chromium-mac/editing/inserting/insert-paragraph-02-expected.png: Added.
* platform/chromium-mac/editing/inserting/insert-paragraph-03-expected.png: Added.
* platform/chromium-mac/editing/inserting/insert-tab-002-expected.png: Added.
* platform/chromium-mac/editing/inserting/insert-tab-003-expected.png: Added.
* platform/chromium-mac/editing/inserting/insert-text-with-newlines-expected.png: Added.
* platform/chromium-mac/editing/inserting/paragraph-separator-01-expected.png: Added.
* platform/chromium-mac/editing/inserting/paragraph-separator-02-expected.png: Added.
* platform/chromium-mac/editing/inserting/paragraph-separator-03-expected.png: Added.
* platform/chromium-mac/editing/inserting/return-key-with-selection-001-expected.png: Added.
* platform/chromium-mac/editing/inserting/return-key-with-selection-002-expected.png: Added.
* platform/chromium-mac/editing/inserting/return-key-with-selection-003-expected.png: Added.
* platform/chromium-mac/editing/inserting/typing-002-expected.png: Added.
* platform/chromium-mac/editing/inserting/typing-around-br-001-expected.png: Added.
* platform/chromium-mac/editing/pasteboard/4242293-expected.png: Added.
* platform/chromium-mac/editing/pasteboard/4641033-expected.png:
* platform/chromium-mac/editing/pasteboard/4944770-1-expected.png:
* platform/chromium-mac/editing/pasteboard/4944770-2-expected.png:
* platform/chromium-mac/editing/pasteboard/5478250-expected.png:
* platform/chromium-mac/editing/pasteboard/8145-2-expected.png: Added.
* platform/chromium-mac/editing/pasteboard/cut-text-001-expected.png: Added.
* platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png:
* platform/chromium-mac/editing/pasteboard/merge-after-delete-1-expected.png: Added.
* platform/chromium-mac/editing/pasteboard/merge-after-delete-2-expected.png: Added.
* platform/chromium-mac/editing/pasteboard/merge-after-delete-expected.png: Added.
* platform/chromium-mac/editing/pasteboard/merge-end-blockquote-expected.png: Added.
* platform/chromium-mac/editing/pasteboard/paste-text-019-expected.png: Added.
* platform/chromium-mac/editing/pasteboard/pasting-tabs-expected.png:
* platform/chromium-mac/editing/selection/13804-expected.png: Added.
* platform/chromium-mac/editing/selection/3690703-2-expected.png:
* platform/chromium-mac/editing/selection/3690703-expected.png:
* platform/chromium-mac/editing/selection/3690719-expected.png:
* platform/chromium-mac/editing/selection/4397952-expected.png:
* platform/chromium-mac/editing/selection/5234383-1-expected.png: Added.
* platform/chromium-mac/editing/selection/5234383-2-expected.png: Added.
* platform/chromium-mac/editing/selection/caret-before-select-expected.png:
* platform/chromium-mac/editing/selection/caret-rtl-2-expected.png:
* platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png:
* platform/chromium-mac/editing/selection/caret-rtl-expected.png:
* platform/chromium-mac/editing/selection/caret-rtl-right-expected.png:
* platform/chromium-mac/editing/selection/extend-by-word-001-expected.png: Added.
* platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png:
* platform/chromium-mac/editing/selection/fake-doubleclick-expected.png:
* platform/chromium-mac/editing/selection/iframe-expected.png:
* platform/chromium-mac/editing/selection/move-backwords-by-word-001-expected.png: Added.
* platform/chromium-mac/editing/selection/move-by-character-001-expected.png: Added.
* platform/chromium-mac/editing/selection/move-by-line-001-expected.png: Added.
* platform/chromium-mac/editing/selection/move-by-word-001-expected.png: Added.
* platform/chromium-mac/editing/selection/move-past-trailing-space-expected.png:
* platform/chromium-mac/editing/selection/replaced-boundaries-3-expected.png:
* platform/chromium-mac/editing/selection/select-all-001-expected.png:
* platform/chromium-mac/editing/selection/select-all-002-expected.png:
* platform/chromium-mac/editing/selection/select-box-expected.png:
* platform/chromium-mac/editing/selection/select-element-paragraph-boundary-expected.png:
* platform/chromium-mac/editing/selection/selection-3748164-fix-expected.png:
* platform/chromium-mac/editing/selection/unrendered-001-expected.png:
* platform/chromium-mac/editing/selection/unrendered-003-expected.png:
* platform/chromium-mac/editing/selection/unrendered-004-expected.png:
* platform/chromium-mac/editing/selection/unrendered-005-expected.png:
* platform/chromium-mac/editing/spelling/spelling-expected.png: Added.
* platform/chromium-mac/editing/style/5046875-1-expected.png:
* platform/chromium-mac/editing/style/block-styles-007-expected.png: Added.
* platform/chromium-mac/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
* platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.png:
* platform/chromium-mac/fast/css/color-correction-expected.png:
* platform/chromium-mac/fast/css/color-correction-on-backgrounds-expected.png:
* platform/chromium-mac/fast/css/focus-ring-outline-width-expected.png:
* platform/chromium-mac/fast/css/outline-auto-location-expected.png:
* platform/chromium-mac/fast/css/shadow-multiple-expected.png:
* platform/chromium-mac/fast/dom/focus-contenteditable-expected.png:
* platform/chromium-mac/fast/events/autoscroll-expected.png:
* platform/chromium-mac/fast/events/context-no-deselect-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-focus-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-number-rtl-expected.png:
* platform/chromium-mac/fast/forms/input-appearance-selection-expected.png:
* platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
* platform/chromium-mac/fast/forms/input-placeholder-visibility-2-expected.png:
* platform/chromium-mac/fast/forms/input-text-double-click-expected.png:
* platform/chromium-mac/fast/forms/input-text-drag-down-expected.png:
* platform/chromium-mac/fast/forms/input-text-option-delete-expected.png:
* platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
* platform/chromium-mac/fast/forms/listbox-hit-test-zoomed-expected.png:
* platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png:
* platform/chromium-mac/fast/forms/select-listbox-multiple-no-focusring-expected.png:
* platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png:
* platform/chromium-mac/fast/forms/textarea-scrollbar-expected.png:
* platform/chromium-mac/fast/forms/textarea-scrolled-type-expected.png:
* platform/chromium-mac/fast/forms/textfield-outline-expected.png:
* platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.png:
* platform/chromium-mac/fast/inline/continuation-outlines-expected.png:
* platform/chromium-mac/fast/inline/continuation-outlines-with-layers-2-expected.png:
* platform/chromium-mac/fast/inline/continuation-outlines-with-layers-expected.png:
* platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.png:
* platform/chromium-mac/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-mac/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/chromium-mac/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/chromium-mac/fast/reflections/reflection-direction-expected.png:
* platform/chromium-mac/fast/reflections/reflection-masks-expected.png:
* platform/chromium-mac/fast/reflections/reflection-masks-opacity-expected.png:
* platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-mac/fast/text/international/rtl-caret-expected.png:
* platform/chromium-mac/fast/text/justify-nbsp-expected.png:
* platform/chromium-mac/fast/text/justify-padding-distribution-expected.png:
* platform/chromium-mac/fast/transforms/transformed-caret-expected.png:
* platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png:
* platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
* platform/chromium-mac/svg/clip-path/clip-path-transform-1-expected.png: Added.
* platform/chromium-mac/svg/clip-path/clip-path-transform-2-expected.png: Added.
* platform/chromium-mac/svg/css/group-with-shadow-expected.png:
* platform/chromium-mac/svg/custom/alignment-baseline-modes-expected.png:
* platform/chromium-mac/svg/custom/createImageElement-expected.png:
* platform/chromium-mac/svg/custom/dominant-baseline-modes-expected.png:
* platform/chromium-mac/svg/custom/external-paintserver-reference-expected.png: Added.
* platform/chromium-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
* platform/chromium-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
* platform/chromium-mac/svg/custom/feComponentTransfer-Linear-expected.png:
* platform/chromium-mac/svg/custom/feComponentTransfer-Table-expected.png:
* platform/chromium-mac/svg/custom/focus-ring-expected.png:
* platform/chromium-mac/svg/custom/font-face-cascade-order-expected.png:
* platform/chromium-mac/svg/custom/font-face-simple-expected.png:
* platform/chromium-mac/svg/custom/glyph-selection-lang-attribute-expected.png:
* platform/chromium-mac/svg/custom/group-opacity-expected.png:
* platform/chromium-mac/svg/custom/image-parent-translation-expected.png:
* platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
* platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png:
* platform/chromium-mac/svg/custom/invalid-css-expected.png:
* platform/chromium-mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
* platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png:
* platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png:
* platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png:
* platform/chromium-mac/svg/custom/js-update-image-expected.png:
* platform/chromium-mac/svg/custom/linking-base-external-reference-expected.png: Added.
* platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
* platform/chromium-mac/svg/custom/text-image-opacity-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
* platform/chromium-mac/svg/filters/filter-source-position-expected.png:
* platform/chromium-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-mac/transforms/2d/compound-transforms-vs-containers-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd myself to the newfangled watchlist plumbing.
dglazkov@chromium.org [Tue, 18 Oct 2011 17:37:03 +0000 (17:37 +0000)]
Add myself to the newfangled watchlist plumbing.
https://bugs.webkit.org/show_bug.cgi?id=70338

Reviewed by David Levin.

* Scripts/webkitpy/common/config/watchlist: Added sheepishly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-18 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 18 Oct 2011 17:34:27 +0000 (17:34 +0000)]
2011-10-18  Eric Carlson  <eric.carlson@apple.com>

        Use the new cached cue loader
        https://bugs.webkit.org/show_bug.cgi?id=70269

        Reviewed by Antti Koivisto.

        No new tests, no functionality changed.

        * CMakeLists.txt: Remove CueParser.cpp/h and CueParserPrivate.h.
        * GNUmakefile.list.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::loadTextTracks):
        (WebCore::HTMLMediaElement::textTrackReadyStateChanged): New, not implemented yet.
        (WebCore::HTMLMediaElement::textTrackModeChanged): Ditto.
        (WebCore::HTMLMediaElement::textTrackCreated): Ditto.
        (WebCore::HTMLMediaElement::textTrackAddCues): Ditto.
        (WebCore::HTMLMediaElement::textTrackRemoveCues): Ditto.
        (WebCore::HTMLMediaElement::textTrackAddCue): Ditto.
        (WebCore::HTMLMediaElement::textTrackRemoveCue): Ditto.
        * html/HTMLMediaElement.h:

        * html/HTMLTrackElement.cpp:
        (WebCore::HTMLTrackElement::load): Update for interface change
        (WebCore::HTMLTrackElement::textTrackLoadingCompleted): New, dispatch 'load' or 'error' event.
        * html/HTMLTrackElement.h:

        * html/LoadableTextTrack.cpp:
        (WebCore::LoadableTextTrack::LoadableTextTrack): Add TextTrackClient and TextTrackLoadingClient
            parameters.
        (WebCore::LoadableTextTrack::load): Make url parameter KURL instead of String. Create the
            cue loader, trigger the load.
        (WebCore::LoadableTextTrack::newCuesAvailable): New callback from the loader. Not implemented yet.
        (WebCore::LoadableTextTrack::cueLoadingStarted): Ditto.
        (WebCore::LoadableTextTrack::cueLoadingCompleted): Ditto.
        * html/LoadableTextTrack.h:

        * html/MutableTextTrack.cpp:
        (WebCore::MutableTextTrack::MutableTextTrack): Add TextTrackClient parameter.
        * html/MutableTextTrack.h:
        (WebCore::MutableTextTrack::create):

        * html/TextTrack.cpp:
        (WebCore::TextTrack::TextTrack): Add TextTrackClient parameter.
        (WebCore::TextTrack::~TextTrack): Tell the client to remove all cues, forget the client.
        (WebCore::TextTrack::setReadyState): Tell client about ready state change.
        (WebCore::TextTrack::setMode): Tell client about mode change.
        * html/TextTrack.h:
        (WebCore::TextTrackClient::textTrackAddCues): New client interface.
        (WebCore::TextTrackClient::textTrackRemoveCues): Ditto.
        (WebCore::TextTrackClient::textTrackAddCue): Ditto.
        (WebCore::TextTrackClient::textTrackRemoveCue): Ditto.
        (WebCore::TextTrack::create):
        (WebCore::TextTrack::trackType): New.
        (WebCore::TextTrack::client): Ditto.
        (WebCore::TextTrack::setClient): Ditto.

        * html/track/CueParser.cpp: Removed.
        * html/track/CueParser.h: Removed.
        * html/track/CueParserPrivate.h: Removed.

        * html/track/WebVTTParser.cpp:
        (WebCore::WebVTTParser::fileIdentifierMaximumLength): New, return length of WebVTT file
            magic number.
        (WebCore::WebVTTParser::hasRequiredFileIdentifier): Update to use constants instead of hard
            coded lengths.
        (WebCore::WebVTTParser::WebVTTParser): Initialize "m_client" in the initilization list
            instead of setting it in the constructor.
        (WebCore::WebVTTParser::getNewCues): Renamed from fetchParsedCues.
        * html/track/WebVTTParser.h:
        (WebCore::WebVTTParser::create): Take a WebVTTParserClient* instead of a CueParserPrivateClient*.

        * loader/CueLoader.cpp:
        (WebCore::CueLoader::CueLoader):
        (WebCore::CueLoader::~CueLoader): Remove client.
        (WebCore::CueLoader::cueLoadTimerFired): Tell client about new clues and/or that the load
            has finished.
        (WebCore::CueLoader::processNewCueData): Process newly loaded data.
        (WebCore::CueLoader::didReceiveData): Ditto.
        (WebCore::CueLoader::notifyFinished): Do final processing as necessary, prime the timer
            to call client.
        (WebCore::CueLoader::load): Create resource loader, initiate loading.
        (WebCore::CueLoader::newCuesParsed): Prime timer to tell client about newly parsed cues.
        (WebCore::CueLoader::getNewCues): Get new cues from parser.
        * loader/CueLoader.h:
        (WebCore::CueLoader::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix a unit test in TestFailures.
dglazkov@chromium.org [Tue, 18 Oct 2011 17:33:24 +0000 (17:33 +0000)]
Fix a unit test in TestFailures.
https://bugs.webkit.org/show_bug.cgi?id=70337

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Turns out,
    the value of a method property should always be lowercase.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAlways enable ENABLE(XPATH)
abarth@webkit.org [Tue, 18 Oct 2011 17:21:28 +0000 (17:21 +0000)]
Always enable ENABLE(XPATH)
https://bugs.webkit.org/show_bug.cgi?id=70217

Reviewed by Eric Seidel.

.:

* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsWinCE.cmake:
* Source/cmakeconfig.h.cmake:
* configure.ac:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

As discussed on webkit-dev, we're reducing the complexity of WebKit by
removing unneeded configuration options.  ENABLE(XPATH) is enabled on
every port, so we are removing the ability to disable the feature.

* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* GNUmakefile.list.am:
* UseJSC.cmake:
* WebCore.pro:
* bindings/js/JSCustomXPathNSResolver.cpp:
* bindings/js/JSCustomXPathNSResolver.h:
* bindings/js/JSDOMBinding.cpp:
(WebCore::setDOMException):
* bindings/js/JSExceptionBase.cpp:
(WebCore::toExceptionBase):
* bindings/js/JSXPathResultCustom.cpp:
* bindings/objc/DOMCustomXPathNSResolver.h:
* bindings/objc/DOMCustomXPathNSResolver.mm:
* bindings/objc/DOMInternal.h:
* bindings/objc/DOMUtility.mm:
(JSC::createDOMWrapper):
* bindings/objc/DOMXPath.mm:
(kit):
* bindings/objc/PublicDOMInterfaces.h:
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getXPathNSResolver):
* bindings/v8/V8DOMWrapper.h:
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::setDOMException):
* bindings/v8/V8Proxy.h:
* bindings/v8/custom/V8CustomXPathNSResolver.cpp:
* bindings/v8/custom/V8CustomXPathNSResolver.h:
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
* dom/Document.cpp:
* dom/Document.h:
* dom/Document.idl:
* dom/ExceptionCode.cpp:
(WebCore::getExceptionCodeDescription):
* dom/ExceptionCode.h:
* features.pri:
* inspector/InspectorDOMAgent.cpp:
* page/DOMWindow.idl:
* xml/NativeXPathNSResolver.cpp:
* xml/NativeXPathNSResolver.h:
* xml/XPathEvaluator.cpp:
* xml/XPathEvaluator.h:
* xml/XPathEvaluator.idl:
* xml/XPathException.h:
* xml/XPathException.idl:
* xml/XPathExpression.cpp:
* xml/XPathExpression.h:
* xml/XPathExpression.idl:
* xml/XPathExpressionNode.cpp:
* xml/XPathExpressionNode.h:
* xml/XPathFunctions.cpp:
* xml/XPathFunctions.h:
* xml/XPathGrammar.y:
* xml/XPathNSResolver.cpp:
* xml/XPathNSResolver.h:
* xml/XPathNSResolver.idl:
* xml/XPathNodeSet.cpp:
* xml/XPathNodeSet.h:
* xml/XPathParser.cpp:
* xml/XPathParser.h:
* xml/XPathPath.cpp:
* xml/XPathPath.h:
* xml/XPathPredicate.cpp:
* xml/XPathPredicate.h:
* xml/XPathResult.cpp:
* xml/XPathResult.h:
* xml/XPathResult.idl:
* xml/XPathStep.cpp:
* xml/XPathStep.h:
* xml/XPathUtil.cpp:
* xml/XPathUtil.h:
* xml/XPathValue.cpp:
* xml/XPathValue.h:
* xml/XPathVariableReference.cpp:
* xml/XPathVariableReference.h:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/win:

* Interfaces/DOMWindow.idl:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/build-webkit:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agogarden-o-matic should not report flaking in expected failures as failures.
dglazkov@chromium.org [Tue, 18 Oct 2011 17:17:50 +0000 (17:17 +0000)]
garden-o-matic should not report flaking in expected failures as failures.
https://bugs.webkit.org/show_bug.cgi?id=70279

Reviewed by Adam Barth.

On the bots, flakes that are already expected to fail aren't reported as failures (they keep the bot green).
For example, if TEXT failure is expected, a TEXT TIMEOUT result will not cause the redness. We should do the
same for garden-o-matic.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Spuriously changed to use Array iterators rather than jQuery APIs,
    rewrote the logic for determining expected or unexpected failures as a central analysis tool.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Added unit tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: buttons of number type <input> controls are not fully accessible
cfleizach@apple.com [Tue, 18 Oct 2011 17:06:52 +0000 (17:06 +0000)]
AX: buttons of number type <input> controls are not fully accessible
https://bugs.webkit.org/show_bug.cgi?id=70241

Source/WebCore:

Staged commit, part 6.

Reviewed by Darin Adler.

Test: platform/mac/accessibility/html5-input-number.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::addImageMapChildren):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
(WebCore::AccessibilityRenderObject::addChildren):
* accessibility/AccessibilityRenderObject.h:

LayoutTests:

Reviewed by Darin Adler.

* platform/mac/accessibility/html5-input-number-expected.txt: Added.
* platform/mac/accessibility/html5-input-number.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexed arguments on the Arguments object should be enumerable.
barraclough@apple.com [Tue, 18 Oct 2011 17:04:32 +0000 (17:04 +0000)]
Indexed arguments on the Arguments object should be enumerable.
https://bugs.webkit.org/show_bug.cgi?id=70302

Reviewed by Sam Weinig.

See ECMA-262 5.1 chapter 10.6 step 11b.
This is visible through a number of means, including Object.keys, Object.getOwnPropertyDescriptor, and operator in.

* fast/js/kde/function-expected.txt:
* fast/js/kde/script-tests/function.js:
(foo2):
    - This tests using 'in'.
* fast/js/arguments-expected.txt:
* fast/js/script-tests/arguments.js:
(descriptor):
    - This tests using 'Object.getOwnPropertyDescriptor'.
* ietestcenter/Javascript/15.2.3.14-3-4-expected.txt:
    - This tests using 'Object.keys'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexed arguments on the Arguments object should be enumerable.
barraclough@apple.com [Tue, 18 Oct 2011 17:03:55 +0000 (17:03 +0000)]
Indexed arguments on the Arguments object should be enumerable.
https://bugs.webkit.org/show_bug.cgi?id=70302

Reviewed by Sam Weinig.

See ECMA-262 5.1 chapter 10.6 step 11b.
This is visible through a number of means, including Object.keys, Object.getOwnPropertyDescriptor, and operator in.

* runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertyDescriptor):
    - The 'enumerable' property should be true for indexed arguments.
(JSC::Arguments::getOwnPropertyNames):
    - Don't guard the adding of indexed properties with 'IncludeDontEnumProperties'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Merge QML plugin for WebKit2 with the original WebKit1 plugin
alexis.menard@openbossa.org [Tue, 18 Oct 2011 16:59:44 +0000 (16:59 +0000)]
[Qt] Merge QML plugin for WebKit2 with the original WebKit1 plugin

.:

We don't need a sepearate plugin, as we no longer expose the WK2
APIs under QtWebKit.experimental, but now use QtWebKit. The version
was also changed to 3.0 instead of 5.0, as the original plugin was
versioned 1.0, and bumping to 3.0 fits the scheme used by QtWebKit releases.

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2011-10-18
Reviewed by Andreas Kling.

* Source/WebKit.pro:

Source/WebKit/qt:

We don't need a separate plugin, as we no longer expose the WK2
APIs under QtWebKit.experimental, but now use QtWebKit. The version
was also changed to 3.0 instead of 5.0, as the original plugin was
versioned 1.0, and bumping to 3.0 fits the scheme used by QtWebKit releases.

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2011-10-18
Reviewed by Andreas Kling.

* declarative/declarative.pro:
* declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes):

Source/WebKit2:

We don't need a separate plugin, as we no longer expose the WK2
APIs under QtWebKit.experimental, but now use QtWebKit. The version
was also changed to 3.0 instead of 5.0, as the original plugin was
versioned 1.0, and bumping to 3.0 fits the scheme used by QtWebKit releases.

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2011-10-18
Reviewed by Andreas Kling.

* UIProcess/API/qt/qmlplugin/plugin.cpp: Removed.
* UIProcess/API/qt/qmlplugin/qmldir: Removed.
* UIProcess/API/qt/qmlplugin/qmlplugin.pro: Removed.
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadFail.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadNegativeSizeView.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadZeroSizeView.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Make DocumentThreadableLoader a CachedResourceClient.
japhet@chromium.org [Tue, 18 Oct 2011 16:31:32 +0000 (16:31 +0000)]
Source/WebCore: Make DocumentThreadableLoader a CachedResourceClient.
This will allow us to cache ThreadableLoaderClients as
appropriate in a later patch.
https://bugs.webkit.org/show_bug.cgi?id=61225

Reviewed by Antti Koivisto.

No new tests, no functionality change intended.

* WebCore.gypi:
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::notifyFinished): CachedResourceClients don't send separate callbacks
    for didFail() and didFinishLoading(), so we need to differentiate here.
(WebCore::DocumentThreadableLoader::loadRequest): Call CachedResourceLoader::requestRawResource()
    instead of ResourceLoadScheduler::scheduleSubresourceLoad().
* loader/DocumentThreadableLoader.h:
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::data): Handle the complexity of some ThreadableLoaderClients setting
    DoNotBufferData in ResoureLoaderOptions. If the DataBufferingPolicy is BufferData, then the
    'data' input parameter will contain all data received so far, and we need to determine the
    incremental data to forward to the clients. If the policy is DoNotBufferData, 'data' is just
    the incremental data.
* loader/cache/CachedRawResource.h:
* loader/cache/CachedResource.cpp:
* loader/cache/CachedResource.h:
(WebCore::CachedResource::preloadResult):
(WebCore::CachedResource::didSendData):
(WebCore::CachedResource::didDownloadData):
(WebCore::CachedResource::setLoadFinishTime):
(WebCore::CachedResource::loadFinishTime):
* loader/cache/CachedResourceClient.h: Add several new callbacks needed by DocumentThreadableLoader.
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::didReceiveResponse): CachedResource::setResponse() can now cancel
    the request, so protect appropriately.
* loader/cache/CachedResourceRequest.h:
* loader/chromium/CachedRawResourceChromium.cpp: Added (plumb didDownloadData() to DocumentThreadableLoader).
* loader/chromium/CachedResourceRequestChromium.cpp: Added (plumb didDownloadData() to DocumentThreadableLoader).
* loader/chromium/DocumentThreadableLoaderChromium.cpp:
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::notifyResponse): Protect before setting response, since it might kill us.

LayoutTests: Test update for https://bugs.webkit.org/show_bug.cgi?id=61225.
Due to changes in the implementation of DocumentThreadableLoader (and
therefore XHR), this test will have empty (rather than null) content
if we go over the length limit.

Reviewed by Antti Koivisto.

* http/tests/inspector/network/network-content-replacement-xhr-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r97752.
commit-queue@webkit.org [Tue, 18 Oct 2011 16:15:48 +0000 (16:15 +0000)]
Unreviewed, rolling out r97752.
http://trac.webkit.org/changeset/97752
https://bugs.webkit.org/show_bug.cgi?id=70332

Caused assertion failures in MediaList::setParentStyleSheet()
on the apple bots. (Requested by kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-18

* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMBinding.h:
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::CSSImportRule):
(WebCore::CSSImportRule::~CSSImportRule):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):
* css/CSSMediaRule.h:
* css/MediaList.cpp:
(WebCore::MediaList::MediaList):
(WebCore::MediaList::notifyChanged):
* css/MediaList.h:
* css/StyleSheet.cpp:
(WebCore::StyleSheet::~StyleSheet):
(WebCore::StyleSheet::setMedia):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange TextTrack to use the word DISABLED instead of OFF for mode
annacc@chromium.org [Tue, 18 Oct 2011 16:07:06 +0000 (16:07 +0000)]
Change TextTrack to use the word DISABLED instead of OFF for mode
https://bugs.webkit.org/show_bug.cgi?id=70268

Reviewed by Daniel Bates.

No new tests. No new functionality.

* html/TextTrack.cpp:
(WebCore::TextTrack::setMode): use Disabled instead of Off
* html/TextTrack.h: update Mode enum to use Disabled instead of Off

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] ASSERT when displaying context menu in input field
commit-queue@webkit.org [Tue, 18 Oct 2011 15:51:32 +0000 (15:51 +0000)]
[Qt][WK2] ASSERT when displaying context menu in input field
https://bugs.webkit.org/show_bug.cgi?id=69859

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2011-10-18
Reviewed by Simon Hausmann.

When creating a submenu in the context menu, the submenu of type
QWidget is statically cast to QObject before calling setParent on
it. QObject::setParent asserts if the object is a QWidget. So, call
setParent of QWidget itself.

* UIProcess/qt/WebContextMenuProxyQt.cpp:
(WebKit::WebContextMenuProxyQt::createContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: buttons of number type <input> controls are not fully accessible
cfleizach@apple.com [Tue, 18 Oct 2011 15:50:25 +0000 (15:50 +0000)]
AX: buttons of number type <input> controls are not fully accessible
https://bugs.webkit.org/show_bug.cgi?id=70241

Staged commit, part 5.

Reviewed by Darin Adler.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundingBoxRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove default stylesheet loading to a separate function
antti@apple.com [Tue, 18 Oct 2011 15:48:47 +0000 (15:48 +0000)]
Move default stylesheet loading to a separate function
https://bugs.webkit.org/show_bug.cgi?id=70331

Reviewed by Andreas Kling.

- Move default stylesheet loading out from CSSStyleSelector::styleForElement()
- Rename e -> element
- Remove pointless reffing of the placeholder style.

* css/CSSStyleSelector.cpp:
(WebCore::ensureDefaultStyleSheetsForElement):
(WebCore::isAtShadowBoundary):
(WebCore::CSSStyleSelector::styleForElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: buttons of number type <input> controls are not fully accessible
cfleizach@apple.com [Tue, 18 Oct 2011 15:43:50 +0000 (15:43 +0000)]
AX: buttons of number type <input> controls are not fully accessible
https://bugs.webkit.org/show_bug.cgi?id=70241

Staged commit part 4.

Reviewed by Darin Adler.

* accessibility/AccessibilityMockObject.h:
(WebCore::AccessibilityMockObject::isMockObject):
(WebCore::AccessibilityMockObject::detachFromParent):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: buttons of number type <input> controls are not fully accessible
cfleizach@apple.com [Tue, 18 Oct 2011 15:38:29 +0000 (15:38 +0000)]
AX: buttons of number type <input> controls are not fully accessible
https://bugs.webkit.org/show_bug.cgi?id=70241

Staged commit part 3. Committing the new spin button classes.

Reviewed by Darin Adler.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilitySpinButton.cpp: Added.
(WebCore::AccessibilitySpinButton::create):
(WebCore::AccessibilitySpinButton::AccessibilitySpinButton):
(WebCore::AccessibilitySpinButton::~AccessibilitySpinButton):
(WebCore::AccessibilitySpinButton::incrementButton):
(WebCore::AccessibilitySpinButton::decrementButton):
(WebCore::AccessibilitySpinButton::elementRect):
(WebCore::AccessibilitySpinButton::addChildren):
(WebCore::AccessibilitySpinButton::step):
(WebCore::AccessibilitySpinButtonPart::AccessibilitySpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::create):
(WebCore::AccessibilitySpinButtonPart::elementRect):
(WebCore::AccessibilitySpinButtonPart::press):
* accessibility/AccessibilitySpinButton.h: Added.
(WebCore::AccessibilitySpinButton::setSpinButtonElement):
(WebCore::AccessibilitySpinButton::roleValue):
(WebCore::AccessibilitySpinButton::accessibilityIsIgnored):
(WebCore::AccessibilitySpinButton::isSpinButton):
(WebCore::AccessibilitySpinButtonPart::~AccessibilitySpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::isIncrementor):
(WebCore::AccessibilitySpinButtonPart::setIsIncrementor):
(WebCore::AccessibilitySpinButtonPart::roleValue):
(WebCore::AccessibilitySpinButtonPart::isSpinButtonPart):
(WebCore::AccessibilitySpinButtonPart::accessibilityIsIgnored):
(WebCore::toAccessibilitySpinButton):
(WebCore::toAccessibilitySpinButtonPart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: buttons of number type <input> controls are not fully accessible
cfleizach@apple.com [Tue, 18 Oct 2011 15:28:11 +0000 (15:28 +0000)]
AX: buttons of number type <input> controls are not fully accessible
https://bugs.webkit.org/show_bug.cgi?id=70241

../WebCore:

Phase 2 of the staged commit.

Reviewed by Darin Adler.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::boundingBoxForQuads):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isSpinButton):
(WebCore::AccessibilityObject::isSpinButtonPart):
(WebCore::AccessibilityObject::isMockObject):

../WebKit/chromium:

Reviewed by Darin Adler.

* public/WebAccessibilityRole.h:
* src/AssertMatchingEnums.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix distcheck.
kov@webkit.org [Tue, 18 Oct 2011 15:26:47 +0000 (15:26 +0000)]
Fix distcheck.

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2011-10-18

Source/JavaScriptCore
* GNUmakefile.list.am: fix a typo and add a missing header to the
list.

Source/WebKit/gtk/po
* GNUmakefile.am: create po directory when it's not there yet both
when updating the pot and the po files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: buttons of number type <input> controls are not fully accessible
cfleizach@apple.com [Tue, 18 Oct 2011 15:22:09 +0000 (15:22 +0000)]
AX: buttons of number type <input> controls are not fully accessible
https://bugs.webkit.org/show_bug.cgi?id=70241

Expose the spin button object to the AX hierarchy. Since there is no distinct
render object that backs this object, a mock object needs to be created for the entire
spin button and the actual increment and decrement buttons inside.

This will be a staged commit since the first time around Windows layout tests started crashing for an undeterminable reason.

Reviewed by Darin Adler.

* html/shadow/TextControlInnerElements.cpp:
(WebCore::SpinButtonElement::step):
(WebCore::SpinButtonElement::repeatingTimerFired):
* html/shadow/TextControlInnerElements.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaList: Remove inheritance from StyleBase.
andreas.kling@nokia.com [Tue, 18 Oct 2011 15:05:52 +0000 (15:05 +0000)]
MediaList: Remove inheritance from StyleBase.
https://bugs.webkit.org/show_bug.cgi?id=70203

Reviewed by Darin Adler.

* css/MediaList.h:
(WebCore::MediaList::parentStyleSheet):
(WebCore::MediaList::setParentStyleSheet):
* css/MediaList.cpp:
(WebCore::MediaList::MediaList):
(WebCore::MediaList::notifyChanged):

    Change MediaList to no longer inherit from StyleBase. The parent()/setParent()
    mechanism was replaced by explicit parentStyleSheet()/setParentStyleSheet().

* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::CSSImportRule):
(WebCore::CSSImportRule::~CSSImportRule):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):

    Change StyleBase::setParent() calls to MediaList::setParentStyleSheet().
    CSSRules are never moved between stylesheets, so the parent style sheet pointer
    is valid for the MediaList's lifetime.

* css/StyleSheet.cpp:
(WebCore::StyleSheet::~StyleSheet):

    Change StyleBase::setParent() calls to MediaList::setParentStyleSheet().

(WebCore::StyleSheet::setMedia):

    Change StyleBase::setParent() calls to MediaList::setParentStyleSheet().
    Assert that the parent sheet is either null, or this, as MediaLists should never
    be reparented to other sheets.
    Assert that the StyleSheet is indeed a CSSStyleSheet.  XSLStyleSheet inherits from
    StyleSheet, but it shouldn't be using the MediaList.

* bindings/js/JSDOMBinding.h:
(WebCore::root):

    Add MediaList* specific overload for root() since it can't fall back
    to root(StyleBase*) anymore.

* WebCore.xcodeproj/project.pbxproj:

    Add some PrivateHeaders to accomodate the JSDOMBinding.h changes.

* css/CSSMediaRule.h:

    Remove unnecessary forward-declaration of MediaList.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoXSLStyleSheet only needs to manage XSLImportRule children.
andreas.kling@nokia.com [Tue, 18 Oct 2011 14:35:11 +0000 (14:35 +0000)]
XSLStyleSheet only needs to manage XSLImportRule children.
https://bugs.webkit.org/show_bug.cgi?id=70326

Reviewed by Antti Koivisto.

* css/StyleBase.h:
* xml/XSLImportRule.h:
* css/CSSRule.h:
(WebCore::CSSRule::isImportRule):

    Move StyleBase::isImportRule() down to CSSRule. Since XSLImportRule no longer
    implements it, it's now specific to CSSImportRule.

* xml/XSLStyleSheet.h:

    Change m_children to be a vector of XSLImportRules. Also remove length(),
    item() and append() since they were only used internally to modify m_children.

* xml/XSLStyleSheetQt.cpp:
(WebCore::XSLStyleSheet::~XSLStyleSheet):
* xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::~XSLStyleSheet):
(WebCore::XSLStyleSheet::isLoading):
(WebCore::XSLStyleSheet::clearDocuments):
(WebCore::XSLStyleSheet::loadChildSheet):
(WebCore::XSLStyleSheet::locateStylesheetSubResource):

    Remove now-unnecessary isImportRule() checks and tidy up the code a bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Qt rebaseline after r97738.
mihnea@adobe.com [Tue, 18 Oct 2011 14:22:24 +0000 (14:22 +0000)]
Unreviewed Qt rebaseline after r97738.

* platform/qt/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Remove const modifier from ctx_menu functions.
commit-queue@webkit.org [Tue, 18 Oct 2011 14:16:17 +0000 (14:16 +0000)]
[EFL] Remove const modifier from ctx_menu functions.
https://bugs.webkit.org/show_bug.cgi?id=70090

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-10-18
Reviewed by Andreas Kling.

Functions ewk_context_menu_show and ewk_context_menu_custom_get
have got const modifer to ensure that Ewk_Context_Menu won't be
changed. The methods emit events through
evas_object_smart_callback_call with Ewk_Context_Menu as parameter
which is converted to void *. In this case an application which
receives those events may change Ewk_Context_Menu.

Additionaly the name of ewk_context_menu_custom_get has been changed
to ewk_context_menu_customize because an application is able to
modify the items of context menu.

* ewk/ewk_contextmenu.cpp:
(ewk_context_menu_customize):
(ewk_context_menu_show):
* ewk/ewk_private.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix linkHoveredDoesntEmitRepeated test in the bot
caio.oliveira@openbossa.org [Tue, 18 Oct 2011 14:12:51 +0000 (14:12 +0000)]
[Qt] Fix linkHoveredDoesntEmitRepeated test in the bot
https://bugs.webkit.org/show_bug.cgi?id=70329

Reviewed by Andreas Kling.

Use LoadSpy::wait() instead of the TestCase::tryCompare(). They should be equivalent,
but I'm getting strange results with tryCompare(). This commit also adds an extra check
to make sure the hovered link is the correct one.

* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Some QML tests were accidentally committed.
alexis.menard@openbossa.org [Tue, 18 Oct 2011 13:51:48 +0000 (13:51 +0000)]
[Qt][WK2] Some QML tests were accidentally committed.
https://bugs.webkit.org/show_bug.cgi?id=70321

Reviewed by Andreas Kling.

These tests were committed by accident. They should not be there.

* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] Support for client-based geolocation
philn@webkit.org [Tue, 18 Oct 2011 13:03:04 +0000 (13:03 +0000)]
[Gtk] Support for client-based geolocation
https://bugs.webkit.org/show_bug.cgi?id=64970

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-10-18
Reviewed by Martin Robinson.

.:

Remove flag for enabling client-based geolocation since
it is used by default on Gtk port and hence not configurable.

* configure.ac:

Source/WebCore:

Add feature defines for client-based geolocation when geolocation is enabled,
since this is the providing method that is now used by default. Remove
service-based providing method completely as it is not needed anymore.

* GNUmakefile.am: Add feature defines for client-based geolocation.
* GNUmakefile.list.am: Remove GeolocationServiceGtk.* files from compilation.
* platform/gtk/GeolocationServiceGtk.cpp: Removed.
* platform/gtk/GeolocationServiceGtk.h: Removed.

Source/WebKit/gtk:

Add DumpRenderTree support functions for client-based geolocation tests
and implement GeolocationClientGtk. The implementation is based on Zecke's
implementation of GeolocationService class in WebCore, which is now redundant
and subsequently removed.

* GNUmakefile.am: Add GeolocationClientGtk.* files to compilation.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Add support functions to operate
with GeolocationClientMock.
(DumpRenderTreeSupportGtk::resetGeolocationClientMock):
(DumpRenderTreeSupportGtk::setMockGeolocationPermission):
(DumpRenderTreeSupportGtk::setMockGeolocationPosition):
(DumpRenderTreeSupportGtk::setMockGeolocationError):
(DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
* WebCoreSupport/GeolocationClientGtk.cpp: Added.
(WebKit::getPositionCallback):
(WebKit::positionChangedCallback):
(WebKit::GeolocationClient::GeolocationClient):
(WebKit::GeolocationClient::geolocationDestroyed):
(WebKit::GeolocationClient::startUpdating):
(WebKit::GeolocationClient::stopUpdating):
(WebKit::GeolocationClient::setEnableHighAccuracy):
(WebKit::GeolocationClient::lastPosition):
(WebKit::GeolocationClient::requestPermission):
(WebKit::GeolocationClient::cancelPermissionRequest):
(WebKit::GeolocationClient::positionChanged):
(WebKit::GeolocationClient::updatePosition):
(WebKit::GeolocationClient::errorOccured):
* WebCoreSupport/GeolocationClientGtk.h: Added.
* webkit/webkitwebview.cpp:
(webkit_web_view_init): Use GeolocationClientMock as geolocation client
when running in DumpRenderTree.

Tools:

Add support for testing client-based geolocation tests in DumpRenderTree.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues): Reset GeolocationClientMock.
(createWebView): Create web view after declaring DumpRenderTree mode.
That way a mock client for geolocation is used instead of a GeoClue
client if a web view is created when testing.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Implement functions for
geolocation layout tests.
(LayoutTestController::setMockGeolocationPosition):
(LayoutTestController::setMockGeolocationError):
(LayoutTestController::setGeolocationPermission):
(LayoutTestController::numberOfPendingGeolocationPermissionRequests):
* Scripts/build-webkit: Note that the Gtk port is using client-based
geolocation, even though changing this flag has no effect on compilation.

LayoutTests:

Unskip geolocation tests that now pass.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r97248): :visited as descendant selector broken
antti@apple.com [Tue, 18 Oct 2011 12:58:07 +0000 (12:58 +0000)]
REGRESSION(r97248): :visited as descendant selector broken
https://bugs.webkit.org/show_bug.cgi?id=70122

Source/WebCore:

Reviewed by Nikolas Zimmerman.

Make ":visited foo" and similar selectors work correctly again. They can affect
the visited style of an element inside a visited link.

Test: fast/selectors/visited-descendant.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyDeclarations):

    Apply visited style to children of visited links too.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector):

    Don't disable visited matching until we run into first ancestor link or use combinator other than child/descendant.

(WebCore::SelectorChecker::determineLinkMatchType):

    Look into child/descendant component selectors too to determine the link match type.

LayoutTests:

Reviewed by Nikolas Zimmerman.

* fast/selectors/visited-descendant.html: Added.
* platform/mac/fast/selectors/visited-descendant-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Send mouse move events when we handle HoverEnter/Leave in QDesktopWebView
caio.oliveira@openbossa.org [Tue, 18 Oct 2011 12:52:32 +0000 (12:52 +0000)]
[Qt] Send mouse move events when we handle HoverEnter/Leave in QDesktopWebView
https://bugs.webkit.org/show_bug.cgi?id=70297

Reviewed by Simon Hausmann.

Qt treat the first and last hover movements as special HoverMove and HoverLeave events, but
WebKit doesn't make the difference, so we need to create move events for them.

While HoverEnter is in practice equivalent to HoverMove, the HoverLeave event is a bit
different because we want to emulate that the mouse is not only leaving the current node, but
completely leaving the whole document. The way to do this is to manufacture a move event with
a very far position, and was inspired by WebView::handleMouseEvent() in
Source/WebKit/win/WebView.cpp.

This patch fixes DesktopWebViewLinkHovered QML tests.

* UIProcess/qt/qdesktopwebpageproxy.cpp:
(QDesktopWebPageProxy::handleEvent):
(QDesktopWebPageProxy::handleHoverLeaveEvent):
* UIProcess/qt/qdesktopwebpageproxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-07 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 18 Oct 2011 12:51:43 +0000 (12:51 +0000)]
2011-10-07  Andrey Kosyakov  <caseq@chromium.org>

        [Chromium] suppress console output from DevTools window
        https://bugs.webkit.org/show_bug.cgi?id=69632

        Reviewed by Pavel Feldman.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::showDevTools):
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::didAddMessageToConsole):
        (WebViewHost::reset):
        (WebViewHost::setLogConsoleOutput):
        * DumpRenderTree/chromium/WebViewHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove CSSRule specific virtuals from StyleBase down into CSSRule.
andreas.kling@nokia.com [Tue, 18 Oct 2011 12:46:06 +0000 (12:46 +0000)]
Move CSSRule specific virtuals from StyleBase down into CSSRule.
https://bugs.webkit.org/show_bug.cgi?id=70240

Reviewed by Darin Adler.

Move all the isFooRule() virtuals except isImportRule() to CSSRule
since they only make sense for its subclasses. isRule() remains in
StyleBase since we still need it for the parent chain traversal.
isImportRule() remains because XSLImportRule implements it.

Also moved insertedIntoParent() and removed its usage in
XSLStyleSheet since it is only reimplemented by CSSImportRule.

* css/CSSRule.h:
(WebCore::CSSRule::isCharsetRule):
(WebCore::CSSRule::isFontFaceRule):
(WebCore::CSSRule::isKeyframeRule):
(WebCore::CSSRule::isKeyframesRule):
(WebCore::CSSRule::isMediaRule):
(WebCore::CSSRule::isPageRule):
(WebCore::CSSRule::isStyleRule):
(WebCore::CSSRule::isRegionStyleRule):
(WebCore::CSSRule::insertedIntoParent):
* css/StyleBase.h:
(WebCore::StyleBase::isImportRule):
(WebCore::StyleBase::isCSSStyleSheet):
* xml/XSLStyleSheet.h:
(WebCore::XSLStyleSheet::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOption.value should trim extra internal html spaces
commit-queue@webkit.org [Tue, 18 Oct 2011 12:39:11 +0000 (12:39 +0000)]
Option.value should trim extra internal html spaces
https://bugs.webkit.org/show_bug.cgi?id=69455

Patch by Sachin Puranik <jcqt43@motorola.com> on 2011-10-18
Reviewed by Kent Tamura.

Currently option.value does not trim the internal white space as suggested by spec. This patch implements the same.

Source/WebCore:

Test: fast/forms/option-value-trim-html-spaces.html

* dom/OptionElement.cpp: Removed a function as this implementation is moved to the HTMLOptionElement.cpp file.
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::value): Implementation of .value function which will now trim the html white spaces.

LayoutTests:

* fast/forms/option-value-trim-html-spaces-expected.txt: Test case to test the text triming on the value attribute.
* fast/forms/option-value-trim-html-spaces.html: Test case to test the text triming on the value attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] WebPreferences are impossible to use in QML.
alexis.menard@openbossa.org [Tue, 18 Oct 2011 12:29:23 +0000 (12:29 +0000)]
[Qt][WK2] WebPreferences are impossible to use in QML.
https://bugs.webkit.org/show_bug.cgi?id=70141

Reviewed by Kenneth Rohde Christiansen.

Make it possible to use qwkpreferences in QML. Renamed it
to follow our new style regarding class names. This class is
now a QObject that is exposed as a property of the view.
The tests give an idea of the usage.

* UIProcess/API/qt/WKView.h:
* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebView::preferences):
* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qmlplugin/plugin.cpp:
(WebKit2QmlPlugin::registerTypes):
* UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::preferences):
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qwebpreferences.cpp: Added.
(QWebPreferencesPrivate::createPreferences):
(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferencesPrivate::setFontFamily):
(QWebPreferencesPrivate::fontFamily):
(QWebPreferencesPrivate::setFontSize):
(QWebPreferencesPrivate::fontSize):
(QWebPreferences::QWebPreferences):
(QWebPreferences::~QWebPreferences):
(QWebPreferences::autoLoadImages):
(QWebPreferences::setAutoLoadImages):
(QWebPreferences::javascriptEnabled):
(QWebPreferences::setJavascriptEnabled):
(QWebPreferences::pluginsEnabled):
(QWebPreferences::setPluginsEnabled):
(QWebPreferences::offlineWebApplicationCacheEnabled):
(QWebPreferences::setOfflineWebApplicationCacheEnabled):
(QWebPreferences::localStorageEnabled):
(QWebPreferences::setLocalStorageEnabled):
(QWebPreferences::XSSAuditingEnabled):
(QWebPreferences::setXSSAuditingEnabled):
(QWebPreferences::privateBrowsingEnabled):
(QWebPreferences::setPrivateBrowsingEnabled):
(QWebPreferences::dnsPrefetchEnabled):
(QWebPreferences::setDnsPrefetchEnabled):
(QWebPreferences::standardFontFamily):
(QWebPreferences::setStandardFontFamily):
(QWebPreferences::fixedFontFamily):
(QWebPreferences::setFixedFontFamily):
(QWebPreferences::serifFontFamily):
(QWebPreferences::setSerifFontFamily):
(QWebPreferences::sansSerifFontFamily):
(QWebPreferences::setSansSerifFontFamily):
(QWebPreferences::cursiveFontFamily):
(QWebPreferences::setCursiveFontFamily):
(QWebPreferences::fantasyFontFamily):
(QWebPreferences::setFantasyFontFamily):
(QWebPreferences::minimumFontSize):
(QWebPreferences::setMinimumFontSize):
(QWebPreferences::defaultFontSize):
(QWebPreferences::setDefaultFontSize):
(QWebPreferences::defaultFixedFontSize):
(QWebPreferences::setDefaultFixedFontSize):
* UIProcess/API/qt/qwebpreferences.h: Added.
* UIProcess/API/qt/qwebpreferences_p.h: Added.
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml: Added.
* UIProcess/API/qt/tests/qmltests/common/javascript.html: Added.
* UIProcess/API/qt/tests/qmltests/common/localStorage.html: Added.
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::preferences):
* UIProcess/qt/QtWebPageProxy.h:
* UIProcess/qt/qwkpreferences.cpp: Removed.
* UIProcess/qt/qwkpreferences.h: Removed.
* UIProcess/qt/qwkpreferences_p.h: Removed.
* WebKit2.pro:
* WebKit2API.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Fix compilation error by include WebErrors.h file.
commit-queue@webkit.org [Tue, 18 Oct 2011 11:52:37 +0000 (11:52 +0000)]
[EFL][WK2] Fix compilation error by include WebErrors.h file.
https://bugs.webkit.org/show_bug.cgi?id=70309

Unreviewed build fix

Added a header file to fix compilation error.

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-10-18

* WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions]Parse @-webkit-region rule
mihnea@adobe.com [Tue, 18 Oct 2011 11:50:49 +0000 (11:50 +0000)]
[CSS Regions]Parse @-webkit-region rule
https://bugs.webkit.org/show_bug.cgi?id=70021

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/parsing-region-style-rule.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOMCSS.mm:
(kitClass):
* bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::toV8):
* css/CSSGrammar.y:
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::cssText):
* css/CSSParser.cpp:
(WebCore::CSSParser::setReusableRegionSelectorVector):
(WebCore::CSSParser::createRegionStylingRule):
* css/CSSParser.h:
(WebCore::CSSParser::reusableRegionSelectorVector):
* css/CSSRegionStyleRule.cpp: Added.
(WebCore::CSSRegionStyleRule::CSSRegionStyleRule):
(WebCore::CSSRegionStyleRule::~CSSRegionStyleRule):
(WebCore::CSSRegionStyleRule::cssText):
* css/CSSRegionStyleRule.h: Added.
* css/CSSRule.h:
* css/CSSRule.idl:
* css/CSSRuleList.cpp:
(WebCore::CSSRuleList::item):
(WebCore::CSSRuleList::rulesText):
* css/CSSRuleList.h:
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::selectorsText):
* css/CSSSelectorList.h:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::addRegionStyleRule):
(WebCore::RuleSet::addRulesFromSheet):
* css/CSSStyleSelector.h:
* css/StyleBase.h:
(WebCore::StyleBase::isRegionStyleRule):
* css/tokenizer.flex:

LayoutTests:

* fast/dom/Window/window-properties-expected.txt:
* fast/regions/parsing-region-style-rule-expected.txt: Added.
* fast/regions/parsing-region-style-rule.html: Added.
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
* platform/win/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r97735.
commit-queue@webkit.org [Tue, 18 Oct 2011 11:41:18 +0000 (11:41 +0000)]
Unreviewed, rolling out r97735.
http://trac.webkit.org/changeset/97735
https://bugs.webkit.org/show_bug.cgi?id=70317

some people apparently use build-jsc with the qt port without
building webkit first (Requested by torarne on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-18

* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
(buildQMakeProject):
(buildQMakeQtProject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97737 268f45cc-cd09-0410-ab3c-d52691b4dbfc