WebKit-https.git
7 years agoSplit the intrinsic padding update code out of RenderTableSection::layoutRows
jchaffraix@webkit.org [Fri, 5 Oct 2012 03:56:17 +0000 (03:56 +0000)]
Split the intrinsic padding update code out of RenderTableSection::layoutRows
https://bugs.webkit.org/show_bug.cgi?id=98454

Reviewed by Eric Seidel.

RenderTableSection::layoutRows is very long and it's difficult to see what's
going on. This change moves the intrinsic padding update code into RenderTableCell
for clarity. While at it, cleaned up a bit the code (renaming variables, functions).

Change covered by existing table tests.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeIntrinsicPadding):
Added this new function that does the update. Removed the 'default' case, replaced by
the explicit label BASELINE_MIDDLE.

* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::setIntrinsicPaddingBefore):
(WebCore::RenderTableCell::setIntrinsicPaddingAfter):
(WebCore::RenderTableCell::setIntrinsicPadding):
Moved those setters to the private section as we want other classes
to use computeIntrinsicPadding.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
Replaced the code with a call to RenderTableCell::computeIntrinsicPadding.
Also moved 2 variables in the loop per our coding style.

* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::rowBaseline):
Renamed to match our coding style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the Qt build by removing an errant paste at the top of the file.
simon.fraser@apple.com [Fri, 5 Oct 2012 03:18:46 +0000 (03:18 +0000)]
Fix the Qt build by removing an errant paste at the top of the file.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate chromium baselines for 5006779.html and paint-subrect-grid.html.
dpranke@chromium.org [Fri, 5 Oct 2012 02:55:44 +0000 (02:55 +0000)]
Update chromium baselines for 5006779.html and paint-subrect-grid.html.

Unreviewed, rebaselining.

Updates after r130425 and r130411.

* platform/chromium-linux/fast/images/paint-subrect-grid-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/images/paint-subrect-grid-expected.png.
* platform/chromium-win-xp/editing/pasteboard/5006779-expected.png: Added.
* platform/chromium-win-xp/editing/pasteboard/5006779-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/5006779-expected.txt.
* platform/chromium-win/editing/pasteboard/5006779-expected.txt:
* platform/chromium/fast/images/paint-subrect-grid-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/images/paint-subrect-grid-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewd. Chromium DEPS roll. Update to r160281.
hclam@chromium.org [Fri, 5 Oct 2012 02:47:52 +0000 (02:47 +0000)]
Unreviewd. Chromium DEPS roll. Update to r160281.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add APIs to get/set the frame flattening.
ryuan.choi@samsung.com [Fri, 5 Oct 2012 02:37:58 +0000 (02:37 +0000)]
[EFL][WK2] Add APIs to get/set the frame flattening.
https://bugs.webkit.org/show_bug.cgi?id=95982

Reviewed by Gyuyoung Kim.

Source/WebKit2:

Added new APIs and test case to support frame flattening.

* UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_enable_frame_flattening_set):
(ewk_settings_enable_frame_flattening_get):
* UIProcess/API/efl/ewk_settings.h:
* UIProcess/API/efl/tests/resources/frame_flattening_test.html: Added.
* UIProcess/API/efl/tests/resources/frame_flattening_test_subframe.html: Added.
* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):

Tools:

* MiniBrowser/efl/main.c: Added frame flattening option to test.
(browserCreate):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in EventHandler::mouseMoved().
japhet@chromium.org [Fri, 5 Oct 2012 02:31:16 +0000 (02:31 +0000)]
Crash in EventHandler::mouseMoved().
https://bugs.webkit.org/show_bug.cgi?id=98460

Reviewed by Abhishek Arya.

No new tests, this fixes fast/events/mouse-moved-remove-frame-crash.html.

* page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Update some #includes for Platform directory
pilgrim@chromium.org [Fri, 5 Oct 2012 02:30:19 +0000 (02:30 +0000)]
[Chromium] Update some #includes for Platform directory
https://bugs.webkit.org/show_bug.cgi?id=98440

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

* src/ApplicationCacheHost.cpp:
* src/AssociatedURLLoader.h:
* src/AsyncFileWriterChromium.cpp:
* src/AudioDestinationChromium.h:
* src/AutofillPopupMenuClient.cpp:
* src/ChromeClientImpl.cpp:
* src/ContextMenuClientImpl.cpp:
* src/DeliveredIntentClientImpl.h:
* src/DragClientImpl.cpp:
* src/DragScrollTimer.h:
* src/FrameLoaderClientImpl.cpp:
* src/InspectorClientImpl.cpp:
* src/InspectorClientImpl.h:
* src/InspectorFrontendClientImpl.cpp:
* src/NotificationPresenterImpl.cpp:
* src/PageWidgetDelegate.h:
* src/SocketStreamHandle.cpp:
* src/SocketStreamHandleInternal.h:
* src/SpeechInputClientImpl.cpp:
* src/StorageAreaProxy.cpp:
* src/StorageNamespaceProxy.cpp:
* src/UserMediaClientImpl.cpp:
* src/WebAccessibilityObject.cpp:
* src/WebAnimationControllerImpl.cpp:
* src/WebCommon.cpp:
* src/WebDOMEventListenerPrivate.h:
* src/WebDOMMessageEvent.cpp:
* src/WebDOMStringList.cpp:
* src/WebDataSourceImpl.cpp:
* src/WebDatabase.cpp:
* src/WebDevToolsAgentImpl.cpp:
* src/WebDevToolsAgentImpl.h:
* src/WebDocument.cpp:
* src/WebDocumentType.cpp:
* src/WebDragData.cpp:
* src/WebElement.cpp:
* src/WebEntities.cpp:
* src/WebFileChooserCompletionImpl.h:
* src/WebFileSystemCallbacksImpl.cpp:
* src/WebFontImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed. Rebaseline mac/win results after r130355
noel.gordon@gmail.com [Fri, 5 Oct 2012 02:26:11 +0000 (02:26 +0000)]
[chromium] Unreviewed. Rebaseline mac/win results after r130355
https://bugs.webkit.org/show_bug.cgi?id=98472

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-10-04

* platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-combinations-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-transformed-expected.png: Added.
* platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
* platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
* platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
* platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
* platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
* platform/chromium-mac-snowleopard/media/controls-styling-strict-expected.png:
* platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
* platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.png:
* platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.png:
* platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
* platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
* platform/chromium-mac-snowleopard/media/video-no-audio-expected.png:
* platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
* platform/chromium-mac/fast/clip/overflow-border-radius-combinations-expected.png:
* platform/chromium-mac/fast/clip/overflow-border-radius-fixed-position-expected.png:
* platform/chromium-mac/fast/clip/overflow-border-radius-transformed-expected.png:
* platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium-mac/media/audio-controls-rendering-expected.png:
* platform/chromium-mac/media/audio-repaint-expected.png:
* platform/chromium-mac/media/controls-after-reload-expected.png:
* platform/chromium-mac/media/controls-strict-expected.png:
* platform/chromium-mac/media/controls-styling-expected.png:
* platform/chromium-mac/media/controls-styling-strict-expected.png:
* platform/chromium-mac/media/controls-without-preload-expected.png:
* platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
* platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.png:
* platform/chromium-mac/media/video-controls-rendering-expected.png:
* platform/chromium-mac/media/video-display-toggle-expected.png:
* platform/chromium-mac/media/video-no-audio-expected.png:
* platform/chromium-mac/media/video-playing-and-pause-expected.png:
* platform/chromium-mac/media/video-zoom-controls-expected.png:
* platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
* platform/chromium-win/fast/clip/overflow-border-radius-combinations-expected.png:
* platform/chromium-win/fast/clip/overflow-border-radius-fixed-position-expected.png:
* platform/chromium-win/fast/clip/overflow-border-radius-transformed-expected.png:
* platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium-win/media/audio-controls-rendering-expected.png:
* platform/chromium-win/media/audio-repaint-expected.png:
* platform/chromium-win/media/controls-after-reload-expected.png:
* platform/chromium-win/media/controls-strict-expected.png:
* platform/chromium-win/media/controls-styling-expected.png:
* platform/chromium-win/media/controls-styling-strict-expected.png:
* platform/chromium-win/media/controls-without-preload-expected.png:
* platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
* platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
* platform/chromium-win/media/video-controls-rendering-expected.png:
* platform/chromium-win/media/video-display-toggle-expected.png:
* platform/chromium-win/media/video-no-audio-expected.png:
* platform/chromium-win/media/video-playing-and-pause-expected.png:
* platform/chromium-win/media/video-zoom-controls-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] NotificationCenter leaks because it uses buggy custom bindings
abarth@webkit.org [Fri, 5 Oct 2012 02:18:45 +0000 (02:18 +0000)]
[V8] NotificationCenter leaks because it uses buggy custom bindings
https://bugs.webkit.org/show_bug.cgi?id=98445

Reviewed by Tony Chang.

There's no reason to use custom bindings here. All they do is cause leaks..

* Modules/notifications/NotificationCenter.idl:
* bindings/v8/custom/V8NotificationCenterCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSelector specificity categories "overflow" into higher categories
commit-queue@webkit.org [Fri, 5 Oct 2012 02:04:44 +0000 (02:04 +0000)]
Selector specificity categories "overflow" into higher categories
https://bugs.webkit.org/show_bug.cgi?id=98295

Patch by Tab Atkins <jackalmage@gmail.com> on 2012-10-04
Reviewed by Eric Seidel.

This patch adds per-component overflow guards for CSS selector specificity.
Previously, we didn't guard against overflow.
Since we stored each component as a byte mapped into a single unsigned int for the whole specificity,
256 of a particular simple selector was equivalent to 1 of the next-higher-group selector.
This violated the Selectors specification,
which requires the components to be compared lexicographically.

Tests: /fast/selectors/specificity-overflow.html

* css/CSSSelector.cpp:
(WebCore::CSSSelector::specificity):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFont::glyphDataAndPageForCharacter doesn't account for text orientation when using...
enrica@apple.com [Fri, 5 Oct 2012 02:03:12 +0000 (02:03 +0000)]
Font::glyphDataAndPageForCharacter doesn't account for text orientation when using systemFallback on a cold cache.
https://bugs.webkit.org/show_bug.cgi?id=98452.

Reviewed by Dan Bernstein.

Source/WebCore:

The text orientation was considered only when there is a cache hit.
This change moves the logic to handle text orientation to a separate
inline function that is called also when the glyph is added to the cache.

Test: fast/text/vertical-rl-rtl-linebreak.html

* platform/graphics/FontFastPath.cpp:
(WebCore::applyTextOrientationForCharacter): Added.
(WebCore::Font::glyphDataAndPageForCharacter): Modified to use the new function in
both cases of cold and warm cache.

LayoutTests:

The new test adds platform specific results for Mac, since it uses system fallback fonts.
I've added the expected failure for all the other platforms.

* fast/text/vertical-rl-rtl-linebreak.html: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
* platform/qt/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMutationRecord attributeName should be null for non attribute changes
adamk@chromium.org [Fri, 5 Oct 2012 01:02:29 +0000 (01:02 +0000)]
MutationRecord attributeName should be null for non attribute changes
https://bugs.webkit.org/show_bug.cgi?id=98438

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/mutation/mutation-record-nullity.html

* dom/MutationRecord.idl:

LayoutTests:

* fast/mutation/mutation-record-nullity-expected.txt: Added.
* fast/mutation/mutation-record-nullity.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTiledCoreAnimationDrawingArea.mm should not include RenderLayerCompositor.h
simon.fraser@apple.com [Fri, 5 Oct 2012 00:54:12 +0000 (00:54 +0000)]
TiledCoreAnimationDrawingArea.mm should not include RenderLayerCompositor.h
https://bugs.webkit.org/show_bug.cgi?id=98471

Reviewed by Dean Jackson.

Remove #import of <WebCore/RenderLayerCompositor.h> from this file.
It is not required.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMore Qt rebaselines after r130411.
rniwa@webkit.org [Fri, 5 Oct 2012 00:46:01 +0000 (00:46 +0000)]
More Qt rebaselines after r130411.

* platform/qt/editing/deleting/delete-block-merge-contents-020-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-021-expected.txt:
* platform/qt/editing/pasteboard/5006779-expected.txt:
* platform/qt/editing/pasteboard/paste-line-endings-007-expected.txt:
* platform/qt/editing/pasteboard/paste-line-endings-008-expected.txt:
* platform/qt/editing/pasteboard/smart-paste-004-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFinal part of "sync" to "flush" renaming
simon.fraser@apple.com [Fri, 5 Oct 2012 00:43:04 +0000 (00:43 +0000)]
Final part of "sync" to "flush" renaming
https://bugs.webkit.org/show_bug.cgi?id=98430

Reviewed by Tim Horton.

Change method names on GraphicsLayer and GraphicsLayerClient that
refer to "sync" to use the term "flush" instead, to be consistent
with the rest of the code.

Source/WebCore:

* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::flushCompositingState):
(WebCore::GraphicsLayer::flushCompositingStateForThisLayerOnly):
* platform/graphics/GraphicsLayerClient.h:
(GraphicsLayerClient):
* platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
(WebCore::GraphicsLayerBlackBerry::notifyFlushRequired):
* platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::setNeedsCommit):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::flushCompositingState):
(WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerCA::platformCALayerDidCreateTiles):
(WebCore::GraphicsLayerCA::positionForCloneRootLayer):
(WebCore::GraphicsLayerCA::noteLayerPropertyChanged):
* platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::notifyChange):
(WebCore::GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::flushCompositingState):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::flushCompositingState):
(WebCore::TextureMapperLayer::flushCompositingStateSelf):
* platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::notifyFlushRequired):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
* rendering/RenderLayerCompositor.h:
(WebCore::RenderLayerCompositor::notifyFlushRequired):

Source/WebKit/blackberry:

* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyFlushRequired):
* Api/WebOverlay_p.h:
(WebOverlayPrivateWebKitThread):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyFlushRequired):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebKitSupport/DefaultTapHighlight.cpp:
(BlackBerry::WebKit::DefaultTapHighlight::notifyFlushRequired):
* WebKitSupport/DefaultTapHighlight.h:
(DefaultTapHighlight):
* WebKitSupport/InspectorOverlayBlackBerry.cpp:
(BlackBerry::WebKit::InspectorOverlay::notifyFlushRequired):
* WebKitSupport/InspectorOverlayBlackBerry.h:
(InspectorOverlay):
* WebKitSupport/SelectionOverlay.cpp:
(BlackBerry::WebKit::SelectionOverlay::notifyFlushRequired):
* WebKitSupport/SelectionOverlay.h:
(SelectionOverlay):

Source/WebKit/efl:

* WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
(WebCore::AcceleratedCompositingContext::syncLayersNow):
(WebCore::AcceleratedCompositingContext::attachRootGraphicsLayer):

Source/WebKit/gtk:

* WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext):
* WebCoreSupport/AcceleratedCompositingContextCairo.cpp:
(WebKit::AcceleratedCompositingContext::attachRootGraphicsLayer):
(WebKit::AcceleratedCompositingContext::resizeRootLayer):
(WebKit::AcceleratedCompositingContext::syncLayersNow):
(WebKit::AcceleratedCompositingContext::notifyFlushRequired):
* WebCoreSupport/AcceleratedCompositingContextClutter.cpp:
(WebKit::AcceleratedCompositingContext::flushPendingLayerChanges):
(WebKit::AcceleratedCompositingContext::notifyFlushRequired):
* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::flushPendingLayerChanges):
(WebKit::AcceleratedCompositingContext::notifyFlushRequired):

Source/WebKit/mac:

* WebView/WebView.mm:

Source/WebKit/qt:

* WebCoreSupport/PageClientQt.cpp:
(WebCore::TextureMapperLayerClientQt::syncRootLayer):

Source/WebKit/win:

* WebView.cpp:
(WebView::notifyFlushRequired):
(WebView::flushPendingGraphicsLayerChanges):
* WebView.h:

Source/WebKit2:

* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::paintToCurrentGLContext):
(WebKit::LayerTreeRenderer::flushLayerChanges):
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(WebKit::LayerTreeRenderer::notifyFlushRequired):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::didChangeLayerState):
(WebCore::CoordinatedGraphicsLayer::didChangeAnimatedProperties):
(WebCore::CoordinatedGraphicsLayer::didChangeChildren):
(WebCore::CoordinatedGraphicsLayer::didChangeFilters):
(WebCore::CoordinatedGraphicsLayer::setContentsNeedsDisplay):
(WebCore::CoordinatedGraphicsLayer::setContentsToCanvas):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::notifyFlushRequired):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::notifyFlushRequired):
(WebKit::LayerTreeHostCA::flushPendingLayerChanges):
* WebProcess/WebPage/ca/LayerTreeHostCA.h:
(LayerTreeHostCA):
* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::notifyFlushRequired):
(WebKit::LayerTreeHostGtk::flushPendingLayerChanges):
* WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
(LayerTreeHostGtk):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::notifyFlushRequired):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGTK+ rebaselines after r130411.
rniwa@webkit.org [Fri, 5 Oct 2012 00:41:17 +0000 (00:41 +0000)]
GTK+ rebaselines after r130411.

* platform/gtk/editing/deleting/delete-block-merge-contents-018-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-019-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-020-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-021-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-022-expected.txt:
* platform/gtk/editing/deleting/merge-no-br-expected.txt:
* platform/gtk/editing/execCommand/find-after-replace-expected.txt:
* platform/gtk/editing/execCommand/paste-2-expected.txt:
* platform/gtk/editing/pasteboard/4944770-2-expected.txt:
* platform/gtk/editing/pasteboard/5006779-expected.txt:
* platform/gtk/editing/pasteboard/5028447-expected.txt:
* platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
* platform/gtk/editing/pasteboard/merge-end-borders-expected.txt:
* platform/gtk/editing/pasteboard/paste-line-endings-008-expected.txt:
* platform/gtk/editing/pasteboard/paste-line-endings-009-expected.txt:
* platform/gtk/editing/pasteboard/paste-line-endings-010-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
* platform/gtk/editing/pasteboard/paste-xml-expected.txt:
* platform/gtk/editing/pasteboard/smart-drag-drop-expected.txt:
* platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
* platform/gtk/fast/lists/drag-into-marker-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago1ex should equal .5em when the font has no x-height metric
commit-queue@webkit.org [Fri, 5 Oct 2012 00:35:56 +0000 (00:35 +0000)]
1ex should equal .5em when the font has no x-height metric
https://bugs.webkit.org/show_bug.cgi?id=80360

Patch by Tab Atkins <tabatkins@google.com> on 2012-10-04
Reviewed by Eric Seidel.

Source/WebCore:

Updated FontMetrics and CSSPrimitiveValue to have/use an explicit "hasXHeight" flag to determine how to size an 'ex' unit.

Updated a few of the platform font files to set the flag properly.

Patch cleanup by David Barr <davidbarr@chromium.org>.

Test: fast/css/ex-unit-with-no-x-height.html

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthDouble):
* platform/graphics/FontMetrics.h:
(WebCore::FontMetrics::FontMetrics):
(WebCore::FontMetrics::setXHeight):
(FontMetrics):
(WebCore::FontMetrics::hasXHeight):
(WebCore::FontMetrics::setHasXHeight):
(WebCore::FontMetrics::reset):
* platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformInit):

LayoutTests:

If a font has no x-height metric, 1ex should equal .5em.

Test layout tweaked by David Barr <davidbarr@chromium.org>.

* fast/css/ex-unit-with-no-x-height-expected.txt: Added.
* fast/css/ex-unit-with-no-x-height.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r130419.
dpranke@chromium.org [Fri, 5 Oct 2012 00:34:19 +0000 (00:34 +0000)]
Unreviewed, rolling out r130419.
http://trac.webkit.org/changeset/130419
https://bugs.webkit.org/show_bug.cgi?id=98406

broke editing/pasteboard/data-transfer-items.html on chromium

* wtf/HashTraits.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] New test introduced in r129346 inspector-protocol/css-getSupportedCSSProperties...
commit-queue@webkit.org [Thu, 4 Oct 2012 23:52:28 +0000 (23:52 +0000)]
[Qt] New test introduced in r129346 inspector-protocol/css-getSupportedCSSProperties.html fails
https://bugs.webkit.org/show_bug.cgi?id=97451

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-04
Reviewed by Kenneth Rohde Christiansen.

Unskipping this test that is passing.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Implement PageClientImpl::isViewVisible()
commit-queue@webkit.org [Thu, 4 Oct 2012 23:51:33 +0000 (23:51 +0000)]
[EFL][WK2] Implement PageClientImpl::isViewVisible()
https://bugs.webkit.org/show_bug.cgi?id=98249

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-04
Reviewed by Kenneth Rohde Christiansen.

Implement PageClientImpl::isViewVisible() for EFL port
by calling evas_object_visible_get() on the view.

* UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::isViewVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate some picker tests for input[type=date]
tkent@chromium.org [Thu, 4 Oct 2012 23:50:09 +0000 (23:50 +0000)]
Update some picker tests for input[type=date]
https://bugs.webkit.org/show_bug.cgi?id=98390

Reviewed by Daniel Bates.

r130375 changed a behavior. A key bind to open a calendar picker
or a suggestion picker was changed from "Down" to "Alt + Down". We
need to update tests which open pickers for input[type=date].

* fast/forms/date/calendar-picker-appearance-expected.txt:
* fast/forms/date/calendar-picker-appearance-pre-100.html:
Use openPicker() in calendar-picker-common.js.
* fast/forms/date/calendar-picker-appearance.html: Ditto.
* fast/forms/date/calendar-picker-common.js:
(openPicker): Specify Alt modifier.
(sendKey): Add ctrlKey and altKey flags.
* fast/forms/date/calendar-picker-with-step.html:
Use openPicker() in calendar-picker-common.js.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html:
Use openPicker() in suggestion-picker-common.js
* platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar.html:
Ditto.
* platform/chromium/fast/forms/date/date-suggestion-picker-appearance.html:
Ditto.
* platform/chromium/fast/forms/date/date-suggestion-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/date/date-suggestion-picker-key-operations.html:
Use openPicker() and sendKey() in suggestion-picker-common.js.
Increase the internal timeout because it was too short on my machine.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Improve initial empty process tracking
ap@apple.com [Thu, 4 Oct 2012 22:54:07 +0000 (22:54 +0000)]
    Improve initial empty process tracking
        https://bugs.webkit.org/show_bug.cgi?id=98458

        Reviewed by Sam Weinig.

        * UIProcess/WebContext.cpp: (WebKit::WebContext::disconnectProcess):
        Unset m_haveInitialEmptyProcess if we no longer do.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Chromium rebaselines.
hclam@chromium.org [Thu, 4 Oct 2012 22:45:39 +0000 (22:45 +0000)]
Unreviewed. Chromium rebaselines.

Rebaseline pixel results after r130412.

* platform/chromium-mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.png:
* platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Build fix after r130411. Add the right offset.
rniwa@webkit.org [Thu, 4 Oct 2012 22:40:35 +0000 (22:40 +0000)]
Source/WebCore: Build fix after r130411. Add the right offset.
Also use RefPtr instead of a raw pointer for next and previous pointers.

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::mergeTextNodesAroundPosition):

LayoutTests: Another rebaseline needed after r130411.

* platform/mac/editing/pasteboard/5006779-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: promote objectstore/index backend ids to the frontend
alecflett@chromium.org [Thu, 4 Oct 2012 22:38:18 +0000 (22:38 +0000)]
IndexedDB: promote objectstore/index backend ids to the frontend
https://bugs.webkit.org/show_bug.cgi?id=97834

Reviewed by Tony Chang.

Source/WebCore:

Expose int64-based database/objectStore/index ids to the renderer,
step 1 of 2. Support both styles of createObjectStore and
createIndex: those that take an explicit id, and those that take
-1, meaning to autogenerate an id on the backend. In part 2, after
the chromium side lands, support for the autogenerated ids will be
removed. (See https://bugs.webkit.org/show_bug.cgi?id=98085)

This is a part of larger refactoring work to ultimately make the interface
between the frontend and the backend simpler.

No new tests, extensive ASSERTs and existing tests cover correctness.

* Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::metadata):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::metadata):
* Modules/indexeddb/IDBIndexBackendImpl.h:
(WebCore::IDBIndexBackendImpl::create):
(IDBIndexBackendImpl):
* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore):
(WebCore::getMaxObjectStoreId):
(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::deleteDatabase):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::setMaxObjectStoreId):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::getMaxIndexId):
(WebCore::setMaxIndexId):
(WebCore::IDBLevelDBBackingStore::createIndex):
* Modules/indexeddb/IDBLevelDBBackingStore.h:
(IDBLevelDBBackingStore):
* Modules/indexeddb/IDBMetadata.h:
(WebCore::IDBDatabaseMetadata::IDBDatabaseMetadata):
(IDBDatabaseMetadata):
(WebCore::IDBObjectStoreMetadata::IDBObjectStoreMetadata):
(IDBObjectStoreMetadata):
(WebCore::IDBIndexMetadata::IDBIndexMetadata):
(IDBIndexMetadata):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::metadata):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(WebCore::IDBObjectStoreBackendImpl::create):
(IDBObjectStoreBackendImpl):
* Modules/indexeddb/IDBObjectStoreBackendInterface.h:

Source/WebKit/chromium:

Support for marshalling additional IDBMetadata and new calls to
createObjectStore/createIndex.

* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::createObjectStore):
* public/WebIDBMetadata.h:
(ObjectStore):
(Index):
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::createIndex):
* src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::createObjectStore):
(WebKit):
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::createIndex):
(WebKit):
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::createObjectStore):
(WebKit):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* src/WebIDBMetadata.cpp:
(WebKit::WebIDBMetadata::WebIDBMetadata):
(WebKit::WebIDBMetadata::operator IDBDatabaseMetadata):
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::createIndex):
(WebKit):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add libxml 2.8.0 to jhbuild
commit-queue@webkit.org [Thu, 4 Oct 2012 22:32:07 +0000 (22:32 +0000)]
[EFL] Add libxml 2.8.0 to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=98418

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-04
Reviewed by Laszlo Gombos.

.:

Bump dependency for libxml to 2.8.0 to match
jhbuild.

* Source/cmake/OptionsEfl.cmake:

Tools:

Add libxml 2.8.0 to EFL's jhbuild for consistency.

* efl/jhbuild.modules:

LayoutTests:

Unskip fast/xsl/xslt-missing-namespace-in-xslt.xml
since it passes with libxml 2.8.0 and we now depend
on that version.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Landing render tree results for css3/flexbox/flexbox-baseline...
tony@chromium.org [Thu, 4 Oct 2012 22:30:46 +0000 (22:30 +0000)]
Unreviewed gardening.  Landing render tree results for css3/flexbox/flexbox-baseline.html.
https://bugs.webkit.org/show_bug.cgi?id=98306

This pixel test was added in r130405.

* platform/chromium-mac-snowleopard/css3/flexbox/flexbox-baseline-expected.png: Added.
* platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.png: Added.
* platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.txt: Added.
* platform/chromium-win/css3/flexbox/flexbox-baseline-expected.png: Added.
* platform/chromium-win/css3/flexbox/flexbox-baseline-expected.txt: Copied from LayoutTests/platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.txt.
* platform/chromium/TestExpectations:
* platform/gtk/TestExpectations:
* platform/gtk/css3/flexbox/flexbox-baseline-expected.txt: Added.
* platform/mac/TestExpectations:
* platform/mac/css3/flexbox/flexbox-baseline-expected.txt: Added.
* platform/qt/TestExpectations:
* platform/qt/css3/flexbox/flexbox-baseline-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Chromium rebaselines.
hclam@chromium.org [Thu, 4 Oct 2012 22:23:01 +0000 (22:23 +0000)]
Unreviewed. Chromium rebaselines.

* platform/chromium-mac/fast/images/paint-subrect-grid-expected.png: Copied from LayoutTests/platform/chromium/fast/images/paint-subrect-grid-expected.png.
* platform/chromium-win/fast/images/paint-subrect-grid-expected.png: Renamed from LayoutTests/platform/chromium/fast/images/paint-subrect-grid-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in Safari at com.apple.JavaScriptCore: WTF::StringImpl::is8Bit const + 12
msaboff@apple.com [Thu, 4 Oct 2012 20:27:45 +0000 (20:27 +0000)]
Crash in Safari at com.apple.JavaScriptCore: WTF::StringImpl::is8Bit const + 12
https://bugs.webkit.org/show_bug.cgi?id=98433

Reviewed by Jessie Berlin.

The problem is due to a String with a null StringImpl (i.e. a null string).
Added a length check before the is8Bit() check since length() checks for a null StringImpl.  Changed the
characters16() call to characters() since it can handle a null StringImpl as well.

* API/JSValueRef.cpp:
(JSValueMakeFromJSONString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium rebaselines after r130411.
rniwa@webkit.org [Thu, 4 Oct 2012 20:18:14 +0000 (20:18 +0000)]
Chromium rebaselines after r130411.

* platform/chromium-linux-x86/editing/pasteboard/paste-xml-expected.txt:
* platform/chromium-linux/editing/pasteboard/4944770-2-expected.txt:
* platform/chromium-linux/editing/pasteboard/paste-xml-expected.txt:
* platform/chromium-linux/editing/pasteboard/smart-drag-drop-expected.txt:
* platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.txt:
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-008-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-xml-expected.txt: Added.
* platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt:
* platform/chromium-win-xp/editing/pasteboard/paste-xml-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-018-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-019-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-020-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-021-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-022-expected.txt:
* platform/chromium-win/editing/deleting/merge-no-br-expected.txt:
* platform/chromium-win/editing/execCommand/find-after-replace-expected.txt:
* platform/chromium-win/editing/execCommand/paste-1-expected.txt:
* platform/chromium-win/editing/execCommand/paste-2-expected.txt:
* platform/chromium-win/editing/pasteboard/4944770-2-expected.txt:
* platform/chromium-win/editing/pasteboard/5028447-expected.txt:
* platform/chromium-win/editing/pasteboard/8145-3-expected.txt:
* platform/chromium-win/editing/pasteboard/drag-drop-modifies-page-expected.txt:
* platform/chromium-win/editing/pasteboard/merge-end-borders-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-line-endings-007-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-line-endings-008-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-line-endings-009-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-line-endings-010-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-match-style-001-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-008-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-009-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
* platform/chromium-win/editing/pasteboard/smart-paste-007-expected.txt:
* platform/chromium-win/editing/pasteboard/subframe-dragndrop-1-expected.txt:
* platform/chromium-win/editing/pasteboard/unrendered-br-expected.txt:
* platform/chromium-win/fast/lists/drag-into-marker-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout broken after cloning and re-inserting a table with a misplaced <form>
commit-queue@webkit.org [Thu, 4 Oct 2012 20:09:42 +0000 (20:09 +0000)]
Layout broken after cloning and re-inserting a table with a misplaced <form>
https://bugs.webkit.org/show_bug.cgi?id=86746

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-10-04
Reviewed by Julien Chaffraix.

Source/WebCore:

There is a concept of demotion for a <form> contained in a table. A <form> is demoted if its immediate parent
is either a <table>, table sections (tbody, etc) or a table row (tr). A renderer for such a <form> is created only
if its display is one of the table display types (TABLE, INLINE_TABLE, TABLE_FOOTER_GROUP, etc).
However when a <table> containing a demoted <form> is cloned, the <form> does not retain its demotion state and
results in the table getting improperly rendered.

Test: fast/table/form-with-non-table-display-inside-table-elements.html

* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::copyNonAttributePropertiesFromElement):
  Extended the virtual function for HTMLFormElement class specific implementation.
  The function is used to copy any necessary state information(member variables) associated with
  the <form> element being cloned to the current node.
  For HTMLFormElement node the member variable can be classified into five groups based on the
  information they hold:
    1) Variables containing information regarding <form> subtree and elements associated with it.
       These get updated as and when an element is added to the <form> subtree.
    2) Variables containing <form> submit state information.
    3) Flag to hold information if reset() has been called.
    4) Flag(m_wasDemoted) that indicates whether the form is demoted or not, based on which it needs to
       be handled differently during creation of its renderer.
       This information is currently being updated only during the HTML tree construction phase.
    5) Flag(m_wasMalformed) to hold information if the <form> is malformed or not.

  Variables of group (1) will be updated as and when elements are added to the <form> subtree. Whereas,
  (2) and (3) hold instance specific information, thus copying them is not required. Also (5) is currently not
  being used(not set by any code).

  On the other hand, (4) is required to be copied during cloning as this information cannot be accessed
  during the cloning process.

(WebCore):
* html/HTMLFormElement.h:
  Added copyNonAttributePropertiesFromElement() declaration.

LayoutTests:

* fast/table/form-with-non-table-display-inside-table-elements-expected.txt: Added.
* fast/table/form-with-non-table-display-inside-table-elements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoQt rebaseline after r130411.
rniwa@webkit.org [Thu, 4 Oct 2012 20:01:12 +0000 (20:01 +0000)]
Qt rebaseline after r130411.

* platform/qt/editing/deleting/delete-block-merge-contents-018-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-019-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-022-expected.txt:
* platform/qt/editing/deleting/merge-no-br-expected.txt:
* platform/qt/editing/execCommand/find-after-replace-expected.txt:
* platform/qt/editing/execCommand/paste-1-expected.txt:
* platform/qt/editing/execCommand/paste-2-expected.txt:
* platform/qt/editing/pasteboard/4944770-2-expected.txt:
* platform/qt/editing/pasteboard/5006779-expected.txt:
* platform/qt/editing/pasteboard/5028447-expected.txt:
* platform/qt/editing/pasteboard/8145-3-expected.txt:
* platform/qt/editing/pasteboard/merge-end-borders-expected.txt:
* platform/qt/editing/pasteboard/paste-line-endings-009-expected.txt:
* platform/qt/editing/pasteboard/paste-line-endings-010-expected.txt:
* platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
* platform/qt/editing/pasteboard/paste-text-008-expected.txt:
* platform/qt/editing/pasteboard/paste-text-009-expected.txt:
* platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
* platform/qt/editing/pasteboard/unrendered-br-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLower minimum table size of WTF::HashTable to reduce memory usage.
kling@webkit.org [Thu, 4 Oct 2012 19:49:15 +0000 (19:49 +0000)]
Lower minimum table size of WTF::HashTable to reduce memory usage.
<http://webkit.org/b/98406>
<rdar://problem/12432140>

Reviewed by Anders Carlsson.

Lower the default minimumTableSize for WTF hash tables from 64 to 8 entries.
This reduces WebProcess memory consumption by ~16MB on Membuster3 (a 6% progression!)

No significant movement on PLT or JSC benchmarks on my machine. If there's a perf regression somewhere
from this, we can tweak individual tables to have a larger minimumTableSize.

* wtf/HashTraits.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse copyLCharsFromUCharSource() for IdentifierLCharFromUCharTranslator translation
benjamin@webkit.org [Thu, 4 Oct 2012 19:34:34 +0000 (19:34 +0000)]
Use copyLCharsFromUCharSource() for IdentifierLCharFromUCharTranslator translation
https://bugs.webkit.org/show_bug.cgi?id=98335

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-10-04
Reviewed by Michael Saboff.

Michael Saboff added an optimized version of UChar->LChar conversion in r125846.
Use this function in JSC::Identifier.

* runtime/Identifier.cpp:
(JSC::IdentifierLCharFromUCharTranslator::translate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAttribute and Uniform variable names need translation in shader
dino@apple.com [Thu, 4 Oct 2012 19:31:10 +0000 (19:31 +0000)]
Attribute and Uniform variable names need translation in shader
https://bugs.webkit.org/show_bug.cgi?id=70989

Reviewed by Tim Horton (and Darin Adler).

Source/WebCore:

WebGL specifies some maximum lengths for variable names (attributes
and uniforms). Also, some GL drivers have issues with long names. For
that reason, ANGLE has an option to rewrite the shader, translating
long names into short names. Turning this on helps shaders compile,
but we need to keep a mapping between the original names and the
translated names, so that we bind to the right location from user code
(which won't ever see the translated source).

This provided an opportunity to clean up some other bits of code:
CSS Filters examined the uniform names after a compilation; It can
now use the variable name map. I also added a typedef for the
HashMaps that keep the shader, the source code and the variable name
mappings.

I also opened a followup bug to make sure these tables are deleted
when the associated shaders (or linked programs) go away:
https://bugs.webkit.org/show_bug.cgi?id=98204

Covered by existing tests (with some enhancements):
- fast/canvas/webgl/attrib-location-length-limits.html:
- fast/canvas/webgl/uniform-location-length-limits.html:

* platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::getSymbolInfo): Extracts all the information on symbols (either attributes
or uniforms) from the newly compiled shader.
(WebCore):
(WebCore::ANGLEWebKitBridge::compileShaderSource): New method name.
* platform/graphics/ANGLEWebKitBridge.h:
(WebCore::getUniforms): Deleted this method.
(WebCore::ANGLEShaderSymbol::isSampler): Make sure the symbol is a uniform.
(ANGLEWebKitBridge):
* platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::SymbolInfo::SymbolInfo): A new object that
holds the size, type and translated name of a symbol from a WebGL shader.
(ShaderSourceEntry):
(WebCore::GraphicsContext3D::ShaderSourceEntry::ShaderSourceEntry): Now keeps track
of the translated source code and symbol mappings.
(WebCore::GraphicsContext3D::ShaderSourceEntry::symbolMap): Helper function to
get the member variable corresponding to the type of symbol you're asking fo.
* platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::CustomFilterValidatedProgram): Calls new method
name which also produces a set of symbols to examine.
* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE): We now can pass
in some extra compile options to do translation of long symbol names. Also fill the
map of translated symbol names.
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::mappedSymbolName): Returns the mapped name for
a shader symbol if it was translated during compilation.
(WebCore):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getUniformLocation):

LayoutTests:

Added subtests to exercise variables that are well under the limits but
not long enough to produce an error. This way we now test all three options:
under the limit, at the limit, over the limit.

Also, the tests are unskipped on Mac.

* fast/canvas/webgl/attrib-location-length-limits-expected.txt:
* fast/canvas/webgl/attrib-location-length-limits.html:
* fast/canvas/webgl/uniform-location-length-limits-expected.txt:
* fast/canvas/webgl/uniform-location-length-limits.html:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Support all attributes of GeolocationPosition
benjamin@webkit.org [Thu, 4 Oct 2012 19:10:18 +0000 (19:10 +0000)]
[WK2] Support all attributes of GeolocationPosition
https://bugs.webkit.org/show_bug.cgi?id=98212

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-10-03
Reviewed by Sam Weinig.

Source/WebKit/mac:

Add an internal constructor for the sake of testing.
A similar API is used on iOS.

* WebView/WebGeolocationPosition.mm:
(-[WebGeolocationPosition initWithGeolocationPosition:]):

Source/WebKit2:

Add complete support for GeolocationPosition.

* Shared/WebGeolocationPosition.cpp:
(WebKit::WebGeolocationPosition::WebGeolocationPosition):
(WebKit::WebGeolocationPosition::Data::encode):
(WebKit::WebGeolocationPosition::Data::decode):
* Shared/WebGeolocationPosition.h:
(Data):
(WebKit::WebGeolocationPosition::create):
(WebKit::WebGeolocationPosition::canProvideAltitude):
(WebKit::WebGeolocationPosition::altitude):
(WebGeolocationPosition):
(WebKit::WebGeolocationPosition::canProvideAltitudeAccuracy):
(WebKit::WebGeolocationPosition::altitudeAccuracy):
(WebKit::WebGeolocationPosition::canProvideHeading):
(WebKit::WebGeolocationPosition::heading):
(WebKit::WebGeolocationPosition::canProvideSpeed):
(WebKit::WebGeolocationPosition::speed):
WebGeolocationPosition mirror the attributes of WebCore::GeolocationPosition.

* UIProcess/API/C/WKGeolocationPosition.cpp:
(WKGeolocationPositionCreate):
(WKGeolocationPositionCreate_b):
Add a new API exposing all the arguments.

* UIProcess/API/C/WKGeolocationPosition.h:
* WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::didChangePosition):

Tools:

Expand WebKitTestRunner and DumpRenderTree to test all the attributes
of GeolocationPosition.

* DumpRenderTree/TestRunner.cpp:
(setMockGeolocationPositionCallback):
* DumpRenderTree/TestRunner.h:
(TestRunner):
* DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::setMockGeolocationPosition):
* DumpRenderTree/gtk/TestRunnerGtk.cpp:
(TestRunner::setMockGeolocationPosition):
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setMockGeolocationPosition):
* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::setMockGeolocationPosition):
* DumpRenderTree/wx/TestRunnerWx.cpp:
(TestRunner::setMockGeolocationPosition):
* WebKitTestRunner/GeolocationProviderMock.cpp:
(WTR::GeolocationProviderMock::setPosition):
* WebKitTestRunner/GeolocationProviderMock.h:
(GeolocationProviderMock):
* WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
(_platformTypeVariableDeclaration):
Use a proper constructor for the JSValueRef, it is an opaque type, we are not supposed
to build the pointer outself.
This is necessary to support optional JSValueRef properly.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::setMockGeolocationPosition):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setMockGeolocationPosition):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::setMockGeolocationPosition):
* WebKitTestRunner/TestController.h:
(TestController):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

Add a new test for the exposed attributes. It is disabled everywhere else than
Mac because of the missing DRT features.

* fast/dom/Geolocation/coordinates-interface-attributes-expected.txt: Added.
* fast/dom/Geolocation/coordinates-interface-attributes.html: Added.
* platform/chromium/TestExpectations:
* platform/gtk/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake the Xvfb driver recognize `X' as a valid X server binary.
rakuco@webkit.org [Thu, 4 Oct 2012 18:58:24 +0000 (18:58 +0000)]
Make the Xvfb driver recognize `X' as a valid X server binary.
https://bugs.webkit.org/show_bug.cgi?id=98434

Reviewed by Dirk Pranke.

The X server binary can also be called `X', so account for that
possibility in the _next_free_display regexp.

Additionally, make the regular expression require at least one
space character after the `ps comm' part.

* Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver._next_free_display):
* Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
(XvfbDriverTest.test_next_free_display):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy: Accept WEBKITOUTPUTDIR in Port._setup_environ_for_server.
rakuco@webkit.org [Thu, 4 Oct 2012 18:50:23 +0000 (18:50 +0000)]
webkitpy: Accept WEBKITOUTPUTDIR in Port._setup_environ_for_server.
https://bugs.webkit.org/show_bug.cgi?id=98436

Reviewed by Dirk Pranke.

The Xvfb driver (ab)uses Port._setup_environ_for_server() to set
the environment for the server process, and the WEBKITOUTPUTDIR
environment variable was not being passed through, causing the
build directory to be wrongfully set to WebKitBuild/ all the time.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.to.setup_environ_for_server):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAfter r130344, OpaqueJSString() creates a empty string which should be a null string
msaboff@apple.com [Thu, 4 Oct 2012 18:49:42 +0000 (18:49 +0000)]
After r130344, OpaqueJSString() creates a empty string which should be a null string
https://bugs.webkit.org/show_bug.cgi?id=98417

Reviewed by Alexey Proskuryakov.

Removed the setting of enclosed string to an empty string from default constructor.
Before changeset r130344, the semantic was the default constructor produced a null
string.

* API/OpaqueJSString.h:
(OpaqueJSString::OpaqueJSString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[skia] Drawing a subrect of bitmap image is misaligned
hclam@chromium.org [Thu, 4 Oct 2012 18:40:56 +0000 (18:40 +0000)]
[skia] Drawing a subrect of bitmap image is misaligned
https://bugs.webkit.org/show_bug.cgi?id=95121

Reviewed by Stephen White.

Source/WebCore:

When drawing a subrect of BitmapImage and the subrect is not aligned
to integer boundaries, skia expands it to the closest enclosing integer
rectangle. This creates prominent rendering artifacts when an image
is used as background and its sub-regions are invalidated frequently.

This patch fixes the problem by doing alignment to integer boundaries
and clipping for both cases of RESAMPLE_AWESOME and RESAMPLE_LINEAR.

A clip rect is applied to the canvas using original destination
rectangle, while source and destination rectangles are enlarged
appropriately to ensure source rectangle is aligned.

This patch also fixes a closely related problem. In RESAMPLE_AWESOME
resampling mode the previous algorithm applies different approximated
scale factor for each scaled image fragment. This caused the stitched
image to look ugly.

Scale factor is approximated using entire image size, this gives a
more accurate approximation because of greater denominator and a
consistent scale factor across all fragments.

Changes in Skia enable caching of the scaled image and return the
scaled fragment because scale factor is now consistent for all
fragments.

Tests: fast/images/paint-subrect-grid.html
       fast/images/paint-subrect.html
       fast/images/repaint-subrect-grid.html

* platform/graphics/skia/ImageSkia.cpp:
(WebCore::computeResamplingMode): Use float for width and height.
(WebCore):
(WebCore::areBoundariesIntegerAligned):
(WebCore::computeBitmapDrawRects):
(WebCore::extractScaledImageFragment):
(WebCore::drawResampledBitmap): New algorithm for drawing scaled image fragment.
(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw): Use SkRect instead of SkIRect.
(WebCore::BitmapImageSingleFrameSkia::draw):
* platform/graphics/skia/NativeImageSkia.cpp:
Changing the algorithm for extracting a scaled image fragment.
A fragment is now identified by (scaledImageSize, scaledImageSubset).
(WebCore::NativeImageSkia::hasResizedBitmap):
(WebCore::NativeImageSkia::resizedBitmap):
(WebCore::NativeImageSkia::shouldCacheResampling):
(WebCore::NativeImageSkia::CachedImageInfo::CachedImageInfo):
(WebCore):
(WebCore::NativeImageSkia::CachedImageInfo::isEqual):
(WebCore::NativeImageSkia::CachedImageInfo::set):
(WebCore::NativeImageSkia::CachedImageInfo::rectInSubset):
* platform/graphics/skia/NativeImageSkia.h:
(NativeImageSkia):
(CachedImageInfo):

LayoutTests:

3 new tests added.

- fast/images/paint-subrect.html

This test enlarges a 2x1 image in a canvas for easy verification.
2/3 of the image is used as source rectangle to exercise the code path
for partial pixel addressing.

Pixel test result should have 1/3 blue on the left and 2/3 green on the
right with gradient according to interpolation settings.

- fast/images/paint-subrect-grid.html

Draws a 11x11 image into a canvas in 8 fragments with partial pixels.
Canvas should look just like a single image enlarged.

- fast/images/repaint-subrect-grid.html

Scale a 31x31 image to 55x55. A blue square moves across the scaled
image such that the image is partially invalidated. After the animation
the image should look the same.

* fast/images/paint-subrect-expected.txt: Added.
* fast/images/paint-subrect-grid-expected.txt: Added.
* fast/images/paint-subrect-grid.html: Added.
* fast/images/paint-subrect.html: Added.
* fast/images/repaint-subrect-grid-expected.html: Added.
* fast/images/repaint-subrect-grid.html: Added.
* fast/images/resources/grid-large.png: Added.
* fast/images/resources/grid-small.png: Added.
* platform/chromium/TestExpectations: Added image failure expectations.
* platform/chromium/fast/images/paint-subrect-expected.png: Added.
* platform/chromium/fast/images/paint-subrect-grid-expected.png: Added.
* platform/chromium/fast/images/repaint-subrect-grid-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplaceSelectionCommand should merge text nodes
rniwa@webkit.org [Thu, 4 Oct 2012 18:36:44 +0000 (18:36 +0000)]
ReplaceSelectionCommand should merge text nodes
https://bugs.webkit.org/show_bug.cgi?id=98188

Reviewed by Levi Weintraub.

Source/WebCore:

Added mergeTextNodesAroundPosition to ReplaceSelectionCommand to merge text nodes after the replace in
completeHTMLReplacement. Also fixed a bunch of bugs in other classes and functions to make this work.

This behavior change is tested by existing tests.

* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply): When splitting a text node, place the insertionPosition
at the end of the first half. Leaving it at the beginning of the second half confuses the rest of the code in
the function. However, the logic to handle the "insignificant" white spaces needs the position at the start of
the second half. So keep this position.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply): Update visibleStart after inserting a paragraph separator so that
the logic to cleanup the nested div checks the right condition (right beneath it starting with a long comment).
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace): Insert a space for smart paste at the appropriate
offset instead of at the end of endNode. Also update the layout before obtaining startDownstream as we may have
modified the DOM by inserting a space for endNode. Finally, a non-breaking space should be treated like a space
isCharacterSmartReplaceExempt for the purpose of smart replace. e.g. if we're inserting "world" after
"hello&nbsp;", we shouldn't be inserting another space between "hello" and "world".
(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
(WebCore::ReplaceSelectionCommand::mergeTextNodesAroundPosition): Added. Merge text nodes around position, and
adjust position and positionOnlyToBeUpdated accordingly. We need to call updatePositionForNodeRemoval when
positions were before or after the text node.
* editing/ReplaceSelectionCommand.h:
(ReplaceSelectionCommand):

LayoutTests:

Rebaselined tests.

* editing/deleting/merge-paragraphs-with-transparent-background-expected.txt:
* editing/deleting/paste-with-transparent-background-color-expected.txt:
* editing/execCommand/outdent-selection-expected.txt:
* editing/execCommand/remove-list-items-expected.txt:
* editing/inserting/insert-3907422-fix-expected.txt:
* editing/pasteboard/avoid-copying-body-with-background-expected.txt:
* editing/pasteboard/block-wrappers-necessary-expected.txt:
* editing/pasteboard/drag-drop-list-expected.txt:
* editing/pasteboard/merge-end-5-expected.txt:
* editing/pasteboard/paste-before-tab-span-expected.txt:
* editing/pasteboard/paste-into-table-cell-expected.txt:
* editing/pasteboard/paste-text-001-expected.txt:
* editing/pasteboard/paste-text-002-expected.txt:
* editing/pasteboard/paste-text-003-expected.txt:
* editing/pasteboard/paste-text-010-expected.txt:
* editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
* editing/pasteboard/paste-unrendered-select-expected.txt:
* editing/pasteboard/smart-paste-001-expected.txt:
* editing/pasteboard/smart-paste-002-expected.txt:
* editing/pasteboard/smart-paste-003-expected.txt:
* editing/pasteboard/smart-paste-004-expected.txt:
* editing/pasteboard/smart-paste-005-expected.txt:
* editing/pasteboard/smart-paste-006-expected.txt:
* fast/events/ondragenter-expected.txt:
* fast/lists/drag-into-marker.html:
* platform/mac/editing/deleting/delete-block-merge-contents-018-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-021-expected.txt:
* platform/mac/editing/deleting/delete-block-merge-contents-022-expected.txt:
* platform/mac/editing/deleting/merge-no-br-expected.txt:
* platform/mac/editing/execCommand/find-after-replace-expected.txt:
* platform/mac/editing/execCommand/paste-1-expected.txt:
* platform/mac/editing/execCommand/paste-2-expected.txt:
* platform/mac/editing/pasteboard/4944770-2-expected.txt:
* platform/mac/editing/pasteboard/5006779-expected.txt:
* platform/mac/editing/pasteboard/5028447-expected.txt:
* platform/mac/editing/pasteboard/8145-3-expected.txt:
* platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.txt:
* platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
* platform/mac/editing/pasteboard/merge-end-borders-expected.txt:
* platform/mac/editing/pasteboard/paste-line-endings-007-expected.txt:
* platform/mac/editing/pasteboard/paste-line-endings-008-expected.txt:
* platform/mac/editing/pasteboard/paste-line-endings-009-expected.txt:
* platform/mac/editing/pasteboard/paste-line-endings-010-expected.txt:
* platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
* platform/mac/editing/pasteboard/paste-text-004-expected.txt:
* platform/mac/editing/pasteboard/paste-text-005-expected.txt:
* platform/mac/editing/pasteboard/paste-text-008-expected.txt:
* platform/mac/editing/pasteboard/paste-text-009-expected.txt:
* platform/mac/editing/pasteboard/smart-drag-drop-expected.txt:
* platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
* platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
* platform/mac/editing/pasteboard/subframe-dragndrop-1-expected.txt:
* platform/mac/editing/pasteboard/unrendered-br-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, fix flexbox-baseline.html to test the new behavior after r130409.
tony@chromium.org [Thu, 4 Oct 2012 17:51:20 +0000 (17:51 +0000)]
Unreviewed, fix flexbox-baseline.html to test the new behavior after r130409.

* css3/flexbox/flexbox-baseline.html:
* platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.png:
* platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix <input type="month"> tests
tony@chromium.org [Thu, 4 Oct 2012 17:46:43 +0000 (17:46 +0000)]
Fix <input type="month"> tests
https://bugs.webkit.org/show_bug.cgi?id=98426

Reviewed by Ojan Vafai.

The month picker uses flexbox and assumes that it will be aligned with
the last line box. This looks visually correct. I will follow up on
www-style to see what the expected behavior is.

Tests: fast/forms/month-multiple-fields tests cover this.

* rendering/RenderFlexibleBox.cpp:
* rendering/RenderFlexibleBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, fixing expected results for a test that needs a new baseline.
tony@chromium.org [Thu, 4 Oct 2012 17:29:56 +0000 (17:29 +0000)]
Unreviewed, fixing expected results for a test that needs a new baseline.

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r130396.
commit-queue@webkit.org [Thu, 4 Oct 2012 17:24:14 +0000 (17:24 +0000)]
Unreviewed, rolling out r130396.
http://trac.webkit.org/changeset/130396
https://bugs.webkit.org/show_bug.cgi?id=98421

This patch is causing crashes on 4 tests on Lion Debug and
Mountain Lion Debug (Requested by jernoble on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-04

Source/WebCore:

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
* rendering/RenderLayerCompositor.h:
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
* testing/InternalSettings.h:
(Backup):

LayoutTests:

* compositing/layer-creation/fixed-position-absolute-descendant-expected.txt: Removed.
* compositing/layer-creation/fixed-position-absolute-descendant.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Fix r140403 by skipping the right test.
rakuco@webkit.org [Thu, 4 Oct 2012 17:21:31 +0000 (17:21 +0000)]
[EFL] Fix r140403 by skipping the right test.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoinline-flex baseline is sometimes wrong
tony@chromium.org [Thu, 4 Oct 2012 16:47:50 +0000 (16:47 +0000)]
inline-flex baseline is sometimes wrong
https://bugs.webkit.org/show_bug.cgi?id=96188

Reviewed by Ojan Vafai.

Source/WebCore:

Implement the necessary methods to get the proper baseline alignment of flexbox.
We were falling back to the inline-block behavior.

Test: css3/flexbox/flexbox-baseline.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::RenderFlexibleBox):
(WebCore::RenderFlexibleBox::baselinePosition): Used to get the baseline of the box.
Mostly just the first line box baseline.
(WebCore):
(WebCore::RenderFlexibleBox::lastLineBoxBaseline): This is used for getting the baseline when in an inline-block.
We actually don't want the last line, but the flexbox's baseline.
(WebCore::RenderFlexibleBox::firstLineBoxBaseline): Compute the baseline according to the rules in the spec.
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems): Keep track of the number of children on the
first line so we don't have to re-compute this when getting the baseline.
(WebCore::RenderFlexibleBox::crossAxisExtentForChild): Make const.
(WebCore::RenderFlexibleBox::mainAxisExtentForChild): Make const.
(WebCore::RenderFlexibleBox::hasAutoMarginsInCrossAxis): Make const.
* rendering/RenderFlexibleBox.h: Add a size_t to keep track of how many children are in the first line.

LayoutTests:

Add a new pixel test and mark the test as failing so we can get pixel results from the bots.

* css3/flexbox/flexbox-baseline.html: Added.
* platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.png: Added.
* platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.txt: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoString::remove will convert an 8 bit string to a 16 bit string
msaboff@apple.com [Thu, 4 Oct 2012 16:45:28 +0000 (16:45 +0000)]
String::remove will convert an 8 bit string to a 16 bit string
https://bugs.webkit.org/show_bug.cgi?id=98299

Reviewed by Benjamin Poulain.

Added an 8 bit path to remove().  Added a private templated helper removeInternal.

* wtf/text/WTFString.cpp:
(WTF::String::removeInternal):
(WTF::String::remove):
* wtf/text/WTFString.h:
(String):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Temporarily skip fast/xsl/xslt-missing-namespace-in-xslt.html.
rakuco@webkit.org [Thu, 4 Oct 2012 16:39:46 +0000 (16:39 +0000)]
[EFL] Temporarily skip fast/xsl/xslt-missing-namespace-in-xslt.html.

As bug 91009 shows, libxml 2.8.0 makes us produce a different test
result. Unskip the test for now until we add that version to
jhbuild.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Should set unitsPerEm in SimpleFontDataSkia.cpp
wangxianzhu@chromium.org [Thu, 4 Oct 2012 16:37:54 +0000 (16:37 +0000)]
[Chromium] Should set unitsPerEm in SimpleFontDataSkia.cpp
https://bugs.webkit.org/show_bug.cgi?id=98100

Reviewed by Stephen White.

Source/WebCore:

At least on chromium-linux and chromium-android, unitsPerEm was not set
according to the information in the font, causing at least problems in
OpenTypeVerticalData when calculating vertical advance.

Test: fast/writing-mode/vertical-font-vmtx-units-per-em.html

* platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformInit):

LayoutTests:

* fast/writing-mode/resources/DroidSansFallback-reduced.ttf: Added.
* fast/writing-mode/vertical-font-vmtx-units-per-em-expected.txt: Added.
* fast/writing-mode/vertical-font-vmtx-units-per-em.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Revert some wrong baselines added in r130387.
rakuco@webkit.org [Thu, 4 Oct 2012 16:24:59 +0000 (16:24 +0000)]
[EFL] Revert some wrong baselines added in r130387.

Thanks to Christophe Dumez and Mikhail Pozdnyakov for the help.

* platform/efl/compositing/visibility/visibility-simple-video-layer-expected.txt: Removed.
* platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStandardize on "flush" terminology for compositing layer flushing/syncing
simon.fraser@apple.com [Thu, 4 Oct 2012 16:16:19 +0000 (16:16 +0000)]
Standardize on "flush" terminology for compositing layer flushing/syncing
https://bugs.webkit.org/show_bug.cgi?id=98321

Reviewed by Simon Fraser.

Rename compositing-related methods that refer to "syncing" to instead
refer to "flushing".

Source/WebCore:

* WebCore.exp.in:
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::scheduleCompositingLayerFlush):
* page/ChromeClient.h:
(ChromeClient):
* page/FrameView.cpp:
(WebCore::FrameView::flushCompositingStateForThisFrame):
(WebCore::FrameView::flushCompositingStateIncludingSubframes):
(WebCore::FrameView::paintContents):
* page/FrameView.h:
(FrameView):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::scheduleLayerFlush):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

Source/WebKit/blackberry:

* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::scheduleCompositingLayerFlush):
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):

Source/WebKit/chromium:

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::scheduleCompositingLayerFlush):
* src/ChromeClientImpl.h:
(ChromeClientImpl):

Source/WebKit/efl:

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::scheduleCompositingLayerFlush):
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::scheduleCompositingLayerFlush):
* WebCoreSupport/ChromeClientGtk.h:
(ChromeClient):

Source/WebKit/mac:

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::scheduleCompositingLayerFlush):
* WebView/WebView.mm:
(-[WebView _flushCompositingChanges]):
(LayerFlushController::flushLayers):
(-[WebView _scheduleCompositingLayerFlush]):
* WebView/WebViewInternal.h:

Source/WebKit/qt:

* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::scheduleCompositingLayerFlush):
* WebCoreSupport/ChromeClientQt.h:
(ChromeClientQt):
* WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQGraphicsWidget::syncLayers):

Source/WebKit/win:

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::scheduleCompositingLayerFlush):
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
* WebView.cpp:
(WebView::flushPendingGraphicsLayerChanges):

Source/WebKit/wince:

* WebCoreSupport/ChromeClientWinCE.cpp:
(WebKit::ChromeClientWinCE::scheduleCompositingLayerFlush):
* WebCoreSupport/ChromeClientWinCE.h:
(ChromeClientWinCE):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::scheduleCompositingLayerFlush):
* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
* WebProcess/WebPage/DrawingArea.h:
(DrawingArea):
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::scheduleCompositingLayerFlush):
* WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::flushPendingLayerChanges):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerFlush):
(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):
(WebKit::TiledCoreAnimationDrawingArea::setPageOverlayNeedsDisplay):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add missing LLInt dependencies to the build system
ossy@webkit.org [Thu, 4 Oct 2012 16:13:07 +0000 (16:13 +0000)]
[Qt] Add missing LLInt dependencies to the build system
https://bugs.webkit.org/show_bug.cgi?id=98394

Reviewed by Geoffrey Garen.

* DerivedSources.pri:
* LLIntOffsetsExtractor.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: expose object internal properties such as PrimitiveValue or BoundThis
commit-queue@webkit.org [Thu, 4 Oct 2012 16:12:42 +0000 (16:12 +0000)]
Web Inspector: expose object internal properties such as PrimitiveValue or BoundThis
https://bugs.webkit.org/show_bug.cgi?id=94397

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-10-04
Reviewed by Yury Semikhatsky.

Source/WebCore:

Internal property access is built from Injected Script to V8 debug API. JSC binding
has a stub imlpementation. Protocol is updated to explicitly reflect internal properties.

Test: inspector-protocol/runtime-getProperties.html

* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::getInternalProperties):
(WebCore):
* bindings/v8/DebuggerScript.js:
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::getInternalProperties):
(WebCore):
* bindings/v8/ScriptDebugServer.h:
(ScriptDebugServer):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::getInternalPropertiesCallback):
(WebCore):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::getInternalProperties):
(WebCore):
* inspector/InjectedScript.h:
(InjectedScript):
* inspector/InjectedScriptHost.idl:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::getProperties):
* inspector/InspectorRuntimeAgent.h:
(InspectorRuntimeAgent):

LayoutTests:

A test is added to support new feature. Old test is updated because line number changed.

* inspector-protocol/runtime-getProperties-expected.txt: Added.
* inspector-protocol/runtime-getProperties.html: Added.
* inspector/console/command-line-api-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Update how we compile inspector front-end javascript.
kpiascik@rim.com [Thu, 4 Oct 2012 16:08:34 +0000 (16:08 +0000)]
[BlackBerry] Update how we compile inspector front-end javascript.
https://bugs.webkit.org/show_bug.cgi?id=98413

Reviewed by Rob Buis.

No longer cat all JavaScript together, instead use the lazy init and
only append our custom changes script to the end of inspectorBB.html.

* PlatformBlackBerry.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixed position visibility check does not consider descendants
commit-queue@webkit.org [Thu, 4 Oct 2012 15:57:50 +0000 (15:57 +0000)]
Fixed position visibility check does not consider descendants
https://bugs.webkit.org/show_bug.cgi?id=98144

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-10-04
Reviewed by Simon Fraser.

Source/WebCore:

The check against creating composition layers for invisible fixed positioned
elements is too aggressive in that it does not consider descendants of the
fixed positioned element that may be visible even though the element itself is
out of view.

Fix the problem by calculating the true composited bounds of the fixed
element instead of just using the size of the fixed layer. Because calculating
the true bounds may be expensive, it is only done if the fixed layer itself is
invisible.

Test: compositing/layer-creation/fixed-position-absolute-descendant.html

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
* rendering/RenderLayerCompositor.h:

LayoutTests:

Added a test for the fixed position layer visibility check.

* compositing/layer-creation/fixed-position-absolute-descendant-expected.txt: Added.
* compositing/layer-creation/fixed-position-absolute-descendant.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add setting to allow file access from file:// URLs
commit-queue@webkit.org [Thu, 4 Oct 2012 15:52:29 +0000 (15:52 +0000)]
[EFL][WK2] Add setting to allow file access from file:// URLs
https://bugs.webkit.org/show_bug.cgi?id=98121

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-04
Reviewed by Laszlo Gombos.

Source/WebKit2:

Add Ewk setting to set / query permission to access
files from file:// URLs.

* UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_file_access_from_file_urls_allowed_set):
(ewk_settings_file_access_from_file_urls_allowed_get):
* UIProcess/API/efl/ewk_settings.h:
* UIProcess/API/efl/tests/resources/local_file_access.html: Added.
* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F): Add unit tests for new ewk setting.

Tools:

Allow file access from file:// URLs by default in Minibrowser
to facilitate testing.

* MiniBrowser/efl/main.c:
(browserCreate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening after r130385. Skip some failing test.
kadam@inf.u-szeged.hu [Thu, 4 Oct 2012 15:47:13 +0000 (15:47 +0000)]
[Qt] Unreviewed gardening after r130385. Skip some failing test.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: When uiSourceCode content has diverged from VM script, call frames...
vsevik@chromium.org [Thu, 4 Oct 2012 15:32:08 +0000 (15:32 +0000)]
Web Inspector: When uiSourceCode content has diverged from VM script, call frames should be shown in temporary script based uiSourceCodes.
https://bugs.webkit.org/show_bug.cgi?id=98385

Reviewed by Pavel Feldman.

Source/WebCore:

When javaScriptSource diverges from VM, ResourceScriptMapping now switches debugging
to temporary VM scripts based uiSourceCode with isDivergedReplacement property set.
Added hasDivergedFromVM and isDivergingFromVM properties to JavaScriptSource.
JavaScriptSourceFrame and ScriptSnippetsModel are updated to process breakpoint changes correctly.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.restoreBreakpoints):
(WebInspector.BreakpointManager.prototype._uiSourceCodeRemoved):
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):
(WebInspector.JavaScriptSource.prototype.workingCopyChanged):
(WebInspector.JavaScriptSource.prototype.fireHasDivergedFromVMChanged):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
(WebInspector.JavaScriptSourceFrame.prototype._hasDivergedFromVM):
(WebInspector.JavaScriptSourceFrame.prototype.onTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._getBreakpointDecorations):
(WebInspector.JavaScriptSourceFrame.prototype._muteBreakpointsWhileEditing):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._restoreBreakpointsAfterEditing):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._hasDivergedFromVMChanged):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._getOrCreateTemporaryUISourceCode):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.ScriptSnippetModel.prototype._restoreBreakpoints):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.formatted):

LayoutTests:

* inspector/debugger/dynamic-script-tag-expected.txt:
* inspector/debugger/resource-script-mapping-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Exiting fullscreen does not set the correct scroll position (Part II)
tonikitoo@webkit.org [Thu, 4 Oct 2012 15:31:42 +0000 (15:31 +0000)]
[BlackBerry] Exiting fullscreen does not set the correct scroll position (Part II)
https://bugs.webkit.org/show_bug.cgi?id=97917
PR #212920

Reviewed by Yong Li.
Patch by Antonio Gomes <agomes@rim.com>
Internally reviewed by Jacky Jiang.

Inform the client of transform change so that we avoid
getting stuck on overscroll.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Scripts panel should not automatically switch to snippet evaluation...
vsevik@chromium.org [Thu, 4 Oct 2012 14:56:22 +0000 (14:56 +0000)]
Web Inspector: Scripts panel should not automatically switch to snippet evaluation when previously evaluated snippet is edited.
https://bugs.webkit.org/show_bug.cgi?id=98402

Reviewed by Pavel Feldman.

Scripts panel does not automatically switch to snippet evaluation when
one edits previously evaluated snippet.

* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Run unit tests with Xvfb
commit-queue@webkit.org [Thu, 4 Oct 2012 14:45:36 +0000 (14:45 +0000)]
[EFL] Run unit tests with Xvfb
https://bugs.webkit.org/show_bug.cgi?id=98389

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-04
Reviewed by Laszlo Gombos.

Source/WebKit2:

* UIProcess/API/efl/ewk_main.cpp:
(ewk_init): Call ecore_evas_shutdown() instead of
edje_shutdown() when ecore_x_init() fails.
(ewk_shutdown): Remove extra call to edje_shutdown().
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F): Temporarily disable fullscreen unit tests
until we get them working with Xvfb.

Tools:

Run EFL unit tests with Xvfb, similarly to GTK port.

* Scripts/run-efl-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago.: Don't allow to disable compositing in forced compositing mode
kbalazs@webkit.org [Thu, 4 Oct 2012 13:42:11 +0000 (13:42 +0000)]
.: Don't allow to disable compositing in forced compositing mode
https://bugs.webkit.org/show_bug.cgi?id=98048

Reviewed by Jocelyn Turcotte.

Export Settings::setAcceleratedCompositingEnabled because it has been deinlined.

* Source/autotools/symbols.filter:

Source/WebCore: Don't allow to disable compositing in forced compositing mode
https://bugs.webkit.org/show_bug.cgi?id=98048

Reviewed by Jocelyn Turcotte.

Make forced compositing mode imply accelerated compositing. This will
avoid unexpected situations for platforms that don't want to support
the non-accelerated rendering path.

Covered by existing tests.

* WebCore.exp.in: Export Settings::setAcceleratedCompositingEnabled
because it has been deinlined.
* page/Settings.cpp:
(WebCore::Settings::setAcceleratedCompositingEnabled):
(WebCore::Settings::setForceCompositingMode):
(WebCore):
* page/Settings.h:
(Settings):
(WebCore::Settings::forceCompositingMode): Make it const as a side fix.

Source/WebKit2: Don't allow compositing to be disabled in forced compositing mode
https://bugs.webkit.org/show_bug.cgi?id=98048

Reviewed by Jocelyn Turcotte.

Export Settings::setAcceleratedCompositingEnabled because it has been deinlined.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening after r130385. Skip a failing test.
kadam@inf.u-szeged.hu [Thu, 4 Oct 2012 13:20:05 +0000 (13:20 +0000)]
[Qt] Unreviewed gardening after r130385. Skip a failing test.
https://bugs.webkit.org/show_bug.cgi?id=62741

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Pixel test rebaselines to enable pixel testing on the bots, part 6.
rakuco@webkit.org [Thu, 4 Oct 2012 12:31:55 +0000 (12:31 +0000)]
[EFL] Pixel test rebaselines to enable pixel testing on the bots, part 6.

* platform/efl/compositing/reflections/animation-inside-reflection-expected.png:
* platform/efl/compositing/visibility/visibility-image-layers-expected.png: Added.
* platform/efl/compositing/visibility/visibility-simple-video-layer-expected.png: Added.
* platform/efl/compositing/visibility/visibility-simple-video-layer-expected.txt: Added.
* platform/efl/fast/forms/datalist/update-range-with-datalist-expected.png: Added.
* platform/efl/fast/selectors/unqualified-hover-strict-expected.png:
* platform/efl/fast/selectors/unqualified-hover-strict-expected.txt:
* platform/efl/fast/xsl/xslt-missing-namespace-in-xslt-expected.png:
* platform/efl/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
* platform/efl/fullscreen/full-screen-stacking-context-expected.png:
* platform/efl/fullscreen/full-screen-zIndex-after-expected.png:
* platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.png:
* platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.txt:
* platform/efl/http/tests/local/file-url-sent-as-referer-expected.png:
* platform/efl/http/tests/misc/frame-access-during-load-expected.png:
* platform/efl/http/tests/misc/iframe404-expected.png:
* platform/efl/http/tests/misc/slow-loading-image-in-pattern-expected.png:
* platform/efl/http/tests/uri/css-href-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
* platform/efl/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png:
* platform/efl/svg/filters/big-sized-filter-expected.png:
* platform/efl/svg/filters/feColorMatrix-saturate-expected.png: Added.
* platform/efl/svg/filters/feDropShadow-expected.png: Added.
* platform/efl/svg/filters/feGaussianBlur-expected.png:
* platform/efl/svg/filters/feImage-reference-svg-primitive-expected.png: Added.
* platform/efl/svg/filters/filterRes1-expected.png:
* platform/efl/svg/filters/filterRes3-expected.png:
* platform/efl/svg/filters/shadow-on-rect-with-filter-expected.png:
* platform/efl/svg/repaint/inner-svg-change-viewBox-contract-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Enable inspector by default in GtkLauncher/MiniBrowser
commit-queue@webkit.org [Thu, 4 Oct 2012 12:24:02 +0000 (12:24 +0000)]
[GTK] Enable inspector by default in GtkLauncher/MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=98333

Patch by Adrian Perez de Castro <aperez@igalia.com> on 2012-10-04
Reviewed by Xan Lopez.

Both MiniBrowser and GtkLauncher are tools for testing, so in
the end every time we want to test the inspector we have to
manually enable enable the “developer extras” setting when using
them. It make sense to have this setting enabled by default.

* GtkLauncher/main.c:
(main):
* MiniBrowser/gtk/main.c:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Reviewing old bugs in Qt TestExpectations. Unskip now passing test.
kadam@inf.u-szeged.hu [Thu, 4 Oct 2012 12:23:38 +0000 (12:23 +0000)]
[Qt] Reviewing old bugs in Qt TestExpectations. Unskip now passing test.

* platform/qt-5.0-wk1/TestExpectations:
* platform/qt-5.0-wk2/TestExpectations:
* platform/qt/TestExpectations:
* platform/qt/editing/pasteboard/smart-paste-008-expected.txt:
* platform/qt/http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object-expected.txt: Added.
* platform/qt/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Mark perf/show-hide-table-rows.html as flaky.
yurys@chromium.org [Thu, 4 Oct 2012 12:18:46 +0000 (12:18 +0000)]
Unreviewed. Mark perf/show-hide-table-rows.html as flaky.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange RTCPeerConnection GetStats to use Date timestamp format
commit-queue@webkit.org [Thu, 4 Oct 2012 11:06:29 +0000 (11:06 +0000)]
Change RTCPeerConnection GetStats to use Date timestamp format
https://bugs.webkit.org/show_bug.cgi?id=98263

Patch by Harald Alvestrand <hta@google.com> on 2012-10-04
Reviewed by Yury Semikhatsky.

Source/Platform:

* chromium/public/WebRTCStatsResponse.h:
(WebRTCStatsResponse):

Source/WebCore:

Tested by extension to RTCPeerConnection-stats test.

* Modules/mediastream/RTCStatsElement.cpp:
(WebCore::RTCStatsElement::create):
(WebCore::RTCStatsElement::RTCStatsElement):
* Modules/mediastream/RTCStatsElement.h: long -> double
(RTCStatsElement):
(WebCore::RTCStatsElement::timestamp):
* Modules/mediastream/RTCStatsElement.idl: long -> Date
* Modules/mediastream/RTCStatsReport.cpp:
(WebCore::RTCStatsReport::addElement):
* Modules/mediastream/RTCStatsReport.h:
(RTCStatsReport):
* Modules/mediastream/RTCStatsResponse.cpp:
(WebCore::RTCStatsResponse::addElement):
* Modules/mediastream/RTCStatsResponse.h:
(RTCStatsResponse):
* platform/chromium/support/WebRTCStatsResponse.cpp:
(WebKit::WebRTCStatsResponse::addElement):
* platform/mediastream/RTCStatsResponseBase.h:
(RTCStatsResponseBase):

Tools:

* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::getStats):

LayoutTests:

* fast/mediastream/RTCPeerConnection-stats-expected.txt:
* fast/mediastream/RTCPeerConnection-stats.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix the tst_QQuickWebView::scrollRequest auto test
jocelyn.turcotte@digia.com [Thu, 4 Oct 2012 10:43:49 +0000 (10:43 +0000)]
[Qt] Fix the tst_QQuickWebView::scrollRequest auto test
https://bugs.webkit.org/show_bug.cgi?id=98045

Reviewed by Simon Hausmann.

Relying on QQuickWebViewPrivate::setNeedsDisplay can cause a false positive
emission of the loadVisuallyCommitted signal since this method is also
called when a layer is deleted or when the root layer changes.

Move the signal emission to QQuickWebViewPrivate::didRenderFrame which
is called only after a DidRenderFrame message has been received from the
web process.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::setNeedsDisplay):
(QQuickWebViewPrivate::didRenderFrame):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/qt/QtPageClient.cpp:
(WebKit::QtPageClient::didRenderFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[NRWT] --skipped option is ignored when --test-list is used
dpranke@chromium.org [Thu, 4 Oct 2012 10:18:54 +0000 (10:18 +0000)]
[NRWT] --skipped option is ignored when --test-list is used
https://bugs.webkit.org/show_bug.cgi?id=98260

Reviewed by Ojan Vafai.

Adds a --skipped=always flag that will skip any tests listed in
TestExpectations even if they're listed explicitly on the
command line.

This is most useful if you are using --test-list to specify a
long list of files but you still want to skip some of them
depending on what's in TestExpectations.

* Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
(LayoutTestFinder.skip_tests):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_skipped_flag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r130377.
commit-queue@webkit.org [Thu, 4 Oct 2012 10:08:00 +0000 (10:08 +0000)]
Unreviewed, rolling out r130377.
http://trac.webkit.org/changeset/130377
https://bugs.webkit.org/show_bug.cgi?id=98392

Chromium Win compilation is broken (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-04

Source/Platform:

* chromium/public/WebRTCStatsResponse.h:
(WebRTCStatsResponse):

Source/WebCore:

* Modules/mediastream/RTCStatsElement.cpp:
(WebCore::RTCStatsElement::create):
(WebCore::RTCStatsElement::RTCStatsElement):
* Modules/mediastream/RTCStatsElement.h:
(RTCStatsElement):
(WebCore::RTCStatsElement::timestamp):
* Modules/mediastream/RTCStatsElement.idl:
* Modules/mediastream/RTCStatsReport.cpp:
(WebCore::RTCStatsReport::addElement):
* Modules/mediastream/RTCStatsReport.h:
(RTCStatsReport):
* Modules/mediastream/RTCStatsResponse.cpp:
(WebCore::RTCStatsResponse::addElement):
* Modules/mediastream/RTCStatsResponse.h:
(RTCStatsResponse):
* platform/chromium/support/WebRTCStatsResponse.cpp:
(WebKit::WebRTCStatsResponse::addElement):
* platform/mediastream/RTCStatsResponseBase.h:
(RTCStatsResponseBase):

Tools:

* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::getStats):

LayoutTests:

* fast/mediastream/RTCPeerConnection-stats-expected.txt:
* fast/mediastream/RTCPeerConnection-stats.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSome picker test for input[type=date] are failing
tkent@chromium.org [Thu, 4 Oct 2012 09:51:44 +0000 (09:51 +0000)]
Some picker test for input[type=date] are failing
https://bugs.webkit.org/show_bug.cgi?id=98390

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Fix an error in TestExpectations.
tkent@chromium.org [Thu, 4 Oct 2012 09:24:37 +0000 (09:24 +0000)]
[Chromium] Fix an error in TestExpectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange RTCPeerConnection GetStats to use Date timestamp format
commit-queue@webkit.org [Thu, 4 Oct 2012 09:14:57 +0000 (09:14 +0000)]
Change RTCPeerConnection GetStats to use Date timestamp format
https://bugs.webkit.org/show_bug.cgi?id=98263

Patch by Harald Alvestrand <hta@google.com> on 2012-10-04
Reviewed by Adam Barth.

Source/Platform:

* chromium/public/WebRTCStatsResponse.h:
(WebRTCStatsResponse):

Source/WebCore:

Tested by extension to RTCPeerConnection-stats test.

* Modules/mediastream/RTCStatsElement.cpp:
(WebCore::RTCStatsElement::create):
(WebCore::RTCStatsElement::RTCStatsElement):
* Modules/mediastream/RTCStatsElement.h: long -> double
(RTCStatsElement):
(WebCore::RTCStatsElement::timestamp):
* Modules/mediastream/RTCStatsElement.idl: long -> Date
* Modules/mediastream/RTCStatsReport.cpp:
(WebCore::RTCStatsReport::addElement):
* Modules/mediastream/RTCStatsReport.h:
(RTCStatsReport):
* Modules/mediastream/RTCStatsResponse.cpp:
(WebCore::RTCStatsResponse::addElement):
* Modules/mediastream/RTCStatsResponse.h:
(RTCStatsResponse):
* platform/chromium/support/WebRTCStatsResponse.cpp:
(WebKit::WebRTCStatsResponse::addElement):
* platform/mediastream/RTCStatsResponseBase.h:
(RTCStatsResponseBase):

Tools:

* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::getStats):

LayoutTests:

* fast/mediastream/RTCPeerConnection-stats-expected.txt:
* fast/mediastream/RTCPeerConnection-stats.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate tests for input[type=date] with the multiple fields UI
tkent@chromium.org [Thu, 4 Oct 2012 09:01:12 +0000 (09:01 +0000)]
Update tests for input[type=date] with the multiple fields UI
https://bugs.webkit.org/show_bug.cgi?id=98386

Reviewed by Hajime Morita.

Remove some tests for input[type=date. They depends on the old UI, which
we don't use any more.
Mark some tests fail. We need to update their results later.

* fast/forms/date/date-appearance.html: Removed.
* fast/forms/date/date-fixed-placeholder-expected.txt: Removed.
* fast/forms/date/date-fixed-placeholder.html: Removed.
* fast/forms/date/date-input-visible-strings-expected.txt: Removed.
* fast/forms/date/date-input-visible-strings.html: Removed.
* fast/forms/date/input-date-commit-valid-only-expected.txt: Removed.
* fast/forms/date/input-date-commit-valid-only.html: Removed.
* platform/chromium-linux/fast/forms/date/date-appearance-expected.png: Removed.
* platform/chromium-linux/fast/forms/date/date-appearance-expected.txt: Removed.
* platform/chromium-linux/fast/forms/date/date-input-visible-strings-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.png: Removed.
* platform/chromium-mac/fast/forms/date/date-appearance-expected.png: Removed.
* platform/chromium-mac/fast/forms/date/date-appearance-expected.txt: Removed.
* platform/chromium-win/fast/forms/date/date-appearance-expected.png: Removed.
* platform/chromium-win/fast/forms/date/date-appearance-expected.txt: Removed.
* platform/chromium-win/fast/forms/date/date-input-visible-strings-expected.txt: Removed.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/date/date-input-visible-strings-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Enable the multiple fields UI for input[type=date]
tkent@chromium.org [Thu, 4 Oct 2012 08:59:20 +0000 (08:59 +0000)]
[Chromium] Enable the multiple fields UI for input[type=date]
https://bugs.webkit.org/show_bug.cgi?id=98351

Reviewed by Hajime Morita.

Source/WebCore:

Touch files related to ENABLE_INPUT_TYPE_DATE_LEGACY_UI to avoid build
issues.

No new tests. Many tests will be landed shortly.

* html/DateInputType.cpp:
* html/DateInputType.h:

Source/WebKit/chromium:

* features.gypi:
Disable ENABLE_INPUT_TYPE_DATE_LEGACY_UI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] webintents/web-intents-failure.html is failing
commit-queue@webkit.org [Thu, 4 Oct 2012 08:58:24 +0000 (08:58 +0000)]
[EFL] webintents/web-intents-failure.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98349

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-04
Reviewed by Gyuyoung Kim.

After r130344, OpaqueJSString().string() returns
an empty string instead of a null one. Therefore,
we need to update the check in
DumpRenderTreeSupportEfl::sendWebIntentResponse().

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::sendWebIntentResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression(r130363): Broke unit tests
commit-queue@webkit.org [Thu, 4 Oct 2012 08:50:14 +0000 (08:50 +0000)]
Regression(r130363): Broke unit tests
https://bugs.webkit.org/show_bug.cgi?id=98341

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-04
Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Fix WebKitEFL unit tests to use X11 as
well.

* tests/UnitTestUtils/EWKTestBase.cpp:
(EWKUnitTests::EWKTestBase::SetUp):
* tests/UnitTestUtils/EWKTestEnvironment.h:
(EWKTestEnvironment):
* tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestView::init):
* tests/UnitTestUtils/EWKTestView.h:
(EWKTestView):

Source/WebKit2:

Fix WebKit2 EFL to use X11 as well.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::SetUp):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:
(EWK2UnitTest::EWK2UnitTestEnvironment::EWK2UnitTestEnvironment):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
(EWK2UnitTestEnvironment):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp:
(main):
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(checkFullScreenProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, remove unused $legacyWebKitBlobBuilderSupport variable after r130343.
rakuco@webkit.org [Thu, 4 Oct 2012 08:46:01 +0000 (08:46 +0000)]
Unreviewed, remove unused $legacyWebKitBlobBuilderSupport variable after r130343.

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] css2.1/20110323/text-indent-intrinsic-00* fail
commit-queue@webkit.org [Thu, 4 Oct 2012 08:09:41 +0000 (08:09 +0000)]
[Qt] css2.1/20110323/text-indent-intrinsic-00* fail
https://bugs.webkit.org/show_bug.cgi?id=91772

Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-04
Reviewed by Yuta Kitamura.

Unskip some tests that are passing.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 4 Oct 2012 07:59:25 +0000 (07:59 +0000)]
Unreviewed GTK gardening.

Adding proper bug modifiers for accessibility failures that don't yet have one.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd code for input[type=date] with the multiple fields UI
tkent@chromium.org [Thu, 4 Oct 2012 07:49:58 +0000 (07:49 +0000)]
Add code for input[type=date] with the multiple fields UI
https://bugs.webkit.org/show_bug.cgi?id=98340

Reviewed by Hajime Morita.

Source/WebCore:

The new code is available if !ENABLE(INPUT_TYPE_DATE_LEGACY_UI). At this
moment, there are no platforms enabling the new code. We're going to
enable it soon on desktop Chromium, and add tests. Then we're going to
remove the code for ENABLE(INPUT_TYPE_DATE_LEGACY_UI).

ENABLE(INPUT_TYPE_DATE_LEGACY_UI) means the current UI; input[type=date]
is represetnted as a kind of text field, and it has code to invoke a
calendar picker.
ENABLE(CALENDAR_PICKER) was used wrongly. It meant calendar picker
support + text field UI of input[type=date]. Now it means only calendar
picker support.

* html/DateInputType.h:
(WebCore): If ENABLE(INPUT_MULTIPLE_FIELDS_UI) &&
!ENABLE(INPUT_TYPE_DATE_LEGACY_UI), change the base class to the class
for multiple fields UI.
(DateInputType): Wrap the code for text fields behavior and calendar
picker UI with ENABLE(INPUT_TYPE_DATE_LEGACY_UI). Add functions for
ENABLE(INPUT_MULTIPLE_FIELDS_UI)
* html/DateInputType.cpp:
(WebCore::DateInputType::DateInputType):
Change the flag name; CALENDAR_PICKER -> INPUT_TYPE_DATE_LEGACY_UI
(WebCore): ditto.
(WebCore::DateInputType::formatDateTimeFieldsState):
A callback for multiple fields UI. This constructs a string value from
each of values of multiple fields.
Note that we don't need to do +1 to month().
(WebCore::DateInputType::setupLayoutParameters):
A callback for multiple fields UI. Passes information to build UI.

* html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):
Add m_pickerIndicatorIsAlwaysVisible member, wrap some members with flags.
* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType):
Initialize m_pickerIndicatorIsAlwaysVisible.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
If a type supports calendar picker, we should always show the picker
indicator. We introduce m_pickerIndicatorIsAlwaysVisible flag, and ask
RenderTheme for support status of each of types.
Add a local variable 'document' to avoid multiple element()->document().
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility):
- If m_pickerIndicatorIsAlwaysVisible, don't hide the picker indicator element.
- Wrap the code with appropriate flags.

* rendering/RenderTheme.h:
(WebCore::RenderTheme::supportsCalendarPicker): Added.
* rendering/RenderThemeChromiumMac.h: Override supportsCalendarPicker.
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::supportsCalendarPicker):
Added. Delegate to RenderThemeChromiumCommon.
* rendering/RenderThemeChromiumSkia.h: Override supportsCalendarPicker.
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::supportsCalendarPicker):
Added. Delegate to RenderThemeChromiumCommon.
* rendering/RenderThemeChromiumCommon.h:
(RenderThemeChromiumCommon): Declare supportsCalendarPicker.
* rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsCalendarPicker):
Returns true if the type is "date."

* html/DateTimeFieldsState.h:
(DateTimeFieldsState): Add a comment for the m_month field.

Source/WebKit/chromium:

* features.gypi: Add ENABLE_INPUT_TYPE_DATE_LEGACY_UI=1 for non-Android.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved duplicate entries introduced by r130355
yurys@chromium.org [Thu, 4 Oct 2012 07:27:05 +0000 (07:27 +0000)]
Removed duplicate entries introduced by r130355

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Unreviewed gardening, skip new crashing tests to paint the bot green.
ossy@webkit.org [Thu, 4 Oct 2012 07:12:04 +0000 (07:12 +0000)]
[Qt][WK2] Unreviewed gardening, skip new crashing tests to paint the bot green.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoForce GC between PageLoad tests.
pdr@google.com [Thu, 4 Oct 2012 06:29:45 +0000 (06:29 +0000)]
Force GC between PageLoad tests.
https://bugs.webkit.org/show_bug.cgi?id=98203

Reviewed by Ryosuke Niwa.

Previously, our PageLoad PerfTests had multi-modal distributions,
typically with a small cluster at 1-2x the median. This turned out
to be caused by not garbage collecting between tests!

This patch adds a new file, force-gc.html, and loads this file between
PageLoad tests to force a GC. I manually verified that this cleans up
our perf test outliers.

PerformanceTests:

* resources/force-gc.html: Added.

Tools:

* Scripts/webkitpy/performance_tests/perftest.py:
(PageLoadingPerfTest.__init__):
(PageLoadingPerfTest):
(PageLoadingPerfTest.run_single):

    This function now loads two pages: one to force a gc and
    then the test to run.

* Scripts/webkitpy/performance_tests/perftest_unittest.py:

    Modified several existing tests to show that the force-gc file
    is loaded.

(MockPort):
(MockPort.__init__):
(MockPort.perf_tests_dir):
(TestPageLoadingPerfTest.MockDriver.__init__):
(TestPageLoadingPerfTest.MockDriver.run_test):
(TestPageLoadingPerfTest.test_run):
(TestPageLoadingPerfTest.test_run_with_bad_output):
(TestReplayPerfTest.ReplayTestPort):
(TestReplayPerfTest.ReplayTestPort.__init__):
(TestReplayPerfTest.test_run_single.run_test):
(TestReplayPerfTest.test_run_single):
(TestReplayPerfTest.test_run_single_fails_when_output_has_error):
(TestPerfTestFactory.test_regular_test):
(TestPerfTestFactory.test_inspector_test):
(TestPerfTestFactory.test_page_loading_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Refactoring] Tidy NDEBUG optioning in RefCountedBase.
commit-queue@webkit.org [Thu, 4 Oct 2012 06:21:57 +0000 (06:21 +0000)]
[Refactoring] Tidy NDEBUG optioning in RefCountedBase.
https://bugs.webkit.org/show_bug.cgi?id=98252

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-03
Reviewed by Benjamin Poulain.

Fixed incomplete implementation for NDEBUG option.
Additionally, adopted CHECK_REF_COUNTED_LIFECYCLE definition to suppress abusing NDEBUG option.

* wtf/RefCounted.h:
(WTF):
(WTF::RefCountedBase::ref):
(WTF::RefCountedBase::hasOneRef):
(WTF::RefCountedBase::refCount):
(WTF::RefCountedBase::turnOffVerifier):
(WTF::RefCountedBase::relaxAdoptionRequirement):
(WTF::RefCountedBase::RefCountedBase):
(WTF::RefCountedBase::~RefCountedBase):
(WTF::RefCountedBase::derefBase):
(RefCountedBase):
(WTF::adopted):
(WTF::RefCountedBase::setMutexForVerifier):
(WTF::RefCountedBase::setDispatchQueueForVerifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Default.edj should be generated although ENABLE_WEBKIT disabled.
ryuan.choi@samsung.com [Thu, 4 Oct 2012 05:46:28 +0000 (05:46 +0000)]
[EFL] Default.edj should be generated although ENABLE_WEBKIT disabled.
https://bugs.webkit.org/show_bug.cgi?id=97753

Reviewed by Laszlo Gombos.

default.edj is used in both webkit/efl and webkit2/efl.
However, it has been generated only when ENABLE_WEBKIT is enabled.

This patch separates the script which generates default.edj
from source/webkit/platformefl.cmake.

.:

* Source/CMakeLists.txt:
* Source/PlatformEfl.cmake: Added to generate custom target for default theme.
* Source/cmake/OptionsEfl.cmake:
Moved directory generation from WebKit/PlatformEfl.cmake
because THEME_BINARY_DIR is used for both Default Theme and control theme in Tools.

Source/WebKit:

* PlatformEfl.cmake: Extracted codes which is related to default.edj.

Source/WebKit/efl:

* DefaultTheme/CMakeLists.txt:
Extracted from Source/WebKit/PlatformEfl.cmake and sanitized.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Enable use of X11 in DumpRenderTree / WebKitTestRunner
commit-queue@webkit.org [Thu, 4 Oct 2012 05:42:45 +0000 (05:42 +0000)]
[EFL] Enable use of X11 in DumpRenderTree / WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=98231

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-03
Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Initialize ecore_x library in ewk_main since it is used by
WebKitEFL.

* ewk/ewk_main.cpp:
(ewk_init):
(ewk_shutdown):

Source/WebKit2:

Initialize ecore_x library in ewk_main instead of
WebKitTestRunner since WebKit is using ecore_x
not WebKitTestRunner itself.

* UIProcess/API/efl/ewk_main.cpp:
(ewk_init):
(ewk_shutdown):

Tools:

Enable use of X11 in DumpRenderTree / WebKitTestRunner.
Call ecore_evas_new() instead of ecore_evas_buffer_new()
in EFL's DumpRenderTree and WebKitTestRunner.
It is safe to do this now that we are using XvfbDriver
for the layout tests.

* DumpRenderTree/efl/DumpRenderTree.cpp:
(parseCommandLineOptions):
(initEcoreEvas):
* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::initEcoreEvas):
* WebKitTestRunner/efl/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDateTimeYearFieldElement should respect min/max values specified by page authors
tkent@chromium.org [Thu, 4 Oct 2012 04:32:42 +0000 (04:32 +0000)]
DateTimeYearFieldElement should respect min/max values specified by page authors
https://bugs.webkit.org/show_bug.cgi?id=98227

Reviewed by Hajime Morita.

Source/WebCore:

Before this patch, we always set 1 to the minimum limit and 275760 to
the maximum limit for a year field, and a user can specify any year
regardless of min/max attributes. Such wide range is unnecessary for
normal applications and we should provide a way to limit the range.

Test: fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html

* html/shadow/DateTimeFieldElements.h:
To add four constructor arguments, introduce Parameters struct.
Actually, we add the followings;
 - minimum year in UI
 - maximum year in UI
 - min attribute is specified
 - max attribute is specified
(Parameters):
(WebCore::DateTimeYearFieldElement::Parameters::Parameters):
(DateTimeYearFieldElement):
* html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeYearFieldElement::DateTimeYearFieldElement): ditto.
(WebCore::DateTimeYearFieldElement::create): ditto.
(WebCore::DateTimeYearFieldElement::clampValueForHardLimits):
Override DateTimeNumericFieldElement::clampValueForHardLimits.
By this, we allow to set out-of-range year values.
(WebCore::currentFullYear): A helper to get the current year.
(WebCore::DateTimeYearFieldElement::defaultValueForStepDown):
If the field has no value and step down operation occurs,
 - the field has the current year if the max attribute is not specified.
 - the field has the maximum value otherwise.
(WebCore::DateTimeYearFieldElement::defaultValueForStepUp): Similar change.

* html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement): Declare clampValueForHardLimits.
* html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::clampValueForHardLimits):
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):
Call clampValueForHardLimits instead of clampValue in order to
distinguish limits for UI and limits for internal value update.

* html/shadow/DateTimeEditElement.h:
(LayoutParameters): Add minimumYear and maximumYear members.
(WebCore::DateTimeEditElement::LayoutParameters::LayoutParameters):
Initialize minimumYear and maximumYear.
(WebCore::DateTimeEditElement::LayoutParameters::undefinedYear):
Represents 'undefined' value for minimumYear and maximumYear.
* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitField):
Preparas DateTimeYearField::Parameters and pass it to the DateTimeYearField factory.

* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::fullYear):
A helper to get a year value from an attribute value string.
* html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType): Add fullYear().

* html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::setupLayoutParameters):
Set LayoutParameters::minimumYear and maximumYear.
* html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::setupLayoutParameters): ditto.
* html/MonthInputType.cpp:
(WebCore::MonthInputType::setupLayoutParameters): ditto.
* html/WeekInputType.cpp:
(WebCore::WeekInputType::setupLayoutParameters): ditto.

LayoutTests:

* fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt: Added.
* fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-10-03 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 4 Oct 2012 04:28:57 +0000 (04:28 +0000)]
2012-10-03  Geoffrey Garen  <ggaren@apple.com>

        Next step toward fixing Windows: add new symbol.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-10-03 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 4 Oct 2012 04:12:44 +0000 (04:12 +0000)]
2012-10-03  Geoffrey Garen  <ggaren@apple.com>

        First step toward fixing Windows: remove old symbol.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved the assumption that "final" objects have a fixed number of inline slots
ggaren@apple.com [Thu, 4 Oct 2012 04:03:14 +0000 (04:03 +0000)]
Removed the assumption that "final" objects have a fixed number of inline slots
https://bugs.webkit.org/show_bug.cgi?id=98332

Reviewed by Filip Pizlo.

This is a step toward object size inference.

I replaced the inline storage capacity constant with a data member per
structure, set the the maximum supported value for the constant to 100,
then fixed what broke. (Note that even though this patch increases the
theoretical maximum inline capacity, it doesn't change any actual inline
capacity.)

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetDirectOffset): These functions just get a rename:
the constant they need is the first out of line offset along the offset
number line, which is not necessarily the same thing (and is, in this
patch, never the same thing) as the inline capacity of any given object.

(JSC::JIT::emit_op_get_by_pname):
* jit/JITPropertyAccess32_64.cpp: This function changes functionality,
since it needs to convert from the abstract offset number line to an
actual offset in memory, and it can't assume that inline and out-of-line
offsets are contiguous on the number line.

(JSC::JIT::compileGetDirectOffset): Updated for rename.

(JSC::JIT::emit_op_get_by_pname): Same as emit_op_get_by_pname above.

* llint/LowLevelInterpreter.asm: Updated to mirror changes in PropertyOffset.h,
since we duplicate values from there.

* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm: Just like the JIT, most things are just
renames, and get_by_pname changes to do more math. I also standardized
offset calculations to use a hard-coded "-2", to match the JIT. This
isn't really better, but it makes global search and replace easier,
should we choose to refactor this code not to hard-code constants.

I also renamed loadPropertyAtVariableOffsetKnownNotFinal to
loadPropertyAtVariableOffsetKnownNotInline in order to sever the assumption
that inline capacity is tied to object type, and I changed the 64bit LLInt
to use this -- not using this previously seems to have been an oversight.

* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren):
(JSC::JSFinalObject::visitChildren):
* runtime/JSObject.h:
(JSC::JSObject::offsetForLocation):
(JSNonFinalObject):
(JSC::JSFinalObject::createStructure):
(JSFinalObject):
(JSC::JSFinalObject::finishCreation): Updated for above changes.

* runtime/JSPropertyNameIterator.h:
(JSPropertyNameIterator):
(JSC::JSPropertyNameIterator::finishCreation): Store the inline capacity
of our object, since it's not a constant.

(JSC::JSPropertyNameIterator::getOffset): Removed. This function was
wrong. Luckily, it was also unused, since the C++ interpreter is gone.

* runtime/PropertyMapHashTable.h:
(PropertyTable): Use a helper function instead of hard-coding assumptions
about object types.

(JSC::PropertyTable::nextOffset):
* runtime/PropertyOffset.h:
(JSC):
(JSC::checkOffset):
(JSC::validateOffset):
(JSC::isInlineOffset):
(JSC::numberOfSlotsForLastOffset):
(JSC::propertyOffsetFor): Refactored these functions to take inline capacity
as an argument, since it's not fixed at compile time anymore.

* runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::putSpecificValue):
* runtime/Structure.h:
(Structure):
(JSC::Structure::outOfLineCapacity):
(JSC::Structure::hasInlineStorage):
(JSC::Structure::inlineCapacity):
(JSC::Structure::inlineSize):
(JSC::Structure::firstValidOffset):
(JSC::Structure::lastValidOffset):
(JSC::Structure::create): Removed some hard-coded assumptions about inline
capacity and object type, and replaced with more liberal use of helper functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix parse error in vcproj file.
abarth@webkit.org [Thu, 4 Oct 2012 03:42:50 +0000 (03:42 +0000)]
Unreviewed. Fix parse error in vcproj file.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement localizeValue for TimeInputType
keishi@webkit.org [Thu, 4 Oct 2012 03:36:42 +0000 (03:36 +0000)]
Implement localizeValue for TimeInputType
https://bugs.webkit.org/show_bug.cgi?id=98237

Reviewed by Kent Tamura.

Source/WebCore:

We want to localize time values for the suggestion picker.
DateTimeStringBuilder parses a format and creates a formatted string.

Added chromium unit test LocaleMacTest.formatTime

* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldHaveSecondField): Moved from LayoutParameters because we want to use it inside localizeValue.
(WebCore):
* html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):
* html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::setupLayoutParameters):
* html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::setupLayoutParameters):
* html/TimeInputType.cpp:
(WebCore::TimeInputType::localizeValue):
(WebCore):
(WebCore::TimeInputType::setupLayoutParameters):
* html/TimeInputType.h:
(TimeInputType):
* html/shadow/DateTimeEditElement.cpp:
(WebCore):
* html/shadow/DateTimeEditElement.h:
(WebCore::DateTimeEditElement::LayoutParameters::LayoutParameters):
* platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::formatDateTime): Calls Localizer::formatDateTime if the date component is not a date.
* platform/text/LocaleICU.h:
(LocaleICU):
* platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::formatDateTime): Calls Localizer::formatDateTime if the date component is not a date.
* platform/text/LocaleWin.h:
(LocaleWin):
* platform/text/LocaleNone.cpp:
(LocaleNone):
(WebCore::LocaleNone::formatDateTime):
* platform/text/Localizer.cpp:
(DateTimeStringBuilder):
(WebCore):
(WebCore::DateTimeStringBuilder::DateTimeStringBuilder): Takes a
Localizer pointer. This is used inside the Localizer so the Localizer
will out live the DateTimeStringBuilder.
(WebCore::DateTimeStringBuilder::build): Builds a localized string for the given format.
(WebCore::DateTimeStringBuilder::zeroPadString):
(WebCore::DateTimeStringBuilder::appendNumber): Appends a number with left zero padding to match width.
(WebCore::DateTimeStringBuilder::visitField):
(WebCore::DateTimeStringBuilder::visitLiteral):
(WebCore::DateTimeStringBuilder::toString): Returns the localized string.
(WebCore::Localizer::formatDateTime):
* platform/text/Localizer.h:
* platform/text/mac/LocaleMac.h:
(LocaleMac):
* platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::formatDateTime): Calls Localizer::formatDateTime if the date component is not a date.

Source/WebKit/chromium:

* tests/LocaleMacTest.cpp:
(LocaleMacTest::timeComponents):
(LocaleMacTest):
(LocaleMacTest::formatTime): Tests formatDateTime() for time.
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorun-webkit-tests tests on win32 after r127302
dpranke@chromium.org [Thu, 4 Oct 2012 02:53:21 +0000 (02:53 +0000)]
run-webkit-tests tests on win32 after r127302
https://bugs.webkit.org/show_bug.cgi?id=98323

Reviewed by Eric Seidel.

run-webkit-tests tests on win32 after r127302
https://bugs.webkit.org/show_bug.cgi?id=98323

Reviewed by Eric Seidel.

Looks like when we converted the json-building logic to use scm
to try and get the svn revision, we missed a win32-ism and
didn't check to make sure had initialized the scm subsystem.

This change fixes that and renames _initialize_scm to be a public method.

* Scripts/webkitpy/common/host.py:
(Host.initialize_scm):
* Scripts/webkitpy/common/host_mock.py:
(MockHost.__init__):
(MockHost.initialize_scm):
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(summarize_results):
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGeneratorBase.get_json):
(JSONResultsGeneratorBase._get_result_char):
(JSONResultsGeneratorBase._get_svn_revision):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.__init__):
* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker.__init__):
* Scripts/webkitpy/style/main.py:
(CheckWebKitStyle.main):
* Scripts/webkitpy/tool/main.py:
(WebKitPatch.handle_global_options):
* Scripts/webkitpy/tool/servers/rebaselineserver.py:
(get_test_baselines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium needs support for border radius clipping
commit-queue@webkit.org [Thu, 4 Oct 2012 02:17:34 +0000 (02:17 +0000)]
Chromium needs support for border radius clipping
https://bugs.webkit.org/show_bug.cgi?id=69866

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-10-03
Reviewed by Stephen White.

Source/WebCore:

Changes to make this suitably efficient have already landed upstream in skia:
http://code.google.com/p/skia/source/detail?r=2924

Covered by existing tests.

* rendering/RenderLayer.cpp:

LayoutTests:

* platform/chromium-linux/fast/clip/overflow-border-radius-combinations-expected.png:
* platform/chromium-linux/fast/clip/overflow-border-radius-fixed-position-expected.png:
* platform/chromium-linux/fast/clip/overflow-border-radius-transformed-expected.png:
* platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium-linux/media/audio-controls-rendering-expected.png:
* platform/chromium-linux/media/audio-repaint-expected.png:
* platform/chromium-linux/media/controls-after-reload-expected.png:
* platform/chromium-linux/media/controls-strict-expected.png:
* platform/chromium-linux/media/controls-styling-expected.png:
* platform/chromium-linux/media/controls-styling-strict-expected.png:
* platform/chromium-linux/media/controls-without-preload-expected.png:
* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
* platform/chromium-linux/media/video-controls-rendering-expected.png:
* platform/chromium-linux/media/video-display-toggle-expected.png:
* platform/chromium-linux/media/video-no-audio-expected.png:
* platform/chromium-linux/media/video-playing-and-pause-expected.png:
* platform/chromium-linux/media/video-zoom-controls-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSimplify attribute access in Element::computeInheritedLanguage
benjamin@webkit.org [Thu, 4 Oct 2012 01:53:31 +0000 (01:53 +0000)]
Simplify attribute access in Element::computeInheritedLanguage
https://bugs.webkit.org/show_bug.cgi?id=98327

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-10-03
Reviewed by Andreas Kling.

* dom/Element.cpp:
(WebCore::Element::computeInheritedLanguage):
By using Element::fastGetAttribute(), we check for the existence of attributeData twice
and do a bunch of useless operation on AtomicString.

By using ElementAttributeData directly, we can cut it to the two important branch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix unused parameter compile warnings.
commit-queue@webkit.org [Thu, 4 Oct 2012 01:50:11 +0000 (01:50 +0000)]
Fix unused parameter compile warnings.
https://bugs.webkit.org/show_bug.cgi?id=98243

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-03
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Fixed unused parameter compile warning by removing parameter names and adding UNUSED_PARAM usage.

* plugins/PluginDebug.cpp:
(WebCore::prettyNameForNPPVariable):
* plugins/npapi.cpp:
(NPN_MemFlush):
(NPN_RequestRead):
(NPN_GetJavaPeer):

Source/WebKit/efl:

Fixed unused parameter compile warning by removing page parameter name and UNUSED_PARAM usage.

* WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::getPluginInfo):

Source/WebKit2:

Fixed unused parameter compile warnings by removing parameter names, adding UNUSED_PARAM usage and commenting out.

* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::createPluginInternal):
* PluginProcess/unix/PluginProcessUnix.cpp:
(WebKit::PluginProcess::platformInitialize):
* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::getOwnPropertyNames):
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_RequestRead):
(WebKit::NPN_NewStream):
(WebKit::NPN_Write):
(WebKit::NPN_MemFlush):
(WebKit::NPN_ReloadPlugins):
(WebKit::NPN_GetJavaPeer):
(WebKit::NPN_InvalidateRegion):
(WebKit::NPN_ForceRedraw):
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::contentsScaleFactorChanged):
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformPostInitializeWindowed):
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::contentsScaleFactorChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake the status bubble iframe big enough to show all the bubbles
simon.fraser@apple.com [Thu, 4 Oct 2012 00:52:43 +0000 (00:52 +0000)]
Make the status bubble iframe big enough to show all the bubbles
https://bugs.webkit.org/show_bug.cgi?id=98329

Reviewed by Eric Seidel.

Make the status bubble iframe big enough.

* template/en/custom/attachment/edit.html.tmpl:
* template/en/custom/attachment/list.html.tmpl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130352 268f45cc-cd09-0410-ab3c-d52691b4dbfc