WebKit-https.git
9 years ago2011-04-12 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 13 Apr 2011 00:50:36 +0000 (00:50 +0000)]
2011-04-12  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] TilingData mishandles very small texture sizes
        https://bugs.webkit.org/show_bug.cgi?id=58364

        Use zero tiles when the texture size is too small for tiling.

        * platform/graphics/gpu/TilingData.cpp:
        (WebCore::TilingData::TilingData):
        (WebCore::TilingData::setMaxTextureSize):
2011-04-12  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] TilingData mishandles very small texture sizes
        https://bugs.webkit.org/show_bug.cgi?id=58364

        Update test to properly handle texture sizes of 0-3.

        * tests/TilingDataTest.cpp:
        (WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Csaba Osztrogon√°c <ossy@webkit.org>
ossy@webkit.org [Wed, 13 Apr 2011 00:24:31 +0000 (00:24 +0000)]
2011-04-12  Csaba Osztrogon√°c  <ossy@webkit.org>

        Unreviewed, rolling out r83634 and r83659.
        http://trac.webkit.org/changeset/83634
        http://trac.webkit.org/changeset/83659
        https://bugs.webkit.org/show_bug.cgi?id=57075

        It made 2 tests time out

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
        (WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
        (WebCore::QNetworkReplyWrapper::receiveMetaData):
        (WebCore::QNetworkReplyWrapper::didReceiveFinished):
        (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
        (WebCore::QNetworkReplyHandler::resetState):
        (WebCore::QNetworkReplyHandler::setLoadingDeferred):
        (WebCore::QNetworkReplyHandler::resumeDeferredLoad):
        (WebCore::QNetworkReplyHandler::release):
        (WebCore::QNetworkReplyHandler::finish):
        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
        (WebCore::QNetworkReplyHandler::forwardData):
        (WebCore::QNetworkReplyHandler::start):
        * platform/network/qt/QNetworkReplyHandler.h:
        * platform/network/qt/ResourceHandleQt.cpp:
        (WebCore::WebCoreSynchronousLoader::resourceResponse):
        (WebCore::WebCoreSynchronousLoader::resourceError):
        (WebCore::WebCoreSynchronousLoader::data):
        (WebCore::WebCoreSynchronousLoader::setReplyFinished):
        (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
        (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
        (WebCore::WebCoreSynchronousLoader::didReceiveData):
        (WebCore::WebCoreSynchronousLoader::didFinishLoading):
        (WebCore::WebCoreSynchronousLoader::didFail):
        (WebCore::WebCoreSynchronousLoader::waitForCompletion):
        (WebCore::ResourceHandle::loadResourceSynchronously):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 13 Apr 2011 00:20:11 +0000 (00:20 +0000)]
2011-04-12  Sam Weinig  <sam@webkit.org>

        Reviewed by Simon Fraser.

        Frames prevent scrolling containing page
        <rdar://problem/8990409>
        https://bugs.webkit.org/show_bug.cgi?id=58392

        Also fixes:
        Should rubber-band on pages with no scrollbars
        <rdar://problem/9034280>

        * page/FrameView.cpp:
        (WebCore::FrameView::FrameView):
        Make the main frame rubber-band horizontally and vertically always.

        * platform/ScrollTypes.h:
        Add ScrollElasticity enum.

        * platform/ScrollableArea.cpp:
        Default to no elasticity.

        (WebCore::ScrollableArea::ScrollableArea):
        * platform/ScrollableArea.h:
        (WebCore::ScrollableArea::setVerticalScrollElasticity):
        (WebCore::ScrollableArea::verticalScrollElasticity):
        (WebCore::ScrollableArea::setHorizontalScrollElasticity):
        (WebCore::ScrollableArea::horizontalScrollElasticity):
        Add state for horizontal and vertical elasticity.

        * platform/mac/ScrollAnimatorMac.mm:
        (WebCore::ScrollAnimatorMac::handleWheelEvent):
        Bail out of new scrolling behavior if we can't rubber-band. By bailing before
        accepting the wheel event, we allow the wheel event to be forwarded. We will
        need to refine this logic to allow subframe scrolling in the future.

        (WebCore::ScrollAnimatorMac::allowsVerticalStretching):
        (WebCore::ScrollAnimatorMac::allowsHorizontalStretching):
        Switch stretching behavior based on the ScrollableArea's elasticity.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 13 Apr 2011 00:18:29 +0000 (00:18 +0000)]
2011-04-12  Geoffrey Garen  <ggaren@apple.com>

        Not reviewed.

        Try to fix the Chromium build.

        Why have one URL when you can have two at twice the price?

        * platform/KURL.h:
        (WebCore::KURL::KURL):
        (WebCore::KURL::isHashTableDeletedValue):
        * platform/KURLGoogle.cpp:
        (WebCore::KURLGooglePrivate::KURLGooglePrivate):
        * platform/KURLGooglePrivate.h: Added a GoogleURL path for KURL's hash
        table deleted value constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] http/tests/misc/favicon-loads-with-icon-loading-override.html fails
ossy@webkit.org [Wed, 13 Apr 2011 00:18:04 +0000 (00:18 +0000)]
[Qt] http/tests/misc/favicon-loads-with-icon-loading-override.html fails
https://bugs.webkit.org/show_bug.cgi?id=58396

* platform/qt/Skipped: Add http/tests/misc/favicon-loads-with-icon-loading-override.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=58395
barraclough@apple.com [Wed, 13 Apr 2011 00:13:43 +0000 (00:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=58395
Exceptions thrown from property getters called from Array prototype functions can be missed

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This is caught by an ASSERT in the top of Interpreter::executeCall.
Check for exceptions after accessing properties that could be getters.

* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
    - Add exception checks.

LayoutTests:

Added layout test.

* fast/js/array-proto-func-property-getter-except-expected.txt: Added.
* fast/js/array-proto-func-property-getter-except.html: Added.
* fast/js/script-tests/array-proto-func-property-getter-except.js: Added.
(test.propertyGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=58280
slewis@apple.com [Wed, 13 Apr 2011 00:13:11 +0000 (00:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=58280
Fix a layout test by correctly comparing enums, and not adding exceptions.

Reviewed by Oliver Hunt.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
* bindings/js/SerializedScriptValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 13 Apr 2011 00:01:11 +0000 (00:01 +0000)]
2011-04-12  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        Apple movie trailers play only audio
        https://bugs.webkit.org/show_bug.cgi?id=58339
        <rdar://problem/9237606>

        No new tests, covered by existing layout and manual tests.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::mediaPlayerEngineUpdated): Do the logging before calling any functions.
        (WebCore::HTMLMediaElement::mediaPlayerFirstVideoFrameAvailable): New, if still displaying the poster
            change the display mode to Video and force a style recalc so the video layer gets hooked
            up the the render tree.
        * html/HTMLMediaElement.h: Define new display mode, PosterWaitingForVideo, to signal that we
            want to stop displaying the poster as soon as the first frame of video is available.

        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::setDisplayMode): Change display mode to PosterWaitingForVideo when
            we want to display Video but the media engines doesn't have the first frame yet.
        * html/HTMLVideoElement.h:
        (WebCore::HTMLVideoElement::shouldDisplayPosterImage): Update to return true when display mode
            is PosterWaitingForVideo.

        * manual-tests/media-elements/video-replaces-poster.html: Clean up bit-rot from patch changes.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::firstVideoFrameAvailable): New, passthrough from media engien to element.
        * platform/graphics/MediaPlayer.h:
        (WebCore::MediaPlayerClient::mediaPlayerFirstVideoFrameAvailable):

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
        (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Initialize
            m_haveReportedFirstVideoFrame and m_playWhenFramesAvailable.
        (WebCore::MediaPlayerPrivateAVFoundation::play): Don't actually start playback until the first
            frame of video has loaded, or audio will begin to play before we can show video.
        (WebCore::MediaPlayerPrivateAVFoundation::pause): Clear m_playWhenFramesAvailable.
        (WebCore::MediaPlayerPrivateAVFoundation::updateStates): When first frame of video is
            available, inform elment and begin playback if it was previousl requested.
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::destroyContextVideoRenderer): Correct logging.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Ditto.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::platformPlay): Renamed from play.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::platformPause): Rename from pause.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Jian Li <jianli@chromium.org>
jianli@chromium.org [Tue, 12 Apr 2011 23:56:37 +0000 (23:56 +0000)]
2011-04-12  Jian Li  <jianli@chromium.org>

        Unreviewed, rolling out r83649.
        http://trac.webkit.org/changeset/83649
        https://bugs.webkit.org/show_bug.cgi?id=57563

        This patch causes compiling errors for chromium

        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
        (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
        (WebCore::Font::drawComplexText):
        * platform/graphics/chromium/ImageBufferData.h:
        * platform/graphics/chromium/LayerChromium.h:
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/PlatformCanvas.cpp:
        (WebCore::PlatformCanvas::resize):
        * platform/graphics/chromium/PlatformCanvas.h:
        * platform/graphics/chromium/TransparencyWin.cpp:
        (WebCore::TransparencyWin::compositeTextComposite):
        (WebCore::TransparencyWin::makeLayerOpaque):
        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::ImageBuffer::ImageBuffer):
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::paintSkBitmap):
        (WebCore::Image::drawPattern):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::PlatformContextSkia):
        (WebCore::PlatformContextSkia::setCanvas):
        (WebCore::PlatformContextSkia::isPrinting):
        (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
        * platform/graphics/skia/PlatformContextSkia.h:
        (WebCore::PlatformContextSkia::canvas):
2011-04-12  Jian Li  <jianli@chromium.org>

        Unreviewed, rolling out r83649.
        http://trac.webkit.org/changeset/83649
        https://bugs.webkit.org/show_bug.cgi?id=57563

        This patch causes compiling errors for chromium

        * public/WebCanvas.h:
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::printPage):
        * tests/TransparencyWinTest.cpp:
        (WebCore::drawNativeRect):
        (WebCore::getPixelAt):
        (WebCore::clearTopLayerAlphaChannel):
        (WebCore::clearTopLayerAlphaPixel):
        (WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement non-activating clicks to allow dragging out of a background window.
enrica@apple.com [Tue, 12 Apr 2011 23:51:59 +0000 (23:51 +0000)]
Implement non-activating clicks to allow dragging out of a background window.
https://bugs.webkit.org/show_bug.cgi?id=55053
<rdar://problem/9042197>

Source/WebCore:

Reviewed by Alexey Proskuryakov.

* WebCore.exp.in: Added new exported method.

Source/WebKit2:

Reviewed by Alexey Proskuryakov and Sam Weinig.

Added methods to WKView to support non activating click. Unfortunately both
methods require a synchronous call to the WebProcess to decide what to do.
acceptFirstMouse is called only if shouldDelayWindowOrderingForEvent returns
true. In order to minimize the number of synchronous calls, we send the request
only if our window is not the key window.

* UIProcess/API/mac/WKView.mm:
(-[WKView acceptsFirstMouse:]):
(-[WKView shouldDelayWindowOrderingForEvent:]):
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::shouldDelayWindowOrderingForEvent):
(WebKit::WebPageProxy::acceptsFirstMouse):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Oliver Hunt <oliver@apple.com>
ggaren@apple.com [Tue, 12 Apr 2011 23:48:11 +0000 (23:48 +0000)]
2011-04-12  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make API callback objects use weak handles to run their finalizers
        https://bugs.webkit.org/show_bug.cgi?id=58389

        Make the API object's private data struct act as a finalizer for
        an api object if the callback object has a API defined finalizer.

        * API/JSCallbackObject.cpp:
        (JSC::JSCallbackObjectData::finalize):
        * API/JSCallbackObject.h:
        * API/JSCallbackObjectFunctions.h:
        (JSC::::init):
        * heap/Handle.h:
2011-04-12  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Geoffrey Garen.

        Cleaned up hash traits, and added hash traits for handles
        https://bugs.webkit.org/show_bug.cgi?id=58381

        * dom/QualifiedName.h: Use new SimpleClassHashTraits to avoid duplication.

        * platform/KURL.h:
        (WebCore::KURL::KURL):
        (WebCore::KURL::isHashTableDeletedValue): Added explicit hash table
        deleted value constructor, to be more explicit and enable use of
        SimpleClassHashTraits.

        * platform/KURLHash.h: Use new SimpleClassHashTraits to avoid duplication.

        * platform/graphics/FontCache.cpp: Ditto.
        * platform/network/ProtectionSpaceHash.h: Ditto.
        * svg/properties/SVGAnimatedPropertyDescription.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed; add two new tests to the mac-wk2 SkippedList.
jer.noble@apple.com [Tue, 12 Apr 2011 23:37:18 +0000 (23:37 +0000)]
Unreviewed; add two new tests to the mac-wk2 SkippedList.

Skip fullscreen/video-specified-size.html and fullscreen/full-screen-zIndex.html

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Oliver Hunt.
ap@apple.com [Tue, 12 Apr 2011 23:34:07 +0000 (23:34 +0000)]
    Reviewed by Oliver Hunt.

        Crash when serializing a null AttributedString
        https://bugs.webkit.org/show_bug.cgi?id=58393
        <rdar://problem/9275326>

        * Shared/mac/AttributedString.mm:
        (WebKit::AttributedString::encode):
        (WebKit::AttributedString::decode):
        Prefix the serialized value with an isNull tag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 12 Apr 2011 23:27:37 +0000 (23:27 +0000)]
2011-04-12  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make API callback objects use weak handles to run their finalizers
        https://bugs.webkit.org/show_bug.cgi?id=58389

        Make the API object's private data struct act as a finalizer for
        an api object if the callback object has a API defined finalizer.

        * API/JSCallbackObject.cpp:
        (JSC::JSCallbackObjectData::finalize):
        * API/JSCallbackObject.h:
        * API/JSCallbackObjectFunctions.h:
        (JSC::::init):
        * heap/Handle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Tue, 12 Apr 2011 23:22:13 +0000 (23:22 +0000)]
2011-04-12  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Jian Li.

        [chromium] Fix spellcheck regression in context menus
        https://bugs.webkit.org/show_bug.cgi?id=58386

        * src/ContextMenuClientImpl.cpp:
        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
2011-04-12  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Jian Li.

        [chromium] Fix spellcheck regression in context menus
        https://bugs.webkit.org/show_bug.cgi?id=58386

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] QNetworkReplyHandler refactoring: remove nested event loop.
luiz@webkit.org [Tue, 12 Apr 2011 23:20:39 +0000 (23:20 +0000)]
[Qt] QNetworkReplyHandler refactoring: remove nested event loop.
https://bugs.webkit.org/show_bug.cgi?id=58375

Reviewed by Andreas Kling.

As QNAM now makes actual synchronous loads there is no need for a nested event loop
in ResourceHandleQt.

Moving the call for QNetworkReplyWrapper::synchronousLoad from
ResourceHandle::loadResourceSynchronously to QNetworkReplyHandler::start for the
redirections to work in synchronous requests.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::ResourceHandle::loadResourceSynchronously):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Noel Gordon <noel.gordon@gmail.com>
commit-queue@webkit.org [Tue, 12 Apr 2011 23:11:09 +0000 (23:11 +0000)]
2011-04-12  Noel Gordon  <noel.gordon@gmail.com>

        Reviewed by Tony Chang.

        [chromium] Use new dragTargetDragEnter() function signature
        https://bugs.webkit.org/show_bug.cgi?id=58303

        After WebKit/chromium/DEPS rolls to chromium r80907, the drag identity
        based version of dragTargetDragEnter() is no longer used; remove it.

        * public/WebView.h:
        * src/WebViewImpl.cpp:
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build correction for WinCairo bot after r83639.
bfulgham@webkit.org [Tue, 12 Apr 2011 22:59:04 +0000 (22:59 +0000)]
Unreviewed build correction for WinCairo bot after r83639.
https://bugs.webkit.org/show_bug.cgi?id=51790

Correct typo for the new "update-webkit-wincairo-libs" script.

* Scripts/build-webkit: Incorrectly calling the
  update-webkit-cairo-libs which does not exist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoA change that should have been part of http://trac.webkit.org/changeset/83628
alice.liu@apple.com [Tue, 12 Apr 2011 22:49:46 +0000 (22:49 +0000)]
A change that should have been part of trac.webkit.org/changeset/83628

Reviewed by Jon Honeycutt.

* DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInfinite recursion in WebHTMLView executeSavedKeypressCommands.
enrica@apple.com [Tue, 12 Apr 2011 22:48:39 +0000 (22:48 +0000)]
Infinite recursion in WebHTMLView executeSavedKeypressCommands.
https://bugs.webkit.org/show_bug.cgi?id=58382
<rdar://problem/9239370>

Reviewed by Alexey Proskuryakov.

Execution of some editing commands could trigger a call to selectedRange that
internally calls executeSavedKeypressCommands creating an infinite recursion.

Source/WebKit/mac:

* WebView/WebHTMLView.mm:
(-[WebHTMLView _executeSavedKeypressCommands]): Added a flag to avoid recursion.
(-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added flag initialization.

Source/WebKit2:

* UIProcess/API/mac/WKView.mm:
(-[WKView _executeSavedKeypressCommands]): Added flag to avoid recursion.
(-[WKView _interpretKeyEvent:withCachedTextInputState:savingCommandsTo:WebCore::]):
Added flag initialization.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Tue, 12 Apr 2011 22:46:01 +0000 (22:46 +0000)]
2011-04-11  Jer Noble  <jer.noble@apple.com>

        Reviewed by Simon Fraser.

        REGRESSION: Vimeo fullscreen video displays incorrectly
        https://bugs.webkit.org/show_bug.cgi?id=58291

        * fullscreen/video-specified-size-expected.txt: Added.
        * fullscreen/video-specified-size.html: Added.
        * fullscreen/full-screen-test.js:
        * fullscreen/full-screen-zIndex-expected.txt: Added.
        * fullscreen/full-screen-zIndex.html: Added.
        * platform/mac/fullscreen/full-screen-zIndex-expected.checksum: Added.
        * platform/mac/fullscreen/full-screen-zIndex-expected.png: Added.
2011-04-11  Jer Noble  <jer.noble@apple.com>

        Reviewed by Simon Fraser.

        REGRESSION: Vimeo fullscreen video displays incorrectly
        https://bugs.webkit.org/show_bug.cgi?id=58291

        Set the RenderFullScreen's zIndex to the max.  And make sure to override
        a video element's specified width and height by making its full screen rules
        important.  Also, always show the controls when a media element is in full
        screen mode.

        Test: fullscreen/video-specified-size.html
        Test: fullscreen/full-screen-zIndex.html

        * css/fullscreen.css:
        (video:-webkit-full-screen):
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::controls): Always show controls in full screen mode.
        (WebCore::HTMLMediaElement::preDispatchEventHandler): Added. Handle the fullscreen
            change event and hide or show the controls accordingly.
        * html/HTMLMediaElement.h:
        * rendering/RenderFullScreen.cpp:
        (RenderFullScreen::createFullScreenStyle): Set the zIndex to INT_MAX and use a
            vertical flexbox instead of a horizontal one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Tue, 12 Apr 2011 22:43:19 +0000 (22:43 +0000)]
2011-04-12  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Page tears and stutters in WebKit2 when page is > 2048 pixels wide
        https://bugs.webkit.org/show_bug.cgi?id=58330

        Added API to GraphicsLayer to disable switching to tiled layers. This is
        set in the nonCompositedContentLayer in WK2, causing that layer to never
        switch to tiles and avoiding the asynchronous update of the content during
        scroll.

        * platform/graphics/ca/GraphicsLayerCA.cpp:
            Implement setAllowTiledLayer() to simulate a SizeChanged action to
            properly switch between tiled and untiled layer.
        * platform/graphics/ca/GraphicsLayerCA.h:
2011-04-12  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Page tears and stutters in WebKit2 when page is > 2048 pixels wide
        https://bugs.webkit.org/show_bug.cgi?id=58330

        Turn off tiling for nonCompositedContentLayer to avoid tearing when
        scrolling very wide (> 2048) windows.

        * WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
        (WebKit::LayerTreeHostCA::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
yael.aharon@nokia.com [Tue, 12 Apr 2011 22:43:01 +0000 (22:43 +0000)]
Unreviewed.

Unskip t0805-c5519-ibrdr-r-00-a.html, since it is now passing.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded http/tests/misc/favicon-loads-with-icon-loading-override.html
alice.liu@apple.com [Tue, 12 Apr 2011 22:41:12 +0000 (22:41 +0000)]
Added http/tests/misc/favicon-loads-with-icon-loading-override.html
to mac-wk2 skipped list because resource load callbacks aren't implemented
in WebKitTestRunner.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
yael.aharon@nokia.com [Tue, 12 Apr 2011 22:35:43 +0000 (22:35 +0000)]
Unreviewed.

Update results after r83638.

* platform/qt/css1/box_properties/padding_right_inline-expected.checksum:
* platform/qt/css1/box_properties/padding_right_inline-expected.png:
* platform/qt/css1/box_properties/padding_right_inline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Alok Priyadarshi <alokp@chromium.org>
commit-queue@webkit.org [Tue, 12 Apr 2011 22:27:04 +0000 (22:27 +0000)]
2011-04-12  Alok Priyadarshi  <alokp@chromium.org>

        Reviewed by James Robinson.

        Remove dependency on chromium skia::PlatformCanvas
        https://bugs.webkit.org/show_bug.cgi?id=57563

        This patch does not change any functionality, just the type of object skia::PlatformCanvas -> SkCanvas.
        The object is still being created by a factory method skia::CreateBitmapCanvas defined in Chromium.
        We will eventually define an API that every port using skia will define.

        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
        (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
        (WebCore::Font::drawComplexText):
        * platform/graphics/chromium/ImageBufferData.h:
        * platform/graphics/chromium/LayerChromium.h:
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/PlatformCanvas.cpp:
        (WebCore::PlatformCanvas::resize):
        * platform/graphics/chromium/PlatformCanvas.h:
        * platform/graphics/chromium/TransparencyWin.cpp:
        (WebCore::TransparencyWin::compositeTextComposite):
        (WebCore::TransparencyWin::makeLayerOpaque):
        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::ImageBuffer::ImageBuffer):
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::paintSkBitmap):
        (WebCore::Image::drawPattern):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::PlatformContextSkia):
        (WebCore::PlatformContextSkia::setCanvas):
        (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
        * platform/graphics/skia/PlatformContextSkia.h:
        (WebCore::PlatformContextSkia::canvas):
        (WebCore::PlatformContextSkia::printing):
        (WebCore::PlatformContextSkia::setPrinting):
2011-04-12  Alok Priyadarshi  <alokp@chromium.org>

        Reviewed by James Robinson.

        Remove dependency on chromium skia::PlatformCanvas
        https://bugs.webkit.org/show_bug.cgi?id=57563

        * public/WebCanvas.h:
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::printPage):
        * tests/TransparencyWinTest.cpp:
        (WebCore::drawNativeRect):
        (WebCore::getPixelAt):
        (WebCore::clearTopLayerAlphaChannel):
        (WebCore::clearTopLayerAlphaPixel):
        (WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update chromium test expectations.
jianli@chromium.org [Tue, 12 Apr 2011 22:20:17 +0000 (22:20 +0000)]
Unreviewed, update chromium test expectations.

Mark 3 bidi related layout tests as failed in chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 12 Apr 2011 22:05:34 +0000 (22:05 +0000)]
2011-04-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Assertion in DrawingAreaImpl::resumePainting() (m_isPaintingSuspended) when clicking a link at twitter.com
        https://bugs.webkit.org/show_bug.cgi?id=58377
        <rdar://problem/8976531>

        Remove the assertion.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::resumePainting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 12 Apr 2011 22:02:14 +0000 (22:02 +0000)]
2011-04-12  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: --results-directory is relative to builddir, not $PWD
        https://bugs.webkit.org/show_bug.cgi?id=58272

        NRWT was interpreting the --results-directory cmd line arg as
        relative to the build directory, not the current working
        directory (ORWT uses the latter, which is much more intuitive).

        This patch fixes the base case, but includes an override for
        Chromium that is needed until the bots can be updated.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago../WebCore: https://bugs.webkit.org/show_bug.cgi?id=58280
slewis@apple.com [Tue, 12 Apr 2011 21:50:04 +0000 (21:50 +0000)]
../WebCore: https://bugs.webkit.org/show_bug.cgi?id=58280
<rdar://problem/9252824> javascript in an inconsistent state due to serialization returning an un-handled exception
Currently serialization and deserialization can throw javascript exceptions.  Since SerializedScriptValue is called in
several places that do not always involve direct calls into javascript have the functions return an error code and the callers
decide whether or not to throw exceptions.

Reviewed by Oliver Hunt.

Don't allow SerializedScriptValue to attempt to serialize objects that inherit from JSNavigator.h.  Walking that object creates
additional objects which eventually causes serialization to end up throwing a stack overflow error.  Instead fail immediately.

Untangle header includes.  SerializedScriptValue was inheriting ScriptValue.h, but not using it.  Since ScriptValue depends on
SerializedScriptValue this could lead to a circular header dependency.

No change in functionality, covered by current tests

* WebCore.exp.in:
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::initMessageEvent):
* bindings/js/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::deserialize):
* bindings/js/ScriptValue.h:
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::deserialize):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
(WebCore::SerializedScriptValue::maybeThrowExceptionIfSerializationFailed):
(WebCore::SerializedScriptValue::serializationDidCompleteSuccessfully):
* bindings/js/SerializedScriptValue.h:

* bindings/js/JSWorkerContextBase.cpp: header include fix
* loader/FrameLoader.h: header include fix
* page/Frame.cpp: header include fix

../WebKit/gtk: https://bugs.webkit.org/show_bug.cgi?id=58280
<rdar://problem/9252824> javascript in an inconsistent state due to serialization returning an un-handled exception.

Reviewed by Oliver Hunt.

Add a header include.  Fallout from untangling some header files in WebCore.

* webkit/webkitwebhistoryitem.cpp:

../WebKit2: https://bugs.webkit.org/show_bug.cgi?id=58280
<rdar://problem/9252824> javascript in an inconsistent state due to serialization returning an un-handled exception
Change use of SerializedScriptValue::Create to use the same api as the rest of WebKit2.  This has the benefit
of handling any exceptions so Javascript is not in an inconsistent state.

Reviewed by Oliver Hunt.

* Shared/API/c/WKSerializedScriptValue.h: fix a typo
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScriptInMainFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update chromium test expectations.
jianli@chromium.org [Tue, 12 Apr 2011 21:46:21 +0000 (21:46 +0000)]
Unreviewed, update chromium test expectations.

Mark 3 layout tests as failed in chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 12 Apr 2011 21:42:32 +0000 (21:42 +0000)]
2011-04-12  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, roll out r83621 as it broke the GTK build.

        [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
        https://bugs.webkit.org/show_bug.cgi?id=58333

        * Scripts/build-jsc:
        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 12 Apr 2011 21:36:50 +0000 (21:36 +0000)]
2011-04-12  Adam Barth  <abarth@webkit.org>

        Revert unintentional changes to WebKit.

        * public/WebSettings.h:
        * src/WebSettingsImpl.cpp:
        * src/WebSettingsImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove libtess from WebCore/thirdparty to ThirdParty
abarth@webkit.org [Tue, 12 Apr 2011 21:34:16 +0000 (21:34 +0000)]
Move libtess from WebCore/thirdparty to ThirdParty
https://bugs.webkit.org/show_bug.cgi?id=57288

Reviewed by Kenneth Russell.

We're putting third party code in Source/ThirdParty these days.

* Source/ThirdParty/glu: Copied from Source/WebCore/thirdparty/glu.
* Source/ThirdParty/glu/glu.gyp: Added.

Source/WebCore:

* WebCore.gyp/WebCore.gyp:
    - Add libtess as a legit dependency.
* WebCore.gypi:
    - Remove libtess files from the gypi.
* thirdparty/glu: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 12 Apr 2011 21:32:58 +0000 (21:32 +0000)]
2011-04-12  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by David Hyatt.

        Bundle w and tmpW in findNextLineBreak together as a class
        https://bugs.webkit.org/show_bug.cgi?id=58362

        Renamed w, tempW, and width in findNextLineBreak to committedWidth, uncommittedWidth,
        and availableWidth respectively. Also bundled committedWidth and uncommittedWith as a class
        named LineWidth.

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::LineWidth::LineWidth): Added.
        (WebCore::LineWidth::currentWidth): Added; returns the sum of committed and uncommitted width.
        (WebCore::LineWidth::uncommittedWidth): Added.
        (WebCore::LineWidth::committedWidth): Added.
        (WebCore::LineWidth::addUncommittedWidth): Added; adds the specified width to the uncommitted width.
        (WebCore::LineWidth::commit): Added; commits the current width and clears the uncommitted width.
        (WebCore::RenderBlock::findNextLineBreak): Uses LineWidth.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Carl Lobo <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Tue, 12 Apr 2011 21:28:53 +0000 (21:28 +0000)]
2011-04-12  Carl Lobo  <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org>

        Reviewed by Adam Roben.

        Patch to download the WinCairo dependancies as part of build-webkit.
        https://bugs.webkit.org/show_bug.cgi?id=51790

        This patch downloads the dependancies from
            http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip
        checking the modification timestamp etc.

        * Tools/Scripts/build-webkit
        * Tools/Scripts/update-webkit: Modified to understand the --wincairo
          flag, and to update WinCairo dependencies when used.
        * Tools/Scripts/update-webkit-cairo-libs: added
        * Tools/Scripts/update-webkit-dependency: added
        * Tools/Scripts/update-webkit-auxiliary-libs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Tue, 12 Apr 2011 21:28:24 +0000 (21:28 +0000)]
2011-04-12  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Eric Seidel.

        REGRESSION(r82419): extra border in t0805-c5519-ibrdr-r-00-a.html
        https://bugs.webkit.org/show_bug.cgi?id=57459

        * fast/borders/bidi-002.html: Added.
        * fast/borders/bidi-004.html: Added.
        * fast/borders/bidi-009a.html: Added.
        * platform/mac/fast/borders/bidi-002-expected.checksum: Added.
        * platform/mac/fast/borders/bidi-002-expected.png: Added.
        * platform/mac/fast/borders/bidi-002-expected.txt: Added.
        * platform/mac/fast/borders/bidi-004-expected.checksum: Added.
        * platform/mac/fast/borders/bidi-004-expected.png: Added.
        * platform/mac/fast/borders/bidi-004-expected.txt: Added.
        * platform/mac/fast/borders/bidi-009a-expected.checksum: Added.
        * platform/mac/fast/borders/bidi-009a-expected.png: Added.
        * platform/mac/fast/borders/bidi-009a-expected.txt: Added.
2011-04-12  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Eric Seidel.

        REGRESSION(r82419): extra border in t0805-c5519-ibrdr-r-00-a.html
        https://bugs.webkit.org/show_bug.cgi?id=57459

        Slightly change the way we decide if a InlineFlowBox is the last box for its renderer.
        We include the border in that box under these conditions:
        (1) The next line was not created, or it is constructed. We check the previous line for rtl.
        (2) The logicallyLastRun is not a descendant of this renderer.
        (3) The logicallyLastRun is a descendant of this renderer, but it is the last child of this renderer and it does not wrap to the next line.
        I added the tests from bug 47210, because now the draw the borders correctly.

        Tests: fast/borders/bidi-002.html
               fast/borders/bidi-004.html
               fast/borders/bidi-009a.html

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::onEndChain):
        (WebCore::isAnsectorAndWithinBlock):
        (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
        * rendering/InlineFlowBox.h:
        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::constructLine):
        (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 12 Apr 2011 21:12:33 +0000 (21:12 +0000)]
2011-04-12  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Cleaned up some Vector traits, and added missing Vector traits for handles
        https://bugs.webkit.org/show_bug.cgi?id=58372

        * heap/Local.h: Inherit from SimpleClassVectorTraits to avoid duplication.

        * heap/Strong.h: Ditto.

        * heap/Weak.h: Ditto.

        * parser/JSParser.cpp: Fixed a traits error. No test case because this
        particular trait is not currently exercised by the parser.

        * runtime/UString.h: No need to override canInitializeWithMemset, since
        our base class sets it to true.

        * wtf/VectorTraits.h: Inherit from VectorTraitsBase to avoid duplication.

        * wtf/text/WTFString.h: No need to override canInitializeWithMemset, since
        our base class sets it to true.
2011-04-12  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Cleaned up some Vector traits, and added missing Vector traits for handles
        https://bugs.webkit.org/show_bug.cgi?id=58372

        * platform/graphics/BitmapImage.h: Added a FIXME because the current
        Vector traits for FrameData are logically incorrect, but I couldn't find
        a place where this currently results in bad behavior, and it's not
        immediately obvious what the right solution is.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 12 Apr 2011 20:59:36 +0000 (20:59 +0000)]
2011-04-12  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Move MediaControlElements to html/shadow.
        https://bugs.webkit.org/show_bug.cgi?id=58347

        Mechanical move of the files.

        * Android.mk: Updated the build file.
        * CMakeLists.txt: Ditto.
        * GNUmakefile.list.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto, also ran sort-XCode-project-files.
        * html/shadow/MediaControlElements.cpp: Copied from Source/WebCore/rendering/MediaControlElements.cpp.
        (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
        * html/shadow/MediaControlElements.h: Copied from Source/WebCore/rendering/MediaControlElements.h.
        * rendering/MediaControlElements.cpp: Removed.
        * rendering/MediaControlElements.h: Removed.
        * rendering/RenderingAllInOne.cpp: Removed the files that were moved.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 12 Apr 2011 20:53:10 +0000 (20:53 +0000)]
2011-04-12  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory
        https://bugs.webkit.org/show_bug.cgi?id=58290

        This is some preliminary refactoring for bug 58272.

        * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] QNetworkReplyHandler refactoring: signal queue
luiz@webkit.org [Tue, 12 Apr 2011 20:46:59 +0000 (20:46 +0000)]
[Qt] QNetworkReplyHandler refactoring: signal queue
https://bugs.webkit.org/show_bug.cgi?id=57075

Reviewed by Andreas Kling.

The idea is to make all signals that come from the QNetworkReply to pass through a queue and to
stop that queue when loading is deferred. This way almost all the deferred logic can be removed
from QNetworkReplyHandler class and encapsulated in its own class.

To stop the queue during wrapper methods execution avoids stacking handler methods over wrapper
methods. Because of this there is no chance for the wrapper to be destroyed inside one of its methods.
This together with empting the queue at wrapper destruction time makes sure that the handler will
not receive calls from a dead wrapper.

The new class is named QNetworkReplyHandlerCallQueue.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandlerCallQueue::QNetworkReplyHandlerCallQueue):
(WebCore::QNetworkReplyHandlerCallQueue::push):
(WebCore::QNetworkReplyHandlerCallQueue::lock):
(WebCore::QNetworkReplyHandlerCallQueue::unlock):
(WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):
(WebCore::QueueLocker::QueueLocker):
(WebCore::QueueLocker::~QueueLocker):
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::readyRead):
(WebCore::QNetworkReplyWrapper::didReceiveFinished):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::resetState):
(WebCore::QNetworkReplyHandler::release):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
(WebCore::QNetworkReplyHandler::synchronousLoad):
* platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyHandlerCallQueue::deferSignals):
(WebCore::QNetworkReplyHandlerCallQueue::clear):
(WebCore::QNetworkReplyWrapper::synchronousLoad):
(WebCore::QNetworkReplyHandler::setLoadingDeferred):
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::loadResourceSynchronously):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Tue, 12 Apr 2011 20:44:17 +0000 (20:44 +0000)]
2011-04-12  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
        https://bugs.webkit.org/show_bug.cgi?id=56020

        Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view,
        since WebKit will do this for us.  If we didn't do this, TranslateMessage() would be called twice,
        which would generate two characters for every keypress (for example).  I didn't bother doing this for
        WebKitTestRunner, since it doesn't get any WM_KEYDOWN events.

        Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior.

        * MiniBrowser/win/main.cpp:
        (shouldTranslateMessage): Added.
        (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
        * TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows.
        * TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown().
        * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added.
        (TestWebKitAPI::didNotHandleKeyEventCallback): Added.
        (TestWebKitAPI::runAndWatchForWMChar): Added.
        (TestWebKitAPI::TEST): Added.
        * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
        (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
        (TestWebKitAPI::Util::shouldTranslateMessage): Added.
        * TestWebKitAPI/win/PlatformWebViewWin.cpp:
        (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added.
        * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp.
2011-04-12  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
        https://bugs.webkit.org/show_bug.cgi?id=56020

        Safari was always calling TranslateMessage() on key events since it has no way to know whether
        WebKit handled the event without a PageUIClient (which Safari only installs on pages inside
        a Safari window), which was generating a WM_CHAR message containing the tab in this case.  The fix
        is for Safari to never call TranslateMessage() on key events outside of a Safari window, but this
        means the WebPageProxy needs to do this for unhandled key events if there is no didNotHandleKeyEvent
        callback in the PageUIClient.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didReceiveEvent): Call TranslateMessage() on Windows for unhandled key events that can't be handled by the PageUIClient.
        * UIProcess/WebUIClient.cpp:
        (WebKit::WebUIClient::canNotHandleKeyEvent): Added.
        * UIProcess/WebUIClient.h: Added canNotHandleKeyEvent().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix spelling layout test. BUG=https://bugs.webkit.org/show_bug.cgi?id...
jam@chromium.org [Tue, 12 Apr 2011 20:40:03 +0000 (20:40 +0000)]
[chromium] Fix spelling layout test.  BUG=https://bugs.webkit.org/show_bug.cgi?id=58371

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 12 Apr 2011 20:34:45 +0000 (20:34 +0000)]
2011-04-12  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        webkitpy: fix mock_filesystem abspath to handle relative paths
        and add filesystem.chdir() and filesystem.getcwd() to be able
        to test this and mock it out.

        https://bugs.webkit.org/show_bug.cgi?id=58288

        * Scripts/webkitpy/common/system/filesystem.py:
        * Scripts/webkitpy/common/system/filesystem_mock.py:
        * Scripts/webkitpy/common/system/filesystem_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Windows XP Debug Tests] http/tests/inspector/resource-tree-model.html failing since...
jberlin@webkit.org [Tue, 12 Apr 2011 20:34:28 +0000 (20:34 +0000)]
[Windows XP Debug Tests] http/tests/inspector/resource-tree-model.html failing since introduction in r83584
https://bugs.webkit.org/show_bug.cgi?id=58367

Add expected failing results to get the bots green.

* platform/win-xp/http: Added.
* platform/win-xp/http/tests: Added.
* platform/win-xp/http/tests/inspector: Added.
* platform/win-xp/http/tests/inspector/resource-tree-model-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=58176
hyatt@apple.com [Tue, 12 Apr 2011 20:31:02 +0000 (20:31 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=58176

Reviewed by Dan Bernstein.

Inline replaced elements following positioned elements on lines are not rendered. Make sure the
logic for skipping run construction in appendRunsForObject matches the new logic that I added
to findNextLineBreak. If they don't match up, you risk confusing the run construction code and
causing it to not make runs for objects that follow the positioned object on the line.

Source/WebCore:

Added fast/inline/positioned-object-between-replaced-elements.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::appendRunsForObject):

LayoutTests:

* fast/inline/positioned-object-between-replaced-elements.html: Added.
* platform/mac/fast/inline/positioned-object-between-replaced-elements-expected.checksum: Added.
* platform/mac/fast/inline/positioned-object-between-replaced-elements-expected.png: Added.
* platform/mac/fast/inline/positioned-object-between-replaced-elements-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=58292
alice.liu@apple.com [Tue, 12 Apr 2011 20:22:22 +0000 (20:22 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=58292
Provide new setting to allow site icon loading despite disabling automatic image loading in general.

Reviewed by Sam Weinig.

Source/WebCore:

Test: http/tests/misc/favicon-loads-with-icon-loading-override.html

* WebCore.exp.in: Added export symbol
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::startIconLoader): Check new setting before deciding that site icon images shouldn't be loaded.
* page/Settings.cpp:
(WebCore::Settings::Settings): Add initializer for new setting
(WebCore::Settings::setLoadsSiteIconsIgnoringImageLoadingSetting): Add setter for new setting.
* page/Settings.h: Explain nuances regarding loadsImagesAutomatically setting.
(WebCore::Settings::loadsSiteIconsIgnoringImageLoadingSetting): Added getter.

Source/WebKit/mac:

* WebView/WebPreferenceKeysPrivate.h: Add preference key.
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Initialize to false.
(-[WebPreferences setLoadsSiteIconsIgnoringImageLoadingPreference:]): Added.
(-[WebPreferences loadsSiteIconsIgnoringImageLoadingPreference]): Added.
* WebView/WebPreferencesPrivate.h: Add setter/getter definitions.
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Add to settings that get propagated upon changes.

Source/WebKit/win:

* Interfaces/IWebPreferencesPrivate.idl: Added prefs.
* Interfaces/WebKit.idl: Touch file to force autogeneration
* WebPreferenceKeysPrivate.h: Add preference key.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Initialize setting to false.
(WebPreferences::setLoadsSiteIconsIgnoringImageLoadingPreference): Added setter
(WebPreferences::loadsSiteIconsIgnoringImageLoadingPreference): Added getter
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged): Add to settings that get propagated upon changes.

Source/WebKit2:

* Shared/WebPreferencesStore.h: Add macro for setting default value.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetLoadsSiteIconsIgnoringImageLoadingPreference): Added setter.
(WKPreferencesGetLoadsSiteIconsIgnoringImageLoadingPreference): Added getter.
* UIProcess/API/C/WKPreferences.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Add to list of WebCore settings that get propagated to WebKit preferences.

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.

LayoutTests:

* http/tests/misc/favicon-loads-with-icon-loading-override-expected.txt: Added.
* http/tests/misc/favicon-loads-with-icon-loading-override.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Spelling and Grammar Checking: Make sure to remove the markings from the...
jberlin@webkit.org [Tue, 12 Apr 2011 20:14:20 +0000 (20:14 +0000)]
WebKit2: Spelling and Grammar Checking: Make sure to remove the markings from the document
when spelling and/or grammar checking is disabled.
https://bugs.webkit.org/show_bug.cgi?id=58350

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView toggleContinuousSpellChecking:]):
Move the call to unmark the errors to the WebProcess.
(-[WKView setGrammarCheckingEnabled:]):
Ditto.
(-[WKView toggleGrammarChecking:]):
Ditto.

* UIProcess/WebPageProxy.cpp:
Remove unused functions.
* UIProcess/WebPageProxy.h:
Ditto.
* WebProcess/WebPage/WebPage.messages.in:
Ditto.
* WebProcess/WebPage/WebPage.h:

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setTextCheckerState):
If grammar or spelling checking is disabled, unmark all the pages.
Doing it here allows makes it possible to unmark all pages in a cross-platform way that is
triggered both by selecting the the context menu items and by any other methods of updating
the enabled / disabled state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Thouraya ANDOLSI <thouraya.andolsi@st.com>
commit-queue@webkit.org [Tue, 12 Apr 2011 20:05:45 +0000 (20:05 +0000)]
2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>

        Reviewed by Eric Seidel.

        [QT] Enable JIT build for SH4 platforms.
        https://bugs.webkit.org/show_bug.cgi?id=58317
        add disable_uitools for SH4 platforms.

        * Source/WebKit.pri:
2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>

        Reviewed by Eric Seidel.

        [Qt] Enable JIT build for SH4 platforms.
        https://bugs.webkit.org/show_bug.cgi?id=58317
        enable JIT build for QT backend  for SH4 platforms.

        * JavaScriptCore.pro:
        * wtf/Platform.h:
2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>

        Reviewed by Eric Seidel.

        [Qt] Enable JIT build for SH4 platforms.
        https://bugs.webkit.org/show_bug.cgi?id=58317

        * DumpRenderTree/qt/DumpRenderTree.pro:
        * QtTestBrowser/QtTestBrowser.pro:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 12 Apr 2011 19:56:04 +0000 (19:56 +0000)]
2011-04-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Cisco Meeting Center will not download or launch from Safari
        https://bugs.webkit.org/show_bug.cgi?id=58366
        <rdar://problem/8987139>

        It's OK if a plug-in has less (or more) MIME type descriptions than actual MIME types.

        * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
        (WebKit::getPluginInfoFromCarbonResources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 12 Apr 2011 19:45:15 +0000 (19:45 +0000)]
2011-04-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Call PluginControllerProxy::platformGeometryDidChange before Plugin::geometryDidChange
        https://bugs.webkit.org/show_bug.cgi?id=58361

        Since Plugin::geometryDidChange ends up calling plug-in code it can resize the plug-in which causes
        platformGeometryDidChange to be called with the wrong rect.

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::geometryDidChange):
        Call platformGeometryDidChange.

        * PluginProcess/PluginControllerProxy.h:
        * PluginProcess/mac/PluginControllerProxyMac.mm:
        (WebKit::PluginControllerProxy::platformGeometryDidChange):
        Remove the parameters to platformGeometryDidChange and just use m_frameRect instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove three Mac specific functions to PluginControllerProxyMac.mm.
andersca@apple.com [Tue, 12 Apr 2011 19:37:44 +0000 (19:37 +0000)]
Move three Mac specific functions to PluginControllerProxyMac.mm.

Reviewed by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 12 Apr 2011 19:35:10 +0000 (19:35 +0000)]
2011-04-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Cache the window and plug-in element NPObjects
        https://bugs.webkit.org/show_bug.cgi?id=58355

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::PluginControllerProxy):
        (WebKit::PluginControllerProxy::~PluginControllerProxy):
        (WebKit::PluginControllerProxy::windowScriptNPObject):
        (WebKit::PluginControllerProxy::pluginElementNPObject):
        * PluginProcess/PluginControllerProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Thouraya ANDOLSI <thouraya.andolsi@st.com>
commit-queue@webkit.org [Tue, 12 Apr 2011 19:24:28 +0000 (19:24 +0000)]
2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>

        Reviewed by Eric Seidel.

        [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
        https://bugs.webkit.org/show_bug.cgi?id=58333

        * Scripts/build-jsc:
        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 George Guo <George.Guo@nokia.com>
commit-queue@webkit.org [Tue, 12 Apr 2011 19:17:06 +0000 (19:17 +0000)]
2011-04-12  George Guo  <George.Guo@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] On Symbian got "Update Error" when installing QtWebkit.sis
        http://bugs.webkit.org/show_bug.cgi?id=58141

        If QtWebKit is already in Symbian ROM, we need package to be
        both SA and RU type

        * QtWebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 12 Apr 2011 19:10:37 +0000 (19:10 +0000)]
2011-04-12  Tony Chang  <tony@chromium.org>

        Reviewed by Andreas Kling.

        [Qt] embed checksums in PNGs written by Qt-DRT
        https://bugs.webkit.org/show_bug.cgi?id=58173

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 12 Apr 2011 19:02:11 +0000 (19:02 +0000)]
2011-04-12  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Move StyleChange and other global functions from ApplyStyleCommand to EditingStyle
        https://bugs.webkit.org/show_bug.cgi?id=55974

        Moved StyleChange, getIdentifierValue, and legacyFontSizeFromCSSValue from ApplyStyleCommand
        to EditingStyle. Also moved reconcileTextDecorationProperties, getIdentifierValue,
        setTextDecorationProperty, isCSSValueLength, legacyFontSizeFromCSSValue, extractTextStyles,
        diffTextDecorations, fontWeightIsBold, getTextAlignment, and getPropertiesNotIn.

        Because of this move, getPropertiesNotIn is no longer visible outside of EditingStyle.cpp

        * editing/ApplyStyleCommand.cpp:
        * editing/ApplyStyleCommand.h:
        * editing/EditingStyle.cpp:
        (WebCore::reconcileTextDecorationProperties):
        (WebCore::StyleChange::StyleChange):
        (WebCore::setTextDecorationProperty):
        (WebCore::getRGBAFontColor):
        (WebCore::StyleChange::extractTextStyles):
        (WebCore::diffTextDecorations):
        (WebCore::fontWeightIsBold):
        (WebCore::getTextAlignment):
        (WebCore::getPropertiesNotIn):
        (WebCore::getIdentifierValue):
        (WebCore::isCSSValueLength):
        (WebCore::legacyFontSizeFromCSSValue):
        * editing/EditingStyle.h:
        (WebCore::StyleChange::cssStyle):
        (WebCore::StyleChange::applyBold):
        (WebCore::StyleChange::applyItalic):
        (WebCore::StyleChange::applyUnderline):
        (WebCore::StyleChange::applyLineThrough):
        (WebCore::StyleChange::applySubscript):
        (WebCore::StyleChange::applySuperscript):
        (WebCore::StyleChange::applyFontColor):
        (WebCore::StyleChange::applyFontFace):
        (WebCore::StyleChange::applyFontSize):
        (WebCore::StyleChange::fontColor):
        (WebCore::StyleChange::fontFace):
        (WebCore::StyleChange::fontSize):
        (WebCore::StyleChange::operator==):
        (WebCore::StyleChange::operator!=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Tue, 12 Apr 2011 18:45:33 +0000 (18:45 +0000)]
2011-04-11  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Fisher.

        [chromium]: Get the list of misspelled words in the WebKit code insetad of in chromium's RenderView
        https://bugs.webkit.org/show_bug.cgi?id=58260

        * public/WebContextMenuData.h:
        * public/WebSpellCheckClient.h:
        (WebKit::WebSpellCheckClient::spellCheck):
        * src/ContextMenuClientImpl.cpp:
        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::checkSpellingOfString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 12 Apr 2011 18:40:45 +0000 (18:40 +0000)]
2011-04-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Review tool should work well on iPad
        https://bugs.webkit.org/show_bug.cgi?id=58351

        On the iPad, the toolbar ends up at some random position in the middle
        of the page because of how position:fixed interacts with scrolling on
        the iPad.  I feel a bit dirty using a user agent detect, but I'm not
        sure if there's a better way to detect whether the user agent has this
        behavior.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Diego Gonzalez <diegohcg@webkit.org>
diegohcg@webkit.org [Tue, 12 Apr 2011 18:30:44 +0000 (18:30 +0000)]
2011-04-12  Diego Gonzalez  <diegohcg@webkit.org>

    [Qt] Better padding for inputs and comboxes in mobile theme
    https://bugs.webkit.org/show_bug.cgi?id=58248

    Reviewed by Kenneth Rohde Christiansen.

    * platform/qt/RenderThemeQt.cpp:
    (WebCore::RenderThemeQt::setButtonPadding):
    (WebCore::RenderThemeQt::adjustTextFieldStyle):
    (WebCore::RenderThemeQt::paintTextField):
    (WebCore::RenderThemeQt::adjustMenuListStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 12 Apr 2011 18:30:17 +0000 (18:30 +0000)]
2011-04-12  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue should upload failure diffs when tests fail
        https://bugs.webkit.org/show_bug.cgi?id=58348

        This change was mostly just plumbing.  We were already saving
        this information for flaky test reporting.  I just made it possible
        for normal failures to report archives as well.

        I did a little abstraction work to try and share some code between
        flakytestreporter.py and this new code.  There is still more we could do.

        In making this change I also went through and updated the various
        places we have urls hard-coded in our python and pointed them at
        common.config.urls.

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
        * Scripts/webkitpy/common/net/buildbot/buildbot.py:
        * Scripts/webkitpy/common/net/statusserver.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/tool/bot/botinfo.py: Added.
        * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added.
        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
        * Scripts/webkitpy/tool/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Bill Budge <bbudge@chromium.org>
commit-queue@webkit.org [Tue, 12 Apr 2011 18:19:09 +0000 (18:19 +0000)]
2011-04-12  Bill Budge  <bbudge@chromium.org>

        Reviewed by Darin Fisher.

        Move the WebURLLoaderOptions struct into its own file and rename the CrossOriginRequestPolicy enum to conform to the WebKit coding standard.
        https://bugs.webkit.org/show_bug.cgi?id=58287

        No new tests. No new functionality exposed.

        * WebKit.gyp:
        * public/WebURLLoader.h:
        * public/WebURLLoaderOptions.h: Added.
        (WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
        * src/AssociatedURLLoader.cpp:
        (WebKit::AssociatedURLLoader::AssociatedURLLoader):
        * src/AssociatedURLLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate pixel results for editable-inline-element.html since it progressed following...
hyatt@apple.com [Tue, 12 Apr 2011 18:00:32 +0000 (18:00 +0000)]
Update pixel results for editable-inline-element.html since it progressed following r83075.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Tue, 12 Apr 2011 17:52:56 +0000 (17:52 +0000)]
2011-04-11  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Tests that we do not crash when reparenting a runin to a details block.
        https://bugs.webkit.org/show_bug.cgi?id=58228

        * fast/runin/runin-reparent-crash-expected.txt: Added.
        * fast/runin/runin-reparent-crash.html: Added.
2011-04-11  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Replace insertChildNode with addChild in handleRunIn's reparenting
        of inlineRunIn to currBlock.
        https://bugs.webkit.org/show_bug.cgi?id=58228

        Use addChild instead of insertChildNode since it handles
        correct placement of the children, esp where we cannot insert
        anything before the first child. e.g. details tag requires that its
        first child be a summary child and won't be able to remove child if
        that is not the case.

        Test: fast/runin/runin-reparent-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::handleRunInChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 12 Apr 2011 17:50:07 +0000 (17:50 +0000)]
2011-04-12  Stephen White  <senorblanco@chromium.org>

        Unreviewed; new chromium layout test baselines.

        New baselines after r83541.  Note that these look worse, but that's
        because we went from greyscale antialiasing to ClearType antialiasing,
        but the layout tests turn off ClearType, so they don't get any AA
        at all.  It looks fine in Chrome.

        * platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum: Removed.
        * platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
        * platform/chromium-win/fast/text/shadow-translucent-fill-expected.checksum: Removed.
        * platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
        * platform/chromium-win/fast/transforms/shadows-expected.png:
        * platform/chromium-win/svg/css/composite-shadow-text-expected.checksum: Removed.
        * platform/chromium-win/svg/css/composite-shadow-text-expected.png:
        * platform/chromium-win/svg/css/shadow-changes-expected.checksum: Removed.
        * platform/chromium-win/svg/css/shadow-changes-expected.png:
        * platform/chromium-win/svg/css/text-shadow-multiple-expected.checksum: Removed.
        * platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
        * platform/chromium-win/transitions/svg-text-shadow-transition-expected.checksum: Removed.
        * platform/chromium-win/transitions/svg-text-shadow-transition-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fixing Leopard build.
cfleizach@apple.com [Tue, 12 Apr 2011 17:46:47 +0000 (17:46 +0000)]
Unreviewed. Fixing Leopard build.

REGRESSION: WK2: misspelled AX attributes no longer returned from text fields
https://bugs.webkit.org/show_bug.cgi?id=58304

checkTextOfParagraph is not available on Leopard. That code needs to be conditionalized with USE(UNIFIED_TEXT_CHECKING).

* accessibility/mac/AccessibilityObjectWrapper.mm:
(AXAttributeStringSetSpelling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 12 Apr 2011 17:40:09 +0000 (17:40 +0000)]
2011-04-12  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed. Added missing files to GNUmakefile.list.am.

        * GNUmakefile.list.am: Added IDBLevelDBBackingStore.[h|cpp].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Cris Neckar <cdn@chromium.org>
cdn@chromium.org [Tue, 12 Apr 2011 17:39:10 +0000 (17:39 +0000)]
2011-04-12  Cris Neckar  <cdn@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Tests for crash when non-svg inline text boxes exist in the list of text boxes.
        https://bugs.webkit.org/show_bug.cgi?id=57933

        * svg/text/svg-rtl-text-crash-expected.txt: Added.
        * svg/text/svg-rtl-text-crash.html: Added.
2011-04-12  Cris Neckar  <cdn@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Add handling for non-svg inline text boxes in text box lists.
        https://bugs.webkit.org/show_bug.cgi?id=57933

        Test: svg/text/svg-rtl-text-crash.html

        * rendering/svg/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::positionForPoint):
        * rendering/svg/SVGInlineFlowBox.cpp:
        (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
        * rendering/svg/SVGRenderTreeAsText.cpp:
        (WebCore::writeSVGInlineTextBoxes):
        * rendering/svg/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::closestLeafChildForPosition):
        (WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
        * rendering/svg/SVGTextQuery.cpp:
        (WebCore::SVGTextQuery::collectTextBoxesInFlowBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 12 Apr 2011 17:35:36 +0000 (17:35 +0000)]
2011-04-12  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] Expose menu items and menus as children of a menu bar
        https://bugs.webkit.org/show_bug.cgi?id=56659

        New cross-platform test. Skipped in platforms with no results yet.

        * accessibility/aria-menubar-menuitems.html: Added.
        * platform/gtk/accessibility/aria-menubar-menuitems-expected.txt: Added.
        * platform/mac/Skipped: Skipped the new test.
        * platform/win/Skipped: Ditto.
2011-04-12  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] Expose menu items and menus as children of a menu bar
        https://bugs.webkit.org/show_bug.cgi?id=56659

        Ensure menu items get exposed when they're children of menu bars.

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
        Consider menu bars as potential parent objects for menu items.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WebKit2 Release Tests] fast/dom/StyleSheet/detached-stylesheet-without-wrapper.html...
jberlin@webkit.org [Tue, 12 Apr 2011 17:29:27 +0000 (17:29 +0000)]
[WebKit2 Release Tests] fast/dom/StyleSheet/detached-stylesheet-without-wrapper.html flakey
https://bugs.webkit.org/show_bug.cgi?id=58337

Skip the test to get the bots green.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update chromium test expectations.
jianli@chromium.org [Tue, 12 Apr 2011 17:23:20 +0000 (17:23 +0000)]
Unreviewed, update chromium test expectations.

Mark access-zero-sized-canvas as crash on chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 12 Apr 2011 17:18:35 +0000 (17:18 +0000)]
2011-04-12  Daniel Bates  <dbates@rim.com>

        Rubber-stamped by Eric Seidel.

        svn-apply and/or patch(1) has trouble applying patches that makes changes to files
        with Windows line endings
        https://bugs.webkit.org/show_bug.cgi?id=53625

        Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be
        applied to an SCM checkout on a Windows file system and vice-versa.

        This issue manifests itself due to custom SCM settings as well as differences in
        gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support
        into svn-apply/unapply to compensate for differences in line endings by converting
        the line endings in a patch to match the line endings in the target file (if it exists).

        * Scripts/VCSUtils.pm:
          - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the
            content read from the specified file handle. Obviously, this heuristic will not work
            for files with mixed line endings, but I don't envision such files to be the norm. If
            this turns out to be an issue then we can improve the heuristic.
          - Added firstEOLInFile().
          - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash.
            In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line
            endings in the diff instead of the line endings in the target file.
          - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be
            re-used in parseDiff().
        * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1}
          to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use
          mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl.
        * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added.
        * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneat...
weinig@apple.com [Tue, 12 Apr 2011 17:11:42 +0000 (17:11 +0000)]
REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=58336

Reviewed by Adam Roben.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
Remove cache clearing as that is causing tests to crash on Windows 7.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 12 Apr 2011 17:07:33 +0000 (17:07 +0000)]
2011-04-12  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: remove scriptWorldType from the protocol.
        https://bugs.webkit.org/show_bug.cgi?id=58324

        * inspector/Inspector.json:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/ScriptDebugListener.h:
        (WebCore::ScriptDebugListener::~ScriptDebugListener):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype._parsedScriptSource):
        (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
        * inspector/front-end/Script.js:
        (WebInspector.Script):
        * inspector/front-end/ScriptsPanel.js:
        * inspector/front-end/SourceFile.js:
        (WebInspector.SourceFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 12 Apr 2011 16:44:56 +0000 (16:44 +0000)]
2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Carlson.

        Should MediaControls::changedNetworkState fiddle with Fullscreen controls?
        https://bugs.webkit.org/show_bug.cgi?id=58163

        Covered by existing tests and manual-tests/media-controls.html.

        * html/shadow/MediaControls.cpp:
        (WebCore::MediaControls::reset): Moved fullscreen showing/hiding here.
        (WebCore::MediaControls::changedNetworkState): ... from here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 12 Apr 2011 16:36:22 +0000 (16:36 +0000)]
2011-04-12  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove unnecessary method InspectorAgent.didEvaluateForTestInFrontend.
        https://bugs.webkit.org/show_bug.cgi?id=58335

        It was the method for Inspector layout tests.
        We can use RuntimeAgent.evaluate instead.

        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.completeTest):
2011-04-12  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove unnecessary method InspectorAgent.didEvaluateForTestInFrontend.
        https://bugs.webkit.org/show_bug.cgi?id=58335

        It was the method for Inspector layout tests.
        We can use RuntimeAgent.evaluate instead.

        * inspector/Inspector.json:
        * inspector/InspectorAgent.cpp:
        * inspector/InspectorAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::connectFrontend):
        * inspector/front-end/TestController.js:
        (WebInspector.TestController.prototype.notifyDone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMerge branch 'bug/58307' into staging
philn@webkit.org [Tue, 12 Apr 2011 16:34:43 +0000 (16:34 +0000)]
Merge branch 'bug/58307' into staging

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 12 Apr 2011 16:29:48 +0000 (16:29 +0000)]
2011-04-12  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GStreamer] advertize HTTP Live Streaming mime-type
        https://bugs.webkit.org/show_bug.cgi?id=58318

        Register the hls mime-type in the internal cache if found in the
        typefind factories.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mimeTypeCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 12 Apr 2011 16:24:38 +0000 (16:24 +0000)]
2011-04-11  MORITA Hajime  <morrita@google.com>

        Reviewed by Ryosuke Niwa.

        RenderIndicator and ShadowBlockElement are no longer used.
        https://bugs.webkit.org/show_bug.cgi?id=58277

        Removed RenderIndicator and ShadowBlockElement.

        No new tests. Just removed unused code.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderIndicator.cpp: Removed.
        * rendering/RenderIndicator.h: Removed.
        * rendering/RenderMeter.h:
        * rendering/RenderingAllInOne.cpp:
        * rendering/ShadowElement.cpp:
        * rendering/ShadowElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=58334
beidson@apple.com [Tue, 12 Apr 2011 16:22:12 +0000 (16:22 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=58334
LayoutTestController.computedStyleIncludingVisitedInfo-based tests don't work in WK2

Rubberstamped by Adam Roben.

* platform/mac-wk2/Skipped: Skip a new test due to an identified bug in WKTR and classify
  three other skipped tests with that same bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 12 Apr 2011 16:13:57 +0000 (16:13 +0000)]
2011-04-12  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Adjusted chromium test expectations (webgl-reflection.html sometimes crashes on chromium mac debug)

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/css/dashboard-regions-attr-crash.html asserts
ossy@webkit.org [Tue, 12 Apr 2011 15:58:49 +0000 (15:58 +0000)]
fast/css/dashboard-regions-attr-crash.html asserts
https://bugs.webkit.org/show_bug.cgi?id=58233

Reviewed by Benjamin Poulain.

Move DASHBOARD_SUPPORT feature detection from features.pri to CodeGenerators.pri
not to generate incorrect properties into CSSPropertyNames.h.

* CodeGenerators.pri:
* features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Leopard Intel Debug Tests] fast/events/tabindex-focus-blur-all.html crashing since...
jberlin@webkit.org [Tue, 12 Apr 2011 15:56:44 +0000 (15:56 +0000)]
[Leopard Intel Debug Tests] fast/events/tabindex-focus-blur-all.html crashing since (83513,
83521].
https://bugs.webkit.org/show_bug.cgi?id=58327

Skip the test on Leopard to get the bots green.

* platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Windows expected failure results for a new test
aroben@apple.com [Tue, 12 Apr 2011 15:50:30 +0000 (15:50 +0000)]
Add Windows expected failure results for a new test

<http://webkit.org/b/58325> tracks the failure.

* platform/win/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove no-longer-needed Windows-specific results for an arraybuffer test
aroben@apple.com [Tue, 12 Apr 2011 15:49:57 +0000 (15:49 +0000)]
Remove no-longer-needed Windows-specific results for an arraybuffer test

Fixes <http://webkit.org/b/58326> REGRESSION (r83532):
http/tests/xmlhttprequest/send-array-buffer.html failing on Windows

* platform/win/http/tests/xmlhttprequest/send-array-buffer-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION: WK2: misspelled AX attributes no longer returned from text fields
cfleizach@apple.com [Tue, 12 Apr 2011 15:45:46 +0000 (15:45 +0000)]
REGRESSION: WK2: misspelled AX attributes no longer returned from text fields
https://bugs.webkit.org/show_bug.cgi?id=58304

Reviewed by Dan Bernstein.

checkSpellingOfString is no longer implemented in WK2. Accessibility needs to change to use
checkTextOfParagraph in order to retrieve misspelled ranges.

Existing tests cover this functionality.

* accessibility/mac/AccessibilityObjectWrapper.mm:
(AXAttributeStringSetSpelling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocompositing/objects/composited-object-alignment.html causing failures in other tests...
jberlin@webkit.org [Tue, 12 Apr 2011 15:35:30 +0000 (15:35 +0000)]
compositing/objects/composited-object-alignment.html causing failures in other tests since
it's introduction in r83518
https://bugs.webkit.org/show_bug.cgi?id=58323

Disabling the test until it is fixed in order to get the bots green.

* compositing/objects/composited-object-alignment.html: Removed.
* compositing/objects/composited-object-alignment.html-disabled: Copied from LayoutTests/compositing/objects/composited-object-alignment.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Tue, 12 Apr 2011 14:43:20 +0000 (14:43 +0000)]
2011-04-12  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Remove m_idleHandler from ResourceHandleSoup
        https://bugs.webkit.org/show_bug.cgi?id=58319

        The m_idleHandler attribute is no longer used in ResourceHandleSoup.
        No new tests needed, no functionality change.

        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandleInternal::~ResourceHandleInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Andrey Adaikin <aandrey@google.com>
commit-queue@webkit.org [Tue, 12 Apr 2011 14:01:49 +0000 (14:01 +0000)]
2011-04-12  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Breakpoints and execution line decoration should stay in place if the edited line is not whitespace
        https://bugs.webkit.org/show_bug.cgi?id=58314

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._lineNumberAfterEditing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 12 Apr 2011 13:52:32 +0000 (13:52 +0000)]
2011-04-11  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: move shortcut handlers from SourceFrame to TextViewer.
        https://bugs.webkit.org/show_bug.cgi?id=58238

        * inspector/debugger/live-edit.html:
2011-04-11  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: move shortcut handlers from SourceFrame to TextViewer.
        https://bugs.webkit.org/show_bug.cgi?id=58238

        Commit/cancel editing functionality is common for all resource types, and it deals with TextViewer state.

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame):
        (WebInspector.SourceFrame.prototype.isContentEditable):
        (WebInspector.SourceFrame.prototype._createTextViewer):
        (WebInspector.SourceFrame.prototype.commitEditing.didEditContent):
        (WebInspector.SourceFrame.prototype.commitEditing):
        (WebInspector.SourceFrame.prototype.cancelEditing):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype._doubleClick):
        (WebInspector.TextViewer.prototype._registerShortcuts):
        (WebInspector.TextViewer.prototype._handleKeyDown):
        (WebInspector.TextViewer.prototype._commitEditing.didCommitEditing):
        (WebInspector.TextViewer.prototype._commitEditing):
        (WebInspector.TextViewer.prototype._cancelEditing):
        (WebInspector.TextViewerDelegate.prototype.endEditing):
        (WebInspector.TextViewerDelegate.prototype.commitEditing):
        (WebInspector.TextViewerDelegate.prototype.cancelEditing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 12 Apr 2011 13:25:43 +0000 (13:25 +0000)]
2011-04-12  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: cookies view is empty even for sites with cookies.
        https://bugs.webkit.org/show_bug.cgi?id=58316

        * http/tests/inspector/resource-tree-model-expected.txt: Added.
        * http/tests/inspector/resource-tree-model.html: Added.
2011-04-12  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: cookies view is empty even for sites with cookies.
        https://bugs.webkit.org/show_bug.cgi?id=58316

        Test: http/tests/inspector/resource-tree-model.html

        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel.prototype._callForFrameResources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 12 Apr 2011 13:03:49 +0000 (13:03 +0000)]
2011-04-12  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: InspectorTest.addObject dumps inner array properties as objects.
        https://bugs.webkit.org/show_bug.cgi?id=58310

        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.addObject):
        (initialize_InspectorTest.InspectorTest.addArray):
        (initialize_InspectorTest.InspectorTest.dump):
        * http/tests/inspector/resource-har-conversion-expected.txt:
        * http/tests/inspector/resource-parameters-expected.txt:
        * inspector/protocol/console-agent-expected.txt:
        * inspector/protocol/runtime-agent-expected.txt:
        * inspector/report-protocol-errors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 12 Apr 2011 12:57:03 +0000 (12:57 +0000)]
2011-04-11  Stephen White  <senorblanco@chromium.org>

        Reviewed by James Robinson.

        [chromium] GPU-accelerated canvas-to-canvas drawImage is incorrect.
        https://bugs.webkit.org/show_bug.cgi?id=58258

        When one accelerated canvas is drawn to another via drawImage(), if the
        prior call in the source canvas was non-accelerated, the
        hardware canvas is not up-to-date, and the results will be incorrect.
        Fixed by calling prepareForHardwareDraw() on the source context.

        Test: fast/canvas/canvas-to-canvas.html

        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::ImageBuffer::draw):
2011-04-11  Stephen White  <senorblanco@chromium.org>

        Reviewed by James Robinson.

        [chromium] Accelerated canvas-to-canvas drawImage() is incorrect.
        https://bugs.webkit.org/show_bug.cgi?id=58258

        Add a new test to cover canvas-to-canvas drawImage() after a
        non-accelerated (strokeRect()) call.

        * fast/canvas/canvas-to-canvas-expected.txt: Added.
        * fast/canvas/canvas-to-canvas.html: Added.
        * fast/canvas/script-tests/canvas-to-canvas.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Tue, 12 Apr 2011 12:28:11 +0000 (12:28 +0000)]
2011-04-12  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Add some more tests for detailed heap snapshots UI.
        https://bugs.webkit.org/show_bug.cgi?id=58146

        Tests: inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting.html
               inspector/profiler/detailed-heapshots-comparison-show-all.html
               inspector/profiler/detailed-heapshots-comparison-show-next.html
               inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting.html
               inspector/profiler/detailed-heapshots-comparison-sorting.html
               inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting.html
               inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting.html
               inspector/profiler/detailed-heapshots-dominators-show-all.html
               inspector/profiler/detailed-heapshots-dominators-show-next.html
               inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting.html
               inspector/profiler/detailed-heapshots-dominators-sorting.html
               inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting.html

        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotDiffDataGrid):

2011-04-12  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Add some more tests for detailed heap snapshots UI.
        https://bugs.webkit.org/show_bug.cgi?id=58146

        * inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-comparison-show-all-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-comparison-show-all.html: Added.
        * inspector/profiler/detailed-heapshots-comparison-show-next-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-comparison-show-next.html: Added.
        * inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting.html: Copied from LayoutTests/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html.
        * inspector/profiler/detailed-heapshots-comparison-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-comparison-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-dominators-show-all-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-dominators-show-all.html: Added.
        * inspector/profiler/detailed-heapshots-dominators-show-next-actual.txt: Added.
        * inspector/profiler/detailed-heapshots-dominators-show-next-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-dominators-show-next.html: Added.
        * inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-dominators-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-dominators-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html:
        * inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting.html: Copied from LayoutTests/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html.
        * inspector/profiler/detailed-heapshots-test.js:
        (initialize_DetailedHeapshotTest.):
        (initialize_DetailedHeapshotTest):
        * platform/chromium/inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-comparison-show-all-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-comparison-show-next-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-comparison-sorting-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-dominators-show-all-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-dominators-show-next-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-dominators-sorting-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 12 Apr 2011 12:12:04 +0000 (12:12 +0000)]
2011-04-12  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: there was incorrect value of id property of responses for malformed json-rpc 2.0 requests.
        https://bugs.webkit.org/show_bug.cgi?id=58305

        It was 0 if the message is not a json object or it has no id property. But according to spec it must be null.

        * inspector/CodeGeneratorInspector.pm:

2011-04-12  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: there was incorrect value of id property of responses for malformed json-rpc 2.0 requests.
        https://bugs.webkit.org/show_bug.cgi?id=58305

        It was 0 if the message is not a json object or it has no id property. But according to spec it must be null.

        * inspector/report-protocol-errors-expected.txt:
        * inspector/report-protocol-errors.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Tue, 12 Apr 2011 12:00:33 +0000 (12:00 +0000)]
2011-04-12  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public header file.
        https://bugs.webkit.org/show_bug.cgi?id=58251

        Fix an issue with slot names after http://trac.webkit.org/changeset/83512.

        * Api/qwebframe.cpp:
        (QWebFrame::QWebFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 12 Apr 2011 11:39:43 +0000 (11:39 +0000)]
2011-04-11  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [chromium] script formatting doesn't work when chromium is built with debug_devtools=1.
        https://bugs.webkit.org/show_bug.cgi?id=58232

        * WebCore.gypi:
2011-04-11  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [chromium] script formatting doesn't work when chromium is built with debug_devtools=1.
        https://bugs.webkit.org/show_bug.cgi?id=58232

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 12 Apr 2011 11:38:11 +0000 (11:38 +0000)]
2011-04-12  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: REGRESSION: Most resources in the Network panel show a blank panel when clicked.
        https://bugs.webkit.org/show_bug.cgi?id=58273

        * inspector/debugger/source-frame-expected.txt:
        * inspector/debugger/source-frame.html:
2011-04-12  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: REGRESSION: Most resources in the Network panel show a blank panel when clicked.
        https://bugs.webkit.org/show_bug.cgi?id=58273

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame):
        (WebInspector.SourceFrame.prototype.get visible):
        (WebInspector.SourceFrame.prototype.set visible):
        (WebInspector.SourceFrame.prototype.show):
        (WebInspector.SourceFrame.prototype.hide):
        (WebInspector.SourceFrame.prototype.detach):
        (WebInspector.SourceFrame.prototype._ensureContentLoaded):
        (WebInspector.SourceFrame.prototype.markDiff):
        (WebInspector.SourceFrame.prototype.addMessage):
        (WebInspector.SourceFrame.prototype.clearMessages):
        (WebInspector.SourceFrame.prototype.get scrollTop):
        (WebInspector.SourceFrame.prototype.set scrollTop):
        (WebInspector.SourceFrame.prototype.highlightLine):
        (WebInspector.SourceFrame.prototype._clearLineHighlight):
        (WebInspector.SourceFrame.prototype._initializeTextViewer):
        (WebInspector.SourceFrame.prototype.performSearch):
        (WebInspector.SourceFrame.prototype.searchCanceled):
        (WebInspector.SourceFrame.prototype._jumpToSearchResult):
        (WebInspector.SourceFrame.prototype.setExecutionLine):
        (WebInspector.SourceFrame.prototype.clearExecutionLine):
        (WebInspector.SourceFrame.prototype.resize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 12 Apr 2011 11:37:10 +0000 (11:37 +0000)]
2011-04-12  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: document runtime agent, share remote object definition between domains.
        https://bugs.webkit.org/show_bug.cgi?id=58246

        * inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 12 Apr 2011 11:35:50 +0000 (11:35 +0000)]
2011-04-12  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: document console domain, support cross-domain type references.
        https://bugs.webkit.org/show_bug.cgi?id=58240

        * inspector/protocol/console-agent-expected.txt:
2011-04-12  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: document console domain, support cross-domain type references.
        https://bugs.webkit.org/show_bug.cgi?id=58240

        * inspector/ConsoleMessage.cpp:
        (WebCore::messageSourceValue):
        (WebCore::messageTypeValue):
        (WebCore::messageLevelValue):
        (WebCore::ConsoleMessage::addToFrontend):
        * inspector/Inspector.json:
        * inspector/ScriptCallFrame.cpp:
        (WebCore::ScriptCallFrame::buildInspectorObject):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):
        (WebInspector.ConsoleMessage):
        (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
        (WebInspector.ConsoleMessage.prototype.isEqual):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
        * inspector/generate-inspector-idl:
        * page/Console.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83575 268f45cc-cd09-0410-ab3c-d52691b4dbfc