WebKit-https.git
9 years ago2011-08-16 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 16 Aug 2011 18:56:43 +0000 (18:56 +0000)]
2011-08-16  Daniel Bates  <dbates@webkit.org>

        Add myself to the list of individual members in the WebKit Security Group.

        Rubber-stamped by Eric Seidel.

        * security/security-group-members.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium Mac: Rubber banding gutter drawing
commit-queue@webkit.org [Tue, 16 Aug 2011 18:45:35 +0000 (18:45 +0000)]
Chromium Mac: Rubber banding gutter drawing
https://bugs.webkit.org/show_bug.cgi?id=66226

Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
draw the overhang areas.
Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
Add a different implementation for Chromium Mac.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-16
Reviewed by Dimitri Glazkov.

No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.

* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::paintOverhangAreas):
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paintOverhangAreas):
* platform/ScrollbarThemeComposite.h:
* platform/chromium/ScrollbarThemeChromiumMac.h:
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoProgrammatically set selection should not have direction on Mac
rniwa@webkit.org [Tue, 16 Aug 2011 18:39:52 +0000 (18:39 +0000)]
Programmatically set selection should not have direction on Mac
https://bugs.webkit.org/show_bug.cgi?id=60529

Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-12
Reviewed by Ryosuke Niwa.

Source/WebCore:

Modified default value of VisibleSelection->m_isDirectional from 'true'
to 'false' by adding a defaulted argument to several VisibleSelection
constructors to make programmatic selection be directionless by default
on Mac. Also modified several calls to VisibleSelection's constructors
to correctly preserve directionality.

Near the end of FrameSelection::modify (presently FrameSelection.cpp:869)
a call to setExtent triggers an editing delegate that uses the
FrameSelection. The direction here should have been preserved from before,
but setIsDirectional was not called until after FrameSelection.cpp:869. It
has been moved up to make things behave.

* WebCore.exp.in:
* editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::doApply):
(WebCore::ApplyBlockElementCommand::formatSelection):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::updateStartEnd):
* editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphWithClones):
(WebCore::CompositeEditCommand::moveParagraphs):
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
* editing/CreateLinkCommand.cpp:
(WebCore::CreateLinkCommand::doApply):
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete):
(WebCore::DeleteSelectionCommand::doApply):
* editing/Editor.cpp:
(WebCore::Editor::selectionForCommand):
* editing/FrameSelection.cpp:
(WebCore::shouldAlwaysUseDirectionalSelection):
(WebCore::FrameSelection::FrameSelection):
(WebCore::FrameSelection::moveTo):
(WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):
(WebCore::FrameSelection::modify):
(WebCore::FrameSelection::setBase):
(WebCore::FrameSelection::setExtent):
* editing/FrameSelection.h:
* editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::doApply):
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply):
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::performTrivialReplace):
(WebCore::InsertTextCommand::doApply):
* editing/MoveSelectionCommand.cpp:
(WebCore::MoveSelectionCommand::doApply):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::makeEditableRootEmpty):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::VisibleSelection):
* editing/VisibleSelection.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart):
(WebCore::EventHandler::updateSelectionForMouseDrag):

LayoutTests:

Added editing/selection/programmatic-selection-on-mac-is-directionless
to test selection direction in programmatically set selections on
windows, unix, and mac, in plain text, editable divs, text-input
fields, and textareas. Modified text baselines for many editing tests,
which had a delegate change as a result of the cpp patch.

* editing/deleting/delete-ligature-003-expected.txt:
* editing/deleting/paragraph-in-preserveNewline-expected.txt:
* editing/deleting/whitespace-pre-1-expected.txt:
* editing/selection/after-line-break-expected.txt:
* platform/mac/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
* platform/mac/editing/deleting/delete-and-undo-expected.txt:
* platform/mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
* platform/mac/editing/deleting/delete-br-002-expected.txt:
* platform/mac/editing/deleting/delete-br-004-expected.txt:
* platform/mac/editing/deleting/delete-br-005-expected.txt:
* platform/mac/editing/deleting/delete-br-006-expected.txt:
* platform/mac/editing/deleting/delete-br-009-expected.txt:
* platform/mac/editing/deleting/delete-br-010-expected.txt:
* platform/mac/editing/deleting/delete-br-011-expected.txt:
* platform/mac/editing/deleting/delete-ws-fixup-003-expected.txt:
* platform/mac/editing/deleting/delete-ws-fixup-004-expected.txt:
* platform/mac/editing/deleting/smart-delete-002-expected.txt:
* platform/mac/editing/inserting/insert-3800346-fix-expected.txt:
* platform/mac/editing/inserting/insert-at-end-01-expected.txt:
* platform/mac/editing/inserting/insert-at-end-02-expected.txt:
* platform/mac/editing/inserting/insert-div-010-expected.txt:
* platform/mac/editing/inserting/insert-div-013-expected.txt:
* platform/mac/editing/inserting/insert-div-015-expected.txt:
* platform/mac/editing/inserting/insert-div-019-expected.txt:
* platform/mac/editing/inserting/insert-paragraph-03-expected.txt:
* platform/mac/editing/pasteboard/3976872-expected.txt:
* platform/mac/editing/pasteboard/4076267-2-expected.txt:
* platform/mac/editing/pasteboard/4076267-expected.txt:
* platform/mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
* platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
* platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
* platform/mac/editing/pasteboard/paste-text-014-expected.txt:
* platform/mac/editing/pasteboard/paste-text-015-expected.txt:
* platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
* platform/mac/editing/selection/4932260-1-expected.txt:
* platform/mac/editing/selection/anchor-focus2-expected.txt:
* platform/mac/editing/selection/anchor-focus3-expected.txt:
* platform/mac/editing/selection/expanding-selections-expected.txt:
* platform/mac/editing/selection/expanding-selections2-expected.txt:
* platform/mac/editing/selection/fake-drag-expected.txt:
* platform/mac/editing/selection/move-by-word-001-expected.txt:
* platform/mac/editing/selection/transformed-selection-rects-expected.txt:
* platform/mac/editing/selection/triple-click-in-pre-expected.txt:
* platform/mac/editing/style/create-block-for-style-008-expected.txt:
* platform/mac/editing/undo/4063751-expected.txt:
* platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
* platform/mac/editing/undo/undo-forward-delete-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNew XML parser: Add document fragment parser
jpfau@apple.com [Tue, 16 Aug 2011 18:36:57 +0000 (18:36 +0000)]
New XML parser: Add document fragment parser
https://bugs.webkit.org/show_bug.cgi?id=66317

Reviewed by Adam Barth.

* dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::parseXML):
* xml/parser/NewXMLDocumentParser.cpp:
(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::parseDocumentFragment):
* xml/parser/NewXMLDocumentParser.h:
(WebCore::NewXMLDocumentParser::create):
* xml/parser/XMLTokenizer.h:
* xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::XMLTreeBuilder):
(WebCore::XMLTreeBuilder::pushCurrentNode):
* xml/parser/XMLTreeBuilder.h:
(WebCore::XMLTreeBuilder::create):
(WebCore::XMLTreeBuilder::NodeStackItem::node):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Mark svg/wicd/test-rightsizing-a.xhtml as flakey.
tony@chromium.org [Tue, 16 Aug 2011 18:36:18 +0000 (18:36 +0000)]
[chromium] Mark svg/wicd/test-rightsizing-a.xhtml as flakey.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGraphicsContext3D should allow its hostWindow to be NULL
senorblanco@chromium.org [Tue, 16 Aug 2011 18:23:44 +0000 (18:23 +0000)]
GraphicsContext3D should allow its hostWindow to be NULL
https://bugs.webkit.org/show_bug.cgi?id=66305

Allow the hostWindow param (and m_webViewImpl) to be NULL.  This
makes it much easier to enable GPU acceleration at a lower level
in WebKit's platform/graphics layer, without needing access to the
Page* or HostWindow*.  Also bump the chromium DEPS to chrome r96940,
which includes a similar change for the in-process GraphicsContext3D
implementations.

Reviewed by James Robinson.

* DEPS:
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DInternal::initialize):
(WebCore::GraphicsContext3DInternal::platformTexture):
(WebCore::GraphicsContext3DInternal::paintsIntoCanvasBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNew XML parser: Replace assertions regarding character data in the prolog with proper...
jpfau@apple.com [Tue, 16 Aug 2011 18:07:20 +0000 (18:07 +0000)]
New XML parser: Replace assertions regarding character data in the prolog with proper checks
https://bugs.webkit.org/show_bug.cgi?id=66269

Reviewed by Adam Barth.

This patch checks for character data in the prolog (which is illegal in XML) and discards it, instead of failing an assertion.

* xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processProcessingInstruction):
(WebCore::XMLTreeBuilder::processXMLDeclaration):
(WebCore::XMLTreeBuilder::processDOCTYPE):
(WebCore::XMLTreeBuilder::enterText):
(WebCore::XMLTreeBuilder::failOnText):
* xml/parser/XMLTreeBuilder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Mark fast/css/last-of-type-pseudo-class.html as flaky in
tony@chromium.org [Tue, 16 Aug 2011 18:04:54 +0000 (18:04 +0000)]
[chromium] Mark fast/css/last-of-type-pseudo-class.html as flaky in
debug (not just snowleopard).

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Windows expected results for resource-har-conversion.html
aroben@apple.com [Tue, 16 Aug 2011 18:03:29 +0000 (18:03 +0000)]
Add Windows expected results for resource-har-conversion.html

While Windows and Lion both agree on the MIME type of the cached .js files, Windows has some
extra fields in the request objects.

* platform/win/http/tests/inspector/resource-har-conversion-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: word wrap long edits
apavlov@chromium.org [Tue, 16 Aug 2011 17:58:52 +0000 (17:58 +0000)]
Web Inspector: word wrap long edits
https://bugs.webkit.org/show_bug.cgi?id=65512

Reviewed by Pavel Feldman.

* inspector/front-end/inspector.css:
(.styles-section .properties li.child-editing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Chromium] Add deployment of NetworkPanel .css files to concatenated...
mnaganov@chromium.org [Tue, 16 Aug 2011 17:31:41 +0000 (17:31 +0000)]
Web Inspector: [Chromium] Add deployment of NetworkPanel .css files to concatenated version
https://bugs.webkit.org/show_bug.cgi?id=66316

Reviewed by NOBODY (OOPS!).

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: convert DOM breakpoint types to strings.
pfeldman@chromium.org [Tue, 16 Aug 2011 17:27:24 +0000 (17:27 +0000)]
Web Inspector: convert DOM breakpoint types to strings.
https://bugs.webkit.org/show_bug.cgi?id=66304

Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::domTypeForName):
(WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):
* inspector/InspectorDOMDebuggerAgent.h:
* inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCopy the results of http/tests/inspector/resource-har-conversion.html
tony@chromium.org [Tue, 16 Aug 2011 17:23:02 +0000 (17:23 +0000)]
Copy the results of http/tests/inspector/resource-har-conversion.html
to the chromium platform dir.  The mac result (r93112) was getting
picked up by the chromium port.

* platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove media/video-controls-no-scripting-iframe.html into the resources
tony@chromium.org [Tue, 16 Aug 2011 17:16:27 +0000 (17:16 +0000)]
Move media/video-controls-no-scripting-iframe.html into the resources
subdir since it's not a standalone test.

Also add chromium baseline (the top of the video control is in a
different place).

* media/resources/video-controls-no-scripting-iframe.html: Renamed from LayoutTests/media/video-controls-no-scripting-iframe.html.
* media/video-controls-no-scripting.html:
* platform/chromium/media/video-controls-no-scripting-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: force pseudo element state when checking it in the styles sidebar.
pfeldman@chromium.org [Tue, 16 Aug 2011 17:15:06 +0000 (17:15 +0000)]
Web Inspector: force pseudo element state when checking it in the styles sidebar.
https://bugs.webkit.org/show_bug.cgi?id=66292

This reverts http://trac.webkit.org/changeset/89132 and introduces InspectorInstrumentation
calls from the CSSStyleSelector for pseudo state processing. These calls are very fast:
they are guarded with the inline checks for the front-end count.

Reviewed by David Hyatt.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::CSSStyleSelector::styleRulesForElement):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
* css/CSSStyleSelector.h:
* inspector/InspectorCSSAgent.cpp:
(WebCore::computePseudoClassMask):
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore::InspectorCSSAgent::getStylesForNode):
(WebCore::InspectorCSSAgent::didRemoveDocument):
(WebCore::InspectorCSSAgent::didRemoveDOMNode):
(WebCore::InspectorCSSAgent::clearPseudoState):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::disconnectFrontend):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::forcePseudoStateImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::forcePseudoState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r93114.
tony@chromium.org [Tue, 16 Aug 2011 16:57:42 +0000 (16:57 +0000)]
Unreviewed, rolling out r93114.
http://trac.webkit.org/changeset/93114
https://bugs.webkit.org/show_bug.cgi?id=66226

broke the chromium mac compile

* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollbarTheme.h:
* platform/ScrollbarThemeComposite.cpp:
* platform/ScrollbarThemeComposite.h:
* platform/chromium/ScrollbarThemeChromiumMac.h:
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
* platform/mac/ScrollbarThemeMac.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Windows results for a fast/text test for Safari 5.1's AAS
aroben@apple.com [Tue, 16 Aug 2011 16:56:02 +0000 (16:56 +0000)]
Update Windows results for a fast/text test for Safari 5.1's AAS

The results are now more like Mac's. Dan Bernstein says this is probably a progression.

* platform/win/fast/text/justify-ideograph-leading-expansion-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Mark media/video-source-error.html as flaky in Debug.
tony@chromium.org [Tue, 16 Aug 2011 16:46:10 +0000 (16:46 +0000)]
[chromium] Mark media/video-source-error.html as flaky in Debug.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Windows results after r92890
aroben@apple.com [Tue, 16 Aug 2011 16:44:14 +0000 (16:44 +0000)]
Update Windows results after r92890

* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove Windows-specific hyphenation test results now that hyphenation works on Windows
aroben@apple.com [Tue, 16 Aug 2011 16:39:08 +0000 (16:39 +0000)]
Remove Windows-specific hyphenation test results now that hyphenation works on Windows

* platform/win/fast/text/hyphenate-first-word-expected.txt: Removed.
* platform/win/fast/text/hyphenate-limit-before-after-expected.txt: Removed.
* platform/win/fast/text/hyphenate-locale-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium Mac: Rubber banding gutter drawing
commit-queue@webkit.org [Tue, 16 Aug 2011 16:34:05 +0000 (16:34 +0000)]
Chromium Mac: Rubber banding gutter drawing
https://bugs.webkit.org/show_bug.cgi?id=66226

Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
draw the overhang areas.
Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
Add a different implementation for Chromium Mac.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-16
Reviewed by Dimitri Glazkov.

No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.

* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::paintOverhangAreas):
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paintOverhangAreas):
* platform/ScrollbarThemeComposite.h:
* platform/chromium/ScrollbarThemeChromiumMac.h:
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCopy the results of http/tests/xmlhttprequest/web-apps/01[23].html
tony@chromium.org [Tue, 16 Aug 2011 16:31:49 +0000 (16:31 +0000)]
Copy the results of http/tests/xmlhttprequest/web-apps/01[23].html
to the chromium platform dir.  The mac failing results (r93105) were
getting picked up by the chromium port.

* platform/chromium/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
* platform/chromium/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Lion/Windows expected results for an Inspector test
aroben@apple.com [Tue, 16 Aug 2011 16:28:24 +0000 (16:28 +0000)]
Add Lion/Windows expected results for an Inspector test

The only difference from the cross-platform results is that the .js resources are now given
a MIME type of "text/plain".

This test reloads the page before dumping it in HAR format. In Lion (and Safari 5.1 on
Windows), CFNetwork no longer uses the file extension as a fallback when determining the
MIME type for 304 cached responses. This matches Chrome. See <rdar://problem/9313303>.

* platform/mac-snowleopard/http/tests/inspector/resource-har-conversion-expected.txt: Copied from http/tests/inspector/resource-har-conversion-expected.txt.
* platform/mac/http/tests/inspector/resource-har-conversion-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTeach TestFailures how to interpret unfinished test runs
aroben@apple.com [Tue, 16 Aug 2011 16:27:54 +0000 (16:27 +0000)]
Teach TestFailures how to interpret unfinished test runs

Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
rather than "isStarted" so that we don't count builds for which the test run never finished.
Bumped the cache version to evict old, buggy cached data.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
Added a test for the above, and made a somewhat synthetic test more realistic by including
more of the actual JSON data from build.webkit.org.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
(LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
cached data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSupport cast between CSSPrimitiveValue and ETransformStyle3D and use in CSSStyleSelector.
macpherson@chromium.org [Tue, 16 Aug 2011 16:19:18 +0000 (16:19 +0000)]
Support cast between CSSPrimitiveValue and ETransformStyle3D and use in CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=66273

Reviewed by Simon Fraser.

No new tests - no functionality changed - refactoring only.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Define cast from CSSPrimitiveValue to ETransformStyle3D.
(WebCore::CSSPrimitiveValue::operator ETransformStyle3D):
Define cast from ETransformStyle3D to CSSPrimitiveValue.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use appropriate macro to handle CSSPropertyWebkitTransformStyle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse appropriate macro to handle CSSPropertyWebkitContentOrder in CSSStyleSelector...
macpherson@chromium.org [Tue, 16 Aug 2011 16:18:20 +0000 (16:18 +0000)]
Use appropriate macro to handle CSSPropertyWebkitContentOrder in CSSStyleSelector::applyProperty()
https://bugs.webkit.org/show_bug.cgi?id=66279

Reviewed by Simon Fraser.

No new tests - no functionality changed - simple refactoring only.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to handle CSSPropertyWebkitContentOrder.
This works because PrimitiveValue now supports cast to int.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-16 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 16 Aug 2011 16:13:09 +0000 (16:13 +0000)]
2011-08-16  Eric Carlson  <eric.carlson@apple.com>

        [REGRESSION] Media controls should always be enabled when scripting is disabled
        https://bugs.webkit.org/show_bug.cgi?id=66303

        Reviewed by Dimitri Glazkov.

        Tests: media/video-controls-no-scripting-iframe.html
               media/video-controls-no-scripting.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::attributeChanged): Move the controls enabling/disabling code
            to configureMediaControls.
        (WebCore::HTMLMediaElement::prepareForLoad): Call configureMediaControls.
        (WebCore::HTMLMediaElement::configureMediaControls): New, move code duplicated in
            attributeChanged and preDispatchEventHandler here.
        (WebCore::HTMLMediaElement::preDispatchEventHandler): Move the controls enabling/disabling code
            to configureMediaControls.
        * html/HTMLMediaElement.h:

2011-08-16  Eric Carlson  <eric.carlson@apple.com>

        [REGRESSION] Media controls should always be enabled when scripting is disabled
        https://bugs.webkit.org/show_bug.cgi?id=66303

        Reviewed by Dimitri Glazkov.

        * media/video-controls-no-scripting-expected.txt: Added.
        * media/video-controls-no-scripting-iframe.html: Added.
        * media/video-controls-no-scripting.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake Apple's Windows port fall back to Lion results instead of SnowLeopard
aroben@apple.com [Tue, 16 Aug 2011 16:03:02 +0000 (16:03 +0000)]
Make Apple's Windows port fall back to Lion results instead of SnowLeopard

Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
should match Lion's behavior.

Fixes <http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
but doesn't use Lion results

Reviewed by David Kilzer.

* Scripts/old-run-webkit-tests:
(expectedDirectoryForTest):
* Scripts/webkitpy/layout_tests/port/win.py:
(WinPort.baseline_search_path):
* Scripts/webkitpy/layout_tests/port/win_unittest.py:
(WinPortTest.test_baseline_search_path):
Replaced mac-snowleopard with mac-lion.

* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
directory, which all Apple Mac platforms and Apple Win platforms could potentially use
results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
will no longer look there for results.

* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest.test_should_build): Tests for the above changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStop skipping the web-apps tests I just landed results for on Lion
aroben@apple.com [Tue, 16 Aug 2011 16:00:25 +0000 (16:00 +0000)]
Stop skipping the web-apps tests I just landed results for on Lion

* platform/mac-lion/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCheck in expected failure results for some web-apps tests on Lion and Windows
aroben@apple.com [Tue, 16 Aug 2011 15:57:24 +0000 (15:57 +0000)]
Check in expected failure results for some web-apps tests on Lion and Windows

Since these failures are likely due to bugs in non-WebKit components, they are tracked by
<rdar://problem/9313271>.

* platform/mac-snowleopard/http/tests/xmlhttprequest/web-apps/012-expected.txt: Copied from http/tests/xmlhttprequest/web-apps/012-expected.txt.
* platform/mac-snowleopard/http/tests/xmlhttprequest/web-apps/013-expected.txt: Copied from http/tests/xmlhttprequest/web-apps/013-expected.txt.
* platform/mac/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
* platform/mac/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShare Sputnik Unicode results between Lion and Windows
aroben@apple.com [Tue, 16 Aug 2011 15:51:37 +0000 (15:51 +0000)]
Share Sputnik Unicode results between Lion and Windows

Both Lion and Windows use ICU 4.6, so they have the same behavior on these tests.

* platform/mac-lion/Skipped: Removed these tests.

* platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt.
* platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt.
* platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt.
* platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt.
* platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt.
* platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt.
* platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt.
* platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Windows Sputnik results for ICU 4.6
aroben@apple.com [Tue, 16 Aug 2011 15:33:11 +0000 (15:33 +0000)]
Update Windows Sputnik results for ICU 4.6

Windows now fails these tests due to changes in ICU. Mac fails these tests, too, though in a
different way. Alexey tells me that these tests are silly because they check compliance with
a particular version of Unicode. Given this, it doesn't seem that a bug is required to track
this change in behavior.

* platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt:
* platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt:
* platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt:
* platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip some tests that fail/time out on Windows with Safari 5.1's Apple Application...
aroben@apple.com [Tue, 16 Aug 2011 15:16:20 +0000 (15:16 +0000)]
Skip some tests that fail/time out on Windows with Safari 5.1's Apple Application Support (AAS)

Since these failures are likely to be due to bugs in non-WebKit components, they are tracked
by Radars.

* platform/win/Skipped: Added http/tests/multipart/invalid-image-data-standalone.html,
http/tests/cookies/simple-cookies-expired.html, and
http/tests/cookies/simple-cookies-max-age.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: hide non-conservative methods from the protocol documentation.
pfeldman@chromium.org [Tue, 16 Aug 2011 14:53:32 +0000 (14:53 +0000)]
Web Inspector: hide non-conservative methods from the protocol documentation.
https://bugs.webkit.org/show_bug.cgi?id=66301

Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSet TIMEOUT expectation for fast/canvas/webgl/uninitialized-test.html on Linux dbg
steveblock@google.com [Tue, 16 Aug 2011 14:50:02 +0000 (14:50 +0000)]
Set TIMEOUT expectation for fast/canvas/webgl/uninitialized-test.html on Linux dbg

See http://code.google.com/p/chromium/issues/detail?id=93044

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd TIMEOUT expectation for editing/deleting/regional-indicators.html
steveblock@google.com [Tue, 16 Aug 2011 14:42:28 +0000 (14:42 +0000)]
Add TIMEOUT expectation for editing/deleting/regional-indicators.html
https://bugs.webkit.org/show_bug.cgi?id=66268

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: nuke background events collection (dead feature)
abecsi@webkit.org [Tue, 16 Aug 2011 14:39:23 +0000 (14:39 +0000)]
Web Inspector: nuke background events collection (dead feature)
https://bugs.webkit.org/show_bug.cgi?id=66296

Fix the GTK build after r93095.

Unreviewed build fix.

No new tests neede.

* GNUmakefile.list.am: Remove nonexistent sources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed by Csaba Osztrogon√°c.
abecsi@webkit.org [Tue, 16 Aug 2011 14:26:27 +0000 (14:26 +0000)]
Reviewed by Csaba Osztrogon√°c.

Need AtomicStrings for the various font family names
https://bugs.webkit.org/show_bug.cgi?id=28024

.:

* Source/cmake/WebKitMacros.cmake: Add new macro.

Source/WebCore:

Unify the usage of '-webkit' prefixed font family names by using
global AtomicStrings.
Use a .in file to generate the needed sources through make_names.pl.

No new tests needed.

* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.make:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_makenames.py:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::identifierForFamily):
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::fontDataForGenericFamily):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/WebKitFontFamilyNames.in: Added.
* dom/make_names.pl:
* page/Frame.cpp:
(WebCore::Frame::Frame):
* platform/graphics/FontCache.cpp:
(WebCore::FontCache::getFontData):
* platform/graphics/FontDescription.h:
(WebCore::FontDescription::useFixedDefaultSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Chromium] Fix 'inspector_resources' target to depend on 'concatenated...
mnaganov@chromium.org [Tue, 16 Aug 2011 14:15:35 +0000 (14:15 +0000)]
Web Inspector: [Chromium] Fix 'inspector_resources' target to depend on 'concatenated_heap_snapshot_worker_js'
https://bugs.webkit.org/show_bug.cgi?id=66300

Reviewed by Pavel Feldman.

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: nuke background events collection (dead feature)
pfeldman@chromium.org [Tue, 16 Aug 2011 13:41:51 +0000 (13:41 +0000)]
Web Inspector: nuke background events collection (dead feature)
https://bugs.webkit.org/show_bug.cgi?id=66296

Reviewed by Yury Semikhatsky.

Source/WebCore:

* CMakeLists.txt:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/EventsCollector.cpp: Removed.
* inspector/EventsCollector.h: Removed.
* inspector/Inspector.json:
* inspector/InspectorFrontendProxy.cpp: Removed.
* inspector/InspectorFrontendProxy.h: Removed.
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::setFrontend):
(WebCore::InspectorResourceAgent::clearFrontend):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
* inspector/InspectorResourceAgent.h:
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):

LayoutTests:

* http/tests/inspector/network-test.js:
* http/tests/inspector/network/network-clear-after-disabled-expected.txt: Removed.
* http/tests/inspector/network/network-clear-after-disabled.html: Removed.
* http/tests/inspector/network/network-close-load-open-expected.txt: Removed.
* http/tests/inspector/network/network-close-load-open.html: Removed.
* http/tests/inspector/network/network-open-load-reopen-expected.txt: Removed.
* http/tests/inspector/network/network-open-load-reopen.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofix
steveblock@google.com [Tue, 16 Aug 2011 13:38:54 +0000 (13:38 +0000)]
fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Missing spell check support
benjamin.poulain@nokia.com [Tue, 16 Aug 2011 13:11:23 +0000 (13:11 +0000)]
[Qt] Missing spell check support
https://bugs.webkit.org/show_bug.cgi?id=44114

Patch by Lindsay Mathieson <lindsay.mathieson@gmail.com> on 2011-08-16
Reviewed by Benjamin Poulain.

Source/WebCore:

Add drawErrorUnderline() from Cairo to render the line for text checking on the Qt port.

* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::drawErrorUnderline):
(WebCore::GraphicsContext::drawLineForTextChecking):

Source/WebKit/qt:

Added a platform plugin to allow spell and grammar check in QtWebKit.

* Api/qwebkitplatformplugin.h:
* QtWebKit.pro:
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::isContinuousSpellCheckingEnabled):
(WebCore::EditorClientQt::isGrammarCheckingEnabled):
(WebCore::EditorClientQt::toggleContinuousSpellChecking):
(WebCore::EditorClientQt::toggleGrammarChecking):
* WebCoreSupport/EditorClientQt.h:
(WebCore::EditorClientQt::textChecker):
* WebCoreSupport/QtPlatformPlugin.cpp:
(WebCore::QtPlatformPlugin::createSpellChecker):
* WebCoreSupport/QtPlatformPlugin.h:
* WebCoreSupport/TextCheckerClientQt.cpp: Added.
(convertToVectorList):
(WebCore::TextCheckerClientQt::ignoreWordInSpellDocument):
(WebCore::TextCheckerClientQt::learnWord):
(WebCore::TextCheckerClientQt::getAutoCorrectSuggestionForMisspelledWord):
(WebCore::TextCheckerClientQt::checkSpellingOfString):
(WebCore::TextCheckerClientQt::checkGrammarOfString):
(WebCore::TextCheckerClientQt::getGuessesForWord):
(WebCore::TextCheckerClientQt::isContinousSpellCheckingEnabled):
(WebCore::TextCheckerClientQt::toggleContinousSpellChecking):
(WebCore::TextCheckerClientQt::isGrammarCheckingEnabled):
(WebCore::TextCheckerClientQt::toggleGrammarChecking):
(WebCore::TextCheckerClientQt::loadSpellChecker):
* WebCoreSupport/TextCheckerClientQt.h: Added.
(WebCore::TextCheckerClientQt::requestCheckingOfString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd javascriptcoregtk to the introspection build, to fix it.
kov@webkit.org [Tue, 16 Aug 2011 13:01:42 +0000 (13:01 +0000)]
Add javascriptcoregtk to the introspection build, to fix it.

Patch by Gustavo Noronha Silva  <gustavo.noronha@collabora.com> in 2011-08-16
Reviewed by Xan Lopez.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKitTestRunner needs a more-complete implementation of eventSender
abecsi@webkit.org [Tue, 16 Aug 2011 12:46:59 +0000 (12:46 +0000)]
WebKitTestRunner needs a more-complete implementation of eventSender
https://bugs.webkit.org/show_bug.cgi?id=42194

Unreviewed gardening.

* platform/wk2/Skipped: skip editing/input/style-change-during-input.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove me from contributor to reviewer.
dino@apple.com [Tue, 16 Aug 2011 11:35:17 +0000 (11:35 +0000)]
Move me from contributor to reviewer.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: resource-tree-errors-reload.html is flaky.
vsevik@chromium.org [Tue, 16 Aug 2011 10:04:55 +0000 (10:04 +0000)]
Web Inspector: resource-tree-errors-reload.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=66217

Reviewed by Pavel Feldman.

* http/tests/inspector/resource-tree/resource-tree-errors-reload.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Ossyize editing/deleting/regional-indicators.html since it fails after r93068
zoltan@webkit.org [Tue, 16 Aug 2011 08:57:13 +0000 (08:57 +0000)]
[Qt] Ossyize editing/deleting/regional-indicators.html since it fails after r93068
https://bugs.webkit.org/show_bug.cgi?id=66268

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r70598): [Chromium] Style changes in textInput event can prevent from...
morrita@google.com [Tue, 16 Aug 2011 07:00:44 +0000 (07:00 +0000)]
REGRESSION(r70598): [Chromium] Style changes in textInput event can prevent from updating <textarea> value.
https://bugs.webkit.org/show_bug.cgi?id=66216

Reviewed by Ryosuke Niwa.

Source/WebCore:

Element::spellcheckAttributeState() uses Element::hasAttribute(),
which calls updateStyleAttribute(), which potentially makes style
dirty. But that is problematic since Editor calls spellcheckAttributeState()
during the spell-checking phase and make the style dirty,
which can trigger re-layout, which wipes the shadow tree of a textarea
out by pre-committed "value" text.

This change removes the hasAttribute() call from
spellcheckAttributeState().

Test: editing/input/style-change-during-input.html

* dom/Element.cpp:
(WebCore::Element::spellcheckAttributeState):

LayoutTests:

* editing/input/style-change-during-input-expected.txt: Added.
* editing/input/style-change-during-input.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMAKE] Wrap files of websocket and worker in each macro.
gyuyoung.kim@samsung.com [Tue, 16 Aug 2011 05:18:38 +0000 (05:18 +0000)]
[CMAKE] Wrap files of websocket and worker in each macro.
https://bugs.webkit.org/show_bug.cgi?id=65012

Move files of web socket and workers into each macro block in CMakeList.txt.
And, header files related to WORKER and SHARED_WORKER are wrapped by macro in cpp files.

Reviewed by Daniel Bates.

* CMakeLists.txt:
* UseJSC.cmake:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSWorkerContextBase.cpp:
* bindings/js/ScriptState.cpp:
* bindings/js/WorkerScriptController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=66263
barraclough@apple.com [Tue, 16 Aug 2011 01:37:18 +0000 (01:37 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=66263
DFG JIT does not always zero extend boolean result of DFG operations

* fast/js/kde/operators-expected.txt:
    - erk! missed new expected results from last commit!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNew XML parser: add xml namespace to the default map of namespaces
jpfau@apple.com [Tue, 16 Aug 2011 01:10:49 +0000 (01:10 +0000)]
New XML parser: add xml namespace to the default map of namespaces
https://bugs.webkit.org/show_bug.cgi?id=66266

Reviewed by Adam Barth.

* xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::NodeStackItem::NodeStackItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix crash when mouse moves from <summary> element to parent <details> element.
hayato@chromium.org [Tue, 16 Aug 2011 01:05:40 +0000 (01:05 +0000)]
Fix crash when mouse moves from <summary> element to parent <details> element.
https://bugs.webkit.org/show_bug.cgi?id=66210

Reviewed by Dimitri Glazkov.

This is a regression caused by r92922, which wrongly assumes that
a shadow host always has a shadow root as an immediate child in
ancestors chain. This assumption does not apply to <details>
element. <details> element is implemented as a shadow host, but
may have a <summary> element as an immediate child element in
ancestors chain.

Source/WebCore:

Test: fast/dom/shadow/details-summary-mouseover.html

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::adjustToShadowBoundaries):

LayoutTests:

* fast/dom/shadow/details-summary-mouseover-expected.txt: Added.
* fast/dom/shadow/details-summary-mouseover.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoA mousedown event is not dispatched when clicking on a disabled INPUT
rniwa@webkit.org [Tue, 16 Aug 2011 00:56:26 +0000 (00:56 +0000)]
A mousedown event is not dispatched when clicking on a disabled INPUT
https://bugs.webkit.org/show_bug.cgi?id=27795

Reviewed by Alexey Proskuryakov.

Add a regression test now that the bug no longer reproduces.

* fast/forms/disabled-mousedown-event-expected.txt: Added.
* fast/forms/disabled-mousedown-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Add WebFrameClient::didAdoptURLLoader() notification
dimich@chromium.org [Tue, 16 Aug 2011 00:32:44 +0000 (00:32 +0000)]
[Chromium] Add WebFrameClient::didAdoptURLLoader() notification
https://bugs.webkit.org/show_bug.cgi?id=66167

Reviewed by Darin Fisher.

* public/WebFrameClient.h:
(WebKit::WebFrameClient::didAdoptURLLoader):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::transferLoadingResourceFromPage):
* src/ResourceHandle.cpp:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(WebCore::ResourceHandleInternal::FromResourceHandle):
(WebCore::ResourceHandle::ResourceHandle):
(WebCore::ResourceHandle::firstRequest):
(WebCore::ResourceHandle::client):
(WebCore::ResourceHandle::setClient):
(WebCore::ResourceHandle::~ResourceHandle):
* src/ResourceHandleInternal.h: Added.
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandleInternal::setOwner):
(WebCore::ResourceHandleInternal::request):
(WebCore::ResourceHandleInternal::client):
(WebCore::ResourceHandleInternal::setClient):
(WebCore::ResourceHandleInternal::loader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNote that this new test fails.
abarth@webkit.org [Tue, 16 Aug 2011 00:32:09 +0000 (00:32 +0000)]
Note that this new test fails.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove expectation for this test, which no longer exists.
abarth@webkit.org [Tue, 16 Aug 2011 00:27:58 +0000 (00:27 +0000)]
Remove expectation for this test, which no longer exists.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd new passing expectations.
abarth@webkit.org [Tue, 16 Aug 2011 00:24:34 +0000 (00:24 +0000)]
Add new passing expectations.

* platform/chromium/fast/js/kde/operators-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNew XML parser: Use xmlnsAtom instead of redundant xmlnsPrefix
jpfau@apple.com [Tue, 16 Aug 2011 00:17:09 +0000 (00:17 +0000)]
New XML parser: Use xmlnsAtom instead of redundant xmlnsPrefix
https://bugs.webkit.org/show_bug.cgi?id=66264

Reviewed by Adam Barth.

* xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processNamespaces):
(WebCore::XMLTreeBuilder::processAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwitch Element/Node to to new layout types
eae@chromium.org [Mon, 15 Aug 2011 23:51:21 +0000 (23:51 +0000)]
Switch Element/Node to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66260

Reviewed by Eric Seidel.

Convert Element, Node, ElementRareData and ContainerNode to new layout
abstraction as a part of the ongoing conversion work.

No new tests, no new functionality.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::getLowerRightCorner):
(WebCore::ContainerNode::getRect):
* dom/ContainerNode.h:
* dom/Element.cpp:
(WebCore::Element::scrollIntoView):
(WebCore::Element::scrollIntoViewIfNeeded):
(WebCore::adjustForLocalZoom):
(WebCore::Element::boundsInWindowSpace):
(WebCore::Element::getClientRects):
(WebCore::Element::getBoundingClientRect):
(WebCore::Element::screenRect):
(WebCore::Element::minimumSizeForResizing):
(WebCore::Element::setMinimumSizeForResizing):
* dom/Element.h:
* dom/ElementRareData.h:
* dom/Node.cpp:
(WebCore::Node::getRect):
(WebCore::Node::renderRect):
(WebCore::Node::hasNonEmptyBoundingBox):
* dom/Node.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=66263
barraclough@apple.com [Mon, 15 Aug 2011 23:44:41 +0000 (23:44 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=66263
DFG JIT does not always zero extend boolean result of DFG operations

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
    - Change bool return values to a 64-bit type.

LayoutTests:

* fast/js/kde/script-tests/operators.js:
(nonSpeculativeNotInner):
(nonSpeculativeNot):
(nonSpeculativeLessInner):
(nonSpeculativeLess):
(nonSpeculativeLessEqInner):
(nonSpeculativeLessEq):
(nonSpeculativeGreaterInner):
(nonSpeculativeGreater):
(nonSpeculativeGreaterEqInner):
(nonSpeculativeGreaterEq):
(nonSpeculativeEqualInner):
(nonSpeculativeEqual):
(nonSpeculativeNotEqualInner):
(nonSpeculativeNotEqual):
(nonSpeculativeStrictEqualInner):
(nonSpeculativeStrictEqual):
(nonSpeculativeStrictNotEqualInner):
(nonSpeculativeStrictNotEqual):
    - Add tests cases that will hit the non-spec path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Committed by accident, restoring the test.
ap@apple.com [Mon, 15 Aug 2011 23:36:48 +0000 (23:36 +0000)]
    Committed by accident, restoring the test.

        * editing/deleting/delete-3928305-fix.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Regional indicator symbols that are combined should behave as a single charac...
ap@apple.com [Mon, 15 Aug 2011 23:34:29 +0000 (23:34 +0000)]
    Regional indicator symbols that are combined should behave as a single character when editing
        https://bugs.webkit.org/show_bug.cgi?id=65395

        Reviewed by Dan Bernstein.

        Part one: make backspace work.

        Test: editing/deleting/regional-indicators.html

        * rendering/RenderText.cpp:
        (WebCore::isRegionalIndicator):
        (WebCore::RenderText::previousOffsetForBackwardDeletion): Added a special case for regional
        indicator symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNew XML parser: Re-entering a character node should not clobber the buffered characters
jpfau@apple.com [Mon, 15 Aug 2011 23:18:25 +0000 (23:18 +0000)]
New XML parser: Re-entering a character node should not clobber the buffered characters
https://bugs.webkit.org/show_bug.cgi?id=66257

Reviewed by Adam Barth.

* xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::enterText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
dimich@chromium.org [Mon, 15 Aug 2011 22:49:41 +0000 (22:49 +0000)]
FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
https://bugs.webkit.org/show_bug.cgi?id=66165

Reviewed by Darin Fisher.

Source/WebCore:

No new tests since no change in behavior.
The original issue is only reproducible on Chromium in multi-process mode
and is tested there by a browsertest.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::transferLoadingResourcesFromPage):
Passing ResourceLoader* into the FrameLoaderClient notification.
Also, fixed the bug where the same ResourceRequest was passed for all subresources.
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::transferLoadingResourceFromPage):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchTransferLoadingResourceFromPage):
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::dispatchTransferLoadingResourceFromPage):
* loader/ResourceLoadNotifier.h:
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::init):
* loader/ResourceLoader.h:
(WebCore::ResourceLoader::originalRequest): Added the originalRequest() accessor that
returns the request as it existed before redirects (but after client's will SendRequest).
This is to be able to pass the original request for loading subresources into
FrameLoaderClient::transferLoadingResourceFromPage, since that one is used to invoke
assignIdentifierToInitialRequest, which needs original request.

Source/WebKit/chromium:

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::transferLoadingResourceFromPage):
* src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::transferLoadingResourceFromPage):
* WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::transferLoadingResourceFromPage):
* WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

* WebCoreSupport/FrameLoaderClientHaiku.cpp:
(WebCore::FrameLoaderClientHaiku::transferLoadingResourceFromPage):
* WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/mac:

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::transferLoadingResourceFromPage):

Source/WebKit/qt:

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::transferLoadingResourceFromPage):
* WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::transferLoadingResourceFromPage):
* WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

* WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::transferLoadingResourceFromPage):
* WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

* WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::transferLoadingResourceFromPage):
* WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transferLoadingResourceFromPage):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r93060.
abarth@webkit.org [Mon, 15 Aug 2011 22:43:14 +0000 (22:43 +0000)]
Unreviewed, rolling out r93060.
http://trac.webkit.org/changeset/93060
https://bugs.webkit.org/show_bug.cgi?id=66259

Does not compile on Chromium Windows (Requested by
abarth|gardener on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-15

* public/WebCache.h:
* public/WebFontCache.h:
* src/WebCache.cpp:
(WebKit::WebCache::clear):
* src/WebFontCache.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTouch a file to trigger a Windows build
aroben@apple.com [Mon, 15 Aug 2011 22:18:41 +0000 (22:18 +0000)]
Touch a file to trigger a Windows build

I'm trying to ferret out some issues with our Debug builder.

* WebView.cpp: Sorted #includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic frontend needs model.commitDataForRevisionRange function.
dglazkov@chromium.org [Mon, 15 Aug 2011 22:14:05 +0000 (22:14 +0000)]
garden-o-matic frontend needs model.commitDataForRevisionRange function.
https://bugs.webkit.org/show_bug.cgi?id=66252

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added commitDataForRevisionRange method.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Unreviewed build fix after r93058.
kbalazs@webkit.org [Mon, 15 Aug 2011 21:56:03 +0000 (21:56 +0000)]
[Qt][WK2] Unreviewed build fix after r93058.

* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::deviceScaleFactorDidChange):
* UIProcess/TiledDrawingAreaProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic frontend needs a generic way to track updates.
dglazkov@chromium.org [Mon, 15 Aug 2011 21:31:36 +0000 (21:31 +0000)]
garden-o-matic frontend needs a generic way to track updates.
https://bugs.webkit.org/show_bug.cgi?id=66245

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added UpdateTracker.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium: expose MemoryCache::prune and FontCache::purgeInactiveFontData.
mnaganov@chromium.org [Mon, 15 Aug 2011 21:28:13 +0000 (21:28 +0000)]
Chromium: expose MemoryCache::prune and FontCache::purgeInactiveFontData.
https://bugs.webkit.org/show_bug.cgi?id=66132

Reviewed by Darin Fisher.

* public/WebCache.h:
* public/WebFontCache.h:
* src/WebCache.cpp:
(WebKit::WebCache::prune):
* src/WebFontCache.cpp:
(WebKit::WebFontCache::prune):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactor JS objects to allocate in static create methods rather than constructors
commit-queue@webkit.org [Mon, 15 Aug 2011 21:12:11 +0000 (21:12 +0000)]
Refactor JS objects to allocate in static create methods rather than constructors
https://bugs.webkit.org/show_bug.cgi?id=65347

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-15
Reviewed by Geoffrey Garen.

Source/JavaScriptGlue:

Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
larger refactoring to get rid of all allocation during initialization.

* JSRun.cpp:
(JSGlueGlobalObject::JSGlueGlobalObject):
* JSRun.h:
(JSGlueGlobalObject::create):

Source/WebCore:

No new tests.

Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
larger refactoring to get rid of all allocation during initialization.

* bindings/js/JSDOMBinding.h:
* bridge/c/CRuntimeObject.cpp:
(JSC::Bindings::CRuntimeObject::CRuntimeObject):
* bridge/c/CRuntimeObject.h:
(JSC::Bindings::CRuntimeObject::create):
* bridge/c/c_instance.cpp:
(JSC::Bindings::CRuntimeMethod::create):
(JSC::Bindings::CRuntimeMethod::CRuntimeMethod):
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaRuntimeMethod::create):
(JavaRuntimeMethod::JavaRuntimeMethod):
* bridge/jni/jsc/JavaRuntimeObject.cpp:
(JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):
* bridge/jni/jsc/JavaRuntimeObject.h:
(JSC::Bindings::JavaRuntimeObject::create):
* bridge/objc/objc_runtime.h:
(JSC::Bindings::ObjcFallbackObjectImp::create):
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObject::create):
(JSC::Bindings::QtRuntimeObject::QtRuntimeObject):
* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapRuntimeObject::create):
(JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):
* bridge/qt/qt_runtime.h:
(JSC::Bindings::QtRuntimeMetaMethod::create):
(JSC::Bindings::QtRuntimeConnectionMethod::create):
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::RuntimeArray):
* bridge/runtime_array.h:
(JSC::RuntimeArray::create):
* bridge/runtime_object.cpp:

Source/WebKit/mac:

Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
larger refactoring to get rid of all allocation during initialization.

* Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyRuntimeMethod::create):
(WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate pages' style and content scale when the window's backing scale factor changes
aroben@apple.com [Mon, 15 Aug 2011 21:06:53 +0000 (21:06 +0000)]
Update pages' style and content scale when the window's backing scale factor changes

Unfortunately, I couldn't think of a way to test this in an automated fashion.

Fixes <http://webkit.org/b/66229> <rdar://problem/9906269> WebKit doesn't react to device
scale factor changes

Reviewed by Simon Fraser.

Source/WebCore:

* WebCore.exp.in: Export Frame::deviceOrScaleFactorChanged.

* page/Frame.cpp:
(WebCore::Frame::deviceScaleFactorChanged):
* page/Frame.h:
Added this new function. We recalc style so that, e.g., device-scale-factor-dependent media
queries will be reevaluated, and we tell compositing layers about the new scale factor so
they can rerender at the new resolution.

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView addWindowObserversForWindow:]):
(-[WebView removeWindowObservers]):
Listen for the notification that tells us the window's backing scale has changed.

(-[WebView _windowDidChangeResolution:]): Tell the page about the change to the device scale
factor so that, e.g., scale-factor-dependent media queries will be reevaluated.

Source/WebKit2:

* UIProcess/API/mac/WKView.mm:
(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):
Listen for the notification that tells us the window's backing scale has changed.

(-[WKView _windowDidChangeResolution:]): Tell the WebPageProxy about the change.

* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxyImpl.h:
Added deviceScaleFactorDidChange.

* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::deviceScaleFactorDidChange): Request a new backing store
since the current one is using an old device scale factor.
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState): Send the device scale factor
along to the web process so it can render accordingly. This is how we tell the web process
about device scale factor changes.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange): Tell the DrawingAreaProxy when the device scale
factor changes.
(WebKit::WebPageProxy::deviceScaleFactor): Added this simple getter that calls through to
the PageClient. DrawingAreaProxy uses this function.

* UIProcess/WebPageProxy.h: Added new members.

* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::updateBackingStoreState):
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/DrawingAreaImpl.h:
Send the device scale factor in the UpdateBackingStoreState message.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updateBackingStoreState): Tell the WebPage and LayerTreeHost about
the new device scale factor.

* WebProcess/WebPage/LayerTreeHost.h:
* WebProcess/WebPage/ca/LayerTreeHostCA.h:
Added deviceScaleFactorDidChange.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setDeviceScaleFactor): Store the new scale factor and tell the page about
it so that, e.g., scale-factor-dependent media queries will be reevaluated.

* WebProcess/WebPage/WebPage.h: Added setDeviceScaleFactor.

* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::deviceScaleFactorDidChange): Tell the layer for non-composited
content about the new scale factor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevise Skia on Chrome Mac to return fallback fonts.
caryclark@google.com [Mon, 15 Aug 2011 19:59:54 +0000 (19:59 +0000)]
Revise Skia on Chrome Mac to return fallback fonts.
https://bugs.webkit.org/show_bug.cgi?id=62986

Reviewed by Darin Fisher.

Since Skia on Chrome Mac uses CoreText to determine
text metrics, CG font architecture is used to return
fallback fonts.

This improves many existing layout tests, including
justify-ideograph-simple and t0905-c414-flt-04-c

* platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::canReturnFallbackFontsForComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Implement shouldRubberBandInDirection
thakis@chromium.org [Mon, 15 Aug 2011 19:59:08 +0000 (19:59 +0000)]
[chromium] Implement shouldRubberBandInDirection
https://bugs.webkit.org/show_bug.cgi?id=66206

Reviewed by Adam Barth.

History swiping can only start after an unhandled mouse wheel event
came back from the renderer, because mouse wheel javascript handlers
take precedence over history swiping. This means that rubberbanding
must not consume wheel events if they could trigger history, else
history swiping won't be triggered for pages without wheel handlers
either.

This is based on the implementation in
Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::shouldRubberBandInDirection):
* src/ChromeClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPass additional details to client in didCreateIsolatedContext
aa@chromium.org [Mon, 15 Aug 2011 19:52:19 +0000 (19:52 +0000)]
Pass additional details to client in didCreateIsolatedContext
https://bugs.webkit.org/show_bug.cgi?id=66037

Reviewed by Darin Fisher.

Source/WebCore:

* bindings/v8/IsolatedWorld.cpp:
(WebCore::IsolatedWorld::IsolatedWorld):
* bindings/v8/IsolatedWorld.h:
(WebCore::IsolatedWorld::create):
(WebCore::IsolatedWorld::id):
* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
* bindings/v8/V8IsolatedContext.h:
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext):
* loader/FrameLoaderClient.h:

Source/WebKit/chromium:

* public/WebFrameClient.h:
(WebKit::WebFrameClient::didCreateIsolatedScriptContext):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):
* src/FrameLoaderClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd shell implementation for Web Audio API's MediaElementAudioSourceNode
crogers@google.com [Mon, 15 Aug 2011 19:37:22 +0000 (19:37 +0000)]
Add shell implementation for Web Audio API's MediaElementAudioSourceNode
https://bugs.webkit.org/show_bug.cgi?id=66175

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/mediaelementaudiosourcenode.html

* DerivedSources.make:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLMediaElement.idl:
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::createMediaElementSource):
* webaudio/AudioContext.h:
* webaudio/AudioContext.idl:
* webaudio/AudioNode.h:
* webaudio/MediaElementAudioSourceNode.cpp: Added.
(WebCore::MediaElementAudioSourceNode::create):
(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::process):
(WebCore::MediaElementAudioSourceNode::reset):
* webaudio/MediaElementAudioSourceNode.h: Added.
(WebCore::MediaElementAudioSourceNode::mediaElement):
* webaudio/MediaElementAudioSourceNode.idl: Added.

LayoutTests:

* webaudio/mediaelementaudiosourcenode-expected.txt: Added.
* webaudio/mediaelementaudiosourcenode.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwitch mouse events to to new layout types
eae@chromium.org [Mon, 15 Aug 2011 19:31:06 +0000 (19:31 +0000)]
Switch mouse events to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66179

Reviewed by Eric Seidel.

Convert mouse events to new layout abstraction as a part of the ongoing
conversion work.

No new tests, no new functionality.

* dom/MouseRelatedEvent.cpp:
(WebCore::contentsScrollOffset):
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
(WebCore::MouseRelatedEvent::initCoordinates):
(WebCore::MouseRelatedEvent::computePageLocation):
(WebCore::MouseRelatedEvent::computeRelativePosition):
(WebCore::MouseRelatedEvent::pageLocation):
* dom/MouseRelatedEvent.h:
(WebCore::MouseRelatedEvent::screenLocation):
(WebCore::MouseRelatedEvent::clientLocation):
(WebCore::MouseRelatedEvent::absoluteLocation):
(WebCore::MouseRelatedEvent::setAbsoluteLocation):
* page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEventSingleClick):
(WebCore::selectionExtentRespectingEditingBoundary):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::currentMousePosition):
(WebCore::documentPointForWindowPoint):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
(WebCore::EventHandler::dragHysteresisExceeded):
(WebCore::EventHandler::handleDrag):
(WebCore::EventHandler::handleTouchEvent):
* page/EventHandler.h:
* platform/PlatformMouseEvent.h:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
(WebCore::PlatformMouseEvent::pos):
(WebCore::PlatformMouseEvent::x):
(WebCore::PlatformMouseEvent::y):
(WebCore::PlatformMouseEvent::globalX):
(WebCore::PlatformMouseEvent::globalY):
* platform/mac/PlatformMouseEventMac.mm:
(WebCore::globalPoint):
(WebCore::pointForEvent):
(WebCore::globalPointForEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTeach TestWebKitAPI/gtest how to print JavaScript failures nicely
aroben@apple.com [Mon, 15 Aug 2011 19:30:42 +0000 (19:30 +0000)]
Teach TestWebKitAPI/gtest how to print JavaScript failures nicely

Failures now give output of the form: foo should be bar but is baz

Fixes <http://webkit.org/b/66240> It's hard to tell what the actual result of a failed JS
test is in TestWebKitAPI's output

Reviewed by David Levin.

* TestWebKitAPI/JavaScriptTest.cpp:
(TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): Removed now-unused
members.
(TestWebKitAPI::javaScriptCallback): Changed to just store the result string in the context
object, rather than doing any testing of it here.
(TestWebKitAPI::runJSTest): Made this function a gtest predicate-formatter. This allows us
to use a pretty error message when the test fails.

* TestWebKitAPI/JavaScriptTest.h: Changed runJSTest to a predicate-formatter, and added nice
gtest-style macros that wrap it.

* TestWebKitAPI/Test.h: Removed now-unused TEST_ASSERT_RETURN.

* TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
(TestWebKitAPI::TEST): Changed to use the new macros.

* TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
(TestWebKitAPI::createSessionStateContainingFormData): Ditto. Note that this function no
longer returns 0 when the JS test fails. That shouldn't have any effect on whether or not
the test passes, though. Returning early seems to have been an unnecessary optimization.

* TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
(TestWebKitAPI::TEST): Changed to use the new macros.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkit-indent-blockquote is unnecessary
rniwa@webkit.org [Mon, 15 Aug 2011 19:23:26 +0000 (19:23 +0000)]
webkit-indent-blockquote is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=66195

Reviewed by Tony Chang.

Source/WebCore:

Stop adding class="webkit-indent-blockquote" on blockquotes created by execCommand('Indent') and
execCommand('Outdent'). Also removed the code to add the class attribute in ApplyBlockElementCommand
since no other class inherited from ApplyBlockElementCommand uses this feature.

* editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::ApplyBlockElementCommand):
(WebCore::ApplyBlockElementCommand::createBlockElement):
* editing/ApplyBlockElementCommand.h:
* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::IndentOutdentCommand):

LayoutTests:

Rebaselined the tests since WebKit longer adds class="webkit-indent-blockquote" on blockquotes
created by execCommand('Indent') and execCommand('Outdent') after this patch.

* editing/execCommand/19653-1-expected.txt:
* editing/execCommand/5658933-2-expected.txt:
* editing/execCommand/5658933-3-expected.txt:
* editing/execCommand/indent-div-inside-list-expected.txt:
* editing/execCommand/indent-nested-blockquotes-expected.txt:
* editing/execCommand/indent-nested-div-expected.txt:
* editing/execCommand/indent-paragraphs-expected.txt:
* editing/execCommand/indent-pre-expected.txt:
* editing/execCommand/indent-pre-list-expected.txt:
* editing/execCommand/indent-pre-paragraphs-expected.txt:
* editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt:
* editing/execCommand/indent-with-style-expected.txt:
* editing/execCommand/indent-with-style2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwitch remaining SVG Rendering methods to LayoutUnits
leviw@chromium.org [Mon, 15 Aug 2011 19:07:58 +0000 (19:07 +0000)]
Switch remaining SVG Rendering methods to LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=66169

Reviewed by Eric Seidel.

Changing remaining integer SVG methods to use the LayoutUnits abstraction.

No tests as no change in functionality.

* rendering/svg/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::visualOverflowRect):
* rendering/svg/RenderSVGBlock.h:
* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::paint):
(WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGForeignObject::computeRectForRepaint):
* rendering/svg/RenderSVGHiddenContainer.cpp:
(WebCore::RenderSVGHiddenContainer::paint):
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::linesBoundingBox):
* rendering/svg/RenderSVGInlineText.h:
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::outlineBoundsForRepaint):
* rendering/svg/RenderSVGPath.cpp:
(WebCore::RenderSVGPath::paint):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::localToBorderBoxTransform):
(WebCore::RenderSVGRoot::parentOriginToBorderBox):
(WebCore::RenderSVGRoot::borderOriginToContentBox):
(WebCore::RenderSVGRoot::localToRepaintContainerTransform):
(WebCore::RenderSVGRoot::localToParentTransform):
(WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
(WebCore::RenderSVGRoot::computeRectForRepaint):
* rendering/svg/RenderSVGRoot.h:
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::paint):
* rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::paint):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paint):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::computeRectForRepaint):
* rendering/svg/SVGRenderSupport.h:
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::paint):
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
(WebCore::SVGRootInlineBox::layoutRootBox):
(WebCore::SVGRootInlineBox::closestLeafChildForPosition):
* rendering/svg/SVGRootInlineBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Get rid of QTouchWebPagePrivate::getPageViewPrivate()
commit-queue@webkit.org [Mon, 15 Aug 2011 19:07:01 +0000 (19:07 +0000)]
[Qt][WK2] Get rid of QTouchWebPagePrivate::getPageViewPrivate()
https://bugs.webkit.org/show_bug.cgi?id=66222

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-08-15
Reviewed by Kenneth Rohde Christiansen.

The function QTouchWebPagePrivate::getPageViewPrivate() exposed
the private QTouchWebPage to any object in WebKit.

Instead, use the friend keyword to list which objects can access
the internal of QTouchWebPage.

* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qtouchwebpage_p.h:
* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::QTouchWebViewPrivate):
(QTouchWebViewPrivate::viewportRectUpdated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash accessing static property on sealed object
barraclough@apple.com [Mon, 15 Aug 2011 18:51:42 +0000 (18:51 +0000)]
Crash accessing static property on sealed object
https://bugs.webkit.org/show_bug.cgi?id=66242

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):
    - should only check isExtensible if checkReadOnly.

LayoutTests:

* fast/js/preventExtensions-expected.txt:
* fast/js/script-tests/preventExtensions.js:
    - added test case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlaye...
jeffm@apple.com [Mon, 15 Aug 2011 17:41:34 +0000 (17:41 +0000)]
MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
https://bugs.webkit.org/show_bug.cgi?id=66171

MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
to match the Mac implementation in MediaPlayerPrivateAVFoundationObjC.  I also added better logging to notificationCallback().

Reviewed by Jon Honeycutt.

No new tests, uses existing media tests.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::playerItemStatus): Return MediaPlayerAVPlayerItemStatusDoesNotExist if no AVPlayerItem.
(WebCore::AVFWrapper::notificationCallback): Log the name of the received notification.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove the Leaks bot back to ORWT until I can fix LeaksViewer regressions filed by...
eric@webkit.org [Mon, 15 Aug 2011 17:21:30 +0000 (17:21 +0000)]
Move the Leaks bot back to ORWT until I can fix LeaksViewer regressions filed by Adam Roben in bug 66227 and 66228.

Unreviewed.

* Scripts/run-webkit-tests:
(usingLeaks):
(useNewRunWebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix release build when building with Clang.
weinig@apple.com [Mon, 15 Aug 2011 16:56:51 +0000 (16:56 +0000)]
Fix release build when building with Clang.

Reviewed by Anders Carlsson.

* runtime/Identifier.cpp:
(JSC::Identifier::checkCurrentIdentifierTable):
Add NO_RETURN_DUE_TO_CRASH.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
kbalazs@webkit.org [Mon, 15 Aug 2011 15:54:35 +0000 (15:54 +0000)]
Unreviewed.
Fix Qt-WK2 build after r93040.

* UIProcess/qt/QtWebPageProxy.h:
(QtWebPageProxy::deviceScaleFactor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename an instance of pageScaleFactorChanged I missed in r93040
aroben@apple.com [Mon, 15 Aug 2011 15:01:50 +0000 (15:01 +0000)]
Rename an instance of pageScaleFactorChanged I missed in r93040

I tried to make a test for this but failed. It would probably have been easier if we dumped
layers' content scales in layerTreeAsText output.

Followup to <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to
the device scale factor

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::deviceOrPageScaleFactorChanged):
* platform/graphics/ca/GraphicsLayerCA.h:
Renamed from pageScaleFactorChanged to match the base class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [V8] crash upon stepIn while not on pause.
pfeldman@chromium.org [Mon, 15 Aug 2011 14:32:41 +0000 (14:32 +0000)]
Web Inspector: [V8] crash upon stepIn while not on pause.
https://bugs.webkit.org/show_bug.cgi?id=66221

Reviewed by Yury Semikhatsky.

* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::resume):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):
(WebCore::InspectorDebuggerAgent::assertPaused):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._stepOverClicked):
(WebInspector.ScriptsPanel.prototype._stepIntoClicked):
(WebInspector.ScriptsPanel.prototype._stepOutClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Network panel: display the current search match index in the toolbar.
vsevik@chromium.org [Mon, 15 Aug 2011 14:26:24 +0000 (14:26 +0000)]
Web Inspector: Network panel: display the current search match index in the toolbar.
https://bugs.webkit.org/show_bug.cgi?id=66051

Reviewed by Pavel Feldman.

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._highlightNthMatchedResource):
(WebInspector.NetworkLogView.prototype.performSearch):
(WebInspector.NetworkPanel):
(WebInspector.NetworkPanel.prototype._onSearchCountUpdated):
(WebInspector.NetworkPanel.prototype._onSearchIndexUpdated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClear up scale factor terminology
aroben@apple.com [Mon, 15 Aug 2011 13:43:29 +0000 (13:43 +0000)]
Clear up scale factor terminology

WebKit by and large deals with two scale factors: one intrinsic to the device on which the
software is running, and one that is per-Page and can be controlled via API calls. This
patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
code use those names. It should introduce no behavior changes.

Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
device scale factor

Reviewed by Simon Fraser.

Source/WebCore:

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
Removed an unused member. This is unrelated to this patch.

* css/MediaQueryEvaluator.cpp:
* html/HTMLCanvasElement.cpp:
* html/HTMLCanvasElement.h:
* loader/EmptyClients.h:
* page/Chrome.cpp:
* page/Chrome.h:
* page/ChromeClient.h:
* page/DOMWindow.cpp:
* page/Frame.cpp:
* page/Frame.h:
* platform/graphics/GraphicsLayer.cpp:
* platform/graphics/GraphicsLayer.h:
* platform/graphics/GraphicsLayerClient.h:
* platform/graphics/ca/GraphicsLayerCA.cpp:
* rendering/RenderInline.cpp:
* rendering/RenderLayerBacking.cpp:
* rendering/RenderLayerBacking.h:
* rendering/RenderLayerCompositor.cpp:
* rendering/RenderLayerCompositor.h:
* rendering/RenderObject.cpp:

Source/WebKit/chromium:

* src/ChromeClientImpl.cpp:
* src/ChromeClientImpl.h:

Source/WebKit/efl:

* WebCoreSupport/ChromeClientEfl.cpp:
* WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.cpp:
* WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/haiku:

* WebCoreSupport/ChromeClientHaiku.cpp:
* WebCoreSupport/ChromeClientHaiku.h:

Source/WebKit/mac:

* Misc/WebNSControlExtras.m:
(-[NSControl sizeToFitAndAdjustWindowHeight]): Updated this function to use more modern
AppKit scale factor terminology. (This is unrelated to the rest of the patch.)

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:

Source/WebKit/qt:

* WebCoreSupport/ChromeClientQt.cpp:
* WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

* WebCoreSupport/ChromeClientWinCE.cpp:
* WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

* WebKitSupport/ChromeClientWx.cpp:
* WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

* Shared/UpdateInfo.cpp:
* Shared/UpdateInfo.h:
* Shared/WebPageCreationParameters.cpp:
* Shared/WebPageCreationParameters.h:
* UIProcess/API/C/WKPage.cpp:
* UIProcess/API/efl/PageClientImpl.cpp:
* UIProcess/API/efl/PageClientImpl.h:
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
* UIProcess/BackingStore.cpp:
* UIProcess/BackingStore.h:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebPopupMenuProxy.h:
* UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
* UIProcess/gtk/WebPopupMenuProxyGtk.h:
* UIProcess/mac/BackingStoreMac.mm:
* UIProcess/mac/WebPageProxyMac.mm:
* UIProcess/mac/WebPopupMenuProxyMac.h:
* UIProcess/mac/WebPopupMenuProxyMac.mm:
* UIProcess/qt/WebPopupMenuProxyQt.h:
* UIProcess/win/WebPopupMenuProxyWin.h:
* UIProcess/win/WebView.h:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
* WebProcess/WebPage/FindController.cpp:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
* WebProcess/WebPage/ca/LayerTreeHostCA.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPatch by Oliver Varga <Varga.Oliver@stud.u-szeged.hu> on 2011-08-15
reni@webkit.org [Mon, 15 Aug 2011 11:59:22 +0000 (11:59 +0000)]
Patch by Oliver Varga <Varga.Oliver@stud.u-szeged.hu> on 2011-08-15
Reviewed by Nikolas Zimmermann.

Speed up SVGSMILElement::findInstanceTime.
https://bugs.webkit.org/show_bug.cgi?id=61025

Source/JavaScriptCore:

Add a new parameter to StdlibExtras.h::binarySerarch function
to also handle cases when the array does not contain the key value.
This is needed for an svg function.

* wtf/StdLibExtras.h:
(WTF::binarySearch):

Source/WebCore:

Replace the linear search to binary search on ordered list because
the previous searches from the beginning was not efficient.
Out of index error fixed by Renata Hodovan.

No new tests this is only a performance tweak.

* svg/animation/SVGSMILElement.cpp:
(WebCore::extractTimeFromVector):
(WebCore::SVGSMILElement::findInstanceTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement proper handling of focusin/focusout events in regard to shadow DOM boundaries.
hayato@chromium.org [Mon, 15 Aug 2011 11:02:10 +0000 (11:02 +0000)]
Implement proper handling of focusin/focusout events in regard to shadow DOM boundaries.
https://bugs.webkit.org/show_bug.cgi?id=64249

Reviewed by Dimitri Glazkov.

Introduces FocusInEventDispatchMediator/FocusOutEventDispatchMediator so
that we can shrink ancestors of event target node considering shadow
DOM boundaries before dispatching focusin/focusout events.

Source/WebCore:

Test: fast/dom/shadow/shadow-boundary-events.html

* dom/Document.cpp:
(WebCore::Document::setFocusedNode):
* dom/Node.cpp:
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchDOMActivateEvent):
(WebCore::Node::defaultEventHandler):
* dom/Node.h:
* dom/UIEvent.cpp:
(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
* dom/UIEvent.h:

LayoutTests:

* fast/dom/shadow/shadow-boundary-events-expected.txt:
* fast/dom/shadow/shadow-boundary-events.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: not all of the properties have valid descriptors on all platforms.
pfeldman@chromium.org [Mon, 15 Aug 2011 10:26:49 +0000 (10:26 +0000)]
Web Inspector: not all of the properties have valid descriptors on all platforms.
Includes PropertyDescriptor protocol documentation fixes.
https://bugs.webkit.org/show_bug.cgi?id=66215

Source/WebCore:

Activations, LocalStorage and some other properties potentially don't have
valid property descriptors. InjectedScript should use conservative getter in order to
mitigate this.

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-15
Reviewed by Yury Semikhatsky.

* inspector/InjectedScriptSource.js:
* inspector/Inspector.json:

LayoutTests:

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-15
Reviewed by Yury Semikhatsky.

* inspector/protocol/runtime-agent-expected.txt:
* inspector/protocol/runtime-agent.html:
* inspector/runtime/runtime-localStorage-getProperties-expected.txt: Added.
* inspector/runtime/runtime-localStorage-getProperties.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: context menu on the link in the console does not have standard link...
pfeldman@chromium.org [Mon, 15 Aug 2011 09:26:41 +0000 (09:26 +0000)]
Web Inspector: context menu on the link in the console does not have standard link options.
https://bugs.webkit.org/show_bug.cgi?id=66214

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-15
Reviewed by Yury Semikhatsky.

* English.lproj/localizedStrings.js:
* inspector/front-end/ConsoleView.js:
* inspector/front-end/ElementsPanel.js:
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._contextMenu):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._contextMenuEventFired):
* inspector/front-end/inspector.js:
(WebInspector.openLinkExternallyLabel):
(WebInspector.copyLinkAddressLabel):
(WebInspector.populateHrefContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: showContextMenu missing in Remote DevTools
pfeldman@chromium.org [Mon, 15 Aug 2011 08:13:33 +0000 (08:13 +0000)]
Web Inspector: showContextMenu missing in Remote DevTools
https://bugs.webkit.org/show_bug.cgi?id=63725

Reviewed by Yury Semikhatsky.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ConsoleView.js:
* inspector/front-end/SoftContextMenu.js: Added.
(.WebInspector.SoftContextMenu):
(.WebInspector.SoftContextMenu.prototype.show):
(.WebInspector.SoftContextMenu.prototype._createMenuItem):
(.WebInspector.SoftContextMenu.prototype._createSeparator):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseDown):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseUp):
(.WebInspector.SoftContextMenu.prototype._triggerAction):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseOver):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseOut):
(.WebInspector.SoftContextMenu.prototype._highlightMenuItem):
(.WebInspector.SoftContextMenu.prototype._highlightPrevious):
(.WebInspector.SoftContextMenu.prototype._highlightNext):
(.WebInspector.SoftContextMenu.prototype._menuKeyDown):
(.WebInspector.SoftContextMenu.prototype._glassPaneMouseUp):
(.WebInspector.SoftContextMenu.prototype._discardMenu):
(.InspectorFrontendHost.showContextMenu):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
(.soft-context-menu-glass-pane):
(.soft-context-menu):
(.soft-context-menu-item):
(.soft-context-menu-separator):
(.soft-context-menu-item-mouse-over):
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago [QT]REGRESSION after r93011
reni@webkit.org [Mon, 15 Aug 2011 06:57:27 +0000 (06:57 +0000)]
   [QT]REGRESSION after r93011
       https://bugs.webkit.org/show_bug.cgi?id=66212

Unreviewed gardening.

* platform/qt-4.8/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Crash in HTMLTreeBuilder::processAnyOtherEndTagForInBody
inferno@chromium.org [Sun, 14 Aug 2011 23:08:11 +0000 (23:08 +0000)]
Source/WebCore: Crash in HTMLTreeBuilder::processAnyOtherEndTagForInBody
https://bugs.webkit.org/show_bug.cgi?id=66187

Reviewed by Adam Barth.

RefPtr a few ContainerNodes to prevent premature deletion.

Test: fast/html/process-end-tag-for-inbody-crash.html

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

LayoutTests: Crash in HTMLTreeBuilder::processAnyOtherEndTagForInBody.
https://bugs.webkit.org/show_bug.cgi?id=66187

Reviewed by Adam Barth.

* fast/html/process-end-tag-for-inbody-crash-expected.txt: Added.
* fast/html/process-end-tag-for-inbody-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix GTK Windows build after r92308.
commit-queue@webkit.org [Sun, 14 Aug 2011 12:21:57 +0000 (12:21 +0000)]
Fix GTK Windows build after r92308.
https://bugs.webkit.org/show_bug.cgi?id=66140

Patch by Kalev Lember <kalevlember@gmail.com> on 2011-08-14
Reviewed by Xan Lopez.

* config.h: Don't try to include WebCoreHeaderDetection.h for GTK.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwitch results detail view over to new-style object-oriented UI widgets
abarth@webkit.org [Sun, 14 Aug 2011 07:02:36 +0000 (07:02 +0000)]
Switch results detail view over to new-style object-oriented UI widgets
https://bugs.webkit.org/show_bug.cgi?id=66200

Reviewed by Dimitri Glazkov.

This patch replaces my goofy template-based UI for the results
comparison screen with new object-oriented UI widgets.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSet the svn:mime-type property of some PNG files to image/png
mitz@apple.com [Sun, 14 Aug 2011 06:55:55 +0000 (06:55 +0000)]
Set the svn:mime-type property of some PNG files to image/png

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93028 268f45cc-cd09-0410-ab3c-d52691b4dbfc