WebKit-https.git
11 years ago2008-11-06 Alp Toker <alp@nuanti.com>
alp@webkit.org [Thu, 6 Nov 2008 18:36:21 +0000 (18:36 +0000)]
2008-11-06  Alp Toker  <alp@nuanti.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22047
        GTK: Add support for multiple file selection in the file upload control

        Implemented with GtkFileChooser.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::runOpenPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemoved misplaced //fixme comment that doesn't belong there.
hausmann@webkit.org [Thu, 6 Nov 2008 18:12:29 +0000 (18:12 +0000)]
Removed misplaced //fixme comment that doesn't belong there.
Noticed by Darin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
hausmann@webkit.org [Thu, 6 Nov 2008 18:03:31 +0000 (18:03 +0000)]
2008-11-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        Borrow some math functions from the MSVC port to the build with the
        RVCT compiler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
hausmann@webkit.org [Thu, 6 Nov 2008 18:03:23 +0000 (18:03 +0000)]
2008-11-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        Include strings.h for strncasecmp().
        This is needed for compilation inside Symbian and it is also
        confirmed by the man-page on Linux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Norbert Leser <norbert.leser@nokia.com>
hausmann@webkit.org [Thu, 6 Nov 2008 17:48:13 +0000 (17:48 +0000)]
2008-11-06  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Simon Hausmann.

        Implemented currentThreadStackBase for Symbian.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
hausmann@webkit.org [Thu, 6 Nov 2008 17:48:06 +0000 (17:48 +0000)]
2008-11-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        RVCT does not support tm_gmtoff field, so disable that code just like
        for MSVC.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
hausmann@webkit.org [Thu, 6 Nov 2008 17:47:58 +0000 (17:47 +0000)]
2008-11-06  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Simon Hausmann.

        Use the GCC defines of the WTF_ALIGN* macros for the RVCT and the
        MINSCW compiler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
hausmann@webkit.org [Thu, 6 Nov 2008 17:42:38 +0000 (17:42 +0000)]
2008-11-06  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Simon Hausmann.

        Define capabilities of the SYMBIAN platform. Some of the system
        headers are actually dependent on RVCT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
hausmann@webkit.org [Thu, 6 Nov 2008 17:42:31 +0000 (17:42 +0000)]
2008-11-06  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Simon Hausmann.

        Add missing stddef.h header needed for compilation in Symbian.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
hausmann@webkit.org [Thu, 6 Nov 2008 16:50:26 +0000 (16:50 +0000)]
2008-11-06  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Simon Hausmann.

        Define PLATFORM(UNIX) for S60. Effectively WebKit on S60 is compiled
        on top of the Posix layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Norbert Leser <norbert.leser@nokia.com>
hausmann@webkit.org [Thu, 6 Nov 2008 16:50:19 +0000 (16:50 +0000)]
2008-11-06  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Simon Hausmann.

        Added __SYMBIAN32__ condition for defining PLATFORM(SYMBIAN).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Thu, 6 Nov 2008 16:39:18 +0000 (16:39 +0000)]
2008-11-06  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon Hausmann.

        Added WINSCW compiler define for Symbian S60.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
hausmann@webkit.org [Thu, 6 Nov 2008 16:39:03 +0000 (16:39 +0000)]
2008-11-06  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Simon Hausmann.

        Added COMPILER(RVCT) to detect the ARM RVCT compiler used in the Symbian environment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>
hausmann@webkit.org [Thu, 6 Nov 2008 16:38:54 +0000 (16:38 +0000)]
2008-11-06  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Simon Hausmann.

        Disable webkit plugins for Symbian.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>
vestbo@webkit.org [Thu, 6 Nov 2008 12:15:13 +0000 (12:15 +0000)]
2008-11-06  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Fix build break in debug mode when XSLT is not enabled

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>
vestbo@webkit.org [Thu, 6 Nov 2008 12:14:49 +0000 (12:14 +0000)]
2008-11-06  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon Hausmann.

        Repaint video on UpdateRequest to prevent recursive painting

        Calling QWidget::render() to update the video generates a paint
        event that's then picked up by the event filter once more :(

        We're really only interested in updates from Phonon, which we
        get through the UpdateRequest for each new frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Thu, 6 Nov 2008 11:46:43 +0000 (11:46 +0000)]
2008-11-06  Simon Hausmann  <hausmann@webkit.org>

        Fix the Qt build, adjust include paths after move of jsc.pro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Thu, 6 Nov 2008 10:21:50 +0000 (10:21 +0000)]
2008-11-06  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Sam Weinig.

        Move kjs/Shell.cpp to the top level of the JavaScriptCore directory and
        rename it to jsc.cpp to reflect the name of the binary compiled from it.

        * GNUmakefile.am:
        * JavaScriptCore.vcproj/jsc/jsc.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * jsc.cpp: Copied from kjs/Shell.cpp.
        * jsc.pro:
        * jscore.bkl:
        * kjs/Shell.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Thu, 6 Nov 2008 09:50:36 +0000 (09:50 +0000)]
2008-11-06  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Tor Arne Vestbø.

        Added a unit tests for QWebFrame::metaData().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Thu, 6 Nov 2008 09:49:10 +0000 (09:49 +0000)]
2008-11-06  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Tor Arne Vestbø.

        Improved documentation for QWebFrame::metaData().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Sriram Yadavalli <sriram.yadavalli@nokia.com>
hausmann@webkit.org [Thu, 6 Nov 2008 09:49:01 +0000 (09:49 +0000)]
2008-11-05  Sriram Yadavalli <sriram.yadavalli@nokia.com>

        Reviewed by Simon Hausmann.

        Added QWebFrame::metaData() to provide a way in the public API
        to retrieve the values of the <meta> tags.

        See https://bugs.webkit.org/show_bug.cgi?id=22071

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Thu, 6 Nov 2008 09:22:54 +0000 (09:22 +0000)]
2008-11-06  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Fix the WebCore build for some platforms by changing build scripts to
        account for the recent move of the create_hash_table script from the kjs
        subdirectory of JavaScriptCore to the root directory.

        * WebCore.pro:
        * make-generated-sources.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Alp Toker <alp@nuanti.com>
alp@webkit.org [Thu, 6 Nov 2008 08:58:53 +0000 (08:58 +0000)]
2008-11-06  Alp Toker  <alp@nuanti.com>

        GTK build fix for r38155. create_hash_table was moved out of kjs/

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Thu, 6 Nov 2008 08:55:35 +0000 (08:55 +0000)]
2008-11-05  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Correct the date on previous ChangeLogs.

        * ChangeLog:
        * JavaScriptCore/ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Thu, 6 Nov 2008 08:53:06 +0000 (08:53 +0000)]
2008-11-05  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Sam Weinig.

        Move create_hash_table and jsc.pro out of the kjs directory and into the
        root directory of JavaScriptCore.

        JavaScriptCore:

        * DerivedSources.make:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * create_hash_table: Copied from kjs/create_hash_table.
        * jsc.pro: Copied from kjs/jsc.pro.
        * kjs/create_hash_table: Removed.
        * kjs/jsc.pro: Removed.
        * make-generated-sources.sh:

        * WebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-06 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Thu, 6 Nov 2008 08:18:35 +0000 (08:18 +0000)]
2008-11-06  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Fix a case-sensitivity issue in Mac forwarding headers. Strangely
        enough, this does not always cause the build to break, even with a
        case-sensitive filesystem.

        * ForwardingHeaders/runtime/Interpreter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Alp Toker <alp@nuanti.com>
alp@webkit.org [Thu, 6 Nov 2008 07:28:44 +0000 (07:28 +0000)]
2008-11-05  Alp Toker  <alp@nuanti.com>

        GTK build script tweak.

        Make the path relative since it will appear in all -I compiler flags.
        Long argument lists cause bizarre slowdowns in libtool and result
        in huge build logs.

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Thu, 6 Nov 2008 07:24:10 +0000 (07:24 +0000)]
2008-11-05  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Fix the JavaScriptGlue build. This wouldn't show up unless one was
        doing a clean build, because changes in JavaScriptCore don't cause
        anything in JavaScriptGlue to get rebuilt.

        * JSRun.cpp:
        * JSUtils.h:
        * JavaScriptGlue.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Maciej Stachowiak.
ap@webkit.org [Thu, 6 Nov 2008 07:07:23 +0000 (07:07 +0000)]
    Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=22083
        MessageEvents cannot be used across threads

        * dom/Event.idl:
        * dom/MessageEvent.idl:
        Add a NoStaticTables attribute - MessageEvent is used in worker threads, so static tables
        won't work.

        * dom/MessagePort.cpp:
        (WebCore::MessagePort::EventData::EventData):
        (WebCore::MessagePort::EventData::~EventData):
        (WebCore::MessagePort::clone):
        (WebCore::MessagePort::postMessage):
        (WebCore::MessagePort::startConversation):
        (WebCore::MessagePort::dispatchMessages):
        * dom/MessagePort.h:
        Don't create a MessageEvent until dispatch time - messages can be posted across threads,
        but MessageEvents are tied to the thread that they were created in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Thu, 6 Nov 2008 07:04:47 +0000 (07:04 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22066
        Implement Worker global object

        * DerivedSources.make: Added WorkerLocation IDL and JSWorkerContext lookup table.

        * WebCore.xcodeproj/project.pbxproj: Only adding files to Mac project for now, as Worker
        support is still disabled by default.

        * bindings/js/JSDOMGlobalObject.cpp: (WebCore::toJSDOMGlobalObject): Implemented Worker case.

        * bindings/js/JSMessageChannelConstructor.cpp:
        (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): Ditto.

        * bindings/js/JSWorkerContext.cpp: Added.
        * bindings/js/JSWorkerContext.h: Added.
        * bindings/js/WorkerScriptController.cpp: Added.
        * bindings/js/WorkerScriptController.h: Added.
        * dom/WorkerContext.cpp: Added.
        * dom/WorkerContext.h: Added.
        Added an implementation of worker contexts.

        * dom/DedicatedWorker.cpp:
        (WebCore::DedicatedWorker::startLoad): Fixed a lifetime bug I saw on my tests.
        (WebCore::DedicatedWorker::notifyFinished): Create a thread. Currently, object ownership
        and lifetime is not clear at all.

        * dom/WorkerLocation.cpp: Added.
        * dom/WorkerLocation.h: Added.
        * dom/WorkerLocation.idl: Added.
        Added WorkerLocation, which is one of the objects available to workers.

        * dom/WorkerThread.cpp: Added.
        (WebCore::WorkerThread::WorkerThread):
        (WebCore::WorkerThread::start):
        (WebCore::WorkerThread::workerThreadStart):
        (WebCore::WorkerThread::workerThread):
        * dom/WorkerThread.h: Added.
        (WebCore::WorkerThread::create):
        Run some code in a worker thread (no message loop yet).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAttempt to fix the GTK build bot after the latest kjs -> runtime move:
alp@webkit.org [Thu, 6 Nov 2008 04:38:05 +0000 (04:38 +0000)]
Attempt to fix the GTK build bot after the latest kjs -> runtime move:
Remove the built products directory completely rather than using distclean.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
barraclough@apple.com [Thu, 6 Nov 2008 03:26:30 +0000 (03:26 +0000)]
JavaScriptCore:

2008-11-05  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=22094

        Fix for bug where the callee incorrectly recieves the caller's lexical
        global object as this, rather than its own.  Implementation closely
        follows the spec, passing jsNull, checking in the callee and replacing
        with the global object where necessary.

        * VM/CTI.cpp:
        (JSC::CTI::compileOpCall):
        * VM/Machine.cpp:
        (JSC::Machine::cti_op_call_NotJSFunction):
        (JSC::Machine::cti_op_call_eval):
        * runtime/JSCell.h:
        (JSC::JSValue::toThisObject):
        * runtime/JSImmediate.cpp:
        (JSC::JSImmediate::toThisObject):
        * runtime/JSImmediate.h:

LayoutTests:

2008-11-05  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Maciej Stachowiak.

        Previosly the test 'cross-site-this' checked that the second level deep method called
        across frames recieved the correct this pointer, when no base object is provided.

        Test updated so that it check that the code in the child frame, and both the first
        and second functions called in the parent frame recieve the correct this values.

        * fast/frames/cross-site-this.html:
        * fast/frames/resources/cross-site-this-helper.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Antti Koivisto <antti@apple.com>
antti@apple.com [Thu, 6 Nov 2008 02:40:54 +0000 (02:40 +0000)]
2008-11-05  Antti Koivisto  <antti@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=22093
        Don't keep decoded stylesheet data in cache

        <rdar://problem/6343588>

        Don't keep decoded stylesheet string around in the cache. There are no sharing benefits and
        performance benefits are negligible (no measured PLT impact). Reduces memory consumption of
        style sheet data in cache by 2/3 in common case.

        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::sheetText):
        (WebCore::CachedCSSStyleSheet::data):
        * loader/CachedCSSStyleSheet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix after Operations.cpp move.
kevino@webkit.org [Thu, 6 Nov 2008 02:02:36 +0000 (02:02 +0000)]
wx build fix after Operations.cpp move.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Bug 21596: WebCore::Cache should use parsed Pragma and Cache-Control headers
ddkilzer@apple.com [Thu, 6 Nov 2008 02:00:19 +0000 (02:00 +0000)]
    Bug 21596: WebCore::Cache should use parsed Pragma and Cache-Control headers

        <https://bugs.webkit.org/show_bug.cgi?id=21596>

        Reviewed by Antti.

        This patch adds real parsing for Pragma and Cache-Control headers
        based on RFC 2616, Sections 2, 14.9 and 14.32.  It also adds some
        new String and StringImpl methods to assist with the parsing.

        * loader/Cache.cpp:
        (WebCore::Cache::dumpStats): Added.  Convenience method for dumping
        stats outside of Safari.
        * loader/Cache.h: Declared dumpStats().

        * loader/CachedResource.cpp:
        (WebCore::CachedResource::mustRevalidate): Updated to use
        ResourceResponseBase::cacheControlDirectives() instead of substring
        matching of the entire Cache-Control header.

        * loader/loader.cpp:
        (WebCore::Loader::Host::didReceiveResponse): Used the local
        'resource' variable instead of 'request->cachedResource()'.

        * platform/network/ResourceResponseBase.cpp:
        (WebCore::ResourceResponseBase::setHTTPHeaderField): Set
        m_haveParsedCacheControlHeader to false when a "Cache-Control"
        header is set.  Ditto for m_haveParsedPragmaHeader and "Pragma".
        (WebCore::ResourceResponseBase::parsePragmaDirectives): Added.
        Provides parsed Pragma header directives.
        (WebCore::ResourceResponseBase::parseCacheControlDirectives): Added.
        Provides parsed Cache-Control header directives.
        (WebCore::isCacheHeaderSeparator): Added.  Returns true if a
        character is a separator character per RFC 2616, Section 2.2, else
        returns false.
        (WebCore::isControlCharacter): Added.  Returns true if a character
        is a control character per RFC 2616 Section 2.2, else returns false.
        (WebCore::trimToNextSeparator): Added.  Returns a string truncated
        at the first separator character per isCacheHeaderSeparator().
        (WebCore::parseCacheHeader): Added.  This is the main parsing
        routine for both Cache-Control and Pragma headers.
        (WebCore::parseCacheControlDirectiveValues): Added.  This splits
        certain Cache-Control directive values into a vector of strings.
        * platform/network/ResourceResponseBase.h:
        (WebCore::CacheControlDirectiveMap): Added.  Typedef for a parsed
        Cache-Control header.
        (WebCore::PragmaDirectiveMap): Added.  Typedef for a parsed Pragma
        header.
        (WebCore::ResourceResponseBase::parsePragmaDirectives): Added
        declaration.
        (WebCore::ResourceResponseBase::parseCacheControlDirectives): Ditto.
        (WebCore::ResourceResponseBase::m_haveParsedCacheControlHeader):
        Added.  Boolean to describe when the "Cache-Control" header needs to
        be reparsed.
        (WebCore::ResourceResponseBase::m_haveParsedPragmaHeader):  Added.
        Boolean to describe when the "Pragma" header needs to be reparsed.
        (WebCore::ResourceResponseBase::m_cacheControlDirectiveMap): Added.
        Cached map to hold parsed "Cache-Control" headers.
        (WebCore::ResourceResponseBase::m_pragmaDirectiveMap): Added.
        Cached map to hold parsed "Pragma" headers.

        * platform/text/PlatformString.h:
        (WebCore::String::find): Added.  Returns the first match based on
        the character-matching function pointer passed in.
        (WebCore::String::removeCharacters): Added declaration.
        (WebCore::find): Added.  Inline method that takes a character-
        matching function pointer.  Called by StringImpl::find().
        * platform/text/String.cpp:
        (WebCore::String::removeCharacters): Added.  Calls
        StringImpl::removeCharacters().
        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::removeCharacters): Added.  Returns a string
        with all characters removed that match the character-matching
        function pointer passed in.  If there is no change to the string, it
        returns itself.  Based heavily on StringImpl::simplifyWhitespace().
        (WebCore::StringImpl::find): Added.  Calls WebCore::find().
        * platform/text/StringImpl.h:
        (WebCore::FindMatchFunctionPtr): Added.  Typedef for a character-
        matching function pointer.
        (WebCore::StringImpl::removeCharacters): Added declaration.
        (WebCore::StringImpl::find): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
justin.garcia@apple.com [Thu, 6 Nov 2008 01:48:04 +0000 (01:48 +0000)]
WebCore:

2008-11-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Beth Dakin.

        <rdar://problem/5480736> In Mail and Gmail, copied indented text pastes with line break

        As a rule, we don't allow merges out of blockquotes.  In the bug, we are inserting a text node
        between two blockquotes.  Because the start merge moves the text node into a blockquote, when we
        determine whether or not we should do the end merge, it incorrectly appears as though the end merge
        is merging out of a blockquote.  The fix is to determine whether or not we should do the end merge
        before we do the start merge, so that the start merge doesn't effect our decision.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Initialize the new boolean.
        (WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Moved code from doApply() here for clarity.
        (WebCore::ReplaceSelectionCommand::doApply): Set m_shouldMergeEnd before we do the start merge.
        * editing/ReplaceSelectionCommand.h: Added m_shouldMergeEnd.

LayoutTests:

2008-11-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Beth Dakin.

        <rdar://problem/5480736> In Mail and Gmail, copied indented text pastes with line break

        * editing/pasteboard/5480736-expected.txt: Added.
        * editing/pasteboard/5480736.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 6 Nov 2008 01:08:11 +0000 (01:08 +0000)]
2008-11-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark Rowe.

        Keep track of which plug-in host architecture would be needed for a given plug-in package.

        * Plugins/WebNetscapePluginPackage.h:
        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage _initWithPath:]):
        * WebKitPrefix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Thu, 6 Nov 2008 00:41:49 +0000 (00:41 +0000)]
2008-11-05  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Speculatively fix the Windows build, even though these changes may not
        actually matter for anything in the build, because the Windows bots are
        behind.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Cameron <zwarich@apple.com>
cwzwarich@webkit.org [Thu, 6 Nov 2008 00:30:42 +0000 (00:30 +0000)]
2008-11-05  Cameron  <zwarich@apple.com>

        Not reviewed.

        Fix the Qt build.

        * bridge/qt/qt_class.cpp:
        * bridge/qt/qt_runtime.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Thu, 6 Nov 2008 00:00:05 +0000 (00:00 +0000)]
2008-11-05  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Fix the build for case-sensitive build systems and wxWindows.

        * JavaScriptCoreSources.bkl:
        * kjs/create_hash_table:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Wed, 5 Nov 2008 23:48:18 +0000 (23:48 +0000)]
2008-11-05  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Fix the build for case-sensitive build systems.

        * JavaScriptCoreSources.bkl:
        * kjs/Shell.cpp:
        * runtime/Interpreter.cpp:
        * runtime/JSArray.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Wed, 5 Nov 2008 23:37:21 +0000 (23:37 +0000)]
2008-11-05  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Fix the build for case-sensitive build systems.

        * API/JSBase.cpp:
        * API/JSObjectRef.cpp:
        * runtime/CommonIdentifiers.h:
        * runtime/Identifier.cpp:
        * runtime/InitializeThreading.cpp:
        * runtime/InternalFunction.h:
        * runtime/JSString.h:
        * runtime/Lookup.h:
        * runtime/PropertyNameArray.h:
        * runtime/PropertySlot.h:
        * runtime/StructureID.cpp:
        * runtime/StructureID.h:
        * runtime/UString.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Wed, 5 Nov 2008 23:21:32 +0000 (23:21 +0000)]
2008-11-05  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Sam Weinig.

        Move more files to the runtime subdirectory of JavaScriptCore.

        JavaScriptCore:

        * API/APICast.h:
        * API/JSBase.cpp:
        * API/JSCallbackObject.cpp:
        * API/JSClassRef.cpp:
        * API/JSClassRef.h:
        * API/JSStringRefCF.cpp:
        * API/JSValueRef.cpp:
        * API/OpaqueJSString.cpp:
        * API/OpaqueJSString.h:
        * AllInOneFile.cpp:
        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * VM/CodeBlock.h:
        * VM/CodeGenerator.cpp:
        * VM/Machine.cpp:
        * VM/RegisterFile.h:
        * debugger/Debugger.h:
        * kjs/SourceProvider.h:
        * kjs/TypeInfo.h: Removed.
        * kjs/collector.cpp: Removed.
        * kjs/collector.h: Removed.
        * kjs/completion.h: Removed.
        * kjs/create_hash_table:
        * kjs/identifier.cpp: Removed.
        * kjs/identifier.h: Removed.
        * kjs/interpreter.cpp: Removed.
        * kjs/interpreter.h: Removed.
        * kjs/lexer.cpp:
        * kjs/lexer.h:
        * kjs/lookup.cpp: Removed.
        * kjs/lookup.h: Removed.
        * kjs/nodes.cpp:
        * kjs/nodes.h:
        * kjs/operations.cpp: Removed.
        * kjs/operations.h: Removed.
        * kjs/protect.h: Removed.
        * kjs/regexp.cpp: Removed.
        * kjs/regexp.h: Removed.
        * kjs/ustring.cpp: Removed.
        * kjs/ustring.h: Removed.
        * pcre/pcre_exec.cpp:
        * profiler/CallIdentifier.h:
        * profiler/Profile.h:
        * runtime/ArrayConstructor.cpp:
        * runtime/ArrayPrototype.cpp:
        * runtime/ArrayPrototype.h:
        * runtime/Collector.cpp: Copied from kjs/collector.cpp.
        * runtime/Collector.h: Copied from kjs/collector.h.
        * runtime/CollectorHeapIterator.h:
        * runtime/Completion.h: Copied from kjs/completion.h.
        * runtime/ErrorPrototype.cpp:
        * runtime/Identifier.cpp: Copied from kjs/identifier.cpp.
        * runtime/Identifier.h: Copied from kjs/identifier.h.
        * runtime/InitializeThreading.cpp:
        * runtime/Interpreter.cpp: Copied from kjs/interpreter.cpp.
        * runtime/Interpreter.h: Copied from kjs/interpreter.h.
        * runtime/JSCell.h:
        * runtime/JSGlobalData.cpp:
        * runtime/JSGlobalData.h:
        * runtime/JSLock.cpp:
        * runtime/JSNumberCell.cpp:
        * runtime/JSNumberCell.h:
        * runtime/JSObject.cpp:
        * runtime/JSValue.h:
        * runtime/Lookup.cpp: Copied from kjs/lookup.cpp.
        * runtime/Lookup.h: Copied from kjs/lookup.h.
        * runtime/MathObject.cpp:
        * runtime/NativeErrorPrototype.cpp:
        * runtime/NumberPrototype.cpp:
        * runtime/Operations.cpp: Copied from kjs/operations.cpp.
        * runtime/Operations.h: Copied from kjs/operations.h.
        * runtime/PropertyMapHashTable.h:
        * runtime/Protect.h: Copied from kjs/protect.h.
        * runtime/RegExp.cpp: Copied from kjs/regexp.cpp.
        * runtime/RegExp.h: Copied from kjs/regexp.h.
        * runtime/RegExpConstructor.cpp:
        * runtime/RegExpObject.h:
        * runtime/RegExpPrototype.cpp:
        * runtime/SmallStrings.h:
        * runtime/StringObjectThatMasqueradesAsUndefined.h:
        * runtime/StructureID.cpp:
        * runtime/StructureID.h:
        * runtime/StructureIDTransitionTable.h:
        * runtime/SymbolTable.h:
        * runtime/TypeInfo.h: Copied from kjs/TypeInfo.h.
        * runtime/UString.cpp: Copied from kjs/ustring.cpp.
        * runtime/UString.h: Copied from kjs/ustring.h.
        * wrec/CharacterClassConstructor.h:
        * wrec/WREC.h:

        WebCore:

        * ForwardingHeaders/kjs/collector.h: Removed.
        * ForwardingHeaders/kjs/completion.h: Removed.
        * ForwardingHeaders/kjs/identifier.h: Removed.
        * ForwardingHeaders/kjs/interpreter.h: Removed.
        * ForwardingHeaders/kjs/lookup.h: Removed.
        * ForwardingHeaders/kjs/operations.h: Removed.
        * ForwardingHeaders/kjs/protect.h: Removed.
        * ForwardingHeaders/kjs/ustring.h: Removed.
        * ForwardingHeaders/runtime/Collector.h: Copied from ForwardingHeaders/kjs/collector.h.
        * ForwardingHeaders/runtime/Completion.h: Copied from ForwardingHeaders/kjs/completion.h.
        * ForwardingHeaders/runtime/Identifier.h: Copied from ForwardingHeaders/kjs/identifier.h.
        * ForwardingHeaders/runtime/Interpreter.h: Copied from ForwardingHeaders/kjs/interpreter.h.
        * ForwardingHeaders/runtime/Lookup.h: Copied from ForwardingHeaders/kjs/lookup.h.
        * ForwardingHeaders/runtime/Operations.h: Copied from ForwardingHeaders/kjs/operations.h.
        * ForwardingHeaders/runtime/Protect.h: Copied from ForwardingHeaders/kjs/protect.h.
        * ForwardingHeaders/runtime/UString.h: Copied from ForwardingHeaders/kjs/ustring.h.
        * bindings/js/GCController.cpp:
        * bindings/js/JSCustomPositionCallback.h:
        * bindings/js/JSCustomPositionErrorCallback.h:
        * bindings/js/JSCustomSQLStatementCallback.h:
        * bindings/js/JSCustomSQLStatementErrorCallback.h:
        * bindings/js/JSCustomSQLTransactionErrorCallback.h:
        * bindings/js/JSCustomVoidCallback.h:
        * bindings/js/JSDOMBinding.h:
        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSEventListener.h:
        * bindings/js/ScheduledAction.h:
        * bindings/js/ScriptController.cpp:
        * bindings/js/ScriptController.h:
        * bindings/objc/WebScriptObject.mm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/NP_jsobject.cpp:
        * bridge/c/c_class.cpp:
        * bridge/jni/jni_class.cpp:
        * bridge/jni/jni_jsobject.mm:
        * bridge/npruntime.cpp:
        * bridge/runtime_root.h:
        * history/CachedPage.h:
        * html/CanvasRenderingContext2D.cpp:
        * html/HTMLCanvasElement.cpp:
        * inspector/InspectorController.cpp:
        * inspector/JavaScriptCallFrame.cpp:
        * page/Console.cpp:
        * page/Page.cpp:
        * platform/text/AtomicString.cpp:
        * platform/text/PlatformString.h:

        WebKit/mac:

        * ForwardingHeaders/kjs/collector.h: Removed.
        * ForwardingHeaders/kjs/identifier.h: Removed.
        * ForwardingHeaders/kjs/interpreter.h: Removed.
        * ForwardingHeaders/kjs/lookup.h: Removed.
        * ForwardingHeaders/kjs/operations.h: Removed.
        * ForwardingHeaders/kjs/protect.h: Removed.
        * ForwardingHeaders/runtime/Interpreter.h: Copied from ForwardingHeaders/kjs/interpreter.h.
        * WebView/WebScriptDebugDelegate.mm:

        WebKit/wx:

        * WebFrame.cpp:
        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 5 Nov 2008 23:19:56 +0000 (23:19 +0000)]
2008-11-05  Anders Carlsson  <andersca@apple.com>

        Fix 64-bit build.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (setDefaultsToConsistentValuesForTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by John Sullivan.
mitz@apple.com [Wed, 5 Nov 2008 20:51:52 +0000 (20:51 +0000)]
    Reviewed by John Sullivan.

        - make the {protocol,proxyType} argument of
          WebURLProtectionSpace::initWith{Proxy}Host actually work and fix
          assertion failures.

        * WebURLProtectionSpace.cpp:
        (WebURLProtectionSpace::initWithHost): The BString comparisons were
        applying the BString==BSTR operator to a right hand side that was
        actually a WCHAR string. Fixed by using BStrings on both sides.
        (WebURLProtectionSpace::initWithProxyHost): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Wed, 5 Nov 2008 20:03:26 +0000 (20:03 +0000)]
WebCore:

2008-11-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Fix https://bugs.webkit.org/show_bug.cgi?id=22085
        The Plugin JS object should expose item() and namedItem() methods to match Firefox

        * bindings/js/JSPluginCustom.cpp:
        (WebCore::JSPlugin::nameGetter):
        * plugins/Plugin.cpp:
        (WebCore::Plugin::namedItem):
        * plugins/Plugin.h:
        * plugins/Plugin.idl:

LayoutTests:

2008-11-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Update tests for https://bugs.webkit.org/show_bug.cgi?id=22085
        The Plugin JS object should expose item() and namedItem() methods to match Firefox

        * fast/dom/Window/window-properties-expected.txt:
        * plugins/plugin-javascript-access-expected.txt:
        * plugins/plugin-javascript-access.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 5 Nov 2008 19:51:35 +0000 (19:51 +0000)]
2008-11-05  Geoffrey Garen  <ggaren@apple.com>

        Suggested by Darin Adler.

        Removed two copy constructors that the compiler can generate for us
        automatically.

        * VM/LabelID.h:
        (JSC::LabelID::setLocation):
        (JSC::LabelID::offsetFrom):
        (JSC::LabelID::ref):
        (JSC::LabelID::refCount):
        * kjs/LabelScope.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Maciej Stachowiak.
ap@webkit.org [Wed, 5 Nov 2008 19:19:02 +0000 (19:19 +0000)]
    Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=21060
        Range#surroundContents incorrectly throws BAD_BOUNDARYPOINTS_ERR

        Test: fast/dom/Range/surroundContents-check-boundary-points.html

        * dom/Range.cpp: (WebCore::Range::surroundContents): Fix BAD_BOUNDARYPOINTS_ERR checks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 5 Nov 2008 18:42:29 +0000 (18:42 +0000)]
2008-11-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Remove two global destructors from CoreTextController.

        * platform/graphics/mac/CoreTextController.cpp:
        (WebCore::CoreTextController::collectCoreTextRunsForCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 5 Nov 2008 18:41:07 +0000 (18:41 +0000)]
2008-11-05  Darin Fisher  <darin@chromium.org>

        Reviewed by Darin Adler.

        CRASH at Scrollbar::invalidateRect due to null m_client
        https://bugs.webkit.org/show_bug.cgi?id=22080

        * platform/Scrollbar.cpp:
        (WebCore::Scrollbar::isWindowActive):
        (WebCore::Scrollbar::invalidateRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Wed, 5 Nov 2008 18:30:59 +0000 (18:30 +0000)]
WebCore:

2008-11-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Simon Hausmann.

        Fix https://bugs.webkit.org/show_bug.cgi?id=21648
        navigator.mimeTypes and navigator.plugins don't expose item and namedItem to JS

        - Also adds constructors for Plugin, PluginArray, MimeType and MimeTypeArray.

        * bindings/js/JSMimeTypeArrayCustom.cpp:
        (WebCore::JSMimeTypeArray::nameGetter):
        * bindings/js/JSPluginArrayCustom.cpp:
        (WebCore::JSPluginArray::nameGetter):
        * page/DOMWindow.idl:
        * plugins/MimeType.idl:
        * plugins/MimeTypeArray.cpp:
        (WebCore::MimeTypeArray::namedItem):
        * plugins/MimeTypeArray.h:
        * plugins/MimeTypeArray.idl:
        * plugins/Plugin.idl:
        * plugins/PluginArray.cpp:
        (WebCore::PluginArray::namedItem):
        * plugins/PluginArray.h:
        * plugins/PluginArray.idl:

LayoutTests:

2008-11-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Simon Hausmann.

        Update tests for https://bugs.webkit.org/show_bug.cgi?id=21648
        navigator.mimeTypes and navigator.plugins don't expose item and namedItem to JS

        * fast/dom/Window/window-properties-expected.txt:
        * fast/js/global-constructors-expected.txt:
        * plugins/plugin-javascript-access-expected.txt:
        * plugins/plugin-javascript-access.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 5 Nov 2008 18:24:36 +0000 (18:24 +0000)]
2008-11-05  Anders Carlsson  <andersca@apple.com>

        Fix Snow Leopard build.

        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Wed, 5 Nov 2008 18:23:10 +0000 (18:23 +0000)]
2008-11-05  Steve Falkenburg  <sfalken@apple.com>

        Build fix.

        * plugins/PluginPackage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit:
andersca@apple.com [Wed, 5 Nov 2008 18:22:39 +0000 (18:22 +0000)]
WebKit:

2008-11-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Remove WebPlugInStreamLoaderDelegate.h

        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-11-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Remove WebPlugInStreamLoaderDelegate.h

        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebPlugInStreamLoaderDelegate.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Jeff Cook <cookiecaper@gmail.com>
hausmann@webkit.org [Wed, 5 Nov 2008 15:31:30 +0000 (15:31 +0000)]
2008-11-05  Jeff Cook  <cookiecaper@gmail.com>

        Reviewed by Simon Hausmann and Tor Arne.

        Fix crash in the Qt port when unloading swfdec and Flash 10
        by reordering window destruction and plugin stop.

        See https://bugs.webkit.org/show_bug.cgi?id=20779

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Wed, 5 Nov 2008 15:31:22 +0000 (15:31 +0000)]
2008-11-05  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Tor Arne Vestbø

        Fix loading of Flash 10 in the Qt port by faking the toolkit to be Gtk.

        Otherwise Flash refuses to load and function :(

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Wed, 5 Nov 2008 15:31:10 +0000 (15:31 +0000)]
2008-11-05  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Tor Arne Vestbø

        Unify determineQuirks between the Qt and the Gtk PluginPackage.
        Share the code for parsing the module version from the description.
        This is currently used to determine Flash based quirks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Pierre-Olivier Latour <pol@apple.com>
mitz@apple.com [Wed, 5 Nov 2008 09:25:40 +0000 (09:25 +0000)]
2008-11-05  Pierre-Olivier Latour  <pol@apple.com>

        Rubber-stamped by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=21821

        Another set of updated expected pixel results generated with the same
        setup. Includes accessiblity/, animations/, css1/, css2.1/, css3/,
        dom/ and editing/.

        (file listing elided)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-05 Pierre-Olivier Latour <pol@apple.com>
mitz@apple.com [Wed, 5 Nov 2008 09:07:52 +0000 (09:07 +0000)]
2008-11-05  Pierre-Olivier Latour  <pol@apple.com>

        Rubber-stamped by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=21821

        Imported more image bases for a representative set of pixel tests in order to
        fully validate latest DRT and test script changes. These results were generated
        by a release build of r38003 on an Intel iMac running Mac OS X 10.5.5 with
        QuickTime 7.5.5.

        (file listing elided)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - Tiger build fix
mitz@apple.com [Wed, 5 Nov 2008 08:45:18 +0000 (08:45 +0000)]
    - Tiger build fix

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView stop]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 5 Nov 2008 01:44:47 +0000 (01:44 +0000)]
2008-11-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Don't leak the CALayer.

        * Plugins/WebBaseNetscapePluginView.h:
        Make the layer a RetainPtr.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView start]):

        (-[WebBaseNetscapePluginView stop]):
        Make sure to clear out the layer here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Wed, 5 Nov 2008 00:58:47 +0000 (00:58 +0000)]
2008-11-04  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Steve Falkenburg.

        Move dtoa.cpp and dtoa.h to the WTF Visual Studio project to reflect
        their movement in the filesystem.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Wed, 5 Nov 2008 00:49:41 +0000 (00:49 +0000)]
2008-11-04  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Sam Weinig.

        Move kjs/dtoa.h to the wtf subdirectory of JavaScriptCore, and remove
        its unused forwarding header in WebKit/mac.

        JavaScriptCore:

        * AllInOneFile.cpp:
        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * kjs/dtoa.cpp: Removed.
        * kjs/dtoa.h: Removed.
        * wtf/dtoa.cpp: Copied from kjs/dtoa.cpp.
        * wtf/dtoa.h: Copied from kjs/dtoa.h.

        WebCore:

        * ForwardingHeaders/kjs/dtoa.h: Removed.
        * ForwardingHeaders/wtf/dtoa.h: Copied from ForwardingHeaders/kjs/dtoa.h.
        * css/CSSParser.cpp:
        * platform/text/String.cpp:
        * platform/text/StringImpl.cpp:

        WebKit/mac:

        * ForwardingHeaders/kjs/dtoa.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 5 Nov 2008 00:45:00 +0000 (00:45 +0000)]
2008-11-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        More cleanup. Make a bunch of instance variables RetainPtrs.

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView visibleRect]):
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
        (-[WebBaseNetscapePluginView sendActivateEvent:]):
        (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
        (-[WebBaseNetscapePluginView stopTimers]):
        (-[WebBaseNetscapePluginView restartTimers]):
        (-[WebBaseNetscapePluginView setHasFocus:]):
        (-[WebBaseNetscapePluginView mouseDown:]):
        (-[WebBaseNetscapePluginView mouseUp:]):
        (-[WebBaseNetscapePluginView mouseEntered:]):
        (-[WebBaseNetscapePluginView mouseExited:]):
        (-[WebBaseNetscapePluginView handleMouseMoved:]):
        (-[WebBaseNetscapePluginView mouseDragged:]):
        (-[WebBaseNetscapePluginView scrollWheel:]):
        (-[WebBaseNetscapePluginView keyUp:]):
        (-[WebBaseNetscapePluginView keyDown:]):
        (-[WebBaseNetscapePluginView flagsChanged:]):
        (-[WebBaseNetscapePluginView cut:]):
        (-[WebBaseNetscapePluginView copy:]):
        (-[WebBaseNetscapePluginView paste:]):
        (-[WebBaseNetscapePluginView selectAll:]):
        (-[WebBaseNetscapePluginView didStart]):
        (-[WebBaseNetscapePluginView start]):
        (-[WebBaseNetscapePluginView stop]):
        (-[WebBaseNetscapePluginView dataSource]):
        (-[WebBaseNetscapePluginView pluginPackage]):
        (-[WebBaseNetscapePluginView setPluginPackage:]):
        (-[WebBaseNetscapePluginView setAttributeKeys:andValues:]):
        (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
        (-[WebBaseNetscapePluginView fini]):
        (-[WebBaseNetscapePluginView dealloc]):
        (-[WebBaseNetscapePluginView pluginView:receivedError:]):
        (-[WebBaseNetscapePluginView requestWithURLCString:]):
        (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]):
        (-[WebBaseNetscapePluginView loadPluginRequest:]):
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
        (-[WebBaseNetscapePluginView userAgent]):
        (-[WebBaseNetscapePluginView getVariable:value:]):
        (-[WebBaseNetscapePluginView setVariable:value:]):
        (-[WebBaseNetscapePluginView _createPlugin]):
        (-[WebBaseNetscapePluginView _redeliverStream]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Jonathan Haas <myrdred@gmail.com>
pam@chromium.org [Wed, 5 Nov 2008 00:24:44 +0000 (00:24 +0000)]
2008-11-04  Jonathan Haas  <myrdred@gmail.com>

        Addiitonal tweaks and patch prep by Pamela Greene <pam@chromium.org>

        Reviewed by Darin Adler.

        Fixed an issue which could cause memory corruption using ToT libxml.
        See https://bugs.webkit.org/show_bug.cgi?id=15715

        Test: fast/xsl/xslt-nested-stylesheets.xml

        * xml/XSLImportRule.cpp:
        (WebCore::XSLImportRule::setXSLStyleSheet): Set parent rather than owner document
        * xml/XSLStyleSheet.cpp:
        (WebCore::XSLStyleSheet::XSLStyleSheet): Initialize m_parentStyleSheet
        (WebCore::XSLStyleSheet::parseString): Make all child stylesheets use parent's dictionary
        (WebCore::XSLStyleSheet::setParentStyleSheet): Added
        * xml/XSLStyleSheet.h: Added m_parentStyleSheet member

2008-11-04  Pamela Greene  <pam@chromium.org>

        Reviewed by Darin Adler.

        Added test for crash resulting from nested stylesheets using certain
        builds of libxml2.  See https://bugs.webkit.org/show_bug.cgi?id=15715 .

        * fast/xsl/resources/xslt-nested-stylesheets0.xsl: Added.
        * fast/xsl/resources/xslt-nested-stylesheets1.xsl: Added.
        * fast/xsl/xslt-nested-stylesheets-expected.txt: Added.
        * fast/xsl/xslt-nested-stylesheets.xml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 23:44:19 +0000 (23:44 +0000)]
2008-11-04  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Sam Weinig.

        Move kjs/config.h to the top level of JavaScriptCore.

        * GNUmakefile.am:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * config.h: Copied from kjs/config.h.
        * kjs/config.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 4 Nov 2008 23:00:23 +0000 (23:00 +0000)]
2008-11-04  Simon Fraser  <simon.fraser@apple.com>

        Add AccessibilityObject.o to the exclude list for the
        check for global destructors.

        * Scripts/check-for-exit-time-destructors:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 4 Nov 2008 22:40:53 +0000 (22:40 +0000)]
2008-11-04  Simon Fraser  <simon.fraser@apple.com>

        No review.

        Improved buid fix: include MathExtras.h to get roundf on all platforms.

        * platform/graphics/FloatPoint.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 4 Nov 2008 22:08:44 +0000 (22:08 +0000)]
2008-11-04  Darin Adler  <darin@apple.com>

        * Scripts/check-for-exit-time-destructors: Fix failures seen on the
        bot, but for some reason not on my computer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
beidson@apple.com [Tue, 4 Nov 2008 20:55:13 +0000 (20:55 +0000)]
WebCore:

2008-11-04  Brady Eidson  <beidson@apple.com>

        Reviewed by John Sullivan

        Add a simple "visited" method to HistoryItem for use by global history

        * WebCore.base.exp:

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::visited):  Update the title on the item, set last visited time,
          and bump the visit count.  All things that should happen when a url is visited again!
        * history/HistoryItem.h:

WebKit/mac:

2008-11-04  Brady Eidson  <beidson@apple.com>

        Reviewed by John Sullivan

        Cleanup global history a tad.

        Used to _addItemForURL always create a new item and merge it with a previous item if one existed.

        It is more efficient and less complicated to update the previous item if one exists.

        * History/WebHistory.mm:
        (-[WebHistoryPrivate visitedURL:withTitle:]):
        (-[WebHistory _visitedURL:withTitle:]):  Instead of calling the general purpose [WebHistoryPrivate addItem:]
          with a new history item, call the new special purposed visitedURL:withTitle:
        * History/WebHistoryInternal.h:

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem _visitedWithTitle:]): Call "visited()" on the WebCore history item with the pertinent info.
        * History/WebHistoryItemInternal.h:

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::updateGlobalHistory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 4 Nov 2008 20:08:57 +0000 (20:08 +0000)]
2008-11-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        https://bugs.webkit.org/show_bug.cgi?id=22065

        Only create the plug-in stream loader when the stream is started.

        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::WebNetscapePluginStream):
        (WebNetscapePluginStream::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Tue, 4 Nov 2008 19:43:58 +0000 (19:43 +0000)]
2008-11-04  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Build fix. Not reviewed.

        * platform/graphics/FloatPoint.h: include math.h.
        reported by zdobersek in #webkit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 4 Nov 2008 19:40:56 +0000 (19:40 +0000)]
2008-11-04  Darin Fisher  <darin@chromium.org>

        Reviewed by Anders Carlsson.

        No need to clobber all ResourceRequest fields in FrameLoader::reload()
        https://bugs.webkit.org/show_bug.cgi?id=21949

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::reload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 4 Nov 2008 19:00:58 +0000 (19:00 +0000)]
2008-11-04  Darin Adler  <darin@apple.com>

        Reviewed by Tim Hatcher.

        * storage/Database.cpp:
        (WebCore::databaseVersionKey): Tweaked formatting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 4 Nov 2008 18:59:56 +0000 (18:59 +0000)]
2008-11-04  Darin Adler  <darin@apple.com>

        Reviewed by Tim Hatcher.

        * wtf/ThreadingNone.cpp: Tweak formatting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-03 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 4 Nov 2008 18:58:45 +0000 (18:58 +0000)]
2008-11-03  Darin Adler  <darin@apple.com>

        Reviewed by Tim Hatcher.

        - https://bugs.webkit.org/show_bug.cgi?id=22061
          create script to check for exit-time destructors

        * WebCore.xcodeproj/project.pbxproj: Added a script
        phase that runs the check-for-exit-time-destructors script.

        * html/HTMLAttributeNames.in: Removed some unused attribute names.

        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::parseMappedAttribute): Removed code that
        sets the write-only m_pluginPage.
        * html/HTMLEmbedElement.h: Ditto.

        * platform/mac/CursorMac.mm:
        (WebCore::leakNamedCursor): Changed to return a Cursor&.
        (WebCore::pointerCursor): Changed to leak an object to avoid an
        exit-time destructor.
        (WebCore::crossCursor): Ditto.
        (WebCore::handCursor): Ditto.
        (WebCore::moveCursor): Ditto.
        (WebCore::verticalTextCursor): Ditto.
        (WebCore::cellCursor): Ditto.
        (WebCore::contextMenuCursor): Ditto.
        (WebCore::aliasCursor): Ditto.
        (WebCore::zoomInCursor): Ditto.
        (WebCore::zoomOutCursor): Ditto.
        (WebCore::copyCursor): Ditto.
        (WebCore::noneCursor): Ditto.
        (WebCore::progressCursor): Ditto.
        (WebCore::noDropCursor): Ditto.
        (WebCore::notAllowedCursor): Ditto.
        (WebCore::iBeamCursor): Ditto.
        (WebCore::waitCursor): Ditto.
        (WebCore::helpCursor): Ditto.
        (WebCore::eastResizeCursor): Ditto.
        (WebCore::northResizeCursor): Ditto.
        (WebCore::northEastResizeCursor): Ditto.
        (WebCore::northWestResizeCursor): Ditto.
        (WebCore::southResizeCursor): Ditto.
        (WebCore::southEastResizeCursor): Ditto.
        (WebCore::southWestResizeCursor): Ditto.
        (WebCore::westResizeCursor): Ditto.
        (WebCore::northSouthResizeCursor): Ditto.
        (WebCore::eastWestResizeCursor): Ditto.
        (WebCore::northEastSouthWestResizeCursor): Ditto.
        (WebCore::northWestSouthEastResizeCursor): Ditto.
        (WebCore::columnResizeCursor): Ditto.
        (WebCore::rowResizeCursor): Ditto.
        (WebCore::grabCursor): Ditto.
        (WebCore::grabbingCursor): Ditto.

        * storage/Database.cpp:
        (WebCore::guidMutex): Changed to leak an object to avoid an
        exit-time destructor. Also added a comment explaining why it's
        thread safe.
        (WebCore::guidToVersionMap): Ditto.
        (WebCore::guidToDatabaseMap): Ditto.
        (WebCore::Database::databaseInfoTableName): Ditto.
        (WebCore::databaseVersionKey): Ditto.
        (WebCore::Database::getVersionFromDatabase): Ditto.
        (WebCore::Database::setVersionInDatabase): Ditto.
        (WebCore::guidForOriginAndName): Ditto.
        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::tracker): Ditto.
        (WebCore::notificationMutex): Ditto.
        (WebCore::notificationQueue): Ditto.
        (WebCore::DatabaseTracker::notifyDatabasesChanged): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Pierre-Olivier Latour <pol@apple.com>
mitz@apple.com [Tue, 4 Nov 2008 18:57:53 +0000 (18:57 +0000)]
2008-11-04  Pierre-Olivier Latour  <pol@apple.com>

        Reviewed by Dan Bernstein.

        - part of https://bugs.webkit.org/show_bug.cgi?id=21821
          Removed pixel results in platform/mac-tiger that were only slightly different
          (within 1% tolerance) from the platform/mac results.
          Removed results in platform/mac-tiger where the results in platform/mac were
          also correct for Tiger.

        (file listing elided)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-03 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 4 Nov 2008 18:57:26 +0000 (18:57 +0000)]
2008-11-03  Darin Adler  <darin@apple.com>

        Reviewed by Tim Hatcher.

        - https://bugs.webkit.org/show_bug.cgi?id=22061
          create script to check for exit-time destructors

        * WebKit.xcodeproj/project.pbxproj: Added a script
        phase that runs the check-for-exit-time-destructors script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-03 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 4 Nov 2008 18:57:01 +0000 (18:57 +0000)]
2008-11-03  Darin Adler  <darin@apple.com>

        Reviewed by Tim Hatcher.

        - https://bugs.webkit.org/show_bug.cgi?id=22061
          create script to check for exit-time destructors

        * JavaScriptCore.exp: Changed to export functions rather than
        a global for the atomically initialized static mutex.

        * JavaScriptCore.xcodeproj/project.pbxproj: Added a script
        phase that runs the check-for-exit-time-destructors script.

        * wtf/MainThread.cpp:
        (WTF::mainThreadFunctionQueueMutex): Changed to leak an object
        rather than using an exit time destructor.
        (WTF::functionQueue): Ditto.
        * wtf/unicode/icu/CollatorICU.cpp:
        (WTF::cachedCollatorMutex): Ditto.

        * wtf/Threading.h: Changed other platforms to share the Windows
        approach where the mutex is internal and the functions are exported.
        * wtf/ThreadingGtk.cpp:
        (WTF::lockAtomicallyInitializedStaticMutex): Ditto.
        (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
        * wtf/ThreadingNone.cpp:
        (WTF::lockAtomicallyInitializedStaticMutex): Ditto.
        (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
        * wtf/ThreadingPthreads.cpp:
        (WTF::threadMapMutex): Changed to leak an object rather than using
        an exit time destructor.
        (WTF::lockAtomicallyInitializedStaticMutex): Mutex change.
        (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
        (WTF::threadMap): Changed to leak an object rather than using
        an exit time destructor.
        * wtf/ThreadingQt.cpp:
        (WTF::lockAtomicallyInitializedStaticMutex): Mutex change.
        (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
        * wtf/ThreadingWin.cpp:
        (WTF::lockAtomicallyInitializedStaticMutex): Added an assertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-03 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 4 Nov 2008 18:56:28 +0000 (18:56 +0000)]
2008-11-03  Darin Adler  <darin@apple.com>

        Reviewed by Tim Hatcher.

        - https://bugs.webkit.org/show_bug.cgi?id=22061
          create script to check for exit-time destructors

        * Scripts/check-for-exit-time-destructors: Added.
        Started as a copy of check-for-global-initializers.

        * Scripts/check-for-global-initializers: Added code to make
        this script rerun any time it's modified, and also to properly
        run again after the first time it reports an error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 4 Nov 2008 18:55:41 +0000 (18:55 +0000)]
2008-11-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        https://bugs.webkit.org/show_bug.cgi?id=22065

        Remove some old, unused plug-in code.

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
        (-[WebBaseNetscapePluginView start]):
        (-[WebBaseNetscapePluginView setVariable:value:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 4 Nov 2008 18:54:50 +0000 (18:54 +0000)]
2008-11-04  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=21941

        Rename absolutePosition() to localToAbsolute(), and add the ability
        to optionally take transforms into account (which will eventually be the
        default behavior).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hausmann@webkit.org [Tue, 4 Nov 2008 16:22:05 +0000 (16:22 +0000)]
WebCore:
    2008-11-03  Yael Aharon  <yael.aharon@nokia.com>

            Reviewed by Simon Hausmann.

            Add methods for getting and setting user data on History Item.
            This change is limited to QT port only. Tests were added in
            the patch for https://bugs.webkit.org/show_bug.cgi?id=21864.

            Minor change by Simon: made the functions inline and added a missing
            const.

WebKit/qt:
    2008-10-24  Yael Aharon <yael.aharon@nokia.com>

            Reviewed by Simon Hausmann.

            Add userData() and setUserData() to QWebHistoryItem.
            Add setMaximumItemCount() and maximumItemCount() to QWebHistory.
            Add currentItemIndex() to QWebHistory.

            See also https://bugs.webkit.org/show_bug.cgi?id=21864

            Small cleanup by Simon (docs and forward declaration of QWebHistoryItem in qwebframe.h)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fix
aroben@apple.com [Tue, 4 Nov 2008 14:15:17 +0000 (14:15 +0000)]
    Windows build fix

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update
        the location of JSStaticScopeObject.{cpp,h}.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 10:59:50 +0000 (10:59 +0000)]
2008-11-04  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Alexey Proskuryakov.

        Move AllInOneFile.cpp to the top level of JavaScriptCore.

        * AllInOneFile.cpp: Copied from kjs/AllInOneFile.cpp.
        * GNUmakefile.am:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/AllInOneFile.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Tue, 4 Nov 2008 10:46:13 +0000 (10:46 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22030
        Make EventNames usable from multiple threads

        * platform/text/AtomicString.cpp:
        (WebCore::stringTable):
        (WebCore::AtomicString::add):
        (WebCore::AtomicString::remove):
        (WebCore::AtomicString::find):
        (WebCore::AtomicString::init):
        * platform/text/AtomicString.h:
        Atomic string table is now per-thread. Individual strings cannot be shared between threads,
        so global AtomicString constants cannot be used from threads other than the main one.

        * dom/EventNames.cpp:
        (WebCore::EventNames::EventNames):
        (WebCore::eventNames):
        (WebCore::EventNames::init):
        * dom/EventNames.h:
        Made EventNames a ThreadSpecific struct. Individual event names are now accessed as
        eventNames().fooEvent, not EventNames::fooEvent. This makes EventNames usable from all
        threads.

        * <Many files>: Access event names via eventNames() function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 10:40:55 +0000 (10:40 +0000)]
2008-11-04  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Alexey Proskuryakov.

        Add NodeInfo.h to the JavaScriptCore Xcode project.

        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 09:43:49 +0000 (09:43 +0000)]
2008-11-04  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Mark Rowe.

        Delete unused forwarding headers.

        WebCore:

        * ForwardingHeaders/kjs/Activation.h: Removed.
        * ForwardingHeaders/kjs/Register.h: Removed.
        * ForwardingHeaders/kjs/RegisterID.h: Removed.

        WebKit/mac:

        * ForwardingHeaders/kjs/string_object.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 08:58:22 +0000 (08:58 +0000)]
2008-11-04  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Mark Rowe.

        Remove JavaScriptGlue forwarding headers that are no longer necessary,
        and correct the path of the ExecState.h forwarding header.

        * ForwardingHeaders/kjs: Removed.
        * ForwardingHeaders/kjs/CTI.h: Removed.
        * ForwardingHeaders/kjs/ExecState.h: Removed.
        * ForwardingHeaders/kjs/JSValue.h: Removed.
        * ForwardingHeaders/kjs/PutPropertySlot.h: Removed.
        * ForwardingHeaders/kjs/ustring.h: Removed.
        * ForwardingHeaders/runtime: Added.
        * ForwardingHeaders/runtime/ExecState.h: Copied from ForwardingHeaders/kjs/ExecState.h.
        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-04 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 08:07:41 +0000 (08:07 +0000)]
2008-11-04  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Fix stupid typo in previous build fix.

        * bindings/js/JSStorageCustom.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/NP_jsobject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-03 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 07:56:20 +0000 (07:56 +0000)]
2008-11-03  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Fix the build for all non-Mac platforms.

        * ForwardingHeaders/kjs/PropertyNameArray.h: Removed.
        * ForwardingHeaders/runtime/PropertyNameArray.h: Copied from ForwardingHeaders/kjs/PropertyNameArray.h.
        * bindings/js/JSStorageCustom.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/NP_jsobject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-03 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 07:33:36 +0000 (07:33 +0000)]
2008-11-03  Cameron Zwarich  <zwarich@apple.com>

        Not reviewed.

        Fix the wxWindows build.

        * bridge/c/c_instance.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-03 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 07:10:41 +0000 (07:10 +0000)]
2008-11-03  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Maciej Stachowiak.

        Move more files into the runtime subdirectory of JavaScriptCore.

        JavaScriptCore:

        * API/JSBase.cpp:
        * API/JSCallbackConstructor.cpp:
        * API/JSCallbackFunction.cpp:
        * API/JSClassRef.cpp:
        * API/OpaqueJSString.cpp:
        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * kjs/AllInOneFile.cpp:
        * kjs/ArgList.cpp: Removed.
        * kjs/ArgList.h: Removed.
        * kjs/Arguments.cpp: Removed.
        * kjs/Arguments.h: Removed.
        * kjs/BatchedTransitionOptimizer.h: Removed.
        * kjs/CollectorHeapIterator.h: Removed.
        * kjs/CommonIdentifiers.cpp: Removed.
        * kjs/CommonIdentifiers.h: Removed.
        * kjs/ExecState.cpp: Removed.
        * kjs/ExecState.h: Removed.
        * kjs/GetterSetter.cpp: Removed.
        * kjs/GetterSetter.h: Removed.
        * kjs/InitializeThreading.cpp: Removed.
        * kjs/InitializeThreading.h: Removed.
        * kjs/JSActivation.cpp: Removed.
        * kjs/JSActivation.h: Removed.
        * kjs/JSGlobalData.cpp: Removed.
        * kjs/JSGlobalData.h: Removed.
        * kjs/JSLock.cpp: Removed.
        * kjs/JSLock.h: Removed.
        * kjs/JSStaticScopeObject.cpp: Removed.
        * kjs/JSStaticScopeObject.h: Removed.
        * kjs/JSType.h: Removed.
        * kjs/PropertyNameArray.cpp: Removed.
        * kjs/PropertyNameArray.h: Removed.
        * kjs/ScopeChain.cpp: Removed.
        * kjs/ScopeChain.h: Removed.
        * kjs/ScopeChainMark.h: Removed.
        * kjs/SymbolTable.h: Removed.
        * kjs/Tracing.d: Removed.
        * kjs/Tracing.h: Removed.
        * runtime/ArgList.cpp: Copied from kjs/ArgList.cpp.
        * runtime/ArgList.h: Copied from kjs/ArgList.h.
        * runtime/Arguments.cpp: Copied from kjs/Arguments.cpp.
        * runtime/Arguments.h: Copied from kjs/Arguments.h.
        * runtime/BatchedTransitionOptimizer.h: Copied from kjs/BatchedTransitionOptimizer.h.
        * runtime/CollectorHeapIterator.h: Copied from kjs/CollectorHeapIterator.h.
        * runtime/CommonIdentifiers.cpp: Copied from kjs/CommonIdentifiers.cpp.
        * runtime/CommonIdentifiers.h: Copied from kjs/CommonIdentifiers.h.
        * runtime/ExecState.cpp: Copied from kjs/ExecState.cpp.
        * runtime/ExecState.h: Copied from kjs/ExecState.h.
        * runtime/GetterSetter.cpp: Copied from kjs/GetterSetter.cpp.
        * runtime/GetterSetter.h: Copied from kjs/GetterSetter.h.
        * runtime/InitializeThreading.cpp: Copied from kjs/InitializeThreading.cpp.
        * runtime/InitializeThreading.h: Copied from kjs/InitializeThreading.h.
        * runtime/JSActivation.cpp: Copied from kjs/JSActivation.cpp.
        * runtime/JSActivation.h: Copied from kjs/JSActivation.h.
        * runtime/JSGlobalData.cpp: Copied from kjs/JSGlobalData.cpp.
        * runtime/JSGlobalData.h: Copied from kjs/JSGlobalData.h.
        * runtime/JSLock.cpp: Copied from kjs/JSLock.cpp.
        * runtime/JSLock.h: Copied from kjs/JSLock.h.
        * runtime/JSStaticScopeObject.cpp: Copied from kjs/JSStaticScopeObject.cpp.
        * runtime/JSStaticScopeObject.h: Copied from kjs/JSStaticScopeObject.h.
        * runtime/JSType.h: Copied from kjs/JSType.h.
        * runtime/PropertyNameArray.cpp: Copied from kjs/PropertyNameArray.cpp.
        * runtime/PropertyNameArray.h: Copied from kjs/PropertyNameArray.h.
        * runtime/ScopeChain.cpp: Copied from kjs/ScopeChain.cpp.
        * runtime/ScopeChain.h: Copied from kjs/ScopeChain.h.
        * runtime/ScopeChainMark.h: Copied from kjs/ScopeChainMark.h.
        * runtime/SymbolTable.h: Copied from kjs/SymbolTable.h.
        * runtime/Tracing.d: Copied from kjs/Tracing.d.
        * runtime/Tracing.h: Copied from kjs/Tracing.h.

        WebCore:

        * ForwardingHeaders/kjs/ArgList.h: Removed.
        * ForwardingHeaders/kjs/CollectorHeapIterator.h: Removed.
        * ForwardingHeaders/kjs/ExecState.h: Removed.
        * ForwardingHeaders/kjs/InitializeThreading.h: Removed.
        * ForwardingHeaders/kjs/JSGlobalData.h: Removed.
        * ForwardingHeaders/kjs/JSLock.h: Removed.
        * ForwardingHeaders/kjs/SymbolTable.h: Removed.
        * ForwardingHeaders/runtime/ArgList.h: Copied from ForwardingHeaders/kjs/ArgList.h.
        * ForwardingHeaders/runtime/CollectorHeapIterator.h: Copied from ForwardingHeaders/kjs/CollectorHeapIterator.h.
        * ForwardingHeaders/runtime/ExecState.h: Copied from ForwardingHeaders/kjs/ExecState.h.
        * ForwardingHeaders/runtime/InitializeThreading.h: Copied from ForwardingHeaders/kjs/InitializeThreading.h.
        * ForwardingHeaders/runtime/JSGlobalData.h: Copied from ForwardingHeaders/kjs/JSGlobalData.h.
        * ForwardingHeaders/runtime/JSLock.h: Copied from ForwardingHeaders/kjs/JSLock.h.
        * ForwardingHeaders/runtime/SymbolTable.h: Copied from ForwardingHeaders/kjs/SymbolTable.h.
        * bindings/js/GCController.cpp:
        * bindings/js/JSCustomPositionCallback.cpp:
        * bindings/js/JSCustomPositionErrorCallback.cpp:
        * bindings/js/JSCustomSQLStatementCallback.cpp:
        * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
        * bindings/js/JSCustomSQLTransactionCallback.cpp:
        * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
        * bindings/js/JSCustomVoidCallback.cpp:
        * bindings/js/JSCustomXPathNSResolver.cpp:
        * bindings/js/JSDOMWindowBase.cpp:
        * bindings/js/JSEventCustom.cpp:
        * bindings/js/JSEventListener.cpp:
        * bindings/js/JSNodeFilterCondition.cpp:
        * bindings/js/ScheduledAction.cpp:
        * bindings/js/ScriptController.cpp:
        * bindings/js/ScriptControllerMac.mm:
        * bindings/objc/WebScriptObject.mm:
        * bridge/NP_jsobject.cpp:
        * bridge/c/c_class.cpp:
        * bridge/c/c_instance.cpp:
        * bridge/c/c_runtime.cpp:
        * bridge/c/c_utility.cpp:
        * bridge/jni/jni_class.cpp:
        * bridge/jni/jni_instance.cpp:
        * bridge/jni/jni_jsobject.mm:
        * bridge/jni/jni_objc.mm:
        * bridge/jni/jni_runtime.cpp:
        * bridge/jni/jni_runtime.h:
        * bridge/jni/jni_utility.cpp:
        * bridge/npruntime.cpp:
        * bridge/objc/objc_instance.mm:
        * bridge/objc/objc_runtime.mm:
        * bridge/objc/objc_utility.mm:
        * bridge/runtime.cpp:
        * dom/Document.cpp:
        * dom/Node.cpp:
        * dom/NodeFilter.cpp:
        * dom/NodeIterator.cpp:
        * dom/TreeWalker.cpp:
        * history/CachedPage.cpp:
        * inspector/InspectorController.cpp:
        * inspector/JavaScriptCallFrame.cpp:
        * inspector/JavaScriptCallFrame.h:
        * inspector/JavaScriptDebugServer.cpp:
        * inspector/JavaScriptProfileNode.cpp:
        * loader/FrameLoader.cpp:
        * loader/icon/IconDatabase.cpp:
        * page/Console.cpp:
        * page/Page.cpp:
        * page/mac/FrameMac.mm:
        * plugins/PluginView.cpp:
        * plugins/gtk/PluginViewGtk.cpp:
        * plugins/qt/PluginViewQt.cpp:
        * plugins/win/PluginViewWin.cpp:
        * storage/Database.cpp:
        * xml/XMLHttpRequest.cpp:

        WebKit/gtk:

        * webkit/webkitprivate.cpp:

        WebKit/mac:

        * ForwardingHeaders/kjs/JSLock.h: Removed.
        * ForwardingHeaders/kjs/SymbolTable.h: Removed.
        * ForwardingHeaders/runtime/JSLock.h: Copied from ForwardingHeaders/kjs/JSLock.h.
        * ForwardingHeaders/runtime/SymbolTable.h: Copied from ForwardingHeaders/kjs/SymbolTable.h.
        * Misc/WebCoreStatistics.mm:
        * Plugins/WebBaseNetscapePluginStream.mm:
        * Plugins/WebBaseNetscapePluginView.mm:
        * Plugins/WebPluginController.mm:
        * WebView/WebFrame.mm:
        * WebView/WebScriptDebugDelegate.mm:
        * WebView/WebView.mm:

        WebKit/qt:

        * Api/qwebpage.cpp:

        WebKit/win:

        * WebJavaScriptCollector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Steve Falkenburg.
mitz@apple.com [Tue, 4 Nov 2008 07:01:26 +0000 (07:01 +0000)]
    Reviewed by Steve Falkenburg.

        - implement WebMutableURLRequest::setHTTPShouldHandleCookies()
        - add and implement WebMutableURLRequest::mutableCopy()

        * Interfaces/IWebURLRequest.idl:
        * WebMutableURLRequest.cpp:
        (WebMutableURLRequest::setHTTPShouldHandleCookies):
        (WebMutableURLRequest::mutableCopy):
        * WebMutableURLRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the 64-bit build.
mrowe@apple.com [Tue, 4 Nov 2008 06:38:11 +0000 (06:38 +0000)]
Fix the 64-bit build.

Pull the frequently-made check for drawingModel == NPDrawingModelQuickDraw out into a
helper function to avoid #ifdef'ing all of the new places that this check is made.

A few other #ifdef's are moved inside functions to allow their call sites to remain #ifdef-free,
and we rely on the compiler to optimise out the check (which will always be false in 64-bit) instead.

* Plugins/WebBaseNetscapePluginView.mm:
(isDrawingModelQuickDraw):
(-[WebBaseNetscapePluginView fixWindowPort]):
(-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
(-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
(-[WebBaseNetscapePluginView updateAndSetWindow]):
(-[WebBaseNetscapePluginView start]):
(-[WebBaseNetscapePluginView tellQuickTimeToChill]):
(-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
(-[WebBaseNetscapePluginView _viewHasMoved]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-03 Alp Toker <alp@nuanti.com>
alp@webkit.org [Tue, 4 Nov 2008 04:25:52 +0000 (04:25 +0000)]
2008-11-03  Alp Toker  <alp@nuanti.com>

        autotools distcleancheck fix. Add dolt-generated files and
        webkitenumtypes.h to the list of files that need to be cleaned.
        Unreviewed.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-03 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Tue, 4 Nov 2008 04:00:31 +0000 (04:00 +0000)]
2008-11-03  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Sam Weinig.

        Remove the forwarding header for FunctionCallProfile, because it was
        renamed to ProfileNode in r33466.

        * ForwardingHeaders/kjs/FunctionCallProfile.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-03 Pierre-Olivier Latour <pol@apple.com>
mitz@apple.com [Tue, 4 Nov 2008 02:32:44 +0000 (02:32 +0000)]
2008-11-03  Pierre-Olivier Latour  <pol@apple.com>

        Reviewed by Dan Bernstein.

        Fixed the override of the "AppleScrollBarVariant" system setting to also work with HIToolbox.

        https://bugs.webkit.org/show_bug.cgi?id=22054

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (setDefaultsToConsistentValuesForTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-03 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 4 Nov 2008 00:33:31 +0000 (00:33 +0000)]
2008-11-03  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Kevin Decker.

        - fix release build (and unitialized variable for CG drawing model!)

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): initialize portState in all code paths

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-11-03 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 3 Nov 2008 22:43:00 +0000 (22:43 +0000)]
2008-11-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Move #define to turn on dumping StructureID statistics to StructureID.cpp so that
        turning it on does not require a full rebuild.

        * runtime/StructureID.cpp:
        (JSC::StructureID::dumpStatistics):
        * runtime/StructureID.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38080 268f45cc-cd09-0410-ab3c-d52691b4dbfc