WebKit-https.git
10 years ago2010-01-13 Simon Fraser <simon.fraser@apple.com>
cmarrin@apple.com [Thu, 14 Jan 2010 00:13:49 +0000 (00:13 +0000)]
2010-01-13 Simon Fraser <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/7532544>

        Expose new method on WebKitSystemInterface, WKGetUserToBaseCTM(), which will
        be used for a shadow drawing fix.

        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 14 Jan 2010 00:08:04 +0000 (00:08 +0000)]
2010-01-13  Kenneth Russell  <kbr@google.com>

        Unreviewed; added myself to the committers list.

        * Scripts/webkitpy/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 14 Jan 2010 00:07:58 +0000 (00:07 +0000)]
2010-01-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Fix shadow drawing to do the correct computations using the base coordinate space
        https://bugs.webkit.org/show_bug.cgi?id=33629

        Step 1: do some renames in setPlatformShadow():
            size -> offset
            width -> xOffset
            height -> yOffset

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::setPlatformShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 13 Jan 2010 23:38:17 +0000 (23:38 +0000)]
2010-01-13  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
        https://bugs.webkit.org/show_bug.cgi?id=33492

        * public/WebKitClient.h:
        * public/WebViewClient.h:
        (WebKit::WebViewClient::createSessionStorageNamespace):
        * src/StorageNamespaceProxy.cpp:
        (WebCore::StorageNamespace::sessionStorageNamespace):
2010-01-13  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
        https://bugs.webkit.org/show_bug.cgi?id=33492

        * page/Page.cpp:
        (WebCore::Page::sessionStorage):
        * storage/StorageNamespace.cpp:
        (WebCore::StorageNamespace::sessionStorageNamespace):
        * storage/StorageNamespace.h:
        (WebCore::StorageNamespace::~StorageNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 13 Jan 2010 23:33:39 +0000 (23:33 +0000)]
2010-01-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/7532544>

        Expose new method on WebKitSystemInterface, WKGetUserToBaseCTM(), which will
        be used for a shadow drawing fix.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceSnowLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIgnore compiled Python in more of webkitpy.
darin@apple.com [Wed, 13 Jan 2010 23:31:49 +0000 (23:31 +0000)]
Ignore compiled Python in more of webkitpy.

* Scripts/webkitpy/commands: Added property svn:ignore.
* Scripts/webkitpy/steps: Added property svn:ignore.
* Scripts/webkitpy/style: Added property svn:ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 13 Jan 2010 22:42:06 +0000 (22:42 +0000)]
2010-01-13  Dirk Schulze  <krit@webkit.org>

        Reviewed by Beth Dakin.

        Repaint bug dragging a star shape with a dash stroke
        https://bugs.webkit.org/show_bug.cgi?id=33406

        Calculation of repaint rects for RenderPath objects was wrong. We must take the
        union of strokeBoundingBox and objectBoundingBox, since the strokeBoundingBox
        must not contain the objectBoundingBox. This is mainly visible on dash-arrays for
        strokes.

        Test: svg/custom/js-repaint-rect-on-path-with-stroke.svg

        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::strokeBoundingBox):

2010-01-13  Dirk Schulze  <krit@webkit.org>

        Reviewed by Beth Dakin.

        Repaint bug dragging a star shape with a dash stroke
        https://bugs.webkit.org/show_bug.cgi?id=33406

        Calculation of repaint rects for RenderPath objects was fixed. We take the
        union of strokeBoundingBox and objectBoundingBox. Since DRT results depend
        on the repaint rect, many results needed an update.
        Added a new test, that makes the wrong calculation visible.
            * js-repaint-rect-on-path-with-stroke.svg

        * platform/mac/fast/repaint/moving-shadow-on-container-expected.checksum
        * platform/mac/fast/repaint/moving-shadow-on-container-expected.txt
        * platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum
        * platform/mac/fast/repaint/moving-shadow-on-path-expected.txt
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
        * platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
        * platform/mac/svg/batik/text/textOnPath-expected.txt:
        * platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
        * platform/mac/svg/batik/text/verticalText-expected.txt:
        * platform/mac/svg/batik/text/verticalTextOnPath-expected.txt:
        * platform/mac/svg/css/composite-shadow-example-expected.txt:
        * platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
        * platform/mac/svg/custom/animate-path-morphing-expected.txt:
        * platform/mac/svg/custom/control-points-for-S-and-T-expected.txt:
        * platform/mac/svg/custom/dasharrayOrigin-expected.txt:
        * platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.checksum: Added.
        * platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png: Added.
        * platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt: Added.
        * platform/mac/svg/custom/path-textPath-simulation-expected.txt:
        * platform/mac/svg/text/text-path-01-b-expected.txt:
        * svg/custom/js-repaint-rect-on-path-with-stroke.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Build fix. Make the XFORM operator work on wx port.
kevino@webkit.org [Wed, 13 Jan 2010 22:28:24 +0000 (22:28 +0000)]
[wx] Build fix. Make the XFORM operator work on wx port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 13 Jan 2010 22:12:48 +0000 (22:12 +0000)]
2010-01-13  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Introduce SourceFrame2 with basic breakpoint / execution line
        rendering capabilities.

        Contains a drive-by naming fix (lineNumberOffset and lineNumberToOffset were
        too close to each other, but were unrelated).

        https://bugs.webkit.org/show_bug.cgi?id=33618

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/SourceFrame2.js: Added.
        (WebInspector.SourceFrame2):
        (WebInspector.SourceFrame2.prototype.set text):
        (WebInspector.SourceFrame2.prototype.get executionLine):
        (WebInspector.SourceFrame2.prototype.set executionLine):
        (WebInspector.SourceFrame2.prototype.revealLine):
        (WebInspector.SourceFrame2.prototype._toggleBreakpoint):
        (WebInspector.SourceFrame2.prototype.resize):
        (WebInspector.BreakpointLineNumberDecorator):
        (WebInspector.BreakpointLineNumberDecorator.prototype.decorate):
        (WebInspector.BreakpointLineNumberDecorator.prototype._paintBreakpoint):
        (WebInspector.BreakpointLineNumberDecorator.prototype._paintProgramCounter):
        (WebInspector.BreakpointLineNumberDecorator.prototype.mouseDown):
        (WebInspector.ExecutionLineDecorator):
        (WebInspector.ExecutionLineDecorator.prototype.decorate):
        * inspector/front-end/TextEditor.js:
        (WebInspector.TextEditor):
        (WebInspector.TextEditor.prototype.get textModel):
        (WebInspector.TextEditor.prototype.set readOnly):
        (WebInspector.TextEditor.prototype.set lineNumberDecorator):
        (WebInspector.TextEditor.prototype.set lineDecorator):
        (WebInspector.TextEditor.prototype.selectionRange):
        (WebInspector.TextEditor.prototype._offsetToLine):
        (WebInspector.TextEditor.prototype._lineToOffset):
        (WebInspector.TextEditor.prototype.reveal):
        (WebInspector.TextEditor.prototype._textChanged):
        (WebInspector.TextEditor.prototype._updateSize):
        (WebInspector.TextEditor.prototype.updateCanvasSize):
        (WebInspector.TextEditor.prototype._repaintAll):
        (WebInspector.TextEditor.prototype._paintLines):
        (WebInspector.TextEditor.prototype._paintLinesContinuation):
        (WebInspector.TextEditor.prototype.paintLineNumbers):
        (WebInspector.TextEditor.prototype._paintCurrentLine):
        (WebInspector.TextEditor.prototype._mouseDown):
        (WebInspector.TextEditor.prototype._caretForMouseEvent):
        (WebInspector.TextEditor.prototype._keyDown):
        (WebInspector.TextEditor.prototype._handleNavigationKey):
        (WebInspector.TextEditor.prototype._textInput):
        (WebInspector.TextEditor.prototype._updateCursor):
        (WebInspector.TextEditor.prototype._paintSelection):
        (WebInspector.TextEditor.prototype._initFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 13 Jan 2010 22:10:03 +0000 (22:10 +0000)]
2010-01-13  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Generate a function in the V8 bindings to convert v8 objects
        to native WebCore objects.

        * bindings/scripts/CodeGeneratorV8.pm: Generate and use toNative().
        * bindings/v8/V8Binding.cpp: Remove manually defined conversion helprs.
        (WebCore::getElementStringAttr):
        (WebCore::setElementStringAttr):
        * bindings/v8/V8Binding.h: Remove manually defined conversion helprs.
        * bindings/v8/V8SVGPODTypeWrapper.h: Still need a manually defined coversion helper for SVGPODTypes.
        (WebCore::V8SVGPODTypeWrapper::toNative):
        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
        (WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
        (WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
        (WebCore::V8WebGLRenderingContext::getUniformCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: REGRESSION (r49268): DHTML drag not allowed unless event.dataTransfer.effect...
bweinstein@apple.com [Wed, 13 Jan 2010 21:59:28 +0000 (21:59 +0000)]
WebCore: REGRESSION (r49268): DHTML drag not allowed unless event.dataTransfer.effectAllowed
is set (differs from HTML5).
Fixes <https://bugs.webkit.org/show_bug.cgi?id=33607> and <rdar://7507114>.

Reviewed by Adam Roben.

If no effectAllowed is set in the dragStart operation, we should default to
uninitialized instead of none, so the user doesn't have to manually set the
effectAllowed to enable drag and drop.

* dom/Clipboard.cpp:
(WebCore::Clipboard::Clipboard):

LayoutTests: REGRESSION (r49268): DHTML drag not allowed unless event.dataTransfer.effectAllowed
is set (differs from HTML5).
Fixes <https://bugs.webkit.org/show_bug.cgi?id=33607> and <rdar://7507114>.

Reviewed by Adam Roben.

Updated the drag and drop test to test if effectAllowed isn't set, in addition
to its other tests.

* fast/events/drag-and-drop-expected.txt:
* fast/events/drag-and-drop.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd additional Geolocation interfaces in WebKit for Windows.
sfalken@apple.com [Wed, 13 Jan 2010 21:35:40 +0000 (21:35 +0000)]
Add additional Geolocation interfaces in WebKit for Windows.

Reviewed by Adam Roben.

* Interfaces/IWebGeolocationPolicyListener.idl: Added.
* Interfaces/IWebUIDelegatePrivate.idl: Add decidePolicyForGeolocationRequest to IWebUIDelegatePrivate2.
Append since this version hasn't shipped.
* Interfaces/WebKit.idl: Add include of IWebGeolocationPolicyListener.idl.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::requestGeolocationPermissionForFrame): Call into decidePolicyForGeolocationRequest.
* WebCoreSupport/WebGeolocationControllerClient.cpp:
(WebGeolocationControllerClient::WebGeolocationControllerClient): Moved *.
* WebGeolocationPolicyListener.cpp: Added.
* WebGeolocationPolicyListener.h: Added.
* WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPolicyListener.
* WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPolicyListener, WebGeolocationPolicyListener.
* WebView.cpp:
(WebView::setGeolocationProvider): Removed extraneous STDMETHODCALLTYPE.
(WebView::geolocationProvider): Removed extraneous STDMETHODCALLTYPE.
(WebView::geolocationDidChangePosition): Removed extraneous STDMETHODCALLTYPE.
(WebView::geolocationDidFailWithError): Removed extraneous STDMETHODCALLTYPE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Dirk Schulze <krit@webkit.org>
eric@webkit.org [Wed, 13 Jan 2010 21:27:18 +0000 (21:27 +0000)]
2010-01-13  Dirk Schulze  <krit@webkit.org>

        Reviewed by Beth Dakin.

        This tests don't pass on Leopard but on Snow Leopard with tolereance of 0.
        Created Leopard specific pixel test results since they do not fail.

        * platform/mac-leopard/svg/css: Added.
        * platform/mac-leopard/svg/css/composite-shadow-example-expected.checksum: Added.
        * platform/mac-leopard/svg/css/composite-shadow-example-expected.png: Added.
        * platform/mac-leopard/svg/css/group-with-shadow-expected.checksum: Added.
        * platform/mac-leopard/svg/css/group-with-shadow-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=32495
hyatt@apple.com [Wed, 13 Jan 2010 21:23:38 +0000 (21:23 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=32495

Reviewed by Dan Bernstein.

font-size:small with background-color causes text to get clipped.  Make sure to only paint within the lineTop/lineBottom of
a line for quirky inline flow boxes that didn't contribute to the overall height of the line.

Added fast/backgrounds/quirks-mode-line-boxes-backgrounds.html

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Dirk Schulze <krit@webkit.org>
eric@webkit.org [Wed, 13 Jan 2010 21:11:34 +0000 (21:11 +0000)]
2010-01-13  Dirk Schulze  <krit@webkit.org>

        Reviewed by Beth Dakin.

        Add tests to check filter, mask, clip, opacity and marker ordering
        https://bugs.webkit.org/show_bug.cgi?id=14010

        This is a follow up. The order of filter and clipping was changes in bug 14010
        according to the Spec. Forgot to update this test.

        * platform/mac/svg/custom/image-with-transform-clip-filter-expected.checksum:
        * platform/mac/svg/custom/image-with-transform-clip-filter-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefactoring DatabaseAuthorizer to use a CaseFoldingHash function
dumi@chromium.org [Wed, 13 Jan 2010 21:09:21 +0000 (21:09 +0000)]
Refactoring DatabaseAuthorizer to use a CaseFoldingHash function
for the set of whitelisted sqlite functions, and fixing some
indenting issues.

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33612

* storage/DatabaseAuthorizer.cpp:
(WebCore::DatabaseAuthorizer::allowFunction):
* storage/DatabaseAuthorizer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Dirk Schulze <krit@webkit.org>
eric@webkit.org [Wed, 13 Jan 2010 20:56:11 +0000 (20:56 +0000)]
2010-01-13  Dirk Schulze  <krit@webkit.org>

        Reviewed by Beth Dakin.

        Speed-up SVG Masking
        https://bugs.webkit.org/show_bug.cgi?id=32738

        This is a followup. The way how masks are created changed and caused
        some results to update. Forgot to update this one.

        * platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
        * platform/mac/svg/custom/grayscale-gradient-mask-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Carol Szabo <carol.szabo@nokia.com>
eric@webkit.org [Wed, 13 Jan 2010 20:40:19 +0000 (20:40 +0000)]
2010-01-13  Carol Szabo  <carol.szabo@nokia.com>

        Reviewed by Darin Adler.

        RenderObject::nextInPreOrderAfterChildren(RenderObject* stayWithin) does not stay within
        https://bugs.webkit.org/show_bug.cgi?id=33600

        No new tests as this fix affects mainly performance.
        No test has been found yet that could evidence the bug in the layout
        of a page, but the fix to bug 32884 exposes this bug on some pages
        such as http://www.w3.org/Style/CSS/Test/CSS2.1/current/html4/counters-scope-implied-001.htm

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::nextInPreOrderAfterChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago https://bugs.webkit.org/show_bug.cgi?id=33610
kdecker@apple.com [Wed, 13 Jan 2010 20:34:01 +0000 (20:34 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=33610
        <rdar://problem/7288546> Silverlight full screen performance problem seen on Snow Leopard.

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView _workaroundSilverlightFullScreenBug:]): Added. Work around Silverlight full screen
         performance issue by maintaining an accelerated GL pixel format. We can safely remove this at some point in
         the future when both Microsoft releases a genuine fix for 7288546 and enough Silverlight users update to the
         new Silverlight. For now, we'll distinguish older broken versions of Silverlight by asking the plug-in if it
         resolved its full screen badness.
        (-[WebNetscapePluginView _createPlugin]): Call _workaroundSilverlightFullScreenBug:YES if this is Silverlight.
        (-[WebNetscapePluginView _destroyPlugin]): Call _workaroundSilverlightFullScreenBug:NO if this is Silverlight.

        https://bugs.webkit.org/show_bug.cgi?id=33610
        <rdar://problem/7288546> Silverlight full screen performance problem seen on Snow Leopard.

         * WebKit.xcodeproj/project.pbxproj: Link the project against OpenGL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: No reviewer. More or less a build fix. My 53180 broke some
jorlow@chromium.org [Wed, 13 Jan 2010 19:18:52 +0000 (19:18 +0000)]
WebCore: No reviewer.  More or less a build fix.  My 53180 broke some
stuff on the Chromium port so I'm reverting.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-13
* page/Page.cpp:
(WebCore::Page::sessionStorage):
* storage/StorageNamespace.cpp:
(WebCore::StorageNamespace::sessionStorageNamespace):
* storage/StorageNamespace.h:
(WebCore::StorageNamespace::~StorageNamespace):

WebKit/chromium: No reviewer.  More or less a build fix.  My 53180 broke some
stuff on the Chromium port so I'm reverting.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-13
* public/WebKitClient.h:
* public/WebViewClient.h:
* src/StorageNamespaceProxy.cpp:
(WebCore::StorageNamespace::sessionStorageNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Steve Block <steveblock@google.com>
eric@webkit.org [Wed, 13 Jan 2010 18:30:04 +0000 (18:30 +0000)]
2010-01-13  Steve Block  <steveblock@google.com>

        Update appendClassName in jni_runtime.cpp to use WebCore::StringBuilder, rather than JSC::StringBuilder.
        https://bugs.webkit.org/show_bug.cgi?id=33586

        Avoiding the JSC version of StringBuilder allows this file to be used with both JSC and V8 on Android.

        No new tests, refactoring only.

        * bridge/jni/jni_runtime.cpp: Modified.
        (JavaMethod::signature): Modified. Use WebCore::StringBuilder.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Kent Hansen <kent.hansen@nokia.com>
eric@webkit.org [Wed, 13 Jan 2010 18:14:16 +0000 (18:14 +0000)]
2010-01-13  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Timothy Hatcher.

        Some objects in the global scope are not completed
        https://bugs.webkit.org/show_bug.cgi?id=19119

        Use Object.getOwnPropertyNames instead of for-in to provide completions, since
        Object.getOwnPropertyNames reports both enumerable and non-enumerable properties.

        * inspector/front-end/InjectedScript.js:
        (InjectedScript._getPropertyNames):
        (InjectedScript.getCompletions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Ben Murdoch <benm@google.com>
eric@webkit.org [Wed, 13 Jan 2010 17:03:33 +0000 (17:03 +0000)]
2010-01-13  Ben Murdoch  <benm@google.com>

        Reviewed by Simon Hausmann.

        [Android] [Qt] The JSC ScriptController does not consider Touch Events user gestures.
        https://bugs.webkit.org/show_bug.cgi?id=33597

        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::processingUserGestureEvent): Add the touch event types (touchstart, touchmove and touchend) to the set of events that are considered user gestures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix build problem related to the pushd command
jocelyn.turcotte@nokia.com [Wed, 13 Jan 2010 16:49:45 +0000 (16:49 +0000)]
[Qt] Fix build problem related to the pushd command

Reviewed by Simon Hausmann.

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Tor Arne Vestbø.
hausmann@webkit.org [Wed, 13 Jan 2010 16:46:29 +0000 (16:46 +0000)]
Rubber-stamped by Tor Arne Vestbø.

[Qt] REGRESSION(53187) Touchevent related tests fail

https://bugs.webkit.org/show_bug.cgi?id=33602

Pass the ENABLE_TOUCH_EVENTS to the IDL generators.

* WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Ilya Tikhonovsky <loislo@chromium.org>
eric@webkit.org [Wed, 13 Jan 2010 16:31:49 +0000 (16:31 +0000)]
2010-01-13  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Timeline panel scrolling speed can be increased.
        https://bugs.webkit.org/show_bug.cgi?id=33579

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelinePanel.prototype._scheduleRefresh):
        (WebInspector.TimelinePanel.prototype._refresh):
        (WebInspector.TimelinePanel.prototype._refreshRecords):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Split the build process in two different .pro files.
hausmann@webkit.org [Wed, 13 Jan 2010 16:06:39 +0000 (16:06 +0000)]
[Qt] Split the build process in two different .pro files.
This allows qmake to be run once all source files are available.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-01-13
Reviewed by Simon Hausmann.

.:

* DerivedSources.pro: Added.
* WebKit.pri:

JavaScriptCore:

* DerivedSources.pro: Added.
* JavaScriptCore.pri: Moved source generation to DerivedSources.pro
* pcre/pcre.pri: Moved source generation to DerivedSources.pro

WebCore:

* DerivedSources.pro: Added.
* WebCore.pri: Added. Contains common logic between source generation and compilation.
* WebCore.pro: Moved source generation to DerivedSources.pro.

WebKitTools:

* Scripts/webkitdirs.pm: Add calls to make DerivedSources.pro in JSC and WC.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 13 Jan 2010 15:55:41 +0000 (15:55 +0000)]
2010-01-13  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed tiny typo fix in docstrings.

        * Scripts/webkitpy/style/checker_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Chris Jerdonek <chris.jerdonek@gmail.com>
hamaji@chromium.org [Wed, 13 Jan 2010 15:52:51 +0000 (15:52 +0000)]
2010-01-13  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by Shinichiro Hamaji.

        Created a CategoryFilter class to encapsulate the logic of
        filter rules.

        https://bugs.webkit.org/show_bug.cgi?id=33454

        * Scripts/webkitpy/style/checker.py:
          - Added CategoryFilter class.

        * Scripts/webkitpy/style/checker_unittest.py:
          - Added CategoryFilter unit tests.

        * Scripts/webkitpy/style/cpp_style.py:
          - Updated filter methods to use CategoryFilter.

        * Scripts/webkitpy/style/cpp_style_unittest.py:
          - Updated references to filters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 13 Jan 2010 15:24:14 +0000 (15:24 +0000)]
2010-01-13  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Scrolling editor to the 20Kth line is not smooth.

        https://bugs.webkit.org/show_bug.cgi?id=33587

        * inspector/front-end/TextEditor.js:
        (WebInspector.TextEditor):
        (WebInspector.TextEditor.prototype._textChanged):
        (WebInspector.TextEditor.prototype._highlightChanged):
        (WebInspector.TextEditor.prototype._paintLinesContinuation):
        * inspector/front-end/TextEditorHighlighter.js:
        (WebInspector.TextEditorHighlighter):
        (WebInspector.TextEditorHighlighter.prototype.highlight):
        (WebInspector.TextEditorHighlighter.prototype._highlightInChunks):
        (WebInspector.TextEditorHighlighter.prototype.updateHighlight):
        (WebInspector.TextEditorHighlighter.prototype._highlightLines):
        (WebInspector.TextEditorHighlighter.prototype._lex):
        * inspector/front-end/TextEditorModel.js:
        (WebInspector.TextEditorModel.prototype._setLine):
        (WebInspector.TextEditorModel.prototype.setAttribute):
        (WebInspector.TextEditorModel.prototype.getAttribute):
        (WebInspector.TextEditorModel.prototype.removeAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix the build on Windows.
hausmann@webkit.org [Wed, 13 Jan 2010 13:49:42 +0000 (13:49 +0000)]
[Qt] Fix the build on Windows.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-01-13
Reviewed by Simon Hausmann.

PluginViewWin.cpp requires the conversion operator from TransformationMatrix to XFORM.

* WebCore.pro: Build TransformationMatrixWin.cpp.
* platform/graphics/transforms/TransformationMatrix.h: Enable the conversion operator to XFORM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-13 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Wed, 13 Jan 2010 09:23:04 +0000 (09:23 +0000)]
2010-01-13  Fumitoshi Ukai  <ukai@chromium.org>

        Unreviewed.

        Add websocket/tests/workers/worker-simple.html, because it starts
        crash after r53174

        * platform/mac/Skipped: Add websocket/tests/workers/worker-simple.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt/Symbian] Added missing vendor information to qtwebkit.sis
hausmann@webkit.org [Wed, 13 Jan 2010 09:18:21 +0000 (09:18 +0000)]
[Qt/Symbian] Added missing vendor information to qtwebkit.sis

Patch by Miikka Heikkinen <miikka.heikkinen@digia.com> on 2010-01-13
Reviewed by Simon Hausmann.

This information is necessary to Symbian sign the package.

http://bugreports.qt.nokia.com/browse/QTBUG-7290

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-11 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 13 Jan 2010 06:51:24 +0000 (06:51 +0000)]
2010-01-11  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
        https://bugs.webkit.org/show_bug.cgi?id=33492

        * public/WebKitClient.h:
        * public/WebViewClient.h:
        (WebKit::WebViewClient::getSessionStorageNamespace):
        * src/StorageNamespaceProxy.cpp:
        (WebCore::StorageNamespace::sessionStorageNamespace):
2010-01-11  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
        https://bugs.webkit.org/show_bug.cgi?id=33492

        * page/Page.cpp:
        (WebCore::Page::sessionStorage):
        * storage/StorageNamespace.cpp:
        (WebCore::StorageNamespace::sessionStorageNamespace):
        * storage/StorageNamespace.h:
        (WebCore::StorageNamespace::~StorageNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 13 Jan 2010 06:12:23 +0000 (06:12 +0000)]
2010-01-12  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed. Now I can review :)

        * Scripts/webkitpy/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7512726> Flash full-screen does not work correctly with Flash 10...
mrowe@apple.com [Wed, 13 Jan 2010 03:33:58 +0000 (03:33 +0000)]
<rdar://problem/7512726> Flash full-screen does not work correctly with Flash 10.1 beta

Reviewed by Darin Adler.

Explicitly track when the plug-in shows and hides a full-screen window to determine
whether a plug-in is currently full-screen, rather than relying on menu bar visibility.
This ensures that we activate the plug-in host process and client application as
appropriate when the plug-in enters or exits full-screen.

* Plugins/Hosted/NetscapePluginHostProxy.h:
(WebKit::NetscapePluginHostProxy::isFullScreenWindowShowing):
* Plugins/Hosted/NetscapePluginHostProxy.mm:
(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::setMenuBarVisible):
(WebKit::NetscapePluginHostProxy::didEnterFullScreen):
(WebKit::NetscapePluginHostProxy::didExitFullScreen):
(WebKit::NetscapePluginHostProxy::setFullScreenWindowIsShowing):
(WKPCSetMenuBarVisible):
(WKPCSetFullScreenWindowIsShowing):
* Plugins/Hosted/WebKitPluginClient.defs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdding a list of whitelisted sqlite functions that users are
dumi@chromium.org [Wed, 13 Jan 2010 03:29:39 +0000 (03:29 +0000)]
Adding a list of whitelisted sqlite functions that users are
allowed to use.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33549

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::authorizerFunction):
* storage/DatabaseAuthorizer.cpp:
(WebCore::DatabaseAuthorizer::DatabaseAuthorizer):
(WebCore::DatabaseAuthorizer::addWhitelistedFunctions):
(WebCore::DatabaseAuthorizer::allowFunction):
* storage/DatabaseAuthorizer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Wed, 13 Jan 2010 02:48:01 +0000 (02:48 +0000)]
2010-01-12  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Simon Hausmann.

        [Qt][WebSocket] SocketStreamHandleSoup.cpp is misnamed
        https://bugs.webkit.org/show_bug.cgi?id=33077

        * WebCore.pro:
        * platform/network/qt/SocketStreamHandleQt.cpp: Copied from WebCore/platform/network/qt/SocketStreamHandleSoup.cpp.
        * platform/network/qt/SocketStreamHandleSoup.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild Fix.
bweinstein@apple.com [Wed, 13 Jan 2010 02:33:25 +0000 (02:33 +0000)]
Build Fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Wed, 13 Jan 2010 02:09:53 +0000 (02:09 +0000)]
2010-01-12  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Darin Adler.

        Add a test of WebSockets for shared workers
        https://bugs.webkit.org/show_bug.cgi?id=33285

        * websocket/tests/workers/resources/worker-simple.js:
        * websocket/tests/workers/shared-worker-simple-expected.txt: Added.
        * websocket/tests/workers/shared-worker-simple.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 13 Jan 2010 02:08:10 +0000 (02:08 +0000)]
2010-01-12  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        position:fixed and transform on same element breaks fixed behavior
        https://bugs.webkit.org/show_bug.cgi?id=31283

        Fix interactions of transforms and fixed positioning, namely that fixed position
        elements with a transformed ancestor are positioned relative to that ancestor,
        and an element with both a transform and fixed position respects that positioning.

        Test: transforms/2d/transform-fixed-container.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::mapLocalToContainer):
        (WebCore::RenderBox::mapAbsoluteToLocalPoint):
        Transforms should not unconditionally stop the propagation of the 'fixed' flag to ancestors,
        but only if the transformed element is not itself fixed.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::convertToLayerCoords):
        Fix this method to behave correctly for fixed position layers whose container is not
        the root, but some other (probably transformed) ancestor. In that case, we can fall into
        the "position: absolute" code path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReplacing RANDOMBLOB with ZEROBLOB, as RANDOMBLOB will soon be
dumi@chromium.org [Wed, 13 Jan 2010 02:04:24 +0000 (02:04 +0000)]
Replacing RANDOMBLOB with ZEROBLOB, as RANDOMBLOB will soon be
disallowed by the authorizer.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33396

* storage/quota-tracking.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Tony Chang <tony@chromium.org>
eric@webkit.org [Wed, 13 Jan 2010 01:29:35 +0000 (01:29 +0000)]
2010-01-12  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        Fix an assert being triggered by how the Chromium port sets the
        replacing flag for error pages.  This was caused by r53143.

        Covered by existing Chromium UI tests.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::checkLoadCompleteForThisFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Kent Hansen <kent.hansen@nokia.com>
eric@webkit.org [Wed, 13 Jan 2010 00:58:21 +0000 (00:58 +0000)]
2010-01-12  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Geoffrey Garen.

        [ES5] Implement Object.getOwnPropertyNames
        https://bugs.webkit.org/show_bug.cgi?id=32242

        Add an extra argument to getPropertyNames() and getOwnPropertyNames()
        (and all reimplementations thereof) that indicates whether non-enumerable
        properties should be added.

        * API/JSCallbackObject.h:
        * API/JSCallbackObjectFunctions.h:
        (JSC::::getOwnPropertyNames):
        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * debugger/DebuggerActivation.cpp:
        (JSC::DebuggerActivation::getOwnPropertyNames):
        * debugger/DebuggerActivation.h:
        * runtime/Arguments.cpp:
        (JSC::Arguments::getOwnPropertyNames):
        * runtime/Arguments.h:
        * runtime/CommonIdentifiers.h:
        * runtime/JSArray.cpp:
        (JSC::JSArray::getOwnPropertyNames):
        * runtime/JSArray.h:
        * runtime/JSByteArray.cpp:
        (JSC::JSByteArray::getOwnPropertyNames):
        * runtime/JSByteArray.h:
        * runtime/JSFunction.cpp:
        (JSC::JSFunction::getOwnPropertyNames):
        * runtime/JSFunction.h:
        * runtime/JSNotAnObject.cpp:
        (JSC::JSNotAnObject::getOwnPropertyNames):
        * runtime/JSNotAnObject.h:
        * runtime/JSObject.cpp:
        (JSC::getClassPropertyNames):
        (JSC::JSObject::getPropertyNames):
        (JSC::JSObject::getOwnPropertyNames):
        * runtime/JSObject.h:
        * runtime/JSVariableObject.cpp:
        (JSC::JSVariableObject::getOwnPropertyNames):
        * runtime/JSVariableObject.h:
        * runtime/ObjectConstructor.cpp:
        (JSC::ObjectConstructor::ObjectConstructor):
        (JSC::objectConstructorGetOwnPropertyNames):
        * runtime/RegExpMatchesArray.h:
        (JSC::RegExpMatchesArray::getOwnPropertyNames):
        * runtime/StringObject.cpp:
        (JSC::StringObject::getOwnPropertyNames):
        * runtime/StringObject.h:
        * runtime/Structure.cpp: Rename getEnumerablePropertyNames() to getPropertyNames(), which takes an extra argument.
        (JSC::Structure::getPropertyNames):
        * runtime/Structure.h:
        (JSC::):
2010-01-12  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Geoffrey Garen.

        [ES5] Implement Object.getOwnPropertyNames
        https://bugs.webkit.org/show_bug.cgi?id=32242

        Add new argument to the reimplementation of getOwnPropertyNames().

        * UserObjectImp.cpp:
        (UserObjectImp::getOwnPropertyNames):
        * UserObjectImp.h:
2010-01-12  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Geoffrey Garen.

        [ES5] Implement Object.getOwnPropertyNames
        https://bugs.webkit.org/show_bug.cgi?id=32242

        Add tests for Object.getOwnPropertyNames(o), both standard usage and cross origin.

        * fast/js/Object-getOwnPropertyNames-expected.txt: Added.
        * fast/js/Object-getOwnPropertyNames.html: Added.
        * fast/js/script-tests/Object-getOwnPropertyNames.js: Added.
        * http/tests/security/cross-frame-access-enumeration-expected.txt:
        * http/tests/security/cross-frame-access-enumeration.html:
2010-01-12  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Geoffrey Garen.

        [ES5] Implement Object.getOwnPropertyNames
        https://bugs.webkit.org/show_bug.cgi?id=32242

        Add new argument to reimplementations of getPropertyNames()
        and getOwnPropertyNames(), and update the JS bindings generator.

        Test: fast/js/Object-getOwnPropertyNames.html

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::getPropertyNames):
        (WebCore::JSDOMWindow::getOwnPropertyNames):
        * bindings/js/JSDOMWindowShell.cpp:
        (WebCore::JSDOMWindowShell::getPropertyNames):
        (WebCore::JSDOMWindowShell::getOwnPropertyNames):
        * bindings/js/JSDOMWindowShell.h:
        * bindings/js/JSHistoryCustom.cpp:
        (WebCore::JSHistory::getOwnPropertyNames):
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::JSLocation::getOwnPropertyNames):
        * bindings/js/JSQuarantinedObjectWrapper.cpp:
        (WebCore::JSQuarantinedObjectWrapper::getPropertyNames):
        (WebCore::JSQuarantinedObjectWrapper::getOwnPropertyNames):
        * bindings/js/JSQuarantinedObjectWrapper.h:
        * bindings/js/JSStorageCustom.cpp:
        (WebCore::JSStorage::getOwnPropertyNames):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/runtime_array.cpp:
        (JSC::RuntimeArray::getOwnPropertyNames):
        * bridge/runtime_array.h:
        * bridge/runtime_object.cpp:
        (JSC::RuntimeObjectImp::getPropertyNames):
        (JSC::RuntimeObjectImp::getOwnPropertyNames):
        * bridge/runtime_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd correct expected results after r53168 for GTK and Qt.
bweinstein@apple.com [Wed, 13 Jan 2010 00:16:35 +0000 (00:16 +0000)]
Add correct expected results after r53168 for GTK and Qt.

* platform/gtk/fast/block: Added.
* platform/gtk/fast/block/positioning: Added.
* platform/gtk/fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt: Added.
* platform/qt/fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSafari shows an unneeded horizontal scrollbar on many websites.
bweinstein@apple.com [Tue, 12 Jan 2010 23:39:16 +0000 (23:39 +0000)]
Safari shows an unneeded horizontal scrollbar on many websites.
Fixes <rdar://6321041> and <http://webkit.org/b/33555>.

Reviewed by Dave Hyatt.

WebCore:

If a div has no children, and its height or width are 0, we can ignore
it in our calculation of lowest, rightmost, and leftmost positions. This
calculation was causing horizontal scrollbars to be drawn when they weren't needed.

Test: fast/block/positioning/absolute-positioning-no-scrollbar.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lowestPosition): Added check for no children and width or height 0.
(WebCore::RenderBlock::rightmostPosition): Ditto.
(WebCore::RenderBlock::leftmostPosition): Ditto.

LayoutTests:

Added a test that shows no scrollbar in the case where a div has no children
and either a width or height of 0. Also updated results for a few tests which
this patch causes progressions for.

* fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt: Added.
* fast/block/positioning/absolute-positioning-no-scrollbar.html: Added.
* fast/block/positioning/fixed-positioning-scrollbar-bug.html:
* platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
* platform/mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Tue, 12 Jan 2010 23:34:20 +0000 (23:34 +0000)]
2010-01-12  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Timothy Hatcher.

        Optimize WebInspector.TimelineGrid.prototype.updateDividers()

        DOM element property access and modification are slow and should be done as lazily as possible.
        https://bugs.webkit.org/show_bug.cgi?id=33536

        * inspector/front-end/TimelineGrid.js:
        (WebInspector.TimelineGrid.prototype.updateDividers):
        (WebInspector.TimelineGrid.prototype._setDividerAndBarLeft):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=33550 REGRESSION: -
bdakin@apple.com [Tue, 12 Jan 2010 23:10:22 +0000 (23:10 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=33550 REGRESSION: -
webkit-svg-shadow with opacity still over-clipped

Reviewed by Sam Weinig.

We need to call inflateForShadow() on the repaintRect before we
clip for opacity or we will over-clip.
* rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=33550 REGRESSION:
-webkit-svg-shadow with opacity still over-clipped

Reviewed by Sam Weinig.

* platform/mac/svg/css/shadow-and-opacity-expected.checksum: Added.
* platform/mac/svg/css/shadow-and-opacity-expected.png: Added.
* platform/mac/svg/css/shadow-and-opacity-expected.txt: Added.
* svg/css/shadow-and-opacity.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Update all-in-one derived sources for Geolocation.
sfalken@apple.com [Tue, 12 Jan 2010 22:48:20 +0000 (22:48 +0000)]
WebCore: Update all-in-one derived sources for Geolocation.

Reviewed by Sam Weinig.

* DerivedSources.cpp: Add JSCoordinates.cpp, JSGeolocation.cpp, JSGeoposition.cpp, JSPositionError.cpp

WebKit/win: Add Geolocation interfaces in WebKit for Windows.

Reviewed by Adam Roben, Sam Weinig.

* ForEachCoClass.h: Added WebGeolocationPosition.
* Interfaces/IWebError.idl:
* Interfaces/IWebGeolocationPosition.idl: Added.
* Interfaces/IWebGeolocationProvider.idl: Added.
* Interfaces/IWebViewPrivate.idl:
* Interfaces/WebKit.idl:
* WebCoreSupport/WebGeolocationControllerClient.cpp: Added.
(WebGeolocationControllerClient::WebGeolocationControllerClient):
(WebGeolocationControllerClient::startUpdating):
(WebGeolocationControllerClient::stopUpdating):
(WebGeolocationControllerClient::lastPosition):
* WebCoreSupport/WebGeolocationControllerClient.h: Added.
* WebGeolocationPosition.cpp: Added IWebGeolocationPosition implementation.
* WebGeolocationPosition.h: Added IWebGeolocationPosition implementation.
* WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPosition.idl, IWebGeolocationProvider.idl,
relocated JavaScriptCoreAPITypes.idl, WebScrollbarTypes.idl
* WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPosition.h/.cpp, WebGeolocationControllerClient.h/cpp,
* WebKitClassFactory.cpp: Add WebGeolocationPosition include.
* WebView.cpp:
(WebView::initWithFrame): Create WebGeolocationControllerClient if Geolocation is enabled.
(WebView::setGeolocationProvider): Added Geolocation-specific method.
(WebView::geolocationProvider): Added Geolocation-specific method.
(WebView::geolocationDidChangePosition): Added Geolocation-specific method.
(WebView::geolocationDidFailWithError): Added Geolocation-specific method.
* WebView.h: Added setGeolocationProvider, geolocationProvider, geolocationDidChangePosition, geolocationDidFailWithError.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 12 Jan 2010 22:12:28 +0000 (22:12 +0000)]
2010-01-12  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Remove static const ints from V8CustomBinding.h

        https://bugs.webkit.org/show_bug.cgi?id=33547

        * bindings/scripts/CodeGeneratorV8.pm: Generate and use custom
            internal field indices from lists of custom internal fields.
        * bindings/v8/NPV8Object.cpp:
        * bindings/v8/NPV8Object.h:
        * bindings/v8/V8Binding.cpp:
        * bindings/v8/V8DOMWindowShell.cpp:
        * bindings/v8/V8DOMWindowShell.h:
        * bindings/v8/V8DOMWrapper.cpp: Remove a bunch of now unnecessary
            manually calls to setInternalFieldCount().
        * bindings/v8/V8DOMWrapper.h:
        * bindings/v8/V8Index.h:
        * bindings/v8/V8IsolatedContext.cpp:
        * bindings/v8/V8IsolatedContext.h:
        * bindings/v8/V8NPObject.cpp:
        * bindings/v8/custom/V8AbstractWorkerCustom.cpp:
        * bindings/v8/custom/V8CustomBinding.h: Remove the static const ints.
        * bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        * bindings/v8/custom/V8DocumentCustom.cpp:
        * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
        * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
        * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
        * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
        * bindings/v8/custom/V8MessageChannelConstructor.cpp:
        * bindings/v8/custom/V8MessagePortCustom.cpp:
        * bindings/v8/custom/V8NodeCustom.cpp:
        * bindings/v8/custom/V8NotificationCenterCustom.cpp:
        * bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
        * bindings/v8/custom/V8WebSocketCustom.cpp:
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMSAA: Accessibility role of <select multiple> elements is wrong
jhoneycutt@apple.com [Tue, 12 Jan 2010 22:07:21 +0000 (22:07 +0000)]
MSAA: Accessibility role of <select multiple> elements is wrong

https://bugs.webkit.org/show_bug.cgi?id=33522

Reviewed by Darin Adler.

WebKit/win:

* AccessibleBase.cpp:
(MSAARole):
Map the WebCore::ListBox and WebCore::ListBoxOption roles to the MSAA
"list" and "list item" roles.

LayoutTests:

* platform/win/accessibility/multiple-select-element-role-expected.txt: Added.
* platform/win/accessibility/multiple-select-element-role.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 12 Jan 2010 21:59:03 +0000 (21:59 +0000)]
2010-01-12  Darin Fisher  <darin@chromium.org>

        Fixing chromium build bustage.

        * bindings/v8/custom/V8PopStateEventCustom.cpp: Add V8Proxy.h include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 12 Jan 2010 21:28:07 +0000 (21:28 +0000)]
2010-01-12  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add V8 bindings for PopStateEvent.
        https://bugs.webkit.org/show_bug.cgi?id=33546

        This is covered by existing tests for PopStateEvent.

        * WebCore.gypi:
        * bindings/v8/DOMObjectsInclude.h:
        * bindings/v8/DerivedSourcesAllInOne.cpp:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertEventToV8Object):
        * bindings/v8/V8Index.cpp:
        * bindings/v8/V8Index.h:
        * bindings/v8/custom/V8PopStateEventCustom.cpp: Added.
        (WebCore::V8PopStateEvent::initPopStateEventCallback):
        (WebCore::V8PopStateEvent::stateAccessorGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Kelly Norton <knorton@google.com>
knorton@google.com [Tue, 12 Jan 2010 21:25:53 +0000 (21:25 +0000)]
2010-01-12  Kelly Norton  <knorton@google.com>

        Reviewed by Timothy Hatcher.

        Adds source length to ParseHTMLRecords in the inspector timeline.
        https://bugs.webkit.org/show_bug.cgi?id=33548

        Test: inspector/timeline-parse-html.html

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::write):
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::willWriteHTML):
        * inspector/InspectorTimelineAgent.h:
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createParseHTMLRecord):
        * inspector/TimelineRecordFactory.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Jungshik Shin <jshin@chromium.org>
eric@webkit.org [Tue, 12 Jan 2010 21:15:28 +0000 (21:15 +0000)]
2010-01-12  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=31597

        Make ICU's text breakiterator and string search use Chrome's UI
        language instead of 'en-US' or the OS UI language.

        As long as the webkit layout tests are run in en-US locale, there'd be
        no visible change.

        * platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp:
        (UILanguage):
        (WebCore::currentSearchLocaleID):
        (WebCore::currentTextBreakLocaleID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdated results for these tests which just have rounding errors.
bdakin@apple.com [Tue, 12 Jan 2010 21:05:20 +0000 (21:05 +0000)]
Updated results for these tests which just have rounding errors.

Reviewed by Nikolas Zimmermann.

* platform/mac/svg/css/composite-shadow-example-expected.checksum:
* platform/mac/svg/css/composite-shadow-example-expected.png:
* platform/mac/svg/css/mask-with-shadow-expected.checksum:
* platform/mac/svg/css/mask-with-shadow-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Rubber-stamped by Dave Hyatt.
bdakin@apple.com [Tue, 12 Jan 2010 20:54:30 +0000 (20:54 +0000)]
WebCore: Rubber-stamped by Dave Hyatt.

This patch changes the name of -webkit-shadow to -webkit-svg-shadow
to avoid giving a custom property an overly-general name.
<rdar://problem/7534590>

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseShadow):
* css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
* css/SVGCSSPropertyNames.in:
* css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):

LayoutTests: This patch changes the name of -webkit-shadow to -webkit-svg-shadow
to avoid giving a custom property an overly-general name.
<rdar://problem/7534590>

* fast/repaint/moving-shadow-on-container.html:
* fast/repaint/moving-shadow-on-path.html:
* platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/arrow-with-shadow.svg:
* svg/css/circle-in-mask-with-shadow.svg:
* svg/css/clippath-with-shadow.svg:
* svg/css/composite-shadow-example.html:
* svg/css/composite-shadow-with-opacity.html:
* svg/css/getComputedStyle-basic-expected.txt:
* svg/css/group-with-shadow.svg:
* svg/css/mask-with-shadow.svg:
* svg/css/path-with-shadow.svg:
* svg/css/shadow-with-large-radius.svg:
* svg/css/shadow-with-negative-offset.svg:
* svg/css/stars-with-shadow.html:
* svg/filters/shadow-on-filter.svg:
* svg/filters/shadow-on-rect-with-filter.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed, build fix.
pkasting@chromium.org [Tue, 12 Jan 2010 20:49:56 +0000 (20:49 +0000)]
Not reviewed, build fix.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 12 Jan 2010 20:44:11 +0000 (20:44 +0000)]
2010-01-12  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add a null check in case of an event handler with invalid syntax.

        Should make fast/js/invalid-syntax--for-function.html not crash in
        Chromium's test shell.

        * bindings/v8/V8LazyEventListener.cpp:
        (WebCore::V8LazyEventListener::callListenerFunction): Check the listener object before using it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExtend WinLauncher example with better printing features.
bfulgham@webkit.org [Tue, 12 Jan 2010 20:32:11 +0000 (20:32 +0000)]
Extend WinLauncher example with better printing features.

Reviewed by Darin Adler.

* WinLauncher/PrintWebUIDelegate.cpp:
(PrintWebUIDelegate::webViewPrintingMarginRect): Provide slightly
 larger margins.
(PrintWebUIDelegate::webViewHeaderHeight): Compute header height based
 on text metrics.
(PrintWebUIDelegate::webViewFooterHeight): Compute footer height based
 on text metrics.
(PrintWebUIDelegate::drawHeaderInRect): Write useful header, along
 with separating line.
(PrintWebUIDelegate::drawFooterInRect):
* WinLauncher/PrintWebUIDelegate.h: Remove stubs.
* WinLauncher/WinLauncher.cpp:
(PrintView): Correct loop used to print individual pages.
 Previously it started at 0, which is a wild-card to print all
 pages at once.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 12 Jan 2010 19:59:33 +0000 (19:59 +0000)]
2010-01-12  Eric Carlson  <eric.carlson@apple.com>

        Unreviewed, build fix.

        Add media/video-poster-scale.html to GTK skipped list, it needs platform specific
        results (https://bugs.webkit.org/show_bug.cgi?id=33541). Fix test results on
        OSX and Windows.

        * media/video-poster-scale-expected.txt:
        * media/video-poster-scale.html:
        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove XBM support from the open-source image decoders.
pkasting@chromium.org [Tue, 12 Jan 2010 19:52:37 +0000 (19:52 +0000)]
Remove XBM support from the open-source image decoders.
https://bugs.webkit.org/show_bug.cgi?id=27823

Reviewed by Dimitri Glazkov.

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCoreSources.bkl:
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::create):
* platform/image-decoders/xbm: Removed.
* platform/image-decoders/xbm/XBMImageDecoder.cpp: Removed.
* platform/image-decoders/xbm/XBMImageDecoder.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Tue, 12 Jan 2010 19:42:07 +0000 (19:42 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=33540
        Make it possible to build in debug mode with assertions disabled

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 12 Jan 2010 19:41:29 +0000 (19:41 +0000)]
2010-01-12  Eric Carlson  <eric.carlson@apple.com>

        Unreviewed, build fix.

        Update test and results after r53146.

        * http/tests/security/local-video-poster-from-remote-expected.txt:
        * http/tests/security/local-video-poster-from-remote.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 12 Jan 2010 19:33:28 +0000 (19:33 +0000)]
2010-01-12  Philippe Normand  <pnormand@igalia.com>

        Rubber-stamped by Gustavo Noronha Silva.

        [GTK] Failing media/video-seek-past-end-playing.html
        https://bugs.webkit.org/show_bug.cgi?id=33015

        * platform/gtk/Skipped: Skipping the test again, we need to kill
        its last timer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-11-23 Yong Li <yoli@rim.com>
yong.li@torchmobile.com [Tue, 12 Jan 2010 18:50:07 +0000 (18:50 +0000)]
2009-11-23  Yong Li  <yoli@rim.com>

        Reviewed by Adam Treat.

        Make GIF decoder support down-sampling
        https://bugs.webkit.org/show_bug.cgi?id=31806

        * platform/image-decoders/ImageDecoder.cpp:
        (WebCore::ImageDecoder::upperBoundScaledY):
        (WebCore::ImageDecoder::lowerBoundScaledY):
        * platform/image-decoders/ImageDecoder.h:
        (WebCore::RGBA32Buffer::scaledRect):
        (WebCore::RGBA32Buffer::setScaledRect):
        (WebCore::ImageDecoder::scaledSize):
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::sizeNowAvailable):
        (WebCore::GIFImageDecoder::initFrameBuffer):
        (WebCore::copyOnePixel):
        (WebCore::GIFImageDecoder::haveDecodedRow):
        (WebCore::GIFImageDecoder::frameComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Eric Carlson.
philn@webkit.org [Tue, 12 Jan 2010 18:33:09 +0000 (18:33 +0000)]
    Reviewed by Eric Carlson.

        [GTK] Failing media/video-seek-past-end-playing.html
        https://bugs.webkit.org/show_bug.cgi?id=33015

        Listen on timeupdate event instead of waiting a fixed amount of
        time, which is prone to test flackyness.

        * media/audio-mpeg-supported.html:
        * media/video-seek-past-end-playing.html:
        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 12 Jan 2010 18:23:36 +0000 (18:23 +0000)]
2010-01-12  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler and Simon Fraser.

        rdar://problem/5684062
        https://bugs.webkit.org/show_bug.cgi?id=23094
        Flash of white when switching from poster image to video playback

        https://bugs.webkit.org/show_bug.cgi?id=23140
        <video> poster should scale like a video frame

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::setReadyState): Only call updatePosterImage from one place

        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::HTMLVideoElement): m_shouldShowPosterImage -> m_shouldDisplayPoster.
        (WebCore::HTMLVideoElement::createRenderer): Always create a RenderVideo.
        (WebCore::HTMLVideoElement::attach): Call updatePosterImage before checking to see if we
            should display the poster image. renderer() is never a RenderImage, don't need to check.
            m_shouldShowPosterImage -> m_shouldDisplayPoster.
        (WebCore::HTMLVideoElement::detach): m_shouldShowPosterImage -> m_shouldDisplayPoster.
        (WebCore::HTMLVideoElement::parseMappedAttribute): Cache poster attribute when it is set since
            it is checked frequently. m_shouldShowPosterImage -> m_shouldDisplayPoster.
        (WebCore::HTMLVideoElement::updatePosterImage): Don't bother looking at the network state,
            display the poster as long as the attribute is valid and the media engine says it hasn't
            rendered a video frame. m_shouldShowPosterImage -> m_shouldDisplayPoster.
        (WebCore::HTMLVideoElement::hasAvailableVideoFrame): New, ask the media engine if a video frame
            is available to render.
        * html/HTMLVideoElement.h:
        (WebCore::HTMLVideoElement::poster):
        (WebCore::HTMLVideoElement::shouldDisplayPoster):

        * loader/ImageLoader.cpp:
        (WebCore::ImageLoader::updateRenderer): Call setCachedImage for render video too.

        * manual-tests/video-player.html: Remove bit-rot from manual test so it works again.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::hasAvailableVideoFrame): New, ask the media engine if a video frame
            is available to render.

        * platform/graphics/MediaPlayer.h: Prototype for hasAvailableVideoFrame.
        * platform/graphics/MediaPlayerPrivate.h: Ditto.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h: Declare hasAvailableVideoFrame, declare
            all bool variables to aid packing.
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_videoFrameHasDrawn. Cleanup
            floating point initializers to match coding guidelines.
        (WebCore::MediaPlayerPrivate::load): Initialize m_videoFrameHasDrawn.
        (WebCore::MediaPlayerPrivate::hasAvailableVideoFrame): New.
        (WebCore::MediaPlayerPrivate::repaint): Set m_videoFrameHasDrawn.

        (WebCore::RenderImage::paintReplaced): Split part out into paint method.
        (WebCore::RenderImage::paint): New.
        * rendering/RenderImage.h: Declare paint. Make isWidthSpecified and isHeightSpecified protected
            instead of private so RenderVideo can use them.

        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::RenderMedia): Inherit from RenderImage, not RenderReplaced
        (WebCore::RenderMedia::destroy): Ditto.
        (WebCore::RenderMedia::styleDidChange): Ditto.
        (WebCore::RenderMedia::layout): Ditto.
        (WebCore::RenderMedia::lowestPosition): Ditto.
        (WebCore::RenderMedia::rightmostPosition): Ditto.
        (WebCore::RenderMedia::leftmostPosition): Ditto.
        * rendering/RenderMedia.h: Declare isImage and isRenderImage.

        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::intrinsicSizeChanged): New, call RenderVideo::intrinsicSizeChanged
            when displaying a poster so it is sized correctly.
        (WebCore::RenderVideo::imageChanged): Override so we can cache the image's intrisic size and
        use it when we also know the movie's intrinsic size but still need to draw the poster.
        (WebCore::RenderVideo::videoBox): Use the poster's intrinsic size when drawing the poster,
        use the movie's intrinsic size when drawing frames.
        (WebCore::RenderVideo::paintReplaced): Call RenderImage::paint when drawing the poster.
        (WebCore::RenderVideo::videoElement): New.
        (WebCore::RenderVideo::updatePlayer):
        * rendering/RenderVideo.h:
        (WebCore::RenderVideo::minimumReplacedHeight): Added.

2010-01-12  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler and Simon Fraser.

        rdar://problem/5684062
        https://bugs.webkit.org/show_bug.cgi?id=23094
        Flash of white when switching from poster image to video playback

        https://bugs.webkit.org/show_bug.cgi?id=23140
        <video> poster should scale like a video frame

        * media/video-poster-expected.txt: Remove blank line at beginning of test result present
        as a side effect of the media element using RenderImage to display the poster.
        * media/video-poster-scale.html: New.
        * media/video-poster-scale-expected.txt: New.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-11 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 12 Jan 2010 18:11:12 +0000 (18:11 +0000)]
2010-01-11  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] "build-webkit --chromium" should run "make all" on Linux
        https://bugs.webkit.org/show_bug.cgi?id=33500

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-11 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 12 Jan 2010 18:10:22 +0000 (18:10 +0000)]
2010-01-11  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Re-work webkit_unit_tests so that WebKit is initialized only once
        https://bugs.webkit.org/show_bug.cgi?id=33504

        * WebKit.gyp:
        * tests/KURLTest.cpp:
        (ComponentCase::TEST):
        * tests/RunAllTests.cpp: Added.
        (main):
        * tests/WebKitTest.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Tony Chang <tony@chromium.org>
eric@webkit.org [Tue, 12 Jan 2010 18:10:14 +0000 (18:10 +0000)]
2010-01-12  Tony Chang  <tony@chromium.org>

        Reviewed by Maciej Stachowiak.

        Add a test for a Chromium crash when loading multipart/x-mixed-replace
        data.

        https://bugs.webkit.org/show_bug.cgi?id=31446

        * http/tests/multipart/multipart-wait-before-boundary-expected.txt: Added.
        * http/tests/multipart/multipart-wait-before-boundary.html: Added.
        * http/tests/multipart/resources/multipart-wait-before-boundary.php: Added.
2010-01-12  Tony Chang  <tony@chromium.org>

        Reviewed by Maciej Stachowiak.

        Fix a crash in Chromium when receiving multipart/x-mixed-replace data.
        If we stop a multipart load after ResourceLoader::didReceiveResponse
        but before ResourceLoader::didReceiveData, we have a NULL document
        loader because it has been moved back to the provisional state.  New
        loads that happen after this will dereference the NULL document
        loader.

        Work around this by moving the provisional document loader back as
        the document loader when the request is stopped.

        https://bugs.webkit.org/show_bug.cgi?id=31446

        Test: http/tests/multipart/multipart-wait-before-boundary.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::checkLoadCompleteForThisFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit returns incorrect match count when first string match is on an element with...
enrica@apple.com [Tue, 12 Jan 2010 17:15:36 +0000 (17:15 +0000)]
WebKit returns incorrect match count when first string match is on an element with user-select-none style
https://bugs.webkit.org/show_bug.cgi?id=33508
<rdar://problem/7482143>

Reviewed by Darin Adler.

If we use VisiblePosition to calculate the start of the new search range,
we skip all the nodes with user-select-none style, producing an incorrect
match count.

No new tests: there are no API's available to Javascript to verify the
number of matches found.

* page/Frame.cpp:
(WebCore::Frame::markAllMatchesForText): Changed to use the end of the previous
result range as the start of the new search range.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Mikhail Naganov <mnaganov@chromium.org>
eric@webkit.org [Tue, 12 Jan 2010 17:03:26 +0000 (17:03 +0000)]
2010-01-12  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Timothy Hatcher.

        Changed ".sidebar" style to allow v-scroll to appear in
        "Profiles" panel sidebar.

        https://bugs.webkit.org/show_bug.cgi?id=33470

        No new tests -- no code changed.

        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Petri Latvala <petri.latvala@nomovok.com>
eric@webkit.org [Tue, 12 Jan 2010 14:37:19 +0000 (14:37 +0000)]
2010-01-12  Petri Latvala  <petri.latvala@nomovok.com>

        Reviewed by Antti Koivisto.

        fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html failed on buildbot
        https://bugs.webkit.org/show_bug.cgi?id=33465

        A touchmove event is not dispatched if none of the touch points actually moved.
        Changed the test to use touchstart instead.

        * fast/events/touch/touch-coords-in-zoom-and-scroll.html:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows accelerated compositing build fix after r53110
aroben@apple.com [Tue, 12 Jan 2010 13:55:31 +0000 (13:55 +0000)]
Windows accelerated compositing build fix after r53110

* plugins/PluginWidget.h:
(WebCore::PluginWidget::platformLayer): Define platformLayer() for
non-Mac platforms that have accelerated compositing turned on. It
would probably be better to make PluginWidget not be used at all on
non-Mac platforms, but this fix is much simpler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Xan Lopez.
kov@webkit.org [Tue, 12 Jan 2010 13:48:08 +0000 (13:48 +0000)]
    Reviewed by Xan Lopez.

        [GTK] couple fixes for signal emissions, and property notifications
        https://bugs.webkit.org/show_bug.cgi?id=33428

        Fix commitedLoad being called where it should not, causing it to
        be called one time too many in some cases. We now match Qt's and
        Mac's behavior here.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::finishedLoading):
        * tests/testloading.c:
        (load_error_status_changed_cb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 12 Jan 2010 13:05:55 +0000 (13:05 +0000)]
2010-01-12  Eric Seidel  <eric@webkit.org>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Threading problems with some of the tests
        https://bugs.webkit.org/show_bug.cgi?id=30814

        Skip another test which is hitting the SQLiteDatabase::sqliteHandle() threading ASSERT.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTouch event layout tests should be in their own subdirectory, so that they can be...
ossy@webkit.org [Tue, 12 Jan 2010 12:45:57 +0000 (12:45 +0000)]
Touch event layout tests should be in their own subdirectory, so that they can be easily skipped
https://bugs.webkit.org/show_bug.cgi?id=33526

Reviewed by Simon Hausmann.

Tests moved from fast/events to fast/events/touch by r53125,
relative resource paths should be adjuted to the new location.

* fast/events/touch/basic-touch-events.html: relative paths fixed.
* fast/events/touch/touch-coords-in-zoom-and-scroll.html: relative paths fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 12 Jan 2010 12:41:42 +0000 (12:41 +0000)]
2010-01-12  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Support injection of inspector scripts into the inspected context.

        https://bugs.webkit.org/show_bug.cgi?id=33523

        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::WeakReferenceCallback):
        (WebCore::createInjectedScriptHostV8Wrapper):
        (WebCore::createInjectedScript):
        (WebCore::InjectedScriptHost::injectedScriptFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 12 Jan 2010 12:31:44 +0000 (12:31 +0000)]
2010-01-12  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        AssignToCommitter does not need to fetch bugs twice
        https://bugs.webkit.org/show_bug.cgi?id=33530

        This is a no-brainer patch now that we've added Bug.reviewed_patches

        * Scripts/webkitpy/commands/upload.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 12 Jan 2010 12:03:21 +0000 (12:03 +0000)]
2010-01-12  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla.py should have an Attachment object instead of passing around dictionaries
        https://bugs.webkit.org/show_bug.cgi?id=31594

        * Scripts/webkitpy/bugzilla.py:
         - Add a new Attachment class, with accessor methods for all the necessary properties.
         - Update Bug to carry a pointer back to bugzilla (attachments need to access Bugzilla for committer validation and url())
         - Move reviewed_patches and commit_queued_patches out of Bugzilla custom methods and onto Bug
         - Move committer validation logic into its own class.
         - Committer rejection is only used in one place.  Make the new Bug reviewed_patches and commit_queued_patches
           handle the common case (of returning "reviewer" or "committer" as None), and let CommitterValidation handle
           the case where we want to reject patches in bugzilla.
         - Simplify fetch_patches_from_commit_queue now that committer validation is simpler.
         - Make all self.bugzilla.fetch_bug access go through BugzillaQueries._fetch_bug.
         - Mark set_flag_on_attachment as non-private to denote that CommitterValidation depends on it.
         - Move fetch_reviewed_patches_from_bug and fetch_commit_queue_patches_from_bug logic onto the Bug class.
        * Scripts/webkitpy/bugzilla_unittest.py:
         - Move test_flag_permission_rejection_message into a new CommitterValidationTest class.
        * Scripts/webkitpy/commands/download.py:
         - Store "bug_id" in state instead of making a fake patch object.
         - Update to use Attachment and Bug objects.
        * Scripts/webkitpy/commands/download_unittest.py:
         - Update expected results now that our testing framework covers more code.
        * Scripts/webkitpy/commands/early_warning_system.py: Update to use new Attachment class.
        * Scripts/webkitpy/commands/queries.py: Remove unused ReviewedPatches class.
        * Scripts/webkitpy/commands/queries_unittest.py: ditto.
        * Scripts/webkitpy/commands/queues.py: Update to use new Attachment and CommitterValidator classes.
        * Scripts/webkitpy/commands/queuestest.py: ditto.
        * Scripts/webkitpy/commands/upload.py: ditto.
        * Scripts/webkitpy/mock_bugzillatool.py:
         - Now that more logic has moved into Attachment and Bug, we have to actually
           provide real reviewer emails as well as real reviewer flags.
         - Update mock methods to return Attachment objects.
        * Scripts/webkitpy/scm.py: Update to use Attachment class.
        * Scripts/webkitpy/scm_unittest.py: Update to use Attachment class.
        * Scripts/webkitpy/statusserver.py: ditto.
        * Scripts/webkitpy/steps/applypatch.py: ditto.
        * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: ditto.
        * Scripts/webkitpy/steps/closebug.py: ditto.
        * Scripts/webkitpy/steps/closebugforlanddiff.py: Handle either state["bug_id"] or state["patch"].bug_id()
        * Scripts/webkitpy/steps/closepatch.py: Update to use Attachment class.
        * Scripts/webkitpy/steps/obsoletepatches.py: ditto.
        * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Ben Murdoch <benm@google.com>
eric@webkit.org [Tue, 12 Jan 2010 11:48:02 +0000 (11:48 +0000)]
2010-01-12  Ben Murdoch  <benm@google.com>

        Reviewed by Darin Adler.

        Form Reset : Press Back Button and Reset , TextareaElemnt is not set to Default Value
        https://bugs.webkit.org/show_bug.cgi?id=31539

        Added manual test: manual-tests/textarea-reset-default-value.html.

        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::restoreFormControlState): set the value, rather than default value of a text area when restoring its state. This allows resetting a form with a textarea to work correctly after its state has been restored.
        * manual-tests/resources/textarea-form-back-on-submit.html: Added.
        * manual-tests/textarea-reset-default-value.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Simon Hausmann <simon.hausmann@nokia.com>
eric@webkit.org [Tue, 12 Jan 2010 11:28:18 +0000 (11:28 +0000)]
2010-01-12  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] WebCore::Path allocates QPainterPath unnecessarily on the heap
        https://bugs.webkit.org/show_bug.cgi?id=33466

        WebCore::Path is a pointer to a PlatformPath. In case of Qt that's a
        QPainterPath, which itself is a pointer to the elements (QVector).
        That creates unecessary allocations in PathQt.cpp.

        Replaced the "PlatformPath* m_path;" with a PlatformPathPtr, which
        is a plain QPainterPath.

        * platform/graphics/Path.h:
        (WebCore::Path::platformPath):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::drawFilledShadowPath):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::addPath):
        (WebCore::GraphicsContext::clip):
        (WebCore::GraphicsContext::clipOut):
        * platform/graphics/qt/PathQt.cpp:
        (WebCore::Path::~Path):
        (WebCore::Path::operator=):
        (WebCore::Path::contains):
        (WebCore::Path::strokeContains):
        (WebCore::Path::translate):
        (WebCore::Path::boundingRect):
        (WebCore::Path::strokeBoundingRect):
        (WebCore::Path::moveTo):
        (WebCore::Path::addLineTo):
        (WebCore::Path::addQuadCurveTo):
        (WebCore::Path::addBezierCurveTo):
        (WebCore::Path::addArcTo):
        (WebCore::Path::closeSubpath):
        (WebCore::Path::addArc):
        (WebCore::Path::addRect):
        (WebCore::Path::addEllipse):
        (WebCore::Path::clear):
        (WebCore::Path::isEmpty):
        (WebCore::Path::debugString):
        (WebCore::Path::apply):
        (WebCore::Path::transform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 12 Jan 2010 11:21:43 +0000 (11:21 +0000)]
2010-01-12  Adam Barth  <abarth@webkit.org>

        Unreviewed typo fix.  :(

        * Scripts/webkitpy/commands/early_warning_system.py:
        * Scripts/webkitpy/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 12 Jan 2010 11:10:38 +0000 (11:10 +0000)]
2010-01-12  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Add "error" to the right part of the message.

        * Scripts/webkitpy/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 12 Jan 2010 11:06:14 +0000 (11:06 +0000)]
2010-01-12  Eric Seidel  <eric@webkit.org>

        Reviewed by Simon Fraser.

        media/video-error-does-not-exist.html failed on Snow Leopard Release Bot
        https://bugs.webkit.org/show_bug.cgi?id=33434

        Add another media test to the skipped list.
        I expect these are all timing out for the same reason.
        We just don't know the reason yet.

        * platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Jakub Wieczorek <faw217@gmail.com>
abarth@webkit.org [Tue, 12 Jan 2010 10:42:06 +0000 (10:42 +0000)]
2010-01-12  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Adam Barth.

        [Qt] XSL stylesheets can load documents from a different origin

        https://bugs.webkit.org/show_bug.cgi?id=33423

        Add two expected results for Qt:
        QXmlQuery has a different behaviour with regard to loading failures
        comparing to libxslt.

        * platform/qt/http/tests/security/xss-DENIED-xsl-document-expected.txt:
        * platform/qt/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt:
2010-01-12  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Adam Barth.

        [Qt] XSL stylesheets can load documents from a different origin

        https://bugs.webkit.org/show_bug.cgi?id=33423

        * xml/XSLTProcessorQt.cpp:
        (WebCore::XSLTUriResolver::XSLTUriResolver):
        (WebCore::XSLTUriResolver::resolve):
        (WebCore::XSLTProcessor::transformToString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 12 Jan 2010 10:17:31 +0000 (10:17 +0000)]
2010-01-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        EWS should show purple when svn-apply fails
        https://bugs.webkit.org/show_bug.cgi?id=33527

        * Scripts/webkitpy/commands/early_warning_system.py:
        * Scripts/webkitpy/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTouch event layout tests should be in their own subdirectory, so that they can be...
hausmann@webkit.org [Tue, 12 Jan 2010 10:17:05 +0000 (10:17 +0000)]
Touch event layout tests should be in their own subdirectory, so that they can be easily skipped
https://bugs.webkit.org/show_bug.cgi?id=33526

Reviewed by Adam Barth.

* fast/events/touch/basic-touch-events-expected.txt: Renamed from LayoutTests/fast/events/basic-touch-events-expected.txt.
* fast/events/touch/basic-touch-events.html: Renamed from LayoutTests/fast/events/basic-touch-events.html.
* fast/events/touch/touch-coords-in-zoom-and-scroll-expected.txt: Renamed from LayoutTests/fast/events/touch-coords-in-zoom-and-scroll-expected.txt.
* fast/events/touch/touch-coords-in-zoom-and-scroll.html: Renamed from LayoutTests/fast/events/touch-coords-in-zoom-and-scroll.html.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Joanmarie Diggs <joanmarie.diggs@gmail.com>
eric@webkit.org [Tue, 12 Jan 2010 10:09:56 +0000 (10:09 +0000)]
2010-01-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Gustavo Noronha Silva.

        https://bugs.webkit.org/show_bug.cgi?id=30883
        [Gtk] Implement AtkText for HTML elements which contain text

        Tweak/correction: Eliminate a needless variable.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_text_get_caret_offset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 12 Jan 2010 09:50:12 +0000 (09:50 +0000)]
2010-01-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove copy/paste code from subclasses of AbstractReviewQueue
        https://bugs.webkit.org/show_bug.cgi?id=33525

        * Scripts/webkitpy/commands/early_warning_system.py:
        * Scripts/webkitpy/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 12 Jan 2010 09:42:13 +0000 (09:42 +0000)]
2010-01-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add Gustavo and Xan as gtk-ews watchers
        https://bugs.webkit.org/show_bug.cgi?id=33519

        * Scripts/webkitpy/commands/early_warning_system.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 12 Jan 2010 09:41:36 +0000 (09:41 +0000)]
2010-01-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        webkit-patch shouldn't waste my time for with a component prompt
        https://bugs.webkit.org/show_bug.cgi?id=33521

        The component field isn't very useful for bugs created with
        webkit-patch because they're likely to be resolved quickly.  Instead of
        always prompting for a component, we should just default to the "New
        Bugs" component.  If the bug stays around for more than five minutes,
        we can assign it a proper component.

        * Scripts/webkitpy/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 12 Jan 2010 09:40:54 +0000 (09:40 +0000)]
2010-01-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add experimental "land-safely" command to webkit-patch
        https://bugs.webkit.org/show_bug.cgi?id=33518

        * Scripts/webkitpy/commands/upload.py:
        * Scripts/webkitpy/commands/upload_unittest.py:
        * Scripts/webkitpy/steps/__init__.py:
        * Scripts/webkitpy/steps/postdiffforcommit.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 12 Jan 2010 08:18:48 +0000 (08:18 +0000)]
2010-01-12  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Geoffrey Garen.

        Allow creating injected script for the inspected script state. The InjectedScript is
        cached on the inspected ExecState global object and will be garbage collected when the
        object is collected. Each InjectedScript object is assigned unique id.

        https://bugs.webkit.org/show_bug.cgi?id=33469

        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::JSDOMGlobalObject::markChildren):
        (WebCore::JSDOMGlobalObject::setInjectedScript):
        (WebCore::JSDOMGlobalObject::injectedScript):
        * bindings/js/JSDOMGlobalObject.h: InjectedScript is cached on the global object as a
        field that is not visible from the inspected code. This InjectedScript should be alive as long as
        the global object is alive and should be accessible from Web Inspector's native code.
        (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::createInjectedScript): Creates injected script using the lexical global object of the
        inspected ScriptState. Reference to the object is stored on the global DOM object.
        (WebCore::InjectedScriptHost::injectedScriptFor):
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::InjectedScriptHost):
        (WebCore::InjectedScriptHost::injectedScriptForId):
        (WebCore::InjectedScriptHost::discardInjectedScripts): This method is expected to be called when the
        the InjectedScript are no longer needed. In particular, this should be called before frame navigation.
        * inspector/InjectedScriptHost.h:
        (WebCore::InjectedScriptHost::setInjectedScriptSource): This allows to provide injected script source.
        The source may be loaded in a platform specific way.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 12 Jan 2010 08:16:40 +0000 (08:16 +0000)]
2010-01-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        ecma/Date/15.9.5.12-1.js fails every night at midnight
        https://bugs.webkit.org/show_bug.cgi?id=28041

        Change the test to use a concrete time instead of "now".

        * tests/mozilla/ecma/Date/15.9.5.10-1.js:
        * tests/mozilla/ecma/Date/15.9.5.12-1.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed; updated for truth (and readability).
mjs@apple.com [Tue, 12 Jan 2010 07:25:51 +0000 (07:25 +0000)]
Not reviewed; updated for truth (and readability).

Fixed some wrong listings and reorganized this page.

* security/security-group-members.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-11 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 12 Jan 2010 06:46:49 +0000 (06:46 +0000)]
2010-01-11  Kent Tamura  <tkent@chromium.org>

        Unreviewd. Remove a duplicated line in an expectation file.

        * platform/mac-leopard/fast/text/find-kana-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to get find-kana tests passing on Qt, Leopard, and Tiger.
darin@apple.com [Tue, 12 Jan 2010 05:53:28 +0000 (05:53 +0000)]
Try to get find-kana tests passing on Qt, Leopard, and Tiger.

* platform/mac-leopard/fast/text/find-kana-expected.txt: Expect more failures.
* platform/qt/fast/text/find-kana-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix handling of unusual kana sequences in search
darin@apple.com [Tue, 12 Jan 2010 01:48:23 +0000 (01:48 +0000)]
Fix handling of unusual kana sequences in search
https://bugs.webkit.org/show_bug.cgi?id=33506

Reviewed by Dan Bernstein.

WebCore:

* editing/TextIterator.cpp:
(WebCore::composedVoicedSoundMark): Removed unnnecessary case for a
non-kana-letter character. This function only works for kana letters.
(WebCore::SearchBuffer::isBadMatch): Fixed voiced sound mark code to
properly handle cases where one character has a shorter list of
combining voiced sound marks than the other.

LayoutTests:

* fast/text/find-kana-expected.txt: Updated.
* fast/text/script-tests/find-kana.js: Added new tests for sequences
that do not have composed equivalents. This is needed to test the code
that compares voice marks. The old test cases didn't cover the combining
character code path because normalizing to NFC combined all the sequences.
* platform/mac-leopard/fast/text/find-kana-expected.txt: Updated.
* platform/qt/fast/text/find-kana-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53114 268f45cc-cd09-0410-ab3c-d52691b4dbfc