WebKit-https.git
8 years agoUnreviewed gardening for Qt port. Updating expectation files and skipped tests which are
alexis.menard@openbossa.org [Mon, 7 May 2012 14:10:34 +0000 (14:10 +0000)]
Unreviewed gardening for Qt port. Updating expectation files and skipped tests which are
timing out.

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/fullscreen/full-screen-placeholder-expected.txt: Added.
* platform/qt-5.0-wk2/fullscreen/full-screen-render-inline-expected.txt: Added.
* platform/qt-5.0-wk2/fullscreen/parent-flow-inline-with-block-child-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnittest fix after r116288, because now there are more than 5 hit for the 'Eric'...
ossy@webkit.org [Mon, 7 May 2012 14:06:43 +0000 (14:06 +0000)]
Unittest fix after r116288, because now there are more than 5 hit for the 'Eric' word.
We have only 2 'Gavin', so it is a better choice than 'Eric' for unit testing.

Reviewed by Tor Arne Vestbø.

* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_whois):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [TextPrompt] Event listeners and CSS style are not removed on detachment
apavlov@chromium.org [Mon, 7 May 2012 13:38:40 +0000 (13:38 +0000)]
Web Inspector: [TextPrompt] Event listeners and CSS style are not removed on detachment
https://bugs.webkit.org/show_bug.cgi?id=85789

Reviewed by Yury Semikhatsky.

* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.detach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116299, r116301, and r116303.
ossy@webkit.org [Mon, 7 May 2012 12:58:21 +0000 (12:58 +0000)]
Unreviewed, rolling out r116299, r116301, and r116303.
http://trac.webkit.org/changeset/116299
http://trac.webkit.org/changeset/116301
http://trac.webkit.org/changeset/116303
https://bugs.webkit.org/show_bug.cgi?id=85795

Build is still broken (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-07

Source/WebKit2:

* qt/MainQt.cpp:
(main):

Tools:

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/main.cpp:
(main):
* QtTestPlatformPlugin/QtTestPlatformPlugin.pro: Removed.
* QtTestPlatformPlugin/TestIntegration.cpp: Removed.
* QtTestPlatformPlugin/TestIntegration.h: Removed.
* QtTestPlatformPlugin/mac/TestFontDatabase.h: Removed.
* QtTestPlatformPlugin/mac/TestFontDatabase.mm: Removed.
* QtTestPlatformPlugin/mac/TestIntegrationMac.mm: Removed.
* QtTestPlatformPlugin/main.cpp: Removed.
* QtTestPlatformPlugin/testplatform.json: Removed.
* Tools.pro:
* WebKitTestRunner/Target.pri:
* WebKitTestRunner/qt/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Qt build fix.
kbalazs@webkit.org [Mon, 7 May 2012 12:30:41 +0000 (12:30 +0000)]
Unreviewed Qt build fix.

One more try to learn how to use
const with a pointer array.

* DumpRenderTree/qt/main.cpp:
(initializeTestPlatformPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Icon database path may be NULL when a new path was set.
commit-queue@webkit.org [Mon, 7 May 2012 12:30:10 +0000 (12:30 +0000)]
[EFL] Icon database path may be NULL when a new path was set.
https://bugs.webkit.org/show_bug.cgi?id=82456

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-05-07
Reviewed by Andreas Kling.

ewk_settings_icon_database_path_set calls asynchronous method WebCore::iconDatabase().open().
There is no notification when the new path is set by WebCore.
Moreover ewk_settings_icon_database_path_set keeps the new path in a local variable.

To retrieve path to icon database ewk_settings_icon_database_path_get can be called.
It first checks flags whether icon databse is opened and enabled. There is possibility
that icon database has been set through API but it hasn't been opened by WebCore yet.
So as a result ewk_settings_icon_database_path_get returns NULL because WebCore hasn't
set an appropriate flag yet.

It may happen while icon database set/get sequences.
Information whether icon database is opened/enabled should be exposed by separate API.

* ewk/ewk_settings.cpp:
(ewk_settings_icon_database_path_get): Skip checking whether icon database is opened, enabled.
* ewk/ewk_settings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix after r116299.
kbalazs@webkit.org [Mon, 7 May 2012 12:15:56 +0000 (12:15 +0000)]
Unreviewed build fix after r116299.

* DumpRenderTree/qt/main.cpp:
(initializeTestPlatformPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Enable fullscreen api layout tests on WebKit2.
alexis.menard@openbossa.org [Mon, 7 May 2012 11:59:44 +0000 (11:59 +0000)]
[Qt] Enable fullscreen api layout tests on WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=85616

Reviewed by Csaba Osztrogonác.

http://trac.webkit.org/changeset/116089 implements the fullscreen API for WebKit2,
we can now unskip the related tests.

* platform/qt-4.8/Skipped:
* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Add test specific platform plugin to achieve unified layout test results
kbalazs@webkit.org [Mon, 7 May 2012 11:49:00 +0000 (11:49 +0000)]
[Qt] Add test specific platform plugin to achieve unified layout test results
https://bugs.webkit.org/show_bug.cgi?id=80996

Reviewed by Simon Hausmann.

Source/WebKit2:

Initialize the test platform plugin before initializing
the web process if we are in a WTR run.
It is necessary to place this initialization here as we
cannot control wich platform plugin will be used after
the instantiation of the QApplication.

* qt/MainQt.cpp:
(initializeTestPlatformPluginForWTRIfRequired):
(main):

Tools:

Added QtTestPlatformPlugin as a new project under Tools.
This is a Qt5-ish platform plugin that can be used to tweak the
platform support interfaces in order to unify layout test results.
For now it only overrides the font database on Mac and redirects
everything else to the real platform plugin. The font database it
provides mimics the way how we set up test fonts with fontconfig on Linux.
Make DumpRenderTree and WebKitTestRunner use this platform plugin.

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/main.cpp:
(initializeTestPlatformPlugin):
(main):
* QtTestPlatformPlugin/QtTestPlatformPlugin.pro: Added.
* QtTestPlatformPlugin/TestIntegration.cpp: Added.
(TestIntegration::TestIntegration):
(TestIntegration::fontDatabase):
* QtTestPlatformPlugin/TestIntegration.h: Added.
(TestIntegration):
(TestIntegration::hasCapability):
(TestIntegration::createPlatformPixmap):
(TestIntegration::createPlatformWindow):
(TestIntegration::createPlatformBackingStore):
(TestIntegration::createPlatformOpenGLContext):
(TestIntegration::createPlatformSharedGraphicsCache):
(TestIntegration::guiThreadEventDispatcher):
(TestIntegration::clipboard):
(TestIntegration::drag):
(TestIntegration::inputContext):
(TestIntegration::accessibility):
(TestIntegration::nativeInterface):
(TestIntegration::services):
(TestIntegration::styleHint):
(TestIntegration::platformTheme):
* QtTestPlatformPlugin/mac/TestFontDatabase.h: Added.
(TestFontDatabase):
* QtTestPlatformPlugin/mac/TestFontDatabase.mm: Added.
(TestFontDatabase::populateFontDatabase):
* QtTestPlatformPlugin/mac/TestIntegrationMac.mm: Added.
(TestIntegration::fontDatabase):
* QtTestPlatformPlugin/main.cpp: Added.
(TestIntegrationPlugin::keys):
(TestIntegrationPlugin::create):
(TestIntegrationPlugin::initialize):
* QtTestPlatformPlugin/testplatform.json: Added.
* Tools.pro:
* WebKitTestRunner/Target.pri:
* WebKitTestRunner/qt/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuildfix for buggy GCC
ossy@webkit.org [Mon, 7 May 2012 11:43:06 +0000 (11:43 +0000)]
Buildfix for buggy GCC
https://bugs.webkit.org/show_bug.cgi?id=85781

Reviewed by Zoltan Herczeg.

* rendering/RenderBlock.h:
(WebCore::RenderBlock::MarginInfo::clearMargin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] Gardening current IMAGE failures
commit-queue@webkit.org [Mon, 7 May 2012 11:34:50 +0000 (11:34 +0000)]
[EFL][DRT] Gardening current IMAGE failures
https://bugs.webkit.org/show_bug.cgi?id=85604

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-05-07

* platform/efl/fast/forms/input-placeholder-text-indent-expected.png: Removed.
* platform/efl/fast/forms/isindex-placeholder-expected.png: Removed.
* platform/efl/fast/forms/placeholder-with-positioned-element-expected.png: Removed.
* platform/efl/fast/forms/textarea-placeholder-wrapping-expected.png: Removed.
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] media/video-poster-blocked-by-willsendrequest.html is flaky
commit-queue@webkit.org [Mon, 7 May 2012 11:26:33 +0000 (11:26 +0000)]
[EFL] media/video-poster-blocked-by-willsendrequest.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=85609

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-07
Reviewed by Simon Hausmann.

Flakiness was caused by the fact that
media/crash-closing-page-with-media-as-plugin-fallback.html and
media/video-poster-blocked-by-willsendrequest.html use the same PNG
file as poster attribute in the video tag. The PNG file gets cached
when the first test is executed and this somehow causes the second
test to fail.

The flakiness was addressed by clearing the memory and page caches
between tests.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, refined expectations for compositing failures + more suppressions.
caseq@chromium.org [Mon, 7 May 2012 11:21:28 +0000 (11:21 +0000)]
Unreviewed gardening, refined expectations for compositing failures + more suppressions.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd values for all features to Qt's features.pri
eric@webkit.org [Mon, 7 May 2012 11:13:05 +0000 (11:13 +0000)]
Add values for all features to Qt's features.pri
https://bugs.webkit.org/show_bug.cgi?id=85746

Reviewed by Tor Arne Vestbø.

When generate-feature-files generates features.pri it provides a value
for every possible ENABLE_.  In prepration for landing generate-feature-files
it seems appropriate to add a value for all possible ENABLEs to the existing
features.pri.  This lets me make sure that I'm getting them all right!

* qmake/mkspecs/features/features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [REGRESSION] Context menu for the left Script view gutter is broken
apavlov@chromium.org [Mon, 7 May 2012 10:30:14 +0000 (10:30 +0000)]
Web Inspector: [REGRESSION] Context menu for the left Script view gutter is broken
https://bugs.webkit.org/show_bug.cgi?id=85785

Reviewed by Pavel Feldman.

Fixed remaining usages of WebInspector.save to be WebInspector.fileManager.save.

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportRequest):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction.doSave):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent.doSave):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._contextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, more compositing test timeouts.
caseq@chromium.org [Mon, 7 May 2012 10:07:28 +0000 (10:07 +0000)]
Unreviewed gardening, more compositing test timeouts.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShare stylesheet data structures between documents
antti@apple.com [Mon, 7 May 2012 09:56:49 +0000 (09:56 +0000)]
Share stylesheet data structures between documents
https://bugs.webkit.org/show_bug.cgi?id=85598

Source/WebCore:

Reviewed by Darin Adler.

We currently make a copy of the data structures when restoring a cached stylesheet. This patch lets us share
the data until someone uses a mutating CSSOM API to modify the sheet.

The patch implements copy-on-write for the internal style sheet data structures. If any mutating CSSOM API is
invoked, we check if the mutation is safe (there is only one client, the sheet is not cached). If not then the
internal structures are copied and any existing CSSOM objects are re-attached to the new style tree. The copied
tree is mutated while the other clients stay attached to the original tree.

Sharing can save significant amount of memory on sites with large stylesheets. For example if you have
multiple articles open on wsj.com this saves ~2.6MB per tab.

Test: http/tests/css/shared-stylesheet-mutation.html
      http/tests/css/shared-stylesheet-mutation-preconstruct.html

* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::reattach):
(WebCore):
* css/CSSFontFaceRule.h:
(CSSFontFaceRule):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):
(WebCore::CSSMediaRule::reattach):
(WebCore):
* css/CSSMediaRule.h:
(CSSMediaRule):
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::setSelectorText):
(WebCore::CSSPageRule::reattach):
(WebCore):
* css/CSSPageRule.h:
(CSSPageRule):
* css/CSSRule.cpp:
(WebCore::CSSRule::reattach):

    After the internal stylerule tree has been copied, the existing wrappers are re-attached using recursive reattach() function.

* css/CSSRule.h:
(WebCore):
(CSSRule):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
(WebCore::CSSStyleRule::reattach):
(WebCore):
* css/CSSStyleRule.h:
(CSSStyleRule):
* css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::isCacheable):
(WebCore::StyleSheetInternal::ruleAt):

    Add ruleAt(), use it for both wrapper creation and reattaching.  Remove createChildRuleCSSOMWrapper .

(WebCore):
(WebCore::StyleSheetInternal::wrapperInsertRule):
(WebCore::StyleSheetInternal::wrapperDeleteRule):

    Invalidation moves to the calling wrapper.

(WebCore::StyleSheetInternal::addedToMemoryCache):
(WebCore::StyleSheetInternal::removedFromMemoryCache):
(WebCore::CSSStyleSheet::willMutateRules):

    This is called whenever StyleSheetInternal is going to be mutated. It will do copy-on-write if needed.

    Usually invoked by CSSStyleSheet::RuleMutation RAII type.

(WebCore::CSSStyleSheet::didMutateRules):

    This is called after the mutation is complete and will trigger the style recalc in the document.

(WebCore::CSSStyleSheet::didMutate):

    This is called directly after mutations that don't change StyleSheetInternal so don't require copy-on-write.

(WebCore::CSSStyleSheet::reattachChildRuleCSSOMWrappers):
(WebCore::CSSStyleSheet::setDisabled):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):
* css/CSSStyleSheet.h:
(StyleSheetInternal):
(WebCore::StyleSheetInternal::hasOneClient):
(WebCore::StyleSheetInternal::isMutable):
(WebCore::StyleSheetInternal::setMutable):

    Track mutability. Mutation is allowed only after willMutate call.

(WebCore::StyleSheetInternal::isInMemoryCache):

    Track if the object is in memory cache.

(WebCore::CSSStyleSheet::clearOwnerRule):
(CSSStyleSheet):
* css/MediaList.cpp:
(WebCore::MediaList::setMediaText):
(WebCore::MediaList::deleteMedium):
(WebCore::MediaList::appendMedium):
(WebCore::MediaList::didMutate):
(WebCore):
(WebCore::MediaList::reattach):
* css/MediaList.h:
(MediaList):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore):
(WebCore::StyleRuleCSSStyleDeclaration::willMutate):
(WebCore::StyleRuleCSSStyleDeclaration::didMutate):
(WebCore::StyleRuleCSSStyleDeclaration::reattach):
(WebCore::InlineCSSStyleDeclaration::didMutate):
* css/PropertySetCSSStyleDeclaration.h:
(WebCore::PropertySetCSSStyleDeclaration::willMutate):
(WebCore::PropertySetCSSStyleDeclaration::didMutate):
(StyleRuleCSSStyleDeclaration):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::setName):
(WebCore::WebKitCSSKeyframesRule::insertRule):
(WebCore::WebKitCSSKeyframesRule::deleteRule):
(WebCore::WebKitCSSKeyframesRule::reattach):
(WebCore):
* css/WebKitCSSKeyframesRule.h:
(WebKitCSSKeyframesRule):
* css/WebKitCSSRegionRule.cpp:
(WebCore::WebKitCSSRegionRule::reattach):
* css/WebKitCSSRegionRule.h:
(WebKitCSSRegionRule):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::reparseStyleSheet):
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::~CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):
(WebCore::CachedCSSStyleSheet::restoreParsedStyleSheet):

    Don't copy when restoring. It is no longer necessary.
    Set the cache bit on the stylesheet.

(WebCore::CachedCSSStyleSheet::saveParsedStyleSheet):

LayoutTests:

Reviewed by Darin Adler.

Test that mutations of a shared stylesheet work as expected.

This is an http test due to cross-document security restrictions with file urls
(they can be overriden in DRT but I'd like this to work in browser too).

* http/tests/css/resources/shared.css: Added.
* http/tests/css/resources/shared-stylesheet-mutation.js: Added.
* http/tests/css/shared-stylesheet-mutation-expected.txt: Added.
* http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt: Added.
* http/tests/css/shared-stylesheet-mutation-preconstruct.html: Added.
* http/tests/css/shared-stylesheet-mutation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed: the same fix in another file for chromium win build. Adding WebCore...
kinuko@chromium.org [Mon, 7 May 2012 09:47:27 +0000 (09:47 +0000)]
Unreviewed: the same fix in another file for chromium win build.  Adding WebCore namespace to FileSystemTypes.

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFileSystem):
(WebKit::WebFrameImpl::createFileEntry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, fast/text/international/thai-{baht-space,line-breaks}.html...
caseq@chromium.org [Mon, 7 May 2012 09:46:17 +0000 (09:46 +0000)]
Unreviewed gardening, fast/text/international/thai-{baht-space,line-breaks}.html now fail in release, too.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded myself as a committer.
adam.bergkvist@ericsson.com [Mon, 7 May 2012 09:31:47 +0000 (09:31 +0000)]
Added myself as a committer.

Not reviewed.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNot reviewed: chromium win build fix attempt; adding WebCore namespace to ambiguous...
kinuko@chromium.org [Mon, 7 May 2012 09:29:16 +0000 (09:29 +0000)]
Not reviewed: chromium win build fix attempt; adding WebCore namespace to ambiguous type name.

* src/WebFileSystemCallbacksImpl.cpp:
(WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed trivial build fix: Don't include bytearraytestdata.h in the QtWebKit
hausmann@webkit.org [Mon, 7 May 2012 09:21:28 +0000 (09:21 +0000)]
[Qt] Unreviewed trivial build fix: Don't include bytearraytestdata.h in the QtWebKit
module header.

* Source/sync.profile:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] Implement LayoutTestController::execCommand
commit-queue@webkit.org [Mon, 7 May 2012 09:20:40 +0000 (09:20 +0000)]
[EFL][DRT] Implement LayoutTestController::execCommand
https://bugs.webkit.org/show_bug.cgi?id=82286

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-07
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Add missing implementation execCommand and isCommandEnabled to EFL's
DumpRenderTreeSupport to execute an internal command and check if the
command is enabled.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::executeCoreCommandByName):
(DumpRenderTreeSupportEfl::isCommandEnabled):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Add missing implementation execCommand and isCommandEnabled to EFL's
LayoutTestController.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::execCommand):
(LayoutTestController::isCommandEnabled):

LayoutTests:

Unskipped test cases which rely on execCommand and
updated test expectations for failure test cases.

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, compositing/overflow/scrollbar-painting.html times out on mac...
caseq@chromium.org [Mon, 7 May 2012 09:17:39 +0000 (09:17 +0000)]
Unreviewed gardening, compositing/overflow/scrollbar-painting.html times out on mac & linux.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCleanup: Change boolean synchronous flag argument into enum in FileSystem API code
kinuko@chromium.org [Mon, 7 May 2012 08:57:37 +0000 (08:57 +0000)]
Cleanup: Change boolean synchronous flag argument into enum in FileSystem API code
https://bugs.webkit.org/show_bug.cgi?id=85741

Reviewed by David Levin.

Source/WebCore:

No new tests as this change has no functional effects.

* Modules/filesystem/DOMWindowFileSystem.cpp:
(WebCore::DOMWindowFileSystem::webkitRequestFileSystem):
* Modules/filesystem/LocalFileSystem.cpp:
(WebCore::LocalFileSystem::requestFileSystem):
* Modules/filesystem/LocalFileSystem.h:
(LocalFileSystem):
* Modules/filesystem/WorkerContextFileSystem.cpp:
(WebCore::WorkerContextFileSystem::webkitRequestFileSystem):
(WebCore::WorkerContextFileSystem::webkitRequestFileSystemSync):
(WebCore::WorkerContextFileSystem::webkitResolveLocalFileSystemSyncURL):
* platform/FileSystemType.h: Added FileSystemSynchronousType enum.

Source/WebKit/chromium:

* src/LocalFileSystemChromium.cpp:
(WebCore::openFileSystemHelper):
(WebCore::LocalFileSystem::readFileSystem):
(WebCore::LocalFileSystem::requestFileSystem):
* src/WebFileSystemCallbacksImpl.cpp:
(WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):
(WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem):
* src/WebFileSystemCallbacksImpl.h:
(WebFileSystemCallbacksImpl):
* src/WorkerAsyncFileSystemChromium.cpp:
(WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):
(WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge):
* src/WorkerAsyncFileSystemChromium.h:
(WebCore::WorkerAsyncFileSystemChromium::create):
(WorkerAsyncFileSystemChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRevert the previous.
antti@apple.com [Mon, 7 May 2012 08:42:51 +0000 (08:42 +0000)]
Revert the previous.

Not reviewed.

Apparently r116235 was already rolled out.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::determineScope):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r116235): broke a lot of tests on all chromium debug bots
antti@apple.com [Mon, 7 May 2012 08:13:57 +0000 (08:13 +0000)]
REGRESSION(r116235): broke a lot of tests on all chromium debug bots
https://bugs.webkit.org/show_bug.cgi?id=85773

Not reviewed.

Try to fix assert when scoped stylesheets are enabled.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::determineScope):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCleanup: Move FileSystem API type definitions into a separate header file
kinuko@chromium.org [Mon, 7 May 2012 07:39:20 +0000 (07:39 +0000)]
Cleanup: Move FileSystem API type definitions into a separate header file
https://bugs.webkit.org/show_bug.cgi?id=85738

Reviewed by David Levin.

Move FileSystem API type definitions from AsyncFileSystem.h and
AsyncFileSystemChromium.cpp for chromium port into a single separate
header file: FileSystemType.h

By doing this we make it clearer that every filesystem type can be
found in the header file and also can save including entire
AsyncFileSystem definition just for referring type enum value.

Source/WebCore:

No new tests as this change has no visible or functional changes.

* Modules/filesystem/DOMFileSystemBase.cpp:
(WebCore::pathToAbsolutePath):
* Modules/filesystem/DOMWindowFileSystem.cpp:
(WebCore::DOMWindowFileSystem::webkitRequestFileSystem):
(WebCore::DOMWindowFileSystem::webkitResolveLocalFileSystemURL):
(WebCore):
* Modules/filesystem/DOMWindowFileSystem.h:
* Modules/filesystem/LocalFileSystem.h:
(LocalFileSystem):
* Modules/filesystem/WorkerContextFileSystem.cpp:
(WebCore::WorkerContextFileSystem::webkitRequestFileSystem):
(WebCore::WorkerContextFileSystem::webkitRequestFileSystemSync):
(WebCore::WorkerContextFileSystem::webkitResolveLocalFileSystemURL):
(WebCore::WorkerContextFileSystem::webkitResolveLocalFileSystemSyncURL):
(WebCore):
* Modules/filesystem/WorkerContextFileSystem.h:
* platform/AsyncFileSystem.cpp:
(WebCore::AsyncFileSystem::isValidType):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
* platform/AsyncFileSystem.h:
(AsyncFileSystem):
(WebCore::AsyncFileSystem::type):
(WebCore::AsyncFileSystem::AsyncFileSystem):
* platform/FileSystemType.h: Added.
(WebCore):
* platform/blackberry/AsyncFileSystemBlackBerry.cpp:
(WebCore::AsyncFileSystem::isValidType):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystem::crackFileSystemURL):
(WebCore::AsyncFileSystemBlackBerry::AsyncFileSystemBlackBerry):
* platform/blackberry/AsyncFileSystemBlackBerry.h:
(AsyncFileSystemBlackBerry):
* platform/gtk/AsyncFileSystemGtk.cpp:
(WebCore::AsyncFileSystem::isValidType):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystem::crackFileSystemURL):
(WebCore::AsyncFileSystemGtk::AsyncFileSystemGtk):
* platform/gtk/AsyncFileSystemGtk.h:
(AsyncFileSystemGtk):

Source/WebKit/chromium:

* src/AssertMatchingEnums.cpp:
* src/AsyncFileSystemChromium.cpp:
(WebCore::AsyncFileSystem::crackFileSystemURL):
(WebCore::AsyncFileSystem::isValidType):
(WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):
(WebCore::AsyncFileSystemChromium::createIsolatedFileSystem):
(WebCore::AsyncFileSystemChromium::toURL):
* src/AsyncFileSystemChromium.h:
(WebCore::AsyncFileSystemChromium::create):
(AsyncFileSystemChromium):
* src/LocalFileSystemChromium.cpp:
(WebCore::openFileSystemHelper):
(WebCore::LocalFileSystem::readFileSystem):
(WebCore::LocalFileSystem::requestFileSystem):
* src/WebFileSystemCallbacksImpl.cpp:
(WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):
* src/WebFileSystemCallbacksImpl.h:
(WebFileSystemCallbacksImpl):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFileSystem):
(WebKit::WebFrameImpl::createFileEntry):
* src/WorkerAsyncFileSystemChromium.cpp:
(WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):
* src/WorkerAsyncFileSystemChromium.h:
(WebCore::WorkerAsyncFileSystemChromium::create):
(WorkerAsyncFileSystemChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[prepare-ChangeLog] Excludes a reference file used by reftests from test files.
hayato@chromium.org [Mon, 7 May 2012 06:52:46 +0000 (06:52 +0000)]
[prepare-ChangeLog] Excludes a reference file used by reftests from test files.
https://bugs.webkit.org/show_bug.cgi?id=74268

Reviewed by Ryosuke Niwa.

* Scripts/prepare-ChangeLog:
(generateFileList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] New test introduced in r116255 is failing
kkristof@inf.u-szeged.hu [Mon, 7 May 2012 06:45:34 +0000 (06:45 +0000)]
[Qt] New test introduced in r116255 is failing
https://bugs.webkit.org/show_bug.cgi?id=85777

Unreviewed gardening.

* platform/qt/Skipped: Skip the failing test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=85265
morrita@google.com [Mon, 7 May 2012 06:05:42 +0000 (06:05 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=85265
[Shadow DOM] ShadowTree needs a better name

Reviewed by Dimitri Glazkov.

.:

* Source/autotools/symbols.filter: Updated exported symbol names according to the rename.

Source/WebCore:

Renamed ShadowTree to ElementShadow, The ElementShadow class is
going to be a facade of Shadow related APIs.

Following renames follow:
- Element::shadowTree() to Element::shadow()
- ShadowRoot::tree() to ShadowRoot::owner()
- ShadowTree::recalcShadowTreeStyle() to ElementShadow::recalcStyle()

No new tests. Just renames.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/ComposedShadowTreeWalker.cpp:
(WebCore::shadowFor):
(WebCore::shadowOfParent):
(WebCore::ComposedShadowTreeWalker::traverseChild):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
(WebCore::ComposedShadowTreeWalker::traverseParent):
* dom/ContainerNodeAlgorithms.cpp:
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoTree):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromTree):
* dom/DOMAllInOne.cpp:
* dom/Document.cpp:
(WebCore::Document::buildAccessKeyMap):
* dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore::Element::willRemove):
(WebCore::Element::attach):
(WebCore::Element::detach):
(WebCore::Element::recalcStyle):
(WebCore::Element::hasShadowRoot):
(WebCore::Element::shadow):
(WebCore::Element::ensureShadow):
(WebCore::Element::ensureShadowRoot):
(WebCore::Element::childrenChanged):
* dom/Element.h:
(WebCore):
(Element):
* dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::~ElementRareData):
* dom/ElementShadow.cpp: Renamed from Source/WebCore/dom/ShadowTree.cpp.
(WebCore):
(WebCore::ElementShadow::ElementShadow):
(WebCore::ElementShadow::~ElementShadow):
(WebCore::validateShadowRoot):
(WebCore::ElementShadow::addShadowRoot):
(WebCore::ElementShadow::removeAllShadowRoots):
(WebCore::ElementShadow::willRemove):
(WebCore::ElementShadow::setParentTreeScope):
(WebCore::ElementShadow::attach):
(WebCore::ElementShadow::attachHost):
(WebCore::ElementShadow::detach):
(WebCore::ElementShadow::detachHost):
(WebCore::ElementShadow::insertionPointFor):
(WebCore::ElementShadow::selectionFor):
(WebCore::ElementShadow::reattach):
(WebCore::ElementShadow::childNeedsStyleRecalc):
(WebCore::ElementShadow::needsStyleRecalc):
(WebCore::ElementShadow::recalcStyle):
(WebCore::ElementShadow::needsReattachHostChildrenAndShadow):
(WebCore::ElementShadow::hostChildrenChanged):
(WebCore::ElementShadow::setNeedsReattachHostChildrenAndShadow):
(WebCore::ElementShadow::reattachHostChildrenAndShadow):
* dom/ElementShadow.h: Renamed from Source/WebCore/dom/ShadowTree.h.
(WebCore):
(ElementShadow):
(WebCore::ElementShadow::hasShadowRoot):
(WebCore::ElementShadow::youngestShadowRoot):
(WebCore::ElementShadow::oldestShadowRoot):
(WebCore::ElementShadow::selector):
(WebCore::ElementShadow::clearNeedsReattachHostChildrenAndShadow):
(WebCore::ElementShadow::host):
(ShadowRootVector):
(WebCore::ShadowRootVector::ShadowRootVector):
* dom/Node.cpp:
(WebCore::oldestShadowRootFor):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::hostChildrenChanged):
* dom/NodeRenderingContext.h:
(WebCore):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
(WebCore::ShadowRoot::owner):
* dom/ShadowRoot.h:
(WebCore):
(ShadowRoot):
* dom/TreeScopeAdopter.cpp:
(WebCore::shadowFor):
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::moveShadowToNewDocument):
* dom/TreeScopeAdopter.h:
(TreeScopeAdopter):
* html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
(WebCore::ColorInputType::shadowColorSwatch):
* html/FileInputType.cpp:
(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::multipleAttributeChanged):
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::findMainSummary):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::shadowSelect):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaControls):
(WebCore::HTMLMediaElement::hasMediaControls):
* html/HTMLSummaryElement.cpp:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::innerTextElement):
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
* html/InputType.cpp:
(WebCore::InputType::destroyShadowSubtree):
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
(WebCore::RangeInputType::createShadowSubtree):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::deleteBubbleTree):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::parseAttribute):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::attach):
(WebCore::InsertionPoint::detach):
(WebCore::InsertionPoint::distributeHostChildren):
(WebCore::InsertionPoint::clearDistribution):
* html/shadow/InsertionPoint.h:
* html/shadow/SliderThumbElement.cpp:
(WebCore::sliderThumbElementOf):
(WebCore::RenderSliderContainer::layout):
(WebCore::trackLimiterElementOf):
* html/shadow/TextFieldDecorationElement.cpp:
(WebCore::getDecorationRootAndDecoratedRoot):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::buildObjectForNode):
* page/FocusController.cpp:
(WebCore::FocusScope::focusScopeOf):
(WebCore::FocusScope::focusScopeOwnedByShadowHost):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::uploadButton):
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::updateReferencedText):
(WebCore::SVGTRefElement::detachTarget):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::clearResourceReferences):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::buildShadowTree):
* testing/Internals.cpp:
(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::youngestShadowRoot):
(WebCore::Internals::oldestShadowRoot):
(WebCore::Internals::removeShadowRoot):

Source/WebKit2:

* win/WebKit2.def: Updated exported symbol names according to the rename.
* win/WebKit2CFLite.def: Updated exported symbol names according to the rename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116235.
caseq@chromium.org [Mon, 7 May 2012 06:02:54 +0000 (06:02 +0000)]
Unreviewed, rolling out r116235.
http://trac.webkit.org/changeset/116235
https://bugs.webkit.org/show_bug.cgi?id=85773

broke a lot of tests on all chromium debug bots (Requested by
caseq_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-06

Source/WebCore:

* bindings/objc/DOMCSS.mm:
* css/CSSFontFaceRule.cpp:
* css/CSSFontFaceRule.h:
(CSSFontFaceRule):
* css/CSSImportRule.cpp:
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):
* css/CSSMediaRule.h:
(CSSMediaRule):
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::setSelectorText):
* css/CSSPageRule.h:
(CSSPageRule):
* css/CSSRule.cpp:
* css/CSSRule.h:
(CSSRule):
(WebCore::CSSRule::parserContext):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
* css/CSSStyleRule.h:
* css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::isCacheable):
(WebCore::StyleSheetInternal::createChildRuleCSSOMWrapper):
(WebCore::StyleSheetInternal::wrapperInsertRule):
(WebCore::StyleSheetInternal::wrapperDeleteRule):
(WebCore::StyleSheetInternal::styleSheetChanged):
(WebCore):
(WebCore::CSSStyleSheet::setDisabled):
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):
* css/CSSStyleSheet.h:
(StyleSheetInternal):
(WebCore::StyleSheetInternal::hasCharsetRule):
(WebCore::CSSStyleSheet::styleSheetChanged):
(CSSStyleSheet):
* css/MediaList.cpp:
(WebCore::MediaList::setMediaText):
(WebCore::MediaList::deleteMedium):
(WebCore::MediaList::appendMedium):
(WebCore::MediaList::notifyChanged):
* css/MediaList.h:
(MediaList):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::didMutate):
(WebCore):
(WebCore::StyleRuleCSSStyleDeclaration::setNeedsStyleRecalc):
(WebCore::InlineCSSStyleDeclaration::setNeedsStyleRecalc):
* css/PropertySetCSSStyleDeclaration.h:
(WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
(PropertySetCSSStyleDeclaration):
(StyleRuleCSSStyleDeclaration):
* css/StylePropertySet.cpp:
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::setName):
(WebCore::WebKitCSSKeyframesRule::insertRule):
(WebCore::WebKitCSSKeyframesRule::deleteRule):
* css/WebKitCSSKeyframesRule.h:
(WebKitCSSKeyframesRule):
* css/WebKitCSSRegionRule.cpp:
* css/WebKitCSSRegionRule.h:
(WebKitCSSRegionRule):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::reparseStyleSheet):
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::~CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):
(WebCore::CachedCSSStyleSheet::restoreParsedStyleSheet):
(WebCore::CachedCSSStyleSheet::saveParsedStyleSheet):

LayoutTests:

* http/tests/css/resources/shared-stylesheet-mutation.js: Removed.
* http/tests/css/resources/shared.css: Removed.
* http/tests/css/shared-stylesheet-mutation-expected.txt: Removed.
* http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt: Removed.
* http/tests/css/shared-stylesheet-mutation-preconstruct.html: Removed.
* http/tests/css/shared-stylesheet-mutation.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAttempt to fix the !ENABLE(INSPECTOR) build by making InspectorValues
abarth@webkit.org [Mon, 7 May 2012 05:54:16 +0000 (05:54 +0000)]
Attempt to fix the !ENABLE(INSPECTOR) build by making InspectorValues
available unconditionally.  We should probably rename these classes to
JSONValues and move them into WebCore/platform.

* inspector/InspectorValues.cpp:
* inspector/InspectorValues.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSP violation reports should have all the fields required by the spec
abarth@webkit.org [Mon, 7 May 2012 05:38:38 +0000 (05:38 +0000)]
CSP violation reports should have all the fields required by the spec
https://bugs.webkit.org/show_bug.cgi?id=85682

Reviewed by Darin Adler.

Source/WebCore:

This patch updates our CSP violation reports to include all the fields
in the spec.  We've discussed all these fields in the working group,
and we have fairly high confidence that these are safe to expose.

Tests: http/tests/security/contentSecurityPolicy/report-and-enforce.html
       http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin.html
       http/tests/security/contentSecurityPolicy/report-blocked-uri.html
       http/tests/security/contentSecurityPolicy/report-only-from-header.html
       http/tests/security/contentSecurityPolicy/report-only.html
       http/tests/security/contentSecurityPolicy/report-uri-from-child-frame.html
       http/tests/security/contentSecurityPolicy/report-uri.html

* page/ContentSecurityPolicy.cpp:
(CSPDirectiveList):
(WebCore::CSPDirectiveList::reportViolation):
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):

LayoutTests:

Update test results to show the new fields in the violation reports.
This patch also adds tests that exercise both the same-origin and the
cross-origin case for blocked-uri.

* http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
* http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin.html: Added.
* http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/report-blocked-uri.html: Added.
* http/tests/security/contentSecurityPolicy/report-only-expected.txt:
* http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
* http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
* http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCleanup: FileSystem API's Entry.toURL() impl should return KURL instead of String
kinuko@chromium.org [Mon, 7 May 2012 05:33:34 +0000 (05:33 +0000)]
Cleanup: FileSystem API's Entry.toURL() impl should return KURL instead of String
https://bugs.webkit.org/show_bug.cgi?id=85736

Change the return type of Entry::toURL() from String to KURL.

Reviewed by David Levin.

No new tests as this change should not have any visible impact in the javascript layer.

Source/WebCore:

* Modules/filesystem/EntryBase.cpp:
(WebCore::EntryBase::toURL):
* Modules/filesystem/EntryBase.h:
* platform/AsyncFileSystem.h:
* platform/blackberry/AsyncFileSystemBlackberry.cpp:
(AsyncFileSystemBlackberry::toURL):
* platform/blackberry/AsyncFileSystemBlackberry.h:
* platform/gtk/AsyncFileSystemGtk.cpp:
(AsyncFileSystemGtk::toURL):
* platform/gtk/AsyncFileSystemGtk.h:

Souce/We/chromium:

* src/AsyncFileSystemChromium.cpp:
(WebCore::AsyncFileSystemChromium::toURL):
String to KURL.
* src/AsyncFileSystemChromium.h:
(AsyncFileSystemChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed expectations update for overflow-positioning.html.
caseq@chromium.org [Mon, 7 May 2012 05:24:03 +0000 (05:24 +0000)]
Unreviewed expectations update for overflow-positioning.html.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Call currentThread through Platform.h directly
pilgrim@chromium.org [Mon, 7 May 2012 04:41:50 +0000 (04:41 +0000)]
[Chromium] Call currentThread through Platform.h directly
https://bugs.webkit.org/show_bug.cgi?id=85769

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8][Performance] Remove Isolate lookup from the call path
haraken@chromium.org [Mon, 7 May 2012 04:39:31 +0000 (04:39 +0000)]
[V8][Performance] Remove Isolate lookup from the call path
to get a cached JS wrapper object by getDOMXXXXMap().
https://bugs.webkit.org/show_bug.cgi?id=85205

Reviewed by Adam Barth.

The patch improves the performance of getting a cached JS wrapper
by getDOMXXXXMap(). For example, it improves the performance
of toV8(NodeList*) in getElementsByTagName(), getElementsByName(),
getElementsByClassName() by 7 ~ 9%.

Performance tests: https://bugs.webkit.org/attachment.cgi?id=139468

The performance test results in my Linux desktop:

getElementsByTagName :   40.76 ms => 37.52ms (+8.6%)
getElementsByName :      41.02 ms => 37.42ms (+9.6%)
getElementsByClassName : 40.32 ms => 37.68ms (+7.0%)

Unfortunately we cannot observe performance improvement in
Dromaeo/dom-query.html, which are testing getElementsByTagName(),
getElementsByName(), getElementsByClassName(). This is because
the bottleneck of these Dromaeo tests is not toV8(NodeList*) but
.length and .nodeType accesses. The patch for optimizing them
will be coming soon.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm: Modified as described above.
(GenerateHeader):
(GenerateNormalAttrGetter):
(GetDomMapFunction):
(NativeToJSValue):
* bindings/v8/DOMData.cpp:
(WebCore::DOMData::getCurrentStore):

* bindings/scripts/test/V8/V8Float64Array.h: Updated run-bindings-tests results.
(WebCore::V8Float64Array::wrap):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::V8TestActiveDOMObject::wrap):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::V8TestCustomNamedGetter::wrap):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::V8TestEventConstructor::wrap):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::itemCallback):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::V8TestEventTarget::wrap):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetter):
* bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::V8TestInterface::wrap):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::V8TestMediaQueryListListener::wrap):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::V8TestNamedConstructor::wrap):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetter):
(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
* bindings/scripts/test/V8/V8TestObj.h:
(WebCore::V8TestObj::wrap):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::V8TestSerializedScriptValueInterface::wrap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoContent Security Policy reports should be reported with content-type application...
abarth@webkit.org [Mon, 7 May 2012 04:34:30 +0000 (04:34 +0000)]
Content Security Policy reports should be reported with content-type application/json, should contain all required fields
https://bugs.webkit.org/show_bug.cgi?id=61360

Reviewed by Eric Seidel.

Source/WebCore:

This patch changes ContentSecurityPolicy to use JSON format for sending
violation reports rather than wwwform-encoding.  This patch aligns our
behavior with the specification and with Mozilla.  A follow up patch
will update the list of fields in the report to match the spec.

* loader/PingLoader.cpp:
(WebCore::PingLoader::reportContentSecurityPolicyViolation):
* page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::reportViolation):

LayoutTests:

Update results to show JSON format.

* http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
* http/tests/security/contentSecurityPolicy/report-only-expected.txt:
* http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
* http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
* http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
* http/tests/security/contentSecurityPolicy/resources/save-report.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Call cryptographicallyRandomValues through Platform.h
pilgrim@chromium.org [Mon, 7 May 2012 04:15:47 +0000 (04:15 +0000)]
[Chromium] Call cryptographicallyRandomValues through Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85763

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

* src/ChromiumOSRandomSource.cpp:
(WTF::cryptographicallyRandomValuesFromOS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a contributor to committers.py
mary.wu@torchmobile.com.cn [Mon, 7 May 2012 04:11:54 +0000 (04:11 +0000)]
Add a contributor to committers.py
https://bugs.webkit.org/show_bug.cgi?id=85761

Reviewed by Unreviewed.

Add myself to committers.py contributor.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Support html5 download attribute.
mary.wu@torchmobile.com.cn [Mon, 7 May 2012 04:09:39 +0000 (04:09 +0000)]
[BlackBerry] Support html5 download attribute.
https://bugs.webkit.org/show_bug.cgi?id=85044

Reviewed by Antonio Gomes.

Source/WebCore:

Pass download attribute filename to networkJob and it could be
overridden by the Content-Disposition HTTP header's filename parameter.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::initialize):
* platform/network/blackberry/ResourceRequest.h:
(WebCore::ResourceRequest::setSuggestSaveName):
(WebCore::ResourceRequest::suggestSaveName):
(ResourceRequest):
* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):

Source/WebKit/blackberry:

If a link has download attribute, we should pass that value and be able to
save file with the name according to HTML5:
http://updates.html5rocks.com/2011/08/Downloading-resources-in-HTML5-a-download

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPage::download):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::startDownload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDisallow unquoted -webkit-font-feature-settings tags
bashi@chromium.org [Mon, 7 May 2012 03:13:12 +0000 (03:13 +0000)]
Disallow unquoted -webkit-font-feature-settings tags
https://bugs.webkit.org/show_bug.cgi?id=85362

Reviewed by Kent Tamura.

Source/WebCore:

Disallow unquoted tags to follow the current draft.
http://dev.w3.org/csswg/css3-fonts/#font-feature-settings-prop

No new tests. css3/font-feature-settings-parsing.html was updated.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFeatureTag): Accepts only 4-characters string.

LayoutTests:

* css3/font-feature-settings-parsing-expected.txt: Updated to follow the current draft specification.
* css3/font-feature-settings-parsing.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix for r116260.
rakuco@webkit.org [Mon, 7 May 2012 02:53:33 +0000 (02:53 +0000)]
Unreviewed build fix for r116260.

COMPILE_ASSERT() does not expect a string in its second parameter.

* platform/graphics/TextRun.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening. Skip more failing tests.
rakuco@webkit.org [Mon, 7 May 2012 02:24:07 +0000 (02:24 +0000)]
[EFL] Gardening. Skip more failing tests.

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShrink TextRun object size
rwlbuis@webkit.org [Mon, 7 May 2012 02:19:15 +0000 (02:19 +0000)]
Shrink TextRun object size
https://bugs.webkit.org/show_bug.cgi?id=85751

Reviewed by Darin Adler.

Reorder the member variables in TextRun so it shrinks from 56 to 40 bytes on my 64-bit build. This is important
for SVG, since RenderSVGText shrinks because of this.

Also add a compile assert for the expected object size.

* platform/graphics/TextRun.cpp:
(ExpectedTextRunSize):
(WebCore):
* platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):
(WebCore::TextRun::direction):
(TextRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add WebKit API to access multiple attribute of input element
keishi@webkit.org [Mon, 7 May 2012 02:10:27 +0000 (02:10 +0000)]
[chromium] Add WebKit API to access multiple attribute of input element
https://bugs.webkit.org/show_bug.cgi?id=85355

Reviewed by Kent Tamura.

We need this to implement the datalist UI for <input type=email multiple>.

* public/WebInputElement.h:
(WebInputElement):
* src/WebInputElement.cpp:
(WebKit::WebInputElement::isMultiple):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Autofill backing store implementation upstream
commit-queue@webkit.org [Mon, 7 May 2012 01:50:45 +0000 (01:50 +0000)]
[BlackBerry] Autofill backing store implementation upstream
https://bugs.webkit.org/show_bug.cgi?id=85575

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-05-06
Reviewed by Rob Buis.

Source/WebCore:

Implemented class AutofillBackingStore which is responsible
for handling interaction with autofill database.

Replaced static function
CredentialBackingStore* CredentialBackingStore::instance()
with a helper function
CredentialBackingStore& credentialBackingStore(),
and used DEFINE_STATIC_LOCAL to construct the singleton
object.
Also removed unnecessary function close() and combined with
the destructor of class CredentialBackingStore.

Initial upstream, No new tests.

* PlatformBlackBerry.cmake:
* platform/network/blackberry/AutofillBackingStore.cpp: Added.
(WebCore):
(WebCore::autofillBackingStore):
(WebCore::AutofillBackingStore::AutofillBackingStore):
(WebCore::AutofillBackingStore::~AutofillBackingStore):
(WebCore::AutofillBackingStore::open):
(WebCore::AutofillBackingStore::add):
(WebCore::AutofillBackingStore::update):
(WebCore::AutofillBackingStore::contains):
(WebCore::AutofillBackingStore::get):
(WebCore::AutofillBackingStore::clear):
* platform/network/blackberry/AutofillBackingStore.h: Added.
(WebCore):
(AutofillBackingStore):
* platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::credentialBackingStore):
(WebCore::CredentialBackingStore::~CredentialBackingStore):
* platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):
(WebCore):
* platform/network/blackberry/CredentialStorageBlackBerry.cpp:
(WebCore::CredentialStorage::getFromPersistentStorage):

Source/WebKit/blackberry:

Replaced calling static function CredentialBackingStore::instance()
with calling the helper function credentialBackingStore().

* WebCoreSupport/CredentialManager.cpp:
(WebCore::CredentialManager::autofillAuthenticationChallenge):
(WebCore::CredentialManager::autofillPasswordForms):
(WebCore::CredentialManager::saveCredentialIfConfirmed):
(WebCore::CredentialManager::clearCredentials):
(WebCore::CredentialManager::clearNeverRememberSites):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago.: Part of: Building and debugging WebKit in the Xcode IDE requires a lot of setup
mitz@apple.com [Mon, 7 May 2012 01:41:09 +0000 (01:41 +0000)]
.: Part of: Building and debugging WebKit in the Xcode IDE requires a lot of setup
https://bugs.webkit.org/show_bug.cgi?id=85739

Reviewed by Daniel Bates.

* WebKit.xcworkspace: Added.
* WebKit.xcworkspace/contents.xcworkspacedata: Added.
* WebKit.xcworkspace/xcshareddata: Added.
* WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings: Added.
* WebKit.xcworkspace/xcshareddata/xcschemes: Added.
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme: Added
this scheme, which builds all source projects and runs WebProcess with
Safari as the client executable.
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Added
this scheme, which builds all source projects and runs Safari.
* WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Added
this scheme, which builds all tools projects and runs DumpRenderTree.

Tools: Tools part of: Building and debugging WebKit in the Xcode IDE requires a lot of setup
https://bugs.webkit.org/show_bug.cgi?id=85739

Reviewed by Daniel Bates.

* Scripts/build-webkit: Moved code that copies from WebKitLibraries to the product directory
from here...
* Scripts/copy-webkitlibraries-to-product-directory: ...to this new script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Enable WebKit2 build by default (again)
kov@webkit.org [Mon, 7 May 2012 01:31:20 +0000 (01:31 +0000)]
[GTK] Enable WebKit2 build by default (again)
https://bugs.webkit.org/show_bug.cgi?id=85750

* configure.ac: enable wk2 build by default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Shadow DOM] Node distribution should be refreshed before style recalc.
morrita@google.com [Mon, 7 May 2012 01:11:15 +0000 (01:11 +0000)]
[Shadow DOM] Node distribution should be refreshed before style recalc.
https://bugs.webkit.org/show_bug.cgi?id=85259

Reviewed by Dimitri Glazkov.

Source/WebCore:

Element::recalcStyle() calls child element's recalcStyle()
recursively, following ShadowTree::recalcShadowTreeStyle(). But
recalcShadowTreeStyle() should be called before such recursion if
necessary.

This is because style calculation and following renderer attachment
of each child element depends on up-to-date node distribution result
which is computed during the recalcShadowTreeStyle().

Test: fast/dom/shadow/shadow-dynamic-style-change-via-mutation-and-selector.html

* dom/Element.cpp: Moved recalcShadowTreeStyle() before child traversals.
(WebCore::Element::recalcStyle):

LayoutTests:

* fast/dom/shadow/shadow-dynamic-style-change-via-mutation-and-selector-expected.txt: Added.
* fast/dom/shadow/shadow-dynamic-style-change-via-mutation-and-selector.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSP should let sites both enforce one policy and monitor another
abarth@webkit.org [Mon, 7 May 2012 00:53:33 +0000 (00:53 +0000)]
CSP should let sites both enforce one policy and monitor another
https://bugs.webkit.org/show_bug.cgi?id=85561

Reviewed by Eric Seidel.

Source/WebCore:

This patch lets us enforce and/or monitor multiple CSP policies.
Rather than having a single directive list, we now have a vector of
directive lists.

Tests: http/tests/security/contentSecurityPolicy/combine-multiple-policies.html
       http/tests/security/contentSecurityPolicy/report-and-enforce.html

* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::copyStateFrom):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
(WebCore::ContentSecurityPolicy::deprecatedHeader):
(WebCore::ContentSecurityPolicy::deprecatedHeaderType):
    - Even after this patch, workers aren't smart enough to enforce
      multiple policies.  They just use the first header, like they did
      before.  We'll need to teach workers how to enforce multiple
      policies in a future patch.
(WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
(WebCore::ContentSecurityPolicy::allowInlineScript):
(WebCore::ContentSecurityPolicy::allowInlineStyle):
(WebCore::ContentSecurityPolicy::allowEval):
(WebCore::ContentSecurityPolicy::allowScriptFromSource):
(WebCore::ContentSecurityPolicy::allowObjectFromSource):
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
(WebCore::ContentSecurityPolicy::allowImageFromSource):
(WebCore::ContentSecurityPolicy::allowStyleFromSource):
(WebCore::ContentSecurityPolicy::allowFontFromSource):
(WebCore::ContentSecurityPolicy::allowMediaFromSource):
(WebCore::ContentSecurityPolicy::allowConnectFromSource):
* page/ContentSecurityPolicy.h:
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::notifyFinished):
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerContext):

Source/WebKit/chromium:

* src/SharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::notifyFinished):
* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::startWorkerContext):

LayoutTests:

Test that we can enforce multiple policies and that we can enforce one
policy while monitoring another.

* http/tests/security/contentSecurityPolicy/combine-multiple-policies-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/combine-multiple-policies.html: Added.
* http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/report-and-enforce.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInlineBox::setHasBadParent should be debug only
commit-queue@webkit.org [Mon, 7 May 2012 00:45:13 +0000 (00:45 +0000)]
InlineBox::setHasBadParent should be debug only
https://bugs.webkit.org/show_bug.cgi?id=85748

Patch by Rob Buis <rbuis@rim.com> on 2012-05-06
Reviewed by Eric Seidel.

Do not provide InlineBox::setHasBadParent in release builds.

* rendering/InlineBox.h:
(InlineBox):
(WebCore):
(WebCore::InlineBox::setHasBadParent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the build after r116246.
aestes@apple.com [Mon, 7 May 2012 00:26:43 +0000 (00:26 +0000)]
Fix the build after r116246.

* DumpRenderTree/LayoutTestController.cpp: Remove an unused function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate several build-webkit options to match the #defines they toggle
eric@webkit.org [Mon, 7 May 2012 00:14:35 +0000 (00:14 +0000)]
Update several build-webkit options to match the #defines they toggle
https://bugs.webkit.org/show_bug.cgi?id=85744

Reviewed by Adam Barth.

Most notable here is fixing --3d-canvas to be --webgl these days --
the define was renamed 15 months ago!

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation
commit-queue@webkit.org [Sun, 6 May 2012 23:28:20 +0000 (23:28 +0000)]
[EFL] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation
https://bugs.webkit.org/show_bug.cgi?id=83687

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-06
Reviewed by Antonio Gomes.

Source/WebKit/efl:

* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_scripts_can_access_clipboard_get):
(ewk_view_setting_scripts_can_access_clipboard_set):
* ewk/ewk_view.h:

Tools:

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setJavaScriptCanAccessClipboard):

LayoutTests:

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove 3D_CANVAS define from vsprops files (it was renamed WEBGL many months ago)
eric@webkit.org [Sun, 6 May 2012 23:26:40 +0000 (23:26 +0000)]
Remove 3D_CANVAS define from vsprops files (it was renamed WEBGL many months ago)
https://bugs.webkit.org/show_bug.cgi?id=85743

Reviewed by Adam Barth.

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoKURL::isBlankURL would be a nicer idiom than KURL::protocolIs("about")
commit-queue@webkit.org [Sun, 6 May 2012 22:57:29 +0000 (22:57 +0000)]
KURL::isBlankURL would be a nicer idiom than KURL::protocolIs("about")
https://bugs.webkit.org/show_bug.cgi?id=85641

Patch by Mike West <mkwst@chromium.org> on 2012-05-06
Reviewed by Adam Barth.

* dom/Document.cpp:
(WebCore::shouldInheritSecurityOriginFromOwner):
* page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::allowObjectFromSource):
(WebCore::CSPDirectiveList::allowChildFrameFromSource):
* page/PageSerializer.cpp:
(WebCore::SerializerMarkupAccumulator::appendCustomAttributes):
(WebCore::PageSerializer::serializeFrame):
* platform/KURL.cpp:
(WebCore::KURL::isBlankURL):
(WebCore):
* platform/KURL.h:
(KURL):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[TextureMapper] Layer images is uploaded to the GPU for each sync
commit-queue@webkit.org [Sun, 6 May 2012 22:46:31 +0000 (22:46 +0000)]
[TextureMapper] Layer images is uploaded to the GPU for each sync
https://bugs.webkit.org/show_bug.cgi?id=85727

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-06
Reviewed by Noam Rosenthal.

No new tests. This does not change functionality,
it only improves performance.

* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::updateBackingStore): Reset the needsDisplay
and needsDisplayRect variables after uploading the layer image.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConvert isPageBoxVisible to use Internals interface.
gyuyoung.kim@samsung.com [Sun, 6 May 2012 22:43:14 +0000 (22:43 +0000)]
Convert isPageBoxVisible to use Internals interface.
https://bugs.webkit.org/show_bug.cgi?id=85692

Reviewed by Darin Adler.

.:

* Source/autotools/symbols.filter: Add isPageBoxVisible symbol filter.

Source/WebCore:

Add isPageBoxVisible functions, because it is able to work in the
cross-port way through the Internals interface.

No new tests, since we are improving here the infra-structure for testing
a specific method.

* testing/Internals.cpp:
(WebCore):
(WebCore::Internals::isPageBoxVisible):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit/efl:

Remove isPageBoxVisible functions, because it is able to work in the
cross-port way through the Internals interface.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

Remove isPageBoxVisible functions, because it is able to work in the
cross-port way through the Internals interface.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Source/WebKit/qt:

Remove isPageBoxVisible functions, because it is able to work in the
cross-port way through the Internals interface.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit2:

* win/WebKit2.def: Add isPageBoxVisible symbol filter.

Tools:

Remove isPageBoxVisible functions, because it is able to work in the
cross-port way through the Internals interface.

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:

LayoutTests:

Call isPageBoxVisible functions from internals, because it is able to work in the
cross-port way through the Internals interface.

* printing/page-format-data-expected.txt:
* printing/page-format-data.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agosheriffbot isn't reopening patches after it lands rollouts
tomz@codeaurora.org [Sun, 6 May 2012 22:33:19 +0000 (22:33 +0000)]
sheriffbot isn't reopening patches after it lands rollouts
https://bugs.webkit.org/show_bug.cgi?id=64418

Reviewed by Adam Barth.

* Scripts/webkitpy/tool/commands/download_unittest.py:
* Scripts/webkitpy/tool/steps/createbug.py:
(CreateBug.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: "Goto Function" filtering should be less restrictive.
commit-queue@webkit.org [Sun, 6 May 2012 22:19:45 +0000 (22:19 +0000)]
Web Inspector: "Goto Function" filtering should be less restrictive.
https://bugs.webkit.org/show_bug.cgi?id=85586

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-05-06
Reviewed by Pavel Feldman.

Added tests for generated regex.

Changes:
1) Avoid asterisks in filtering queue.
2) Optimization: do not create regexp for each item.

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype.get _itemsLoaded):
Applied new filtering workflow.
(WebInspector.FilteredItemSelectionDialog.prototype._checkItemAt):
Removed.
(WebInspector.FilteredItemSelectionDialog.prototype._createSearchRegExp):
Removed unused "suffix" logic; changed the way regexp is composed from query.
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
Applied new filtering workflow.
(WebInspector.FilteredItemSelectionDialog.prototype._onKeyDown):
Removed unused var.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename ICULocale to LocaleICU, part 2
tkent@chromium.org [Sun, 6 May 2012 22:12:51 +0000 (22:12 +0000)]
Rename ICULocale to LocaleICU, part 2
https://bugs.webkit.org/show_bug.cgi?id=85695

Reviewed by Kentaro Hara.

Source/WebCore:

No behavior change

* platform/text/LocaleICU.cpp: Rename ICULocale to LocaleICU.
* platform/text/LocaleICU.h: ditto.
Also, update obsolete comments.
* platform/text/LocalizedDateICU.cpp: Rename ICULocale to LocaleICU.
(WebCore::parseLocalizedDate):
(WebCore::formatLocalizedDate):
(WebCore::localizedDateFormatText):
(WebCore::monthLabels):
(WebCore::weekDayShortLabels):
(WebCore::firstDayOfWeek):
* platform/text/LocalizedNumberICU.cpp: ditto.
(WebCore::convertToLocalizedNumber):
(WebCore::convertFromLocalizedNumber):

Source/WebKit/chromium:

* tests/LocalizedNumberICUTest.cpp:
(testNumberIsReversible): Rename ICULocale to LocaleICU.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Allow WebMediaPlayerClientImpl to switch clients
enne@google.com [Sun, 6 May 2012 22:06:47 +0000 (22:06 +0000)]
[chromium] Allow WebMediaPlayerClientImpl to switch clients
https://bugs.webkit.org/show_bug.cgi?id=85093

Reviewed by James Robinson.

WebVideoFrameProviderClient has a 1:1 relationship with a
WebVideoFrameProvider. The client here is CCVideoLayerImpl and the
provider is WebMediaPlayerClientImpl.  If the provider gets a new
client, then the old client needs to be informed to stop using the
provider.

If this doesn't happen, then the old client will have an unsafe
pointer to the provider, will not get informed if the provider gets
deleted, and the client will crash when it dereferences the provider
pointer trying to tell the provider that its client is going away.

Test: WebMediaPlayerClientImplTest.InitialNullVideoClient
      WebMediaPlayerClientImplTest.SetAndUnsetVideoClient
      WebMediaPlayerClientImplTest.DestroyProvider
      WebMediaPlayerClientImplTest.SetMultipleVideoClients

* WebKit.gypi:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
* tests/WebMediaPlayerClientImplTest.cpp: Added.
(WebKit):
(FakeWebMediaPlayerClientImpl):
(WebKit::FakeWebMediaPlayerClientImpl::create):
(WebKit::FakeWebMediaPlayerClientImpl::FakeWebMediaPlayerClientImpl):
(FakeVideoFrameProviderClient):
(WebKit::FakeVideoFrameProviderClient::create):
(WebKit::FakeVideoFrameProviderClient::~FakeVideoFrameProviderClient):
(WebKit::FakeVideoFrameProviderClient::didReceiveFrame):
(WebKit::FakeVideoFrameProviderClient::didUpdateMatrix):
(WebKit::FakeVideoFrameProviderClient::stopUsingProvider):
(WebKit::FakeVideoFrameProviderClient::provider):
(WebKit::FakeVideoFrameProviderClient::FakeVideoFrameProviderClient):
(WebKit::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Enable credential persistance and auto fill
commit-queue@webkit.org [Sun, 6 May 2012 22:05:38 +0000 (22:05 +0000)]
[BlackBerry] Enable credential persistance and auto fill
https://bugs.webkit.org/show_bug.cgi?id=85572

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-05-06
Reviewed by Rob Buis.

.:

Enable credential persistance and auto fill feature by adding
ENABLE_BLACKBERRY_CREDENTIAL_PERSIST=1.

* Source/cmake/OptionsBlackBerry.cmake:

Source/WebKit/blackberry:

Set autofilled status of credential input fields when credential
information is auto filled by CredentialManager.
By doing this the input element will get painted with yellow background
which can notify user this input field is auto filled by the browser.

No behavior changes, so no new test.

* WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::setCredential):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
abarth@webkit.org [Sun, 6 May 2012 21:19:04 +0000 (21:19 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-06

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[wx] Unreviewed. Build fixes for recent trunk changes.
kevino@webkit.org [Sun, 6 May 2012 20:20:28 +0000 (20:20 +0000)]
[wx] Unreviewed. Build fixes for recent trunk changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: take timeline frame mode out of experimental
caseq@chromium.org [Sun, 6 May 2012 14:54:10 +0000 (14:54 +0000)]
Web Inspector: take timeline frame mode out of experimental
https://bugs.webkit.org/show_bug.cgi?id=85707

Reviewed by Pavel Feldman.

Source/WebCore:

- remove "Vertical timeline overview" experiment;
- add supportsFrameInstrumentation capability to InspectorTimelineAgent;
- show frame mode selector conditionally on supportsFrameInstrumentation capability.

* inspector/Inspector.json: Add Timeline.supportsFrameInstrumentation capability;
* inspector/InspectorClient.h: Add supportsFrameInstrumentation();
(InspectorClient):
(WebCore::InspectorClient::supportsFrameInstrumentation):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::supportsFrameInstrumentation):
(WebCore):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent): Added FrameInstrumentationSupport parameter.
* inspector/InspectorTimelineAgent.h:
(WebCore):
(WebCore::InspectorTimelineAgent::create): ditto.
(InspectorTimelineAgent):
* inspector/WorkerInspectorController.cpp: Updated call site for InspectorTimelineAgent::create() to indicate frame instrumentation not supported.
(WebCore::WorkerInspectorController::WorkerInspectorController):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings): Removed "Vertical Overview" experiment.
* inspector/front-end/TimelineOverviewPane.js: Expose frame mode conditionally on capability, not the experiment.
(WebInspector.TimelineOverviewPane):
* inspector/front-end/inspector.js: Added initialization for Capabilities.timelineSupportsFrameInstrumentation;
(WebInspector.doLoadedDone):

Source/WebKit/chromium:

- exposed supportFrameInstrumentation method to InspectorClient. Client must return true iff the platform will call
  InspectorInstrumentation::instrumentBeginFrame() upon beginning of frame rendering;

* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::supportsFrameInstrumentation):
(WebKit):
* src/InspectorClientImpl.h:
(InspectorClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix.
antti@apple.com [Sun, 6 May 2012 10:51:00 +0000 (10:51 +0000)]
Build fix.

Not reviewed.

* css/PropertySetCSSStyleDeclaration.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShare stylesheet data structures between documents
antti@apple.com [Sun, 6 May 2012 10:29:14 +0000 (10:29 +0000)]
Share stylesheet data structures between documents
https://bugs.webkit.org/show_bug.cgi?id=85598

Source/WebCore:

Reviewed by Darin Adler.

We currently make a copy of the data structures when restoring a cached stylesheet. This patch lets us share
the data until someone uses CSSOM to modify the sheet.

The patch implements copy-on-write for the internal style sheet data structures. If any mutation CSSOM API is
invoked, we check if the stylesheet can be safely mutated (we are the only client, it is not cached). If not
then the internal structures are copied and any existing CSSOM objects are re-attached to the new tree.

Sharing can save significant amount of memory on sites with large stylesheets. For example if you have
multiple articles open on wsj.com this saves ~2.6MB per tab.

Test: http/tests/css/shared-stylesheet-mutation.html
      http/tests/css/shared-stylesheet-mutation-preconstruct.html

* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::reattach):
(WebCore):
* css/CSSFontFaceRule.h:
(CSSFontFaceRule):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):
(WebCore::CSSMediaRule::reattach):
(WebCore):
* css/CSSMediaRule.h:
(CSSMediaRule):
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::setSelectorText):
(WebCore::CSSPageRule::reattach):
(WebCore):
* css/CSSPageRule.h:
(CSSPageRule):
* css/CSSRule.cpp:
(WebCore::CSSRule::reattach):

    After the internal stylerule tree has been copied, the existing wrappers are re-attached using recursive reattach() function.

* css/CSSRule.h:
(WebCore):
(CSSRule):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
(WebCore::CSSStyleRule::reattach):
(WebCore):
* css/CSSStyleRule.h:
(CSSStyleRule):
* css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::isCacheable):
(WebCore::StyleSheetInternal::ruleAt):

    Add ruleAt(), use it for both wrapper creation and reattaching.  Remove createChildRuleCSSOMWrapper .

(WebCore):
(WebCore::StyleSheetInternal::wrapperInsertRule):
(WebCore::StyleSheetInternal::wrapperDeleteRule):

    Invalidation moves to the calling wrapper.

(WebCore::StyleSheetInternal::addedToMemoryCache):
(WebCore::StyleSheetInternal::removedFromMemoryCache):
(WebCore::CSSStyleSheet::willMutateRules):

    This is called whenever StyleSheetInternal is going to be mutated. It will do copy-on-write if needed.

    Usually invoked by CSSStyleSheet::RuleMutation RAII type.

(WebCore::CSSStyleSheet::didMutateRules):

    This is called after the mutation is complete and will trigger the style recalc in the document.

(WebCore::CSSStyleSheet::didMutate):

    This is called directly after mutations that don't change StyleSheetInternal so don't require copy-on-write.

(WebCore::CSSStyleSheet::reattachChildRuleCSSOMWrappers):
(WebCore::CSSStyleSheet::setDisabled):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):
* css/CSSStyleSheet.h:
(StyleSheetInternal):
(WebCore::StyleSheetInternal::hasOneClient):
(WebCore::StyleSheetInternal::isMutable):
(WebCore::StyleSheetInternal::setMutable):

    Track mutability. Mutation is allowed only after willMutate call.

(WebCore::StyleSheetInternal::isInMemoryCache):

    Track if the object is in memory cache.

(WebCore::CSSStyleSheet::clearOwnerRule):
(CSSStyleSheet):
* css/MediaList.cpp:
(WebCore::MediaList::setMediaText):
(WebCore::MediaList::deleteMedium):
(WebCore::MediaList::appendMedium):
(WebCore::MediaList::didMutate):
(WebCore):
(WebCore::MediaList::reattach):
* css/MediaList.h:
(MediaList):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore):
(WebCore::StyleRuleCSSStyleDeclaration::willMutate):
(WebCore::StyleRuleCSSStyleDeclaration::didMutate):
(WebCore::StyleRuleCSSStyleDeclaration::reattach):
(WebCore::InlineCSSStyleDeclaration::didMutate):
* css/PropertySetCSSStyleDeclaration.h:
(WebCore::PropertySetCSSStyleDeclaration::willMutate):
(WebCore::PropertySetCSSStyleDeclaration::didMutate):
(StyleRuleCSSStyleDeclaration):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::setName):
(WebCore::WebKitCSSKeyframesRule::insertRule):
(WebCore::WebKitCSSKeyframesRule::deleteRule):
(WebCore::WebKitCSSKeyframesRule::reattach):
(WebCore):
* css/WebKitCSSKeyframesRule.h:
(WebKitCSSKeyframesRule):
* css/WebKitCSSRegionRule.cpp:
(WebCore::WebKitCSSRegionRule::reattach):
* css/WebKitCSSRegionRule.h:
(WebKitCSSRegionRule):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::reparseStyleSheet):
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::~CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):
(WebCore::CachedCSSStyleSheet::restoreParsedStyleSheet):

    Don't copy when restoring. It is no longer necessary.
    Set the cache bit on the stylesheet.

(WebCore::CachedCSSStyleSheet::saveParsedStyleSheet):

LayoutTests:

Reviewed by Darin Adler.

Test that mutations of a shared stylesheet work as expected.

This is an http test due to cross-document security restrictions with file urls
(they can be overriden in DRT but I'd like this to work in browser too).

* http/tests/css/resources/shared.css: Added.
* http/tests/css/resources/shared-stylesheet-mutation.js: Added.
* http/tests/css/shared-stylesheet-mutation-expected.txt: Added.
* http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt: Added.
* http/tests/css/shared-stylesheet-mutation-preconstruct.html: Added.
* http/tests/css/shared-stylesheet-mutation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the GTK+ TextureMapper accelerated compositing build.
mrobinson@webkit.org [Sun, 6 May 2012 07:17:48 +0000 (07:17 +0000)]
Fix the GTK+ TextureMapper accelerated compositing build.

* webkit/webkitwebview.cpp:
(webkit_web_view_realize): Properly access the private data
structure of the WebKitWebView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove TrustedImm32::m_isPointer
barraclough@apple.com [Sun, 6 May 2012 05:27:29 +0000 (05:27 +0000)]
Remove TrustedImm32::m_isPointer
https://bugs.webkit.org/show_bug.cgi?id=85726

Rubber stamped by Sam Weinig.

We used to rely on being able to generate code with known, fixed offsets – to do so we
would inhibit more optimal code generation for pointers. This is no longer necessary.

* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::TrustedImm32::TrustedImm32):
(TrustedImm32):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::move):
(JSC::MacroAssemblerARM::branch32):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::move):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::add32):
(JSC::MacroAssemblerMIPS::and32):
(JSC::MacroAssemblerMIPS::mul32):
(JSC::MacroAssemblerMIPS::or32):
(JSC::MacroAssemblerMIPS::sub32):
(JSC::MacroAssemblerMIPS::store32):
(JSC::MacroAssemblerMIPS::move):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116221.
commit-queue@webkit.org [Sat, 5 May 2012 23:04:13 +0000 (23:04 +0000)]
Unreviewed, rolling out r116221.
http://trac.webkit.org/changeset/116221
https://bugs.webkit.org/show_bug.cgi?id=85722

broke builds that use -Wshorten-64-to-32 (Requested by pizlo
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-05

Source/WebCore:

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::getVertexAttribOffset):
(WebCore::WebGLRenderingContext::vertexAttribPointer):
* html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):
* html/canvas/WebGLRenderingContext.idl:

LayoutTests:

* fast/canvas/webgl/index-validation-expected.txt:
* fast/canvas/webgl/index-validation.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] WebKit should properly set the input method context window location
kov@webkit.org [Sat, 5 May 2012 21:41:00 +0000 (21:41 +0000)]
[GTK] WebKit should properly set the input method context window location
https://bugs.webkit.org/show_bug.cgi?id=84981

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-05
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

* platform/gtk/GtkInputMethodFilter.cpp:
(WebCore::GtkInputMethodFilter::setCursorRect): Add this method to plumb the
cursor rect through to the input method.
* platform/gtk/GtkInputMethodFilter.h: Add the new method declaration.

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::paint): During painting, update the cursor rectangle
if possible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd new Setting/Preference to disable requestAnimationFrame
dino@apple.com [Sat, 5 May 2012 21:38:17 +0000 (21:38 +0000)]
Add new Setting/Preference to disable requestAnimationFrame
https://bugs.webkit.org/show_bug.cgi?id=85693

Reviewed by Simon Fraser.

Source/WebCore:

Hook up the new WebPreference for disabling requestAnimationFrame
to Settings. This isn't disabling the feature in the typical
WebKit ENABLE() way - it's still available in the DOM, it's
just that the animations will never be serviced. This allows a client
to disable the machinery without breaking content (other than the
animations).

The new test is currently skipped on all platforms because toggling
the preference interferes with the other tests that are running
at the same time (and expect a working requestAnimationFrame).
https://bugs.webkit.org/show_bug.cgi?id=85689

Test: fast/animation/request-animation-frame-disabled.html

* dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::windowScreenDidChange):
(WebCore::ScriptedAnimationController::scheduleAnimation):
Check the setting before deciding to act.
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setRequestAnimationFrameEnabled):
(WebCore::Settings::requestAnimationFrameEnabled):
(Settings):

Source/WebKit/mac:

Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled.
The default value is true. The majority of applications will leave
it this way.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences requestAnimationFrameEnabled]):
(-[WebPreferences setRequestAnimationFrameEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit/win:

Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled.
The default value is true. The majority of applications will leave
it this way.

* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::setRequestAnimationFrameEnabled):
(WebPreferences::requestAnimationFrameEnabled):
* WebPreferences.h:
(WebPreferences):
* WebView.cpp:
(WebView::notifyPreferencesChanged):

Source/WebKit2:

Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled.
The default value is true. The majority of applications will leave
it this way.

* Shared/WebPreferencesStore.h:
(WebKit):
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetRequestAnimationFrameEnabled):
(WKPreferencesGetRequestAnimationFrameEnabled):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

LayoutTests:

A new test that exercises turning the requestAnimationFrame
preference off. Unfortunately this conflicts with the parallel
tests that expect the preference to be on (as it should by default),
so the test is skipped on all platforms. It can be run in isolation.
https://bugs.webkit.org/show_bug.cgi?id=85689

* fast/animation/request-animation-frame-disabled-expected.txt: Added.
* fast/animation/request-animation-frame-disabled.html: Added.
* fast/animation/script-tests/request-animation-frame-disabled.js: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/Skipped:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
* platform/win/Skipped:
* platform/win/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT.
rakuco@webkit.org [Sat, 5 May 2012 21:08:25 +0000 (21:08 +0000)]
webkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT.
https://bugs.webkit.org/show_bug.cgi?id=85697

Reviewed by Eric Seidel.

* Scripts/new-run-webkit-tests: Instead of manually detecting whether
the path separator should be ':' or ';' by checking sys.platform, rely
on os.pathsep which has exactly the same information (os.pathsep is
':' for Cygwin, from what I could check in Python's sources).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed preparation for 1.9.2.
kov@webkit.org [Sat, 5 May 2012 21:00:14 +0000 (21:00 +0000)]
Unreviewed preparation for 1.9.2.

* configure.ac: bump version to 1.9.2 and bump libtool version.

Source/WebKit/gtk:

* NEWS: changes from 1.9.1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, make distcheck fix.
kov@webkit.org [Sat, 5 May 2012 20:59:45 +0000 (20:59 +0000)]
Unreviewed, make distcheck fix.

Source/WebCore:

* GNUmakefile.list.am: Add missing headers to the sources list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Incoming events may be processed out-of-order
jonlee@apple.com [Sat, 5 May 2012 19:38:46 +0000 (19:38 +0000)]
[WK2] Incoming events may be processed out-of-order
https://bugs.webkit.org/show_bug.cgi?id=85696
<rdar://problem/11386129>

Reviewed by Maciej Stachowiak.

All messages go to a single queue that gets iterated over by dispatchMessages(). If an input
event arrives in the middle of a flood of messages, all of them will be dispatched before the
input event is dispatched.

In other words, the first dispatchMessages() call will process all of the messages in the queue,
and all subsequent dispatchMessages() calls will act as no-ops, since there is nothing in the queue.

To fix this, we rename dispatchMessages to dispatchOneMessage, and only process one message at a
time.

* Platform/CoreIPC/Connection.h: Rename dispatchMessages() to dispatchOneMessage().
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::enqueueIncomingMessage): Dispatch a call to dispatchOneMessage() on the
run loop.
(CoreIPC::Connection::dispatchOneMessage): Remove the while(true) loop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: unreviewed followup fix for the performance test after r116218.
loislo@chromium.org [Sat, 5 May 2012 17:05:00 +0000 (17:05 +0000)]
Web Inspector: unreviewed followup fix for the performance test after r116218.

* inspector/heap-snapshot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116223.
rakuco@webkit.org [Sat, 5 May 2012 16:54:23 +0000 (16:54 +0000)]
Unreviewed, rolling out r116223.
http://trac.webkit.org/changeset/116223
https://bugs.webkit.org/show_bug.cgi?id=85718

The bots need to set XDG_DATA_DIRS (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-05

* efl/jhbuildrc:
* gtk/jhbuildrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[jhbuild] Do not set XDG_DATA_DIRS in jhbuildrc.
rakuco@webkit.org [Sat, 5 May 2012 16:34:24 +0000 (16:34 +0000)]
[jhbuild] Do not set XDG_DATA_DIRS in jhbuildrc.
https://bugs.webkit.org/show_bug.cgi?id=85717

Reviewed by Martin Robinson.

After r116209, the XDG_DATA_DIRS environment variable is now
passed by webkitpy's layout_tests code to run-with-jhbuild, so
instead of setting a few defaults in jhbuildrc we can now rely on
the values set and really used by each system.

* efl/jhbuildrc:
* gtk/jhbuildrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: convert standalone functions save/append/savedURL/appendedToURL into...
loislo@chromium.org [Sat, 5 May 2012 15:33:10 +0000 (15:33 +0000)]
Web Inspector: convert standalone functions save/append/savedURL/appendedToURL into WebInspector.FileManager object.
https://bugs.webkit.org/show_bug.cgi?id=85710

The idea is to have an object and be able to add/remove event listeners from it.

Reviewed by Yury Semikhatsky.

* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/FileManager.js: Copied from Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js.
(WebInspector.FileManager):
(WebInspector.FileManager.prototype.canSave):
(WebInspector.FileManager.prototype.canAppend):
(WebInspector.FileManager.prototype.append):
(WebInspector.FileManager.prototype.appendedToURL):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapProfileHeader.prototype.canSave):
(WebInspector.HeapProfileHeader.prototype.save):
* inspector/front-end/InspectorFrontendHostStub.js:
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agovertexAttribPointer needs to reject large negative offsets
zmo@google.com [Sat, 5 May 2012 14:51:39 +0000 (14:51 +0000)]
vertexAttribPointer needs to reject large negative offsets
https://bugs.webkit.org/show_bug.cgi?id=85117

Reviewed by Kenneth Russell.

Source/WebCore:

* html/canvas/WebGLRenderingContext.cpp: Use long long for GLsizeiptr and GLintptr
(WebCore):
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::getVertexAttribOffset):
(WebCore::WebGLRenderingContext::vertexAttribPointer):
* html/canvas/WebGLRenderingContext.h: Ditto
(WebGLRenderingContext):
* html/canvas/WebGLRenderingContext.idl: Ditto

LayoutTests:

* fast/canvas/webgl/index-validation-expected.txt:
* fast/canvas/webgl/index-validation.html: Add a test case for large negative offset.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: add separate timeline overview item for the frame mode
caseq@chromium.org [Sat, 5 May 2012 12:24:28 +0000 (12:24 +0000)]
Web Inspector: add separate timeline overview item for the frame mode
https://bugs.webkit.org/show_bug.cgi?id=85706

- remove two-buttons horizontal/vertical mode switch from Timelines item of the timeline overview menu;
- rename "Timeline" into "Events";
- add "Frames" item;
- replace overview sidebar icons with smaller, monochrome ones.

* English.lproj/localizedStrings.js: Added "Frames" and "Events".
* inspector/front-end/Images/statusbarButtonGlyphs.png: Added icon for "Memory".
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showEvents):
(WebInspector.TimelineOverviewPane.prototype._showFrames):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype._setMode):
* inspector/front-end/timelinePanel.css:
(#timeline-overview-sidebar .sidebar-tree-item):
(#timeline-overview-sidebar .sidebar-tree-item .titles.no-subtitle):
(#timeline-overview-sidebar .icon):
(.timeline-overview-sidebar-events .icon):
(.timeline-overview-sidebar-frames .icon):
(.timeline-overview-sidebar-memory .icon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNot reviewed: follow up to r116216, fixing the inspector test.
pfeldman@chromium.org [Sat, 5 May 2012 10:25:09 +0000 (10:25 +0000)]
Not reviewed: follow up to r116216, fixing the inspector test.

* inspector/debugger/script-extract-outline.html:
* inspector/debugger/script-extract-outline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: save HeapSnapshot implementation.
loislo@chromium.org [Sat, 5 May 2012 10:23:21 +0000 (10:23 +0000)]
Web Inspector: save HeapSnapshot implementation.
https://bugs.webkit.org/show_bug.cgi?id=85595

HeapSnapshot specific implementation for loading was moved
from ProfilesPanel to HeapProfileHeader class.

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype.get profileWrapper):
(WebInspector.HeapSnapshotView.prototype.get baseProfileWrapper):
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.load.setProfileWait):
(WebInspector.HeapProfileHeader.prototype.load.done):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._saveStatusUpdate):
(WebInspector.HeapProfileHeader.prototype.pushJSONChunk):
(WebInspector.HeapProfileHeader.prototype.finishHeapSnapshot):
(WebInspector.HeapProfileHeader.prototype.canSave):
(WebInspector.HeapProfileHeader.prototype.save):
* inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.appendedToURL):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._registerProfileType):
(WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):
(WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
(WebInspector.ProfileSidebarTreeElement.prototype.set searchMatches):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):
* inspector/front-end/inspector.js:
(WebInspector.append):
(WebInspector.appendedToURL):

LayoutTests:

* inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: allow overriding the script mapping on the UI level
pfeldman@chromium.org [Sat, 5 May 2012 10:07:39 +0000 (10:07 +0000)]
Web Inspector: allow overriding the script mapping on the UI level
https://bugs.webkit.org/show_bug.cgi?id=85702

Reviewed by Yury Semikhatsky.

Source/WebCore:

This allows formatting update live locations all over the place automatically.

* inspector/front-end/Script.js:
(WebInspector.Script.prototype.rawLocationToUILocation):
(WebInspector.Script.Location):
(WebInspector.Script.Location.prototype.update):
(WebInspector.Script.Location.prototype.dispose):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.addLiveLocation):
(WebInspector.UISourceCode.prototype.removeLiveLocation):
(WebInspector.UISourceCode.prototype.updateLiveLocations):
(WebInspector.UISourceCode.prototype.overrideLocation):

LayoutTests:

* inspector/debugger/breakpoint-manager.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: simplify the JavaScriptOutline dialog interaction.
pfeldman@chromium.org [Sat, 5 May 2012 09:46:20 +0000 (09:46 +0000)]
Web Inspector: simplify the JavaScriptOutline dialog interaction.
https://bugs.webkit.org/show_bug.cgi?id=85701

Reviewed by Yury Semikhatsky.

Removed bidirectional dependency between scripts panel and outline dialog.

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.JavaScriptOutlineDialog):
(WebInspector.JavaScriptOutlineDialog.show):
(WebInspector.JavaScriptOutlineDialog.prototype.requestItems):
(WebInspector.JavaScriptOutlineDialog.prototype._didBuildOutlineChunk):
(WebInspector.JavaScriptOutlineDialog.prototype.selectItem):
* inspector/front-end/ScriptFormatterWorker.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.addToWatch):
(WebInspector.ScriptsPanel.prototype._showJavaScriptOutlineDialog):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Buildfix for --minimal build after r116107.
ossy@webkit.org [Sat, 5 May 2012 09:38:41 +0000 (09:38 +0000)]
[Qt] Buildfix for --minimal build after r116107.

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2012-05-05
Reviewed by Csaba Osztrogonác.

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Gtk gardening, mark fullscreen/non-ancestor-iframe.html as
zandobersek@gmail.com [Sat, 5 May 2012 07:46:53 +0000 (07:46 +0000)]
Unreviewed Gtk gardening, mark fullscreen/non-ancestor-iframe.html as
failing after it was added in r116165.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rebaseline fast/events/attribute-listener-deletion-crash.html (added...
caseq@chromium.org [Sat, 5 May 2012 07:43:26 +0000 (07:43 +0000)]
Unreviewed. Rebaseline fast/events/attribute-listener-deletion-crash.html (added in r116191).

* platform/chromium/fast/events/attribute-listener-deletion-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Gtk] GtkDriver is not required anymore after r116134
zandobersek@gmail.com [Sat, 5 May 2012 07:34:50 +0000 (07:34 +0000)]
[Gtk] GtkDriver is not required anymore after r116134
https://bugs.webkit.org/show_bug.cgi?id=85699

Reviewed by Csaba Osztrogonác.

Remove GtkDriver as it was replaced by the XvfbDriver and is
no longer needed.

* Scripts/webkitpy/layout_tests/port/gtk.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIncrease the display ID for the Xvfb process to use if pixel_tests argument
zandobersek@gmail.com [Sat, 5 May 2012 07:25:08 +0000 (07:25 +0000)]
Increase the display ID for the Xvfb process to use if pixel_tests argument
is true rather than if pixel_tests option is present. This fixes the
XvfbDriver in the same way r115825 fixed the now-redundant GtkDriver.

Rubber-stamped by Csaba Osztrogonác.

* Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver._start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: annotate ProfilerAgent.
loislo@chromium.org [Sat, 5 May 2012 06:52:38 +0000 (06:52 +0000)]
Web Inspector: annotate ProfilerAgent.
https://bugs.webkit.org/show_bug.cgi?id=85630

Reviewed by Pavel Feldman.

* inspector/Inspector.json:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::createProfileHeader):
(WebCore::InspectorProfilerAgent::createSnapshotHeader):
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::getProfile):
* inspector/InspectorProfilerAgent.h:
(InspectorProfilerAgent):
* inspector/front-end/CSSSelectorProfileView.js:
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotProfileType.prototype.createProfile):
* inspector/front-end/ProfileView.js:
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
(WebInspector.ProfilerDispatcher.prototype.resetProfiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: Preserve XDG_DATA_DIRS in the environment passed to ServerProcess.
rakuco@webkit.org [Sat, 5 May 2012 05:48:07 +0000 (05:48 +0000)]
webkitpy: Preserve XDG_DATA_DIRS in the environment passed to ServerProcess.
https://bugs.webkit.org/show_bug.cgi?id=85694

Reviewed by Martin Robinson.

This is sort of a follow-up to r100674: $XDG_DATA_DIRS should be
preserved, as it is particularly useful for Linux/Unix
environments.  As a real use case, if shared-mime-info is
installed into a non-trivial prefix, Glib and other libraries will
have trouble to properly identify mimetypes (in ResourceResponses,
for example) as the base freedesktop.org mimetype file will not be
found.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.to.setup_environ_for_server):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening, unskip test after r116097.
rakuco@webkit.org [Sat, 5 May 2012 04:26:50 +0000 (04:26 +0000)]
[EFL] Gardening, unskip test after r116097.

The test was unskipped from Skipped, but some other commit added it to
test_expectations.txt as well...

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening; skip tests that depend on beginDragWithFiles.
rakuco@webkit.org [Sat, 5 May 2012 04:26:22 +0000 (04:26 +0000)]
[EFL] Gardening; skip tests that depend on beginDragWithFiles.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed, rebaseline after r116009.
rakuco@webkit.org [Sat, 5 May 2012 03:56:43 +0000 (03:56 +0000)]
[EFL] Unreviewed, rebaseline after r116009.

* platform/efl/fast/block/float/float-not-removed-from-next-sibling4-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Simplify how libWebCoreModules is linked in, and fix WebKit2 build
kov@webkit.org [Sat, 5 May 2012 03:35:51 +0000 (03:35 +0000)]
[GTK] Simplify how libWebCoreModules is linked in, and fix WebKit2 build
https://bugs.webkit.org/show_bug.cgi?id=85691

Source/WebCore:

* GNUmakefile.am: link libWebCoreModules into libWebCore.

Source/WebKit/gtk:

* GNUmakefile.am: no longer link libwebkitgtk to libWebCoreModules.

Source/WebKit2:

* GNUmakefile.am: no longer link libWebCoreModules, and remove -no-
fast-install and -no-install from link flags, since we want those
programs installed.

Tools:

* GNUmakefile.am: no longer link libWebCoreModules to DumpRenderTree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116205 268f45cc-cd09-0410-ab3c-d52691b4dbfc