WebKit-https.git
9 years ago2010-08-16 Paul Sawaya <psawaya@apple.com>
cmarrin@apple.com [Mon, 16 Aug 2010 19:18:45 +0000 (19:18 +0000)]
2010-08-16  Paul Sawaya  <psawaya@apple.com>

        Reviewed by Chris Marrin.

        Added shader validation via ANGLE
        https://bugs.webkit.org/show_bug.cgi?id=42405

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix, do not build WebCore as a convenience library as this leads to
kevino@webkit.org [Mon, 16 Aug 2010 19:12:19 +0000 (19:12 +0000)]
[wx] Build fix, do not build WebCore as a convenience library as this leads to
errors in the Win build w/export symbols and causes problems with DOM bindings
debugging in gdb.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Mihai Parparita <mihaip@chromium.org>
commit-queue@webkit.org [Mon, 16 Aug 2010 19:00:33 +0000 (19:00 +0000)]
2010-08-16  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Nate Chapin.

        Some http/tests/history tests now pass on Chromium after r65340
        https://bugs.webkit.org/show_bug.cgi?id=44033

        Remove expected failures.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 16 Aug 2010 18:24:17 +0000 (18:24 +0000)]
2010-08-16  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Adam Roben.

        Current implementation of WebCore post-build step on windows platform is error prone.
        It would be better to extract the script into external file.
        https://bugs.webkit.org/show_bug.cgi?id=44058

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/copyForwardingHeaders.cmd: Added.
        * WebCore.vcproj/copyInspectorFiles.cmd: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Fix typo in previous build fix.
kevino@webkit.org [Mon, 16 Aug 2010 18:09:06 +0000 (18:09 +0000)]
[wx] Fix typo in previous build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Alex Milowski <alex@milowski.com>
commit-queue@webkit.org [Mon, 16 Aug 2010 18:04:40 +0000 (18:04 +0000)]
2010-08-16  Alex Milowski  <alex@milowski.com>

        Reviewed by David Levin.

        Added the configuration of the MathML related files.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
2010-08-16  Alex Milowski  <alex@milowski.com>

        Reviewed by David Levin.

        Added the ENABLE_MATHML=1 to the feature_defines.

        * features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 16 Aug 2010 17:39:48 +0000 (17:39 +0000)]
2010-08-16  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: fix Leopard Release inspector tests.

        * inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Mon, 16 Aug 2010 17:30:58 +0000 (17:30 +0000)]
2010-08-16  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Implements IDBKeyPath extractor.
        https://bugs.webkit.org/show_bug.cgi?id=43276

        Unit-test IDBKeyPathExtractorTest.cpp.
        LayoutTests will arrive as IndexedDB infrastructure is fleshed out.

        * bindings/v8/IDBBindingUtilities.cpp:
        (WebCore::getValueFrom):
        (WebCore::createIDBKeyFromSerializedValueAndKeyPath):
        * bindings/v8/IDBBindingUtilities.h:
2010-08-16  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Implements IDBKeyPath extractor.
        https://bugs.webkit.org/show_bug.cgi?id=43276

        Unit-test IDBKeyPathExtractorTest.cpp.
        LayoutTests will arrive as IndexedDB infrastructure is fleshed out.

        * WebKit.gyp:
        * public/WebIDBKey.h:
        * public/WebIDBKeyPath.h: Added.
        (WebKit::WebIDBKeyPath::WebIDBKeyPath):
        (WebKit::WebIDBKeyPath::~WebIDBKeyPath):
        * public/WebPrivateOwnPtr.h: Added.
        (WebKit::WebPrivateOwnPtr::WebPrivateOwnPtr):
        (WebKit::WebPrivateOwnPtr::~WebPrivateOwnPtr):
        (WebKit::WebPrivateOwnPtr::reset):
        (WebKit::WebPrivateOwnPtr::get):
        (WebKit::WebPrivateOwnPtr::operator->):
        * src/WebIDBKey.cpp:
        (WebKit::WebIDBKey::createFromValueAndKeyPath):
        * src/WebIDBKeyPath.cpp: Added.
        (WebKit::WebIDBKeyPath::create):
        (WebKit::WebIDBKeyPath::WebIDBKeyPath):
        (WebKit::WebIDBKeyPath::parseError):
        (WebKit::WebIDBKeyPath::assign):
        (WebKit::WebIDBKeyPath::reset):
        (WebKit::WebIDBKeyPath::operator const WTF::Vector<WebCore::IDBKeyPathElement, 0>&):
        * tests/IDBBindingUtilitiesTest.cpp: Added.
        (WebCore::LocalContext::LocalContext):
        (WebCore::LocalContext::~LocalContext):
        (WebCore::checkKeyFromValueAndKeyPathInternal):
        (WebCore::checkKeyPathNullValue):
        (WebCore::checkKeyPathStringValue):
        (WebCore::checkKeyPathNumberValue):
        (WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 16 Aug 2010 17:10:38 +0000 (17:10 +0000)]
2010-08-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Kenneth Rohde Christiansen and Martin Robinson.

        [GTK] GTK+ drawing idle starved
        https://bugs.webkit.org/show_bug.cgi?id=43994

        Tune down the priority of the shared timers to guarantee GTK+ has
        an opportunity to redraw.

        * platform/gtk/SharedTimerGtk.cpp:
        (WebCore::setSharedTimerFireTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Leandro Pereira <leandro@profusion.mobi>
leandro@webkit.org [Mon, 16 Aug 2010 16:44:46 +0000 (16:44 +0000)]
2010-08-16  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Build fix after r65366.

        * CMakeLists.txt: Use if (VAR) instead of if (${VAR}) to check if
        they're empty.
        * jsc/CMakeLists.txt: Ditto.
        * wtf/CMakeLists.txt: Ditto.
2010-08-16  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Build fix after r65366.

        * CMakeLists.txt: Use if (VAR) instead of if (${VAR}) to check if
        they're empty.
2010-08-16  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Build fix after r65366.

        EFL port does not support automated tests yet.

        * CMakeLists.txt: Use if (VAR) instead of if (${VAR}) to check if
        they're empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix.
steveblock@google.com [Mon, 16 Aug 2010 16:40:36 +0000 (16:40 +0000)]
Unreviewed build fix.

Add fast/dom/Geolocation/disconnected-frame-permission-denied.html to failing tests for Chromium
https://bugs.webkit.org/show_bug.cgi?id=44059

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
mitz@apple.com [Mon, 16 Aug 2010 16:35:55 +0000 (16:35 +0000)]
Build fix.

* WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage): Initialize the contentsSizeChanged member.
(WTR::TestController::initialize): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 16 Aug 2010 16:33:36 +0000 (16:33 +0000)]
2010-08-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Make InjectedScript proto-based.
        https://bugs.webkit.org/show_bug.cgi?id=44028

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):
        (injectedScriptConstructor.):

2010-08-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Make InjectedScript proto-based.
        https://bugs.webkit.org/show_bug.cgi?id=44028
        Drive-by test fix.

        * http/tests/inspector-enabled/console-log-before-frame-navigation.html:
        * http/tests/inspector-enabled/resources/console-log-before-frame-navigation.js: Removed.
        * http/tests/inspector-enabled/resources/console-log-frame-before-navigation.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowxMSW build fix. Don't build the Python DOM bindings until we get the export issues
kevino@webkit.org [Mon, 16 Aug 2010 16:31:03 +0000 (16:31 +0000)]
wxMSW build fix. Don't build the Python DOM bindings until we get the export issues
sorted out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix warning in WebCore/plugins/win/PluginPackageWin.cpp
ossy@webkit.org [Mon, 16 Aug 2010 16:29:59 +0000 (16:29 +0000)]
Fix warning in WebCore/plugins/win/PluginPackageWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=43920

Reviewed by Adam Roben.

* plugins/win/PluginPackageWin.cpp:
(WebCore::PluginPackage::fetchInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Mon, 16 Aug 2010 16:19:54 +0000 (16:19 +0000)]
Unreviewed.

[Qt] fast/dom/Geolocation/disconnected-frame-permission-denied.html fails
https://bugs.webkit.org/show_bug.cgi?id=44059

* platform/qt/Skipped: fast/dom/Geolocation/disconnected-frame-permission-denied.html skipped until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 16 Aug 2010 16:15:02 +0000 (16:15 +0000)]
2010-08-16  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Touch inspector file to force frontend deployment.

        * inspector/InspectorController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix for non-Win ports on Windows.
kevino@webkit.org [Mon, 16 Aug 2010 16:06:10 +0000 (16:06 +0000)]
[wx] Build fix for non-Win ports on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Adam Langley <agl@chromium.org>
agl@chromium.org [Mon, 16 Aug 2010 15:16:46 +0000 (15:16 +0000)]
2010-08-16  Adam Langley  <agl@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Improve spacing support for complex text on Linux

        https://bugs.webkit.org/show_bug.cgi?id=39014

        Previously, our complex text support ignored word-spacing,
        justification and letter-spacing. This fixes the first two issues and
        allows us to render Scribd's HTML5 documents much better.

        Test: fast/text/atsui-spacing-features.html

        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::TextRunWalker::TextRunWalker):
        (WebCore::TextRunWalker::setWordSpacingAdjustment):
        (WebCore::TextRunWalker::setLetterSpacingAdjustment):
        (WebCore::TextRunWalker::setPadding):
        (WebCore::TextRunWalker::setGlyphXPositions):
        (WebCore::TextRunWalker::isCodepointSpace):
        (WebCore::Font::drawComplexText):
        (WebCore::Font::floatWidthForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix warnings: unknown conversion type character 'l' in format
ossy@webkit.org [Mon, 16 Aug 2010 15:14:14 +0000 (15:14 +0000)]
Fix warnings: unknown conversion type character 'l' in format
https://bugs.webkit.org/show_bug.cgi?id=43359

Reviewed by Kenneth Rohde Christiansen.

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::performURLImport): Replace %zu with %lu, because Windows doesn't understand z modifier.
(WebCore::IconDatabase::pruneUnretainedIcons): Use %I64i intsead of %lli on Windows.
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
(WebCore::MediaPlayerPrivate::totalTimeChanged): Use %I64d intsead of %lld on Windows.
* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::setMaximumSize): Use %I64i intsead of %lli on Windows.
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::setQuota): Use %I64u intsead of %llu on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix warnings: unknown conversion type character 'l' in format
ossy@webkit.org [Mon, 16 Aug 2010 15:02:45 +0000 (15:02 +0000)]
Fix warnings: unknown conversion type character 'l' in format
https://bugs.webkit.org/show_bug.cgi?id=43359

Reviewed by Kenneth Rohde Christiansen.

* loader/FTPDirectoryParser.cpp: Use %I64u format specifier instead of %llu on Windows.
(WebCore::parseOneFTPLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Shadow blur for rectangle fill
ariya@webkit.org [Mon, 16 Aug 2010 14:32:25 +0000 (14:32 +0000)]
[Qt] Shadow blur for rectangle fill
https://bugs.webkit.org/show_bug.cgi?id=44025

Patch by Ariya Hidayat <ariya@sencha.com> on 2010-08-16
Reviewed by Kenneth Rohde Christiansen.

WebCore:

The blur implementation follows the approximation of Gaussian blur
with three successive box blurs, working on the alpha channel only.
(see http://www.w3.org/TR/SVG/filters.html#feGaussianBlur).

* WebCore.pro: Refer to ContexShadow.* files.
* platform/graphics/qt/ContextShadow.cpp: Added.
(WebCore::ContextShadow::ContextShadow):
(WebCore::ContextShadow::clear):
(WebCore::blurHorizontal): Box blurs in horizontal direction, working
on QImage (in-place).
(WebCore::shadowBlur): Main blur function which just calls the
above blurHorizontal function twice, once with transposed image
(equivalent as it would have done vertical box blurs).
(WebCore::ContextShadow::drawShadowRect):
* platform/graphics/qt/ContextShadow.h: Added.
(WebCore::ContextShadow::):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContextPlatformPrivate::hasShadow):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::fillRect): Use ContextShadow for the shadow.
(WebCore::GraphicsContext::setPlatformShadow):

LayoutTests:

Update pixel test reference after the blur support.

* platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
* platform/qt/fast/box-shadow/basic-shadows-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Mon, 16 Aug 2010 14:09:36 +0000 (14:09 +0000)]
2010-08-16  Andras Becsi  <abecsi@webkit.org>

        Rubber-stamped by Gustavo Noronha Silva.

        [GTK] Build fix for MathML code generation.

        No new tests needed.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Mon, 16 Aug 2010 13:58:16 +0000 (13:58 +0000)]
2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65414.
        http://trac.webkit.org/changeset/65414
        https://bugs.webkit.org/show_bug.cgi?id=44055

        GTL & QT tests failing. (Requested by pfeldman on #webkit).

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):
        (injectedScriptConstructor.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Balazs Kelemen <kb@inf.u-szeged.hu>
abecsi@webkit.org [Mon, 16 Aug 2010 13:39:56 +0000 (13:39 +0000)]
2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Kenneth Rohde Christiansen.

        Handle content size change in WebKit2
        Re-landing after fix.

        https://bugs.webkit.org/show_bug.cgi?id=43198

        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
        * MiniBrowser/win/BrowserView.cpp:
        (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Kenneth Rohde Christiansen.

        Handle content size change in WebKit2
        Re-landing after fix.

        https://bugs.webkit.org/show_bug.cgi?id=43198

        Based on the work of Antti Koivisto.
        Send message to the UI client when the contents size has changed through the WebChromeClient
        and propagate it to the WKPageUIClient.

        * Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
        (WebPageProxyMessage::): Added ContentsSizeChanged message kind.
        * UIProcess/API/C/WKPage.h: Added WKPageContentsSizeChangedCallback callback to the WKPageUIClient.
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::QWKPage): Initialize the new callback to 0.
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didReceiveMessage): Handle ContentsSizeChanged message. Calls contetsSizeChanged.
        (WebKit::WebPageProxy::contentsSizeChanged): Added. Propagate the event to the the UI client.
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebUIClient.cpp:
        (WebKit::WebUIClient::contentsSizeChanged): Added. Propagate the event forward to the WKPageUIClient.
        * UIProcess/WebUIClient.h:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::contentsSizeChanged): Implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Mon, 16 Aug 2010 13:28:06 +0000 (13:28 +0000)]
2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65419.
        http://trac.webkit.org/changeset/65419
        https://bugs.webkit.org/show_bug.cgi?id=44053

        Broke the Windows build (Requested by bbandix on #webkit).

        * Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
        (WebPageProxyMessage::):
        * UIProcess/API/C/WKPage.h:
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::QWKPage):
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didReceiveMessage):
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebUIClient.cpp:
        * UIProcess/WebUIClient.h:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::contentsSizeChanged):
2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65419.
        http://trac.webkit.org/changeset/65419
        https://bugs.webkit.org/show_bug.cgi?id=44053

        Broke the Windows build (Requested by bbandix on #webkit).

        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController awakeFromNib]):
        * MiniBrowser/win/BrowserView.cpp:
        (BrowserView::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Mon, 16 Aug 2010 12:58:48 +0000 (12:58 +0000)]
2010-08-16  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Antonio Gomes.

        [Qt] Save and restore shadow state in GraphicsContextQt
        https://bugs.webkit.org/show_bug.cgi?id=44031

        This is needed after r65362.
        Use a new class ContextShadowParameter to track and keep the shadow
        state. We use this rather than using GraphicsContextState to allow
        possible optimizations (right now only to determine the shadow type,
        but in future it might cover things like cached scratch image,
        persistent shader, etc).

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::ContextShadowParameter::):
        (WebCore::ContextShadowParameter::ContextShadowParameter):
        (WebCore::ContextShadowParameter::clear):
        (WebCore::GraphicsContextPlatformPrivate::hasShadow):
        (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
        (WebCore::GraphicsContext::savePlatformState):
        (WebCore::GraphicsContext::restorePlatformState):
        (WebCore::GraphicsContext::drawRect):
        (WebCore::GraphicsContext::drawLine):
        (WebCore::GraphicsContext::strokeArc):
        (WebCore::GraphicsContext::drawConvexPolygon):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::setPlatformShadow):
        (WebCore::GraphicsContext::clearPlatformShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Balazs Kelemen <kb@inf.u-szeged.hu>
abecsi@webkit.org [Mon, 16 Aug 2010 12:52:20 +0000 (12:52 +0000)]
2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Kenneth Rohde Christiansen.

        Handle content size change in WebKit2

        https://bugs.webkit.org/show_bug.cgi?id=43198

        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
        * MiniBrowser/win/BrowserView.cpp:
        (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Kenneth Rohde Christiansen.

        Handle content size change in WebKit2

        https://bugs.webkit.org/show_bug.cgi?id=43198

        Based on the work of Antti Koivisto.
        Send message to the UI client when the contents size has changed through the WebChromeClient
        and propagate it to the WKPageUIClient.

        * Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
        (WebPageProxyMessage::): Added ContentsSizeChanged message kind.
        * UIProcess/API/C/WKPage.h: Added WKPageContentsSizeChangedCallback callback to the WKPageUIClient.
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::QWKPage): Initialize the new callback to 0.
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didReceiveMessage): Handle ContentsSizeChanged message. Calls contetsSizeChanged.
        (WebKit::WebPageProxy::contentsSizeChanged): Added. Propagate the event to the the UI client.
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebUIClient.cpp:
        (WebKit::WebUIClient::contentsSizeChanged): Added. Propagate the event forward to the WKPageUIClient.
        * UIProcess/WebUIClient.h:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::contentsSizeChanged): Implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd my new email address to committers.py.
ariya@webkit.org [Mon, 16 Aug 2010 12:44:58 +0000 (12:44 +0000)]
Add my new email address to committers.py.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-28 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Mon, 16 Aug 2010 12:43:54 +0000 (12:43 +0000)]
2010-07-28  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Adam Barth.

        Implement IDBKeyPath parser.
        https://bugs.webkit.org/show_bug.cgi?id=42976

        IDBKeyPath is an internal class, exposed only for unit tests for now.
        It'll allow indexed database implementation to traverse a given key path and obtain the corresponding properties
        from a SerializedScriptValue.

        * WebCore.gypi:
        * storage/IDBKeyPath.cpp: Added.
        (WebCore::IDBKeyPath::create):
        (WebCore::IDBKeyPath::IDBKeyPath):
        (WebCore::IDBKeyPath::~IDBKeyPath):
        (WebCore::IDBKeyPath::hasNext):
        (WebCore::IDBKeyPath::next):
        (WebCore::IDBKeyPath::identifier):
        (WebCore::IDBKeyPath::hasIndex):
        (WebCore::IDBKeyPath::indexValue):
        (WebCore::IDBKeyPath::parserError):
        (WebCore::IDBKeyPath::parse):
        (WebCore::IDBKeyPath::Lexer::lex):
        (WebCore::isSafeIdentifierStartCharacter):
        (WebCore::isSafeIdentifierCharacter):
        (WebCore::IDBKeyPath::Lexer::lexIdentifier):
        (WebCore::IDBKeyPath::Lexer::lexNumber):
        * storage/IDBKeyPath.h: Added.
        (WebCore::IDBKeyPath::Token::Token):
        (WebCore::IDBKeyPath::):
        (WebCore::IDBKeyPath::Lexer::Lexer):
        (WebCore::IDBKeyPath::Lexer::next):
        (WebCore::IDBKeyPath::Lexer::currentToken):
2010-07-28  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Adam Barth.

        Implement IDBKeyPath parser.
        https://bugs.webkit.org/show_bug.cgi?id=42976

        IDBKeyPath is an internal class, exposed only for unit tests for now.
        It'll allow indexed database implementation to traverse a given key path and obtain the corresponding properties
        from a SerializedScriptValue.

        * WebKit.gyp:
        * tests/IDBKeyPathTest.cpp: Added.
        (WebCore::ExpectedToken::ExpectedToken):
        (WebCore::checkKeyPath):
        (WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-13 Steve Block <steveblock@google.com>
steveblock@google.com [Mon, 16 Aug 2010 12:30:05 +0000 (12:30 +0000)]
2010-08-13  Steve Block  <steveblock@google.com>

        Reviewed by Alexey Proskuryakov.

        Geolocation requests in progress when the frame is disconnected should invoke the error callback
        https://bugs.webkit.org/show_bug.cgi?id=43974

        If requests are ongoing when the Frame is disconnected, we abort them with a fatal error.
        To do this, when Geolocation::disconnectFrame() is called we call cancelAllRequests() to
        set a fatal error on all ongoing requests. Once the requests have made their error
        callbacks, they are deleted. Note that we check at callback time that the script
        execution context for the callback is still valid, so it's safe to attempt these
        callbacks even after the Geolocation object's Frame has gone.

        This requires a change to allow multiple calls to GeoNotifier::setFatalError().
        For repeated calls, we do not replace the existing error. This ensures that when
        permission has been denied and the frame is then disconnected, the error callback
        reports the permission error, as required by the spec.

        Tests: fast/dom/Geolocation/disconnected-frame.html
               fast/dom/Geolocation/disconnected-frame-permission-denied.html

        * page/Geolocation.cpp:
        (WebCore::Geolocation::GeoNotifier::setFatalError):
        (WebCore::Geolocation::disconnectFrame):
        (WebCore::Geolocation::startRequest):
        (WebCore::Geolocation::cancelAllRequests):
        * page/Geolocation.h:
2010-08-13  Steve Block  <steveblock@google.com>

        Reviewed by Alexey Proskuryakov.

        Geolocation requests in progress when the frame is disconnected should invoke the error callback
        https://bugs.webkit.org/show_bug.cgi?id=43974

        Added new tests to GTK skipped list.

        * fast/dom/Geolocation/disconnected-frame.html: Added.
        * fast/dom/Geolocation/disconnected-frame-expected.txt: Added.
        * fast/dom/Geolocation/script-tests/disconnected-frame.js: Added.
        * fast/dom/Geolocation/resources/disconnected-frame-inner.html: Added.
        * fast/dom/Geolocation/disconnected-frame-permission-denied.html: Added.
        * fast/dom/Geolocation/disconnected-frame-permission-denied-expected.txt: Added.
        * fast/dom/Geolocation/script-tests/disconnected-frame-permission-denied.js: Added.
        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 16 Aug 2010 12:23:47 +0000 (12:23 +0000)]
2010-08-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: upstream frontend-side WebSocket transport.
        https://bugs.webkit.org/show_bug.cgi?id=43970

        Chromium already has an alternate WebSocket-based communication channel with
        the backend. Upstreaming it in this change. We will agree on the URI
        of the remote service as the protocol matures.

        * inspector/front-end/inspector.js:
        (.WebInspector.socket.onmessage):
        (.WebInspector.socket.onerror):
        (.WebInspector.socket.onopen):
        (WebInspector.loaded):
        (WebInspector.doLoadedDone):
        (WebInspector_syncDispatch):
2010-08-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: upstream frontend-side WebSocket transport.
        https://bugs.webkit.org/show_bug.cgi?id=43970

        Chromium already has an alternate WebSocket-based communication channel with
        the backend. Upstreaming it in this change. We will agree on the URI
        of the remote service as the protocol matures.

        * src/WebDevToolsFrontendImpl.cpp:
        (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
        * src/js/DevTools.js:
        (WebInspector.loaded):
        (devtools.domContentLoaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 16 Aug 2010 12:19:22 +0000 (12:19 +0000)]
2010-08-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Make InjectedScript proto-based.
        https://bugs.webkit.org/show_bug.cgi?id=44028

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):
        (injectedScriptConstructor.):
        * inspector/front-end/inspector.js:
        (WebInspector.loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 16 Aug 2010 12:16:59 +0000 (12:16 +0000)]
2010-08-16  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove utility context related code from debugger agent
        https://bugs.webkit.org/show_bug.cgi?id=44049

        * src/DebuggerAgentManager.cpp:
        (WebKit::DebuggerAgentManager::onV8DebugMessage):
        (WebKit::DebuggerAgentManager::pauseScript):
        * src/DebuggerAgentManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 16 Aug 2010 12:16:15 +0000 (12:16 +0000)]
2010-08-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: [REGRESSION] console's clear command does not work.
        https://bugs.webkit.org/show_bug.cgi?id=44027

        * inspector/console-clear.html:
        * inspector/console-command-clear-expected.txt: Added.
        * inspector/console-command-clear.html: Copied from LayoutTests/inspector/console-clear.html.
2010-08-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: [REGRESSION] console's clear command does not work.
        https://bugs.webkit.org/show_bug.cgi?id=44027

        Test: inspector/console-command-clear.html

        * inspector/Inspector.idl:
        * inspector/InspectorBackend.cpp:
        * inspector/InspectorBackend.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::clearConsoleMessages):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.requestClearMessages):
        * inspector/front-end/inspector.js:
        (WebInspector.consoleMessagesCleared):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Yuta Kitamura <yutak@chromium.org>
hamaji@chromium.org [Mon, 16 Aug 2010 11:57:17 +0000 (11:57 +0000)]
2010-08-16  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Attempt to fix Chromium's test_shell_tests.

        Port Chromium's WebEntities to HTMLEntityTable
        https://bugs.webkit.org/show_bug.cgi?id=44036

        * src/WebEntities.cpp:
        (WebKit::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Mon, 16 Aug 2010 11:26:18 +0000 (11:26 +0000)]
2010-08-16  Jeremy Orlow  <jorlow@chromium.org>

        Ugh, the #if ENABLE() was supposed to be added to Settings not GroupSettings.

        * page/GroupSettings.cpp:
        (WebCore::GroupSettings::GroupSettings):
        (WebCore::GroupSettings::setLocalStorageQuotaBytes):
        * page/GroupSettings.h:
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Mon, 16 Aug 2010 11:09:49 +0000 (11:09 +0000)]
2010-08-16  Jeremy Orlow  <jorlow@chromium.org>

        Last build fix?

        * page/PageGroup.cpp:
        (WebCore::PageGroup::PageGroup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Mon, 16 Aug 2010 10:53:12 +0000 (10:53 +0000)]
2010-08-16  Jeremy Orlow  <jorlow@chromium.org>

        Ugh...another build fix.

        * page/GroupSettings.cpp:
        (WebCore::GroupSettings::GroupSettings):
        * page/GroupSettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Mon, 16 Aug 2010 10:40:59 +0000 (10:40 +0000)]
2010-08-16  Jeremy Orlow  <jorlow@chromium.org>

        Build fix.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Mon, 16 Aug 2010 10:20:50 +0000 (10:20 +0000)]
2010-08-16  Jeremy Orlow  <jorlow@chromium.org>

        Build fix.

        * page/PageGroup.cpp:
        (WebCore::PageGroup::localStorage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-13 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Mon, 16 Aug 2010 10:02:45 +0000 (10:02 +0000)]
2010-08-13  Jeremy Orlow  <jorlow@chromium.org>

        Some settings are linked to the PageGroup not the Page.  Create a new class for those.
        https://bugs.webkit.org/show_bug.cgi?id=43794

        Since persistient storage is shared between pages, there's no way to modify
        some settings related to it on a per page basis.  As such, it's not technically
        correct for these settings to be on the Page's settings.  Create a new class
        called GroupSettings, move  group-wide local storage setting there (the other we
        can't), and add a new setting for IndexedDB's path (which is prompting this change).

        No behavior has changed, so no tests.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/GroupSettings.cpp: Added.
        (WebCore::GroupSettings::GroupSettings):
        (WebCore::GroupSettings::setLocalStorageQuotaBytes):
        (WebCore::GroupSettings::setLocalStorageDatabasePath):
        (WebCore::GroupSettings::setIndexedDBDatabasePath):
        * page/GroupSettings.h: Added.
        (WebCore::GroupSettings::create):
        (WebCore::GroupSettings::localStorageQuotaBytes):
        (WebCore::GroupSettings::localStorageDatabasePath):
        (WebCore::GroupSettings::indexedDBDatabasePath):
        * page/PageGroup.cpp:
        (WebCore::PageGroup::PageGroup):
        (WebCore::PageGroup::localStorage):
        * page/PageGroup.h:
        (WebCore::PageGroup::groupSettings):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setSessionStorageQuota):
        * page/Settings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 16 Aug 2010 09:44:46 +0000 (09:44 +0000)]
2010-08-16  MORITA Hajime  <morrita@google.com>

        Unreviewed; test expectations fix for Chromium.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Qt WebKit2 build fix.
zoltan@webkit.org [Mon, 16 Aug 2010 09:21:00 +0000 (09:21 +0000)]
Unreviewed Qt WebKit2 build fix.

Patch by Balazs Kelemen <kb@inf.u-szeged.hu> on 2010-08-16
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformSetUpWebProcess): Added empty stub implementation.
* WebKit2.pro: Enumerate new files, include WebKit.pri for correct define macro set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 16 Aug 2010 09:09:50 +0000 (09:09 +0000)]
2010-08-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        document.write causes the links to appear twice (noscript content is not ignored)
        https://bugs.webkit.org/show_bug.cgi?id=16230

        Add a test for this case.

        * fast/parser/document-write-noscript-expected.txt: Added.
        * fast/parser/document-write-noscript.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 16 Aug 2010 08:51:20 +0000 (08:51 +0000)]
2010-08-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        document.write() isn't processed immediately before DOM access
        https://bugs.webkit.org/show_bug.cgi?id=36881

        Test that document.write gets flushed before DOM access takes place.

        * fast/tokenizer/document-write-racing-dom-access-expected.txt: Added.
        * fast/tokenizer/document-write-racing-dom-access.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Yuta Kitamura <yutak@chromium.org>
hamaji@chromium.org [Mon, 16 Aug 2010 08:45:58 +0000 (08:45 +0000)]
2010-08-16  Yuta Kitamura  <yutak@chromium.org>

        Not reviewed. Chromium test expectations updates and rebaselines.

        * platform/chromium-linux/fast/canvas/setWidthResetAfterForcedRender-expected.checksum: Added.
        * platform/chromium-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
        * platform/chromium-linux/fast/text/word-space-expected.checksum:
        * platform/chromium-linux/fast/text/word-space-expected.png:
        * platform/chromium-linux/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum:
        * platform/chromium-linux/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
        * platform/chromium-mac/fast/canvas/setWidthResetAfterForcedRender-expected.checksum: Added.
        * platform/chromium-mac/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
        * platform/chromium-mac/fast/text/word-space-expected.checksum: Added.
        * platform/chromium-mac/fast/text/word-space-expected.png: Added.
        * platform/chromium-mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum: Added.
        * platform/chromium-mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.png: Added.
        * platform/chromium-win/fast/canvas/setWidthResetAfterForcedRender-expected.checksum: Added.
        * platform/chromium-win/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
        * platform/chromium-win/fast/canvas/setWidthResetAfterForcedRender-expected.txt: Added.
        * platform/chromium-win/fast/text/word-space-expected.checksum:
        * platform/chromium-win/fast/text/word-space-expected.png:
        * platform/chromium-win/fast/text/word-space-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt:
        * platform/chromium-win/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum:
        * platform/chromium-win/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
        * platform/chromium-win/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
        * platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Mon, 16 Aug 2010 08:45:44 +0000 (08:45 +0000)]
2010-08-16  Zoltan Horvath  <zoltan@webkit.org>

        Add my old e-mail addresses to committers.py.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 16 Aug 2010 08:22:11 +0000 (08:22 +0000)]
2010-08-16  MORITA Hajime <morrita@google.com>

        Unreviewd, added skip list entries.

        This is follow up for r65395. QT port ignores tests under
        editing/pasteboard.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 16 Aug 2010 08:14:12 +0000 (08:14 +0000)]
2010-08-16  MORITA Hajime  <morrita@google.com>

        Unreviewd, added skip list entries.

        This is follow up for r65395. GTK port ignores tests under
        editing/pasteboard.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 16 Aug 2010 08:04:17 +0000 (08:04 +0000)]
2010-08-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        HTML5 fragment parsing doesn't load iframes
        https://bugs.webkit.org/show_bug.cgi?id=44038

        Test that iframes created in detached documents actually get loaded
        when they're adopted into attached documents (or, rather, when they're
        inserted into the DOM).

        * fast/frames/adopt-from-created-document-expected.txt: Added.
        * fast/frames/adopt-from-created-document.html: Added.
2010-08-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        HTML5 fragment parsing doesn't load iframes
        https://bugs.webkit.org/show_bug.cgi?id=44038

        Previously, this code assumed that every source iframe was actually
        attached to a render tree.  It tried to "keep the iframe alive" as it
        moved documents.  However, if the iframe wasn't attached to begin with,
        it was never "alive," so trying to keep a dead iframe alive lead to a
        ...  zombie iframe.

        Test: fast/frames/adopt-from-created-document.html

        * dom/Document.cpp:
        (WebCore::Document::adoptNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-13 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 16 Aug 2010 07:30:02 +0000 (07:30 +0000)]
2010-08-13  MORITA Hajime  <morrita@google.com>

        Reviewed by Tony Chang.

        https://bugs.webkit.org/show_bug.cgi?id=43778
        Dropping should fire textInput event.

        * editing/pasteboard/drop-text-events-expected.txt: Added.
        * editing/pasteboard/drop-text-events-sideeffect-expected.txt: Added.
        * editing/pasteboard/drop-text-events-sideeffect.html: Added.
        * editing/pasteboard/drop-text-events.html: Added.
        * editing/pasteboard/script-tests/drop-text-events-sideeffect.js: Added.
        * editing/pasteboard/script-tests/drop-text-events.js: Added.
2010-08-13  MORITA Hajime  <morrita@google.com>

        Reviewed by Tony Chang.

        https://bugs.webkit.org/show_bug.cgi?id=43778
        Dropping should fire textInput event

        This change:
        - added TextEvent::m_isDrop to distinguish drop-initiated events.
        - added to dispatch TextEvent from DragController before making a side effect
          and cancel the side effect if the event prevents default

        Tests: editing/pasteboard/drop-text-events-sideeffect.html
               editing/pasteboard/drop-text-events.html

        * dom/TextEvent.cpp:
        (WebCore::TextEvent::createForDrop): Added.
        (WebCore::TextEvent::TextEvent):
        * dom/TextEvent.h:
        (WebCore::TextEvent::isDrop): Added.
        * editing/Editor.cpp:
        (WebCore::Editor::handleTextEvent):
        (WebCore::Editor::findEventTargetFrom): Extracted from findEventTargetFromSelection().
        (WebCore::Editor::findEventTargetFromSelection):
        * editing/Editor.h:
        * page/DragController.cpp:
        (WebCore::DragController::dispatchTextInputEventFor): Added.
        (WebCore::DragController::concludeEditDrag): Added an event dispatch path.
        * page/DragController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-15 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Mon, 16 Aug 2010 06:38:06 +0000 (06:38 +0000)]
2010-08-15  Ariya Hidayat  <ariya@sencha.com>

        Unreviewed, rolling out r65393.
        http://trac.webkit.org/changeset/65393
        https://bugs.webkit.org/show_bug.cgi?id=44031

        Breaks some canvas tests.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContextPlatformPrivate::):
        (WebCore::GraphicsContextPlatformPrivate::hasShadow):
        (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
        (WebCore::GraphicsContext::savePlatformState):
        (WebCore::GraphicsContext::restorePlatformState):
        (WebCore::GraphicsContext::strokeArc):
        (WebCore::GraphicsContext::drawConvexPolygon):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::setPlatformShadow):
        (WebCore::GraphicsContext::clearPlatformShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Save and restore shadow state in GraphicsContextQt
ariya@webkit.org [Mon, 16 Aug 2010 06:19:01 +0000 (06:19 +0000)]
[Qt] Save and restore shadow state in GraphicsContextQt
https://bugs.webkit.org/show_bug.cgi?id=44031

Patch by Ariya Hidayat <ariya@sencha.com> on 2010-08-15
Reviewed by Antonio Gomes.

This is needed after r65362.
Use a new class ContextShadowParameter to track and keep the shadow
state. We use this rather than using GraphicsContextState to allow
possible optimizations (right now only to determine the shadow type,
but in future it might cover things like cached scratch image,
persistent shader, etc).

* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::ContextShadowParameter::):
(WebCore::ContextShadowParameter::ContextShadowParameter):
(WebCore::ContextShadowParameter::clear):
(WebCore::GraphicsContextPlatformPrivate::hasShadow):
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::clearPlatformShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-15 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Mon, 16 Aug 2010 05:27:39 +0000 (05:27 +0000)]
2010-08-15  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Antonio Gomes.

        [Qt] Border should not cast shadows
        https://bugs.webkit.org/show_bug.cgi?id=44015

        Update pixel test reference.

        * platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
        * platform/qt/fast/box-shadow/basic-shadows-expected.png:
2010-08-15  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Antonio Gomes.

        [Qt] Border should not cast shadows
        https://bugs.webkit.org/show_bug.cgi?id=44015

        Shadows should be not casted except for brush fill (which is not what
        drawLine and drawRect are supposed to do).

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::drawRect): Remove shadow painting,
        (WebCore::GraphicsContext::drawLine): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-15 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Mon, 16 Aug 2010 03:28:58 +0000 (03:28 +0000)]
2010-08-15  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Build error on r65378
        https://bugs.webkit.org/show_bug.cgi?id=44019

        Add GENERATE_JSON macro for HTMLEntityNames.json instead of HTMLEntityNames.gperf

        * cmake/WebKitMacros.cmake:
2010-08-15  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Build error on r65378
        https://bugs.webkit.org/show_bug.cgi?id=44019

        Change build script for HTMLEntityNames.json instead of HTMLEntityNames.gperf

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebEditorClient::didBeginEditing is never called in WebKit2
jhoneycutt@apple.com [Mon, 16 Aug 2010 01:58:15 +0000 (01:58 +0000)]
WebEditorClient::didBeginEditing is never called in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42939

Reviewed by Sam Weinig.

* WebKitTestRunner/PlatformWebView.h:
Declare focus().

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
Focus the PlatformWebView.

* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::focus):
Stubbed.

* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::focus):
Focus the view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agorun-webkit-tests should not strip editing callbacks when using
jhoneycutt@apple.com [Mon, 16 Aug 2010 01:57:40 +0000 (01:57 +0000)]
run-webkit-tests should not strip editing callbacks when using
WebKitTestRunner on Windows
https://bugs.webkit.org/show_bug.cgi?id=44000

Reviewed by Mark Rowe.

* Scripts/old-run-webkit-tests:
Leave $stripEditingCallbacks undefined until we look for command-line
arguments. If using WebKit2, set it to 0 if not explicity set on the
command line. Later, set it to isCygwin() to match old behavior if it is
not yet defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-15 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 16 Aug 2010 01:48:54 +0000 (01:48 +0000)]
2010-08-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Port Chromium's WebEntities to HTMLEntityTable
        https://bugs.webkit.org/show_bug.cgi?id=44036

        This code is wrong and needs to be removed.  However, at least after
        this patch, it will compile.

        * src/WebEntities.cpp:
        (WebKit::):
        (WebKit::WebEntities::WebEntities):
        * src/WebEntities.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix, add missing header.
kevino@webkit.org [Mon, 16 Aug 2010 00:12:49 +0000 (00:12 +0000)]
[wx] Build fix, add missing header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix, don't build PluginDataNone.cpp even on GTK as PluginDataWx.cpp compiles.
kevino@webkit.org [Mon, 16 Aug 2010 00:05:17 +0000 (00:05 +0000)]
[wx] Build fix, don't build PluginDataNone.cpp even on GTK as PluginDataWx.cpp compiles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix, don't build intermediate source in DerivedSources dir.
kevino@webkit.org [Mon, 16 Aug 2010 00:02:22 +0000 (00:02 +0000)]
[wx] Build fix, don't build intermediate source in DerivedSources dir.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
kevino@webkit.org [Sun, 15 Aug 2010 23:47:58 +0000 (23:47 +0000)]
[wx] Build fix, remove define always set to the correct value by wtf/Platform.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-14 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sun, 15 Aug 2010 20:15:04 +0000 (20:15 +0000)]
2010-08-14  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: -[WebInspector attach] and detach should work
        https://bugs.webkit.org/show_bug.cgi?id=43924

        * WebKit.xcodeproj/project.pbxproj: Added WebInspectorFrontend.{h,mm}.

2010-08-14  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: -[WebInspector attach] and detach should work
        https://bugs.webkit.org/show_bug.cgi?id=43924

        For actions that relate only to the Web Inspector's Frontend
        window (actions on the InspectorFrontendClient) the new Obj-C
        wrapper class WebInspectorFrontend can be used. For now, this
        is just attach and detach.

        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::openInspectorFrontend): setup and attach the WebInspectorFrontend to the WebInspector.
        * WebInspector/WebInspector.h:
        * WebInspector/WebInspector.mm:
        (-[WebInspector dealloc]):
        (-[WebInspector attach:]): delegate to the frontend.
        (-[WebInspector detach:]): delegate to the frontend.
        (-[WebInspector setFrontend:]):
        * WebInspector/WebInspectorFrontend.h: Added.
        * WebInspector/WebInspectorFrontend.mm: Added.
        (-[WebInspectorFrontend initWithFrontendClient:]):
        (-[WebInspectorFrontend attach]):
        (-[WebInspectorFrontend detach]):
        * WebInspector/WebInspectorPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-15 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 15 Aug 2010 19:43:17 +0000 (19:43 +0000)]
2010-08-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        document.write() doesn't flush plain text
        https://bugs.webkit.org/show_bug.cgi?id=8961

        Add test cases for flushing character tokens.

        * fast/tokenizer/flush-characters-in-document-write-evil-expected.txt: Added.
        * fast/tokenizer/flush-characters-in-document-write-evil.html: Added.
        * fast/tokenizer/flush-characters-in-document-write-expected.txt: Added.
        * fast/tokenizer/flush-characters-in-document-write.html: Added.
2010-08-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        document.write() doesn't flush plain text
        https://bugs.webkit.org/show_bug.cgi?id=8961

        Originally I thought we should buffer the character tokens until we've
        reached the end of the input stream, but that's not how the spec
        handles things (it emits the character tokens one-by-one).

        Tests: fast/tokenizer/flush-characters-in-document-write-evil.html
               fast/tokenizer/flush-characters-in-document-write.html

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::emitEndOfFile):
        (WebCore::HTMLTokenizer::nextToken):
        (WebCore::HTMLTokenizer::haveBufferedCharacterToken):
            - Renamed this function now that it's simplier.
        * html/HTMLTokenizer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-15 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 15 Aug 2010 15:34:25 +0000 (15:34 +0000)]
2010-08-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Don't try to replace a non-existent document after executing JavaScript URLs
        https://bugs.webkit.org/show_bug.cgi?id=44024

        Test what happens if a JavaScript URL returns a value after deleting
        the frame it was supposed to operate on.

        * fast/frames/javascript-url-for-deleted-frame-expected.txt: Added.
        * fast/frames/javascript-url-for-deleted-frame.html: Added.
2010-08-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Don't try to replace a non-existent document after executing JavaScript URLs
        https://bugs.webkit.org/show_bug.cgi?id=44024

        Synchronous JavaScript execution is evil.  Previously, the frame was
        deleted after executing the JavaScript URL, so we'd get confused when
        we tried to replace its document.

        Test: fast/frames/javascript-url-for-deleted-frame.html

        * bindings/ScriptControllerBase.cpp:
        (WebCore::ScriptController::executeIfJavaScriptURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-15 Gyuyoung Kim <gyuyoung.kim@samsung.com>
commit-queue@webkit.org [Sun, 15 Aug 2010 14:10:01 +0000 (14:10 +0000)]
2010-08-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Enable localStorage of HTML5 for WebKit EFL
        https://bugs.webkit.org/show_bug.cgi?id=44020

        * ewk/ewk_view.cpp:
        (_ewk_view_priv_new):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevised build fix from r65363 based on suggestion from Darin Adler.
mitz@apple.com [Sun, 15 Aug 2010 07:24:34 +0000 (07:24 +0000)]
Revised build fix from r65363 based on suggestion from Darin Adler.

* UIProcess/API/C/WKArray.h: Include stddef.h.
* UIProcess/API/C/WKBase.h: Uninclude ctype.h.
* UIProcess/API/C/WKData.h: Include stddef.h.
* UIProcess/API/C/WKDictionary.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-14 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Sun, 15 Aug 2010 01:29:49 +0000 (01:29 +0000)]
2010-08-14  Martin Robinson  <mrobinson@igalia.com>

        [GTK] Some test results are one pixel different between the x86_64 and i386 bots
        https://bugs.webkit.org/show_bug.cgi?id=39022

        * platform/gtk/Skipped: Skip MathML tests which show 32-bit/64-bit rounding differences.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-14 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Sun, 15 Aug 2010 00:52:29 +0000 (00:52 +0000)]
2010-08-14  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [GTK] autogen.sh not executed if build-webkit options change
        https://bugs.webkit.org/show_bug.cgi?id=42266

        Rerun autogen.sh in situations where the arguments to build-webkit have
        changed since the previous build. This will fix some issues on the bots
        where the build does not notice changes to default build-webkit arguments.

        * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-14 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Sat, 14 Aug 2010 23:34:04 +0000 (23:34 +0000)]
2010-08-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65374.
        http://trac.webkit.org/changeset/65374
        https://bugs.webkit.org/show_bug.cgi?id=44018

        broke a myriad of svg tests (Requested by kling on #webkit).

        * platform/graphics/qt/PathQt.cpp:
        (WebCore::Path::strokeBoundingRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 14 Aug 2010 23:29:39 +0000 (23:29 +0000)]
2010-08-14  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        XSLTProcessor.transformToFragment should not pass contextElement to html/xml document parsers
        https://bugs.webkit.org/show_bug.cgi?id=44017

        This fixes two tests which otherwise would fail when the
        HTML5 TreeBuilder is enabled for fragment parsing.

        This revealed a bug in HTMLTreeBuilder() which I fixed as well.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
        * xml/XSLTProcessor.cpp:
        (WebCore::createFragmentFromSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-14 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Sat, 14 Aug 2010 22:44:20 +0000 (22:44 +0000)]
2010-08-14  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Path: Fast approximation of stroke bounding rects
        https://bugs.webkit.org/show_bug.cgi?id=44014

        * platform/graphics/qt/PathQt.cpp:
        (WebCore::Path::strokeBoundingRect): Use QPainterPath::controlPointRect()
        to calculate a slightly larger bounding rect in a fraction of the time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-14 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 14 Aug 2010 22:00:57 +0000 (22:00 +0000)]
2010-08-14  Adam Barth  <abarth@webkit.org>

        Propagate name change to Qt.

        * Api/qwebelement.cpp:
        (QWebElement::appendInside):
        (QWebElement::prependInside):
        (QWebElement::prependOutside):
        (QWebElement::appendOutside):
        (QWebElement::encloseContentsWith):
        (QWebElement::encloseWith):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 14 Aug 2010 21:38:50 +0000 (21:38 +0000)]
2010-08-14  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Move innerHTML off of Range::createContextualFragment
        https://bugs.webkit.org/show_bug.cgi?id=44011

        This makes all the editing tests stop failing under the
        HTML5 TreeBuilder.

        In a previous patch Adam disabled some of the (wrong) code
        in createContextualFragment when in html5 treebuilder mode.
        The problem is that the editing code depends on
        createContextualFragment (as well as the Range DOM API),
        so we have to leave this code in until we can figure
        out if it's right or wrong behavior for the Range API.

        This patch moves innerHTML/outerHTML off of using
        createContextualFragment and instead calls
        DocumentFragment::parseHTML directly (which is much simpler).

        I expect Adam and I will end up turning on the HTML5 TreeBuilder
        in the next couple days, and most of the if branches I added
        here will go away for good.

        I renamed Element::createContextualFragment to
        deprecatedCreateContextualFragment, to indicate that it's a
        dead API.  The editing code should move off of it and consider
        using DocumentFragment::parseHTML instead.

        * dom/Element.cpp:
        (WebCore::Element::deprecatedCreateContextualFragment):
        * dom/Element.h:
        * dom/Range.cpp:
        (WebCore::Range::createContextualFragment):
        * editing/markup.cpp:
        (WebCore::createFragmentFromMarkup):
        * html/HTMLElement.cpp:
        (WebCore::useLegacyTreeBuilder):
        (WebCore::HTMLElement::deprecatedCreateContextualFragment):
        (WebCore::HTMLElement::setInnerHTML):
        (WebCore::HTMLElement::setOuterHTML):
        * html/HTMLElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-14 Tasuku Suzuki <tasuku.suzuki@nokia.com>
commit-queue@webkit.org [Sat, 14 Aug 2010 19:24:30 +0000 (19:24 +0000)]
2010-08-14  Tasuku Suzuki  <tasuku.suzuki@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] Fix compilation with QT_NO_LINEEDIT
        https://bugs.webkit.org/show_bug.cgi?id=38324

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::convertValueToQVariant):
        (JSC::Bindings::convertQVariantToValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-14 Rob Buis <rwlbuis@gmail.com>
rwlbuis@webkit.org [Sat, 14 Aug 2010 17:53:47 +0000 (17:53 +0000)]
2010-08-14  Rob Buis  <rwlbuis@gmail.com>

        Reviewed by Dirk Schulze.

        IE SVG empty path test fails
        https://bugs.webkit.org/show_bug.cgi?id=44008

        Change createLine to allow creating zero-length lines. This makes it possible
        to have markers and line-caps applied to zero-length lines.

        Test: svg/custom/marker-empty-path.svg

        * platform/graphics/Path.cpp:
        (WebCore::Path::createLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-14 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Sat, 14 Aug 2010 16:34:26 +0000 (16:34 +0000)]
2010-08-14  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kenneth Rohde Christiansen.

        [CMake] Add preprocessor detection for generator scripts
        https://bugs.webkit.org/show_bug.cgi?id=43984

        * cmake/OptionsCommon.cmake:
2010-08-14  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kenneth Rohde Christiansen.

        [CMake] Add preprocessor detection for generator scripts
        https://bugs.webkit.org/show_bug.cgi?id=43984

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-14 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Sat, 14 Aug 2010 15:53:04 +0000 (15:53 +0000)]
2010-08-14  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kenneth Rohde Christiansen.

        [CMake] Move SQL files into a IF (ENABLE_DATABASE) section
        https://bugs.webkit.org/show_bug.cgi?id=43979

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-14 Matthew Delaney <mdelaney@apple.com>
commit-queue@webkit.org [Sat, 14 Aug 2010 15:36:40 +0000 (15:36 +0000)]
2010-08-14  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Kenneth Rohde Christiansen.

        Canvas is not reset when setting canvas.width
        https://bugs.webkit.org/show_bug.cgi?id=43341

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::reset): Moved the call to
        hasCreatedImageBuffer up *before* the call to setSurface since setSurface
        sets hasCreatedImageBuffer to false every time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-14 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Sat, 14 Aug 2010 15:17:54 +0000 (15:17 +0000)]
2010-08-14  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kenneth Rohde Christiansen.

        [CMake] Set target properties only if available
        https://bugs.webkit.org/show_bug.cgi?id=43978

        * CMakeLists.txt:
        * jsc/CMakeLists.txt:
        * wtf/CMakeLists.txt:
2010-08-14  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kenneth Rohde Christiansen.

        [CMake] Set target properties only if available
        https://bugs.webkit.org/show_bug.cgi?id=43978

        * CMakeLists.txt:
2010-08-14  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kenneth Rohde Christiansen.

        [CMake] Set target properties only if available
        https://bugs.webkit.org/show_bug.cgi?id=43978

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-14 Adrienne Walker <enne@google.com>
commit-queue@webkit.org [Sat, 14 Aug 2010 15:00:20 +0000 (15:00 +0000)]
2010-08-14  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Rohde Christiansen.

        Update .gitignore file for more files
        https://bugs.webkit.org/show_bug.cgi?id=43991

        * .gitignore:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-14 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sat, 14 Aug 2010 14:11:11 +0000 (14:11 +0000)]
2010-08-14  Dirk Schulze  <krit@webkit.org>

        Unreviewed sort of Xcode project file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClean build of WebKitTestRunner fails with “'size_t' has not been declared” in WKArray.h
mitz@apple.com [Sat, 14 Aug 2010 08:39:08 +0000 (08:39 +0000)]
Clean build of WebKitTestRunner fails with “'size_t' has not been declared” in WKArray.h
https://bugs.webkit.org/show_bug.cgi?id=44005

Reviewed by Anders Carlsson in Sweden.

* UIProcess/API/C/WKBase.h: Include ctype.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-14 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Sat, 14 Aug 2010 08:22:55 +0000 (08:22 +0000)]
2010-08-14  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Simon Hausmann and Kenneth Rohde Christiansen.

        [Qt] Refactor shadow state handling in GraphicsContextQt
        https://bugs.webkit.org/show_bug.cgi?id=44006

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContextPlatformPrivate::): Added shadow states as
        member variables.
        (WebCore::GraphicsContextPlatformPrivate::hasShadow): Convenient
        function to check whether there is shadow or not.
        (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
        (WebCore::GraphicsContext::drawRect): Use shadow states instead of
        calling getShadow.
        (WebCore::GraphicsContext::drawLine): ditto.
        (WebCore::GraphicsContext::strokeArc): ditto.
        (WebCore::GraphicsContext::drawConvexPolygon): ditto.
        (WebCore::GraphicsContext::fillPath): ditto.
        (WebCore::GraphicsContext::strokePath): ditto.
        (WebCore::GraphicsContext::fillRect): Removes the use of helper function
        drawBorderlessRectShadow as the code already becomes a lot simpler.
        (WebCore::GraphicsContext::fillRoundedRect): Removes the use of helper
function drawFilledShadowPath as the code already becomes a lot simpler.
        (WebCore::GraphicsContext::setPlatformShadow): Store shadow states
        and find out the shadow type (complexity) for future use.
        (WebCore::GraphicsContext::clearPlatformShadow): Reset shadow states.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-14 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Sat, 14 Aug 2010 08:04:53 +0000 (08:04 +0000)]
2010-08-14  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Outdated pixel test reference for fast/box-shadow/transform-fringing.html
        https://bugs.webkit.org/show_bug.cgi?id=44007

        * platform/qt/fast/box-shadow/transform-fringing-expected.checksum:
        * platform/qt/fast/box-shadow/transform-fringing-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 14 Aug 2010 07:17:47 +0000 (07:17 +0000)]
2010-08-14  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Another fix to support python 2.3.

        Add support for MathML entities
        https://bugs.webkit.org/show_bug.cgi?id=43949

        * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
         - It looks like our simplejson is version 1.7.3 which
           should be python 2.3 compatible.  But someone modified
           our copy slightly from the original source.
           I've removed the relative import in hopes this fixes
           the problem.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 14 Aug 2010 06:44:40 +0000 (06:44 +0000)]
2010-08-13  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Build fix only.

        Add support for MathML entities
        https://bugs.webkit.org/show_bug.cgi?id=43949

        * Scripts/create-html-entity-table:
         - Hack sys.path to avoid executing 2.5 dependent python
           on systems (like chromium-win and Tiger) which do not have 2.5 python.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-13 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 14 Aug 2010 06:26:10 +0000 (06:26 +0000)]
2010-08-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Rename some concepts in HTML entity search to be more self-documenting
        https://bugs.webkit.org/show_bug.cgi?id=44004

        Start and end are now first and last, which lets us use some better
        names for the statics in HTMLEntityTable.

        * html/HTMLEntityParser.cpp:
        (WebCore::consumeHTMLEntity):
        * html/HTMLEntitySearch.cpp:
        (WebCore::HTMLEntitySearch::HTMLEntitySearch):
        (WebCore::HTMLEntitySearch::findFirst):
        (WebCore::HTMLEntitySearch::findLast):
        (WebCore::HTMLEntitySearch::advance):
        * html/HTMLEntitySearch.h:
        (WebCore::HTMLEntitySearch::isEntityPrefix):
        (WebCore::HTMLEntitySearch::mostRecentMatch):
        (WebCore::HTMLEntitySearch::fail):
        * html/HTMLEntityTable.h:
2010-08-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Rename some concepts in HTML entity search to be more self-documenting
        https://bugs.webkit.org/show_bug.cgi?id=44004

        Reflect name change in generator script.

        * Scripts/create-html-entity-table:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-13 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 14 Aug 2010 06:03:37 +0000 (06:03 +0000)]
2010-08-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Make it easier to run LayoutTests in Firefox
        https://bugs.webkit.org/show_bug.cgi?id=44002

        Firefox doesn't seem to have innerText.  Instead, let's just use the
        normal DOM operations.

        * fast/parser/resources/p-in-scope.js:
        * fast/table/incomplete-table-in-fragment-2.html:
        * fast/table/incomplete-table-in-fragment-hang.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix, add CString to the list of forwards.
kevino@webkit.org [Sat, 14 Aug 2010 05:09:57 +0000 (05:09 +0000)]
[wx] Build fix, add CString to the list of forwards.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-13 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 14 Aug 2010 05:05:32 +0000 (05:05 +0000)]
2010-08-13  Adam Barth  <abarth@webkit.org>

        Update test expectations to account for the HTML5 entity parser.  There
        are two main differences:

        1) The value of lang and rang have changed.
        2) We now parse FOO&ltBAR as FOO<BAR.

        * fast/parser/entities-in-html-expected.txt:
        * fast/parser/entities-in-xhtml-expected.txt:
        * http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
        * http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
            - This test expectation is wrong.  It's on my list to redesign how
              the XSS auditor works now that we have better parsing tools.
              Rather than skip the test on all platforms, I'm updating the
              expectation.
        * platform/mac/fast/text/word-space-expected.txt:
        * platform/mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
        * platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-13 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 14 Aug 2010 04:57:03 +0000 (04:57 +0000)]
2010-08-13  Adam Barth  <abarth@webkit.org>

        Fix ASSERT in XML entity parsing.  You can't advance the entity search
        if you've already discovered that your string is not an entity.

        * html/HTMLEntityParser.cpp:
        (WebCore::decodeNamedEntity):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 14 Aug 2010 03:32:08 +0000 (03:32 +0000)]
2010-08-13  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Attempt at fixing Chromium build.

        Add support for MathML entities
        https://bugs.webkit.org/show_bug.cgi?id=43949

        * WebCore.gyp/WebCore.gyp:
         - I have no clue if this is right or not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 14 Aug 2010 03:28:52 +0000 (03:28 +0000)]
2010-08-13  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Attempted build fix for Windows.

        Add support for MathML entities
        https://bugs.webkit.org/show_bug.cgi?id=43949

        * DerivedSources.cpp:
         - Add HTMLEntityTable.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Adam Barth <abarth@webkit.org>
eric@webkit.org [Sat, 14 Aug 2010 03:18:16 +0000 (03:18 +0000)]
2010-08-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add support for MathML entities
        https://bugs.webkit.org/show_bug.cgi?id=43949

        Test progression for proper entity support.

        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:
2010-08-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add support for MathML entities
        https://bugs.webkit.org/show_bug.cgi?id=43949

        Implementing the HTML5 entity parsing algorithm require refactoring how
        we search for entity names.  Instead of using a perfect hash, we now
        use a sorted list.  As we advance through the input, we walk down a
        binary search of the table looking for an entity.

        Using this data structure lets us keep track of whether the current
        string is a prefix of an existing entity, which we need for the
        algorithm.  In a future patch, I plan to add some indices to the
        table, which should let us narrow down the range of interesting entries
        more quickly.

        The one nasty piece of the algorithm is if we walk too far down the
        input and we need to back up to a previous match.  In this patch, we
        accomplish this by rewinding the input and consuming a known number of
        characters to resync the source.

        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLEntityParser.cpp:
        (WebCore::consumeHTMLEntity):
        * html/HTMLEntitySearch.cpp: Added.
        (WebCore::):
        (WebCore::HTMLEntitySearch::HTMLEntitySearch):
        (WebCore::HTMLEntitySearch::compare):
        (WebCore::HTMLEntitySearch::findStart):
        (WebCore::HTMLEntitySearch::findEnd):
        (WebCore::HTMLEntitySearch::advance):
        * html/HTMLEntitySearch.h: Added.
        (WebCore::HTMLEntitySearch::isEntityPrefix):
        (WebCore::HTMLEntitySearch::currentValue):
        (WebCore::HTMLEntitySearch::lastMatch):
        (WebCore::HTMLEntitySearch::):
        (WebCore::HTMLEntitySearch::fail):
        * html/HTMLEntityTable.h: Added.
        (WebCore::HTMLEntityTableEntry::lastCharacter):
2010-08-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add support for MathML entities
        https://bugs.webkit.org/show_bug.cgi?id=43949

        A script for generating the C++ state data structure describing all the
        entities from a JSON description.

        * Scripts/create-html-entity-table: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-13 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Sat, 14 Aug 2010 03:09:36 +0000 (03:09 +0000)]
2010-08-13  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Eric Seidel.

        Refactor HTMLScriptRunner to allow deferred scripts to share code
        https://bugs.webkit.org/show_bug.cgi?id=43736

        No new tests because no functional change

        * html/HTMLScriptRunner.cpp:
        (WebCore::HTMLScriptRunner::sourceFromPendingScript): Make const to enforce the idea that it doesn't change m_parsingBlockingScript.
        (WebCore::HTMLScriptRunner::executeParsingBlockingScript): Rename to make it clear this deals with the parsing blocking script and refactor to use executePendingScriptAndDispatchEvent.
        (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): Factored out of executePendingScript, this can be used for executing any external script.
        (WebCore::HTMLScriptRunner::executeScript): This can be used for executing any inline or external script. ASSERTs moved to the two calling points.
        (WebCore::HTMLScriptRunner::executeParsingBlockingScripts): Moved method.
        (WebCore::HTMLScriptRunner::requestParsingBlockingScript): Factored out requestPendingScript.
        (WebCore::HTMLScriptRunner::requestPendingScript): Factored out from reqeustParsingBlockingScript.
        (WebCore::HTMLScriptRunner::runScript):
        * html/HTMLScriptRunner.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix.
barraclough@apple.com [Sat, 14 Aug 2010 02:23:43 +0000 (02:23 +0000)]
Windows build fix.

* WebCore.xcodeproj/project.pbxproj:
* platform/win/SharedBufferWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-13 Mihai Parparita <mihaip@chromium.org>
commit-queue@webkit.org [Sat, 14 Aug 2010 02:16:42 +0000 (02:16 +0000)]
2010-08-13  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Dimitri Glazkov.

        Form state restore tests fail on GTK build with r65340
        https://bugs.webkit.org/show_bug.cgi?id=43998

        Move form submits (and rest of test) to run during onload, to make sure
        that the submit generates a history entry.

        * fast/forms/state-restore-to-non-autocomplete-form.html:
        * fast/forms/state-restore-to-non-edited-controls.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix
barraclough@apple.com [Sat, 14 Aug 2010 01:53:25 +0000 (01:53 +0000)]
Windows build fix

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65347 268f45cc-cd09-0410-ab3c-d52691b4dbfc