WebKit-https.git
9 years ago2010-09-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 13 Sep 2010 01:04:35 +0000 (01:04 +0000)]
2010-09-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Adoption agency should use takeAllChildrenFrom
        https://bugs.webkit.org/show_bug.cgi?id=45570

        Before this patch, we were using an unsafe pattern of walking the
        sibling list without grabbing references.  Instead, we should use the
        shiny new takeAllChildrenFrom method that shoves the children into a
        vector first.  Also, update takeAllChildrenFrom to handle the case
        where the old parent is attached.

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::takeAllChildrenFrom):
        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
        * html/parser/HTMLTreeBuilder.h:
2010-09-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Adoption agency should use takeAllChildrenFrom
        https://bugs.webkit.org/show_bug.cgi?id=45570

        More test cases.

        * html5lib/resources/webkit01.dat:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 13 Sep 2010 00:42:45 +0000 (00:42 +0000)]
2010-09-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        isParsingFragment assert hit in new treebuilder
        https://bugs.webkit.org/show_bug.cgi?id=45621

        Add new tests and (minor) test progression.

        * html5lib/resources/webkit01.dat:
        * html5lib/runner-expected.txt:
2010-09-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        isParsingFragment assert hit in new treebuilder
        https://bugs.webkit.org/show_bug.cgi?id=45621

        Update our list of special tags to match the spec.

        * html/parser/HTMLTreeBuilder.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-12 Robert Hogan <robert@webkit.org>
robert@webkit.org [Mon, 13 Sep 2010 00:19:43 +0000 (00:19 +0000)]
2010-09-12  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Fix http/tests/navigation/reload-subframe-object.html

        Unskip http/tests/navigation/reload-subframe-object.html

        https://bugs.webkit.org/show_bug.cgi?id=45613

        * platform/qt/Skipped:
2010-09-12  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Fix http/tests/navigation/reload-subframe-object.html

        We need to bring our use of getMimeTypeForPath() and
        getMimeTypeForExtension() into line with WebCore expectations.

        We should use MIMETypeRegistry::getMIMETypeForExtension() for cases
        where an empty mimetype should be returned if no match is found, and
        MIMETypeRegistry::getMIMETypeForPath() for cases where
        'application/octet-stream' should be returned if no match is found.

        Fixes http/tests/navigation/reload-subframe-object.html

        Based on findings in webkit.org/b/31398 and webkit.org/b/15554.

        https://bugs.webkit.org/show_bug.cgi?id=45613

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
        * platform/qt/MIMETypeRegistryQt.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-12 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 13 Sep 2010 00:02:04 +0000 (00:02 +0000)]
2010-09-12  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by James Robinson.

        Remove some tests from the WebKit2 skipped list that are now passing
        https://bugs.webkit.org/show_bug.cgi?id=45625

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-12 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sun, 12 Sep 2010 23:40:51 +0000 (23:40 +0000)]
2010-09-12  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-12 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sun, 12 Sep 2010 23:37:46 +0000 (23:37 +0000)]
2010-09-12  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.

        My last change accidentally contained a local change to the
        rebaselinig script; webkit-patch land picked it up without telling
        me and committed it :(

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-12 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sun, 12 Sep 2010 23:34:37 +0000 (23:34 +0000)]
2010-09-12  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeglect unlikely hyphenation opportunities
mitz@apple.com [Sun, 12 Sep 2010 23:04:16 +0000 (23:04 +0000)]
Neglect unlikely hyphenation opportunities
https://bugs.webkit.org/show_bug.cgi?id=45606

Reviewed by Adele Peterson.

Avoid looking for hyphenation points in about 40% of the cases at the cost of missing about
3% of the hyphenation opportunities.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::tryHyphenating): Bail out if the widest the prefix before the hyphen can be is no more
than 5/4 the font size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-12 James Robinson <jamesr@chromium.org>
jamesr@google.com [Sun, 12 Sep 2010 22:58:56 +0000 (22:58 +0000)]
2010-09-12  James Robinson  <jamesr@chromium.org>

        Unreviewed, rolling out r67328.
        http://trac.webkit.org/changeset/67328
        https://bugs.webkit.org/show_bug.cgi?id=45610

        Broke layout tests on mac and chromium.

        * http/tests/navigation/post-basic-expected.txt: Removed.
        * http/tests/navigation/post-basic.html:
        * http/tests/navigation/post-frames-expected.txt: Removed.
        * http/tests/navigation/post-frames.html:
        * http/tests/navigation/resources/page-that-posts.html: Removed.
        * http/tests/navigation/resources/postresult.pl:
        * platform/chromium-linux/http/tests/navigation/post-basic-expected.checksum: Added.
        * platform/chromium-linux/http/tests/navigation/post-basic-expected.png: Added.
        * platform/chromium-linux/http/tests/navigation/post-frames-expected.checksum: Added.
        * platform/chromium-linux/http/tests/navigation/post-frames-expected.png: Added.
        * platform/chromium-win/http/tests/navigation/post-basic-expected.checksum: Added.
        * platform/chromium-win/http/tests/navigation/post-basic-expected.png: Added.
        * platform/chromium-win/http/tests/navigation/post-basic-expected.txt: Added.
        * platform/chromium-win/http/tests/navigation/post-frames-expected.checksum: Added.
        * platform/chromium-win/http/tests/navigation/post-frames-expected.png: Added.
        * platform/chromium-win/http/tests/navigation/post-frames-expected.txt: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/http/tests/navigation/post-basic-expected.checksum: Copied from LayoutTests/platform/mac/http/tests/navigation/post-goback1-expected.checksum.
        * platform/mac/http/tests/navigation/post-basic-expected.png: Copied from LayoutTests/platform/mac/http/tests/navigation/post-goback1-expected.png.
        * platform/mac/http/tests/navigation/post-basic-expected.txt: Added.
        * platform/mac/http/tests/navigation/post-frames-expected.checksum: Added.
        * platform/mac/http/tests/navigation/post-frames-expected.png: Added.
        * platform/mac/http/tests/navigation/post-frames-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agodoc: Changed the title so lists of contents sort better.
hausmann@webkit.org [Sun, 12 Sep 2010 21:19:15 +0000 (21:19 +0000)]
doc: Changed the title so lists of contents sort better.

Patch by Martin Smith <martin.smith@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

* docs/qtwebkit.qdoc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDoc: More work on the QML documentation.
hausmann@webkit.org [Sun, 12 Sep 2010 21:08:55 +0000 (21:08 +0000)]
Doc: More work on the QML documentation.

Patch by David Boddie <david.boddie@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

* declarative/qdeclarativewebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qml] Ensure WebView gets focus when an editable node is clicked on.
hausmann@webkit.org [Sun, 12 Sep 2010 20:58:30 +0000 (20:58 +0000)]
[Qml] Ensure WebView gets focus when an editable node is clicked on.

Patch by Martin Jones <martin.jones@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

Task-number: QTBUG-13342

* declarative/qdeclarativewebview.cpp:
(GraphicsWebView::mousePressEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDoc: qdoc fixes.
hausmann@webkit.org [Sun, 12 Sep 2010 20:56:59 +0000 (20:56 +0000)]
Doc: qdoc fixes.

Patch by David Boddie <david.boddie@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

* declarative/qdeclarativewebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] fix qt_webkit_version.pri install for in-Qt builds
hausmann@webkit.org [Sun, 12 Sep 2010 20:53:56 +0000 (20:53 +0000)]
[Qt] fix qt_webkit_version.pri install for in-Qt builds

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

Always add the target, even if building inside Qt - as opposed to the
headers and libraries, there are no rules for that coming from
qbase.pri.

Task-number: QTBUG-13306

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore: [Qt] Let QtWebKit inject itself into the qt configuration
hausmann@webkit.org [Sun, 12 Sep 2010 20:50:22 +0000 (20:50 +0000)]
WebCore: [Qt] Let QtWebKit inject itself into the qt configuration

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

i.e., don't explicitly deal with qt_webkit_version.pri outside of the
webkit source directory.

Task-number: QTBUG-12379

* WebCore.pro:

WebKit/qt: [Qt] let WebKit inject itself into the qt configuration

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

Task-number: QTBUG-12379

* qt_webkit_version.pri: Use the faster + instead of *
operator to add webkit to the config.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix group of declarative web view in QML docs.
hausmann@webkit.org [Sun, 12 Sep 2010 20:44:02 +0000 (20:44 +0000)]
[Qt] Fix group of declarative web view in QML docs.

Patch by Martin Smith <martin.smith@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

* declarative/qdeclarativewebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Rebase a bunch of tests after r67200.
hausmann@webkit.org [Sun, 12 Sep 2010 19:08:43 +0000 (19:08 +0000)]
[Qt] Rebase a bunch of tests after r67200.

Reviewed by Antonio Gomes.

* platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
* platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
* platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
* platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Build fix.
hausmann@webkit.org [Sun, 12 Sep 2010 18:40:43 +0000 (18:40 +0000)]
[Qt] Build fix.

* WebCore.pro: Re-add erroneously removed sources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-12 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Sun, 12 Sep 2010 18:35:58 +0000 (18:35 +0000)]
2010-09-12  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Remove Path::closeSubpath() workaround for broken miter joins
        https://bugs.webkit.org/show_bug.cgi?id=45618

        Removed Path::closeCanvasSubpath() and share the logic between Canvas and SVG
        paths. The problem was actually in Qt's path stroker and has been fixed for Qt 4.7.1.

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::closePath):
        * platform/graphics/Path.h:
        * platform/graphics/qt/PathQt.cpp:
2010-09-12  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Remove Path::closeSubpath() workaround for broken miter joins
        https://bugs.webkit.org/show_bug.cgi?id=45618

        Skip fast/canvas/canvas-closePath-single-point.html - it can be unskipped again
        once the bot is upgraded to Qt 4.7.1.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the Gtk and minimal builds.
hausmann@webkit.org [Sun, 12 Sep 2010 18:32:15 +0000 (18:32 +0000)]
Fix the Gtk and minimal builds.

* plugins/PluginView.cpp:
(WebCore::PluginView::npObject): Correct the #ifdefs.
(WebCore::PluginView::bindingInstance): Moved npErr variable
into npObject() function where it is used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Prospective build fix for minimal build.
hausmann@webkit.org [Sun, 12 Sep 2010 18:28:20 +0000 (18:28 +0000)]
[Qt] Prospective build fix for minimal build.

* plugins/PluginView.cpp: Guard newly added function
by ENABLE_NETSCAPE_PLUGIN feature.
(WebCore::PluginView::npObject):
* plugins/PluginView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Partial implementation of Qt bridge using V8 and QtScript.
hausmann@webkit.org [Sun, 12 Sep 2010 18:21:59 +0000 (18:21 +0000)]
[Qt] Partial implementation of Qt bridge using V8 and QtScript.

Reviewed by Andreas Kling.

* Api/qwebelement.cpp:
(QWebElement::evaluateJavaScript): Stub it out for now,
to compile, until we have a conversion path between v8::Object
and QScriptValue.
* Api/qwebframe.cpp:
(QWebFrame::addToJavaScriptWindowObject): Implemented using
few lines of QtScript code.
(QWebFrame::evaluateJavaScript): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add support for binding QtWebKit to a QScriptEngine.
hausmann@webkit.org [Sun, 12 Sep 2010 18:19:53 +0000 (18:19 +0000)]
[Qt] Add support for binding QtWebKit to a QScriptEngine.

Reviewed by Andreas Kling.

The ScriptController owns the V8 context, and this patch
for the Qt build also gives it a QScriptEngine, that has
been instructed to adopt the V8 context.

This is the enabler for the QObject bindings, used in
the API and DRT.

* WebCore.pro:
* bindings/v8/ScriptController.cpp: Include QScriptEngine
for the Qt build, to let the ~ScriptController destructor
find the QScriptEngine destructor (via OwnPtr).
* bindings/v8/ScriptController.h: Declare getters.
* bindings/v8/ScriptControllerQt.cpp: Added.
(WebCore::ScriptController::qtScriptEngine): Implement
engine adoption.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Last bits and pieces for a V8 build.
hausmann@webkit.org [Sun, 12 Sep 2010 18:15:17 +0000 (18:15 +0000)]
[Qt] Last bits and pieces for a V8 build.

Reviewed by Andreas Kling.

When building with V8, get it from QtScript.

* WebCore.pro: Use QtScript, removed non-existant
bridge files from the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add PlatformBridge for V8 build.
hausmann@webkit.org [Sun, 12 Sep 2010 18:12:27 +0000 (18:12 +0000)]
[Qt] Add PlatformBridge for V8 build.

Reviewed by Andreas Kling.

Add the minimalisting platform bridge with the two
methods needed by NPV8Object.cpp.

* WebCore.pro:
* platform/qt/PlatformBridge.h: Added.
* platform/qt/PlatformBridgeQt.cpp: Added.
(WebCore::PlatformBridge::popupsAllowed):
(WebCore::PlatformBridge::pluginScriptableObject):
* plugins/PluginView.cpp: Refactor the plugin object
retrieval code into a separate function, called by
bindingInstance() and PlatformBridge.
(WebCore::PluginView::npObject):
(WebCore::PluginView::bindingInstance):
* plugins/PluginView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the build with V8.
hausmann@webkit.org [Sun, 12 Sep 2010 18:08:22 +0000 (18:08 +0000)]
Fix the build with V8.

Reviewed by Andreas Kling.

This is a temporary kludge until the scriptworld stuff is properly
ported, as part of the upcoming DRT work.

* Api/qwebscriptworld.cpp:
(QWebScriptWorld::QWebScriptWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix compilation of the V8 bindings on X11 with Qt.
hausmann@webkit.org [Sun, 12 Sep 2010 18:08:07 +0000 (18:08 +0000)]
Fix compilation of the V8 bindings on X11 with Qt.

Reviewed by Andreas Kling.

This changes brings the file in sync with its copy in bridge/,
adding additional conflicting X11 keywords to undef. This is
a temporary fix until the file is removed altogether, which is
tracked in https://bugs.webkit.org/show_bug.cgi?id=45617

* bindings/v8/npruntime_internal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Sun, 12 Sep 2010 17:38:08 +0000 (17:38 +0000)]
2010-09-11  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        http/tests/media/text-served-as-text.html failing on Windows (Debug+Release)
        https://bugs.webkit.org/show_bug.cgi?id=45603

        Disable the eat/text components under Windows the same way as we do on the Mac.

        * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
        * platform/graphics/win/QTMovie.cpp:
        * platform/graphics/win/QTMovie.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix compilation of the V8 bindings on X11 with Qt.
hausmann@webkit.org [Sun, 12 Sep 2010 16:57:06 +0000 (16:57 +0000)]
Fix compilation of the V8 bindings on X11 with Qt.

Reviewed by Andreas Kling.

These headers include npruntime, which drag on X11Resources.h, which
among other things #define's None and Boolean. Later on v8.h is included,
which declares these in enums and therefore conflicts. npruntime_internal.h
was introduced exactly to address this problem by including npruntime.h
and undeff'ing the offending constants.

* bindings/v8/V8Helpers.h:
* bindings/v8/V8NPObject.h:
* bindings/v8/V8NPUtils.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-12 Mihai Parparita <mihaip@chromium.org>
dglazkov@chromium.org [Sun, 12 Sep 2010 15:11:24 +0000 (15:11 +0000)]
2010-09-12  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Dimitri Glazkov.

        post-basic.html and post-frames.html in http/tests/navigation should not be pixel tests
        https://bugs.webkit.org/show_bug.cgi?id=45610

        post-basic.html and post-frames.html would be a lot simpler if
        they weren't pixel tests (post-frames.html doesn't even have the right
        expectations for Chromium/Mac). Since all they test is that form
        POSTs are handled correctly, they can just use dumpAsText.

        * http/tests/navigation/post-basic-expected.txt: Added.
        * http/tests/navigation/post-basic.html:
        * http/tests/navigation/post-frames-expected.txt: Added.
        * http/tests/navigation/post-frames.html:
        * http/tests/navigation/resources/page-that-posts.html: Added.
        * http/tests/navigation/resources/postresult.pl:
        * platform/chromium-linux/http/tests/navigation/post-basic-expected.checksum: Removed.
        * platform/chromium-linux/http/tests/navigation/post-basic-expected.png: Removed.
        * platform/chromium-linux/http/tests/navigation/post-frames-expected.checksum: Removed.
        * platform/chromium-linux/http/tests/navigation/post-frames-expected.png: Removed.
        * platform/chromium-win/http/tests/navigation/post-basic-expected.checksum: Removed.
        * platform/chromium-win/http/tests/navigation/post-basic-expected.png: Removed.
        * platform/chromium-win/http/tests/navigation/post-basic-expected.txt: Removed.
        * platform/chromium-win/http/tests/navigation/post-frames-expected.checksum: Removed.
        * platform/chromium-win/http/tests/navigation/post-frames-expected.png: Removed.
        * platform/chromium-win/http/tests/navigation/post-frames-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/mac/http/tests/navigation/post-basic-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/post-basic-expected.png: Removed.
        * platform/mac/http/tests/navigation/post-basic-expected.txt: Removed.
        * platform/mac/http/tests/navigation/post-frames-expected.checksum: Removed.
        * platform/mac/http/tests/navigation/post-frames-expected.png: Removed.
        * platform/mac/http/tests/navigation/post-frames-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGtk build fix.
hausmann@webkit.org [Sun, 12 Sep 2010 14:47:42 +0000 (14:47 +0000)]
Gtk build fix.

Use false instead of False after
http://trac.webkit.org/changeset/67323

* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix the compilation of V8Binding.cpp when compiling with Qt.
hausmann@webkit.org [Sun, 12 Sep 2010 14:28:12 +0000 (14:28 +0000)]
[Qt] Fix the compilation of V8Binding.cpp when compiling with Qt.

Reviewed by Andreas Kling.

* bindings/v8/V8Binding.cpp:
(WebCore::WebCoreStringResource::WebCoreStringResource): In this
line an AtomicString should be converted to a WTF::String. The former
has a conversion operator to the latter, to be able to call the
WTF::String copy constructor. When compiling with Qt, then AtomicString
also has a conversion operator to QString _and_ WTF::String has an
implicit constructor that takes a QString. Therefore the compiler is
confused and not sure which conversion to prefer, the one that isn't
actually a conversion - going to WTF::String - or the conversion from
AtomicString to QString and then constructing the WTF::String from
a QString. To resolve this ambiguity we explicitly call the string()
helper function on the AtomicString, which is equivalent to the
operator WTF::String().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the build without JSC.
hausmann@webkit.org [Sun, 12 Sep 2010 13:57:54 +0000 (13:57 +0000)]
Fix the build without JSC.

Reviewed by Andreas Kling.

Complement http://trac.webkit.org/changeset/59826 and
add missing JSC guards.

* plugins/PluginView.cpp:
(WebCore::PluginView::bindingInstance):
(WebCore::PluginView::privateBrowsingStateChanged):
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformStart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix compilation with V8 and XPath enabled.
hausmann@webkit.org [Sun, 12 Sep 2010 13:57:40 +0000 (13:57 +0000)]
Fix compilation with V8 and XPath enabled.

Reviewed by Andreas Kling.

V8XPathNSResolver.cpp includes V8XPathNSResolver.h,
which includes V8DOMWrapper.h as its first header.
V8DOMWrapper.h then uses V8XPathNSResolver in an inline
function, and gcc doesn't seem to like this, because
at this point the type isn't known ("V8XPathNSResolver
has not been declared"). Forward declaring the type
doesn't help unfortunately: "incomplete type
'WebCore::V8XPathNSResolver' used in nested name
specifier".

To resolve this circular dependency, this patch moves
the inline function into the .cpp file.

* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getXPathNSResolver):
* bindings/v8/V8DOMWrapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][X11] Fix build with V8 against X11 headers.
hausmann@webkit.org [Sun, 12 Sep 2010 13:33:34 +0000 (13:33 +0000)]
[Qt][X11] Fix build with V8 against X11 headers.

Reviewed by Andreas Kling.

Added "True" and "False" to the list of words
we free from the X11 macro jail.

* bridge/npruntime_internal.h:
* config.h: The V8 bindings end up indirectly pulling
in X11 headers and they use True/False. There's no
central header apart from this one, so include the
x11 fixing header here for Qt/X11/V8.
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::paint): Use false instead of False
since False isn't available anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix compilation with V8 and Qt.
hausmann@webkit.org [Sun, 12 Sep 2010 13:28:33 +0000 (13:28 +0000)]
[Qt] Fix compilation with V8 and Qt.

Reviewed by Andreas Kling.

Use WebKit's page cache for ScriptCachedFrameData.

* bindings/v8/ScriptCachedFrameData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix compiler warning.
hausmann@webkit.org [Sun, 12 Sep 2010 13:25:25 +0000 (13:25 +0000)]
Fix compiler warning.

Reviewed by Andreas Kling.

NPClass has 13 members, the last one (NPConstructFunctionPtr construct) wasn't
initialized explicitly.

* bindings/v8/NPV8Object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-12 Mario Sanchez Prada <msanchez@igalia.com>
commit-queue@webkit.org [Sun, 12 Sep 2010 11:16:14 +0000 (11:16 +0000)]
2010-09-12  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] get_n_selections and get_selection fail when selecting text across object boundaries
        https://bugs.webkit.org/show_bug.cgi?id=26991

        Fix AtkText getNSelections() and getSelection() to work properly

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (selectionBelongsToObject): Check that both the selection intersects
        the node AND that the selection is not just "touching" one of the
        boundaries for the selected node. We want to check whether the
        node is actually inside the region, at least partially
        (getSelectionOffsetsForObject): New function to get the start and
        end offsets of a selection for a given accessible object.
        (webkit_accessible_text_get_selection): Return zero when both
        start and end offsets are equal, following the lead of GAIL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sun, 12 Sep 2010 07:37:02 +0000 (07:37 +0000)]
2010-09-11  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Barth.

        Animations don't seem to run in multiple WebKit2 animation tests
        https://bugs.webkit.org/show_bug.cgi?id=42137

        * platform/mac-wk2/Skipped:
        These tests no longer fail, so simply unskip them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Sun, 12 Sep 2010 06:37:59 +0000 (06:37 +0000)]
2010-09-11  Daniel Bates  <dbates@rim.com>

        Attempt to fix the Qt Linux Release build after changeset 67312 <http://trac.webkit.org/changeset/67312>.

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::QWKPage): Add missing ',' in WKPageUIClient initialization list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sun, 12 Sep 2010 04:58:08 +0000 (04:58 +0000)]
2010-09-11  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Anders Carlsson.

        Attempt to fix Windows MiniBrowser build (untested)
        https://bugs.webkit.org/show_bug.cgi?id=45609

        * MiniBrowser/win/BrowserView.cpp:
        (runJavaScriptConfirm):
        (runJavaScriptPrompt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 12 Sep 2010 02:28:10 +0000 (02:28 +0000)]
2010-09-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Make SecurityOrigin::canDisplay an instance function
        https://bugs.webkit.org/show_bug.cgi?id=45219

        This function was secretly an instance function because callers needed
        to pass in a document (which owns a SecurityOrigin).  Only the
        FrameLoader actually needs the method to be static.

        * WebCore.exp.in:
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::isSafeToLoadURL):
        * loader/Cache.cpp:
        (WebCore::Cache::requestResource):
            - Notice that DocLoader::doc() can never be 0.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadFrameRequest):
        * loader/PingLoader.cpp:
        (WebCore::PingLoader::loadImage):
        * loader/SubframeLoader.cpp:
        (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
        (WebCore::SubframeLoader::createJavaAppletWidget):
        (WebCore::SubframeLoader::loadSubframe):
        (WebCore::SubframeLoader::loadPlugin):
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::create):
        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::canDisplay):
        (WebCore::SecurityOrigin::deprecatedCanDisplay):
        * page/SecurityOrigin.h:
        * plugins/PluginView.cpp:
        (WebCore::PluginView::load):
2010-09-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Make SecurityOrigin::canDisplay an instance function
        https://bugs.webkit.org/show_bug.cgi?id=45219

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::loadRequest):
        * Plugins/WebNetscapePluginStream.mm:
        (WebNetscapePluginStream::WebNetscapePluginStream):
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
        * Plugins/WebPluginContainerCheck.mm:
        (-[WebPluginContainerCheck _isForbiddenFileLoad]):
        * WebView/WebFrame.mm:
        (-[WebFrame _allowsFollowingLink:]):
2010-09-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Make SecurityOrigin::canDisplay an instance function
        https://bugs.webkit.org/show_bug.cgi?id=45219

        * WebFrame.cpp:
        (WebFrame::allowsFollowingLink):
2010-09-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Make SecurityOrigin::canDisplay an instance function
        https://bugs.webkit.org/show_bug.cgi?id=45219

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::performFrameLoadURLRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sun, 12 Sep 2010 02:17:42 +0000 (02:17 +0000)]
2010-09-11  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        Remove nonexistent test from skipped list
        https://bugs.webkit.org/show_bug.cgi?id=45608

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix zoom related tests when testing WebKit2.
weinig@apple.com [Sun, 12 Sep 2010 02:15:59 +0000 (02:15 +0000)]
Fix zoom related tests when testing WebKit2.

Reviewed by Maciej Stachowiak.

* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sun, 12 Sep 2010 02:08:33 +0000 (02:08 +0000)]
2010-09-11  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        Skip some new tests that depend on APIs missing from WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=45607

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
weinig@apple.com [Sun, 12 Sep 2010 01:50:30 +0000 (01:50 +0000)]
Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
<rdar://problem/8359252>
https://bugs.webkit.org/show_bug.cgi?id=45605

Reviewed by Dan Bernstein.

WebKit2:

* Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
* UIProcess/API/C/WKPage.h:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::setStatusText):
* UIProcess/WebPageProxy.h:
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::setStatusText):
* UIProcess/WebUIClient.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setStatusbarText):

WebKitTools:

* MiniBrowser/mac/BrowserWindowController.m:
(setStatusText):
(contentsSizeChanged):
(-[BrowserWindowController awakeFromNib]):
* MiniBrowser/win/BrowserView.cpp:
(runJavaScriptConfirm):
(runJavaScriptPrompt):
(setStatusText):
(contentsSizeChanged):
(BrowserView::create):
* WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
(WTR::TestController::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd callback mechanism for the getting the source of a frame
weinig@apple.com [Sun, 12 Sep 2010 01:17:52 +0000 (01:17 +0000)]
Add callback mechanism for the getting the source of a frame
<rdar://problem/8364681>
https://bugs.webkit.org/show_bug.cgi?id=45604

Reviewed by Dan Bernstein.

WebKit2:

* Shared/CoreIPCSupport/WebPageMessageKinds.h:
* Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageGetSourceForFrame):
(callGetSourceForFrameBlockBlockAndDispose):
(WKPageGetSourceForFrame_b):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::getSourceForFrame):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didGetSourceForFrame):
(WebKit::WebPageProxy::processDidExit):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::source):
* WebProcess/WebPage/WebFrame.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getSourceForFrame):
(WebKit::WebPage::didReceiveMessage):
* WebProcess/WebPage/WebPage.h:

WebKitTools:

Add ability to dump the main frame's source to the console.

* MiniBrowser/mac/BrowserWindowController.h:
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController dumpSourceToConsole:]):
* MiniBrowser/mac/MainMenu.xib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 11 Sep 2010 23:25:17 +0000 (23:25 +0000)]
2010-09-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Remove unneeded Empty Queue messages
        https://bugs.webkit.org/show_bug.cgi?id=45602

        We already have a /gc job to delete these.
        recentstatus.py is already smart enough to use the
        most recent of the workitems last update or the most recent status,
        so removing these should not change the _last_status_date() return
        value more than a few milliseconds.

        These messages just spam the recent status log.

        * Scripts/webkitpy/tool/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
hausmann@webkit.org [Sat, 11 Sep 2010 19:15:45 +0000 (19:15 +0000)]
Unreviewed.

[Qt] Trivial V8 build fix.

* WebCore.pri: Add storage, workers and css to the include paths for the
JS code generator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Sat, 11 Sep 2010 18:28:51 +0000 (18:28 +0000)]
2010-09-11  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] V8 port: Fix "WTF::String::utf8" returns incomplete type WTF::CString
        https://bugs.webkit.org/show_bug.cgi?id=45157

        Include CString.h where necessary. Chromium builds would get it from
        KURLGooglePrivate.h so this is only an issue for Qt + V8.

        * bindings/v8/V8Proxy.cpp:
        * inspector/InspectorDebuggerAgent.cpp:
        * inspector/InspectorProfilerAgent.cpp:
        * plugins/PluginDatabase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] V8 port: webkit project files changes
hausmann@webkit.org [Sat, 11 Sep 2010 18:22:14 +0000 (18:22 +0000)]
[Qt] V8 port: webkit project files changes
https://bugs.webkit.org/show_bug.cgi?id=45140

Reviewed by Andreas Kling.

.:

* WebKit.pro: Don't compile JavaScriptCore and jsc when
building with v8.

WebCore:

* WebCore.pro: Removed unecessary common.pri inclusion from earlier patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJavaScriptCore: [Qt] V8 port: webcore project files changes
hausmann@webkit.org [Sat, 11 Sep 2010 18:11:05 +0000 (18:11 +0000)]
JavaScriptCore: [Qt] V8 port: webcore project files changes
https://bugs.webkit.org/show_bug.cgi?id=45141

Reviewed by Andreas Kling.

* JavaScriptCore.pro: Moved wtf specific files to wtf.pri,
so that they can also be used from WebCore.pro for v8 builds.
* wtf/wtf.pri: Added.

WebCore: [Qt] V8 port: webcore project files changes
https://bugs.webkit.org/show_bug.cgi?id=45141

Reviewed by Andreas Kling.

Modify webcore project files to include V8 javascript engine. By default disabled.

* WebCore.pri:
* WebCore.pro:
* features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Sat, 11 Sep 2010 18:09:54 +0000 (18:09 +0000)]
2010-09-11  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Simon Hausmann.

        Web Inspector: Include CString.h in generated files

        This is necessary for generated code that uses the CString
        returned by String::utf8() (from generateBackendDispatcher)

        Chromium builds already get CString.h from KURLGooglePrivate.h
        so this issue only occurs when building Qt against V8.

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Sat, 11 Sep 2010 17:44:17 +0000 (17:44 +0000)]
2010-09-11  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] V8 port for Qt platform: Qt WebCoreSupport changes
        https://bugs.webkit.org/show_bug.cgi?id=45149

        Original patch by Vlad Burlik <volodimir.burlik@nokia.com>

        Implemented the V8 specifics needed in DumpRenderTreeSupportQt and
        FrameLoaderClientQt.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::javaScriptObjectsCount):
        (DumpRenderTreeSupportQt::garbageCollectorCollect):
        (DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread):
        (DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::didCreateScriptContextForFrame):
        (WebCore::FrameLoaderClientQt::didDestroyScriptContextForFrame):
        (WebCore::FrameLoaderClientQt::didCreateIsolatedScriptContext):
        (WebCore::FrameLoaderClientQt::createDocumentLoader):
        * WebCoreSupport/FrameLoaderClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Sat, 11 Sep 2010 17:42:29 +0000 (17:42 +0000)]
2010-09-11  Martin Robinson  <mrobinson@igalia.com>

        Add a platform-specific result after r67281.

        * platform/gtk/fast/dynamic/first-letter-display-change-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Mihai Parparita <mihaip@chromium.org>
commit-queue@webkit.org [Sat, 11 Sep 2010 17:09:07 +0000 (17:09 +0000)]
2010-09-11  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        Fix Python exception when generating synthetic patch IDs
        https://bugs.webkit.org/show_bug.cgi?id=45592

        Can't concatenate strings and numbers directly.

        * QueueStatusServer/handlers/queuestatus.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Vlad Burlik <volodimir.burlik@nokia.com>
andreas.kling@nokia.com [Sat, 11 Sep 2010 17:06:57 +0000 (17:06 +0000)]
2010-09-11  Vlad Burlik  <volodimir.burlik@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] V8 port for QT platform: QT API implementation changes
        https://bugs.webkit.org/show_bug.cgi?id=45148

        V8 Implementation of QWebFrame::addToJavaScriptWindowObject()
        and QWebFrame::evaluateJavaScript()

        * Api/qwebelement.cpp:
        (setupScriptContext): JSC and V8 variations
        (QWebElement::evaluateJavaScript):
        * Api/qwebelement.h:
        * Api/qwebframe.cpp: QObject injection to V8 world
        (QWebFrame::addToJavaScriptWindowObject):
        (QWebFrame::evaluateJavaScript):
        * Api/qwebpage.cpp: Use ScriptController type definitions instead of direct references to JSC or V8
        (QWebPagePrivate::QWebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 11 Sep 2010 16:25:58 +0000 (16:25 +0000)]
2010-09-11  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Make introspection work with g-o-i 0.9.5
        https://bugs.webkit.org/show_bug.cgi?id=45590

        Bump required gobject-introspection version to 0.9.5.

        * configure.ac:

WebKit/gtk:

2010-09-11  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Make introspection work with g-o-i 0.9.5
        https://bugs.webkit.org/show_bug.cgi?id=45590

        Use new type syntax and bump version number of the gir file.

        * JSCore.gir.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 11 Sep 2010 16:19:30 +0000 (16:19 +0000)]
2010-09-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        chromium fast/dom/replaceChild.html regression by r67182
        https://bugs.webkit.org/show_bug.cgi?id=45527

        Turns out this is a progression!  Our new images
        match minefield (and sanity).  The old image had a
        border drawn which should have been removed when the
        iframe was replaced.

        Other platforms may need to update their results as well.

        * platform/mac/fast/dom/replaceChild-expected.checksum:
        * platform/mac/fast/dom/replaceChild-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sat, 11 Sep 2010 16:09:25 +0000 (16:09 +0000)]
2010-09-11  Robert Hogan  <robert@webkit.org>

        Unreviewed, unskip passing test.

        Test fixed by http://trac.webkit.org/changeset/56511

        See https://bugs.webkit.org/show_bug.cgi?id=36492

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Sat, 11 Sep 2010 15:04:58 +0000 (15:04 +0000)]
2010-09-11  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Fix EFL build after r67274
        https://bugs.webkit.org/show_bug.cgi?id=45584

        Remove include of ZoomMode.h and change setZoomFactor and zoomFactor
        to proper apis chaged by r67264.

        * ewk/ewk_frame.cpp:
        (ewk_frame_zoom_get):
        (ewk_frame_zoom_set):
        (ewk_frame_zoom_text_only_get):
        (ewk_frame_zoom_text_only_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=45587
adele@apple.com [Sat, 11 Sep 2010 13:20:26 +0000 (13:20 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=45587
Move line clamp code to its own function.

Reviewed by Sam Weinig.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutVerticalBox):
(WebCore::RenderFlexibleBox::applyLineClamp):
* rendering/RenderFlexibleBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Mihai Parparita <mihaip@chromium.org>
commit-queue@webkit.org [Sat, 11 Sep 2010 10:06:21 +0000 (10:06 +0000)]
2010-09-11  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        Group statuses in queue status by patch ID
        https://bugs.webkit.org/show_bug.cgi?id=45588

        Group statuses by patch ID so that the status page is easier
        to scan.

        * QueueStatusServer/handlers/queuestatus.py:
        * QueueStatusServer/stylesheets/dashboard.css:
        (.status-group):
        (.status-bug):
        (.status-group ul):
        (.status-group ul li):
        (.status-group ul li:hover):
        (.status-cell):
        (.status-cell:hover):
        (.status-cell.pass):
        (.status-cell.fail):
        (.status-cell.pending):
        (.status-cell.error):
        * QueueStatusServer/templates/dashboard.html:
        * QueueStatusServer/templates/queuestatus.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Mihai Parparita <mihaip@chromium.org>
commit-queue@webkit.org [Sat, 11 Sep 2010 09:48:54 +0000 (09:48 +0000)]
2010-09-11  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
        https://bugs.webkit.org/show_bug.cgi?id=45479

        Remove tests from Chromium expectations that now pass. Add
        Chromium/Linux expectations for the script test, since it reports a
        different MIME type (application/javascript vs.
        application/x-javascript).

        * platform/chromium-linux/fast/dom/HTMLLinkElement/prefetch-expected.txt: Removed.
        * platform/chromium-linux/fast/preloader/script-expected.txt: Added.
        * platform/chromium-mac/fast/dom/HTMLLinkElement/prefetch-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:
2010-09-11  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
        https://bugs.webkit.org/show_bug.cgi?id=45479

        Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
        implementation in ResourceLoadDelegate in the Mac port).

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::dumpResourceResponseMIMETypes):
        (LayoutTestController::reset):
        * DumpRenderTree/chromium/LayoutTestController.h:
        (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
        (LayoutTestController::shouldDumpResourceResponseMIMETypes):
        * DumpRenderTree/chromium/TestShell.h:
        (TestShell::shouldDumpResourceResponseMIMETypes):
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::didReceiveResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Tony Chang <tony@chromium.org>
tony@chromium.org [Sat, 11 Sep 2010 09:32:12 +0000 (09:32 +0000)]
2010-09-11  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] remove passing test svg/custom/transform-ignore-after-invalid.svg
        https://bugs.webkit.org/show_bug.cgi?id=45579

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Mihai Parparita <mihaip@chromium.org>
commit-queue@webkit.org [Sat, 11 Sep 2010 08:59:57 +0000 (08:59 +0000)]
2010-09-11  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        URIs in styles created via innerHTML are not resolved against the document's base URI
        https://bugs.webkit.org/show_bug.cgi?id=45565

        Add test to read back the background image URL from an element that was
        created via innerHTML (reduction of http://crbug.com/55023).

        * fast/innerHTML/innerHTML-uri-resolution-expected.txt: Added.
        * fast/innerHTML/innerHTML-uri-resolution.html: Added.
2010-09-11  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        URIs in styles created via innerHTML are not resolved against the document's base URI
        https://bugs.webkit.org/show_bug.cgi?id=45565

        The dummy document used for fragment parsing created by
        FragmentParsingContext should use the base URI of the fragment's
        document. Since (HTML)Document doesn't expose a setter for the base URI
        (and shouldn't), we allow it to be set by the constructor/create
        function.

        Also remove some obsolete code that references the legacy tree builder
        from HTMLElement that I happened to notice.

        Test: fast/innerHTML/innerHTML-uri-resolution.html

        * dom/Document.cpp:
        (WebCore::Document::Document):
        * dom/Document.h:
        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::HTMLDocument):
        * html/HTMLDocument.h:
        (WebCore::HTMLDocument::create):
        * html/HTMLElement.cpp:
        (WebCore::createFragmentFromSource):
        (WebCore::HTMLElement::setInnerHTML):
        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd NetworkingContext to avoid layer violations https://bugs.webkit.org/show_bug...
diegohcg@webkit.org [Sat, 11 Sep 2010 07:54:15 +0000 (07:54 +0000)]
Add NetworkingContext to avoid layer violations https://bugs.webkit.org/show_bug.cgi?id=42292

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2010-09-10
Reviewed by Darin Adler.

WebCore:

Activate NetworkingContext:

Since the ResourceHandle::create, ResourceHandle::start and
ResourceHandle::loadResourceSynchronously API's were modified,
having their Frame* parameter substituted by a NetworkingContext*,
all implementations of them were also modified.
This patch also modifies all functions that were calling the above
ones.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadResourceSynchronously):
* loader/FrameLoader.h:
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::loadNow):
* loader/PingLoader.cpp:
(WebCore::PingLoader::PingLoader):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::load):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::createResourceHandle):
* loader/icon/IconFetcher.cpp:
(WebCore::IconFetcher::loadEntry):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcStart):
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::create):
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
* platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::willLoadFromCache):
(WebCore::ResourceHandle::loadResourceSynchronously):
* platform/network/soup/ResourceHandleSoup.cpp:
* platform/network/win/ResourceHandleWin.cpp:
(WebCore::ResourceHandle::start):

WebKit/chromium:

* src/ResourceHandle.cpp:
(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

WebKit/gtk:

* webkit/webkitdownload.cpp:
(webkit_download_start):
* webkit/webkitprivate.cpp:
(currentToplevelCallback):

WebKit/win:

* WebCoreSupport/WebFrameNetworkingContext.cpp:
(WebFrameNetworkingContext::blockedError):
* WebCoreSupport/WebFrameNetworkingContext.h:

WebKit2:

* WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.cpp:
* WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h:
(WebFrameNetworkingContext::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 11 Sep 2010 07:23:45 +0000 (07:23 +0000)]
2010-09-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        queues.webkit.org should expose /remote_api for data upload/download
        https://bugs.webkit.org/show_bug.cgi?id=45559

        * QueueStatusServer/app.yaml:
         - /remote_api is a standard app-engine service which allows use of
           the bulk uploader for data upload/download.  Exposing this
           (for admin access only) allows us to use

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 yi shen <yi.4.shen@nokia.com>
commit-queue@webkit.org [Sat, 11 Sep 2010 07:07:00 +0000 (07:07 +0000)]
2010-09-10  yi shen  <yi.4.shen@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] selected text gets deleted when qgraphicswebview losts focus
        https://bugs.webkit.org/show_bug.cgi?id=45539

        * Api/qwebpage.cpp:
        (QWebPagePrivate::inputMethodEvent):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNo review; build fix only.
jer.noble@apple.com [Sat, 11 Sep 2010 06:52:42 +0000 (06:52 +0000)]
No review; build fix only.

<CoreGraphics/CGAffineTransform.h> isn't on the build bots either.  Wrap
all references to m_movieTransform in #if USE(ACCELERATED_COMPOSITING) guards.

* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::naturalSize):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveAndResetMovieTransform):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd zoom support to WebKit2 API
weinig@apple.com [Sat, 11 Sep 2010 06:45:41 +0000 (06:45 +0000)]
Add zoom support to WebKit2 API
<rdar://problem/7660657>
https://bugs.webkit.org/show_bug.cgi?id=45585

Reviewed by Dan Bernstein.

WebKit2:

- Add UIProcess API for setting zoom factors.
- Change bundle zoom API to be in terms of doubles
  for consistency.

* Shared/CoreIPCSupport/WebPageMessageKinds.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageGetTextZoomFactor):
(WKPageSetTextZoomFactor):
(WKPageGetPageZoomFactor):
(WKPageSetPageZoomFactor):
(WKPageSetPageAndTextZoomFactors):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setTextZoomFactor):
(WebKit::WebPageProxy::setPageZoomFactor):
(WebKit::WebPageProxy::setPageAndTextZoomFactors):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::textZoomFactor):
(WebKit::WebPageProxy::pageZoomFactor):
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageGetTextZoomFactor):
(WKBundlePageSetTextZoomFactor):
(WKBundlePageGetPageZoomFactor):
(WKBundlePageSetPageZoomFactor):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::textZoomFactor):
(WebKit::WebPage::setTextZoomFactor):
(WebKit::WebPage::pageZoomFactor):
(WebKit::WebPage::setPageZoomFactor):
(WebKit::WebPage::setPageAndTextZoomFactors):
(WebKit::WebPage::didReceiveMessage):
* WebProcess/WebPage/WebPage.h:

WebKitTools:

- Add zoom options to MiniBrowser that mimic Safari's options using
  the new WebKit2 zoom APIs.
- Switch uses of float for the zoom APIs to use double.

* MiniBrowser/mac/BrowserWindowController.h:
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController initWithPageNamespace:]):
(-[BrowserWindowController validateMenuItem:]):
(-[BrowserWindowController validateUserInterfaceItem:]):
(-[BrowserWindowController currentZoomFactor]):
(-[BrowserWindowController setCurrentZoomFactor:]):
(-[BrowserWindowController canZoomIn]):
(-[BrowserWindowController zoomIn:]):
(-[BrowserWindowController canZoomOut]):
(-[BrowserWindowController zoomOut:]):
(-[BrowserWindowController canResetZoom]):
(-[BrowserWindowController resetZoom:]):
(-[BrowserWindowController toggleZoomMode:]):
* MiniBrowser/mac/MainMenu.xib:
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNo review; build fix only.
jer.noble@apple.com [Sat, 11 Sep 2010 06:36:16 +0000 (06:36 +0000)]
No review; build fix only.

<CoreGraphics/CGFloat.h> does not exist on the build bots.  Replace
instances of CGFAbs() with abs().

* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::naturalSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Sat, 11 Sep 2010 06:24:36 +0000 (06:24 +0000)]
2010-09-10  Jer Noble  <jer.noble@apple.com>

        Reviewed by Simon Fraser.

        Movies with track or movie matrices don't display in <video> elements (Safari 5/Windows)
        https://bugs.webkit.org/show_bug.cgi?id=45333

        The rootChild layer must be set as flipped, otherwise transformed movies will appear
        incorrectly rotated.

        * FullscreenVideoController.cpp:
        (FullscreenVideoController::enterFullscreen):
2010-09-10  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/8414282> Can’t dynamically change first-letter to/from floating

        Test: fast/dynamic/first-letter-display-change.html

        * rendering/RenderBlock.cpp:
        (WebCore::styleForFirstLetter): Factored this helper function out.
        (WebCore::RenderBlock::updateFirstLetter): Renamed variables so that the
        “update style” and “create new” branches use the same terminology. In the
        update case, if the style change requires a new renderer, handle it.
        * rendering/RenderTextFragment.h:
        (WebCore::toRenderTextFragment): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Alexey Proskuryakov <ap@apple.com>
ap@apple.com [Sat, 11 Sep 2010 06:19:18 +0000 (06:19 +0000)]
2010-09-10  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=45563
        Assertion failure: useTransforms when scrolling to an SVG element

        This has been indirectly fixed in r63633, just adding a test.

        * svg/custom/scroll-to-svg-element-assertion-expected.txt: Added.
        * svg/custom/scroll-to-svg-element-assertion.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix chromium build.
weinig@apple.com [Sat, 11 Sep 2010 05:57:02 +0000 (05:57 +0000)]
Fix chromium build.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setZoomLevel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sat, 11 Sep 2010 05:55:46 +0000 (05:55 +0000)]
2010-09-10  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Fix crash in DRT in standalone mode

        https://bugs.webkit.org/show_bug.cgi?id=45454

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8414282> Can’t dynamically change first-letter to/from floating
mitz@apple.com [Sat, 11 Sep 2010 05:55:18 +0000 (05:55 +0000)]
<rdar://problem/8414282> Can’t dynamically change first-letter to/from floating

Reviewed by Darin Adler.

WebCore:

Test: fast/dynamic/first-letter-display-change.html

* rendering/RenderBlock.cpp:
(WebCore::styleForFirstLetter): Factored this helper function out.
(WebCore::RenderBlock::updateFirstLetter): Renamed variables so that the
“update style” and “create new” branches use the same terminology. In the
update case, if the style change requires a new renderer, handle it.
* rendering/RenderTextFragment.h:
(WebCore::toRenderTextFragment): Added.

LayoutTests:

* fast/dynamic/first-letter-display-change-expected.checksum: Added.
* fast/dynamic/first-letter-display-change-expected.png: Added.
* fast/dynamic/first-letter-display-change-expected.txt: Added.
* fast/dynamic/first-letter-display-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 11 Sep 2010 05:50:54 +0000 (05:50 +0000)]
2010-09-10  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed, speculative chromium build fix.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setZoomLevel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 11 Sep 2010 05:31:02 +0000 (05:31 +0000)]
2010-09-10  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed.

        Added editing/style/style-3690704-fix.html to the gtk's skipped list
        since the test requires editing delegates, which hasn't been implemented in gtk.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Balazs Kelemen <kb@inf.u-szeged.hu>
commit-queue@webkit.org [Sat, 11 Sep 2010 05:21:17 +0000 (05:21 +0000)]
2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Andreas Kling.

        Application cache directory should be checked before sending to the web process
        https://bugs.webkit.org/show_bug.cgi?id=45462

        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::WebProcessProxy): Check the return value of
        m_context->applicationCacheDirectoy() to avoid sending a null string
        to the web process what makes it asserting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 11 Sep 2010 05:08:40 +0000 (05:08 +0000)]
2010-09-10  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        editing/inserting/insert-3659587-fix.html and editing/style/style-3690704-fix.html should use runDumpAsTextEditingTest
        https://bugs.webkit.org/show_bug.cgi?id=45578

        Modified insert-3659587-fix.html and style-3690704-fix.html to use runDumpAsTextEditingTest().

        * editing/inserting/insert-3659587-fix-expected.txt: Added.
        * editing/inserting/insert-3659587-fix.html:
        * editing/style/style-3690704-fix-expected.txt: Added.
        * editing/style/style-3690704-fix.html:
        * platform/chromium-linux/editing/inserting/insert-3659587-fix-expected.checksum: Removed.
        * platform/chromium-linux/editing/inserting/insert-3659587-fix-expected.png: Removed.
        * platform/chromium-linux/editing/style/style-3690704-fix-expected.checksum: Removed.
        * platform/chromium-linux/editing/style/style-3690704-fix-expected.png: Removed.
        * platform/chromium-win/editing/inserting/insert-3659587-fix-expected.checksum: Removed.
        * platform/chromium-win/editing/inserting/insert-3659587-fix-expected.png: Removed.
        * platform/chromium-win/editing/inserting/insert-3659587-fix-expected.txt: Removed.
        * platform/chromium-win/editing/style/style-3690704-fix-expected.checksum: Removed.
        * platform/chromium-win/editing/style/style-3690704-fix-expected.png: Removed.
        * platform/chromium-win/editing/style/style-3690704-fix-expected.txt: Removed.
        * platform/gtk/editing/inserting/insert-3659587-fix-expected.txt: Removed.
        * platform/gtk/editing/style/style-3690704-fix-expected.txt: Removed.
        * platform/mac/editing/inserting/insert-3659587-fix-expected.checksum: Removed.
        * platform/mac/editing/inserting/insert-3659587-fix-expected.png: Removed.
        * platform/mac/editing/inserting/insert-3659587-fix-expected.txt: Removed.
        * platform/mac/editing/style/style-3690704-fix-expected.checksum: Removed.
        * platform/mac/editing/style/style-3690704-fix-expected.png: Removed.
        * platform/mac/editing/style/style-3690704-fix-expected.txt: Removed.
        * platform/qt/editing/inserting/insert-3659587-fix-expected.txt: Removed.
        * platform/qt/editing/style/style-3690704-fix-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Qt build.
weinig@apple.com [Sat, 11 Sep 2010 04:11:47 +0000 (04:11 +0000)]
Fix Qt build.

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix GTK build.
weinig@apple.com [Sat, 11 Sep 2010 04:09:12 +0000 (04:09 +0000)]
Fix GTK build.

* webkit/webkitwebview.cpp:
(webkit_web_view_set_full_content_zoom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unnecessary constraint in WebCore of choosing either text zoom or full page...
weinig@apple.com [Sat, 11 Sep 2010 04:01:43 +0000 (04:01 +0000)]
Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
Precursor to <rdar://problem/7660657>
https://bugs.webkit.org/show_bug.cgi?id=45522

Reviewed by Darin Adler.

WebCore:

* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Remove ZoomMode.h

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
Remove uses of shouldApplyTextZoom(), it had turned into just a compare to 1.0f.

* html/HTMLBodyElement.cpp:
(WebCore::adjustForZoom):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):
Convert these to use the explicit pageZoomFactor() function, it made no sense for text zoom
anyway.

* page/Frame.h:
Remove include of ZoomMode.h

* page/FrameView.cpp:
(WebCore::parentPageZoomFactor):
(WebCore::parentTextZoomFactor):
(WebCore::FrameView::FrameView):
(WebCore::FrameView::setPageZoomFactor):
(WebCore::FrameView::setTextZoomFactor):
(WebCore::FrameView::setPageAndTextZoomFactors):
* page/FrameView.h:
(WebCore::FrameView::pageZoomFactor):
(WebCore::FrameView::textZoomFactor):
Change FrameView to store two values for zoom, one for page zoom and one for text zoom.

* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
Removed zoom mode.

* page/ZoomMode.h: Removed.

* rendering/RenderView.cpp:
(WebCore::RenderView::zoomFactor):
Remove now unnecessary call to shouldApplyPageZoom since it will be 1 if it should
be ignored.

* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::setCurrentScale):
Use explicit setPageZoomFactor function.

WebKit/chromium:

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::createPlugin):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setZoomLevel):
* src/WebViewImpl.h:
(WebKit::WebViewImpl::zoomTextOnly):
Move tracking of text only zoom here from WebCore.

WebKit/gtk:

* webkit/webkitwebview.cpp:
(webkit_web_view_get_zoom_level):
(webkit_web_view_apply_zoom_level):
(webkit_web_view_set_full_content_zoom):

WebKit/mac:

* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):
(-[WebView _setZoomMultiplier:isTextOnly:]):
(-[WebView _realZoomMultiplierIsTextOnly]):
* WebView/WebViewData.h:
* WebView/WebViewData.mm:
(-[WebViewPrivate init]):
Move tracking of text only zoom here from WebCore.

WebKit/qt:

* Api/qwebframe.cpp:
(QWebFrame::setTextSizeMultiplier):
(QWebFrame::textSizeMultiplier):
(QWebFrame::setZoomFactor):
(QWebFrame::zoomFactor):
* Api/qwebframe_p.h:
(QWebFramePrivate::QWebFramePrivate):
Move tracking of text only zoom here from WebCore.

WebKit/win:

* WebFrame.cpp:
* WebFrame.h:
Remove dead code.

* WebView.cpp:
(WebView::WebView):
(WebView::setZoomMultiplier):
(WebView::zoomMultiplier):
(WebView::canMakeTextLarger):
(WebView::makeTextLarger):
(WebView::canMakeTextSmaller):
(WebView::makeTextSmaller):
(WebView::notifyPreferencesChanged):
* WebView.h:
Move tracking of text only zoom here from WebCore.

WebKit2:

Now that WebCore doesn't require a mode, change the bundle API for zoom to not
require one either.

* WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageStopLoading):
(WKBundlePageGetTextZoomFactor):
(WKBundlePageSetTextZoomFactor):
(WKBundlePageGetPageZoomFactor):
(WKBundlePageSetPageZoomFactor):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::textZoomFactor):
(WebKit::WebPage::setTextZoomFactor):
(WebKit::WebPage::pageZoomFactor):
(WebKit::WebPage::setPageZoomFactor):
* WebProcess/WebPage/WebPage.h:

WebKitTools:

Update for changes to the Bundle API to allow separate control of page and text zoom
levels.

* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Balazs Kelemen <kb@inf.u-szeged.hu>
commit-queue@webkit.org [Sat, 11 Sep 2010 03:59:32 +0000 (03:59 +0000)]
2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Andreas Kling.

        [Qt] Implement port specific part of WebKit::InjectedBundle
        https://bugs.webkit.org/show_bug.cgi?id=45541

        * WebProcess/InjectedBundle/InjectedBundle.h: Typedef PlatformBundle as QLibrary for qt.
        * WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp:
        (WebKit::InjectedBundle::load): Implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Sat, 11 Sep 2010 03:42:09 +0000 (03:42 +0000)]
2010-09-10  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Support click event for notifications
        https://bugs.webkit.org/show_bug.cgi?id=44836

        * fast/notifications/notifications-click-event-expected.txt:
        * platform/qt/Skipped:
2010-09-10  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Support click event for notifications
        https://bugs.webkit.org/show_bug.cgi?id=44836

        Propagate click events to JavaScript from either the
        platform plugn or from QSystemTrayIcon.
        Also added the method NotificationWrapper::openerPageUrl so that
        if the platform plugin can reopen the page that created the
        notification directly, when the user clicks the notification.

        Added DumpRenderTreeSupportQt::simulateDesktopNotificationClick
        for testing purpose.

        * Api/qwebkitplatformplugin.h:
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::simulateDesktopNotificationClick):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
        * WebCoreSupport/NotificationPresenterClientQt.cpp:
        (WebCore::NotificationWrapper::openerPageUrl):
        (WebCore::NotificationWrapper::notificationClicked):
        (WebCore::NotificationPresenterClientQt::displayNotification):
        (WebCore::NotificationPresenterClientQt::notificationClicked):
        * WebCoreSupport/NotificationPresenterClientQt.h:
        * examples/platformplugin/WebNotificationPresenter.cpp:
        (WebNotificationWidget::event):
        * examples/platformplugin/WebNotificationPresenter.h:
        (WebNotificationPresenter::WebNotificationPresenter):
        * examples/platformplugin/qwebkitplatformplugin.h:
2010-09-10  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Support click event for notifications
        https://bugs.webkit.org/show_bug.cgi?id=44836

        Add support for simulateDesktopNotificationClick by calling
        back to DumpRenderTreeSupportQt.cpp.

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::simulateDesktopNotificationClick):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Fridrich Strba <fridrich.strba@bluewin.ch>
commit-queue@webkit.org [Sat, 11 Sep 2010 03:25:05 +0000 (03:25 +0000)]
2010-09-10  Fridrich Strba  <fridrich.strba@bluewin.ch>

        Reviewed by Andreas Kling.

        Add a define missing when building with glib unicode backend
        https://bugs.webkit.org/show_bug.cgi?id=45544

        * wtf/unicode/glib/UnicodeMacrosFromICU.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Mario Sanchez Prada <msanchez@igalia.com>
commit-queue@webkit.org [Sat, 11 Sep 2010 02:47:17 +0000 (02:47 +0000)]
2010-09-10  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Fix warnings because of bad assignments in testatk.c
        https://bugs.webkit.org/show_bug.cgi?id=45538

        Use AtkObject and AtkText instances properly in the code.

        * tests/testatk.c:
        (testWebkitAtkListsOfItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Mihai Parparita <mihaip@chromium.org>
abarth@webkit.org [Sat, 11 Sep 2010 02:33:08 +0000 (02:33 +0000)]
2010-09-10  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Eric Seidel.

        Update queue status when patches fail their first land attempt
        https://bugs.webkit.org/show_bug.cgi?id=45583

        Add a few more _update_status calls to make it more obvious if a patch is
        being retried because tests failed.

        * Scripts/webkitpy/tool/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 11 Sep 2010 02:28:20 +0000 (02:28 +0000)]
2010-09-10  Adam Barth  <abarth@webkit.org>

        Attempt to fix the failign Qt tests.  This patch adapts code from
        Chromium.  The long-term fix is to remove the need for this code, but
        that's a bit too complicated for a buildfix patch.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
        (WebCore::FrameLoaderClientQt::makeRepresentation):
        (WebCore::FrameLoaderClientQt::revertToProvisionalState):
        (WebCore::FrameLoaderClientQt::finishedLoading):
        * WebCoreSupport/FrameLoaderClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Sat, 11 Sep 2010 02:27:14 +0000 (02:27 +0000)]
2010-09-10  Ryuan Choi  <ryuan.choi@samsung.com>

        Unreviewed build fix for EFL.

        [EFL] REGRESSION(67167) build break because of newly added JSBindingState.cpp
        https://bugs.webkit.org/show_bug.cgi?id=45537

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Balazs Kelemen <kb@inf.u-szeged.hu>
commit-queue@webkit.org [Sat, 11 Sep 2010 01:56:49 +0000 (01:56 +0000)]
2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Andreas Kling.

        [Qt] MiniBrowser crashes with multiply windows when closing one of them
        https://bugs.webkit.org/show_bug.cgi?id=45536

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::~QWKPage): Do not call WKPageTerminate since this is designed
        to terminate the web process. We are correctly detaching the page without
        this call anyway.
2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Andreas Kling.

        [Qt] MiniBrowser crashes with multiply windows when closing one of them
        https://bugs.webkit.org/show_bug.cgi?id=45536

        * MiniBrowser/qt/BrowserView.cpp:
        (BrowserView::BrowserView): Reference the context instead of adopting it
        because it can be shared across different views.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJavaScriptCore: Refactor JavaScriptCore memory statistics so that WebKit doesn't...
slewis@apple.com [Sat, 11 Sep 2010 01:40:45 +0000 (01:40 +0000)]
JavaScriptCore: Refactor JavaScriptCore memory statistics so that WebKit doesn't need to know
about the JIT and other implementation details of JavaScriptCore.  Necessary
to fix PPC build.

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=45528

* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/MemoryStatistics.cpp: Added.
(JSC::memoryStatistics):
* runtime/MemoryStatistics.h: Added.

WebKit/mac: Refactor JavaScriptCore memory statistics so that WebKit doesn't need to know about the JIT and
other implementation details of JavaScriptCore.  Necessary to fix PPC build.

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=45528

* Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics memoryStatistics]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 11 Sep 2010 01:28:15 +0000 (01:28 +0000)]
2010-09-10  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
        https://bugs.webkit.org/show_bug.cgi?id=45582

        * WebKit.xcodeproj/project.pbxproj: Added WebDashboardRegion.h/mm and
        also gave the header private visibility so it will get installed in the
        PrivateHeaders directory.
2010-09-10  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
        https://bugs.webkit.org/show_bug.cgi?id=45582

        * MigrateHeaders.make: Removed WebDashboardRegion.h from the set of header to copy.

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::dashboardRegionsChanged): Changed this to call
        -[WebView _dashboardRegions] so we don't have two copies of that code.

        * WebView/WebDashboardRegion.h: Copied from WebCore/page/mac/WebDashboardRegion.h.
        * WebView/WebDashboardRegion.mm: Copied from WebCore/page/mac/WebDashboardRegion.m.

        * WebView/WebView.mm:
        (-[WebView _dashboardRegions]): Moved the code from Frame::dashboardRegions here.
2010-09-10  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
        https://bugs.webkit.org/show_bug.cgi?id=45582

        * WebCore.exp.in: Updated.

        * WebCore.xcodeproj/project.pbxproj: Removed WebDashboardRegion.h/m.
        * page/mac/WebDashboardRegion.h: Removed.
        * page/mac/WebDashboardRegion.m: Removed.

        * page/Frame.h: Removed unneeded #if. Removed dashboardRegionsDictionary function, now
        handled in WebKit. Removed searchForNSLabelsAboveCell function, which had become dead code.
        * page/mac/FrameMac.mm: Ditto. Also tweaked a place that said "int unsigned".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake middle clicks not fire DOM onclick events.
pkasting@chromium.org [Sat, 11 Sep 2010 01:16:12 +0000 (01:16 +0000)]
Make middle clicks not fire DOM onclick events.
https://bugs.webkit.org/show_bug.cgi?id=22382

Reviewed by Darin Adler.

WebCore:

* html/HTMLAnchorElement.cpp: Explicitly include middle-clicks in the
computation of what constitutes a link click, since they're no longer
implicitly included.
(WebCore::isLinkClick):
* html/HTMLInputElement.cpp: Removed unneeded checks that click events
are coming from the left mouse button, since they all are now.
(WebCore::HTMLInputElement::preDispatchEventHandler):
(WebCore::HTMLInputElement::postDispatchEventHandler):
(WebCore::HTMLInputElement::defaultEventHandler):
* page/EventHandler.cpp: Changed logic to send a click event only for
the left button.
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):

LayoutTests:

* fast/events/mouse-click-events-expected.txt:
* fast/events/script-tests/mouse-click-events.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows Build Fix. Fix some fallout from r67238, currentForm is now off of
bweinstein@apple.com [Sat, 11 Sep 2010 01:07:23 +0000 (01:07 +0000)]
Windows Build Fix. Fix some fallout from r67238, currentForm is now off of
SelectionController instead of frame. Also fix a style issue.

* WebFrame.cpp:
(WebFrame::currentForm):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 11 Sep 2010 01:03:34 +0000 (01:03 +0000)]
2010-09-10  Adam Barth  <abarth@webkit.org>

        Attempted build fix for Qt Minimal.

        * dom/Element.cpp:
        (WebCore::Element::getBoundingClientRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 11 Sep 2010 00:58:39 +0000 (00:58 +0000)]
2010-09-10  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        Need to rebaseline a bunch of files resulting from the SVG change
        in r67200.

        https://bugs.webkit.org/show_bug.cgi?id=45580

        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt
        * platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt
        * platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.txt
        * platform/chromium-win/svg/W3C-SVG-1.1/text-text-06-t-expected.txt
        * platform/chromium-win/svg/W3C-SVG-1.1/text-text-07-t-expected.txt
        * platform/chromium-win/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt
        * platform/chromium-win/svg/batik/text/textAnchor2-expected.txt
        * platform/chromium-win/svg/batik/text/textAnchor3-expected.txt
        * platform/chromium-win/svg/batik/text/textLayout-expected.txt
        * platform/chromium-win/svg/batik/text/textLayout2-expected.txt
        * platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt
        * platform/chromium-win/svg/batik/text/textPosition-expected.txt
        * platform/chromium-win/svg/batik/text/textPosition2-expected.txt
        * platform/chromium-win/svg/custom/text-letter-spacing-expected.txt
        * platform/chromium-win/svg/custom/text-x-dx-lists-expected.txt
        * platform/chromium-win/svg/custom/text-x-override-in-tspan-child-expected.txt
        * platform/chromium-win/svg/text/select-x-list-1-expected.txt
        * platform/chromium-win/svg/text/select-x-list-2-expected.txt
        * platform/chromium-win/svg/text/select-x-list-3-expected.txt
        * platform/chromium-win/svg/text/select-x-list-4-expected.txt
        * platform/chromium-win/svg/text/select-x-list-with-tspans-1-expected.txt
        * platform/chromium-win/svg/text/select-x-list-with-tspans-2-expected.txt
        * platform/chromium-win/svg/text/select-x-list-with-tspans-3-expected.txt
        * platform/chromium-win/svg/text/select-x-list-with-tspans-4-expected.txt
        * platform/chromium-win/svg/text/text-text-04-t-expected.txt
        * platform/chromium-win/svg/text/text-text-05-t-expected.txt
        * platform/chromium-win/svg/text/text-text-06-t-expected.txt
        * platform/chromium-win/svg/text/text-text-07-t-expected.txt
        * platform/chromium-win/svg/text/text-tspan-01-b-expected.txt

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-10 Dan Bernstein <mitz@apple.com>
mitz@apple.com [Sat, 11 Sep 2010 00:53:09 +0000 (00:53 +0000)]
2010-09-10  Dan Bernstein  <mitz@apple.com>

        Reviewed by Anders Carlsson.

        Pseudostyle resolution corrupts cached child index values
        https://bugs.webkit.org/show_bug.cgi?id=45574

        Covered by fast/dom/firstline-fixed-crash.html and fast/dom/firstletter-tablecell-crash.html.

        RenderBlock::updateFirstLetter() calls getCachedPseudoStyle() passing as the parent style the
        style of the parent of the first letter, which is not always the parent of the element for
        which we are getting :first-letter style. As a result, style resolution caches childIndex values
        in the wrong element’s style.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::pseudoStyleForElement): Create the new style and inherit from
        the parent style before matching rules, to avoid corrupting the parent style itself.
        (WebCore::CSSStyleSelector::checkSelector): Always pass the element’s parent style as
        the parent style here.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateFirstLetter): Removed the null check that was added
        in r67183.
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::findNextLineBreak): Removed the null check that was added
        in r67184.
2010-09-10  Dan Bernstein  <mitz@apple.com>

        Reviewed by Anders Carlsson.

        Pseudostyle resolution corrupts cached child index values
        https://bugs.webkit.org/show_bug.cgi?id=45574

        * fast/dom/firstline-fixed-crash-expected.txt: Updated results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNo review; build fix only.
jer.noble@apple.com [Sat, 11 Sep 2010 00:50:59 +0000 (00:50 +0000)]
No review; build fix only.

Touch mediaControlsQuickTime in order to trigger the UserAgentStyleSheet.h to be rebuilt.

* css/mediaControlsQuickTime.css:
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67254 268f45cc-cd09-0410-ab3c-d52691b4dbfc