kevino@webkit.org [Wed, 10 Aug 2011 23:19:30 +0000 (23:19 +0000)]
[wx] Unreviewed build fix. Do not build LocaleToScriptMappingICU.cpp for now as ICU on Leopard is too old to build this.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 10 Aug 2011 23:16:15 +0000 (23:16 +0000)]
new-run-webkit-test's WinPort has no fallback logic
https://bugs.webkit.org/show_bug.cgi?id=64486
Unreviewed. Fix test-webkitpy under Python 2.5.
* Scripts/webkitpy/layout_tests/port/win.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 10 Aug 2011 21:51:53 +0000 (21:51 +0000)]
[Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method
https://bugs.webkit.org/show_bug.cgi?id=65875
Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-08-10
Reviewed by Kenneth Rohde Christiansen.
For some reason, QWidget send fake mouse event on some platform, under certains conditions.
This causes mouse events to be sent twice in some cases. We work around the problem
by defining the first touch point to be a primary touch point (case which hit some
weird condition in QWidget, skipping the generation of fake mouse events).
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Wed, 10 Aug 2011 21:48:18 +0000 (21:48 +0000)]
Source/WebCore: Check that we do not need layout before trying to dirty
m_originatingLine for our floats.
https://bugs.webkit.org/show_bug.cgi?id=65938
Reviewed by Dave Hyatt.
Test: fast/block/float/float-originating-line-deleted-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::clearFloats):
LayoutTests: Tests that we do not crash when trying to access a removed
m_originatingLine for a float.
https://bugs.webkit.org/show_bug.cgi?id=65938
Reviewed by Dave Hyatt.
* fast/block/float/float-originating-line-deleted-crash-expected.txt: Added.
* fast/block/float/float-originating-line-deleted-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 10 Aug 2011 21:42:26 +0000 (21:42 +0000)]
JSC should always throw when function arg list is too long
https://bugs.webkit.org/show_bug.cgi?id=65869
Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-10
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
Changed the behavior of the interpreter and JIT to throw an exception
when too many arguments are passed rather than truncating the list. Added
a new method to create a "Too many arguments." exception used by this
new functionality.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ExceptionHelpers.cpp:
(JSC::createTooManyParamsError):
* runtime/ExceptionHelpers.h:
LayoutTests:
Changed the tests to make sure passing too many function arguments throws an exception
rather than truncating the arguments.
* fast/js/function-apply-many-args-expected.txt:
* fast/js/script-tests/function-apply-many-args.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 10 Aug 2011 21:03:12 +0000 (21:03 +0000)]
Add missing regions/exclusions-related files to EFL.
* CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 10 Aug 2011 20:59:04 +0000 (20:59 +0000)]
Add missing regions/exclusions-related files to Chromium.
* WebCore.gypi:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 10 Aug 2011 20:54:43 +0000 (20:54 +0000)]
Fix Qt build bustage. Add missing regions/exclusions-related files to their project.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 10 Aug 2011 20:39:18 +0000 (20:39 +0000)]
Update chromium gpu baselines for r92255
* platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-gpu-mac/media/video-transformed-expected.png:
* platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
* platform/chromium-gpu-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png:
* platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
* platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
* platform/chromium-gpu-mac/platform/chromium/compositing/tiny-layer-rotated-expected.png:
* platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-gpu-win/compositing/direct-image-compositing-expected.png:
* platform/chromium-gpu-win/compositing/geometry/ancestor-overflow-change-expected.png:
* platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
* platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
* platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.png:
* platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.png:
* platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
* platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.png:
* platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.png:
* platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 10 Aug 2011 20:36:55 +0000 (20:36 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=66004
Source/WebCore:
Remove ifdefs for CSS Exclusions (since the feature doesn't exist any longer and has morphed into positioned
floats instead). Go ahead and yank the ifdefs for CSS Regions also and just turn them on.
Reviewed by Adam Roben.
* Configurations/FeatureDefines.xcconfig:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseWrapShape):
(WebCore::CSSParser::parseFromFlowContent):
* css/CSSParser.h:
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::cssText):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::getShapeValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator RegionOverflow):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSValueKeywords.in:
* css/CSSWrapShapes.cpp:
* css/CSSWrapShapes.h:
* css/SVGCSSValueKeywords.in:
* dom/Node.cpp:
(WebCore::Node::diff):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::setStyle):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRendererFactory::createRendererIfNeeded):
* dom/NodeRenderingContext.h:
* rendering/RenderFlowThread.cpp:
* rendering/RenderFlowThread.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::collectLayers):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
* rendering/RenderObject.h:
(WebCore::RenderObject::isRenderRegion):
(WebCore::RenderObject::isRenderFlowThread):
* rendering/RenderRegion.cpp:
* rendering/RenderRegion.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
* rendering/RenderView.cpp:
(WebCore::RenderView::renderFlowThreadWithName):
* rendering/RenderView.h:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::regionOverflow):
(WebCore::InheritedFlags::setRegionOverflow):
(WebCore::InheritedFlags::initialWrapShape):
(WebCore::InheritedFlags::initialRegionOverflow):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:
Source/WebKit/mac:
Removing the CSS Regions and Exclusions ifdefs.
Reviewed by Adam Roben.
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Removing the CSS Regions and CSS Exclusions ifdefs.
Reviewed by Adam Roben.
* Configurations/FeatureDefines.xcconfig:
Tools:
Remove the regions and exclusions bots and also the flags in build-webkit, since I'm just turning
the code on by default.
Reviewed by Adam Roben.
* BuildSlaveSupport/build.webkit.org-config/config.json:
* Scripts/build-webkit:
LayoutTests:
Removing ifdefs for CSS Exclusions and CSS Regions. The code is now on by default, so the new CSS
properties are showing up in the computed style results.
Reviewed by Adam Roben.
* fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Wed, 10 Aug 2011 20:12:26 +0000 (20:12 +0000)]
Source/WebCore: Don't create html renderer for SVG <glyphRef>
https://bugs.webkit.org/show_bug.cgi?id=66000
Reviewed by David Hyatt.
Test: svg/text/glyphref-renderer-create-crash.html
* svg/SVGGlyphRefElement.h:
LayoutTests: ASSERTION FAILED: curr->isRenderInline()
https://bugs.webkit.org/show_bug.cgi?id=66000
Reviewed by David Hyatt.
* svg/text/glyphref-renderer-create-crash-expected.txt: Added.
* svg/text/glyphref-renderer-create-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 10 Aug 2011 19:57:00 +0000 (19:57 +0000)]
[Chromium] plugins/mouse-events-fixedpos.html should pass on win/mac/linux
https://bugs.webkit.org/show_bug.cgi?id=65841
Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-10
Reviewed by Tony Chang.
Add attribute windowPlugin="false" to the <embed> in this test to force the Chromium
Windows and Linux ports to load the test plugin in windowless mode. The plugin will
then receive events and can log them to the console as required by this test.
Also note, the Apple Mac/Win ports report 0 as the line number for all console.log()
messages, whereas, the Chromium ports report the actual line numbers, hence the need
for separate test results for Chromium.
* platform/chromium-linux/plugins/mouse-events-fixedpos-expected.txt:
* platform/chromium-mac/plugins/mouse-events-fixedpos-expected.txt:
* platform/chromium-win/plugins/mouse-events-fixedpos-expected.txt:
* platform/chromium/test_expectations.txt: New expectations.
* plugins/mouse-events-fixedpos.html: Add <embed> attribute windowPlugin="false".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 10 Aug 2011 19:53:50 +0000 (19:53 +0000)]
OpenTypeSanitizer in chromium gyp files is linked twice
https://bugs.webkit.org/show_bug.cgi?id=65927
Patch by Scott Graham <scottmg@google.com> on 2011-08-10
Reviewed by Adam Barth.
No new tests, should just build and link properly on all platforms.
* WebCore.gyp/WebCore.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 10 Aug 2011 19:52:27 +0000 (19:52 +0000)]
Make GC checks more aggressive in release builds
https://bugs.webkit.org/show_bug.cgi?id=66001
Reviewed by Gavin Barraclough.
../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:
* heap/HandleHeap.cpp:
(JSC::HandleHeap::visitStrongHandles):
(JSC::HandleHeap::visitWeakHandles):
(JSC::HandleHeap::finalizeWeakHandles):
(JSC::HandleHeap::writeBarrier):
(JSC::HandleHeap::isLiveNode):
(JSC::HandleHeap::isValidWeakNode):
Increase handle heap validation logic, and make some of
the crashes trigger in release builds as well as debug.
* heap/HandleHeap.h:
(JSC::HandleHeap::allocate):
(JSC::HandleHeap::makeWeak):
Ditto
* runtime/JSGlobalData.cpp:
(WTF::Recompiler::operator()):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren):
Fix GC bugs found while testing this patch
../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:
Fix GC bugs found while testing increased validation logic
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::createWindowShell):
* bridge/objc/ObjCRuntimeObject.h:
(JSC::Bindings::ObjCRuntimeObject::create):
* bridge/objc/ObjCRuntimeObject.mm:
(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
* bridge/objc/objc_instance.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 10 Aug 2011 19:47:45 +0000 (19:47 +0000)]
[skia] Move calls to makeGrContextCurrent into clipPathAntiAliased from callers
https://bugs.webkit.org/show_bug.cgi?id=65733
This protects against callers of clipPathAntiAliased forgetting to call makeGrContextCurrent.
Patch by Ben Wells <benwells@chromium.org> on 2011-08-10
Reviewed by James Robinson.
No change in functionality, no new tests.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::clip):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::clipPathAntiAliased):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 10 Aug 2011 19:45:49 +0000 (19:45 +0000)]
MarkupAccumulator: make resolution of URLs implicit to appendQuotedURLAttributeValue()
https://bugs.webkit.org/show_bug.cgi?id=65990
Patch by Benjamin Poulain <ikipou@gmail.com> on 2011-08-10
Reviewed by Ryosuke Niwa.
Instead of resolving the URLs in the call site of appendQuotedURLAttributeValue(),
the URL is now resolved if necessary in appendQuotedURLAttributeValue().
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):
(WebCore::MarkupAccumulator::appendAttribute):
* editing/MarkupAccumulator.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 10 Aug 2011 19:42:17 +0000 (19:42 +0000)]
JSEvaluteScript does not return the correct object when given JSONP data
https://bugs.webkit.org/show_bug.cgi?id=66003
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Make sure we propagate the result of the function call rather than the
argument.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
Tools:
Add a test case.
* DumpRenderTree/mac/DumpRenderTree.mm:
(testStringByEvaluatingJavaScriptFromString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 10 Aug 2011 19:35:01 +0000 (19:35 +0000)]
WIN: NRWT runs compositing tests on configurations that don't support compositing
https://bugs.webkit.org/show_bug.cgi?id=64472
Reviewed by Adam Barth.
I think the code was just wrong. It was never splitting the string
into list pieces before.
I've now tested the supported_features code and theoretically it
should now work with Windows DRT.
I also made the list-lookup functions always return lists, to make
it possible to clean up the list-transform code in the future
(I opted not to do that cleanup in this patch, but at least now
both types of feature lookup functions match return types.)
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Wed, 10 Aug 2011 19:24:26 +0000 (19:24 +0000)]
[Chromium] Implement text shaping with font-feature-settings on Linux
https://bugs.webkit.org/show_bug.cgi?id=65903
Source/WebCore:
- Modifies Font::codePath() to return Complex when there is font feature settings CSS property.
- Implements OpenType advanced typography feature using Harfbuzz on Chromium Linux port.
Reviewed by Adam Barth.
Test: css3/font-feature-settings-rendering.html
* platform/graphics/Font.cpp:
(WebCore::Font::codePath): Returns Complex when fontFeatureSettings exists.
* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::setupFontFeatures): Added.
(WebCore::ComplexTextController::setupFontForScriptRun): Calls setupFontFeatures().
LayoutTests:
Adds a rendering test for -webkit-font-feature-settings.
This tests disabled for now expect for chromium-linux port.
FeatureTest.ttf is created from scratch by using FontForge.
Reviewed by Adam Barth.
* css3/font-feature-settings-rendering.html: Added.
* css3/resources/FeatureTest.ttf: Added.
* platform/chromium-linux/css3/font-feature-settings-rendering-expected.png: Added.
* platform/chromium-linux/css3/font-feature-settings-rendering-expected.txt: Added.
* platform/chromium/test_expectations.txt: Skips css3/font-feature-settings-rendering.html.
* platform/gtk/Skipped: Ditto.
* platform/mac/Skipped: Ditto.
* platform/qt/Skipped: Ditto.
* platform/win/Skipped: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Wed, 10 Aug 2011 19:13:07 +0000 (19:13 +0000)]
[chromium] Notify MemoryCache of decoded data access
https://bugs.webkit.org/show_bug.cgi?id=65859
Reviewed by James Robinson.
This causes us to call CachedImage::didDraw() which calls CachedResource::didAccessDecodedData()
which updates the LRU for decoded image data and potentially prunes the cache. This is already done
by almost all of the other ports.
The decoded bitmaps obviously use quite a bit of memory, so pruning them when necessary is important.
In my tests, this saves several MB on many popular web pages.
No new tests because no observable difference in functionality.
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Wed, 10 Aug 2011 18:45:25 +0000 (18:45 +0000)]
Web Inspector: Remove Network.initialContentSet from protocol, store workers content on backend.
https://bugs.webkit.org/show_bug.cgi?id=65929
Reviewed by Pavel Feldman.
Source/WebCore:
Tests: http/tests/inspector/network/network-shared-worker.html
http/tests/inspector/network/network-worker.html
* inspector/Inspector.json:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didReceiveScriptResponseImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didReceiveScriptResponse):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::setInitialScriptContent):
(WebCore::InspectorResourceAgent::didReceiveScriptResponse):
* inspector/InspectorResourceAgent.h:
* inspector/front-end/NetworkManager.js:
* inspector/front-end/Resource.js:
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::didReceiveResponse):
* workers/Worker.cpp:
(WebCore::Worker::didReceiveResponse):
* workers/Worker.h:
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::didReceiveResponse):
* workers/WorkerScriptLoaderClient.h:
(WebCore::WorkerScriptLoaderClient::didReceiveResponse):
Source/WebKit/chromium:
* src/SharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::didReceiveResponse):
LayoutTests:
* http/tests/inspector/network/network-shared-worker-expected.txt: Added.
* http/tests/inspector/network/network-shared-worker.html: Added.
* http/tests/inspector/network/network-worker-expected.txt: Added.
* http/tests/inspector/network/network-worker.html: Added.
* http/tests/inspector/network/resources/shared-worker.js: Added.
(onconnect):
* http/tests/inspector/network/resources/worker.js: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Wed, 10 Aug 2011 18:41:03 +0000 (18:41 +0000)]
Web Inspector: [Network] Filtering by stylesheet does not update the # reqs, filesizes.
https://bugs.webkit.org/show_bug.cgi?id=65515
Reviewed by Pavel Feldman.
* English.lproj/localizedStrings.js:
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._updateSummaryBar):
(WebInspector.NetworkLogView.prototype._updateFilter):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 10 Aug 2011 18:37:58 +0000 (18:37 +0000)]
Clean up ChromiumDriver a little
https://bugs.webkit.org/show_bug.cgi?id=65995
Unreviewed.
Fix NRWT for chromium. Silly python.
* Scripts/webkitpy/layout_tests/port/chromium.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Wed, 10 Aug 2011 18:30:08 +0000 (18:30 +0000)]
Accidentally commented out an assertion in BackingStore::incorporateUpdate
https://bugs.webkit.org/show_bug.cgi?id=65989
Reviewed by Anders Carlsson.
I couldn't get this assertion to fire in quick testing, let's bring it back.
* UIProcess/BackingStore.cpp: (WebKit::BackingStore::incorporateUpdate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 10 Aug 2011 17:58:00 +0000 (17:58 +0000)]
Clean up ChromiumDriver a little
https://bugs.webkit.org/show_bug.cgi?id=65995
Reviewed by Adam Barth.
- We no longer support threading, so remove threading specific code.
- Add FIXMEs about using ServerProcess instead.
- Condense option-mapping if-cascade into a for loop.
- Unindent long if blocks by using early return.
- Unwrap lines which are needlessly wrapped.
There should be no functional changes here, just code cleanup/dead-code removal.
* Scripts/webkitpy/layout_tests/port/chromium.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Wed, 10 Aug 2011 17:56:08 +0000 (17:56 +0000)]
Web Inspector: console messages markers are lost in Resources panel after page reload
https://bugs.webkit.org/show_bug.cgi?id=60701
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/resource-tree/resource-tree-errors-reload.html
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
(WebInspector.ResourceTreeModel.prototype._addPendingConsoleMessage):
(WebInspector.ResourceTreeModel.prototype._addPendingConsoleMessagesToResource):
(WebInspector.ResourceTreeModel.prototype._addConsoleMessageToResource):
(WebInspector.ResourceTreeModel.prototype._consoleCleared):
(WebInspector.ResourceTreeModel.prototype._bindResourceURL):
LayoutTests:
* http/tests/inspector/resource-tree/resource-tree-errors-reload-expected.txt: Added.
* http/tests/inspector/resource-tree/resource-tree-errors-reload.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 10 Aug 2011 17:08:47 +0000 (17:08 +0000)]
Unmuddle construction options for TestConfiguration.
https://bugs.webkit.org/show_bug.cgi?id=65988
The TestConfiguration instance is now constructed only using actual values.
Port-based construction is split into a "from_port" class method.
Reviewed by Eric Seidel.
* Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfiguration.from_port
* Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Adjusted code to accommodate the change.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
* Scripts/webkitpy/layout_tests/port/base.py: Ditto.
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 10 Aug 2011 16:35:03 +0000 (16:35 +0000)]
Update expectations for this test. It's just a minor flake.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 10 Aug 2011 16:27:17 +0000 (16:27 +0000)]
Add device specific settings to support viewport computing
https://bugs.webkit.org/show_bug.cgi?id=65984
Patch by Lars Knudsen <lars.knudsen@nokia.com> on 2011-08-10
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Based on patch by Zalan Bujtas.
Added settings for device size, dpi and layout fallback width
to support viewport computing.
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setLayoutFallbackWidth):
(WebCore::Settings::layoutFallbackWidth):
(WebCore::Settings::setDeviceWidth):
(WebCore::Settings::deviceWidth):
(WebCore::Settings::setDeviceHeight):
(WebCore::Settings::deviceHeight):
(WebCore::Settings::setDeviceDPI):
(WebCore::Settings::deviceDPI):
Source/WebKit2:
Expose new viewport related WebCore settings to WebKit2.
* Shared/WebPreferencesStore.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 10 Aug 2011 15:49:40 +0000 (15:49 +0000)]
Leaks bot shows python logging prefixes as part of summary display
https://bugs.webkit.org/show_bug.cgi?id=65931
Reviewed by Adam Barth.
The big part of this change is adding a unittesting system for
master.cfg, so mere-mortals can make changes to build.webkit.org
with greatly-reduced risk of breaking the world.
Turns out that in typing up my trival logging fix I made 2 typos,
so hopefully the hour spent getting master.cfg to load was worth it. :)
I also tried to make mastercfg_unittest run as part of test-webkitpy
but right now test-webkitpy requires that unittest files be located in
a module-name-compatible directory. 'build.webkit.org-config' is not
a valid module name.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
- Fixed _parseNewRunWebKitTestsOutput to strip NRWT's python formatter prefix
by using a new _strip_python_logging_prefix function.
- Also fixed this function to file to work with a more modern
simplejson version (which returns unicode objects instead of str objects)
and filed a related bug with buildbot.net due to their handling of unicode builder names.
* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added.
- BuildBotConfigLoader is a huge pile of code just to get master.cfg to load.
- The actual tiny unittest of the new _parseNewRunWebKitTestsOutput logic.
* Scripts/webkitpy/thirdparty/__init__.py:
- Add autoinstallation of buildbot (and jinja2) for use by mastercfg_unittest.py
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 10 Aug 2011 15:43:49 +0000 (15:43 +0000)]
[GTK] wrong annotation for the return value of webkit_web_view_get_hit_test_results()
https://bugs.webkit.org/show_bug.cgi?id=65985
Patch by Gustavo Noronha Silva <gns@gnome.org> on 2011-08-10
Reviewed by Xan Lopez.
* webkit/webkitwebview.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 10 Aug 2011 15:34:51 +0000 (15:34 +0000)]
garden-o-matic should extrapolate failures given a set of known results
https://bugs.webkit.org/show_bug.cgi?id=65882
Reviewed by Adam Barth.
* Scripts/webkitpy/layout_tests/models/test_configuration.py: Spuriously covered my old sins.
* Scripts/webkitpy/layout_tests/port/builders.py: Augmented builders dictionary to contain build coverage specifiers,
adjusted all call sites.
* Scripts/webkitpy/tool/servers/gardeningserver.py: Added BuildCoverageExtrapolator, a thing that
makes wider net for specific failures.
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 10 Aug 2011 15:27:17 +0000 (15:27 +0000)]
Unify the way we generate HTML for an image in the Clipboard
https://bugs.webkit.org/show_bug.cgi?id=58043
Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-08-10
Reviewed by Ryosuke Niwa.
Source/WebCore:
Unify the way we generate the markup when dragging and image.
Previously, the code was using the special function imageToMarkup() that was
spread from the Chromium port.
That function ignores some edge cases so this patch replace it by the
more generic MarkupAccumulator (which is also used by the other pasteboard
actions).
The MarkupAccumulator was modified because following r61178, the local filepath
are treated differently (the enum was changed to make this behavior
explicit).
Tests: fast/drag-and-drop/drag-and-drop-image-contenteditable.html
fast/drag-and-drop/drag-and-drop-inputimage-contenteditable.html
fast/drag-and-drop/drag-and-drop-objectimage-contenteditable.html
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::MarkupAccumulator):
(WebCore::MarkupAccumulator::resolveURLIfNeeded):
(WebCore::MarkupAccumulator::appendAttribute):
* editing/MarkupAccumulator.h:
* editing/markup.cpp:
* editing/markup.h:
* page/PageSerializer.cpp:
(WebCore::SerializerMarkupAccumulator::SerializerMarkupAccumulator):
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::declareAndWriteDragImage):
(WebCore::ClipboardChromium::writeRange):
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeSelection):
* platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::declareAndWriteDragImage):
(WebCore::ClipboardGtk::writeRange):
* platform/gtk/DataObjectGtk.cpp:
(WebCore::DataObjectGtk::markup):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writeImage):
* platform/haiku/PasteboardHaiku.cpp:
(WebCore::Pasteboard::writeSelection):
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::declareAndWriteDragImage):
(WebCore::ClipboardQt::writeRange):
* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeSelection):
* platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::declareAndWriteDragImage):
LayoutTests:
Add 3 tests for dragging an image-like element to an editable area.
* editing/pasteboard/drag-and-drop-image-contenteditable-expected.txt: Added.
* editing/pasteboard/drag-and-drop-image-contenteditable.html: Added.
* editing/pasteboard/drag-and-drop-inputimage-contenteditable-expected.txt: Added.
* editing/pasteboard/drag-and-drop-inputimage-contenteditable.html: Added.
* editing/pasteboard/drag-and-drop-objectimage-contenteditable-expected.txt: Added.
* editing/pasteboard/drag-and-drop-objectimage-contenteditable.html: Added.
* platform/qt/Skipped: Qt does not have support for testing drag and drop.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 10 Aug 2011 14:37:23 +0000 (14:37 +0000)]
Web Inspector: auto-completion for string literals doesn't work
https://bugs.webkit.org/show_bug.cgi?id=65701
Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-10
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluateOnCallFrame):
* inspector/InjectedScript.h:
* inspector/InjectedScriptSource.js:
(.):
():
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._completions.evaluated.getCompletions):
(WebInspector.ConsoleView.prototype._completions.evaluated):
(WebInspector.ConsoleView.prototype._completions.receivedPropertyNamesFromEval):
(WebInspector.ConsoleView.prototype._completions.receivedPropertyNames):
(WebInspector.ConsoleView.prototype._completions):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.PresenationCallFrame.prototype.evaluate):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):
LayoutTests:
* inspector/debugger/debugger-completions-on-call-frame-expected.txt:
* inspector/debugger/debugger-completions-on-call-frame.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 10 Aug 2011 14:06:11 +0000 (14:06 +0000)]
2011-08-10 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Rolled DEPS 95813:96009 to pick data url timing fix.
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 10 Aug 2011 14:01:09 +0000 (14:01 +0000)]
Web Inspector: CSS editing file containing tabs leads to the whole file change in revision history.
https://bugs.webkit.org/show_bug.cgi?id=65959
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.prototype._innerSetText):
LayoutTests:
* inspector/editor/text-editor-model-replace-tabs-expected.txt: Removed.
* inspector/editor/text-editor-model-replace-tabs.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 10 Aug 2011 13:41:30 +0000 (13:41 +0000)]
Web Inspector: there should be a way to tell what properties are non-enumerable when expanding objects.
https://bugs.webkit.org/show_bug.cgi?id=65518
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::getProperties):
* inspector/InjectedScript.h:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::getProperties):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
(WebInspector.ObjectPropertyTreeElement.prototype.update):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.getOwnProperties):
(WebInspector.RemoteObject.prototype.getAllProperties):
(WebInspector.RemoteObjectProperty):
* inspector/front-end/inspector.css:
(.section .properties .dimmed):
LayoutTests:
* inspector/debugger/debugger-expand-scope-expected.txt:
* inspector/protocol/runtime-agent-expected.txt:
* inspector/runtime/runtime-getProperties-expected.txt:
* inspector/runtime/runtime-getProperties.html:
* platform/chromium/inspector/runtime/runtime-getProperties-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 10 Aug 2011 13:36:50 +0000 (13:36 +0000)]
Web Inspector: [REGRESSION] Editor lost after committing a CSS property value for inline style
https://bugs.webkit.org/show_bug.cgi?id=65918
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._innerUpdate.stylesCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.event):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert.parentPane):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert):
LayoutTests:
* inspector/styles/styles-commit-editing.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 10 Aug 2011 11:53:31 +0000 (11:53 +0000)]
[EFL] API methods check NULL and return proper value.
https://bugs.webkit.org/show_bug.cgi?id=65844
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-10
Reviewed by Kenneth Rohde Christiansen.
Check NULL before access to the smart and private data of the view object
and return the proper value if error occurred.
* ewk/ewk_view.cpp:
(ewk_view_zoom_range_set):
(ewk_view_zoom_range_min_get):
(ewk_view_zoom_range_max_get):
(ewk_view_user_scalable_set):
(ewk_view_user_scalable_get):
(ewk_view_device_pixel_ratio_get):
* ewk/ewk_view.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 10 Aug 2011 10:24:10 +0000 (10:24 +0000)]
Move <input type=datetime> tests to fast/forms/datetime/
https://bugs.webkit.org/show_bug.cgi?id=65970
Reviewed by Hajime Morita.
* fast/forms/ValidityState-rangeOverflow-expected.txt: Removed "datetime" part.
* fast/forms/ValidityState-rangeUnderflow-expected.txt: ditto.
* fast/forms/ValidityState-stepMismatch-expected.txt: ditto.
* fast/forms/ValidityState-typeMismatch-datetime-expected.txt: Removed.
* fast/forms/ValidityState-typeMismatch-datetime.html: Removed.
* fast/forms/date-input-visible-strings-expected.txt: Removed "datetime" part.
* fast/forms/date-input-visible-strings.html: ditto.
* fast/forms/datetime: Added.
* fast/forms/datetime/ValidityState-rangeOverflow-datetime-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeOverflow-expected.txt.
* fast/forms/datetime/ValidityState-rangeOverflow-datetime.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js.
* fast/forms/datetime/ValidityState-rangeUnderflow-datetime-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeUnderflow-expected.txt.
* fast/forms/datetime/ValidityState-rangeUnderflow-datetime.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js.
* fast/forms/datetime/ValidityState-stepMismatch-datetime-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt.
* fast/forms/datetime/ValidityState-stepMismatch-datetime.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
* fast/forms/datetime/ValidityState-typeMismatch-datetime-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-datetime-expected.txt.
* fast/forms/datetime/ValidityState-typeMismatch-datetime.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-datetime.js.
* fast/forms/datetime/datetime-input-type-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-type-expected.txt.
* fast/forms/datetime/datetime-input-type.html: Copied from LayoutTests/fast/forms/week/week-input-type.html.
* fast/forms/datetime/datetime-input-visible-string-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-visible-string-expected.txt.
* fast/forms/datetime/datetime-input-visible-string.html: Copied from LayoutTests/fast/forms/week/week-input-visible-string.html.
* fast/forms/datetime/datetime-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt.
* fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt.
* fast/forms/datetime/datetime-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
* fast/forms/datetime/datetime-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
* fast/forms/datetime/input-valueasdate-datetime-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-datetime-expected.txt.
* fast/forms/datetime/input-valueasdate-datetime.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-datetime.js.
* fast/forms/datetime/input-valueasnumber-datetime-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-datetime-expected.txt.
* fast/forms/datetime/input-valueasnumber-datetime.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-datetime.js.
* fast/forms/input-stepup-stepdown-expected.txt: Removed "datetime" part.
* fast/forms/input-stepup-stepdown-from-renderer-expected.txt: ditto.
* fast/forms/input-type-change3-expected.txt: ditto.
* fast/forms/input-valueasdate-datetime-expected.txt: Removed.
* fast/forms/input-valueasdate-datetime.html: Removed.
* fast/forms/input-valueasnumber-datetime-expected.txt: Removed.
* fast/forms/input-valueasnumber-datetime.html: Removed.
* fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed "datetime" part.
* fast/forms/script-tests/ValidityState-rangeUnderflow.js: ditto.
* fast/forms/script-tests/ValidityState-stepMismatch.js: ditto.
* fast/forms/script-tests/ValidityState-typeMismatch-datetime.js: Removed.
* fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed "datetime" part.
* fast/forms/script-tests/input-stepup-stepdown.js: ditto.
* fast/forms/script-tests/input-type-change3.js: ditto.
* fast/forms/script-tests/input-valueasdate-datetime.js: Removed.
* fast/forms/script-tests/input-valueasnumber-datetime.js: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 10 Aug 2011 09:59:41 +0000 (09:59 +0000)]
[Qt] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm fails intermittently
https://bugs.webkit.org/show_bug.cgi?id=65969
Unreviewed gardening.
* platform/qt-4.8/Skipped: Remove http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm, because it isn't Qt 4.8 specific bug.
* platform/qt/Skipped: Skip http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm.
* platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Update to the correct results.
* platform/qt/test_expectations.txt: Remove http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 10 Aug 2011 09:23:02 +0000 (09:23 +0000)]
2011-08-10 Andrey Kosyakov <caseq@chromium.org>
Unreviewed test fix.
* inspector/network-status-non-http-expected.txt:
* inspector/network-status-non-http.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Wed, 10 Aug 2011 09:19:51 +0000 (09:19 +0000)]
WebSocket: Add binaryType attribute
https://bugs.webkit.org/show_bug.cgi?id=65967
Reviewed by Kent Tamura.
Source/WebCore:
Add a new attribute "binaryType" to WebSocket. It controls the data type of MessageEvent
for WebSocket's binary frames.
Tests: http/tests/websocket/tests/hixie76/undefined-attributes.html
http/tests/websocket/tests/hybi/binary-type.html
* websockets/WebSocket.cpp:
(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::binaryType):
(WebCore::WebSocket::setBinaryType):
* websockets/WebSocket.h:
* websockets/WebSocket.idl:
LayoutTests:
* http/tests/websocket/tests/hixie76/undefined-attributes-expected.txt: Added.
* http/tests/websocket/tests/hixie76/undefined-attributes.html: Added.
* http/tests/websocket/tests/hybi/binary-type-expected.txt: Added.
* http/tests/websocket/tests/hybi/binary-type.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 10 Aug 2011 09:09:39 +0000 (09:09 +0000)]
[EFL] Remove unused local variable from _ewk_tiled_backing_store_item_process_idler_cb.
https://bugs.webkit.org/show_bug.cgi?id=65846
As Ewk_Tiled_Backing_Store_Item *it is declared as local variable, but it's never referenced anywhere,
it is better to be removed from _ewk_tiled_backing_store_item_process_idler_cb.
Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-10
Reviewed by Kenneth Rohde Christiansen.
* ewk/ewk_tiled_backing_store.c:
(_ewk_tiled_backing_store_item_process_idler_cb):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Wed, 10 Aug 2011 09:07:18 +0000 (09:07 +0000)]
WebSocket: Accept multiple subprotocols
https://bugs.webkit.org/show_bug.cgi?id=65247
Reviewed by Kent Tamura.
Source/WebCore:
WebSocket constructor should accept an array of subprotocols if hybi-10 protocol is chosen.
Tests: http/tests/websocket/tests/hybi/invalid-subprotocol-characters.html
http/tests/websocket/tests/hybi/invalid-subprotocols.html
http/tests/websocket/tests/hybi/multiple-subprotocols.html
http/tests/websocket/tests/hybi/workers/multiple-subprotocols.html
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocketConstructor::constructJSWebSocket):
If the second argument of WebSocket constructor is an array, build a Vector<String> and
pass it to WebSocket::connect().
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback):
Ditto.
* websockets/WebSocket.cpp:
(WebCore::isValidProtocolCharacter): Added.
(WebCore::isValidProtocolString): Added.
(WebCore::isValidProtocolStringHixie76): Renamed from isValidProtocolString.
(WebCore::joinStrings):
(WebCore::WebSocket::connect):
If an array is provided as a subprotocol, and if hixie-76 is used for this connection, it
must be converted to a string in the same manner as JavaScript's Array.toString() in order
to keep compatibility.
* websockets/WebSocket.h:
Removed m_protocol because it was not used at all.
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::disconnect):
WebSocketChannel may be released before connect() is called, thus m_handshake may be null.
LayoutTests:
Add tests to check whether WebSocket accepts multiple subprotocols in constructor.
* http/tests/websocket/tests/hybi/accept-first-subprotocol_wsh.py: Added.
* http/tests/websocket/tests/hybi/invalid-subprotocol-characters-expected.txt: Added.
* http/tests/websocket/tests/hybi/invalid-subprotocol-characters.html: Added.
* http/tests/websocket/tests/hybi/invalid-subprotocols-expected.txt: Added.
* http/tests/websocket/tests/hybi/invalid-subprotocols.html: Added.
* http/tests/websocket/tests/hybi/multiple-subprotocols-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/hybi/sub-protocol-with-space-expected.txt.
* http/tests/websocket/tests/hybi/multiple-subprotocols.html: Added.
* http/tests/websocket/tests/hybi/sub-protocol-with-space-expected.txt: Removed.
* http/tests/websocket/tests/hybi/sub-protocol-with-space.html:
Removed because hybi-10 does not allow subprotocols containing a space.
* http/tests/websocket/tests/hybi/workers/multiple-subprotocols-expected.txt: Added.
* http/tests/websocket/tests/hybi/workers/multiple-subprotocols.html: Added.
* http/tests/websocket/tests/hybi/workers/resources/multiple-subprotocols.js: Added.
(ws.onopen):
(ws.onmessage):
(ws.onclose):
* http/tests/websocket/tests/hybi/workers/resources/protocol-test_wsh.py: Copied from http/tests/websocket/tests/hybi/protocol-test_wsh.py.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 10 Aug 2011 08:44:23 +0000 (08:44 +0000)]
[Chromium] plugins/mouse-events.html should pass on the mac.
https://bugs.webkit.org/show_bug.cgi?id=65957
Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-10
Reviewed by Kent Tamura.
Cocoa plugins do not generate adjustCursorEvents. Rebaseline this test result for the
chromium Mac port. Note the WebKit Mac/Win ports report 0 for the line number for all
console.log() events. The Chromium port reports the actual line number, and hence the
need for separate test results for Chromium. Following bug 61721, this test now runs,
and passes on all the Chromium ports. The test confirms user-plugin interactivity, so
we don't regress sites like youtube.com. Refer to bug 11517.
* platform/chromium-mac/plugins/mouse-events-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 10 Aug 2011 08:25:50 +0000 (08:25 +0000)]
2011-08-10 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: Network panel always displays file:// resources as "(pending)"
https://bugs.webkit.org/show_bug.cgi?id=65784
Reviewed by Pavel Feldman.
Test: inspector/network-status-non-http.html
* English.lproj/localizedStrings.js:
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.isHttpFamily):
2011-08-10 Andrey Kosyakov <caseq@chromium.org>
Web Inspector: Network panel always displays file:// resources as "(pending)"
https://bugs.webkit.org/show_bug.cgi?id=65784
Reviewed by Pavel Feldman.
* inspector/network-status-non-http-expected.txt: Added.
* inspector/network-status-non-http.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 10 Aug 2011 08:06:14 +0000 (08:06 +0000)]
Move <input type=datetime-local> tests to fast/forms/datetimelocal/
https://bugs.webkit.org/show_bug.cgi?id=65958
Reviewed by Hajime Morita.
* fast/forms/ValidityState-rangeOverflow-expected.txt: Removed datetime-local part.
* fast/forms/ValidityState-rangeUnderflow-expected.txt: ditto.
* fast/forms/ValidityState-stepMismatch-expected.txt: ditto.
* fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt: Removed.
* fast/forms/ValidityState-typeMismatch-datetimelocal.html: Removed.
* fast/forms/date-input-visible-strings-expected.txt: Removed datetime-local and time parts.
* fast/forms/date-input-visible-strings.html: ditto.
* fast/forms/datetimelocal: Added.
* fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeOverflow-expected.txt.
* fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js.
* fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeUnderflow-expected.txt.
* fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js.
* fast/forms/datetimelocal/ValidityState-stepMismatch-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt.
* fast/forms/datetimelocal/ValidityState-stepMismatch-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
* fast/forms/datetimelocal/ValidityState-typeMismatch-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt.
* fast/forms/datetimelocal/ValidityState-typeMismatch-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js.
* fast/forms/datetimelocal/datetimelocal-input-type-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-type-expected.txt.
* fast/forms/datetimelocal/datetimelocal-input-type.html: Copied from LayoutTests/fast/forms/week/week-input-type.html.
* fast/forms/datetimelocal/datetimelocal-input-visible-string-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-visible-string-expected.txt.
* fast/forms/datetimelocal/datetimelocal-input-visible-string.html: Copied from LayoutTests/fast/forms/week/week-input-visible-string.html.
* fast/forms/datetimelocal/datetimelocal-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt.
* fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt.
* fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
* fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
* fast/forms/datetimelocal/input-valueasdate-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-datetimelocal-expected.txt.
* fast/forms/datetimelocal/input-valueasdate-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-datetimelocal.js.
* fast/forms/datetimelocal/input-valueasnumber-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-datetimelocal-expected.txt.
* fast/forms/datetimelocal/input-valueasnumber-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-datetimelocal.js.
* fast/forms/input-stepup-stepdown-expected.txt: Removed datetime-local part.
* fast/forms/input-stepup-stepdown-from-renderer-expected.txt: ditto.
* fast/forms/input-type-change3-expected.txt: ditto.
* fast/forms/input-valueasdate-datetimelocal-expected.txt: Removed.
* fast/forms/input-valueasdate-datetimelocal.html: Removed.
* fast/forms/input-valueasnumber-datetimelocal-expected.txt: Removed.
* fast/forms/input-valueasnumber-datetimelocal.html: Removed.
* fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed datetime-local part.
* fast/forms/script-tests/ValidityState-rangeUnderflow.js: ditto.
* fast/forms/script-tests/ValidityState-stepMismatch.js: ditto.
* fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js: Removed.
* fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed datetime-local part.
* fast/forms/script-tests/input-stepup-stepdown.js: Removed datetime-local part.
* fast/forms/script-tests/input-type-change3.js: Removed datetime-local part.
* fast/forms/script-tests/input-valueasdate-datetimelocal.js: Removed.
* fast/forms/script-tests/input-valueasnumber-datetimelocal.js: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 10 Aug 2011 07:39:17 +0000 (07:39 +0000)]
Updated results after trac.webkit.org/changeset/92744.
* platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.png:
* platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.png:
* platform/chromium-mac-leopard/fast/css-generated-content/table-row-before-after-child-add-expected.png:
* platform/chromium-mac-leopard/fast/css-generated-content/table-table-before-after-child-add-expected.png:
* platform/chromium-mac/fast/css-generated-content/table-row-before-after-child-add-expected.png:
* platform/chromium-mac/fast/css-generated-content/table-table-before-after-child-add-expected.png:
* platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.png:
* platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 10 Aug 2011 07:36:49 +0000 (07:36 +0000)]
The URL we were computing for retrieving baselines was missing a slash
character because our mocks had an extra slash character. I've
corrected both the code and the mock.
* Scripts/webkitpy/tool/commands/rebaseline.py:
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 10 Aug 2011 07:35:13 +0000 (07:35 +0000)]
[Chromium] Name an enum used in some template arguments.
https://bugs.webkit.org/show_bug.cgi?id=65953
Patch by Peter Kasting <pkasting@google.com> on 2011-08-10
Reviewed by Darin Fisher.
* public/WebHTTPBody.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 10 Aug 2011 07:06:57 +0000 (07:06 +0000)]
DFG JIT heap prediction causes regressions when combined with
aggressive integer prediction
https://bugs.webkit.org/show_bug.cgi?id=65954
Reviewed by Gavin Barraclough.
Disabled heap prediction, but did not remove the capability.
This improves V8 crypto performance by 20%.
* dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Wed, 10 Aug 2011 05:35:28 +0000 (05:35 +0000)]
Use setFontDescription helper to set m_fontDirty.
https://bugs.webkit.org/show_bug.cgi?id=65956
Reviewed by Dan Bernstein.
No new tests / trivial cleanup.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 10 Aug 2011 05:28:19 +0000 (05:28 +0000)]
Move the quote mark to the right place.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dominicc@chromium.org [Wed, 10 Aug 2011 04:51:50 +0000 (04:51 +0000)]
[V8] The prototype property of DOM constructors should be read-only.
https://bugs.webkit.org/show_bug.cgi?id=39655
Reviewed by Dimitri Glazkov.
Source/WebCore:
Test: fast/dom/prototype-property.html
* bindings/scripts/CodeGeneratorV8.pm: Make prototypes read-only.
* bindings/scripts/test/V8/V8TestInterface.cpp: Update expectations.
(WebCore::ConfigureV8TestInterfaceTemplate):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
LayoutTests:
* platform/chromium/test_expectations.txt: Unskip test for prototypes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 10 Aug 2011 04:43:59 +0000 (04:43 +0000)]
Move <input type=time> tests to fast/forms/time/
https://bugs.webkit.org/show_bug.cgi?id=65955
Reviewed by Hajime Morita.
* fast/forms/ValidityState-rangeOverflow-expected.txt: Removed 'time' part.
* fast/forms/ValidityState-rangeUnderflow-expected.txt: ditto.
* fast/forms/ValidityState-stepMismatch-expected.txt: ditto.
* fast/forms/ValidityState-typeMismatch-time-expected.txt: Removed.
* fast/forms/ValidityState-typeMismatch-time.html: Removed.
* fast/forms/input-stepup-stepdown-expected.txt: Removed 'time' part.
* fast/forms/input-stepup-stepdown-from-renderer-expected.txt: ditto.
* fast/forms/input-type-change3-expected.txt: ditto.
* fast/forms/input-valueasdate-time-expected.txt: Removed.
* fast/forms/input-valueasdate-time.html: Removed.
* fast/forms/input-valueasnumber-time-expected.txt: Removed.
* fast/forms/input-valueasnumber-time.html: Removed.
* fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed 'time' part.
* fast/forms/script-tests/ValidityState-rangeUnderflow.js: ditto.
* fast/forms/script-tests/ValidityState-stepMismatch.js: ditto.
* fast/forms/script-tests/ValidityState-typeMismatch-time.js: Removed.
* fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed 'time' part.
* fast/forms/script-tests/input-stepup-stepdown.js: ditto.
* fast/forms/script-tests/input-type-change3.js: ditto.
* fast/forms/script-tests/input-valueasdate-time.js: Removed.
* fast/forms/script-tests/input-valueasnumber-time.js: Removed.
* fast/forms/time: Added.
* fast/forms/time/ValidityState-rangeOverflow-time-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeOverflow-expected.txt.
* fast/forms/time/ValidityState-rangeOverflow-time.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js.
* fast/forms/time/ValidityState-rangeUnderflow-time-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeUnderflow-expected.txt.
* fast/forms/time/ValidityState-rangeUnderflow-time.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js.
* fast/forms/time/ValidityState-stepMismatch-time-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt.
* fast/forms/time/ValidityState-stepMismatch-time.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
* fast/forms/time/ValidityState-typeMismatch-time-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-time-expected.txt.
* fast/forms/time/ValidityState-typeMismatch-time.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-time.js.
* fast/forms/time/input-valueasdate-time-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-time-expected.txt.
* fast/forms/time/input-valueasdate-time.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-time.js.
* fast/forms/time/input-valueasnumber-time-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-time-expected.txt.
* fast/forms/time/input-valueasnumber-time.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-time.js.
* fast/forms/time/time-input-type-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-type-expected.txt.
* fast/forms/time/time-input-type.html: Copied from LayoutTests/fast/forms/week/week-input-type.html.
* fast/forms/time/time-input-visible-string-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-visible-string-expected.txt.
* fast/forms/time/time-input-visible-string.html: Copied from LayoutTests/fast/forms/week/week-input-visible-string.html.
* fast/forms/time/time-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt.
* fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt.
* fast/forms/time/time-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
* fast/forms/time/time-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 10 Aug 2011 02:04:06 +0000 (02:04 +0000)]
Source/WebCore: Style change not propagating for before, after content
for table parts.
https://bugs.webkit.org/show_bug.cgi?id=51862
Fix by Chris Evans (cevans@chromium.org).
In the table case, make sure to return the before /
after parent rather then the before / after node
itself.
Patch by Abhishek Arya <inferno@chromium.org> on 2011-08-09
Reviewed by Simon Fraser.
* rendering/RenderObjectChildList.cpp:
(WebCore::findBeforeAfterParent):
LayoutTests: Fix functional bug where style change was not getting propogated to before, after
content.
https://bugs.webkit.org/show_bug.cgi?id=51862
Patch by Abhishek Arya <inferno@chromium.org> on 2011-08-09
Reviewed by Simon Fraser.
* platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.png:
* platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 10 Aug 2011 01:49:02 +0000 (01:49 +0000)]
garden-o-matic should use huerstics to narrow regression range
https://bugs.webkit.org/show_bug.cgi?id=65948
Reviewed by Dimitri Glazkov.
When analyzing a regression range, if one of the commit messages
mentions the test in question, we now hueristically assume that
revision caused the failure. (I'm shamelessly stealing this idea from
TestFailures.)
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Wed, 10 Aug 2011 01:44:07 +0000 (01:44 +0000)]
Implement string based properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=65662
Reviewed by Darin Adler.
No new tests / refactoring only.
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyString::ApplyPropertyString):
Added class to handle string based properties.
(WebCore::ApplyPropertyString::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Add initializers for CSSPropertyWebkitHighlight and CSSPropertyWebkitHyphenateCharacter.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Remove existing implementations for CSSPropertyWebkitHighlight and CSSPropertyWebkitHyphenateCharacter.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 10 Aug 2011 01:40:10 +0000 (01:40 +0000)]
Another follow-up for r92728.
https://bugs.webkit.org/show_bug.cgi?id=65916
* fast/forms/month/ValidityState-stepMismatch-month-expected.txt: Updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 10 Aug 2011 01:12:28 +0000 (01:12 +0000)]
DFG JIT does not speculative integers as aggressively as it should
https://bugs.webkit.org/show_bug.cgi?id=65949
Reviewed by Gavin Barraclough.
Added a tree walk to propagate integer predictions through arithmetic
expressions.
This is a 71% speed-up on Kraken's imaging-gaussian-blur, which
translates to a 19% speed-up on Kraken overall. It's neutral on
other benchmarks.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::predictInt32):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Wed, 10 Aug 2011 00:59:41 +0000 (00:59 +0000)]
[EFL] Sort signal comments by alphabetical order.
http://bugs.webkit.org/show_bug.cgi?id=65520
Reviewed by Kent Tamura.
Signals caused by ewk still are listed without any specific rule.
It sure isn't a nice thing to understand the signal list. So, this patch
lists signals by alphabetical order.
* ewk/ewk_contextmenu.h:
* ewk/ewk_frame.h:
* ewk/ewk_view.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 10 Aug 2011 00:51:11 +0000 (00:51 +0000)]
DFG JIT has no way of propagating predictions to loads and calls
https://bugs.webkit.org/show_bug.cgi?id=65883
Reviewed by Gavin Barraclough.
This introduces the capability to store predictions on graph
nodes. To save space while being somewhat consistent, the
prediction is always stored in the second OpInfo slot (since
a GetById will use the first one for the identifier). This
change is a natural extension of r92593 (global variable
prediction).
This is a 1.5% win on V8 in the arithmetic mean, and a 0.6%
win on V8 in the geometric mean. It is neutral on SunSpider
and Kraken. Interestingly, on V8 it regresses crypto by 3%
while progressing deltablue and richards by 2.6% and 4.3%,
respectively.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):
* dfg/DFGNode.h:
(JSC::DFG::isCellPrediction):
(JSC::DFG::isArrayPrediction):
(JSC::DFG::isInt32Prediction):
(JSC::DFG::isDoublePrediction):
(JSC::DFG::isNumberPrediction):
(JSC::DFG::predictionToString):
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasPrediction):
(JSC::DFG::Node::getPrediction):
(JSC::DFG::Node::predict):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 10 Aug 2011 00:36:19 +0000 (00:36 +0000)]
Add a missing </script> for r92728.
* fast/forms/month/ValidityState-stepMismatch-month.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 10 Aug 2011 00:30:50 +0000 (00:30 +0000)]
DFG JIT passes the this argument to constructors even though
it's not necessary
https://bugs.webkit.org/show_bug.cgi?id=65943
Reviewed by Gavin Barraclough.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 10 Aug 2011 00:28:48 +0000 (00:28 +0000)]
Fix one MIPS instruction to call JITStubThunked_##op
https://bugs.webkit.org/show_bug.cgi?id=65942
Patch by Chao-ying Fu <fu@mips.com> on 2011-08-09
Reviewed by Gavin Barraclough.
Changed "bal" to "jalr" for a possible processor mode change from
MIPS32 to MIPS16.
* jit/JITStubs.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Wed, 10 Aug 2011 00:28:46 +0000 (00:28 +0000)]
Unreviewed, mark 2 webaudio tests as failed on chromium win.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Wed, 10 Aug 2011 00:09:08 +0000 (00:09 +0000)]
WKPageCopyPendingAPIRequestURL returns stale result if policy decision set to Ignore
https://bugs.webkit.org/show_bug.cgi?id=65950
<rdar://problem/9925931>
Reviewed by Anders Carlsson.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
Call clearPendingAPIRequestURL() if the policy decision is PolicyIgnore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 10 Aug 2011 00:05:38 +0000 (00:05 +0000)]
Move <input type=month> tests to fast/forms/month/
https://bugs.webkit.org/show_bug.cgi?id=65916
Reviewed by Tony Chang.
* fast/forms/ValidityState-rangeOverflow-expected.txt: Removed month part.
* fast/forms/ValidityState-rangeUnderflow-expected.txt: Removed month part.
* fast/forms/ValidityState-stepMismatch-expected.txt: Removed month part.
* fast/forms/ValidityState-typeMismatch-month-expected.txt: Removed.
* fast/forms/ValidityState-typeMismatch-month.html: Removed.
* fast/forms/date-input-visible-strings-expected.txt: Removed month part.
* fast/forms/date-input-visible-strings.html: Removed month part.
* fast/forms/input-stepup-stepdown-expected.txt: Removed month part.
* fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Removed month part.
* fast/forms/input-type-change3-expected.txt: Removed month part.
* fast/forms/input-valueasdate-expected.txt: Removed.
* fast/forms/input-valueasdate-month-expected.txt: Removed.
* fast/forms/input-valueasdate-month.html: Removed.
* fast/forms/input-valueasdate.html: Removed.
* fast/forms/input-valueasnumber-month-expected.txt: Removed.
* fast/forms/input-valueasnumber-month.html: Removed.
* fast/forms/month: Added.
* fast/forms/month/ValidityState-rangeOverflow-month-expected.txt: Added.
* fast/forms/month/ValidityState-rangeOverflow-month.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js.
* fast/forms/month/ValidityState-rangeUnderflow-month-expected.txt: Added.
* fast/forms/month/ValidityState-rangeUnderflow-month.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js.
* fast/forms/month/ValidityState-stepMismatch-month-expected.txt: Added.
* fast/forms/month/ValidityState-stepMismatch-month.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
* fast/forms/month/ValidityState-typeMismatch-month-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-month-expected.txt.
* fast/forms/month/ValidityState-typeMismatch-month.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-month.js.
* fast/forms/month/input-valueasdate-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-expected.txt.
* fast/forms/month/input-valueasdate-month-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-month-expected.txt.
* fast/forms/month/input-valueasdate-month.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-month.js.
* fast/forms/month/input-valueasdate.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate.js.
* fast/forms/month/input-valueasnumber-month-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-month-expected.txt.
* fast/forms/month/input-valueasnumber-month.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-month.js.
* fast/forms/month/month-input-type-expected.txt: Added.
* fast/forms/month/month-input-type.html: Copied from LayoutTests/fast/forms/week/week-input-type.html.
* fast/forms/month/month-input-visible-string-expected.txt: Added.
* fast/forms/month/month-input-visible-string.html: Copied from LayoutTests/fast/forms/week/week-input-visible-string.html.
* fast/forms/month/month-stepup-stepdown-expected.txt: Added.
* fast/forms/month/month-stepup-stepdown-from-renderer-expected.txt: Added.
* fast/forms/month/month-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
* fast/forms/month/month-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
* fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed month part.
* fast/forms/script-tests/ValidityState-rangeUnderflow.js: Removed month part.
* fast/forms/script-tests/ValidityState-stepMismatch.js: Removed month part.
* fast/forms/script-tests/ValidityState-typeMismatch-month.js: Removed.
* fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed month part.
* fast/forms/script-tests/input-stepup-stepdown.js: Removed month part.
* fast/forms/script-tests/input-type-change3.js: Removed month part.
* fast/forms/script-tests/input-valueasdate-month.js: Removed.
* fast/forms/script-tests/input-valueasdate.js: Removed.
* fast/forms/script-tests/input-valueasnumber-month.js: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 9 Aug 2011 23:25:45 +0000 (23:25 +0000)]
Add the final batch of Lion specific SVG test results.
* platform/mac-snowleopard/svg/W3C-SVG-1.1: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png.
* platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Copied from platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Copied from platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt.
* platform/mac-snowleopard/svg/text: Added.
* platform/mac-snowleopard/svg/text/text-intro-05-t-expected.png: Copied from platform/mac/svg/text/text-intro-05-t-expected.png.
* platform/mac-snowleopard/svg/text/text-intro-05-t-expected.txt: Copied from platform/mac/svg/text/text-intro-05-t-expected.txt.
* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
* platform/mac/svg/text/text-intro-05-t-expected.png:
* platform/mac/svg/text/text-intro-05-t-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 9 Aug 2011 23:18:02 +0000 (23:18 +0000)]
Skip a couple of SVG tests that are missing parts of the content for some odd reason.
* platform/mac-lion/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 9 Aug 2011 22:52:36 +0000 (22:52 +0000)]
Add Lion tests results for a couple of bidi SVG tests.
* platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt.
* platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt.
* platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt.
* platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt.
* platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt.
* platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt.
* platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt.
* platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt.
* platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt.
* platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt.
* platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt.
* platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt.
* platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt.
* platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt.
* platform/mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt.
* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Tue, 9 Aug 2011 22:45:55 +0000 (22:45 +0000)]
Add a Radar number to a skipped test.
* platform/mac-lion/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 9 Aug 2011 22:39:09 +0000 (22:39 +0000)]
Broken link to LICENSE on contributing code page
https://bugs.webkit.org/show_bug.cgi?id=65947
Reviewed by Ryosuke Niwa.
* coding/contributing.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 9 Aug 2011 22:31:14 +0000 (22:31 +0000)]
Add an expected result for svg/W3C-I18N/text-anchor-dirLTR-anchorEnd.svg and check if it's
possible to have a pixel test result in a different platform directory from a text result.
* platform/mac-snowleopard/svg/W3C-I18N: Added.
* platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt.
* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 9 Aug 2011 22:12:01 +0000 (22:12 +0000)]
new-run-webkit-test's WinPort has no fallback logic
https://bugs.webkit.org/show_bug.cgi?id=64486
Reviewed by Adam Roben.
I've tried to write a patch for bug 64439 twice now, and both times
I've ended up re-writing half the port system. So I'm breaking
things up into smaller pieces, this being the first.
WinPort still does not have any port_name parsing, so when instantiated
with the name "win-xp" (i.e. by the rebaseline server) it will just behave as the 'win' port.
I'll fix this in a second pass when I standardize port_name parsing for all webkit ports.
Otherwise this should "just work" for windows. I've not been able to test the
version detection on my mac, but the unit tests show the code behaving as designed.
* Scripts/webkitpy/layout_tests/port/win.py:
* Scripts/webkitpy/layout_tests/port/win_unittest.py: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 9 Aug 2011 22:10:27 +0000 (22:10 +0000)]
Add a WebKit prefix to the user default.
Reviewed by Dan Bernstein.
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Tue, 9 Aug 2011 22:09:07 +0000 (22:09 +0000)]
Fix gtest to compile in the release configuration with clang.
This change was made upstream in r443.
* gtest/src/gtest.cc:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 9 Aug 2011 21:53:59 +0000 (21:53 +0000)]
Tweak an expected result.
* platform/mac-snowleopard/fast/loader/file-url-mimetypes-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 9 Aug 2011 21:52:55 +0000 (21:52 +0000)]
Add a user default to disable the plug-in process message timeout
https://bugs.webkit.org/show_bug.cgi?id=65945
Reviewed by Adam Roben.
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
Add a disablePluginProcessMessageTimeout member variable.
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
Initialize the disablePluginProcessMessageTimeout member variable from the
"DisablePluginProcessMessageTimeout" user default.
* WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::defaultSyncMessageTimeout):
Return NoTimeout if WebProcess::disablePluginProcessMessageTimeout returns true.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):
Initialize m_disablePluginProcessMessageTimeout.
* WebProcess/WebProcess.h:
(WebKit::WebProcess::disablePluginProcessMessageTimeout):
Add getter.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Tue, 9 Aug 2011 21:52:39 +0000 (21:52 +0000)]
Switch RenderBlock to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=65396
Reviewed by Eric Seidel.
No new tests, no new functionality.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::setLogicalLeftForChild):
(WebCore::RenderBlock::setLogicalTopForChild):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::flipFloatForWritingMode):
(WebCore::RenderBlock::isPointInOverflowControl):
(WebCore::RenderBlock::hitTestFloats):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalTopForFloat):
(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::logicalLeftForFloat):
(WebCore::RenderBlock::logicalRightForFloat):
(WebCore::RenderBlock::logicalWidthForFloat):
(WebCore::RenderBlock::setLogicalTopForFloat):
(WebCore::RenderBlock::setLogicalLeftForFloat):
(WebCore::RenderBlock::setLogicalHeightForFloat):
(WebCore::RenderBlock::setLogicalWidthForFloat):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 9 Aug 2011 21:38:57 +0000 (21:38 +0000)]
DFG JIT failure loading web site
https://bugs.webkit.org/show_bug.cgi?id=65930
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
Put the use() call after the fpr()/gpr() calls, since doing otherwise
breaks the register allocator.
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
LayoutTests:
Reviewed by Oliver Hunt.
Reproduced the failure seen in
http://www.skinnytaste.com/2011/06/ricotta-cheese-chocolate-chip-muffins.html
* fast/js/boxed-double-to-int-expected.txt: Added.
* fast/js/boxed-double-to-int.html: Added.
* fast/js/script-tests/boxed-double-to-int.js: Added.
(boxedDoubleToInt):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jpfau@apple.com [Tue, 9 Aug 2011 21:32:04 +0000 (21:32 +0000)]
Initial pass at a new XML tree builder
https://bugs.webkit.org/show_bug.cgi?id=65803
Reviewed by Adam Barth.
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* xml/parser/NewXMLDocumentParser.cpp:
(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::~NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::append):
(WebCore::NewXMLDocumentParser::finish):
(WebCore::NewXMLDocumentParser::finishWasCalled):
* xml/parser/NewXMLDocumentParser.h:
* xml/parser/XMLTreeBuilder.cpp: Added.
(WebCore::XMLTreeBuilder::XMLTreeBuilder):
(WebCore::XMLTreeBuilder::processToken):
(WebCore::XMLTreeBuilder::pushCurrentNode):
(WebCore::XMLTreeBuilder::popCurrentNode):
(WebCore::XMLTreeBuilder::processProcessingInstruction):
(WebCore::XMLTreeBuilder::processXMLDeclaration):
(WebCore::XMLTreeBuilder::processDOCTYPE):
(WebCore::XMLTreeBuilder::processStartTag):
(WebCore::XMLTreeBuilder::processEndTag):
(WebCore::XMLTreeBuilder::processCharacter):
(WebCore::XMLTreeBuilder::processCDATA):
(WebCore::XMLTreeBuilder::processComment):
(WebCore::XMLTreeBuilder::processEntity):
(WebCore::XMLTreeBuilder::processNamespaces):
(WebCore::XMLTreeBuilder::processAttributes):
(WebCore::XMLTreeBuilder::processXMLEntity):
(WebCore::XMLTreeBuilder::processHTMLEntity):
(WebCore::XMLTreeBuilder::add):
(WebCore::XMLTreeBuilder::appendToText):
(WebCore::XMLTreeBuilder::enterText):
(WebCore::XMLTreeBuilder::exitText):
(WebCore::XMLTreeBuilder::NodeStackItem::NodeStackItem):
(WebCore::XMLTreeBuilder::NodeStackItem::hasNamespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::namespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::setNamespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::namespaceForPrefix):
* xml/parser/XMLTreeBuilder.h: Added.
(WebCore::XMLTreeBuilder::create):
(WebCore::XMLTreeBuilder::NodeStackItem::namespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::setNamespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::node):
(WebCore::XMLTreeBuilder::NodeStackItem::setNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 9 Aug 2011 21:21:20 +0000 (21:21 +0000)]
Teach build.webkit.org's garden-o-matic how to talk to the local server
https://bugs.webkit.org/show_bug.cgi?id=65940
Reviewed by Dimitri Glazkov.
After this patch, the version of garden-o-matic on build.webkit.org is
fully functional. It can interact with the local server via CORS.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
* Scripts/webkitpy/tool/commands/gardenomatic.py:
* Scripts/webkitpy/tool/servers/gardeningserver.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 9 Aug 2011 21:17:42 +0000 (21:17 +0000)]
Enable CORS for garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=65936
Reviewed by Dimitri Glazkov.
This patch will allow the hosted instance of garden-o-matic to
communicate with the local server.
* Scripts/webkitpy/tool/servers/gardeningserver.py:
* Scripts/webkitpy/tool/servers/reflectionhandler.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 9 Aug 2011 20:46:17 +0000 (20:46 +0000)]
Add ParentClass typedef in all JSC classes
https://bugs.webkit.org/show_bug.cgi?id=65731
Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-09
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
Just added the Base typedefs in all the classes that are a subclass of JSCell
to point at their parent classes. This is a change to support future changes to the way
constructors and destructors are implemented in JS objects, among other things.
* API/JSCallbackConstructor.h:
* API/JSCallbackFunction.h:
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::createStructure):
(JSC::JSCallbackObject::visitChildren):
* API/JSCallbackObjectFunctions.h:
(JSC::::asCallbackObject):
(JSC::::JSCallbackObject):
(JSC::::init):
(JSC::::className):
(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertyDescriptor):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::getConstructData):
(JSC::::construct):
(JSC::::hasInstance):
(JSC::::getCallData):
(JSC::::call):
(JSC::::getOwnPropertyNames):
(JSC::::toNumber):
(JSC::::toString):
(JSC::::setPrivate):
(JSC::::getPrivate):
(JSC::::inherits):
(JSC::::getStaticValue):
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):
* debugger/DebuggerActivation.h:
* jsc.cpp:
* runtime/Arguments.h:
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.h:
* runtime/BooleanConstructor.h:
* runtime/BooleanObject.h:
* runtime/BooleanPrototype.h:
* runtime/DateConstructor.h:
* runtime/DateInstance.h:
* runtime/DatePrototype.h:
* runtime/Error.cpp:
* runtime/ErrorConstructor.h:
* runtime/ErrorInstance.h:
* runtime/ErrorPrototype.h:
* runtime/ExceptionHelpers.cpp:
* runtime/Executable.h:
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.h:
* runtime/GetterSetter.h:
* runtime/InternalFunction.h:
* runtime/JSAPIValueWrapper.h:
* runtime/JSActivation.h:
* runtime/JSArray.h:
* runtime/JSFunction.h:
* runtime/JSGlobalObject.h:
* runtime/JSNotAnObject.h:
* runtime/JSONObject.h:
* runtime/JSObject.h:
* runtime/JSPropertyNameIterator.h:
* runtime/JSStaticScopeObject.h:
* runtime/JSString.h:
* runtime/JSVariableObject.h:
* runtime/JSWrapperObject.h:
* runtime/MathObject.h:
* runtime/NativeErrorConstructor.h:
* runtime/NativeErrorPrototype.h:
* runtime/NumberConstructor.h:
* runtime/NumberObject.h:
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.h:
* runtime/ObjectPrototype.h:
* runtime/RegExp.h:
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
* runtime/RegExpObject.h:
(JSC::RegExpObject::create):
* runtime/RegExpPrototype.h:
* runtime/ScopeChain.h:
* runtime/StrictEvalActivation.h:
* runtime/StringConstructor.h:
* runtime/StringObject.h:
* runtime/StringObjectThatMasqueradesAsUndefined.h:
* runtime/StringPrototype.h:
* runtime/Structure.h:
* runtime/StructureChain.h:
Source/JavaScriptGlue:
Just added the Base typedefs in all the classes that are a subclass of JSCell
to point at their parent classes. This is a change to support future changes to the way
constructors and destructors are implemented in JS objects, among other things.
* JSRun.h:
* UserObjectImp.h:
Source/WebCore:
No new tests.
Just added the Base typedefs in all the classes that are a subclass of JSCell
to point at their parent classes. This is a change to support future changes to the way
constructors and destructors are implemented in JS objects, among other things.
* bindings/js/JSAudioConstructor.h:
* bindings/js/JSImageConstructor.h:
* bindings/js/JSOptionConstructor.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateConstructorDeclaration):
* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestInterface.h:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
* bridge/c/CRuntimeObject.h:
* bridge/c/c_instance.cpp:
* bridge/jni/jsc/JavaInstanceJSC.cpp:
* bridge/jni/jsc/JavaRuntimeObject.h:
* bridge/objc/ObjCRuntimeObject.h:
* bridge/objc/objc_runtime.h:
* bridge/qt/qt_instance.cpp:
* bridge/qt/qt_pixmapruntime.cpp:
* bridge/qt/qt_runtime.h:
* bridge/runtime_array.h:
* bridge/runtime_method.h:
* bridge/runtime_object.h:
* bridge/testqtbindings.cpp:
(Global::className):
Source/WebKit/mac:
Just added the Base typedefs in all the classes that are a subclass of JSCell
to point at their parent classes. This is a change to support future changes to the way
constructors and destructors are implemented in JS objects, among other things.
* Plugins/Hosted/ProxyInstance.mm:
* Plugins/Hosted/ProxyRuntimeObject.h:
Source/WebKit2:
Just added the Base typedefs in all the classes that are a subclass of JSCell
to point at their parent classes. This is a change to support future changes to the way
constructors and destructors are implemented in JS objects, among other things.
* WebProcess/Plugins/Netscape/JSNPMethod.h:
* WebProcess/Plugins/Netscape/JSNPObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 9 Aug 2011 20:41:12 +0000 (20:41 +0000)]
Add updated media test results for Lion.
* platform/mac-snowleopard/media: Added.
* platform/mac-snowleopard/media/controls-strict-expected.png: Copied from platform/mac/media/controls-strict-expected.png.
* platform/mac-snowleopard/media/controls-strict-expected.txt: Copied from platform/mac/media/controls-strict-expected.txt.
* platform/mac-snowleopard/media/video-controls-rendering-expected.png: Copied from platform/mac/media/video-controls-rendering-expected.png.
* platform/mac-snowleopard/media/video-controls-rendering-expected.txt: Copied from platform/mac/media/video-controls-rendering-expected.txt.
* platform/mac-snowleopard/media/video-display-toggle-expected.png: Copied from platform/mac/media/video-display-toggle-expected.png.
* platform/mac-snowleopard/media/video-display-toggle-expected.txt: Copied from platform/mac/media/video-display-toggle-expected.txt.
* platform/mac-snowleopard/media/video-layer-crash-expected.png: Copied from platform/mac/media/video-layer-crash-expected.png.
* platform/mac-snowleopard/media/video-layer-crash-expected.txt: Copied from platform/mac/media/video-layer-crash-expected.txt.
* platform/mac-snowleopard/media/video-no-audio-expected.png: Copied from platform/mac/media/video-no-audio-expected.png.
* platform/mac-snowleopard/media/video-no-audio-expected.txt: Copied from platform/mac/media/video-no-audio-expected.txt.
* platform/mac/media/controls-strict-expected.png:
* platform/mac/media/controls-strict-expected.txt:
* platform/mac/media/video-controls-rendering-expected.png:
* platform/mac/media/video-controls-rendering-expected.txt:
* platform/mac/media/video-display-toggle-expected.png:
* platform/mac/media/video-display-toggle-expected.txt:
* platform/mac/media/video-layer-crash-expected.png:
* platform/mac/media/video-no-audio-expected.png:
* platform/mac/media/video-no-audio-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Tue, 9 Aug 2011 20:26:15 +0000 (20:26 +0000)]
Add more Web Audio layout tests
https://bugs.webkit.org/show_bug.cgi?id=65786
Reviewed by Kenneth Russell.
* webaudio/audiobuffersource-expected.wav: Added.
* webaudio/audiobuffersource-playbackrate-expected.wav: Added.
* webaudio/audiobuffersource-playbackrate.html: Added.
* webaudio/audiobuffersource.html: Added.
* webaudio/mixing-expected.wav: Added.
* webaudio/mixing.html: Added.
* webaudio/resources/hyper-reality: Added.
* webaudio/resources/hyper-reality/br-jam-loop.wav: Added.
* webaudio/resources/hyper-reality/laughter.wav: Added.
* webaudio/sample-accurate-scheduling-expected.txt: Added.
* webaudio/sample-accurate-scheduling.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 9 Aug 2011 20:18:05 +0000 (20:18 +0000)]
More Lion skipped list goodness.
* platform/mac-lion/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 9 Aug 2011 19:58:47 +0000 (19:58 +0000)]
Upgrade jquery in TestFailures
https://bugs.webkit.org/show_bug.cgi?id=65935
Reviewed by Dimitri Glazkov.
Upgrade to a newer version of jQuery with better support for CORS and CSP.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 9 Aug 2011 19:42:26 +0000 (19:42 +0000)]
[Chromium] Enable rubber banding when scrolling.
https://bugs.webkit.org/show_bug.cgi?id=65707
Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-09
Reviewed by Dimitri Glazkov.
Source/WebCore:
No new tests since this is just syncing changes to chromium platform.
* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):
Source/WebKit/chromium:
* features.gypi:
* public/WebInputEvent.h:
(WebKit::WebMouseWheelEvent::WebMouseWheelEvent):
(WebKit::WebGestureEvent::WebGestureEvent):
* public/mac/WebInputEventFactory.h:
* src/WebInputEventConversion.cpp:
(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
* src/WebInputEventConversion.h:
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::GestureEvent):
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::gestureEvent):
(WebKit::WebViewImpl::handleInputEvent):
* src/WebViewImpl.h:
* src/mac/WebInputEventFactory.mm:
(WebKit::gestureEventTypeForEvent):
(WebKit::phaseForNSEventPhase):
(WebKit::phaseForEvent):
(WebKit::momentumPhaseForEvent):
(WebKit::WebInputEventFactory::mouseWheelEvent):
(WebKit::WebInputEventFactory::gestureEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Tue, 9 Aug 2011 19:29:21 +0000 (19:29 +0000)]
Web Inspector: XHRs end up in the resources panel.
https://bugs.webkit.org/show_bug.cgi?id=60321
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/resource-tree/resource-tree-no-xhrs.html
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
LayoutTests:
* http/tests/inspector/console-xhr-logging-expected.txt:
* http/tests/inspector/resource-tree/resource-tree-no-xhrs-expected.txt: Added.
* http/tests/inspector/resource-tree/resource-tree-no-xhrs.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Tue, 9 Aug 2011 19:27:24 +0000 (19:27 +0000)]
Add testing for --force-compositing-mode to windows.internal
https://bugs.webkit.org/show_bug.cgi?id=65777
Reviewed by Adam Barth.
.:
Add exports for Document::settings().
* Source/autotools/symbols.filter:
Source/WebCore:
Test: platform/chromium/compositing/force-compositing-mode/force-composite-empty.html
Move initial initialization to settings caching function so that RLC
picks up changes to the force compositing mode flag.
* WebCore.exp.in:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
* testing/Internals.cpp:
(WebCore::Internals::setForceCompositingMode):
* testing/Internals.h:
* testing/Internals.idl:
Source/WebKit2:
Add exports for Document::settings().
* win/WebKit2.def:
* win/WebKit2CFLite.def:
LayoutTests:
Add empty page to test that the root gets a graphics layer.
* platform/chromium/compositing/force-compositing-mode/force-composite-empty-expected.txt: Added.
* platform/chromium/compositing/force-compositing-mode/force-composite-empty.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 9 Aug 2011 19:13:45 +0000 (19:13 +0000)]
Fixing 65868 REGRESSION(r92610) caused by 65668 - Optimize floating elements lookup
https://bugs.webkit.org/show_bug.cgi?id=65871
PerformanceTests:
Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-09
Reviewed by Dave Hyatt.
* Layout/floats.html: Added the nested divs, so that we can test the propagation impact of the floats tree.
Source/WebCore:
Added an interval tree in the FloatingObjects structure. Also added new mechanisms to make
sure the tree is updated correctly when a float is repositioned.
Changed the PODIntervalTree to support giving a search adapter that can be implemented by the
client. I'm not adding a different bug for that because PODIntervalTree is not used anywhere else
and would be hard to test that the change is not breaking anything.
Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-09
Reviewed by Dave Hyatt.
No new tests, just a refactor on the floating objects data structure.
* WebCore.xcodeproj/project.pbxproj:
* platform/PODIntervalTree.h:
(WebCore::PODIntervalSearchAdapter::PODIntervalSearchAdapter):
(WebCore::PODIntervalSearchAdapter::lowValue):
(WebCore::PODIntervalSearchAdapter::highValue):
(WebCore::PODIntervalSearchAdapter::collectIfNeeded):
(WebCore::PODIntervalTree::PODIntervalTree):
(WebCore::PODIntervalTree::allOverlaps):
(WebCore::PODIntervalTree::allOverlapsWithAdapter):
(WebCore::PODIntervalTree::searchForOverlapsFrom):
* platform/PODRedBlackTree.h:
(WebCore::PODRedBlackTree::PODRedBlackTree):
(WebCore::PODRedBlackTree::clear):
(WebCore::PODRedBlackTree::isInitialized):
(WebCore::PODRedBlackTree::initIfNeeded):
(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::remove):
(WebCore::PODRedBlackTree::contains):
(WebCore::PODRedBlackTree::visitInorder):
(WebCore::PODRedBlackTree::size):
(WebCore::PODRedBlackTree::checkInvariants):
(WebCore::PODRedBlackTree::dump):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::::collectIfNeeded):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::addPositionedFloats):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::hasOverhangingFloat):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::FloatingObjects::clear):
(WebCore::RenderBlock::FloatingObjects::intervalForFloatingObject):
(WebCore::RenderBlock::FloatingObjects::addPlacedObject):
(WebCore::RenderBlock::FloatingObjects::removePlacedObject):
(WebCore::RenderBlock::FloatingObjects::add):
(WebCore::RenderBlock::FloatingObjects::remove):
(WebCore::RenderBlock::FloatingObjects::computePlacedFloatsTree):
(WebCore::::string):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::setX):
(WebCore::RenderBlock::FloatingObject::setY):
(WebCore::RenderBlock::FloatingObject::setWidth):
(WebCore::RenderBlock::FloatingObject::setHeight):
(WebCore::RenderBlock::FloatingObject::setFrameRect):
(WebCore::RenderBlock::FloatingObject::isInPlacedTree):
(WebCore::RenderBlock::FloatingObject::setIsInPlacedTree):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::lowValue):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::highValue):
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
(WebCore::RenderBlock::FloatingObjects::setHorizontalWritingMode):
(WebCore::RenderBlock::FloatingObjects::set):
(WebCore::RenderBlock::FloatingObjects::placedFloatsTree):
(WebCore::RenderBlock::FloatingObjects::computePlacedFloatsTreeIfNeeded):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::positionNewFloatOnLine):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 9 Aug 2011 19:10:32 +0000 (19:10 +0000)]
Source/WebCore: Repeated copy and paste result in nested font elements
https://bugs.webkit.org/show_bug.cgi?id=65824
Reviewed by Tony Chang.
Modified isInlineNodeWithStyle to match font element. Also made the function match strictly with those nodes that
ApplyStyleCommand may add to avoid removing non-styling elements. And fixed a regression from r81887 that
ReplaceSelectionCommand may remove non-editing styles such as border in the attempt to avoid nesting styling elements.
This patch paves the way to fix the bug 34564.
Tests: editing/pasteboard/paste-text-with-style-2.html
editing/pasteboard/paste-text-with-style-3.html
editing/pasteboard/paste-text-with-style-4.html
* editing/EditingStyle.cpp:
(WebCore::HTMLElementEquivalent::matches): Takes const Element* instead of Element*.
(WebCore::HTMLAttributeEquivalent::matches): Ditto.
(WebCore::htmlElementEquivalents): Extracted from conflictsWithImplicitStyleOfElement.
(WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Calls htmlElementEquivalents.
(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent): Added; determines whether an element is style span
or a styling element (e.g. b, i, font) possibly with editing style.
* editing/EditingStyle.h:
* editing/ReplaceSelectionCommand.cpp:
(WebCore::isInlineNodeWithStyle): Calls EditingStyle::elementIsStyledSpanOrHTMLEquivalent.
(WebCore::ReplaceSelectionCommand::doApply): More aggressively avoid nesting styling elements.
* editing/htmlediting.cpp:
(WebCore::highestEnclosingNodeOfType):
* editing/htmlediting.h:
LayoutTests: Repeated copy and paste result in nested style elements such as b and font
https://bugs.webkit.org/show_bug.cgi?id=65824
Reviewed by Tony Chang.
Added tests to ensure WebKit does not nest styling elements and does not remove elements with non-editing styles.
Also rebaselined several tests.
Because WebKit serializes all editing inheritable styles on copy, we should be able to remove all inline styles
at the insertion point on paste. And this patch removes inline style elements such as font and b more aggressively.
WebKit erroneously bolded the last words in paste-after-inline-style-element.html and paste-with-redundant-style.html
before this change set but this is no longer the case.
* editing/pasteboard/5065605-expected.txt: Lost wrapping font and span elements.
* editing/pasteboard/merge-end-1-expected.txt: Span is split but visually identical.
* editing/pasteboard/merge-end-2-expected.txt: Ditto.
* editing/pasteboard/paste-after-inline-style-element-expected.txt: No longer bolds "line 2" erroneously.
* editing/pasteboard/paste-text-011-expected.txt: Lost wrapping font, b, and span elements.
* editing/pasteboard/paste-text-with-style-2-expected.txt: Added.
* editing/pasteboard/paste-text-with-style-2.html: Added.
* editing/pasteboard/paste-text-with-style-3-expected.txt: Added.
* editing/pasteboard/paste-text-with-style-3.html: Added.
* editing/pasteboard/paste-text-with-style-4-expected.txt: Added.
* editing/pasteboard/paste-text-with-style-4.html: Added.
* editing/pasteboard/paste-with-redundant-style-expected.txt: Lost wrapping b.
* editing/pasteboard/paste-with-redundant-style.html: Updated comments per rebaseline.
* platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dslomov@google.com [Tue, 9 Aug 2011 19:01:05 +0000 (19:01 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=65778
[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates.
Reviewed by Dmitry Titov.
Covered by existing tests.
* bindings/v8/V8Binding.cpp:
(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):
* bindings/v8/V8Binding.h:
(WebCore::V8BindingPerIsolateData::lazyEventListenerToStringTemplate):
(WebCore::V8BindingPerIsolateData::hiddenPropertyName):
(WebCore::V8BindingPerIsolateData::globalHandleMap):
(WebCore::AllowAllocation::AllowAllocation):Moving to V8Binding.h from V8Utilities.h to resolve header dependency.
(WebCore::AllowAllocation::~AllowAllocation):
(WebCore::AllowAllocation::current):
(WebCore::SafeAllocation::newInstance):
* bindings/v8/V8GCController.cpp:
(WebCore::currentGlobalHandleMap):
(WebCore::enumerateGlobalHandles):
(WebCore::V8GCController::registerGlobalHandle):
(WebCore::V8GCController::unregisterGlobalHandle):
* bindings/v8/V8HiddenPropertyName.cpp:
(WebCore::V8HiddenPropertyName::createString):
* bindings/v8/V8HiddenPropertyName.h:
(WebCore::V8HiddenPropertyName::V8HiddenPropertyName):
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8NPObject.cpp:
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::checkNewLegal):
* bindings/v8/V8Utilities.h:
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::initIsolate):
* bindings/v8/WorkerContextExecutionProxy.h:
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::scheduleExecutionTermination):
Source/WebKit/chromium: https://bugs.webkit.org/show_bug.cgi?id=65778
[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates
Reviewed by Dmitry Titov.
* src/BoundObject.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Tue, 9 Aug 2011 18:36:47 +0000 (18:36 +0000)]
JavaString is not needed by V8
https://bugs.webkit.org/show_bug.cgi?id=65909
Removes the JavaString wrapper class, moves the JSC implementation
to JavaStringJSC.h and removes the V8 implementation.
Reviewed by Alexey Proskuryakov.
No new tests, refactoring only.
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bridge/jni/JavaString.h: Removed.
* bridge/jni/jni_jsobject.mm:
* bridge/jni/jsc/JavaFieldJSC.h:
* bridge/jni/jsc/JavaInstanceJSC.cpp:
* bridge/jni/jsc/JavaMethodJSC.h:
* bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaString::JavaString):
(JSC::Bindings::JavaString::~JavaString):
(JSC::Bindings::JavaString::init):
* bridge/jni/v8/JavaStringV8.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Tue, 9 Aug 2011 18:18:36 +0000 (18:18 +0000)]
Source/WebCore: Regression(83075): Fix updateAlwaysCreateLineBoxes on information
about full layout which is needed when dirtying lineboxes.
https://bugs.webkit.org/show_bug.cgi?id=65924
Reviewed by Dave Hyatt.
Test: fast/inline/update-always-create-line-boxes-full-layout-crash.html
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
* rendering/RenderInline.h:
LayoutTests: Tests that we do not crash when trying to dirty line boxes on
a RenderInline needing full relayout.
https://bugs.webkit.org/show_bug.cgi?id=65924
Reviewed by Dave Hyatt.
* fast/inline/update-always-create-line-boxes-full-layout-crash-expected.txt: Added.
* fast/inline/update-always-create-line-boxes-full-layout-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Tue, 9 Aug 2011 18:05:30 +0000 (18:05 +0000)]
2011-08-09 Nate Chapin <japhet@chromium.org>
Remove receivedCancellation() from SubresourceLoaderClient.
http://bugs.webkit.org/show_bug.cgi?id=65330
Reviewed by Alexey Proskuryakov.
No new tests, no change in functionality intended.
* loader/DocumentThreadableLoader.cpp:
* loader/DocumentThreadableLoader.h:
* loader/SubresourceLoader.cpp:
* loader/SubresourceLoader.h:
* loader/SubresourceLoaderClient.h:
* loader/ThreadableLoaderClient.h:
* loader/WorkerThreadableLoader.cpp:
* loader/WorkerThreadableLoader.h:
* notifications/Notification.cpp:
* notifications/Notification.h: Remove receivedCancellation() since it's
identical to didFail(), which is always called immediately after.
* workers/WorkerScriptLoader.cpp:
* workers/WorkerScriptLoader.h: Remove receivedCancellation() since it's
identical to didFail(), which is always called immediately after.
* xml/XMLHttpRequest.cpp:
* xml/XMLHttpRequest.h: Remove receivedCancellation(). All it does is
set m_response, which is cleared in didFail() before it can be used.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 9 Aug 2011 17:08:28 +0000 (17:08 +0000)]
2011-08-09 Pavel Feldman <pfeldman@google.com>
Not reviewed: rebaselining inspector test.
* inspector/debugger/scripts-panel-expected.txt:
* inspector/debugger/scripts-panel.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc