WebKit-https.git
12 years ago2008-05-08 Timothy Hatcher <timothy@apple.com>
timothy@apple.com [Thu, 8 May 2008 20:00:17 +0000 (20:00 +0000)]
2008-05-08  Timothy Hatcher  <timothy@apple.com>

        Fixes the bug where the Web Inspector could not
        find any localization strings.

        Reviewed by Mark Rowe.

        * WebCore.xcodeproj/project.pbxproj: Add the localizedStrings.js
        file to the WebCore Copy Resources phase. Also removes an idl from
        the Copy Resources phase.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
mitz@apple.com [Thu, 8 May 2008 19:04:54 +0000 (19:04 +0000)]
    Reviewed by Adam Roben.

        - fix <rdar://problem/5697957> "No recent searches" label in a narrow search field's history popup is truncated

        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::calculatePositionAndSize): Changed to use a bold
        font for measuring labels.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoffrey Garen.
mitz@apple.com [Thu, 8 May 2008 18:54:39 +0000 (18:54 +0000)]
    Reviewed by Geoffrey Garen.

        - cross-platform fix for http://bugs.webkit.org/show_bug.cgi?id=17590
          ASSERTION FAILED: subject in jsRegExpExecute()

        * page/Frame.cpp:
        (WebCore::Frame::matchLabelsAgainstElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Thu, 8 May 2008 18:11:43 +0000 (18:11 +0000)]
2008-05-08  Mark Rowe  <mrowe@apple.com>

        Reviewed by Sam Weinig.

        Add a link to the Mac OS Forge terms of use.

        * nav.inc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Holger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Thu, 8 May 2008 14:58:01 +0000 (14:58 +0000)]
2008-05-08  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Simon.

        Simple ImageBuffer::image implementation.

        In contrast to cg and cairo we do not use a special BitmapImage because
        the ownership of the FrameData inside the BitmapImage is a bit backward
        (actually owned by the ImageDecoderQt...). Further work is needed for image
        and pixmap handling in the qt port...

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Holger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Thu, 8 May 2008 14:57:35 +0000 (14:57 +0000)]
2008-05-08  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Simon.

        Update the WebKit.qrc of the inspector to be functional again

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 8 May 2008 13:53:11 +0000 (13:53 +0000)]
2008-05-08  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Fix the Qt/Mac build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWarwick Allison <warwick@trolltech.com>
hausmann@webkit.org [Thu, 8 May 2008 10:40:09 +0000 (10:40 +0000)]
Warwick Allison <warwick@trolltech.com>

Fixes: WebKit expects initial input method state to be *disabled*.

At least QWS does not need the initial input method state to be forced to
enabled, but other platforms (esp. X11) do. Until fixed/tested on those
platforms, this is specific to QWS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Thu, 8 May 2008 09:39:35 +0000 (09:39 +0000)]
2008-05-08  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Use native Windows library handling (instead of QLibrary)
        for Qt/Win32's PlatformModule.

        * platform/FileSystem.h:
        (WebCore::PlatformModuleVersion::PlatformModuleVersion):
        * platform/qt/FileSystemQt.cpp:
        (WebCore::unloadModule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Thu, 8 May 2008 09:38:24 +0000 (09:38 +0000)]
2008-05-08  Simon Hausmann  <hausmann@webkit.org>

        Reviewed and found by Holger.

        Include .css in the list of extensions for text/css. Fixes
        fast/loader/local-css-allowed-in-strict-mode.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-08 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Thu, 8 May 2008 07:45:01 +0000 (07:45 +0000)]
2008-05-08  Simon Hausmann  <hausmann@webkit.org>

        Fix the Qt and Wx build when compiling without offline app support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Thu, 8 May 2008 03:28:48 +0000 (03:28 +0000)]
2008-05-07  Stephanie Lewis  <slewis@apple.com>

        fix messed up result

        * fast/events/onunload-not-on-body-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 8 May 2008 02:13:39 +0000 (02:13 +0000)]
2008-05-07  Sam Weinig  <sam@webkit.org>

        Reviewed by Adele Peterson

        Update MessageEvent to match the latest version of the HTML5 spec,
        adding the lastEventId attribute.

        * dom/MessageEvent.cpp:
        (WebCore::MessageEvent::MessageEvent):
        (WebCore::MessageEvent::initMessageEvent):
        * dom/MessageEvent.h:
        (WebCore::MessageEvent::lastEventId):
        * dom/MessageEvent.idl:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::postMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Thu, 8 May 2008 01:05:19 +0000 (01:05 +0000)]
2008-05-07  Stephanie Lewis <slewis@apple.com>

        Reviewed by Maciej.

        remove non-functioning code.  If onunload should be fired from these nodes then
        a WindowEventListener needs to be set.  However, Firefox and IE also do not
        fire onunload events for these cases.

        Test: fast/events/onunload-not-on-body.html

        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::parseMappedAttribute):
        * html/HTMLObjectElement.cpp
        (WebCore::HTMLObjectElement::parseMappedAttribute):

        Test onunload attr on a frame does not call onunload, but that an onunload attr on the body of
        a frame does.  Also test that onunloads on object elements are not called.

        * fast/events/onunload-not-on-body-expected.txt: Added.
        * fast/events/onunload-not-on-body.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Wed, 7 May 2008 20:44:42 +0000 (20:44 +0000)]
WebCore:

        Reviewed by John Sullivan.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18909
          <rdar://problem/5914165> REGRESSION (r31872-r31878): Viewed photos not closing completely at indycar.com

        Test: fast/dynamic/positioned-movement-with-positioned-children.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutOnlyPositionedObjects): Cover the case of
        a positioned object that has only moved and has only positioned children
        that have changed.
        * rendering/RenderObject.h:
        (WebCore::RenderObject::needsPositionedMovementLayout): Added this
        accessor.

LayoutTests:

        Reviewed by John Sullivan.

        - test for https://bugs.webkit.org/show_bug.cgi?id=18909
          <rdar://problem/5914165> REGRESSION (r31872-r31878): Viewed photos not closing completely at indycar.com

        * fast/dynamic/positioned-movement-with-positioned-children.html: Added.
        * platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.checksum: Added.
        * platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.png: Added.
        * platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 7 May 2008 20:41:34 +0000 (20:41 +0000)]
2008-05-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by John.

        When no document loaders are associated with an application cache group,
        release the reference to the newest cache group. This prevents reference cycles.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::ApplicationCacheGroup):
        (WebCore::ApplicationCacheGroup::documentLoaderDestroyed):
        (WebCore::ApplicationCacheGroup::cacheDestroyed):
        * loader/appcache/ApplicationCacheGroup.h:

        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::cacheGroupForURL):
        Return early if the datbase wasn't open.

        (WebCore::ApplicationCacheStorage::loadCache):
        Add error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 7 May 2008 19:42:34 +0000 (19:42 +0000)]
2008-05-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Don't put pages with an application cache in the BF cache.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::canCachePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Wed, 7 May 2008 18:59:37 +0000 (18:59 +0000)]
WebCore:

2008-05-07  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John Sullivan.

        <rdar://problem/5666354> Crashes in Mail at WebCore::RemoveNodeCommand::doApply

        When a single tab or series of tabs was copied, we weren't putting them into a
        tab span.  On Paste, we would be given a text node with a single tab or series
        of tabs in it, and we would crash when inserting it at the start of a block
        (where that kind of text becomes completely unrendered).

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): Clean
        up correctly and early return if we removed everything that was inserted.
        * editing/markup.cpp:
        (WebCore::createMarkup):  Include the tab span when the only thing copied
        was a tab or a series of tabs.

LayoutTests:

2008-05-07  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John Sullivan.

        <rdar://problem/5666354> Crashes in Mail at WebCore::RemoveNodeCommand::doApply

        * editing/pasteboard/5761530-1-expected.txt: Added.
        * editing/pasteboard/5761530-1.html: Added.
        * editing/pasteboard/5761530-2-expected.txt: Added.
        * editing/pasteboard/5761530-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 7 May 2008 18:02:46 +0000 (18:02 +0000)]
2008-05-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        REGRESSION (3.1.1-TOT): Arrow keys are sticky in Google Maps street view
        https://bugs.webkit.org/show_bug.cgi?id=18880
        <rdar://problem/5909513>

        Stop suspending key up events before calling handleEvent.

        * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
        (WebNetscapePluginEventHandlerCarbon::sendEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdded radar to changelog for r32959.
ddkilzer@apple.com [Wed, 7 May 2008 17:33:19 +0000 (17:33 +0000)]
Added radar to changelog for r32959.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Wed, 7 May 2008 17:16:03 +0000 (17:16 +0000)]
2008-05-07  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Adam Roben.

        wx & Gtk build fix.

        Add SIZE_MAX definition for the wx port.

        * os-win32/stdint.h:

2008-05-07  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Adam Roben.

        wx & Gtk build fix.

        * platform/network/curl/FormDataStreamCurl.cpp: Added stdint.h include. We need to define
        __STDC_LIMIT_MACROS to have SIZE_MAX exported.
        * platform/network/curl/FormDataStreamCurl.h: Removed cstdint include (replaced by stdint.h)
        as it is not present on the build bots.
        * plugins/gtk/PluginDatabaseGtk.cpp: Added missing #endif.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
ddkilzer@apple.com [Wed, 7 May 2008 17:11:46 +0000 (17:11 +0000)]
WebCore:

        Bug 18900: Password field has focus but can't type text (i.rememberthemilk.com)
        <https://bugs.webkit.org/show_bug.cgi?id=18900>

        Original patch by Aaron Golden and Tim Omernick.  Reviewed by Adele.

        Test: fast/forms/textfield-to-password-on-focus.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setInputType): If the current node has
        focus, call updateFocusAppearance() to make sure its state is correct
        after changing its type.

LayoutTests:

        Bug 18900: Password field has focus but can't type text (i.rememberthemilk.com)
        <https://bugs.webkit.org/show_bug.cgi?id=18900>

        Reviewed by Adele.

        * fast/forms/textfield-to-password-on-focus-expected.txt: Added.
        * fast/forms/textfield-to-password-on-focus.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/4867889> REGRESSION: "Choose File.." buttons are exposed as AXGroup...
cfleizach@apple.com [Wed, 7 May 2008 16:35:48 +0000 (16:35 +0000)]
<rdar://problem/4867889> REGRESSION: "Choose File.." buttons are exposed as AXGroup instead of AXButton

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Wed, 7 May 2008 14:21:40 +0000 (14:21 +0000)]
2008-05-07  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Add ~250 tests that fail to the skipped list so we have a sane baseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Wed, 7 May 2008 13:05:27 +0000 (13:05 +0000)]
2008-05-07  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Bug 17971: [Curl] FormData processing should be moved to its own class

        Move FormData treatment into FormDataStream. The aim is to have FormDataStream behave like a stream that cURL
        could manipulate.

        First step into having complete file uploading facility in cURL.

        No test case as it is only code refactoring.

        * GNUmakefile.am: Add FormDataStreamCurl.cpp
        * platform/network/ResourceHandleInternal.h: Move code to FormStreamDataCurl.h
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/curl/FormDataStreamCurl.cpp: Added.
        (WebCore::FormDataStream::~FormDataStream):
        (WebCore::FormDataStream::read):
        * platform/network/curl/FormDataStreamCurl.h: Added.
        (WebCore::FormDataStream::FormDataStream):
        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::readCallback): Move code to FormDataStreamCurl.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Adam Treat <treat@kde.org>
hausmann@webkit.org [Wed, 7 May 2008 12:28:42 +0000 (12:28 +0000)]
2008-05-07  Adam Treat  <treat@kde.org>

        Reviewed by Simon.

        https://bugs.webkit.org/show_bug.cgi?id=18898

        Fixed wrong transform being used for creating the pixmap for a new
        transparency layer. This fixes the popup menus on dell.com.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 7 May 2008 12:10:01 +0000 (12:10 +0000)]
2008-05-07  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Share the plug-in directories between Gtk and Qt/X11 port.

        * platform/qt/FileSystemQt.cpp:
        (WebCore::homeDirectoryPath): Implement it for Qt.
        * plugins/PluginDatabase.cpp:
        (WebCore::addMozillaPluginDirectories): Shared code.
        (WebCore::PluginDatabase::defaultPluginDirectories):
        (WebCore::PluginDatabase::isPreferredPluginDirectory): Shared code.
        * plugins/gtk/PluginDatabaseGtk.cpp:
        (WebCore::PluginDatabase::isPreferredPluginDirectory): Refactored.
        * plugins/qt/PluginDatabaseQt.cpp: Refactored.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Wed, 7 May 2008 11:46:01 +0000 (11:46 +0000)]
2008-05-07  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Fix build issues on Mac and refeactor the .pro file a bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Wed, 7 May 2008 11:45:30 +0000 (11:45 +0000)]
2008-05-07  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Draw scrollview corners (between scrollbars) using the Qt style.

        https://bugs.webkit.org/show_bug.cgi?id=18894

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Use File::Find and Getopt::Long in make-js-test-wrappers
ddkilzer@apple.com [Wed, 7 May 2008 09:50:58 +0000 (09:50 +0000)]
    Use File::Find and Getopt::Long in make-js-test-wrappers

        Reviewed by Darin.

        * Scripts/make-js-test-wrappers:
        - Updated Apple copyright statement.
        - Added command-line switch parsing and -h|--help switch.
        - Allowed user to pass list of files/directories on which to do
          a restricted search for TEMPLATE.html files.  The default
          behavior is still to search the entire LayoutTests directory.
        - Removed duplicate 'use strict' statement.
        - Replaced use of `find` statements with File::Find::find().
        - Remove unneeded chomp() calls now that we use File::Find.
        (directoryFilter): Added.  Filters .svn directories when used
        with File::Find::find().
        (findTemplateFiles): Added.  Returns a list of TEMPLATE.html
        files found.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Wed, 7 May 2008 09:37:29 +0000 (09:37 +0000)]
2008-05-07  Simon Hausmann  <hausmann@webkit.org>

        Fix the Qt build, added AccessibilityListBox and ListBoxOption.cpp to
        the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 7 May 2008 09:37:13 +0000 (09:37 +0000)]
2008-05-07  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Support for isMainThread in the Qt port.

        * wtf/ThreadingQt.cpp:
        (WTF::initializeThreading): Adjusted.
        (WTF::isMainThread): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 7 May 2008 09:36:59 +0000 (09:36 +0000)]
2008-05-07  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Holger.

        Fix building without storage support.

        * page/PageGroup.cpp:
        (WebCore::PageGroup::closeLocalStorage): proper #if

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-07 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 7 May 2008 09:36:39 +0000 (09:36 +0000)]
2008-05-07  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Oliver Hunt.

        Fix building without accessibility.

        * page/AXObjectCache.cpp:
        (WebCore::AXObjectCache::selectedChildrenChanged): proper #if

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Wed, 7 May 2008 06:33:25 +0000 (06:33 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix <rdar://problem/5914544> Crash in layoutInlineChildren()

        Test: fast/block/float/float-on-zero-height-line.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::markLinesDirtyInVerticalRange):

LayoutTests:

        Reviewed by Darin Adler.

        - test for <rdar://problem/5914544> Crash in layoutInlineChildren()

        * fast/block/float/float-on-zero-height-line.html: Added.
        * platform/mac/fast/block/float/float-on-zero-height-line-expected.checksum: Added.
        * platform/mac/fast/block/float/float-on-zero-height-line-expected.png: Added.
        * platform/mac/fast/block/float/float-on-zero-height-line-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Wed, 7 May 2008 06:16:14 +0000 (06:16 +0000)]
2008-05-06  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Andersca.

        prepare for plugin fast teardown work - make WebPluginDatabase a objective C++ file.

        * Plugins/WebPluginDatabase.m: Removed.
        * Plugins/WebPluginDatabase.mm: Copied from WebKit/mac/Plugins/WebPluginDatabase.m.
        * Plugins/npapi.m: Removed.
        * Plugins/npapi.mm: Copied from WebKit/mac/Plugins/npapi.m.

        prepare for plugin fast teardown work - make WebPluginDatabase a objective C++ file.

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
alice.liu@apple.com [Wed, 7 May 2008 05:35:24 +0000 (05:35 +0000)]
WebCore:

2008-05-06  Alice Liu  <alice.liu@apple.com>

        Reviewed by Adele Peterson and John Sullivan.

        changes needed to build on Windows after r32911 and r32927

        * WebCore.vcproj/WebCore.vcproj:
        * page/AXObjectCache.cpp:
        (WebCore::AXObjectCache::selectedChildrenChanged):
        * page/AccessibilityObject.h:
        (WebCore::AccessibilityObject::document):
        (WebCore::AccessibilityObject::topDocumentFrameView):
        (WebCore::AccessibilityObject::documentFrameView):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::document):
        (WebCore::AccessibilityRenderObject::topDocumentFrameView):
        (WebCore::AccessibilityRenderObject::documentFrameView):
        * page/AccessibilityRenderObject.h:
        * page/mac/AXObjectCacheMac.mm:
        * page/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper position]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

WebKit/win:

2008-05-06  Alice Liu  <alice.liu@apple.com>

        Reviewed by Adele Peterson and John Sullivan.

        changes needed to build on Windows after r32911 and r32927

        * AccessibleBase.cpp:
        (AccessibleBase::get_accParent):
        * AccessibleDocument.cpp:
        (AccessibleDocument::document):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 7 May 2008 05:31:34 +0000 (05:31 +0000)]
2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Fix a few bugs with the final sync'ing of LocalStorageAreas when the thread is shut down.
        1 - A sync task actually needs to be scheduled for each LocalStorageArea when the shut down occurs.
        2 - Pending sync timers all need to be cancelled.

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::storageArea):
        (WebCore::LocalStorage::close): Tell each LocalStorageArea to schedule it's final sync before scheduling
          thread termination.
        * storage/LocalStorage.h:  Change the map to be of LocalStorageAreas instead of StorageAreas

        * storage/LocalStorageArea.cpp:
        (WebCore::LocalStorageArea::LocalStorageArea):
        (WebCore::LocalStorageArea::~LocalStorageArea): ASSERT the timer has been cancelled, but make SURE it is
          in release builds.
        (WebCore::LocalStorageArea::scheduleFinalSync): Cancel the sync timer, schedule the final sync, and set the
          "final sync scheduled" flag
        (WebCore::LocalStorageArea::scheduleItemForSync): ASSERT that the final sync hasn't already been scheduled
        (WebCore::LocalStorageArea::scheduleClear): Ditto
        * storage/LocalStorageArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix. Adding files added in r32925 to the bakefiles.
kevino@webkit.org [Wed, 7 May 2008 04:42:48 +0000 (04:42 +0000)]
wx build fix. Adding files added in  r32925 to the bakefiles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Alp Toker <alp@nuanti.com>
alp@webkit.org [Wed, 7 May 2008 02:10:49 +0000 (02:10 +0000)]
2008-05-06  Alp Toker  <alp@nuanti.com>

        GTK+ build fix. Add empty stub to keep non-accessible ports building.

        * page/AXObjectCache.h:
        (WebCore::AXObjectCache::selectedChildrenChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Wed, 7 May 2008 01:47:47 +0000 (01:47 +0000)]
2008-05-06  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin.

        Fix for <rdar://problem/5907916> Implement 'aria-labeledby' and
        'aria-describedby' attributes.

        * html/HTMLAttributeNames.in: Added new attributes. Added both the
        British spelling (since that is what is specified in the spec), and
        the American spelling (since the bug filer and I are two Americans
        who keep spelling it the American way by accident).
        * page/AccessibilityObject.cpp: Added empty wrappers. These
        functions can't do anything meaningful without a renderer.
        (WebCore::AccessibilityObject::ariaAccessiblityName):
        (WebCore::AccessibilityObject::ariaLabeledByAttribute):
        (WebCore::AccessibilityObject::ariaDescribedByAttribute):
        * page/AccessibilityObject.h:

        Here is where the real work is done.
        * page/AccessibilityRenderObject.h:
        * page/AccessibilityRenderObject.cpp:
        (WebCore::accessibleNameForNode): Takes a node and finds its
        contribution to the accessible name, as defined by the Mozilla ARIA
        Implementer's Guide.
        (WebCore::AccessibilityRenderObject::ariaAccessiblityName): Takes a
        string of space-separated IDs, fetches the corresponding element
        for each ID, and concatenates an accessible name based on the
        elements.
        (WebCore::AccessibilityRenderObject::ariaLabeledByAttribute):
        Retrieve the labeledby attribute and send its contents to
        ariaAccessibilityName().
        (WebCore::AccessibilityRenderObject::title): Return the ARIA
        labeledby value if one exists.
        (WebCore::AccessibilityRenderObject::ariaDescribedByAttribute):
        Retrieve the describedby attribute and send its contents to
        ariaAccessibilityName().
        (WebCore::AccessibilityRenderObject::accessibilityDescription):
        Return the ARIA describedby attribute if one exists.

        These are two bugs I spotted.
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Don't
        ignore anything with an ARIA role.
        (WebCore::AccessibilityRenderObject::roleValue): Button tags maps
        to ButtonRole.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix tyop
andersca@apple.com [Wed, 7 May 2008 01:28:07 +0000 (01:28 +0000)]
Fix tyop

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 7 May 2008 01:27:53 +0000 (01:27 +0000)]
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady.

        Support reading back app caches from the datbase.

        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::ApplicationCache):
        Initialize m_storageID to 0.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::cacheDestroyed):
        If the cache being destroyed is not the newest cache, it should no longer be
        stored in the database. Remove it.

        (WebCore::ApplicationCacheGroup::setNewestCache):
        Don't store the cache here.

        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
        Store it here instead.

        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::loadCacheGroup):
        New method that loads a cache group with a given manifest URL (or returns 0 if the load fails).

        (WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
        Search for the group in the database.

        (WebCore::ApplicationCacheStorage::loadManifestHostHashes):
        New method that loads the host hashes from the database.

        (WebCore::ApplicationCacheStorage::cacheGroupForURL):
        Search in the database for a cache that contains the resource.

        (WebCore::ApplicationCacheStorage::loadCache):
        New method that loads a cache with a given ID.

        (WebCore::ApplicationCacheStorage::remove):
        New method that removes a cache.

        * loader/appcache/ApplicationCacheStorage.h:
        Add definitions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Alp Toker <alp@nuanti.com>
alp@webkit.org [Wed, 7 May 2008 01:21:22 +0000 (01:21 +0000)]
2008-05-06  Alp Toker  <alp@nuanti.com>

        Partial GTK+ build fix. Add files from r32925 to the build and replace
        'nil' return with 0.

        * GNUmakefile.am:
        * page/AccessibilityListBoxOption.cpp:
        (WebCore::AccessibilityListBoxOption::parentObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 7 May 2008 00:52:56 +0000 (00:52 +0000)]
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        Add NPN_PopUpContextMenu example.

        * NetscapeCocoaPlugin/MenuHandler.h: Added.
        * NetscapeCocoaPlugin/MenuHandler.m: Added.
        (-[MenuHandler _openURL:]):
        (-[MenuHandler _disabledItem:]):
        (-[MenuHandler validateUserInterfaceItem:]):
        (-[MenuHandler initWithBrowserFuncs:instance:]):
        (-[MenuHandler dealloc]):
        (-[MenuHandler menu]):
        * NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj:
        * NetscapeCocoaPlugin/main.m:
        (NPP_Destroy):
        (handleMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 7 May 2008 00:32:36 +0000 (00:32 +0000)]
2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        Make LocalStorage persistent using a SQLite database.

        There's a few things going on here.  Whenever an item is changed, we add it to a set of
        "items to be sync'ed."  Instead of immediately scheduling the sync'ing on the background
        thread, we set a "sync timer" instead.  This is to shield against a series of rapid changes
        to avoid thread churn.

        When the sync timer fires, we move the "items to be sync'ed" set to a background thread set
        and schedule the sync task which is where the items are actually committed to disk.

        Current design for reading items back in from disk is to be as aggressive as possible.
        When a page first accesses it's LocalStorage area, we begin to import all items in from disk so
        they are immediately available.  A future enhancement will be to being this pre-fetching the
        moment we start loading a page when we know that page has LocalStorage.

        * storage/LocalStorageArea.cpp:
        (WebCore::LocalStorageArea::LocalStorageArea):
        (WebCore::LocalStorageArea::length): Return the length, or wait for the import to complete then return it.
        (WebCore::LocalStorageArea::key): Return the key, or wait for the import to complete then return it.
        (WebCore::LocalStorageArea::getItem): Return the item, or wait for the import to complete then return it.
        (WebCore::LocalStorageArea::setItem): Set the item, or hold the import lock and set it.  The second case is
          because if the item is set while the import is still in progress, the new value should override whatever
          the imported value is.
        (WebCore::LocalStorageArea::removeItem): Remove the item, or hold the import lock and remove it.  See the
          explanation for setItem()
        (WebCore::LocalStorageArea::contains): Return whether or not the item is contained.  Do the same dance with
          the import flag, import lock, and import condition that the above methods do.

        (WebCore::LocalStorageArea::itemChanged): Schedule the item for sync'ing
        (WebCore::LocalStorageArea::itemRemoved): Schedule the removal of the item for sync'ing
        (WebCore::LocalStorageArea::areaCleared): Schedule the clear for sync'ing, and clear all previously
          scheduled items.

        (WebCore::LocalStorageArea::scheduleItemForSync): Add an item to the sync set.
        (WebCore::LocalStorageArea::scheduleClear): Set a bool flag denoting "All items removed."  If any
          items are later set before the actual removal takes place, they will be written *after* the removal.
        (WebCore::LocalStorageArea::syncTimerFired): Move the current sync-set to the background thread sync set, then
          schedule a sync task.  Also transfer the "items cleared" flag to the "background thread items cleared" flag
        (WebCore::LocalStorageArea::performImport): Import all items from disk, then signal the import complete.
        (WebCore::LocalStorageArea::markImported): Set the imported flag and signal the import complete
        (WebCore::LocalStorageArea::performSync): If the clear flag is set then drop all items.  Then update or delete
          each item waiting to be sync'ed
        * storage/LocalStorageArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 6 May 2008 23:42:56 +0000 (23:42 +0000)]
2008-05-06  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Mitz Pettel RTL

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::fullDatabaseFilename): Filename extensions for localstorage = all lowercase

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 6 May 2008 23:32:49 +0000 (23:32 +0000)]
2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin, Sam Weinig, and Anders

        Preparation for upcoming work making LocalStorage persistent.

        The final step before code that actually does storage and retrieval of LocalStorage items.

        The LocalStorage set is responsible for controlling the path and filenames that individual
        LocalStorageAreas will use for their persistent store.  This adds the ability to return that
        filename.

        Also, add the scheduling methods that LocalStorageArea will use for importing and syncing
        it's persistent items.

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::storageArea):  Add some comments re: the future direction of this
          method once we actually do quota tracking.
        (WebCore::LocalStorage::fullDatabaseFilename):
        (WebCore::LocalStorage::scheduleImport):
        (WebCore::LocalStorage::scheduleSync):
        * storage/LocalStorage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agordar://problem/5408464> REGRESSION: Unable to use Voiceover on combo boxes (disneyjob...
cfleizach@apple.com [Tue, 6 May 2008 23:27:40 +0000 (23:27 +0000)]
rdar://problem/5408464> REGRESSION: Unable to use Voiceover on combo boxes (disneyjobs.com)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5455287> AXWebArea should include AXURL
cfleizach@apple.com [Tue, 6 May 2008 22:44:25 +0000 (22:44 +0000)]
<rdar://problem/5455287> AXWebArea should include AXURL

Now it does

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Tue, 6 May 2008 22:17:24 +0000 (22:17 +0000)]
2008-05-06  Alice Liu  <alice.liu@apple.com>

        Rubber-stamped by Beth

        stab-in-the-dark attempt at fixing non-mac builds.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCoreSources.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWhoops, I did not intend to commit this right now.
andersca@apple.com [Tue, 6 May 2008 22:16:59 +0000 (22:16 +0000)]
Whoops, I did not intend to commit this right now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 6 May 2008 22:15:52 +0000 (22:15 +0000)]
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Only use the toplevel application cache when loading subframes.

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Tue, 6 May 2008 22:00:05 +0000 (22:00 +0000)]
WebCore:

2008-05-06  Adam Barth  <abarth-webkit@adambarth.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=18725
        Implement asynchronous postMessage.
        MessageEvent no longer bubbles as per r1237 in the HTML 5 working draft.

        Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.

        Test: http/tests/security/postMessage/delivery-order.html

        * dom/MessageEvent.cpp:
        (WebCore::MessageEvent::MessageEvent):
        * page/DOMWindow.cpp:
        (WebCore::PostMessageTimer::PostMessageTimer):
        (WebCore::PostMessageTimer::event):
        (WebCore::PostMessageTimer::targetOrigin):
        (WebCore::PostMessageTimer::fired):
        (WebCore::DOMWindow::postMessage):
        (WebCore::DOMWindow::postMessageTimerFired):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

LayoutTests:

2008-05-06  Adam Barth  <abarth-webkit@adambarth.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=18725
        Update tests for asynchronous postMessage.

        Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.

        * http/tests/messaging/cross-domain-message-send.html:
        * http/tests/messaging/resources/cross-domain-message-receive.html:
        * http/tests/security/cross-frame-access-delete.html:
        * http/tests/security/cross-frame-access-history-put.html:
        * http/tests/security/cross-frame-access-location-put.html:
        * http/tests/security/postMessage/delivery-order-expected.txt: Added.
        * http/tests/security/postMessage/delivery-order.html: Added.
        * http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
        * http/tests/security/postMessage/invalid-origin-throws-exception.html:
        * http/tests/security/postMessage/origin-unaffected-by-base-tag-expected.txt:
        * http/tests/security/postMessage/origin-unaffected-by-base-tag.html:
        * http/tests/security/postMessage/origin-unaffected-by-document-domain-expected.txt:
        * http/tests/security/postMessage/origin-unaffected-by-document-domain.html:
        * http/tests/security/postMessage/resources/javascript-post-message-sender.html:
        * http/tests/security/postMessage/resources/post-message-listener.html:
        * http/tests/security/postMessage/resources/recv.js: Added.
        * http/tests/security/postMessage/target-origin-expected.txt:
        * http/tests/security/postMessage/target-origin.html:
        * http/tests/security/resources/cross-frame-iframe-for-delete-test.html:
        * http/tests/security/resources/cross-frame-iframe-for-history-put-test.html:
        * http/tests/security/resources/cross-frame-iframe-for-location-put-test.html:
        * http/tests/security/resources/xss-eval3.html:
        * http/tests/security/xss-eval.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 6 May 2008 21:01:32 +0000 (21:01 +0000)]
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady.

        Store cache to the database.

        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::addResource):
        If the cache has been saved to disk, save the resource as well.

        * loader/appcache/ApplicationCache.h:
        (WebCore::ApplicationCache::onlineWhitelist):
        New method which returns the online whitelist.

        (WebCore::ApplicationCache::setStorageId):
        (WebCore::ApplicationCache::storageId):
        Setter/getter for the application cache storage ID.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
        Save the cache/group to disk.

        * loader/appcache/ApplicationCacheGroup.h:
        (WebCore::ApplicationCacheGroup::setStorageID):
        (WebCore::ApplicationCacheGroup::storageID):
        Setter/getter for the application cache group storage ID.

        * loader/appcache/ApplicationCacheResource.cpp:
        (WebCore::ApplicationCacheResource::addType):
        We can't add a new type if the resource has been saved to disk.

        * loader/appcache/ApplicationCacheResource.h:
        (WebCore::ApplicationCacheResource::setStorageID):
        (WebCore::ApplicationCacheResource::storageID):
        Setter/getter for the application cache resource storage ID.

        * loader/appcache/ApplicationCacheStorage.cpp:
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::executeSQLCommand):
        New method for executing SQL and logging any errors.

        (WebCore::ApplicationCacheStorage::openDatabase):
        Create new tables.

        (WebCore::ApplicationCacheStorage::executeStatement):
        New method for executing an SQL statement and logging any errors.

        (WebCore::ApplicationCacheStorage::store):
        New methods for storing a cache group, cache and cache resource to the store.

        (WebCore::ApplicationCacheStorage::storeNewestCache):
        New method which stores the newest cache and updates the newest cache field in the cache group.

        * loader/appcache/ApplicationCacheStorage.h:
        Add new methods.

        * platform/sql/SQLiteStatement.h:
        (WebCore::SQLiteStatement::query):
        Getter for the SQL query.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 6 May 2008 20:47:58 +0000 (20:47 +0000)]
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Initialize numArchs to 0.

        * Plugins/WebBasePluginPackage.m:
        (-[WebBasePluginPackage isNativeLibraryData:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 6 May 2008 20:46:51 +0000 (20:46 +0000)]
2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        Preparation for upcoming work making LocalStorage persistent.

        Writing persistent values for LocalStorage will take place on a background thread.
        Here is that background thread, as well as most of the hooks that will be utilized to
        make the whole song and dance work.

        The thread itself is very simple and MessageQueue based.  LocalStorageTasks are what
        mark the work that needs to be done and come in 5 flavors:  Import and Sync a LocalStorage set,
        Import and Sync a LocalStorageArea, and terminate the thread.

        This patch accomplished 2 things:

        1 - Each PageGroup has its own LocalStorage set.  Upon its creation its LocalStorageThread is
            created and started.

        2 - At application shutdown, each thread is synchronously terminated.

        What happens between steps 1 and 2 will come later.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:

        * storage/LocalStorage.cpp: Add some threading ASSERTs to make it clear which thread each
          method is meant to be called from.
        (WebCore::LocalStorage::LocalStorage):
        (WebCore::LocalStorage::storageArea):
        (WebCore::LocalStorage::performImport): Placeholder for importing known origins and quotas
        (WebCore::LocalStorage::performSync): Placeholder for writing out updated origins and quotas
        (WebCore::LocalStorage::close): Synchronously terminate the thread.
        * storage/LocalStorage.h:

        * storage/LocalStorageArea.cpp: Add some threading ASSERTs to make it clear which thread each
          method is meant to be called from.
        (WebCore::LocalStorageArea::itemChanged):
        (WebCore::LocalStorageArea::itemRemoved):
        (WebCore::LocalStorageArea::areaCleared):
        (WebCore::LocalStorageArea::dispatchStorageEvent):
        (WebCore::LocalStorageArea::performImport): Placeholder for importing all items for this
          LocalStorageArea to prime the page before the items are needed
        (WebCore::LocalStorageArea::performSync): Placeholder for writing out dirty items to disk
        * storage/LocalStorageArea.h:

        * storage/LocalStorageTask.cpp: Added.
        (WebCore::LocalStorageTask::LocalStorageTask):
        (WebCore::LocalStorageTask::performTask):
        * storage/LocalStorageTask.h: Added.
        (WebCore::LocalStorageTask::):
        (WebCore::LocalStorageTask::createImport):
        (WebCore::LocalStorageTask::createSync):
        (WebCore::LocalStorageTask::createTerminate):

        * storage/LocalStorageThread.cpp: Added.
        (WebCore::LocalStorageThread::create):
        (WebCore::LocalStorageThread::LocalStorageThread):
        (WebCore::LocalStorageThread::start):
        (WebCore::LocalStorageThread::localStorageThreadStart):
        (WebCore::LocalStorageThread::localStorageThread):
        (WebCore::LocalStorageThread::scheduleImport):
        (WebCore::LocalStorageThread::scheduleSync):
        (WebCore::LocalStorageThread::terminate):
        (WebCore::LocalStorageThread::performTerminate):
        * storage/LocalStorageThread.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 6 May 2008 20:40:45 +0000 (20:40 +0000)]
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Add implementation of NPN_PopUpContextMenu.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView popUpContextMenu:]):
        * Plugins/WebBaseNetscapePluginViewPrivate.h:
        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage load]):
        * Plugins/npapi.m:
        (NPN_PopUpContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 6 May 2008 20:40:22 +0000 (20:40 +0000)]
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Add NPN_PopUpContextMenu.

        * bridge/npapi.h:
        * plugins/npfunctions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Alp Toker <alp@nuanti.com>
alp@webkit.org [Tue, 6 May 2008 20:35:53 +0000 (20:35 +0000)]
2008-05-06  Alp Toker  <alp@nuanti.com>

        GTK+ build fix. Add file from r32911 to the build.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber stamped by Alp.
christian@webkit.org [Tue, 6 May 2008 20:21:44 +0000 (20:21 +0000)]
     Rubber stamped by Alp.

         Back out 17626. It wasn't ready for commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Gwenole Beauchesne <gbeauchesne@splitted-desktop.org>
alp@webkit.org [Tue, 6 May 2008 20:17:12 +0000 (20:17 +0000)]
2008-05-06  Gwenole Beauchesne  <gbeauchesne@splitted-desktop.org>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=18906
        [GTK] Fix varargs terminator in g_build_filename()

        * plugins/gtk/PluginDatabaseGtk.cpp:
        (WebCore::PluginDatabase::isPreferredPluginDirectory): Fix varargs
        terminator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 6 May 2008 18:44:05 +0000 (18:44 +0000)]
2008-05-06  Kevin McCullough  <kmccullough@apple.com>

        - Forgot to update localized Strings from previous checkin.

        * English.lproj/localizedStrings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5408464> REGRESSION: Unable to use Voiceover on combo boxes (disneyjo...
cfleizach@apple.com [Tue, 6 May 2008 18:39:48 +0000 (18:39 +0000)]
<rdar://problem/5408464> REGRESSION: Unable to use Voiceover on combo boxes (disneyjobs.com)
<rdar://problem/5895634> AX: AccessibilityObjectWrapper is being leaked all over the place
<rdar://problem/5893907> CrashTracer: [REGRESSION] 44 crashes in Safari at com.apple.WebCore: WebCore::AccessibilityObject::clearChildren + 9

Initial prep work to support accessibility objects that do not have renderers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 6 May 2008 18:16:30 +0000 (18:16 +0000)]
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Fix typo (don't read random memory).

        * Plugins/WebBasePluginPackage.m:
        (-[WebBasePluginPackage isNativeLibraryData:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 6 May 2008 17:55:50 +0000 (17:55 +0000)]
2008-05-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Change the isNativeLibraryData: method to handle universal binaries.

        * Plugins/WebBasePluginPackage.m:
        (swapIntsInHeader):
        (-[WebBasePluginPackage isNativeLibraryData:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Jon, Tim and Mark.
andersca@apple.com [Tue, 6 May 2008 17:54:58 +0000 (17:54 +0000)]
    Reviewed by Jon, Tim and Mark.

        Add a sample NPAPI plugin that uses the Cocoa event model.

        * .: Added.
        * ChangeLog: Added.
        * NetscapeCocoaPlugin: Added.
        * NetscapeCocoaPlugin/English.lproj: Added.
        * NetscapeCocoaPlugin/English.lproj/InfoPlist.strings: Added.
        * NetscapeCocoaPlugin/Info.plist: Added.
        * NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Added.
        * NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj: Added.
        * NetscapeCocoaPlugin/main.m: Added.
        (NP_Initialize):
        (NP_GetEntryPoints):
        (NP_Shutdown):
        (NPP_New):
        (NPP_Destroy):
        (NPP_SetWindow):
        (NPP_NewStream):
        (NPP_DestroyStream):
        (NPP_WriteReady):
        (NPP_Write):
        (NPP_StreamAsFile):
        (NPP_Print):
        (handleDraw):
        (eventType):
        (invalidatePlugin):
        (handleMouseEvent):
        (handleKeyboardEvent):
        (NPP_HandleEvent):
        (NPP_URLNotify):
        (NPP_GetValue):
        (NPP_SetValue):
        * NetscapeCocoaPlugin/test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Rob Buis.
rwlbuis@webkit.org [Tue, 6 May 2008 17:32:54 +0000 (17:32 +0000)]
    Reviewed by Rob Buis.

        https://bugs.webkit.org/show_bug.cgi?id=18859\
        Prevented SVGRootInlineBox from static_casting a
        node to a class it doesn't inherit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Tue, 6 May 2008 17:28:24 +0000 (17:28 +0000)]
WebCore:

2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        Preparation for upcoming work making LocalStorage persistent.

        When the application terminates, all pending local storage writes need to be
        sync'ed out to disk.
        This works n combination with platform specific code in WebKit that calls it.

        * WebCore.base.exp:

        * page/PageGroup.cpp:
        (WebCore::PageGroup::closeLocalStorage): Close all open LocalStorage objects
        * page/PageGroup.h:

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::close): Placeholder for what will sync and terminate the
          local storage thread in the future.
        * storage/LocalStorage.h:

WebKit/mac:

2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        Preparation for upcoming work making LocalStorage persistent.

        When the application terminates, all LocalStorage areas must be sync'ed out to disk first.

        * WebView/WebView.mm:
        (+[WebView _applicationWillTerminate]):  Close all LocalStorage areas before quitting.

WebKit/win:

2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        Preparation for upcoming work making LocalStorage persistent.

        When the application terminates, all LocalStorage areas must be sync'ed out to disk first.

        * WebKitDLL.cpp:
        (shutDownWebKit): Close all LocalStorage areas before quitting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 6 May 2008 17:24:44 +0000 (17:24 +0000)]
2008-05-06  Brady Eidson  <beidson@apple.com>

        Rubberstamped by David Kilzer

        * WebCore.base.exp:  Sort this mess!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 6 May 2008 17:07:35 +0000 (17:07 +0000)]
2008-05-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by John.

        Add preference for enabling the offline web application cache.

        * Interfaces/IWebPreferencesPrivate.idl:
        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):
        (WebPreferences::setOfflineWebApplicationCacheEnabled):
        (WebPreferences::offlineWebApplicationCacheEnabled):
        * WebPreferences.h:
        * WebView.cpp:
        (WebView::notifyPreferencesChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLanding an updated test that was supposed to be part of r32879.
ap@webkit.org [Tue, 6 May 2008 14:21:06 +0000 (14:21 +0000)]
Landing an updated test that was supposed to be part of r32879.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-06 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Tue, 6 May 2008 13:12:42 +0000 (13:12 +0000)]
2008-05-06  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Holger.

        Fix logic error in QWebHitTestResult::isNull().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix 60 crashes seen on the buildbots that were misreported as hangs.
mrowe@apple.com [Tue, 6 May 2008 05:01:24 +0000 (05:01 +0000)]
Fix 60 crashes seen on the buildbots that were misreported as hangs.

Reviewed by Dan Bernstein.

* dom/Document.cpp:
(WebCore::Document::detachNodeIterator): Null-check page() before dereferencing it.
(WebCore::Document::nodeWillBeRemoved): Ditto.
(WebCore::Document::textInserted): Ditto.
(WebCore::Document::textNodesMerged): Ditto.
(WebCore::Document::textRemoved): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 6 May 2008 04:09:17 +0000 (04:09 +0000)]
2008-05-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel RTL

        Preparation for upcoming work making LocalStorage persistent.

        The other half of the StorageMap::importItem() addition.

        * storage/StorageArea.cpp:
        (WebCore::StorageArea::importItem):
        * storage/StorageArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 6 May 2008 04:03:06 +0000 (04:03 +0000)]
2008-05-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel RTL

        Preparation for upcoming work making LocalStorage persistent.

        - Create the LocalStorage object for a PageGroup the moment the first Page is added to it
          The Settings of the first Page define what persistent path the LocalStorage will use
        - Add a Frame argument for the LocalStorageArea request - this will allow a client object
          to be queried before the LocalStorageArea is established

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::localStorage):

        * page/PageGroup.cpp:
        (WebCore::PageGroup::addPage):
        (WebCore::PageGroup::localStorage):

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::LocalStorage): Take the path as a constructor argument.  Deep copy
          the path as it will be used from another thread.
        (WebCore::LocalStorage::storageArea):
        * storage/LocalStorage.h:
        (WebCore::LocalStorage::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 6 May 2008 03:14:22 +0000 (03:14 +0000)]
2008-05-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel RTL

        Preparation for upcoming work making LocalStorage persistent.

        StorageMaps normally have copy-on-write semantics to help support SessionStorage.
        For LocalStorage, we never want this behavior.  When we forcefully import items into
        a StorageMap from the LocalStorage background thread, this new import method will be used.

        * storage/StorageMap.cpp:
        (WebCore::StorageMap::importItem): Add a deep-copy of the item to the map without worrying
          about copy-on-write.
        * storage/StorageMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Copy dependencies of ImageDiff, DumpRenderTree in post-build step.
sfalken@apple.com [Tue, 6 May 2008 00:45:03 +0000 (00:45 +0000)]
    Copy dependencies of ImageDiff, DumpRenderTree in post-build step.

        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/ImageDiff.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 6 May 2008 00:01:19 +0000 (00:01 +0000)]
2008-05-05  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        -<rdar://problem/5770054> JavaScript profiler (10928)
        -Begininings of a UI for the Profiler in the WebInspector.

        * English.lproj/InspectorLocalizedStrings.js: Add new strings to be
        localized.
        * page/inspector/DatabasesPanel.js: Changed the name of the Databae's
        results table to be more generic as it is now also used by the profiler.
        * page/inspector/Images/glossySelected.png: Added.
        * page/inspector/Images/profilesIcon.png: Added.
        * page/inspector/Images/treeUpTriangleBlack.png: Added.
        * page/inspector/Images/treeUpTriangleWhite.png: Added.
        * page/inspector/ProfileView.js: Added. Sets up the header of the table.
        * page/inspector/ProfilesPanel.js: Added.
        * page/inspector/ProfilesPanel.js: Added. Sets up the containers of the
        profiler's content.
        * page/inspector/inspector.css: Change database-result-table to be more
        generic as well as add the styles needed by the profiler.
        * page/inspector/inspector.html: Add profiler support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 5 May 2008 23:42:43 +0000 (23:42 +0000)]
2008-05-05  Brady Eidson  <beidson@apple.com>

        Change by Darin, reviewed by Brady

        Small efficiency improvement Darin just spotted

        * storage/StorageMap.cpp:
        (WebCore::StorageMap::setItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Antti Koivisto <antti@apple.com>
antti@apple.com [Mon, 5 May 2008 23:31:01 +0000 (23:31 +0000)]
2008-05-05  Antti Koivisto  <antti@apple.com>

        Reviewed by Anders.

        Fix https://bugs.webkit.org/show_bug.cgi?id=18899
        Bug 18899: REGRESSION (r32871): Non-Safari crash in WTF::HashTable on startup

        * loader/loader.cpp:
        (WebCore::Loader::Loader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 5 May 2008 23:04:53 +0000 (23:04 +0000)]
2008-05-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Fix for <rdar://problem/5884383>
        Escape look-a-like characters from the the entire url.

        * Misc/WebNSURLExtras.mm:
        (escapeUnsafeCharacters):
        (-[NSURL _web_userVisibleString]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 5 May 2008 22:57:51 +0000 (22:57 +0000)]
2008-05-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Fix a bug in StorageMap iterator tracking where the iterator was not successfully
        invalidated at an appropriate time.

        * storage/StorageMap.cpp:
        (WebCore::StorageMap::setItem): ALWAYS invalidate it here

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Mon, 5 May 2008 22:50:56 +0000 (22:50 +0000)]
WebCore:

2008-05-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.

        <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end

        Disable Range mutation on document modifications in Tiger and Leopard Mail,
        since they do their own mutation which interferes with ours.

        * WebCore.base.exp:
        * dom/Document.cpp:
        (WebCore::Document::nodeChildrenChanged):
        (WebCore::Document::nodeWillBeRemoved):
        (WebCore::Document::textInserted):
        (WebCore::Document::textRemoved):
        (WebCore::Document::textNodesMerged):
        (WebCore::Document::textNodeSplit):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::disableRangeMutationForOldAppleMail):
        * page/Settings.h:
        (WebCore::Settings::rangeMutationDisabledForOldAppleMail):

WebKit/mac:

2008-05-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.

        <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end

        * WebView/WebView.mm:
        (-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to
        the document for Tiger and Leopard Mail.  There is code in Mail that does it, and
        the two interfere.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Mon, 5 May 2008 22:47:21 +0000 (22:47 +0000)]
WebCore:

2008-05-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Tim Hatcher.

        Make the Inspector's localizable strings file match the format used by Dashboard widgets.

        * English.lproj/InspectorLocalizedStrings.js: Removed.
        * English.lproj/localizedStrings.js: Added.
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/inspector/inspector.js:

WebKit/mac:

2008-05-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Tim Hatcher.

        Make the Inspector's localizable strings file match the format used by Dashboard widgets.

        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::localizedStringsURL):

WebKit/win:

2008-05-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Tim Hatcher.

        Make the Inspector's localizable strings file match the format used by Dashboard widgets.

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::localizedStringsURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Mon, 5 May 2008 20:51:32 +0000 (20:51 +0000)]
2008-05-05  Steve Falkenburg  <sfalken@apple.com>

        Add WebPreference for application chrome mode.

        Reviewed by Dave Hyatt.

        * Interfaces/IWebPreferencesPrivate.idl:
        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):
        (WebPreferences::inApplicationChromeMode):
        (WebPreferences::setApplicationChromeMode):
        * WebPreferences.h:
        * WebView.cpp:
        (WebView::notifyPreferencesChanged):

2008-05-05  Steve Falkenburg  <sfalken@apple.com>

        Add support for default button appearance.
        Add WebCore setting for app chrome mode.

        Reviewed by Dave Hyatt.

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        * css/CSSValueKeywords.in: Added default-button value keyword.
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setApplicationChromeMode):
        * page/Settings.h:
        (WebCore::Settings::inApplicationChromeMode):
        * rendering/RenderButton.cpp:
        (WebCore::RenderButton::RenderButton):
        (WebCore::RenderButton::setStyle):
        (WebCore::RenderButton::timerFired):
        * rendering/RenderButton.h:
        * rendering/RenderStyle.h:
        (WebCore::):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::adjustStyle):
        (WebCore::RenderTheme::paint):
        (WebCore::RenderTheme::paintBorderOnly):
        (WebCore::RenderTheme::paintDecorations):
        (WebCore::RenderTheme::isControlStyled):
        (WebCore::RenderTheme::isDefault):
        * rendering/RenderTheme.h:
        (WebCore::):
        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::determineState):
        (WebCore::RenderThemeSafari::adjustRepaintRect):
        (WebCore::RenderThemeSafari::adjustButtonStyle):
        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::supportsFocus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Adele Peterson <adele@apple.com>
adele@apple.com [Mon, 5 May 2008 20:35:15 +0000 (20:35 +0000)]
2008-05-05  Adele Peterson  <adele@apple.com>

        Reviewed by Adam.

        Look for the right ImageDiff executable for debug builds.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Mon, 5 May 2008 18:29:09 +0000 (18:29 +0000)]
    Reviewed by Darin.

        https://bugs.webkit.org/show_bug.cgi?id=11947
        nbsps should be converted to entities in innerHTML

        https://bugs.webkit.org/show_bug.cgi?id=18769
        replacing &nbsp; with spaces using regexp creates inconsistent result

        Tests: fast/dom/innerHTML-nbsp.html
               fast/dom/innerHTML-escaping-attribute.html

        * editing/markup.cpp:
        (WebCore::appendAttributeValue):
        (WebCore::escapeContentText):
        (WebCore::appendEscapedContent):
        Added U+00a0/nbsp to the list of characters to escape.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Mon, 5 May 2008 18:26:17 +0000 (18:26 +0000)]
WebCore:

2008-05-05  David Hyatt  <hyatt@apple.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=18821.  Fix some bugs in both get/PutImageData of <canvas>.

        Reviewed by Eric

        New tests added in fast/canvas/

        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::getImageData):
        (WebCore::ImageBuffer::putImageData):

LayoutTests:

2008-05-05  David Hyatt  <hyatt@apple.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=18821, putImageData incorrect when data has alpha.

        Reviewed by Eric

        * fast/canvas/canvas-alphaImageData-behavior-expected.txt: Added.
        * fast/canvas/canvas-alphaImageData-behavior.html: Added.
        * fast/canvas/canvas-alphaImageData-behavior.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 5 May 2008 16:59:05 +0000 (16:59 +0000)]
2008-05-05  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan.

        - fix debug-only leak seen on buildbot

        * wtf/HashTable.h:
        (WTF::HashTable::checkKey): After writing an empty value in, but before constructing a
        deleted value on top of it, call the destructor so the empty value doesn't leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 5 May 2008 16:47:21 +0000 (16:47 +0000)]
2008-05-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Jess.

        Apparently preflighting can cause hangs for some reason. Revert this for now.

        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage _initWithPath:]):
        * Plugins/WebPluginPackage.m:
        (-[WebPluginPackage initWithPath:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 5 May 2008 16:44:16 +0000 (16:44 +0000)]
2008-05-05  Darin Adler  <darin@apple.com>

        * Scripts/run-webkit-tests: Ignore a Java leak showing up in the WebKit
        leak tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 5 May 2008 16:34:03 +0000 (16:34 +0000)]
2008-05-05  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - https://bugs.webkit.org/show_bug.cgi?id=18789
          fix some shouldCloseWithWindow edge cases

        * WebView/WebView.mm:
        (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the
        NSWindowWillCloseNotification if the view was moved out of the window but still
        had that window set as the host window. Also make sure this function doesn't do
        anything if the WebView is already closed.
        (-[WebView setHostWindow:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Adam Roben.
mitz@apple.com [Mon, 5 May 2008 16:31:24 +0000 (16:31 +0000)]
    Rubber-stamped by Adam Roben.

        - fix test failure due to Windows' preference for Mac results over
          generic results

        * platform/win/editing/selection/move-left-right-expected.txt: Copied from LayoutTests/editing/selection/move-left-right-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Mon, 5 May 2008 16:27:51 +0000 (16:27 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18809
          Forms with block level generated content and absolutely positioned labels break inline layout (fixed on reflow)

        Test: fast/block/basic/adding-near-anonymous-block.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::addChildToFlow): When adding a floating or
        positioned object, if it follows an anonymous block, put it
        inside the anonymous block. When adding an inline, check if it comes
        after an anonymous block and put it in the anonymous block.

LayoutTests:

        Reviewed by Dave Hyatt.

        - test, updated test and updated results for https://bugs.webkit.org/show_bug.cgi?id=18809
          Forms with block level generated content and absolutely positioned labels break inline layout (fixed on reflow)

        * fast/block/basic/adding-near-anonymous-block.html: Added.
        * media/video-controls-rendering.html: Changed to work around
        https://bugs.webkit.org/show_bug.cgi?id=18857 which now affects this
        test in its original form.
        * platform/mac/css1/box_properties/clear-expected.txt:
        * platform/mac/fast/block/basic/adding-near-anonymous-block-expected.checksum: Added.
        * platform/mac/fast/block/basic/adding-near-anonymous-block-expected.png: Added.
        * platform/mac/fast/block/basic/adding-near-anonymous-block-expected.txt: Added.
        * platform/mac/fast/forms/input-align-image-expected.txt:
        * platform/mac/media/audio-controls-rendering-expected.txt:
        * platform/mac/media/video-controls-rendering-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug51140-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Antti Koivisto <antti@apple.com>
antti@apple.com [Mon, 5 May 2008 16:09:00 +0000 (16:09 +0000)]
2008-05-05  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin.

        Speculative fix for <rdar://problem/5906790>
        Crash in Loader::servePendingRequests() due to hash table being modified during iteration

        I don't know how to reproduce this. It would require the load to fail (or succeed)
        synchronously, something that should not usually happen.

        * loader/loader.cpp:
        (WebCore::Loader::Loader):
        (WebCore::Loader::load):
        (WebCore::Loader::servePendingRequests):
        (WebCore::Loader::cancelRequests):
        (WebCore::Loader::Host::Host):
        * loader/loader.h:
        (WebCore::Loader::Host::name):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Mon, 5 May 2008 10:26:33 +0000 (10:26 +0000)]
Ariya Hidayat  <ariya.hidayat@trolltech.com>

In the Qt's DumpRenderTree, adjust the web view properly (because W3C SVG
tests expect to be 480x360)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Mon, 5 May 2008 09:59:34 +0000 (09:59 +0000)]
Ariya Hidayat  <ariya.hidayat@trolltech.com>

Disable SVG As Image support in the Qt port again, as it
requires more work. Right now the chrome client is
assumed to be a ChromeClientQt, which the SVG Image support
changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Mon, 5 May 2008 05:30:44 +0000 (05:30 +0000)]
Reviewed by Kevin Ollivier.

Allow events to specify the ID of the particular wxWebView they are to be sent to.

https://bugs.webkit.org/show_bug.cgi?id=18659

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-02 Antti Koivisto <antti@apple.com>
antti@apple.com [Mon, 5 May 2008 04:46:26 +0000 (04:46 +0000)]
2008-05-02  Antti Koivisto  <antti@apple.com>

        Reviewed by Mitz.

        Test for <rdar://problem/5840475>
        CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::RenderBlock::insertPositionedObject

        * fast/transforms/container-transform-crash-expected.txt: Added.
        * fast/transforms/container-transform-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32862 268f45cc-cd09-0410-ab3c-d52691b4dbfc