WebKit-https.git
8 years agoUpdate label for blacklisted plug-in
sullivan@apple.com [Tue, 29 May 2012 19:33:02 +0000 (19:33 +0000)]
Update label for blacklisted plug-in
https://bugs.webkit.org/show_bug.cgi?id=87767
rdar://problem/11550048

Reviewed by Kevin Decker.

* English.lproj/Localizable.strings:
Regenerated.

* platform/LocalizedStrings.cpp:
(WebCore::insecurePluginVersionText):
Changed this string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r111742): box-sizing: border-box doesn't work on fixed table layout
jchaffraix@webkit.org [Tue, 29 May 2012 19:30:43 +0000 (19:30 +0000)]
REGRESSION(r111742): box-sizing: border-box doesn't work on fixed table layout
https://bugs.webkit.org/show_bug.cgi?id=87536

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/table/fixed-table-layout/cell-box-sizing-fixed-table-layout.html
       fast/table/fixed-table-layout/column-box-sizing-fixed-table-layout.html
       fast/table/fixed-table-layout/column-group-box-sizing-fixed-table-layout.html
       fast/table/fixed-table-layout/column-in-column-group-box-sizing-fixed-table-layout.html

The change in r111742 completely ignored border-sizing (following the table's code lead unfortunately).
The issue is that we would count the borders and paddings twice for the border-box case which would lead
to the content-box including them too. From a web-author, this behavior is equivalent to ignoring box-sizing.

* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
Reworked the function to properly use computeBorderBoxLogicalWidth() for correctness. This matches
what RenderBox and the rendering code does generally. Also refactored the code to avoid the need
for local variables and make it more readable.

LayoutTests:

* fast/table/fixed-table-layout/cell-box-sizing-fixed-table-layout-expected.html: Added.
* fast/table/fixed-table-layout/cell-box-sizing-fixed-table-layout.html: Added.
This test covers the regression.

* fast/table/fixed-table-layout/column-box-sizing-fixed-table-layout-expected.html: Added.
* fast/table/fixed-table-layout/column-box-sizing-fixed-table-layout.html: Added.
* fast/table/fixed-table-layout/column-group-box-sizing-fixed-table-layout-expected.html: Added.
* fast/table/fixed-table-layout/column-group-box-sizing-fixed-table-layout.html: Added.
* fast/table/fixed-table-layout/column-in-column-group-box-sizing-fixed-table-layout-expected.html: Added.
* fast/table/fixed-table-layout/column-in-column-group-box-sizing-fixed-table-layout.html: Added.
Those test ensured I didn't regress and document our current behavior ie that column and column group fixed
width apply to the cell's border-box.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAbsolute positioned elements in a relative positioned CSS3 Flexbox fail to display...
ojan@chromium.org [Tue, 29 May 2012 19:28:04 +0000 (19:28 +0000)]
Absolute positioned elements in a relative positioned CSS3 Flexbox fail to display properly
https://bugs.webkit.org/show_bug.cgi?id=58453

Reviewed by Tony Chang.

Source/WebCore:

Test: css3/flexbox/align-absolute-child.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::prepareChildForPositionedLayout):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::adjustAlignmentForChild):
When adjusting positioned items, adjust their static position, not their location.
(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):
(WebCore::RenderFlexibleBox::flipForWrapReverse):
* rendering/RenderFlexibleBox.h:

LayoutTests:

* css3/flexbox/align-absolute-child-expected.txt: Added.
* css3/flexbox/align-absolute-child.html: Added.
* css3/flexbox/position-absolute-child-expected.txt:
* css3/flexbox/position-absolute-child.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Win] ~1/2 of all the iframe seamless tests fail
jberlin@webkit.org [Tue, 29 May 2012 19:23:23 +0000 (19:23 +0000)]
[Win] ~1/2 of all the iframe seamless tests fail
https://bugs.webkit.org/show_bug.cgi?id=87543

Rubber-stamped by Eric Seidel.

WebKitLibraries:

Finish enabling IFRAME_SEAMLESS on Windows.

* win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

Remove the platform-specific results as they are no longer needed.

* platform/win/fast/frames/seamless/seamless-basic-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-css-cascade-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-form-get-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-form-get-named-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-form-post-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-form-post-named-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-hyperlink-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-hyperlink-named-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-inherited-document-style-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-window-location-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-window-location-href-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-window-location-sandbox-expected.txt: Removed.
* platform/win/fast/frames/seamless/seamless-window-open-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash due to text fragment destruction when updating first-letter block.
inferno@chromium.org [Tue, 29 May 2012 19:15:26 +0000 (19:15 +0000)]
Crash due to text fragment destruction when updating first-letter block.
https://bugs.webkit.org/show_bug.cgi?id=87751

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/text/text-fragment-first-letter-update-crash.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):

LayoutTests:

* fast/text/text-fragment-first-letter-update-crash-expected.txt: Added.
* fast/text/text-fragment-first-letter-update-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=87764
hyatt@apple.com [Tue, 29 May 2012 19:12:34 +0000 (19:12 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=87764

Add implementation of checkForPaginationLogicalHeightChange to RenderMultiColumnBlock.

Also stub out ensureColumnSets() and write a comment describing how it's going to work.

Reviewed by Anders Carlsson.

* rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):
(WebCore):
(WebCore::RenderMultiColumnBlock::ensureColumnSets):
* rendering/RenderMultiColumnBlock.h:
(WebCore::RenderMultiColumnBlock::columnHeight):
(WebCore::RenderMultiColumnBlock::setColumnHeight):
(RenderMultiColumnBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening of failing tests and new passes
commit-queue@webkit.org [Tue, 29 May 2012 18:48:19 +0000 (18:48 +0000)]
[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=87754

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-29

* platform/efl/Skipped:
* platform/efl/fast/forms/select/optgroup-rendering-expected.png: Added.
* platform/efl/fast/forms/select/optgroup-rendering-expected.txt: Added.
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r118620.
commit-queue@webkit.org [Tue, 29 May 2012 18:42:01 +0000 (18:42 +0000)]
Unreviewed, rolling out r118620.
http://trac.webkit.org/changeset/118620
https://bugs.webkit.org/show_bug.cgi?id=87760

This patch causes regression to read an empty file/blob via
FileReader (Requested by jianli on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-29

Source/WebCore:

* fileapi/FileReader.cpp:
(WebCore::FileReader::stringResult):

LayoutTests:

* fast/files/blob-slice-test-expected.txt:
* fast/files/read-blob-async-expected.txt:
* fast/files/read-file-async-expected.txt:
* fast/files/resources/read-common.js:
(logResult):
* fast/files/workers/worker-read-blob-async-expected.txt:
* fast/files/workers/worker-read-file-async-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Win] ASSERT(m_manualStream) failed in PluginView::didFinishLoading running
jberlin@webkit.org [Tue, 29 May 2012 18:39:32 +0000 (18:39 +0000)]
[Win] ASSERT(m_manualStream) failed in PluginView::didFinishLoading running
fast/loader/reload-zero-byte-plugin.html

Skip the test on Windows to get the bots greener.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCopiedSpace::doneCopying could start another collection
mhahnenberg@apple.com [Tue, 29 May 2012 18:38:14 +0000 (18:38 +0000)]
CopiedSpace::doneCopying could start another collection
https://bugs.webkit.org/show_bug.cgi?id=86538

Reviewed by Geoffrey Garen.

It's possible that if we don't have anything at the head of to-space
after a collection and the BlockAllocator doesn't have any fresh blocks
to give us right now we could start another collection while still in
the middle of the first collection when we call CopiedSpace::addNewBlock().

One way to resolve this would be to have Heap::shouldCollect() check that
m_operationInProgress is NoOperation. This would prevent the path in
getFreshBlock() that starts the collection if we're already in the middle of one.

I could not come up with a test case to reproduce this crash on ToT.

* heap/Heap.h:
(JSC::Heap::shouldCollect): We shouldn't collect if we're already in the middle
of a collection, i.e. the current operation should be NoOperation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake StylePropertySet a variable-sized object to reduce memory use.
kling@webkit.org [Tue, 29 May 2012 18:19:59 +0000 (18:19 +0000)]
Make StylePropertySet a variable-sized object to reduce memory use.
<http://webkit.org/b/87506>

Reviewed by Antti Koivisto.

Make immutable StylePropertySet objects variable-sized and allocate exactly
the space needed to hold the CSSProperty objects passed at construction.
This lets us avoid the memory overhead of Vector<CSSProperty, 4>.

Renamed StylePropertySet::adopt* to create and createImmutable since they no
longer adopt the incoming vector. More cleanup will follow in this area.

This reduces memory usage across the board - the more CSS declarations,
the bigger the benefit. As an example, we save around ~0.5MB on wsj.com.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
* css/CSSParser.cpp:
(WebCore::CSSParser::createStylePropertySet):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::createImmutable):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::~StylePropertySet):
(WebCore::StylePropertySet::copyPropertiesFrom):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addParsedProperties):
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::merge):
(WebCore::StylePropertySet::addSubresourceStyleURLs):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::findPropertyWithId):
(WebCore::StylePropertySet::removeEquivalentProperties):
(WebCore::StylePropertySet::copyPropertiesInSet):
(WebCore::StylePropertySet::averageSizeInBytes):
(SameSizeAsStylePropertySet):
(WebCore::StylePropertySet::append):
* css/StylePropertySet.h:
(WebCore::StylePropertySet::create):
(StylePropertySet):
(WebCore::StylePropertySet::propertyAt):
(WebCore::StylePropertySet::propertyCount):
(WebCore::StylePropertySet::isEmpty):
(WebCore::StylePropertySet::array):
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateAttributeStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=87759
hyatt@apple.com [Tue, 29 May 2012 18:15:03 +0000 (18:15 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=87759

Pull the initial page logical height checking for columns into its own separate function. This
will allow the derived RenderMultiColumnBlock class to do its own setup there. It also has the
effect of cleaning up layoutBlock even for the existing code.

Reviewed by Anders Carlsson.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::checkForPaginationLogicalHeightChange):
(WebCore):
(WebCore::RenderBlock::layoutBlock):
* rendering/RenderBlock.h:
(RenderBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding VISTA timeout expectations to a number of viewport tests. Also, narrowing...
rafaelw@chromium.org [Tue, 29 May 2012 18:13:07 +0000 (18:13 +0000)]
Adding VISTA timeout expectations to a number of viewport tests. Also, narrowing optgroup-clicking.html
to be just MAC.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate cue event dispatching for zero and negative duration cues
commit-queue@webkit.org [Tue, 29 May 2012 17:55:52 +0000 (17:55 +0000)]
Update cue event dispatching for zero and negative duration cues
https://bugs.webkit.org/show_bug.cgi?id=85143

Patch by Victor Carbune <victor@rosedu.org> on 2012-05-29
Reviewed by Eric Carlson.

Source/WebCore:

Updated existing test.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Explicitly
treated event dispatching for zero and negative duration cues.
(WebCore::HTMLMediaElement::textTrackAddCue): Interval tree doesn't
handle invalid cues with intervals - negative cues need to be treated
as zero-length cues as they are always missed cues anyway.
(WebCore::HTMLMediaElement::textTrackRemoveCue): Same.

LayoutTests:

* media/track/captions-webvtt/missed-cues.vtt: Added negative
duration cue and changed a missed cue to have zero-length.
* media/track/track-cues-missed-expected.txt: Updated.
* media/track/track-cues-missed.html: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Make DefaultTapHighlight use the new WebOverlay API
commit-queue@webkit.org [Tue, 29 May 2012 17:50:56 +0000 (17:50 +0000)]
[BlackBerry] Make DefaultTapHighlight use the new WebOverlay API
https://bugs.webkit.org/show_bug.cgi?id=87604

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-29
Reviewed by Antonio Gomes.

Also add a new method to allow the embedder to use the default tap
highlight instead of replacing it with a custom one just to keep track
of the "shouldHideAfterScroll" flag.

PR #160262.

* Api/WebTapHighlight.h:
* WebKitSupport/DefaultTapHighlight.cpp:
(BlackBerry::WebKit::DefaultTapHighlight::DefaultTapHighlight):
(BlackBerry::WebKit::DefaultTapHighlight::draw):
(BlackBerry::WebKit::DefaultTapHighlight::hide):
(BlackBerry::WebKit::DefaultTapHighlight::paintContents):
* WebKitSupport/DefaultTapHighlight.h:
(BlackBerry::WebKit::DefaultTapHighlight::shouldHideAfterScroll):
(DefaultTapHighlight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShadowRoot.getElementById() returns removed node.
morrita@google.com [Tue, 29 May 2012 17:50:03 +0000 (17:50 +0000)]
ShadowRoot.getElementById() returns removed node.
https://bugs.webkit.org/show_bug.cgi?id=62184

Source/WebCore:

Deregitration of m_elementsById map is done at Element::removedFrom()
But the tree scope of the removed node is already reset from a shadow root
to a document.

This change lookup the old shadow root through its parent node and
deregitrater the node against it.

Reviewed by Dimitri Glazkov.

Test: fast/dom/shadow/get-element-by-id-in-shadow-mutation.html

* dom/Element.cpp:
(WebCore::treeScopeOfParent):
(WebCore):
(WebCore::Element::removedFrom):
* dom/Element.h:
(Element):
(WebCore::Element::updateId):
(WebCore):

LayoutTests:

Reviewed by Dimitri Glazkov.

* fast/dom/shadow/get-element-by-id-in-shadow-mutation-expected.txt: Added.
* fast/dom/shadow/get-element-by-id-in-shadow-mutation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unoccluded area in surfaces should always be clipped to the rootScissorRect
danakj@chromium.org [Tue, 29 May 2012 17:46:03 +0000 (17:46 +0000)]
[chromium] Unoccluded area in surfaces should always be clipped to the rootScissorRect
https://bugs.webkit.org/show_bug.cgi?id=87677

Reviewed by Adrienne Walker.

Source/WebCore:

When a contributing surface is visited, and we have not visited another
surface, then we know the surface is completely unoccluded. However, the
root scissor rect should still be applied, and anything outside of it
should be considered occluded.

Unit test: WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor

* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::targetRenderSurface):
(WebCore):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::unoccludedContributingSurfaceContentRect):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::targetRenderSurface):
(WebCore):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):

Source/WebKit/chromium:

* tests/CCOcclusionTrackerTest.cpp:
(CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor):
(WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor::runMyTest):
(WebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago * platform/mac/Skipped: Skipping a heap profiler test (unsupported functional...
ap@apple.com [Tue, 29 May 2012 17:23:02 +0000 (17:23 +0000)]
    * platform/mac/Skipped: Skipping a heap profiler test (unsupported functionality).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Refactoring http/proxy authentication to use authcallback mechanism...
commit-queue@webkit.org [Tue, 29 May 2012 17:14:19 +0000 (17:14 +0000)]
[BlackBerry] Refactoring http/proxy authentication to use authcallback mechanism introduced with libcurl
https://bugs.webkit.org/show_bug.cgi?id=87706

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-05-29
Reviewed by Antonio Gomes.

Because we use authentication callback mechanism of libcurl,
which will take care of all the authentication communication
between UA and server, so the only thing we need to do is to
provide credential information when authentication callback
is triggered. By using this we don't need to process
intermediate headers for each http authentication scheme.

Implemented interface function notifyAuthReceived() in
NetworkJob to handle the authentication notification from
networking thread.
When the authentication callback is triggered, we should
cancel the current loading request and restart a new one with
credential information attached which comes from
credentialStorage or user input.

Internally reviewed by Joe Mason <jmason@rim.com>.

No new tests since there is no behavior change.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore):
(WebCore::NetworkJob::handleNotifyHeaderReceived):
(WebCore::NetworkJob::sendRequestWithCredentials):
* platform/network/blackberry/NetworkJob.h:
(NetworkJob):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] http authentication challenge issue when loading subresource
commit-queue@webkit.org [Tue, 29 May 2012 16:57:19 +0000 (16:57 +0000)]
[BlackBerry] http authentication challenge issue when loading subresource
https://bugs.webkit.org/show_bug.cgi?id=87660

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-05-29
Reviewed by Rob Buis.

We should try to store the credential information as soon as we
receive http status notification which indicates that the
authentication succeeds, instead of storing credentials when the
main resource receives notify done which is too late for loading
subresource.

Internally reviewed by Joe Mason <jmason@rim.com>

No new tests since there is no change in behavior.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyStatusReceived):
(WebCore::NetworkJob::handleNotifyClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] Move DefaultFonts.plist to C++ code
ap@apple.com [Tue, 29 May 2012 16:52:42 +0000 (16:52 +0000)]
[Mac] Move DefaultFonts.plist to C++ code
https://bugs.webkit.org/show_bug.cgi?id=87560
<rdar://problem/11466119>

Reviewed by Dan Bernstein.

* DerivedSources.make:
* Resources/DefaultFonts.plist.in: Removed.
* WebCore.xcodeproj/project.pbxproj:
* page/mac/SettingsMac.mm: (WebCore::Settings::initializeDefaultFontFamilies):
Instead of having a separate configuration file, just hardcode the settings in C++.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegression: fast/forms/select/optgroup-clicking.html is failing / timing out
jberlin@webkit.org [Tue, 29 May 2012 16:49:11 +0000 (16:49 +0000)]
Regression: fast/forms/select/optgroup-clicking.html is failing / timing out
https://bugs.webkit.org/show_bug.cgi?id=87748

This test times out on Mac if there is no interaction with the keyboard. Skip it to keep the
bots green.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] [WK2] Reproducible crash in performDragControllerAction
commit-queue@webkit.org [Tue, 29 May 2012 16:48:54 +0000 (16:48 +0000)]
[GTK] [WK2] Reproducible crash in performDragControllerAction
https://bugs.webkit.org/show_bug.cgi?id=87744

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-29
Reviewed by Martin Robinson.

Fix a crash by using deref() instead of delete to dereference and
release the platformData of DragData.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Missing field initializers for WKPageLoaderClient and WKPageUIClient
commit-queue@webkit.org [Tue, 29 May 2012 16:47:03 +0000 (16:47 +0000)]
[GTK] Missing field initializers for WKPageLoaderClient and WKPageUIClient
https://bugs.webkit.org/show_bug.cgi?id=87745

Patch by Simon Pena <spena@igalia.com> on 2012-05-29
Reviewed by Carlos Garcia Campos.

Add missing initializers for WKPageLoaderClient and
WKPageUIClient, for callbacks WKPagePluginDidFailCallback and
WKPageUnavailablePluginButtonClickedCallback, introduced in
revision r116716.

* UIProcess/API/gtk/WebKitLoaderClient.cpp:
(attachLoaderClientToView): Initialize WKPagePluginDidFailCallback
* UIProcess/API/gtk/WebKitUIClient.cpp:
(attachUIClientToView): Initialize callback
WKPageUnavailablePluginButtonClickedCallback

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Policy decision headers are not included in the main webkit2.h header
carlosgc@webkit.org [Tue, 29 May 2012 16:44:29 +0000 (16:44 +0000)]
[GTK] Policy decision headers are not included in the main webkit2.h header
https://bugs.webkit.org/show_bug.cgi?id=87753

Reviewed by Martin Robinson.

* UIProcess/API/gtk/webkit2.h: Include
WebKitNavigationPolicyDecision.h and WebKitResponsePolicyDecision.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Retainers are missing for all objects
commit-queue@webkit.org [Tue, 29 May 2012 16:36:08 +0000 (16:36 +0000)]
Web Inspector: Retainers are missing for all objects
https://bugs.webkit.org/show_bug.cgi?id=87655

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-29
Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):

LayoutTests:

* inspector/profiler/heap-snapshot-summary-retainers-expected.txt: Added.
* inspector/profiler/heap-snapshot-summary-retainers.html: Added.
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.):
(initialize_HeapSnapshotTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] fast tests needs rebaseline after r118733
commit-queue@webkit.org [Tue, 29 May 2012 16:31:58 +0000 (16:31 +0000)]
[GTK] fast tests needs rebaseline after r118733
https://bugs.webkit.org/show_bug.cgi?id=87729

Unreviewed GTK gardening, updated fast pngs.

Patch by Simon Pena <spena@igalia.com> on 2012-05-29

* platform/gtk/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/gtk/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/gtk/fast/forms/placeholder-position-expected.png:
* platform/gtk/fast/forms/placeholder-pseudo-style-expected.png:
* platform/gtk/fast/forms/search-styled-expected.png:
* platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.png:
* platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.png:
* platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] fast/forms/select/optgroup-rendering.html "failing" since introduction in r118772
jberlin@webkit.org [Tue, 29 May 2012 16:29:31 +0000 (16:29 +0000)]
[Mac] fast/forms/select/optgroup-rendering.html "failing" since introduction in r118772
https://bugs.webkit.org/show_bug.cgi?id=87752

Add expected (failing?) results to get the bots green.

* platform/mac/fast/forms/select/optgroup-rendering-expected.png: Added.
* platform/mac/fast/forms/select/optgroup-rendering-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening after r118776. The failing test was split into
zandobersek@gmail.com [Tue, 29 May 2012 16:28:50 +0000 (16:28 +0000)]
Unreviewed GTK gardening after r118776. The failing test was split into
5 separate tests, but we're still failing all of them.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GStreamer] Video sink doesn't respect WebKit code style
philn@webkit.org [Tue, 29 May 2012 16:27:08 +0000 (16:27 +0000)]
[GStreamer] Video sink doesn't respect WebKit code style
https://bugs.webkit.org/show_bug.cgi?id=87693

Reviewed by Alexis Menard.

No change in behavior of the sink, this patch only adapts the code
style to WebKit's.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(_WebKitVideoSinkPrivate):
(webkitVideoSinkTimeoutCallback):
(webkitVideoSinkRender):
(webkitVideoSinkDispose):
(unlockBufferMutex):
(webkitVideoSinkUnlock):
(webkitVideoSinkUnlockStop):
(webkitVideoSinkStop):
(webkitVideoSinkStart):
(webkitVideoSinkMarshalVoidAndMiniObject):
(webkit_video_sink_class_init):
(webkitVideoSinkNew):
* platform/graphics/gstreamer/VideoSinkGStreamer.h:
(_WebKitVideoSink):
(_WebKitVideoSinkClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Uninitialized shader compiler when GLES is used
commit-queue@webkit.org [Tue, 29 May 2012 16:20:46 +0000 (16:20 +0000)]
[Qt] Uninitialized shader compiler when GLES is used
https://bugs.webkit.org/show_bug.cgi?id=87712

The '#if !defined(QT_OPENGL_ES_2)' has been removed before the initialization
of shader compiler to compile shader codes for ES-platforms as well.

Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-05-29
Reviewed by Noam Rosenthal.

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[FileAPI] Miss FileList test
commit-queue@webkit.org [Tue, 29 May 2012 16:17:54 +0000 (16:17 +0000)]
[FileAPI] Miss FileList test
https://bugs.webkit.org/show_bug.cgi?id=87696

Patch by Li Yin <li.yin@intel.com> on 2012-05-29
Reviewed by Kentaro Hara.

WebKit should have the test to track the attribute of FileList.

* fast/files/file-list-test-expected.txt: Added.
* fast/files/file-list-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Add webkit_web_view_can_show_mime_type() to WebKit2 GTK+ API
carlosgc@webkit.org [Tue, 29 May 2012 16:09:46 +0000 (16:09 +0000)]
[GTK] Add webkit_web_view_can_show_mime_type() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=85998

Reviewed by Martin Robinson.

And use it in the default handler of WebKitWebView::decide-policy
signal to decide whether to use or ignore a response policy
decision depending on whether the mime type of the response can be
displayed in the WebView or not.

* UIProcess/API/gtk/WebKitURIResponse.cpp:
(webkitURIResponseGetProperty): Add getter for mime-type property.
(webkit_uri_response_class_init): Add mime-type property.
(webkit_uri_response_get_mime_type): Return the mime type of the
response.
* UIProcess/API/gtk/WebKitURIResponse.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewDecidePolicy): In case of response policy decisions,
use the URI response to decide what to do: download if the
response is an attachment, use if the mime type is supported by
the web view or ignore otherwise.
(webkit_web_view_can_show_mime_type): Returns whether the given
mime type can be displayed in the WebView or not.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/tests/TestResources.cpp:
(testWebResourceResponse):
(testWebResourceMimeType):
(serverCallback):
(beforeAll):
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewCanShowMIMEType):
(beforeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] WebKit-side implementation of SelectionOverlay
commit-queue@webkit.org [Tue, 29 May 2012 16:06:16 +0000 (16:06 +0000)]
[BlackBerry] WebKit-side implementation of SelectionOverlay
https://bugs.webkit.org/show_bug.cgi?id=87605

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-29
Reviewed by Rob Buis.

Source/WebKit:

Add SelectionOverlay to the build system.

PR #160263

* PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Leverage the new WebOverlay API to move SelectionOverlay to the WebKit
library, so we always draw selection regardless of which embedder is
integrating WebKit.

PR #160263

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::selectionOverlay):
(WebKit):
* Api/WebPage.h:
(WebKit):
* Api/WebPage_p.h:
(WebPagePrivate):
* Api/WebSelectionOverlay.h: Added.
(WebKit):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
* WebKitSupport/SelectionOverlay.cpp: Added.
(WebKit):
(BlackBerry::WebKit::SelectionOverlay::SelectionOverlay):
(BlackBerry::WebKit::SelectionOverlay::~SelectionOverlay):
(BlackBerry::WebKit::SelectionOverlay::draw):
(BlackBerry::WebKit::SelectionOverlay::hide):
(BlackBerry::WebKit::SelectionOverlay::notifySyncRequired):
(BlackBerry::WebKit::SelectionOverlay::paintContents):
* WebKitSupport/SelectionOverlay.h: Added.
(WebKit):
(SelectionOverlay):
(BlackBerry::WebKit::SelectionOverlay::create):
(BlackBerry::WebKit::SelectionOverlay::notifyAnimationStarted):
(BlackBerry::WebKit::SelectionOverlay::showDebugBorders):
(BlackBerry::WebKit::SelectionOverlay::showRepaintCounter):
(BlackBerry::WebKit::SelectionOverlay::contentsVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] fast/events/message-port-constructor-for-deleted-document.html ASSERTS in Debug.
jberlin@webkit.org [Tue, 29 May 2012 16:02:00 +0000 (16:02 +0000)]
[Mac] fast/events/message-port-constructor-for-deleted-document.html ASSERTS in Debug.

This is happening often enough that it is necessary to add the test to the Mac Skipped list
in order to keep the bots green.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd InspectorFileSystemAgent::FrontendProvider
commit-queue@webkit.org [Tue, 29 May 2012 16:00:35 +0000 (16:00 +0000)]
Add InspectorFileSystemAgent::FrontendProvider
https://bugs.webkit.org/show_bug.cgi?id=87635

InspectorFileSystemAgent needs weak reference to its frontend to perform
asynchronous operation.

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-05-29
Reviewed by Yury Semikhatsky.

* inspector/InspectorFileSystemAgent.cpp:
(InspectorFileSystemAgent::FrontendProvider):
(WebCore):
(WebCore::InspectorFileSystemAgent::~InspectorFileSystemAgent):
(WebCore::InspectorFileSystemAgent::enable):
(WebCore::InspectorFileSystemAgent::disable):
(WebCore::InspectorFileSystemAgent::setFrontend):
(WebCore::InspectorFileSystemAgent::clearFrontend):
(WebCore::InspectorFileSystemAgent::restore):
(WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):
* inspector/InspectorFileSystemAgent.h:
(InspectorFileSystemAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] move idn encoding test to test_expectations.txt
commit-queue@webkit.org [Tue, 29 May 2012 15:52:54 +0000 (15:52 +0000)]
[EFL][DRT] move idn encoding test to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=86080

Unreviewed gardening. Implementing copy{En,De}codedHostName just
to test them is not useful: marking fast/encoding/idn-security.html
as expected to fail.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-05-29

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Tue, 29 May 2012 15:28:05 +0000 (15:28 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0-wk2/compositing/geometry/composited-in-columns-expected.txt: Added.
* platform/qt-5.0-wk2/fast/forms/placeholder-pseudo-style-expected.png:
* platform/qt-5.0-wk2/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/qt-5.0-wk2/svg/css/text-gradient-shadow-expected.png: Added.
* platform/qt-5.0-wk2/svg/css/text-gradient-shadow-expected.txt:
* platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.png:
* platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Regression: fast/forms/select/optgroup-clicking.html is failing
bulach@chromium.org [Tue, 29 May 2012 15:20:12 +0000 (15:20 +0000)]
[chromium] Regression: fast/forms/select/optgroup-clicking.html is failing
https://bugs.webkit.org/show_bug.cgi?id=87748

Unreviewed gardening.

This test was added by r118772 and it fails with a mismatch in menulist.selectedIndex.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix new layout tests for images with color profiles by using fixed size
commit-queue@webkit.org [Tue, 29 May 2012 15:12:24 +0000 (15:12 +0000)]
Fix new layout tests for images with color profiles by using fixed size
https://bugs.webkit.org/show_bug.cgi?id=87542

Patch by Tony Payne <tpayne@chromium.org> on 2012-05-29
Reviewed by Kent Tamura.

* fast/images/jpeg-with-color-profile.html: Use width=400px instead of 50% to make sure size is consistent across ports.
* fast/images/png-with-color-profile.html: Use width=40px instead of 50% to make sure size is consistent across ports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed: Web Inspector: single line fix.
loislo@chromium.org [Tue, 29 May 2012 15:08:01 +0000 (15:08 +0000)]
Unreviewed: Web Inspector: single line fix.
heap-snapshot-loader are failing in Debug configuration because the list of profiles is not empty.

* inspector/profiler/heap-snapshot-loader.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] OpenGL content is not rendered on simulator
commit-queue@webkit.org [Tue, 29 May 2012 14:56:43 +0000 (14:56 +0000)]
[BlackBerry] OpenGL content is not rendered on simulator
https://bugs.webkit.org/show_bug.cgi?id=87721

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-29
Reviewed by George Staikos.

Fixed by enabling GLES2 support in simulator builds.

To experiment with building without OpenGL support, you can set the
DISABLE_GLES2 environment variable to a non-empty string and rebuild.

PR #150695

* Scripts/webkitdirs.pm:
(blackberryCMakeArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSplit svg/dom/viewspec-parser.html in smaller tests
bulach@chromium.org [Tue, 29 May 2012 14:53:14 +0000 (14:53 +0000)]
Split svg/dom/viewspec-parser.html in smaller tests
https://bugs.webkit.org/show_bug.cgi?id=87726

Reviewed by Andreas Kling.

This test was added by r118735.
Splits into smaller independent tests to avoid timeouts on ports such as chromium.

* svg/dom/resources/viewspec-parser.js: Added.
(buildTestsToRun):
(zoomAndPanToString):
(viewSpecToString):
(testString.string_appeared_here.makeURLRelative):
(testFragment):
(startNextTest):
(continueFuzzing.else.script.onload):
(continueFuzzing):
* svg/dom/viewspec-parser-1-expected.txt: Copied from LayoutTests/svg/dom/viewspec-parser-expected.txt.
* svg/dom/viewspec-parser-1.html: Added.
* svg/dom/viewspec-parser-2-expected.txt: Copied from LayoutTests/svg/dom/viewspec-parser-expected.txt.
* svg/dom/viewspec-parser-2.html: Added.
* svg/dom/viewspec-parser-3-expected.txt: Copied from LayoutTests/svg/dom/viewspec-parser-expected.txt.
* svg/dom/viewspec-parser-3.html: Added.
* svg/dom/viewspec-parser-4-expected.txt: Copied from LayoutTests/svg/dom/viewspec-parser-expected.txt.
* svg/dom/viewspec-parser-4.html: Added.
* svg/dom/viewspec-parser-5-expected.txt: Renamed from LayoutTests/svg/dom/viewspec-parser-expected.txt.
* svg/dom/viewspec-parser-5.html: Added.
* svg/dom/viewspec-parser.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, skip failing tests.
ossy@webkit.org [Tue, 29 May 2012 14:45:47 +0000 (14:45 +0000)]
Unreviewed gardening, skip failing tests.

* platform/mac/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIntroduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
commit-queue@webkit.org [Tue, 29 May 2012 14:44:38 +0000 (14:44 +0000)]
Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
https://bugs.webkit.org/show_bug.cgi?id=87685

Patch by David Barr <davidbarr@chromium.org> on 2012-05-29
Reviewed by Eric Seidel.

Add a configuration option for CSS image-resolution support, disabling it by default.

.:

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r109729): The optgroup element's "disabled" attribute has no effect to...
yosin@chromium.org [Tue, 29 May 2012 14:00:34 +0000 (14:00 +0000)]
REGRESSION(r109729): The optgroup element's "disabled" attribute has no effect to rendering and selection
https://bugs.webkit.org/show_bug.cgi?id=87614

Reviewed by Kent Tamura.

Source/WebCore:

This patch adds HTMLOptGroupElement::disabled and isEnabledFormControl
methods which was implemented in HTMLFormControlElement at r109729 and
updates CSS pseudo class checker to check "optgroup" element.

Tests: fast/forms/select/optgroup-clicking.html
       fast/forms/select/optgroup-disabled.html
       fast/forms/select/optgroup-rendering.html

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): On disabled and enabled pseudo class checker.
We checked tag name "optgroup" in addition isFormControlElement.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement): Checks optgroup.disabled.
* html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::disabled): Added.
* html/HTMLOptGroupElement.h:
(HTMLOptGroupElement): Added isEnabledFormControl.

LayoutTests:

Note: An image for optgroup-rendering.html will be change due by
BUG-87719. Color of option elements should be blue (:enabled
pseudo class) instead of green.

* fast/forms/select/optgroup-clicking-expected.txt: Added.
* fast/forms/select/optgroup-clicking.html: Added.
* fast/forms/select/optgroup-disabled-expected.txt: Added.
* fast/forms/select/optgroup-disabled.html: Added.
* fast/forms/select/optgroup-rendering.html: Added.
* platform/chromium/test_expectations.txt: Add MISSING entry for optgroup-rendering.html.
* platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png: Added.
* platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r118742): It made inspector/profiler/heap-snapshot-loader.html fail on...
ossy@webkit.org [Tue, 29 May 2012 13:57:21 +0000 (13:57 +0000)]
REGRESSION(r118742): It made inspector/profiler/heap-snapshot-loader.html fail on Lion, Qt
https://bugs.webkit.org/show_bug.cgi?id=87741

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-29
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped: Skip the failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Tests needs gardening after r118733
commit-queue@webkit.org [Tue, 29 May 2012 13:53:18 +0000 (13:53 +0000)]
[EFL] Tests needs gardening after r118733
https://bugs.webkit.org/show_bug.cgi?id=87733

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-29

* platform/efl/fast/css/text-overflow-input-expected.txt:
* platform/efl/fast/forms/search-styled-expected.png:
* platform/efl/fast/forms/search-styled-expected.txt:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Remove duplication of logic for disabling selected warnings related to C++11
vestbo@webkit.org [Tue, 29 May 2012 13:53:04 +0000 (13:53 +0000)]
[Qt] Remove duplication of logic for disabling selected warnings related to C++11

This is already handled in unix/default_post.prf

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] [Regression] SELECT popup misplaced when there is not enough vertical...
apavlov@chromium.org [Tue, 29 May 2012 13:41:08 +0000 (13:41 +0000)]
[Chromium] [Regression] SELECT popup misplaced when there is not enough vertical space
https://bugs.webkit.org/show_bug.cgi?id=87735

Reviewed by Kent Tamura.

This change fixes the obsolete WebWidget Y-repositioning code for the insufficient vertical space case, not removed in r113418.

No new tests, as popups are not testable in Chromium.

* platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Regions]Rename NamedFlow::overflow to NamedFlow::overset
commit-queue@webkit.org [Tue, 29 May 2012 13:39:52 +0000 (13:39 +0000)]
[CSS Regions]Rename NamedFlow::overflow to NamedFlow::overset
https://bugs.webkit.org/show_bug.cgi?id=87491

This patch updates the CSSOM property name overflow to overset. There are no changes in functionality.
Link to spec: http://www.w3.org/TR/2012/WD-css3-regions-20120503/

Source/WebCore:

Patch by Andrei Bucur <abucur@adobe.com> on 2012-05-29
Reviewed by Andreas Kling.

Test: fast/regions/webkit-named-flow-overset.html

* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::overset):
* dom/WebKitNamedFlow.h:
(WebKitNamedFlow):
* dom/WebKitNamedFlow.idl:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
* rendering/RenderFlowThread.h:

LayoutTests:

The test was refactored to be more similar to the other script tests (by using make-new-script-test)

Patch by Andrei Bucur <abucur@adobe.com> on 2012-05-29
Reviewed by Andreas Kling.

* fast/regions/webkit-named-flow-overflow-expected.txt: Removed.
* fast/regions/webkit-named-flow-overflow.html: Removed.
* fast/regions/webkit-named-flow-overset-expected.txt: Added.
* fast/regions/webkit-named-flow-overset.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] REGRESSION(r118568): It broke fast/forms/textarea-maxlength.html on Qt 4.8
ossy@webkit.org [Tue, 29 May 2012 13:37:15 +0000 (13:37 +0000)]
[Qt] REGRESSION(r118568): It broke fast/forms/textarea-maxlength.html on Qt 4.8
https://bugs.webkit.org/show_bug.cgi?id=87740

Unreviewed gardening.

* platform/qt-4.8/Skipped: Skip fast/forms/textarea-maxlength.html until proper fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Tue, 29 May 2012 13:34:52 +0000 (13:34 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-4.8/Skipped: Skip fast/parser/innerhtml-with-prefixed-elements.xhtml because of buggy QtXmlPatterns.
* platform/qt-5.0/Skipped: Unskip fast/parser/innerhtml-with-prefixed-elements.xhtml, because libxslt works fine.
* platform/qt/Skipped: Unskip a non-existing test.
* platform/qt/fast/parser/innerhtml-with-prefixed-elements-expected.png: Added.
* platform/qt/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Move tests from DesktopBehavior which can be made to work
kenneth@webkit.org [Tue, 29 May 2012 13:26:03 +0000 (13:26 +0000)]
[Qt] Move tests from DesktopBehavior which can be made to work
https://bugs.webkit.org/show_bug.cgi?id=87736

Rubberstamped by Simon Hausmann.

Move and modify the following tests to WebView/ and make them
use touch events.

* UIProcess/API/qt/tests/qmltests/WebView/tst_itemSelector.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml.
* UIProcess/API/qt/tests/qmltests/WebView/tst_messaging.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml.
* UIProcess/API/qt/tests/qmltests/WebView/tst_multiFileUpload.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_multiFileUpload.qml.
* UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_singleFileUpload.qml.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Don't add cxx-flags to QMAKE_CFLAGS
vestbo@webkit.org [Tue, 29 May 2012 13:21:43 +0000 (13:21 +0000)]
[Qt] Don't add cxx-flags to QMAKE_CFLAGS

Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
    valid for C++/ObjC++ but not for C [enabled by default]"

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Sync up favicon-implementation with WebView url changes in r118158
vestbo@webkit.org [Tue, 29 May 2012 13:17:23 +0000 (13:17 +0000)]
[Qt] Sync up favicon-implementation with WebView url changes in r118158

https://bugs.webkit.org/show_bug.cgi?id=87133

We now base64-encode the page url in the image-provider url, so that any
normalization done by QUrl will not mess up the page-url. The logic of
creating and parsing the provider-url has been moved into the image
provider, to keep it in one place.

We were also releasing icons (even ones we hadn't retained), which we can't
do since we don't know when the icon url is no longer in use.

Reviewed-by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGive StylePropertySet a proper mutability flag.
kling@webkit.org [Tue, 29 May 2012 12:25:07 +0000 (12:25 +0000)]
Give StylePropertySet a proper mutability flag.
<http://webkit.org/b/87675>

Reviewed by Antti Koivisto.

Add a flag to StylePropertySet that determines whether it's mutable or not. Only objects
constructed from the CSS parser (by way of StylePropertySet::adopt()) are made immutable.
This is clean-up and prep work for implementing a more efficient storage scheme for immutable
StylePropertySets (fixed-size array instead of vector) as the vast majority of them are
unlikely to ever mutate during their lifetime.

Sprinkled ASSERT(isMutable()) all over StylePropertySet to catch any attempts to modify
an immutable object.

Also made properties() const on StyleRule and friends, which brought some additional code
churn along with it.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::style):
(WebCore::CSSFontFaceRule::reattach):
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs):
* css/CSSFontFaceSrcValue.h:
(CSSFontFaceSrcValue):
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::style):
(WebCore::CSSPageRule::reattach):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::addSubresourceStyleURLs):
* css/CSSPrimitiveValue.h:
(CSSPrimitiveValue):
* css/CSSReflectValue.cpp:
(WebCore::CSSReflectValue::addSubresourceStyleURLs):
* css/CSSReflectValue.h:
(CSSReflectValue):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::style):
(WebCore::CSSStyleRule::reattach):
* css/CSSValue.cpp:
(WebCore::CSSValue::addSubresourceStyleURLs):
* css/CSSValue.h:
(CSSValue):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::addSubresourceStyleURLs):
* css/CSSValueList.h:
(CSSValueList):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::setCSSParserMode):
(WebCore):
(WebCore::StylePropertySet::copyPropertiesFrom):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addParsedProperties):
(WebCore::StylePropertySet::addParsedProperty):
(WebCore::StylePropertySet::merge):
(WebCore::StylePropertySet::addSubresourceStyleURLs):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::findPropertyWithId):
(WebCore::StylePropertySet::removeEquivalentProperties):
(WebCore::StylePropertySet::copyPropertiesInSet):
* css/StylePropertySet.h:
(WebCore::StylePropertySet::adopt):
(WebCore::StylePropertySet::adoptMutable):
(StylePropertySet):
(WebCore::StylePropertySet::isMutable):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::addMatchedProperties):
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleResolver.h:
(StyleResolver):
* css/StyleRule.cpp:
(WebCore::StyleRule::mutableProperties):
(WebCore):
(WebCore::StyleRulePage::mutableProperties):
(WebCore::StyleRuleFontFace::mutableProperties):
* css/StyleRule.h:
(WebCore::StyleRule::properties):
(StyleRule):
(WebCore::StyleRuleFontFace::properties):
(StyleRuleFontFace):
(WebCore::StyleRulePage::properties):
(StyleRulePage):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::ensureInlineStyle):
(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):
* editing/EditingStyle.cpp:
(WebCore::styleFromMatchedRulesForElement):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::parseAttribute):
(WebCore::SVGFontFaceElement::rebuildFontFace):
(WebCore::SVGFontFaceElement::removedFrom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
commit-queue@webkit.org [Tue, 29 May 2012 12:13:03 +0000 (12:13 +0000)]
[EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
https://bugs.webkit.org/show_bug.cgi?id=87654

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-29
Reviewed by Csaba Osztrogonác.

Source/WebCore:

Evas key events already provide key string, so no practical need for singleCharacterString()
evaluating the event string from keyname.
Modified code related functionality is already covered with fast/events and fast/forms tests.

* platform/efl/EflKeyboardUtilities.cpp:
* platform/efl/PlatformKeyboardEventEfl.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

Tools:

Event sender provides strings for all the key events.
Also KeyEventInfo constructor parameters order was changed to simplify the case when
a key event has empty string.

* DumpRenderTree/efl/EventSender.cpp:
(KeyEventInfo::KeyEventInfo):
(keyPadNameFromJSValue):
(keyNameFromJSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening after r118733 and r118735.
zandobersek@gmail.com [Tue, 29 May 2012 12:10:19 +0000 (12:10 +0000)]
Unreviewed GTK gardening after r118733 and r118735.

* platform/gtk/fast/css/text-overflow-input-expected.txt:
* platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
* platform/gtk/fast/forms/placeholder-position-expected.txt:
* platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/search-styled-expected.txt:
* platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
* platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Fix failing qmltests::FitToView::test_basic()
kenneth@webkit.org [Tue, 29 May 2012 12:09:58 +0000 (12:09 +0000)]
[Qt][WK2] Fix failing qmltests::FitToView::test_basic()
https://bugs.webkit.org/show_bug.cgi?id=87236

Reviewed by Simon Hausmann.

The fix is a combination of things. First of all some events
were emitted at the wrong times or when nothing had changed.

We also initialized the view saying it was suspended which is
not correct.

Another bug was that the touch tap, didn't result in marking
the view as having user interaction. This was recently fixed
in r118493.

* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPage::setContentsScale):
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):

    Make sure pageIsSuspended is initialized to false.

(QQuickWebViewFlickablePrivate::_q_onInformVisibleContentChange):

    Early bail out if there is no change.

    Inform contentScaleCommitted if the scale changed since last time.

(QQuickWebViewFlickablePrivate::didChangeContentsSize):

    Make sure to commit the right signals, ie. *Changed and not *Committed.

* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qwebkittest.cpp:
(touchPoint):
(QWebKitTest::sendTouchEvent):
(QWebKitTest::touchTap):
(QWebKitTest::touchDoubleTap):

    Add proper touch emulation for the testing system. Call directly
    to our WebKit API (avoid Qt event loop) to ensure all events gets
    delivered.

* UIProcess/API/qt/qwebkittest_p.h:
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::setItemRectVisible):

    Assert that a ViewportUpdateDeferrer is always used when calling
    this method.

(WebKit::QtViewportInteractionEngine::animateItemRectVisible):

    Remove work around now we have the proper fix in place.

(WebKit::QtViewportInteractionEngine::pagePositionRequest):

    Do not send the informVisibleContentChange manually, use the
    ViewportUpdateDeferrer instead.

(WebKit::QtViewportInteractionEngine::cancelScrollAnimation):

    Add missing ViewportUpdateDeferrer.

(WebKit::QtViewportInteractionEngine::pinchGestureStarted):

    No reason to emit informVisibleContentChange before pinch
    start, as it is always done on end (due to the ViewportUpdateDeferrer).

(WebKit::QtViewportInteractionEngine::itemSizeChanged):

    Add missing ViewportUpdateDeferrer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed Gardening. Update test expectations after r118733.
kkristof@inf.u-szeged.hu [Tue, 29 May 2012 11:43:28 +0000 (11:43 +0000)]
[Qt] Unreviewed Gardening. Update test expectations after r118733.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-29

* platform/qt/fast/css/text-overflow-input-expected.txt:
* platform/qt/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/qt/fast/forms/input-placeholder-visibility-3-expected.txt:
* platform/qt/fast/forms/placeholder-position-expected.txt:
* platform/qt/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/qt/fast/forms/search-styled-expected.txt:
* platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.txt:
* platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] [WK2] Allow user to inject JS scripts when the page loads
caio.oliveira@openbossa.org [Tue, 29 May 2012 11:43:07 +0000 (11:43 +0000)]
[Qt] [WK2] Allow user to inject JS scripts when the page loads
https://bugs.webkit.org/show_bug.cgi?id=85827

Reviewed by Simon Hausmann.

Create a new experimental property to list URLs of JS scripts that should be
loaded when a page is loaded. These scripts will run in the normal JS environment
of the page.

The supported URL schemes are file:/// and qrc:///. The scripts are read from the
UI process and transfered to the Web process.

Together with the experimental messaging API this provides a way for the
application to manipulate the DOM (by injecting a script that does the
manipulation and communicating with it via postMessage). This covers some of the
use cases of QWebElement in our WK1 API.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::didRelaunchProcess):
(readUserScript):
(QQuickWebViewPrivate::updateUserScripts):
(QQuickWebViewExperimental::userScripts):
(QQuickWebViewExperimental::setUserScripts):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/API/qt/tests/qmltests/WebView.pro:
* UIProcess/API/qt/tests/qmltests/WebView/tst_userScripts.qml: Added.
* UIProcess/API/qt/tests/qmltests/common/append-document-title.js: Added.
* UIProcess/API/qt/tests/qmltests/common/big-user-script.js: Added.
* UIProcess/API/qt/tests/qmltests/common/change-document-title.js: Added.
* UIProcess/API/qt/tests/qmltests/resources.qrc: Added.
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/qt/WebPageProxyQt.cpp:
(WebKit::WebPageProxy::setUserScripts):
(WebKit):
* WebProcess/WebPage/WebPage.h:
(WebPage):
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::setUserScripts):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Cancel potential url-edit when going back/forward
vestbo@webkit.org [Tue, 29 May 2012 11:42:35 +0000 (11:42 +0000)]
[Qt] Cancel potential url-edit when going back/forward

Reviewed by Kenneth Rohde Christiansen.

* MiniBrowser/qt/qml/BrowserWindow.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r118752.
caio.oliveira@openbossa.org [Tue, 29 May 2012 11:37:41 +0000 (11:37 +0000)]
Unreviewed, rolling out r118752.
http://trac.webkit.org/changeset/118752
https://bugs.webkit.org/show_bug.cgi?id=87731

incomplete patch (Requested by cmarcelo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-29

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::didRelaunchProcess):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/API/qt/tests/qmltests/WebView.pro:
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/qt/WebPageProxyQt.cpp:
* WebProcess/WebPage/WebPage.h:
(WebPage):
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/qt/WebPageQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, skipping failing test
slewis@apple.com [Tue, 29 May 2012 11:36:14 +0000 (11:36 +0000)]
Unreviewed, skipping failing test
See https://bugs.webkit.org/show_bug.cgi?id=87728

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] [WK2] Allow user to inject JS scripts when the page loads
caio.oliveira@openbossa.org [Tue, 29 May 2012 11:22:09 +0000 (11:22 +0000)]
[Qt] [WK2] Allow user to inject JS scripts when the page loads
https://bugs.webkit.org/show_bug.cgi?id=85827

Reviewed by Simon Hausmann.

Create a new experimental property to list URLs of JS scripts that should be
loaded when a page is loaded. These scripts will run in the normal JS environment
of the page.

The supported URL schemes are file:/// and qrc:///. The scripts are read from the
UI process and transfered to the Web process.

Together with the experimental messaging API this provides a way for the
application to manipulate the DOM (by injecting a script that does the
manipulation and communicating with it via postMessage). This covers some of the
use cases of QWebElement in our WK1 API.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::didRelaunchProcess):
(readUserScript):
(QQuickWebViewPrivate::updateUserScripts):
(QQuickWebViewExperimental::userScripts):
(QQuickWebViewExperimental::setUserScripts):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/API/qt/tests/qmltests/WebView.pro:
* UIProcess/API/qt/tests/qmltests/WebView/tst_userScripts.qml: Added.
* UIProcess/API/qt/tests/qmltests/common/append-document-title.js: Added.
* UIProcess/API/qt/tests/qmltests/common/big-user-script.js: Added.
* UIProcess/API/qt/tests/qmltests/common/change-document-title.js: Added.
* UIProcess/API/qt/tests/qmltests/resources.qrc: Added.
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/qt/WebPageProxyQt.cpp:
(WebKit::WebPageProxy::setUserScripts):
(WebKit):
* WebProcess/WebPage/WebPage.h:
(WebPage):
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::setUserScripts):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, updating results after http://trac.webkit.org/projects/webkit/changeset...
slewis@apple.com [Tue, 29 May 2012 11:14:56 +0000 (11:14 +0000)]
Unreviewed, updating results after trac.webkit.org/projects/webkit/changeset/118733

* platform/mac/fast/css/text-overflow-input-expected.txt:
* platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
* platform/mac/fast/forms/placeholder-position-expected.txt:
* platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/mac/fast/forms/search-styled-expected.txt:
* platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
* platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] WebOverlay API
commit-queue@webkit.org [Tue, 29 May 2012 11:14:29 +0000 (11:14 +0000)]
[BlackBerry] WebOverlay API
https://bugs.webkit.org/show_bug.cgi?id=87603

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-29
Reviewed by Rob Buis.

Source/WebKit:

Add WebOverlay related files to the build system.

PR #156812

* PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

This new API makes it possible to leverage the BlackBerry accelerated
compositing implementation to draw, transform and fluidly animate
overlays in the embedding library or application.

A WebOverlay has an affinity for the thread where it was created. If
the current thread is the WebKit thread, use WebPage::addOverlay() to
add it to the page, and manipulate it only from the WebKit thread, with
exception of the "override" functionality which can be used from the
compositing thread. If the current thread is the compositing thread,
use WebPage::addCompositingThreadOverlay() to add it to the page, and
only manipulate it on the compositing thread.

A WebOverlay can be painted using Skia, or its contents can be set to
an image or a solid color.

PR #156812

* Api/WebAnimation.cpp: Added.
(WebKit):
(BlackBerry::WebKit::WebAnimation::fadeAnimation):
(BlackBerry::WebKit::WebAnimation::name):
(BlackBerry::WebKit::WebAnimation::WebAnimation):
(BlackBerry::WebKit::WebAnimation::~WebAnimation):
(BlackBerry::WebKit::WebAnimation::operator=):
* Api/WebAnimation.h: Added.
(WebKit):
* Api/WebAnimation_p.h: Added.
(WebKit):
(WebAnimationPrivate):
(BlackBerry::WebKit::WebAnimationPrivate::WebAnimationPrivate):
* Api/WebOverlay.cpp: Added.
(WebKit):
(BlackBerry::WebKit::WebOverlay::WebOverlay):
(BlackBerry::WebKit::WebOverlay::~WebOverlay):
(BlackBerry::WebKit::WebOverlay::position):
(BlackBerry::WebKit::WebOverlay::setPosition):
(BlackBerry::WebKit::WebOverlay::anchorPoint):
(BlackBerry::WebKit::WebOverlay::setAnchorPoint):
(BlackBerry::WebKit::WebOverlay::size):
(BlackBerry::WebKit::WebOverlay::setSize):
(BlackBerry::WebKit::WebOverlay::sizeIsScaleInvariant):
(BlackBerry::WebKit::WebOverlay::setSizeIsScaleInvariant):
(BlackBerry::WebKit::WebOverlay::transform):
(BlackBerry::WebKit::WebOverlay::setTransform):
(BlackBerry::WebKit::WebOverlay::opacity):
(BlackBerry::WebKit::WebOverlay::setOpacity):
(BlackBerry::WebKit::WebOverlay::addAnimation):
(BlackBerry::WebKit::WebOverlay::removeAnimation):
(BlackBerry::WebKit::WebOverlay::parent):
(BlackBerry::WebKit::WebOverlay::addChild):
(BlackBerry::WebKit::WebOverlay::removeFromParent):
(BlackBerry::WebKit::WebOverlay::setContentsToImage):
(BlackBerry::WebKit::WebOverlay::setContentsToColor):
(BlackBerry::WebKit::WebOverlay::setDrawsContent):
(BlackBerry::WebKit::WebOverlay::invalidate):
(BlackBerry::WebKit::WebOverlay::setClient):
(BlackBerry::WebKit::WebOverlay::override):
(BlackBerry::WebKit::WebOverlay::resetOverrides):
(BlackBerry::WebKit::WebOverlayPrivate::page):
(BlackBerry::WebKit::WebOverlayPrivate::override):
(BlackBerry::WebKit::WebOverlayPrivate::drawContents):
(BlackBerry::WebKit::WebOverlayPrivate::scheduleCompositingRun):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::WebOverlayPrivateWebKitThread):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::override):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::position):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setPosition):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::anchorPoint):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setAnchorPoint):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::size):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setSize):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::sizeIsScaleInvariant):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setSizeIsScaleInvariant):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::transform):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setTransform):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::opacity):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setOpacity):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::addAnimation):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::removeAnimation):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::addChild):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::removeFromParent):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToImage):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToColor):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setDrawsContent):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::clear):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::invalidate):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::resetOverrides):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifySyncRequired):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::paintContents):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::~WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setDrawsContent):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::invalidate):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContents):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToColor):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::layerCompositingThreadDestroyed):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::layerVisibilityChanged):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::deleteTextures):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setClient):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::override):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::position):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setPosition):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::anchorPoint):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setAnchorPoint):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::size):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setSize):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::sizeIsScaleInvariant):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setSizeIsScaleInvariant):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::transform):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setTransform):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::opacity):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setOpacity):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::addAnimation):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeAnimation):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::addChild):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeFromParent):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToColor):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setDrawsContent):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::clear):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::invalidate):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::resetOverrides):
* Api/WebOverlay.h: Added.
(WebCore):
(WebKit):
* Api/WebOverlayClient.h: Added.
(WebKit):
* Api/WebOverlayOverride.cpp: Added.
(WebKit):
(BlackBerry::WebKit::WebOverlayOverride::WebOverlayOverride):
(BlackBerry::WebKit::WebOverlayOverride::~WebOverlayOverride):
(BlackBerry::WebKit::WebOverlayOverride::setPosition):
(BlackBerry::WebKit::WebOverlayOverride::setAnchorPoint):
(BlackBerry::WebKit::WebOverlayOverride::setSize):
(BlackBerry::WebKit::WebOverlayOverride::setTransform):
(BlackBerry::WebKit::WebOverlayOverride::setOpacity):
(BlackBerry::WebKit::WebOverlayOverride::addAnimation):
(BlackBerry::WebKit::WebOverlayOverride::removeAnimation):
* Api/WebOverlayOverride.h: Added.
(WebKit):
* Api/WebOverlay_p.h: Added.
(WTF):
(WebCore):
(WebKit):
(WebOverlayPrivate):
(BlackBerry::WebKit::WebOverlayPrivate::WebOverlayPrivate):
(BlackBerry::WebKit::WebOverlayPrivate::~WebOverlayPrivate):
(BlackBerry::WebKit::WebOverlayPrivate::setPage):
(BlackBerry::WebKit::WebOverlayPrivate::setClient):
(BlackBerry::WebKit::WebOverlayPrivate::layerCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivate::graphicsLayer):
(WebOverlayPrivateWebKitThread):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::graphicsLayer):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyAnimationStarted):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showDebugBorders):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showRepaintCounter):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::contentsVisible):
(WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setLayer):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawsContent):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::contents):
(WebOverlayPrivateCompositingThread):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::addOverlay):
(WebKit):
(BlackBerry::WebKit::WebPage::removeOverlay):
(BlackBerry::WebKit::WebPage::addCompositingThreadOverlay):
(BlackBerry::WebKit::WebPage::removeCompositingThreadOverlay):
* Api/WebPage.h:
(WebKit):
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::compositeLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::addOverlay):
(BlackBerry::WebKit::WebPageCompositorPrivate::removeOverlay):
* Api/WebPageCompositor_p.h:
(BlackBerry::WebKit::WebPageCompositorPrivate::compositingThreadOverlayLayer):
(WebPageCompositorPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed: Web Inspector: single line fix after r118742.
loislo@chromium.org [Tue, 29 May 2012 11:14:13 +0000 (11:14 +0000)]
Unreviewed: Web Inspector: single line fix after r118742.

* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapProfileHeader.prototype.saveToFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove m_rootNode and m_selectorChecker from SelectorQuery.h
haraken@chromium.org [Tue, 29 May 2012 10:42:47 +0000 (10:42 +0000)]
Remove m_rootNode and m_selectorChecker from SelectorQuery.h
https://bugs.webkit.org/show_bug.cgi?id=87650

Reviewed by Antti Koivisto.

To avoid parsing CSS selectors every time, I am planning to cache
SelectorQuery objects into a HashMap, which will be defined in
Node::querySelector(). To make the size of SelectorQuery small,
this patch removes m_rootNode and m_selectorChecker from SelectorQuery.h.

Tests: fast/dom/SelectorAPI/*. No change in test results.

* dom/Node.cpp:
(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):
* dom/SelectorQuery.cpp:
(WebCore::SelectorQuery::SelectorQuery):
(WebCore):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):
* dom/SelectorQuery.h:
(SelectorQuery):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Tabbed Settings Screen
caseq@chromium.org [Tue, 29 May 2012 10:06:05 +0000 (10:06 +0000)]
Web Inspector: Tabbed Settings Screen
https://bugs.webkit.org/show_bug.cgi?id=87497

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-05-29
Reviewed by Yury Semikhatsky.

Combine settings screen and shortcuts screen
to a single tabbed settings screen.
This will make shortcuts screen more discoverable.

* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen): Make titled tamplate optional.
(WebInspector.HelpScreen.prototype._createCloseButton): Extract method.
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen): Split initialization and UI construction.
(WebInspector.SettingsScreen.prototype._createSettingsTabView.appendSection):
(WebInspector.SettingsScreen.prototype._createSettingsTabView):
Extract GUI construction method.
(WebInspector.SettingsScreen.prototype._getOrCreateTabbedPane):
Make GUI construction lazy.
(WebInspector.SettingsScreen.prototype.selectTab):
Add method for external tab swithching.
(WebInspector.SettingsScreen.prototype.wasShown):
Make GUI construction lazy.
(WebInspector.SettingsScreenTabbedPane):
Extend class to access protected member.
(WebInspector.SettingsController.prototype._buttonClicked):
Change "showSettingsScreen" visibility and parameters.
(WebInspector.SettingsController.prototype._onHideSettingsScreen):
Preserve settings screen state.
(WebInspector.SettingsController.prototype.showSettingsScreen):
Change method visibility and parameters.
* inspector/front-end/ShortcutsScreen.js:
(WebInspector.ShortcutsScreen): Remove inheritance from HelpScreen.
(WebInspector.ShortcutsScreen.prototype._createShortcutsTabView):
Refactoring of GUI construction.
(WebInspector.ShortcutsSection.prototype.renderSection):
Ditto.
* inspector/front-end/helpScreen.css:
(.help-window-main ::-webkit-scrollbar): Rebind scrollbar settings.
(.help-window-main ::-webkit-resizer): Ditto.
(.help-window-main ::-webkit-scrollbar-thumb:vertical): Ditto.
(.help-window-main ::-webkit-scrollbar-thumb:vertical:active): Ditto.
(.help-window-main ::-webkit-scrollbar-track:vertical): Ditto.
(body:not(.compact) #settings-screen .tabbed-pane): Fix container height.
(#settings-screen .tabbed-pane-header): Ditto.
(#settings-screen .tabbed-pane-header-tabs): Adjust spacing.
(#settings-screen .tabbed-pane-header-tab): Adjust style.
(#settings-screen .help-close-button): Adjust spacing.
(#settings-screen .tabbed-pane-header-tab.selected):
Erase line below active tab.
(#settings-screen .tabbed-pane-content): Adjust spacing.
(#settings-screen .help-content): Ditto.
* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown): Use Settings screen to show shortcuts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
peter@chromium.org [Tue, 29 May 2012 09:43:13 +0000 (09:43 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Update test expectations
tkent@chromium.org [Tue, 29 May 2012 09:35:21 +0000 (09:35 +0000)]
[Chromium] Update test expectations
https://bugs.webkit.org/show_bug.cgi?id=87155

More placehodler tests.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Update test expectations.
tkent@chromium.org [Tue, 29 May 2012 09:29:34 +0000 (09:29 +0000)]
[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=87155

Placeholder-related render dumps need to be udpated.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening after r118618. http/tests/cache/cancel-in-progress-load...
kkristof@inf.u-szeged.hu [Tue, 29 May 2012 09:20:04 +0000 (09:20 +0000)]
[Qt] Unreviewed gardening after r118618. http/tests/cache/cancel-in-progress-load.html
fails with code 5.
https://bugs.webkit.org/show_bug.cgi?id=35377

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-05-29

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: REGRESSION: load heap snapshot doesn't work.
loislo@chromium.org [Tue, 29 May 2012 09:17:36 +0000 (09:17 +0000)]
Web Inspector: REGRESSION: load heap snapshot doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=87642

Source/WebCore:

HeapSnapshotReceiver interface was introduced.
It declares the API for HeapSnapshotLoader, HeapSnapshotLoaderProxy and HeapSnapshotSaveToFileReceiver.
The HeapProfileHeader was refactored and tests were added.

Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshotLoader.js:
(WebInspector.HeapSnapshotLoader):
(WebInspector.HeapSnapshotLoader.prototype.startLoading):
(WebInspector.HeapSnapshotLoader.prototype.dispose):
(WebInspector.HeapSnapshotLoader.prototype._reset):
(WebInspector.HeapSnapshotLoader.prototype.finishLoading):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorker.prototype.startCheckingForLongRunningCalls):
(WebInspector.HeapSnapshotLoaderProxy.prototype.startLoading):
(WebInspector.HeapSnapshotLoaderProxy.prototype.pushJSONChunk):
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotReceiver):
(WebInspector.HeapSnapshotReceiver.prototype.startLoading):
(WebInspector.HeapSnapshotReceiver.prototype.pushJSONChunk):
(WebInspector.HeapSnapshotReceiver.prototype.finishLoading):
(WebInspector.HeapSnapshotReceiver.prototype.dispose):
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._setupWorker):
(WebInspector.HeapProfileHeader.prototype.dispose):
(WebInspector.HeapProfileHeader.prototype._saveStatusUpdate):
(WebInspector.HeapProfileHeader.prototype.pushJSONChunk):
(WebInspector.HeapProfileHeader.prototype._parsed):
(WebInspector.HeapProfileHeader.prototype.finishHeapSnapshot):
(WebInspector.HeapProfileHeader.prototype.saveToFile):
(WebInspector.HeapProfileHeader.prototype.loadFromFile.onLoad):
(WebInspector.HeapProfileHeader.prototype.loadFromFile):
(WebInspector.HeapProfileHeader.prototype._loadNextChunk):
(WebInspector.HeapProfileHeader.prototype._nextChunkLoaded):
(WebInspector.HeapProfileHeader.prototype._createFileReader):
(WebInspector.HeapSnapshotSaveToFileReceiver):
(WebInspector.HeapSnapshotSaveToFileReceiver.prototype.startLoading):
(WebInspector.HeapSnapshotSaveToFileReceiver.prototype.pushJSONChunk):
(WebInspector.HeapSnapshotSaveToFileReceiver.prototype.finishLoading):
(WebInspector.HeapSnapshotSaveToFileReceiver.prototype.dispose):
(WebInspector.HeapSnapshotSaveToFileReceiver.prototype._startSavingSnapshot):
(WebInspector.HeapSnapshotSaveToFileReceiver.prototype._saveStatusUpdate):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._createFileSelectorElement.onChange):
(WebInspector.ProfilesPanel.prototype._createFileSelectorElement):
(WebInspector.ProfilesPanel.prototype._loadFromFile):

LayoutTests:

HeapSnapshotReceiver interface was introduced.
It declares the API for HSLoader, HSLoaderProxy and HSSaveToFileReceiver.
The HeapProfileHeader was refactored and tests were added.

Reviewed by Yury Semikhatsky.

* inspector/profiler/heap-snapshot-loader-expected.txt:
* inspector/profiler/heap-snapshot-loader.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTest expectation pngs missing checksums are treated as MISSING by bots
bulach@chromium.org [Tue, 29 May 2012 09:12:11 +0000 (09:12 +0000)]
Test expectation pngs missing checksums are treated as MISSING by bots
https://bugs.webkit.org/show_bug.cgi?id=87552

Unreviewed gardening.

This test was already failing for IMAGE and TEXT reasons prior to r118566.
On r118566, new images were added, probably without an embedded checksum.
It looks like our test infrastructure thinks that these images are MISSING.
Temporarily add MISSING expectations, so that we can proceed with this (failing) test.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse WebSpellCheckClient::spellcheck to retrieve suggestions.
hbono@chromium.org [Tue, 29 May 2012 09:10:41 +0000 (09:10 +0000)]
Use WebSpellCheckClient::spellcheck to retrieve suggestions.
https://bugs.webkit.org/show_bug.cgi?id=87690

Reviewed by Hajime Morita.

This change uses WebSpellCheckClient::spellcheck as a fallback method to
retrieve suggestions when a marker does not have any suggestions. (It consumes
lots of CPU power to get suggestions for misspelled word, i.e. Chromium cannot
afford to attach suggestions to all spelling markers.)

* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Retrieve suggestions if markers do not have any.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] MathML tests needs rebaseline after r118713
commit-queue@webkit.org [Tue, 29 May 2012 09:06:53 +0000 (09:06 +0000)]
[EFL] MathML tests needs rebaseline after r118713
https://bugs.webkit.org/show_bug.cgi?id=87705

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-29

* platform/efl/mathml/presentation/mo-stretch-expected.png:
* platform/efl/mathml/presentation/mo-stretch-expected.txt:
* platform/efl/mathml/presentation/mroot-pref-width-expected.png:
* platform/efl/mathml/presentation/mroot-pref-width-expected.txt:
* platform/efl/mathml/presentation/tables-expected.png:
* platform/efl/mathml/presentation/tables-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening after r118585. Added Qt platform specific expected files.
kkristof@inf.u-szeged.hu [Tue, 29 May 2012 09:05:27 +0000 (09:05 +0000)]
[Qt] Unreviewed gardening after r118585. Added Qt platform specific expected files.
https://bugs.webkit.org/show_bug.cgi?id=86848

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-05-29

* platform/qt/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Added.
* platform/qt/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd HTMLIFrameElement.seamless property accessor now that seamless is enabled and...
eric@webkit.org [Tue, 29 May 2012 09:01:34 +0000 (09:01 +0000)]
Add HTMLIFrameElement.seamless property accessor now that seamless is enabled and works
https://bugs.webkit.org/show_bug.cgi?id=87708

Reviewed by Adam Barth.

Source/WebCore:

Lots of tests in fast/frames/seamless cover this property.

* html/HTMLIFrameElement.idl:

LayoutTests:

* fast/frames/seamless/seamless-basic-expected.txt:
* fast/frames/seamless/seamless-inherited-origin-expected.txt:
* fast/frames/seamless/seamless-nested-expected.txt:
* fast/frames/seamless/seamless-quirks-expected.txt:
* fast/frames/seamless/seamless-sandbox-flag-expected.txt:
* fast/frames/seamless/seamless-sandbox-srcdoc-expected.txt:
* http/tests/security/seamless/seamless-cross-origin-expected.txt:
* http/tests/security/seamless/seamless-sandbox-srcdoc-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Performance] Optimize querySelector() and querySelectorAll() by removing
haraken@chromium.org [Tue, 29 May 2012 08:43:40 +0000 (08:43 +0000)]
[Performance] Optimize querySelector() and querySelectorAll() by removing
redundant dummy style sheet creations
https://bugs.webkit.org/show_bug.cgi?id=87627

Reviewed by Antti Koivisto.

This patch improves performance of querySelector("#id") by 4.2% ~ 17.7%
in Safari and Chromium.

Performance tests: https://bugs.webkit.org/attachment.cgi?id=144288

The performance test results in my desktop:

[Safari/Mac]
document.querySelector("#headId") :               13.60 ms =>  12.40 ms  +9.68%
document.querySelector("#duplicatedId") :         14.80 ms =>  14.20 ms  +4.23%
document.querySelector("#tailId") :               13.80 ms =>  12.20 ms  +13.11%
document.querySelectorAll("#headId") :            17.80 ms =>  14.60 ms  +21.92%
document.querySelectorAll("#duplicatedId") :     513.80 ms => 471.60 ms  +8.95%
document.querySelectorAll("#tailId") :            19.20 ms =>  16.40 ms  +17.07%
document.querySelector("h1") :                    14.40 ms =>  13.60 ms  +5.88%
document.querySelector("h2") :                    14.80 ms =>  13.80 ms  +7.25%
document.querySelector("h3") :                   312.00 ms => 306.60 ms  +1.76%
document.querySelectorAll("h1") :                322.00 ms => 314.60 ms  +2.35%
document.querySelectorAll("h2") :                481.00 ms => 420.60 ms  +14.36%
document.querySelectorAll("h3") :                326.80 ms => 315.80 ms  +3.48%
document.querySelector(".headClass") :            16.20 ms =>  15.40 ms  +5.19%
document.querySelector(".duplicatedClass") :      17.00 ms =>  15.40 ms  +10.39%
document.querySelector(".tailClass") :           369.60 ms => 362.60 ms  +1.93%
document.querySelectorAll(".headClass") :        388.20 ms => 377.60 ms  +2.81%
document.querySelectorAll(".duplicatedClass") :  605.00 ms => 581.20 ms  +4.09%
document.querySelectorAll(".tailClass") :        401.60 ms => 391.40 ms  +2.61%

[Chromium/Linux]
ocument.querySelector("#headId") :                16.00 ms =>  13.60 ms  +17.65%
document.querySelector("#duplicatedId") :         16.80 ms =>  15.40 ms  +9.09%
document.querySelector("#tailId") :               16.00 ms =>  13.60 ms  +17.65%
document.querySelectorAll("#headId") :            29.00 ms =>  25.00 ms  +16.00%
document.querySelectorAll("#duplicatedId") :     561.40 ms => 505.20 ms  +11.12%
document.querySelectorAll("#tailId") :            34.00 ms =>  26.80 ms  +26.87%
document.querySelector("h1") :                    18.20 ms =>  15.80 ms  +15.19%
document.querySelector("h2") :                    19.00 ms =>  16.60 ms  +14.46%
document.querySelector("h3") :                   280.40 ms => 274.00 ms  +2.34%
document.querySelectorAll("h1") :                300.20 ms => 365.20 ms  -17.80%
document.querySelectorAll("h2") :                487.60 ms => 504.20 ms  -3.29%
document.querySelectorAll("h3") :                349.40 ms => 324.00 ms  +7.84%
document.querySelector(".headClass") :            18.40 ms =>  16.00 ms  +15.00%
document.querySelector(".duplicatedClass") :      19.40 ms =>  16.20 ms  +19.75%
document.querySelector(".tailClass") :           349.60 ms => 345.40 ms  +1.22%
document.querySelectorAll(".headClass") :        382.80 ms => 378.20 ms  +1.22%
document.querySelectorAll(".duplicatedClass") :  550.80 ms => 574.20 ms  -4.08%
document.querySelectorAll(".tailClass") :        381.00 ms => 387.00 ms  -1.55%

I've found that StyleSheetInternal::create() in CSSParser::parseSelector()
is a bottleneck of querySelector() and querySelectorAll().

void CSSParser::parseSelector(const String& string, CSSSelectorList& selectorList)
{
    RefPtr<StyleSheetInternal> dummyStyleSheet = StyleSheetInternal::create();
    setStyleSheet(dummyStyleSheet.get());
    ...;
}

This patch removes a dummy style sheet. Previously the dummy style sheet
was needed to avoid null checks of m_styleSheet in CSSGrammer.y.
This patch fixes CSSGrammer.y so that it works fine with a null m_styleSheet.

Tests: fast/dom/SelectorAPI/*. No change in the test results.

* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::parseSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSVGViewSpec DOM bindings aka SVGSVGElement.currentView is unimplemented
zimmermann@webkit.org [Tue, 29 May 2012 08:41:58 +0000 (08:41 +0000)]
SVGViewSpec DOM bindings aka SVGSVGElement.currentView is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=15495

Reviewed by Rob Buis.

Source/WebCore:

Finish SVGViewSpec implementation and expose it to the Web. Numerous smaller bugs are fixed:
- SVGViewSpec and all of its contents should be read-only. Enforce that and test it.
  Add a new enum to SVGPropertyInfo so that each SVGAnimatedProperty knows if its content is supposed to be read-write or read-only.
- Make the 'transform' attribute of SVGViewSpec exposable by switching to a SVGTransformListProperty - it can now be accessed from JS.
- Assure that following XXXString methods are in sync with the corresponding SVG DOM interfaces
    readonly attribute DOMString viewBoxString;
    readonly attribute DOMString preserveAspectRatioString;
    readonly attribute DOMString transformString;
    readonly attribute DOMString viewTargetString;
- Cleanup code in svg/properties that was intended to handle SVGViewSpec. Turns out lot of the complexity was unncessary, and can be removed.
- Move SVGFitToViewBox to the same pattern SVGZoomAndPan uses since two days, that avoids any virtual function calls for attribute parsing.
- Create/expose ObjectiveC/JS bindings for SVGViewSpec.
- Enable SVGViewSpec constructor.

Tests: svg/custom/linking-a-03-b-all-expected.svg
       svg/dom/SVGViewSpec-defaults.html
       svg/dom/SVGViewSpec.html
       svg/dom/complex-svgView-specification.html
       svg/dom/viewspec-parser.html

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.order:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSSVGLengthCustom.cpp:
(WebCore::JSSVGLength::setValue):
(WebCore::JSSVGLength::convertToSpecifiedUnits):
* bindings/objc/DOMSVG.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(NativeToJSValue):
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateFunctionCallback):
* bindings/v8/custom/V8SVGLengthCustom.cpp:
(WebCore::V8SVGLength::valueAccessorSetter):
(WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
* page/DOMWindow.idl:
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::buildTileImageTransform):
* svg/SVGFitToViewBox.cpp:
* svg/SVGFitToViewBox.h:
(SVGFitToViewBox):
(WebCore::SVGFitToViewBox::parseAttribute):
* svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::orientTypePropertyInfo):
(WebCore::SVGMarkerElement::parseAttribute):
(WebCore::SVGMarkerElement::synchronizeOrientType):
(WebCore::SVGMarkerElement::lookupOrCreateOrientTypeWrapper):
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::dPropertyInfo):
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathByteStream):
(WebCore::SVGPathElement::lookupOrCreateDWrapper):
(WebCore::SVGPathElement::synchronizeD):
* svg/SVGPathSegWithContext.h:
(WebCore::SVGPathSegWithContext::animatedProperty):
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::parseAttribute):
* svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::pointsPropertyInfo):
(WebCore::SVGPolyElement::parseAttribute):
(WebCore::SVGPolyElement::synchronizePoints):
(WebCore::SVGPolyElement::lookupOrCreatePointsWrapper):
* svg/SVGRect.h:
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::~SVGSVGElement):
(WebCore::SVGSVGElement::currentView):
(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::currentViewBoxRect):
(WebCore::SVGSVGElement::viewBoxToViewTransform):
(WebCore::SVGSVGElement::setupInitialView):
(WebCore::SVGSVGElement::inheritViewAttributes):
* svg/SVGSVGElement.h:
(SVGSVGElement):
* svg/SVGSVGElement.idl:
* svg/SVGSymbolElement.cpp:
(WebCore::SVGSymbolElement::parseAttribute):
* svg/SVGTests.cpp:
(WebCore::SVGTests::requiredFeaturesPropertyInfo):
(WebCore::SVGTests::requiredExtensionsPropertyInfo):
(WebCore::SVGTests::systemLanguagePropertyInfo):
(WebCore::SVGTests::synchronizeRequiredFeatures):
(WebCore::SVGTests::synchronizeRequiredExtensions):
(WebCore::SVGTests::synchronizeSystemLanguage):
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::textLengthPropertyInfo):
(WebCore::SVGTextContentElement::synchronizeTextLength):
(WebCore::SVGTextContentElement::lookupOrCreateTextLengthWrapper):
* svg/SVGViewElement.cpp:
(WebCore::SVGViewElement::parseAttribute):
* svg/SVGViewElement.h:
* svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::viewBoxPropertyInfo):
(WebCore::SVGViewSpec::preserveAspectRatioPropertyInfo):
(WebCore::SVGViewSpec::transformPropertyInfo):
(WebCore::SVGViewSpec::SVGViewSpec):
(WebCore::SVGViewSpec::viewBoxIdentifier):
(WebCore::SVGViewSpec::preserveAspectRatioIdentifier):
(WebCore::SVGViewSpec::transformIdentifier):
(WebCore::SVGViewSpec::setZoomAndPan):
(WebCore::SVGViewSpec::setTransformString):
(WebCore::SVGViewSpec::transformString):
(WebCore::SVGViewSpec::viewBoxString):
(WebCore::SVGViewSpec::preserveAspectRatioString):
(WebCore::SVGViewSpec::viewTarget):
(WebCore::SVGViewSpec::transform):
(WebCore::SVGViewSpec::lookupOrCreateViewBoxWrapper):
(WebCore::SVGViewSpec::lookupOrCreatePreserveAspectRatioWrapper):
(WebCore::SVGViewSpec::lookupOrCreateTransformWrapper):
(WebCore::SVGViewSpec::reset):
(WebCore::SVGViewSpec::parseViewSpec):
* svg/SVGViewSpec.h:
(WebCore::SVGViewSpec::~SVGViewSpec):
(SVGViewSpec):
(WebCore::SVGViewSpec::create):
(WebCore::SVGViewSpec::setViewTargetString):
(WebCore::SVGViewSpec::setZoomAndPan):
(WebCore::SVGViewSpec::contextElement):
(WebCore::SVGViewSpec::resetContextElement):
(WebCore::SVGViewSpec::transformBaseValue):
(WebCore::SVGViewSpec::viewBoxAnimated):
(WebCore::SVGViewSpec::viewBox):
(WebCore::SVGViewSpec::viewBoxBaseValue):
(WebCore::SVGViewSpec::setViewBoxBaseValue):
(WebCore::SVGViewSpec::preserveAspectRatioAnimated):
(WebCore::SVGViewSpec::preserveAspectRatio):
(WebCore::SVGViewSpec::preserveAspectRatioBaseValue):
(WebCore::SVGViewSpec::setPreserveAspectRatioBaseValue):
* svg/SVGViewSpec.idl:
* svg/properties/SVGAnimatedProperty.h:
(WebCore::SVGAnimatedProperty::isReadOnly):
(WebCore::SVGAnimatedProperty::setIsReadOnly):
(SVGAnimatedProperty):
(WebCore::SVGAnimatedProperty::lookupOrCreateWrapper):
(WebCore::SVGAnimatedProperty::lookupWrapper):
(WebCore::SVGAnimatedProperty::SVGAnimatedProperty):
* svg/properties/SVGAnimatedPropertyMacros.h:
(WebCore::SVGSynchronizableAnimatedProperty::synchronize):
(SVGSynchronizableAnimatedProperty):
* svg/properties/SVGAnimatedPropertySynchronizer.h: Removed.
* svg/properties/SVGAttributeToPropertyMap.h:
* svg/properties/SVGListProperty.h:
* svg/properties/SVGListPropertyTearOff.h:
(SVGListPropertyTearOff):
(WebCore::SVGListPropertyTearOff::isReadOnly):
* svg/properties/SVGPathSegListPropertyTearOff.h:
(SVGPathSegListPropertyTearOff):
(WebCore::SVGPathSegListPropertyTearOff::isReadOnly):
* svg/properties/SVGProperty.h:
(SVGProperty):
* svg/properties/SVGPropertyInfo.h:
(WebCore::SVGPropertyInfo::SVGPropertyInfo):
(SVGPropertyInfo):
* svg/properties/SVGPropertyTearOff.h:
(WebCore::SVGPropertyTearOff::isReadOnly):
* svg/properties/SVGStaticListPropertyTearOff.h:
(SVGStaticListPropertyTearOff):
(WebCore::SVGStaticListPropertyTearOff::isReadOnly):

Source/WebKit/mac:

* MigrateHeaders.make: Copy DOMSVGViewSpec*.h headers.

LayoutTests:

Re-enable a long disabled test for SVGViewSpec, and make it actually work.
Extend SVGViewSpec test coverage, and rebaseline results that changed due the SVGViewSpec constructor addition.

Make linking-a-03-b-all.svg a reftest, to avoid rebaselines on all platforms.

* platform/chromium-linux/svg/custom/linking-a-03-b-all-expected.png: Removed.
* platform/chromium-mac/svg/custom/linking-a-03-b-all-expected.png: Removed.
* platform/chromium-win/fast/js/global-constructors-expected.txt:
* platform/chromium-win/svg/custom/linking-a-03-b-all-expected.png: Removed.
* platform/chromium-win/svg/custom/linking-a-03-b-all-expected.txt: Removed.
* platform/gtk/fast/js/global-constructors-expected.txt:
* platform/gtk/svg/custom/linking-a-03-b-all-expected.png: Removed.
* platform/gtk/svg/custom/linking-a-03-b-all-expected.txt: Removed.
* platform/mac/fast/js/global-constructors-expected.txt:
* platform/mac/svg/custom/linking-a-03-b-all-expected.png: Removed.
* platform/mac/svg/custom/linking-a-03-b-all-expected.txt: Removed.
* platform/qt/fast/js/global-constructors-expected.txt:
* platform/qt/svg/custom/linking-a-03-b-all-expected.png: Removed.
* platform/qt/svg/custom/linking-a-03-b-all-expected.txt: Removed.
* platform/win/fast/js/global-constructors-expected.txt:
* svg/custom/global-constructors-expected.txt:
* svg/custom/linking-a-03-b-all-expected.svg: Added.
* svg/dom/SVGViewSpec-defaults-expected.txt: Added.
* svg/dom/SVGViewSpec-defaults.html: Added.
* svg/dom/SVGViewSpec-expected.txt: Added.
* svg/dom/SVGViewSpec.html: Added.
* svg/dom/complex-svgView-specification-expected.html: Added.
* svg/dom/complex-svgView-specification.html: Added.
* svg/dom/resources/viewspec-target.svg: Added.
* svg/dom/script-tests/SVGViewSpec-defaults.js: Added.
* svg/dom/script-tests/SVGViewSpec.js: Added.
(completeTest.script.onload):
(completeTest):
(testFragment):
(matrixToString):
(continueTesting):
* svg/dom/viewspec-parser-expected.txt: Added.
* svg/dom/viewspec-parser.html: Renamed from LayoutTests/svg/dom/viewspec-parser.html-disabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Adjust expectations for fast/layers/clip-rects-assertion-expected.txt
bulach@chromium.org [Tue, 29 May 2012 08:32:51 +0000 (08:32 +0000)]
[chromium] Adjust expectations for fast/layers/clip-rects-assertion-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=87671

Unreviewed gardening.
Test has been fixed by r118724, remove expectation.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r90971): the cursor is painted “behind” the placeholder text
tkent@chromium.org [Tue, 29 May 2012 08:23:17 +0000 (08:23 +0000)]
REGRESSION (r90971): the cursor is painted “behind” the placeholder text
https://bugs.webkit.org/show_bug.cgi?id=87155

Reviewed by Hajime Morita.

Source/WebCore:

This regression happened only on platforms on which
RenderTheme::shouldShowPlaceholderWhenFocused() returns true.

Because the order of renderers for the editable node and the placeholder
node was:
 - A renderer for the editable node
 - A renderer for the placeholder node,
The text caret was painted, then the palceholder was painted.

We should not use z-index in the built-in shadow nodes. So the patch
fixes this bug by re-ordering these renderers.

Tests: fast/forms/input-placeholder-paint-order-2.html
       fast/forms/input-placeholder-paint-order.html
       fast/forms/textarea/textarea-placeholder-paint-order-2.html
       fast/forms/textarea/textarea-placeholder-paint-order.html

* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::fixPlaceholderRenderer):
Added. Reorder the order of renderers so that the placeholder renderer
precedes the inner text renderer.
* html/HTMLTextFormControlElement.h: Add fixPlaceholderRenderer() declaration.

* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::attach): Calls fixPlaceholderRenderer().
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
ditto. Also, use innerTextElement() to improvde code readability.
* html/HTMLTextAreaElement.h:
(HTMLTextAreaElement): Overrides attach().

* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::updatePlaceholderText):
Calls fixPlaceholderRenderer().
(WebCore::TextFieldInputType::attach): ditto.
* html/TextFieldInputType.h:
(TextFieldInputType): Overrides attach().

LayoutTests:

* fast/forms/input-placeholder-paint-order-2-expected.html: Added.
* fast/forms/input-placeholder-paint-order-2.html: Added.
* fast/forms/input-placeholder-paint-order.html: Added.
* fast/forms/textarea/textarea-placeholder-paint-order-2-expected.html: Added.
* fast/forms/textarea/textarea-placeholder-paint-order-2.html: Added.
* fast/forms/textarea/textarea-placeholder-paint-order.html: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-placeholder-paint-order-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-placeholder-paint-order-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Add return value information to WebKitWebView::load-failed signal documentation
carlosgc@webkit.org [Tue, 29 May 2012 08:08:18 +0000 (08:08 +0000)]
[GTK] Add return value information to WebKitWebView::load-failed signal documentation
https://bugs.webkit.org/show_bug.cgi?id=87704

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Add WebKitWebInspector.h to the list of WebKit2 GTK public headers
carlosgc@webkit.org [Tue, 29 May 2012 08:06:06 +0000 (08:06 +0000)]
[GTK] Add WebKitWebInspector.h to the list of WebKit2 GTK public headers
https://bugs.webkit.org/show_bug.cgi?id=87703

Reviewed by Martin Robinson.

* GNUmakefile.list.am: Add WebKitWebInspector.h to webkit2gtk_h_api.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening after r118631. http/tests/appcache/load-from-appcache-defer...
kkristof@inf.u-szeged.hu [Tue, 29 May 2012 07:57:26 +0000 (07:57 +0000)]
[Qt] Unreviewed gardening after r118631. http/tests/appcache/load-from-appcache-defer-resume-crash.html
fails because of missing LayoutTestController::setUseDeferredFrameLoading implementation.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-05-29

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Compilation warning in DumpRenderTreeView.cpp
commit-queue@webkit.org [Tue, 29 May 2012 07:51:23 +0000 (07:51 +0000)]
[EFL] Compilation warning in DumpRenderTreeView.cpp
https://bugs.webkit.org/show_bug.cgi?id=87636

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-29
Reviewed by Filip Pizlo.

Source/WebKit/efl:

Fix return type of exceeded_application_cache_quota callback, it
should be int64_t, not uint64_t.

* ewk/ewk_view.h:

Tools:

Fix compilation error in DumpRenderTreeView.cpp due to wrong format
specifier in printf. Also fix the return type for
onExceededApplicationCacheQuota callback.

* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onExceededApplicationCacheQuota):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding Hironori Bono to committers.py.
hbono@chromium.org [Tue, 29 May 2012 07:34:49 +0000 (07:34 +0000)]
Adding Hironori Bono to committers.py.
https://bugs.webkit.org/show_bug.cgi?id=87697

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] New fast/dom/window-scroll-scaling.html made 3-400 tests flakey
ossy@webkit.org [Tue, 29 May 2012 06:44:24 +0000 (06:44 +0000)]
[Qt] New fast/dom/window-scroll-scaling.html made 3-400 tests flakey
https://bugs.webkit.org/show_bug.cgi?id=87700

Unreviewed gardening to paint the bot less and less red.

* platform/qt/Skipped: Skip fast/dom/window-scroll-scaling.html until proper fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Implement V8Binding::v8Null(isolate) and use it in CodeGeneratorV8.pm
haraken@chromium.org [Tue, 29 May 2012 06:42:08 +0000 (06:42 +0000)]
[V8] Implement V8Binding::v8Null(isolate) and use it in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=87692

Reviewed by Adam Barth.

Since v8::Null(isolate) crashes if we pass a NULL isolate, we are planning
to pass Isolate to v8::Null() in the following steps:

[1] Implement V8Bindings::v8Null(isolate). v8Null(isolate) does the NULL check.
If isolate is NULL, v8Null(isolate) calls v8::Null(). Otherwise,
v8Null(isolate) calls v8::Null(isolate).

[2] In V8 bindings, we replace v8::Null() with v8::Null(isolate) for a non-optional
'isolate' parameter. (e.g. void foo(..., Isolate* isolate) { v8::Null(); } )

[3] In V8 bindings, we replace v8::Null() with v8Null(isolate) for an optional
'isolate' parameter. (e.g. void foo(..., Isolate* isolate = 0) { v8::Null(); } )

This bug fixes [1] by implementing V8Binding::v8Null(isolate). Also this patch uses
V8Binding::v8Null(isolate) in bindings/v8/*.{h,cpp}.

No tests. No behavior change.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(NativeToJSValue):
* bindings/scripts/test/V8/V8Float64Array.h:
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestException.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestObj.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetter):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::toV8):
* bindings/v8/V8Binding.h:
(WebCore::v8Null):
(WebCore):
(WebCore::v8DateOrNull):
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8DOMWrapper.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a crash in HTMLFormControlElement::disabled().
tkent@chromium.org [Tue, 29 May 2012 05:37:57 +0000 (05:37 +0000)]
Fix a crash in HTMLFormControlElement::disabled().
https://bugs.webkit.org/show_bug.cgi?id=86534

Reviewed by Ryosuke Niwa.

Source/WebCore:

Stop to hold pointers of fildset and legend elements. We can avoid it by
holding ancestor's disabled state.

The ancesotr's disabled state should be invalidated when
 - fieldset's disabled value is changed.
 - fieldset's children is updated because a legend position might be changed.
 - A form control is attached to or detached from a tree.

No new tests. It's almost impossible to make a reliable test.

* html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::invalidateDisabledStateUnder):
Added. Invalidate disabled state of form controls under the specified node.
(WebCore::HTMLFieldSetElement::disabledAttributeChanged):
Uses invalidateDisabledStateUnder().
(WebCore::HTMLFieldSetElement::childrenChanged):
Added new override function. We need invalidate disabled state of form
controls under legend elements.

* html/HTMLFieldSetElement.h:
(HTMLFieldSetElement): Add invalidateDisabledStateUnder() and childrenChanged().

* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
Remove initialization of the removed data members.
Initialize m_ancestorDisabledState.
(WebCore::HTMLFormControlElement::updateAncestorDisabledState):
Update m_ancestorDisabledState. It should be
AncestorDisabledStateDisabled if the control is under a disabled
fieldset and not under the first legend child of the disabled filedset.
(WebCore::HTMLFormControlElement::ancestorDisabledStateWasChanged):
Invalidate m_ancestorDisabledState.
(WebCore::HTMLFormControlElement::insertedInto): ditto.
(WebCore::HTMLFormControlElement::removedFrom): ditto.
(WebCore::HTMLFormControlElement::disabled):
Calls updateAncestorDisabledState() if needed.
(WebCore::HTMLFormControlElement::recalcWillValidate):
Remove unnecessary check for m_legendAncestor.

* html/HTMLFormControlElement.h:
(HTMLFormControlElement):
- Rename updateFieldSetAndLegendAncestor() to updateAncestorDisabledState(), and make it private.
- Remove m_fieldSetAncestor, m_legendAncestor, and m_fieldSetAncestorValid.
- Add m_ancestorDisabledState.

LayoutTests:

Add a testcase to confirm <lagend> doesn't affect validation.

* fast/forms/datalist/datalist-child-validation-expected.txt:
* fast/forms/datalist/datalist-child-validation.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemoves pixel result requirements from fast/layers/clip-rects-assertion-expected.txt
bulach@chromium.org [Tue, 29 May 2012 05:16:54 +0000 (05:16 +0000)]
Removes pixel result requirements from fast/layers/clip-rects-assertion-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=87663

Unreviewed gardening.

This test was added by r118612, but no pixel result were provided.
It seems that it's enough to remove the param for dumpAsText() and just use the text text output.

* fast/layers/clip-rects-assertion.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebSocket] Receiving reserved close codes, 1005, 1006, and 1015 must appear as code...
toyoshim@chromium.org [Tue, 29 May 2012 05:15:23 +0000 (05:15 +0000)]
[WebSocket] Receiving reserved close codes, 1005, 1006, and 1015 must appear as code=1006 and wasClean=false
https://bugs.webkit.org/show_bug.cgi?id=87084

Reviewed by Kent Tamura.

Source/WebCore:

Status codes 1005, 1006, and 1015 are forbidden to be sent in actual close frames.
If a client received these frames, the client should handle them as broken.
Close frames containing invalid body size are the same as these forbidden cases.
Update close-code-and-reason tests to verify this patch.

* Modules/websockets/WebSocket.cpp: Handle AbnormalClosure as wasClean == false
(WebCore::WebSocket::didClose):
* Modules/websockets/WebSocketChannel.cpp: Handle close frames' status code carefully
(WebCore::WebSocketChannel::processFrame):
* Modules/websockets/WebSocketChannel.h: Update on newly defined close event codes

Source/WebKit/chromium:

Update close event codes corresponding to WebSocketChannel::CloseEventCode.

* public/WebSocket.h: Update on newly defined close event codes

LayoutTests:

Add test cases where server initiates a closing handshake with forbidden status codes.

* http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt:
* http/tests/websocket/tests/hybi/close-code-and-reason.html:
* http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt:
* http/tests/websocket/tests/hybi/workers/resources/close-code-and-reason.js:
(WebSocketTest.prototype.onclose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Avoid passing NULL to an 'isolate' parameter
haraken@chromium.org [Tue, 29 May 2012 04:11:05 +0000 (04:11 +0000)]
[V8] Avoid passing NULL to an 'isolate' parameter
https://bugs.webkit.org/show_bug.cgi?id=87689

Reviewed by Adam Barth.

v8::Null(isolate) crashes if we pass a NULL isolate.
Thus we are planning to replace v8::Null()s in a following way:

- Implement V8Bindings::v8Null(isolate). v8Null(isolate) does the NULL check.
If isolate is NULL, v8Null(isolate) calls v8::Null(). Otherwise,
v8Null(isolate) calls v8::Null(isolate).

- In V8 bindings, we replace v8::Null() with v8::Null(isolate) for a
non-optional 'isolate' parameter.
(e.g. void foo(..., Isolate* isolate) { v8::Null(); } )

- In V8 bindings, we replace v8::Null() with v8Null(isolate) for an
optional 'isolate' parameter.
(e.g. void foo(..., Isolate* isolate = 0) { v8::Null(); } )

However, currently we cannot do the replacement mechanically, since some code
pass NULL to a non-optional 'isolate' parameter. In other words, currently
"non-optional" does not guarantee that 'isolate' is not NULL.

This patch removes all the code that passes NULL to a non-optional 'isolate'
parameter. This will enable us to achieve the replacement mechanically.

No tests. No behavior change.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallbackImplementation):
(NativeToJSValue):
* bindings/scripts/test/V8/V8TestCallback.cpp:
(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):
(WebCore::V8TestCallback::callbackWithStringList):
(WebCore::V8TestCallback::callbackRequiresThisToPass):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::installPerContextProperties):
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8SQLStatementErrorCallback::handleEvent):
* bindings/v8/custom/V8MutationCallbackCustom.cpp:
(WebCore::V8MutationCallback::handleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoForm controls in <fieldset disabled> should not be validated.
tkent@chromium.org [Tue, 29 May 2012 04:08:42 +0000 (04:08 +0000)]
Form controls in <fieldset disabled> should not be validated.
https://bugs.webkit.org/show_bug.cgi?id=87381

Reviewed by Hajime Morita.

Source/WebCore:

We need to use disabeld() instead of m_disabled to calculate
willValidate property. Also, we need to update willValidate if
necessary.

Test: fast/forms/fieldset/validation-in-fieldset.html

* html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::disabledAttributeChanged):
 - Do not traverse this.
 - Calls ancestorDisabledStateWasChanged() instead of
  setNeedsStyleRecalc() because we'd like to do additional tasks.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::ancestorDisabledStateWasChanged):
Added. Just calls disabledAttributeChanged().
(WebCore::HTMLFormControlElement::parseAttribute):
Do not call setNeedsWillValidateCheck() whenever an attribute is updated.
It should be called only if disabled or readonly attribute is updated.
(WebCore::HTMLFormControlElement::disabledAttributeChanged):
Add setNeedsWillValidateCheck(). It was moved from parseAttribute().
(WebCore::HTMLFormControlElement::insertedInto):
Invalidate ancestor information.
(WebCore::HTMLFormControlElement::recalcWillValidate):
Use disabled() instead of m_disabled. disabled() takes care of
ancestor's disabled state.
* html/HTMLFormControlElement.h:
(HTMLFormControlElement):

LayoutTests:

* fast/forms/fieldset/validation-in-fieldset-expected.txt: Added.
* fast/forms/fieldset/validation-in-fieldset.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] HTMLFieldSetElement.idl doesn't have elements attribute.
commit-queue@webkit.org [Tue, 29 May 2012 03:57:17 +0000 (03:57 +0000)]
[Forms] HTMLFieldSetElement.idl doesn't have elements attribute.
https://bugs.webkit.org/show_bug.cgi?id=80110

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-05-28
Reviewed by Kent Tamura.

Source/WebCore:

Implemented elements attribute for HTMLFieldSetElement. This is spec'ed at
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#dom-fieldset-elements

Tests: fast/forms/fieldset/fieldset-elements.html
       fast/forms/fieldset/fieldset-form-collection-radionode-list.html

* dom/Node.cpp:
(WebCore::Node::radioNodeList):
Extended ASSERT to assert if not HTMLFieldSetElement or HTMLFormElement.
* html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::elements):
Elements attribute implementation.
(WebCore::HTMLFieldSetElement::refreshElementsIfNeeded):
Update the formcontrol elements collections if dom tree got modified.
(WebCore::HTMLFieldSetElement::associatedElements):
FormControl elements collection accessor.
(WebCore::HTMLFieldSetElement::length):
Number of elements in the fieldset group.
* html/HTMLFieldSetElement.h:
Added elements collection member and form control collection members.
* html/HTMLFieldSetElement.idl:
Added elements attribute.
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::formControlElements):
Added support for HTMLFieldSetElement, based on base element type gets its associated elements.
(WebCore::HTMLFormCollection::numberOfFormControlElements): Ditto
(WebCore::HTMLFormCollection::getNamedFormItem): Process image elements only for form element.
(WebCore::HTMLFormCollection::updateNameCache): Ditto
* html/RadioNodeList.cpp:
(WebCore::RadioNodeList::RadioNodeList):
DynamicSubTree root element is decided based on the type whether base element is form or fieldset element.
Renamed m_formElement to m_baseElement.
(WebCore::RadioNodeList::~RadioNodeList):
Renamed m_formElement to m_baseElement.
(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):
Form element specific changes moved under form element check.
* html/RadioNodeList.h:
(WebCore::RadioNodeList::create):
(RadioNodeList):
Renamed m_formElement to m_baseElement.

LayoutTests:

* fast/forms/fieldset/fieldset-elements-expected.txt: Added.
* fast/forms/fieldset/fieldset-elements.html: Added.
* fast/forms/fieldset/fieldset-form-collection-radionode-list-expected.txt: Added.
* fast/forms/fieldset/fieldset-form-collection-radionode-list.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] http authenticate dialog popup only once no matter authentication pass...
commit-queue@webkit.org [Tue, 29 May 2012 03:49:32 +0000 (03:49 +0000)]
[BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
https://bugs.webkit.org/show_bug.cgi?id=80135

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-05-28
Reviewed by Rob Buis.

Source/WebCore:

RIM PR: 145660
Fixed a regression introduced by r111810, we should cancel the new
request when user press cancel button in http authentication challenge
dialog, and we should also allow sending empty username and password
with the request.
Also removed redundant codes which checked the existence of the
FrameLoaderClient pointer, as we've already moved authenticationChallenge()
out of class FrameLoaderClient, it is not needed.

Manual test added. Testing http authentication dialog relies on user interaction.

Resubmit the patch reverted by r115104 after the digest infinite loop
issue for BlackBerry porting get identified and fixed.

Internally reviewed by Joe Mason <jmason@rim.com>

* platform/blackberry/PageClientBlackBerry.h:
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):

Source/WebKit/blackberry:

RIM PR: 145660
Fixed a regression introduced by r111810, which used the wrong
credential object.

Added the interface function didReceivedAuthenticaitonChallenge()
in interface class DumpRenderTreeClient;
Called m_dumpRenderTree->didReceiveAuthenticationChallenge() in
WebPagePrivate::authenticationChallenge() when DRT is enabled.

Test: reuse existing test cases:
http/tests/loading/basic-credentials-sent-automatically.html
http/tests/loading/basic-auth-resend-wrong-credentials.html

Resubmit the patch reverted by r115104 after the digest infinite loop
issue for BlackBerry porting get identified and fixed.

Internally reviewed by Joe Mason <jmason@rim.com>

* Api/DumpRenderTreeClient.h:
(WebCore):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
* Api/WebPageClient.h:
* Api/WebPage_p.h:
(WebPagePrivate):

Tools:

Implemented interface function didReceiveAuthenticationChallenge in class
DumpRenderTree.

Resubmit the patch reverted by r115104 after the digest infinite loop
issue for BlackBerry porting get identified and fixed.

Internally reviewed by Joe Mason <jmason@rim.com>

* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(drtCredentialDescription):
(BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
(WebKit):
* DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
(WebCore):
(DumpRenderTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r118646.
commit-queue@webkit.org [Tue, 29 May 2012 03:24:49 +0000 (03:24 +0000)]
Unreviewed, rolling out r118646.
http://trac.webkit.org/changeset/118646
https://bugs.webkit.org/show_bug.cgi?id=87691

broke V8 raytrace benchmark (Requested by pizlo_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-28

* heap/Heap.cpp:
(JSC::Heap::collect):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweep):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::sweepWeakSet):
(JSC):
* heap/MarkedSpace.cpp:
(JSC::SweepWeakSet::operator()):
(JSC):
(JSC::MarkedSpace::sweepWeakSets):
* heap/MarkedSpace.h:
(MarkedSpace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118718 268f45cc-cd09-0410-ab3c-d52691b4dbfc