12 years agoAdd better support for RuntimeArray type conversions.
hausmann@webkit.org [Mon, 21 Apr 2008 14:24:07 +0000 (14:24 +0000)]
Add better support for RuntimeArray type conversions.
It seems that RuntimeArray claims to inherit ArrayInstance
(in the JS sense), but the C++ class doesn't, so properly
access RuntimeArrays.  Also, properly support turning
a JS object into a QVariantMap, since we support the

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoChanged the return type of QWebFrame::evaluateJavaScript from a QString to a QVariant.
hausmann@webkit.org [Mon, 21 Apr 2008 13:57:41 +0000 (13:57 +0000)]
Changed the return type of QWebFrame::evaluateJavaScript from a QString to a QVariant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSimon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 21 Apr 2008 13:47:43 +0000 (13:47 +0000)]
Simon Hausmann <hausmann@webkit.org>

Fix painting of text fields in the CleanLooks style.

The CleanLooks style calls painter->drawRect() and expects a painter
that has no brush set. This is a fairly common assumption and therefore
we now always set the brush to NoBrush before calling a style. This
is done by centralizing the painter setup code into StylePainter
and restore the old brush in the StylePainter destructor.

In addition for textfields it is not necessary anymore to draw
PE_FrameLineEdit as we set the lineWidth in the style option correctly
and it's the style responsibility (QCommonStyle usually) to draw

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoOlivier Goffart <ogoffart@trolltech.com>
hausmann@webkit.org [Mon, 21 Apr 2008 13:47:27 +0000 (13:47 +0000)]
Olivier Goffart <ogoffart@trolltech.com>

Fixes copy and paste of international characters.

When exporting HTML to the clipboard we need meta tags for now that confirm the
conversion to utf-8 done inside QClipboard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoOlivier Goffart <ogoffart@trolltech.com>
hausmann@webkit.org [Mon, 21 Apr 2008 13:47:10 +0000 (13:47 +0000)]
Olivier Goffart <ogoffart@trolltech.com>

Fixes: Copying on X11 doesn't always work in webkit

Calling QClipboard::clear right before QClipboard::setData create a race condition with klipper. So don't call QClipboard::clear since it's not required.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSimon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 21 Apr 2008 13:40:27 +0000 (13:40 +0000)]
Simon Hausmann <hausmann@webkit.org>

Fixes redundant "Fonts" submenu in default lineedits that has only disabled items.

Don't show sub-menus that have only actions that are disabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoKavindra Devi Palaraja <kdpalara@trolltech.com>.
hausmann@webkit.org [Mon, 21 Apr 2008 13:40:05 +0000 (13:40 +0000)]
Kavindra Devi Palaraja <kdpalara@trolltech.com>.

Lots of documentation fixes, fixed all qdoc warnings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMarius Bugge Monsen <mmonsen@trolltech.com>
hausmann@webkit.org [Mon, 21 Apr 2008 12:24:23 +0000 (12:24 +0000)]
Marius Bugge Monsen <mmonsen@trolltech.com>

Fix compile failure on solaris-cc

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Mon, 21 Apr 2008 12:11:12 +0000 (12:11 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Build fix for Qt 4.3

* When building WebCore/internal make sure the QT_[BEGIN,END]_NAMESPACE is
  always defined. Do this by adding defines to the compiler line
* For users of our API this is not feasible. Every public header file should
  include qwebkitglobal.h. Define the QT_BEGIN_NAMESPACE and QT_END_NAMESPACE
  when we are building everything < 4.4.0 and don't have them defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Mon, 21 Apr 2008 11:16:08 +0000 (11:16 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Assume that our lineedit has a frame. This is needed for the motif style

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Mon, 21 Apr 2008 11:15:51 +0000 (11:15 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Follow the windows render theme when determining whether to style
listboxes or not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Mon, 21 Apr 2008 11:15:34 +0000 (11:15 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Try to bring the notImplemented implementations closer together. This will
  print each unimplemted method name only once.

* We might want to change wtf/Assertions.cpp to use qDebug

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-21 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Mon, 21 Apr 2008 10:46:47 +0000 (10:46 +0000)]
2008-04-21  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>

        Reviewed by Simon.

        * Remove the special Qt ctor of BitmapImage as it did not work. The Bitmap returned
        0 as width and after intialising drawing would fail. BitmapImage relies on a proper
        * Instead of adding more special cases to BitmapImage create a new class called StillImage
        which is getting one QPixmap and is implementing Image::draw and Image::size. This is
        working well for the images created using Image::loadPlatformResource.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWhoops, fixed file permissions to not be executable.
hausmann@webkit.org [Mon, 21 Apr 2008 10:38:44 +0000 (10:38 +0000)]
Whoops, fixed file permissions to not be executable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Mon, 21 Apr 2008 10:28:43 +0000 (10:28 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Initialize the WebGraphics with the one found in WebCore

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Mon, 21 Apr 2008 10:28:31 +0000 (10:28 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Package the Resources into a qrc

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Mon, 21 Apr 2008 10:28:15 +0000 (10:28 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Make sure every resource is available als png as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Mon, 21 Apr 2008 10:27:59 +0000 (10:27 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Allow TextAreas to be resized.
* No QWebSettings for this is introduced.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSimon Hausmann <shausman@trolltech.com>
hausmann@webkit.org [Mon, 21 Apr 2008 10:08:53 +0000 (10:08 +0000)]
Simon Hausmann <shausman@trolltech.com>

Fixes: QWebView::url property behaviour strange in designer

Added QWebView/QWebFrame::setUrl, which unlike load() clears the view immediately, schedules a load of the url but also makes sure url() returns the set url. This setter is now also used for the url property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAndre Poenitz <andre.poenitz@trolltech.com>
hausmann@webkit.org [Mon, 21 Apr 2008 09:55:09 +0000 (09:55 +0000)]
Andre Poenitz <andre.poenitz@trolltech.com>

Fixe compilation with Qt namespaces

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWhen printing on high resolution printers we need to scale the painter accordingly...
hausmann@webkit.org [Mon, 21 Apr 2008 09:36:06 +0000 (09:36 +0000)]
When printing on high resolution printers we need to scale the painter accordingly (for now).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoProvide a print preview in the QtLauncher
hausmann@webkit.org [Mon, 21 Apr 2008 09:35:53 +0000 (09:35 +0000)]
Provide a print preview in the QtLauncher

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-20 Sriram Neelakandan <sriram.neelakandan@gmail.com>
alp@webkit.org [Mon, 21 Apr 2008 06:35:28 +0000 (06:35 +0000)]
2008-04-20  Sriram Neelakandan  <sriram.neelakandan@gmail.com>

        Reviewed by Alp Toker.

        Implement FileSystemGtk's getFileModificationTime() with GLib.

        * platform/gtk/FileSystemGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-20 Christian Persch <chpe@gnome.org>
alp@webkit.org [Mon, 21 Apr 2008 06:02:28 +0000 (06:02 +0000)]
2008-04-20  Christian Persch  <chpe@gnome.org>

        Reviewed by Alp Toker.

        Bundle GTK+ Xt compatibility code from Mozilla. These files are used
        by all currently proposed GTK+ plugin patches and will make the
        proposed patches smaller and easier to review.

        These files should be kept as close to the upstream versions as
        possible so fixes can be shared between projects and to ensure
        compatibility with the reference implementation.

        * plugins/gtk/gtk2xtbin.c: Added.
        * plugins/gtk/gtk2xtbin.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-20 Dirk Schulze <vbs85@gmx.de>
alp@webkit.org [Mon, 21 Apr 2008 00:22:24 +0000 (00:22 +0000)]
2008-04-20  Dirk Schulze  <vbs85@gmx.de>

        Reviewed by Alp Toker.

        [CAIRO] SVG gradients do not work properly

        Fixed SVG-gradients in Cairo.

        * svg/graphics/cairo/SVGPaintServerGradientCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-20 Matt Lilek <webkit@mattlilek.com>
pewtermoose@webkit.org [Sun, 20 Apr 2008 20:48:55 +0000 (20:48 +0000)]
2008-04-20  Matt Lilek  <webkit@mattlilek.com>

        Mysteriously reviewed by mitz|away.

        Bug 18111: Closing a tab while dragging crashes Safari

        Null check the page before handling drag events.

        * WebView/WebView.mm:
        (-[WebView draggingUpdated:]):
        (-[WebView draggingExited:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-20 Simon Hausmann <hausmann@webkit.org>
alp@webkit.org [Sun, 20 Apr 2008 07:28:27 +0000 (07:28 +0000)]
2008-04-20  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Alp Toker.

        Share the printing code between the Gtk and the Qt port

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-19 Alp Toker <alp@nuanti.com>
alp@webkit.org [Sun, 20 Apr 2008 06:59:13 +0000 (06:59 +0000)]
2008-04-19  Alp Toker  <alp@nuanti.com>

        Reviewed by Mark Rowe.

        Complete the Cairo (CSS) gradient implementation.

        * platform/graphics/Gradient.h:
        * platform/graphics/cairo/GradientCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-19 Alp Toker <alp@nuanti.com>
alp@webkit.org [Sun, 20 Apr 2008 05:34:46 +0000 (05:34 +0000)]
2008-04-19  Alp Toker  <alp@nuanti.com>

        Reviewed by Dave Hyatt.

        Restore Cairo canvas support following the recent changes in
        BitmapImage and ImageBuffer integrating canvas with CSS. Some
        drawing regressions remain unfixed.

        * platform/graphics/BitmapImage.h:
        * platform/graphics/ImageBuffer.h:
        * platform/graphics/cairo/ImageBufferCairo.cpp:
        * platform/graphics/cairo/ImageCairo.cpp:
        * platform/graphics/cairo/ImageSourceCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Sun, 20 Apr 2008 04:26:28 +0000 (04:26 +0000)]

        Reviewed by Dave Hyatt.

        - fix additional cases of https://bugs.webkit.org/show_bug.cgi?id=17921
          namely cases where the trailing white space is already in a separate
          run but still needs to be re-ordered.

        Test: fast/text/trailing-white-space-2.html

        * platform/text/BidiResolver.h:
        * rendering/bidi.cpp:


        Reviewed by Dave Hyatt.

        - more test cases for https://bugs.webkit.org/show_bug.cgi?id=17921
          in which the trailing white space is already in a separate
          run but still needs to be re-ordered.

        * fast/text/trailing-white-space-2.html: Copied from LayoutTests/fast/text/trailing-white-space.html.
        * platform/mac/fast/text/trailing-white-space-2-expected.checksum: Added.
        * platform/mac/fast/text/trailing-white-space-2-expected.png: Added.
        * platform/mac/fast/text/trailing-white-space-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-19 Matt Lilek <webkit@mattlilek.com>
pewtermoose@webkit.org [Sun, 20 Apr 2008 02:27:42 +0000 (02:27 +0000)]
2008-04-19  Matt Lilek  <webkit@mattlilek.com>

        Not reviewed, Windows build fix - copy the profiler headers in all
        configurations, not just Debug_Internal.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoVersioning.
mrowe@apple.com [Sun, 20 Apr 2008 02:06:57 +0000 (02:06 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-19 Alp Toker <alp@nuanti.com>
alp@webkit.org [Sat, 19 Apr 2008 21:11:04 +0000 (21:11 +0000)]
2008-04-19  Alp Toker  <alp@nuanti.com>

        Reviewed by Maciej.

        Enable visited link tracking by default at startup.

        With this patch, the GTK+ port rendering of Acid3 now matches the
        reference page.

        * webkit/webkitprivate.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-19 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Sat, 19 Apr 2008 20:34:32 +0000 (20:34 +0000)]
2008-04-19  Julien Chaffraix  <jchaffraix@webkit.org>

        Qt build fix (renderer() -> contentRenderer()).

        * Api/qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-19 Brady Eidson <beidson@apple.com>
beidson@apple.com [Sat, 19 Apr 2008 16:00:55 +0000 (16:00 +0000)]
2008-04-19  Brady Eidson  <beidson@apple.com>

        Update window-properties to add the profiler and fix a layout test

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix. renderer() -> contentRenderer()
kevino@webkit.org [Sat, 19 Apr 2008 16:00:37 +0000 (16:00 +0000)]
wx build fix. renderer() -> contentRenderer()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-19 Alp Toker <alp@nuanti.com>
alp@webkit.org [Sat, 19 Apr 2008 09:39:32 +0000 (09:39 +0000)]
2008-04-19  Alp Toker  <alp@nuanti.com>

        Reviewed by Nikolas.

        Add text shadow support for simple text in FontCairo.

        * platform/graphics/cairo/FontCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-19 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 19 Apr 2008 09:21:46 +0000 (09:21 +0000)]
2008-04-19  David Hyatt  <hyatt@apple.com>

        Fix a minor typo in CSSGradientValue's cssText() method.

        Reviewed by olliej

        * css/CSSGradientValue.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-19 Mike Hommey <glandium@debian.org>
alp@webkit.org [Sat, 19 Apr 2008 07:56:28 +0000 (07:56 +0000)]
2008-04-19  Mike Hommey  <glandium@debian.org>

        Reviewed by Alp Toker.

        Don't build GtkLauncher and DumpRenderTree with rpath.

        Don't build testkjs with rpath.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Sat, 19 Apr 2008 07:26:21 +0000 (07:26 +0000)]

2008-04-19  Brady Eidson  <beidson@apple.com>

        Reviewed by Tim Hatcher

        Add LocalStorageDatabasePath to the settings for the location of persistent local storage.

        * WebCore.base.exp:

        * page/Settings.cpp:
        * page/Settings.h:


2008-04-19  Brady Eidson  <beidson@apple.com>

        Reviewed by Tim Hatcher

        Add a WebPreference for the path of the local storage persistent store.

        * WebView/WebPreferenceKeysPrivate.h:

        * WebView/WebPreferences.m:
        (-[WebPreferences _localStorageDatabasePath]):
        (-[WebPreferences _setLocalStorageDatabasePath:]):
        * WebView/WebPreferencesPrivate.h:

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Sat, 19 Apr 2008 05:46:55 +0000 (05:46 +0000)]
2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>

        Fix build after r32231.

        * WebFrame.cpp:
        (WebFrame::renderTreeAsExternalRepresentation): renderer() ->

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fixes. Rename LocalStorage.h to LocalStorageEntry.h to avoid header detectio...
kevino@webkit.org [Sat, 19 Apr 2008 05:39:32 +0000 (05:39 +0000)]
wx build fixes. Rename LocalStorage.h to LocalStorageEntry.h to avoid header detection issues between WebCore/storage/LocalStorage.h and it, and add $(PROFILER_SOURCES) to the wx JSCore build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix changelog entries for r32257 (reference to wrong bug).
alp@webkit.org [Sat, 19 Apr 2008 05:19:57 +0000 (05:19 +0000)]
Fix changelog entries for r32257 (reference to wrong bug).
This commit was unrelated to plugin support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Jan Michael Alonzo <jmalonzo@unpluggable.com>
alp@webkit.org [Sat, 19 Apr 2008 05:16:00 +0000 (05:16 +0000)]
2008-04-18  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Reviewed by Alp Toker.

        [gtk] Implement plugin support in GTK backend


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Sat, 19 Apr 2008 05:08:21 +0000 (05:08 +0000)]
2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>

        Fix build after r32231.

        * WebView.cpp:
        (WebView::paintIntoBackingStore): renderer() -> contentRenderer()
        (WebView::elementAtPoint): Same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Sat, 19 Apr 2008 05:02:25 +0000 (05:02 +0000)]
2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Windows
        build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Sat, 19 Apr 2008 04:01:15 +0000 (04:01 +0000)]
2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>

        * AccessibleBase.cpp: Build fix for copy/paste error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Sat, 19 Apr 2008 03:54:26 +0000 (03:54 +0000)]
2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

        Implement IAccessible::get_accChild().

        * AccessibleBase.cpp:
        (AccessibleBase::get_accChild): Call getAccessibilityObjectForChild
        to find the AccessibilityObject for the VARIANT vChild. Get the
        AccessibilityObjectWrapper for the child, add a ref, and pass it back.
        (AccessibleBase::getAccessibilityObjectForChild): Added; finds the
        AccessibilityObject referred to by a VARIANT, or returns a COM error on
        (AccessibleBase::wrapper): Added; returns the wrapper for the
        AccessibilityObject. Creates one if necessary.
        * AccessibleBase.h: Added definitions for wrapper() and

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Sat, 19 Apr 2008 03:53:55 +0000 (03:53 +0000)]
2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin, Ollie.

        * AccessibleBase.cpp:
        (AccessibleBase::get_accChildCount): Implement get_accChildCount.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-17 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Sat, 19 Apr 2008 03:53:21 +0000 (03:53 +0000)]
2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

        Implement IAccessible::get_accParent().

        * AccessibleBase.cpp:
        (AccessibleBase::get_accParent): Call AccessibleObjectFromWindow with
        OBJID_WINDOW. This will be handled by Windows to return the default
        accessible object for the WebView, because we only handle OBJID_CLIENT.
        * WebView.cpp:
        (WebView::AccessibleObjectFromWindow): Added; calls through to the
        AccessibleObjectFromWindow in the MSAA DLL.
        * WebView.h: Added definition for AccessibleObjectFromWindow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-17 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Sat, 19 Apr 2008 03:52:44 +0000 (03:52 +0000)]
2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

        Return an AccessibleDocument when our root accessible object is queried

        * AccessibleDocument.cpp: Added; represents an AccessibilityObject that
        itself represents a Document.
        (AccessibleDocument::AccessibleDocument): Initialize AccessibleBase with
        the AccessibilityObject for this Document.
        * AccessibleDocument.h: Added.
        * WebFrame.cpp:
        (WebFrame::accessible): If m_accessible is 0, or if Document in this
        frame does not match the Document in the cached m_accessible object,
        create a new AccessibleDocument for this frame's Document.
        * WebFrame.h: Swap AccessibleBase.h for AccessibleDocument.h
        * WebKit.vcproj/WebKit.vcproj: Add AccessibleDocument.{h,cpp}

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-17 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Sat, 19 Apr 2008 03:52:04 +0000 (03:52 +0000)]
2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin, Alice.

        Implement AXObjectCache::detachWrapper() on Windows.

        * page/win/AXObjectCacheWin.cpp:
        (WebCore::AXObjectCache::detachWrapper): If this object has a wrapper,
        call its detach() method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-17 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Sat, 19 Apr 2008 03:51:20 +0000 (03:51 +0000)]
2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

        Respond to WM_GETOBJECT messages. Currently returns NULL.

        * WebFrame.cpp:
        (WebFrame::accessible): Added; will return the root accessible object
        for this frame.
        * WebFrame.h: Added definition for accessible().
        * WebView.cpp:
        (WebViewWndProc): Handle WM_GETOBJECT messages by calling onGetObject().
        (WebView::onGetObject): Added; enables the AXObjectCache in WebCore,
        queries the top-level frame for its root accessible object, and loads
        the MSAA DLL and locates its LresultFromObject function. If calling
        LresultFromObject succeeds, it returns a reference to the accessible
        object to pass back to Windows. If not, we return false and let Windows
        handle the request through DefWindowProc.
        * WebView.h: Added definition for onGetObject().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Antti Koivisto <antti@apple.com>
antti@apple.com [Sat, 19 Apr 2008 03:37:51 +0000 (03:37 +0000)]
2008-04-18  Antti Koivisto  <antti@apple.com>

        Update test results.

        * platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
        * platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Marco Barisione <marco.barisione@collabora.co.uk>
alp@webkit.org [Sat, 19 Apr 2008 03:32:34 +0000 (03:32 +0000)]
2008-04-18  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Alexey.

        [GTK] Enter on buttons doesn't work

        * platform/gtk/KeyEventGtk.cpp:
        (WebCore::singleCharacterString): Set the text of a keyboard event for
        GDK_ISO_Enter, GDK_KP_Enter, GDK_Return to "\r" instead of an empty

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Marco Barisione <marco@barisione.org>
alp@webkit.org [Sat, 19 Apr 2008 03:29:17 +0000 (03:29 +0000)]
2008-04-18  Marco Barisione  <marco@barisione.org>

        Reviewed by Alp Toker.

        [GTK] windowsKeyCodeForKeyEvent doesn't handle GDK_ISO_Enter and

        * platform/gtk/KeyEventGtk.cpp:
        (WebCore::windowsKeyCodeForKeyEvent): handle GDK_ISO_Enter and
        GDK_KP_Enter in windowsKeyCodeForKeyEvent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoGtk build fix.
mrowe@apple.com [Sat, 19 Apr 2008 02:50:57 +0000 (02:50 +0000)]
Gtk build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Antti Koivisto <antti@apple.com>
antti@apple.com [Sat, 19 Apr 2008 01:34:03 +0000 (01:34 +0000)]
2008-04-18  Antti Koivisto  <antti@apple.com>

        Reviewed by Oliver.

        Implement path animation for <animateMotion>.

        SVG test suite tests

        * svg/SVGAnimateMotionElement.cpp:
        * svg/SVGAnimateMotionElement.h:
        * svg/SVGAnimationElement.cpp:
        * svg/SVGAnimationElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSilence some warnings that GCC 4.3 triggers.
mrowe@apple.com [Sat, 19 Apr 2008 01:31:29 +0000 (01:31 +0000)]
Silence some warnings that GCC 4.3 triggers.

Rubber-stamped by Antti Koivisto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit/mac:
beidson@apple.com [Sat, 19 Apr 2008 01:12:30 +0000 (01:12 +0000)]

2008-04-18  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
        No reason to do the work twice...

        * WebView/WebView.mm:
        (-[WebView _close]):


2008-04-18  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
        No reason to do the work twice...

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoGtk build fix after r32231.
mrowe@apple.com [Sat, 19 Apr 2008 01:01:13 +0000 (01:01 +0000)]
Gtk build fix after r32231.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Brady Eidson <beidson@apple.com>
beidson@apple.com [Sat, 19 Apr 2008 00:15:26 +0000 (00:15 +0000)]
2008-04-18  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Mark Rowe

        Roll out http://trac.webkit.org/projects/webkit/changeset/32204 as it was an incorrect build fix.
        The feature in question was NOT database support.

        The proper build fix was later applied by Mark in http://trac.webkit.org/projects/webkit/changeset/32225

        * page/PageGroup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 18 Apr 2008 23:58:20 +0000 (23:58 +0000)]
2008-04-18  Sam Weinig  <sam@webkit.org>

        Disable this test until we can figure out why it is failing on some systems.

        * fast/canvas/toDataURL-supportedTypes.html: Removed.
        * fast/canvas/toDataURL-supportedTypes.html-disabled: Copied from fast/canvas/toDataURL-supportedTypes.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Brady Eidson <beidson@apple.com>
beidson@apple.com [Fri, 18 Apr 2008 23:56:26 +0000 (23:56 +0000)]
2008-04-18  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin and Sam

        Don't forget PageGroups when their last Page goes away, as this hurts visited links and anything
        else that will be per-PageGroup in the future (such as LocalStorage).

        This also fixes a leak, since PageGroups are ref-counted and therefore clearing the raw pointer out
        of the PageGroups map without manual deletion leaked it!

        * page/Page.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Fri, 18 Apr 2008 23:19:19 +0000 (23:19 +0000)]

        Reviewed by Brady Eidson.

        - fix <rdar://problem/5872671> REGRESSION (3.1.1-TOT): Repro crash going to Ortega Park home page

        Test: fast/dynamic/5872671.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren): Added a missing null


        Reviewed by Brady Eidson.

        - test for <rdar://problem/5872671> REGRESSION (3.1.1-TOT): Repro crash going to Ortega Park home page

        * fast/dynamic/5872671-expected.txt: Added.
        * fast/dynamic/5872671.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 18 Apr 2008 22:58:58 +0000 (22:58 +0000)]
2008-04-18  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Mark Rowe.

        responseText and responseXML don't throw exceptions so they don't need an ExceptionCode parameter.

        * bindings/js/JSXMLHttpRequestCustom.cpp:
        * xml/XMLHttpRequest.cpp:
        * xml/XMLHttpRequest.h:
        * xml/XMLHttpRequest.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 18 Apr 2008 22:41:49 +0000 (22:41 +0000)]
2008-04-18  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Sam.

        -<rdar://problem/5770054> JavaScript profiler (10928)
        - Use Deque instead of Vector since the profiler uses prepend a lot
        and deque is faster at that.

        * profiler/FunctionCallProfile.h:
        (KJS::FunctionCallProfile::milliSecs): Corrected the name to match
        its output.
        * wtf/Deque.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 18 Apr 2008 22:17:13 +0000 (22:17 +0000)]
2008-04-18  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Sam.

        - Build fix.

        * page/Console.cpp:
        * page/Console.h:
        * page/Console.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by darin.
eric@webkit.org [Fri, 18 Apr 2008 21:59:32 +0000 (21:59 +0000)]
    Reviewed by darin.

        Fix probable crasher caused by invalid static_cast

        * page/Frame.cpp:
        * rendering/RenderObject.h: sort the "is*" functions
        * rendering/RenderPart.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by beth.
eric@webkit.org [Fri, 18 Apr 2008 21:59:21 +0000 (21:59 +0000)]
    Reviewed by beth.

        Rename Frame::renderer() to contentRenderer() and fix uses.

        * WebCore.base.exp:
        * editing/Editor.cpp:
        * loader/FrameLoader.cpp:
        * page/DragController.cpp:
        * page/EventHandler.cpp:
        * page/Frame.cpp:
        * page/Frame.h:
        * page/FrameView.cpp:
        * rendering/RenderTreeAsText.cpp:
        * svg/graphics/SVGImage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 18 Apr 2008 21:56:49 +0000 (21:56 +0000)]
2008-04-18  Antti Koivisto  <antti@apple.com>

        Reviewed by Oliver.

        REGRESSION (r31801?): Crash in ContainerNode::removedFromDocument on many SVG tests

        Fix for test svg/W3C-SVG-1.1/animate-elem-62-t.svg which was still
        crashing under guard malloc after the previous fix.

        If the event base element was a parent of the current element, dereffing it during
        removedFromDocument() would cause problems. Avoid this by not holding ref pointer
        to the event base but instead checking from the ref count of the event listener whether
        it is still alive and in need for unregistering.

        This shold not be a problem for syncbase pointers since those are always animation elements
        and leaf nodes.

        * svg/animation/SVGSMILElement.cpp:
        * svg/animation/SVGSMILElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 18 Apr 2008 21:50:35 +0000 (21:50 +0000)]
2008-04-18  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Sam and Adam.

        -<rdar://problem/5770054> JavaScript profiler (10928)
        - Added support for console.profile() and console.profileEnd().

        * ForwardingHeaders/kjs/FunctionCallProfile.h: Added.
        * ForwardingHeaders/kjs/Profiler.h: Added.
        * page/Console.cpp:
        * page/Console.h:
        * page/Console.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 18 Apr 2008 21:49:56 +0000 (21:49 +0000)]
2008-04-18  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Sam and Adam.

        -<rdar://problem/5770054> JavaScript profiler (10928)
        - Cleaned up the header file and made some functions static, added
        a new, sane, printing function, and fixed a few minor bugs.

        * JavaScriptCore.exp:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * profiler/FunctionCallProfile.cpp:
        (KJS::FunctionCallProfile::didExecute): Removed assertion that time is
        > 0 because at ms resolution that may not be true and only cross-
        platform way to get time differences is in ms.
        (KJS::FunctionCallProfile::printDataInspectorStyle): Added a new
        printing function for dumping data in a sane style.
        (KJS::FunctionCallProfile::printDataSampleStyle): Fixed a bug where we
        displayed too much precision when printing our floats. Also added logic
        to make sure we don't display 0 because that doesn't make sense for a
        sampling profile.
        * profiler/FunctionCallProfile.h:
        * profiler/Profiler.cpp: Moved functions that could be static into the
        implementation, and chaned the ASSERTs to early returns.  I did this
        because console.profile() is a JS function and so was being profiled
        but asserting because the profiler had not been started! In the future
        I would like to put the ASSERTs back and not profile the calls to
        console.profile() and console.profileEnd().
        (KJS::getStackNames): Fixed a bug where the wrong ExecState was being
        * profiler/Profiler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build 'fix'. Add loader/appcache sources to the build, and define ENABLE_DOM_STORAGE.
kevino@webkit.org [Fri, 18 Apr 2008 21:25:28 +0000 (21:25 +0000)]
wx build 'fix'. Add loader/appcache sources to the build, and define ENABLE_DOM_STORAGE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Fri, 18 Apr 2008 21:18:26 +0000 (21:18 +0000)]

        Reviewed by Darin Adler.

        - fix https://bugs.webkit.org/show_bug.cgi?id=17921
          Extra white space at the end of right-aligned or justified text with -webkit-line-break: after-white-space

        Test: fast/text/trailing-white-space.html

        Made trailing white space on the line always behave like it has the base
        bidi level of the block, meaning it will always go on the right (left)
        of the line in a left-to-right (right-to-left) block. Made the trailing
        white space vanish when it is next to a margin that the text should
        be touching, and made its width not count when computing the center
        point for center alignment.

        * platform/text/BidiResolver.h:
        (WebCore::::prependRun): Added.
        * rendering/RenderBlock.h:
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::computeHorizontalPositionsForLine): Changed the
        logicallyLastRun parameter to an optional trailingSpaceRun and changed
        the alignment logic to implement the above rules.
        (WebCore::RenderBlock::layoutInlineChildren): Added code to identify
        when there is trailing white space that needs to be split into its own
        run and optionally re-ordered.
        (WebCore::RenderBlock::findNextLineBreak): Removed code that split some
        trailing space into a separate run in one special case.


        Reviewed by Darin Adler.

        - test and updated results for https://bugs.webkit.org/show_bug.cgi?id=17921
          Extra white space at the end of right-aligned or justified text with -webkit-line-break: after-white-space

        * fast/text/trailing-white-space.html: Added.
        * http/tests/misc/acid3-expected.txt:
        * platform/mac/editing/deleting/delete-block-table-expected.txt:
        * platform/mac/editing/deleting/delete-to-select-table-expected.txt:
        * platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
        * platform/mac/editing/execCommand/5482023-expected.txt:
        * platform/mac/editing/execCommand/boldSelection-expected.txt:
        * platform/mac/editing/execCommand/italicizeByCharacter-expected.txt:
        * platform/mac/editing/execCommand/modifyForeColorByCharacter-expected.txt:
        * platform/mac/editing/execCommand/print-expected.txt:
        * platform/mac/editing/execCommand/selectAll-expected.txt:
        * platform/mac/editing/execCommand/strikethroughSelection-expected.txt:
        * platform/mac/editing/inserting/editable-html-element-expected.txt:
        * platform/mac/editing/inserting/insert-div-027-expected.txt:
        * platform/mac/editing/pasteboard/5028447-expected.txt:
        * platform/mac/editing/pasteboard/block-wrappers-necessary-expected.checksum:
        * platform/mac/editing/pasteboard/block-wrappers-necessary-expected.png:
        * platform/mac/editing/pasteboard/block-wrappers-necessary-expected.txt:
        * platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
        * platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.png:
        * platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt:
        * platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
        * platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.png:
        * platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.txt:
        * platform/mac/editing/selection/5081257-1-expected.txt:
        * platform/mac/editing/selection/after-line-wrap-expected.txt:
        * platform/mac/editing/selection/mixed-editability-1-expected.txt:
        * platform/mac/editing/selection/select-all-001-expected.txt:
        * platform/mac/editing/selection/select-all-002-expected.txt:
        * platform/mac/editing/selection/select-all-003-expected.txt:
        * platform/mac/editing/style/apple-style-editable-mix-expected.txt:
        * platform/mac/editing/style/create-block-for-style-012-expected.checksum:
        * platform/mac/editing/style/create-block-for-style-012-expected.png:
        * platform/mac/editing/style/create-block-for-style-012-expected.txt:
        * platform/mac/fast/clip/outline-overflowClip-expected.txt:
        * platform/mac/fast/forms/textarea-rows-cols-expected.txt:
        * platform/mac/fast/replaced/width100percent-textarea-expected.txt:
        * platform/mac/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
        * platform/mac/fast/text/justified-text-rect-expected.txt:
        * platform/mac/fast/text/trailing-white-space-expected.checksum: Added.
        * platform/mac/fast/text/trailing-white-space-expected.png: Added.
        * platform/mac/fast/text/trailing-white-space-expected.txt: Added.
        * platform/mac/fast/text/whitespace/pre-wrap-last-char-expected.txt:
        * platform/mac/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
        * platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix builds that do not have DOM storage enabled.
mrowe@apple.com [Fri, 18 Apr 2008 20:54:04 +0000 (20:54 +0000)]
Fix builds that do not have DOM storage enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes the regression where style rules in the Inspector always show "inline stylesheet"
timothy@apple.com [Fri, 18 Apr 2008 20:33:25 +0000 (20:33 +0000)]
Fixes the regression where style rules in the Inspector always show "inline stylesheet"
for the source of the rule and not the URL or other sources.


Reviewed by Dan Bernstein.

* page/inspector/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.update): Add parentStyleSheet to the anonymous obejct
that we make for each matched rule. The parentStyleSheet property is used later to make the subtitle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed marquee suspension on wrong document. Passes current
dino@apple.com [Fri, 18 Apr 2008 20:14:58 +0000 (20:14 +0000)]
Fixed marquee suspension on wrong document. Passes current
document into Frame::clearTimers.

Reviewed by hyatt.

* history/CachedPage.cpp:
* page/Frame.cpp:
* page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Fri, 18 Apr 2008 19:46:13 +0000 (19:46 +0000)]
    Reviewed by Darin.

        Fix leaks during plugin tests (which actually excercise background JS), and potential
        PAC brokenness that was not reported, but very likely.

        The leaks shadowed a bigger problem with Identifier destruction. Identifier::remove involves
        an IdentifierTable lookup, which is now a per-thread instance. Since garbage collection can
        currently happen on a different thread than allocation, a wrong table was used.

        No measurable change on SunSpider total, ~1% variation on individual tests.

        * kjs/ustring.cpp:
        * kjs/ustring.h:
        Replaced isIdentifier with a pointer to IdentifierTable, so that destruction can be done
        correctly. Took one bit from reportedCost, to avoid making UString::Rep larger (performance
        effect was measurable on SunSpider).

        * kjs/identifier.cpp:
        Make IdentifierTable a real class. Its destructor needs to zero out outstanding references,
        because some identifiers may briefly outlive it during thread destruction, and we don't want
        them to use their stale pointers.

        Now that LiteralIdentifierTable is per-thread and can be destroyed not just during application
        shutdown, it is not appropriate to simply bump refcount for strings that get there; changed
        the table to hold RefPtrs.

        * kjs/identifier.h:
        Use and update UString::Rep::identifierTable as appropriate. Updating it is now done in
        IdentifierTable::add, not in translators.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd 'ease' timing function to transitions and
dino@apple.com [Fri, 18 Apr 2008 19:45:50 +0000 (19:45 +0000)]
Add 'ease' timing function to transitions and
make it the default. See latest specification proposal at:

Reviewed by hyatt.

NOTE: still working on a way to test animating/transitioning content

* css/CSSParser.cpp:
* css/CSSStyleSelector.cpp:
* css/CSSValueKeywords.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Fri, 18 Apr 2008 19:02:50 +0000 (19:02 +0000)]
    Reviewed by Darin.

        Get rid of static compareWithCompareFunctionArguments in array_instance.cpp.

        No change on SunSpider, CelticKane or iBench JavaScript. It is probable that in some cases,
        merge sort is still faster, but more investigation is needed to determine a new cutoff.
        Or possibly, it would be better to do what FIXME says (change to tree sort).

        Also, made arguments a local variable - not sure why it was a member of

        * kjs/array_instance.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoChange JavaScriptDebugListener to use KJS::UString instead of WebCore::String
aroben@apple.com [Fri, 18 Apr 2008 18:03:00 +0000 (18:03 +0000)]
Change JavaScriptDebugListener to use KJS::UString instead of WebCore::String


        Change JavaScriptDebugListener to use KJS::UString instead of

        This should reduce the number of string allocations performed while

        Reviewed by Tim Hatcher.

        * page/InspectorController.cpp: Updated JavaScriptDebugListener
        * page/InspectorController.h: Ditto.
        * page/JavaScriptDebugListener.h: Changed to use KJS::UString instead
        of WebCore::String.
        * page/JavaScriptDebugServer.cpp: Ditto.
        * platform/win/BString.cpp:
        (WebCore::BString::BString): Added a constructor that takes a
        * platform/win/BString.h:


        Update WebScriptDebugServer for JavaScriptDebugListener changes

        Reviewed by Tim Hatcher.

        * WebScriptDebugServer.cpp: Changed to use KJS::UString instead of
        * WebScriptDebugServer.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Mac build fix
aroben@apple.com [Fri, 18 Apr 2008 17:27:49 +0000 (17:27 +0000)]
    Mac build fix

        * WebCore.xcodeproj/project.pbxproj: Mark JavaScriptDebugListener.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make InspectorController a JavaScriptDebugListener
aroben@apple.com [Fri, 18 Apr 2008 16:32:18 +0000 (16:32 +0000)]
    Make InspectorController a JavaScriptDebugListener

        I added two new functions to the InspectorController JS object:
        reloadInspectedPageAndStartDebugging and stopDebugging. These control
        when the InspectorController adds/removes itself to/from the

        Reviewed by Tim Hatcher.

        * page/InspectorController.cpp:
        (WebCore::reloadInspectedPageAndStartDebugging): Added. Just calls
        through to InspectorController.
        (WebCore::stopDebugging): Ditto.
        (WebCore::InspectorController::~InspectorController): Make sure we
        stop debugging before we are destroyed so the JavaScriptDebugServer
        won't be left with a stale pointer.
        (WebCore::InspectorController::windowScriptObjectAvailable): Added two
        new functions to our JS object.
        (WebCore::InspectorController::closeWindow): Stop debugging when the
        window closes.
        (WebCore::InspectorController::stopDebugging): Added.

        Added empty implementations of the JavaScriptDebugListener functions.

        * page/InspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - add css2.1/t1506-c525-font-wt-00-b.html to the Windows skipped list
mitz@apple.com [Fri, 18 Apr 2008 16:01:53 +0000 (16:01 +0000)]
    - add css2.1/t1506-c525-font-wt-00-b.html to the Windows skipped list

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rename ExecState* instances from state to exec
aroben@apple.com [Fri, 18 Apr 2008 15:43:48 +0000 (15:43 +0000)]
    Rename ExecState* instances from state to exec

        Requested by Darin Adler and Sam Weinig.

        * bindings/js/JSConsoleCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago * platform/win/Skipped: Added another failing test.
aroben@apple.com [Fri, 18 Apr 2008 15:41:40 +0000 (15:41 +0000)]
    * platform/win/Skipped: Added another failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Clean up InspectorController's use of JSStringRef
aroben@apple.com [Fri, 18 Apr 2008 15:38:01 +0000 (15:38 +0000)]
    Clean up InspectorController's use of JSStringRef

        All JSStringRef creation now happens through a helper function,
        jsStringRef, which takes either a const char* or a const String& and
        returns a JSRetainPtr<JSStringRef>.

        Reviewed by Mitz Pettel.

        * page/InspectorController.cpp:
        Added jsStringRef and converted all callers to
        JSStringCreateWithUTF8CString or JSStringCreateWithCharacters to use

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Drop the hang timer to 30 seconds
aroben@apple.com [Fri, 18 Apr 2008 15:34:01 +0000 (15:34 +0000)]
    Drop the hang timer to 30 seconds

        This matches what DRT/mac was using.

        Reviewed by Mitz Pettel.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Get rid of DRT's Watchdog
aroben@apple.com [Fri, 18 Apr 2008 15:33:36 +0000 (15:33 +0000)]
    Get rid of DRT's Watchdog

        run-webkit-tests now detects hangs and samples DRT as needed.

        Reviewed by Mitz Pettel.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Removed
        Watchdog* files from the project.
        * DumpRenderTree/Watchdog.cpp: Removed.
        * DumpRenderTree/Watchdog.h: Removed.
        * DumpRenderTree/mac/DumpRenderTree.mm: Removed uses of Watchdog
        * DumpRenderTree/mac/WatchdogMac.h: Removed.
        * DumpRenderTree/mac/WatchdogMac.mm: Removed.
        * Scripts/run-webkit-tests:
        (sub testCrashedOrTimedOut): Call sampleDumpTool() if we timed out.
        (sub sampleDumpTool): Added. Writes a sample report to

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Add wrappers around InspectorClient::{show,close}Window
aroben@apple.com [Fri, 18 Apr 2008 15:19:38 +0000 (15:19 +0000)]
    Add wrappers around InspectorClient::{show,close}Window

        This will let us perform actions when the window is actually
        showing/closing (InspectorController::show doesn't always directly
        show the window).

        Reviewed by Tim Hatcher.

        * page/InspectorController.cpp:
        (WebCore::InspectorController::scriptObjectReady): Call showWindow()
        instead of m_client->showWindow().
        (WebCore::InspectorController::show): Ditto.
        (WebCore::InspectorController::close): Ditto for closeWindow().
        * page/InspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMany API changes and additions after a full review with Jasmin Blanchette <jasmin...
hausmann@webkit.org [Fri, 18 Apr 2008 14:53:06 +0000 (14:53 +0000)]
Many API changes and additions after a full review with Jasmin Blanchette <jasmin@trolltech.com>

The diff is too big to mention the changes individually, but most of the changes were of cosmetic
nature where methods or enums have been renamed or prefixed/suffixed according to the consistency
rules of the Qt API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Fri, 18 Apr 2008 14:37:00 +0000 (14:37 +0000)]
2008-04-18  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Adam Roben.


        No resize indication is shown when moving/hovering over the frame

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdded QWebView::find/QWebFrame::find.
hausmann@webkit.org [Fri, 18 Apr 2008 14:32:06 +0000 (14:32 +0000)]
Added QWebView::find/QWebFrame::find.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix
aroben@apple.com [Fri, 18 Apr 2008 14:07:51 +0000 (14:07 +0000)]
    Windows build fix

        Same as before, but for fabs/fabsf.

        * svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::calculateDistance): Changed to
        use fabsf and removed narrowPrecisionToFloat.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix
aroben@apple.com [Fri, 18 Apr 2008 13:57:38 +0000 (13:57 +0000)]
    Windows build fix

        In MSVC, sqrt() has three overloads: float, double, and long
        double. In GCC, sqrt() is only for doubles. Both MSVC and GCC have
        sqrtf() to operate explicitly on floats.

        * svg/SVGAnimateMotionElement.cpp:
        (WebCore::SVGAnimateMotionElement::calculateDistance): Changed to use
        sqrtf and removed narrowPrecisionToFloat.
        * svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::calculateDistance): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the build without Database support (fixes the Qt/win build).
hausmann@webkit.org [Fri, 18 Apr 2008 12:47:27 +0000 (12:47 +0000)]
Fix the build without Database support (fixes the Qt/win build).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-18 Alp Toker <alp@atoker.com>
alp@webkit.org [Fri, 18 Apr 2008 11:13:26 +0000 (11:13 +0000)]
2008-04-18  Alp Toker  <alp@atoker.com>

        Rubber-stamped by Holger Freyther.

        [Gtk] segfault when clicking on a disabled button

        Always use the main frame for mouse events (not the focused frame)
        since it knows best how to get the event through to the right target.

        This also fixes a null crasher.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Gtk build on the build bot.
hausmann@webkit.org [Fri, 18 Apr 2008 11:03:57 +0000 (11:03 +0000)]
Fix the Gtk build on the build bot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoProspective wx build fix.
hausmann@webkit.org [Fri, 18 Apr 2008 10:44:02 +0000 (10:44 +0000)]
Prospective wx build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32201 268f45cc-cd09-0410-ab3c-d52691b4dbfc