WebKit-https.git
7 years agoSunSpider 1.0: 3d-morph: use epsilon to check result
commit-queue@webkit.org [Sat, 4 May 2013 02:11:49 +0000 (02:11 +0000)]
SunSpider 1.0: 3d-morph: use epsilon to check result
https://bugs.webkit.org/show_bug.cgi?id=115553

Patch by Cosmin Truta <ctruta@blackberry.com> on 2013-05-03
Reviewed by George Staikos.

SunSpider/3d-morph should be more lenient in validating its results, since they depend on Math.sin, which isn't formally specified.

* tests/sunspider-1.0/3d-morph.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCreate a script to import W3C tests
commit-queue@webkit.org [Sat, 4 May 2013 02:07:30 +0000 (02:07 +0000)]
Create a script to import W3C tests
https://bugs.webkit.org/show_bug.cgi?id=111513

Patch by Rebecca Hauck <rhauck@adobe.com> on 2013-05-03
Reviewed by Dirk Pranke.

Script to automate the import of W3C tests into WebKit.
For the full description of how it works, see the comments
at the top of test_importer.py.

* Scripts/import-w3c-tests: Added.
* Scripts/webkitpy/w3c/__init__.py: Added.
* Scripts/webkitpy/w3c/test_converter.py: Added.
(TestConverter):
(TestConverter.__init__):
(TestConverter.load_prefixed_prop_list):
(TestConverter.load_file):
(TestConverter.convert_for_webkit):
(TestConverter.convert_testharness_paths):
(TestConverter.convert_prefixed_properties):
(TestConverter.scrub_unprefixed_props):
(TestConverter.replace_tag):
* Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
(TestConverterTest):
(TestConverterTest.testLoadPrefixedPropList):
(TestConverterTest.test_convertForWebkitNothingToConvert):
(test_convertForWebkitHarnessOnly):
(test_convertForWebkitPropsOnly):
(test_convertForWebkitHarnessAndProps):
(test_convertTestHarnessPaths):
(test_convertPrefixedProperties):
(verifyTestHarnessPaths):
(verifyPrefixedProperties):
(generateTestContent):
* Scripts/webkitpy/w3c/test_importer.py: Added.
(main):
(parse_args):
(validate_import_directory):
(TestImporter):
(TestImporter.__init__):
(TestImporter.do_import):
(TestImporter.get_changeset):
(TestImporter.scan_source_directory):
(TestImporter.import_tests):
(TestImporter.setup_destination_directory):
(TestImporter.get_test_status):
(TestImporter.remove_deleted_files):
(TestImporter.write_import_log):
* Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
(TestImporterTest):
(TestImporterTest.test_ImportDirWithNoTests):
* Scripts/webkitpy/w3c/test_parser.py: Added.
(TestParser):
(TestParser.__init__):
(TestParser.load_file):
(TestParser.analyze_test):
(TestParser.get_reftests):
(TestParser.is_jstest):
(TestParser.get_support_files):
* Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
(TestParserTest):
(TestParserTest.test_analyzeTestReftestOneMatch):
(test_analyzeTestReftestMultipleMatches):
(test_analyzeTestReftestMatchAndMismatch):
(test_analyzeTestReftestWithRefSupportFiles):
(test_analyzeJSTest):
(test_analyzePixelTestAllTrue):
(test_analyzePixelTestAllFalse):
(test_analyzeNonHTMLFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSimplify the #ifdefs in GraphicsContext3D.h
mrobinson@webkit.org [Sat, 4 May 2013 00:03:05 +0000 (00:03 +0000)]
Simplify the #ifdefs in GraphicsContext3D.h
https://bugs.webkit.org/show_bug.cgi?id=115568

Reviewed by Daniel Bates.

* platform/graphics/GraphicsContext3D.h:
(GraphicsContext3D): Combine #ifdefs paths that have a common
implementation. This reduces the #ifdef paths from many to just three.
* platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::platformTexture): Move the implementation
here to simplify the header.
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::platformTexture): Ditto.
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
ch.dumez@sisa.samsung.com [Fri, 3 May 2013 23:50:02 +0000 (23:50 +0000)]
Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Build with --video-track fails because String(AtomicString) is ambiguous
commit-queue@webkit.org [Fri, 3 May 2013 23:44:41 +0000 (23:44 +0000)]
[Qt] Build with --video-track fails because String(AtomicString) is ambiguous
https://bugs.webkit.org/show_bug.cgi?id=115551

Patch by Brendan Long <b.long@cablelabs.com> on 2013-05-03
Reviewed by Benjamin Poulain.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::configureTextTrackGroup):
Change String(textTrack->kind()) to textTrack->kind().string(), and same thing with language.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer] GStreamer log crashes in MediaPlayerPrivateGStreamerBase because of unini...
commit-queue@webkit.org [Fri, 3 May 2013 23:12:05 +0000 (23:12 +0000)]
[GStreamer] GStreamer log crashes in MediaPlayerPrivateGStreamerBase because of uninitialized category
https://bugs.webkit.org/show_bug.cgi?id=115575

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-05-03
Reviewed by Philippe Normand.

No new tests needed.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
Using extern debug category.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
Declaring debug category as not static.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Page rendering scale is changed after go back and forward
zhajiang@rim.com [Fri, 3 May 2013 22:19:15 +0000 (22:19 +0000)]
[BlackBerry] Page rendering scale is changed after go back and forward
https://bugs.webkit.org/show_bug.cgi?id=115573

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-05-03.
Reviewed by Rob Buis.
Internally reviewed by Jeff Rogers.

PR: 326886
When navigating back from page A with viewport to page B without
viewport, we didn't call setViewMode(); therefore, we didn't change
the fixed layout size which was set by page A. In that case, WebCore
would just pick up page A's fixed layout size to layout page B which
caused this issue.
Expecting zoomToInitialScaleOnLoad() or other functions to setViewMode()
later is not a good way, because zoomToInitialScaleOnLoad() has never
been called in this case. So we should always call setViewMode() to set
fixed layout size when a new page is committed.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Unreviewed VS2010 Build Correction.
bfulgham@webkit.org [Fri, 3 May 2013 22:14:42 +0000 (22:14 +0000)]
[WinCairo] Unreviewed VS2010 Build Correction.

* WebCore.vcxproj/WebCore.vcxproj: Exclude CG-only
SubimageCacheWithTimer.cpp from WinCairo build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Cairo] Anti-aliasing should not be always disabled for lines
commit-queue@webkit.org [Fri, 3 May 2013 22:12:54 +0000 (22:12 +0000)]
[Cairo] Anti-aliasing should not be always disabled for lines
https://bugs.webkit.org/show_bug.cgi?id=109535

Patch by Viatcheslav Ostapenko <viatchslav.o@samsung.com> on 2013-05-03
Reviewed by Martin Robinson.

Source/WebCore:

Don't disable antialiasing for text lines because it produces ugly picture if
page is scaled.

Test: fast/css3-text/css3-text-decoration/text-decoration-line-scaled.html

* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::drawLineOnCairoContext):

LayoutTests:

Add pixel test with scaled text lines.

* fast/css3-text/css3-text-decoration/text-decoration-line-scaled.html: Added.
* platform/efl/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.png: Added.
* platform/efl/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unnecessary include HTMLNames.h from RenderThemeGtk.cpp
dbates@webkit.org [Fri, 3 May 2013 21:41:54 +0000 (21:41 +0000)]
Remove unnecessary include HTMLNames.h from RenderThemeGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=115571

Reviewed by Martin Robinson.

* platform/gtk/RenderThemeGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] setMetadataURL incorrectly treats path bytes as Latin-1
ap@apple.com [Fri, 3 May 2013 20:56:53 +0000 (20:56 +0000)]
[Mac] setMetadataURL incorrectly treats path bytes as Latin-1
https://bugs.webkit.org/show_bug.cgi?id=115557

Reviewed by Sam Weinig.

* platform/mac/FileSystemMac.mm: (WebCore::setMetaData): Use the correct constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPDFPlugin: Changes being made to active annotation aren't saved when the PDF is exported
timothy_horton@apple.com [Fri, 3 May 2013 20:56:44 +0000 (20:56 +0000)]
PDFPlugin: Changes being made to active annotation aren't saved when the PDF is exported
https://bugs.webkit.org/show_bug.cgi?id=115544
<rdar://problem/13801789>

Reviewed by Alexey Proskuryakov.

Commit changes to the active annotation (if there is one) before
returning the live PDF data, so that said changes are represented
in the exported or printed output.

* WebProcess/Plugins/PDF/PDFPlugin.h: Override liveData.
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::liveData): Commit the active annotation if there is one.
* WebProcess/Plugins/PDF/SimplePDFPlugin.h:
(SimplePDFPlugin): Make liveData virtual.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb process crashes at WebPage::determinePrimarySnapshottedPlugInTimerFired + 8
timothy_horton@apple.com [Fri, 3 May 2013 20:56:22 +0000 (20:56 +0000)]
Web process crashes at WebPage::determinePrimarySnapshottedPlugInTimerFired + 8
https://bugs.webkit.org/show_bug.cgi?id=115056
<rdar://problem/13719543>

Reviewed by Simon Fraser.

Null-check m_page. In theory, we shouldn't get here, because we stop
the timer at the only point where m_page is cleared, but crash logs say
we're still crashing here.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::determinePrimarySnapshottedPlugInTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove some "what" comments from FindController
timothy_horton@apple.com [Fri, 3 May 2013 20:55:53 +0000 (20:55 +0000)]
Remove some "what" comments from FindController
https://bugs.webkit.org/show_bug.cgi?id=115546

Reviewed by Andreas Kling.

* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::countStringMatches):
(WebKit::FindController::updateFindUIAfterPageScroll):
(WebKit::FindController::willMoveToWebPage):
(WebKit::FindController::mouseEvent):
Remove or reword some comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove pixelSnappedLayoutOverflowRect and maxLayoutOverflow from RenderBox
abucur@adobe.com [Fri, 3 May 2013 20:48:00 +0000 (20:48 +0000)]
Move pixelSnappedLayoutOverflowRect and maxLayoutOverflow from RenderBox
https://bugs.webkit.org/show_bug.cgi?id=115550

Reviewed by Simon Fraser.

The patch moves pixelSnappedLayoutOverflowRect and maxLayoutOverflow out
of RenderBox somewhere logically closer to their usage place.

pixelSnappedLayoutOverflowRect - moved to RenderView because it's called only
for RenderView at this moment.
There are other places when the overflow rect is pixel snapped but only after
the rect is adjusted for writing modes or inflated.

maxLayoutOverflow - moved to RenderTreeAsText.cpp as a static function because
it's used only there.

Tests: no new functional change.

* rendering/RenderBox.h: The functions declarations are removed.
* rendering/RenderTreeAsText.cpp:
(WebCore::maxLayoutOverflow):
* rendering/RenderView.h:
(WebCore::RenderView::pixelSnappedLayoutOverflowRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStyleResolver: Have "list of matched rules" API vend internal types instead of CSSOM...
akling@apple.com [Fri, 3 May 2013 20:43:27 +0000 (20:43 +0000)]
StyleResolver: Have "list of matched rules" API vend internal types instead of CSSOM wrappers.
<http://webkit.org/b/115563>

Reviewed by Antti Koivisto.

Source/WebCore:

Change styleRulesForElement() and pseudoStyleRulesForElement() to return Vectors of StyleRuleBase
instead of CSSRuleLists. This defers instantiating CSSOM wrappers until they're actually needed
for exposure to web API.

* page/DOMWindow.cpp:
(WebCore::DOMWindow::getMatchedCSSRules):

    Create a StaticCSSRuleList and populate it with CSSOM wrappers for the matched rules.
    This is the one place where we expose this functionality to the web.

* css/ElementRuleCollector.h:
* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::matchedRuleList):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):

    Collect internal StyleRuleBase pointers here instead of creating wrappers.

* css/StyleResolver.h:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::styleRulesForElement):
(WebCore::StyleResolver::pseudoStyleRulesForElement):

    Vend said pointers.

* editing/EditingStyle.cpp:
(WebCore::styleFromMatchedRulesForElement):

    Dodge CSSOM wrapper instantiation (Woop woop!)

* inspector/InspectorCSSAgent.h:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForRule):

    Split buildObjectForRule() into two versions, one for CSSStyleRule and one for StyleRule.
    The CSSStyleRule one doesn't need a special path for parent-less rules, since those always
    come in through the StyleRule interface instead. This factoring can be improved further
    after this change.

(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):

    Tweaked for changes in StyleResolver API.

Source/WebKit/qt:

* Api/qwebelement.cpp:
(QWebElement::styleProperty):

    Tweaked for changes in StyleResolver API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago REGRESSION (r145042): Downloading a file sometimes results in could not create
ap@apple.com [Fri, 3 May 2013 20:29:53 +0000 (20:29 +0000)]
    REGRESSION (r145042): Downloading a file sometimes results in could not create
        a sandbox extension Console message and file stays as a .download file
        https://bugs.webkit.org/show_bug.cgi?id=115559
        <rdar://problem/13785101>

        Reviewed by Sam Weinig.

        CString is evil, it has two lengths which can be different - specifically, fileSystemRepresentation()
        creates a string with maximum possible buffer size. This was confusing resolveSymlinksInPath().

        * platform/cf/FileSystemCF.cpp: (WebCore::fileSystemRepresentation):
        Change fileSystemRepresentation to be less surprising. Really, we should rip apart
        CString and update callers to use better defined semantics, but this is the one function
        that repeatedly causes problems in practice.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSSRule style declarations getters shouldn't be const.
akling@apple.com [Fri, 3 May 2013 20:27:39 +0000 (20:27 +0000)]
CSSRule style declarations getters shouldn't be const.
<http://webkit.org/b/115572>

Reviewed by Antti Koivisto.

Accessing the CSSStyleDeclaration for a CSSRule is a potentially mutating operation,
and should not be const.

* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::style):
* css/CSSFontFaceRule.h:
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::style):
* css/CSSPageRule.h:
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::style):
* css/CSSStyleRule.h:
(CSSStyleRule):
* css/WebKitCSSFilterRule.cpp:
(WebCore::WebKitCSSFilterRule::style):
* css/WebKitCSSFilterRule.h:
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::WebKitCSSKeyframeRule::style):
* css/WebKitCSSKeyframeRule.h:
(WebKitCSSKeyframeRule):
* css/WebKitCSSViewportRule.cpp:
(WebCore::WebKitCSSViewportRule::style):
* css/WebKitCSSViewportRule.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse NotNull tag for placement new in WebCore.
akling@apple.com [Fri, 3 May 2013 19:31:15 +0000 (19:31 +0000)]
Use NotNull tag for placement new in WebCore.
<http://webkit.org/b/115569>

Reviewed by Antti Koivisto.

Avoid emitting null checks where we use placement new to construct objects into safe locations.

* css/StylePropertySet.cpp:
(WebCore::ImmutableStylePropertySet::create):
* dom/Element.cpp:
(WebCore::ShareableElementData::createWithAttributes):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::UniqueElementData::makeShareableCopy):
* dom/QualifiedName.cpp:
(WebCore::QualifiedName::init):
(WebCore::createQualifiedName):
* dom/make_names.pl:
(printNamesCppFile):
* platform/ThreadGlobalData.h:
(WebCore::threadGlobalData):
* platform/graphics/GlyphPage.h:
(WebCore::GlyphPage::createForMixedFontData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSimplify CSSSelectorList creation/adoption.
akling@apple.com [Fri, 3 May 2013 19:11:28 +0000 (19:11 +0000)]
Simplify CSSSelectorList creation/adoption.
<http://webkit.org/b/106649>

Reviewed by Antti Koivisto.

Remove the optimization that special-cased construction of CSSSelectorLists with a single entry.
This is in preparation for changing the way we store the selector lists on style rules.

* css/CSSParser.h:
* css/CSSSelector.h:

    Remove move(PassOwnPtr<CSSSelector> from, CSSSelector* to), inlining it into
    CSSSelectorList::adoptSelectorVector instead.

* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::CSSSelectorList):
(WebCore::CSSSelectorList::deleteSelectors):

    Handle all selector list lengths the same way.

(WebCore::CSSSelectorList::adoptSelectorVector):

    Merge move() from CSSSelector.h into this code since it was the only call site.
    Also some minor readability cleanups.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRevert to old results on Lion.
slewis@apple.com [Fri, 3 May 2013 18:26:47 +0000 (18:26 +0000)]
Revert to old results on Lion.

Unreviewed.

Results were updated in (http://trac.webkit.org/changeset/149503) but that is compiled
out on Lion (http://trac.webkit.org/changeset/149510).

* platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove HTMLShadowElement
antti@apple.com [Fri, 3 May 2013 18:08:58 +0000 (18:08 +0000)]
Remove HTMLShadowElement
https://bugs.webkit.org/show_bug.cgi?id=115555

Reviewed by Andreas Kling.

This is not used internally.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* dom/ComposedShadowTreeWalker.cpp:
* dom/NodeRenderingContext.cpp:
* html/HTMLElementsAllInOne.cpp:
* html/HTMLTagNames.in:
* html/InputType.cpp:
(WebCore::InputType::destroyShadowSubtree):
* html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::distribute):
* html/shadow/HTMLShadowElement.cpp: Removed.
* html/shadow/HTMLShadowElement.h: Removed.
* html/shadow/HTMLShadowElement.idl: Removed.
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake ThreadFunctionInvocation fast allocated.
bfulgham@webkit.org [Fri, 3 May 2013 18:08:43 +0000 (18:08 +0000)]
Make ThreadFunctionInvocation fast allocated.
https://bugs.webkit.org/show_bug.cgi?id=115552

Reviewed by Benjamin Poulain.

* wtf/ThreadFunctionInvocation.h:
(ThreadFunctionInvocation): Make Fast-allocated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove WTF::ListRefPtr class
mikhail.pozdnyakov@intel.com [Fri, 3 May 2013 17:12:44 +0000 (17:12 +0000)]
Remove WTF::ListRefPtr class
https://bugs.webkit.org/show_bug.cgi?id=115516

Reviewed by Anders Carlsson.

ListRefPtr was used only by FontFamily class, besides it strongly depended
on FontFamily class semantics which made it non-generic and inappropriate
for being present inside WTF.

This patch removes WTF::ListRefPtr class and moves its the functionality
into FontFamily class.

Source/WebCore:

No new tests, no change in the behavior.

* page/FrameTree.h:
(FrameTree):
* platform/graphics/FontFamily.h:
(FontFamily):
(WebCore::FontFamily::~FontFamily):
(WebCore):

Source/WTF:

* GNUmakefile.list.am:
* WTF.pro:
* WTF.vcproj/WTF.vcproj:
* WTF.vcxproj/WTF.vcxproj:
* WTF.vcxproj/WTF.vcxproj.filters:
* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/Forward.h:
(WTF):
* wtf/ListRefPtr.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
joone.hur@intel.com [Fri, 3 May 2013 16:58:01 +0000 (16:58 +0000)]
Unreviewed EFL gardening.

Skip some failing tests after r149504.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash when calling QWebFrame::evaluateJavaScript
allan.jensen@digia.com [Fri, 3 May 2013 09:34:36 +0000 (09:34 +0000)]
Crash when calling QWebFrame::evaluateJavaScript
https://bugs.webkit.org/show_bug.cgi?id=113434

Reviewed by Simon Hausmann.

We must take the JS API lock before accessing internal JS methods.

* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::unwrapBoxedPrimitive):
(JSC::Bindings::getGregorianDateTimeUTC):
(JSC::Bindings::convertQVariantToValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][CustomProtocols] NSURLProtocolClient methods should be dispatched on NSURLConne...
aestes@apple.com [Fri, 3 May 2013 07:10:20 +0000 (07:10 +0000)]
[WK2][CustomProtocols] NSURLProtocolClient methods should be dispatched on NSURLConnection's resource loader run loop
https://bugs.webkit.org/show_bug.cgi?id=115539

Reviewed by Alexey Proskuryakov.

It turns out that calling NSURLProtocolClient methods from a different
thread than the one running the NSURLConnection run loop is unsafe.
Although I can't capture it reliably in a test case, doing so can
sometimes result in a load timing out because the call to
-[NSURLProtocolClient URLProtocolDidFinishLoading:] was ignored by
NSURLConnection.

Fix this by dispatching these methods on the NSURLConnection resource
load run loop. This matches where NSURLProtocolClient methods are
dispatched by typical NSURLProtocol implementations, and in my testing
this solves the timeout issue.

* Shared/Network/CustomProtocols/CustomProtocolManager.h: Declare
dispatchOnResourceLoaderRunLoop().
* Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
Declare +[NSURLConnection resourceLoaderRunLoop] on a category of
NSURLConnection. Also include the header that declares it if it's present.
(WebKit::CustomProtocolManager::didFailWithError): Call the
NSURLProtocolClient method via dispatchOnResourceLoaderRunLoop().
(WebKit::CustomProtocolManager::didLoadData): Ditto.
(WebKit::CustomProtocolManager::didReceiveResponse): Ditto.
(WebKit::CustomProtocolManager::didFinishLoading): Ditto.
(WebKit::CustomProtocolManager::dispatchOnResourceLoaderRunLoop):
Dispatch a block on the NSURLConnection resource loader run loop and
then wake up the run loop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Fine tune dependencies for glslang generated files
commit-queue@webkit.org [Fri, 3 May 2013 06:47:37 +0000 (06:47 +0000)]
[GTK] Fine tune dependencies for glslang generated files
https://bugs.webkit.org/show_bug.cgi?id=115537

Patch by Xan Lopez <xlopez@igalia.com> on 2013-05-02
Reviewed by Martin Robinson.

Make glslang.* explictly depend on glslang_tab.*, since the
dependency does exist. Otherwise Make might decide to compile
things ahead of time and fail.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix build warnings on ResourceHandleClient.h
commit-queue@webkit.org [Fri, 3 May 2013 05:01:03 +0000 (05:01 +0000)]
Fix build warnings on ResourceHandleClient.h
https://bugs.webkit.org/show_bug.cgi?id=115540

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2013-05-02
Reviewed by Alexey Proskuryakov.

Comment out the parameter names for 'getOrCreateReadBuffer' to fix -Wunused-parameter build warnings.

* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::getOrCreateReadBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFollowing r149463, set Path for WebCore and WebKit makefile as well.
roger_fong@apple.com [Fri, 3 May 2013 01:06:35 +0000 (01:06 +0000)]
Following r149463, set Path for WebCore and WebKit makefile as well.

* WebKit.vcxproj/WebKit.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
joone.hur@intel.com [Fri, 3 May 2013 00:38:11 +0000 (00:38 +0000)]
Unreviewed EFL gardening.

Unskip html5lib test cases that were skipped due to failure after r143804.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Unreviewed build fix.
bfulgham@webkit.org [Fri, 3 May 2013 00:25:31 +0000 (00:25 +0000)]
[WinCairo] Unreviewed build fix.

* WTF.vcxproj/WTF.vcxproj: Use WinCairo FeatureDefines
* WTF.vcxproj/WTF.vcxproj.filters: Use WinCairo FeatureDefines
* WTF.vcxproj/WTFDebugWinCairo.props: Added.
* WTF.vcxproj/WTFReleaseWinCairo.props: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Windows build fix.
roger_fong@apple.com [Fri, 3 May 2013 00:04:34 +0000 (00:04 +0000)]
Unreviewed Windows build fix.

* win/lib/WebKitSystemInterface.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed fix for Mac Lion build after r149503.
eric.carlson@apple.com [Fri, 3 May 2013 00:04:16 +0000 (00:04 +0000)]
Unreviewed fix for Mac Lion build after r149503.

* platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h:
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows, WinCairo] Fix crash in fast/js/create-lots-of-workers.html
bfulgham@webkit.org [Fri, 3 May 2013 00:01:02 +0000 (00:01 +0000)]
[Windows, WinCairo] Fix crash in fast/js/create-lots-of-workers.html
https://bugs.webkit.org/show_bug.cgi?id=115130

Reviewed by Tim Horton.

Windows is suffering from mismatched allocation/deallocation
between the system allocator and fastMalloc/fastFree.  By turning
off the global switch to fastMalloc, only classes specified to
honor fastMalloc/fastFree are affected, and other memory allocation
and freeing is done with consistent library calls.

* wtf/Platform.h: Deactivate ENABLE_GLOBAL_FASTMALLOC_NEW for
the Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBUILD FIX: Move Mac-only symbols into the shared symbol list
ddkilzer@apple.com [Fri, 3 May 2013 00:00:35 +0000 (00:00 +0000)]
BUILD FIX: Move Mac-only symbols into the shared symbol list

* WebCore.exp.in: Move symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShadow DOM removal: Get rid of ContentSelectorQuery
antti@apple.com [Thu, 2 May 2013 23:56:56 +0000 (23:56 +0000)]
Shadow DOM removal: Get rid of ContentSelectorQuery
https://bugs.webkit.org/show_bug.cgi?id=115533

Reviewed by Anders Carlsson.

This is only used for Shadow DOM distribution. <details> element works fine without it.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::distributeSelectionsTo):
* html/shadow/ContentSelectorQuery.cpp: Removed.
* html/shadow/ContentSelectorQuery.h: Removed.
* html/shadow/HTMLContentElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
ryuan.choi@samsung.com [Thu, 2 May 2013 23:39:02 +0000 (23:39 +0000)]
Unreviewed EFL gardening.

Moved XFrameOptions results from efl-wk2 to efl and rebased source-list-parsing-nonascii.html

* platform/efl/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Renamed from LayoutTests/platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt.
* platform/efl/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Renamed from LayoutTests/platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt.
* platform/efl/http/tests/security/contentSecurityPolicy/source-list-parsing-nonascii-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
joone.hur@intel.com [Thu, 2 May 2013 23:34:21 +0000 (23:34 +0000)]
Unreviewed EFL gardening.

Unskip WebAudio test cases on EFL WK2.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoborder-radius clipping a canvas does not always clip
commit-queue@webkit.org [Thu, 2 May 2013 23:33:15 +0000 (23:33 +0000)]
border-radius clipping a canvas does not always clip
https://bugs.webkit.org/show_bug.cgi?id=113343

Source/WebCore:

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-05-02
Reviewed by Simon Fraser.

clipToRect method clip context to clipRect, and then clip to rounded
rect if clipRect has a radius. But currently, clipToRect exit early if
clipToRect is equal to paintDirtyRect.

This patch allows clipping to rounded corner ever if clipToRect is
equal to paintDirtyRect.

Test: fast/overflow/border-radius-clipping-2.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clipToRect):

LayoutTests:

Create a test that draws a canvas into a clipped overflown div with
radius corner. Then redraw that same thing a moment later. The canvas
should stay correctly clipped the second time.

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-05-02
Reviewed by Simon Fraser.

* fast/overflow/border-radius-clipping-2-expected.html: Added.
* fast/overflow/border-radius-clipping-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCaption menu does not include in-band captions
eric.carlson@apple.com [Thu, 2 May 2013 23:06:09 +0000 (23:06 +0000)]
Caption menu does not include in-band captions
https://bugs.webkit.org/show_bug.cgi?id=111934

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, upated existing tests for these changes.

* WebCore.xcodeproj/project.pbxproj: Add new files.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::loadInternal): Clear the LoadMediaResource from m_pendingActionFlags
    in case there is a pending async load.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Always log the track score.
(WebCore::HTMLMediaElement::configureTextTracks): Call configureTextTrackDisplay so
    m_legacyWebKitClosedCaptionsVisible is always updated immediately.
(WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): Use m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): Ditto.
* html/HTMLMediaElement.h:

* page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::CaptionUserPreferences): Initialize m_displayMode to ForcedOnly
    because it is no longer used for testing only.
(WebCore::CaptionUserPreferences::notify): Post notifications when not in testing-only mode.

* page/CaptionUserPreferencesMac.h:
* page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Calculate a track score when
    webkitClosedCaptionsVisible has been set.
(WebCore::CaptionUserPreferencesMac::sortedTrackListForMenu): Don't filter track list when we
    don't have the media accessibility framework. Make logging more informative.
* platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

* platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
(WebCore::InbandTextTrackPrivateAVFObjC::create): Take a AVFInbandTrackParent instead of a
    MediaPlayerPrivateAVFoundationObjC.
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
(WebCore::InbandTextTrackPrivateAVFObjC::InbandTextTrackPrivateAVFObjC): Ditto.

* platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h: Added.
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm: Added.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): We only have legible output when
    HAVE_AVFOUNDATION_LEGIBLE_OUTPUT_SUPPORT is defined.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Create a legacy CC track if
    there are no media selection options and there is a CC AVAssetTrack.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyCCTracks): New, process CC tracks.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processNewAndRemovedTextTracks): New, refactored
    common setup/cleanup code from processMediaSelectionOptions.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions): Renamed from
    processTextTracks. Move common setup/cleanup code to processNewAndRemovedTextTracks.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Deal with legacy CC tracks.

Source/WTF:

* wtf/Platform.h: Define HAVE_AVFOUNDATION_TEXT_TRACK_SUPPORT on 10.8 and higher. Added
    HAVE_AVFOUNDATION_LEGIBLE_OUTPUT_SUPPORT.

LayoutTests:

* platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
* platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] caption track menu includes "easy to read" in-band tracks twice
eric.carlson@apple.com [Thu, 2 May 2013 22:57:35 +0000 (22:57 +0000)]
[Mac] caption track menu includes "easy to read" in-band tracks twice
https://bugs.webkit.org/show_bug.cgi?id=115529

Reviewed by Dean Jackson.

* page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::sortedTrackListForMenu): Check to see if a track is
     easy-to-read after checking if it is forced only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove SiblingTraversalStrategies.h
antti@apple.com [Thu, 2 May 2013 22:41:49 +0000 (22:41 +0000)]
Remove SiblingTraversalStrategies.h
https://bugs.webkit.org/show_bug.cgi?id=115532

Reviewed by Andreas Kling.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* css/SiblingTraversalStrategies.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (149389) Main resources converted to downloads are immediately cancelled.
beidson@apple.com [Thu, 2 May 2013 22:23:25 +0000 (22:23 +0000)]
REGRESSION (149389) Main resources converted to downloads are immediately cancelled.
<rdar://problem/13795795> and https://bugs.webkit.org/show_bug.cgi?id=115530

Reviewed by Alexey Proskuryakov.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload): Call didConvertHandleToDownload
  on the NetworkResourceLoader.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::didConvertHandleToDownload): Set m_handleConvertedToDownload to true.
(WebKit::NetworkResourceLoader::abort): Only cancel the handle if m_handleConvertedToDownload is false.
* NetworkProcess/NetworkResourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShadow DOM removal: Make SelectorChecker non-generic
antti@apple.com [Thu, 2 May 2013 22:13:56 +0000 (22:13 +0000)]
Shadow DOM removal: Make SelectorChecker non-generic
https://bugs.webkit.org/show_bug.cgi?id=115526

Reviewed by Andreas Kling.

Without Shadow DOM distribution we don't need SiblingTraversalStrategies anymore.

* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
* css/SelectorChecker.cpp:
(WebCore):
(WebCore::isFirstChildElement):
(WebCore::isLastChildElement):
(WebCore::isFirstOfType):
(WebCore::isLastOfType):
(WebCore::countElementsBefore):
(WebCore::countElementsOfTypeBefore):
(WebCore::countElementsAfter):
(WebCore::countElementsOfTypeAfter):
(WebCore::SelectorChecker::match):
(WebCore::SelectorChecker::checkOne):
* css/SelectorChecker.h:
(SelectorChecker):
* css/SiblingTraversalStrategies.h:
* css/StyleResolver.h:
(WebCore::checkRegionSelector):
* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::selectorMatches):
* html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorDataList::checkContentSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
joone.hur@intel.com [Thu, 2 May 2013 21:33:37 +0000 (21:33 +0000)]
Unreviewed EFL gardening.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix potential bug in lookup logic
oliver@apple.com [Thu, 2 May 2013 20:59:33 +0000 (20:59 +0000)]
Fix potential bug in lookup logic
https://bugs.webkit.org/show_bug.cgi?id=115522

Reviewed by Mark Hahnenberg.

Though not a problem in practise, it is technically possible
to inject an un-proxied global object into the scope chain
via the C API.  This change makes sure that the scope walk
in BytecodeGenerator actually limits itself to scopes that
are statically bindable.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::resolve):
* runtime/JSObject.h:
(JSObject):
(JSC):
(JSC::JSObject::isStaticScopeObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSimplify WebCoreObjCExtras by using WTF::bind
andersca@apple.com [Thu, 2 May 2013 20:56:41 +0000 (20:56 +0000)]
Simplify WebCoreObjCExtras by using WTF::bind
https://bugs.webkit.org/show_bug.cgi?id=115524

Reviewed by Andreas Kling.

* platform/mac/WebCoreObjCExtras.mm:
(deallocCallback):
(WebCoreObjCScheduleDeallocateOnMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdated WebKitGTK+ Translation for Odia [or] language.
kov@webkit.org [Thu, 2 May 2013 20:43:02 +0000 (20:43 +0000)]
Updated WebKitGTK+ Translation for Odia [or] language.
https://bugs.webkit.org/show_bug.cgi?id=115030

Patch by Manoj Kumar Giri <mgiri@redhat.com> on 2013-05-02
Reviewed by Gustavo Noronha Silva.

* or.po: updated translation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake BloomFilter fast allocated.
bfulgham@webkit.org [Thu, 2 May 2013 20:42:04 +0000 (20:42 +0000)]
Make BloomFilter fast allocated.
https://bugs.webkit.org/show_bug.cgi?id=115519

Reviewed by Benjamin Poulain.

* wtf/BloomFilter.h:
(BloomFilter): Make BloomFilter Fast-allocated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove a stale script file.
thakis@chromium.org [Thu, 2 May 2013 20:00:13 +0000 (20:00 +0000)]
Remove a stale script file.
https://bugs.webkit.org/show_bug.cgi?id=115521

Reviewed by Anders Carlsson.

This script was added in
https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
Bakefile system that was removed in
https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
script just asserts when it's run and is useless.

* Scripts/update-sources-list.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago <rdar://problem/13740375> Non-ASCII downloaded file names are garbled when...
ap@apple.com [Thu, 2 May 2013 19:26:04 +0000 (19:26 +0000)]
    <rdar://problem/13740375> Non-ASCII downloaded file names are garbled when using NetworkProcess
        https://bugs.webkit.org/show_bug.cgi?id=115520

        Reviewed by Darin Adler.

        * Shared/mac/WebCoreArgumentCodersMac.mm:
        (CoreIPC::::encodePlatformData):
        (CoreIPC::::decodePlatformData):
        Send the encoding fallback array over IPC, so that it's present when NetworkProcess does its loading.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Cannot touch scroll readonly text input.
commit-queue@webkit.org [Thu, 2 May 2013 18:33:39 +0000 (18:33 +0000)]
[BlackBerry] Cannot touch scroll readonly text input.
https://bugs.webkit.org/show_bug.cgi?id=115378

Patch by Genevieve Mak <gmak@rim.com> on 2013-05-02
Reviewed by Rob Buis.

PR #332902
Reviewed Internally by Mike Fenton.
Forgot half the patch.
Node::rendererIsEditable() returns false if the input element has the readonly tag set.
Check the node type instead.

* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago REGRESSION (r149422): -[WKBrowsingContextController loadFileURL:restrictToFil...
ap@apple.com [Thu, 2 May 2013 16:56:29 +0000 (16:56 +0000)]
    REGRESSION (r149422): -[WKBrowsingContextController loadFileURL:restrictToFilesWithin:]
        broken when second argument is nil
        https://bugs.webkit.org/show_bug.cgi?id=115505
        <rdar://problem/13787297>

        Reviewed by Darin Adler.

        * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::loadFile): Pass a URL string
        to assumeReadAccessToBaseURL, as this is what it takes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Make scroll position adjustment work with pages with fixed position...
commit-queue@webkit.org [Thu, 2 May 2013 15:52:38 +0000 (15:52 +0000)]
[BlackBerry] Make scroll position adjustment work with pages with fixed position elements.
https://bugs.webkit.org/show_bug.cgi?id=115178

Patch by Iris Wu <shuwu@blackberry.com> on 2013-05-02
Reviewed by Rob Buis.

PR 308796
Debug build fix.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::fixedElementSizeDelta):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSegmentation Fault with Romanian locale. Evolution not starting.
zandobersek@gmail.com [Thu, 2 May 2013 14:22:22 +0000 (14:22 +0000)]
Segmentation Fault with Romanian locale. Evolution not starting.
https://bugs.webkit.org/show_bug.cgi?id=115484

Reviewed by Darin Adler.

Do not translate the property names that are being passed to the g_param_spec_boolean
method - it is not required and is causing segfaults with various locales.

* webkit/webkitviewportattributes.cpp:
(webkit_viewport_attributes_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed. Some more gardening after r149292.
zarvai@inf.u-szeged.hu [Thu, 2 May 2013 12:49:18 +0000 (12:49 +0000)]
[Qt] Unreviewed. Some more gardening after r149292.
https://bugs.webkit.org/show_bug.cgi?id=115372

* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.png:
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.png:
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
* platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-sticky-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.png:
* platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
* platform/qt-5.0-wk2/css3/filters/filtered-compositing-descendant-expected.txt: Added.
* platform/qt-5.0-wk2/editing/selection/caret-rtl-right-expected.txt:
* platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.png:
* platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.txt:
* platform/qt-5.0-wk2/fast/forms/menulist-separator-painting-expected.txt:
* platform/qt-5.0-wk2/fast/forms/selectlist-minsize-expected.txt:
* platform/qt-5.0-wk2/svg/custom/glyph-selection-bidi-mirror-expected.txt:
* platform/qt-5.0-wk2/svg/custom/use-instanceRoot-event-listeners-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening after r149457 and r149388.
zarvai@inf.u-szeged.hu [Thu, 2 May 2013 12:13:47 +0000 (12:13 +0000)]
[Qt] Unreviewed gardening after r149457 and r149388.

* platform/qt/TestExpectations:
* platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
ryuan.choi@samsung.com [Thu, 2 May 2013 06:30:33 +0000 (06:30 +0000)]
Unreviewed EFL gardening.

* platform/efl/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt: Added.
* platform/efl/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Added.
* platform/efl/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Added.
* platform/efl/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Added.
* platform/efl/svg/text/text-midpoint-split-bug-expected.txt: Added.
* platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoVersioning.
lforschler@apple.com [Thu, 2 May 2013 03:45:30 +0000 (03:45 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate Lion results after http://trac.webkit.org/projects/webkit/changeset/149474
slewis@apple.com [Thu, 2 May 2013 02:38:44 +0000 (02:38 +0000)]
Update Lion results after trac.webkit.org/projects/webkit/changeset/149474

Unreviewed.

* platform/mac-lion/fast/text/text-combine-different-fonts-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[webkitpy] Need abstract base class for commands that analyze commit logs
glenn@skynav.com [Thu, 2 May 2013 02:10:25 +0000 (02:10 +0000)]
[webkitpy] Need abstract base class for commands that analyze commit logs
https://bugs.webkit.org/show_bug.cgi?id=115391

Reviewed by Benjamin Poulain.

Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
in preparation for adding two new commands that will reuse this functionality along with
suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
https://bugs.webkit.org/show_bug.cgi?id=115388.

No new tests as this patch does not change existing functionality or behavior.

* Scripts/webkitpy/tool/commands/suggestnominations.py:
(AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
(AbstractCommitLogCommand.__init__):
(AbstractCommitLogCommand._init_options):
(AbstractCommitLogCommand._parse_commit_message):
(SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
(SuggestNominations.__init__):
(SuggestNominations._init_options):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] WebKit doesn't enable or disable autocorrections when system preferences are...
rniwa@webkit.org [Thu, 2 May 2013 01:54:27 +0000 (01:54 +0000)]
[Mac] WebKit doesn't enable or disable autocorrections when system preferences are changed
https://bugs.webkit.org/show_bug.cgi?id=115463

Reviewed by Darin Adler.

Source/WebKit/mac:

Observe the default notification center for changes to autocorrection preferences.
Note system preferences may also update WebAutomatic* defaults.

* WebView/WebView.mm:
(+[WebView initialize]):
(+[WebView _shouldAutomaticTextReplacementBeEnabled]):
(+[WebView _didChangeAutomaticTextReplacementEnabled:]):
(+[WebView _shouldAutomaticSpellingCorrectionBeEnabled]):
(+[WebView _didChangeAutomaticSpellingCorrectionEnabled:]):
(+[WebView _shouldAutomaticQuoteSubstitutionBeEnabled]):
(+[WebView _shouldAutomaticDashSubstitutionBeEnabled]):
(+[WebView _didChangeAutomaticQuoteSubstitutionEnabled:]):
(+[WebView _didChangeAutomaticDashSubstitutionEnabled:]):

Source/WebKit2:

Observe the default notification center and propagate the changes to TextCheckerState and
to all WebProcesses when system preferences are updated.

* UIProcess/TextChecker.h:
* UIProcess/WebContext.h:
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::shouldAutomaticTextReplacementBeEnabled):
(WebKit::shouldAutomaticSpellingCorrectionBeEnabled):
(WebKit::shouldAutomaticQuoteSubstitutionBeEnabled):
(WebKit::shouldAutomaticDashSubstitutionBeEnabled):
(WebKit::initializeState):
(WebKit::TextChecker::didChangeAutomaticTextReplacementEnabled):
(WebKit::TextChecker::didChangeAutomaticSpellingCorrectionEnabled):
(WebKit::TextChecker::didChangeAutomaticQuoteSubstitutionEnabled):
(WebKit::TextChecker::didChangeAutomaticDashSubstitutionEnabled):
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::registerNotificationObservers):
(WebKit::WebContext::unregisterNotificationObservers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agotext-combine: horizontal does not work properly for some fonts.
enrica@apple.com [Thu, 2 May 2013 01:48:55 +0000 (01:48 +0000)]
text-combine: horizontal does not work properly for some fonts.
https://bugs.webkit.org/show_bug.cgi?id=115503.

Reviewed by Dave Hyatt.

Source/WebCore:

For some fonts that don't have width variants, we fail to combine glyphs
because we believe they don't fit. That decision is made comparing the run width
with the font computed size multiplied by a margin factor.
I've increased the margin from 10% to 15%.

Test: fast/text/text-combine-different-fonts.html

* rendering/RenderCombineText.cpp:

LayoutTests:

* fast/text/text-combine-different-fonts.html: Added.
* platform/mac/fast/text/text-combine-different-fonts-expected.png: Added.
* platform/mac/fast/text/text-combine-different-fonts-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Fix build break after r149449
ryuan.choi@samsung.com [Thu, 2 May 2013 01:30:26 +0000 (01:30 +0000)]
[GTK] Fix build break after r149449
https://bugs.webkit.org/show_bug.cgi?id=115500

Reviewed by Gustavo Noronha Silva.

Unreviewed GTK build fix

* GNUmakefile.list.am: Added LocalStorageDatabase.[cpp|h] to the list of
sources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFastMalloc.cpp should use system defined page size instead of literal constant
msaboff@apple.com [Thu, 2 May 2013 01:22:55 +0000 (01:22 +0000)]
FastMalloc.cpp should use system defined page size instead of literal constant
https://bugs.webkit.org/show_bug.cgi?id=115502

Reviewed by Geoffrey Garen.

Updated kPageShift to be PAGE_SHIFT for Mac.  Changed kMaxSize to be fixed at 32K.
Updated kNumClasses for 4K and 16K page sizes.

* wtf/FastMalloc.cpp:
kPageShift: Changed this to be PAGE_SHIFT on mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [BlackBerry] Upstream smart selection
commit-queue@webkit.org [Thu, 2 May 2013 01:09:18 +0000 (01:09 +0000)]
 [BlackBerry] Upstream smart selection
 https://bugs.webkit.org/show_bug.cgi?id=111226

Patch by Iris Wu <shuwu@blackberry.com> on 2013-05-01
Reviewed by Rob Buis.

Calling userInterfaceViewportAccessor()->documentViewportRect() on WK thread
caused crash.
But viewport from webkitThreadViewportAccessor uses unadjusted size which is
wrong for email.
The solution here is to get actual viewport size on UI thread and then pass it
to WebKit::SelectionHandler.

PR 333763
Reviewed Internally By Jakob Petsovits.

* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setSelectionDocumentViewportSize):
(WebKit):
* Api/WebPage.h:
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
(BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
(BlackBerry::WebKit::SelectionHandler::selectionViewportRect):
* WebKitSupport/SelectionHandler.h:
(BlackBerry::WebKit::SelectionHandler::setSelectionViewportSize):
(BlackBerry::WebKit::SelectionHandler::setSelectionSubframeViewportRect):
(SelectionHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate Lion results after http://trac.webkit.org/projects/webkit/changeset/149450
slewis@apple.com [Thu, 2 May 2013 01:07:03 +0000 (01:07 +0000)]
Update Lion results after trac.webkit.org/projects/webkit/changeset/149450

Unreviewed.

* platform/mac-lion/fast/block/lineboxcontain/block-with-ideographs-expected.png: Added.
* platform/mac-lion/fast/block/lineboxcontain/block-with-ideographs-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNull check plugInClient earlier in snapshotting path
commit-queue@webkit.org [Thu, 2 May 2013 00:40:22 +0000 (00:40 +0000)]
Null check plugInClient earlier in snapshotting path
https://bugs.webkit.org/show_bug.cgi?id=115498

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-05-01
Reviewed by Darin Adler.

* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Fix check-inspector-strings script and fix localized strings
commit-queue@webkit.org [Thu, 2 May 2013 00:39:14 +0000 (00:39 +0000)]
Web Inspector: Fix check-inspector-strings script and fix localized strings
https://bugs.webkit.org/show_bug.cgi?id=115495

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-05-01
Reviewed by Joseph Pecoraro.

Source/WebCore:

No new tests, because there is no change in behavior.

* English.lproj/localizedStrings.js:

Tools:

* Scripts/check-inspector-strings:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] [WebKit2] Documentation for webkit_web_view_run_javascript should indicate...
mrobinson@webkit.org [Thu, 2 May 2013 00:38:37 +0000 (00:38 +0000)]
[GTK] [WebKit2] Documentation for webkit_web_view_run_javascript should indicate what happens when JavaScript is disabled
https://bugs.webkit.org/show_bug.cgi?id=115492

Reviewed by Xan Lopez.

* UIProcess/API/gtk/WebKitWebView.cpp: Clarify the documentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<object data="<some data URL>"> MIME types aren't case-insensitive
timothy_horton@apple.com [Thu, 2 May 2013 00:15:28 +0000 (00:15 +0000)]
<object data="<some data URL>"> MIME types aren't case-insensitive
https://bugs.webkit.org/show_bug.cgi?id=115494

Reviewed by Darin Adler.

Test: fast/images/object-data-url-case-insensitivity.html

MIME types are defined to be case-insensitive, but many places in WebCore
only compare them against lower-case strings. Most entry points for MIME
types lower-case them, but mimeTypeFromDataURL doesn't, causing, for example,
data:image/png;... to work, but data:iMaGe/PNG;... to fail.

To fix this, lower-case the string returned from mimeTypeFromDataURL.

* platform/KURL.cpp:
(WebCore::mimeTypeFromDataURL):

Add a testcase that ensures that iMaGe/PNG == image/png when it comes to
the MIME type specified in a data URL provided to <object> via its
'data' attribute.

* fast/images/object-data-url-case-insensitivity-expected.html: Added.
* fast/images/object-data-url-case-insensitivity.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Text replacement should use correction indicator
rniwa@webkit.org [Thu, 2 May 2013 00:02:29 +0000 (00:02 +0000)]
[Mac] Text replacement should use correction indicator
https://bugs.webkit.org/show_bug.cgi?id=115471

Reviewed by Darin Adler.

Support autocorrection panel for text replacements by making AlternativeTextTypeCorrection
handle text replacements as well as automatic spelling correction.

No new tests. Unfortunately this feature is not testable as is. We need to provide some
internals or testRunner methods to make this feature testable in the long term.

* editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::timerFired): Trigger both TextCheckingTypeReplacement
and TextCheckingTypeShowCorrectionPanel.

* editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor): Autocorrection panel maybe used for both
TextCheckingTypeReplacement and TextCheckingTypeShowCorrectionPanel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove knowledge of PDF/PostScript MIME types into MIMETypeRegistry
timothy_horton@apple.com [Wed, 1 May 2013 23:46:55 +0000 (23:46 +0000)]
Move knowledge of PDF/PostScript MIME types into MIMETypeRegistry
https://bugs.webkit.org/show_bug.cgi?id=115487

Reviewed by Darin Adler.

No new tests, just a refactoring.

* UIProcess/WebContext.cpp:
* UIProcess/WebContext.h:
Remove pdfAndPostScriptMIMETypes.

* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::canShowMIMEType): Move PDF bits to WebPageProxy.
(WebKit::WebFrameProxy::isDisplayingPDFDocument):
Make use of WebCore's newfound knowledge of PDF and PostScript MIME types,
so we don't have to duplicate it unnecessarily in WebKit2.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::canShowMIMEType):
Add code which used to be in WebFrameProxy::canShowMIMEType, and adapt it
to use WebCore's knowledge of PDF and PostScript MIME types.

* WebProcess/Plugins/PDF/SimplePDFPlugin.mm:
(WebKit::SimplePDFPlugin::pluginInfo):
We previously supported the "text/pdf" MIME type for PDFViewController,
so SimplePDFPlugin and PDFPlugin should support it as well.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Adopt MIMETypeRegistry::isPDFOrPostScriptMIMEType.

* WebProcess/WebPage/WebPage.h:
(WebPage):
Remove pdfAndPostScriptMIMETypes.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformPreferencesDidChange):
Adopt getPDFAndPostScriptMIMETypes instead of duplicating the list in WebKit2.

* WebCore.exp.in:
Export newly-added isPDFOrPostScriptMIMEType and getPDFAndPostScriptMIMETypes.

* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
Adopt MIMETypeRegistry::isPDFOrPostScriptMIMEType instead of duplicating
the list of MIME types. The previous list did not include PostScript, but
it seems reasonable to put plugins ahead of built-in support for it in addition to PDF.

* platform/MIMETypeRegistry.cpp:
(WebCore::initializePDFAndPostScriptMIMETypes): Added.
(WebCore::initializeMIMETypeRegistry): Call initializePDFAndPostScriptMIMETypes.
(WebCore::MIMETypeRegistry::isPDFOrPostScriptMIMEType):
Consult our new HashSet to see if the given MIME type is one of those used for PDF or PS.

(WebCore::MIMETypeRegistry::getPDFAndPostScriptMIMETypes): Added.
* platform/MIMETypeRegistry.h:
(MIMETypeRegistry): Add isPDFOrPostScriptMIMEType and getPDFAndPostScriptMIMETypes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSet Path in makefile for AppleWin.
roger_fong@apple.com [Wed, 1 May 2013 23:28:46 +0000 (23:28 +0000)]
Set Path in makefile for AppleWin.

* JavaScriptCore.vcxproj/JavaScriptCore.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement LocalStorageDatabase::importItems
andersca@apple.com [Wed, 1 May 2013 23:17:29 +0000 (23:17 +0000)]
Implement LocalStorageDatabase::importItems
https://bugs.webkit.org/show_bug.cgi?id=115493

Reviewed by Andreas Kling.

Source/WebCore:

Export symbols needed by WebKit2.

* WebCore.exp.in:

Source/WebKit2:

Fetch items and insert them in the storage map.
* UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::importItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBegin work on loading items from the local storage database
andersca@apple.com [Wed, 1 May 2013 22:38:45 +0000 (22:38 +0000)]
Begin work on loading items from the local storage database
https://bugs.webkit.org/show_bug.cgi?id=115489

Reviewed by Andreas Kling.

Source/WebCore:

Export symbols and SQLite headers needed.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Some of the LocalStorageDatabase code is originally from WebCore,
but has been simplified due to the fact that we don't need to load
database data asynchronously since we're already running on a non-main thread.

* UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::LocalStorageDatabase):
(WebKit::LocalStorageDatabase::openDatabase):
(WebKit::LocalStorageDatabase::tryToOpenDatabase):
(WebKit::LocalStorageDatabase::migrateItemTableIfNeeded):
(WebKit::LocalStorageDatabase::importItems):

* UIProcess/Storage/LocalStorageDatabase.h:
(WebKit::StorageManager::StorageArea::setItem):
(WebKit::StorageManager::StorageArea::removeItem):
(WebKit::StorageManager::StorageArea::clear):
(WebKit::StorageManager::StorageArea::items):
Call importItemsFromDatabase().

(WebKit::StorageManager::StorageArea::importItemsFromDatabase):
Ask the database to import the items.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] Programmatic layout tests fail when subpixel layout is disabled
hmuller@adobe.com [Wed, 1 May 2013 22:01:10 +0000 (22:01 +0000)]
[CSS Exclusions] Programmatic layout tests fail when subpixel layout is disabled
https://bugs.webkit.org/show_bug.cgi?id=115455

Source/WebCore:

First round of changes to restore platform/mac exclusion tests that started failing when
subpixel layout was turned off.

Reviewed by Dirk Schulze.

* rendering/ExclusionPolygon.cpp:
(WebCore::appendArc): Ensure that the 3rd of 5 added vertices is in the center of the arc.
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): Use ceiledLayoutUnit() for downwards-snapping first fit location.
* rendering/ExclusionRectangle.cpp:
(WebCore::ExclusionRectangle::firstIncludedIntervalLogicalTop): Ditto.

LayoutTests:

Reviewed by Dirk Schulze.

First round of changes to restore platform/mac exclusion tests that started failing when
subpixel layout was turned off. This set of changes just restores four tests. It also revises
the subpixel-utils code to bring it into line with the most recent LayoutUnit et al changes
and to simplify its use a little.

* fast/exclusions/resources/rounded-rectangle.js:
(simulateShape): Revised dependencies on subpixel-utils.
* fast/exclusions/resources/simple-polygon.js:
(polygonXIntercepts): Ditto.
* fast/exclusions/resources/subpixel-utils.js:
(SubPixelLayout.): Substantially revised, see description.
* fast/exclusions/shape-inside/shape-inside-polygon-layout-expected.txt:
* fast/exclusions/shape-inside/shape-inside-polygon-layout.html:
* fast/exclusions/shape-inside/shape-inside-polygon-padding-003-expected.txt:
* fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html:
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-002-expected.html:
* fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon-expected.txt:
* fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html:
* fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left-expected.txt:
* fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html:
* fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right-expected.txt:
* fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed buildfix after r149449.
ryuan.choi@samsung.com [Wed, 1 May 2013 21:50:29 +0000 (21:50 +0000)]
[EFL] Unreviewed buildfix after r149449.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the function names of r149453
benjamin@webkit.org [Wed, 1 May 2013 21:22:24 +0000 (21:22 +0000)]
Fix the function names of r149453

Unreviewed.

I forgot to follow one of Darin's review comment. This patch
fixes the function names to follow CF naming conventions.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-01

* WebView/WebHTMLRepresentation.mm:
(newArrayWithStrings):
(newArrayByConcatenatingArrays):
(+[WebHTMLRepresentation supportedMIMETypes]):
(+[WebHTMLRepresentation supportedNonImageMIMETypes]):
(+[WebHTMLRepresentation supportedImageMIMETypes]):
(+[WebHTMLRepresentation unsupportedTextMIMETypes]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSimplify WebHTMLRepresentation supportedMIMETypes methods
benjamin@webkit.org [Wed, 1 May 2013 21:02:13 +0000 (21:02 +0000)]
Simplify WebHTMLRepresentation supportedMIMETypes methods
https://bugs.webkit.org/show_bug.cgi?id=115314

Reviewed by Darin Adler.

The initialization was surprisingly complex because of DEFINE_STATIC_LOCAL.
First, a new pointer was allocated on the heap with fast malloc (for RetainPtr<NSArray>).
Then a new NSMutableArray was allocated but immediately put on the autorelease pool.
Finally, that array was retained by the RetainPtr.

This patch changes the code to only leak the NSMutableArray memory. There
is no fastMalloc, nor any use of the autorelease pool.

* WebView/WebHTMLRepresentation.mm:
(createArrayWithStrings):
(createArrayByConcatenatingArrays):
(+[WebHTMLRepresentation supportedMIMETypes]):
(+[WebHTMLRepresentation supportedNonImageMIMETypes]):
(+[WebHTMLRepresentation supportedImageMIMETypes]):
(+[WebHTMLRepresentation unsupportedTextMIMETypes]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed buildfix after r149449.
zarvai@inf.u-szeged.hu [Wed, 1 May 2013 20:58:32 +0000 (20:58 +0000)]
[Qt] Unreviewed buildfix after r149449.

* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove the remaining wscript
benjamin@webkit.org [Wed, 1 May 2013 20:52:04 +0000 (20:52 +0000)]
Remove the remaining wscript
https://bugs.webkit.org/show_bug.cgi?id=115459

Reviewed by Andreas Kling.

.:

* wscript: Removed.

Source/JavaScriptCore:

* wscript: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIncorrect layout for blocks containing ideographs with -webkit-linebox-contain: glyph...
enrica@apple.com [Wed, 1 May 2013 20:37:04 +0000 (20:37 +0000)]
Incorrect layout for blocks containing ideographs with -webkit-linebox-contain: glyphs, font, inline-box.
https://bugs.webkit.org/show_bug.cgi?id=115478.

Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/block/lineboxcontain/block-with-ideographs.xhtml

When computing ascent and descent we need to take into account
the baseline type. RootInlineBox::ascentAndDescentForBox failed
to do that in few cases.

* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::ascentAndDescentForBox):

LayoutTests:

* fast/block/lineboxcontain/block-with-ideographs.xhtml: Added.
* platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.txt: Added.
* platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.png : Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd LocalStorageDatabase class
andersca@apple.com [Wed, 1 May 2013 20:28:27 +0000 (20:28 +0000)]
Add LocalStorageDatabase class
https://bugs.webkit.org/show_bug.cgi?id=115486

Reviewed by Sam Weinig.

Source/WebCore:

Export symbols needed by WebKit2.

* WebCore.exp.in:

Source/WebKit2:

The LocalStorageDatabase class will persist local storage data to disk.

* UIProcess/Storage/LocalStorageDatabase.cpp:
* UIProcess/Storage/LocalStorageDatabase.h: Added.

* UIProcess/Storage/StorageManager.cpp:
(StorageManager::StorageArea):
(WebKit::StorageManager::LocalStorageNamespace::storageManager):
Add getter.

(StorageManager::LocalStorageNamespace):
(WebKit::StorageManager::StorageArea::StorageArea):
If this is a local storage area, create a LocalStorageDatabase.

(WebKit::StorageManager::LocalStorageNamespace::databaseFilename):
Helper function for getting the name of the database for the given origin.

* WebKit2.xcodeproj/project.pbxproj:
Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac Lion] Assertion failure in MediaControlTextTrackContainerElement::updateDisplay()
eric.carlson@apple.com [Wed, 1 May 2013 19:57:31 +0000 (19:57 +0000)]
[Mac Lion] Assertion failure in MediaControlTextTrackContainerElement::updateDisplay()
https://bugs.webkit.org/show_bug.cgi?id=115289

Reviewed by Jer Noble.

No new tests, this is a speculative fix for an infrequent assertion.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackRemoveCue): Mark the cue as inactive when it is removed
    from the active set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTextTrackMenu crashes in ports where MediaElement players are lazily created
commit-queue@webkit.org [Wed, 1 May 2013 19:55:31 +0000 (19:55 +0000)]
TextTrackMenu crashes in ports where MediaElement players are lazily created
https://bugs.webkit.org/show_bug.cgi?id=115485

Null check the player for ports, like iOS, that lazily create the player.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-05-01
Reviewed by Eric Carlson.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::platformTextTrackMenu):
(WebCore::HTMLMediaElement::closeCaptionTracksChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
zandobersek@gmail.com [Wed, 1 May 2013 19:10:35 +0000 (19:10 +0000)]
[TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
https://bugs.webkit.org/show_bug.cgi?id=115470

Reviewed by Martin Robinson.

In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
not building either of the IOS, Windows or GTK-WK1 platforms.

Up until now the header was included for everything but the IOS and Windows platforms due to
an incorrectly stated condition regarding the GTK platform.

* TestWebKitAPI/config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
zandobersek@gmail.com [Wed, 1 May 2013 19:09:32 +0000 (19:09 +0000)]
[GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
https://bugs.webkit.org/show_bug.cgi?id=115469

Reviewed by Martin Robinson.

Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
for the WebKit2 tests and the injected bundle required by them.

This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
under the WebKit2 code).

The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.

* TestWebKitAPI/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd FunctionDispatcher class and make RunLoop derive from it
andersca@apple.com [Wed, 1 May 2013 18:59:21 +0000 (18:59 +0000)]
Add FunctionDispatcher class and make RunLoop derive from it
https://bugs.webkit.org/show_bug.cgi?id=115480

Reviewed by Sam Weinig.

Source/WebCore:

Change RunLoop to be a subclass of FunctionDispatcher.

* platform/RunLoop.h:
(RunLoop):

Source/WTF:

Add FunctionDispatcher files.

* WTF.pro:
* WTF.vcproj/WTF.vcproj:
* WTF.vcxproj/WTF.vcxproj:
* WTF.xcodeproj/project.pbxproj:
* wtf/FunctionDispatcher.cpp: Added.
(WTF::FunctionDispatcher::FunctionDispatcher):
(WTF::FunctionDispatcher::~FunctionDispatcher):
* wtf/FunctionDispatcher.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHTMLMediaElement::updateActiveTextTrackCues can do unnecessary work
eric.carlson@apple.com [Wed, 1 May 2013 18:55:32 +0000 (18:55 +0000)]
HTMLMediaElement::updateActiveTextTrackCues can do unnecessary work
https://bugs.webkit.org/show_bug.cgi?id=81856

Reviewed by Jer Noble.

No new tests, covered by existing tests.

* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::ignoreTrackDisplayUpdateRequests): Add an early return when there
    is obviously no work to be done.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Update WebKitSystemInterface.
ap@apple.com [Wed, 1 May 2013 18:26:51 +0000 (18:26 +0000)]
    Update WebKitSystemInterface.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLion.a:
        * libWebKitSystemInterfaceMountainLion.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago <rdar://problem/13781156> Launching NetworkProcess broken on some OS versions.
ap@apple.com [Wed, 1 May 2013 18:14:59 +0000 (18:14 +0000)]
    <rdar://problem/13781156> Launching NetworkProcess broken on some OS versions.

        Reviewed by Anders Carlsson.

        Adapt to LaunchServices changes.

        * Shared/mac/ChildProcessMac.mm:
        (WebKit::ChildProcess::setApplicationIsDaemon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] [WebKit2] Add a setting to control whether or not accelerated 2D canvas is...
commit-queue@webkit.org [Wed, 1 May 2013 18:10:59 +0000 (18:10 +0000)]
[GTK] [WebKit2] Add a setting to control whether or not accelerated 2D canvas is enabled
https://bugs.webkit.org/show_bug.cgi?id=114394

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-05-01
Reviewed by Anders Carlsson.

Add a setting to control accelerated 2D canvas, which determines whether
or not to consider rendering HTML canvas with hardware acceleration.

* UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty): Added support for enable-accelerated-2d-canvas property.
(webKitSettingsGetProperty): Added support for enable-accelerated-2d-canvas property.
(webkit_settings_class_init): Added support for enable-accelerated-2d-canvas property.
(webkit_settings_get_enable_accelerated_2d_canvas): Added.
(webkit_settings_set_enable_accelerated_2d_canvas): Added.
* UIProcess/API/gtk/WebKitSettings.h: New methods.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Added new methods to the documentation.
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings): Added a simple test for the setting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEntering full screen mode shows desktop linen instead of WKView the first time.
jer.noble@apple.com [Wed, 1 May 2013 17:45:11 +0000 (17:45 +0000)]
Entering full screen mode shows desktop linen instead of WKView the first time.
https://bugs.webkit.org/show_bug.cgi?id=115433
<rdar://problem/13774540>

Reviewed by Eric Carlson.

For certain types of windows created by subclasses of WKView, the window in question fails to paint
when created with a zero-size rect. Create the window with an initial size of the active screen frame
as that is the likely destination size.

* UIProcess/API/mac/WKView.mm:
(-[WKView createFullScreenWindow]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClosed caption lines overlap
jer.noble@apple.com [Wed, 1 May 2013 17:38:56 +0000 (17:38 +0000)]
Closed caption lines overlap
https://bugs.webkit.org/show_bug.cgi?id=115438
<rdar://problem/13351747>

Reviewed by Eric Carlson.

Take the line-box padding into account when determining line hight by setting
the -webkit-line-box-contain property to include 'inline-box'.

* css/mediaControls.css:
(video::-webkit-media-text-track-container):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBUILD FIX (r149410): CFRunLoopStop() doesn't know what to do with a RetainPtr<CFRunLo...
ddkilzer@apple.com [Wed, 1 May 2013 17:29:18 +0000 (17:29 +0000)]
BUILD FIX (r149410): CFRunLoopStop() doesn't know what to do with a RetainPtr<CFRunLoopRef>

Fixes the following build failure:

    WebCore/platform/cf/RunLoopCF.cpp:82:5: error: no matching function for call to 'CFRunLoopStop'
        CFRunLoopStop(m_runLoop);
        ^~~~~~~~~~~~~

* platform/cf/RunLoopCF.cpp:
(WebCore::RunLoop::stop): Call RetainPtr::get().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEventSource: Loss of reconnect time precision due to integer division
commit-queue@webkit.org [Wed, 1 May 2013 17:15:46 +0000 (17:15 +0000)]
EventSource: Loss of reconnect time precision due to integer division
https://bugs.webkit.org/show_bug.cgi?id=115358

Source/WebCore:

Make sure precision is not lost when converting the reconnect time from milliseconds to seconds.

Patch by Per-Erik Brodin <per-erik.brodin@ericsson.com> on 2013-05-01
Reviewed by Alexey Proskuryakov.

Test: http/tests/eventsource/eventsource-retry-precision.html

* page/EventSource.cpp:
(WebCore::EventSource::scheduleReconnect):

LayoutTests:

Patch by Per-Erik Brodin <per-erik.brodin@ericsson.com> on 2013-05-01
Reviewed by Alexey Proskuryakov.

* http/tests/eventsource/eventsource-retry-precision-expected.txt: Added.
* http/tests/eventsource/eventsource-retry-precision.html: Added.
* http/tests/eventsource/resources/precise-retry.asis: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r149287): Assertion failure in fast/frames/flattening/iframe-flattening...
akling@apple.com [Wed, 1 May 2013 16:55:59 +0000 (16:55 +0000)]
REGRESSION(r149287): Assertion failure in fast/frames/flattening/iframe-flattening-crash.html
<http://webkit.org/b/115386>
<rdar://problem/13769995>

Reviewed by Antti Koivisto.

Only send synchronous resize events for the main frame. Subframes change size during layout,
so it never really makes sense for them to use synchronous dispatch anyway.

* page/FrameView.cpp:
(WebCore::FrameView::dispatchResizeEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed trivial buildfix after r149432.
ossy@webkit.org [Wed, 1 May 2013 15:47:16 +0000 (15:47 +0000)]
Unreviewed trivial buildfix after r149432.

* testing/Internals.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149434 268f45cc-cd09-0410-ab3c-d52691b4dbfc