12 years ago2009-01-05 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 5 Jan 2009 21:33:53 +0000 (21:33 +0000)]
2009-01-05  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        Fix failing set-colors test.

        * fast/canvas/resources/set-colors.js: Change the CMYK test cases to use the
        black channel only.
        * fast/canvas/set-colors-expected.txt: Updated. The old version I checked in
        accidentally expected failure for the bug I fixed. Also need new results for
        the CMYK test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes QWebFrame::setScrollBarPolicy(..) to actually work. Also happens
treat@webkit.org [Mon, 5 Jan 2009 21:14:50 +0000 (21:14 +0000)]
Fixes QWebFrame::setScrollBarPolicy(..) to actually work.  Also happens
to fix 192 layout tests that were previously failing for Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig.
ap@webkit.org [Mon, 5 Jan 2009 19:53:57 +0000 (19:53 +0000)]
    Reviewed by Sam Weinig.

        Fix platforms that don't have Workers enabled.

        * platform/ThreadGlobalData.cpp: (WebCore::threadGlobalData): Create ThreadGlobalData in
        two stages, so that EventNames constructor can access the just-created atomic string table.
        This matches what happens in ThreadSpecific case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin@apple.com [Mon, 5 Jan 2009 19:50:37 +0000 (19:50 +0000)]

2009-01-05  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23109: REGRESSION: Backwards search in a long document matches incorrectly

        Test: fast/text/find-backwards.html

        * editing/TextIterator.cpp:
        (WebCore::SearchBuffer::append): Fix incorrect size passed to memcpy.
        (WebCore::SearchBuffer::search): Handle case where we have an empty buffer but
        we're at a break; must not try to search because ICU will give us an error.
        Fix incorrect size passed to memcpy and memmove.
        (WebCore::findPlainText): Fix case where we found a match and need to search
        again because we want to find the last match. We need to try again without
        adding any more text or handling the break before moving on.


2009-01-05  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23109: REGRESSION: Backwards search in a long document matches incorrectly

        * fast/text/find-backwards-expected.txt: Added.
        * fast/text/find-backwards.html: Added.
        * fast/text/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
        * fast/text/resources/find-backwards.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Qt build
treat@webkit.org [Mon, 5 Jan 2009 19:45:05 +0000 (19:45 +0000)]
Fix the Qt build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Suggested by Dave Levin.
ap@webkit.org [Mon, 5 Jan 2009 19:13:09 +0000 (19:13 +0000)]
    Suggested by Dave Levin.

        Mac release build fix.

        * WebCore.base.exp: Remove ThreadGlobalData::eventNames(), which is now inline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-05 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 5 Jan 2009 18:24:12 +0000 (18:24 +0000)]
2009-01-05  Darin Adler  <darin@apple.com>

        * dom/Document.cpp: Fix build. Oops again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-05 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 5 Jan 2009 18:19:52 +0000 (18:19 +0000)]
2009-01-05  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        Fix hang whenever following an anchor.

        * dom/Document.cpp:
        (WebCore::Document::findAnchor): Oops!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Mon, 5 Jan 2009 18:13:05 +0000 (18:13 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/6471129> Workers crash on Windows Release builds

        * wtf/ThreadSpecific.h:
        (WTF::ThreadSpecific::destroy): Changed to clear the pointer only after data object
        destruction is finished - otherwise, WebCore::ThreadGlobalData destructor was re-creating
        the object in order to access atomic string table.
        (WTF::ThreadSpecific::operator T*): Symmetrically, set up the per-thread pointer before
        data constructor is called.

        * wtf/ThreadingWin.cpp: (WTF::wtfThreadEntryPoint): Remove a Windows-only hack to finalize
        a thread - pthreadVC2 is a DLL, so it gets thread detached messages, and cleans up thread
        specific data automatically. Besides, this code wasn't even compiled in for some time now.

        * platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::ThreadGlobalData):
        * platform/ThreadGlobalData.h: (WebCore::ThreadGlobalData::eventNames):
        Now that ThreadSpecific sets up the pointer before invoking data constructor, we can
        initialize EventNames right away.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-05 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 5 Jan 2009 17:32:03 +0000 (17:32 +0000)]
2009-01-05  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        Bug 23106: HTMLFormCollection::namedItem ignores caseSensitive argument

        This led me to a bunch of dead code. It turns out that HTML collections
        were carrying the case-insensitive code just so they could be used to
        find anchors, something we can do more simply and efficiently without
        creating a DOM HTMLCollection object.

        No behavior change. Just adding a new function findAnchor function and
        removing some dead code.

        * dom/Document.cpp:
        (WebCore::Document::findAnchor): Added.
        * dom/Document.h: Ditto.

        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::accessKey): Take and return AtomicString
        references for better efficiency.
        (WebCore::HTMLAnchorElement::setAccessKey): Ditto.
        (WebCore::HTMLAnchorElement::charset): Ditto.
        (WebCore::HTMLAnchorElement::setCharset): Ditto.
        (WebCore::HTMLAnchorElement::coords): Ditto.
        (WebCore::HTMLAnchorElement::setCoords): Ditto.
        (WebCore::HTMLAnchorElement::setHref): Ditto.
        (WebCore::HTMLAnchorElement::hreflang): Ditto.
        (WebCore::HTMLAnchorElement::setHreflang): Ditto.
        (WebCore::HTMLAnchorElement::name): Ditto.
        (WebCore::HTMLAnchorElement::setName): Ditto.
        (WebCore::HTMLAnchorElement::rel): Ditto.
        (WebCore::HTMLAnchorElement::setRel): Ditto.
        (WebCore::HTMLAnchorElement::rev): Ditto.
        (WebCore::HTMLAnchorElement::setRev): Ditto.
        (WebCore::HTMLAnchorElement::shape): Ditto.
        (WebCore::HTMLAnchorElement::setShape): Ditto.
        (WebCore::HTMLAnchorElement::setTarget): Ditto.
        (WebCore::HTMLAnchorElement::type): Ditto.
        (WebCore::HTMLAnchorElement::setType): Ditto.
        * html/HTMLAnchorElement.h: Ditto.

        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::checkForNameMatch): Changed argument to an
        AtomicString and removed the caseSensitive boolean, since we're now always
        case sensitive.
        (WebCore::HTMLCollection::namedItem): Ditto.
        (WebCore::HTMLCollection::nextNamedItem): Ditto.
        * html/HTMLCollection.h: Ditto.
        * html/HTMLFormCollection.cpp:
        (WebCore::HTMLFormCollection::getNamedItem): Ditto.
        (WebCore::HTMLFormCollection::getNamedFormItem): Ditto.
        (WebCore::HTMLFormCollection::nextNamedItemInternal): Ditto.
        (WebCore::HTMLFormCollection::namedItem): Ditto.
        (WebCore::HTMLFormCollection::nextNamedItem): Ditto.
        * html/HTMLFormCollection.h: Ditto.
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::namedItem): Ditto.
        * html/HTMLSelectElement.h: Ditto.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::gotoAnchor): Use the new findAnchor function.
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::internalLinkElement): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin@apple.com [Mon, 5 Jan 2009 17:29:22 +0000 (17:29 +0000)]

2009-01-05  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        Bug 23104: minor mistakes in init functions for animation and transition events

        Test: fast/events/init-events.html

        Also fixed two StorageEvent problems the test case uncovered:

            Made document.createEvent("StorageEvent") work.
            Allow null values for StorageEvent.oldValue and StorageEvent.newValue.

        * dom/Document.cpp:
        (WebCore::Document::createEvent): Sorted alphabetically by the name of the event
        class. Added StorageEvent.

        * dom/UIEvent.idl: Fixed typo in a comment.

        * dom/WebKitAnimationEvent.cpp:
        (WebCore::WebKitAnimationEvent::initWebKitAnimationEvent): Use all the arguments.
        * dom/WebKitTransitionEvent.cpp:
        (WebCore::WebKitTransitionEvent::initWebKitTransitionEvent): Ditto.

        * storage/StorageEvent.idl: Use the ConvertNullToNullString keyword on the
        arguments to initStorageEvent so it can create events with null values for the
        oldValue and newValue, just like the real storage events. Note that the properties
        already had ConvertNullStringTo=Null, so this is just the other half of that.


2009-01-05  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        Bug 23104: minor mistakes in init functions for animation and transition events

        * fast/events/init-events-expected.txt: Added.
        * fast/events/init-events.html: Added.
        * fast/events/resources/init-events.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-05 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 5 Jan 2009 17:26:53 +0000 (17:26 +0000)]
2009-01-05  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        Bug 23102: turn on unused parameter warnings in WebCore

        First step: Fix the simple cases where we can just remove an argument name.
        Also made a few more things protected and private.

        * many files

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Mon, 5 Jan 2009 17:21:13 +0000 (17:21 +0000)]
    Reviewed by Darin Adler.

        Create a version of ASSERT for use with otherwise unused variables

        * wtf/Assertions.h: Added ASSERT_UNUSED.

        * jit/ExecutableAllocatorPosix.cpp:
        * runtime/Collector.cpp:
        * runtime/JSNotAnObject.cpp:
        * wtf/TCSystemAlloc.cpp:
        Use it in some places that used other idioms for this purpose.

        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::verifySchemaVersion): Use the new ASSERT_UNUSED macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Non-Mac build fix.
ap@webkit.org [Mon, 5 Jan 2009 17:18:28 +0000 (17:18 +0000)]
    Non-Mac build fix.

        * loader/appcache/ApplicationCacheStorage.cpp: Include wtf/StringExtras.h for snprintf.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove unnecessary methods from EmptyFrameLoaderClient
treat@webkit.org [Mon, 5 Jan 2009 17:15:06 +0000 (17:15 +0000)]
Remove unnecessary methods from EmptyFrameLoaderClient

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Mon, 5 Jan 2009 08:55:40 +0000 (08:55 +0000)]
    Reviewed by Darin Adler.

        Make application cache use SQLite built-in user_version

        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::verifySchemaVersion): Changed to track versions with
        PRAGMA user_version.

        * loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::):
        Used the occasion to get rid of the hole in bitmask that was a leftover from opportunistic
        cache entries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-04 David Smith <catfish.man@gmail.com>
dsmith@webkit.org [Mon, 5 Jan 2009 08:39:12 +0000 (08:39 +0000)]
2009-01-04  David Smith  <catfish.man@gmail.com>

        Reviewed by Oliver Hunt.

        Avoid redundant AtomicString conversions

        * dom/Node.cpp:
        (WebCore::Node::getElementsByTagName): Pass starAtom instead of "*"
        (WebCore::Node::getElementsByTagNameNS): Take an AtomicString for the namespace URI
        (WebCore::Node::isDefaultNamespace): Ditto
        (WebCore::Node::lookupPrefix): Ditto
        (WebCore::Node::lookupNamespacePrefix): Ditto
        * dom/Node.h: Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin@apple.com [Mon, 5 Jan 2009 07:25:22 +0000 (07:25 +0000)]

2009-01-04  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        Bug 23105: canvas setFillColor function ignores alpha argument

        Test: fast/canvas/set-colors.html

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::setFillColor): Pass alpha value through instead
        of ignoring it and always passing 1.

        * html/CanvasStyle.cpp:
        (WebCore::CanvasStyle::applyStrokeColor): Fix spelling of transparent in comments.
        (WebCore::CanvasStyle::applyFillColor): Ditto.


2009-01-04  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        Bug 23105: canvas setFillColor function ignores alpha argument

        * fast/canvas/resources/set-colors.js: Added.
        * fast/canvas/set-colors-expected.txt: Added.
        * fast/canvas/set-colors.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-04 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 5 Jan 2009 05:41:10 +0000 (05:41 +0000)]
2009-01-04  Darin Adler  <darin@apple.com>

        Bug 23086: REGRESSION(r39540/r39541): Windows build fails due to ICU errors

        * editing/TextIterator.cpp: Check UCONFIG_NO_COLLATION and don't compile
        in the new search path if it's 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-04 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Mon, 5 Jan 2009 00:18:53 +0000 (00:18 +0000)]
2009-01-04  Alice Liu  <alice.liu@apple.com>

        <rdar://problem/6341776> Merge m_transitionCount and m_offset in Structure.

        Reviewed by Darin Adler.

        * runtime/Structure.cpp:
        (JSC::Structure::Structure): Remove m_transitionCount
        (JSC::Structure::addPropertyTransitionToExistingStructure): No need to wait until after the assignment to offset to assert if it's notFound; move it up.
        (JSC::Structure::addPropertyTransition): Use method for transitionCount instead of m_transitionCount. Remove line that maintains the m_transitionCount.
        (JSC::Structure::changePrototypeTransition): Remove line that maintains the m_transitionCount.
        (JSC::Structure::getterSetterTransition): Remove line that maintains the m_transitionCount.
        * runtime/Structure.h:
        Changed s_maxTransitionLength and m_offset from size_t to signed char.  m_offset will never become greater than 64
        because the structure transitions to a dictionary at that time.
        (JSC::Structure::transitionCount): method to replace the data member

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Don't install internal headers in WebKit framework
ddkilzer@apple.com [Sun, 4 Jan 2009 21:09:57 +0000 (21:09 +0000)]
    Don't install internal headers in WebKit framework

        Reviewed by Darin Adler.


        * WebKit.xcodeproj/project.pbxproj: Remove roles from internal
        headers so they're not installed.


        Since WebHTMLRepresentationInternal.h and WebTypesInternal.h are
        no longer installed in WebKit.framework/PrivateHeaders, use the
        special relationship of DumpRenderTree within the WebKit source
        tree to include the internal headers through relative paths.
        Created the concept of mac/InternalHeaders to hide the ugly

        * DumpRenderTree/mac/Configurations/Base.xcconfig: Added
        mac/InternalHeaders to HEADER_SEARCH_PATHS.
        * DumpRenderTree/mac/InternalHeaders/WebKit/WebHTMLRepresentationInternal.h: Added.
        * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed change log entry dates.
mitz@apple.com [Sun, 4 Jan 2009 20:14:24 +0000 (20:14 +0000)]
Fixed change log entry dates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Don't install *.idl and *.in files as resources
ddkilzer@apple.com [Sun, 4 Jan 2009 19:57:23 +0000 (19:57 +0000)]
    Don't install *.idl and *.in files as resources

        Reviewed by Oliver Hunt.

        Don't install these files as resources in the WebCore framework:
        - WMLAttributeNames.in
        - WMLTagNames.in
        - WorkerContext.idl
        - WorkerLocation.idl
        - WorkerNavigator.idl

        * WebCore.xcodeproj/project.pbxproj: Removed resources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sun, 4 Jan 2009 19:10:35 +0000 (19:10 +0000)]
2009-01-04  Simon Fraser  <simon.fraser@apple.com>

        Fix the expected image to account for a typo fix done on 2008-12-23.

        * platform/mac/fast/transforms/identity-matrix-expected.checksum:
        * platform/mac/fast/transforms/identity-matrix-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sun, 4 Jan 2009 18:38:35 +0000 (18:38 +0000)]
2009-01-04  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler


        If an object gets a Layout hint, and the style change will result in
        the creation of a RenderLayer, then we need to repaint the old position
        of the object. This was done for transform, but we have to test opacity too.

        Test: fast/repaint/create-layer-repaint.html

        * rendering/RenderObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-04 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 4 Jan 2009 18:24:38 +0000 (18:24 +0000)]
2009-01-04  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23103: Safari's auto-fill no longer works for <select> elements

        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLSelectElement _activateItemAtIndex:]): Implemented this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed change log entry dates.
darin@apple.com [Sun, 4 Jan 2009 18:23:56 +0000 (18:23 +0000)]
Fixed change log entry dates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-04 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 4 Jan 2009 18:00:58 +0000 (18:00 +0000)]
2009-01-04  Darin Adler  <darin@apple.com>

        Reviewed by David Kilzer.

        Bug 15114: Provide compile-time assertions for sizeof(UChar), sizeof(DeprecatedChar), etc.

        * wtf/unicode/Unicode.h: Assert size of UChar. There is no DeprecatedChar any more.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd new API to QWebHitTestResult to return a rect for the smallest enclosing
treat@webkit.org [Sun, 4 Jan 2009 17:39:25 +0000 (17:39 +0000)]
Add new API to QWebHitTestResult to return a rect for the smallest enclosing
block element of the hit test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake the apple windows port build with the new fixedLayoutSize feature
treat@webkit.org [Sun, 4 Jan 2009 17:28:48 +0000 (17:28 +0000)]
Make the apple windows port build with the new fixedLayoutSize feature

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake the gtk port build with the new fixedLayoutSize feature
treat@webkit.org [Sun, 4 Jan 2009 17:26:01 +0000 (17:26 +0000)]
Make the gtk port build with the new fixedLayoutSize feature

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake the qt port build and work with the new fixedLayoutSize feature
treat@webkit.org [Sun, 4 Jan 2009 17:25:53 +0000 (17:25 +0000)]
Make the qt port build and work with the new fixedLayoutSize feature

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd fixedLayoutSize feature to ScrollView to allow for controlling the
treat@webkit.org [Sun, 4 Jan 2009 17:25:30 +0000 (17:25 +0000)]
Add fixedLayoutSize feature to ScrollView to allow for controlling the
layout beyond the constraint of the current viewports dynamic size

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-04 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 4 Jan 2009 14:26:01 +0000 (14:26 +0000)]
2009-01-04  Darin Adler  <darin@apple.com>

        Suggested by Dan Bernstein.

        * platform/mac/editing/selection/move-left-right-expected.txt: Remove WARNING lines that are no
        longer showing up. Dan said he didn't know why we were seeing those before and why they're gone
        now, but it's good that they're gone.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-03 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 4 Jan 2009 14:12:53 +0000 (14:12 +0000)]
2009-01-03  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23095: REGRESSION: fast/text/find-case-folding.html regression test failing when ICU used for text search

        * fast/text/find-case-folding.html: Work around this ICU bug in the test for now.
        Later we might want to work around it in our search code instead, or in addition,
        if we can figure out how to do that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-03 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 4 Jan 2009 06:19:44 +0000 (06:19 +0000)]
2009-01-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Change the pcVector from storing native code pointers to storing offsets
        from the base pointer. This will allow us to generate the pcVector on demand
        for exceptions.

        * bytecode/CodeBlock.h:
        * jit/JIT.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Bug 23091: Some webarchive http tests intermittently fail due to Connection...
ddkilzer@apple.com [Sun, 4 Jan 2009 03:22:53 +0000 (03:22 +0000)]
    Bug 23091: Some webarchive http tests intermittently fail due to Connection/Keep-Alive header differences


        Reviewed by Darin Adler.


        * DumpRenderTree/mac/DumpRenderTree.mm:
        (normalizeHTTPResponseHeaderFields): Remove Keep-Alive and
        Connection headers from webarchive results.


        Updated test results after removing Keep-Alive and Connection
        headers from webarchive tests.

        * http/tests/webarchive/test-css-url-encoding-expected.webarchive:
        * http/tests/webarchive/test-css-url-encoding-shift-jis-expected.webarchive:
        * http/tests/webarchive/test-css-url-encoding-utf-8-expected.webarchive:
        * http/tests/webarchive/test-preload-resources-expected.webarchive:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] Fix the reference counting of WebKitWebFrames
zecke@webkit.org [Sat, 3 Jan 2009 19:52:56 +0000 (19:52 +0000)]
[GTK] Fix the reference counting of WebKitWebFrames

The ownership is the following: WebKitWebView owns a WebCore::Page.
WebKitWebView is creating one WebKitWebFrame which will be the
mainFrame of the WebCore::Page (having the reference on the Frame).

The FrameLoaderClient has the reference of the WebKitWebFrame for
the main frame and also any other frame. This means when the
WebCore::Frame goes away the FrameLoaderClient will go away which
will normally remove the last reference of the WebKitWebFrame. Because
an API user might have g_object_ref'ed the WebKitWebFrame null
checks had to be added to WebKitWebFrame.

For WebCore::Frames created by the FrameLoaderClient the ownership
will be passed down to the FrameTree, the WebKitWebFrame is not holding
a reference to the WebCore::Frame.

Do not g_object_unref the mainFrame in the destructor of the
WebKitWebFrame as this will happen from within the WebCore::Page
destruction. Do not hold a reference to the WebCore::Frame (circle) in
WebKitWebFrame, add null checks as the WebCore::Frame might have gone
away. Do not keep track of the FrameLoaderClient in the private
structures as it was mostly unusued.


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
rwlbuis@webkit.org [Sat, 3 Jan 2009 16:48:24 +0000 (16:48 +0000)]
    Reviewed by Darin.

        SVG elements that are moved are nor fully invalidated/earsed

        Mark the SVG root as needing a layout when its position changes.

        Tests: svg/custom/circle-move-invalidation.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix.
sfalken@apple.com [Sat, 3 Jan 2009 08:21:52 +0000 (08:21 +0000)]
    Build fix.

        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix.
oliver@apple.com [Sat, 3 Jan 2009 05:23:26 +0000 (05:23 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix. Include FrameState.h
oliver@apple.com [Sat, 3 Jan 2009 04:36:40 +0000 (04:36 +0000)]
Build fix. Include FrameState.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix. Include FrameState.h
zecke@webkit.org [Sat, 3 Jan 2009 03:08:13 +0000 (03:08 +0000)]
Build fix. Include FrameState.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-02 Cary Clark <caryclark@google.com>
darin@apple.com [Sat, 3 Jan 2009 02:35:55 +0000 (02:35 +0000)]
2009-01-02  Cary Clark  <caryclark@google.com>

        Reviewed and landed by Darin Adler.

        Bug 22963: write icons before reading them

        Reverse the order in the icon database main thread loop to
        write the pending icons to the database before trying
        to read any requested icons. This ensures that a requested icon
        has the correct data when read.

        * loader/icon/IconDatabase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-02 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 3 Jan 2009 02:33:11 +0000 (02:33 +0000)]
2009-01-02  Darin Adler  <darin@apple.com>

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadItem): One small thing I forgot in my last check-in.
        This cuts down on the number of hash table operations during loading.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-02 Dmitry Titov <dimich@chromium.org>
darin@apple.com [Sat, 3 Jan 2009 02:27:33 +0000 (02:27 +0000)]
2009-01-02  Dmitry Titov  <dimich@chromium.org>

        Reviewed and landed by Darin.

        DOMTimer lifetime cleanup: timeoutMap methods on Document now do not delete the timer.
        Instead, all 3 places that delete timers do it directly calling 'delete' and then timer's dtor removes the ID from the timeoutMap.
        Note that in case the context is destroyed and timers are deleted at once, the check in ~DOMTimer() prevents
        unnecessary HashMap remove in case the Document is being destroyed.

        * bindings/js/DOMTimer.cpp:
        (WebCore::DOMTimer::~DOMTimer): removes the id from the timeoutMap.
        (WebCore::DOMTimer::removeById): simply uses 'delete this'.
        (WebCore::DOMTimer::fired): same.
        (WebCore::DOMTimer::contextDestroyed): same.
        * dom/Document.cpp:
        (WebCore::Document::removeTimeout): now it only removes the id from the map, does not delete the timer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin@apple.com [Sat, 3 Jan 2009 02:04:30 +0000 (02:04 +0000)]

2009-01-02  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears
        inside its web view when resizing its window

        The first attempt at fixing this did not work.
        This time I was able to reproduce the bug and test the fix.

        Bug 11212: REGRESSION: Activity window doesn't always list all files until refresh

        I had to fix this second bug because otherwise the WebKit code to trigger the first
        fix didn't run.

        Also fixes memory use that kept growing as we maintained a set of all URLs loaded in
        a particular frame. Bad idea! It's bad enough that we do it for each document, but
        the old version kept the set around forever as you moved from one document to the next.

        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::parseMappedAttribute): Change this so that we allow
        turning off scrolling when the quirk is enabled. We just don't allow turning it on.
        This fixes one of the two problems with the initial patch; the other fix is in WebKit.

        * loader/DocumentLoader.h: Moved didTellClientAboutLoad and haveToldClientAboutLoad
        here from FrameLoader. The old way meant that a given frame would forever remember
        the URL of any resources loaded in that frame and never send any "loaded from cache"
        client calls about those URLs.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadResourceSynchronously): Removed call to didTellCientAboutLoad.
        This is now handled by dispatchWillSendRequest, which is safer since that's the actual
        function that tells the client about the load.
        (WebCore::FrameLoader::loadedResourceFromMemoryCache): Changed calls to
        haveToldClientAboutLoad and didTellClientAboutLoad to call the document loader.
        Also removed the call in the case where we don't load from the cache, since
        dispatchWillSendRequest now takes care of it.
        (WebCore::FrameLoader::dispatchWillSendRequest): Put calls to didTellClientAboutLoad
        here. Call it both on the URL we pass in and the URL the client returns; we won't
        tell the client about either if it's loaded from the memory cache.

        * loader/FrameLoader.h: Removed didTellClientAboutLoad, haveToldClientAboutLoad, and

        * loader/SubresourceLoader.cpp: Removed unneeded load function that called
        didTellClientAboutLoad. That's now taken care of in dispatchWillSendRequest.

        * loader/SubresourceLoader.h: Removed load function. Also made all members private
        except for create and clearClient.


2009-01-02  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears
        inside its web view when resizing its window

        The first attempt at fixing this did not work.
        This time I was able to reproduce the bug and test the fix.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (applyAppleDictionaryApplicationQuirkNonInlinePart): Changed the arguments and
        function names around a bit to make even less code at the call site.
        (applyAppleDictionaryApplicationQuirk): Put the check for whether this is the
        Dictionary application in here.
        (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): Put a call to
        applyAppleDictionaryApplicationQuirk here. This was a case I had missed before,
        when the script is cached. This fixes one of the two problems with the initial
        patch; the other fix is in WebCore.
        (WebFrameLoaderClient::dispatchWillSendRequest): Changed the
        applyAppleDictionaryApplicationQuirk call here to work the new simpler way.

        * WebView/WebView.mm: Had to add an include due to changes in WebCore header includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSet the svn:mime-type property of recently-added PNG files to image/png.
mitz@apple.com [Sat, 3 Jan 2009 01:13:34 +0000 (01:13 +0000)]
Set the svn:mime-type property of recently-added PNG files to image/png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 3 Jan 2009 01:06:11 +0000 (01:06 +0000)]
2009-01-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler


        Fix GIF animation by ensuring that the signature of
        startAnimation() in the base class matches the method in BitmapImage.

        Test: fast/backgrounds/animated-gif-as-background.html

        * platform/graphics/Image.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
dsmith@webkit.org [Sat, 3 Jan 2009 00:25:59 +0000 (00:25 +0000)]

2009-01-02  David Smith  <catfish.man@gmail.com>

        Reviewed by Darin Adler.

        Enable NodeList caching for getElementsByTagName

        * wtf/HashFunctions.h: Moved the definition of PHI here and renamed to stringHashingStartValue


2009-01-02  David Smith  <catfish.man@gmail.com>

        Reviewed by Darin Adler.

        Enable NodeList caching for getElementsByTagName

        test: fast/dom/getelementsbytagnamens-mixed-namespaces.html

        * dom/Document.cpp:
        (WebCore::FormElementKeyHash::hash): Use WTF::stringHashingStartValue
        * dom/Node.cpp:
        (WebCore::Node::getElementsByTagNameNS): Ensure rare data and add a node list cache
        (WebCore::NodeListsNodeData::invalidateCaches): Invalidate the tag name node list cache as well as the others
        (WebCore::NodeListsNodeData::isEmpty): Check the tag name node list cache as well as the others
        * dom/NodeRareData.h: Add m_tagNodeListCaches
        * dom/QualifiedName.cpp:
        * dom/QualifiedName.h: Move QNameHash to the header, make it work on QualifiedNames, and rename to QualifiedNameHash
        * dom/StyledElement.cpp:
        (WebCore::MappedAttributeHash::hash): Use WTF::stringHashingStartValue
        * dom/TagNodeList.cpp:
        (WebCore::TagNodeList::TagNodeList): Add a NodeList cache argument
        * dom/TagNodeList.h:
        (WebCore::TagNodeList::create): Add a NodeList cache argument
        * platform/text/StringHash.h:
        (WebCore::CaseFoldingHash::hash): Use WTF::stringHashingStartValue
        * platform/text/TextEncodingRegistry.cpp:
        (WebCore::TextEncodingNameHash::hash): Use WTF::stringHashingStartValue


2009-01-02  David Smith  <catfish.man@gmail.com>

        Reviewed by Darin Adler.

        Enable NodeList caching for getElementsByTagName

        * fast/dom/getelementsbytagnamens-mixed-namespaces-expected.txt: Added.
        * fast/dom/getelementsbytagnamens-mixed-namespaces.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-02 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Sat, 3 Jan 2009 00:02:01 +0000 (00:02 +0000)]
2009-01-02  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23066 & <rdar://problem/6028417>
        Full Page Zoom: a <video> element that doesn't include width/height attribute does not scale

        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::calcReplacedWidth): Multiply aspect ratio width by style()->effectiveZoom()
        (WebCore::RenderVideo::calcReplacedHeight): Multiply aspect ratio height by style()->effectiveZoom()

2009-01-02  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=23066 & <rdar://problem/6028417>
        Full Page Zoom: a <video> element that doesn't include width/height attribute does not scale

        Add test for <video> zoom with and without width/height attributes

        * media/video-zoom.html: Added.
        * platform/mac/media/video-zoom-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago BUILD FIX (r39552): Add mediaControls.css to other build files
ddkilzer@apple.com [Fri, 2 Jan 2009 22:19:02 +0000 (22:19 +0000)]
    BUILD FIX (r39552): Add mediaControls.css to other build files

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Try to fix Wx build after r39427
ddkilzer@apple.com [Fri, 2 Jan 2009 21:52:41 +0000 (21:52 +0000)]
    Try to fix Wx build after r39427

        * platform/graphics/wx/PathWx.cpp:
        (WebCore::Path::strokeBoundingRect): Added stub.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adele Peterson.
ap@webkit.org [Fri, 2 Jan 2009 21:47:00 +0000 (21:47 +0000)]
    Reviewed by Adele Peterson.

        <rdar://problem/6471356> Failed assertion on quit

        * platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::~ThreadGlobalData):
        Only assert that empty string are all removed on secondary threads.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Attempt to fix Qt Linux build after r39553
ddkilzer@apple.com [Fri, 2 Jan 2009 21:25:17 +0000 (21:25 +0000)]
    Attempt to fix Qt Linux build after r39553

        * wtf/RandomNumberSeed.h: Include <sys/time.h> for gettimeofday().
        Include <sys/types.h> and <unistd.h> for getpid().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 2 Jan 2009 21:22:29 +0000 (21:22 +0000)]
2009-01-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        Use an OwnPtr for m_chromeClient.

        * svg/graphics/SVGImage.cpp:
        * svg/graphics/SVGImage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Bug 23081: These files are no longer part of the KDE libraries
ddkilzer@apple.com [Fri, 2 Jan 2009 21:10:30 +0000 (21:10 +0000)]
    Bug 23081: These files are no longer part of the KDE libraries


        Reviewed by Darin Adler.

        Removed "This file is part of the KDE libraries" comment from
        source files.  Added or updated Apple copyrights as well.


        * parser/Lexer.h:
        * wtf/HashCountedSet.h:
        * wtf/RetainPtr.h:
        * wtf/VectorTraits.h:


        No tests since there are only changes to comments.

        * bridge/testbindings.cpp:
        * html/HTMLEntityNames.gperf:
        * loader/Cache.h:
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedResourceClient.h:
        * loader/CachedResourceClientWalker.cpp:
        * loader/CachedResourceClientWalker.h:
        * loader/CachedScript.cpp:
        * loader/CachedScript.h:
        * loader/CachedXBLDocument.cpp:
        * loader/CachedXBLDocument.h:
        * loader/CachedXSLStyleSheet.cpp:
        * loader/CachedXSLStyleSheet.h:
        * rendering/GapRects.h:
        * xml/XMLSerializer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 2 Jan 2009 21:04:27 +0000 (21:04 +0000)]
2009-01-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler


        Repaints inside of an SVGImage were thrown on the floor,
        which broke incremental painting due to loading, or SVG animation.
        Fix this by assigning the SVGImage a ChromeClient subclass that passes
        along repaints via a new method on ImageObserver, which also takes
        a rect parameter for the changed rect, allowing incremental repaints.
        Fix RenderImage::imageChanged to take advantage of this changedRect to
        only repaint the changed parts of the image.

        This also enables incremental painting for canvas-as-image, so
        add tests for that too.

        Tests: fast/backgrounds/animated-svg-as-background.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Bug 23080: Remove last vestiges of KJS references
ddkilzer@apple.com [Fri, 2 Jan 2009 20:59:17 +0000 (20:59 +0000)]
    Bug 23080: Remove last vestiges of KJS references


        Reviewed by Darin Adler.

        Also updated Apple copyright statements.

        * DerivedSources.make: Changed bison "kjsyy" prefix to "jscyy".
        * GNUmakefile.am: Ditto.
        * JavaScriptCore.pri: Ditto.  Also changed KJSBISON to JSCBISON
        and kjsbison to jscbison.

        * JavaScriptCoreSources.bkl: Changed JSCORE_KJS_SOURCES to
        * jscore.bkl: Ditto.

        * create_hash_table: Updated copyright and removed old comment.

        * parser/Grammar.y: Changed "kjsyy" prefix to "jscyy" prefix.
        * parser/Lexer.cpp: Ditto.  Also changed KJS_DEBUG_LEX to
        * parser/Parser.cpp: Ditto.

        * pcre/dftables: Changed "kjs_pcre_" prefix to "jsc_pcre_".
        * pcre/pcre_compile.cpp: Ditto.
        * pcre/pcre_exec.cpp: Ditto.
        * pcre/pcre_internal.h: Ditto.
        * pcre/pcre_tables.cpp: Ditto.
        * pcre/pcre_ucp_searchfuncs.cpp: Ditto.
        * pcre/pcre_xclass.cpp: Ditto.

        * runtime/Collector.h: Updated header guards using the
        clean-header-guards script.
        * runtime/CollectorHeapIterator.h: Added missing header guard.
        * runtime/Identifier.h: Updated header guards.
        * runtime/JSFunction.h: Fixed end-of-namespace comment.

        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::reset): Renamed "kjsprint" debug function
        to "jscprint".  Changed implementation method from
        globalFuncKJSPrint() to globalFuncJSCPrint().
        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::globalFuncJSCPrint): Renamed from globalFuncKJSPrint().
        * runtime/JSGlobalObjectFunctions.h: Ditto.

        * runtime/JSImmediate.h: Updated header guards.
        * runtime/JSLock.h: Ditto.
        * runtime/JSType.h: Ditto.
        * runtime/JSWrapperObject.h: Ditto.
        * runtime/Lookup.h: Ditto.
        * runtime/Operations.h: Ditto.
        * runtime/Protect.h: Ditto.
        * runtime/RegExp.h: Ditto.
        * runtime/UString.h: Ditto.

        * tests/mozilla/js1_5/Array/regress-157652.js: Changed "KJS"
        reference in comment to "JSC".

        * wrec/CharacterClassConstructor.cpp: Change "kjs_pcre_" function
        prefixes to "jsc_pcre_".

        * wtf/unicode/Unicode.h: Change "KJS_" header guard to "WTF_".
        * wtf/unicode/icu/UnicodeIcu.h: Ditto.
        * wtf/unicode/qt4/UnicodeQt4.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake randomNumber generate 2^53 values instead of 2^32 (or 2^31 for rand() platforms)
oliver@apple.com [Fri, 2 Jan 2009 20:17:21 +0000 (20:17 +0000)]
Make randomNumber generate 2^53 values instead of 2^32 (or 2^31 for rand() platforms)

Reviewed by Maciej Stachowiak

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-02 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 2 Jan 2009 18:33:35 +0000 (18:33 +0000)]
2009-01-02  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler


        Pull media controls css out of html4.css into separate file. Don't generate
        wml, svg, or media css globals unless the feature is enabled.

        * DerivedSources.make:
            Don't include css for unused features.

        * WebCore.xcodeproj/project.pbxproj:
            include mediaControls.css

        * css/CSSStyleSelector.cpp:
            don't parse or add media css unless VIDEO feature is enabled and the target
            element is video or audio

        * css/html4.css:
            moved media controls css to mediaControls.css

        * css/mediaControls.css: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Remove declaration for JSC::Identifier::initializeIdentifierThreading()
ddkilzer@apple.com [Fri, 2 Jan 2009 18:11:54 +0000 (18:11 +0000)]
    Remove declaration for JSC::Identifier::initializeIdentifierThreading()

        Reviewed by Alexey Proskuryakov.

        * runtime/Identifier.h:
        (JSC::Identifier::initializeIdentifierThreading): Removed
        declaration since the implementation was removed in r34412.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Fri, 2 Jan 2009 17:44:27 +0000 (17:44 +0000)]
    Reviewed by Darin Adler.

        Add tests for application cache manifest parse failures

        * http/tests/appcache/resources/.htaccess:
        * http/tests/appcache/resources/wrong-content-type.manifest: Added.
        * http/tests/appcache/resources/wrong-signature.manifest: Added.
        * http/tests/appcache/wrong-content-type-expected.txt: Added.
        * http/tests/appcache/wrong-content-type.html: Added.
        * http/tests/appcache/wrong-signature-expected.txt: Added.
        * http/tests/appcache/wrong-signature.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-02 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Fri, 2 Jan 2009 15:18:11 +0000 (15:18 +0000)]
2009-01-02  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Darin Adler.

        Bug 23060: REGRESSION (r38629): Cannot scroll a WebHTMLView using Home/End/Page up/Page down

        After r38629, all keyboard events get sent by Editor to the EditorClient, even
        if the selection is not editable. If the event's command is unsupported by
        WebHTMLView, WebHTMLView mistakenly thinks that the event was handled when it
        was not. When using the page up / page down keys, the events generated are of
        the form scrollPageUp rather than movePageUp, so they are unsupported by
        WebHTMLView and cause this bug to occur.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView doCommandBySelector:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Fri, 2 Jan 2009 11:12:39 +0000 (11:12 +0000)]
    Reviewed by Darin Adler.

        Fix multiple issues with appcache online whitelist handling

        Test: http/tests/appcache/online-whitelist.html

        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::isURLInOnlineWhitelist): Test whitelist entries as prefixes,
        making it possible to use them for CGI invocation (as required by HTML5).

        * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
        Re-ordered checks, so that resources that are cached, but are also listed in online whitelist
        are loaded from the cache. This is required by HTML5, although Firefox doesn't match.

        * loader/appcache/ManifestParser.cpp:
        * loader/appcache/ManifestParser.h:
        * loader/appcache/ApplicationCache.h:
        * loader/appcache/ApplicationCacheStorage.cpp:
        Changed online whitelist to be a vector of URLs, which is better suited for the new algorithm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin@apple.com [Fri, 2 Jan 2009 09:27:08 +0000 (09:27 +0000)]

2009-01-02  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears inside its web view when resizing its window

        * WebCore.base.exp: Updated.
        * WebCore.xcodeproj/project.pbxproj: Mark HTMLHeadElement.h Private so it can be used in WebKit.

        * dom/Document.cpp:
        (WebCore::Document::Document): Initialize m_frameElementsShouldIgnoreScrolling to false.
        * dom/Document.h: Added setFrameElementsShouldIgnoreScrolling, frameElementsShouldIgnoreScrolling,
        and m_frameElementsShouldIgnoreScrolling.

        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::parseMappedAttribute): Don't allow changes to the scrolling attribute
        to affect the scrolling mode if frameElementsShouldIgnoreScrolling() returns true. This is only
        triggered on Mac OS X when running the Dictionary application.


2009-01-02  Darin Adler  <darin@apple.com>

        * StringsNotToBeLocalized.txt: Updated.


2009-01-02  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears inside its web view when resizing its window

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (isAppleDictionaryApplication): Added.
        (applyAppleDictionaryApplicationQuirk): Added. Under the right conditions, sets
        a flag to ask HTMLFrameElementBase to ignore the scrolling attribute.
        (WebFrameLoaderClient::dispatchWillSendRequest): Call the two functions above to
        apply the quirk when the relevant script is loaded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Fri, 2 Jan 2009 09:25:02 +0000 (09:25 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/6451666> Implement AppCache fallback entries (23036)

        Test: http/tests/appcache/fallback.html

        * loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously): Use fallback
        entries if normal loading fails.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache): Do not prevent normal
        loading for resources that match fallback namespaces - they are only loaded from the cache
        if that fails.
        (WebCore::DocumentLoader::getApplicationCacheFallbackResource): Get a fallback entry for
        resource from associated appcache, or from passed in one, if any.
        (WebCore::DocumentLoader::scheduleLoadFallbackResourceFromApplicationCache): If a fallback
        entry for resourse exists, add it to pending substitute loads.

        * loader/DocumentLoader.h: Added new functions for loading fallback data for resources.

        * loader/ResourceLoader.h:
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::scheduleLoadFallbackResourceFromApplicationCache): This function
        is called when normal loading fails (which includes network failures, 4xx and 5xx responses,
        and cross-origin redirects) to load appcache fallback data instead. It can use either the
        cache that is associated with the browsing context, or a custom one if association is yet
        to take place.
        (WebCore::ResourceLoader::willSendRequest): Try using fallback data.
        (WebCore::ResourceLoader::didReceiveResponse): Ditto.
        (WebCore::ResourceLoader::didFail): Ditto.

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::didReceiveResponse): Locate an appropriate cache and load
        fallback data from it if loading fails. The browsing context may still be associated with
        its previous document here, so the cache to load from must be passed explicitly.
        (WebCore::MainResourceLoader::didFail): Ditto.
        (WebCore::MainResourceLoader::load): Remove unnecessary check and FIXME.

        * loader/appcache/ApplicationCache.cpp:
        * loader/appcache/ApplicationCache.h:
        * loader/appcache/ApplicationCacheStorage.cpp:
        * loader/appcache/ApplicationCacheStorage.h:
        * loader/appcache/ApplicationCacheGroup.cpp:
        * loader/appcache/ApplicationCacheGroup.h:
        Implement fallback map saving and loading, pass it to the cache.

        * loader/appcache/ManifestParser.h: Use a correct data structure for fallback map - keys
        are matched by prefix, so HAshMap cannot be used.

        * loader/appcache/ManifestParser.cpp: (WebCore::parseManifest): Fix bugs in fallback section

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6450530> WebCore::FontPlatformData should not leak
oliver@apple.com [Fri, 2 Jan 2009 07:49:37 +0000 (07:49 +0000)]
<rdar://problem/6450530> WebCore::FontPlatformData should not leak

Reviewed by Dan Bernstein.

Whoops, previous patch should also have fixed the font referencing in
the constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6450530> WebCore::FontPlatformData should not leak
oliver@apple.com [Fri, 2 Jan 2009 07:46:05 +0000 (07:46 +0000)]
<rdar://problem/6450530> WebCore::FontPlatformData should not leak

Reviewed by Dan Bernstein.

Make sure we only adopt the new font, rather than re-referencing (and so leaking).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-01 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 2 Jan 2009 06:09:59 +0000 (06:09 +0000)]
2009-01-01  Darin Adler  <darin@apple.com>

        Add one more String.replace test case that I should have included in that last check-in.

        * fast/js/resources/string-replace-3.js: Added test case that covers more of the cases where
        $0-$99 are used but are actually valid.
        * fast/js/string-replace-3-expected.txt: Added new result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
darin@apple.com [Fri, 2 Jan 2009 05:56:54 +0000 (05:56 +0000)]

2009-01-01  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        String.replace does not support $& replacement metacharacter when search term is not a RegExp

        Test: fast/js/string-replace-3.html

        * runtime/StringPrototype.cpp:
        (JSC::substituteBackreferences): Added a null check here so we won't try to handle $$-$9
        backreferences when the search term is a string, not a RegExp. Added a check for 0 so we
        won't try to handle $0 or $00 as a backreference.
        (JSC::stringProtoFuncReplace): Added a call to substituteBackreferences.


2009-01-01  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        String.replace does not support $& replacement metacharacter when search term is not a RegExp

        * fast/js/resources/string-replace-3.js: Added test cases to cover replace with non-regexp and
        to cover "$0" and "$00".
        * fast/js/string-replace-3-expected.txt: Added new results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin@apple.com [Fri, 2 Jan 2009 04:47:05 +0000 (04:47 +0000)]

2009-01-01  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23071: REGRESSION (r39536): New test failures after committing patch in bug 23051 (ICU search)

        Also fix some things that Dan suggested during review of the ICU search patch that I forgot
        the first time around.

        * editing/TextIterator.cpp: Use ICU search on all platforms that use ICU, now that
        we've double checked it works everywhere, removing HAVE_ICU_SEARCH entirely.
        Removed unused m_atBreak data member from the non-ICU code path.
        (WebCore::TextIterator::TextIterator): Move null check up.
        (WebCore::TextIterator::handleTextBox): Fix mistake that made the iterator include
        collapsed whitespace. This was left over from an earlier version of the patch.
        Move null check up.


2009-01-01  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Turn on the regression test for ICU search on Mac OS X Tiger too.
        It was already on for Windows (by accident, failing), but now WebCore has been changed
        so it should work fine on all platforms using ICU, which includes both of those.

        * platform/mac-tiger/editing/execCommand: Removed.
        * platform/mac-tiger/editing/execCommand/findString-diacriticals-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-01 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 2 Jan 2009 03:06:10 +0000 (03:06 +0000)]
2009-01-01  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Darin Adler.

        Allow 32-bit integers to be stored in JSImmediates, on x64-bit.
        Presently the top 32-bits of a 64-bit JSImmediate serve as a sign extension of a 31-bit
        int stored in the low word (shifted left by one, to make room for a tag).  In the new
        format, the top 31-bits serve as a sign extension of a 32-bit int, still shifted left by

        The new behavior is enabled using a flag in Platform.h, 'WTF_USE_ALTERNATE_JSIMMEDIATE'.
        When this is set the constants defining the range of ints allowed to be stored as
        JSImmediate values is extended.  The code in JSImmediate.h can safely operate on either
        format.  This patch updates the JIT so that it can also operate with the new format.

        ~2% progression on x86-64, with & without the JIT, on sunspider & v8 tests.

        * assembler/MacroAssembler.h:
        * assembler/X86Assembler.h:
        * jit/JIT.cpp:
        * jit/JIT.h:
        * jit/JITArithmetic.cpp:
        * jit/JITInlineMethods.h:
        * runtime/JSImmediate.h:
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSet the svn:mime-type property of recently-added PNG files to image/png.
mitz@apple.com [Fri, 2 Jan 2009 02:21:07 +0000 (02:21 +0000)]
Set the svn:mime-type property of recently-added PNG files to image/png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-01 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 2 Jan 2009 02:07:01 +0000 (02:07 +0000)]
2009-01-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler, Oliver Hunt


        Enable incremental painting of canvas. This turns incremental painting
        back on, and fixes issues with stroke width and miters, calling willDraw()
        for strokeText and fillText, and taking shadows into account.

        Test: fast/canvas/canvas-incremental-repaint.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-12-29 Konstantin Käfer <kkaefer@gmail.com>
oliver@apple.com [Fri, 2 Jan 2009 01:08:20 +0000 (01:08 +0000)]
2008-12-29  Konstantin Käfer  <kkaefer@gmail.com>

        Reviewed by Tim Hatcher.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=17229
        <rdar://problem/5732829> Inspector should show properties of all JS objects in Console

        Prints objects not as plain text but makes them expandable so that
        they can be inspected.

        * inspector/front-end/Console.js:
        (): added a parameter "inline" to the WebInspector.Console._format function which indicates
            whether the object is printed in the context of another string (with console.log()) or
            as sole element.
        (.): objects and DOM nodes are now printed in an expandable form when they are printed alone
            (i.e. not in the context of a console.log() string) so that they can be inspected.
        * inspector/front-end/PropertiesSection.js:
        (WebInspector.PropertiesSection.prototype.set title): Allow DOM Nodes as title instead of strings
            in that case, the Node is inserted into the title instead of the string value of the passed
            object. This is used for displaying linkified titles, for example when inspecting DOM nodes,
            the syntax highlighted HTML representation is shown instead of the plain source code.
        * inspector/front-end/inspector.css: correct the offsetParent for the expandable object inspector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin@apple.com [Thu, 1 Jan 2009 21:19:59 +0000 (21:19 +0000)]

2009-01-01  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23051: web page searching should use ICU's search so it can ignore diacritical differences

        Test: editing/execCommand/findString-diacriticals.html

        * editing/TextIterator.cpp: Changed the CircularSearchBuffer class to have a new
        name, since it doesn't always use a circular buffer any more. Changed the interface
        so it can work well in the new chunky comparison mode for ICU search, and also
        added private data members for both the ICU-search and non-ICU-search code paths.
        (WebCore::TextIterator::TextIterator): Use the versions of the Range functions
        that don't take an exception code.
        (WebCore::TextIterator::handleTextBox): Added a special case to handle the position
        of a collapsed-away space better. This is not needed for search mechanism, but was
        helpful in an earlier version of this patch, and is still an improvement.
        (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Use the
        versions of the Range functions that don't take an exception code.
        (WebCore::CharacterIterator::range): Ditto.
        (WebCore::characterSubrange): Added. Helper function used in both places below where
        we want to convert a range and character offsets into a subrange.
        (WebCore::WordAwareIterator::advance): Use the versions of the Range functions that
        don't take an exception code.
        (WebCore::createSearcher): Added.
        (WebCore::searcher): Added.
        (WebCore::lockSearcher): Added.
        (WebCore::unlockSearcher): Added.
        (WebCore::SearchBuffer::SearchBuffer): Added.
        (WebCore::SearchBuffer::~SearchBuffer): Added.
        (WebCore::SearchBuffer::append): Added.
        (WebCore::SearchBuffer::atBreak): Added.
        (WebCore::SearchBuffer::reachedBreak): Added.
        (WebCore::SearchBuffer::search): Added.
        (WebCore::SearchBuffer::length): Added.
        (WebCore::TextIterator::subrange): Changed to call the characterSubrange
        function above.
        (WebCore::TextIterator::rangeFromLocationAndLength): Use the versions of the
        Range functions that don't take an exception code. Also tweak some other details
        of the code.
        (WebCore::isAllCollapsibleWhitespace): Added.
        (WebCore::collapsedToBoundary): Added.
        (WebCore::findPlainText): Rewrote to use new interface and streamline the
        logic a bit.

        Add the relevant files in the icu directory. As icu/README says, the "icu"
        directory is really just for Mac OS X, where we have the ICU library but not
        the headers installed. It should be moved inside platform/mac at some point
        to make this more clear (and the copy in JavaScriptCore should be moved
        somewhere similar for the same reason).

        * icu/unicode/ucoleitr.h: Added.
        * icu/unicode/usearch.h: Added.


2009-01-01  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23051: web page searching should use ICU's search so it can ignore diacritical differences

        Currently this is only activated on the Mac platform, not including Tiger.

        * editing/execCommand/findString-diacriticals-expected.txt: Added. Expect failure.
        * editing/execCommand/findString-diacriticals.html: Added.
        * platform/mac-tiger/editing/execCommand: Added.
        * platform/mac-tiger/editing/execCommand/findString-diacriticals-expected.txt: Added. Expect failure.
        * platform/mac/editing/execCommand/findString-diacriticals-expected.txt: Added. Expect success.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCrashTracer: [REGRESSION] 1090 crashes in Safari at com.apple.JavaScriptCore: KJS...
oliver@apple.com [Thu, 1 Jan 2009 08:34:58 +0000 (08:34 +0000)]
CrashTracer: [REGRESSION] 1090 crashes in Safari at com.apple.JavaScriptCore: KJS::JSGlobalObject::stopTimeoutCheck + 0

Reviewed by Cameron Zwarich.

This was caused by a plugin instance calling into JS code that removed the plugin
object.  This fix is to cache the global object locally in a ProtectedPtr so we don't
need to rely on the continued existence of the plugin instance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[jsfunfuzz] Assertion + incorrect behaviour with dynamically created local variable...
oliver@apple.com [Thu, 1 Jan 2009 08:22:40 +0000 (08:22 +0000)]
[jsfunfuzz] Assertion + incorrect behaviour with dynamically created local variable in a catch block

Reviewed by Cameron Zwarich

Eval inside a catch block attempts to use the catch block's static scope in
an unsafe way by attempting to add new properties to the scope.  This patch
fixes this issue simply by preventing the catch block from using a static
scope if it contains an eval.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[jsfunfuzz] Computed exception offset wrong when first instruction is attempt to...
oliver@apple.com [Thu, 1 Jan 2009 02:33:43 +0000 (02:33 +0000)]
[jsfunfuzz] Computed exception offset wrong when first instruction is attempt to resolve deleted eval

Reviewed by Gavin Barraclough.

This was caused by the expression information for the initial resolve of
eval not being emitted.  If this resolve was the first instruction that
could throw an exception the information search would fail leading to an
assertion failure.  If it was not the first throwable opcode the wrong
expression information would used.

Fix is simply to emit the expression info.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd section information for View, Frame, Settings, HistoryItem, BackForwardList,...
zecke@webkit.org [Wed, 31 Dec 2008 17:52:47 +0000 (17:52 +0000)]
Add section information for View, Frame, Settings, HistoryItem, BackForwardList, WindowFeatures and Inspector

Add section information and informal examples for WebKitWebView,
WebKitWebFrame, WebKitWebSettings, WebKitWebNetworkRequest,
WebKitWebWindowFeatures, WebKitWebHistoryItem,
WebKitWebBackForwardList and WebKitWebInspector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-12-31 Zan Dobersek <zandobersek@gmail.com>
zecke@webkit.org [Wed, 31 Dec 2008 17:31:04 +0000 (17:31 +0000)]
2008-12-31  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Holger Freyther.


        Prevent TestNetscapePlugin from installing system-wide.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-12-31 Laszlo Gombos <laszlo.1.gombos@nokia.com>
zecke@webkit.org [Wed, 31 Dec 2008 17:12:01 +0000 (17:12 +0000)]
2008-12-31  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Holger Freyther.

        Fixes: https://bugs.webkit.org/show_bug.cgi?id=22964

        MinGW build failure.

        * platform/graphics/qt/SimpleFontDataQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-12-31 Zan Dobersek <zandobersek@gmail.com>
zecke@webkit.org [Wed, 31 Dec 2008 16:52:19 +0000 (16:52 +0000)]
2008-12-31  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Holger Freyther.


        Move WebKitWebView's size allocation into a proper place.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-12-31 Alexander V. Butenko <alex@digiqube.com>
zecke@webkit.org [Wed, 31 Dec 2008 16:37:00 +0000 (16:37 +0000)]
2008-12-31  Alexander V. Butenko  <alex@digiqube.com>

        Reviewed by Holger Freyther.

        [gtk] webkit up to r39121 crash on image urls like

        * platform/network/soup/ResourceHandleSoup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-12-31 Hiroyuki Ikezoe <poincare@ikezoe.net>
zecke@webkit.org [Wed, 31 Dec 2008 16:17:04 +0000 (16:17 +0000)]
2008-12-31  Hiroyuki Ikezoe  <poincare@ikezoe.net>

        Reviewed by Holger Freyther.


        * platform/graphics/gtk/SimpleFontDataPango.cpp:
        (WebCore::SimpleFontData::determinePitch): Do not invoke
        isFixedPitch() when the font is a custom font.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMore work on Bug 3781: Animation via canvas could be faster
oliver@apple.com [Wed, 31 Dec 2008 12:32:12 +0000 (12:32 +0000)]
More work on Bug 3781: Animation via canvas could be faster

Reviewed by Cameron Zwarich

Make use of the fast path parsing of color strings that Color
uses.  This improves performance of '#rgb', '#rrggbb', etc and
named (eg. 'green') colors.

Improves frame rate of test by around 40%

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-12-31 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Wed, 31 Dec 2008 10:17:05 +0000 (10:17 +0000)]
2008-12-31  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver Hunt.

        Bug 23054: Caching of global lookups occurs even when the global object has become a dictionary


        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::resolveGlobal): Do not cache lookup if the global
        object has transitioned to a dictionary.
        (JSC::Interpreter::cti_op_resolve_global): Do not cache lookup if the
        global object has transitioned to a dictionary.


        * fast/js/pic/delete-global-object-expected.txt: Added.
        * fast/js/pic/delete-global-object.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<https://bugs.webkit.org/show_bug.cgi?id=23049> [jsfunfuzz] With blocks do not correc...
oliver@apple.com [Wed, 31 Dec 2008 06:49:34 +0000 (06:49 +0000)]
<https://bugs.webkit.org/show_bug.cgi?id=23049> [jsfunfuzz] With blocks do not correctly protect their scope object
<rdar://problem/6469742> Crash in JSC::TypeInfo::hasStandardGetOwnPropertySlot() running jsfunfuzz

Reviewed by Darin Adler

The problem that caused this was that with nodes were not correctly protecting
the final object that was placed in the scope chain.  We correct this by forcing
the use of a temporary register (which stops us relying on a local register
protecting the scope) and changing the behaviour of op_push_scope so that it
will store the final scope object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-12-30 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 31 Dec 2008 05:16:27 +0000 (05:16 +0000)]
2008-12-30  Simon Fraser  <simon.fraser@apple.com>

        Fix spurious test failures by rounding floating point values to
        mask math differences between machines.

        * transitions/transform-op-list-match-expected.txt:
        * transitions/transform-op-list-match.html:
        * transitions/transform-op-list-no-match-expected.txt:
        * transitions/transform-op-list-no-match.html:
        * transitions/transition-test-helpers.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-12-30 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 31 Dec 2008 00:11:50 +0000 (00:11 +0000)]
2008-12-30  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler


        Rather than doing a repaint() inside of computeAbsoluteRepaintRect()
        when there is a reflection, compute the location of the rect inside
        the reflection and take the union of the unreflected and reflected rects.

        Test: fast/repaint/reflection-redraw.html

        * rendering/RenderBox.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-12-30 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Wed, 31 Dec 2008 00:07:20 +0000 (00:07 +0000)]
2008-12-30  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Sam Weinig.

        Bug 23037: Parsing and reparsing disagree on automatic semicolon insertion

        Parsing and reparsing disagree about automatic semicolon insertion, so that a
        function like

        function() { a = 1, }

        is parsed as being syntactically valid but gets a syntax error upon reparsing.
        This leads to an assertion failure in Parser::reparse(). It is not that big of
        an issue in practice, because in a Release build such a function will return
        'undefined' when called.

        In this case, we are not following the spec and it should be a syntax error.
        However, unless there is a newline separating the ',' and the '}', WebKit would
        not treat it as a syntax error in the past either. It would be a bit of work to
        make the automatic semicolon insertion match the spec exactly, so this patch
        changes it to match our past behaviour.

        The problem is that even during reparsing, the Lexer adds a semicolon at the
        end of the input, which confuses allowAutomaticSemicolon(), because it is
        expecting either a '}', the end of input, or a terminator like a newline.


        * parser/Lexer.cpp:
        (JSC::Lexer::Lexer): Initialize m_isReparsing to false.
        (JSC::Lexer::lex): Do not perform automatic semicolon insertion in the Lexer if
        we are in the middle of reparsing.
        (JSC::Lexer::clear): Set m_isReparsing to false.
        * parser/Lexer.h:
        (JSC::Lexer::setIsReparsing): Added.
        * parser/Parser.cpp:
        (JSC::Parser::reparse): Call Lexer::setIsReparsing() to notify the Lexer of


        * fast/js/reparsing-semicolon-insertion-expected.txt: Added.
        * fast/js/reparsing-semicolon-insertion.html: Added.
        * fast/js/resources/reparsing-semicolon-insertion.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Tue, 30 Dec 2008 22:30:25 +0000 (22:30 +0000)]

        Reviewed by Adele Peterson.

        - fix <rdar://problem/6469944> REGRESSION(3.2.1-ToT): Repro crash in WebCore::HTMLInputElement::updatePlaceholderVisibility opening http://billshrink.com

        Test: fast/forms/placeholder-non-textfield.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::parseMappedAttribute): Only call
        updatePlaceholderVisibility() when the placeholder attribute changes if
        the element is a text field.


        Reviewed by Adele Peterson.

        - test for <rdar://problem/6469944> REGRESSION(3.2.1-ToT): Repro crash in WebCore::HTMLInputElement::updatePlaceholderVisibility opening http://billshrink.com

        * fast/forms/placeholder-non-textfield-expected.txt: Added.
        * fast/forms/placeholder-non-textfield.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-12-30 Brent Fulgham <bfulgham@gmail.com>
pam@chromium.org [Tue, 30 Dec 2008 19:24:19 +0000 (19:24 +0000)]
2008-12-30  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Darin Adler.
        Landed by Pamela Greene.

        Fixes: https://bugs.webkit.org/show_bug.cgi?id=22908.
        Update website so that newbies are told they must set the
        WebKitOutputDir to get a valid build.

        * building/build.html: Add language (and link) indicating the
        importance of setting the WebKitOutputDir variable, as well
        as a link to instructions on how to do so.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFirst step of Bug 3781: Animation via canvas could be faster
oliver@apple.com [Tue, 30 Dec 2008 12:19:23 +0000 (12:19 +0000)]
First step of Bug 3781: Animation via canvas could be faster

Reviewed by Antti Koivisto.

Amortise the cost of calling repaint by coalescing repaint rects
while the canvas is drawn to.  In a later step we'll stop calling
repaint() directly, and instead have all dirty canvases repaint
at the end of JS execution.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-12-30 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Tue, 30 Dec 2008 11:08:26 +0000 (11:08 +0000)]
2008-12-30  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Antti Koivisto.

        Bug 22931: Using the inspector with purgeable resources leads to assertion failures

        Change InspectorResource::sourceString() so that it doesn't attempt to
        unsafely get the data of a purgeable CachedResource.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorResource::sourceString): Attempt to make a purgeable
        resource unpurgeable, and if this not possible, return an empty string.
        * loader/CachedResource.h: Make InspectorResource a friend of CachedResource.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoYet another attempt to fix Tiger.
oliver@apple.com [Tue, 30 Dec 2008 07:54:28 +0000 (07:54 +0000)]
Yet another attempt to fix Tiger.

Reviewed by NOBODY(Build fix)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTiger build fix (correct this time)
oliver@apple.com [Tue, 30 Dec 2008 07:46:13 +0000 (07:46 +0000)]
Tiger build fix (correct this time)

Reviewed by NOBODY(build fix)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig.
ap@webkit.org [Tue, 30 Dec 2008 07:46:02 +0000 (07:46 +0000)]
    Reviewed by Sam Weinig.

        Remove incomplete support for opportunistic appcache entries

        No change in behavior, thus no test.

        * loader/appcache/ApplicationCacheResource.h:
        (WebCore::ApplicationCacheResource::Type): Removed Opportunistic bit, will re-use when schema
        version changes.

        * loader/DocumentLoader.cpp:
        * loader/appcache/ApplicationCacheGroup.cpp:
        * loader/appcache/ApplicationCacheResource.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-12-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Tue, 30 Dec 2008 07:42:11 +0000 (07:42 +0000)]
2008-12-29  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Rubber-stamped by Alexey Proskuryakov.

        Revert r39509, because kjsyydebug is used in the generated code if YYDEBUG is 1.

        * parser/Grammar.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39513 268f45cc-cd09-0410-ab3c-d52691b4dbfc