WebKit-https.git
10 years ago2009-08-18 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 19 Aug 2009 05:16:12 +0000 (05:16 +0000)]
2009-08-18  Xan Lopez  <xlopez@igalia.com>

        Rubber-stamped by Holger Freyther.

        Require at least libsoup 2.27.91 for the new password
        manager/authentication APIs.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-13 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 19 Aug 2009 05:09:35 +0000 (05:09 +0000)]
2009-08-13  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        - Implement HTML5 nav element
        https://bugs.webkit.org/show_bug.cgi?id=27937

        <nav> should behave essentially the same as <div> for parsing
        etc. This is implemented by the changes below.

        Tests: fast/html/nav-element.html

        * css/html.css:
        * editing/htmlediting.cpp:
        (WebCore::validBlockTag):
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::tagPriority):
        (WebCore::blockTagList):
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::getNode):
        * html/HTMLTagNames.in:

2009-08-13  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        - Tests for: Implement HTML5 nav element
        https://bugs.webkit.org/show_bug.cgi?id=27937

        Test aspects of <nav>, including residual style, <p> closing, and FormatBlock.

        * fast/html/nav-element-expected.txt: Added.
        * fast/html/nav-element.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLand updated Windows layout test results.
hyatt@apple.com [Wed, 19 Aug 2009 04:39:26 +0000 (04:39 +0000)]
Land updated Windows layout test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a new build configuration that checks for leaks during the layout tests,
mrowe@apple.com [Wed, 19 Aug 2009 04:19:38 +0000 (04:19 +0000)]
Add a new build configuration that checks for leaks during the layout tests,
and hook a new machine up to it.

Rubber-stamped by Oliver Hunt.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago- Fix <rdar://problem/7152727>
andersca@apple.com [Wed, 19 Aug 2009 04:01:17 +0000 (04:01 +0000)]
- Fix <rdar://problem/7152727>

Patch by Anders Carlsson <andersca@apple.com> on 2009-08-18
Reviewed by Adele Peterson, David Hyatt and Dan Bernstein.

If a page has custom scroll bars, they will not update correctly when the window is activated/deactivated.

* page/FrameView.cpp:
(WebCore::FrameView::hasCustomScrollbars):
Check if the frame view or any of its subviews have custom scroll bars.

(WebCore::FrameView::updateControlTints):
Go ahead and update control tints if the frame view has custom scroll bars.

* page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRoll out r47477 as it introduced assertion failures and crashes on the build bots.
mrowe@apple.com [Wed, 19 Aug 2009 03:42:02 +0000 (03:42 +0000)]
Roll out r47477 as it introduced assertion failures and crashes on the build bots.

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* storage/Database.cpp:
* storage/Database.h:
* storage/DatabaseThread.cpp:
(WebCore::DatabaseThread::DatabaseThread):
* storage/DatabaseThread.h:
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback):
(WebCore::SQLTransaction::postflightAndCommit):
* storage/SQLTransactionClient.cpp: Removed.
* storage/SQLTransactionClient.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Maxime Simon <simon.maxime@gmail.com>
eric@webkit.org [Wed, 19 Aug 2009 03:32:52 +0000 (03:32 +0000)]
2009-08-18  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Eric Seidel.

        [Haiku] Adding the SharedTimer file for WebCore.
        https://bugs.webkit.org/show_bug.cgi?id=28126

        * platform/haiku/SharedTimerHaiku.cpp: Added.
        (WebCore::):
        (WebCore::SharedTimerHaiku::SharedTimerHaiku):
        (WebCore::SharedTimerHaiku::~SharedTimerHaiku):
        (WebCore::SharedTimerHaiku::instance):
        (WebCore::SharedTimerHaiku::start):
        (WebCore::SharedTimerHaiku::stop):
        (WebCore::SharedTimerHaiku::Filter):
        (WebCore::setSharedTimerFiredFunction):
        (WebCore::setSharedTimerFireTime):
        (WebCore::stopSharedTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRelease build fix.
mrowe@apple.com [Wed, 19 Aug 2009 03:13:16 +0000 (03:13 +0000)]
Release build fix.

* xml/XMLHttpRequest.cpp: Sprinkle some #ifndef NDEBUG around.
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::~XMLHttpRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLeak of WebCore::XMLHttpRequest object during layout tests (<https://bugs.webkit...
mrowe@apple.com [Wed, 19 Aug 2009 03:01:15 +0000 (03:01 +0000)]
Leak of WebCore::XMLHttpRequest object during layout tests (<https://bugs.webkit.org/show_bug.cgi?id=28412>).

2009-08-18  Aaron Boodman  <aa@chromium.org>

        Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=28412: Leak of WebCore::XMLHttpRequest object during layout tests.

        No new tests: Already covered by existing tests.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::XMLHttpRequest): Add instrumentation for this kind of leak.
        (WebCore::XMLHttpRequest::~XMLHttpRequest): Ditto.
        (WebCore::XMLHttpRequest::createRequest): Only setPendingActivity() if we actually started a request. Also,
        restore a call to nonCacheRequestInFlight() that got lost in a recent refactor.

        * Scripts/check-for-global-initializers: Allow global initialization of WTF::RefCountedLeakCounter for XMLHttpRequest.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Dumitru Daniliuc <dumi@chromium.org>
eric@webkit.org [Wed, 19 Aug 2009 02:56:13 +0000 (02:56 +0000)]
2009-08-18  Dumitru Daniliuc  <dumi@chromium.org>

        Reviewed by Dimitri Glazkov.

        Added a client to SQLTransaction. In addition to being a place to
        get notifications about certain events in a transaction, it is
        also an abstraction layer that allows us to plug in different
        implementations for each port for how transactions interract with
        the main DB. For example, WebCore's default implementation will
        make direct calls to DatabaseTracker's methods. At the same time,
        Chromium's implementation will send IPCs to the browser process
        whenever a transaction needs something from the main DB.

        All storage tests pass.

        https://bugs.webkit.org/show_bug.cgi?id=27967

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * storage/Database.cpp:
        (WebCore::Database::transactionClient):
        * storage/Database.h:
        * storage/DatabaseThread.cpp:
        (WebCore::DatabaseThread::DatabaseThread):
        * storage/DatabaseThread.h:
        (WebCore::DatabaseThread::transactionClient):
        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::runCurrentStatement):
        (WebCore::SQLTransaction::deliverQuotaIncreaseCallback):
        (WebCore::SQLTransaction::postflightAndCommit):
        * storage/SQLTransactionClient.cpp: Added.
        * storage/SQLTransactionClient.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed, build fix for Chromium.
jparent@chromium.org [Wed, 19 Aug 2009 02:44:00 +0000 (02:44 +0000)]
Not reviewed, build fix for Chromium.

Patch by Julie Parent <jparent@chromium.org> on 2009-08-18
Final change for v8 corresponding to http://trac.webkit.org/changeset/47469.

* bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added missing using statment

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed, build fix for Chromium.
jparent@chromium.org [Wed, 19 Aug 2009 02:32:51 +0000 (02:32 +0000)]
Not reviewed, build fix for Chromium.

Patch by Julie Parent <jparent@chromium.org> on 2009-08-18
       More corresponding changes to V8 from http://trac.webkit.org/changeset/47469.

* bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
(WebCore::ACCESSOR_SETTER): Use srcAttr instead of the src function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAssigning a function to an object should always use the existing transition, even...
oliver@apple.com [Wed, 19 Aug 2009 02:19:10 +0000 (02:19 +0000)]
Assigning a function to an object should always use the existing transition, even if the transition is not specialized
https://bugs.webkit.org/show_bug.cgi?id=28442

Reviewed by Gavin Barraclough.

Check for an unspecialized transition as an alternative to always failing if specialisation does not match.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed, build fix for Chromium.
jparent@chromium.org [Wed, 19 Aug 2009 02:18:16 +0000 (02:18 +0000)]
Not reviewed, build fix for Chromium.

Patch by Julie Parent <jparent@chromium.org> on 2009-08-18
Make corresponding changes to V8 from http://trac.webkit.org/changeset/47469.

* bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
(WebCore::ACCESSOR_SETTER): Use srcAttr instead of the src function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove accidentally committed logging
oliver@apple.com [Wed, 19 Aug 2009 02:15:26 +0000 (02:15 +0000)]
Remove accidentally committed logging

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake test faster so leaks bot won't time out.
oliver@apple.com [Wed, 19 Aug 2009 01:36:56 +0000 (01:36 +0000)]
Make test faster so leaks bot won't time out.

Reviewed by Mark Rowe

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
mitz@apple.com [Wed, 19 Aug 2009 00:26:50 +0000 (00:26 +0000)]
Build fix.

* editing/ApplyStyleCommand.cpp:
(WebCore::getIdentifierValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMore work on making DOM classes start with reference count of 1
darin@apple.com [Wed, 19 Aug 2009 00:17:59 +0000 (00:17 +0000)]
More work on making DOM classes start with reference count of 1
https://bugs.webkit.org/show_bug.cgi?id=28068

Patch by Darin Adler <darin@apple.com> on 2009-08-18
Reviewed by Sam Weinig.

Some related clean-up and preparation steps so the subsequent
patches will be as small as possible.

* WebCore.base.exp: Sorted this file.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityDescription):
Use nameAttr instead of the name function.

* bindings/js/JSHTMLFrameElementCustom.cpp:
(WebCore::JSHTMLFrameElement::setSrc):
Use srcAttr instead of the src function.

* bindings/js/JSHTMLIFrameElementCustom.cpp:
(WebCore::JSHTMLIFrameElement::setSrc):
Use srcAttr instead of the src function.

* bindings/objc/DOM.mm: Sorted includes.
* dom/Document.cpp: Ditto.

* dom/StyledElement.cpp: Made invalidateStyleAttribute inline.
* dom/StyledElement.h: Ditto.

* dom/make_names.pl: Changed default of createWithNew to 0.
Eventually all elements will be created with create instead of new.

* html/HTMLTagNames.in:
* svg/svgtags.in:
* wml/WMLTagNames.in:
Added createWithNew for every tag. We'll remove it as we convert
element classes to use create.

* html/HTMLAppletElement.h: Removed unneeded forward declarations.
* html/HTMLFrameElement.h: Ditto.

* html/HTMLEmbedElement.cpp: Removed many attribute get and
set functions.
* html/HTMLEmbedElement.h: Ditto.
* html/HTMLIFrameElement.cpp: Ditto.
* html/HTMLIFrameElement.h: Ditto.
* html/HTMLObjectElement.cpp: Ditto.
* html/HTMLObjectElement.h: Ditto.
* html/HTMLPlugInElement.cpp: Ditto.
* html/HTMLPlugInElement.h: Ditto.

* html/HTMLFrameElementBase.cpp: Removed many attribute get and
set functions.
(WebCore::HTMLFrameElementBase::location): Changed to use
srcAttr instead of src.
* html/HTMLFrameElementBase.h: Removed many attribute get and set
functions.

* loader/MediaDocument.cpp:
(WebCore::MediaDocument::replaceMediaElementTimerFired):
Use srcAttr and typeAttr instead of setSrc and setType.
* loader/PluginDocument.cpp:
(WebCore::PluginTokenizer::createDocumentStructure): Ditto.

* rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::updateWidget): Use nameAttr instead
of name -- this avoids an extra AtomicString round trip and a little
ref count churn too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Mark Rowe
mitz@apple.com [Wed, 19 Aug 2009 00:05:59 +0000 (00:05 +0000)]
Rubber-stamped by Mark Rowe

Update Windows and Qt results after r47462.

* platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: SharedWorkers need to support loading.
atwilson@chromium.org [Wed, 19 Aug 2009 00:04:04 +0000 (00:04 +0000)]
WebCore: SharedWorkers need to support loading.
https://bugs.webkit.org/show_bug.cgi?id=28342

Reviewed by David Levin.

Added loader support to shared workers, and refactored worker tests to also test SharedWorkers

* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postTaskToLoader):
Forwards load requests to an arbitrary document from the list of worker's documents.
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext):
Posts responses back to the shared worker thread.

LayoutTests: SharedWorkers need to support loading
https://bugs.webkit.org/show_bug.cgi?id=28342

Reviewed by David Levin.

Refactored worker network tests to also test SharedWorkers.

* http/tests/workers/resources/worker-importScripts.js:
Refactored to run in either a dedicated or shared worker.
(handleConnect.self.postMessage):
(handleConnect):
(runTests.try.resetLoadFlags):
(runTests):
* http/tests/workers/resources/worker-redirect-target.js:
Refactored to run in either a dedicated or shared worker.
(else.self.onconnect):
* http/tests/workers/resources/worker-redirect.js: Added.
Moved test code out of worker-redirect.html so it can be shared with shared worker tests.
(log):
(runNextTest):
(testCrossOriginLoad.try.worker.onerror):
(testCrossOriginLoad.try.worker.onmessage):
(testCrossOriginLoad):
(testCrossOriginRedirectedLoad.try.worker.onerror):
(testCrossOriginRedirectedLoad.try.worker.onmessage):
(testCrossOriginRedirectedLoad):
* http/tests/workers/shared-worker-importScripts-expected.txt: Added.
* http/tests/workers/shared-worker-importScripts.html-disabled: Added.
* http/tests/workers/shared-worker-redirect-expected.txt: Added
* http/tests/workers/shared-worker-redirect.html-disabled: Added.
* http/tests/workers/worker-redirect.html:
Moved test code into worker-redirect.js.
* http/tests/xmlhttprequest/workers/close.html:
Moved test code into close-test.js.
* http/tests/xmlhttprequest/workers/methods-async.html:
Moved test code into methods-async-test.js.
* http/tests/xmlhttprequest/workers/methods.html:
Moved test code into methods.js.
* http/tests/xmlhttprequest/workers/resources/close-test.js: Added.
Contains test code moved from close.html, so tests can be shared with SharedWorkers.
(log):
(testAsync.worker.onmessage.else):
(testAsync.worker.onmessage):
(testAsync):
(testSync.worker.onmessage.else):
(testSync.worker.onmessage):
(testSync):
(done):
(handleException):
* http/tests/xmlhttprequest/workers/resources/close.js:
Modified worker code so it runs in shared workers also.
* http/tests/xmlhttprequest/workers/resources/file-not-found.js: Added.
Contains test code moved from xmlhttprequest-file-not-found.html (now shared with shared worker tests).
(log):
(worker.onmessage):
* http/tests/xmlhttprequest/workers/resources/methods-async-test.js: Added.
Contains test code moved from methods-async.html (now shared with shared worker tests).
(log):
(worker.onmessage):
* http/tests/xmlhttprequest/workers/resources/methods-async.js:
Changed code to run in shared workers also.
* http/tests/xmlhttprequest/workers/resources/methods-test.js: Added.
Contains test code moved from methods.html (now shared with shared worker tests).
(log):
(worker.onmessage):
* http/tests/xmlhttprequest/workers/resources/methods.js:
Now can run in either dedicated or shared workers.
(init):
* http/tests/xmlhttprequest/workers/resources/shared-worker-create.js: Added.
Utility code to allow shared workers to look like dedicated workers to enable sharing test code.
(createWorker.worker.port.onmessage):
(createWorker.worker.postMessage):
(createWorker):
* http/tests/xmlhttprequest/workers/resources/worker-create.js: Added.
(createWorker):
* http/tests/xmlhttprequest/workers/resources/worker-pre.js: Added.
Utility code to make SharedWorkerGlobalScope look like DedicatedWorkerGlobalScope, to enable test code sharing.
(else.self.onconnect.self.postMessage):
(else.self.onconnect.event.messagePort.onmessage):
(else.self.onconnect):
* http/tests/xmlhttprequest/workers/resources/xmlhttprequest-file-not-found.js:
(init):
Updated code so it runs in shared workers also.
* http/tests/xmlhttprequest/workers/shared-worker-close-expected.txt: Added.
* http/tests/xmlhttprequest/workers/shared-worker-close.html-disabled: Added.
* http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.
* http/tests/xmlhttprequest/workers/shared-worker-methods-async.html-disabled: Added.
* http/tests/xmlhttprequest/workers/shared-worker-methods-expected.txt: Added.
* http/tests/xmlhttprequest/workers/shared-worker-methods.html-disabled: Added.
* http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found-expected.txt: Added.
* http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found.html-disabled: Added.
* http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html:
Moved test code into file-not-found.js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Ryosuke Niwa <rniwa@webkit.org>
eric@webkit.org [Wed, 19 Aug 2009 00:01:30 +0000 (00:01 +0000)]
2009-08-18  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        StyleChange::init needs clean up before fixing the bug 23892
        https://bugs.webkit.org/show_bug.cgi?id=27749

        This patch simplifies StyleChange::init by removing the iteration on CSS properties,
        and adding functions reconcileTextDecorationProperties and extractTextStyle to handle the style.

        Because there is a bug in how text decorations are processes in getPropertiesNotInComputedStyle,
        this patch simplifies the treatment in order to preserve the original behavior of WebKit.
        However, the current implementation is not best (adds redundant text-decorations) and we should fix it later.

        No test is added since there is no change in behavior.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::StyleChange::init): Uses getPropertiesNotInComputedStyle instead of iterating through the properties
        (WebCore::StyleChange::reconcileTextDecorationProperties): Removes -webkit-text-decorations-in-effects and redundant "none"
        (WebCore::getIdentifierValue): Obtains the identifier of a CSSPrimitiveValue
        (WebCore::StyleChange::extractTextStyles): Converts properties in style to m_apply* and removes the property
        (WebCore::getPropertiesNotInComputedStyle): Fixed a bug with how text decorations are treated

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webki...
mrowe@apple.com [Wed, 19 Aug 2009 00:00:34 +0000 (00:00 +0000)]
Bump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webkit-tests.

Rubber-stamped by Geoff Garen.

* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Dumitru Daniliuc <dumi@chromium.org>
eric@webkit.org [Tue, 18 Aug 2009 23:54:39 +0000 (23:54 +0000)]
2009-08-18  Dumitru Daniliuc  <dumi@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fixing a DB file naming bug in Chromium. The origin should come
        before the DB name in the file name.

        https://bugs.webkit.org/show_bug.cgi?id=28331

        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::fullPathForDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Maxime Simon <simon.maxime@gmail.com>
eric@webkit.org [Tue, 18 Aug 2009 23:47:39 +0000 (23:47 +0000)]
2009-08-18  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Eric Seidel.

        [Haiku] Adding four image-specific files to WebCore:
        IconHaiku.cpp, ImageBufferData.h, ImageBufferHaiku.cpp, ImageHaiku.cpp
        https://bugs.webkit.org/show_bug.cgi?id=28130

        * platform/graphics/Icon.h:
        * platform/graphics/haiku/IconHaiku.cpp: Added.
        (WebCore::Icon::~Icon):
        (WebCore::Icon::createIconForFile):
        (WebCore::Icon::createIconForFiles):
        (WebCore::Icon::paint):
        * platform/graphics/haiku/ImageBufferData.h: Added.
        * platform/graphics/haiku/ImageBufferHaiku.cpp: Added.
        (WebCore::ImageBufferData::ImageBufferData):
        (WebCore::ImageBuffer::ImageBuffer):
        (WebCore::ImageBuffer::~ImageBuffer):
        (WebCore::ImageBuffer::context):
        (WebCore::ImageBuffer::getUnmultipliedImageData):
        (WebCore::ImageBuffer::getPremultipliedImageData):
        (WebCore::ImageBuffer::putUnmultipliedImageData):
        (WebCore::ImageBuffer::putPremultipliedImageData):
        (WebCore::ImageBuffer::toDataURL):
        (WebCore::ImageBuffer::image):
        (WebCore::ImageBuffer::platformTransformColorSpace):
        * platform/graphics/haiku/ImageHaiku.cpp: Added.
        (WebCore::FrameData::clear):
        (WebCore::Image::loadPlatformResource):
        (WebCore::BitmapImage::initPlatformData):
        (WebCore::BitmapImage::invalidatePlatformData):
        (WebCore::BitmapImage::draw):
        (WebCore::Image::drawPattern):
        (WebCore::BitmapImage::checkForSolidColor):
        (WebCore::BitmapImage::getBBitmap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=27575 [CSS3
bdakin@apple.com [Tue, 18 Aug 2009 23:36:27 +0000 (23:36 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=27575 [CSS3
Backgrounds and Borders] Drop the prefix from background-size

Reviewed by Dan Bernstein.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillProperty):
(WebCore::cssPropertyID):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* page/animation/AnimationBase.cpp:
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
(WebCore::ensurePropertyMap):

LayoutTests: Test result changes for https://bugs.webkit.org/show_bug.cgi?id=27575
[CSS3 Backgrounds and Borders] Drop the prefix from background-size

Reviewed by Dan Bernstein.

* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Tue, 18 Aug 2009 23:09:20 +0000 (23:09 +0000)]
2009-08-18  Brian Weinstein  <bweinstein@apple.com>

        Rubber-stamped by Adam Roben.

        Changed use of CComBSTR in exceededDatabaseQuota to BSTRs, and free them,
        and removed include to fix building on VC++ Express.

        * DumpRenderTree/win/UIDelegate.cpp:
        (UIDelegate::exceededDatabaseQuota):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Drew Wilson <atwilson@google.com>
eric@webkit.org [Tue, 18 Aug 2009 22:15:57 +0000 (22:15 +0000)]
2009-08-18  Drew Wilson  <atwilson@google.com>

        Reviewed by David Levin.

        SharedWorkers need to forward exceptions to parent documents
        https://bugs.webkit.org/show_bug.cgi?id=28320

        Wrote test to generate exception and make sure it gets logged to the console.
        Started switching over to using the same test utilities that the tests under fast/js use.

        * fast/workers/resources/shared-worker-common.js:
        (generateError):
        (handleMessage):
        * fast/workers/resources/shared-worker-exception.js: Added.
        (worker.onmessage):
        (done):
        * fast/workers/shared-worker-exception-expected.txt: Added.
        * fast/workers/shared-worker-exception.html-disabled: Added.

2009-08-18  Drew Wilson  <atwilson@google.com>

        Reviewed by David Levin.

        SharedWorkers need to forward exceptions to parent documents
        https://bugs.webkit.org/show_bug.cgi?id=28320

        Changed SharedWorkerProxy to have individual mutexes (so workers can interact with their parent documents without contention).

        Updated SharedWorkerProxy to forward exceptions/console messages to all parent documents.

        * bindings/js/JSSharedWorkerConstructor.cpp:
        Cleaned up bitrot - added missing include.
        * workers/DefaultSharedWorkerRepository.cpp:
        (WebCore::postExceptionTask):
        Callback used to deliver exceptions to a document.
        (WebCore::SharedWorkerProxy::postExceptionToWorkerObject):
        Forwards exceptions to all parent documents for presentation to the user.
        (WebCore::postConsoleMessageTask):
        (WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
        Forwards console messages to all parent documents for presentation to the user.
        (WebCore::SharedWorkerProxy::addToWorkerDocuments):
        Grabs the mutex before accessing workerDocuments.
        (WebCore::SharedWorkerProxy::documentDetached):
        Grabs the mutex before accessing workerDocuments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: <rdar://problem/7135588> HTMLMediaElement should ask WebPolicyLoadDelegate...
andersca@apple.com [Tue, 18 Aug 2009 22:06:15 +0000 (22:06 +0000)]
WebCore: <rdar://problem/7135588> HTMLMediaElement should ask WebPolicyLoadDelegate before loading resource

Reviewed by Adele Peterson.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isSafeToLoadURL):
Call FrameLoaderClient::shouldLoadMediaElementURL.

* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::shouldLoadMediaElementURL):
Return true by default.

WebKit/mac: Mac specific part of

Reviewed by Adele Peterson.

<rdar://problem/7135588> HTMLMediaElement should ask WebPolicyLoadDelegate before loading resource

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
Implement shouldLoadMediaElementURL by asking the policy delegate.

* WebView/WebPolicyDelegatePrivate.h:
Add new delegate method, remove some unused cruft.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Dumitru Daniliuc <dumi@chromium.org>
eric@webkit.org [Tue, 18 Aug 2009 21:58:34 +0000 (21:58 +0000)]
2009-08-18  Dumitru Daniliuc  <dumi@chromium.org>

        Reviewed by Dimitri Glazkov.

        Adding a test to verify that openDatabase() does not execute
        SQL statements on the database it's trying to open, unless we're
        opening the first handle to that database.

        https://bugs.webkit.org/show_bug.cgi?id=28207

        * storage/open-database-while-transaction-in-progress-expected.txt: Added.
        * storage/open-database-while-transaction-in-progress.html: Added.

2009-08-18  Dumitru Daniliuc  <dumi@chromium.org>

        Reviewed by Dimitri Glazkov.

        openDatabase() should not execute any SQL statement on the
        database it's trying to open, unless there are no other open
        handles to the same database. Otherwise, we might run into a
        deadlock.

        Test: storage/open-database-while-transaction-in-progress.html

        https://bugs.webkit.org/show_bug.cgi?id=28207

        * storage/Database.cpp:
        (WebCore::Database::performOpenAndVerify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 18 Aug 2009 21:48:07 +0000 (21:48 +0000)]
2009-08-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=19360
        Frags on current page don't generate "navigation-requested" events

        Fix order of parameters for the creation of SubstituteData object,
        so that normal data loads do not have an unreachable URL. Also
        remove a confusion about the purpose of the last parameter.

        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_load_data):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Tue, 18 Aug 2009 21:37:17 +0000 (21:37 +0000)]
2009-08-18  Dirk Schulze  <krit@webkit.org>

        Reviewed by Oliver Hunt.

        SVG Filter feBlend implementation missing
        [https://bugs.webkit.org/show_bug.cgi?id=28133]

       Implementation of SVG Filter feBlend.

        FilterEffect.cp needed changes to optimize the rendering. With the old code
        we drew a subEffect on the current FilterEffect by drawImage, got the PixelArray,
        cleared the drawing area, drew the next FilterEffect with drawImage and picked this
        PixelArray again. This was unefficient and slow. Now we calculate the requested area
        of the subEffect and ask the FilterEffect's ImageBuffer for the PixelArray directly,
        without any drawing operations on GraphicsContext.

        There is already a test case
        Test: svg/W3C-SVG-1.1/filters-blend-01-b.svg

        * html/canvas/CanvasPixelArray.h:
        (WebCore::CanvasPixelArray::set):
        (WebCore::CanvasPixelArray::get):
        * platform/graphics/filters/FEBlend.cpp:
        (WebCore::unknown):
        (WebCore::normal):
        (WebCore::multiply):
        (WebCore::screen):
        (WebCore::darken):
        (WebCore::lighten):
        (WebCore::FEBlend::apply):
        * platform/graphics/filters/FEBlend.h:
        * platform/graphics/filters/FilterEffect.cpp:
        (WebCore::FilterEffect::calculateDrawingIntRect):
        * platform/graphics/filters/FilterEffect.h:

2009-08-18  Dirk Schulze  <krit@webkit.org>

        Reviewed by Oliver Hunt.

        Added additional getter to ByteArray with an unsigned char as return.
        ByteArray can take unsigned char directly now.

        * wtf/ByteArray.h:
        (WTF::ByteArray::set):
        (WTF::ByteArray::get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 18 Aug 2009 21:09:03 +0000 (21:09 +0000)]
2009-08-18  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        WebInspector: Fix array formatter followup: node formatter.

        https://bugs.webkit.org/show_bug.cgi?id=28427

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._format):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate SnowLeopard-specific layout test results after r47440.
mrowe@apple.com [Tue, 18 Aug 2009 21:05:00 +0000 (21:05 +0000)]
Update SnowLeopard-specific layout test results after r47440.

* platform/mac/media/audio-controls-rendering-expected.txt:
* platform/mac/media/controls-after-reload-expected.txt:
* platform/mac/media/controls-styling-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 18 Aug 2009 20:44:48 +0000 (20:44 +0000)]
2009-08-18  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        WebInspector: Metrics sidebar broken

        https://bugs.webkit.org/show_bug.cgi?id=28434

        * inspector/front-end/MetricsSidebarPane.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix GTK bustage.
hyatt@apple.com [Tue, 18 Aug 2009 20:21:23 +0000 (20:21 +0000)]
Fix GTK bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Chromium bustage.
hyatt@apple.com [Tue, 18 Aug 2009 20:20:29 +0000 (20:20 +0000)]
Fix Chromium bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLand updated results after my last patch.
hyatt@apple.com [Tue, 18 Aug 2009 20:15:56 +0000 (20:15 +0000)]
Land updated results after my last patch.

* platform/mac/compositing/geometry/clipping-foreground-expected.txt:
* platform/mac/compositing/masks/masked-ancestor-expected.txt:
* platform/mac/compositing/masks/multiple-masks-expected.txt:
* platform/mac/compositing/masks/simple-composited-mask-expected.txt:
* platform/mac/fast/clip/008-expected.txt:
* platform/mac/fast/clip/011-expected.txt:
* platform/mac/fast/clip/012-expected.txt:
* platform/mac/fast/overflow/scrollRevealButton-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Tue, 18 Aug 2009 20:01:59 +0000 (20:01 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=28432
        String::createCFString() returns a non-retained empty string

        No known change in functionality, so no test.

        * platform/text/cf/StringCF.cpp: (WebCore::String::createCFString): Retain the CFSTR result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Windows build bustage.
hyatt@apple.com [Tue, 18 Aug 2009 19:58:13 +0000 (19:58 +0000)]
Fix Windows build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-17 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Tue, 18 Aug 2009 19:53:31 +0000 (19:53 +0000)]
2009-08-17  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Oliver Hunt.

        Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support
        LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.

        Implemenent setDatabaseQuota and added a new function to the IWebDatabaseManager interface.
        Also added a console output on UIDelegate::exceededDatabaseQuota to match the mac.

        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setDatabaseQuota):
        * DumpRenderTree/win/UIDelegate.cpp:
        (UIDelegate::exceededDatabaseQuota):

2009-08-17  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Oliver Hunt.

        Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support
        LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.

        Added a setQuota interface method to IWebDatabaseManager and implemented it.

        * Interfaces/IWebDatabaseManager.idl:
        * WebDatabaseManager.cpp:
        (WebDatabaseManager::setQuota):
        * WebDatabaseManager.h:

2009-08-17  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Oliver Hunt.

        Removed now passing storage tests from the Skipped list, now we pass all storage tests on Windows.

        * platform/win/Skipped:

2009-08-17  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Oliver Hunt.

        Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support
        LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.

        Removed an early return that can cause deleteOrigin or deleteAllDatabases to fail when
        it doesn't have to.

        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::deleteOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: https://bugs.webkit.org/show_bug.cgi?id=27357
pkasting@chromium.org [Tue, 18 Aug 2009 19:50:04 +0000 (19:50 +0000)]
WebCore: https://bugs.webkit.org/show_bug.cgi?id=27357
Support for :valid and :invalid CSS selectors, from HTML5 specs.
http://www.whatwg.org/specs/web-apps/current-work/#selector-valid

Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-18
Reviewed by Adele Peterson.

Tests: fast/css/pseudo-invalid-001.html
       fast/css/pseudo-invalid-002.html
       fast/css/pseudo-valid-001.html
       fast/css/pseudo-valid-002.html
       fast/css/pseudo-valid-003.html
       fast/css/pseudo-valid-004.html
       fast/css/pseudo-valid-005.html
       fast/css/pseudo-valid-006.html
       fast/css/pseudo-valid-007.html

* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType): extracts new pseudo-classes
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement): Make sure we don't share style between

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=27357
Tests for :valid and :invalid CSS selectors, from HTML5 specs.
http://www.whatwg.org/specs/web-apps/current-work/#selector-valid

Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-18
Reviewed by Adele Peterson.

* fast/css/pseudo-invalid-001-expected.txt: Added.
* fast/css/pseudo-invalid-001.html: Added.
* fast/css/pseudo-invalid-002-expected.txt: Added.
* fast/css/pseudo-invalid-002.html: Added.
* fast/css/pseudo-valid-001-expected.txt: Added.
* fast/css/pseudo-valid-001.html: Added.
* fast/css/pseudo-valid-002-expected.txt: Added.
* fast/css/pseudo-valid-002.html: Added.
* fast/css/pseudo-valid-003-expected.txt: Added.
* fast/css/pseudo-valid-003.html: Added.
* fast/css/pseudo-valid-004-expected.txt: Added.
* fast/css/pseudo-valid-004.html: Added.
* fast/css/pseudo-valid-005-expected.txt: Added.
* fast/css/pseudo-valid-005.html: Added.
* fast/css/pseudo-valid-006-expected.txt: Added.
* fast/css/pseudo-valid-006.html: Added.
* fast/css/pseudo-valid-007-expected.txt: Added.
* fast/css/pseudo-valid-007.html: Added.
* fast/dom/plugin-attributes-enumeration-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 18 Aug 2009 19:47:18 +0000 (19:47 +0000)]
2009-08-18  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        WebInspector: Fix array formatter.

        https://bugs.webkit.org/show_bug.cgi?id=28427

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._formatarray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-17 Joe Mason <joe.mason@torchmobile.com>
yong.li@torchmobile.com [Tue, 18 Aug 2009 19:39:33 +0000 (19:39 +0000)]
2009-08-17  Joe Mason  <joe.mason@torchmobile.com>

        Reviewed by George Staikos

        Replace repeated string of PLATFORM(FOO) with a single define
        https://bugs.webkit.org/show_bug.cgi?id=27734

        * loader/CachedFont.cpp:
        (WebCore::CachedFont::~CachedFont):
        (WebCore::CachedFont::ensureCustomFontData):
        (WebCore::CachedFont::platformDataFromCustomData):
        (WebCore::CachedFont::allClientsRemoved):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: https://bugs.webkit.org/show_bug.cgi?id=20329, shadows and reflections incor...
hyatt@apple.com [Tue, 18 Aug 2009 19:15:19 +0000 (19:15 +0000)]
WebCore: https://bugs.webkit.org/show_bug.cgi?id=20329, shadows and reflections incorrectly
considered part of scrollable overflow.

Reviewed by Dan Bernstein.

This patch takes the engine's concept of overflow and splits it into two types:
layout overflow and visual overflow.

Layout overflow is about other boxes that spill out of an enclosing box,  For example,
in the inline flow case a tall image could spill out of a line box. Examples of
visual overflow are shadows, text stroke (and eventually outline and
border-image).

Three objects tracked overflow before this patch: RenderBlock had
m_overflowLeft/Top/Width/Height variables.  RootInlineBox had an Overflow*
that also had four overflow values.  Finally RenderReplaced elements tracked shadow/reflection
overflow using a map that cached four values.

This patch takes all of these different overflow models and unifies them into a single
new class called RenderOverflow.   This class is now a member variable in RenderBox and
InlineFlowBoxes.  It is only allocated if overflow actually exists.  Instead of tracking
four values, it tracks eight: left/top/right/bottom for layout overflow and
left/top/right/bottom for visual overflow.

Overflow computation is now done after layout is finished rather than during layout
(when child objects can be churning and moving around).  A number of layout tests progressed
by deferring overflow computation to a separate pass.

All inline flow boxes now track overflow (and not just the root line box).  This allows
repainting of line boxes to actually be tight and bail early if the overflow rect of a box
doesn't intersect.  The old code always visited all object on a line if the root line box
intersected at all.

Line box overflow no longer propagates across self-painting layers.  This fixes a number of
issues with incorrect scrollbars appearing when relative positioned inlines were used in a page.

Layer bounds have been modified to exclude visual overflow.  The width/height members only really
have one reason for continued existence, and that is that they happen to be used in repaint()
when an overflow clip object's height isn't accurate.  In this case, the bounds should exclude
visual overflow anyway, so this change tightens that repaint up.

Root lines have renamed m_selectionTop/Bottom to m_lineTop/Bottom and positionForPoint methods have
been changed to use these instead of relying on overflow (which was totally wrong).

Significant changes have been made to the "almost strict mode" line box quirk where objects with no
text children have no effect on the height of a line.  Instead of making the height() of the objects
variable and dependent on overflow, the objects now have their full height and get placed on
the baseline properly.  They simply don't contribute to overflow above lineTop/Bottom.

Reflections are no longer considered overflow of any kind.  Because reflections have their own layers,
it is not necessary to treat them as visual or layout overflow in the RenderObject tree.  The end result
of not incorporating them into RenderOverflow is that they have no effect on scrolling.  transparencyClipBox
has been extended to support fully reflecting the entire clip box when a reflection exists.  This fixes
numerous repaint bugs in transparent objects with reflections when the transparent objects had self-painting
sublayers.

* WebCore.xcodeproj/project.pbxproj:
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::getUpperLeftCorner):
* editing/visible_units.cpp:
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
* page/FrameView.cpp:
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::adjustPageHeight):
* rendering/InlineBox.cpp:
(WebCore::InlineBox::height):
* rendering/InlineBox.h:
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::adjustPosition):
(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::placeBoxesVertically):
(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paint):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::topCombinedOverflow):
(WebCore::InlineFlowBox::bottomCombinedOverflow):
(WebCore::InlineFlowBox::leftCombinedOverflow):
(WebCore::InlineFlowBox::rightCombinedOverflow):
(WebCore::InlineFlowBox::combinedOverflowRect):
(WebCore::InlineFlowBox::topLayoutOverflow):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::leftLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::topVisualOverflow):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::leftVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):
(WebCore::InlineFlowBox::visualOverflowRect):
(WebCore::InlineFlowBox::setHorizontalOverflowPositions):
(WebCore::InlineFlowBox::setVerticalOverflowPositions):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::layout):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromBlockChildren):
(WebCore::RenderBlock::handleBottomOfBlock):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::fillInlineSelectionGaps):
(WebCore::RenderBlock::floatRect):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::RenderBlock::layoutColumns):
(WebCore::getHeightForLineCount):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeHorizontalPositionsForLine):
(WebCore::RenderBlock::computeVerticalPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::addOverflowFromInlineChildren):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::destroy):
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::localCaretRect):
(WebCore::RenderBox::addShadowAndReflectionOverflow):
(WebCore::RenderBox::addOverflowFromChild):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::addVisualOverflow):
(WebCore::RenderBox::clearLayoutOverflow):
* rendering/RenderBox.h:
(WebCore::RenderBox::combinedOverflowRect):
(WebCore::RenderBox::topCombinedOverflow):
(WebCore::RenderBox::bottomCombinedOverflow):
(WebCore::RenderBox::leftCombinedOverflow):
(WebCore::RenderBox::rightCombinedOverflow):
(WebCore::RenderBox::layoutOverflowRect):
(WebCore::RenderBox::topLayoutOverflow):
(WebCore::RenderBox::bottomLayoutOverflow):
(WebCore::RenderBox::leftLayoutOverflow):
(WebCore::RenderBox::rightLayoutOverflow):
(WebCore::RenderBox::visualOverflowRect):
(WebCore::RenderBox::topVisualOverflow):
(WebCore::RenderBox::bottomVisualOverflow):
(WebCore::RenderBox::leftVisualOverflow):
(WebCore::RenderBox::rightVisualOverflow):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::localBoundingBox):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
* rendering/RenderObject.h:
* rendering/RenderOverflow.h: Added.
(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::topLayoutOverflow):
(WebCore::RenderOverflow::bottomLayoutOverflow):
(WebCore::RenderOverflow::leftLayoutOverflow):
(WebCore::RenderOverflow::rightLayoutOverflow):
(WebCore::RenderOverflow::topVisualOverflow):
(WebCore::RenderOverflow::bottomVisualOverflow):
(WebCore::RenderOverflow::leftVisualOverflow):
(WebCore::RenderOverflow::rightVisualOverflow):
(WebCore::RenderOverflow::setTopLayoutOverflow):
(WebCore::RenderOverflow::setBottomLayoutOverflow):
(WebCore::RenderOverflow::setLeftLayoutOverflow):
(WebCore::RenderOverflow::setRightLayoutOverflow):
(WebCore::RenderOverflow::setTopVisualOverflow):
(WebCore::RenderOverflow::setBottomVisualOverflow):
(WebCore::RenderOverflow::setLeftVisualOverflow):
(WebCore::RenderOverflow::setRightVisualOverflow):
(WebCore::RenderOverflow::layoutOverflowRect):
(WebCore::RenderOverflow::visualOverflowRect):
(WebCore::RenderOverflow::combinedOverflowRect):
(WebCore::RenderOverflow::move):
(WebCore::RenderOverflow::addLayoutOverflow):
(WebCore::RenderOverflow::addVisualOverflow):
(WebCore::RenderOverflow::resetLayoutOverflow):
* rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::layout):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::~RenderReplaced):
(WebCore::RenderReplaced::layout):
(WebCore::RenderReplaced::shouldPaint):
(WebCore::RenderReplaced::positionForPoint):
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):
* rendering/RenderReplaced.h:
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::layout):
(WebCore::RenderScrollbarPart::paintIntoRect):
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::layout):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
(WebCore::RenderTable::paint):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
* rendering/RenderTableSection.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::localCaretRect):
* rendering/RenderView.cpp:
(WebCore::RenderView::layout):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::addHighlightOverflow):
(WebCore::RootInlineBox::adjustPosition):
(WebCore::RootInlineBox::verticallyAlignBoxes):
(WebCore::RootInlineBox::selectionTop):
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::nextRootBox):
(WebCore::RootInlineBox::prevRootBox):
(WebCore::RootInlineBox::lineTop):
(WebCore::RootInlineBox::lineBottom):
(WebCore::RootInlineBox::selectionBottom):
(WebCore::RootInlineBox::selectionHeight):
(WebCore::RootInlineBox::floats):
(WebCore::RootInlineBox::floatsPtr):
(WebCore::RootInlineBox::setLineTopBottomPositions):
* rendering/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::layoutInlineBoxes):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=20329, shadows and reflections incorrectly being included
as part of scrollable overflow.

Reviewed by Dan Bernstein.

Update layout tests to account for all of the changes made to overflow to split it into two types.  Remove the layout
tests that were recently added that assumed that shadows and reflections should be part of scrollable overflow.

* fast/box-shadow/box-shadow-overflow-scroll-expected.txt: Removed.
* fast/box-shadow/box-shadow-overflow-scroll.html: Removed.
* fast/reflections/reflection-overflow-scroll-expected.txt: Removed.
* fast/reflections/reflection-overflow-scroll.html: Removed.
* platform/mac/compositing/overflow/ancestor-overflow-expected.txt:
* platform/mac/compositing/reflections/reflection-on-composited-expected.txt:
* platform/mac/editing/deleting/delete-br-011-expected.txt:
* platform/mac/editing/deleting/delete-br-012-expected.txt:
* platform/mac/editing/pasteboard/select-element-1-expected.txt:
* platform/mac/fast/block/positioning/relative-overflow-block-expected.txt:
* platform/mac/fast/body-propagation/background-color/002-expected.txt:
* platform/mac/fast/body-propagation/background-color/002-xhtml-expected.txt:
* platform/mac/fast/body-propagation/background-image/002-expected.txt:
* platform/mac/fast/body-propagation/background-image/002-xhtml-expected.txt:
* platform/mac/fast/body-propagation/overflow/001-expected.txt:
* platform/mac/fast/body-propagation/overflow/001-xhtml-expected.txt:
* platform/mac/fast/body-propagation/overflow/005-declarative-expected.txt:
* platform/mac/fast/body-propagation/overflow/005-expected.txt:
* platform/mac/fast/body-propagation/overflow/005-xhtml-expected.txt:
* platform/mac/fast/borders/fieldsetBorderRadius-expected.txt:
* platform/mac/fast/box-shadow/transform-fringing-expected.txt:
* platform/mac/fast/clip/008-expected.txt:
* platform/mac/fast/clip/011-expected.txt:
* platform/mac/fast/clip/012-expected.txt:
* platform/mac/fast/dynamic/genContentDestroyChildren-expected.txt:
* platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.txt:
* platform/mac/fast/encoding/utf-16-big-endian-expected.txt:
* platform/mac/fast/encoding/utf-16-little-endian-expected.txt:
* platform/mac/fast/forms/form-element-geometry-expected.txt:
* platform/mac/fast/images/image-in-map-expected.txt:
* platform/mac/fast/inline-block/003-expected.txt:
* platform/mac/fast/inline/inline-text-quirk-bpm-expected.txt:
* platform/mac/fast/invalid/012-expected.txt:
* platform/mac/fast/layers/normal-flow-hit-test-expected.txt:
* platform/mac/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
* platform/mac/fast/overflow/scrollRevealButton-expected.txt:
* platform/mac/fast/reflections/reflection-direction-expected.txt:
* platform/mac/fast/reflections/reflection-masks-expected.checksum:
* platform/mac/fast/reflections/reflection-masks-expected.png:
* platform/mac/fast/reflections/reflection-masks-expected.txt:
* platform/mac/fast/reflections/reflection-masks-opacity-expected.checksum:
* platform/mac/fast/reflections/reflection-masks-opacity-expected.png:
* platform/mac/fast/reflections/reflection-masks-opacity-expected.txt:
* platform/mac/fast/reflections/reflection-nesting-expected.txt:
* platform/mac/fast/reflections/reflection-overflow-hidden-expected.png:
* platform/mac/fast/reflections/reflection-overflow-hidden-expected.txt:
* platform/mac/fast/repaint/box-shadow-h-expected.txt:
* platform/mac/fast/repaint/box-shadow-v-expected.txt:
* platform/mac/fast/repaint/reflection-redraw-expected.txt:
* platform/mac/fast/repaint/reflection-repaint-test-expected.txt:
* platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
* platform/mac/fast/repaint/transform-replaced-shadows-expected.txt:
* platform/mac/fast/replaced/border-radius-clip-expected.txt:
* platform/mac/fast/transforms/shadows-expected.txt:
* platform/mac/fast/transforms/transforms-with-opacity-expected.txt:
* platform/mac/media/video-layer-crash-expected.txt:
* platform/mac/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
* platform/mac/tables/mozilla/bugs/bug10565-expected.txt:
* platform/mac/tables/mozilla/bugs/bug10633-expected.txt:
* platform/mac/tables/mozilla/bugs/bug113424-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
* platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
* platform/mac/tables/mozilla/bugs/bug22513-expected.txt:
* platform/mac/tables/mozilla/bugs/bug26553-expected.txt:
* platform/mac/tables/mozilla/bugs/bug3309-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4427-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
* platform/mac/tables/mozilla/bugs/bug5538-expected.txt:
* platform/mac/tables/mozilla/bugs/bug78162-expected.txt:
* platform/mac/tables/mozilla/bugs/bug8381-expected.txt:
* platform/mac/tables/mozilla/bugs/bug86708-expected.txt:
* platform/mac/tables/mozilla/core/bloomberg-expected.txt:
* platform/mac/tables/mozilla/other/ms-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt:
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt:
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt:
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt:
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Tue, 18 Aug 2009 19:03:16 +0000 (19:03 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=28431
        <rdar://problem/7137610> Application Cache doesn't work with HTTP authentication

        Test: http/tests/appcache/auth.html

        * loader/appcache/ApplicationCacheGroup.h:
        (WebCore::ApplicationCacheGroup::shouldUseCredentialStorage): If appcache is enabled,
        always allow it to use stored credentials (we can't ask WebKit client, and maybe we
        shouldn't ask it, because it's not a document that's loading these resources).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix <rdar://problem/7147996>
andersca@apple.com [Tue, 18 Aug 2009 18:56:21 +0000 (18:56 +0000)]
Fix <rdar://problem/7147996>

Reviewed by John Sullivan and David Hyatt.

* platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
Update the style of the scroll bars.

* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::RenderScrollbar):
Calculate the size of the scrollbar and set it as the frame size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed. Forgot to add pixel test results for html-fieldset-crash.html some...
zimmermann@webkit.org [Tue, 18 Aug 2009 18:54:33 +0000 (18:54 +0000)]
Not reviewed. Forgot to add pixel test results for html-fieldset-crash.html some time ago.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed (Updating skipped tests).
atwilson@chromium.org [Tue, 18 Aug 2009 18:44:00 +0000 (18:44 +0000)]
Unreviewed (Updating skipped tests).

Re-enabled test on GTK platform (DRT supports layoutTestController.workerThreadCount on GTK).

Disabled test on QT platform (DRT does not support workerThreadCount on QT).

* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 18 Aug 2009 18:42:17 +0000 (18:42 +0000)]
2009-08-18  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by NOBODY (build fix).

        Update results added for https://bugs.webkit.org/show_bug.cgi?id=28314 to
        not log 'progress' event as the timing relative to other media events
        isn't important and varies according to the behavior of the media engine.

        * media/event-attributes-expected.txt:
        * media/event-attributes.html:
        * media/progress-event-at-least-one-expected.txt:
        * media/progress-event-at-least-one.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed (build break).
atwilson@chromium.org [Tue, 18 Aug 2009 18:40:19 +0000 (18:40 +0000)]
Unreviewed (build break).

Added missing include for WebWorkersPrivate.h.

* WebKitClassFactory.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed - skipping test on GTK.
atwilson@chromium.org [Tue, 18 Aug 2009 18:35:00 +0000 (18:35 +0000)]
Unreviewed - skipping test on GTK.

Added worker-lifecycle.html tests to skipped tests on GTK platform due to missing DRT functionality.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSpeculative fix for GTK DumpRenderTree.
atwilson@chromium.org [Tue, 18 Aug 2009 18:14:26 +0000 (18:14 +0000)]
Speculative fix for GTK DumpRenderTree.

Reviewed by NOBODY (Build Break).

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 18 Aug 2009 17:46:21 +0000 (17:46 +0000)]
2009-08-18  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        HTMLMediaElement should fire 'progress' event before 'load'
        https://bugs.webkit.org/show_bug.cgi?id=28314

        Test: media/progress-event-at-least-one.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::setNetworkState):
            Schedule 'progress' event before 'load'.

2009-08-18  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        HTMLMediaElement should fire 'progress' event before 'load'
        https://bugs.webkit.org/show_bug.cgi?id=28314

        * media/event-attributes-expected.txt:
            Update results to include 'progress' event fired before 'load'.

        * media/progress-event-at-least-one-expected.txt: Added.
        * media/progress-event-at-least-one.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=28415
pkasting@chromium.org [Tue, 18 Aug 2009 17:44:09 +0000 (17:44 +0000)]
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=28415
Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
have it.

Reviewed by Eric Seidel.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
* JavaScriptCore.vcproj/testapi/testapi.vcproj:

WebCore: https://bugs.webkit.org/show_bug.cgi?id=28415
Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
have it.

Reviewed by Eric Seidel.

* WebCore.vcproj/QTMovieWin.vcproj:
* WebCore.vcproj/WebCoreGenerated.vcproj:

WebKit/win: https://bugs.webkit.org/show_bug.cgi?id=28415
Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
have it.

Reviewed by Eric Seidel.

* WebKit.vcproj/InterfacesGenerated.vcproj:

WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=28415
Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
have it.

Reviewed by Eric Seidel.

* record-memory-win/record-memory-win.vcproj:
* WinLauncher/WinLauncher.vcproj:
* WebKitLauncherWin/WebKitLauncherWin.vcproj:
* DumpRenderTree/win/ImageDiff.vcproj:
* FindSafari/FindSafari.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Need to extend DumpRenderTree to expose number of worker threads
atwilson@chromium.org [Tue, 18 Aug 2009 17:35:36 +0000 (17:35 +0000)]
WebCore: Need to extend DumpRenderTree to expose number of worker threads
https://bugs.webkit.org/show_bug.cgi?id=28292

Reviewed by Eric Seidel.

Expose WorkerThread::workerThreadCount() for DumpRenderTree so we can write worker lifecycle tests.

Tests: fast/workers/shared-worker-lifecycle.html-disabled
       fast/workers/worker-lifecycle.html

* WebCore.base.exp:
Exported WorkerThread::workerThreadCount().
* WebCore.xcodeproj/project.pbxproj:
* workers/WorkerThread.cpp:
Added tracking of the number of worker threads.
(WebCore::threadCountMutex):
(WebCore::WorkerThread::workerThreadCount):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::~WorkerThread):
* workers/WorkerThread.h:

WebKit: Need to extend DumpRenderTree to expose number of worker threads.
https://bugs.webkit.org/show_bug.cgi?id=28292

Reviewed by Eric Seidel.

* WebKit.xcodeproj/project.pbxproj:
Added WebWorkersPrivate APIs to mac WebKit to expose workerThreadCount() for DumpRenderTree.

WebKit/gtk: Need to extend DumpRenderTree to expose number of worker threads
https://bugs.webkit.org/show_bug.cgi?id=28292

Reviewed by Eric Seidel.

* webkit/webkitprivate.h:
* webkit/webkitworkers.cpp: Added.
(webkit_worker_thread_count):
Exposed WebCore::WorkerThread::workerThreadCount() for the gtk version of DumpRenderTree.

WebKit/mac: Need to extend DumpRenderTree to expose number of worker threads.
https://bugs.webkit.org/show_bug.cgi?id=28292

Reviewed by Eric Seidel.

* WebKit.exp:
Exported WebWorkersPrivate so DumpRenderTree can access it.
* Workers/WebWorkersPrivate.h: Added.
* Workers/WebWorkersPrivate.mm: Added.
(+[WebWorkersPrivate workerThreadCount]):
Added WebWorkersPrivate::workerThreadCount() API for DumpRenderTree.

WebKit/win: Need to extend DumpRenderTree to expose number of worker threads
https://bugs.webkit.org/show_bug.cgi?id=28292

Reviewed by Eric Seidel.

Defined/implemented COM interfaces to expose WorkerThread::workerThreadCount() for DumpRenderTree.

* ForEachCoClass.h:
Added WebWorkersPrivate.
* Interfaces/IWebWorkersPrivate.idl: Added.
* Interfaces/WebKit.idl:
Added WebWorkersPrivate.
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKit.vcproj:
* WebWorkersPrivate.cpp: Added.
Implementation of the IWebWorkersPrivate COM interface, to expose workerThreadCount() for DumpRenderTree.
(WebWorkersPrivate::QueryInterface):
(WebWorkersPrivate::AddRef):
(WebWorkersPrivate::Release):
(WebWorkersPrivate::workerThreadCount):
(WebWorkersPrivate::createInstance):
(WebWorkersPrivate::WebWorkersPrivate):
(WebWorkersPrivate::~WebWorkersPrivate):
* WebWorkersPrivate.h: Added.

WebKitTools: Need to extend DumpRenderTree to expose number of worker threads
https://bugs.webkit.org/show_bug.cgi?id=28292

Reviewed by Eric Seidel.

Added layoutTestController.workerThreadCount, and implementations on various platforms that call into WebKit.

* DumpRenderTree/LayoutTestController.cpp:
(getWorkerThreadCountCallback):
(LayoutTestController::staticValues):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::workerThreadCount):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::workerThreadCount):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::workerThreadCount):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::workerThreadCount):

LayoutTests: Need to extend DumpRenderTree to expose number of worker threads
https://bugs.webkit.org/show_bug.cgi?id=28292

Reviewed by Eric Seidel.

Added simple layout tests that use the new layoutTestController.workerThreadCount() API

* fast/workers/resources/shared-worker-common.js:
Added support for "close" command to match worker-common.js.
* fast/workers/resources/worker-lifecycle.js: Added.
* fast/workers/shared-worker-lifecycle-expected.txt: Added.
* fast/workers/shared-worker-lifecycle.html-disabled: Added.
* fast/workers/worker-lifecycle-expected.txt: Added.
* fast/workers/worker-lifecycle.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Tue, 18 Aug 2009 15:21:20 +0000 (15:21 +0000)]
2009-08-18  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        Mention handy --bug flag of prepare-ChangeLog script.
        https://bugs.webkit.org/show_bug.cgi?id=28425

        * coding/contributing.html: Add a reference for --bug flag

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 18 Aug 2009 14:31:47 +0000 (14:31 +0000)]
2009-08-18  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Fix the ATK unit test.

        We now support line boundaries in the get_text functions, so we
        need to make sure the test has the layout we expect by giving it
        enough space to fit in one line.

        * tests/testatk.c:
        (test_webkit_atk_get_text_at_offset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Andras Becsi <becsi.andras@stud.u-szeged.hu>
ariya@webkit.org [Tue, 18 Aug 2009 12:49:35 +0000 (12:49 +0000)]
2009-08-18  Andras Becsi  <becsi.andras@stud.u-szeged.hu>

        Reviewed by Ariya Hidayat.

        [Qt] These tests pass now. Fixed metrics related to default font size and added some expected files for new tests.

        * platform/qt/Skipped:
        * platform/qt/fast/images/animated-gif-with-offsets-expected.txt:
        * platform/qt/fast/images/animated-svg-as-image-expected.txt: Added.
        * platform/qt/fast/images/embed-image-expected.txt: Added.
        * platform/qt/fast/images/favicon-as-image-expected.txt: Added.
        * platform/qt/fast/images/object-image-expected.txt: Added.
        * platform/qt/fast/images/svg-as-background-expected.txt:
        * platform/qt/fast/images/svg-as-image-expected.txt:
        * platform/qt/fast/images/svg-as-relative-image-expected.txt: Added.
        * platform/qt/fast/images/svg-width-100p-as-background-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Tue, 18 Aug 2009 12:44:50 +0000 (12:44 +0000)]
2009-08-18  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Unreviewed, build fix.

        [Qt] Add new files I forgot to add in r47424.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore/ChangeLog:
ariya@webkit.org [Tue, 18 Aug 2009 12:23:29 +0000 (12:23 +0000)]
WebCore/ChangeLog:

2009-08-18  Markus Goetz <Markus.Goetz@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Implement prefetchDNS() function.

        * WebCore.pro:
        * platform/qt/TemporaryLinkStubs.cpp:

WebKit/qt/ChangeLog:

2009-08-18  Markus Goetz <Markus.Goetz@nokia.com>

        Reviwed by Ariya Hidayat.

        [Qt] For prefecthDNS, the pre-fetching has to be enabled in the
        WebSettings.

        * Api/qwebsettings.cpp:
        (QWebSettings::QWebSettings):
        * Api/qwebsettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 18 Aug 2009 12:02:29 +0000 (12:02 +0000)]
2009-08-18  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        Initialize x and y in the GtkAllocation structure to shut up
        valgrind.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 18 Aug 2009 07:35:32 +0000 (07:35 +0000)]
2009-08-18  Xan Lopez  <xlopez@igalia.com>

        Try to fix the GTK+ build.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Shinichiro Hamaji <hamaji@chromium.org>
eric@webkit.org [Tue, 18 Aug 2009 07:33:11 +0000 (07:33 +0000)]
2009-08-18  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        Assertion failure in WebCore::RenderHTMLCanvas::layout
        https://bugs.webkit.org/show_bug.cgi?id=12052

        Remove string "foo" in <video> tag. This made Qt layout test fail.
        Qt doesn't support video yet and the string will be rendered.

        * fast/runin/nonblock-runin.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-18 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Tue, 18 Aug 2009 07:16:12 +0000 (07:16 +0000)]
2009-08-18  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Add --enable-datalist option.

        * configure.ac:

2009-08-18  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Tests for <datalist> element.
        https://bugs.webkit.org/show_bug.cgi?id=26915

        * fast/forms/datalist-expected.txt: Added.
        * fast/forms/datalist-nonoption-child-expected.txt: Added.
        * fast/forms/datalist-nonoption-child.html: Added.
        * fast/forms/datalist.html: Added.

2009-08-18  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Support for parsing <datalist> element and generating HTMLDataListElement nodes.
        https://bugs.webkit.org/show_bug.cgi?id=26915

        Tests: fast/forms/datalist-nonoption-child.html
               fast/forms/datalist.html

        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/WebCoreCommon.vsprops:
        * WebCore.vcproj/build-generated-files.sh:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * css/html.css:
        * html/CollectionType.h:
        (WebCore::):
        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::itemAfter):
        * html/HTMLDataListElement.cpp: Added.
        (WebCore::HTMLDataListElement::HTMLDataListElement):
        (WebCore::HTMLDataListElement::~HTMLDataListElement):
        (WebCore::HTMLDataListElement::checkDTD):
        (WebCore::HTMLDataListElement::options):
        * html/HTMLDataListElement.h: Added.
        * html/HTMLDataListElement.idl: Added.
        * html/HTMLElement.cpp:
        (WebCore::inlineTagList):
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::isAffectedByResidualStyle):
        * html/HTMLTagNames.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-17 Shinichiro Hamaji <hamaji@chromium.org>
eric@webkit.org [Tue, 18 Aug 2009 06:35:11 +0000 (06:35 +0000)]
2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Some HTMLs are modified by make-script-test-wrappers
        https://bugs.webkit.org/show_bug.cgi?id=28213

        Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
        the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
        re-generated wml/* and Geolocation/* .

        * fast/dom/Geolocation/enabled.html:
        * fast/dom/Geolocation/resources/TEMPLATE.html:
        * http/tests/wml/access-target-domain-deny.html:
        * http/tests/wml/access-target-path-deny.html:
        * http/tests/wml/access-target.html:

2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Some HTMLs are modified by make-script-test-wrappers
        https://bugs.webkit.org/show_bug.cgi?id=28213

        Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
        the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
        re-generated wml/* and Geolocation/* .

        * Scripts/make-script-test-wrappers:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-17 Shinichiro Hamaji <hamaji@chromium.org>
eric@webkit.org [Tue, 18 Aug 2009 06:26:56 +0000 (06:26 +0000)]
2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        -webkit-box-orient:horizontal doesn't work on <button> tag
        https://bugs.webkit.org/show_bug.cgi?id=34445

        Make a flexible button's anonymous child flexible and pass the
        parent's box-orient to the anonymous child.

        Also, added a renderName for anonymous flexible boxes.

        * fast/flexbox/box-orient-button-expected.txt: Added.
        * fast/flexbox/box-orient-button.html: Added.
        * fast/flexbox/resources/box-orient-button.js: Added.
        (setBoxOrient):
        (gebi):

2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        -webkit-box-orient:horizontal doesn't work on <button> tag
        https://bugs.webkit.org/show_bug.cgi?id=34445

        Make a flexible button's anonymous child flexible and pass the
        parent's box-orient to the anonymous child.

        Also, added a renderName for anonymous flexible boxes.

        Test: fast/flexbox/box-orient-button.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::createAnonymousBlock):
        * rendering/RenderBlock.h:
        * rendering/RenderButton.cpp:
        (WebCore::RenderButton::addChild):
        (WebCore::RenderButton::setupInnerStyle):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::renderName):

2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        -webkit-box-orient:horizontal doesn't work on <button> tag
        https://bugs.webkit.org/show_bug.cgi?id=34445

        Make a flexible button's anonymous child flexible and pass the
        parent's box-orient to the anonymous child.

        Also, added a renderName for anonymous flexible boxes.

        * Scripts/make-script-test-wrappers:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoadd THE CORRECT new file to lunix builds (you idiot).
barraclough@apple.com [Tue, 18 Aug 2009 06:20:22 +0000 (06:20 +0000)]
add THE CORRECT new file to lunix builds (you idiot).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoadd new file to lunix builds.
barraclough@apple.com [Tue, 18 Aug 2009 06:08:46 +0000 (06:08 +0000)]
add new file to lunix builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agospeculative interpretoid build fixeration.
barraclough@apple.com [Tue, 18 Aug 2009 05:56:23 +0000 (05:56 +0000)]
speculative interpretoid build fixeration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agospeculative 'doze build fixeration II.
barraclough@apple.com [Tue, 18 Aug 2009 05:49:15 +0000 (05:49 +0000)]
speculative 'doze build fixeration II.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agospeculative 'doze build fixeration.
barraclough@apple.com [Tue, 18 Aug 2009 05:42:34 +0000 (05:42 +0000)]
speculative 'doze build fixeration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNo, silly runtime, AST nodes are not for you.
barraclough@apple.com [Tue, 18 Aug 2009 05:34:52 +0000 (05:34 +0000)]
No, silly runtime, AST nodes are not for you.

Reviewed by Sam Weinig.

We still use AST nodes (ScopeNodes, particularly FunctionBodyNodes) within
the runtime, which means that these nodes must be persisted outside of the
arena, contain both parser & runtime data, etc.  This is all a bit of a mess.

Move functionality into a new FunctionExecutable class.

* API/JSCallbackFunction.cpp:
* API/JSObjectRef.cpp:
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::markAggregate):
(JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::getBytecodeIndex):
(JSC::CodeBlock::discardBytecode):
(JSC::CodeBlock::instructionCount):
(JSC::CodeBlock::getJITCode):
(JSC::CodeBlock::executablePool):
(JSC::CodeBlock::ownerExecutable):
(JSC::CodeBlock::extractExceptionInfo):
(JSC::CodeBlock::addFunctionDecl):
(JSC::CodeBlock::functionDecl):
(JSC::CodeBlock::numberOfFunctionDecls):
(JSC::CodeBlock::addFunctionExpr):
(JSC::CodeBlock::functionExpr):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::NativeCodeBlock::NativeCodeBlock):
* bytecode/EvalCodeCache.h:
* bytecode/SamplingTool.cpp:
(JSC::SamplingTool::doRun):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionExpression):
* bytecompiler/BytecodeGenerator.h:
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall):
* interpreter/CallFrameClosure.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::debug):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):
* interpreter/Interpreter.h:
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JSC::JIT::compile):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::emit_op_new_func):
(JSC::JIT::emit_op_new_func_exp):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC::):
* parser/Nodes.cpp:
(JSC::FunctionBodyNode::reparseDataIfNecessary):
* parser/Nodes.h:
(JSC::EvalNode::partialDestroyData):
* parser/Parser.h:
* profiler/ProfileGenerator.cpp:
* profiler/Profiler.cpp:
(JSC::Profiler::createCallIdentifier):
(JSC::createCallIdentifierFromFunctionImp):
* runtime/Arguments.h:
(JSC::Arguments::getArgumentsData):
(JSC::Arguments::Arguments):
(JSC::JSActivation::copyRegisters):
* runtime/ArrayPrototype.cpp:
(JSC::isNumericCompareFunction):
* runtime/CallData.h:
(JSC::):
* runtime/Collector.cpp:
(JSC::Heap::collect):
* runtime/ConstructData.h:
(JSC::):
* runtime/ExceptionHelpers.cpp:
(JSC::createUndefinedVariableError):
(JSC::createInvalidParamError):
(JSC::createNotAConstructorError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):
* runtime/Executable.cpp: Added.
(JSC::EvalExecutable::generateBytecode):
(JSC::ProgramExecutable::generateBytecode):
(JSC::FunctionExecutable::generateBytecode):
(JSC::EvalExecutable::generateJITCode):
(JSC::ProgramExecutable::generateJITCode):
(JSC::FunctionExecutable::generateJITCode):
(JSC::FunctionExecutable::isHostFunction):
(JSC::FunctionExecutable::markAggregate):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::recompile):
(JSC::FunctionExecutable::FunctionExecutable):
* runtime/Executable.h:
(JSC::ExecutableBase::~ExecutableBase):
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::source):
(JSC::ExecutableBase::sourceID):
(JSC::ExecutableBase::lastLine):
(JSC::ExecutableBase::usesEval):
(JSC::ExecutableBase::usesArguments):
(JSC::ExecutableBase::needsActivation):
(JSC::ExecutableBase::astNode):
(JSC::ExecutableBase::generatedJITCode):
(JSC::ExecutableBase::getExecutablePool):
(JSC::EvalExecutable::EvalExecutable):
(JSC::EvalExecutable::bytecode):
(JSC::EvalExecutable::varStack):
(JSC::EvalExecutable::evalNode):
(JSC::EvalExecutable::jitCode):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::ProgramExecutable::reparseExceptionInfo):
(JSC::ProgramExecutable::bytecode):
(JSC::ProgramExecutable::programNode):
(JSC::ProgramExecutable::jitCode):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::name):
(JSC::FunctionExecutable::bytecode):
(JSC::FunctionExecutable::generatedBytecode):
(JSC::FunctionExecutable::usesEval):
(JSC::FunctionExecutable::usesArguments):
(JSC::FunctionExecutable::parameterCount):
(JSC::FunctionExecutable::paramString):
(JSC::FunctionExecutable::isGenerated):
(JSC::FunctionExecutable::body):
(JSC::FunctionExecutable::jitCode):
(JSC::FunctionExecutable::createNativeThunk):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::markChildren):
(JSC::JSActivation::isDynamicScope):
(JSC::JSActivation::argumentsGetter):
* runtime/JSActivation.h:
(JSC::JSActivation::JSActivationData::JSActivationData):
* runtime/JSFunction.cpp:
(JSC::JSFunction::isHostFunction):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::markChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::call):
(JSC::JSFunction::lengthGetter):
(JSC::JSFunction::getConstructData):
(JSC::JSFunction::construct):
* runtime/JSFunction.h:
(JSC::JSFunction::executable):
(JSC::FunctionExecutable::make):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::numericCompareFunction):
* runtime/JSGlobalData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert r47399 as Eric landed it in the wrong directory.
mrowe@apple.com [Tue, 18 Aug 2009 05:12:49 +0000 (05:12 +0000)]
Revert r47399 as Eric landed it in the wrong directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-17 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 18 Aug 2009 03:57:08 +0000 (03:57 +0000)]
2009-08-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt.

        Render -webkit-mask via compositing layers when possible
        https://bugs.webkit.org/show_bug.cgi?id=28414

        Implement accelerated compositing of -webkit-mask, when combined
        with already-composited content.

        RenderLayerBacking now creates an additional GraphicsLayer for the mask contents,
        and sets this as the mask on another GraphicsLayer via the setMaskLayer() method.
        GraphicsLayerCA then applies the mask using -[CALayer setMask:].

        The enum values for GraphicsLayerPaintingPhase were renamed to avoid the
        confusion with "mask", and a new value, GraphicsLayerPaintMask, was added which
        indicates that just the mask is painting.

        When painting the composited mask, we need to paint with the normal compositing
        mode rather than CompositeDestinationIn, so InlineFlowBox and RenderBox now consult
        layer()->hasCompositedMask() to pick the mode. If the mask is composited, they no longer
        need to make transparency layers.

        We no longer have to throw video rendering into software because of masks.

        When a masked element has composited descendants, that element needs to
        become composited so that the mask can be applied via compositing.

        Tests: compositing/masks/masked-ancestor.html
               compositing/masks/simple-composited-mask.html

        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::GraphicsLayer):
        * platform/graphics/GraphicsLayer.h:
        (WebCore::GraphicsLayer::maskLayer):
        (WebCore::GraphicsLayer::setMaskLayer):
        (WebCore::GraphicsLayer::paintingPhase):
        (WebCore::GraphicsLayer::setPaintingPhase):
        * platform/graphics/GraphicsLayerClient.h:
        (WebCore::):
        * platform/graphics/mac/GraphicsLayerCA.h:
        (WebCore::GraphicsLayerCA::):
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::setMaskLayer):
        (WebCore::GraphicsLayerCA::recursiveCommitChanges):
        (WebCore::GraphicsLayerCA::commitLayerChanges):
        (WebCore::GraphicsLayerCA::updateMaskLayer):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintMask):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintMaskImages):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hasCompositedMask):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::hasCompositedMask):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::~RenderLayerBacking):
        (WebCore::RenderLayerBacking::destroyGraphicsLayer):
        (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
        (WebCore::RenderLayerBacking::updateForegroundLayer):
        (WebCore::RenderLayerBacking::updateMaskLayer):
        (WebCore::RenderLayerBacking::paintingPhaseForPrimaryLayer):
        (WebCore::RenderLayerBacking::setContentsNeedDisplay):
        (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
        (WebCore::RenderLayerBacking::paintIntoLayer):
        (WebCore::RenderLayerBacking::paintContents):
        * rendering/RenderLayerBacking.h:
        (WebCore::RenderLayerBacking::hasMaskLayer):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::computeCompositingRequirements):
        (WebCore::RenderLayerCompositor::canAccelerateVideoRendering):
        (WebCore::RenderLayerCompositor::requiresCompositingWhenDescendantsAreCompositing):
        * rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-17 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 18 Aug 2009 03:31:57 +0000 (03:31 +0000)]
2009-08-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt.

        Layer content misplaced with compositing, z-index and overflow
        https://bugs.webkit.org/show_bug.cgi?id=28361

        The foreground GraphicsLayer (used to render element foreground when the element has
        negative z-order children) was misplaced when there is a clipping layer (which clips
        children). The foreground layer is parented under the clipping layer so that the foreground
        depth-sorts with the layer's children, so its geometry needs to be computed relative to
        that clipping layer.

        Also clarified some FIXME comments, and corrected a debug-only layer name.

        Test: compositing/geometry/clipping-foreground.html

        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::updateSublayerList):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
        (WebCore::RenderLayerBacking::updateForegroundLayer):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix leaks of SVGElementInstance seen during regression tests.
mrowe@apple.com [Tue, 18 Aug 2009 02:58:59 +0000 (02:58 +0000)]
Fix leaks of SVGElementInstance seen during regression tests.

Reviewed by Sam Weinig.

r47313 made TreeShared types start with a ref-count of 1, but SVGElementInstance was mistakenly
not updated to have a create method that adopted the initial reference.  This lead to the instances
of SVGElementInstance allocated by SVGUseElement being leaked.

* svg/SVGElementInstance.h:
(WebCore::SVGElementInstance::create):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildInstanceTree):
(WebCore::SVGUseElement::handleDeepUseReferencing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSome cleanup towards https://bugs.webkit.org/show_bug.cgi?id=13631
beidson@apple.com [Tue, 18 Aug 2009 01:37:56 +0000 (01:37 +0000)]
Some cleanup towards https://bugs.webkit.org/show_bug.cgi?id=13631
Page Cache should support pages with frames.

Reviewed by Sam Weinig.

- Re-factor all remaining page cache code out of DocumentLoader, as CachedPage/CacheFrame loads
  are solely the responsibility of FrameLoader.
- Enhance some page cache related Logging to help development.

* inspector/InspectorController.cpp:
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::identifierForInitialRequest):

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
* loader/DocumentLoader.h:

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
* loader/FrameLoader.h:
(WebCore::FrameLoader::isLoadingFromCachedPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-17 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Tue, 18 Aug 2009 01:18:36 +0000 (01:18 +0000)]
2009-08-17  Brian Weinstein  <bweinstein@apple.com>

        Rubber-stamped by Adele Peterson.

        http/tests/misc/favicon-loads-with-images-disabled.html was passing on my machine
        (when I ran all http tests), but failed on the bot, so adding it back to the
        Skipped list.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix 300,000+ leaks seen during the regression tests.
mrowe@apple.com [Tue, 18 Aug 2009 01:05:37 +0000 (01:05 +0000)]
Fix 300,000+ leaks seen during the regression tests.

Reviewed by Darin Adler.

EvalCodeCache::get was heap-allocating an EvalExecutable instance without adopting the initial reference.
While fixing this we noticed that EvalExecutable was a RefCounted type that was sometimes stack allocated.
To make this cleaner and to prevent clients from attempting to ref a stack-allocated instance, we move the
refcounting down to a new CacheableEvalExecutable class that derives from EvalExecutable. EvalCodeCache::get
now uses CacheableEvalExecutable::create and avoids the leak.

* bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::get):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
* runtime/Executable.h:
(JSC::CacheableEvalExecutable::create):
(JSC::CacheableEvalExecutable::CacheableEvalExecutable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r47292): Prototype.js is broken by ES5 Arguments changes
oliver@apple.com [Tue, 18 Aug 2009 01:00:12 +0000 (01:00 +0000)]
REGRESSION (r47292): Prototype.js is broken by ES5 Arguments changes
https://bugs.webkit.org/show_bug.cgi?id=28341
<rdar://problem/7145615>

RS=Mark Rowe

Reverting r47292.  Alas Prototype.js breaks with Arguments inheriting
from Array as ES5 attempted.  Prototype.js defines $A in terms of a
function it places on (among other global objects) the Array prototype,
thus breaking $A for arrays.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-17 Roland Steiner <rolandsteiner@google.com>
eric@webkit.org [Tue, 18 Aug 2009 00:58:10 +0000 (00:58 +0000)]
2009-08-17  Roland Steiner  <rolandsteiner@google.com>

        Reviewed by Eric Seidel.

        Moved implementation of isAfterContent to RenderObject
        (as inline method to avoid potential performance regressions).

        BUG 28376 -  [Cleanup] isAfterContent() implemented twice, should be member of RenderObject
        (https://bugs.webkit.org/show_bug.cgi?id=28376)

        * rendering/RenderBox.cpp:
        * rendering/RenderBox.h:
        * rendering/RenderInline.cpp:
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isAfterContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 18 Aug 2009 00:49:13 +0000 (00:49 +0000)]
2009-08-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin Adler.

        Can no longer --reset-results of a layout test directory
        https://bugs.webkit.org/show_bug.cgi?id=28336

        --reset-results and --exit-after-n-failures are incompatible.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-17 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Tue, 18 Aug 2009 00:40:03 +0000 (00:40 +0000)]
2009-08-17  Brian Weinstein  <bweinstein@apple.com>

        Rubber-stamped by Adele Peterson.

        http/tests/misc/favicon-loads-with-images-disabled.html is passing on my
        machine, trying to remove it from the Skipped list on Windows.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-17 Shinichiro Hamaji <hamaji@chromium.org>
eric@webkit.org [Tue, 18 Aug 2009 00:24:46 +0000 (00:24 +0000)]
2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Assertion failure in WebCore::RenderHTMLCanvas::layout
        https://bugs.webkit.org/show_bug.cgi?id=12052

        Don't handle run-in if the element is not a block element.

        * fast/runin/canvas-runin-expected.txt: Added.
        * fast/runin/canvas-runin.html: Added.

2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Assertion failure in WebCore::RenderHTMLCanvas::layout
        https://bugs.webkit.org/show_bug.cgi?id=12052

        Don't handle run-in if the element is not a block element.

        Test: fast/runin/nonblock-runin.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::handleRunInChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-17 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>
eric@webkit.org [Tue, 18 Aug 2009 00:16:44 +0000 (00:16 +0000)]
2009-08-17  Christian Plesner Hansen  <christian.plesner.hansen@gmail.com>

        Reviewed by Darin Adler.

        Regression test for bug fixed in
        http://codereview.chromium.org/171039.  Regexps created in one
        frame were not callable outside that frame.
        https://bugs.webkit.org/show_bug.cgi?id=28387

        * fast/regex/regexp-cross-frame-callable-expected.txt: Added.
        * fast/regex/regexp-cross-frame-callable.html: Added.
        * fast/regex/resources/regexp-cross-frame-callable-child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-17 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
eric@webkit.org [Tue, 18 Aug 2009 00:05:55 +0000 (00:05 +0000)]
2009-08-17  Benjamin C Meyer  <benjamin.meyer@torchmobile.com>

        Reviewed by Darin Adler.

        Fix createImageData to raise the NOT_SUPPORTED_ERR exception when
        either of the arguments are not finite.

        According to
        http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation:
        "If any of the arguments to createImageData() or getImageData() are
        infinite or NaN, or if the createImageData()  method is invoked with
        only one argument but that argument is null, the method must instead
        raise a NOT_SUPPORTED_ERR  exception."

        Test: http://philip.html5.org/tests/canvas/suite/tests/2d.imageData.create.nonfinite.html

        * fast/canvas/canvas-2d-imageData-create-nonfinite-expected.txt: Added.
        * fast/canvas/canvas-2d-imageData-create-nonfinite.html: Added.
        * fast/canvas/resources/canvas-2d-imageData-create-nonfinite.js: Added.

2009-08-17  Benjamin C Meyer  <benjamin.meyer@torchmobile.com>

        Reviewed by Darin Adler.

        Fix createImageData to raise the NOT_SUPPORTED_ERR exception when
        either of the arguments are not finite.

        According to
        http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation:
        "If any of the arguments to createImageData() or getImageData() are
        infinite or NaN, or if the createImageData()  method is invoked with
        only one argument but that argument is null, the method must instead
        raise a NOT_SUPPORTED_ERR  exception."

        Test: http://philip.html5.org/tests/canvas/suite/tests/2d.imageData.create.nonfinite.html

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::createImageData):
        * html/canvas/CanvasRenderingContext2D.h:
        * html/canvas/CanvasRenderingContext2D.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-17 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Mon, 17 Aug 2009 23:28:38 +0000 (23:28 +0000)]
2009-08-17  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Add a way to release the storage lock
        https://bugs.webkit.org/show_bug.cgi?id=28411

        Two scripts within the same origin that are accessing LocalStorage must not do
        it simultaneously, according to the spec.  There are some cases, however, where
        a script might want to override this behavior.  navigator.getStorageUpdates()
        was added for this reason:
        http://dev.w3.org/html5/spec/Overview.html#manually-releasing-the-storage-mutex

        Add this function to navigator and hook it up to DOM Storage.

        * page/Navigator.cpp:
        (WebCore::Navigator::getStorageUpdates):
        * page/Navigator.h:
        * page/Navigator.idl:
        * storage/StorageNamespace.h:
        * storage/StorageNamespaceImpl.cpp:
        (WebCore::StorageNamespaceImpl::unlock):
        * storage/StorageNamespaceImpl.h:

2009-08-17  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Add a way to release the storage lock
        https://bugs.webkit.org/show_bug.cgi?id=28411

        Two scripts within the same origin that are accessing LocalStorage must not do
        it simultaneously, according to the spec.  There are some cases, however, where
        a script might want to override this behavior.  navigator.getStorageUpdates()
        was added for this reason:
        http://dev.w3.org/html5/spec/Overview.html#manually-releasing-the-storage-mutex

        Update the test expectations to include this new element.

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/navigator-detached-no-crash-expected.txt:
        * platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
mrowe@apple.com [Mon, 17 Aug 2009 23:11:45 +0000 (23:11 +0000)]
Build fix.

CFNetwork isn't present in the framework search path on Mac OS X so we can't directly include its headers.
We include CoreServices.h, the umbrella framework that contains CFNetwork, from the prefix header which
results in the CFNetwork headers being included on Mac OS X.  CoreServices.h doesn't include CFNetwork.h on
Windows though so we explicitly include this header from the prefix header when on Windows.

* WebCorePrefix.h:
* platform/network/cf/DNSCFNet.cpp: Remove #include that is no longer needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Trying a better build fix (the previous one broke Leopard bots, although...
ap@apple.com [Mon, 17 Aug 2009 22:48:21 +0000 (22:48 +0000)]
    Trying a better build fix (the previous one broke Leopard bots, although it did build for me).

        * platform/network/cf/DNSCFNet.cpp: Include CFNetwork/CFNetwork.h instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Trying to fix Windows build.
ap@apple.com [Mon, 17 Aug 2009 22:30:11 +0000 (22:30 +0000)]
    Trying to fix Windows build.

        * platform/network/cf/DNSCFNet.cpp: Include CFNetwork/CFHost.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago <http://webkit.org/b/26920> bugzilla-tool dumps too much junk the the commit...
ddkilzer@apple.com [Mon, 17 Aug 2009 22:17:50 +0000 (22:17 +0000)]
    <webkit.org/b/26920> bugzilla-tool dumps too much junk the the commit comment from git

        Reviewed by Adam Roben.

        New commit message:
            Committed r12345: <http://trac.webkit.org/changeset/12345>

        * Scripts/bugzilla-tool:
        (bug_comment_from_commit_text): Print out a compact,
        standardized commit message for both git and svn.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=27323
pkasting@chromium.org [Mon, 17 Aug 2009 22:12:15 +0000 (22:12 +0000)]
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there.  This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

Reviewed by Steve Falkenburg.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
* JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
* JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:

WebCore: https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there.  This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

Reviewed by Steve Falkenburg.

* WebCore.vcproj/QTMovieWin.vcproj:
* WebCore.vcproj/WebCoreCommon.vsprops:
* WebCore.vcproj/WebCoreGenerated.vcproj:

WebKit/win: https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there.  This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

Reviewed by Steve Falkenburg.

* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/InterfacesGenerated.vcproj:
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:

WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there.  This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

Reviewed by Steve Falkenburg.

* DumpRenderTree/win/DumpRenderTree.vcproj:
* DumpRenderTree/win/ImageDiff.vcproj:
* DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Geoff Garen.
ap@apple.com [Mon, 17 Aug 2009 22:08:01 +0000 (22:08 +0000)]
    Reviewed by Geoff Garen.

        https://bugs.webkit.org/show_bug.cgi?id=28401
        Add support for DNS prefetching with CFNetwork

        This is just an optimization, no behavior change, so no tests.

        * platform/network/cf/DNSCFNet.cpp:
        (WebCore::clientCallback):
        (WebCore::prefetchDNS):
        Use async CFHostStartInfoResolution() for implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 17 Aug 2009 21:48:25 +0000 (21:48 +0000)]
2009-08-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed. Skip new tests.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Rubber-stamped by Dan Bernstein.
ap@apple.com [Mon, 17 Aug 2009 21:14:24 +0000 (21:14 +0000)]
    Rubber-stamped by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=28403
        Update Apache2 module list from Leopard defaults

        No change in functionality, only commented out modules needed an update.

        * http/conf/apache2-httpd.conf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-17 Aaron Boodman <aa@chromium.org>
eric@webkit.org [Mon, 17 Aug 2009 20:43:57 +0000 (20:43 +0000)]
2009-08-17  Aaron Boodman  <aa@chromium.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=28313: Combine ThreadableLoaderOptions::crossOriginRequestPolicy and
        ThreadableLoaderOptions::crossOriginRedirectPolicy since they are always set the same way.

        Also, tightened up behavior of XMLHttpRequest with cross-origin redirects and access control. We have not implemented redirects
        for access control, so we should never redirect across origins. But in two edge cases, we were:

        * Asynchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control
          authorization headers) to a resource on origin A.
        * Synchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control
          authorization headers) to another resource on origin B (this time sending access control authorization headers).

        * http/tests/xmlhttprequest/access-control-and-redirects-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-and-redirects.html: Added.

2009-08-17  Aaron Boodman  <aa@chromium.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=28313: Combine ThreadableLoaderOptions::crossOriginRequestPolicy and
        ThreadableLoaderOptions::crossOriginRedirectPolicy since they are always set the same way.

        Also, tightened up behavior of XMLHttpRequest with cross-origin redirects and access control. We have not implemented
        redirects access control, so we should never redirect across origins. But in two edge cases, we were:

        * Asynchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control
          authorization headers) to a resource on origin A.
        * Synchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control
          authorization headers) to another resource on origin B (this time sending access control authorization headers).

        Test: http/tests/xmlhttprequest/access-control-and-redirects.html

        * loader/DocumentThreadableLoader.cpp:
        (WebCore::DocumentThreadableLoader::willSendRequest): Refactor redirect checking code into shared location.
        (WebCore::DocumentThreadableLoader::loadRequest): Ditto.
        (WebCore::DocumentThreadableLoader::isAllowedRedirect): Ditto.
        * loader/DocumentThreadableLoader.h:
        * loader/ThreadableLoader.h:
        (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Remove ThreadableLoaderOptions::crossOriginRedirectPolicy.
        * page/EventSource.cpp:
        (WebCore::EventSource::connect): Ditto.
        * workers/Worker.cpp: Ditto.
        (WebCore::Worker::Worker): Ditto.
        * workers/WorkerContext.cpp: Ditto.
        (WebCore::WorkerContext::importScripts): Ditto.
        * workers/WorkerScriptLoader.cpp:
        (WebCore::WorkerScriptLoader::loadSynchronously): Ditto.
        (WebCore::WorkerScriptLoader::loadAsynchronously): Ditto.
        * workers/WorkerScriptLoader.h:
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::createRequest): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix Qt build again.
darin@apple.com [Mon, 17 Aug 2009 20:41:59 +0000 (20:41 +0000)]
Try to fix Qt build again.

Patch by Darin Adler <darin@apple.com> on 2009-08-17
* WebCoreSupport/EditorClientQt.cpp: Move "using namespace".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-17 Adam Langley <agl@google.com>
agl@chromium.org [Mon, 17 Aug 2009 20:36:22 +0000 (20:36 +0000)]
2009-08-17  Adam Langley  <agl@google.com>

        Reviewed by Dan Bernstein (relanding of r47157).

        Fix a typo in platform/graphics/skia/PlatformContextSkia.cpp

        https://bugs.webkit.org/show_bug.cgi?id=28172

        This was originally fixed in r47157, however it triggered a bug in
        Skia which caused Chromium Linux to fail layout tests in debug mode.
        It was reverted in r47189 while we sorted it out.

        The Skia bug was fixed in Skia's r321 [1] and rolled into Chromium in
        Chromium's r23523. This is a reland of the original patch.

        No new tests because it's a just typo fix.

        [1] http://code.google.com/p/skia/source/detail?r=321

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::setupPaintCommon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago <http://webkit.org/b/28393> check-webkit-style: add check for use of std...
ddkilzer@apple.com [Mon, 17 Aug 2009 20:33:37 +0000 (20:33 +0000)]
    <webkit.org/b/28393> check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN()

        Reviewed by David Levin.

        * Scripts/modules/cpp_style.py:
        (_ERROR_CATEGORIES): Added 'runtime/max_min_macros'.
        (check_max_min_macros): Added.  Returns level 4 error when MAX()
        and MIN() macros are used in header files and C++ source files.
        (check_style): Added call to check_max_min_macros().
        * Scripts/modules/cpp_style_unittest.py: Added unit tests.
        (test_max_macro): Added.
        (test_min_macro): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-08-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 17 Aug 2009 20:29:53 +0000 (20:29 +0000)]
2009-08-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Protect ResourceHandle for g_file_query_info_async call, using the
        same technique we already use for HTTP requests that take the soup
        path.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
        (WebCore::ResourceHandle::~ResourceHandle):
        (WebCore::finishedCallback):
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47384 268f45cc-cd09-0410-ab3c-d52691b4dbfc